[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #851 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Aleisha Amohia from comment #850)

> Not unfinished business, I was just copying the similar code above, but I
> have removed in latest follow-up.

Are you really really sure about that :) ?
Look here, read the else comment too !

     elsif ( $code eq 'ReturnClaims' ) {
         $template->param( ReturnClaims => $messages->{ReturnClaims} );
-    } elsif ( $code eq 'RecallFound' ) {
-        ;
-    } elsif ( $code eq 'RecallNeedsTransfer' ) {
-        ;
-    } elsif ( $code eq 'TransferredRecall' ) {
-        ;
     } else {
         die "Unknown error code $code";    # note we need all the (empty)
elsif's above, or we die.
         # This forces the issue of staying in sync w/ Circulation.pm

In conclusion: We dont wanna die here, but as for ReturnClaims we could send a
code to the template allowing to return something meaningful to the user?
Obsoleting the last patch now. Correct me when I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.