[Koha-bugs] [Bug 19532] Recalls for Koha

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 2 16:55:35 CET 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131257|0                           |1
        is obsolete|                            |

--- Comment #880 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 131281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131281&action=edit
Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber

The fines cron job uses Getoverdues to pass issue info to CalcFine.
It took me a while to realize that the overdue hash does not contain
a biblionumber. When testing CalcFine, we pass an item hash that
does include one.

So what happened? $item->{biblionumber} is undefined when it comes from
Getoverdues and no recall overdue fine is calculated, only a regular one.

Simple fix (without any impact): Add a biblionumber to Getoverdues.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with fines.pl: recall fine applied now.
Ran some Circulation and Overdues unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list