[Koha-bugs] [Bug 30203] Can we trust the clean slate in Circulation.t ?

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hmm. I should have known.

One of the last subtests calls SendCirculationAlert..
And that sub includes one of the worst Koha hacks:

    # LOCK TABLES is not transaction-safe and implicitly commits any active
transaction before attempting to lock the tables.
    # If the LOCK/UNLOCK statements are executed from tests, the current
transaction will be committed.
    # To avoid that we need to guess if this code is execute from tests or not
(yes it is a bit hacky)
    my $do_not_lock = ( exists $ENV{_} && $ENV{_} =~ m|prove| ) ||
$ENV{KOHA_TESTING};

I will send a patch instead of closing this report btw.

-- 
You are receiving this mail because:
You are watching all bug changes.