[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) Can you please explain this change in Items.pm? 

This would also affect the item form in serials IIRC.

@@ -1559,6 +1559,8 @@ sub PrepareItemrecordDisplay {
     my $itemrecord;
     if ($itemnum) {
         $itemrecord = C4::Items::GetMarcItem( $bibnum, $itemnum );
+    }elsif ($defaultvalues && $defaultvalues->{'itemrecord'} ) {
+        $itemrecord = $defaultvalues->{'itemrecord'};
     }

2) GetMarcFieldsToOrderValues in Koha/Acquisition/Utils.pm

* Method names in Koha should be using snake case.
* Is it possible that the $syspref parameter has been removed/not implemented?
It appears to be hardcoded to Koha/Acquisition/Utils.pm.

+=head3 GetMarcFieldsToOrderValues($syspref_name, $record, $field_list)
+
+my $data =
Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder',
$marcrecord, ['price', 'quantity', 'budget_code', etc.]);
+

+sub GetMarcFieldsToOrderValues {
+    my ($record, $field_list) = @_;
+    my $syspref = C4::Context->preference('MarcFieldsToOrder');

3) GetMarcItemFieldsToOrderValues in Koha/Acquisition/Utils.pm

Same questions as for 2) actually.

4) Test plan

None of the commit messages contain much of a description or test plan. I found
this - is it still accurate? Could you add some notes for how
GetMarcFieldsToOrder and GetMarcItemFieldsToOrder should be set up/tested? I
haven't used these features so far.

To test:
1) Choose an existing record from "Add order to basket" area either searching a
record or clicking "From a staged file" section
2) After you reach "New order" page for existing record you will see new
fieldset called "Existing items" which are existing items belong to a record
not previously ordered
3) When you choose item(s) from this new tab fields of "Accounting details" tab
will be automatically filled
4) When you finished click save button.

If you could at least enhance the first commit message that would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.