[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Fridolin Somers from comment #13)
> Ahhh thanks, it works.
> Looks great :D
> 
> Some feedbacks :
> 
> 1)
> When arriving in patrons home page without searching :
> /cgi-bin/koha/members/members-home.pl
> We see the header with 'Select all' 'Clear all' ...
> This fells odd.
> We may hide it like in current master.

I didn't manage to hide it. When it's hidden the "sticky" behaviour is broken
(see patch "Fix sticky")

> 2)
> Why not keeping 'Browse by last name: A B ...' on top of header 'Select all'
> 'Clear all' ... ?

Because I had to rebuild a bit how the "blocks" are ordered. The header with
actions (select/clear all, add to list, merge) is only available from the main
patron search, when the "browse by" is available for all patron searches. It
was easier to then in the "browse by" code into the include file.
We can certainly change the order if there is a real need, but it will make the
code a bit more complex then.

> 3)
> Perform a search with some text in left form.
> Click on a letter of 'Browse by last name'.
> Note that search text is not removed in left form like in current master.

Don't you think this behaviour is better?

> We may also clear form in page header, but keeping it is the current
> behavior.

When? I wouldn't modify another form, that would feel weird.

-- 
You are receiving this mail because:
You are watching all bug changes.