[Koha-bugs] [Bug 30195] opac-suggestions.pl should use ISBN to FindDuplicate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30195

Thomas Klausner <domm at plix.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |domm at plix.at

--- Comment #1 from Thomas Klausner <domm at plix.at> ---
Created attachment 131731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131731&action=edit
Patch adding ISBN-search to purchase suggestions

When a patron enters an ISBN/ISSN when suggesting a new purchase, the
ISBN is used to find duplicates. Title/Author are ignored (as patrons
might misspell them, and the ISBN provides a better way to find
duplicates)

Test Plan:
* in the OPAC, go to /cgi-bin/koha/opac-suggestions.pl
* Click "new purchase suggestion"
* Enter any title
* Enter an ISBN that exists in your library
* Click "Submit your suggestion"
-> A new purchase suggestion has been submitted

* Apply the patch!

* Again start a new purchase suggestion, enter any title and the
  duplicate ISBN, and Submit
* You should see the note "A similar document already exists: ..."

Please note that the title should not be required when entering an ISBN,
but as the list of required fields is managed via OPACSuggestionMandatoryFields
I fear that it's rather complicated to make title an optional required
field if isbn is provided.

I also added a simple non-DB test case to t/db_dependent/Suggestions.t
(in a subtest at the end), but could not actually run it as I haven't
gotten around to set up / try a testing Koha dev env...

Sponsored-by: Steiermärkische Landesbibliothek

-- 
You are receiving this mail because:
You are watching all bug changes.