[Koha-bugs] [Bug 30194] Update required JSON::Validator version

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #29)
> 1. gulp task could be "api_spec", "spec" it too generic IMO

I agree. We can also do what you proposed on IRC, using a single bundled file
altogether.

> 2. Did you test with plugins injecting their own routes?

I tested the INN-Reach plugin (several routes), and the Coverflow plugin
(static assets routes).

> 3. We need to document this on the wiki

Probably. Once we reach a consensus on things I can volunteer.

> 4. We need a check in the release tools, or we will get things out of sync
> 
> 5. Reference to api/swagger-v2-schema.json has been removed from
> Koha/REST/V1.pm but still in Koha/REST/Plugin/PluginRoutes.pm. Is that
> correct?

I might have removed it because the spec is packaged my Mason on an
openapi-specification

> 6. Can you clarify: what would be an option to not have the bundled version?
> How can we fix the "invalid refs"?

We just need to move the paths.yaml content into swagger.yaml, and probably the
same for definitions and parameters. The latter are not actually used so can
just be removed for now. Because we point to definitions.yaml and
parameters.yaml directly from the paths. And x-koha-primitives... can just be
removed as it doesn't help much.

-- 
You are receiving this mail because:
You are watching all bug changes.