[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From the third patch:

             my $delimiter = C4::Context->preference('CSVDelimiter') || ';';
+            $delimiter = "\t" if $delimiter eq 'tabulation';

         my $delimiter = C4::Context->preference('CSVDelimiter') || ',';
+        $delimiter = "\t" if $delimiter eq 'tabulation';

+            my $delimiter = C4::Context->preference('CSVDelimiter') || ',';
+            $delimiter = "\t" if $delimiter eq 'tabulation';

In addition to last comment of Jonathan, if we are adding a function now to
control behavior, we should not need to 'fiddle' anymore like in the above
lines. Call the function and thats it.

Which probably means move the function out of the template plugin, and only
leave a wrapper there.

-- 
You are receiving this mail because:
You are watching all bug changes.