[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #4)
> Please show that it breaks in your test. And that your change resolves that.

Tests updated and moved to own patch
> 
> And tell me what this does:
> +    my $mocked_context = Test::MockModule->new('C4::Context');
> +    $mocked_context->mock( 'yaml_preference', sub {
> +        return { biblionumber => [ $biblio2->biblionumber ] };
> +    });
> 
> I think it is useless code.

Looks like you are correct - copied from Items.t - seems to have been done for
convenience there, mocking pref directly works

-- 
You are receiving this mail because:
You are watching all bug changes.