[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #129 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #126)
> Hi Alex, these are the results when I run the QA tools:
> 
> Processing files before patches
> |========================>| 13 / 13 (100.00%)
> Processing files after patches
> |========================>| 13 / 13 (100.00%)
> 
>  OK	Koha/Patron.pm
>  OK	Koha/Schema/Result/Virtualshelve.pm
>  OK	Koha/Virtualshelf.pm
>  OK	Koha/Virtualshelves.pm
>  FAIL	installer/data/mysql/kohastructure.sql
>    FAIL	  tinyint_has_boolean_flag
> 		The new column virtualshelves.public is using TINYINT(1) as type but is
> not defined as boolean in the schema file
> (Koha/Schema/Result/Virtualshelve.pm), see the SQL12 coding guideline
> 		The new column virtualshelves.allow_change_from_staff is using TINYINT(1)
> as type but is not defined as boolean in the schema file
> (Koha/Schema/Result/Virtualshelve.pm), see the SQL12 coding guideline
> 
>  OK	koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>  OK	koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>  OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>  OK	opac/opac-addbybiblionumber.pl
>  OK	opac/opac-shelves.pl
>  OK	t/db_dependent/Koha/Patron.t
>  FAIL	t/db_dependent/Virtualshelves.t
>    FAIL	  spelling
> 		 thier ==> their
> 
>  OK	virtualshelves/shelves.pl

Hi Katrin, 

Could you please re-run the QA test tool now after applying the fourth patch on
this bug report? 
Hopefully, that will fix up those QA errors. 

Many thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.