[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

--- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Séverine Queune from comment #23)
> This is a first feedback about the member-home.pl page only, tested using
> the branch available on Joubu's GitLab.
> 
> 1) About Frido's point 3, I completely agree with the new behaviour that
> keeps the search performs in the form and then filters the results. As an
> example, at BULAC, we have plenty of homonyms specifically for Asiatic short
> names that can be used as firstname or family name and it can be really
> difficult sometimes to find someone. Having a new way to refine the search
> is really useful.

Thanks for the feedback!

> 2) Sorting by 'Name' isn't logical for a user like me : the table display
> surname then firstname but sorting uses firstname then surname

Fixed!
Bug 30063: Sort by "Name" firstname,surname

> 3) Some special signs need to be escaped to be search, like % or _
> Probably not related to this patch, but searching for % searches for not
> NULL datas. On 'Notes' filter column e.g., it bring some unexpected results
> displaying patrons without any circulation notes just because the SQL field
> is not NULL.

Bug 30393.

> 4) I had some strange behaviours using the column filters or general search
> : many times, the search only applied when I kind of 'refresh' the table by
> sorting it (see https://snipboard.io/6EGyV8.jpg) To reproduce : enter your
> search very quickly in the search box or filter box ; see that many results
> are not supposed to be here.

Bug 30394.

> 5) Hiding a column in table setting introduces a bug : the filter doesn't
> search the data in the selected column but the data of the column just on
> the left : see screenshots
>  - https://snipboard.io/JAdjup.jpg : column 'Card' hidden, filter 'Date'
> search for the name 
>  - https://snipboard.io/1gb9Kq.jpg : column 'Card' hidden, filter 'Name'
> search for the card 
>  - https://snipboard.io/RKB4ip.jpg : column 'Card' hidden, filter
> 'Checkouts' search for the expiration date 
>  - https://snipboard.io/DBX5Ve.jpg :  column 'Name' hidden, filter 'Date'
> search for the name 
> You can also notice on these screenshots that there is some wrong with
> filter for it's not supposed to exists for the 'Checkout' and 'Actions'
> columns, and there is no more filter for 'Notes'.

Opened bug 30406.

> 6) It's not possible to got back to the form search if the results bring a
> unique result : the form reloaded automatically and bring us back to the
> patron account. This is not the behaviour in master and I feel uncomfortable
> with that change.

Not sure it's fixed, I am getting an error on Firefox but it's working on
Chromium.
Bug 30063: Restore back behaviour

> 7) On side search form, 'Search type' = 'Starts with' doesn't work for none
> of the 'Search field' I tried (cardnumber, address, firstname, surname).

Fixed!
Bug 30063: Fix start with

> 8) The patch doesn't work for users with only 'edit_borrowers' or
> 'view_borrower_infos_from_any_libraries' permissions : the full 'borrowers'
> permission seems to be needed to display results

Fixed!
Bug 30063: Fix permission for GET /patrons

> All the other points (Length menu, query description, highlight of the
> current library) are ok expect for length menu displaying two times '20
> results' but I'll fill another bug as it's already existing in master and
> 20.11.11).
> 
> I'll feedback about the other tables in the dedicated bugs.

Thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.