[Koha-bugs] [Bug 30465] BatchUpdateBiblio task does not deal with indexation correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30465

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #10)
> (In reply to Tomás Cohen Arazi from comment #8)
> > Created attachment 134404 [details] [review] [review]
> > Bug 30465: (QA follow-up) Enqueue indexing
> > 
> > Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
> 
> Can you explain why we need this patch?
> 
> Moreover the first patch is introducing the index_now param and you are
> removing the occurrence that is using it.

The patch on this bug does three main things:
1. Adds a 'skip_record_index' flag to ModBiblio/ModBiblioMarc so indexing is
not triggered within those.
2. Makes the background job trigger indexing on the whole bibios set after the
action has taken place.
3. Indexing is triggered within the background job, as part of it.

As I mentioned already in the hackfest, I'm against (3). I'm pretty sure
indexing should always stand as its own enqueued task just in case ES/Zebra is
not available or something wrong happens, and also because its failure
shouldn't mean the batch task had failed, for example.

So most of the patch is correct (adding a way to signal not indexing,
optimizing by indexing all at once) but I'd enqueue indexing. Hope it
clarifies.

-- 
You are receiving this mail because:
You are watching all bug changes.