[Koha-bugs] [Bug 30536] Embeds should be defined in a single place

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #19)

I updated the POD a little for you, hopefully it's a little clearer.

> [2] api/v1/swagger/paths/acquisitions_baskets.yaml
> Here you do not specify collectionFormat: csv while you do at
> acquisitions_funds.yaml.
> And again you dont in suggestions.yaml.
> Note that as I understand that it is the default array format, we should not
> need them. But this looks inconsistent.

Good catch, all sorted in the follow-up.

> [3] Please fix t/Koha/REST/Plugin/Query.t
> It fails now.

Another good catch, I somehow missed this test entirely when I wrote this. 
Follow-up cleans up the test a little.. as we no longer validate in this method
I dropped the validation side of the test and focused instead on just the
structure testing.  Validation is however now tested in the test I added above
at the API level.

-- 
You are receiving this mail because:
You are watching all bug changes.