[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #14 from David Nind <david at davidnind.com> ---
Created attachment 134562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134562&action=edit
Screenshots - behaviour after patches applied

Hi Tomás.

I finally managed to get this to work (I think)!

Things I didn't do:

- Make sure the 3 records had multiple books and some other type of items.

- I didn't update the database after the patches were applied.

- I didn't test with BiblioHoldItemTypeUseForRules set to 'Don't consider'
(retains current behaviour - the total number of holds is not taken into
account when multiple item types) and 'Consider' (limits number of holds to
holds allowed (total)) when AllowHoldItemTypeSelection set to allow.

However:

1. When I went to place a hold for record 3 (searching for 'a' after applying
the patches) I didn't get any message - it just took me to the patron holds
summary page and didn't place a hold.

2. Placing a hold for another record where there were only items with one item
type showed the message "There are no items that can be placed on hold.", which
seems like the correct behaviour to me. However, if I add another item to that
record with a different item type, I get the same behaviour as in 1 - that is,
I don't get any message and am taken to the patron holds summary screen.

I've attached a PDF with some screenshots to illustrate what I mean.

Also, for the new/updated system preference, should it be 'BiblioHold...' and
'biblio-level hold...' or 'RecordHold...' and 'record-level hold...'? I'm not
sure of the correct terminology to use, considering we have several system
preference names that include biblio, but all the descriptions now use
bibliographic record.

David

-- 
You are receiving this mail because:
You are watching all bug changes.