[Koha-bugs] [Bug 30667] Holds reminder cronjob (holds_reminder.pl) never uses default letter template

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134504|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 134564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134564&action=edit
Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter
template

Bug 28514 changed the way holds_reminder.pl searches for templates, using a
direct search for letters,
but should be using find_effective_template instead. Now, if a branch specific
template does not exist,
it will skip that branch.

Test Plan:
1) Ensure you only have the default HOLD_REMINDER template
2) Become the koha user using koha-shell
3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v
4) Note that the script skips every branch
5) Apply this patch
6) Run the command in step 3 again
7) Note the script doesn't skip over any branches

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.