[Koha-bugs] [Bug 30354] AUTO_RENEWALS_DGST notices are not generated if patron set to receive notice via SMS and no SMS notice defined
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed May 4 18:49:52 CEST 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30354
Joonas Kylmälä <joonas.kylmala at iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #134435|0 |1
is obsolete| |
--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 134616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134616&action=edit
Bug 30354: Don't assign warn as letter
TO test:
1 - Check out an item marked for autop renewal to a patron and make it overdue
2 - Set system preference AutoRenewalNotices to follow messaging prefs
3 - set that borrower to receive both email and SMS AUTO_RENEWALS_DGST
4 - confirm your AUTO_RENEWALS_DGST does not have SMS content but does have
email
5 - run the auto_renew cron
6 - item is renewed, but error from cron, and cron dies:
No circulation AUTO_RENEWALS_DGST letter transported by sms at
/kohadevbox/koha/C4/Letters.pm line 583.
no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see
sample_notices.sql at misc/cronjobs/automatic_renewals.pl line 305.
Can't use string ("1") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Letters.pm line 898.
7 - Apply patch
8 - Make item eligible for auto renewal agian (or checkin/checkout)
9 - Run the cron
10 - There is still 2 warn, but cron does not die:
No circulation AUTO_RENEWALS_DGST letter transported by sms at
/kohadevbox/koha/C4/Letters.pm line 583.
no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see
sample_notices.sql at misc/cronjobs/ automatic_renewals.pl line 305.
11 - Patron receives email and item is renewed
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list