[Koha-bugs] [Bug 30697] IsAvailableForItemLevelRequest returns wrong when items_any_available is defined

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30697

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134661|0                           |1
        is obsolete|                            |

--- Comment #3 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 134666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134666&action=edit
Bug 30697: Fix return value when $items_any_available is defined

Return the value of $item_any_available when it is defined instead of
the opposite value.

Here is a test plan to reproduce an issue created by this bug

Test plan:
1- Go to administration > system preferences >
AllowRenewalIfOtherItemsAvailable and select "Allow"
2- Go to administration > circulation and fine rules and create an
All/All rule where "on shelf holds allowed" is set to "if all unavailable"
3- Have at least 2 library branches
Go to administration > libraries > new library
to create them
4- Have 2 users, one from each library
Go to patrons > new patron
to create them
5- Have 2 items of the same record, but one item from each library
Go to catalog > create or find a record > new > new item
to create them
6- Make the first user check out the first item
7- Make the second user place a hold on the same record (even though it
is not allowd)
8- Go back to the first user's page and try to renew
9- Notice it is written "on hold" under "Renew" even though the first user
should be
able to renew his item
10- Apply the patch
11- Refresh and notice it now shows the usual checkbox to renew

-- 
You are receiving this mail because:
You are watching all bug changes.