[Koha-bugs] [Bug 28998] Encrypt borrowers.secret

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

--- Comment #99 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #98)
> Comment on attachment 134637 [details] [review]
> Bug 28998: (QA follow-up) Silence some useless warnings
> 
> Review of attachment 134637 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: t/db_dependent/Auth.t
> @@ +151,4 @@
> >          }
> >  
> >          t::lib::Mocks::mock_preference( 'TwoFactorAuthentication', 0 );
> > +        $patron->encode_secret('one_secret');
> 
> It feels weird here to require a secret set when TwoFactorAuthentication is
> disabled?

Thats true. I will move it a bit lower. Submitting a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.