[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
The last patch would break a lot of pages, e.g. see the browser title field
after applying the patch. I fix would be to go for now how other pages have
handled this: by grepping "patron-title.inc" you can find for examples:

> ./prog/en/modules/members/accountline-details.tt: <a href="/cgi-bin/koha/members/boraccount.pl?borrowernumber=[% patron.borrowernumber | uri %]">Account for [% INCLUDE 'patron-title.inc' %]</a>

so basically add the link manually around the patron-title.inc include
statement.

However the ideal solution would be to:

1. Modify the last patch from here to support in addition no_html = 1 parameter
correctly in patron-title.inc (the current support is only partly done...)
2. add the no_html = 1 tag to all the places where patron-title.inc is used and
it cannot contain a link (for example in a browser title tag or inside another
link)

If you don't decide to go with the ideal solution then let's open another bug
report for that.

-- 
You are receiving this mail because:
You are watching all bug changes.