[Koha-bugs] [Bug 30730] New: Holds to Pull should not list items with a notforloan status

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730

            Bug ID: 30730
           Summary: Holds to Pull should not list items with a notforloan
                    status
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, nick at bywatersolutions.com

The holds to pull list (pendingreserves.pl) is mistakenly showing titles where
there are no available items and telling staff to pull items with negative
notforloan statuses that should keep them off the list.

To recreate:
- have a bib with 2 items, both holdable. Give one of these items a notforloan
status with a negative value (like Ordered in the testing docker data).
- place a title-level hold on your bib
- confirm your bib is showing on Holds to Pull as expected, prompting staff to
pull the item that does not have a not for loan status (correct!)
- take the item that does not have a not for loan status and check it out to a
different patron, make sure not to fill or cancel your hold
- reload Holds to Pull, see your title is still listed and now Koha is
directing staff to the item with a notforloan status

In building this list, we start by getting only the bibs that have at least one
holdable item, but then we neglect to actually exclude the non-circulating
items from the final output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.