[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #7)
> Hmm, I started looking at adding unit tests for this and I see that there
> are a reasonable number for the same function in ElasticSearch.. wondering
> if we need to handle any other cases here that are already handled in the ES
> implementation..?

As Liz and Sheri have mentioned, there are other special characters in the CCL
syntax. (See https://software.indexdata.com/yaz/doc/tools.html#ccl.syntax)

However, so long as those are within double quotes, they should be treated as
search data and not reserved characters.

So I suppose clean_search_term() should really just escape double quotes.

--

Note: We're in a fortunate position here of building the search string
ourselves rather than having to parse user input, so we have so much control
and ability to do this the way that works for the search engine.

-- 
You are receiving this mail because:
You are watching all bug changes.