[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu May 12 11:26:01 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

--- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This introduces a warning in the log

Use of uninitialized value $bad_bibs_param in split at
/kohadevbox/koha/reserve/placerequest.pl line 55.

We could fix it with:

diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl
index 0a8d6dd64e6..e85c6ad292a 100755
--- a/reserve/placerequest.pl
+++ b/reserve/placerequest.pl
@@ -51,7 +51,7 @@ my $non_priority   = $input->param('non_priority');

 my $patron = Koha::Patrons->find( $borrowernumber );

-my $bad_bibs_param = $input->param('bad_bibs');
+my $bad_bibs_param = $input->param('bad_bibs') || '';
 my @bad_bibs = split '/', $bad_bibs_param;
 my $holds_to_place_count = $input->param('holds_to_place_count') || 1;

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list