[Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where clause' 500 error in API /api/v1/acquisitions/orders

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Andrew Nugged from comment #10)
> I want to propose as QA-phase only this:
> 
> That "if" is _probably_ not needed:
> 
>       ... if $q =~ m/.*(isbn|ean|publisher).*/;
> 
> because this anyway matches only those places:
> 
>    $q =~ s{biblio\.(?=isbn|ean|publisher)}{biblio\.biblioitem\.}g;
> 
> so having this:
> 
>     $q =~ s{biblio\.(?=isbn|ean|publisher)}{biblio\.biblioitem\.}g
>        if $q =~ m/.*(isbn|ean|publisher).*/;
> 
> is something like "double-check for the same thing",
> But this is more like 50/50 proposal to agree with you JD/Martin.

Yes that if is horrible for a purist.
And note that matching .* is an insult already.
We just wanted m/isbn|etc/ and that was not even very specific matching.

Also note the separator switching here:
Please use s/ a / b / and m/c/ for instance, but not do s| | |  and m/ / 
It hurts my eyes :)

-- 
You are receiving this mail because:
You are watching all bug changes.