[Koha-bugs] [Bug 30195] opac-suggestions.pl should use ISBN to FindDuplicate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30195

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |victor at tuxayo.net

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
There are some issues with the signoff.

- Each commit must be signed off. I don't know the simplest way, I used to do
an interactive rebase with git but now I just signoff when applying the
patches: `git git bz apply 30195 --signoff`
- It's clearer if comments are written in separate messages than the patches.
- The 2nd and 3rd attachment are actually a duplicate of the 2nd patch.

-- 
You are receiving this mail because:
You are watching all bug changes.