[Koha-bugs] [Bug 30167] Return soonest renewal date when CanBookBeRenewed returns %too_soon

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 16 13:08:47 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 135016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135016&action=edit
Bug 30167: [21.11.x] Return soonest renewal date when renewal is to soon

This patch adds an 'info' return param to CanBookBeRenewed and passes
the soonest renewal date when returning too_soon errors

To test:
1 - prove -v t/db_dependent/Circulation.t

Fix whitespace

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30167: Use returned renewal date rather than fetching

This patch updates the three scripts that fetched the soonest renewal date
to use the return from CanBookBeRenewed

To test:
1 - Set a circulation rule with a 'no renewal before' set to 3, loan length set
to 5
2 - Check out an item to a patron that uses this rule
3 - Verify the checkouts for the patron show the correct 'No renewal before'
date
4 - Sign in to the patron's opac account
5 - Verify the item shows it cannot be renewed, and shows the correct date
6 - Go to Circulation->Renew
7 - Attempt to renew using barcode
8 - Confirm error shows the soonest renewal date

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30167: (follow-up) Return a hash with soonest_renew_date

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30167: (follow-up) Compare dt objects

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list