[Koha-bugs] [Bug 30781] New: Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781

            Bug ID: 30781
           Summary: Use of uninitialized value $val in substitution
                    iterator at /usr/share/koha/lib/C4/Letters.pm line
                    665.
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

In our installation 20.11.17 it's these lines:

    if (%$substitute) {
        while ( my ($token, $val) = each %$substitute ) {
            if ( $token eq 'items.content' ) {
                $val =~ s|\n|<br/>|g if $letter->{is_html};
            }

-->            $letter->{title} =~ s/<<$token>>/$val/g;
            $letter->{content} =~ s/<<$token>>/$val/g;
       }
    }

Itemscontent is used as:

koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/overdue_notices.pl -t -itemscontent
date_due,title,subtitle,part_number,part_name,author,itemcallnumber,barcode

koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/advance_notices.pl -c --itemscontent
date_due,title,subtitle,part_number,part_name,author,itemcallnumber,barcode


This creates quite a bit of noise from the cronjobs, so it would be nice to get
a hint on how to fix this or a patch.

In master the code in question is unchanged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.