[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Failed QA

--- Comment #17 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I really like the redesign - it's very clear and user friendly.

It all works perfectly, except if the staff make a mistake and do the
following:

- Place a hold for a patron
- Choose 'Place a hold on a specific item'
- Fail to choose an item 
- Just press the 'Place hold' button beneath 'Place a hold on a specific item'
(#hold_item_btn)

The hold is now placed for pick up at a blank library.  

If you check an item in to fill the hold, Koha presents an error page, e.g.

Can't call method "branchcode" on an undefined value at
/kohadevbox/koha/Koha/Item.pm line 683

On the current version of Koha, if the staff press this button (#hold_item_btn)
without selecting an item, the hold defaults to being a bib level hold where
the pick up library is the logged in library (as if they'd pressed: 
#hold_any_btn)

It'd be good if the 'Place hold' button for 'Place a hold on a specific item'
could be blanked out until a specific item has been chosen.

Alternatively, maybe the pick up location drop down could go back into the
'Hold details' section at the top of the page - so then it can still fall back
to a bib level hold if it's pressed without selection, but it would still be
given a location.

-- 
You are receiving this mail because:
You are watching all bug changes.