[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
            var ids = ['holdings_table', 'otherholdings_table'];
            var table_settings = [ [%
TablesSettings.GetTableSettings('catalogue', 'detail','holdings_table','json')
| $raw %], [% TablesSettings.GetTableSettings('catalogue',
'detail','otherholdings_table','json')  | $raw %] ];
            var has_images = ["[% itemloop_has_images | html %]", "[%
otheritemloop_has_images | html %]"];
            for (var i in ids) {
                var id = ids[i];

This code does not look good to me.
Note: for...in should not be used to iterate over an Array where the index
order is important.

-- 
You are receiving this mail because:
You are watching all bug changes.