[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #4)
> I've not looked in depth yet.. but I'm wondering if we aught to start
> adopting a pattern of generally accepting Object or Identifier for passed
> params. If one already has the object it's a no brainer to pass it through
> and save a lookup. In this case I could see the potential of having to fetch
> a patron to pass in then not actually need to use it, depending on the
> pref.. which is also wasteful?
> 
> Thoughts?

In this particular case, what bothered me was that every place the method was
called, the object was already there and it got unblessed just because (it was
obviously a transition step when moving GetMember and friends to Koha::Patrons
to avoid friction).

I'd say in this particular case either is fine. We always have the object in
context anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.