[Koha-bugs] [Bug 30831] New: Incorrect setting of error when importing items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831

            Bug ID: 30831
           Summary: Incorrect setting of error when importing items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In C4::ImportBatch::BatchCommitItems we attempt to store the error 'duplicate
item barcode' in the 'itemnumber' column of import_items

This fails


To recreate:
1 - Export a record with items from the catalog
2 - Stage the record for import
3 - Import the batch
4 - Silent failure? Batch stuck in 'importing
5 - Bonus points/QA team, otherwise skip:
    Stage again, go to manage batch, before clicking 'Import this batch'
    a - Right click and inspect the submit button
    b - Scroll to <form> element
    c - Right click and 'Edit as HTML'
    d - Add '?runinbackground=0' to form action
    e - Delete the hidden input for 'runinbackground' a few lines down
    f - Click 'Import'
    g - Error:
[Mon May 23 10:47:43.583448 2022] [cgi:error] [pid 3114] [client
172.18.0.1:60936] AH01215: C4::ImportBatch::BatchCommitItems(): DBI Exception:
DBD::mysql::st execute failed: Incorrect integer value: 'duplicate item
barcode' for column `koha_kohadev`.`import_items`.`itemnumber` at row 1 at
/kohadevbox/koha/C4/ImportBatch.pm line 652:
/kohadevbox/koha/tools/manage-marc-import.pl, referer:
http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.