[Koha-bugs] [Bug 28787] Send a notice with the TOTP token

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 25 02:01:47 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 135287
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135287
Bug 28787: Send a notice with the TOTP token

Review of attachment 135287:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28787&attachment=135287)
-----------------------------------------------------------------

::: C4/Letters.pm
@@ +1605,5 @@
>  
> +    if ( $content =~ m|\[% otp_token %\]| ) {
> +        my $patron = Koha::Patrons->find(C4::Context->userenv->{number});
> +        $tt_params->{otp_token} = Koha::Auth::TwoFactorAuth->new({patron => $patron})->code;
> +    }

This looks like a hack. We should pass the code in via a public
method/function. That said, it looks like this OTP will wind up in the
message_queue table?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list