[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #30 from David Nind <david at davidnind.com> ---
Hi Tomás.

I have tested this, and it all works fine except for these two things:

1. Test fails for prove t/db_dependent/Koha/Hold.t

2. I'm not sure of the workflow in the staff interface or the reason why there
is a "Reject cancellation" option

1. Test fails for prove t/db_dependent/Koha/Hold.t
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

prove t/db_dependent/Koha/Hold.t
t/db_dependent/Koha/Hold.t .. 4/8 DBIx::Class::Storage::DBI::_dbh_execute():
DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row:
a foreign key constraint fails (`koha_kohadev`.`hold_cancellation_requests`,
CONSTRAINT `hc_resolver_ibfk` FOREIGN KEY (`resolver_id`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) at
/kohadevbox/koha/Koha/Object.pm line 170
        # Looks like you planned 2 tests but ran 1.

    #   Failed test 'cancellation_requests handling'
    #   at t/db_dependent/Koha/Hold.t line 650.
    # Looks like you failed 1 test of 7.
t/db_dependent/Koha/Hold.t .. 5/8 
#   Failed test 'cancel() tests'
#   at t/db_dependent/Koha/Hold.t line 653.
Broken FK constraint# Looks like your test exited with 255 just after 5.
t/db_dependent/Koha/Hold.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 4/8 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Hold.t (Wstat: 65280 Tests: 5 Failed: 1)
  Failed test:  5
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 5.
Files=1, Tests=5, 12 wallclock secs ( 0.03 usr  0.01 sys +  9.59 cusr  1.79
csys = 11.42 CPU)
Result: FAIL

2. I'm not sure of the workflow in the staff interface or the reason why there
is a "Reject cancellation" option
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If I:

1. Request cancellation in the OPAC (Request cancellation button) it changes to
a non-clickable button (Cancellation requested).

2. Reject cancellation in the staff interface (Holds awaiting pickup > Holds
with cancellation requests tab, and select "Reject cancellation".

The result is:
- In OPAC the button for the hold changes to "Cancellation rejected"
(non-clickable)
- In the staff interface it goes back into the "Holds waiting" tab
- I have to click "Cancel hold", then it is removed from the OPAC and holds
awaiting pickup > Holds waiting tab

-- 
You are receiving this mail because:
You are watching all bug changes.