[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
I guess it's not in the Coding Guidelines, but we shouldn't use "javascript:"
to handle events. The template before your patch *also* wasn't doing it
correctly (see
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events).

See members-menu.js, where click handlers are added for the various controls in
the patron toolbar. I recommend adding an ID attribute to the deletion link so
that you can target it in members-menu.js

Also, changes to the po file should not be included in the patch. Patch testers
will need to update the translations themselves.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.