[Koha-bugs] [Bug 30028] Patron message delete confirmation untranslatable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Before applying the patch, I grepped for the missing phrase - there were no
occurrences:
   - git grep "Are you sure you want to delete this message? This cannot be
undone." misc/translator/po/fr-CA-*.po 

2. Sequence for updating a translation, after patch applied:
   - cd misc/translator
   - ./translate update fr-CA
   - update the strings in po file: vi po/fr-CA-staff-prog.po 
   - install the updated translation: ./translate install fr-CA
   - file ownership was changed to root, I needed to change so that updated
messages appear: sudo chown kohadev-koha:kohadev-koha po/fr-CA-*.po
   - test that updated translation works
   - clean up files so patch can be signed off rather than having to
individually delete unstaged files and check out modified files: 
     . change back to the koha directory cd ../../ 
     . git checkout
     . git clean -fd

3. When editing the translations, I deleted the extra lines 13586 and 13589 -
not sure whether that was necessary or not, but it worked for me! Lines before
updated:

13584 #. SCRIPT
13585 #: koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc:230
13586 #, fuzzy
13587 msgid "Are you sure you want to delete this message? This cannot be
undone."
13588 msgstr ""
13589 "Voulez-vous vraiment supprimer cette règle? L'opération est
irréversible."

4. I did notice that there were a few examples of empty "" after msgstr and a
translation straight after that (as above). I'm not familiar enough with
translations to know whether this is something that is expected.

5. I also noticed that after adding a patron message, going to delete it, and
pressing cancel - the message is deleted when it shouldn't be. I have logged
bug 30863 for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.