[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #15)
> IMO this does not belong to Koha::Item. We are making our Koha objects grow
> and it will be a nightmare soon.
> This is not the responsibility of the item object, it must go on separate
> modules.

I agree. We talked about it with Martin as we felt it didn't belong here.

> I don't have something clear to suggest right now. I have asked a couple of
> months ago to have a wider discussion about those naming/namespace/etc but
> it didn't move much (cannot remember the bug report however).

It'd be interesting to find it.

I like what they are doing here about availability:
https://github.com/NatLibFi/koha-plugin-rest-di/tree/main/Koha/Plugin/Fi/KohaSuomi/DI/Koha

-- 
You are receiving this mail because:
You are watching all bug changes.