From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 00:00:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 31 Oct 2022 23:00:57 +0000
Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields
In-Reply-To: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31562-70-WPG74LOLEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
Patchset won't apply cleanly for 22.05.x. If needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 00:02:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 31 Oct 2022 23:02:00 +0000
Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table
In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7021-70-Yt9ig06V5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting
                 CC|                            |lucas at bywatersolutions.com

--- Comment #60 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 00:06:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 31 Oct 2022 23:06:07 +0000
Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include
 totals of sub-sub-funds on acquisitions home page
In-Reply-To: <bug-31367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31367-70-B9qfyhA4JD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 01:05:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 00:05:39 +0000
Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
In-Reply-To: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28172-70-PG21GIxjNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from David Nind <david at davidnind.com> ---
The patch no longer applies :-(..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 01:36:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 00:36:28 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-5CPHz5nJOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 01:36:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 00:36:33 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-oZr4yNaaUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135661|0                           |1
        is obsolete|                            |

--- Comment #26 from David Nind <david at davidnind.com> ---
Created attachment 142844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142844&action=edit
Bug 29672: [DO NOT PUSH] Test script

Run test-plugins-call.pl without arguments with and without the patches,
with some plugins enabled. Make sure to run
misc/devel/install_plugins.pl before

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 01:36:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 00:36:38 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-LTOm1LPj4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135660|0                           |1
        is obsolete|                            |

--- Comment #27 from David Nind <david at davidnind.com> ---
Created attachment 142845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142845&action=edit
Bug 29672: Increase performance of Koha::Plugins->call

Make use of Koha::Cache::Memory::Lite to avoid hitting the database and
creating plugins object for every call to Koha::Plugins->call

Test plan:
1. Make sure plugins still work by executing
   `prove t/db_dependent/Koha/Plugins/Plugins.t`
2. Run the test script provided in the following patch to see how it
   affects performances

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 01:36:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 00:36:42 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-FXedvSz7Un@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135704|0                           |1
        is obsolete|                            |

--- Comment #28 from David Nind <david at davidnind.com> ---
Created attachment 142846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142846&action=edit
Bug 29672: Clear cache of enabled plugins when a plugin's state change

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 01:53:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 00:53:17 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-T8pSlmOxtN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Signed Off                  |Failed QA

--- Comment #29 from David Nind <david at davidnind.com> ---
Apologies, I signed off and then reealised that I hadn't run the tests after
applying the patches!

Tests now fail after the patches are applied. Weirdly, running the tests seemed
to uninstall the plugins. I reinstalled the plugins again, flush_memcached +
restart_all, and ran the tests again - they failed [4].

Testing notes (using koha-testing-docker):
1. Ran prove t/db_dependent/Koha/Plugins/Plugins.t - tests passed
2. Installed 2 plugins and enabled
3. Ran misc/devel/install_plugins.pl [1]
4. Applied test script patch and ran [2]
5. Applied other patches and flush_memcached + restart_all
6. Re-ran test script [3]
7. Ran prove t/db_dependent/Koha/Plugins/Plugins.t - tests failed

[1] Output from running misc/devel/install_plugins.pl:

misc/devel/install_plugins.pl
Installed Example Kitchen-Sink Plugin version 2.3.0
Installed BiblbioCommons connector plugin for Koha version 0.5.3
All plugins successfully re-initialised

[2] Output of the test script BEFORE the patches were applied:

./test-plugins-call.pl
1 call(s): Elapsed 0.686131 seconds
10 call(s): Elapsed 0.093689 seconds
100 call(s): Elapsed 0.572402 seconds
1000 call(s): Elapsed 5.629604 seconds

[3] Output of the test script AFTER the patches were applied:

./test-plugins-call.pl
1 call(s): Elapsed 0.683855 seconds
10 call(s): Elapsed 0.000213 seconds
100 call(s): Elapsed 0.001843 seconds
1000 call(s): Elapsed 0.017745 seconds

[4] Tests fail after patches are applied:

prove t/db_dependent/Koha/Plugins/Plugins.t
t/db_dependent/Koha/Plugins/Plugins.t .. 6/61 
    #   Failed test at t/db_dependent/Koha/Plugins/Plugins.t line 112.
    # found warning: Failed to load
Koha::Plugin::Com::ByWaterSolutions::KitchenSink: Could not find or check
module 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' at
/kohadevbox/koha/Koha/Plugins.pm line 116.
    # found warning: Failed to load Koha::Plugin::Com::Theke::BiblioCommons:
Could not find or check module 'Koha::Plugin::Com::Theke::BiblioCommons' at
/kohadevbox/koha/Koha/Plugins.pm line 116.
    # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception'
thrown 'item_barcode_transform called with parameter: 1'
    # found warning: Plugin error (Test Plugin for item_barcode_transform):
Exception 'Koha::Exception' thrown 'item_barcode_transform called with
parameter: 2'
    # expected to find warning: Plugin error (Test Plugin): Exception
'Koha::Exception' thrown 'item_barcode_transform called with parameter: 1'
    # expected to find warning: Plugin error (Test Plugin for
item_barcode_transform): Exception 'Koha::Exception' thrown
'item_barcode_transform called with parameter: 2'
    # Looks like you failed 1 test of 6.

#   Failed test 'more call() tests'
#   at t/db_dependent/Koha/Plugins/Plugins.t line 129.
t/db_dependent/Koha/Plugins/Plugins.t .. 48/61 # Looks like you failed 1 test
of 61.
t/db_dependent/Koha/Plugins/Plugins.t .. Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/61 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Plugins/Plugins.t (Wstat: 256 Tests: 61 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=61,  3 wallclock secs ( 0.03 usr  0.01 sys +  2.63 cusr  0.24
csys =  2.91 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:02:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:02:30 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-lrPfMKQLth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:02:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:02:34 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-CMPsLXeQLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140187|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 142847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142847&action=edit
Bug 31517: Replace raw SQL queries in C4::Tags with Koha object accesses

To test:
 1) Create a few new tags to any biblio by visiting the biblio's detail
 page on OPAC
 2) The visit http://localhost:8080/cgi-bin/koha/opac-tags.pl and try
 deleting those tags.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:02:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:02:38 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-yRJD0YYxtO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140188|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 142848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142848&action=edit
Bug 31517: Remove unused get_tag function

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:34:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:34:33 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-Q2cZoGIyoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:34:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:34:38 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-OEYiYEQSiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142055|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 142849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142849&action=edit
Bug 31854: Document --not_borrowed_since and anonymization

To test:
- Run "perldoc misc/cronjobs/delete_patrons.pl"
- Note the absence of information about the potential conflict
  between --not_borrowed_since and anonymization
- Apply this patch
- Re-run the perldoc command and make sure the note about
  anonymization make sense

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:35:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:35:48 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-wQuWlEte8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
           Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no
                   |ity.org                     |

--- Comment #4 from David Nind <david at davidnind.com> ---
Updated the assignee...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:37:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:37:46 +0000
Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to
 prioritize either matching a patron's home library to the item's home or
 holding library
In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31557-70-ZwXjDmtOyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
I updated the assignee...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 02:38:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 01:38:39 +0000
Subject: [Koha-bugs] [Bug 31856] Improve performance of serials
 subscriptions search
In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31856-70-ZR7rDNOmUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Updated the assignee..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 03:23:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 02:23:23 +0000
Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
In-Reply-To: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28172-70-7WHxgzz5wB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Arf not a trivial rebase.
I leave it to Julian ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 06:08:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 05:08:39 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-25VUqtkcy9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Kyle M Hall from comment #9)
> (In reply to Victor Grousset/tuxayo from comment #8)
> > I don't get how to encrypt a password to an external service and still be
> > able to use the external service. Does that mean Koha can in full autonomy
> > decrypt it?
> 
> Yes, we store a key in the koha konf file for encryption and decryption. I
> need to rebase this patch to use the work from Bug 28998.

Ok IIUC the security value doesn't come from encryption but from having the
date out of the DB. So a simple SQL injection can't get it.
Is there any gain compared to just storing the passwords into koha-conf.xml
directly? 
(hum, maybe Koha can't write to that file and that would need a separate file)
Like is it a plausible attack scenario to be able to read the file but not the
DB? That when needing both would help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 06:49:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 05:49:33 +0000
Subject: [Koha-bugs] [Bug 32056] New: Database tmpdir check before upgrade
Message-ID: <bug-32056-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32056

            Bug ID: 32056
           Summary: Database tmpdir check before upgrade
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mengu at devinim.com.tr
        QA Contact: testopia at bugs.koha-community.org

Hi all,

It may an error occur during koha upgrade if tmp directory is not free enough
for database. This may lead as if upgrade completes but there may occur lots of
problem.

Can it be good idea to check free tmpdir area for database need and suggest to
increase or change the value before proceeding upgrade?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 08:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 07:36:06 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-RPd8k73K9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Kyle M Hall from comment #3)
> > * If I attach a very large document to a license ( like 70 MB ), not only
> > does the file not attach, but I lose all my existing files as well. (
> > http://192.168.1.20:8081/cgi-bin/koha/erm/licenses/1 ) 
> 
> Reported on https://tree.taiga.io/project/joubu-koha-erm/us/130

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 10:08:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 09:08:56 +0000
Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in
 outgoing email notices
In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31627-70-EcDkVwSf4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I wonder if it would be nice to have a way to make this invisible at least in
HTML notices. Something like <div style="display:none">ID</div> ?

This line looks like it would allow to do just that:
             if ($is_html) {
+                $content .= "<br/>$message->{letter_id}" if $message->{id} &&
C4::Context->preference('SendLetterIdInEmailNotices');

At the moment there is no way libraries could change how this appears in the
notices and it might raise questions about the 'number' appearing at the end of
the message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 10:16:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 09:16:07 +0000
Subject: [Koha-bugs] [Bug 32053] Authority not in database
In-Reply-To: <bug-32053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32053-70-2TyMWDbIKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32053

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, this is more of a support question and as such should be asked on the
mailing list or in our chat. 

I assume that the authoritiy is saved, but you might not be able to search for
it as indexing is not working.

You could create a report with:
select * from auth_header; 

This way you can confirm if the authorities were stored to the database.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 10:44:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 09:44:46 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-UVLlfFlNMj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Still working through the code.. so far so good.

One query however, in EHoldingsEBSCOPackageAgreements.vue you use a <style
scoped> block to localise some modal css.. should/can this be moved to the
standard scss sheets?  My reading suggests that 'scoped' is deprecated already?
(Must admit, I've never seen it so had to google)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 10:55:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 09:55:51 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-Y2TiP08oCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ah, I see.. the vue docs actually recommend it..
https://vuejs.org/guide/introduction.html#the-progressive-framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:01:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:01:28 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-Qllh68d5xL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

--- Comment #9 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 142850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142850&action=edit
Bug 24616: Do not save form if user press cancel

If one starts to copy a notice but then cancels
this when pop-up is displayed, changes are still
saved. This patch fixes this.

To test:
1. Copy notice to a library where it already exists
2. Press save and then cancel when pop-up is
displayed
=> Form and changes are still saved
3. Apply this patch.
4. Repeat steps 1. and 2.
=> Form is no longer saved

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:01:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:01:53 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-WnCOoGlsSJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:15:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:15:59 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-33AvP74JAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #10 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Changing back to ASSIGNED, latest patch broke saving the form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:21:29 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-cb3J08wFx5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:21:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:21:33 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-Dl8gEBYofL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142839|0                           |1
        is obsolete|                            |
 Attachment #142840|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142851&action=edit
Bug 30254: Unit tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:21:37 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-U3Rdpu50GX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142852&action=edit
Bug 30254: Don't charge overdue fines unless some fine exists

We need to determine if a book was lost by a patron, the clues we have
are previous charges. If we don't find any, we shouldn't charge a new fine

To test:
 1 - set Lost item fee refund on return policy to "Refund lost item charge and
charge new overdue fine", turn on FinesMode, make sure your circ rules charge
fines
 2 - have an itemtype / patron combo that charges an overdue fine
 3 - check item out (with a due date in the future) and then right back in
again
 4 - confirm patron doesn't have a fine because the item was not late
 5 - set the item to Lost
 6 - in the database, edit the date_due of your checkout to a date in the past
 7 - check the item in, it is marked found
 8 - confirm your patron now has a fine
 9 - Apply patch
10 - Repeat with a new item and patron
11 - Confirm no charges

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:21:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:21:42 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-ofyz4O7ZPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142853&action=edit
Bug 30254: (QA follow-up) Remove warn from tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:22:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:22:33 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-BeG3Ti6ygu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for beating me to this one Nick, much appreciated..

Simple fix, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:26:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:26:55 +0000
Subject: [Koha-bugs] [Bug 32024] Placing a hold on OPAC ignores Hold Pickup
 Location Match
In-Reply-To: <bug-32024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32024-70-IBFNDQfXJK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32024

--- Comment #4 from Daphne Hoolahan <dch at interleaf.ie> ---
Thanks Katrin.  We don't have that SysPref on 21.11, would you have a bugzilla
reference by any chance?  Perhaps we could copy the functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:34:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:34:00 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-aA2iMUDAE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:34:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:34:03 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-OntaAlZBO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142854&action=edit
Bug 32044: Improve consistency in primary submit buttons

We currently have a mix of ways to style buttons, including some using
Bootstrap's btn-primary class and some with CSS targeting
input[type='submit']. This patch works to make these buttons more
consistent in their appearance and to improve the modularity of related
SCSS.

The patch also removes some unused CSS from login.css.

To test, apply the patch and rebuild the staff interface CSS.

Test various page to see if main submit buttons look correct in their
default, hover, and active states:

- The login page
- Circulation -> Checkouts -> Check out button (btn-primary)
- Circulation -> Set library (input[type='submit'])
- Cataloging -> Basic MARC editor (split button)

Also check "default" buttons:

- Patrons -> Sidebar filter (input[type='button'])
- Circulation -> Checkouts -> Show checkouts (btn-default)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:35:05 +0000
Subject: [Koha-bugs] [Bug 32057] New: Add optional stack trace to action logs
Message-ID: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

            Bug ID: 32057
           Summary: Add optional stack trace to action logs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It can be useful to know where in Koha a particular logged action was generated
from, and how. We should add the ability to attach a syspref controlled basic
stack trace with the caller depth controlled via the syspref. We can the call
caller() until the specified depth has been reached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:35:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:35:11 +0000
Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs
In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32057-70-Q54Qvq0DAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:51:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:51:17 +0000
Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs
In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32057-70-QspCY0E8ND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:51:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:51:22 +0000
Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs
In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32057-70-osP7N3wssP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142855&action=edit
Bug 32057: Add optional stack trace to action logs

It can be useful to know where in Koha a particular logged action was generated
from, and how. We should add the ability to attach a syspref controlled basic
stack trace with the caller depth controlled via the syspref. We can the call
caller() until the specified depth has been reached.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
4) Restart all the things!
5) Set the new syspref ActionLogsTraceDepth to a number ( e.g. 3 )
6) Update a syspref or trigger another enabled log action
7) Query the database: SELECT * FROM action_logs WHERE trace IS NOT NULL
8) Note the stack trace was created!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 11:57:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 10:57:47 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-wHL5wlyQT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142850|0                           |1
        is obsolete|                            |

--- Comment #11 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 142856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142856&action=edit
Bug 24616: Do not save form if user press cancel

If one starts to copy a notice but then cancels
this when pop-up is displayed, changes are still
saved. This patch fixes this.

To test:
1. Copy notice to a library where it already exists
2. Press save and then cancel when pop-up is
displayed
=> Form and changes are still saved
3. Apply this patch.
4. Repeat steps 1. and 2.
=> Form is no longer saved

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:00:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:00:40 +0000
Subject: [Koha-bugs] [Bug 32058] New: 'Print > Print X' could use clearer
 labels
Message-ID: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32058

            Bug ID: 32058
           Summary: 'Print > Print X' could use clearer labels
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We have a 'Print' option in the patron toolbar, it's exposes a number of
options all labelled 'Print X'.

I would argue as the person has just clicked the 'Print' button to expose the
pulldown they already know the options are all 'Print something' so we don't
need the 'Print' as part of each label.. I also don't think the existing
options are all that clear as to what they're printing... could we rename them
more clearly?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:01:12 +0000
Subject: [Koha-bugs] [Bug 32058] 'Print > Print X' could use clearer labels
In-Reply-To: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32058-70-BUG91Rz4Xf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32058

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:01:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:01:33 +0000
Subject: [Koha-bugs] [Bug 32058] 'Print > Print X' could use clearer labels
In-Reply-To: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32058-70-bEtkxPlvZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32058

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31713

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:01:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:01:33 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-swD85wosGu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32058

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:04:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:04:22 +0000
Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs
In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32057-70-5QjPLWS1YL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142855|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142857&action=edit
Bug 32057: Add optional stack trace to action logs

It can be useful to know where in Koha a particular logged action was generated
from, and how. We should add the ability to attach a syspref controlled basic
stack trace with the caller depth controlled via the syspref. We can the call
caller() until the specified depth has been reached.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
4) Restart all the things!
5) Set the new syspref ActionLogsTraceDepth to a number ( e.g. 3 )
6) Update a syspref or trigger another enabled log action
7) Query the database: SELECT * FROM action_logs WHERE trace IS NOT NULL
8) Note the stack trace was created!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:05:51 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-wxPnOlGHWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
How about:

`Print account balance` for the button name and `ACCOUNTS_SUMMARY` for the
notice code...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:06:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:06:02 +0000
Subject: [Koha-bugs] [Bug 32057] Add optional stack trace to action logs
In-Reply-To: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32057-70-IMq8OvkWhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32057

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:12:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:12:41 +0000
Subject: [Koha-bugs] [Bug 32024] Placing a hold on OPAC ignores Hold Pickup
 Location Match
In-Reply-To: <bug-32024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32024-70-SmDmAnNKxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32024

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Daphne,

a good trick here is to add ALL in the front of your bugzilla search. This way
the closed bugs are also showing up in the results. 

The bug that added the preference is bug 23659.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:21:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:21:08 +0000
Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields
In-Reply-To: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31562-70-V58ec3FOHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 142858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142858&action=edit
Bug 31562: [22.05.x] Treat flags as other borrower fields

Rather than generate a custom hash for these fields, we should treat them as
other borrower data fields

To test:
 1 - Edit a patron, note the 'Lost card' and 'Gone no address' fields
 2 - Edit syspref BorrowerunwantedField
 3 - Set gonenoaddress and lost as unwanted
 4 - Edit patron, the fields remain
 5 - Apply patch
 6 - Edit a patron, fields are hidden
 7 - Unhide one of the fields
 8 - Edit a patron and confirm it shows and saves correctly
 9 - Unhide the other field
10 - Confirm it can be edited and saved

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 31562: Remove gonenoaddress and lost from OPAC borrower field preferences

These are not shown, so cannot be unwanted or mandatory

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 31562: Respect mandatory fields pref

To test:
1 - Set gonenoaddress and lost in BorrowerMandatoryField
2 - Edit a patron, confirm fields are required

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:26:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:26:53 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-ZOORg099XK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
When testing this already looked pretty good, but I noticed a small
inconsistency. When the login button is clicked, it turns white with grey/black
borders. The other buttons show the orange border when clicked.

The login button also appears to have more 'height' than other similar buttons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:30:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:30:00 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-arE5o4bk6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:36:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:36:01 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-rGWE8CWtb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #84 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 142859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142859&action=edit
Bug 30982: [22.05.x] Use the REST API for background job list view

Bug 30982: REST API specs

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: (QA follow-up) Double quoting and console.log

This patch fixes the issues highlighted by the QA script; We use double
quotes for translatable strings in JS and remove an errant console.log
call.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: Add tests and implement GET /background_jobs/$id

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: Make code more re-usable

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: Add 'context' to the REST API specs

context has been added by bug 30889

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: Add Koha::BackgroundJobs->filter_by_current

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: API tweaks

This patch makes the following changes to the 'background_jobs' API:

* We now call them 'jobs'
* Removed deprecated query parameter definitions
* Added only_current query parameter
* Controller gets adapted to use $rs->filter_by_current when
  only_current is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: Adapt table to new API spec

Disclaimer: this patch is highly opinionated :-D

When I started looking at this patch I felt like the two tables
(current/past jobs) implemented on bug 30462 was the way to go.

In order to make this patches apply after it I had to redo all the
things. Or most of them.

But I decided to keep the idea of filtering out completed tasks, not
just having the option to display 'the last hour' tasks. For the task I
added some required helper methods and the relevant tests as well. So a
behavior change.

Hope you all agree with it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: Rename 'Background Jobs' => 'Jobs'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: (QA follow-up) Resolve pod warning

Empty section in previous paragraph at line 32 in file Koha/BackgroundJobs.pm

Test plan:
Run podchecker again on this module.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: (QA follow-up) Spelling

[1] Correct: BackgrounJob
[2] If should filter out not current jobs
=> Had a hard time reading that one until I replaced if by it.
=> Decided to rephrase it in a more positive way.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: (QA follow-up) Remove redundancy from template

The template now contains two lists for both status and type:
a TT list and a JS list. The type list already proves that
redundancy leads to bugs. We miss three types at one side:
    Unknown job type 'stage_marc_for_import'
    Unknown job type 'marc_import_commit_batch'
    Unknown job type 'marc_import_revert_batch'

This patch removes the TT list. And gets the status and type
via an additional js call. For that reason I hide the fieldset
until document ready. This can be improved later when needed.

Test plan:
Look at status and type on both job list and detail view.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 30982: (QA follow-up) No userenv, no jobs

+    # Assume permission if context has no user
+    my $can_manage_background_jobs = 1;
=> This felt a bit unsafe.

Test plan:
Try interface for jobs. Call API with cookie. Call API with OAuth.
Run t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:36:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:36:28 +0000
Subject: [Koha-bugs] [Bug 30462] Should the background job list view hide
 index tasks by default?
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-N4dWAx9ROQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #36 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 142860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142860&action=edit
Bug 30462: [22.05.x] Separate Queued and Complete jobs

This patch updates the background jobs management page to display
queued and completed jobs in their own tabs on the page.

JD Amended patch:
Fix QA failures:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt
   FAIL   forbidden patterns
                forbidden pattern: trailing space char (line 158)
                forbidden pattern: trailing space char (line 256)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 30462: (follow-up) Limit completed to 60 minutes

This follow-up reduces the completed jobs list to only those jobs
completed within the last 60 minutes.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 30462: Remove 'Ended' column for current jobs

This column will always be empty

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 30462: Fix display of the complete jobs

We want to display the jobs terminated in the last hour, not today.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 30462: (QA follow-up) Tab name change

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:36:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:36:53 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-pA3lncyGZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

--- Comment #25 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 142861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142861&action=edit
Bug 31565: [22.05.x] Fix datatables searching escape for exact search

To test:
1. Add a new patron category with categorycode 'TEST_CAT'
2. Add a patron to category 'TEST_CAT'
3. Go to Patrons search view
4. Under "Search for patron" filters, filter by category you created at step 1
5. Click Search
6. Observe no results
7. Apply this patch and reload
8. Repeat 3-5
9. Observe expected result

Double check tests from Bug 30393 still work as expected:

10. Go to the cities page
11. Add two cities:
   - 'Cordoba %'
   - 'Buenos Aires _'
   - 'London \'
12. Use the column search on the name, alternating _, \ and % as the query
=> SUCCESS: Filtering works correctly!

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Bug 31565: Escape datatables MySQL special characters only in LIKE queries

Escaping \ yields no results when performing exact search in datatables.
This patch adds MySQL special character escaping only to LIKE searches.

To test:
1. Add following categorycode 'TEST\CAT' by SQL
insert into categories (categorycode,description) values ('TEST\\CAT',
'TEST\\CAT');
2. Add a patron into TEST\CAT category
3. Go to patron search
4. Limit search by category TEST\CAT
5. Observe no results
6. Apply patch
7. Refresh patron search page
8. Limit search by category TEST\CAT
9. Observe Koha redirecting you to patron you chose in step 2

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Bug 31565: (QA follow-up) Remove support for _ as wildcard in -like queries

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:46:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:46:06 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-8eyUVgD9yb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So.. I now understand 'scoped'.. it's not the html spec 'scoped'.. it's a vue
version that builds.

I still wonder how much of it we actually need.. but perhaps stripping it back
and trying to apply our global css rules is a follow-up task as part of our
general UI effort.

Generally.. I'm really happy to see the Vue Single-File Components being used,
it makes the code so easily readable and understandable keeping it all together
in a nice tightly packed file instead of spread all over the place the way I'm
doing with our old fashioned modals and things.

That said.. I might need some tips on getting vim to highlight things nicely..
having mixes of css, html and javascript in the same file messes with my
current setup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:48:23 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-TD4a0T9Rvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Back here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 12:59:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 11:59:05 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-vMbgffUsa6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142854|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142862&action=edit
Bug 32044: Improve consistency in primary submit buttons

We currently have a mix of ways to style buttons, including some using
Bootstrap's btn-primary class and some with CSS targeting
input[type='submit']. This patch works to make these buttons more
consistent in their appearance and to improve the modularity of related
SCSS.

The patch also removes some unused CSS from login.css.

To test, apply the patch and rebuild the staff interface CSS.

Test various page to see if main submit buttons look correct in their
default, hover, and active states:

- The login page
- Circulation -> Checkouts -> Check out button (btn-primary)
- Circulation -> Set library (input[type='submit'])
- Cataloging -> Basic MARC editor (split button)

Also check "default" buttons:

- Patrons -> Sidebar filter (input[type='button'])
- Circulation -> Checkouts -> Show checkouts (btn-default)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:02:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:02:14 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-dxP2iFFDXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #5)

> The login button also appears to have more 'height' than other similar
> buttons.

The login button has always been bigger than others. What changed is that I
altered it so that the padding increased proportionally with the font size. It
should be roughly the same font size but the padding-to-font ratio should
better match other buttons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:18:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:18:56 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-CJVN7ymPVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:18:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:18:59 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-oepApuoxEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142614|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142863&action=edit
Bug 31960: Information on job detail view is misaligned

This patch updates the structure of the background jobs template so that
HTML processed in the report includes is well styled. The patch does
this by breaking the report and detail includes out of the fieldset and
putting them in a separate section.

This patch also adds the page-section class to the table view of current
and past background jobs.

Note: The patch includes indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Administration -> Manage jobs.

- The table of jobs (even if empty) should be contained in a
  page-section style white box.
- Test various processes which trigger a backgroud job:
  - Batch item modification
  - Batch item deletion
  - Batch hold deletion
  - Batch record modification
  ... etc.
- After each process has been started, view the details of the job.
- The information about the job shold be displayed well, with separate
  sections for "Report" and "Detailed messages."

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:19:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:19:04 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-r9fAGiUtKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142864&action=edit
Bug 31960: (follow-up) Make headings match

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:22:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:22:26 +0000
Subject: [Koha-bugs] [Bug 31919] Hovered items in "More" should change
 background color
In-Reply-To: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31919-70-duqmyGUPE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|jonathan.druart+koha at gmail. |oleonard at myacpl.org
                   |com                         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:29:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:29:59 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-MCKGBSzKBt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #17 from David Nind <david at davidnind.com> ---
(In reply to Martin Renvoize from comment #16)
> How about:
> 
> `Print account balance` for the button name and `ACCOUNTS_SUMMARY` for the
> notice code...

Sounds great to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 13:59:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 12:59:57 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-tSmOgOIkns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141795|0                           |1
        is obsolete|                            |

--- Comment #18 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142865&action=edit
Bug 31735: Avoid re-fetcing objects from database by passing them directly
instead of ids to various subroutines

To test:

1) Run the following test and make sure all pass:
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/Illrequests.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Items.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Acquisition/Order.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Holds.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Item.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/Reserves.t
  t/db_dependent/rollingloans.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/SIP/ILS.t
2) Performe one or more checkouts for a patron, making sure
  that the circulation rules allows for renewals (for example by
  setting an earlier due-date).
3) Log in as this patron in OPAC and make sure the list of
  checkouts is displayed correctly, and that renewing an issue
  still works.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 14:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 13:00:03 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-f3Jf6y6LPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141796|0                           |1
        is obsolete|                            |

--- Comment #19 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142866&action=edit
Bug 31735: Avoid unesssary unblessing of objects

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 14:00:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 13:00:09 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-cDFnGtuE8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141797|0                           |1
        is obsolete|                            |

--- Comment #20 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142867&action=edit
Bug 31735: Add caching for relatively expensive patron attributes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 14:00:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 13:00:14 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-Q3xwNUAh7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141819|0                           |1
        is obsolete|                            |

--- Comment #21 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142868&action=edit
Bug 31735: Remove Koha::Config::SysPref->find since bypasses cache

get_yaml_pref_hash also allows invalid YAML and only parses a limited
subset so remove this method to avoid future issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 14:00:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 13:00:19 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-sWNWd0dHYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141820|0                           |1
        is obsolete|                            |

--- Comment #22 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142869&action=edit
Bug 31735: Match rules on effective item type instead of itype

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 14:00:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 13:00:24 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-vN8sGTR3i5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141821|0                           |1
        is obsolete|                            |

--- Comment #23 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142870&action=edit
Bug 31735: Optimize OPAC checkouts view

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:11:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:11:27 +0000
Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields
In-Reply-To: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31562-70-0CQh3JWL7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for the upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:25:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:25:19 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-eXME8ZA0PW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142340|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142871&action=edit
Bug 31713: Add FEE_SUMMARY print slip link

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:25:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:25:25 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-SRZP9vkalb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142341|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142872&action=edit
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:25:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:25:31 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-Eup7dMf86R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142760|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142873&action=edit
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
[EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:25:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:25:36 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-wKHv2k4ZXB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142874&action=edit
Bug 31713: (follow-up) Fix terminology

This patch fixes the terminology as proposed.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:25:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:25:42 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-ppUnF9THMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142875&action=edit
Bug 31713: (follow-up) Display print option for any outstanding

Prior to this patch we only allowed printing if the balance was owed to
the library.. This patch exposes the option when the patron is owed too.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:26:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:26:08 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-wneT0wbrR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:29:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:29:34 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-SuBiCMy8pP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142875|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142876&action=edit
Bug 31713: (follow-up) Display print option for any outstanding

Prior to this patch we only allowed printing if the balance was owed to
the library.. This patch exposes the option when the patron is owed too.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:32:17 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-GZLnB6wz0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:32:50 +0000
Subject: [Koha-bugs] [Bug 32059] New: How to run scripts found under
 https://perldoc.koha-community.org/
Message-ID: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32059

            Bug ID: 32059
           Summary: How to run scripts found under
                    https://perldoc.koha-community.org/
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mik at adminkuhn.ch
        QA Contact: testopia at bugs.koha-community.org

Documentation pages like
https://perldoc.koha-community.org/misc/migration_tools/bulkmarcimport.html do
not give the proper command to run the script. In the example section "Usage"
says:

$ export KOHA_CONF=/etc/koha.conf
$ perl misc/migration_tools/bulkmarcimport.pl -d -commit 1000 -file
/home/jmf/koha.mrc -n 3000

When using Debian package installation one way to actually run the program is:

As user "root":

# export KOHA_CONF=/etc/koha/sites/instancename/koha-conf.xml
# export PERL5LIB=/usr/share/koha/lib
# /usr/share/koha/bin/migration_tools/bulkmarcimport.pl -b -m marcxml
-framework=frameworkname -file TITEL.marcxml -v 2

But it seems the following way is recommended:

As user "koha":

$ sudo koha-shell -c
"/usr/share/koha/bin/migration_tools/bulkmarcimport.pl -b -m marcxml
-framework=frameworkname -file TITEL.marcxml -v 2" instancename

Better documentation how to run this kind of scripts would be useful.
https://perldoc.koha-community.org/ shows many more such scripts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:27 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-Je0g9oXDEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:32 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-FeZ8o8zKKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142003|0                           |1
        is obsolete|                            |

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142877&action=edit
Bug 24606: Update database, add new schema file

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:38 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-khkBGDKUcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142004|0                           |1
        is obsolete|                            |

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142878&action=edit
Bug 24606: Add Koha Object(s) with unit tests

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:43 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-WYZxu0uRgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142005|0                           |1
        is obsolete|                            |

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142879&action=edit
Bug 24606: Implement item templates

This patch set implements item editor templates for community Koha.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Restart all the things!
4) prove t/db_dependent/Koha/Item/Template*
5) As a non superlibrarian, enter the item editor
6) Set some item fields, save as a new template using the buttom and
   form below the editor.
7) Test loading a template without remembering for the session
8) Test loading a template while remembering for the session
9) Test deleting a template
10) Test updating a template
11) Create one or more shared templates
12) Log in as another non superlibrarian without the new permission
manage_item_editor_templates,
    verify you cannot edit/delete templates shared to you
13) Enable the new permission manage_item_editor_templates,
    verify you can now edit and delete templates shared to you

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:48 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-hPean1pj9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142006|0                           |1
        is obsolete|                            |

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142880&action=edit
Bug 24606: Add item template editor permission

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:53 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-FiJeKNIZFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142007|0                           |1
        is obsolete|                            |

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142881&action=edit
Bug 24606: Update existing schema files [DO NOT PUSH]

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:36:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:36:59 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-uxC9YeoGw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142008|0                           |1
        is obsolete|                            |

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142882&action=edit
Bug 24606: (QA follow-up) Set existing sharing setting when updating existing
template

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:37:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:37:04 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-nAx2duYmS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142833|0                           |1
        is obsolete|                            |

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142883&action=edit
Bug 24606: (QA follow-up) Fix QA script issues

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:37:10 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-LhOMJlPFVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142834|0                           |1
        is obsolete|                            |

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142884&action=edit
Bug 24606: (QA follow-up) Update js message translation style

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:37:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:37:16 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-9ODLv4BVHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142835|0                           |1
        is obsolete|                            |

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142885&action=edit
Bug 24606: (QA follow-up) Fix up interface

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:37:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:37:22 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-UtG1v8rhAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142836|0                           |1
        is obsolete|                            |

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142886&action=edit
Bug 24606: (QA follow-up) Hide button when using multi-add

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:37:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:37:28 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-2hVm1uYKwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142837|0                           |1
        is obsolete|                            |

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142887&action=edit
Bug 24606: (QA follow-up) Disable 'Apply template' button if no template is
selected

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:37:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:37:33 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-LyxKEJFoV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142888&action=edit
Bug 24606: (QA follow-up) Remove string variable

This string is no longer needed as the __() is used
in the .js file directly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:40:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:40:22 +0000
Subject: [Koha-bugs] [Bug 32059] How to run scripts found under
 https://perldoc.koha-community.org/
In-Reply-To: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32059-70-kvyt89nIc0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32059

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel like the instructions are not wrong in itself, the instructions work,
they just assume that in a package installation you run the 'sudo koha-shell
instance' command first, no matter which script you run. 

Also it depends, if you are not using a package based installation, but using
tarball, you'd have to run them under the koha-user without having the
koha-shell command option.

This might be better for the manual instead of altering all the man pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:42:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:42:03 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-YEuzTlJ59A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this a nice addition and have passed QA on this. 

BUT: The GUI still needs a little bit more work, so this can shine on release:
https://snipboard.io/IaM4VW.jpg 

I noticed that it reloads the page every time you apply or clean a template, it
might be a nice improvement to rely on an API call here in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:44:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:44:13 +0000
Subject: [Koha-bugs] [Bug 32033] Cannot rebuild zebra
In-Reply-To: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32033-70-IzVG2hKo3f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033

--- Comment #5 from Chaminda de Silva <chimesh at gmail.com> ---
(In reply to David Cook from comment #3)
> (In reply to Chaminda de Silva from comment #2)
> > 1. How to findout the URL of the particulaar record.
> 
> Do you mean how do you determine which record is causing the problem?
> 
> You'll need to do a SQL Report. 
> 
> You could try something like the following:
> 
> SELECT biblionumber, ExtractValue(metadata,'//datafield[@tag="880" and
> subfield[@code="6" and substring(text(),1,3)="24 "]]/*') as f880 from
> biblio_metadata HAVING f880 <> ''
> 
> Do you have a public OPAC? If you can provide the URL to that OPAC, I can
> lookup the records once you've given me a biblionumber.

Thank you  very much David, I figured out the problem of Tag "24 " is not a
valid tag using  your SQL Query. It should be Tag "245" not Tag "24 ".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:46:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:46:41 +0000
Subject: [Koha-bugs] [Bug 32059] How to run scripts found under
 https://perldoc.koha-community.org/
In-Reply-To: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32059-70-vVVx9iJJVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32059

--- Comment #2 from Michael Kuhn <mik at adminkuhn.ch> ---
"...the instructions work, they just assume that in a package installation you
run the 'sudo koha-shell instance' command first, no matter which script you
run. Also it depends, if you are not using a package based installation, but
using tarball, you'd have to run them under the koha-user without having the
koha-shell command option."

But that's exactly the problem I wanted to submit - the documentation page
doesn't say so. So if you're not already knowing what's assumed or how it works
you're stuck.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:50:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:50:00 +0000
Subject: [Koha-bugs] [Bug 32052] Hold cancellations in the OPAC are falsely
 recorded as 'intranet'
In-Reply-To: <bug-32052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32052-70-jxS6sYLhWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32052

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Transparency on Hold        |Hold cancellations in the
                   |Cancellations               |OPAC are falsely recorded
                   |                            |as 'intranet'
           Severity|enhancement                 |minor

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's not quite right, we do keep a log, but I think there is still a bug there
actually: if you cancel a hold from the OPAC, the logs still show the interface
as "Intranet". It should be OPAC.

To test:
* Create 2 holds
* Turn on HoldsLog system preference
* Cancel one hold from the staff interface
* Cancel one hold from the OPAC
* Check the holds logs - you can see that both cancel entries look the same

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:51:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:51:38 +0000
Subject: [Koha-bugs] [Bug 32059] How to run scripts found under
 https://perldoc.koha-community.org/
In-Reply-To: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32059-70-aHaAqIIL1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32059

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree we should document, just thinking that the auto-generated perl-doc
might not be the right place. As this is dependent on how you installed Koha,
notes in the wiki or manual in a general 'how to' chapter might better.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:53:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:53:17 +0000
Subject: [Koha-bugs] [Bug 32031] Sidebars and Breadcrumbs
In-Reply-To: <bug-32031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32031-70-uoKpTQVfP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32031

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I agree to some extent... we'd need a more formal idea of what a sidebar should
contain.. we jumble a lot of extra content into it at times and that certainly
does lead to it looking weird.. we're also not consistent in when we actually
have a sidebar at all.

One to keep in the 'ideas' pile for now I think... though I'd love to still see
us slowly progress towards it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:55:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:55:15 +0000
Subject: [Koha-bugs] [Bug 32050] Add 'page-section' to calendar page
In-Reply-To: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32050-70-Vo3T4nSkb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142842|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142889&action=edit
Bug 32050: Add 'page-section' to calendar page

This patch adds a "page-section" div to a couple of areas on the
calendar page.

To test, apply the patch and go to Tools -> Calendar.

The content in the page's two columns should be wrapped in a white box.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:55:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:55:28 +0000
Subject: [Koha-bugs] [Bug 32050] Add 'page-section' to calendar page
In-Reply-To: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32050-70-xBl8FHel3S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:59:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:59:03 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-pT72BQEZRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:59:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:59:08 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-yfzPgQU52x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142862|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142890&action=edit
Bug 32044: Improve consistency in primary submit buttons

We currently have a mix of ways to style buttons, including some using
Bootstrap's btn-primary class and some with CSS targeting
input[type='submit']. This patch works to make these buttons more
consistent in their appearance and to improve the modularity of related
SCSS.

The patch also removes some unused CSS from login.css.

To test, apply the patch and rebuild the staff interface CSS.

Test various page to see if main submit buttons look correct in their
default, hover, and active states:

- The login page
- Circulation -> Checkouts -> Check out button (btn-primary)
- Circulation -> Set library (input[type='submit'])
- Cataloging -> Basic MARC editor (split button)

Also check "default" buttons:

- Patrons -> Sidebar filter (input[type='button'])
- Circulation -> Checkouts -> Show checkouts (btn-default)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 15:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 14:59:40 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-7X5bTLXWAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is a CSS only change, taking the liberty to move straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 16:03:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 15:03:19 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-3Xn4GGdGqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 16:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 15:03:24 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-e1c8j2NX1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142863|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142891&action=edit
Bug 31960: Information on job detail view is misaligned

This patch updates the structure of the background jobs template so that
HTML processed in the report includes is well styled. The patch does
this by breaking the report and detail includes out of the fieldset and
putting them in a separate section.

This patch also adds the page-section class to the table view of current
and past background jobs.

Note: The patch includes indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Administration -> Manage jobs.

- The table of jobs (even if empty) should be contained in a
  page-section style white box.
- Test various processes which trigger a backgroud job:
  - Batch item modification
  - Batch item deletion
  - Batch hold deletion
  - Batch record modification
  ... etc.
- After each process has been started, view the details of the job.
- The information about the job shold be displayed well, with separate
  sections for "Report" and "Detailed messages."

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 16:03:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 15:03:29 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-u221nzhaqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142864|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142892&action=edit
Bug 31960: (follow-up) Make headings match

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 16:06:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 15:06:52 +0000
Subject: [Koha-bugs] [Bug 31919] Hovered items in "More" should change
 background color
In-Reply-To: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31919-70-Lyvx8MMxmu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 16:06:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 15:06:56 +0000
Subject: [Koha-bugs] [Bug 31919] Hovered items in "More" should change
 background color
In-Reply-To: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31919-70-elmFIujl5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142831|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142893&action=edit
Bug 31919: Add backgground color to hovered items in header dropdowns

This alternate patch is different in a few ways:

- Add a hover background color only to items in dropdown menus.
- Use an SCSS variable for the background color
- Update the specificity of the hover CSS to more fully override
  Bootstrap's default.

To test, apply the patch and rebuild the staff interface CSS.

- On any page in the staff interface, test the behavior of links in the
  nav header.
- The always-visible links (Circulation, Patrons, etc) should keep the
  same style as before: Underline on hover.
- In dropdown menus like "More" and the user menu in the upper right
  corner, hovered links should have a green background.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 16:09:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 15:09:55 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-NJuLeTB90X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #178 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Back here again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:11:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:11:21 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-Zwg6VNvmn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #179 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry Kyle, the latest follow-up fixed the error, but the new text in
pendingreserves never displays. I have tried to figure out what's going on
there, but got stuck on this line:

+    if ( $res_info->item_group ) {
+       $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
$_->item_group && ( $_->item_group->id == $res_info->item_group_id )  ?
$_->barcode : () } @$items ];
+    }
+

I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold group
hold.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:13:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:13:16 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-Hydf6tL8i3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this is intentional and not a bug if there is only one
sub-permission, it equals the module permissions level.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:15:04 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-VftNiaHzkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|kyle at bywatersolutions.com   |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:31:37 +0000
Subject: [Koha-bugs] [Bug 32060] New: Improve performance of
 Koha::Item->columns_to_str
Message-ID: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

            Bug ID: 32060
           Summary: Improve performance of Koha::Item->columns_to_str
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When creating a new item for a biblio with many items, for example serials
which can have several hundreds, the table of existing items that is shown is
currently very performance heavy to generate. The main culprit is
Koha::Item->columns_to_str that can be sped up substantially by caching data
that is looked up repeatedly for each call. With this patch columns_to_str will
run about ~70x faster, reducing the load time of
/cataloguing/additem.pl?biblionumber=... to about one fifth for a biblio with
about 150 items (and even more with increasing number of items).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:33:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:33:06 +0000
Subject: [Koha-bugs] [Bug 32060] Improve performance of
 Koha::Item->columns_to_str
In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32060-70-iKJN7KQpKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:46:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:46:55 +0000
Subject: [Koha-bugs] [Bug 32060] Improve performance of
 Koha::Item->columns_to_str
In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32060-70-AD2ZTPdESP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 142894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142894&action=edit
Bug 32060: Improve performance of columns_to_str

To test:
1) Ensure tests in t/db_dependent/Koha/Item.t all pass
2) Go to a biblio (preferably as serial) with many items and
   click "New" -> "New item" and take not of the response time.
3) Apply the patch.
4) Ensure tests in t/db_dependent/Koha/Item.t still pass
5) Repeat step 1), the response time should be substantially
   improved.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:47:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:47:14 +0000
Subject: [Koha-bugs] [Bug 32060] Improve performance of
 Koha::Item->columns_to_str
In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32060-70-wVqtP1IvwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 17:55:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 16:55:31 +0000
Subject: [Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.
In-Reply-To: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31241-70-WxBnLl9YJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

Manos PETRIDIS <egpetridis at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egpetridis at yahoo.com

--- Comment #1 from Manos PETRIDIS <egpetridis at yahoo.com> ---
Does the error persist?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 18:15:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 17:15:31 +0000
Subject: [Koha-bugs] [Bug 31453] Add ability to filter messages to process
 using process_message_queue.pl via a command line parameter
In-Reply-To: <bug-31453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31453-70-gBcAxE0U5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability to skip         |Add ability to filter
                   |processing messages in      |messages to process using
                   |message queue based on      |process_message_queue.pl
                   |message contents            |via a command line
                   |                            |parameter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 18:16:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 17:16:09 +0000
Subject: [Koha-bugs] [Bug 31453] Add ability to filter messages to process
 using process_message_queue.pl via a command line parameter
In-Reply-To: <bug-31453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31453-70-zgHvsFLlUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139828|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142895&action=edit
Bug 31453: Add ability to filter messages to process using
process_message_queue.pl via a command line parameter

It would be very useful to be able to tell process_message_queue.pl to skip
processing some messages. This is particularly useful where a plugin handles
sending some message using the before_send_messages hook, but while that plugin
is processing, more messages meant for the plugin might be queued. At that
point, control moves back to the script and SendQueuedMessages is called, and
those messages end up being processed there instead of by the plugin.

Test Plan:
1) Apply this patch
2) Queue two messages, each with a unique word
3) Run process_message_queue --where "content NOT LIKE '%WORD%'"
   where WORD is a unique word in one of the two message
4) Note the message containing "WORD" was not processed
5) prove t/db_dependent/Letters.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 18:24:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 17:24:34 +0000
Subject: [Koha-bugs] [Bug 31345] Add ability to exit
 process_message_queue.pl early if any plugin before_send_messages hook
 fails
In-Reply-To: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31345-70-sumjHkVQqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Keywords|                            |rel_22_11_candidate

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Trivial and handy minor enh.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 18:32:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 17:32:16 +0000
Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a
 dropdown field in the cataloguing editor
In-Reply-To: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31646-70-E3iS9Fapdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 19:05:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 18:05:05 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-YKxgv7R7bi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

--- Comment #11 from Blou <philippe.blouin at inlibro.com> ---
The last patch "import issue" fixes a crash in 22.05.06 (at least).

I haven't managed to apply the whole set on Koha/VirtualShelf.pm, because of
Bug 30933.  It's a rabbit hole, but without it we get a 500 on public lists
when logged in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 19:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 18:35:05 +0000
Subject: [Koha-bugs] [Bug 32058] 'Print > Print X' could use clearer labels
In-Reply-To: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32058-70-hXYQKsE96I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32058

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I'm ok with new labels/names, but please remember we've got a couple of
sysprefs that refer to these by their current names: CircAutoPrintQuickSlip and
DisplayClearScreenButton.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 19:52:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 18:52:15 +0000
Subject: [Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong
 match when passed 'best only'
In-Reply-To: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32054-70-FIEuKITQc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
I'm happy to try and test, however there is no attached record (step 1 of the
test plan).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 20:19:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 19:19:46 +0000
Subject: [Koha-bugs] [Bug 32061] New: <span> in the title of z39.50 servers
 page
Message-ID: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

            Bug ID: 32061
           Summary: <span> in the title of z39.50 servers page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When accessing the Z39.50 servers page, in the title of the page (what appears
in the browser tab) there are html tags <span>.

To test:
1. Go to Administration > Z39.50/SRU servers
2. Click "New Z39.50 server"
   --> Notice in the browser tab, the title of the page is New
<span>Z39.50</span> server > ...

It does this for new Z39.50 server, new SRU server and when editing a server
too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 20:20:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 19:20:11 +0000
Subject: [Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong
 match when passed 'best only'
In-Reply-To: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32054-70-N0HpItGTmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 142896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142896&action=edit
Sample biblio from sample database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:28:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:28:09 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-gzK3RRbpZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:28:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:28:20 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-ac7YoFgHMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133089|0                           |1
        is obsolete|                            |

--- Comment #189 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142897&action=edit
Bug 8367: Add holds_pickup_period circulation rule

So that pickup delay can have a different value per patron category,
   item type or branch.

To test:

1) Update database, restart services
2) Set ReservesMaxPickUpDelay syspref (if not already set)
3) Edit your circulation rules and set a value under 'Holds pickup
period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few
different numbers for different branches as well.
4) Place a hold on a biblio from the staff client.
5) Check in an item from that biblio and confirm the hold as waiting
6) Confirm the expiration date is calculated using the 'Holds pickup
period' value instead of the ReservesMaxPickUpDelay syspref
7) Revert the waiting status and delete the hold
8) Re-place the hold on the biblio on the OPAC. Notice that when you
change the pick up location, the number of days in the pickup message
below the dropdown changes based on the circ rules.
9) Create a holiday with a date that will overlap with the 'Holds pickup
period'
10) Check in an item from that biblio and confirm the hold as waiting
11) Confirm the expiration date is calculated using the 'Holds pickup
period' value AND considers the special holiday
12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t
13) Test Talking Tech:
13a) Enable TalkingTechItivaPhoneNotification
13b) Go to Tools -> Notices & slips. Add content to the HOLD phone
(itiva) notice.
13c) In your terminal, run perl
/path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o
~/itiva.tmp -w 0 --type=RESERVE

Sponsored-by: Catalyst IT

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:28:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:28:33 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-wMrSkzuUOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133090|0                           |1
        is obsolete|                            |

--- Comment #190 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142898&action=edit
Bug 8367: Make database update idempotent

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:28:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:28:44 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-Ss2ztnpLdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133091|0                           |1
        is obsolete|                            |

--- Comment #191 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142899&action=edit
Bug 8367: Make database update idempotent (across different MariaDB versions)

The previous query seemed to work on MariaDB 10.1.48 (used by
koha-testing-docker),
but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this
writing),
but this patched query works on both indempotently.

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:28:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:28:54 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-aVF4ATAcpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133092|0                           |1
        is obsolete|                            |

--- Comment #192 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142900&action=edit
Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:29:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:29:04 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-8VsVF35yeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133093|0                           |1
        is obsolete|                            |

--- Comment #193 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142901&action=edit
Bug 8367: (follow-up) Remove pickup delay message from OPAC

It adds unnecessary complexity and information.

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:29:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:29:14 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-CJ2tSanvOG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133094|0                           |1
        is obsolete|                            |

--- Comment #194 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142902&action=edit
Bug 8367: (follow-up) Fix tests

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:29:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:29:25 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-ekuC9CXrLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #195 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142903&action=edit
Bug 8367: (follow-up) Remove unnecessary code and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:56:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:56:59 +0000
Subject: [Koha-bugs] [Bug 32062] New: Add import tool to Authorities
Message-ID: <bug-32062-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062

            Bug ID: 32062
           Summary: Add import tool to Authorities
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The stage MARC records/managed staged MARC records tools have been moved from
tools to cataloging in bug 31162.

Those two tools are also used for authority records. We should add a link there
too, because now it looks like it's only for bibliographic records.

(we could argue that authorities are cataloging, I'm open to whatever, I just
find that authorities are left behind)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:57:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:57:13 +0000
Subject: [Koha-bugs] [Bug 32062] Add import tool to Authorities
In-Reply-To: <bug-32062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32062-70-zxpzwM4F6r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162
[Bug 31162] Add a clear cataloguing module home page
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 21:57:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 20:57:13 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-GvPewpCwwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32062


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062
[Bug 32062] Add import tool to Authorities
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 22:36:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 21:36:10 +0000
Subject: [Koha-bugs] [Bug 32063] New: Streamline importing of records
Message-ID: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063

            Bug ID: 32063
           Summary: Streamline importing of records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Since bug 27421, importing records is managed in background jobs. I feel like
this has added steps/clicks to something that was already click-heavy.

Before (basing off of 22.05), to import a record file
1. Go to Tools > Stage MARC records for import
2. Click Browse and choose the file
3. Click Upload file
4. Choose the settings
5. Click Stage for import
   --> The summary of the file is presented
6. Click Manage staged records
   --> I am taken directly to manage my file
7. If needed, choose parameters, framework, etc.
8. Click Import this file into the catalog
   --> File is imported
   --> If needed, I can view/edit the records (for bibliographic records, this
is almost always since I add items manually to add the barcodes)

Now (based off master 22.06.?)
1. Go to Cataloging > Stage records for import
2. Click Browse and choose the file
3. Click Upload file
4. Choose the settings
5. Click Stage for import
6. Click View details of the enqueued job
7. Click View batch
8. If needed, choose parameters, framework, etc.
9. Click Import this file into the catalog
Mine, for some reason, never works on the first try, so I have to go back and
click Import this file into the catalog again, then it works. I hope this is
just me...
10. Click Manage imported batch (if needed to see the records to add items for
example)

So it's not that many new clicks, but it's still two more steps than before, 10
vs 8 (or four more if the import doesn't work on the first try like mine!)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 22:39:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 21:39:27 +0000
Subject: [Koha-bugs] [Bug 30462] Should the background job list view hide
 index tasks by default?
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-WLvY7MWaAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #37 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 22:43:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 21:43:18 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-tVh6SWIPKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #85 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 22:58:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 21:58:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-mOk8q9QPSY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #91 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Is this the link? https://gitlab.com/thekesolutions/Koha/-/commits/oauth_client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 22:59:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 21:59:28 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-N1j3rz0zMs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #92 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Aleisha Amohia from comment #91)
> Is this the link?
> https://gitlab.com/thekesolutions/Koha/-/commits/oauth_client

Hi Aleisha, Tomas added it to the URL field after my last comment, it matches
with yours.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:00:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:00:07 +0000
Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items
 does not work
In-Reply-To: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25375-70-jSu536Yibr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #44 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:04:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:04:12 +0000
Subject: [Koha-bugs] [Bug 31518] Hidden items count not displayed on hold
 request page
In-Reply-To: <bug-31518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31518-70-wNpKcBjrpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:06:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:06:47 +0000
Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly
 on patron search results page
In-Reply-To: <bug-31525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31525-70-goWCoOp5Z8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:07:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:07:30 +0000
Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more
 than 20 items on the return screen
In-Reply-To: <bug-30802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30802-70-6Op5eTWNSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:08:48 +0000
Subject: [Koha-bugs] [Bug 30484] Interlibrary loans should have the ability
 to send notices based on request supplier updates
In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30484-70-CtdMQYuuCB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting
                 CC|                            |lucas at bywatersolutions.com

--- Comment #29 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:09:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:09:58 +0000
Subject: [Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with
 'plack'
In-Reply-To: <bug-31468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31468-70-4851mnoKKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
Missing dependencies for 22.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:09:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:09:59 +0000
Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo
 logger for the REST API
In-Reply-To: <bug-22678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22678-70-p5RXibYosK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678
Bug 22678 depends on bug 31468, which changed state.

Bug 31468 Summary: Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:10:55 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-EVmsSc0FS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #42 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:11:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:11:50 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-J3g75PBNKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:25:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:25:16 +0000
Subject: [Koha-bugs] [Bug 31527] Breadcrumbs for anonymous suggestions are
 not correct
In-Reply-To: <bug-31527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31527-70-21nZEwfVhM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31527

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:28:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:28:51 +0000
Subject: [Koha-bugs] [Bug 31605] Improve style of OPAC suggestions search
 form
In-Reply-To: <bug-31605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31605-70-2qevQ9slNm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31605

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:29:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:29:19 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-avHobFpu6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #26 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:29:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:29:42 +0000
Subject: [Koha-bugs] [Bug 31419] Add accesskeys to recall modal
In-Reply-To: <bug-31419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31419-70-vJsgjiCemr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:31:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:31:03 +0000
Subject: [Koha-bugs] [Bug 8305] Add an icon for iOS home screens
In-Reply-To: <bug-8305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8305-70-VUFoO1uN1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:32:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:32:37 +0000
Subject: [Koha-bugs] [Bug 15545] Remove remainders of unfinished
 reqholdnotes functionality
In-Reply-To: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15545-70-1PsM7MNJrw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:33:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:33:25 +0000
Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values
In-Reply-To: <bug-26368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26368-70-DG4jtWhBZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:44:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:44:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-4rHYtsUsOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #93 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #89)
> Hi all, a couple follow-ups have been pushed to the branch and are ready for
> testing. We couldn't make some new tests we attempted to write for login
> work.
> 
> It would be great to have them, but not sure if required. Why help there is
> welcome. We ran out of fuel yesterday

Does this mean that the tests are failing and you'd like help to fix the tests?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  1 23:56:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 22:56:54 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-LXCcPXAO1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #94 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #93)
> (In reply to Tomás Cohen Arazi from comment #89)
> > Hi all, a couple follow-ups have been pushed to the branch and are ready for
> > testing. We couldn't make some new tests we attempted to write for login
> > work.
> > 
> > It would be great to have them, but not sure if required. Why help there is
> > welcome. We ran out of fuel yesterday
> 
> Does this mean that the tests are failing and you'd like help to fix the
> tests?

It means an attempt from Agustín to write login tests didn't go well. We're can
live without those.

I'd like you to test that branch, which solves things that were reported,
including a rename. That branch probably needs a tidy, I haven't checked that
last commit (before the tests).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:09:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:09:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-yVneEIZ35P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #95 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #94)
> It means an attempt from Agustín to write login tests didn't go well. We're
> can live without those.

Ok I think I understand. I won't worry too much about failing tests for this go
around then.

> I'd like you to test that branch, which solves things that were reported,
> including a rename. That branch probably needs a tidy, I haven't checked
> that last commit (before the tests).

The follow up commits seem to be a mix of the tests and core code changes, so
those would need to be re-organised before QAing and pushing I think. 

--

I suppose Aleisha or myself could QA, so I suppose either of us could sign off.
I'll have a look in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:10:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:10:27 +0000
Subject: [Koha-bugs] [Bug 32033] Cannot rebuild zebra
In-Reply-To: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32033-70-p8kUkHouwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Chaminda de Silva from comment #5)
> Thank you  very much David, I figured out the problem of Tag "24 " is not a
> valid tag using  your SQL Query. It should be Tag "245" not Tag "24 ".

I thought that's what I was saying in my 1st comment. Apologies that I wasn't
clearer!

Glad you were able to sort it out.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:12:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:12:00 +0000
Subject: [Koha-bugs] [Bug 32033] Cannot rebuild zebra
In-Reply-To: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32033-70-7KJCJ7FxCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Katrin, do you think this should be closed? 

On one hand, failing to reindex due to one bad record seems suboptimal.

On the other hand, if it just warns or silences the error, then it's not
obvious there is a problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:16:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:16:10 +0000
Subject: [Koha-bugs] [Bug 32063] Streamline importing of records
In-Reply-To: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32063-70-x6bTZIuuEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:23:32 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eS9unUMXFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #96 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Just skip the last commit (wip trying to add tests).

I noticed we need to redo Nick's and your patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:29:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:29:28 +0000
Subject: [Koha-bugs] [Bug 31329] Add ability to block all linked accounts
 when one account has been restricted
In-Reply-To: <bug-31329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31329-70-AQun2v6OAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31329

saylett at spanishfork.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |saylett at spanishfork.org

--- Comment #4 from saylett at spanishfork.org ---
Yes! Yes! Yes! We would absolutely love this feature at our library. Like
others have said, manually blocking/blocking all of the guarantee accounts is
time consuming and oftentimes forgotten about.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:58:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:58:48 +0000
Subject: [Koha-bugs] [Bug 6960] staffaccess permission requires borrowers
 permission
In-Reply-To: <bug-6960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6960-70-Sv0seT3zvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6960

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
I agree with Katrin. It's not feasible to turn "staffacess" into a
subpermission of "borrowers".

In theory, the "staffaccess" line could be moved up and placed adjacent to the
"borrowers" and "permissions" lines. However, that would probably require a
re-jigging of the templating, since right now the permissions are in "bit"
order. 

That re-jigging might be a good idea though, as there are other permissions
that could potentially be grouped together functionally.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 00:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Nov 2022 23:59:46 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-a7ELRZFZKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Choosing the top level flag is the same thing as selecting all sub-permissions.
If you go to "Check out and check in items", choose all the sub-permissions and
you'll see that the top level flag gets set. (Alternatively, if you just choose
the top level flag, it will set all the sub-permissions. Uncheck one
sub-permission, and you the top level flag is unchecked.)

If you go to
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31389&attachment=140563
and look at "Permissions.t", it might be clearer.

You get CAN_user_circulate if you're superlibrarian, if you have the top level
"circulate" permission, or if you have *any* circulation sub-permission. 

When you just set "circulate" without specifying individual subpermissions, it
automatically gives you all sub-permissions. 

So setting the "manage_recalls" sub-permission is functionally equivalent to
setting the "recalls" top level flag, since there is only . You'll get the
exact same authorization.

I hope that makes sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:32:50 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-BU0upk1GFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #97 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #96)
> Just skip the last commit (wip trying to add tests).
> 
> I noticed we need to redo Nick's and your patches

It looks like the last commit includes some updates besides tests though
despite the commit name?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:37:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:37:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-qMF7ywFzs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #98 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #97)
>
> It looks like the last commit includes some updates besides tests though
> despite the commit name?

Skip the tests themselves, unless you really want to look at them

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:41:27 +0000
Subject: [Koha-bugs] [Bug 24465] Label creator requires catalogue permission
 instead of label_creator permission from tools
In-Reply-To: <bug-24465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24465-70-RQRzVnEceh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Can you clarify this one?

It looks to me like the template for
./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt uses
the correct tools label creator sub-permission.

However, it looks like the Perl scripts (e.g. ./labels/label-home.pl) are using
the "catalogue" permission instead.

Actually running 'grep "flagsrequired" ./labels/*' shows either "catalogue =>
1" or "tools => 'label_creator'" or "borrowers => 'edit_borrowers'"

I wonder if the Perl scripts should have both the "label_creator" sub
permission and the "catalogue" permission...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:42:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:42:03 +0000
Subject: [Koha-bugs] [Bug 32064] New: Add missing test to template
 permission calculation
Message-ID: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

            Bug ID: 32064
           Summary: Add missing test to template permission calculation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Test Suite
          Assignee: dcook at prosentient.com.au
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Bug 31389 refactored how permissions are calculated for the templates. Today I
realized there was 1 missing test to test that all subpermission authorizations
are set when the top level permission is set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:43:44 +0000
Subject: [Koha-bugs] [Bug 31389] Calculate user permissions in separate
 function
In-Reply-To: <bug-31389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31389-70-wgGSvH2Kzp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
In hindsight, there is 1 test missing.

For "normal staff user test", I should've included "'reports' => 1" and then
checked that it all the sub-permissions authorizations. 

I've opened bug 32064 to include that missing test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:46:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:46:01 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-kfSHDPVRlS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:46:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:46:04 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-uRJUDfYewA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 142904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142904&action=edit
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:46:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:46:20 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-dJYVIlEO0v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31389


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389
[Bug 31389] Calculate user permissions in separate function
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 01:46:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 00:46:20 +0000
Subject: [Koha-bugs] [Bug 31389] Calculate user permissions in separate
 function
In-Reply-To: <bug-31389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31389-70-vQwiPlPjOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31389

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32064


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064
[Bug 32064] Add missing test to template permission calculation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:05:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:05:33 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-BFeujfSEED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #40 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #39)
> I've discussed this a little offline with a few people but never found a
> moment to put it down as a comment here.
> 
> I think this bug starts going in the right direction.. but..
> 
> I don't think we should continue down the route of 'nesting' permissions in
> a hierarchy.
> 
> I'd rather see 'a bag of permissions' and then ways to arbitrarily group
> them.. be that for 'roles' or 'permissions groups' or whatever.

Agreed.

I think a good first step would be to have a single coherent way of fetching
and checking permissions (ie authorizations) across Koha, and then we can
incrementally improve the creation and organisation of permissions.

Right now, we use "C4::Auth::haspermission($userid,$flagsrequired)" in order to
get our permission data structure, when really we should be doing something
like "Koha::Auth->is_authorized({ flags => $flags, flagsrequired =>
$flagsrequired })"

Bug 31389 takes the $flags data structure and translates it into something that
can be used for the template authorizations. 

Koha::Auth->is_authorized could actually leverage
Koha::Auth::Permissions->get_authz_from_flags(). 

Or something new could be made that fits the different scenarios.

--

Overall, we're not doing anything too complicated with
permissions/authorizations.

Maybe I could have another look at this sometime...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:19:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:19:41 +0000
Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed
 first
In-Reply-To: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30976-70-olgyOr8mCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Jonathan Druart from comment #13)
> Are you editing it manually? There is a RMaint script for that!

I do it manually too (I got stuff ready to copy paste so it's quick),
especially needed since we now have to assess if documentation is needed or not
or maybe. That changes the status and message to write.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:30:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:30:41 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-bJbMCLlNX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #41 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #37)
> This is just top of the iceberg. Looks like this development is far from
> ready.

Yikes... yeah maybe it'll be a while before we get rid of flags...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:32:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:32:05 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-QZDj1a34Sp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #42 from David Cook <dcook at prosentient.com.au> ---
I like a lot of things from these patches, but I reckon they could probably be
broken up into a number of smaller issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:34:26 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
 changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-kA0J6jW3ma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
I reckon we log it in action_logs, but just make it so that it can't be toggled
off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:37:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:37:09 +0000
Subject: [Koha-bugs] [Bug 31718] Change the IF ELSE values in MARC subfields
 structure breadcrumbs to facilitate translation
In-Reply-To: <bug-31718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31718-70-ieVHWkae81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31718

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> After that, I figured it wouldn't apply...

It depends on the conflicts, if they are simple, Lucas will be able to solve
them. Otherwise they will call for a backported patch here if someone needs it.
You might then need to ask your dev colleagues to try to backport it and solve
the conflict if you really need it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:39:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:39:09 +0000
Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to
 Koha staff intranet, SIP, API, etc.
In-Reply-To: <bug-26912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26912-70-873ocge7qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
If I recall correctly, locally we block SIP logins if the user is expired.

So I think this could actually just be handled during an authorization step. 

We just need to add some business logic alongside the account lockout feature I
imagine.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:40:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:40:09 +0000
Subject: [Koha-bugs] [Bug 26912] Expired staff accounts can still log in to
 Koha staff intranet, SIP, API, etc.
In-Reply-To: <bug-26912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26912-70-yO4jcOvY77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #12)
> So I think this could actually just be handled during an authorization step. 

That is, they've proven they are who they say they are during the
authentication step.

But expired users aren't authorized to use Koha, so they must take steps
out-of-band to no longer be expired, so that they can be re-authorized.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:45:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:45:09 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-AW8yFul9hf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> Use Carp::Always to get the stacktrace (`perl -MCarp::Always test.t`).

I meant if should I submit a patch to make diagnosing this easier as
wait_for_ajax is in a lot of places. But maybe it's so rare to fail like that.
So ok for now I'll change from using prove to `perl -MCarp::Always` for running
UI tests in a loop.

Meanwhile, "not such alert" and "unexpected alert open" come so much more often
than hunting for "Cannot wait more for jQuery to be active" would be tedious.

So should ticket this be reopened?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:50:05 +0000
Subject: [Koha-bugs] [Bug 30891] SMS provider shows on staff side even if
 SMS::Send driver is not set to "Email"
In-Reply-To: <bug-30891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30891-70-GkKosveXoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Noted for 21.05, hopefully it will be in 21.11 before the next and last release
of 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:57:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:57:43 +0000
Subject: [Koha-bugs] [Bug 32065] New: Invalid  for some system preferences
Message-ID: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

            Bug ID: 32065
           Summary: Invalid  for some system preferences
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victor at tuxayo.net
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Follow up are needed here after bug 31952 and bug 31886

CI caught this:
(https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/consoleText)

koha_1       | #   Failed test
'/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref
is YAML'
koha_1       | #   at xt/yaml_valid.t line 41.
koha_1       | 
koha_1       | #   Failed test
'/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/local_use.pref
is YAML'
koha_1       | #   at xt/yaml_valid.t line 41.
koha_1       | 
koha_1       | #   Failed test
'/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref
is YAML'
koha_1       | #   at xt/yaml_valid.t line 41.
koha_1       | # Looks like you failed 3 tests of 17.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:57:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:57:56 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid  for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-2xdi3UzxU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31952, 31886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886
[Bug 31886] No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952
[Bug 31952] Sending an empty system preference search breaks layout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:57:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:57:56 +0000
Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref
In-Reply-To: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31886-70-9UjkvOoby2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32065


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065
[Bug 32065] Invalid  for some system preferences
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:57:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:57:56 +0000
Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search
 breaks layout
In-Reply-To: <bug-31952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31952-70-5SDJNipoD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32065


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065
[Bug 32065] Invalid  for some system preferences
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:58:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:58:05 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid  for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-FwcpcULHFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31886, 31952                |
         Depends on|                            |31886, 31952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886
[Bug 31886] No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952
[Bug 31952] Sending an empty system preference search breaks layout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:58:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:58:05 +0000
Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref
In-Reply-To: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31886-70-Kesk9aaeY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32065
         Depends on|32065                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065
[Bug 32065] Invalid  for some system preferences
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:58:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:58:05 +0000
Subject: [Koha-bugs] [Bug 31952] Sending an empty system preference search
 breaks layout
In-Reply-To: <bug-31952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31952-70-u9ov6HQ5es@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31952

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32065
         Depends on|32065                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065
[Bug 32065] Invalid  for some system preferences
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:58:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:58:28 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-ol6WVDbTua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Invalid  for some system    |Invalid YAML for some
                   |preferences                 |system preferences

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 02:59:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 01:59:41 +0000
Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref
In-Reply-To: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31886-70-BLdaaHm1J1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886

--- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Ok, I wasn't sure if a follow-up could be made in the existing tickets: Bug
32065

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:08:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:08:27 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-kkthZXrPIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:08:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:08:33 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-TezCrFyEtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137451|0                           |1
        is obsolete|                            |

--- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142905&action=edit
Bug 30358: Strip leading/trailing whitespace characters from input fields when
cataloguing

This enhancement adds a system preference StripWhitespaceChars which,
when enabled, will strip leading and trailing whitespace characters from
all fields when cataloguing both bibliographic records and authority
records. Whitespace characters that will be stripped are:
- spaces
- newlines
- carriage returns
- tabs

To test:
1. Apply patch and install database updates
2. Go to Administration, system preferences, find the new
StripWhitespaceChars preference. It should be "Don't strip" by default.
Change it to "Strip".
3. Search for a biblio record and edit it. Put some leading or trailing
whitespace characters in input fields and textarea fields and save.
4. Confirm these characters are removed when you save the record.
5. Repeat steps 3 and 4 for authority records.
6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t

Sponsored-by: Educational Services Australia SCIS

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:08:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:08:38 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-xx1xYwNJo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137452|0                           |1
        is obsolete|                            |

--- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142906&action=edit
Bug 30358: (follow-up) Also strip inner newlines

This patch amends the StripWhitespaceChars system preference to also
strip inner newlines (line breaks and carriage returns) when enabled.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:08:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:08:44 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-TQhjYMx65L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137453|0                           |1
        is obsolete|                            |

--- Comment #29 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142907&action=edit
Bug 30358: (follow-up) Inner newlines should be replaced with a space

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:08:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:08:49 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-yFQaeClBiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137454|0                           |1
        is obsolete|                            |

--- Comment #30 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142908&action=edit
Bug 30358: (follow-up) Fixing tests and including for inner newlines

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:08:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:08:55 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-AVnV2yTsla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137455|0                           |1
        is obsolete|                            |

--- Comment #31 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142909&action=edit
Bug 30358: (follow-up) Clarify syspref wording about fields affected

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:09:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:09:02 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-nM5erh8Yku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137456|0                           |1
        is obsolete|                            |

--- Comment #32 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142910&action=edit
Bug 30358: (follow-up) Consider field has multiple subfields of same key

To test:

1) Click the clone subfield button to make multiple subfields with the
same key, i.e. 500$a$a$a
2) Save the record and confirm that the fields contain the correct data
after whitespaces are stripped.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:09:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:09:07 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-Bx01bztHwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137457|0                           |1
        is obsolete|                            |

--- Comment #33 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142911&action=edit
Bug 30358: (follow-up) Put multiple subfields fix on auth side

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:09:14 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-ubSNmX4sJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139110|0                           |1
        is obsolete|                            |

--- Comment #34 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 142912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142912&action=edit
Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests

To test:

Confirm test plan above still works as expected and tests pass in
t/Koha_MetadataRecord.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:30:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:30:01 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-DCEUUDjeEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #43 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #42)
> I like a lot of things from these patches, but I reckon they could probably
> be broken up into a number of smaller issues.

- Refactor C4::Auth::getuserflags() and move to
Koha::Auth::Permissions->get_flags() with unit tests
- Refactor Koha::Auth::Permissions->get_authz_from_flags to build a fully
populated authz hash, and then create
Koha::Auth::Permissions->get_template_authz_from_authz() 
- Refactor C4::Auth::haspermission() (this is actually used more extensively
through Koha than I originally thought...)
- Update Acquisition.pm, Budgets.pm, about.pl, and other users of authorization
data checks outside of the initial AuthZ check on page load...

The goal of the above is to centralize the business logic of
permission/authorization checks in Koha, so we're not repeating complex code
structures throughout the app.

- Finally, move "flags" column into "user_permissions" table (that said, this
could have unexpected consequences for borrower_modifications and
deletedborrowers...)(this also will have consequences with manual SQL and
tests)

The goal of the above is to free us from the bit-packed "flags" integer and
separate sub-permission table, so that it's easier to create and organise
flags/permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:34:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:34:08 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-u8KIAapGXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #44 from David Cook <dcook at prosentient.com.au> ---
Want to work on this since it's fresh in the mind... but better work on OIDC
instead...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:38:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:38:15 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-z4DiI86w9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #99 from David Cook <dcook at prosentient.com.au> ---
Ok. Starting testing now...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:40:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:40:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-niEnyzRiPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #100 from David Cook <dcook at prosentient.com.au> ---
Looks like we're 547 commits behind master... and for some reason "qa" think
the "qa-prev-commit" is 1 commit behind.

Getting a number of failures:

testing 1 commit(s) (applied to 46c299f 'd6 Bug 31378: Rename Auth Provider
to')

Processing files before patches
Configure idp routes=====>| 10 / 10 (100.00%)

Processing files after patches
|========================>| 10 / 10 (100.00%)

 OK     Koha/Auth/Client.pm
 OK     Koha/REST/V1/Auth/Identity/Provider/Domains.pm
 OK     api/v1/swagger/definitions/identity_provider.yaml
 OK     api/v1/swagger/definitions/identity_provider_domain.yaml
 OK     api/v1/swagger/paths/auth.yaml
 OK     installer/data/mysql/atomicupdate/bug_31378.pl
 OK     installer/data/mysql/kohastructure.sql
 FAIL   t/db_dependent/Koha/REST/Plugin/Auth/IdP.t
   FAIL   file permissions
                File must have the exec flag
   FAIL   forbidden patterns
                forbidden pattern: trailing space char (line 55)
                forbidden pattern: trailing space char (line 123)

 FAIL   t/db_dependent/api/v1/idp.t
   FAIL   file permissions
                File must have the exec flag
   FAIL   forbidden patterns
                forbidden pattern: trailing space char (line 195)
                forbidden pattern: trailing space char (line 258)
                forbidden pattern: trailing space char (line 301)
                forbidden pattern: Use of Data::Printer (line 310)
                forbidden pattern: Use of Data::Printer, should only be used
for devlopment purpose (line 310)
   FAIL   spelling
                 wiht ==> with
                 wihtout ==> without
   FAIL   valid
                Can't locate Crypt/OpenSSL/RSA.pm in @INC (you may need to
install the Crypt::OpenSSL::RSA module) (@INC contains: /kohadevbox/koha
/kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/
perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32
/usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base
/usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32
/usr/local/lib/site_perl)

 FAIL   t/lib/IdP/ExternalIdP.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666


Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - c649ebc111

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:42:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:42:11 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-GYobYo8d2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #101 from David Cook <dcook at prosentient.com.au> ---
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
Auto-merging installer/data/mysql/mandatory/userpermissions.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/mandatory/userpermissions.sql
error: could not apply b466baa415... Bug 31378: Add
manage_authentication_providers permission
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase
--abort".
Could not apply b466baa415... Bug 31378: Add manage_authentication_providers
permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:44:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:44:20 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-8BwKRNNrd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #102 from David Cook <dcook at prosentient.com.au> ---
Started trying to fix the merge conflicts but looks like there's a fair number. 

This is something that should've been done before moving it to "Needs Signoff"
I reckon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 03:52:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 02:52:08 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-3ebEz37lNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #103 from David Cook <dcook at prosentient.com.au> ---
I'll still keep testing to see what I can see though...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 05:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 04:41:24 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-PZgmwdwTpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 05:41:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 04:41:32 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-uEZEr304KJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142904|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 142913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142913&action=edit
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 06:12:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 05:12:46 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-SrqtEfTtqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Failed QA

--- Comment #104 from David Cook <dcook at prosentient.com.au> ---
Test plan 1:
1. apt install libmojolicious-plugin-oauth2-perl
2. koha-upgrade-schema kohadev
3. restart_all

<Note that Nick and David's patches from Bugzilla are still needed for Gitlab
branch...>

Test plan 2:
1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl
2. Click on "Identity providers"
3. Click "New identity provider"
(#NOTE: UI formatting looks OK on Koha 22.06, but I wonder what it'll look like
on Koha 22.11...)
(#FIXME: "Add default OAuth..." buttons still don't work if you make any
changes in the text box before pressing the button.)
(#FIXME: There's still not enough help text on the UI to explain how to fill it
all in.)
(#NOTE: It probably makes more sense to default to "OIDC" than "OAuth" since
the former is more common with common identity providers)
4. Enter relevant details and click "Submit"
(#FIXME: "Code" shouldn't be able to contain non-alphanumeric characters)
(#FIXME: Putting in garbage values causes the page to return to
/cgi-bin/koha/admin/identity_providers.pl with no error messages)
(#FIXME: There needs to be a warning that integration won't work until after an
application restart...)
5. Click on "Manage Domains"
(#FIXME: It's not clear what "domains" means in this context. It should say
something like "Identity provider email domains")
6. Click "Edit" on the default domains
(#FIXME: The "Default library" and "Default category" are initially set to
empty, but you can't set them to empty in the "Edit" interface)
(#FIXME: The breadcrumb says "Domains for" instead of "Domains for Test")

7. koha-plack --restart kohadev

8. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that doesn't exist in Koha
(#FIXME: When authentication fails, the end user sees the following message:
There was an error authenticating to external identity provider

Can't call method "auto_register" on an undefined value at
/kohadevbox/koha/Koha/REST/Plugin/Auth/IdP.pm line 66.
)

9. Change "Identity provider" default domain to "Auto register"
10. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that doesn't exist in Koha
(#FIXME: When authentication fails, the end user sees the following message:
There was an error authenticating to external identity provider

Can't call method "auto_register" on an undefined value at
/kohadevbox/koha/Koha/REST/Plugin/Auth/IdP.pm line 66.
)
(#FIXME: The auto register feature doens't work. It needs to be fixed.)

11. Create a Koha user to match your IdP user
12. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that does exist in Koha
13. Login succeeds

14. Kill IdP session and logout of Koha

15. Change default domain to "Update on login"

16. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that does exist in Koha
(#FIXME: The update on login feature doesn't work. It needs to be fixed.)

17. Change default domain to "Allow staff" logins
18. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that does exist in Koha
19. Note that you get a normal "Error: You do not have permission to access
this page" message. That's good.

20. Add "catalogue" permission to the Koha user
21. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that does exist in Koha
22. Login succeeds

23. In an Incognito window or different browser, go to http://localhost:8081,
and try logging in with a user that doesn't exist in Koha
(#FIXME: When authentication fails, the end user sees the following message:
Error: Session timed out.
Please log in again
There was an error authenticating to external identity provider

Exception 'Koha::Exceptions::Auth::Unauthorized' thrown 'External auth user
cannot access resource' with code => 401
)

24. Add a new domain for that matches the email domain of your IdP/Koha user.
25. Mark "Allow opac" and "Allow staff" as "No"

26. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that does exist in Koha
(#FIXME: Koha login happens even though the specific domain says it shouldn't
be allowed)
27. In an Incognito window or different browser, go to http://localhost:8081,
and try logging in with a user that does exist in Koha
(#FIXME: Koha login happens even though the specific domain says it shouldn't
be allowed)

--

I imagine that there are other problems, but I think that's a fairly thorough
analysis of the core functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 06:19:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 05:19:12 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-SDqXEJ5JBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #105 from David Cook <dcook at prosentient.com.au> ---
I appreciate the replacement of "Authentication provider" being changed to
"Identity provider" and "tranverse_hash" being changed to "traverse_hash", but
it looks like every other issue I described last time is still present in the
Gitlab version...

I have to fail this again, because several of the features don't work. 

Before I test this again, I'd like someone to confirm that they've looked at my
"FIXME" comments, and fixed them (or at least provide a reason for not fixing
them).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 06:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 05:21:37 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-ENlDxw3mMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Kyle M Hall from comment #3)
> * I can only find my logged in user when searching for users to add to an
> agreement ( http://192.168.1.20:8081/cgi-bin/koha/erm/agreements/add )

(In reply to Jonathan Field from comment #4)
> On Point 1 Kyle, when you add users to an Agreement you ONLY see users who
> have the ERM permission, that is by design so that you do not retrieve many
> regular patrons. Is that what you are seeing or something else?

Works as expected when having multiple users with ERM permission or
superlibrarians.

Also tested addition multiple users and custom roles via the AV.
And basic creation of license, package, title

Any guidelines to test this? Beside from filling every field and being creating
to try to find edge cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 06:25:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 05:25:16 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-DEolFWq3zh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #106 from David Cook <dcook at prosentient.com.au> ---
Overall, I think that we're on the right track, and I'm so excited for this
feature. 

Thanks for all the work, Theke.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 06:29:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 05:29:19 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-9Wl43TXsRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Thanks, David :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 06:40:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 05:40:50 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-p9EyYEXgtg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
FYI on October 12th I updated our OAI-PMH servers to honour OpacSuppression and
OpacHiddenItems, so we've been running it in production for nearly a month. 

So far so good.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 08:13:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 07:13:24 +0000
Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field
 ci_raw in field_config.yaml
In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31695-70-7lTKHMqYv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to David Nind from comment #3)
> I'm not sure how to do step 2 - happy to test if you can show how to do that.

I mean in Administration > Search engine configuration (Elasticsearch) 
In tab Search fields, choose a field and change its type to "Std. Number".
For example "identifier-standard" is already of this type.
In tab Authorities use this search field on some MARC field.

Rebuild authorities index.

And create of edit an authority with this MARC field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 08:33:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 07:33:01 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-QCQVr30Nb1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #35 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Note that line feed in title or author breaks items search because of Ajax via
JSON

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 08:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 07:56:52 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-yzqYRwZNlM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 08:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 07:56:52 +0000
Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25551-70-4sU2uTgjMs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
Bug 25551 depends on bug 32010, which changed state.

Bug 32010 Summary: selenium/authentication_2fa.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 08:56:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 07:56:59 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-xnfIJ1NubD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:04:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:04:52 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-WZmoLKknBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
In my understanding there is a missing wait_for_ajax call at after we click

The test:
279         $driver->find_element('//*[@id="pin_code"]')->clear;
280         $driver->find_element('//*[@id="pin_code"]')->send_keys($pin_code);
281         $driver->find_element('//*[@id="register-2FA"]')->click;
282         is( $driver->get_alert_text,
283             "Two-factor authentication correctly configured. You will be
redirected to the login screen."
284         );
285         $driver->accept_alert;

But wait_for_ajax is waiting for the return of success, and the alert is there.
The code:
250                 $.ajax({
251                     data: data,
252                     type: 'POST',
253                     url:
'/api/v1/auth/two-factor/registration/verification',
254                     success: function (data) {
255                         alert(_("Two-factor authentication correctly
configured. You will be redirected to the login screen."));
256                         window.location = "/cgi-bin/koha/mainpage.pl";
257                     },
258                     error: function (data) {
259                         const error = data.responseJSON.error;
260                         if ( error == 'Invalid pin' ) {
261                             $("#errors").html(_("Invalid PIN
code")).show();
262                         } else {
263                             alert(error);
264                         }
265                     },
266                 });

So either we remove the test, or adjust the code to make the alert appears
after the ajax call is done (which may make the code not very nice).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:11:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:11:54 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-bOnY6xwUNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:11:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:11:58 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-IaZ1IVlO3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 142914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142914&action=edit
Bug 32010: Make sure the alert will be displayed after the ajax call

There is a missing wait_for_ajax call at after we click but wait_for_ajax
is waiting for the return of success, and the alert is there.

22:01:57 koha_1       | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in
Selenium::Remote::Driver::catch {...}
22:01:57 koha_1       |         /usr/share/perl5/Selenium/Remote/Driver.pm:361
in Try::Tiny::try
22:01:57 koha_1       |         (eval 541):1 in
Selenium::Remote::Driver::__ANON__
22:01:57 koha_1       |         (eval 543):2 in
Selenium::Remote::Driver::__ANON__
22:01:57 koha_1       |         /usr/share/perl5/Selenium/Remote/Driver.pm:654
in Selenium::Remote::Driver::_execute_command
22:01:57 koha_1       |        
t/db_dependent/selenium/authentication_2fa.t:282 in
Selenium::Remote::Driver::get_alert_text
22:01:57 koha_1       |         /usr/share/perl/5.32/Test/Builder.pm:334 in
main::__ANON__
22:01:57 koha_1       |         /usr/share/perl/5.32/Test/Builder.pm:334 in
(eval)
22:01:57 koha_1       |         /usr/share/perl/5.32/Test/More.pm:809 in
Test::Builder::subtest
22:01:57 koha_1       |        
t/db_dependent/selenium/authentication_2fa.t:291 in Test::More::subtest
22:01:57 koha_1       |
22:01:57 koha_1       |     # Looks like you planned 7 tests but ran 4.
22:01:57 koha_1       |
22:01:57 koha_1       | #   Failed test 'Enforce 2FA setup on first login'
22:01:57 koha_1       | #   at t/db_dependent/selenium/authentication_2fa.t
line 291.
22:01:57 koha_1       | Error while executing command: no such alert at
/usr/share/perl5/Selenium/Remote/Driver.pm line 411.
22:01:57 koha_1       |  at /usr/share/perl5/Selenium/Remote/Driver.pm line
356.
22:01:57 koha_1       | # Looks like your test exited with 255 just after 4.
22:01:57 koha_1       | [20:59:37] t/db_dependent/selenium/authentication_2fa.t

Test plan:
Confirm that the test pass (execute it in a loop, hundreds of times)
Confirm that the behaviour of 2FA "enforced" (see bug 30588) is still
working as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:17:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:17:29 +0000
Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack
In-Reply-To: <bug-31729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31729-70-xDSZ0Qvppt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729

pierre.genty at biblibre.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre.genty at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:29:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:29:39 +0000
Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out
In-Reply-To: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30403-70-WTZPw7qpn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139675|0                           |1
        is obsolete|                            |

--- Comment #10 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 142915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142915&action=edit
Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout

We currently have syspref UpdateNotForLoanStatusOnCheckin which updates
notforloan status when item is checked in. We should also have
same kind of syspref for check outs. This would be usefull if for
example library has item in exhibition with status
"In exhibition, available for loan". When patron check outs the
item notforloan status can be reseted back to 0, informing staff
that the item is back on circulation.

This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout.

To test:
1. Set items notforloan status as e.g -1.
2. Check out item for a patron.
=> Note that items status doesn't change.
3. Apply patch and update database if needed.
4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout.
5. Check item in and out again for a patron.
=> Note that items status is changed as 0.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:29:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:29:47 +0000
Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out
In-Reply-To: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30403-70-61IE7uBXuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:48:36 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-Wb7mb30sjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 142916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142916&action=edit
Bug 29672: Fix test t/db_dependent/Koha/Plugins/Plugins.t

Table plugin_data was not always cleared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:50:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:50:03 +0000
Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
In-Reply-To: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28172-70-su3tO3Wd0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119870|0                           |1
        is obsolete|                            |

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 142917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142917&action=edit
Bug 28172: [DO NOT PUSH] Test script for GetPlugins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:50:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:50:09 +0000
Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
In-Reply-To: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28172-70-LmMEtWWo2k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119871|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 142918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142918&action=edit
Bug 28172: Optimize Koha::Plugins::GetPlugins

Instead of doing one SQL query for retrieving a list of plugin classes
(filtered or not by a method name) + one SQL query for each loaded
plugin (to look up the 'enabled' status), we can do a single SQL query,
fetching only enabled plugins, and do the method check using `can`.

It allows to use the Module::Load::Conditional cache when requesting
only enabled modules, which gives a great performance boost

Also, call get_metadata only if needed

Test plan:
1. Make sure you have some plugins enabled
2. Apply the 1st patch ("Test script for GetPlugins")
3. Run the test script several times, copy each result into a file A
4. Apply the other patch(es)
5. Run the test script several times, copy each result into another
   file B
6. Compare the results. Times in file B should be smaller than in file A

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:50:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:50:28 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-wqIqLfuFS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 09:57:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 08:57:08 +0000
Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
In-Reply-To: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28172-70-H183fQDwK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Rebased on master, but now when running the test script I get a really bad time
for "1000 calls to GetPlugins with all = 1".

As bug 29672 changes Koha::Plugins::call so that it does not use GetPlugins,
I'm not sure if this patch is still relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:29:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:29:20 +0000
Subject: [Koha-bugs] [Bug 32033] Cannot rebuild zebra
In-Reply-To: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32033-70-mhKg00tW2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32033

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
That's ok for me, glad it could be resolved. When I tagged you I was not sure
if it was related to the recent work on 880 indexing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:35:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:35:18 +0000
Subject: [Koha-bugs] [Bug 32066] New: User can get stuck on login screen
Message-ID: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

            Bug ID: 32066
           Summary: User can get stuck on login screen
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org
        Depends on: 30588

To recreate:
1. Set the syspref TwoFactorAuthentication (enforce or enabled)
2. Configure 2FA for a patron
3. Logout
4. Authenticate but don't enter the 2FA code
5. Switch off the syspref (disabled)
=> Patron is stuck on the login screen (actually can access 

Same can happens when the patron needs to setup 2FA.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
[Bug 30588] Add the option to require 2FA setup on first staff login
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:35:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:35:18 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-tgPKVq4fLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32066


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066
[Bug 32066] User can get stuck on login screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:35:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:35:40 +0000
Subject: [Koha-bugs] [Bug 32066] User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-YdgK9TVkWj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:35:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:35:59 +0000
Subject: [Koha-bugs] [Bug 32066] User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-NNSFf7ll1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This change should fix the problem.

diff --git a/C4/Auth.pm b/C4/Auth.pm
index b6933e4cc60..8bd13e88e1f 100644
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -1784,11 +1784,13 @@ sub check_cookie_auth {
                     $session->param('desk_id'),     
$session->param('desk_name'),
                     $session->param('register_id'), 
$session->param('register_name')
                 );
-                return ( "additional-auth-needed", $session )
-                    if $session->param('waiting-for-2FA');
+                if ( C4::Context->preference('TwoFactorAuthentication') ne
'disabled' ) {
+                    return ( "additional-auth-needed", $session )
+                        if $session->param('waiting-for-2FA');
.
-                return ( "setup-additional-auth-needed", $session )
-                    if $session->param('waiting-for-2FA-setup');
+                    return ( "setup-additional-auth-needed", $session )
+                        if $session->param('waiting-for-2FA-setup');
+                }
.
                 return ( "ok", $session );
             } else {

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:36:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:36:25 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-O5AgskquO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:37:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:37:16 +0000
Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values
In-Reply-To: <bug-26368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26368-70-zYJ2X5lUKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |Needs documenting
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:42:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:42:45 +0000
Subject: [Koha-bugs] [Bug 30277] Make fetching ILL data from the API more
 efficient
In-Reply-To: <bug-30277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30277-70-7shXcYwvcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30277

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22440

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:42:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:42:45 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
 other endpoints
In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22440-70-R65BUT4l59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30277

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:42:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:42:59 +0000
Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider
 custom statuses
In-Reply-To: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28641-70-ACFerGwPIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22440

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:42:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:42:59 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
 other endpoints
In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22440-70-CvQwM4axtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28641

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:43:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:43:37 +0000
Subject: [Koha-bugs] [Bug 22714] ILL table population call might benefit
 from being inside the datatable
In-Reply-To: <bug-22714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22714-70-vPnbVdtToz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22714

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22440
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 10:43:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 09:43:37 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
 other endpoints
In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22440-70-Lbi8oRoCOJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22714

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:06:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:06:57 +0000
Subject: [Koha-bugs] [Bug 32067] New: [OMNIBUS] Consistent classes for
 submit and/or primary buttons
Message-ID: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

            Bug ID: 32067
           Summary: [OMNIBUS] Consistent classes for submit and/or primary
                    buttons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Koha has long had a style applied broadly to input tags of type input, button,
and reset. We have not been consistently moving to use the Bootstrap
"btn-primary" class. Now that the staff interface has a more specific style for
this kind of button it would be good to move to using the "btn-primary" class
everywhere and eventually phase out the style applied to all kinds of input
buttons.

Before:

<input type="submit" value="Search" />

After:

<input type="submit" class="btn btn-primary" value="Search" />

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:09:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:09:25 +0000
Subject: [Koha-bugs] [Bug 32068] New: Consistent classes for primary
 buttons: Administration
Message-ID: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

            Bug ID: 32068
           Summary: Consistent classes for primary buttons: Administration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

This patch will update buttons in the Administration area so that buttons which
are currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:09:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:09:25 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-L7vNMbVZvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32068


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068
[Bug 32068] Consistent classes for primary buttons: Administration
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:16:55 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-pHytRO5Y5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:17:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:17:00 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-L86jXK4uWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142844|0                           |1
        is obsolete|                            |
 Attachment #142845|0                           |1
        is obsolete|                            |
 Attachment #142846|0                           |1
        is obsolete|                            |
 Attachment #142916|0                           |1
        is obsolete|                            |

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142919&action=edit
Bug 29672: [DO NOT PUSH] Test script

Run test-plugins-call.pl without arguments with and without the patches,
with some plugins enabled. Make sure to run
misc/devel/install_plugins.pl before

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:17:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:17:30 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-ndRxJDdIAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142920&action=edit
Bug 29672: Increase performance of Koha::Plugins->call

Make use of Koha::Cache::Memory::Lite to avoid hitting the database and
creating plugins object for every call to Koha::Plugins->call

Test plan:
1. Make sure plugins still work by executing
   `prove t/db_dependent/Koha/Plugins/Plugins.t`
2. Run the test script provided in the following patch to see how it
   affects performances

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:17:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:17:35 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-0FQPBxVoHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142921&action=edit
Bug 29672: Clear cache of enabled plugins when a plugin's state change

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:17:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:17:40 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-5kbfNwtYLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142922&action=edit
Bug 29672: Fix test t/db_dependent/Koha/Plugins/Plugins.t

Table plugin_data was not always cleared

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:17:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:17:45 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-gsY13tD6WO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142923&action=edit
Bug 29672: (QA followup) Add POD

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:31:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:31:02 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-27efy7D9Ky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:31:07 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-PKxVjpwLWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142924&action=edit
Bug 32068: Consistent classes for primary buttons: Administration

This patch makes changes the button markup in Administration templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Administration to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:36:52 +0000
Subject: [Koha-bugs] [Bug 32069] New: Make submit button yellow on "create
 manual invoice"
Message-ID: <bug-32069-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32069

            Bug ID: 32069
           Summary: Make submit button yellow on "create manual invoice"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
            Blocks: 31947

The other accounting tabs have yellow buttons, but "Create manual invoice" does
not.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947
[Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's
missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:36:52 +0000
Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main
 action button where it's missing
In-Reply-To: <bug-31947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31947-70-3fWCgKXrRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32069


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32069
[Bug 32069] Make submit button yellow on "create manual invoice"
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:43:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:43:28 +0000
Subject: [Koha-bugs] [Bug 32070] New: Consistent classes for primary
 buttons: Acquisitions
Message-ID: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

            Bug ID: 32070
           Summary: Consistent classes for primary buttons: Acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in the Acquisitions area so that buttons which
are currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:43:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:43:28 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-hOgUwZJ2G7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32070


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070
[Bug 32070] Consistent classes for primary buttons: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:52:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:52:27 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-0XBYGACECH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:52:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:52:31 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-hbB5jXiW9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142925&action=edit
Bug 32070: Consistent classes for primary buttons: Acquisitions

This patch makes changes the button markup in Acquisitions templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Acquisitions to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:02 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-DG7aqpPF9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:08 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-Lhqd9WMEPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142871|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142926&action=edit
Bug 31713: Add FEE_SUMMARY print slip link

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:15 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-rWcrlIlK2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142872|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142927&action=edit
Bug 31713: Add FEE_SUMMARY slip template

This patch adds the new FEE_SUMMARY print slip notice template to the
database.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:21 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-QsIxMStias@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142873|0                           |1
        is obsolete|                            |

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142928&action=edit
Bug 31713: (QA follow-up) Add current date to slip

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
[EDIT] Reverting the KohaDates.now changes. We can simply use [% today %].
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:29 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-WJSwgyzPLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142874|0                           |1
        is obsolete|                            |

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142929&action=edit
Bug 31713: (follow-up) Fix terminology

This patch fixes the terminology as proposed.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:37 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-cP5mq71JFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142876|0                           |1
        is obsolete|                            |

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142930&action=edit
Bug 31713: (follow-up) Display print option for any outstanding

Prior to this patch we only allowed printing if the balance was owed to
the library.. This patch exposes the option when the patron is owed too.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 12:53:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 11:53:44 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-xws6wjhKU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142931&action=edit
Bug 31713: (QA follow-up) Make credits positive

* This makes amount and amountoutstanding for credits positive
* Adapts the total line to read credits instead of due when the
  balance is >0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:05:13 +0000
Subject: [Koha-bugs] [Bug 32071] New: Consistent classes for primary
 buttons: Catalog
Message-ID: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

            Bug ID: 32071
           Summary: Consistent classes for primary buttons: Catalog
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in catalog templates so that buttons which are
currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:05:13 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-c6WlJdMf3j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32071


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071
[Bug 32071] Consistent classes for primary buttons: Catalog
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:06:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:06:16 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-Noo1O1Ohc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Very low risk of side effects, dear RM, please consider :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:09:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:09:21 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-X4RH5j56W7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142616|0                           |1
        is obsolete|                            |

--- Comment #216 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142932&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:09:30 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-nmfISLSuIP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142617|0                           |1
        is obsolete|                            |

--- Comment #217 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142933&action=edit
Bug 31028: DBIC Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:09:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:09:40 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ELMkkuEwep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142618|0                           |1
        is obsolete|                            |

--- Comment #218 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142934&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:09:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:09:47 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-hM16NOO6eb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142619|0                           |1
        is obsolete|                            |

--- Comment #219 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142935&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:09:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:09:55 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-90m4zbihH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142620|0                           |1
        is obsolete|                            |

--- Comment #220 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142936&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:02 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-3YZOQoc74J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142621|0                           |1
        is obsolete|                            |

--- Comment #221 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142937&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:10 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-bm1A7pCTiz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142622|0                           |1
        is obsolete|                            |

--- Comment #222 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142938&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:27 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-p0Re9jKDrM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142623|0                           |1
        is obsolete|                            |

--- Comment #223 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142939&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:35 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ilppmqWlLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142624|0                           |1
        is obsolete|                            |

--- Comment #224 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142940&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:42 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-AOSgUcyV9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142625|0                           |1
        is obsolete|                            |

--- Comment #225 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142941&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional catalogeur notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CataloguerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CataloguerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:50 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-dbM6KkksaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142626|0                           |1
        is obsolete|                            |

--- Comment #226 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142942&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:10:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:10:57 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-95WvsOj4mq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142627|0                           |1
        is obsolete|                            |

--- Comment #227 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142943&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:11:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:11:04 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-RPoxi6KNpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #228 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142944&action=edit
Bug 31028: Improve display-ticket modal form display

This patch improves the display of the concern details modal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:11:11 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-lhXHYxeIEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #229 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142945&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:11:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:11:19 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-CMHcYDUsyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #230 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142946&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:11:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:11:27 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-pgdjE3Doxr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #231 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142947&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:11:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:11:34 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-kWoOthXhCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #232 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142948&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:11:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:11:42 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-JG3iPSSFs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #233 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142949&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:14:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:14:06 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-0mI83t9Uh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:14:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:14:09 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-2Sd72Okcpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142950&action=edit
Bug 32071: Consistent classes for primary buttons: Catalog

This patch makes changes the button markup in Catalog
templates -- including the Cart -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view pages the catalog to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:15:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:15:02 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-pROw812xHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #234 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thankyou so much for your thorough testing and feedback again David.. it's
great to see this level of detail.

My apologies for some bits that clearly weren't working as expected.. there was
a rebase issue that had crept in so some things clearly just weren't working a
all :(.

I believe I've resolved all those issues now and have taken into account all of
your feedback on top.

I've also tried to fold some of your excellent test plan into test plans
attached to each commit.

The permission you were looking for and wasn't at all documented is
'edit_catalogue'.. I took the approach that cataloguers should be dealing with
concerns raised so adopted the pre-existing permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:22:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:22:01 +0000
Subject: [Koha-bugs] [Bug 32072] New: Consistent classes for primary
 buttons: Cataloging
Message-ID: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

            Bug ID: 32072
           Summary: Consistent classes for primary buttons: Cataloging
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in cataloging templates so that buttons which
are currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:22:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:22:01 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-JUcXcr2K7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32072


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072
[Bug 32072] Consistent classes for primary buttons: Cataloging
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:32:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:32:12 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-ONx4jOvC9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co
                   |ity.org                     |m

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please don't forget to fill in the Assignee!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:32:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:32:43 +0000
Subject: [Koha-bugs] [Bug 32037] Circulation module in action logs has bad
 links for deleted items
In-Reply-To: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32037-70-r1fHYikZg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Nick, Nick, Nick... Assignee! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:33:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:33:10 +0000
Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when
 only one result
In-Reply-To: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31967-70-BgmObnRTvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|fridolin.somers at biblibre.co |testopia at bugs.koha-communit
                   |m                           |y.org
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:33:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:33:19 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-c0SBUEt8zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:33:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:33:23 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-YqweMdeCg8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142951&action=edit
Bug 32072: Consistent classes for primary buttons: Cataloging

This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:38:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:38:20 +0000
Subject: [Koha-bugs] [Bug 32073] New: Consistent classes for primary
 buttons: Circulation
Message-ID: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

            Bug ID: 32073
           Summary: Consistent classes for primary buttons: Circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in circulation templates so that buttons which
are currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:38:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:38:20 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-30F7y2P0hB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32073


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073
[Bug 32073] Consistent classes for primary buttons: Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:38:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:38:47 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-a9xDgLcaLR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:43:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:43:31 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-nnreKe2Dm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #11 from Jonathan Field <jonathan.field at ptfs-europe.com> ---
We're in the process of producing some documentation for this in order that our
team can add this to the Koha manual. For now you can find it in this document
-
https://docs.google.com/document/d/1W23B1M9G8uvd5mN3Hlpld7uYLTBXN_7dNBz5WY8ZfiA/edit?usp=sharing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:46:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:46:40 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-phrwwwfCrt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:46:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:46:44 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-GLvrLYj7vs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 142952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142952&action=edit
Bug 32073: Consistent classes for primary buttons: Circulation

This patch makes changes the button markup in Circulation templates --
including offline circulation -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Circulation to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:59:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:59:20 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-XBc7Hr1Hpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 13:59:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 12:59:25 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-IV1bM9eybg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142924|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142953&action=edit
Bug 32068: Consistent classes for primary buttons: Administration

This patch makes changes the button markup in Administration templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Administration to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:04:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:04:34 +0000
Subject: [Koha-bugs] [Bug 32074] New: Edit vendor has a floating toolbar,
 but still an additional save button at the bottom
Message-ID: <bug-32074-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074

            Bug ID: 32074
           Summary: Edit vendor has a floating toolbar, but still an
                    additional save button at the bottom
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

That's a small inconsistency with other forms having the floating toolbar. On
the edit vendor form, there is also another save button at the bottom.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:05:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:05:49 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-OZHeNUVtLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:08:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:08:33 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-o3S9JpMwal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:08:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:08:38 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-64IfiSEEz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142925|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142954&action=edit
Bug 32070: Consistent classes for primary buttons: Acquisitions

This patch makes changes the button markup in Acquisitions templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Acquisitions to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:10:55 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-HLkblQm0zN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The test isn't failing for me on master. Is this maybe fixed already?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:11:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:11:18 +0000
Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons
In-Reply-To: <bug-22632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22632-70-NAnDmGmkvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Sharon Dugdale <sharon.dugdale at cumbria.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sharon.dugdale at cumbria.gov.
                   |                            |uk

--- Comment #29 from Sharon Dugdale <sharon.dugdale at cumbria.gov.uk> ---
Hi
This has come up as an issue with Cumbria Libraries and the ability to see the
previous information on a merged patron record in the modification logs would
be really useful. I am told that the information is retained in the deleted
borrowers table however that would require a report to access the information
and our frontline staff would find it very useful to be able to see these
deleted personal details from the merged account. We get alot of duplicate
memberships from patrons re-joining online, sometimes with more uptodate
information than their existing record has and it would be useful for staff to
have this information if a patron queries the merge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:13:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:13:22 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-3LRqasioMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:13:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:13:28 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-EI7nStBLMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142413|0                           |1
        is obsolete|                            |
 Attachment #142414|0                           |1
        is obsolete|                            |
 Attachment #142415|0                           |1
        is obsolete|                            |
 Attachment #142416|0                           |1
        is obsolete|                            |
 Attachment #142417|0                           |1
        is obsolete|                            |
 Attachment #142418|0                           |1
        is obsolete|                            |
 Attachment #142419|0                           |1
        is obsolete|                            |
 Attachment #142420|0                           |1
        is obsolete|                            |
 Attachment #142421|0                           |1
        is obsolete|                            |
 Attachment #142422|0                           |1
        is obsolete|                            |
 Attachment #142423|0                           |1
        is obsolete|                            |
 Attachment #142424|0                           |1
        is obsolete|                            |
 Attachment #142425|0                           |1
        is obsolete|                            |
 Attachment #142426|0                           |1
        is obsolete|                            |
 Attachment #142427|0                           |1
        is obsolete|                            |
 Attachment #142428|0                           |1
        is obsolete|                            |
 Attachment #142429|0                           |1
        is obsolete|                            |
 Attachment #142430|0                           |1
        is obsolete|                            |
 Attachment #142827|0                           |1
        is obsolete|                            |

--- Comment #180 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142955&action=edit
Bug 24860: Add reserves.item_group_it

This feature builds upon bug 24857 and allows placing holds that target a
specific item group of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and item groups, with each item being assigned to
an item group
6) Place a hold for a patron
7) Note the new selector to choose an item group in addition to record and item
level holds
8) Place an item group level hold
9) Check in an item from the record that is not part of that item group
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that item group
12) Note the hold is trapped for that item
13) Place an item group level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that item group
16) Check out all the items of that item group to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:13:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:13:54 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-WPrnsFoUsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #181 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142956&action=edit
Bug 24860: Add new syspref EnableItemGroupHolds

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:00 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-cXO6EyJPH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #182 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142957&action=edit
Bug 24860: Implement reserves.item_group_id

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:06 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-CvsHHRuLDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #183 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142958&action=edit
Bug 24860: Add ability to select an item group when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:12 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-FrBohQqUGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #184 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142959&action=edit
Bug 24860: Add ability to select an item group when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:18 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-LNrLyYUnmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #185 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142960&action=edit
Bug 24860: Skip non-matching item group holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:24 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-3hT3pUmSCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #186 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142961&action=edit
Bug 24860: Skip non-matching item group holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:33 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-uZk1oavdND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #187 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142962&action=edit
Bug 24860: Add hold's item group to holds table on circulation.pl and
moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:40 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-ZYHZqAVhWn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #188 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142963&action=edit
Bug 24860: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:46 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-6HzXy96wwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #189 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142964&action=edit
Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:51 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-mzHwfHM2sj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #190 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142965&action=edit
Bug 24860: (QA follow-up) Terminology and translation fixes

* Fixes a single to a double underscore for translation in holds.js
* Fixes item_group to item group in API description
* Fixes volume hold to item group hold in syspref db descrpitions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:14:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:14:57 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-keQraJYQLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #191 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142966&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:04 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-rDahw0rufk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #192 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142967&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:11 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-9hNQtfykhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #193 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142968&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:17 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-VcLv8mDAw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #194 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142969&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover
Koha::Holds::forced_hold_level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:24 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-chIWlK8q0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #195 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142970&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:31 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-lmbaDuYfkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #196 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142971&action=edit
Bug 24860: (QA follow-up) Fix typo in holds queue viewer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:39 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-FNfKkmPavG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #197 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142972&action=edit
Bug 24860: (QA follow-up) Show group holds on Holds to pull

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:45 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-tZc7hfMnzL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #198 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142973&action=edit
Bug 24860: (QA follow-up): Don't assume item group is set for all items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:51 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-ZkFgzNoN36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #199 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142974&action=edit
Bug 24860: (QA follow-up) Ask for any available item of matching group

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:15:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:15:58 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-Ihrchd8YYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #200 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 142975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142975&action=edit
Bug 24860: (QA follow-up) Don't show holds where a matching item group item is
not available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:17:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:17:42 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-1pf2qAMtTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:17:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:17:58 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-blSIYP83h5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:18:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:18:03 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-DJeu42EniA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142913|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142976&action=edit
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:19:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:19:43 +0000
Subject: [Koha-bugs] [Bug 32075] New: Staff mainpage crashed on Can't use an
 undefined value as a HASH reference
Message-ID: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075

            Bug ID: 32075
           Summary: Staff mainpage crashed on Can't use an undefined value
                    as a HASH reference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Found under 21.11
Can't use an undefined value as a HASH reference at /usr/share/koha/mainpage.pl
line 87
Log shows:
[02/Nov/2022:08:36:51 +0100] "POST /intranet/mainpage.pl HTTP/1.1" 500 41624 

Line 87:
    my $local_pendingsuggestions_count = $pendingsuggestions->search({
'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();

Note: In master this is line 88.

Apparently there is no user context. So no branch key. But when you get here,
you came thru Auth.pm. So we should expect one?

Could not find a way to reproduce this one yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:22:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:22:04 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-vtZ8Q6ZUGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #201 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #179)
> I am sorry Kyle, the latest follow-up fixed the error, but the new text in
> pendingreserves never displays. I have tried to figure out what's going on
> there, but got stuck on this line:
> 
> +    if ( $res_info->item_group ) {
> +       $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> $_->item_group && ( $_->item_group->id == $res_info->item_group_id )  ?
> $_->barcode : () } @$items ];
> +    }
> +
> 
> I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold
> group hold.

Yes, the problem here is that there are not items with the selected hold group
currently available. We have two choices where, either we hide that hold until
there is an item from that item group available, or we just display an "Any
item from item group $item_group" message.

"Bug 24860: (QA follow-up) Don't show holds where a matching item group item is
not available" does the former, "Bug 24860: (QA follow-up) Ask for any
available item of matching group" does the latter. Please choose which behavior
you would prefer and deprecate the other patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:26:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:26:50 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-PR5R2Dyw6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #202 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Kyle M Hall from comment #201)
> (In reply to Katrin Fischer from comment #179)
> > I am sorry Kyle, the latest follow-up fixed the error, but the new text in
> > pendingreserves never displays. I have tried to figure out what's going on
> > there, but got stuck on this line:
> > 
> > +    if ( $res_info->item_group ) {
> > +       $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> > $_->item_group && ( $_->item_group->id == $res_info->item_group_id )  ?
> > $_->barcode : () } @$items ];
> > +    }
> > +
> > 
> > I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold
> > group hold.
> 
> Yes, the problem here is that there are not items with the selected hold
> group currently available. We have two choices where, either we hide that
> hold until there is an item from that item group available, or we just
> display an "Any item from item group $item_group" message.
> 
> "Bug 24860: (QA follow-up) Don't show holds where a matching item group item
> is not available" does the former, "Bug 24860: (QA follow-up) Ask for any
> available item of matching group" does the latter. Please choose which
> behavior you would prefer and deprecate the other patch!

But it's not true... in my test case I had 2 available items within this group.
I can retest, but I am pretty sure. I had created new items in order to group
and place a hold on them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:36:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:36:56 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-HktqyUuzpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #36 from David Nind <david at davidnind.com> ---
Everything works as per the test plan, except for tests failing for
t/db_dependent/Biblio/ModBiblioMarc.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:41:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:41:59 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-puvvFe2RBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:42:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:42:05 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-ceZV3DxNoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142797|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142977&action=edit
Bug 32016: Fix clear filter button behavior

For example, if you filter by global search input a datatable which saves its
previous state when you want to return to this datatable, the backup is
recovered in a cookie but the "clear filter" button is disabled because for it
the input is empty, the verification of the recovery of the cookie not being
made.

When loading I therefore added the verification of the cookie and if the search
value is not empty then the button can be activated.

Test plan:

1) Be sure to have some orders and baskets which can be received
2) Go to 'cgi-bin/koha/acqui/booksellers.pl' and click on 'Receive
shipments'
3) Enter something in global search
4) Go to receive and cancel or save to be back on datatable
5) See that you cannot remove your previous input by the 'clear filter'
button
6) Apply this patch
7) Repeat steps 3) and 4)
8) See that now you can remove your search

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:43:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:43:05 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC if they
 will actually be charged
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-qiZCQbpHpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Only show reserve fee       |Only show hold fee message
                   |message on OPAC if they     |on OPAC if they will
                   |will actually be charged    |actually be charged

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:43:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:43:35 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC if they
 will actually be charged
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-uQvKGEL3TM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 14:49:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 13:49:13 +0000
Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to
 prioritize either matching a patron's home library to the item's home or
 holding library
In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31557-70-rhDD9Lb9Hm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:04:55 +0000
Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat
 this Tag
In-Reply-To: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31877-70-zlAbxd4nLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142572|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142978&action=edit
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"

To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a
small x next to the tag title)
   --> a little popup thing (tooltip?) appears with "Delete this Tag"
4. Open the developper tools inspector in your browser
5. Click on the delete tag button
   --> the image alt text is "Delete this Tag"
6. Repeat the same check in the authorities editor
7. Apply patch
8. All tooltips and alt text should read correctly now

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:05:51 +0000
Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat
 this Tag
In-Reply-To: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31877-70-C6Ia4HP69T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ha.. there's another bug for the other case.

Passing QA.. this works great.. especially when bug 31876 is also included :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:07:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:07:07 +0000
Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
In-Reply-To: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31876-70-1qZIUGHwdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142570|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142979&action=edit
Bug 31876: Fix capitalization "Click to Expand Tag"

The string "Click to Expand this Tag" appears in addbiblio.tt a couple of
times. It should be "Click to expand this tag".

To get to the string for the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER)
   --> a little popup thing (tooltip?) appears with "Click to Expand this Tag"
4. Go to Administration > Global system preferences
5. Search for advancedMARCeditor
6. Change the value to "Don't show"
7. Click "Save all Cataloging preferences"
8. Go back to Cataloging > New record
9. Hover the mouse cursor over the tag number (e.g. 001)
   --> a little popup thing (tooltip?) appears with "<tag title> Click to
Expand this Tag"
10. Go to Authorities > new record
11. Hover over the desription of a tag which subfields are collapsed
   --> verify the tooltip appears with "Click to Expand this Tag"
12. Apply patch, all occurrences should be fixed now.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:07:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:07:34 +0000
Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
In-Reply-To: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31876-70-cQzeRHLFVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:07:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:07:48 +0000
Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat
 this Tag
In-Reply-To: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31877-70-3qyWq4ORzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:12:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:12:50 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-Eb8Pycsvk2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142582|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142980&action=edit
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:12:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:12:55 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-LG4qeZQk8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142583|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142981&action=edit
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:13:00 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-8ZKIUWBQMO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142584|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142982&action=edit
Bug 21381: (follow-up) fix typo in columns setting yml

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:13:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:13:05 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-ZHHLNwRRCa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142983&action=edit
Bug 21381: (QA follow-up) Add missing filter

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:13:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:13:34 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-D1lurW92Pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
             Status|Signed Off                  |Passed QA

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice little addition, no regressions..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:21:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:21:07 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-n0KjMjF2KE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142974|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:21:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:21:14 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-ZwKfJKYH8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142975|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:21:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:21:48 +0000
Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when
 only one result
In-Reply-To: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31967-70-LVKOf5q7wd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142601|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142984&action=edit
Bug 31967: Search terms retained in header search when only one result

Bug 26247 added a system preference to manage the Retaining of search terms in
header search.
But this does not work if there is only one match and you go directly to
details page.

Test plan :
1) Set system preference RetainCatalogSearchTerms to "Don't retain"
2) Perform a search leading to a single result.
   For example in KTD the ISBN 1932100083
=> Without patch search bar is populated with search terms
=> With patch search bar is not populated with search terms

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:22:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:22:05 +0000
Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when
 only one result
In-Reply-To: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31967-70-qPLnxe4yu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:22:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:22:18 +0000
Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when
 only one result
In-Reply-To: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31967-70-7VWL9rlWR8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial fix, works.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:23:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:23:52 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC if they
 will actually be charged
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-yBMs1Noybp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:23:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:23:56 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC if they
 will actually be charged
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-Frt8OfiRsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142592|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142985&action=edit
Bug 31963: Only show hold fee msg on OPAC if patron will be charged

This patch ensures HoldFeeMode is considered when displaying a message
to patrons on the OPAC that says they'll be charged a hold fee when
placing or collecting the hold.

When HoldFeeMode is set to not_always or "only if all items are checked
out and the record has at least one hold already" then the hold fee
message should only show if all items on the record are checked out, AND
the record has at least one hold already - both of these conditions must
be met.

To test:
1. Go to Administration -> Patron categories
2. Edit your patron category and give a hold fee of $1.
3. Go to Administration -> System preferences and search for
HoldFeeMode. Set to 'only if all items are checked out and the record
has at least one hold already' if not already set. Keep this tab open.
4. In another tab, open the OPAC.
5. Search the OPAC for a record with one item which is NOT checked out.
6. Go to place a hold on this record. Confirm you see a message saying
that you will be charged a hold fee, even though not all items are
checked out and the record does not have a hold --> This is the bug.

7. Apply patch and restart services.

Items available, no holds placed

8. Repeat steps 5-6. This time, you should NOT see the hold fee message.

Items available, holds placed

9. In your staff interface tab, find the same record.
10. Place a hold for a different patron on this record.
11. In your OPAC tab, find this record again and go to place a hold. You
should NOT see the hold fee message.

No items available, no holds placed

12. In your staff interface tab, cancel the hold placed on this record.
13. Check out the item to a different patron.
14. In your OPAC tab, find this record again and go to place a hold. You
should NOT see the hold fee message.

No items available, holds placed

15. In your staff interface tab, keep the item checked out to another
patron.
16. Place a hold for a third patron on this record.
17. In your OPAC tab, find this record again and go to place a hold. You
SHOULD see the hold fee message.

Multiple holds

18. Search the OPAC for a record. Make sure your search will return more
than one result, including our test record.
19. Check the checkbox for our test record, plus another record where
the item is not checked out.
20. Click the Place hold button to place holds on all of our selected
records. You should only see the hold fee message above our test record.

21. In your staff interface tab, test setting HoldFeeMode to the other
values and confirm the hold message shows on the OPAC as expected.
22. Confirm tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:24:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:24:32 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-bjHkLRR88k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142974|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:24:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:24:38 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC if they
 will actually be charged
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-Mq83okAqdu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It took me a bit to wrap my head around this.

I believe while this advertises as a display fix, it's also a behavior change:

GetReserveFee:

-        if( $notissued ) {
+        if( $notissued == 0 ) {
+            # all items are issued


And later this is also used to determine what is charged:

AddReserve:

    # add a reserve fee if needed
    if ( C4::Context->preference('HoldFeeMode') ne 'any_time_is_collected' ) {
        my $reserve_fee = GetReserveFee( $borrowernumber, $biblionumber );
        ChargeReserveFee( $borrowernumber, $reserve_fee, $title );
    }

The system preference states: "Charge a hold fee only if all items are checked
out and the record has at least one hold already". So the change in behaviour
makes this happen. 

Only problem: I am having a hard time to phrase out the actual difference in
when a user is charged right now :(

Can you please update the bug description/title and release notes to be more
clear about this not only affecting display please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:25:11 +0000
Subject: [Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
In-Reply-To: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32012-70-SVMb5yl43f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142704|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142986&action=edit
Bug 32012: runreport.pl should use binmode UTF-8

Like Bug 26832 added binmode UTF-8 to script
misc/search_tools/export_elasticsearch_mappings.pl, this should be added to
misc/cronjobs/runreport.pl.

Test plan :
1) Do not apply patch
2) Create a SQL report with :
   SELECT 'accentué',barcode FROM items limit 3
3) Note the id of this report, for example 1
4) Run : misc/cronjobs/runreport.pl 1 --format csv | tee /tmp/without.csv
=> You see output with unknown character instead of é :
5) Run : file --mime-type /tmp/without.csv
=> You see : /tmp/without.csv: iso-8859-1
6) Apply patch
7) Run : misc/cronjobs/runreport.pl 1 --format csv | tee /tmp/with.csv
=> You see correct output with é
8) Run : file --mime-type /tmp/without.csv
=> You see : /tmp/without.csv: utf-8

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:25:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:25:31 +0000
Subject: [Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
In-Reply-To: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32012-70-ohIm379IAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:25:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:25:39 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-gQTIaGSlLc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #203 from Kyle M Hall <kyle at bywatersolutions.com> ---
Ah! I was testing a slightly different scenario. You are right, the last patch
is no good. I've obsoleted it and now everything should be good!

I'm not sure what scenario you are
> But it's not true... in my test case I had 2 available items within this
> group. I can retest, but I am pretty sure. I had created new items in order
> to group and place a hold on them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:28:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:28:02 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-05w0KAqkhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to David Cook from comment #44)
> Want to work on this since it's fresh in the mind... but better work on OIDC
> instead...

If you do decide to, I'll be happy to sign/qa anything you do :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:39:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:39:13 +0000
Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a
 dropdown field in the cataloguing editor
In-Reply-To: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31646-70-iflH489eZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:43:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:43:51 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-x7X8weXYx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142954|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142987&action=edit
Bug 32070: Consistent classes for primary buttons: Acquisitions

This patch makes changes the button markup in Acquisitions templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Acquisitions to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:45:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:45:23 +0000
Subject: [Koha-bugs] [Bug 32076] New: Form for editing a basket group is
 misaligned
Message-ID: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

            Bug ID: 32076
           Summary: Form for editing a basket group is misaligned
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

The input fields on the edit form for basket groups are misaligned and the
'ungrouped baskets' on the right should probably be page-sectioned.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:45:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:45:23 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-LVvTt1gzom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32076


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076
[Bug 32076] Form for editing a basket group is misaligned
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:45:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:45:59 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-BhJwlCvg7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Passing QA as this just improves markup consistency..

What I'm less sure about is having all the actions buttons on the closed
basketgroups table be primary.. it feels like primary should be saved for 'the
main action on a page'.. can we really have a whole table full of 'main
actions'?  One for the new style guide I reckon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:51:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:51:10 +0000
Subject: [Koha-bugs] [Bug 32077] New: 'Close and Export as PDF' doesn't work
 on basketgroups page
Message-ID: <bug-32077-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32077

            Bug ID: 32077
           Summary: 'Close and Export as PDF' doesn't work on basketgroups
                    page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

If you attempt to 'Close and Export as PDF' a basketgroup from the open
basketgroups tab of a vendor basketgroup page the action fails and an error is
shown in the console.

Uncaught ReferenceError: closeandprint is not defined
    onclick
http://mrdev-zebra-staff.koha-ptfs.co.uk/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=8&listclosed=1:1
basketgroup.pl:1:1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:53:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:53:17 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" doesn't appear in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-yy4FUi3waf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

Claude Demeure <claude.demeure at mailo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claude.demeure at mailo.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:54:12 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-9BJ9buSFBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142953|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142988&action=edit
Bug 32068: Consistent classes for primary buttons: Administration

This patch makes changes the button markup in Administration templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Administration to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:54:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:54:47 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-oNAXZtZnk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is great work, thanks Owen!

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 15:54:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 14:54:52 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-GZs2S8xMBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 16:13:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 15:13:41 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-CWGnMXbn8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
I agree. I simply applied classes according to the existing markup, which
consisted of input[type='submit'] which would have had the primary appearance
regardless of the added class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 16:45:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 15:45:34 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-LDL5GoPUnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142820|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142989&action=edit
Bug 30649: Vendor EDI account passwords should be encrypted in the database

We are storing edi vendor acccount passwords in clear text in the
database. Now that Koha has the Koha::Encryption module, we should
use that to encrypt passwords for all existing and new EDI accounts.

Test Plan:
1) Apply this patch
2) Create one or more EDI vendor accounts
3) Run a report to view the account passwords, note they are in clear
   text
4) Run updatedatabase.pl
5) Re-run the report, account passwords should be encrypted now
6) Edit a vendor EDI account, note you can still view and update the
   password for an account

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 16:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 15:45:47 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-CBgG3fyRMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 16:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 15:51:09 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-qoN3HP0LI7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Victor Grousset/tuxayo from comment #14)
> (In reply to Kyle M Hall from comment #9)
> > (In reply to Victor Grousset/tuxayo from comment #8)
> > > I don't get how to encrypt a password to an external service and still be
> > > able to use the external service. Does that mean Koha can in full autonomy
> > > decrypt it?
> > 
> > Yes, we store a key in the koha konf file for encryption and decryption. I
> > need to rebase this patch to use the work from Bug 28998.
> 
> Ok IIUC the security value doesn't come from encryption but from having the
> date out of the DB. So a simple SQL injection can't get it.
> Is there any gain compared to just storing the passwords into koha-conf.xml
> directly? 
> (hum, maybe Koha can't write to that file and that would need a separate
> file)
> Like is it a plausible attack scenario to be able to read the file but not
> the DB? That when needing both would help.

The value does come from the encryption.  If the database is somehow
compromised (for example, someone accidentally shares a backup.. it could be as
simple as that).. by having the data in the databawse encrypted the nafarious
actor doesn't have something useful to them.. They still need to hack the
machine to get ahold of the key (from the conf file) and/or read the code to
understand what sort of algorithm is used.

So this closes one door.. if they have full access to the server, they have all
the elements they need to access the plaintext credentials.. but the
improvement here is that they now have to have that full access rather than
just a db dump.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 16:55:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 15:55:46 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-0ByGUw48kX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Still contemplating QA here.. the code works as expected and I'm happy with the
implementation as a whole.

However.. I'm not so sure about the in place database upgrade... we tend to try
and steer away from referencing Koha modules from within the atomicupdates in
case there's a change to said module down the line.  That said.. that's not a
blocker for me, just a consideration.  When we upgraded from SHA to BCrypt for
user account hashing we added a layer inside the codebase to upgrade the hash
on first access I seem to recall.

My other pondering is around what happens if/when an admin wants to change the
encryption key for the server.. that's out of scope for this particular bug,
but I feel like we should have an option for it somewhere.. either a script to
update encrypted data's to use the new key (given the old and new key as input)
or a way to defined the keys as an array and upgrade on access or something
like that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:00:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:00:44 +0000
Subject: [Koha-bugs] [Bug 32078] New: We should have an easy way for an
 administrator to update the encryption keys
Message-ID: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

            Bug ID: 32078
           Summary: We should have an easy way for an administrator to
                    update the encryption keys
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

We now use encryption on a number of Koha database fields and utilise a key
sorted in koha-conf.xml..

However, we have no easy way to change key should that key be leaked or found
to be to simple to crack.  We should add a script to allow updating of our
encrpyted values from one key to the next... (or alternatively, perhaps we
should allow for an array of keys in our config and update the encryption on
access whenever we find an prior key is in use?.. I believe this is what we did
when we upgraded from SHA to BCrypt for user passwords).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:01:12 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-oh8mXfBbCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28998

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:01:12 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-oDInJcDqFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32078

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:01:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:01:20 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-sOtjCDmwJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Command-line Utilities      |Architecture, internals,
                   |                            |and plumbing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:01:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:01:42 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-7xPUJRJ8LU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30649

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:01:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:01:42 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-rEU3MEFC1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32078

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:06:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:06:36 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-syWRLYpU7a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. I decided to open another bug for my thoughts on key change..

I'll pass this one but highlight to the RM that we may need to rethink the DB
update.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:13:20 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-NhAX0Ve1oQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:13:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:13:57 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-P1iCStlPLd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:30:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:30:37 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if patron has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-7yBDDqPFJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140970|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142990&action=edit
Bug 29102: Do not count patron's own hold against limits

This patch makes three changes:
1 - The borrower's own holds are not counted towards HighHolds limit
2 - We exclude all hold counts from CanItemBeReserved
3 - Static mode should only decrease hold when over the
decreaseLoanHighHoldsValue, not when equal

Previously a patron's hold could put the count over the threshhold, and
if the patron is only allowed 1 hold per record, and the hold wasn't found
before
the checkout, it would make all items unholdable, thus lowering the theshhold
for
dynamic HighHolds

To test:
 1 - Set sysaprefs:
     decreaseLoanHighHolds  - enable
     decreaseLoanHighHoldsDuration - 1
     decreaseLoanHighHoldsValue - 1
     decreaseLoanHighHoldsControl - "over the number of holdable items on the
record" / dynamic
     decreaseLoanHighHoldsIgnoreStatuses - blank
 2 - Set circ rules to allow 1 hold per record and loan period of 5
 3 - Find/create a record with 3 items
 4 - Place a title level hold for two different patrons
 5 - Attempt to checkout item - note warning about high holds
 6 - Cancel checkout
 7 - Set decreaseLoanHighHoldsControl - "on the record" / static
 8 - Attempt checkout - note warning about high holds
 9 - Apply patch
10 - Checkout item - no warning
11 - checkin item, replace hold
12 - Set decreaseLoanHighHoldsControl - "over the number of holdable items on
the record" / dynamic
13 - Checkout item - no warning
14 - prove t/db_dependent/DecreaseLoanHighHolds.t

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:30:44 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if patron has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-vbp4O8TbQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140971|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 142991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142991&action=edit
Bug 29102: Remove ignore_found_holds

If not counting patrons holds, found or unfound, we no longer need this option
introduced by bug 28078

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:31:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:31:53 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if patron has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-5XOaN55Fiz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as described, nice clean code., unit tests and QA script is happy.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:31:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:31:58 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if patron has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-C41XzxqTFX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:45:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:45:59 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-HEipphPscC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:06 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-KdKawSQ44U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142955|0                           |1
        is obsolete|                            |

--- Comment #204 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142992&action=edit
Bug 24860: Add reserves.item_group_it

This feature builds upon bug 24857 and allows placing holds that target a
specific item group of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and item groups, with each item being assigned to
an item group
6) Place a hold for a patron
7) Note the new selector to choose an item group in addition to record and item
level holds
8) Place an item group level hold
9) Check in an item from the record that is not part of that item group
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that item group
12) Note the hold is trapped for that item
13) Place an item group level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that item group
16) Check out all the items of that item group to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:14 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-mcRWm1YA6f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142956|0                           |1
        is obsolete|                            |

--- Comment #205 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142993&action=edit
Bug 24860: Add new syspref EnableItemGroupHolds

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:22 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-Mg07My8d9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142957|0                           |1
        is obsolete|                            |

--- Comment #206 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142994&action=edit
Bug 24860: Implement reserves.item_group_id

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:30 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-wPbG2eHYxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142958|0                           |1
        is obsolete|                            |

--- Comment #207 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142995&action=edit
Bug 24860: Add ability to select an item group when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:38 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-JsflL3pazo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142959|0                           |1
        is obsolete|                            |

--- Comment #208 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142996&action=edit
Bug 24860: Add ability to select an item group when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:45 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-PQjbOqYUyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142960|0                           |1
        is obsolete|                            |

--- Comment #209 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142997&action=edit
Bug 24860: Skip non-matching item group holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:46:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:46:52 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-8MpaHp4Uuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142961|0                           |1
        is obsolete|                            |

--- Comment #210 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142998&action=edit
Bug 24860: Skip non-matching item group holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:00 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-MxI0AKW99s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142962|0                           |1
        is obsolete|                            |

--- Comment #211 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 142999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142999&action=edit
Bug 24860: Add hold's item group to holds table on circulation.pl and
moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:07 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-gKZlSxcc0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142963|0                           |1
        is obsolete|                            |

--- Comment #212 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143000&action=edit
Bug 24860: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:15 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-AiyMLCcHHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142964|0                           |1
        is obsolete|                            |

--- Comment #213 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143001&action=edit
Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:23 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-4YTOsaPWf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142965|0                           |1
        is obsolete|                            |

--- Comment #214 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143002&action=edit
Bug 24860: (QA follow-up) Terminology and translation fixes

* Fixes a single to a double underscore for translation in holds.js
* Fixes item_group to item group in API description
* Fixes volume hold to item group hold in syspref db descrpitions

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:32 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-ekQPFYPArA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142966|0                           |1
        is obsolete|                            |

--- Comment #215 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143003&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:39 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-lkRcRiBH5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142967|0                           |1
        is obsolete|                            |

--- Comment #216 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143004&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:47 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-pvH4FusgK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142968|0                           |1
        is obsolete|                            |

--- Comment #217 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143005&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:47:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:47:54 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-l4jOp6UMDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142969|0                           |1
        is obsolete|                            |

--- Comment #218 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143006&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover
Koha::Holds::forced_hold_level

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:48:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:48:02 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-jHiEmmF71H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142970|0                           |1
        is obsolete|                            |

--- Comment #219 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143007&action=edit
Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:48:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:48:10 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-iez7Aj9Qhv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142971|0                           |1
        is obsolete|                            |

--- Comment #220 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143008&action=edit
Bug 24860: (QA follow-up) Fix typo in holds queue viewer

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:48:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:48:20 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-8gqF5G8Y7p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142972|0                           |1
        is obsolete|                            |

--- Comment #221 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143009&action=edit
Bug 24860: (QA follow-up) Show group holds on Holds to pull

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:48:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:48:28 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-gU9YuAV3AV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142973|0                           |1
        is obsolete|                            |

--- Comment #222 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143010&action=edit
Bug 24860: (QA follow-up): Don't assume item group is set for all items

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:48:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:48:37 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-gTU2qvktKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142974|0                           |1
        is obsolete|                            |

--- Comment #223 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143011&action=edit
Bug 24860: (QA follow-up) Ask for any available item of matching group

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:49:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:49:09 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-4LnHXPcs5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Version|22.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:50:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:50:25 +0000
Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an
 undefined value at cataloguing/additem.pl
In-Reply-To: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31873-70-uYFw6hhsRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |29746


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
[Bug 29746] Add a handy Koha::Result::Boolean class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:50:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:50:25 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29746-70-rSK0Z3L5ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31873


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873
[Bug 31873] Can't call method "safe_delete" on an undefined value at
cataloguing/additem.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:53:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:53:11 +0000
Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an
 undefined value at cataloguing/additem.pl
In-Reply-To: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31873-70-OfQ1iDHMIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142206|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143012&action=edit
Bug 31873: Check ->find before calling ->safe_delete

When there is no item, you cannot safely delete it :)

Resolve this warning:
  Can't call method "safe_delete" on an undefined value at
/usr/share/koha/cataloguing/additem.pl line 379
(Line numbers may vary across versions.)

Test plan:
Open item editor.
Add a new item.
Add another tab with same form. Delete new item.
Go back to former tab. Try to delete again.
You should see an alert now on top of the form.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:53:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:53:43 +0000
Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an
 undefined value at cataloguing/additem.pl
In-Reply-To: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31873-70-UtAKovmMzJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as described, code is clean.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:53:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:53:48 +0000
Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an
 undefined value at cataloguing/additem.pl
In-Reply-To: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31873-70-f4XM3XM50u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:54:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:54:54 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-kTdnK2Ca2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:56:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:56:20 +0000
Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not
 honor SyndeticsCoverImageSize
In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32041-70-0qK81KJ7BJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
I think this is being handled correctly, the results pages should always show
the smaller thumbnail type images. The system preference description should be
updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:59:29 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-H29B2MJEcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141021|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143013&action=edit
Bug 27259: Test HomeOrHoldingBranch usage in TooMany()

This shows that HomeOrHoldingBranch syspref is incorrectly not used by
TooMany() when it decides which circ rule to use.

Run "prove t/db_dependent/Circulation/TooMany.t" to notice the tests
now fail.

Signed-off-by: Petro Vashchuk <stalkernoid at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:59:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:59:35 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-7d8qgzaiGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141022|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143014&action=edit
Bug 27259: Test HomeOrHoldingBranch usage in _CalculateAndUpdateFine()

This shows that HomeOrHoldingBranch syspref is incorrectly not used by
_CalculateAndUpdateFine() when it decides which circ rule to use.

Run "prove t/db_dependent/Circulation/_CalculateAndUpdateFine.t" to
notice the tests now fail.

Signed-off-by: Petro Vashchuk <stalkernoid at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 17:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 16:59:40 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-65cHWiXHoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141023|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143015&action=edit
Bug 27259: Add HomeOrHoldingBranch checks where it was missing from

The TooMany() function and fine calculation functions were incorrectly
hard coded to use homebranch for fetching the circulation rules. Those
ignored completely the syspref HomeOrHoldingBranch where the user
might have set it to holdingbranch and therefore the fines and whether
patron has too many checkouts (TooMany()) were counted using the
unintended branch's rules. This problem only arises in the cases where
there are branch specific circulation rules defined.

Test plan:
1. Make sure following tests pass:
   $ prove t/db_dependent/Circulation/_CalculateAndUpdateFine.t
   $ prove t/db_dependent/Circulation/TooMany.t

Test plan for fines.pl:
1. Add branch specific fine rules for branches A and B. A having a
   fine of 1 per day and B having a fine of 0 per day.
2. Set sysprefs:
   CircControl = the library the items is from
   finesMode = Calculate and charge
   HomeOrHoldingBranch = holdingbranch
3. Create an item with home and holding branch of A
4. Checkout the item with a due date in the past (the past due date can be
   specified by clicking "Checkout settings" in the checkout page) and
   make sure the branch you are checking from is B.
5. Run perl /usr/share/koha/bin/cronjobs/fines.pl
6. Notice that fines have popped up now to the patron incorrectly
7. Apply patch
8. Pay fines, Check-in the item and check it out again
9. Run perl /usr/share/koha/bin/cronjobs/fines.pl
10. Notice that fine is now 0. This means that the branch
    B (holdingbranch of the checked-out item) specific rule is used.

Test plan for staticfines.pl:
1. Add branch specific fine rules for branches A and B. A having a
   fine of 1 per day and B having a fine of 0 per day.
2. Set sysprefs:
   CircControl = the library the items is from
   finesMode = Calculate and charge
   HomeOrHoldingBranch = holdingbranch
3. Create an item with homebranch A and holding branch of A
4. Checkout the item with a due date in the past (the past due date can be
   specified by clicking "Checkout settings" in the checkout page) and
   make sure the branch you are checking from is B.
5. Run perl staticfines.pl --library A --library B --category
<PATRONS_CATEGORYCODE>
   and notice that now there is inccorectly fines
6. Apply patch
7. Pay fines, Check-in the item and check it out again
8. Run perl staticfines.pl --library A --library B --category
<PATRONS_CATEGORYCODE>
    and notice the fines are now not generated

Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
Signed-off-by: Petro Vashchuk <stalkernoid at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:00:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:00:18 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-2RfYNDxJES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nicely worked through.. good to see unit tests and qa script is happy.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:02:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:02:56 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-Vdt6HCCfuE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:03:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:03:01 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-mxEkDxYXOM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142798|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143016&action=edit
Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue
syspref is on

The real time hold queue and the build_holds_queue.pl jobs are not 100%
compatible in that we should not be running the cron if the real time queue is
enabled, this could lead to double server work. It would be good to have a
check in build_holds_queue for the RealTimeHoldsQueue syspref and not run the
job if the preference is enabled.

There might be times when we'd want to force a run of this job without changing
the syspref. To that end we would also want a flag for this job so that system
administrators could force the job from the command line if required,
overriding this limitation.

Test Plan:
1) Apply this patch
2) Try run misc/cronjobs/holds/build_holds_queue.pl with the -h/--help and
-m/--man options
3) Disable RealTimeHoldsQueue
4) Run with no options, should succeed
5) Enable RealTimeHoldsQueue
6) Run with no options, should display a message and not rebuild the
   holds queue
7) Run again with the -f/--force option, should succeed

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:03:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:03:05 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-9k2HFaL60S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143017&action=edit
Bug 31995: (QA follow-up) Add 'system preference' to help text

We often get asked where something can be found in setting,
adding the hint that RealTimeHoldsQueue is a system preference
is hopefully helpful here.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:03:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:03:25 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-tbygXWKsKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Love to see this script improved - most of this patch is documentation :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:06:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:06:17 +0000
Subject: [Koha-bugs] [Bug 32037] Circulation module in action logs has bad
 links for deleted items
In-Reply-To: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32037-70-24Xtl4eZhp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:06:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:06:19 +0000
Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing
In-Reply-To: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31907-70-1ATUz8efPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142821|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143018&action=edit
Bug 31907: Show items as On hold when in processing

Test plan:
1. Make sure syspref "opacbookbag" is set to "Allow".
2. Make sure syspref "HoldsNeedProcessingSIP" is set to "Don't fulfill".
3. Place a hold on an item.
4. Return item via SIP at the pickup library.
5. View biblio in Opac.
6. Note that it says "Available" as status.
7. Add biblio to Cart.
8. Open Cart.
9. Note that it says "Available" as status.
10. Apply patch.
11. Reload Opac page.
12. It should now say "On hold".
13. Reload Card page.
14. It should also say "On hold".

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:06:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:06:23 +0000
Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing
In-Reply-To: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31907-70-uj3eDRT6Kg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143019&action=edit
Bug 31907: (QA follow-up) Add POD

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:07:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:07:15 +0000
Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing
In-Reply-To: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31907-70-r8BfmdqgZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works as expected, Unit tests included and QA script happy once the
follow-up was added.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:07:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:07:39 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-zPReDJjPLP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:15:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:15:35 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-xGN21fyRcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143020&action=edit
Bug 24606: (QA follow-up) Fix up save form a bit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:27:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:27:25 +0000
Subject: [Koha-bugs] [Bug 32037] Circulation module in action logs has bad
 links for deleted items
In-Reply-To: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32037-70-Jx3kHlCZwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:27:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:27:29 +0000
Subject: [Koha-bugs] [Bug 32037] Circulation module in action logs has bad
 links for deleted items
In-Reply-To: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32037-70-EFIYm44tQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142790|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143021&action=edit
Bug 32037: Check for existence of object before building link

This patch adds a check on the existence of the object and passes this to the
template

I also drop a level of IF by moving to ELSIF

To test:
 1 - Enable ReturnLog amd IssueLog
 2 - Checkout an item to a patron
 3 - Return it
 4 - View 'Modification log' tab of the borrwer
 5 - Note item links, test them, they work
 6 - Delete the item
 7 - Reload and try links again, they do not work
 8 - Apply patch
 9 - Reload, no more links
10 - Checkout and return another item
11 - This one has links, and they work as before

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:27:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:27:33 +0000
Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in
 outgoing email notices
In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31627-70-P2RSMuv3Vb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #10)
> I wonder if it would be nice to have a way to make this invisible at least
> in HTML notices. Something like <div style="display:none">ID</div> ?
> 
> This line looks like it would allow to do just that:
>              if ($is_html) {
> +                $content .= "<br/>$message->{letter_id}" if $message->{id}
> && C4::Context->preference('SendLetterIdInEmailNotices');
> 
> At the moment there is no way libraries could change how this appears in the
> notices and it might raise questions about the 'number' appearing at the end
> of the message.

Sounds good! I'll post a followup for that!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:32:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:32:59 +0000
Subject: [Koha-bugs] [Bug 31627] Add ability to embed the letter ID in
 outgoing email notices
In-Reply-To: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31627-70-fJXQlh3PE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143022&action=edit
Bug 31627: (followup) Hide id for HTML messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:51:12 +0000
Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount
 exceeds allowed budget when editing existing order
In-Reply-To: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31840-70-XytOzG4dSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:51:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:51:16 +0000
Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount
 exceeds allowed budget when editing existing order
In-Reply-To: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31840-70-qphYGxv0Ym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142129|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143023&action=edit
Bug 31840: Consider current cost if modifying order

This patch deducts the current cost of an order if modifying it, so that
the current cost isn't counted when checking whether the updated cost
will take the order total amount above the allowed budget.

To test:
1. Add an active budget of $1,000
2. Attach a fund of $1,000. Set the fund to warn at 98% and $900.
3. Add an order to a basket, give it a vendor price of $500 with no
discount or tax and Save
4. Modify the order and change the vendor price to $450 and Save
5. Notice you get a warning that this order total amount will exceed the
allowed budget - this is incorrect.
6. Apply the patch and cancel the change so you're redirected back to
the basket
7. Modify the order and change the vendor price to $450 and Save
8. You should be able to Save without requiring confirmation
9. Add another order to the basket, give it a vendor price of $100 with
no discount or tax and Save. This should save normally, confirming we
can add new orders that do not exceed the allowed budget
10. Add another order to the basket, give it a vendor price of $500 with
no discount or tax and Save. This should trigger the warning that you
will exceed the allowed budget, as expected.

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:52:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:52:17 +0000
Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when
 EnhancedMessagingPreferencesOPAC is off
In-Reply-To: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31743-70-f2VghASAa6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:53:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:53:54 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-C1pZdF69LJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         Resolution|INVALID                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
I think this causes confusion then - either we should always have a single
subpermission, or we should only have them if we have two?

For OPAC problem reports - we only seem to ever check the top permission
For recalls we check the subpermission every time, except once

Having two settings with the same behavior seems wrong to me

Maybe we need a guideline?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 18:54:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 17:54:00 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-GwqSh0lsif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 19:06:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 18:06:18 +0000
Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when
 EnhancedMessagingPreferencesOPAC is off
In-Reply-To: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31743-70-u5zUd2zWml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 19:06:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 18:06:22 +0000
Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when
 EnhancedMessagingPreferencesOPAC is off
In-Reply-To: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31743-70-K5REA3SZzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141849|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143024&action=edit
Bug 31743: Change condition for messaging tab

Note for QA:
The code for SMSnumber is still made dependent on
EnhancedMessagingPreferencesOPAC in order to not
disturb current behavior.
This fixes Enhanced on, EnhancedOPAC off; the case of
Enhanced off is not considered here.

Test plan:
Enable EnhancedMessaging, disable EnhancedMessagingOPAC.
Enable TranslateNotices.
Check if you can only change notice language on OPAC.
Enable EnhancedMessagingOPAC.
Check if you change messaging prefs too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: marie-luce <marie-luce.laflamme at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 19:07:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 18:07:26 +0000
Subject: [Koha-bugs] [Bug 28012] Error on saving new numbering pattern
In-Reply-To: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28012-70-iAc0aXUwTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Error on Saving new         |Error on saving new
                   |numbering pattern           |numbering pattern

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 19:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 18:16:55 +0000
Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for
 non-waiting holds
In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14783-70-ACyW04Fntc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hafen at washk12.org

--- Comment #54 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 143025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143025&action=edit
Bug 14783: (follow-up) MySQL doesn't like selecting from a table it is updating

I have a problem with the db_rev.  MySQL doesn't allow selecting from a table
you are updating (which has tripped me up before too).  MySQL error message:

ERROR 1093 (HY000): You can't specify target table 'systempreferences' for
update in FROM clause


The value needs to be selected separately.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 19:55:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 18:55:16 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-XOqcsl5MuK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:03 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-a5L9DpDMIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:07 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-t03Sh93irr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143026&action=edit
Bug 32076: Add page-section to basketgroup.tt and clean-up markup

This patch adds the page-section div to the basket group 'Ungrouped baskets'.
It also adds the row class to the fieldset to get the list to display properly.

To test:
1. Apply patch
2. Make sure the page section div for 'Ungrouped baskets' looks good.
3. Look at the markup changes and make sure the make sense.
4. Make sure the form still works as it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:17 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-o5iyF3sS4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:22 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-CoqpFQT7zf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142801|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:26 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-FAaUdYoq2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142802|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:30 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-FbFYOPz83t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142803|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:34 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-ZNhGkMyozL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142804|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:35 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-mAmVege6Be@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:01:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:01:39 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-7HV6W5i1Vr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142805|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:06:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:06:27 +0000
Subject: [Koha-bugs] [Bug 28012] Error on saving new numbering pattern
In-Reply-To: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28012-70-nYE8n594j1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As noted in comments before this one, I don't think that making the description
mandatory is the right solution here. 

These features work currently for all libraries as we don't set strict on
production systems. So making them required, will be a regression. I confirmed
that without the strict, it's possible to save numbering patterns in master
with only name and numbering pattern set.

We should instead fix it on database level, perhaps by making the field
nullable. 

Note: bug 31297 was supposed to take care of this, but I believe Joonas is no
longer around and it's currently in FQA. So we cannot expect a fix there right
now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:09:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:09:35 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-BhPFKmXrI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:09:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:09:40 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-3ifzYvATGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142849|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143027&action=edit
Bug 31854: Document --not_borrowed_since and anonymization

To test:
- Run "perldoc misc/cronjobs/delete_patrons.pl"
- Note the absence of information about the potential conflict
  between --not_borrowed_since and anonymization
- Apply this patch
- Re-run the perldoc command and make sure the note about
  anonymization make sense

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:11:11 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-JbuI4cxZW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143028&action=edit
Bug 31854: (QA follow-up) Terminology: loans > checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:11:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:11:40 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-ghlEQmBxjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:19:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:19:32 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-73Ofl3Z62E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Thibaud, 

please make sure to run the QA tools on your patches and to set your editor to
use 4 spaces for indentation instead of tabs:

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_110.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 37)
                forbidden pattern: tab char (line 38)
                forbidden pattern: tab char (line 39)
                forbidden pattern: tab char (line 40)
                forbidden pattern: tab char (line 42)
                forbidden pattern: tab char (line 43)
                forbidden pattern: tab char (line 44)
                forbidden pattern: tab char (line 45)
                forbidden pattern: tab char (line 47)
                forbidden pattern: tab char (line 48)
                forbidden pattern: tab char (line 49)
                forbidden pattern: tab char (line 50)
                forbidden pattern: tab char (line 52)
                forbidden pattern: tab char (line 53)
                forbidden pattern: tab char (line 54)
                forbidden pattern: tab char (line 55)
                forbidden pattern: tab char (line 57)
                forbidden pattern: tab char (line 58)
                forbidden pattern: tab char (line 59)
                forbidden pattern: tab char (line 60)
                forbidden pattern: tab char (line 62)
                forbidden pattern: tab char (line 63)
                forbidden pattern: tab char (line 64)
                forbidden pattern: tab char (line 65)
                forbidden pattern: tab char (line 67)
                forbidden pattern: tab char (line 68)
                forbidden pattern: tab char (line 69)
                forbidden pattern: tab char (line 70)
                forbidden pattern: tab char (line 72)
                forbidden pattern: tab char (line 73)
                forbidden pattern: tab char (line 74)
                forbidden pattern: tab char (line 75)
                forbidden pattern: tab char (line 77)
                forbidden pattern: tab char (line 78)
                forbidden pattern: tab char (line 79)
                forbidden pattern: tab char (line 80)
                forbidden pattern: tab char (line 184)
                forbidden pattern: tab char (line 185)
                forbidden pattern: tab char (line 186)
                forbidden pattern: tab char (line 187)

Will fix in a follow-up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:21:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:21:07 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-fCdDsQOZdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:21:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:21:11 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-gwej9vMJ5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142698|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143029&action=edit
Bug 31987: Update plugin unimarc_field_110 fields

According to
https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf

Test plan:

1) Be sure to manage unimarc 110 field in your bibliographic framework
2) Edit a record and click on plugin unimarc_110_field input to see new
select values

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:21:18 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-cqNgI3iEoi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143030&action=edit
Bug 31987: (QA follow-up) Fix indentation and remove trailing spaces

Fix tabs for 4 spaces in file.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:22:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:22:02 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-9YymMdwIYi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Koha" doesn't appear in    |"Koha" less prominent in
                   |new staff interface         |new staff interface
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:24:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:24:48 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-1NeUobJa2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:24:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:24:53 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-N1x8Lv3fWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142800|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143031&action=edit
Bug 32035: Add "Koha" to the staff interface home page

Currently the staff interface does not include Koha before the version
number shown on the home page.

Test plan:
1. Log in and view the staff interface home page.
2. In the bottom right-hand corner "Version 22.06.00" is shown.
3. Apply the patch.
4. Refresh the staff interface home page.
5. It now shows "Koha 22.06.00" (linked to the Koha website).
6. Sign off :D (or comment on alternative options).

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:25:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:25:47 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-4fgoesoo5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Claude, I see you set this to Signed off - are we missing your sign-off line
here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:26:44 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-ffVy53ENiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:28:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:28:30 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-ey5dJ59hUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:28:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:28:35 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-ByVPvNcFq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142230|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143032&action=edit
Bug 31887: Fix search on MARC field in Elasticsearch mappings table

In Elasticsearch mappings table, in tabs with MARC fields, searching using
DataTable search field does not work for MARC fields / subfields.
This is because cell contains an input HTML tag with MARC data in attribute
value.

Test plan :
1) Go to Administration > Search engine configuration (Elasticsearch)
2) Go to tab 'Bibliographic records'
3) Enter in search field a used MARC field (like 245)
=> Table gets filtered by rows with mapping on searched field
4) Enter in search field the field+subfield used for issues (952l in KTD)
=> Table gets filtered by rows with mapping on field+subfield

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:29:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:29:59 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-ibi3S81e1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:34:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:34:08 +0000
Subject: [Koha-bugs] [Bug 15869] Change framework on overlay
In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15869-70-9YDnHAN00f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143033&action=edit
Bug 15869: (follow-up) Don't mock undef return value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:36:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:36:12 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-cv16UqJXBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

--- Comment #8 from Claude Demeure <claude.demeure at mailo.com> ---
Hello Katrin, 
it was my first time "alone" on Bugzilla ;-).
Did i forgot something when i signed off ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:37:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:37:55 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-FwKz8frN4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Claude Demeure from comment #8)
> Hello Katrin, 
> it was my first time "alone" on Bugzilla ;-).
> Did i forgot something when i signed off ?

Hi Claude, not a problem :) You didn't add the sign-off line to the patch. I
can do that right now for you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:39:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:39:23 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-4WONGZ9zjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143031|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143034&action=edit
Bug 32035: Add "Koha" to the staff interface home page

Currently the staff interface does not include Koha before the version
number shown on the home page.

Test plan:
1. Log in and view the staff interface home page.
2. In the bottom right-hand corner "Version 22.06.00" is shown.
3. Apply the patch.
4. Refresh the staff interface home page.
5. It now shows "Koha 22.06.00" (linked to the Koha website).
6. Sign off :D (or comment on alternative options).

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Claude Demeure <claude.demeure at mailo.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:40:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:40:06 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-5pHS0FRKAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Great little fix!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:52:57 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-OImTLFUbpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:53:01 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-xukp2SxDMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142273|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143035&action=edit
Bug 31889: Remove exported ghost routine from Biblio module

It has been moved to a Koha object.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:53:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:53:07 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-Y74UQNNPnE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142274|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143036&action=edit
Bug 31889: Add unit test to show problem

Test plan:
Run t/db_dependent/Koha/Biblio/Metadata.t
Fails with:
  not ok 10 - 951-952s-953 in
245,100,942,951,953,999,952,952,952,952,952,952,952,952

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:53:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:53:12 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-3okGIbkCJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142275|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143037&action=edit
Bug 31889: Replace append_fields in _embed_items

Test plan:
Run t/db_dependent/Koha/Biblio/Metadata.t again. Should pass.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 20:55:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 19:55:06 +0000
Subject: [Koha-bugs] [Bug 31664] Show pending transfers on catalog details
 page
In-Reply-To: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31664-70-TjFhEg4ALe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Summary|Show pending transfers on   |Show pending transfers on
                   |biblio details page         |catalog details page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 21:04:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 20:04:26 +0000
Subject: [Koha-bugs] [Bug 31664] Show pending transfers on catalog details
 page
In-Reply-To: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31664-70-tuAnB4Xpjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 21:04:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 20:04:31 +0000
Subject: [Koha-bugs] [Bug 31664] Show pending transfers on catalog details
 page
In-Reply-To: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31664-70-eK0Xewmbqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142121|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143038&action=edit
Bug 31664: Display pending transfer information on details page

If a transfer is requested, but not sent, we should display this information on
biblio details for staff

This patch also removes nocancel parameter that was not used, passes transfer
object directly to template

To test
1 - Manually transfer an item
2 - Note the item shows in transit on details page
3 - Remove the datesent to emulate a pending transfer
    UPDATE branchtransfers SET datesent = NULL itemnumber=1;
4 - View details page - no info on transfer
5 - Apply patch
6 - Item shows 'Transit pending'

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 21:06:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 20:06:04 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-BpUyfBCSZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 21:14:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 20:14:41 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-v35si7hbLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Thanks Jonathan!

Testing notes:
After `apt install libmojolicious-plugin-renderfile-perl` you need to restart
the services to have it work. Otherwise:

[2022/11/02 19:54:30] [ERROR] Warning: Could not load REST API spec bundle:
Plugin "RenderFile" missing, maybe you need to install it?
[2022/11/02 20:05:50] [ERROR] GET /api/v1/erm/documents/1/file/content:
unhandled exception (Mojo::Exception)<<Can't locate object method "render_file"
via package "Koha::REST::V1::ERM::Documents" at
/kohadevbox/koha/Koha/REST/V1/ERM/Documents.pm line 53.>>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 21:50:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 20:50:17 +0000
Subject: [Koha-bugs] [Bug 31015] Remove option to clear pickup location
 selects on multi-holds page
In-Reply-To: <bug-31015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31015-70-K3FHDDQH7w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015

--- Comment #3 from Jason Robb <jrobb at sekls.org> ---
The larger issue was that holds could be placed without branchcodes assigned
under certain circumstances.

If I'm understanding correctly, bug 31086 seems to fully prevent that from
happening so this may not be a problem any longer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 22:33:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 21:33:26 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-p7gi1e4aMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #235 from David Nind <david at davidnind.com> ---
Thanks Martin for addressing the items I raised!

I've retested and here are some more comments.

1. When submitting a concern on the OPAC, there is no acknowledgement message,
for example like when you report a problem or make a purchase suggestion (such
as, "Your catalog concern report was submitted.") - you are just returned to
the record.

2. Last comment/update is prepopulated into the update field without a hard
page refresh:
   2.1 Click on the Details action for a concern
   2.2 Add a comment in the update field and click on comment
   2.3 Click on the details action again for the same concern without
refreshing the page: note that the update field is populated with the last
comment made
   2.4 Click on another concern: same results as 2.3
   2.5 If you click away to another page (or a hard referesh - Shift +
Refresh), and then go back to the catalog concerns page this doesn't happen.

3. Permissions to manage concerns - I still can't get this to work using the
editcatalog permission: 
   3.1 I added the editcatalog permission + all tools to a staff user (Henry).
   3.2 When I go to access catalog concerns (either from 'Pending catalog
concerns' on the home page or from the cataloging home page), I get "You do not
have permission to access this page" and the login form. 
   3.3 Without the permission, I don't see 'Pending catalog concerns' on the
home page or "Catalog concerns" on the Cataloguing home page (as expected).
   3.4 I also gave all permissions except "Access to all librarian functions
(superlibrarian)" and I still get the same permission error as in 3.2.

4. Details of concerns listed on the record details page are now shown,
however:
   4.1 If resolved, can still add comments, and can also click on resolve again
(using the koha superlibrarian user).
   4.2 Whereas, in the Cataloging > Catalog concerns area, once you have
resolved the concern the only option you have is the "Comment" button.
   4.2 If you don't have permission, can see the details in modal window and
the Resolve and Comment buttons are displayed. When attempting to make a
comment or resolve, the modal sits there with the "spinner" on the button.

5. Reporting a catalog concern from the staff interface - display of help text:
   5.1 If the help text has a bulleted list, the bullets aren't shown (add some
lines to the help text, make them into a bulleted list, report a problem in the
staff interface for a record).

6. Notices sent using email (see [1] for how I set up to test):
   8.1 Acknowledgement, update, and resolved notifications come through
(acknowledgement messages cam straight through, but update and resolved came
through when I ran misc/cronjobs/process_message_queue.pl).
   8.2 The notify message to CatalogersEmail address didn't come through and is
not in the message queue.
   8.3 Messages come through as a single line without any line breaks. Does the
notice need HTML tags for this? See [2] for examples of what was received.
   8.4 Only the 'Catalog concern updated' and 'Catalog concern resolved;
notices were displayed under the patron's record of notices - the
acknowledgement notice wasn't listed.

7. Setting CatalogerEmails - wrong name in test plan for patch 'Add email
notification of cataloguers on submissions' (CataloguerEmails should be
CatalogerEmails.

8. List of concerns - should it default to only displaying the unresolved
concerns? Otherwise, the list could get quite long... Maybe this should be a
separate bug if considered an issue, as I noticed that this is the same pattern
used for OPAC problem reports and AllowCheckoutNotes.

[1] Set up for testing notifications using Gmail when using KTD. Add this to
/etc/koha/sites/kohadev/koha-conf.xml, setup an App password for your Gmail
account, add the details as indicated, and add your Gmail address as the email
for a patron(s) used in testing:

<smtp_server>
    <host>smtp.gmail.com</host>
    <port>587</port>
    <timeout>5</timeout>
    <ssl_mode>STARTTLS</ssl_mode>
    <user_name>YOURGMAILADDRESS</user_name>
    <password>YOURAPPPASSWORD/password>
    <debug>1</debug>
 </smtp_server>

[2] Text of email messages - came through as a single line:

Acknowledgement:

Dear koha (42), Thankyou for your report concerning Lady Susan ; The Watsons ;
Sanditon / . You reported: **Describe the concern** A clear and concise
description of what the concern is. **To Reproduce** Steps to reproduce the
behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See
error **Expected behavior** A clear and concise description of what you
expected to happen. Thankyou 

Update:

Dear koha (42), The library has added an update to the concern you reported
against Lady Susan ; The Watsons ; Sanditon / . The following comment was left:
Send an update Thankyou 

Resolved:

Dear koha (42), The library has now marked your concern with Lady Susan ; The
Watsons ; Sanditon / as resolved. The following comment was left: This is now
fixed! Thankyou

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 22:53:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 21:53:41 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-q4vWF4K7jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:05:13 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-3ZegumkinZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #73 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143039&action=edit
Bug 26635: Add tests

Add tests in t/db_dependent/Koha/Object.t and
t/db_dependent/Koha/REST/Plugin/Objects.t

Sponsored-by: Virginia Polytechnic Institute and State University

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:05:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:05:20 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-bGpbK0aClU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #74 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143040&action=edit
Bug 26635: Expand authorised values in to_api method

This patch adds the posibility to expand authorised values when to_api
method is called.

The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following

{
  column_name => Koha::AuthorisedValue->unblessed
  ...
}

This patch will be used in bug 8179, so please test there.

Sponsored-by: Virginia Polytechnic Institute and State University

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:05:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:05:27 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-qp5oDIyNWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #75 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143041&action=edit
Bug 26635: Add tests for av-expand => 0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:05:35 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-AuufTOeMoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #76 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143042&action=edit
Bug 26635: AV expansion should ackowledge $params->{public}

This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.

It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:05:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:05:44 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-xKU6L1i1Wp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #77 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143043&action=edit
Bug 26635: Refined data structure and methods

This patch makes the returned data structure be simpler:

_str => {
    attribute_1 => {
        category => 'some_category_name',
        str      => 'description',
        type     => 'av'
    },
    ...
}

The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.

Tests are adjusted accordingly, also to reflect the public => 1 use
case.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:05:51 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-mGoJ4uNxp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #78 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143044&action=edit
Bug 26635: Move expand syntax to x-koha-embed

Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:

GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
    "_str": {
        "city": { "str": "Córdoba", ... }
    },
    ...
    "checkouts": [
        {
            ...,
            "item": {
                "_str": {
                    "not_for_loan_status": { "str": "Reference material", ...
},
                    ...
                },
                ...
            }
        }
    ]
}

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/Koha/REST/Plugin/Query.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:10:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:10:09 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-TA22Qr3MOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #79 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I haven't fully recovered, but... I get bored so...

I have submitted a revisited patch for revisiting the data structure and
methods, and then another interesting follow-up for getting rid of the
x-koha-expand-av flag, and just add a syntax for +av_expand on the
x-koha-embed, which makes a lot more sense and provides a fine-grained approach
instead of an all-or-nothing one.

I implemented things mostly as Jonathan proposed (I only added an obvious
'category' attribute).

We'll see how we later add 'str' counterpart for other types of things.

Please test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:16:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:16:27 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-uSrKSxYWQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Local use works a bit differently than the rest of the prefs so I think we need
to add the page-section for this directly in systempreferences.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:19:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:19:42 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-u32seHdq4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #3)
> I think this causes confusion then - either we should always have a single
> subpermission, or we should only have them if we have two?

Confusion for whom?

> For OPAC problem reports - we only seem to ever check the top permission
> For recalls we check the subpermission every time, except once
>
> Having two settings with the same behavior seems wrong to me

What do you mean by "two settings"?

For "OPAC problem reports management" and "Recalls", you get the same thing
whether you click the top level or the sub-permission, and that's clearly
indicated visually.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:21:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:21:52 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-pylN9oR6py@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:21:55 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-o4t8u5tZoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143045&action=edit
Bug 32006: Add page-section for local use system preferences

To test:
1. Go to the System preferences > Local use
2. Notice there is no page section and the table has much more space on the
left than other system preference sections
3. Apply patch
4. Look again, the extra space on the left should be eliminated and the
page-section should be added.
5. Use an HTML validator to spot errors.

Note: I elimiated the inline style on the table that set the width to 80%. I
don't see why that is needed but if it is we should be using CSS to do so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:24:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:24:20 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-LcA5BWIqHj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:25:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:25:27 +0000
Subject: [Koha-bugs] [Bug 32079] New: Add 'select all' to Tags page in OPAC
Message-ID: <bug-32079-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32079

            Bug ID: 32079
           Summary: Add 'select all' to Tags page in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

On the tags tab in the OPAC you can select multiple entries for deletion, but
you can only do it one by one using the checkboxes. It would be nice to have a
'select all/select none' toggle.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:38 +0000
Subject: [Koha-bugs] [Bug 31664] Show pending transfers on catalog details
 page
In-Reply-To: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31664-70-WdHPAFV93F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:41 +0000
Subject: [Koha-bugs] [Bug 31664] Show pending transfers on catalog details
 page
In-Reply-To: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31664-70-IKUznCSqb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31664

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:44 +0000
Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
In-Reply-To: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31876-70-txodnnMPQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:47 +0000
Subject: [Koha-bugs] [Bug 31876] Capitalization: Click to Expand this Tag
In-Reply-To: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31876-70-6NaQuOVQ5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31876

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:50 +0000
Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat
 this Tag
In-Reply-To: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31877-70-CKqnQ8B2z8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:52 +0000
Subject: [Koha-bugs] [Bug 31877] Capitalization: Delete this Tag and Repeat
 this Tag
In-Reply-To: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31877-70-gUxqHkl59q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31877

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:55 +0000
Subject: [Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
In-Reply-To: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32012-70-q6U5mpX8qV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:27:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:27:57 +0000
Subject: [Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
In-Reply-To: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32012-70-0tSlos6Tlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:00 +0000
Subject: [Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
In-Reply-To: <bug-32014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32014-70-h2ozNF7ZgH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:03 +0000
Subject: [Koha-bugs] [Bug 32014] Tweak style of checkout settings panel
In-Reply-To: <bug-32014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32014-70-5NXeNRxFQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32014

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:05 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-dodPf7L3Zu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:08 +0000
Subject: [Koha-bugs] [Bug 32035] "Koha" less prominent in new staff interface
In-Reply-To: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32035-70-iUbTlpkhvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32035

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:11 +0000
Subject: [Koha-bugs] [Bug 32038] Sidebar and footer style improvements on
 suggestions page
In-Reply-To: <bug-32038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32038-70-wI6fGtzSpD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:13 +0000
Subject: [Koha-bugs] [Bug 32038] Sidebar and footer style improvements on
 suggestions page
In-Reply-To: <bug-32038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32038-70-epZv2TPnFP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:15 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-RYqTH68zb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:18 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-WjCp3tJzDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:21 +0000
Subject: [Koha-bugs] [Bug 32050] Add 'page-section' to calendar page
In-Reply-To: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32050-70-EABO5tuxz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32050

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:23 +0000
Subject: [Koha-bugs] [Bug 32050] Add 'page-section' to calendar page
In-Reply-To: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32050-70-rl1MDHnD6E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32050

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:48 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-fhNSZtd9mj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:53 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-WEn7ZYaTEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142847|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143046&action=edit
Bug 31517: Replace raw SQL queries in C4::Tags with Koha object accesses

To test:
 1) Create a few new tags to any biblio by visiting the biblio's detail
 page on OPAC
 2) The visit http://localhost:8080/cgi-bin/koha/opac-tags.pl and try
 deleting those tags.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:28:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:28:58 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-X5QLGLJpmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142848|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143047&action=edit
Bug 31517: Remove unused get_tag function

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:29:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:29:02 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-Wiuv0s8VoW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143048&action=edit
Bug 31517: (QA follow-up) Fix indentation

Also removes commented out Data::Dumper.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:29:50 +0000
Subject: [Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer'
 checkin are not sent if modal is dismissed
In-Reply-To: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29792-70-UzVPsfikKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Summary|Transfers created from      |Transfers created from
                   |Wrong Transfer checkin are  |'wrong transfer' checkin
                   |not sent if modal is        |are not sent if modal is
                   |dismissed                   |dismissed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:44:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:44:01 +0000
Subject: [Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer'
 checkin are not sent if modal is dismissed
In-Reply-To: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29792-70-50G7JjVlox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:44:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:44:07 +0000
Subject: [Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer'
 checkin are not sent if modal is dismissed
In-Reply-To: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29792-70-gskdNc7xBP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141576|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143049&action=edit
Bug 29792: Automatically send wrong transfers

Bug 24434 reinstated the 'updateWrongTransfer' call here, but made the
assertion that
the transfer should not be sent until 'Ok' was clicked.

I see how unsent transfers are useful for rotation, but I believe for wrong
transfer we shouldn't require a confirm or print. If a library does want to,
the 'transfersblockcirc' system preference will enforce clicking the button
to continue

This patch also confirms a transfer when item already has a transfer and only
options are Confirm/Print because the transfer already exists

To test:
1 - Disable TransfersBlockCirc system preference
2 - Manually transfer an item from branch A to branch B
3 - Check in the item at branch A
4 - Dismiss modal without confirming
5 - View item on biblio details page, item not in transit
6 - Check in item, confirm transfer
7 - Note item in transit on details page
8 - Check in the item at branch C
9 - Dismiss modal without confirm
10 - View item on biblio detail, not in transit
11 - Checkin at A, cancel transfer
12 - Apply patch
13 - repeat 1 - 4
14 - Confirm item appears in transit
15 - Check in at branch C, dismiss modal
16 - Confirm item in transit

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:53:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:53:24 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-j09TkBk1Aj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Good call on adding functionality for key rotation!

The tricky thing is that we don't currently have a way of noting which key was
used to encrypt which field.

In master, I'm only seeing Koha::Encryption used in Koha::Patron, and within
Koha::Patron it's used in the function "encode_secret".

So we could put a "key_id" or "encrypt_key_id" field in the patron table row,
and then look up the key that way.

Then the re-encryption tool could take a source ID and a destination ID for
doing the re-encryption. 

If we wanted to automate it more, we could add additional metadata to the keys
to indicate something like "revoked", "preferred", or whatever. But I think
recording the key ID would be the first step. (You can see this all over AWS
with KMS IDs.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:56:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:56:29 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-qUmbhKk9Oe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:56:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:56:33 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-BCp5GR8TNE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142285|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143050&action=edit
Bug 31422: Add patron's current category to dropdown while editing

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:56:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:56:38 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-8HPG9wWMRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143051&action=edit
Bug 31422: (QA follow-up) Fix terminology and switch icon

* fa-exclamation-circle looks more like 'info', but I feel this
  should be more of a warning, so switched to fa-exclamation-triangle
* Changed branches to libraries in message

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  2 23:56:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 22:56:57 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-jZ12PsAuM4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks Nick for tackling this, it was bothering us quite a bit. 

I wonder if the warning should stand out even more. I have updated the image to
fa-exclamation-triangle to give it more of a warning character in the
follow-up. 

Maybe it would be nice to also have a confirmation message if the category was
changed?

Commit message could have more words! ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:01:22 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-NEygayn20R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Do we need the separator (last patch) for the OPAC too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:04:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:04:02 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-00TbeQniYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #17)
> When we upgraded
> from SHA to BCrypt for user account hashing we added a layer inside the
> codebase to upgrade the hash on first access I seem to recall.

We were upgrading from MD5 hashes to BCrypt hashes, which were easy to
differentiate, since the BCrypt hashes started with "$2a$08$".

We also had the user input so you could always compare hashes. In this case
with the decryption I don't think there's any way to know whether or not you
got a valid decrypted value (unless the encryption module throws an
exception)...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:05:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:05:20 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-R7i7V1v9GE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #20 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #18)
> OK.. I decided to open another bug for my thoughts on key change..
> 
> I'll pass this one but highlight to the RM that we may need to rethink the
> DB update.

I've commented on Bug 32078 with what I think would be a fairly straightforward
approach to allow key rotation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:09:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:09:32 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
 changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-2weztWipXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are scripts that delete older entries from action_logs, something to
think about if you don't want these to be deleted by accident.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:20:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:20:04 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order mulitple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-XCtfmJiyaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
To test:
* Create order
* Stage file of MARC records
* Order from staged file
* Select file 
* Select one or more records for ordering using the checkbox
* Save: You get: Some budgets are not defined in item records
* IMPORTANT: Set the funds on the "Default accounting details" tab
* Save again: nothing happens


New bug: that error is actually wrong too.... budgets should be funds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:33:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:33:13 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
 changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-UEXDMi4ZHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #11)
> There are scripts that delete older entries from action_logs, something to
> think about if you don't want these to be deleted by accident.

I suppose that's a problem we'll face with any kind of logging potentially.

But that does explain Kyle's suggestion of logging it outside of Koha. Log
rotation would be up to the sysadmins.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:34:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:34:17 +0000
Subject: [Koha-bugs] [Bug 32066] User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-ltNHeSq9do@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:39:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:39:21 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-trCtDSxOnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143052&action=edit
Bug 32028: Add page-section to smart-rules.tt and fix markup errors

To test:
1. Apply patch
2. Go to Adminstration > Circulation and fine rules
3. Look at the page-section added and make sure each looks good.
4. Use an HTML validator to check and make sure the HTML looks good.

Note: There are indentation changes and some fixes to bad markup ( stray tags,
etc ). Since there were quite a few mark-up errors I am attaching the
smart-rules.tt patch by itself. The rest of the Adminstration pages mentioned
will be in a single patch that is incoming!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 00:40:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Nov 2022 23:40:00 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-KnPICKi61N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 01:41:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 00:41:50 +0000
Subject: [Koha-bugs] [Bug 32080] New: Public lists not available after
 recent upgrade
Message-ID: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

            Bug ID: 32080
           Summary: Public lists not available after recent upgrade
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: snicker1 at maine.rr.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I recently upgraded the Debian package version from 19.11.03.000 to the
latest 22.05.04.000 (including the underlying OS upgrades as well) and now
no one is able to view any of the "Public Lists" and get a 500 error when
trying.   Opac-error.log shows this ("USERID" is my userid and "WEBSITE" is the
hostname in the messages below):



Mon Oct 24 17:44:32.268569 2022] [cgi:error] [pid 22000] [client
x.x.x.x:5322] AH01215: DBIx::Class::Storage::DBI::select_single(): Query
returned more than one row.  SQL that returns multiple rows is DEPRECATED
for ->find and ->single at /usr/share/koha/lib/Koha/Objects.pm line 96:
/usr/share/koha/opac/cgi-bin/opac/opac-suggestions.pl

[Mon Oct 24 17:44:39.651936 2022] [cgi:error] [pid 21984] [client
x.x.x.x:56417] AH01215: Use of inherited AUTOLOAD for non-method
Koha::Virtualshelf::haspermission() is deprecated at
/usr/share/koha/lib/Koha/Virtualshelf.pm line 247.:
/usr/share/koha/opac/cgi-bin/opac/opac-shelves.pl, referer:
http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=1

[Mon Oct 24 17:44:39.652426 2022] [cgi:error] [pid 21984] [client
x.x.x.x:56417] AH01215: Template process failed: undef error - Can't locate
object method "_columns" via package "USERID" (perhaps you forgot to load
"USERID"?) at /usr/share/koha/lib/Koha/Object.pm line 858.:
/usr/share/koha/opac/cgi-bin/opac/opac-shelves.pl, referer:
http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=1

[Mon Oct 24 17:44:39.695408 2022] [cgi:error] [pid 21984] [client
x.x.x.x:56417] End of script output before headers: opac-shelves.pl,
referer: http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list
<http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=
1> &public=1


I did look in the database itself and do find a count of 93 items in the
'virtualshelves' table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:12:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:12:56 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-pFKqYZOgOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:13:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:13:02 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-IYqcF6xTs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #37 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143053&action=edit
Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:17:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:17:29 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and
 charge hold fee is HoldFeeMode conditions are true as described in the
 system preference
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-LOf3QoVRPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This patch ensures          |When HoldFeeMode is set to
      release notes|HoldFeeMode is considered   |not_always or "only if all
                   |when displaying a message   |items are checked out and
                   |to patrons on the OPAC that |the record has at least one
                   |says they'll be charged a   |hold already", Koha will
                   |hold fee when placing or    |unexpectedly show a hold
                   |collecting the hold.
       |fee message and charge a
                   |
                           |hold fee if at least one of
                   |When                        |those conditions are met.
                   |HoldFeeMode is set to       |
                   |not_always or "only if all  |This patch fixes the
                   |items are checked out and   |behaviour so that a hold
                   |the record has at least one |fee message is only shown,
                   |hold already" then the hold |and hold fee only charged,
                   |fee message should only     |if all items on the record
                   |show if all items on the    |are checked out, AND the
                   |record are checked out, AND |record has at least one
                   |the record has at least one |hold already - both of
                   |hold already - both of      |these conditions must be
                   |these conditions must be    |met, as the system
                   |met.                        |preference implies.
            Summary|Only show hold fee message  |Only show hold fee message
                   |on OPAC if they will        |on OPAC and charge hold fee
                   |actually be charged         |is HoldFeeMode conditions
                   |                            |are true as described in
                   |                            |the system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:17:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:17:51 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and
 charge hold fee is HoldFeeMode conditions are true as described in the
 system preference
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-E1sStN7fe0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #4)
> Can you please update the bug description/title and release notes to be more
> clear about this not only affecting display please?

I've done an update, hopefully that's better

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:18:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:18:02 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and
 charge hold fee if HoldFeeMode conditions are true as described in the
 system preference
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-NdEDxu7wYN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Only show hold fee message  |Only show hold fee message
                   |on OPAC and charge hold fee |on OPAC and charge hold fee
                   |is HoldFeeMode conditions   |if HoldFeeMode conditions
                   |are true as described in    |are true as described in
                   |the system preference       |the system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:39:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:39:27 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-jva50hc3Sh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:39:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:39:33 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-nHKBuBcfuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143045|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 143054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143054&action=edit
Bug 32006: Add page-section for local use system preferences

To test:
1. Go to the System preferences > Local use
2. Notice there is no page section and the table has much more space on the
left than other system preference sections
3. Apply patch
4. Look again, the extra space on the left should be eliminated and the
page-section should be added.
5. Use an HTML validator to spot errors.

Note: I elimiated the inline style on the table that set the width to 80%. I
don't see why that is needed but if it is we should be using CSS to do so.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:40:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:40:34 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-x5Tl6uTEGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Testing notes:

- Used https://www.gueury.com/mozilla/index.html as an HTML validator for
Firefox.

- Lots of warnings, but no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:53:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:53:53 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-Yx2mea9ehI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 02:53:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 01:53:58 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-J1FFZc1mvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143026|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143055&action=edit
Bug 32076: Add page-section to basketgroup.tt and clean-up markup

This patch adds the page-section div to the basket group 'Ungrouped baskets'.
It also adds the row class to the fieldset to get the list to display properly.

To test:
1. Apply patch
2. Make sure the page section div for 'Ungrouped baskets' looks good.
3. Look at the markup changes and make sure the make sense.
4. Make sure the form still works as it should.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 03:05:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 02:05:02 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-S8Qv7M4uNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141801|0                           |1
        is obsolete|                            |

--- Comment #107 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143056&action=edit
Bug 31378: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 03:14:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 02:14:50 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-CFqmf5ksMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143056|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 03:16:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 02:16:06 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-5XPHWK0X3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #108 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to David Cook from comment #105)
> I appreciate the replacement of "Authentication provider" being changed to
> "Identity provider" and "tranverse_hash" being changed to "traverse_hash",
> but it looks like every other issue I described last time is still present
> in the Gitlab version...
> 
> I have to fail this again, because several of the features don't work. 
> 
> Before I test this again, I'd like someone to confirm that they've looked at
> my "FIXME" comments, and fixed them (or at least provide a reason for not
> fixing them).

Hi David, could you please try again?

I've attended to all your valuable FIXME comments in the last patch. 

Please let me know what you think.

Thanks so much!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:26 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-ZJvlh1ADTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:31 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-6ygzog330e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142905|0                           |1
        is obsolete|                            |

--- Comment #38 from David Nind <david at davidnind.com> ---
Created attachment 143057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143057&action=edit
Bug 30358: Strip leading/trailing whitespace characters from input fields when
cataloguing

This enhancement adds a system preference StripWhitespaceChars which,
when enabled, will strip leading and trailing whitespace characters from
all fields when cataloguing both bibliographic records and authority
records. Whitespace characters that will be stripped are:
- spaces
- newlines
- carriage returns
- tabs

To test:
1. Apply patch and install database updates
2. Go to Administration, system preferences, find the new
StripWhitespaceChars preference. It should be "Don't strip" by default.
Change it to "Strip".
3. Search for a biblio record and edit it. Put some leading or trailing
whitespace characters in input fields and textarea fields and save.
4. Confirm these characters are removed when you save the record.
5. Repeat steps 3 and 4 for authority records.
6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t

Sponsored-by: Educational Services Australia SCIS

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:37 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-xEzt3nyZHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142906|0                           |1
        is obsolete|                            |

--- Comment #39 from David Nind <david at davidnind.com> ---
Created attachment 143058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143058&action=edit
Bug 30358: (follow-up) Also strip inner newlines

This patch amends the StripWhitespaceChars system preference to also
strip inner newlines (line breaks and carriage returns) when enabled.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:42 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-mx01eFvYqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142907|0                           |1
        is obsolete|                            |

--- Comment #40 from David Nind <david at davidnind.com> ---
Created attachment 143059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143059&action=edit
Bug 30358: (follow-up) Inner newlines should be replaced with a space

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:47 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-9GkyOCXB67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142908|0                           |1
        is obsolete|                            |

--- Comment #41 from David Nind <david at davidnind.com> ---
Created attachment 143060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143060&action=edit
Bug 30358: (follow-up) Fixing tests and including for inner newlines

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:52 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-AiS6oHtHCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142909|0                           |1
        is obsolete|                            |

--- Comment #42 from David Nind <david at davidnind.com> ---
Created attachment 143061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143061&action=edit
Bug 30358: (follow-up) Clarify syspref wording about fields affected

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:34:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:34:58 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-XRq2dnPWay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142910|0                           |1
        is obsolete|                            |

--- Comment #43 from David Nind <david at davidnind.com> ---
Created attachment 143062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143062&action=edit
Bug 30358: (follow-up) Consider field has multiple subfields of same key

To test:

1) Click the clone subfield button to make multiple subfields with the
same key, i.e. 500$a$a$a
2) Save the record and confirm that the fields contain the correct data
after whitespaces are stripped.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:35:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:35:04 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-45n2RgDRyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142911|0                           |1
        is obsolete|                            |

--- Comment #44 from David Nind <david at davidnind.com> ---
Created attachment 143063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143063&action=edit
Bug 30358: (follow-up) Put multiple subfields fix on auth side

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:35:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:35:09 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-IVUfuN7V7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142912|0                           |1
        is obsolete|                            |

--- Comment #45 from David Nind <david at davidnind.com> ---
Created attachment 143064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143064&action=edit
Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests

To test:

Confirm test plan above still works as expected and tests pass in
t/Koha_MetadataRecord.t

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 07:35:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 06:35:15 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-ZRkHiO758k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143053|0                           |1
        is obsolete|                            |

--- Comment #46 from David Nind <david at davidnind.com> ---
Created attachment 143065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143065&action=edit
Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 08:21:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 07:21:17 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-kb5rwt4Ywl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Blou from comment #11)
> The last patch "import issue" fixes a crash in 22.05.06 (at least).
> 
> I haven't managed to apply the whole set on Koha/VirtualShelf.pm, because of
> Bug 30933.  It's a rabbit hole, but without it we get a 500 on public lists
> when logged in the OPAC.

See also bug 32080.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 08:24:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 07:24:37 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-tP6ABHO4ho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29955
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Steven Nickerson from comment #0)
> [Mon Oct 24 17:44:39.651936 2022] [cgi:error] [pid 21984] [client
> x.x.x.x:56417] AH01215: Use of inherited AUTOLOAD for non-method
> Koha::Virtualshelf::haspermission() is deprecated at
> /usr/share/koha/lib/Koha/Virtualshelf.pm line 247.:
> /usr/share/koha/opac/cgi-bin/opac/opac-shelves.pl, referer:
> http://WEBSITE/cgi-bin/koha/opac-shelves.pl?op=list&public=1

    return 1
      if $self->is_public and haspermission( $patron->userid, { lists =>
'edit_public_lists' } );

This is corrected in master with:
    return 1
      if $self->is_public and C4::Auth::haspermission( $patron->userid, { lists
=> 'edit_public_lists' } );

Solved on Bug 29955: Fix method import issues
This fix should be backported.

Trying to catch the attention of the 22.05 RMaint: Lucas Gass.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 08:24:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 07:24:37 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-cz3pij3SPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32080

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 08:29:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 07:29:04 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-G7qvTGJtVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Setting the keyword for his version - agreed with Lucas on that so that he can
spot those requests easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 08:43:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 07:43:21 +0000
Subject: [Koha-bugs] [Bug 32066] User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-SoWKYrjOk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #1)
> This change should fix the problem.
> 
> diff --git a/C4/Auth.pm b/C4/Auth.pm
> index b6933e4cc60..8bd13e88e1f 100644
> --- a/C4/Auth.pm
> +++ b/C4/Auth.pm
> @@ -1784,11 +1784,13 @@ sub check_cookie_auth {
>                      $session->param('desk_id'),     
> $session->param('desk_name'),
>                      $session->param('register_id'), 
> $session->param('register_name')
>                  );
> -                return ( "additional-auth-needed", $session )
> -                    if $session->param('waiting-for-2FA');
> +                if ( C4::Context->preference('TwoFactorAuthentication') ne
> 'disabled' ) {
> +                    return ( "additional-auth-needed", $session )
> +                        if $session->param('waiting-for-2FA');
> .
> -                return ( "setup-additional-auth-needed", $session )
> -                    if $session->param('waiting-for-2FA-setup');
> +                    return ( "setup-additional-auth-needed", $session )
> +                        if $session->param('waiting-for-2FA-setup');
> +                }
> .
>                  return ( "ok", $session );
>              } else {

Note that this diff contains a few strange dots that block applying it
directly. No problem. I will have a look now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:16:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:16:21 +0000
Subject: [Koha-bugs] [Bug 32066] User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-r0FIezsZTf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:16:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:16:25 +0000
Subject: [Koha-bugs] [Bug 32066] User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-Ta7ctVLYdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143066&action=edit
Bug 32066: Check 2FA pref in check_cookie_auth

Test plan:
Without this patch:
1. Set the syspref TwoFactorAuthentication (enforce or enabled)
2. Configure 2FA for a patron
3. Logout
4. Authenticate but don't enter the 2FA code
5. Switch off the syspref (disabled) [via another browser or so]
6. Patron is stuck on the [original] login screen. [Only removing
   the session cookie would resolve it.]
With this patch:
1. Follow the steps above again. But note that you can refresh
   your browser window to get in now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:16:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:16:41 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User can get stuck on login screen
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-7f2lbCGEe1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|User can get stuck on login |2FA: User can get stuck on
                   |screen                      |login screen

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:17:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:17:03 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck on login screen
 when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-OlwFhBqDCB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|2FA: User can get stuck on  |2FA: User could get stuck
                   |login screen                |on login screen when
                   |                            |disabling pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:17:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:17:17 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-0JZuRgqIHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|2FA: User could get stuck   |2FA: User could get stuck
                   |on login screen when        |temporarily on login screen
                   |disabling pref              |when disabling pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:17:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:17:57 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-tGs9EyOJbM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:18:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:18:24 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-mpBPBYu4aH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I will still have a look at unit testing now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:20:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:20:02 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-wmUeLhqge7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

--- Comment #7 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to Katrin Fischer from comment #4)
> Hi Thibaud, 
> 
> please make sure to run the QA tools on your patches and to set your editor
> to use 4 spaces for indentation instead of tabs:
> 
>  FAIL
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/
> unimarc_field_110.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 37)
> 		forbidden pattern: tab char (line 38)
> 		forbidden pattern: tab char (line 39)
> 		forbidden pattern: tab char (line 40)
> 		forbidden pattern: tab char (line 42)
> 		forbidden pattern: tab char (line 43)
> 		forbidden pattern: tab char (line 44)
> 		forbidden pattern: tab char (line 45)
> 		forbidden pattern: tab char (line 47)
> 		forbidden pattern: tab char (line 48)
> 		forbidden pattern: tab char (line 49)
> 		forbidden pattern: tab char (line 50)
> 		forbidden pattern: tab char (line 52)
> 		forbidden pattern: tab char (line 53)
> 		forbidden pattern: tab char (line 54)
> 		forbidden pattern: tab char (line 55)
> 		forbidden pattern: tab char (line 57)
> 		forbidden pattern: tab char (line 58)
> 		forbidden pattern: tab char (line 59)
> 		forbidden pattern: tab char (line 60)
> 		forbidden pattern: tab char (line 62)
> 		forbidden pattern: tab char (line 63)
> 		forbidden pattern: tab char (line 64)
> 		forbidden pattern: tab char (line 65)
> 		forbidden pattern: tab char (line 67)
> 		forbidden pattern: tab char (line 68)
> 		forbidden pattern: tab char (line 69)
> 		forbidden pattern: tab char (line 70)
> 		forbidden pattern: tab char (line 72)
> 		forbidden pattern: tab char (line 73)
> 		forbidden pattern: tab char (line 74)
> 		forbidden pattern: tab char (line 75)
> 		forbidden pattern: tab char (line 77)
> 		forbidden pattern: tab char (line 78)
> 		forbidden pattern: tab char (line 79)
> 		forbidden pattern: tab char (line 80)
> 		forbidden pattern: tab char (line 184)
> 		forbidden pattern: tab char (line 185)
> 		forbidden pattern: tab char (line 186)
> 		forbidden pattern: tab char (line 187)
> 
> Will fix in a follow-up!

Oh sorry, it's my bad I forgot it... thanks to you and I will remember next
time :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:20:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:20:18 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-5PQiUawygX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143066|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143067&action=edit
Bug 32066: Check 2FA pref in check_cookie_auth

Test plan:
Without this patch:
1. Set the syspref TwoFactorAuthentication (enforce or enabled)
2. Configure 2FA for a patron
3. Logout
4. Authenticate but don't enter the 2FA code
5. Switch off the syspref (disabled) [via another browser or so]
6. Patron is stuck on the [original] login screen. [Only removing
   the session cookie would resolve it.]
With this patch:
1. Follow the steps above again. But note that you can refresh
   your browser window to get in now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:32:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:32:25 +0000
Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item
 fields
In-Reply-To: <bug-31550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31550-70-qAS2Shr68D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

--- Comment #5 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to David Nind from comment #4)
> I'm getting this error after applying the patch (using koha-testing-docker -
> flush_memcached, restart_all, and browser cached cleared after patch
> applied):
> 
> Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload
> C4/ILSDI/Services.pm aborted.
> Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22.
> BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22.
>  at /usr/share/perl5/CGI/Compile.pm line 144
> 
>     in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144
> 
>       141:         my $code = $self->_eval($eval);
>       142:         my $exception = $@;
>       143: 
>       144:         die "Could not compile $script: $exception" if $exception;
>       145: 
>       146:         subname "${package}::$subname", sub {
>       147:             my @args = @_;
> 
>     Show function arguments
> ....
> 
> Testing notes:
> 1. Added OPAC descriptions for CCODE authorised values.
> 2. Tested with sample data using:
> http://127.0.0.1:8081/cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=262

Thanks for your feeback, I restart from zero, apply this patch but I can't
reproduce the bug.. this apparently comes from the ILS-DI service so I will try
later like you in kohadevbox to see if the problem still be. (Thanks for you
link but it concern your localhost - 127.0.0.1 so I can see your record)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:33:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:33:03 +0000
Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item
 fields
In-Reply-To: <bug-31550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31550-70-NQvLvuygaP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

Thibaud Guillot <thibaud.guillot at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:33:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:33:03 +0000
Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item
 fields
In-Reply-To: <bug-31550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31550-70-6IUvm3x2Hm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

Thibaud Guillot <thibaud.guillot at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 09:43:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 08:43:37 +0000
Subject: [Koha-bugs] [Bug 32081] New: Add OpacBrowseSearch functionality to
 lists
Message-ID: <bug-32081-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32081

            Bug ID: 32081
           Summary: Add OpacBrowseSearch functionality to lists
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It should be a nice feature adding the functionality of browse within a list,
as it is in result list, next record instead of browse back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:01:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:01:31 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-G7FuxuzAg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #1)
> -                return ( "setup-additional-auth-needed", $session )
> -                    if $session->param('waiting-for-2FA-setup');
> +                    return ( "setup-additional-auth-needed", $session )
> +                        if $session->param('waiting-for-2FA-setup');
> +                }

I am still thinking about this second case btw. Not sure yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:16:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:16:44 +0000
Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required
 / allow indefinite subscriptions
In-Reply-To: <bug-5276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5276-70-BnwKYx13vN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276

Michaela Sieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:22:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:22:17 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-ydzMWrb5cr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:36:30 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-EFdhHtAOcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:36:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:36:35 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-9ANuS6T4x5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143055|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143068&action=edit
Bug 32076: Add page-section to basketgroup.tt and clean-up markup

This patch adds the page-section div to the basket group 'Ungrouped baskets'.
It also adds the row class to the fieldset to get the list to display properly.

To test:
1. Apply patch
2. Make sure the page section div for 'Ungrouped baskets' looks good.
3. Look at the markup changes and make sure the make sense.
4. Make sure the form still works as it should.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:39:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:39:59 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-kMozT2jcXS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Nice fix, thx Lucas. Could you maybe take a look at bug 31819?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:41:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:41:47 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-11dc3maEFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

--- Comment #45 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143069&action=edit
Bug 13600: (follow-up) Add seperator on the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:44:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:44:59 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-RDujqLdHxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:45:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:45:04 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-uAaIECjEpd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143054|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143070&action=edit
Bug 32006: Add page-section for local use system preferences

To test:
1. Go to the System preferences > Local use
2. Notice there is no page section and the table has much more space on the
left than other system preference sections
3. Apply patch
4. Look again, the extra space on the left should be eliminated and the
page-section should be added.
5. Use an HTML validator to spot errors.

Note: I elimiated the inline style on the table that set the width to 80%. I
don't see why that is needed but if it is we should be using CSS to do so.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:45:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:45:29 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-JMRcZwAUtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 10:51:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 09:51:00 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-Ya5rVo4P0v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Cook from comment #4)
> (In reply to Nick Clemens from comment #3)
> > I think this causes confusion then - either we should always have a single
> > subpermission, or we should only have them if we have two?
> 
> Confusion for whom?

For developers, or users. Why does problem reports have a subpermission, and
edit authorities does not?

> 
> > For OPAC problem reports - we only seem to ever check the top permission
> > For recalls we check the subpermission every time, except once
> >
> > Having two settings with the same behavior seems wrong to me
> 
> What do you mean by "two settings"?

flagsrequired   => { recalls => "manage_recalls" }
flagsrequired => { recalls => 1 }

These are checking two different things, but provide the same answer

> 
> For "OPAC problem reports management" and "Recalls", you get the same thing
> whether you click the top level or the sub-permission, and that's clearly
> indicated visually.

Sure, but then why is the subpermission added at all? If it is the same as
clicking the top level, let's not provide two checkboxes when one will do

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:01:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:01:31 +0000
Subject: [Koha-bugs] [Bug 32082] New: CanBookBeReserved with itype option is
 a different subroutine and should be split out
Message-ID: <bug-32082-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32082

            Bug ID: 32082
           Summary: CanBookBeReserved with itype option is a different
                    subroutine and should be split out
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The call to this routine with param itemtype is self contained code that in
fact checks CanItemtypeBeReserved

Calling it as CanBookBeReturned passes ReservesControlBranch as pickup_location
- it's a bad smell

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:11:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:11:14 +0000
Subject: [Koha-bugs] [Bug 32082] CanBookBeReserved with itype option is a
 different subroutine and should be split out
In-Reply-To: <bug-32082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32082-70-nJK8j0gKQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32082

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:17:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:17:43 +0000
Subject: [Koha-bugs] [Bug 32083] New: POD for GetMaxPatronHoldsForRecord
 references ReservesControlBranch
Message-ID: <bug-32083-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32083

            Bug ID: 32083
           Summary: POD for GetMaxPatronHoldsForRecord references
                    ReservesControlBranch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Example usage names wrong routine

2331 =head2 GetMaxPatronHoldsForRecord
2332 
2333 my $holds_per_record = ReservesControlBranch( $borrowernumber,     
$biblionumber );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:17:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:17:51 +0000
Subject: [Koha-bugs] [Bug 32083] POD for GetMaxPatronHoldsForRecord
 references ReservesControlBranch
In-Reply-To: <bug-32083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32083-70-lcmWG04rUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32083

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:29:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:29:28 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-th4d3tUQri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #6)
> (In reply to Jonathan Druart from comment #1)
> > -                return ( "setup-additional-auth-needed", $session )
> > -                    if $session->param('waiting-for-2FA-setup');
> > +                    return ( "setup-additional-auth-needed", $session )
> > +                        if $session->param('waiting-for-2FA-setup');
> > +                }
> 
> I am still thinking about this second case btw. Not sure yet.

The change actually seems to be unneeded. But it is hard to catch why checkauth
allows the login if cookie_auth returned:
[2022/11/03 10:20:14] [WARN] L853:setup-additional-auth-needed: at
/usr/share/koha/C4/Auth.pm line 853.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:31:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:31:53 +0000
Subject: [Koha-bugs] [Bug 32084] New: GetMaxPatronHoldsForRecord is
 incorrect and inefficient
Message-ID: <bug-32084-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32084

            Bug ID: 32084
           Summary: GetMaxPatronHoldsForRecord is incorrect and
                    inefficient
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This routine claims to return the max number of holds a patron can place on a
record, however, it does not take into account whether a patron can hold an
itemtype or not, so may be inflating the maximum number when the patron cannot
in fact hold those items

Additionally, the routine makes a call for effective circulation rule per item.

We really only need to call once per itemtype and branch combination - if
reserves control branch is 'patrons library' then it is really only once per
itemtype on the biblio

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:32:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:32:06 +0000
Subject: [Koha-bugs] [Bug 32084] GetMaxPatronHoldsForRecord is incorrect and
 inefficient
In-Reply-To: <bug-32084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32084-70-BdYlqZufYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32084

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:52:14 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-ZpjfvzDug2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > (In reply to Jonathan Druart from comment #1)
> > > -                return ( "setup-additional-auth-needed", $session )
> > > -                    if $session->param('waiting-for-2FA-setup');
> > > +                    return ( "setup-additional-auth-needed", $session )
> > > +                        if $session->param('waiting-for-2FA-setup');
> > > +                }
> > 
> > I am still thinking about this second case btw. Not sure yet.
> 
> The change actually seems to be unneeded. But it is hard to catch why
> checkauth allows the login if cookie_auth returned:
> [2022/11/03 10:20:14] [WARN] L853:setup-additional-auth-needed: at
> /usr/share/koha/C4/Auth.pm line 853.

Hmm. What happens is that the q_userid and password are checked again with
checkpw and are fine. So login is granted.
It seems that checkauth might need more attention in responding to the
setup-additional-auth-needed response of cookie_auth?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:57:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:57:52 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-QijHL3Hh2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:57:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:57:56 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-evOuUejfey@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143071&action=edit
Bug 32066: Add unit test to Auth.t

Test plan:
Run without next patch. Should fail.
Run with next patch. Should pass.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:58:00 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-I5tfT5S0b2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143067|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143072&action=edit
Bug 32066: Check 2FA pref in check_cookie_auth

Test plan:

Without this patch:
1. Set the syspref TwoFactorAuthentication (enforce or enabled)
2. Configure 2FA for a patron
3. Logout
4. Authenticate but don't enter the 2FA code
5. Switch off the syspref (disabled) [via another browser or so]
6. Patron is stuck on the [original] login screen. [Only removing
   the session cookie would resolve it.]

With this patch:
1. Follow the steps above again. But note that you can refresh
   your browser window to get in now.
2. Verify that Auth.t passes now too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:58:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:58:15 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-zxBsG8JLm1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 11:59:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 10:59:21 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-ZYCHh4ITmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
See my earlier remarks about checkauth and the setup flag. But I agree with
this patch. Further refinements might be possible on follow-up reports.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:06:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:06:09 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-enNGCQDuB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, looks good, passes QA tests and unit tests, but couldn't finish
testing here (ran out of time).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:24:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:24:26 +0000
Subject: [Koha-bugs] [Bug 32085] New: Consistent classes for primary
 buttons: Circulation
Message-ID: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

            Bug ID: 32085
           Summary: Consistent classes for primary buttons: Circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in label-creation templates so that buttons
which are currently styled as primary buttons will have the the "btn
btn-primary" classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:24:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:24:26 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-YtYuaA5Gpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32085


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085
[Bug 32085] Consistent classes for primary buttons: Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:25:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:25:21 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-9yOU6GVIK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Consistent classes for      |Consistent classes for
                   |primary buttons:            |primary buttons: Labels
                   |Circulation                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:29:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:29:42 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-fePlHNVo3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143039|0                           |1
        is obsolete|                            |

--- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143073&action=edit
Bug 26635: Add tests

Add tests in t/db_dependent/Koha/Object.t and
t/db_dependent/Koha/REST/Plugin/Objects.t

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:29:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:29:48 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-fV7mAegbcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143040|0                           |1
        is obsolete|                            |

--- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143074&action=edit
Bug 26635: Expand authorised values in to_api method

This patch adds the posibility to expand authorised values when to_api
method is called.

The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following

{
  column_name => Koha::AuthorisedValue->unblessed
  ...
}

This patch will be used in bug 8179, so please test there.

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:29:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:29:54 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-SHCd2bxrsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143041|0                           |1
        is obsolete|                            |

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143075&action=edit
Bug 26635: Add tests for av-expand => 0

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:29:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:29:59 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-jQnzslsAZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143042|0                           |1
        is obsolete|                            |

--- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143076&action=edit
Bug 26635: AV expansion should ackowledge $params->{public}

This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.

It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:30:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:30:06 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-sJvuwLFQ5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143043|0                           |1
        is obsolete|                            |

--- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143077&action=edit
Bug 26635: Refined data structure and methods

This patch makes the returned data structure be simpler:

_str => {
    attribute_1 => {
        category => 'some_category_name',
        str      => 'description',
        type     => 'av'
    },
    ...
}

The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.

Tests are adjusted accordingly, also to reflect the public => 1 use
case.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:30:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:30:12 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-UAD5DSzK9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143044|0                           |1
        is obsolete|                            |

--- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143078&action=edit
Bug 26635: Move expand syntax to x-koha-embed

Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:

GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
    "_str": {
        "city": { "str": "Córdoba", ... }
    },
    ...
    "checkouts": [
        {
            ...,
            "item": {
                "_str": {
                    "not_for_loan_status": { "str": "Reference material", ...
},
                    ...
                },
                ...
            }
        }
    ]
}

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/Koha/REST/Plugin/Query.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:30:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:30:19 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-us64ZILnLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143079&action=edit
Bug 26635: (follow-up) Add optional support for `:` as the modifier

This patch adds optional support for using `:` as the modifier for
invoking the 'count' method for relations as discussed.

We retain support for `+` for backward compatability to prevent a
breaking change.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:30:25 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-61qZRvb0rp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143080&action=edit
Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header

This patch updates the last remaining test that mentioned the now defunkt
x-koha-av-expand header.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:32:35 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-DD0wdkBW2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:32:39 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-bJDquHgoHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143081&action=edit
Bug 32085: Consistent classes for primary buttons: Labels

This patch makes changes the button markup in label-creation templates
-- including the barcode image generator -- so that all submit buttons
and any buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view label-related pages to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:33:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:33:44 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-RQ6cv3wKom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm loving this… signing off.

The one very, very minor niggle… I'm wondering if `+av_expand` is right; With
us switching to _str to generalize it, perhaps the key string should be
`+str_expand` or `+code_expand`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:47:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:47:16 +0000
Subject: [Koha-bugs] [Bug 32086] New: Consistent classes for primary
 buttons: Patrons
Message-ID: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

            Bug ID: 32086
           Summary: Consistent classes for primary buttons: Patrons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 32085

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in patron module templates so that buttons which
are currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085
[Bug 32085] Consistent classes for primary buttons: Labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 12:47:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 11:47:16 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-aGSVXUgKhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32086


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086
[Bug 32086] Consistent classes for primary buttons: Patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:31 +0000
Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs
In-Reply-To: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31943-70-Z4dJaVPzsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:34 +0000
Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs
In-Reply-To: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31943-70-qJTNnw4YvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:36 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-c489LmxdQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:39 +0000
Subject: [Koha-bugs] [Bug 31960] Information on job detail view is misaligned
In-Reply-To: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31960-70-RM1bac3afx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:42 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and
 charge hold fee if HoldFeeMode conditions are true as described in the
 system preference
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-uF0MbmKn3V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:45 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and
 charge hold fee if HoldFeeMode conditions are true as described in the
 system preference
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-V5mZZmV8TI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:48 +0000
Subject: [Koha-bugs] [Bug 32002] Make submit button yellow on administration
 > Did you mean?
In-Reply-To: <bug-32002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32002-70-vkethqAYlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32002

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:50 +0000
Subject: [Koha-bugs] [Bug 32002] Make submit button yellow on administration
 > Did you mean?
In-Reply-To: <bug-32002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32002-70-zA5Zgn7pKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32002

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:53 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-0XZDo8t8g6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:55 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-LWoRP4flwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:55 +0000
Subject: [Koha-bugs] [Bug 32068] Consistent classes for primary buttons:
 Administration
In-Reply-To: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32068-70-THzoGZKAzF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32068

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:58 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-DQLol6Tt3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:05:58 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-w3zGgiTrfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143082&action=edit
Bug 32086: Consistent classes for primary buttons: Patrons

This patch makes changes the button markup in patron
module templates so that all submit buttons and any buttons that should
should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron module pages to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:06:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:06:00 +0000
Subject: [Koha-bugs] [Bug 32070] Consistent classes for primary buttons:
 Acquisitions
In-Reply-To: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32070-70-kC9fdh5ZzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32070

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:07:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:07:01 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-nQjIgOPHpn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:07:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:07:05 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-lkGttAwTvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142791|0                           |1
        is obsolete|                            |

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143083&action=edit
Bug 8948: Display MARC 787 relationship field

This field is defined similar to 775, as a related work:
https://www.loc.gov/marc/bibliographic/bd787.html

This patch adds a display of this field, linking to the referenced record as
the 775 does

It also tests for 580 field, and displays the text there if present, using the
787 a and t subfields otherwise

To test:
1 - Edit the default framework to make 787atw and 580a visible in editor
2 - Add a 787 to a record:
    $tThe ideas behind the chess openings
    $aFine, Reuben<
    $w2470231
3 - Confirm there is no display
4 - Apply patch / restart all
5 - 'Other related works' now shows
6 - Link should be using title of record
7 - Set system preference UseControlNumber to Use
8 - Reload details, link should now use control number
9 - Add a 580 to the record:
    $a This is a friendly work to this one
10 - Confirm the text of the link now displays before the link
11 - Add a second 580, confirm it displays as well
   - there is no seperator as each should end with a period or other
punctuation according to MARC
   - there is a dpan with a class surrounding each so styling can be added as
desired
12 - Add a second 787
   - confirm seperator present and wrapped in a span with a class
   - confirm each 787 is shown with a span/class for styling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:07:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:07:10 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-ezBMODTxRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143084&action=edit
Bug 8948: Changes for OPAC

Test with same record, confirm OPAC view is as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:08:48 +0000
Subject: [Koha-bugs] [Bug 32087] New: Consistent classes for primary
 buttons: Course reserves
Message-ID: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

            Bug ID: 32087
           Summary: Consistent classes for primary buttons: Course
                    reserves
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in course reserve templates so that buttons
which are currently styled as primary buttons will have the the "btn
btn-primary" classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:08:48 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-QtopMpAoKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32087


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087
[Bug 32087] Consistent classes for primary buttons: Course reserves
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:13:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:13:51 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-zqcx0iF6Ig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:13:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:13:55 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-ReZNUM7Ek9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143085&action=edit
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:16:00 +0000
Subject: [Koha-bugs] [Bug 32088] New: Consistent classes for primary
 buttons: Patron card creator
Message-ID: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

            Bug ID: 32088
           Summary: Consistent classes for primary buttons: Patron card
                    creator
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in patron card creator templates so that buttons
which are currently styled as primary buttons will have the the "btn
btn-primary" classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:16:00 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-PKGTtxfXP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32088


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088
[Bug 32088] Consistent classes for primary buttons: Patron card creator
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:19:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:19:22 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-JRf0mMIfei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #89 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #88)
> I'm loving this… signing off.
> 
> The one very, very minor niggle… I'm wondering if `+av_expand` is right;
> With us switching to _str to generalize it, perhaps the key string should be
> `+str_expand` or `+code_expand`

Oh I didn't mention that... On our chat we agreed that `attribute+count` was
not the best syntax, as it is not 'adding', and that we should push for
`attribute:count`. That said, I feel like we will end up implementing something
like: `item_type_id:str` or `pickup_location_id:str`.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:32:11 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-pn11Kag29z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:32:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:32:15 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-C0f5BAO10D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143086&action=edit
Bug 31271: Preselect previous search index

This patch passes the constructed value of the preselect to search_indexes.inc

To test:
1 - Perform an advanced search, making sure to select different indexes
2 - Click 'Edit search' on results page
3 - Confirm index selections are preselected
4 - Enable  IntranetCatalogSearchPulldown
5 - Do a search form the top bar using an index
6 - Confirm 'Edit search' correctly popluates the chosen index

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:15 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-EsucsZOzHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141802|0                           |1
        is obsolete|                            |
 Attachment #141803|0                           |1
        is obsolete|                            |
 Attachment #141804|0                           |1
        is obsolete|                            |
 Attachment #141805|0                           |1
        is obsolete|                            |
 Attachment #141806|0                           |1
        is obsolete|                            |
 Attachment #141807|0                           |1
        is obsolete|                            |
 Attachment #141808|0                           |1
        is obsolete|                            |
 Attachment #141809|0                           |1
        is obsolete|                            |
 Attachment #141810|0                           |1
        is obsolete|                            |
 Attachment #141811|0                           |1
        is obsolete|                            |
 Attachment #141812|0                           |1
        is obsolete|                            |
 Attachment #141813|0                           |1
        is obsolete|                            |
 Attachment #141814|0                           |1
        is obsolete|                            |
 Attachment #141815|0                           |1
        is obsolete|                            |
 Attachment #141816|0                           |1
        is obsolete|                            |
 Attachment #141817|0                           |1
        is obsolete|                            |
 Attachment #141818|0                           |1
        is obsolete|                            |
 Attachment #141853|0                           |1
        is obsolete|                            |

--- Comment #109 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143087&action=edit
Bug 31378: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Px7KmYQXQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #110 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143088&action=edit
Bug 31378: DBIC updates [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:30 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-dB20AMY4Q9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #111 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143089&action=edit
Bug 31378: Add dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-vbp8RjsWKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #112 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143090&action=edit
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:44 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-6bb1xTaMru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #113 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143091&action=edit
Bug 31378: Add Koha::Auth::Provider(s) class(es)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:51 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-PlS6va0GBP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #114 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143092&action=edit
Bug 31378: Add Koha::Auth::Client* modules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:35:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:35:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-cHjsxRznWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #115 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143093&action=edit
Bug 31378: Add Auth mojo plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:06 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-FqFfJgOdCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #116 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143094&action=edit
Bug 31378: Add API routes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:13 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-bFBX47eGq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #117 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143095&action=edit
Bug 31378: Add auth providers template plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-gS82bXeLJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #118 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143096&action=edit
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:36 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-faInATrisu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #119 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143097&action=edit
Bug 31378: Add OPAC support for authentication providers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:45 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-l91oKtrWp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #120 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143098&action=edit
Bug 31378: Add STAFF support for authentication providers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:53 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-aI4rmvzQeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #121 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143099&action=edit
Bug 31378: Add accessor methods for JSON attributes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:36:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:36:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-lCNM1jbXHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #122 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143100&action=edit
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:37:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:37:06 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-U9VU0rXp5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #123 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143101&action=edit
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:37:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:37:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eakywsZjkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #124 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143102&action=edit
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:37:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:37:27 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-zmGcxA8pLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #125 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143103&action=edit
Bug 31378: Add an administration interface for authentication sources

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:37:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:37:39 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-TxyjZfhqYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #126 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143104&action=edit
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:37:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:37:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-0PWsAAxwtk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #127 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143105&action=edit
Bug 31378: (follow-up) do all FIXME pointed by David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:38:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:38:04 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-QEOy7Cpd0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #128 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143106&action=edit
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:38:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:38:13 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-2n8eFCC07p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #129 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143107&action=edit
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:40:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:40:45 +0000
Subject: [Koha-bugs] [Bug 31345] Add ability to exit
 process_message_queue.pl early if any plugin before_send_messages hook
 fails
In-Reply-To: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31345-70-ZdiUlarUQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:47:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:47:16 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-GNZvl2VSbm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

--- Comment #3 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 143108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143108&action=edit
Bug 29955: Fix method import issues

This patch fixes this:

$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t
t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited
AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer
allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:51:37 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-F9F64paEPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143108|0                           |1
        is obsolete|                            |

--- Comment #4 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 143109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143109&action=edit
Bug 29955: Fix method import issues

This patch fixes this:

$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t
t/db_dependent/Utils/Datatables_Virtualshelves.t .. 2/13 Use of inherited
AUTOLOAD for non-method Koha::Virtualshelf::haspermission() is no longer
allowed at /kohadevbox/koha/Koha/Virtualshelf.pm line 248.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

https://bugs.koha-community.org/show_bug.cgi?id=32080
Signed-off-by: Blou <blou at inlibro.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:52:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:52:35 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-za5rwBO4Gd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |philippe.blouin at inlibro.com

--- Comment #5 from Blou <philippe.blouin at inlibro.com> ---
I attached the REBASED patch from Bug 29955 that fixed it for me in 22.05.06.

Not sure if RM want to put it as-is, or rename it or ...
So I signed it off, as it works for me.  Marcel/QA can validate if it makes
sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:52:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:52:59 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-JNvsP7wgR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:54:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:54:04 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-eDZvLI9BgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Wondering if this is a bit too aggressively cleaning up?
E.g. field 008 (and maybe more control fields) could end with a few spaces. You
will remove them, which is not correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:55:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:55:45 +0000
Subject: [Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer'
 checkin are not sent if modal is dismissed
In-Reply-To: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29792-70-CO70vo4goz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:55:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:55:49 +0000
Subject: [Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer'
 checkin are not sent if modal is dismissed
In-Reply-To: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29792-70-4CxxzgL03Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:55:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:55:52 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-FwSWhomMuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:55:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:55:55 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-F7YEZwUw0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:55:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:55:58 +0000
Subject: [Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected
 labels in the header search
In-Reply-To: <bug-31974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31974-70-xbXbsIGOBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:00 +0000
Subject: [Koha-bugs] [Bug 31974] Regression: Bug 31813 incorrectly affected
 labels in the header search
In-Reply-To: <bug-31974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31974-70-trcGZOb1d7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31974

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:03 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-eS4F72H4yS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:06 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-ewd2RJYD9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:09 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-DG3U6noqzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:11 +0000
Subject: [Koha-bugs] [Bug 32006] Add page-section to local use system
 preference tab (admin)
In-Reply-To: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32006-70-6jwW0gvsR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32006

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:14 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-To0XiKC9FV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:56:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:56:17 +0000
Subject: [Koha-bugs] [Bug 32064] Add missing test to template permission
 calculation
In-Reply-To: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32064-70-Y72d3AqCG5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32064

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:57:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:57:39 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-NbYrcQ6dDD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #23 from David Nind <david at davidnind.com> ---
The link for the OPAC results in a 404 error.

The link should start with ../cgi-bin/koha/opac-search.pl?.. instead of
../cgi-bin/koha/catalogue/search.pl?.. ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 13:59:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 12:59:11 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-m2uJhjlxZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
About the regex:

$value =~ s/^\s+|\s+$|^\n+|\n+$|^\r+|\r+$|^\t+|\t+$//g;

Is the following not the same:

$value =~ s/^\s+|\s+$//g;

?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:05:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:05:39 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-voXJ4NjNc8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:05:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:05:43 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-1oIjnrvM0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143110&action=edit
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:09:20 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-iaIr7iF0vW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143111&action=edit
Bug 8948 (follow-up) Correct OPAC link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:32:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:32:49 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-KPC3oCNpsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #10 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143112&action=edit
Bug 31447: Add unit tests

To test prove t/db_dependent/Circulation.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:33:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:33:04 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-xItMWhIQdJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:34:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:34:06 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-doYZDsvUxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 143113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143113&action=edit
[DO NOT PUSH] DBIX schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:45:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:45:37 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-WjK3Kd5bHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Blou from comment #5)
> I attached the REBASED patch from Bug 29955 that fixed it for me in 22.05.06.
> 
> Not sure if RM want to put it as-is, or rename it or ...
> So I signed it off, as it works for me.  Marcel/QA can validate if it makes
> sense.

Looks good to me. Will change status so that RMaint can pick it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:45:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:45:46 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-H9pU76xKtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:48:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:48:48 +0000
Subject: [Koha-bugs] [Bug 32089] New: build_holds_queue should optimize
 transfers to the hold pickup location rather than the patron home library
Message-ID: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089

            Bug ID: 32089
           Summary: build_holds_queue should optimize transfers to the
                    hold pickup location rather than the patron home
                    library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 31557

The logic used in build_holds_queue is all based on the item location and the
patron's home branch, on the assumption that the patron will be picking the
hold up at their home branch. That's going to be correct often, but not always.
We should instead look at the hold pickup location, reserves.branchcode.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557
[Bug 31557] Add ability for holds queue builder to prioritize either matching a
patron's home library to the item's home or holding library
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:48:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:48:48 +0000
Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to
 prioritize either matching a patron's home library to the item's home or
 holding library
In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31557-70-bgnKb34e6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32089


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089
[Bug 32089] build_holds_queue should optimize transfers to the hold pickup
location rather than the patron home library
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:49:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:49:20 +0000
Subject: [Koha-bugs] [Bug 32089] build_holds_queue should optimize transfers
 to the hold pickup location rather than the patron home library
In-Reply-To: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32089-70-t2Ndr5KKz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 14:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 13:58:00 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-q6I5AjAO0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:03:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:03:38 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-b91aCgSv6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

--- Comment #6 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143114&action=edit
DBIX schema update

https://bugs.koha-community.org/show_bug.cgi?id=26573

Signed-off-by: Aude Charillon <aude-charillon at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:11:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:11:06 +0000
Subject: [Koha-bugs] [Bug 12242] Allow hiding branches from the OPAC search
 pulldowns
In-Reply-To: <bug-12242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12242-70-j9fassm5Ao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12242

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Failed QA                   |RESOLVED

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 31654 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:11:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:11:06 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-tMlv0Ld9Wc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at koha-suomi.fi

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 12242 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:17:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:17:35 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-5fagkpxs1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

Aude Charillon <aude.charillon at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aude.charillon at ptfs-europe.
                   |                            |com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:18:05 +0000
Subject: [Koha-bugs] [Bug 32090] New: Emojis (or other utf8 characters) can
 break background job processing
Message-ID: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32090

            Bug ID: 32090
           Summary: Emojis (or other utf8 characters) can break background
                    job processing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Change your user's first name to be:
Developer 😺

Do something that enqueues a background job

Check the logs:
Wide character in subroutine entry at /usr/share/koha/lib/Koha/BackgroundJob.pm
line 170.

Comes from:
263 Returns a JSON object with utf8 disabled. Encoding to UTF-8 should be
264 done later.
265 
266 =cut
267 
268 sub json {
269     my ( $self ) = @_;
270     $self->{_json} //= JSON->new->utf8(0); # TODO Should we allow_nonref ?
271     return $self->{_json};
272 }


Maybe we should not do that later?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:18:39 +0000
Subject: [Koha-bugs] [Bug 32090] Emojis (or other utf8 characters) can break
 background job processing
In-Reply-To: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32090-70-XkuMV6Ougc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32090

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:19:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:19:13 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-0yqPHbbAxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139823|0                           |1
        is obsolete|                            |

--- Comment #7 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143115&action=edit
Bug 26573: Limit patron attribute types to more than one patron category

Test plan:
1. Create patron attribute types, some with a category limit, some
   without
2. Apply patch
3. Run installer/data/mysql/updatedatabase.pl
4. Run misc/devel/update_dbix_class_files.pl --koha-conf
5. Restart koha
6. Verify that existing category limits were kept
7. Create a new patron attribute type and select multiple category
   limits. Verify that they have been saved correctly.
8. Edit this patron attribute type and modify category limits. Verify
   that the changes have been saved correctly
9. Go to the patron creation form, and verify that patron attributes are
   shown/hidden accordingly when categorycode is changed.
10. Go to patron batch modification tool, enter a cardnumber (or a
    borrowernumber) and submit the form to go to the next step.
    Now select a patron attribute type that has category limits and
    verify that the message shown to the right is correct

Signed-off-by: Aude Charillon <aude-charillon at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:19:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:19:18 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-N6E8x1rsuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143114|0                           |1
        is obsolete|                            |

--- Comment #8 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143116&action=edit
DBIX schema update

https://bugs.koha-community.org/show_bug.cgi?id=26573

Signed-off-by: Aude Charillon <aude-charillon at ptfs-europe.com>

Signed-off-by: Aude Charillon <aude-charillon at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:19:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:19:37 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-eJpYNEvjKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142514|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143117&action=edit
Bug 31654: Hide non-public libraries from MastheadLibraryPulldown
(bug_31654_hide_nonpublic_libs)

Do not list library in masthead and advanced search if branches.public is false

Test Plan:

* Set OpacAddMastheadLibraryPulldown to "Add"
* Go to Administration -> Libraries, edit "Fairfield", set "public" = "no" (at
the end of the form)
* Or connect to DB and run
  update branches set public = 0 where branchcode like 'F%';
  This will set all three libraries starting with F to non-public
* open OPAC
* The "All libraries" Pulldown in the Header (between search slot and search
button) still shows the non-public libraries
* Go to OPAC -> Advanced Search, scroll to "Location and availability": The
selectbox still shows the non-public libraries

Now apply the patch

* Open OPAC
* The "All libraries" Pulldown in the Header now should not contain the
libraries set to "public = no"
* And in the Advanced Search "Location and availability" pulldown those
libraries should also not be shown.

Sponsored-by: Steiermärkische Landesbibliothek
Signed-off-by: Claude Demeure <claude.demeure at mailo.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:19:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:19:42 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-CkdPFJT43i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143118&action=edit
Bug 31654: (follow-up) Update hint

This patch updates the 'public' hint to include the additional
functionality we now tie to it.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:20:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:20:32 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-A3GKdTayPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great work, QA scripts are happy and I added the minor follow-up to clarify the
hint when enabled/disabling the public option.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:21:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:21:16 +0000
Subject: [Koha-bugs] [Bug 32091] New: Consistent classes for primary
 buttons: Reports
Message-ID: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

            Bug ID: 32091
           Summary: Consistent classes for primary buttons: Reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in reports templates so that buttons which are
currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:21:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:21:16 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-E6eV7d06ku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32091


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091
[Bug 32091] Consistent classes for primary buttons: Reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:23:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:23:01 +0000
Subject: [Koha-bugs] [Bug 32092] New: Improve circulation rules cache
 utilization
Message-ID: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092

            Bug ID: 32092
           Summary: Improve circulation rules cache utilization
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Currently the cache is bypassed when fetching of circulation rules in a lot of
places, calling get_effective_rule instead of get_effective_rule_value which
makes use of in-memory cached. Additionally the case where the rule value is an
empty string or undefined or no rule is found are not currently cached which
results in the database is being queried repeatedly for cases where no results
are found (which usually are the majority of calls). For example on the page
where items are listed when placing a hold the current hit ratio for the cache
in get_effective_rule_value is about 6%, with this patch we instead get a hit
ratio of 99.8%, resulting in a whooping 340x less time spent performing the
database lookup in get_effective_rule_value. With 150 items (we have serials
with up to 1400 items), about 50% of the execution time is spent looking up
rules which is practically reduced to zero when also caching empty results (and
replacing the uncached direct calls to get_effective_rule with
get_effective_rule_value).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:23:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:23:19 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-lfJaV1RxCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

--- Comment #9 from Aude Charillon <aude.charillon at ptfs-europe.com> ---
All works! A lot of library colleagues will find this useful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:24:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:24:17 +0000
Subject: [Koha-bugs] [Bug 32093] New: cleanup_database.pl bg-jobs parameter
 should be bg-days
Message-ID: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

            Bug ID: 32093
           Summary: cleanup_database.pl bg-jobs parameter should be
                    bg-days
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The help says:
--bg-days DAYS          Purge all finished background jobs this many days old.
Defaults to 1 if no DAYS provide    d.


The script checks:
'bg-jobs:i'         => \$background_days,

We should use bg-days

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:24:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:24:25 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-79bu3Qypps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:31:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:31:13 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-AgpOsSIjL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:31:17 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-iPGeuiHOTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143119&action=edit
Bug 32091: Consistent classes for primary buttons: Reports

This patch makes changes the button markup in reports templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view reports pages to confirm that
everything looks correct. In most cases there are no visible changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:31:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:31:59 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-ui3lAJO3VZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:03 +0000
Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29672-70-VPqWQLTZQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:06 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-F4znecl4tC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:10 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-1bkpvNZBkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:14 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-HjWamwM0jU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:17 +0000
Subject: [Koha-bugs] [Bug 31854] Document conflict with delete_patrons.pl
 --not_borrowed_since and anonymization
In-Reply-To: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31854-70-migAd720f4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31854

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:20 +0000
Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an
 undefined value at cataloguing/additem.pl
In-Reply-To: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31873-70-UpCDJT3im1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:23 +0000
Subject: [Koha-bugs] [Bug 31873] Can't call method "safe_delete" on an
 undefined value at cataloguing/additem.pl
In-Reply-To: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31873-70-uTiznWDnEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31873

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:26 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-RPLwlYBHOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:32:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:32:29 +0000
Subject: [Koha-bugs] [Bug 32076] Form for editing a basket group is
 misaligned
In-Reply-To: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32076-70-jnYM4vTlsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32076

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:34:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:34:27 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-sZgEhAUteK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

--- Comment #3 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
+1 This would be helpful to both patrons and staff.  We don't like proving
inaccurate results to our patrons and they find it very frustrating when it
appears a book is available only to realize that it has holds on it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:34:26 +0000
Subject: [Koha-bugs] [Bug 32094] New: Consistent classes for primary
 buttons: Serials
Message-ID: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

            Bug ID: 32094
           Summary: Consistent classes for primary buttons: Serials
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in serials templates so that buttons which are
currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:34:26 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-E8btOKeo4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32094


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094
[Bug 32094] Consistent classes for primary buttons: Serials
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:39:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:39:28 +0000
Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to
 prioritize either matching a patron's home library to the item's home or
 holding library
In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31557-70-YN3VKqLa9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Kyle, please let me know if this proposed test plan misses something:

To test:
1: have 2 branches: A, B
2: have a bib with two items: Item 1 with homebranch=A, holdingbranch=B; item 2
with homebranch=B, holdingbranch=A
3: have a patron with homebranch=A
4: place a bib-level hold on your bib for your patron, for pickup at A
5: run build_holds_queue.pl
6: consult the queue, confirm it's targeted Item 1, which will require a
transfer to fill
7: apply patch, restart services
8: confirm the new HoldsQueuePrioritizeBranch syspref is set to homebranch
9: run build_holds_queue again
10: confirm nothing changed, still targeting Item 1
11: switch HoldsQueuePrioritizeBranch to holdingbranch
12: run build_holds_queue
13: confirm the queue is now targeting Item 2, which will not require a
transfer

I didn't involve the real time holds queue, just for simplicity.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:39:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:39:40 +0000
Subject: [Koha-bugs] [Bug 32090] Emojis (or other utf8 characters) can break
 background job processing
In-Reply-To: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32090-70-dABMD226Yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32090

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #0)
> Change your user's first name to be:
> Developer 😺

Ok. You are asking for trouble :)

> Maybe we should not do that later?

No. You create a lot of problems when you encode in the middle of the process.
The idea is: decode at start, encode at the end. Keep everything in perl
internal format in between.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:40:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:40:56 +0000
Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization
In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32092-70-1wBrYDyqA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 143120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143120&action=edit
Bug 32092: Improve circulation rules cache utilization

To test:
1) Go to the page for placing a hold for a biblio with a large
   number of items
2) Depending on the number of items this page can be very slow
   to load
3) Ensure the following tests pass:
   t/db_dependent/Circulation.t
   t/db_dependent/Reserves.t
   t/db_dependent/Biblio.t
   t/db_dependent/Koha/Charges/Fees.t
   t/db_dependent/Koha/Charges/Fees.t
   t/db_dependent/Items.t
   t/db_dependent/Koha/Patron.t
   t/db_dependent/api/v1/checkouts.t
   t/db_dependent/Koha/Template/Plugin/CirculationRules.t
   t/db_dependent/Template/Plugin/CirculationRules.t
3) Apply the patch
4) The page loading time should now be significantly faster
5) Ensure all the tests in 3) still pass

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:41:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:41:13 +0000
Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should
 have an option to filter out notforloan statuses
In-Reply-To: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27973-70-2Uza06XkBe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

--- Comment #2 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
++1 for this functionality.  Having the 'Limit to currently available' filter
return results for items that are on order provides a very bad user experience.
 Being able to limit your search to what you actually have a chance at checking
out immediately is essential functionality.  It's like being told that a table
at your favorite restaurant is available now only to find that the actual table
is on order so you will have to wait 6 weeks for it to get delivered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:41:15 +0000
Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization
In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32092-70-TaU7PQ86eR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:41:27 +0000
Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization
In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32092-70-4CcqonQ2DO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:42:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:42:48 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-2pFFBGWHpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:42:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:42:48 +0000
Subject: [Koha-bugs] [Bug 32090] Emojis (or other utf8 characters) can break
 background job processing
In-Reply-To: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32090-70-FySIk9EujU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32090

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #1)

> No. You create a lot of problems when you encode in the middle of the
> process. The idea is: decode at start, encode at the end. Keep everything in
> perl internal format in between.

Note that I had utf8 here more in mind than JSON btw. But it follows a similar
pattern..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:42:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:42:51 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-8MiE031c1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143121&action=edit
Bug 32094: Consistent classes for primary buttons: Serials

This patch makes changes the button markup in serials templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view serials pages to confirm that
everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:43:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:43:49 +0000
Subject: [Koha-bugs] [Bug 32095] New: Remove bullets from statuses in
 inventory tool
Message-ID: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095

            Bug ID: 32095
           Summary: Remove bullets from statuses in inventory tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

I was just redoing some screenshots for the inventory tool and I noticed that
in the new design, statuses have bullet points next to them. I'm not sure this
is necessary, especially that the list items are right aligned, it looks a bit
weird with the bullets...

Cataloging > Inventory > Optional filters for inventory list or comparing
barcodes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:44:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:44:37 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
 tool
In-Reply-To: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32095-70-7MX32xsbt7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 143122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143122&action=edit
Inventory tool in old design

This is the screenshot in the manual currently, for comparison

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:45:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:45:35 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
 tool
In-Reply-To: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32095-70-qzgSr31sXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 143123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143123&action=edit
Inventory tool in new design

This is a screenshot of the current inventory tool in the new design. Notice
the bullet points next to the item statuses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:45:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:45:57 +0000
Subject: [Koha-bugs] [Bug 32096] New: Consistent classes for primary
 buttons: Tools
Message-ID: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

            Bug ID: 32096
           Summary: Consistent classes for primary buttons: Tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in various tools templates so that buttons which
are currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:45:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:45:57 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-07WDzIIsa0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32096


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096
[Bug 32096] Consistent classes for primary buttons: Tools
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:51:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:51:34 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-ApJCGfDDdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:51:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:51:38 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-n6nTyymyg8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143124&action=edit
Bug 32096: Consistent classes for primary buttons: Tools

This patch makes changes the button markup in various tool
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in the tools section to confirm
that everything looks correct. In most cases there are no visible
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:54:12 +0000
Subject: [Koha-bugs] [Bug 32097] New: Consistent classes for primary
 buttons: Lists
Message-ID: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

            Bug ID: 32097
           Summary: Consistent classes for primary buttons: Lists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in lists templates so that buttons which are
currently styled as primary buttons will have the the "btn btn-primary"
classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:54:12 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-oAwM53ThM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097
[Bug 32097] Consistent classes for primary buttons: Lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:59:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:59:09 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-wR4d8TqGpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 15:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 14:59:12 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-RQ5I8UTwZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143125&action=edit
Bug 32097: Consistent classes for primary buttons: Lists

This patch makes changes the button markup in lists templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view lists pages to confirm that everything
looks correct. In most cases there are no visible changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:05:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:05:06 +0000
Subject: [Koha-bugs] [Bug 32098] New: Consistent classes for primary
 buttons: Clubs and rotating collections
Message-ID: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

            Bug ID: 32098
           Summary: Consistent classes for primary buttons: Clubs and
                    rotating collections
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in clubs and rotating collections templates so
that buttons which are currently styled as primary buttons will have the the
"btn btn-primary" classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:05:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:05:06 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-WBFgHQlWZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32098


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098
[Bug 32098] Consistent classes for primary buttons: Clubs and rotating
collections
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:11:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:11:24 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-BsOcNNRsz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:11:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:11:29 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-hupIMSHtsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143126&action=edit
Bug 32098: Consistent classes for primary buttons: Clubs and rotating
collections

This patch makes changes the button markup in clubs and rotating
collections templates so that all submit buttons and any buttons that
should should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron clubs and rotating collections
pages to confirm that everything looks correct. In most cases there are
no visible changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:14:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:14:44 +0000
Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should
 have an option to filter out notforloan statuses
In-Reply-To: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27973-70-ikLsV6ZW2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Sam Passey <passey at uintah.utah.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |passey at uintah.utah.gov

--- Comment #3 from Sam Passey <passey at uintah.utah.gov> ---
I agree that is is a huge customer service issue. Please give it some love!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:17:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:17:02 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-Y4FRbZhQiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Sam Passey <passey at uintah.utah.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |passey at uintah.utah.gov

--- Comment #4 from Sam Passey <passey at uintah.utah.gov> ---
Does anyone have updates on this one? This is problematic. Available now to me
means that something is on the shelf at that moment that someone should be able
to grab.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:21:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:21:59 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-S1hHW5HgpH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143073|0                           |1
        is obsolete|                            |
 Attachment #143074|0                           |1
        is obsolete|                            |
 Attachment #143075|0                           |1
        is obsolete|                            |
 Attachment #143076|0                           |1
        is obsolete|                            |
 Attachment #143077|0                           |1
        is obsolete|                            |
 Attachment #143078|0                           |1
        is obsolete|                            |
 Attachment #143079|0                           |1
        is obsolete|                            |
 Attachment #143080|0                           |1
        is obsolete|                            |

--- Comment #90 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143127&action=edit
Bug 26635: Add tests

Add tests in t/db_dependent/Koha/Object.t and
t/db_dependent/Koha/REST/Plugin/Objects.t

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:30 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-Sh2bxl087x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #91 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143128&action=edit
Bug 26635: Expand authorised values in to_api method

This patch adds the posibility to expand authorised values when to_api
method is called.

The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following

{
  column_name => Koha::AuthorisedValue->unblessed
  ...
}

This patch will be used in bug 8179, so please test there.

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:36 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-dmS5fYP2b8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #92 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143129&action=edit
Bug 26635: Add tests for av-expand => 0

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:41 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-ONbWRbEyoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #93 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143130&action=edit
Bug 26635: AV expansion should ackowledge $params->{public}

This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.

It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:46 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-FMIIjoEImQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #94 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143131&action=edit
Bug 26635: Refined data structure and methods

This patch makes the returned data structure be simpler:

_str => {
    attribute_1 => {
        category => 'some_category_name',
        str      => 'description',
        type     => 'av'
    },
    ...
}

The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.

Tests are adjusted accordingly, also to reflect the public => 1 use
case.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:51 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-QB4oUcwfb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #95 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143132&action=edit
Bug 26635: Move expand syntax to x-koha-embed

Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:

GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
    "_str": {
        "city": { "str": "Córdoba", ... }
    },
    ...
    "checkouts": [
        {
            ...,
            "item": {
                "_str": {
                    "not_for_loan_status": { "str": "Reference material", ...
},
                    ...
                },
                ...
            }
        }
    ]
}

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/Koha/REST/Plugin/Query.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:57 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-Y4kka8z9LL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #96 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143133&action=edit
Bug 26635: (follow-up) Add optional support for `:` as the modifier

This patch adds optional support for using `:` as the modifier for
invoking the 'count' method for relations as discussed.

We retain support for `+` for backward compatability to prevent a
breaking change.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:22:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:22:57 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-U1c8IxYb7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:23:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:23:02 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-XLCqIM31q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #97 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143134&action=edit
Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header

This patch updates the last remaining test that mentioned the now defunkt
x-koha-av-expand header.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:23:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:23:21 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-1UmdXmACor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:23:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:23:24 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-QVxrsshwGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143135&action=edit
Bug 31818: Enable table elements in keyboard shortcuts popover

This patch updates the whitelist for the popover to ensrue our shortcuts table
displays

To test:
1 - Open the advanced cataloging editor
2 - Click 'Keyboard shortcuts'
3 - Is empty, be sad
4 - Apply patch
5 - Reload
6 - Click it again
7 - Shortcuts!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:23:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:23:38 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-B4NQUYJXIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:28:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:28:54 +0000
Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to
 prioritize either matching a patron's home library to the item's home or
 holding library
In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31557-70-Bbgj0Nq6t4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:28:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:28:57 +0000
Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to
 prioritize either matching a patron's home library to the item's home or
 holding library
In-Reply-To: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31557-70-FYGFXK92Tn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142082|0                           |1
        is obsolete|                            |

--- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143136&action=edit
Bug 31557: Add ability for holds queue builder to prioritize either matching a
patron's home library to the item's home or holding library

Right now the holds queue builder starts filling bib-level holds with
items whose patron's home library matches the item's home library.

It would be good and reasonable to have the option to prioritize
item's whose patron's home library matches the item's holding library
to minimize transfers.

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:32:11 +0000
Subject: [Koha-bugs] [Bug 32099] New: Consistent classes for primary
 buttons: Assorted templates
Message-ID: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

            Bug ID: 32099
           Summary: Consistent classes for primary buttons: Assorted
                    templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 32067

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary
buttons:

This patch will update buttons in remaining unchanged templates so that buttons
which are currently styled as primary buttons will have the the "btn
btn-primary" classes.

In some places, the classes have been added to buttons which were not
input[type='submit'] but which should be styled as primary.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067
[Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:32:11 +0000
Subject: [Koha-bugs] [Bug 32067] [OMNIBUS] Consistent classes for submit
 and/or primary buttons
In-Reply-To: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32067-70-O7iqYoRpJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32099


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099
[Bug 32099] Consistent classes for primary buttons: Assorted templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:40:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:40:30 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-kKh4mTXQbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:46:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:46:24 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-n69eB5eMK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:46:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:46:27 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-kyxiPgfYM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143137&action=edit
Bug 31819: Fix formatting of item form in acq when ordering

To test:
1. Apply patch and regenerate CSS ( yarn build )
2. Add to order from an empty record to an order, make sure the page looks
good.
3. Add to order from an existing record to an order, make sure the page looks
good.
4. In neworderempty.pl add some new items to the order by clicking 'Add item'.
The item lists table should now appear, confirm it looks right.
5. Save the form, ensuring everthing still works as it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 16:47:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 15:47:01 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-HtwC00vSks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:31:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:31:54 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-TkNhuCu143@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:31:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:31:58 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-pZDGMtijvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143135|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143138&action=edit
Bug 31818: Enable table elements in keyboard shortcuts popover

This patch updates the whitelist for the popover to ensrue our shortcuts table
displays

To test:
1 - Open the advanced cataloging editor
2 - Click 'Keyboard shortcuts'
3 - Is empty, be sad
4 - Apply patch
5 - Reload
6 - Click it again
7 - Shortcuts!

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:34:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:34:52 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-ILLOfQPtmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
(In reply to Andrew Fuerste-Henry from comment #3)
> Created attachment 143138 [details] [review]
> Bug 31818: Enable table elements in keyboard shortcuts popover
> 
> This patch updates the whitelist for the popover to ensrue our shortcuts
> table displays
> 
> To test:
> 1 - Open the advanced cataloging editor
> 2 - Click 'Keyboard shortcuts'
> 3 - Is empty, be sad
> 4 - Apply patch
> 5 - Reload
> 6 - Click it again
> 7 - Shortcuts!
> 
> Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

In my testing, I was not able to feel actual sadness in step 3, but maybe we
can handle that in a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:50:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:50:09 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-hTJEZxS1Si@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:50:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:50:13 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-ZNlUORraJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143086|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143139&action=edit
Bug 31271: Preselect previous search index

This patch passes the constructed value of the preselect to search_indexes.inc

To test:
1 - Perform an advanced search, making sure to select different indexes
2 - Click 'Edit search' on results page
3 - Confirm index selections are preselected
4 - Enable  IntranetCatalogSearchPulldown
5 - Do a search form the top bar using an index
6 - Confirm 'Edit search' correctly popluates the chosen index

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:55:40 +0000
Subject: [Koha-bugs] [Bug 32100] New: "edit search" feature quote-wraps
 search terms if original search had no results
Message-ID: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100

            Bug ID: 32100
           Summary: "edit search" feature quote-wraps search terms if
                    original search had no results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: nick at bywatersolutions.com
        Depends on: 22605, 31271

To recreate:
- perform a search that returns no results
- on the No Results Found page, click Edit Search
- when the search page reloads, note that your search term is now wrapped in
double quotes
- enter your now-quoted search, then click Edit Search on the No Results page
again
- your search term is now double-double quoted


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605
[Bug 22605] Adding the option to modify/edit searches on the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271
[Bug 31271] "Edit search" always resets search options to keyword
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:55:40 +0000
Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches
 on the staff interface
In-Reply-To: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22605-70-zi8Zcviw3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32100


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100
[Bug 32100] "edit search" feature quote-wraps search terms if original search
had no results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 17:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 16:55:40 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-Hc95g89KaO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32100


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100
[Bug 32100] "edit search" feature quote-wraps search terms if original search
had no results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:06:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:06:34 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-jv1vThAjh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:06:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:06:37 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-Ry7SIsiSAw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143140&action=edit
Bug 32099: Consistent classes for primary buttons: Assorted templates

This patch makes changes the button markup in various assorted
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view the following pages to confirm that
everything looks correct. In most cases there are no visible changes.

- Staff interface login
- Authorities -> Add/edit
- Authorities -> Merge
- ILL -> ILL requests
- Tools -> Patron lists
- Administration -> Manage plugins -> Upload plugin
- Point of sale
- Point of sale -> Transaction history
- Holds
- Suggestions
- Tags
- Calendar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:13:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:13:35 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-yRjL9gUQ20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:13:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:13:40 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-Xz0LVtXntj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143083|0                           |1
        is obsolete|                            |

--- Comment #25 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143141&action=edit
Bug 8948: Display MARC 787 relationship field

This field is defined similar to 775, as a related work:
https://www.loc.gov/marc/bibliographic/bd787.html

This patch adds a display of this field, linking to the referenced record as
the 775 does

It also tests for 580 field, and displays the text there if present, using the
787 a and t subfields otherwise

To test:
1 - Edit the default framework to make 787atw and 580a visible in editor
2 - Add a 787 to a record:
    $tThe ideas behind the chess openings
    $aFine, Reuben<
    $w2470231
3 - Confirm there is no display
4 - Apply patch / restart all
5 - 'Other related works' now shows
6 - Link should be using title of record
7 - Set system preference UseControlNumber to Use
8 - Reload details, link should now use control number
9 - Add a 580 to the record:
    $a This is a friendly work to this one
10 - Confirm the text of the link now displays before the link
11 - Add a second 580, confirm it displays as well
   - there is no seperator as each should end with a period or other
punctuation according to MARC
   - there is a dpan with a class surrounding each so styling can be added as
desired
12 - Add a second 787
   - confirm seperator present and wrapped in a span with a class
   - confirm each 787 is shown with a span/class for styling

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:13:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:13:45 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-XTAv0n28fT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143084|0                           |1
        is obsolete|                            |

--- Comment #26 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143142&action=edit
Bug 8948: Changes for OPAC

Test with same record, confirm OPAC view is as expected

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:13:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:13:49 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-qOrVsrhnKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143111|0                           |1
        is obsolete|                            |

--- Comment #27 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143143&action=edit
Bug 8948 (follow-up) Correct OPAC link

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:31:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:31:27 +0000
Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
In-Reply-To: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30869-70-d9iXBFlnxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

--- Comment #3 from Pedro Amorim <pjamorim91 at gmail.com> ---
Created attachment 143144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143144&action=edit
Add delete action to stock rotation rotas

To test:
1) Enable StockRotation system preference
2) Tools > Stock rotation > New rota
3) Enter Name, save
4) Verify "Delete" button shows on the right
5) Click "Delete" -> Confirm "Yes"
6) Repeat steps 1-3 and click "Manage"->"Stages"
7) Add a new stage, enter Library and Duration, click "Save"
8) Return to rotas, click "Manage"->"Items"
9) Add item, enter barcode, click "Save" (optional: add more than 1 item)
10) Click "return to rotas" and press "Delete"
11) Verify the warning now shows, because items are attached, with the attached
items count
12) Click "Delete" -> Deletion is successful

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:44:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:44:06 +0000
Subject: [Koha-bugs] [Bug 32101] New: Add padding to floating toolbars
Message-ID: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

            Bug ID: 32101
           Summary: Add padding to floating toolbars
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

Created attachment 143145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143145&action=edit
Patron entry form floating toolbar

In several cases floating toolbars have no padding, making the layout seem
awkward. See attached screenshot.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:44:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:44:06 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-NWtrC0HiZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32101


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101
[Bug 32101] Add padding to floating toolbars
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:46:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:46:24 +0000
Subject: [Koha-bugs] [Bug 28012] Error on saving new numbering pattern
In-Reply-To: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28012-70-KBBtYDvwiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #21 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Katrin Fischer from comment #20)
> As noted in comments before this one, I don't think that making the
> description mandatory is the right solution here. 

I addressed this after the last time you commented on this, please see the
patch again, it is not mandatory. Setting the status back to Signed off, let me
know if there is something I'm not understanding.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:50:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:50:30 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-eoDp9u8mZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:50:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:50:34 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-9ZjbEMwfnS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143146&action=edit
Bug 32028: Add page-section to various admin pages

This patch adds the page section to div to the following administration pages:

admin/cash_registers.tt
admin/cities.tt
admin/credit_types.tt
admin/debit_types.tt
admin/patron-attr-types.tt
admin/restrictions.tt
plugins/plugins-home.tt

To test go the following pages and make sure everything looks good:

Administration > Cash registers. You must enable the sys pref
'UseCashRegisters'
Administration > Cities and towns.
Administration > Credit types
Administration > Debit types
Administration > Patron restrictions
Adminstration > Patron attribute types
Administration > Manage plugins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:50:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:50:35 +0000
Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should
 have an option to filter out notforloan statuses
In-Reply-To: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27973-70-BU3R6zZk70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #4 from George Williams (NEKLS) <george at nekls.org> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:50:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:50:51 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-rSfV9Ux95i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #5 from George Williams (NEKLS) <george at nekls.org> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:50:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:50:57 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-5EeVu7xITk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:51:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:51:00 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-pUxdgZv5k2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143147&action=edit
Bug 32101: Add padding to floating toolbars

This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.

To test, apply the patch and rebuild the staff interface CSS.

View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:

- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:52:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:52:05 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-4B8thlBAhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
I believe the background jobs page has already handled in Bug 31960.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 18:56:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 17:56:25 +0000
Subject: [Koha-bugs] [Bug 28396] Call number browse pagination
In-Reply-To: <bug-28396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28396-70-EyNlDYf5ST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28396

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Perhaps making this into a dataTable is not a good idea. Maybe instead we can
either up the number of results shown at a time. Or maybe a system preference
so the number of results can be defined there?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 19:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 18:04:37 +0000
Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
In-Reply-To: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30869-70-J6M1RdxsL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

Pedro Amorim <pjamorim91 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143144|0                           |1
        is obsolete|                            |

--- Comment #4 from Pedro Amorim <pjamorim91 at gmail.com> ---
Created attachment 143148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143148&action=edit
Add delete action to stock rotation rotas

To test:
1) Enable StockRotation system preference
2) Tools > Stock rotation > New rota
3) Enter Name, save
4) Verify "Delete" button shows on the right
5) Click "Delete" -> Confirm "Yes"
6) Repeat steps 1-3 and click "Manage"->"Stages"
7) Add a new stage, enter Library and Duration, click "Save"
8) Return to rotas, click "Manage"->"Items"
9) Add item, enter barcode, click "Save" (optional: add more than 1 item)
10) Click "return to rotas" and press "Delete"
11) Verify the warning now shows, because items are attached, with the attached
items count
12) Click "Delete" -> Deletion is successful

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 19:19:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 18:19:24 +0000
Subject: [Koha-bugs] [Bug 32102] New: Improve specificity of batch record
 modification breadcrumbs
Message-ID: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

            Bug ID: 32102
           Summary: Improve specificity of batch record modification
                    breadcrumbs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

After you've submitted a batch of biblionumbers for modification the
breadcrumbs menu doesn't offer you a link back to the initial page where you
can submit another batch. The breadcrumbs menu should reflect whether or not
you're on the first page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 19:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 18:25:11 +0000
Subject: [Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return
 all item values
In-Reply-To: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30860-70-DIebsfxZRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 19:25:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 18:25:38 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-rHMoiSelfy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 19:25:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 18:25:41 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-BkL08v9SjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143149&action=edit
Bug 32102: Improve specificity of batch record modification breadcrumbs

This patch makes a minor change to the batch record modification
template so that there is a link back to the initial view after you have
submitted a batch for modification.

To test, apply the patch and go to Cataloging -> Batch record
modification.

- Initially the breadcrumbs menu should show Home -> Cataloging -> Batch
  record modification
- Submit a batch of bibliographic or authority records for modification
- The breadcrumbs should now read Home -> Cataloging -> Batch record
  modification -> Results
- The same menu options should show after you confirm the operation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 20:20:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 19:20:42 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-N2zHj7O8eL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 20:20:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 19:20:46 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-oKRgZHFD5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143147|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143150&action=edit
Bug 32101: Add padding to floating toolbars

This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.

To test, apply the patch and rebuild the staff interface CSS.

View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:

- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 20:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 19:21:18 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-iu3P3Nj8PH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Thanks Owen, I've noticed this but neglected to file a bug. Glad to see it
fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 21:12:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 20:12:46 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-JamgdLj5b3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #32 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Katrin Fischer from comment #31)
> Oh no... I found an issue :(
> 
> You remove the itemnumber, which would have been enough on old versions, but
> now we also need to change reserves.item_level_hold
> 
> Should be an easy fix - please follow-up.

Good catch. Although it has been there for 3 years I didn't know of this "new"
column :) Fix will follow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 21:52:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 20:52:01 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-5EYHxFw874@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 21:52:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 20:52:04 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-uDbGz9Fxj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #33 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143151&action=edit
Bug 31692: (follow-up) Adjust reserves.item_level_hold

Original patch missed handling reserves.item_level_hold column.

To test:
1. prove t/db_dependent/Koha/Hold.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:20:16 +0000
Subject: [Koha-bugs] [Bug 32103] New: Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
Message-ID: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

            Bug ID: 32103
           Summary: Can't focus on content field in HTML customizations
                    with mouse click ( CodeMirror )
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:

1. Go to HTML customization, News, or Pages and make a new entry using the text
editor ( CodeMirror )
2. Trying using your mouse to focus on the content field. You cannot gain
focus. 
3. I can use my tab key to focus on the field.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:20:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:20:26 +0000
Subject: [Koha-bugs] [Bug 32103] Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-43a6Lfb5Bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:27:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:27:17 +0000
Subject: [Koha-bugs] [Bug 32104] New: console error on additional_content.pl
 after saving
Message-ID: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

            Bug ID: 32104
           Summary: console error on additional_content.pl after saving
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
1. Make a new HTML customization, news item, or page with the text editor (
CodeMirror ). 
2. Save the content ( not Save and continue )
3. Notice the console error:

Uncaught TypeError: firstTab[0] is undefined

This only seems to happen for me when using CodeMirror. Using the WYSIWYG
editor does not produce the console error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:38:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:38:21 +0000
Subject: [Koha-bugs] [Bug 32103] Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-fcdxon5iyt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
I can focus with my mouse but it is difficult the CodeMirror-wrap is only as
wide as the content, so when there is no content it is very small.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:47:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:47:43 +0000
Subject: [Koha-bugs] [Bug 32012] runreport.pl should use binmode UTF-8
In-Reply-To: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32012-70-DEnGEQZlr4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32012

--- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This is great :D thanks everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:52:54 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-czCPH4OyNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I'm a fan of JS DataTable ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:53:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:53:51 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-vueDqGR5SB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 22:53:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 21:53:58 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-of2Lc2WXU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143081|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143152&action=edit
Bug 32085: Consistent classes for primary buttons: Labels

This patch makes changes the button markup in label-creation templates
-- including the barcode image generator -- so that all submit buttons
and any buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view label-related pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:03:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:03:17 +0000
Subject: [Koha-bugs] [Bug 32103] Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-bM5L7AvqD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Ahh, it's because the list element now uses flex. Perhaps this particular
content should not do that. We can remedy it by removing the rows class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:06:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:06:15 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-ri2hrS149z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker)

1. These change the label templates accessed from Cataloging > Tools > 
   Label creator
   Barcode image generator
   Quick spine label creator

2. I struggled on the best way to test these changes. In the end, I:
   . Reviewed the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   . Listed the templates in
koha-tmpl/intranet-tmpl/prog/en/modules/labels/files and split into two lists -
those changed and those not changed
   . Worked out how to access them
   . Created screenshots and put them in a document (I haven't attached this,
but am happy to)
   . Applied the patch (+ flush_memcached, restart_all, and cleared browser
cache)
   . Went through list of files again: compared to original screenshot taken,
then noted whether changed or not
   . Noted any questions - don't affect the sign off for this bug

3. Files changed:
- barcode-print.tt (No change. Barcode image generator) > 39999000011111 > Show
barcode)
- label-bib-search.tt (note: couldn't figure out where this is used from - no
results except .po files from "git grep label-bib-search.tt" (git grep
label-bib-search.tt ":(exclude)*.po" shows no results))
- label-edit-layout.tt (No change. Label creator > New > Layout)
- label-edit-profile.tt (No change. Label creator > New > Printer profile)
- label-edit-range.tt (Changed - now orange colour. Label creator > New >
Barcode range)
- label-edit-template.tt (No change. Label creator > New > Label template)
- label-print.tt (No changes. Called from 
    . labels/label-print.pl (Label creator > New > Label batch > [add some
barcodes or item numbers] > Add items > select and use any of the export
options) 
    . labels/spinelabel-print.pl (Quick spine label creator > [Enter a barcode
for an item with a call number] > pop up window with noptions to "Print this
label" and "Edit this label"))
- search.tt (No change. Label creator > New > Label batch > [leave Add by
barocde(s) or itemnumbers field blank] > enter search criteria > Search)
(called from label-item-search.pl)
- spinelabel-home.tt (No change. Quick spine label creator > 39999000011111 >
View spine label)

4. Files not changed:
- label-edit-batch.tt (Label creator > New > Label batch)
- label-home.tt (Label creator)
- label-manage.tt (Any of the options for Label creator > Manage)
- result.tt (called from label-item-search.pl - see search.tt)
- spinelabel-print.tt (result window from spinelabel-home.tt (Quick spine label
creator > 39999000011111 > View spine label)

5. File count check:
- Number of files in folder: 14
- Number of files listed: 14

Questions: 

1. Should the buttons be in the div or outisde the div? Those in the white
background are:
  - Barcode image generator
  - Quick spine label creator

2. I couldn't figure out where label-bib-search.tt is used from - looks like it
is not used anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:11:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:11:15 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-W1iFp3DFIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Thanks for testing David

(In reply to David Nind from comment #6)
> Created attachment 142661 [details]
> Screenshot - Receiving order - formatting and default values
> 
> Testing notes and issues/query (tested using koha-testing-docker).
> 
> Three things I noticed:
> 
> 1. Tax Rate system preference warning message
> ---------------------------------------------
> 

Unrelated (exists before patches), see bug 31984 

> 
> 2. Step 13 - Formatting things
> ------------------------------
> 

Unrelated (exists before patches), maybe open another bug for this?

> 
> 3. For step 13 - Query about using the default values
> -----------------------------------------------------
> 
> These values are correctly calculated, but don't match up with the test
> plan. So should I have entered the actual costs as 8.00 (the $10 retail
> price less the 20% discount, tax exclusive)?

Yes I think that's right sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:12:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:12:33 +0000
Subject: [Koha-bugs] [Bug 32103] Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-x4QeIyFCe0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:12:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:12:36 +0000
Subject: [Koha-bugs] [Bug 32103] Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-0BRxbzGzZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143153&action=edit
Bug 32103: Remove flex from tab-content list elements

To test:
1. Go to HTML customization, News, or Pages and make a new entry using the text
editor ( CodeMirror )
2. It is hard to focus on the Content field because the wrapper width is very
small.
3. Apply patch and try again
4. The CodeMirror wrapper width should be normal again.
5. Check the other language tabs.
6. Also test the WYSIWYG editor, it should also be normal.

Note: I added some CSS to make the labels appear bold.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:22:29 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-2sWSicZ4GL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:22:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:22:33 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-X8Jte1cFgH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143154&action=edit
Bug 32104: Prevent console error on additonal-contents.pl

To test:
1. Make a new HTML customization, news item, or page with the text editor (
CodeMirror ).
2. Save the content ( not Save and continue )
3. Notice the console error:
4. Apply patch
5. Try 1 & 2 again.
6. No error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:22:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:22:46 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-tfhAJzrQMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:22:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:22:56 +0000
Subject: [Koha-bugs] [Bug 32103] Can't focus on content field in HTML
 customizations with mouse click ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-LCH016TTl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:23:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:23:38 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-aaGv7LnDxw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't focus on content      |Content field in HTML
                   |field in HTML               |customizations is too
                   |customizations with mouse   |narrow ( CodeMirror )
                   |click ( CodeMirror )        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov  3 23:57:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 22:57:19 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-O3xQe1ocyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #34 from David Nind <david at davidnind.com> ---
The patches still apply, but something seems changed:

1. Step 7 - There is now no dropdown list (before there was a drop down list
with Only item <barcode> and Next available); selecting next available and
updating removes the drop down list).

2. Step 9 - There is still a dropdown list with the two options (Only item
<barcode> and Next available).

Happy to sign off again if that is what is expected.

Tests pass both before and after patches are applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:06:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:06:06 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-AHTbfGLRV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:06:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:06:11 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-BORF9hKnx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #15 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143155&action=edit
Bug 31391: (follow-up) Fix cancel recalls using checkbox

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:13:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:13:06 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-qxfRDDenI8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Nind from comment #14)
> Hi Aleisha.
> 
> Apologies for Failing QA on this again!
> 
> The previous issue reported is fixed (step 7 - can't cancel a recall from
> OPAC when RecallsInterface = staff interface only).
> 
> I've identified a new issue with step 5 - cancelling a recall from the
> recalls section for a record - record doesn't exist after cancelling a
> recall using the 'Cancel selected recalls' button and selecting the normal
> section. 
> 
> To replicate:
> 1. Place a recall
> 2. Go to the recalls section for the record on the staff interface
> 3. Using Actions > Cancel works as expected
> 4. Repeat steps 1 and 2.
> 5. Cancel the recall by ticking the box next to the item and then selecting
> 'Cancel selected recalls' button doesn't work as expected:
>    . The recall is cancelled
>    . URL = http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl
>    . Breadcrumb = Home > Catalog > No title > Place a recall 
>    . Click on the normal section:
>       message = The record you requested does not exist ().
>       URL =
> http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=
> 
> I'm not sure if I tested this last time. I'm also sure I've seen this when
> testing something else a while ago, but can't remember or find what bug it
> was.

Fixed in latest follow-up

> 
> Also, for step 13 it is possible to have more than one recall for a record
> or item. Whose recall takes priority, and what is the workflow libraries
> would use to address this?
> - If a recall is already on the record (from the previous step), there are
> now two recalls (a record level one, and an item level one)
> - On the record page is shows "recalled by X on [date]" - for X it shows the
> person who made the latest recall, not the first person who place a recall.  
> - Is this an edge case to be resolved in a separate bug, or a non-issue? 
> - It seems logical that multiple patrons could make a recall request for the
> same record. What would the workflow be for libraries if they were in this
> situation, and how do they resolve this?
> 

I think that is outside of the scope of this particular ticket (because
fulfilling recalls via the staff interface came from the original Bug 19532)
but at the moment the oldest/earliest placed recall will be picked first, and
priority is given to item-level recalls over biblio-level recalls. A follow-up
to all of this would be to introduce a priority field like reserves has, but
that can come after we bring in functionality to place recalls via the staff
interface I think

> 
> David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:20:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:20:25 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-FfmbXJ6mhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #35 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to David Nind from comment #34)
> The patches still apply, but something seems changed:
> 
> 1. Step 7 - There is now no dropdown list (before there was a drop down list
> with Only item <barcode> and Next available); selecting next available and
> updating removes the drop down list).

The wording in this step is a bit silly, it appears I didn't properly rewrite
it when I squashed the new dropdown menu with the original patch.

What you describe seems expected behavior to me. After changing from item level
hold to record level hold there should no longer be a dropdown. So at step 7 if
you see just the text "Next available" then that is to be expected.

This is because the patches here do not add GUI support for going from record
level to item level hold, but only the other way around.

> 2. Step 9 - There is still a dropdown list with the two options (Only item
> <barcode> and Next available).

This is not expected, did you add the two item level holds for the same patron?
I noticed the test plan does not clarify that this is required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:22:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:22:40 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-IOUbi2DWvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:22:45 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-zgy36qJ3Ae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141017|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 143156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143156&action=edit
Bug 31631: Add new system preference

Sponsored-by: Waikato Institute of Technology, New Zealand

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:22:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:22:50 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-p5zce8vz8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141018|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 143157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143157&action=edit
Bug 31631: Optionally use tax-exclusive values for calculating fund values

Test plan:
1. Apply patches
2. sudo koha-upgrade-schema <instance>
3. Restart services
4. Set TaxRates syspref = 0.15
5. Create a new fund with amount = 1000
6. Add an order to a basket with the following values:
- Fund = Choose the fund from step #5
- Quantity = 1
- Vendor price = 10
- Tax rate = 15%
- Discount = 20%
- Retail price = 10.00
- Replacement cost = 10.00
- Actual cost = 10.00
7. Go to the Acquisitions home page
8. Confirm the 'Ordered' column for the step #5 fund contains 9.20
9. Click on the 9.20 link and confirm the ordered.pl page that loads
also contains 9.20 as the 'Subtotal'

10. Change 'CalculateFundValuesIncludingTax' = 'Exclude'
11. On the Acquisitions home page confirm the 'Ordered' column now
contains 8.00
12. Click on the 8.00 link and confirm the ordered.pl page also contains
8.00 as the 'Subtotal'

13. Close your basket and receive your order keeping all the default
values
14. Go to the Acquisitions home page and confirm the 'Spent' column now
contains 8.00
15. Click on the 8.00 link and confirm the spent.pl page also contains
8.00 as the 'Subtotal'

16. Change 'CalculateFundValuesIncludingTax' = 'Include'
17. Confirm the 'Spent' column on the Acquisitions home page now shows
9.20
18. Click on the 9.20 link and confirm the spent.pl page also contains
9.20 as the 'Subtotal'

Sponsored-by: Waikato Institute of Technology, New Zealand

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:22:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:22:55 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-3ipc7crcFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141019|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 143158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143158&action=edit
Bug 31631: Unit tests

Test plan:
1. Run tests in koha-shell
sudo koha-shell <instance>
prove t/db_dependent/Budgets.t

Sponsored-by: Waikato Institute of Technology, New Zealand

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:23:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:23:00 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-DNJCRBXlFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142597|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 143159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143159&action=edit
Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying
existing order

This patch depends on Bug 31840.

To test:
1) Edit an order and increase the price so that you would expect it to
trigger a warning that you will exceed the amount allowed for this Fund
2) Confirm the warning is triggered

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:45:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:45:26 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-MyoazSJOFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #36 from David Nind <david at davidnind.com> ---
(In reply to Lari Taskula from comment #35)
> (In reply to David Nind from comment #34)
> > The patches still apply, but something seems changed:
> > 
> > 1. Step 7 - There is now no dropdown list (before there was a drop down list
> > with Only item <barcode> and Next available); selecting next available and
> > updating removes the drop down list).
> 
> The wording in this step is a bit silly, it appears I didn't properly
> rewrite it when I squashed the new dropdown menu with the original patch.
> 
> What you describe seems expected behavior to me. After changing from item
> level hold to record level hold there should no longer be a dropdown. So at
> step 7 if you see just the text "Next available" then that is to be expected.
> 
> This is because the patches here do not add GUI support for going from
> record level to item level hold, but only the other way around.

Thanks for clarifying!

> > 2. Step 9 - There is still a dropdown list with the two options (Only item
> > <barcode> and Next available).
> 
> This is not expected, did you add the two item level holds for the same
> patron? I noticed the test plan does not clarify that this is required.

I added for different patrons, so will use the same patron.

Just re-testing, so should be signed off shortly!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:51:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:51:15 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-VBWOf5AU3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:51:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:51:20 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-k2NN0OfRqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142818|0                           |1
        is obsolete|                            |

--- Comment #37 from David Nind <david at davidnind.com> ---
Created attachment 143160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143160&action=edit
Bug 31692: Add Koha::Hold::change_type and unit tests

To test:
1. prove t/db_dependent/Koha/Hold.t

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:51:25 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-dffd4HYpGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142819|0                           |1
        is obsolete|                            |

--- Comment #38 from David Nind <david at davidnind.com> ---
Created attachment 143161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143161&action=edit
Bug 31692: Allow librarians to change hold type in staff client

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown value has changed from "Only item <barcode>" to
   "Next available"
8. Cancel the hold and add two item level holds
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 00:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Nov 2022 23:51:30 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-DCUfDt9moH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143151|0                           |1
        is obsolete|                            |

--- Comment #39 from David Nind <david at davidnind.com> ---
Created attachment 143162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143162&action=edit
Bug 31692: (follow-up) Adjust reserves.item_level_hold

Original patch missed handling reserves.item_level_hold column.

To test:
1. prove t/db_dependent/Koha/Hold.t

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 01:08:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 00:08:07 +0000
Subject: [Koha-bugs] [Bug 32105] New: Patron lists needs to share to
 specific people or groups
Message-ID: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105

            Bug ID: 32105
           Summary: Patron lists needs to share to specific people or
                    groups
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

If using patron lists with the batch permissions modifier plugin, there is no
way to share that list with specific people or groups.  It is all or nothing. 
This means if you use the plugin, either only one person maintains that list,
or everyone with patron list permissions has access to that list, giving them
power over all permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 01:30:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 00:30:22 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-Lu9VvwQ5cE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #5)
> (In reply to David Cook from comment #4)
> > Confusion for whom?
> 
> For developers, or users. Why does problem reports have a subpermission, and
> edit authorities does not?

Ahh, I understand now. That is confusing. My only thought is that the original
developer thought that additional sub-permissions might be added?

Aleisha could probably speak to that for recalls. 

> > What do you mean by "two settings"?
> 
> flagsrequired   => { recalls => "manage_recalls" }
> flagsrequired => { recalls => 1 }
> 
> These are checking two different things, but provide the same answer

That's true (where there is only one sub-permission like recalls). 

If additional sub-permissions were added, they would mean different things. I
suppose that is both a pro and a con...

> > For "OPAC problem reports management" and "Recalls", you get the same thing
> > whether you click the top level or the sub-permission, and that's clearly
> > indicated visually.
> 
> Sure, but then why is the subpermission added at all? If it is the same as
> clicking the top level, let's not provide two checkboxes when one will do

I think that's the crux of the matter. 

I suppose one option could be removing unnecessary sub-permissions? 

Alternatively, we could also grey-out sub-permissions where there's only 1
sub-permission available. That might make it less confusing visually?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 01:31:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 00:31:45 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-bByy2vtHvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 01:32:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 00:32:21 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-lB6Avvc8bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 03:26:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 02:26:15 +0000
Subject: [Koha-bugs] [Bug 32106] New: Formatting issues - accounting details
 form when receiving items
Message-ID: <bug-32106-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32106

            Bug ID: 32106
           Summary: Formatting issues - accounting details form when
                    receiving items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 143163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143163&action=edit
Screenshot - Receiving order form - formatting

When receiving an order, there are some minor formatting issues for two fields
on the accounting details form (see the attached screenshot):
- Retail price: no space after value and the opening bracket; no space between
comma and tax exclusive (or tax inclusive, depending on the vendor setting)
- Budgeted cost: no space after value and the opening bracket

This requires changes to
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt to fix.

To replicate:*
1. Add an order to a basket for a vendor (Acquisitions > Manage orders > click
search > select My Basket (for My Vendor) > Add to basket).
2. Close the basket (select 'Close basket' from the basket page).
3. Receive shipments for the vendor (Acquisitions > Manage orders > click
search (shows My Basket for My Vendor) > Receive shipments > Enter an invoice
number > Next).
4. Click receive for an item in My Basket.
5. Note the formatting issues on the accounting details form for these fields:
   - Retail price: no space after value and the opening bracket; no space
between comma and tax exclusive (or tax inclusive)
   - Budgeted cost: no space after value and the opening bracket
6. On another tab, edit the vendor so that for 'list prices' and 'invoice
prices' the 'include tax' option is selected.
7. Refresh the tab for receiving items.
8. Note the same formatting issues as in step 5.

* Using koha-testing-docker (KTD) there is one vendor (My Vendor) with an empty
basket (My Basket) already setup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 03:27:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 02:27:25 +0000
Subject: [Koha-bugs] [Bug 32106] Formatting issues - accounting details form
 when receiving items
In-Reply-To: <bug-32106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32106-70-ZryXNle0N9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31631
   Patch complexity|---                         |String patch
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 03:27:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 02:27:25 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
 to be used for calculating fund values (spent, ordered)
In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31631-70-M93zbUwMc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32106

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 06:58:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 05:58:49 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-J8rCxE8foj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #130 from David Cook <dcook at prosentient.com.au> ---
(In reply to Agustín Moyano from comment #108)
> Hi David, could you please try again?
> 
> I've attended to all your valuable FIXME comments in the last patch. 
> 
> Please let me know what you think.
> 
> Thanks so much!

Thanks, Agustín.

I don't have time to thoroughly test it today, and I'm away on Monday, but I'll
do a quick glance over it now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 06:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 05:59:40 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-N83SXprbUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #131 from David Cook <dcook at prosentient.com.au> ---
First things first...staying in Failed QA due to qa tool failures:

--

testing 21 commit(s) (applied to ba01d76 '78 Bug 31713: Fix permissions')

Processing files before patches
Configure idp routes=====>| 48 / 48 (100.00%)

Processing files after patches
|========================>| 48 / 48 (100.00%)

 OK     C4/Auth.pm
 OK     Koha/Auth/Client.pm
 FAIL   Koha/Auth/Client/OAuth.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK     Koha/Auth/Provider.pm
 OK     Koha/Auth/Provider/Domain.pm
 OK     Koha/Auth/Provider/Domains.pm
 OK     Koha/Auth/Provider/OAuth.pm
 OK     Koha/Auth/Provider/OIDC.pm
 OK     Koha/Auth/Providers.pm
 OK     Koha/Exceptions.pm
 FAIL   Koha/Exceptions/Auth.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 OK     Koha/REST/Plugin/Auth.pm
 OK     Koha/REST/V1.pm
 OK     Koha/REST/V1/Auth/Provider/Domains.pm
 OK     Koha/REST/V1/Auth/Providers.pm
 OK     Koha/REST/V1/OAuth/Client.pm
 OK     Koha/Schema/Result/AuthProvider.pm
 OK     Koha/Schema/Result/AuthProviderDomain.pm
 OK     Koha/Schema/Result/Branch.pm
 OK     Koha/Schema/Result/Category.pm
 OK     Koha/Schema/Result/IdentityProviderDomain.pm
 OK     Koha/Template/Plugin/AuthClient.pm
 OK     admin/authentication_providers.pl
 OK     admin/identity_providers.pl
 OK     api/v1/swagger/definitions/auth_provider.yaml
 OK     api/v1/swagger/definitions/auth_provider_domain.yaml
 OK     api/v1/swagger/paths/auth.yaml
 OK     api/v1/swagger/paths/oauth.yaml
 OK     api/v1/swagger/paths/public_oauth.yaml
 OK     api/v1/swagger/swagger.yaml
 OK     installer/data/mysql/atomicupdate/bug_31378.pl
 OK     installer/data/mysql/kohastructure.sql
 OK     koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
 OK     koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
 OK    
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_provider_domains.tt
 OK    
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authentication_providers.tt
 OK    
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt
 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
   FAIL   valid_template
                DBIx::Class::Schema::source(): Can't find source for
IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524


 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
   FAIL   valid_template
                DBIx::Class::Schema::source(): Can't find source for
IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524


 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
   FAIL   valid_template
                DBIx::Class::Schema::source(): Can't find source for
IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524


 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
   FAIL   valid_template
                DBIx::Class::Schema::source(): Can't find source for
IdentityProvider at /kohadevbox/koha/Koha/Objects.pm line 524


 OK     t/db_dependent/Koha/Auth/Client.t
 OK     t/db_dependent/Koha/Auth/Provider.t
 OK     t/db_dependent/Koha/REST/Plugin/Auth/IdP.t
 OK     t/db_dependent/api/v1/idp.t
 FAIL   t/lib/IdP/ExternalIdP.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666


Processing additional checks OK!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 07:17:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 06:17:09 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-TQX0JE7qIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #132 from David Cook <dcook at prosentient.com.au> ---
Looks like Koha/Template/Plugin/AuthClient.pm might be having an issue with
Koha/Auth/Identity/Providers.pm...

--

Test plan 1:
0. Apply patches
1. apt install libmojolicious-plugin-oauth2-perl
2. koha-upgrade-schema kohadev
3. restart_all

Test plan 2:
1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl
2. Click on "Identity providers"
3. Click "New identity provider"
4. Enter relevant details and click "Submit"
5. Click on "Manage Domains"
6. Click "Edit" on the default domains
7. Set "Allow staff" and allow update on login and autoregister and click
"Submit"

8. koha-plack --restart kohadev

9. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that doesn't exist in Koha

--

I'm getting this error:

"There was an error authenticating to external identity provider

No configuration found for your provider"

I'm seeing the following error in the logs on Starman startup:

[2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration:
Can't locate object method "search" via package "Koha::Auth::Providers"
(perhaps you forgot to load "Koha::Auth::Providers"?) at
/kohadevbox/koha/Koha/REST/V1.pm
line 143.
[2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration:
Can't locate object method "search" via package "Koha::Auth::Providers"
(perhaps you forgot to load "Koha::Auth::Providers"?) at
/kohadevbox/koha/Koha/REST/V1.pm
line 143.

--

Looks like a typo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 07:19:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 06:19:41 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-SYMjhcJzvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #133 from David Cook <dcook at prosentient.com.au> ---
Agustín, how are you testing this during development?

In my docker-compose.yml, I use the following:

    keycloak:
        image: jboss/keycloak
        networks:
            - kohanet
        environment:
            KEYCLOAK_USER: <username>
            KEYCLOAK_PASSWORD: <password>
        ports:
            - "8082:8080"

If you are interested in using Keycloak for testing, I can give a few more
instructions on how to set up the realm, the client, the user, and where to
find the details for the Koha configuration.

--

That actually reminds me that I don't have a test plan for the "OAuth" Protocol
option. Does it still work with the OIDC option since OIDC is just a wrapper
around OAuth?

--

Anyway, that's all for me for now!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 07:38:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 06:38:48 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-8BRUp1K5yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #17 from David Nind <david at davidnind.com> ---
(In reply to Aleisha Amohia from comment #16)
> (In reply to David Nind from comment #14)
> > Hi Aleisha.
> > 
> > Apologies for Failing QA on this again!
> > 
> > The previous issue reported is fixed (step 7 - can't cancel a recall from
> > OPAC when RecallsInterface = staff interface only).
> > 
> > I've identified a new issue with step 5 - cancelling a recall from the
> > recalls section for a record - record doesn't exist after cancelling a
> > recall using the 'Cancel selected recalls' button and selecting the normal
> > section. 
> > 
> > To replicate:
> > 1. Place a recall
> > 2. Go to the recalls section for the record on the staff interface
> > 3. Using Actions > Cancel works as expected
> > 4. Repeat steps 1 and 2.
> > 5. Cancel the recall by ticking the box next to the item and then selecting
> > 'Cancel selected recalls' button doesn't work as expected:
> >    . The recall is cancelled
> >    . URL = http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl
> >    . Breadcrumb = Home > Catalog > No title > Place a recall 
> >    . Click on the normal section:
> >       message = The record you requested does not exist ().
> >       URL =
> > http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=
> > 
> > I'm not sure if I tested this last time. I'm also sure I've seen this when
> > testing something else a while ago, but can't remember or find what bug it
> > was.
> 
> Fixed in latest follow-up

This is still not working for me and doesn't appear to be fixed.

If it helps, there is an entry in
/var/log/koha/kohadev/plack-intranet-error.log:
[2022/11/04 06:36:44] [WARN] Use of uninitialized value $biblionumber in
concatenation (.) or string at /kohadevbox/koha/recalls/request.pl     line 49.

Everything else continues to work as per the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 07:43:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 06:43:15 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-9TMfbMgOq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #40 from David Nind <david at davidnind.com> ---
I've ended up adding sign off lines for the first two patches - not sure how to
remove those!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 07:46:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 06:46:03 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-AVvNg2shAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:07:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:07:57 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-7x8WK6P4LL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:08:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:08:01 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-HWtwefYaru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143154|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143164&action=edit
Bug 32104: Prevent console error on additonal-contents.pl

To test:
1. Make a new HTML customization, news item, or page with the text editor (
CodeMirror ).
2. Save the content ( not Save and continue )
3. Notice the console error:
4. Apply patch
5. Try 1 & 2 again.
6. No error.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:41:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:41:47 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-4yIowfAS84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
The patch no longer applies 8-(..

git bz apply 32028

Bug 32028 - Add page-section to various administration pages (part 2)

143052 - Bug 32028: Add page-section to smart-rules.tt and fix markup errors
143146 - Bug 32028: Add page-section to various admin pages

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32028: Add page-section to smart-rules.tt and fix markup errors
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 32028: Add page-section to smart-rules.tt and fix
markup errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:57:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:57:02 +0000
Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents
 in checkouts table
In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25503-70-vpLrnZDQpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143165&action=edit
Bug 25503: Make Koha::Exporter::Record tests pass with unimarc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:57:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:57:07 +0000
Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents
 in checkouts table
In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25503-70-OmMJQoGK8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143166&action=edit
Bug 25503: Add failing test for _get_biblio_for_export

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:57:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:57:12 +0000
Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents
 in checkouts table
In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25503-70-9C0jdWAoEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143167&action=edit
Bug 25503: Make _get_biblio_for_export test pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 09:57:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 08:57:16 +0000
Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents
 in checkouts table
In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25503-70-o9gupjbV5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142715|0                           |1
        is obsolete|                            |

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143168&action=edit
Bug 25503: Add option to export items bundle contents in checkouts table

Test plan:
1. Enable system preference ExportCircHistory
2. Create an item bundle (see bug 28854 comment 458)
3. Check out the item bundle
4. In the checkouts table, check the box in column "Export",
   choose export format 'MARC with items', check "Export items bundle
   contents" and click on "Export" button
   The exported file should contain the biblio and item created at step
   2, but also the biblio and items that are part of the bundle

Signed-off-by: Marie-Luce <marie-luce.laflamme at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marie-Luce <marie-luce.laflamme at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:07:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:07:28 +0000
Subject: [Koha-bugs] [Bug 32107] New: Send $self to Plugins->call and call
 discard_changes inside
Message-ID: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

            Bug ID: 32107
           Summary: Send $self to Plugins->call and call discard_changes
                    inside
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Plugin architecture
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Resulting from a discussion on IRC and in the QA team. If there is a need for
further discussion, we can continue here.

The idea is: We should no longer $self->store and pass $self->get_from_storage
to the ->call routine.
But we should $self->store, pass $self to Plugins->call, and ->discard_changes
once inside ->call to fetch timestamps and default values from DBMS.

What happens after ->call? Currently, we pass a copy but continue afterwards
with the old $self. Normally, we wont do much more, but this might create
side-effects since we do not operate on the latest data (we ignore changes from
plugins).
If we pass $self, we have the latest state back after ->call. Though we are not
sure if the plugin(s) did a store. If we would do a discard after the plugins
loop in ->call, we actually ignore unsaved changes like we do now too and we do
not disturb the plugins loop inside ->call.

To make it even more explicit, we could add a parameter to ->call that controls
if we do or do not discard after the plugins loop..

Side note: The execution order of plugins seems to be database insert order
when I look at the code in GetPlugins. Theoretically I would rather control
that differently but that could be a topic of another report. Not in this scope
;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:08:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:08:11 +0000
Subject: [Koha-bugs] [Bug 32107] Send $self to Plugins->call and call
 discard_changes inside
In-Reply-To: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32107-70-aQWo6WIuHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au,
                   |                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:12:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:12:29 +0000
Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents
 in checkouts table
In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25503-70-xYeuYFgaEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:14:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:14:33 +0000
Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
In-Reply-To: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31894-70-mMrok6tLfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #16)
> Created attachment 142747 [details] [review]
> Bug 31894: (QA follow-up) Remove unneeded get_from_storage calls
> 
> Test plan:
> Run test again.
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

We had an interesting discussion on IRC and within the QA team now about this.
I opened bug 32107 to get a consistent approach. For now I will remove the
latest follow-up here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:15:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:15:10 +0000
Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
In-Reply-To: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31894-70-oss38OWTik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142747|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 142747
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142747
Bug 31894: (QA follow-up) Remove unneeded get_from_storage calls

Moving to 32107

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:16:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:16:24 +0000
Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit
In-Reply-To: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31895-70-yGfQqsfkWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Here I left the get_from_storage. The comment gets attention on bug 32107.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:19:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:19:42 +0000
Subject: [Koha-bugs] [Bug 31944] Toolbar is not correctly aligned
In-Reply-To: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31944-70-MvqfiwrdeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---


*** This bug has been marked as a duplicate of bug 32101 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:19:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:19:42 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-9nmC96MGQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 31944 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:22:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:22:00 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-hptY1nwTZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Better but still misaligned IMO.

https://snipboard.io/XE7LgI.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:22:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:22:34 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-Uy96Ysxuef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I will restore the get_from_storage here in the first patch to be consistent.
With a FIXME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:26:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:26:10 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-DaXumAJqQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142757|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143169&action=edit
Bug 31896: New after_recall_action hook

Hooks added:
after_recall_action with new action add

How to test:
Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t

Sponsored by: Gothenburg University Library

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
[EDIT} Adding get_from_storage ;) For current consistency.
See further bug 32107.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:26:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:26:14 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-IkuJ1xkw13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142758|0                           |1
        is obsolete|                            |

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143170&action=edit
Bug 31896: (QA follow-up) Fix modules

Triggered by seeing Koha::Account. Copy and paste ;)
But a bunch of other modules should (at least formally) be there.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:26:18 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-cnudx2q2iq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142759|0                           |1
        is obsolete|                            |

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143171&action=edit
Bug 31896: (QA follow-up) Fix rollback

Yes, it should be the last statement.
Actually the preceding delete is unneeded.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:26:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:26:56 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-0Z75Sk9DG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:28:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:28:14 +0000
Subject: [Koha-bugs] [Bug 32107] Send $self to Plugins->call and call
 discard_changes inside
In-Reply-To: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32107-70-Dws9kbAFGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Marcel de Rooy from comment #0)
> To make it even more explicit, we could add a parameter to ->call that
> controls if we do or do not discard after the plugins loop..

I think that Koha::Plugin::call should not do anything on its @args except
passing it to plugins. It should not even care of what's in these @args.
IMO its the responsibility of the caller of Koha::Plugin::call to pass the
right arguments and handle the eventual side-effects correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:28:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:28:59 +0000
Subject: [Koha-bugs] [Bug 32107] Send $self to Plugins->call and call
 discard_changes inside
In-Reply-To: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32107-70-ebmvd4Dbwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Adding a diff here from 31894

>From 59ff56f2b77ed9b529e886b40bc2da63fb929a81 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue, 25 Oct 2022 14:45:57 +0000
Subject: [PATCH] Bug 31894: (QA follow-up) Remove unneeded get_from_storage
 calls
Content-Type: text/plain; charset=utf-8

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
---
 Koha/Hold.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Koha/Hold.pm b/Koha/Hold.pm
index 8379e3f718..36b434ed2b 100644
--- a/Koha/Hold.pm
+++ b/Koha/Hold.pm
@@ -204,7 +204,7 @@ sub set_transfer {
         'after_hold_action',
         {
             action  => 'transfer',
-            payload => { hold => $self->get_from_storage }
+            payload => { hold => $self }
         }
     );

@@ -269,7 +269,7 @@ sub set_waiting {
         'after_hold_action',
         {
             action  => 'waiting',
-            payload => { hold => $self->get_from_storage }
+            payload => { hold => $self }
         }
     );

@@ -365,7 +365,7 @@ sub set_processing {
         'after_hold_action',
         {
             action  => 'processing',
-            payload => { hold => $self->get_from_storage }
+            payload => { hold => $self }
         }
     );

-- 
2.30.2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:32:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:32:21 +0000
Subject: [Koha-bugs] [Bug 32107] Send $self to Plugins->call and call
 discard_changes inside
In-Reply-To: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32107-70-AITYvGjUO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Julian Maurice from comment #1)
> (In reply to Marcel de Rooy from comment #0)
> > To make it even more explicit, we could add a parameter to ->call that
> > controls if we do or do not discard after the plugins loop..
> 
> I think that Koha::Plugin::call should not do anything on its @args except
> passing it to plugins. It should not even care of what's in these @args.
> IMO its the responsibility of the caller of Koha::Plugin::call to pass the
> right arguments and handle the eventual side-effects correctly.

Yes, I appreciate that principle. But the problem is that we are inserting more
and more calls to Plugins->call and that we are loosing consistency. So we are
looking for a balance here..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:34:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:34:03 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-nxPn2ejyy0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #98 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. "Add optional support for `:` as the modifier"
We should document that. Why do we have it here actually? Shouldn't it be on
its own bug?

2. Cannot we come with something better than "_str" and "str"?

3. We still have specific reference to "av" when I think we should focus on
"stringify coded values" as a general concept.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:42:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:42:47 +0000
Subject: [Koha-bugs] [Bug 32107] Send $self to Plugins->call and call
 discard_changes inside
In-Reply-To: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32107-70-FSYrx83XIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
> Yes, I appreciate that principle. But the problem is that we are inserting
> more and more calls to Plugins->call and that we are loosing consistency. So
> we are looking for a balance here..

Maybe adding a "wrapper subroutine" around `call` would work ? It would keep
the `call` subroutine simple and data-agnostic while removing the boilerplate
eventually needed everywhere Koha::Objects are passed to plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:43:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:43:28 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-bpEBmwfRYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Seeing same warning about Uncaught TypeError: t is undefined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:45:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:45:43 +0000
Subject: [Koha-bugs] [Bug 32107] Send $self to Plugins->call and call
 discard_changes inside
In-Reply-To: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32107-70-TfejkMIBep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Julian Maurice from comment #4)
> > Yes, I appreciate that principle. But the problem is that we are inserting
> > more and more calls to Plugins->call and that we are loosing consistency. So
> > we are looking for a balance here..
> 
> Maybe adding a "wrapper subroutine" around `call` would work ? It would keep
> the `call` subroutine simple and data-agnostic while removing the
> boilerplate eventually needed everywhere Koha::Objects are passed to plugins.

Good idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:54:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:54:51 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-ih7xReL5cO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143172&action=edit
Bug 30310: Add missing utc plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:55:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:55:43 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-bTT1hEFi4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #30)
> Created attachment 143172 [details] [review]
> Bug 30310: Add missing utc plugin

Joubu> The following paths are ignored by one of your .gitignore files:
Joubu> koha-tmpl/intranet-tmpl/lib/dayjs/plugin
Joubu> Use -f if you really want to add them.
Joubu> I have one file that is not committed there
Joubu> but it does not appear in git status because "plugin" is in .gitignore

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:57:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:57:50 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-RZVpnRZKQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #29)
> Seeing same warning about Uncaught TypeError: t is undefined

Last follow-up clears warning for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:58:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:58:58 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-ZGrHetn61Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Should be good now, sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 10:59:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 09:59:04 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-ctaXcrHBXh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:03:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:03:42 +0000
Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
In-Reply-To: <bug-31897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31897-70-uYkg3fw8Ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Stefan Berndtsson from comment #11)
> I'm really not sure what I'm supposed to do here. This is based on what the
> test t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t does, with the
> Plugin parts added to it.
> 
> That test does the same result-check of get_elasticsearch_params, and if
> there is no elasticsearch running (localhost:9200 or equivalent) it also
> fails with the NoNodes error.
> 
> I can't see how I can come up with a solution to a test depending on a
> running Elasticsearch without having a running Elasticsearch.
> 
> The current test does not like it when there is an Elastic running but Zebra
> is set as the engine, so it'll have to be tweaked (the existing Indexer.t
> works here). I did some more copy&paste from that one so I can make this
> test work as well regardless of that syspref, but not without actually
> having Elastic running.

I would fail Indexer.t now too for the same reason indeed. But it is pushed
already ;)
I am not an Elastic expert. Please ask on IRC or dev list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:12:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:12:50 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-CHoRRKsXfQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143172|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143173&action=edit
Bug 30310: Add missing utc plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:23:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:23:16 +0000
Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work
In-Reply-To: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31881-70-3ubZs88hUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:23:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:23:19 +0000
Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work
In-Reply-To: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31881-70-wgdueQnqPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142246|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143174&action=edit
Bug 31881: Fix search link in MARC view

In framework a subfield can be defined with a link (with a search field).
This create an hyperlink in MARC view.
Currently with Elasticsearch the link does not work because search query
contains 'field,phr:',
which is useless since the link contains 'idx=field,phr'.
With Zebra looks like the idx param is ignored.

Test plan :
1) Use Elasticsearch search engine
2) Edit subfield 245$a in default framework
3) Enter 'title' in 'Link'
4) Save
5) Create a record with default framework with 245$a = 'The Fifth Elephant'
6) Go to MARC view
7) Click on link in 245$a
8) You find the record

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:23:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:23:56 +0000
Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work
In-Reply-To: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31881-70-riKRenTnYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Fridolin Somers from comment #5)
> I think we want to build a search query like it as been created from
> advanced search. So keep '&idx' and remove search field from '&q'.

Great. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:58:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:58:13 +0000
Subject: [Koha-bugs] [Bug 31944] Toolbar is not correctly aligned
In-Reply-To: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31944-70-xZ1KSDMoCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 11:58:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 10:58:20 +0000
Subject: [Koha-bugs] [Bug 31944] Toolbar is not correctly aligned
In-Reply-To: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31944-70-388kb68zB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:14:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:14:19 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-nSwjwpAtEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #119 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143175&action=edit
Bug 30718: Fix curbside pickups

No slots are displayed without this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:14:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:14:36 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-n3FsCVmaWQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:22:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:22:48 +0000
Subject: [Koha-bugs] [Bug 32108] New: Change "x" icon to replace patron when
 scheduling a pickup
Message-ID: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

            Bug ID: 32108
           Summary: Change "x" icon to replace patron when scheduling a
                    pickup
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30650

It's now a green 'x' icon, we should use the trash icon + "Remove", like in
other areas of Koha (add/remove guarantor for instance).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Add a curbside pickup module
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:22:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:22:48 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-KJIKANUZh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32108


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108
[Bug 32108] Change "x" icon to replace patron when scheduling a pickup
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:27:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:27:53 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-FWbLTwSceT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:27:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:27:58 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-9bxyvpyPcz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143176&action=edit
Bug 32108: Replace "x" icon with "trash" + Remove

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:29:57 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-Ij9uzEVAOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed,     |
                   |rel_22_11_candidate         |

--- Comment #120 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-up pushed. Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:41:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:41:37 +0000
Subject: [Koha-bugs] [Bug 32109] New: Toolbar containing text links lacks
 spacing
Message-ID: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

            Bug ID: 32109
           Summary: Toolbar containing text links lacks spacing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

Created attachment 143177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143177&action=edit
Screenshot showing the crowded links

In the redesign, <div id="toolbar"> has "display:flex," which works well for
Bootstrap-styled buttons but creates a problem if the toolbar has only text
links.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 12:41:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 11:41:37 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-UZDnRQoZ0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32109


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109
[Bug 32109] Toolbar containing text links lacks spacing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:00:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:00:01 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-viHBAk2KZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:00:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:00:06 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-2zWwpiMt56@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143178&action=edit
Bug 32109: Fix spacing in toolbars containing text links

This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.

- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:00:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:00:31 +0000
Subject: [Koha-bugs] [Bug 32110] New: Duplicated additional content entries
 on DBRev 210600016
Message-ID: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

            Bug ID: 32110
           Summary: Duplicated additional content entries on DBRev
                    210600016
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

As explained on the bug 24387 follow-up, there's a problem with the db_rev.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:01:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:01:07 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-vBmlnALSvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Keywords|                            |rel_21_11_candidate,
                   |                            |rel_22_05_candidate,
                   |                            |rel_22_11_candidate
           Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:01:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:01:17 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-tRcPIUWX5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24387


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
[Bug 24387] Rename News tool
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:01:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:01:17 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-AbSni1fsXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32110


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110
[Bug 32110] Duplicated additional content entries on DBRev 210600016
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:04:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:04:46 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-YtnbLT2qSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143179&action=edit
Bug 32110: Fixup to db_rev for non-english, multilingual Koha

Without this patch, the update process duplicates all the news and
content entries when they were non-english to start with.

This patch keeps the same process, but new "default" "parent" entries are empty
so there'
no duplication in the OPAC display, while still being editable/deletable
in the intranet.

We came through that through many iterations.  This was the least
invasive while still providing satisfying results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:06:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:06:01 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-v7eCv57nmA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

--- Comment #70 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #69)
> Thanks Blou! I've marked this as "additional_work_needed" to get some
> attention, but as this bug has already been released and we don't want it to
> show up in release notes again, we should move the follow-up to a separate
> bug where we can also highlight it as a fix for a bad bug.

Moved to bug 32110 to get proper QA on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:06:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:06:22 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-xFORw9lTJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142653|0                           |1
        is obsolete|                            |

--- Comment #71 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 142653
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142653
Bug 24387 - fixup to db_rev for non-english, multilingual Koha

>From 559376aaf1c53efa1589a37e77769c6ffc41088d Mon Sep 17 00:00:00 2001
>From: Blou <blou at inlibro.com>
>Date: Tue, 25 Oct 2022 14:55:52 -0400
>Subject: [PATCH] Bug 24387 - fixup to db_rev for non-english, multilingual
> Koha
>
>Without this patch, the update process duplicates all the news and
>content entries when they were non-english to start with.
>
>This patch keeps the same process, but new "default" "parent" entries are empty so there'
>no duplication in the OPAC display, while still being editable/deletable
>in the intranet.
>
>We came through that through many iterations.  This was the least
>invasive while still providing satisfying results.
>---
> installer/data/mysql/db_revs/210600016.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/db_revs/210600016.pl b/installer/data/mysql/db_revs/210600016.pl
>index 8d66de86cb..6d03adc89d 100755
>--- a/installer/data/mysql/db_revs/210600016.pl
>+++ b/installer/data/mysql/db_revs/210600016.pl
>@@ -111,7 +111,7 @@ return {
>             # Now this is getting weird
>             # We are adding an extra news with the same code when the lang is not "default" (/"en")
> 
>-            $new_lang = "default" if $new_lang eq 'en'; # Assume that "en" is "default"
>+#            $new_lang = "default" if $new_lang eq 'en'; # Assume that "en" is "default"
> 
>             my $sth_update = $dbh->prepare(q|
>                 UPDATE additional_contents
>@@ -124,7 +124,7 @@ return {
>                 $dbh->do(q|
>                     INSERT INTO additional_contents(category, code, location, branchcode, title, content, lang, published_on, updated_on, expirationdate, number, borrowernumber)
>                     VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
>-                |, undef, $category, 'tmp_code', $location, $c->{branchcode}, $c->{title}, $c->{content}, 'default', $c->{published_on}, $c->{updated_on}, $c->{expirationdate}, $c->{number}, $c->{borrowernumber});
>+                |, undef, $category, 'tmp_code', $location, $c->{branchcode}, $c->{title}, '', 'default', $c->{published_on}, $c->{updated_on}, $c->{expirationdate}, $c->{number}, $c->{borrowernumber});
> 
>                 $parent_idnew = $dbh->last_insert_id(undef, undef, 'additional_contents', undef);
>             }
>-- 
>2.34.1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:07:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:07:19 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-h88zNIgS38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:15:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:15:55 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-8wGfopg3Db@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:16:00 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-2M6tz25q9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143176|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143180&action=edit
Bug 32108: Replace "x" icon with "trash" + Remove

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:24:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:24:28 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-D7JfWTcxAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #99 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #98)
> 1. "Add optional support for `:` as the modifier"
> We should document that. Why do we have it here actually? Shouldn't it be on
> its own bug?

I agree.

> 2. Cannot we come with something better than "_str" and "str"?

I agree with that, you proposed. You don't like?

> 3. We still have specific reference to "av" when I think we should focus on
> "stringify coded values" as a general concept.

AV expansion can be expensive. And so other strings. The idea of ':', was to
later add <attribute>:str, so things that are not linked to av, might be
generated on demand as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:29:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:29:19 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-iYLoMjSHkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker).

Since I haven't used the curbside pick up before, these are my notes on setting
things up for testing:
1. Enable the CurbsidePickup system preference.
2. Setup dates and times when pickups are available;
   2.1 Go to Administration > Patrons and circulation > Curbside pickup
   2.2 For a library (for example Centerville) click on enable, pickup interval
= 5, maximum patrons per interval = 2, enable for waiting holds only, and add
some slots, and save.
3. Place some holds for a patron for pickup at the library enabled.
4. Check items in and fulfil the holds.
5. Schedule a pcikup time for the patron:
   5.1 Go to Circulation > Holds > Curbside pickups.
   5.2 Select the schedule pickup tab.
   5.3 Start typing the patron's name and select.
6. Next to the patron name is a red X before the patch.
7. Apply the patch and refresh the page.
8. The red X is replaced with a green trash can and Remove.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:29:57 +0000
Subject: [Koha-bugs] [Bug 32111] New: Cannot schedule a pickup at the OPAC
Message-ID: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

            Bug ID: 32111
           Summary: Cannot schedule a pickup at the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Circulation
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 30650, 30718

The date input is always disabled and it's not possible to select or enter a
date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput:
true"


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Add a curbside pickup module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
[Bug 30718] Use flatpickr's altInput option everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:29:57 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-BKUFi6tzqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32111


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111
[Bug 32111] Cannot schedule a pickup at the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:29:57 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-iokbPYtnJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32111


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111
[Bug 32111] Cannot schedule a pickup at the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:30:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:30:06 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-W74pygE6KC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:32:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:32:31 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-e0F1bP02Q2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:32:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:32:36 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-xcua9nt7Zr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143181&action=edit
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a
date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput:
true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:38:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:38:12 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-G5CG2Xjxb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:38:17 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-J1hU2T86Sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138406|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143182&action=edit
Bug 31261: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:38:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:38:22 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-0xLuPq1Erw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143183&action=edit
Bug 31261: Introduce flatpickr-futureinclusive

That let us use future + today, and it's working perfectly for our use
case :)

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:38:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:38:52 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-YVtYzEJir5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32111


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111
[Bug 32111] Cannot schedule a pickup at the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:38:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:38:52 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-6DwbypgH4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31261


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261
[Bug 31261] Curbside pickups - remove slots in the past
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:41:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:41:18 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-mO5e3Yomxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:41:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:41:21 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-syUgtxxXO0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143181|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143184&action=edit
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a
date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput:
true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:43:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:43:22 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-kSJu1WgJ44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:43:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:43:26 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-c2A1H6jijf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143184|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143185&action=edit
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a
date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput:
true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:48:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:48:56 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-7xUhGMcfqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143087|0                           |1
        is obsolete|                            |
 Attachment #143088|0                           |1
        is obsolete|                            |
 Attachment #143089|0                           |1
        is obsolete|                            |
 Attachment #143090|0                           |1
        is obsolete|                            |
 Attachment #143091|0                           |1
        is obsolete|                            |
 Attachment #143092|0                           |1
        is obsolete|                            |
 Attachment #143093|0                           |1
        is obsolete|                            |
 Attachment #143094|0                           |1
        is obsolete|                            |
 Attachment #143095|0                           |1
        is obsolete|                            |
 Attachment #143096|0                           |1
        is obsolete|                            |
 Attachment #143097|0                           |1
        is obsolete|                            |
 Attachment #143098|0                           |1
        is obsolete|                            |
 Attachment #143099|0                           |1
        is obsolete|                            |
 Attachment #143100|0                           |1
        is obsolete|                            |
 Attachment #143101|0                           |1
        is obsolete|                            |
 Attachment #143102|0                           |1
        is obsolete|                            |
 Attachment #143103|0                           |1
        is obsolete|                            |
 Attachment #143104|0                           |1
        is obsolete|                            |
 Attachment #143105|0                           |1
        is obsolete|                            |
 Attachment #143106|0                           |1
        is obsolete|                            |
 Attachment #143107|0                           |1
        is obsolete|                            |

--- Comment #134 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143186&action=edit
Bug 31378: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Hhq5Jc3m3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #135 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143187&action=edit
Bug 31378: DBIC updates [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:15 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-nHqW6jOaTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #136 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143188&action=edit
Bug 31378: Add dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:23 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-vbCAQpnZaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #137 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143189&action=edit
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:30 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eJnkdPjHgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #138 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143190&action=edit
Bug 31378: Add Koha::Auth::Provider(s) class(es)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-bC6u5LHeeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #139 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143191&action=edit
Bug 31378: Add Koha::Auth::Client* modules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:44 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-LhzeCGpExP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #140 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143192&action=edit
Bug 31378: Add Auth mojo plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:49:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:49:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-CUGY6CUHTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #141 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143193&action=edit
Bug 31378: Add API routes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:06 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-7HZ8JKZcxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #142 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143194&action=edit
Bug 31378: Add auth providers template plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:14 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-718Kc2wSl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #143 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143195&action=edit
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:21 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-oi2frRiFz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #144 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143196&action=edit
Bug 31378: Add OPAC support for authentication providers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:29 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-YBDafMGgvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #145 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143197&action=edit
Bug 31378: Add STAFF support for authentication providers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-MherRpEXP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #146 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143198&action=edit
Bug 31378: Add accessor methods for JSON attributes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:45 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-db6XSyTtWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #147 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143199&action=edit
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-liRknpuQQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #148 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143200&action=edit
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:50:54 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-ZTIIUi18ni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:00 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-sZ5QRYDjN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143182|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 143201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143201&action=edit
Bug 31261: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:03 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-okNSDmHHQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #149 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143202&action=edit
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:05 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-z4KnGD7PzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143183|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 143203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143203&action=edit
Bug 31261: Introduce flatpickr-futureinclusive

That let us use future + today, and it's working perfectly for our use
case :)

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:15 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9yFWV9Xpv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #150 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143204&action=edit
Bug 31378: Add an administration interface for authentication sources

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:25 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-efPWXJPMqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #151 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143205&action=edit
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:35 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-K7bpLErlD1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #152 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143206&action=edit
Bug 31378: (follow-up) do all FIXME pointed by David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:48 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-M7j6Y8uO1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #153 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143207&action=edit
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:51:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:51:56 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-DLZU1Veqe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #154 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 143208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143208&action=edit
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 13:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 12:54:40 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-ziqb4jYEDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #155 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to David Cook from comment #132)
> Looks like Koha/Template/Plugin/AuthClient.pm might be having an issue with
> Koha/Auth/Identity/Providers.pm...
> 
> --
> 
> Test plan 1:
> 0. Apply patches
> 1. apt install libmojolicious-plugin-oauth2-perl
> 2. koha-upgrade-schema kohadev
> 3. restart_all
> 
> Test plan 2:
> 1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl
> 2. Click on "Identity providers"
> 3. Click "New identity provider"
> 4. Enter relevant details and click "Submit"
> 5. Click on "Manage Domains"
> 6. Click "Edit" on the default domains
> 7. Set "Allow staff" and allow update on login and autoregister and click
> "Submit"
> 
> 8. koha-plack --restart kohadev
> 
> 9. In an Incognito window or different browser, go to http://localhost:8080,
> and try logging in with a user that doesn't exist in Koha
> 
> --
> 
> I'm getting this error:
> 
> "There was an error authenticating to external identity provider
> 
> No configuration found for your provider"
> 
> I'm seeing the following error in the logs on Starman startup:
> 
> [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration:
> Can't locate object method "search" via package "Koha::Auth::Providers"
> (perhaps you forgot to load "Koha::Auth::Providers"?) at
> /kohadevbox/koha/Koha/REST/V1.pm
> line 143.
> [2022/11/04 06:16:26] [WARN] Warning: Failed to fetch oauth configuration:
> Can't locate object method "search" via package "Koha::Auth::Providers"
> (perhaps you forgot to load "Koha::Auth::Providers"?) at
> /kohadevbox/koha/Koha/REST/V1.pm
> line 143.
> 
> --
> 
> Looks like a typo.

Sorry, I applied your patch but didn't update Koha::Auth::Providers to
Koha::Auth::Identity::Providers

Now it should work

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 14:11:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 13:11:55 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-i73muum4oP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #100 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #99)
> (In reply to Jonathan Druart from comment #98)
> > 1. "Add optional support for `:` as the modifier"
> > We should document that. Why do we have it here actually? Shouldn't it be on
> > its own bug?
> 
> I agree.
> 
> > 2. Cannot we come with something better than "_str" and "str"?
> 
> I agree with that, you proposed. You don't like?

Yes, the idea, but I was expecting someone to tell me that "str" is ugly
(especially when appearing twice :D)
The second one can be 'str', not the first one.

> > 3. We still have specific reference to "av" when I think we should focus on
> > "stringify coded values" as a general concept.
> 
> AV expansion can be expensive. And so other strings. The idea of ':', was to
> later add <attribute>:str, so things that are not linked to av, might be
> generated on demand as well.

In my mind consumers don't want to ask for each attributes to be expanded, but
one "expand everything" (actually "stringify everything") switch. I may be
wrong.

Maybe we are mixing "expand" and "stringify" into the same concept and we
should not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 14:29:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 13:29:49 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-79VktNAOHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 14:50:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 13:50:38 +0000
Subject: [Koha-bugs] [Bug 32112] New: Misaligned checkbox and text in
 batchmod.pl
Message-ID: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

            Bug ID: 32112
           Summary: Misaligned checkbox and text in batchmod.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When deleting items in batch, there is an option to delete the bibliographic
record if all the items are deleted. In the new design, the text and the
checkbox for this option are misaligned. They are also on the same line as the
button to delete the item, which was not the case before.

To test:
1. Go to a bibliographic record that has items
2. Click Edit > Delete items in a batch
   --> At the bottom of the resulting screen, there is a checkbox 'Delete
records if no items remain', which is misaligned

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 14:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 13:52:14 +0000
Subject: [Koha-bugs] [Bug 32112] Misaligned checkbox and text in batchmod.pl
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-UMXhhdLD8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 143209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143209&action=edit
Screenshot of the items batch deletion tool in the old design

This is a screenshot of the items batch deletion tool in the old design. Note
that the text and checkbox under the table are aligned, and also on their own
line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 14:53:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 13:53:34 +0000
Subject: [Koha-bugs] [Bug 32112] Misaligned checkbox and text in batchmod.pl
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-bIYPNA0wf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 143210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143210&action=edit
Screenshot of the items batch deletion tool in the new design

This is a screenshot of the items batch deletion tool in the new design. Note
that the checkbox and text are misaligned and also on the same line as the
button and cancel option.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 14:58:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 13:58:15 +0000
Subject: [Koha-bugs] [Bug 32112] Misaligned checkbox and text in batchmod.pl
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-wN8FhOmfOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I just noticed that the line break is not in the more recent versions. I was
comparing with the manual screenshot, which dates back to I don't know when,
but I checked in a 21.05 instance and the option is on the same line as the
button and delete option.

I kind of like when it is on two lines, but I don't know why it was changed,
and maybe there is a reason it was put on the same line...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:10:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:10:15 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-QItkoX2TiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:10:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:10:20 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-LIl1pa5aiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143211&action=edit
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:10:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:10:57 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-9wEZmuvgoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143211|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143212&action=edit
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:11:11 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-0IpldKmNdH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:11:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:11:17 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-hIVfg49moO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-oG8SE5P8nd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-k3R0h40Uav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143200|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:30 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9z0cByq2Si@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143202|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-EDhfeBn63I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143204|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:43 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-8z3wWLq1hp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143205|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:48 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-ITwsNLgNep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143206|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:12:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:12:54 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-M6QBWrtCVQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143207|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:00 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-SOgNMi3TVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143208|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:08 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-g6xFDcRf9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143186|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:15 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-SJCHKWazB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143187|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:22 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-6KUkBtxl3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143188|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:28 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-8bezGHyTn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143189|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:34 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Et4gRLYKpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143190|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:40 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Hc3NmkPYaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143191|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:47 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-FCDyUDJADM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143192|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:53 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-WK4MMNfUbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143193|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:13:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:13:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-YC3N9TT0en@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143194|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:14:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:14:05 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-rokg2ocy5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143195|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:14:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:14:11 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-DzIIzbLTfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143196|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:14:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:14:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-NTE8Tm9cxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143197|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:14:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:14:25 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-c26m05woEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143198|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:14:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:14:31 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-D4Var3KWkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143199|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:20:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:20:58 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-XTNDLWzKFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

--- Comment #24 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 143213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143213&action=edit
Bug 29145: (QA follow-up) Add missing POD and don't return undef

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:22:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:22:58 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-Aui6VPy9Lc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #25 from David Gustafsson <glasklas at gmail.com> ---
Thanks for the feedback, will be sure to run qa-tools next time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:53:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:53:36 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-AdumL4dkIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:53:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:53:46 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-HFWVN0Gscb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143052|0                           |1
        is obsolete|                            |

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143214&action=edit
Bug 32028: Add page-section to smart-rules.tt and fix markup errors

To test:
1. Apply patch
2. Go to Adminstration > Circulation and fine rules
3. Look at the page-section added and make sure each looks good.
4. Use an HTML validator to check and make sure the HTML looks good.

Note: There are indentation changes and some fixes to bad markup ( stray tags,
etc ).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:58:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:58:25 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-S4VIaLjsKI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #156 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143215&action=edit
Bug 31378: DB changes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:58:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:58:33 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9ZrTMIu0gi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #157 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143216&action=edit
Bug 31378: DBIC updates [DO NOT PUSH]

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:58:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:58:41 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-E1EzjQhsM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #158 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143217&action=edit
Bug 31378: Add dependencies

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:58:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:58:49 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-XN6pooyzv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #159 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143218&action=edit
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:58:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:58:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-cXI3nSLsaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #160 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143219&action=edit
Bug 31378: Add Koha::Auth::Provider(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:59:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:59:13 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9NBj3Fx3OH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #161 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143220&action=edit
Bug 31378: Add Koha::Auth::Client* modules

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:59:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:59:31 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-iR8RQtVsxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #162 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143221&action=edit
Bug 31378: Add Auth mojo plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:59:40 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-g86vLBpgCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #163 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143222&action=edit
Bug 31378: Add API routes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:59:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:59:48 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-yUxkbOdCVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #164 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143223&action=edit
Bug 31378: Add auth providers template plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 15:59:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 14:59:57 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-PWcq0S21jX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #165 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143224&action=edit
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:00:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:00:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-qZ6UVfRnBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #166 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143225&action=edit
Bug 31378: Add OPAC support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:00:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:00:20 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-nFdcun70OP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #167 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143226&action=edit
Bug 31378: Add STAFF support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:00:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:00:29 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9nbzVijvJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #168 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143227&action=edit
Bug 31378: Add accessor methods for JSON attributes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:00:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:00:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-mYRdpk9OAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #169 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143228&action=edit
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:00:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:00:45 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-jyt7u5NbwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #170 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143229&action=edit
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:00:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:00:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Uimm5NgUOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #171 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143230&action=edit
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:01:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:01:11 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Q5bSBbcC32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #172 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143231&action=edit
Bug 31378: Add an administration interface for authentication sources

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:01:22 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Faz0MShgUG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #173 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143232&action=edit
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:01:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:01:31 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Ai6HZkEC51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #174 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143233&action=edit
Bug 31378: (follow-up) Fix QA concerns

Several FIXME comments added on the report addressed here.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:01:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:01:41 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-1dZCmlarr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #175 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143234&action=edit
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:01:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:01:53 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-TqwzYvDh8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #176 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143235&action=edit
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:02:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:02:02 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-XStNa1jcaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #177 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143236&action=edit
Bug 31378: (QA follow-up) Tidy tests

This patch perltidys the tests added lately. It also removes some
commented debugging lines.

Note: There's an attempt to write tests on the full auth workflow that
is commented out but left there on purpose for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:16:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:16:05 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-9L3OjFPHjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:16:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:16:05 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-DfzLFqLlR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32103


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103
[Bug 32103] Content field in HTML customizations is too narrow ( CodeMirror )
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:17:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:17:22 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-iXn2UnHA7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Carolyn Hughesman <chughesman at cclsny.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chughesman at cclsny.org

--- Comment #6 from Carolyn Hughesman <chughesman at cclsny.org> ---
+1 This is frustrating to our patrons as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:17:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:17:50 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Fzz9QHCyj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #178 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I restored Lucasz signature that was lost at some point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:18:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:18:57 +0000
Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should
 have an option to filter out notforloan statuses
In-Reply-To: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27973-70-eyuaLqxr48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Carolyn Hughesman <chughesman at cclsny.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chughesman at cclsny.org

--- Comment #5 from Carolyn Hughesman <chughesman at cclsny.org> ---
+1 This is frustrating to our patrons as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:37:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:37:38 +0000
Subject: [Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be
 able to alert even if not staged
In-Reply-To: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31263-70-wrKV9V4KyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:38:17 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-TkxGBs00sU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:38:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:38:24 +0000
Subject: [Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be
 able to alert even if not staged
In-Reply-To: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31263-70-6qrAn3qpY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:38:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:38:25 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-L2ZIOZNSBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143237&action=edit
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:38:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:38:31 +0000
Subject: [Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be
 able to alert even if not staged
In-Reply-To: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31263-70-xI5hZsXLXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:40:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:40:26 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-7gbgOhWxDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I went with the nice version, I think (not the ideal one however).

Note that I won't have much additional time for this.

https://snipboard.io/sfo6We.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:43:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:43:27 +0000
Subject: [Koha-bugs] [Bug 23644] Update linked patron accounts when one
 account is updated
In-Reply-To: <bug-23644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23644-70-icZMWtp1Rp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23644

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |andrewfh at dubcolib.org
             Status|NEW                         |RESOLVED

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---


*** This bug has been marked as a duplicate of bug 21551 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:43:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:43:27 +0000
Subject: [Koha-bugs] [Bug 21551] Automatically update guarantee when
 updating guarantor
In-Reply-To: <bug-21551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21551-70-JOskV0KNoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21551

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
*** Bug 23644 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:12 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-h0gWa28z0J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142932|0                           |1
        is obsolete|                            |

--- Comment #236 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143238&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:18 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-bIxxjizyu9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142933|0                           |1
        is obsolete|                            |

--- Comment #237 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143239&action=edit
Bug 31028: DBIC Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:25 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-UMa7Vihr1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142934|0                           |1
        is obsolete|                            |

--- Comment #238 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143240&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:31 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-6RVKlND4ei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142935|0                           |1
        is obsolete|                            |

--- Comment #239 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143241&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:37 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ayoUbMkY8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142936|0                           |1
        is obsolete|                            |

--- Comment #240 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143242&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:44 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-snuaWoy5Dh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142937|0                           |1
        is obsolete|                            |

--- Comment #241 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143243&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:51 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-lrB4Lptrpk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142938|0                           |1
        is obsolete|                            |

--- Comment #242 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143244&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:51:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:51:58 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-YrBOeeqcSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142939|0                           |1
        is obsolete|                            |

--- Comment #243 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143245&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:05 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-OeWvZpC720@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142940|0                           |1
        is obsolete|                            |

--- Comment #244 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143246&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:12 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-YahK9MO2FE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142941|0                           |1
        is obsolete|                            |

--- Comment #245 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143247&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional cataloger notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CatalogerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CatalogerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:18 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-GkR9ZII6ZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142942|0                           |1
        is obsolete|                            |

--- Comment #246 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143248&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:26 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-044l8TIjlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142943|0                           |1
        is obsolete|                            |

--- Comment #247 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143249&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:33 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-LmTqAbSBKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142945|0                           |1
        is obsolete|                            |

--- Comment #248 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143250&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:40 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-Y7wLcmlfsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142946|0                           |1
        is obsolete|                            |

--- Comment #249 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143251&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:47 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-O34AE4NVnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142947|0                           |1
        is obsolete|                            |

--- Comment #250 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143252&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:52:54 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-NdGyoWGYxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142948|0                           |1
        is obsolete|                            |

--- Comment #251 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143253&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:53:01 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-9hHUHClLOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142949|0                           |1
        is obsolete|                            |

--- Comment #252 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143254&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:53:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:53:08 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-0vXODzmVxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #253 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143255&action=edit
Bug 31028: Add feedback to the patron on submission

This patch adds a success alert box when a patron submits a concern
sucessfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:53:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:53:15 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-kyR0lM91A7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #254 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143256&action=edit
Bug 31028: (follow-up) Fix permissions names

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:53:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:53:22 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-hgfW6lBYny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #255 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143257&action=edit
Bug 31028: (follow-up) Set notice to non-html

This should resolve the lack of linebreaks in resulting emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 16:54:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 15:54:42 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-27tLRUxRoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142944|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 17:03:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 16:03:41 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-1exFpSiljd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #256 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Nind from comment #235)
> I've retested and here are some more comments.

Thank you so much for persevering here :)

> 1. When submitting a concern on the OPAC, there is no acknowledgement
> message, for example like when you report a problem or make a purchase
> suggestion (such as, "Your catalog concern report was submitted.") - you are
> just returned to the record.

Added now to the OPAC.. I didn't add it to the staff client yet, I wasn't sure
it was as important here.

> 2. Last comment/update is prepopulated into the update field without a hard
> page refresh:
>    2.1 Click on the Details action for a concern
>    2.2 Add a comment in the update field and click on comment
>    2.3 Click on the details action again for the same concern without
> refreshing the page: note that the update field is populated with the last
> comment made
>    2.4 Click on another concern: same results as 2.3
>    2.5 If you click away to another page (or a hard referesh - Shift +
> Refresh), and then go back to the catalog concerns page this doesn't happen.

This should be resolved now.

> 3. Permissions to manage concerns - I still can't get this to work using the
> editcatalog permission: 
>    3.1 I added the editcatalog permission + all tools to a staff user
> (Henry).
>    3.2 When I go to access catalog concerns (either from 'Pending catalog
> concerns' on the home page or from the cataloging home page), I get "You do
> not have permission to access this page" and the login form. 
>    3.3 Without the permission, I don't see 'Pending catalog concerns' on the
> home page or "Catalog concerns" on the Cataloguing home page (as expected).
>    3.4 I also gave all permissions except "Access to all librarian functions
> (superlibrarian)" and I still get the same permission error as in 3.2.

Great work spotting this one, there was a misnamed permission on my part in the
code. Fixed now.

> 4. Details of concerns listed on the record details page are now shown,
> however:
>    4.1 If resolved, can still add comments, and can also click on resolve
> again (using the koha superlibrarian user).
>    4.2 Whereas, in the Cataloging > Catalog concerns area, once you have
> resolved the concern the only option you have is the "Comment" button.
>    4.2 If you don't have permission, can see the details in modal window and
> the Resolve and Comment buttons are displayed. When attempting to make a
> comment or resolve, the modal sits there with the "spinner" on the button.

This should now match the main concern management page.

> 5. Reporting a catalog concern from the staff interface - display of help
> text:
>    5.1 If the help text has a bulleted list, the bullets aren't shown (add
> some lines to the help text, make them into a bulleted list, report a
> problem in the staff interface for a record).

Resolved, but required a CSS rebuild to test

> 6. Notices sent using email (see [1] for how I set up to test):
>    8.1 Acknowledgement, update, and resolved notifications come through
> (acknowledgement messages came straight through, but update and resolved came
> through when I ran misc/cronjobs/process_message_queue.pl).

Timing is as designed, acknowledgement is immediate, other notices are queued.

>    8.2 The notify message to CatalogersEmail address didn't come through and
> is not in the message queue.

I can't seem to replicate this not coming through.. - Perhaps the empty
CatalogersEmail preference was cached?

>    8.3 Messages come through as a single line without any line breaks. Does
> the notice need HTML tags for this? See [2] for examples of what was
> received.

This should be resolved now by dropping the 'is_html' flag.

>    8.4 Only the 'Catalog concern updated' and 'Catalog concern resolved;
> notices were displayed under the patron's record of notices - the
> acknowledgement notice wasn't listed.

Acknowledgement should now also show here.

> 7. Setting CatalogerEmails - wrong name in test plan for patch 'Add email
> notification of cataloguers on submissions' (CataloguerEmails should be
> CatalogerEmails.

Corrected, but I also noticed you cannot enter a comma delimited list.. I think
it's OK to only allow one email address for now.

> 8. List of concerns - should it default to only displaying the unresolved
> concerns? Otherwise, the list could get quite long... Maybe this should be a
> separate bug if considered an issue, as I noticed that this is the same
> pattern used for OPAC problem reports and AllowCheckoutNotes.

Good idea, but I agree perhaps it's one for a later bug.

> [1] Set up for testing notifications using Gmail when using KTD. Add this to
> /etc/koha/sites/kohadev/koha-conf.xml, setup an App password for your Gmail
> account, add the details as indicated, and add your Gmail address as the
> email for a patron(s) used in testing:
> 
> <smtp_server>
>     <host>smtp.gmail.com</host>
>     <port>587</port>
>     <timeout>5</timeout>
>     <ssl_mode>STARTTLS</ssl_mode>
>     <user_name>YOURGMAILADDRESS</user_name>
>     <password>YOURAPPPASSWORD/password>
>     <debug>1</debug>
>  </smtp_server>
>    
> [2] Text of email messages - came through as a single line:
> 
> Acknowledgement:
> 
> Dear koha (42), Thankyou for your report concerning Lady Susan ; The Watsons
> ; Sanditon / . You reported: **Describe the concern** A clear and concise
> description of what the concern is. **To Reproduce** Steps to reproduce the
> behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See
> error **Expected behavior** A clear and concise description of what you
> expected to happen. Thankyou 
> 
> Update:
> 
> Dear koha (42), The library has added an update to the concern you reported
> against Lady Susan ; The Watsons ; Sanditon / . The following comment was
> left: Send an update Thankyou 
> 
> Resolved:
> 
> Dear koha (42), The library has now marked your concern with Lady Susan ;
> The Watsons ; Sanditon / as resolved. The following comment was left: This
> is now fixed! Thankyou

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 17:36:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 16:36:00 +0000
Subject: [Koha-bugs] [Bug 32113] New: Missing table from batchMod.pl when
 coming from a bib record
Message-ID: <bug-32113-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32113

            Bug ID: 32113
           Summary: Missing table from batchMod.pl when coming from a bib
                    record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

There are several ways to access batch item modification, one of them is from a
bibliographic record. Normally, there is a table showing item details at the
top of the page. But that table is missing when we access the page from a
bibliographic record.

To test:
1) Go to Reports
2) Make a report of item numbers (e.g. select itemnumber from items limit 5)
3) Click Batch operations with X visible records
4) Choose Batch item modification
   --> Note that there is a table of items at the top of the page
5) Go to a bibliographic record that has at least one item (and less than 1000)
6) Click Edit > Edit items in batch
   --> Note that there is no table at the top of the page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:11:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:11:04 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-EKBA6daM89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143258&action=edit
Proposed layout change

How does this look as an alternative layout?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:20:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:20:28 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-RC2fGjv2UT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff Client                |Templates
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:35:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:35:20 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-TZW9qzktpP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:35:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:35:23 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-ejoDQo3rP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143259&action=edit
Bug 32043: Circulation alerts can overlap other elements on smaller screens

This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.

To test, apply the patch and rebuild the staff interface CSS.

Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:

- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.

The confirmation dialog should have a comfortable margin between it and
the checkout form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:46:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:46:02 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-8qWjmncj32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:46:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:46:08 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-XN787yIpL6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143146|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143260&action=edit
Bug 32028: Add page-section to various admin pages

This patch adds the page section to div to the following administration pages:

admin/cash_registers.tt
admin/cities.tt
admin/credit_types.tt
admin/debit_types.tt
admin/patron-attr-types.tt
admin/restrictions.tt
plugins/plugins-home.tt

To test go the following pages and make sure everything looks good:

Administration > Cash registers. You must enable the sys pref
'UseCashRegisters'
Administration > Cities and towns.
Administration > Credit types
Administration > Debit types
Administration > Patron restrictions
Adminstration > Patron attribute types
Administration > Manage plugins

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:46:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:46:13 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-YTScH2JTUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143214|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 143261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143261&action=edit
Bug 32028: Add page-section to smart-rules.tt and fix markup errors

To test:
1. Apply patch
2. Go to Adminstration > Circulation and fine rules
3. Look at the page-section added and make sure each looks good.
4. Use an HTML validator to check and make sure the HTML looks good.

Note: There are indentation changes and some fixes to bad markup ( stray tags,
etc ).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:48:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:48:31 +0000
Subject: [Koha-bugs] [Bug 21551] Automatically update guarantee when
 updating guarantor
In-Reply-To: <bug-21551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21551-70-5QsAeW1qgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21551

--- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> ---
As stated in bug 23644, we are interested in this project, and our consortium
would like to help fund this enhancement.  Also, to recap my thoughts on how
this might work:

We are thinking the following would be good parameters for this:
* When a guarantor or guarantee account is updated, have Koha check for
connected accounts.
* If detected, a checkbox is added to the edit screen to "Update connected
accounts"
* Upon saving the record, if the checkbox is checked, Koha will present an edit
screen for each of the connected accounts, with the fields pre-populated with
the updated information from the original edit screen.  Staff can then choose
to save the record as is, or modify each field as necessary (for instance, if
each person had their own unique email address)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:50:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:50:46 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-ypHrzLTche@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143262&action=edit
Overlay of previous version and current version

Overlaying the two versions it looks to me like the new version is, if
anything, slightly larger.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:52:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:52:56 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-uZqpGqhf2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 18:53:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 17:53:52 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-WAz79kYp4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #8 from David Nind <david at davidnind.com> ---
Questions from testing:

1. Delete confirmation messages: there are two styles, assuming there will be
bugs to fix these at some stage to make consistent:
   - Patron restrictions - "new" style (confirmation message in a page section
div)
   - Patron attribute types - "old" yellow style (yellow box and asking you to
confirm deletion)
   - Cities and towns - "old" yellow style

2. Patron restrictions: Delete - 'Delete this restriction' and cancel buttons
are in the page section div.

3. Plugins: has the tools sidebar menu, breadcrumb, and page title - if there
is not a bug for that already, then I can log one.

Other notes:

1. Plugins: installed three plugins - BiblbioCommons connector plugin for Koha,
Example Kitchen-Sink Plugin, and SMS::Send::LinkMobility::Driver. Assuming it
will be up to the plugin author to update any pages for their plugin, for
example, the kitchen sink plugin configure section.

2. Circulation and fines rules: 
   - before patch applied any before any changes made: 0 errors, 73 warnings
(using HTML Validator for Firefox - https://www.gueury.com/mozilla/)
   - after applying patch: 0 errors, 54 warnings
   - not sure of the "best" tool to do this or where the threshold is for
addressing any issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:00:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:00:45 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-b9Q7jCV1V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:00:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:00:49 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-MG5U8GmIJQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143071|0                           |1
        is obsolete|                            |
 Attachment #143072|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143263&action=edit
Bug 32066: Add unit test to Auth.t

Test plan:
Run without next patch. Should fail.
Run with next patch. Should pass.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:02:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:02:49 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-JfZAnmf8Tv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143263|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143264&action=edit
Bug 32066: Add unit test to Auth.t

Test plan:
Run without next patch. Should fail.
Run with next patch. Should pass.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:03:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:03:01 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-iOEM6TKs77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143265&action=edit
Bug 32066: Check 2FA pref in check_cookie_auth

Test plan:

Without this patch:
1. Set the syspref TwoFactorAuthentication (enforce or enabled)
2. Configure 2FA for a patron
3. Logout
4. Authenticate but don't enter the 2FA code
5. Switch off the syspref (disabled) [via another browser or so]
6. Patron is stuck on the [original] login screen. [Only removing
   the session cookie would resolve it.]

With this patch:
1. Follow the steps above again. But note that you can refresh
   your browser window to get in now.
2. Verify that Auth.t passes now too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:10:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:10:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-YKnJhr1amO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143215|0                           |1
        is obsolete|                            |

--- Comment #179 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143266&action=edit
Bug 31378: DB changes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:06 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-ejF4fnxEJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143216|0                           |1
        is obsolete|                            |

--- Comment #180 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143267&action=edit
Bug 31378: DBIC updates [DO NOT PUSH]

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:12 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-x3GKOxe05N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143217|0                           |1
        is obsolete|                            |

--- Comment #181 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143268&action=edit
Bug 31378: Add dependencies

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-xYB7GKRxp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143218|0                           |1
        is obsolete|                            |

--- Comment #182 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143269&action=edit
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:25 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-3o5DMNDeYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143219|0                           |1
        is obsolete|                            |

--- Comment #183 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143270&action=edit
Bug 31378: Add Koha::Auth::Provider(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:31 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-SB4TVjkyH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143220|0                           |1
        is obsolete|                            |

--- Comment #184 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143271&action=edit
Bug 31378: Add Koha::Auth::Client* modules

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-OL7jYjiulD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143221|0                           |1
        is obsolete|                            |

--- Comment #185 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143272&action=edit
Bug 31378: Add Auth mojo plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:43 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-UTzpPM9iO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143222|0                           |1
        is obsolete|                            |

--- Comment #186 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143273&action=edit
Bug 31378: Add API routes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:49 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-0Z2flhvanx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143223|0                           |1
        is obsolete|                            |

--- Comment #187 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143274&action=edit
Bug 31378: Add auth providers template plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:51 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-pyq4B7D899@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:56 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-OYxzIdyYBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143224|0                           |1
        is obsolete|                            |

--- Comment #188 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143275&action=edit
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:11:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:11:57 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-56nQkvhbHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #101 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143276&action=edit
Bug 26635: (QA follow-up) Rename key _str to _strings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:03 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-mgihntoX5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143225|0                           |1
        is obsolete|                            |

--- Comment #189 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143277&action=edit
Bug 31378: Add OPAC support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:10 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-qIPhOYS6C2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143226|0                           |1
        is obsolete|                            |

--- Comment #190 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143278&action=edit
Bug 31378: Add STAFF support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:17 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-GRDaGdwJdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143227|0                           |1
        is obsolete|                            |

--- Comment #191 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143279&action=edit
Bug 31378: Add accessor methods for JSON attributes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:23 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-EiBYumrds5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143228|0                           |1
        is obsolete|                            |

--- Comment #192 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143280&action=edit
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:29 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-sszN0kX1DL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143229|0                           |1
        is obsolete|                            |

--- Comment #193 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143281&action=edit
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:36 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-N26vV4gzfJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143230|0                           |1
        is obsolete|                            |

--- Comment #194 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143282&action=edit
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:12:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:12:48 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-I2bIBJnJAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143231|0                           |1
        is obsolete|                            |

--- Comment #195 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143283&action=edit
Bug 31378: Add an administration interface for authentication sources

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:13:00 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-vYqqU7aCWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143232|0                           |1
        is obsolete|                            |

--- Comment #196 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143284&action=edit
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:13:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-DnLID9ykwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143233|0                           |1
        is obsolete|                            |

--- Comment #197 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143285&action=edit
Bug 31378: (follow-up) Fix QA concerns

Several FIXME comments added on the report addressed here.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:13:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:13:13 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-3BVLzMP36j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143234|0                           |1
        is obsolete|                            |

--- Comment #198 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143286&action=edit
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:13:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:13:19 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-MK4dCP5cYL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143235|0                           |1
        is obsolete|                            |

--- Comment #199 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143287&action=edit
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:13:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:13:26 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-hUMxilpHuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143236|0                           |1
        is obsolete|                            |

--- Comment #200 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143288&action=edit
Bug 31378: (QA follow-up) Tidy tests

This patch perltidys the tests added lately. It also removes some
commented debugging lines.

Note: There's an attempt to write tests on the full auth workflow that
is commented out but left there on purpose for now.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:16:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:16:02 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-wMh499f0DV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #102 from Kyle M Hall <kyle at bywatersolutions.com> ---
> Yes, the idea, but I was expecting someone to tell me that "str" is ugly
> (especially when appearing twice :D)
> The second one can be 'str', not the first one.

Fix in the latest followup!

> In my mind consumers don't want to ask for each attributes to be expanded,
> but one "expand everything" (actually "stringify everything") switch. I may
> be wrong.

I think it depends on the use case. For speed, it is good to specify each
expansion you'd like. Adding an 'expand all' switch would be a nice enhancement
on top of this, but I don't think it's necessary for this to move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:27:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:27:02 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-uxhYnPw0Kl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:27:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:27:06 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-eznVbuX1C3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143152|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143289&action=edit
Bug 32085: Consistent classes for primary buttons: Labels

This patch makes changes the button markup in label-creation templates
-- including the barcode image generator -- so that all submit buttons
and any buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view label-related pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 19:37:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 18:37:22 +0000
Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than
 one patron category
In-Reply-To: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26573-70-9fCNUZojs2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
TABLE `borrower_attribute_types` (
  `code` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'unique key
used to identify each custom field',
  `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT
'description for each custom field',
  `repeatable` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines whether one
patron/borrower can have multiple values for this custom field  (1 for yes, 0
for no)',
  `unique_id` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if this value
needs to be unique (1 for yes, 0 for no)',
  `opac_display` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if this field
is visible to patrons on their account in the OPAC (1 for yes, 0 for no)',
  `opac_editable` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if this field
is editable by patrons on their account in the OPAC (1 for yes, 0 for no)',
  `staff_searchable` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if this
field is searchable via the patron search in the staff interface (1 for yes, 0
for no)',
  `authorised_value_category` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT
NULL COMMENT 'foreign key from authorised_values that links this custom field
to an authorized value category',
  `display_checkout` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if this
field displays in checkout screens',
  `class` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '' COMMENT
'defines a class for an attribute_type',
  `keep_for_pseudonymization` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if
this field is copied to anonymized_borrower_attributes (1 for yes, 0 for no)',
  `mandatory` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if the attribute
is mandatory or not',
  PRIMARY KEY (`code`),
  KEY `auth_val_cat_idx` (`authorised_value_category`),
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
) at /kohadevbox/koha/C4/Installer.pm line 583.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 20:29:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 19:29:01 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-50AUkIdap3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 20:29:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 19:29:06 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-UByLV7EOIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143179|0                           |1
        is obsolete|                            |

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 143290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143290&action=edit
Bug 32110: Fixup to db_rev for non-english, multilingual Koha

Without this patch, the update process duplicates all the news and
content entries when they were non-english to start with.

This patch keeps the same process, but new "default" "parent" entries are empty
so there'
no duplication in the OPAC display, while still being editable/deletable
in the intranet.

We came through that through many iterations.  This was the least
invasive while still providing satisfying results.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 20:32:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 19:32:28 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-agkFTmR8GA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Works well for upgrade from 20.11.

Note that it creates HTML customizations with empty content for default.
If you edit and try to save it will show a popup saying content can not be
empty.

We can leave it like that, it is much better as currently.
Or we may add some HTML comment in content, like "<!-- generated by upgrade
-->"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 20:55:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 19:55:28 +0000
Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
In-Reply-To: <bug-31897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31897-70-JgzmwmvwlJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897

--- Comment #13 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
(In reply to Marcel de Rooy from comment #12)

> I would fail Indexer.t now too for the same reason indeed. But it is pushed
> already ;)
> I am not an Elastic expert. Please ask on IRC or dev list.

I'll have to put this on hold for the time being. It's not within the scope of
this patch, nor unfortunately within the scope of my available time and
resources to deal with a solution to the generic Elasticsearch testing model.
We're at the end of a release-phase now, and the actual code in this works for
us. It'll have to be resumed at some later date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 21:35:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 20:35:16 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-wXSsi2THB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #257 from David Nind <david at davidnind.com> ---
Thanks Martin for fixing all these things!

On retesting, some more issues (sorry!).

1. Error on OPAC - there looks to be something wrong with the patch 'Add
feedback to the patron on submission':
   - I get this error in the console when accessing thedetails page for a
record:
   09:25:59.890 Uncaught SyntaxError: missing } after property list
catalog_concern_22.0600077.js:45:12
   note: { opened at line 32, column 15
   - Clicking on 'Report a concern' in the OPAC doesn't prompt you to login,
and doesn't do anything when you submit
   - I skipped this patch for testing everything else

2. Staff interface home page display - "Catalog concerns pending: X":
   - If CatalogConcerns is not enabled, then this doesn't display (not expected
- would expect it to display if staff user can manage catalog concerns)
   - If there are active purchase suggestions, problem reports, article
requests, and allow checkout notes (with these system preferences enabled), it
does display (tested various combinations, and ended up confusing myself!)
   - If purchase suggestions, problem reports, article requests, and allow
checkout notes are not enabled (or there are no active requests), then it
doesn't display catalog concerns pending

3. Notices:

   3.1 TICKET_ACKNOWLEDGE notice: 
   . there are lots of extra lines in the message, not sure whether that is
something to do with using Gmail to test or not [1]
   . there is a span tag visible around the record name
   . If I select HTML message for the notice, it comes through as one line
   . This is similar for the other notices (and non-catalog concern notices as
well) - it maybe something more generic with my setup/HTML email message
generation

   3.2 TICKET_NOTIFY notice - warning in the
/var/log/koha/kohadev/plack-api-error.log:
  [2022/11/04 19:36:16] [WARN] No catalog TICKET_NOTIFY letter transported by
email at /kohadevbox/koha/C4/Letters.pm line 584.
   . This warning may explain why I'm not receiving the TICKET_NOTIFY notices,
I'm assuming it is probably a combination of system preferences and the mail
setup using Gmail to send notices

   3.3 Patron sent notices: I'm now only seeing the catalog concern
acknowledgements notice under the patron's notices (previously I was only
seeing 'Catalog concern updated' and 'Catalog concern resolved' notices)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 21:47:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 20:47:22 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-pSbVX77lrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 21:47:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 20:47:26 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-G0lQEzpw63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143259|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143291&action=edit
Bug 32043: Circulation alerts can overlap other elements on smaller screens

This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.

To test, apply the patch and rebuild the staff interface CSS.

Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:

- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.

The confirmation dialog should have a comfortable margin between it and
the checkout form.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 21:49:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 20:49:46 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-87INlJ97gE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes:

- This was happening to me even on a large monitor (27") with browser window
maximised.

- Another occurrence to test is if you checkout an item to a patron and set the
due date in the past.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 21:53:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 20:53:23 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-bRS1ceACSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141168|0                           |1
        is obsolete|                            |

--- Comment #46 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 143292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143292&action=edit
Bug 11300: Add a new authority linker which searches for authority links on a
Z39.50 server.

This patch adds a Z39.50 Linker which searches for authority links on a remote
server.

If a matching authority is found, it's imported in the local database for
linking with the current biblio record.

If no matching authority was found on the remote server, the Linker falls back
to a local authority search.

Configuration :
* The option "Z39.50 Server" is added to the LinkerModule preference. You must
choose this to use the new Linker.
* The preference LinkerZ3950Server is required and specifies which server to
use for linking. It must contain the "name" of the server, as defined in the
z3950servers table.
* You can set the "local_first" option in the LinkerOptions preference to force
the Linker to search for authorities in the local database first. If no local
authority match was found, the Linker falls back to a remote Z39.50 search.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 21:56:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 20:56:05 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-sHHQR7VKie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:16 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-PQWtcoePHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:18 +0000
Subject: [Koha-bugs] [Bug 21381] Add serial enumeration to circulation
 history
In-Reply-To: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21381-70-iKsNk2QR0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21381

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:21 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-6T43NJIZe1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:25 +0000
Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all
 places
In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27259-70-eQgny6Xlp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:28 +0000
Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work
In-Reply-To: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31881-70-eIpW1VmzEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:31 +0000
Subject: [Koha-bugs] [Bug 31881] Link in MARC view does not work
In-Reply-To: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31881-70-sPyQ2k9IEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:34 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-8SpV7sAshV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:40 +0000
Subject: [Koha-bugs] [Bug 31987] Update plugin unimarc_field_110.pl fields
In-Reply-To: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31987-70-kguJn3yzOq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31987

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:47 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-YiMOj4rPaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:51 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-ytq0ASRAf3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:54 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-34FPfobpUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:14:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:14:58 +0000
Subject: [Koha-bugs] [Bug 32066] 2FA: User could get stuck temporarily on
 login screen when disabling pref
In-Reply-To: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32066-70-R2FIC4xIA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:24 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if patron has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-t9gWh25fgq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:28 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if patron has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-D163rTYGVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:32 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-JrBHVuVFMO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:35 +0000
Subject: [Koha-bugs] [Bug 31654] Hide non-public libraries from
 MastheadLibraryPulldown
In-Reply-To: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31654-70-nUuiqbuDhU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31654

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:38 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-vWj9N9b6iH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:40 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-nabWoMTTEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:42 +0000
Subject: [Koha-bugs] [Bug 31919] Hovered items in "More" should change
 background color
In-Reply-To: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31919-70-tCYXYxbHGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:45 +0000
Subject: [Koha-bugs] [Bug 31919] Hovered items in "More" should change
 background color
In-Reply-To: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31919-70-TsvPMrom4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:48 +0000
Subject: [Koha-bugs] [Bug 32037] Circulation module in action logs has bad
 links for deleted items
In-Reply-To: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32037-70-yDj18o2WKk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:50 +0000
Subject: [Koha-bugs] [Bug 32037] Circulation module in action logs has bad
 links for deleted items
In-Reply-To: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32037-70-4wYtLcRqqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32037

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:52 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-tlSk7bEFFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:25:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:25:55 +0000
Subject: [Koha-bugs] [Bug 32085] Consistent classes for primary buttons:
 Labels
In-Reply-To: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32085-70-7EoAN3xoeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:33:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:33:10 +0000
Subject: [Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong
 match when passed 'best only'
In-Reply-To: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32054-70-UeG2KhkT9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:33:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:33:12 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-DYBDSyhHqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:33:15 +0000
Subject: [Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong
 match when passed 'best only'
In-Reply-To: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32054-70-znZyXphslW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142838|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143293&action=edit
Bug 32054: Add get_import_record_matches object method and use it

Thispatch adds the new method and alters addorderiso2907.pl to use this
rather than GetRecordImportMatches

To test:
 1 - Import the attached record several times
 2 - Set up a matching rule:
    TitleAuthor threshold: 100
    Matchpoint:
    search index: title, score: 100, tag: 245$a
    search index: author, score: 100, tag:100$a
 3 - Edit one of the imported records to have a different author
 4 - Stage the file again. and match using the matchpoint above
 5 - Note that matches are found and listed on batch management, with the
lowest scored match last
 6 - Choose that match
 7 - In acquisitions, add to a basket from the staged file
 8 - Check the box for the record
 9 - Note the match lists the biblionumber for the highest scoring match, not
the chosen one
10 - Add an order and note it is for the wrong biblio
11 - Appy patch
12 - Restart_all
13 - Stage the file again and choose a lower scoring match
14 - Confirm when adding to basket this match is preserved
15 - Complete order and verify correct biblio ordered
16 - Stage again, select no match
17 - Confirm no match listed when adding to basket, and choose 'Do not look for
matching records' while adding
18 - Confirm order is created on a new biblio

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:36:36 +0000
Subject: [Koha-bugs] [Bug 32054] GetImportRecordMatches returns the wrong
 match when passed 'best only'
In-Reply-To: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32054-70-Uelc4Gmx9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32054

--- Comment #5 from David Nind <david at davidnind.com> ---
I think I tested this correctly - this is the first time I've used matching
rules and adding to an order from a staged record.

Mainly found the options for steps 14-15, and the duplicate record message and
choices, a bit confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:38:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:38:10 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-MzLTjtDWfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:49:36 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-EA1u9WFAwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:49:40 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-BEwlswRGIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143212|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143294&action=edit
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:55:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:55:11 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-aLtzgtbwQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov  4 23:55:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 22:55:16 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-N2C4V7d14Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143237|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 143295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143295&action=edit
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:19:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:19:26 +0000
Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing
In-Reply-To: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31907-70-p9IvVwJ7Q1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143296&action=edit
Bug 31907: (QA follow-up) Simplify tests

This patch simplipfies the tests, and highlighs the fact the introduced
method should add filters to the current resultset.

It also aligns the tests with the currently adopted style.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:20:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:20:57 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-vr719MVZX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:02 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-m6JnrTuWEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #224 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:06 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-ipYEH6Vidt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:10 +0000
Subject: [Koha-bugs] [Bug 31517] C4::Tags should use Koha::Tags objects
 instead of raw SQL
In-Reply-To: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31517-70-Ll3r0BzcdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:13 +0000
Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when
 EnhancedMessagingPreferencesOPAC is off
In-Reply-To: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31743-70-PskGCWNEUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:16 +0000
Subject: [Koha-bugs] [Bug 31743] Cannot change my notice language when
 EnhancedMessagingPreferencesOPAC is off
In-Reply-To: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31743-70-l3oBreE8o3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31743

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:19 +0000
Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount
 exceeds allowed budget when editing existing order
In-Reply-To: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31840-70-blF3uQnWxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:22 +0000
Subject: [Koha-bugs] [Bug 31840] Incorrect warning that order total amount
 exceeds allowed budget when editing existing order
In-Reply-To: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31840-70-i3N6gruud1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:25 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-wXf0wbRJde@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:29 +0000
Subject: [Koha-bugs] [Bug 31887] Search on MARC field does not work in
 Elasticsearch mappings table
In-Reply-To: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31887-70-U0vbTBvmrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:34 +0000
Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing
In-Reply-To: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31907-70-Lc2AkkBwbG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:21:37 +0000
Subject: [Koha-bugs] [Bug 31907] Show items as On hold when in processing
In-Reply-To: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31907-70-4UZ4bJW5kY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31907

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:29:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:29:05 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-ouibw5hlkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Keywords|                            |additional_work_needed

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Marcel, this broke some tests because of the order in which items are added by
the exporter:

https://jenkins.koha-community.org/job/Koha_Master_D11_My8/1082/

In my opinion it looks suspicios as items should be introduced ordered by id.
I'm not too worried because we actually plan to remove the use of this method
(_embed_items) for good.

But please, fix the failing tests for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 00:29:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Nov 2022 23:29:14 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-xQNNMYhj1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 16:57:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 15:57:12 +0000
Subject: [Koha-bugs] [Bug 32114] New: Template error in OPAC search results
 RSS
Message-ID: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

            Bug ID: 32114
           Summary: Template error in OPAC search results RSS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 28307

Found during testing of Bug 28307:

> But I get the following error when
> clicking on the RSS feed for a search results page: 
> Template process failed: file error - biblio_a_href: not found at
> /kohadevbox/koha/C4/Templates.pm line 127


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307
[Bug 28307] Enable BakerTaylorEnabled content in the staff interface with
separate system preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 16:57:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 15:57:12 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-3hcOj8icNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32114


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114
[Bug 32114] Template error in OPAC search results RSS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 17:05:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 16:05:37 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-YwB6M41Ios@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 17:05:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 16:05:40 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-zdiofmTSjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143297&action=edit
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 17:06:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 16:06:46 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-mmQdgYirxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

--- Comment #32 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Juliet Heltibridle from comment #30)
> But I get the following error when
> clicking on the RSS feed for a search results page: 
> Template process failed: file error - biblio_a_href: not found at
> /kohadevbox/koha/C4/Templates.pm line 127

This bug is in master too. I have submitted a fix on Bug 32114.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 18:53:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 17:53:34 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-vyBsVltCaB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 18:53:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 17:53:38 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-KOmXLRCKyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143297|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143298&action=edit
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 19:20:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 18:20:40 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-kozK58kAJc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Some comments:

1. The forms seem to be aligned to the centre of the screen, rather than left
aligned.

2. Form input field widths: I think these look odd being almost all the same
width, particularly on the accounting details form for fields with numbers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 20:34:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 19:34:11 +0000
Subject: [Koha-bugs] [Bug 32115] New: Add ID to check-out default help
 message dialog to allow customization
Message-ID: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

            Bug ID: 32115
           Summary: Add ID to check-out default help message dialog to
                    allow customization
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Self checkout
          Assignee: m+koha at mpan.ch
          Reporter: m+koha at mpan.ch
        QA Contact: testopia at bugs.koha-community.org

We want to customize the default help message on the Self checkout page, as our
library  doesn't have bar codes and therefore doesn't have scanning. We only
have a number that users input when using self checkout. The help message
confused our users.

This doesn't seem to be something that many libraries will have.
Therefore as an easy solution, I propose to create a patch that adds a div with
an id around the default help message.
Then we can add our own help content in "SCOMainUserBlock" and hide the default
message with CSS in "SCOUserCSS". 

Otherwise I could also see there being a new flag that specifies whether a
library has scanning or not and changing the text based on that. That would
require lots of translation effort that doesn't seem worth it to me. 

I will attach a patch to this with my proposed solution but I am also open to
implementing other solutions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 20:47:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 19:47:51 +0000
Subject: [Koha-bugs] [Bug 32115] Add ID to check-out default help message
 dialog to allow customization
In-Reply-To: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32115-70-fo6FR0HKko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

--- Comment #1 from m+koha at mpan.ch ---
Created attachment 143299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143299&action=edit
Proposed patch to add div with id to allow hiding it and customize with
SCOMainUserBlock.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 20:48:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 19:48:56 +0000
Subject: [Koha-bugs] [Bug 32115] Add ID to check-out default help message
 dialog to allow customization
In-Reply-To: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32115-70-CWnUPoSm7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

m+koha at mpan.ch changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov  5 20:49:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 19:49:35 +0000
Subject: [Koha-bugs] [Bug 32115] Add ID to check-out default help message
 dialog to allow customization
In-Reply-To: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32115-70-sL5kEzgfnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

m+koha at mpan.ch changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m+koha at mpan.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 00:37:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 23:37:21 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-AyfYKhbEfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
In the /agreements page, the «Filter by expired: [X] on» is confusing. It's not
clear that it must be ticked for the date field to have any effect. Or maybe
unchecked has a different effect. But it seems not.

https://wtf.roflcopter.fr/pics/foywDHSU/5E4BFfT6.png

The doc draft says
> At the top of the Agreements page you will notice a Filter box. The purpose of this is to allow you to quickly filter expired agreements or agreements which may have an upcoming renewal (and therefore might require action).

There doesn't seem to be another filter mode when unchecked.

>From the code it seems the date field is only used when the box is ticked. Is
that done to be able to keep an expiration date saved without having it used?
(it's not saved so it's not that)
Otherwise the filter could just be used when the date field is populated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 00:40:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 23:40:35 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-mneRfDNz2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143300&action=edit
Screenshots - where some changes are required

I think these two things need looking at:

1. catalogue/moredetail.tt (items section for a record): alignment issue with
'Update' button for public and non-public note fields. See document with before
and after screenshots attached.

2. catalogue/search-history.tt: Line 182 of catalogue/search-history.tt needs
updating as well for the previous sessions for authority records, similar to
previous sessions for catalog records. See document with screenshot attached.

Testing notes (using KTD).

1. These changed templates accessed from:
   Details view for a record
   Search results from a normal catalog search
   The cart
   User account menu (search history)

2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/basket/
and koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/, and splitting into two
lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I haven't attached
this, but am happy to)
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser
cache)
   - Going through the list of files again: compared to original screenshot
taken, then noted whether changed or not
   - Noting any questions

3. Files changed:
   - basket/downloadcart.tt (No change. I couldn't find a link on the UI to get
to this form, was able to access directly at
http://127.0.0.1:8081/cgi-bin/koha/basket/downloadcart.pl, called from
basket/downloadcart.pl)
   - basket/sendbasketform.tt (No change. Add some items to the cart. View the
cart > Select all > Send.)
   - catalogue/advsearch.tt (Changed - search button now in orange. From the
menu bar: Search > Advanced search.)
   - catalogue/detail.tt (Not determined. I couldn't figure out how to trigger
or enable the "Download record" form/button.)
   - catalogue/itemsearch.tt (Changed - search button now in orange. Search
(from the navigation bar at top of screen) > Item search).)
   - catalogue/moredetail.tt (Changed - Set status and Update buttons are
larger. From the details page for a record select the 'Items' section.)
   - catalogue/results.tt (Minor change - search button is slightly bigger.
Search the catalog, under the search results is 'Search withing results'.)
   - catalogue/search-history.tt (Changed - 'Delete' is now an orange button,
dulled when no entries are selected, bright when entries are selected. Enable
EnableSearchHistory. Do some catalog and authority searches. Log out and then
log back in. Do some more catalog and authority searches. From the top
navigation bar go to your user account drop down list in the top right-hand
corner and select 'Search history'). 

4. Files not changed:
   - basket/basket.tt (Add some items to the cart. View the cart.)
   - basket/sendbasket.tt (This is the template for the body of the email
message sent when sending a cart.)
   - catalogue/imageviewer.tt (Enable LocalCoverImages, upload a cover image
for a record, triggered by clicking on the image displayed for the record and
under the images tab.)
   - catalogue/ISBDdetail.tt (View the ISBD section for a record.)
   - catalogue/issuehistory.tt (View the checkout history section for a
record.)
   - catalogue/itemsearch_csv.tt (Used to export details of items from Search >
Item search > [enter search term] > search results page.) 
   - catalogue/itemsearch_json.tt (Used to export details of items from Search
> Item search > [enter search term] > search results page.)
   - catalogue/labeledMARCdetail.tt (Enable viewLabeledMARC, view the labeled
MARC section for a record.)
   - catalogue/MARCdetail.tt (View the MARC section for a record.)
   - catalogue/showmarc.tt (Click on 'Show' for 'MARC preview' in the normal
details page for a record.)
   - catalogue/stockrotation.tt (Enable StockRotation and go to Cataloging >
Stock rotation. Add a new rota. Add a stage to the rota. Add an item to the
rota (Manage > Items > Add an item using barcode). View the rota section for a
record.)

5. File count check:
   - Number of files in folder - basket: 4
   - Number of files listed - basket: 4 (only 2 changed in this patch)
   - Number of files in folder -  catalogue: 15
   - Number of files listed - catalogue: 15 (only 6 changed in this patch)

Questions/notes: 

1. basket/downloadcart.tt: I couldn't find a link on the UI to get to this
form, was able to access directly at
http://127.0.0.1:8081/cgi-bin/koha/basket/downloadcart.pl, called from
basket/downloadcart.pl)

2. catalogue/detail.tt: I couldn't figure out how to trigger or enable the
"Download record" form/button - I see a form that may be it that flashes up
very briefly under the tabs section when viewing the details page for a record.

3. catalogue/moredetail.tt: alignment issue with 'Update' button for public and
non-public note fields. See document with before and after screenshots
attached.

4. catalogue/search-history.tt: Line 182 of catalogue/search-history.tt needs
updating as well for the previous sessions for authority records, similar to
previous sessions for catalog records. See document with screenshot attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 00:41:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Nov 2022 23:41:05 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-A2QSUGljg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 05:19:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 04:19:07 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-sAllCp6sWJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 05:19:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 04:19:11 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-CfOH5oTZdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143085|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143301&action=edit
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 05:21:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 04:21:30 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-oZvSJ472Wk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using KTD).

1. These changed templates accessed from: Home page > Course reserves.

2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   - Listing the templates in
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/ and splitting into two
lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I haven't attached
this, but am happy to)
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser
cache)
   - Going through the list of files again: compared to original screenshot
taken, then noted whether thre is a visible change or not
   - Noting any questions - these don't affect the sign off for this bug

3. Files changed:
   - add_items-step1.tt (No visible change. Course reserves > [select or create
a course] > Add reserves > [First step - barcode or biblionumber])
   - add_items-step2.tt (No visible change. Next step when adding a course
reserve - continues from step 1 - [select check boxes, add staff or public
notes])
   - batch_add_items.tt (No visible change. Course reserves > [select or create
a course] > Batch add reserves)
   - batch_rm_items.tt (No visible change. Course reserves > Batch remove
reserves)
   - course.tt (No visible change. Course reserves > New course)

4. Files not changed:
   - course-details.tt (Course reserves > [select or create a course])
   - course-reserves.tt (Course reserves) (course reserves home page)
   - invalid-course.tt (Not sure how to trigger - has no buttons anyway)

5. File count check:
   - Number of files in folder: 8
   - Number of files listed: 8 (5 changed in this patch)

Questions/notes: none

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:01 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-Z79hs1Eh2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143238|0                           |1
        is obsolete|                            |
 Attachment #143239|0                           |1
        is obsolete|                            |
 Attachment #143240|0                           |1
        is obsolete|                            |
 Attachment #143241|0                           |1
        is obsolete|                            |
 Attachment #143242|0                           |1
        is obsolete|                            |
 Attachment #143243|0                           |1
        is obsolete|                            |
 Attachment #143244|0                           |1
        is obsolete|                            |
 Attachment #143245|0                           |1
        is obsolete|                            |
 Attachment #143246|0                           |1
        is obsolete|                            |
 Attachment #143247|0                           |1
        is obsolete|                            |
 Attachment #143248|0                           |1
        is obsolete|                            |
 Attachment #143249|0                           |1
        is obsolete|                            |
 Attachment #143250|0                           |1
        is obsolete|                            |
 Attachment #143251|0                           |1
        is obsolete|                            |
 Attachment #143252|0                           |1
        is obsolete|                            |
 Attachment #143253|0                           |1
        is obsolete|                            |
 Attachment #143254|0                           |1
        is obsolete|                            |
 Attachment #143255|0                           |1
        is obsolete|                            |
 Attachment #143256|0                           |1
        is obsolete|                            |
 Attachment #143257|0                           |1
        is obsolete|                            |

--- Comment #258 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143302&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:10 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-JubJ0PhmKP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #259 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143303&action=edit
Bug 31028: DBIC Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:17 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-SkqVPidbce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #260 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143304&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:25 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-YYQqXMaFTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #261 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143305&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:32 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-rKPbtUCRav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #262 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143306&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:39 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-J3euArLfbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #263 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143307&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:48 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-PoEUFDoidI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #264 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143308&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:40:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:40:56 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-GtqwuzN4KK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #265 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143309&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:04 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-MBMYNluZ2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #266 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143310&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:10 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-JkCWp1NHcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #267 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143311&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional cataloger notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CatalogerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CatalogerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:21 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-KCe3OWwaKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #268 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143312&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:28 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-PixE6Up29S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #269 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143313&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:36 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-0GWK84x7jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #270 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143314&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:43 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-uC2z9Pxx1O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #271 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143315&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:49 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-plCGdb5GSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #272 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143316&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:41:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:41:57 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ktOa45Bcou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #273 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143317&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:42:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:42:04 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-M89mBqxIAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #274 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143318&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:42:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:42:11 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-X4Fw7YzJ8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #275 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143319&action=edit
Bug 31028: Add feedback to the patron on submission

This patch adds a success alert box when a patron submits a concern
sucessfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:42:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:42:18 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-c3GyHTZOk8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #276 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143320&action=edit
Bug 31028: (follow-up) Fix permissions names

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:42:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:42:25 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-W1BHavVrb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #277 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143321&action=edit
Bug 31028: (follow-up) Add <br> to notices

This should resolve the lack of linebreaks in resulting emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:48:36 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-h1zdWKwqUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like the x icon better than the trash icon, because it does empty the field
but not actually delete/remove. I think the red color was restored by another
patch I tested, but not sure which one right now :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:49:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:49:34 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-FRjmiLfgqq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #278 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Nind from comment #257)
> Thanks Martin for fixing all these things!
> 
> On retesting, some more issues (sorry!).
> 
> 1. Error on OPAC - there looks to be something wrong with the patch 'Add
> feedback to the patron on submission':

Damn, I missed a comma in the rebuse just prior to uploading that last set of
patches.. resolved now.

> 2. Staff interface home page display - "Catalog concerns pending: X":
>    - If CatalogConcerns is not enabled, then this doesn't display (not
> expected - would expect it to display if staff user can manage catalog
> concerns)
>    - If there are active purchase suggestions, problem reports, article
> requests, and allow checkout notes (with these system preferences enabled),
> it does display (tested various combinations, and ended up confusing myself!)
>    - If purchase suggestions, problem reports, article requests, and allow
> checkout notes are not enabled (or there are no active requests), then it
> doesn't display catalog concerns pending

So the conditions here are 'IF ( CatalogConcerns is enabled OR
OpacCatalogConcerns is enabled ) AND there are pending concerns AND the user
has the edit_catalog permission DISPLAY the pending concerns count'.  

I'm wondering if we got a database update mixed in somewhere a long the lines
or something here.  I just tested this with a fresh k-t-d running just the db
update and yarn builds and it appears to work as expected for me.

> 3. Notices:
> 
>    3.1 TICKET_ACKNOWLEDGE notice: 
>    . there are lots of extra lines in the message, not sure whether that is
> something to do with using Gmail to test or not [1]
>    . there is a span tag visible around the record name
>    . If I select HTML message for the notice, it comes through as one line
>    . This is similar for the other notices (and non-catalog concern notices
> as well) - it maybe something more generic with my setup/HTML email message
> generation

I've updated the final patch to go back to html emails and I've replaced the
\r\n with <br>.. hopefully that'll resolve this one.

>    3.2 TICKET_NOTIFY notice - warning in the
> /var/log/koha/kohadev/plack-api-error.log:
>   [2022/11/04 19:36:16] [WARN] No catalog TICKET_NOTIFY letter transported
> by email at /kohadevbox/koha/C4/Letters.pm line 584.
>    . This warning may explain why I'm not receiving the TICKET_NOTIFY
> notices, I'm assuming it is probably a combination of system preferences and
> the mail setup using Gmail to send notices

Hmm.. wonder if this was again a mix up in the database updates.. running this
in a fresh k-t-d now to try to replicate.

>    3.3 Patron sent notices: I'm now only seeing the catalog concern
> acknowledgements notice under the patron's notices (previously I was only
> seeing 'Catalog concern updated' and 'Catalog concern resolved' notices)

These only send when 'Notify' is set.. I'm testing this in k-t-d again now
myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 10:52:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 09:52:53 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-Lb0fTyjefi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
After QA feedback it's usually ok to set back to signed off directly :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:04 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-vgr2UfQoCf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143302|0                           |1
        is obsolete|                            |
 Attachment #143303|0                           |1
        is obsolete|                            |
 Attachment #143304|0                           |1
        is obsolete|                            |
 Attachment #143305|0                           |1
        is obsolete|                            |
 Attachment #143306|0                           |1
        is obsolete|                            |
 Attachment #143307|0                           |1
        is obsolete|                            |
 Attachment #143308|0                           |1
        is obsolete|                            |
 Attachment #143309|0                           |1
        is obsolete|                            |
 Attachment #143310|0                           |1
        is obsolete|                            |
 Attachment #143311|0                           |1
        is obsolete|                            |
 Attachment #143312|0                           |1
        is obsolete|                            |
 Attachment #143313|0                           |1
        is obsolete|                            |
 Attachment #143314|0                           |1
        is obsolete|                            |
 Attachment #143315|0                           |1
        is obsolete|                            |
 Attachment #143316|0                           |1
        is obsolete|                            |
 Attachment #143317|0                           |1
        is obsolete|                            |
 Attachment #143318|0                           |1
        is obsolete|                            |
 Attachment #143319|0                           |1
        is obsolete|                            |
 Attachment #143320|0                           |1
        is obsolete|                            |
 Attachment #143321|0                           |1
        is obsolete|                            |

--- Comment #279 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143322&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:12 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-2qwjmnDlKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #280 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143323&action=edit
Bug 31028: DBIC Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:20 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-0QWv5b6H6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #281 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143324&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:28 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-aRjSomgT33@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #282 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143325&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:36 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-4wbs2MnVR9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #283 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143326&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:43 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-cAyzH7OhcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #284 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143327&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:51 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ts6KSo9GIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #285 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143328&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:31:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:31:58 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-XPO6YA2ICK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #286 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143329&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:05 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-xIiclP9hsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #287 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143330&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:13 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ymjU1jJGcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #288 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143331&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional cataloger notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CatalogerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CatalogerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:21 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-9kkJJsFtt9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #289 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143332&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:30 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-qjaA9pXIi2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #290 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143333&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:38 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-9qIWsWfBd4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #291 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143334&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:46 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-EtdIBlKXcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #292 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143335&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:32:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:32:53 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-xhW3tSazUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #293 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143336&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:33:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:33:00 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-gjq2e0m5Qj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #294 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143337&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:33:08 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-wMAR6sIVYc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #295 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143338&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:33:15 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-tSZO26keGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #296 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143339&action=edit
Bug 31028: Add feedback to the patron on submission

This patch adds a success alert box when a patron submits a concern
sucessfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:33:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:33:23 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-A4riCErg9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #297 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143340&action=edit
Bug 31028: (follow-up) Fix permissions names

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:33:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:33:30 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-AsC4ZyeTrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #298 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143341&action=edit
Bug 31028: (follow-up) Add <br> to notices

This should resolve the lack of linebreaks in resulting emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 11:35:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 10:35:40 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-pofIAapsdH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #299 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Found and resolved the issue with update/resolve emails not sending.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 14:22:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 13:22:25 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-9rlOAGvd64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 14:22:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 13:22:30 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-NfZA1RcRVa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143110|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143342&action=edit
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 14:25:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 13:25:16 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-CvRUTmFz7b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using KTD).

1. These changed templates accessed from: Tools > Patrons and circulation >
Patron card creator

2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   - Listing the templates in
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards and splitting into two
lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I haven't attached
this, but am happy to)
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser
cache)
   - Going through the list of files again: compared to original screenshot
taken, then noted whether changed or not
   - Noting any questions - these don't affect the sign off for this bug

3. Files changed:
   - edit-layout.tt (No visible change. Manage > Layouts > select the 'Edit'
action for a layout) (same template used to add new layouts)
   - edit-profile.tt (No visible change. Manage > Printer profiles > select the
'Edit' action for a printer) (same template used to add new printer profiles)
   - edit-template.tt (No visible change. Manage > Card templates > select the
'Edit' action for a template) (same template used to add new card templates)
   - image-manage.tt (No visible change. Manage > Images) (Bonus - add an
image) (same template used to add and delete images)
   - print.tt (No visible change. New > Card batch > enter borrowernumbers >
Add patron > select Export card batch option)

4. Files not changed:
   - edit-batch.tt (Manage > Card batches > [select the 'Edit' action for a
batch] or [select a batch and the 'Export selected batches']
   - home.tt (Patron card creator home page - no buttons apart from toolbar)
   - manage.tt (used to either add or edit batches (or print selected batches
from a list of batches), images, layouts, card templates and printer profiles)

5. File count check:
   - Number of files in folder: 8
   - Number of files listed: 8 (5 changed in this patch)

Question

1. Should the buttons be in the div or outisde the div? Those in the white
background are:
   - Image manager: the upload button is inside the white div area

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 15:36:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 14:36:49 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-ao4guNNdqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

--- Comment #1 from Isobel Graham <isobel.graham09 at gmail.com> ---
Created attachment 143343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143343&action=edit
Bug 31414: Set focus to name in additional fields.

Focus is set to name on additional fields on
administation add fields.

Test plan
1. Go to administation and manange additional
fields.
2. If you then add field the focus should
automatically go to the field name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 15:37:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 14:37:38 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-z03MWweiYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

Isobel Graham <isobel.graham09 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |isobel.graham09 at gmail.com
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |isobel.graham09 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 16:04:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 15:04:43 +0000
Subject: [Koha-bugs] [Bug 31406] Set focus for cursor to Name input when
 adding a new item search field
In-Reply-To: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31406-70-StUCGXkWE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406

--- Comment #1 from Isobel Graham <isobel.graham09 at gmail.com> ---
Created attachment 143344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143344&action=edit
Bug 31406: Set focus to name on new fields

Focus is directed to the name field when
you want to add a new field.

Test plan
1. Got to administration and then item search
fields.
2. Add new field and focus should be set to
name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 16:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 15:05:11 +0000
Subject: [Koha-bugs] [Bug 31406] Set focus for cursor to Name input when
 adding a new item search field
In-Reply-To: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31406-70-gOKU8sJnLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406

Isobel Graham <isobel.graham09 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |isobel.graham09 at gmail.com
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |isobel.graham09 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 16:07:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 15:07:51 +0000
Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when
 adding a new currency
In-Reply-To: <bug-31407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31407-70-vnJ33PBWSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407

Isobel Graham <isobel.graham09 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |isobel.graham09 at gmail.com
           Assignee|oleonard at myacpl.org         |isobel.graham09 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 16:08:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 15:08:28 +0000
Subject: [Koha-bugs] [Bug 31408] Set focus for cursor to Start date when
 adding a new budget
In-Reply-To: <bug-31408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31408-70-Ro01kVmWDf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31408

Isobel Graham <isobel.graham09 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |isobel.graham09 at gmail.com
                 CC|                            |isobel.graham09 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 16:08:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 15:08:54 +0000
Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when
 adding a new fund
In-Reply-To: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31409-70-bhM2Ot4AIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409

Isobel Graham <isobel.graham09 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |isobel.graham09 at gmail.com
           Assignee|oleonard at myacpl.org         |isobel.graham09 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov  6 22:19:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Nov 2022 21:19:11 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-rF9YjaCpQD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #11 from David Nind <david at davidnind.com> ---
The tests fail 8-(...

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/67 Use of uninitialized value $rentalCharge
in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119.

    #   Failed test 'Branchcodes match when hold exists.'
    #   at t/db_dependent/Circulation.t line 5718.
    #          got: undef
    #     expected: 'CU4TLG6'
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
    # Looks like you failed 1 test of 4.
t/db_dependent/Circulation.t .. 64/67 
#   Failed test 'CanBookBeIssued + needsconfirmation message'
#   at t/db_dependent/Circulation.t line 5733.
# Looks like you planned 67 tests but ran 64.
# Looks like you failed 1 test of 64 run.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 4/67 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 64 Failed: 1)
  Failed test:  64
  Non-zero exit status: 1
  Parse errors: Bad plan.  You planned 67 tests but ran 64.
Files=1, Tests=64, 42 wallclock secs ( 0.11 usr  0.01 sys + 35.68 cusr  3.49
csys = 39.29 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 01:52:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 00:52:09 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-EmHF27x4im@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
This appears to have broken our ES6, we're seeing this error:

Exception 'Koha::Exception' thrown 'Unable to update mappings for index
"koha_instance_biblios". Reason was: "request
[/koha_instance_biblios/_mapping/data] contains unrecognized parameter:
[include_type_name]". Index needs to be recreated and reindexed'
Something went wrong rebuilding indexes 

How do we fix this please? I'm not sure what this change means for us if we're
still running ES6.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 02:51:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 01:51:24 +0000
Subject: [Koha-bugs] [Bug 31578] "Patrons who haven't checked out" report
 broken with SQL strict mode enabled
In-Reply-To: <bug-31578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31578-70-kWLDRL4stN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31578

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
                 CC|                            |david at davidnind.com
           Severity|minor                       |normal

--- Comment #2 from David Nind <david at davidnind.com> ---
Just adding a note, following testing of another bug.

Link title and page title are different:
- Link to report on reports page: Patrons who haven't checked out
- Title of page when clicked through: Patrons with no checkouts

I think for consistency, these should be the same.

I have also bumped up to normal as I think something that is clearly linked to
and doesn't work is more than a minor bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:09:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:09:40 +0000
Subject: [Koha-bugs] [Bug 32116] New: "Patrons with the most checkouts"
 report (bor_issues_top.pl) broken with SQL strict mode enabled
Message-ID: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116

            Bug ID: 32116
           Summary: "Patrons with the most checkouts" report
                    (bor_issues_top.pl) broken with SQL strict mode
                    enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

This report (Reports > Top lists > Patrons with the most checkouts) does not
work when the database is in strict mode.

Error trace:

CGI::Compile::ROOT::kohadevbox_koha_reports_bor_issues_top_2epl::calculate():
DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.borrowers.surname'
isn't in GROUP BY at /kohadevbox/koha/reports/bor_issues_top.pl line 58 at
/usr/share/perl5/DBIx/Class/Exception.pm line 77
....

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:10:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:10:26 +0000
Subject: [Koha-bugs] [Bug 32116] "Patrons with the most checkouts" report
 (bor_issues_top.pl) broken with SQL strict mode enabled
In-Reply-To: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32116-70-dou3drMgOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17528
           Priority|P5 - low                    |P1 - high


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
[Bug 17528] Holds to pull: check button Solved by
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:10:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:10:26 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17528-70-EdlYW4JrmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32116


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116
[Bug 32116] "Patrons with the most checkouts" report (bor_issues_top.pl) broken
with SQL strict mode enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:11:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:11:55 +0000
Subject: [Koha-bugs] [Bug 32117] New: "Items with no checkouts" report
 (catalogue_out.pl) broken with SQL strict mode enabled
Message-ID: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117

            Bug ID: 32117
           Summary: "Items with no checkouts" report (catalogue_out.pl)
                    broken with SQL strict mode enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

This report (Reports > Inactive > Items with no checkouts) does not work when
the database is in strict mode.

Error trace:

CGI::Compile::ROOT::kohadevbox_koha_reports_catalogue_out_2epl::calculate():
DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.items.barcode'
isn't in GROUP BY at /kohadevbox/koha/reports/catalogue_out.pl line 51 at
/usr/share/perl5/DBIx/Class/Exception.pm line 77
....

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:12:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:12:30 +0000
Subject: [Koha-bugs] [Bug 32117] "Items with no checkouts" report
 (catalogue_out.pl) broken with SQL strict mode enabled
In-Reply-To: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32117-70-eK3fKnjyEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17528
           Priority|P5 - low                    |P1 - high


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
[Bug 17528] Holds to pull: check button Solved by
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:12:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:12:30 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17528-70-ft0GhkimUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32117


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117
[Bug 32117] "Items with no checkouts" report (catalogue_out.pl) broken with SQL
strict mode enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:13:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:13:40 +0000
Subject: [Koha-bugs] [Bug 32117] "Items with no checkouts" report
 (catalogue_out.pl) broken with SQL strict mode enabled
In-Reply-To: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32117-70-gTdkYNqYC7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17528                       |17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
[Bug 17528] Holds to pull: check button Solved by
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:13:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:13:40 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-32RX4rG9qo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32117


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117
[Bug 32117] "Items with no checkouts" report (catalogue_out.pl) broken with SQL
strict mode enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:13:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:13:40 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17528-70-jzU0VeSy4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32117                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117
[Bug 32117] "Items with no checkouts" report (catalogue_out.pl) broken with SQL
strict mode enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:14:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:14:22 +0000
Subject: [Koha-bugs] [Bug 32116] "Patrons with the most checkouts" report
 (bor_issues_top.pl) broken with SQL strict mode enabled
In-Reply-To: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32116-70-9LuI1ALaHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17528                       |17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528
[Bug 17528] Holds to pull: check button Solved by
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:14:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:14:22 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-Sh29AkdQRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32116


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116
[Bug 32116] "Patrons with the most checkouts" report (bor_issues_top.pl) broken
with SQL strict mode enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:14:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:14:22 +0000
Subject: [Koha-bugs] [Bug 17528] Holds to pull: check button Solved by
In-Reply-To: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17528-70-14e0C5HS6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32116                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116
[Bug 32116] "Patrons with the most checkouts" report (bor_issues_top.pl) broken
with SQL strict mode enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:16:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:16:14 +0000
Subject: [Koha-bugs] [Bug 32116] "Patrons with the most checkouts" report
 (bor_issues_top.pl) broken with SQL strict mode enabled
In-Reply-To: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32116-70-K5tsMVKLJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17258                       |
             Blocks|                            |17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:16:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:16:14 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-6IAABS3zjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32116                       |
         Depends on|                            |32116


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32116
[Bug 32116] "Patrons with the most checkouts" report (bor_issues_top.pl) broken
with SQL strict mode enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:17:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:17:50 +0000
Subject: [Koha-bugs] [Bug 32117] "Items with no checkouts" report
 (catalogue_out.pl) broken with SQL strict mode enabled
In-Reply-To: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32117-70-D2SjUGl3Pp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17258                       |
             Blocks|                            |17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 03:17:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 02:17:50 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-0FU6m2ZVPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32117                       |
         Depends on|                            |32117


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32117
[Bug 32117] "Items with no checkouts" report (catalogue_out.pl) broken with SQL
strict mode enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 04:00:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 03:00:41 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-yNJ9zTPRDQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 04:00:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 03:00:46 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-k0eNCatXwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143119|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143345&action=edit
Bug 32091: Consistent classes for primary buttons: Reports

This patch makes changes the button markup in reports templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view reports pages to confirm that
everything looks correct. In most cases there are no visible changes.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 04:05:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 03:05:02 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-WNCMVb3LsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using KTD).

1. These changed templates are accessed from: Reports

2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/reports/
and splitting into two lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I have attached this,
as there are a lot of pages and screenshots)
   - Applying the patch (+ flush_memcached, restart_all, and clear browser
cache)
   - Going through the list of files again: compared to screenshot taken, then
noted whether visible changes or not
   - Noting any questions - these don't affect the sign off for this bug

3. Files changed - no visible changes for all files that were changed:
   - acquisitions_stats.tt (No visible change. Reports > Statistics wizards >
Acquisitions)
   - bor_issues_top.tt (No visible change. Reports > Top lists > Patrons with
the most checkouts)
   - borrowers_out.tt (No visible change. Reports > Inactive > Patrons who
haven't checked out)
   - borrowers_stats.tt (No visible change. Reports > Statistics wizards >
Patrons)
   - cash_register_stats.tt (No visible change. Reports > Statistics wizards >
Cash register)
   - cat_issues_top.tt (No visible change. Reports > Top lists >
Most-circulated items
   - catalogue_out.tt (No visible change. Reports > Inactive > Items with no
checkouts)
   - catalogue_stats.tt (No visible change. Reports > Statistics wizards >
Catalog)  
   - dictionary.tt (No visible change. Reports > Reports dictionary > View
dictionary. Setup: Go through Steps 1 to 5 to add a new definition - all have
'Next buttons' then 'Save' as the last button)
   - guided_reports_start.tt - all use guided_reports.pl:
     . Create guided reports (No visible change. Reports > Guided reports >
[six steps - steps 1 to 5 have a Next button, step 6 = Finish, the confirm
steps (Next, then Save report), then Edit SQL report where you can either
update the SQL, run or schedule the report])
     . Create from SQL (No visible change. Guided reports > Create from SQL)
     . Use saved (No visible change. Guided reports > Use saved)
     . Search by keyword (No visible change. Guided reports > Search by
keyword. Takes you to the 'Used saved' page with a filter)
   - issues_avg_stats.tt (No visible change. Reports > Other > Average loan
time)
   - issues_stats.tt (No visible change. Reports > Statistics wizards >
Circulation)
   - itemslost.tt (No visible change. Reports > Other > Items lost)
   - itemtypes.tt (No visible change. Reports > Other > Catalog by item type)
   - orders_by_budget.tt (No visible change. Reports > Other > Orders by fund)
   - reports-home.tt (No visible change. Reports home page)
   - reserves_stats.tt (No visible change. Reports > Statistics wizards >
Holds)
   - serials_stats.tt (No visible change. Reports > Statistics wizards >
Serials)

4. Files not changed:
   - convert_report.tt (referenced by svc/convert_report, doesn't have any
submit buttons)
   - csv/cash_register_stats.tt (referenced by reports/cash_register_stats.pl,
doesn't have any submit buttons)
   - csv/orders_by_budget.tt (referenced by reports/orders_by_fund.pl, doesn't
have any submit buttons)

5. Other things:
   - Report plugins link: goes to plugins home page

6. File count check:
   - Number of files in folder: 19 + 2 in csv subfolder = 21
   - Number of files listed: 21 (18 changed in this patch)

Questions and notes

1. Dictionary - deleting current terms: when you delete a definition, you are
NOT prompted to confirm deletion. This seems at odds with our normal pattern to
get confirmation before deleting something.

2. GROUP BY issue when database is in strict mode:
   - Patrons with the most checkouts (bor_issues_top.pl): bug 32116 created
   - Patrons who haven't checked out/Patrons with no checkouts
(borrowers_out.pl): existing bug 31578
   - Items with no checkouts (catalogue_out.pl): bug 32117 created

3. Breadcrumb for guided reports: In any of the guided reports areas, clicking
on the 'Guided reports wizard' breadcrumb takes you back to a landing page for
guided reports that has links to the various areas. Should this just be 'Guided
reports' and then take you back to the reports home page instead?

4. Lost items report: 
   - if there are no lost items, you just get a page with a blank body area
with the heading "Lost items" if there are no results
   - this message appears when there are results for the report:
     "To enable the export of selected items, create a CSV profile of the type
"SQL" with usage option "Export lost items in report.""
   - if I create a CSV profile and then refresh the lost items list the option
to select the CSV profile/export very briefly appears, then disappears - it
maybe something wrong with my CSV profile

5. Orders by fund: similar to the lost items report, you get a blank body area
with the heading "Orders by fund" if there are no results.

6. Statistics wizards: most of the pages have the heading repeated, for
example: acquisition statistics. The only one that don't is the serials
statistics - the single heading is "Serials subscriptions". The cash register
statistics heading is repeated, but this includes the date range.

7. Page name heading inconsistencies with the link on reports landing page:
   - 'Items lost' on reports landing page, 'Lost items' on actual page
   - 'Serials' on reports landing page, 'Serials subscriptions' on actual page
   - 'Reports dictionary'/'View dictionary' on landing page, 'Dictionary' on
actual page: perhaps on the landing page just have as part of the guided
reports block with "Reports dictionary" as the name of the link with an
appropriate icon, and on use "Reports dictionary" on the actual pages. Would
also require changes to the sidebar.
   - 'Create guided report' on landing page, 'Build a report' on step pages.
   - 'Use saved' on landing page, 'Saved reports" on actual page
   - 'Patrons who haven't checked out' on landing page, 'Patrons with no
checkouts' on actual page
   - 'Catalog by item type' on landing page, 'View a count of items held at
your library grouped by item type' on actual page
   - 'Average loan time' on landing page, 'Average checkout period' on actual
page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 04:12:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 03:12:44 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-K3g45liJzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143346&action=edit
Screenshots of pages changed - before patch applied

As there were a lot of pages changed, I've attached a file with screenshots of
the pages before the patch was applied.

The order is the same as the list of files changed in comment #3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 05:08:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 04:08:26 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-1j96WmhJLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

--- Comment #2 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
It's only happening the Ubuntu 18.04 on the CI
Which I also happen to use, let's try.

Confirmed!
Maybe the YAML is valid and the particular version of the OS of the failing
build has a bug. Checking against external tools and YAML specs might be needed
to be sure what's wrong.

root at kohadevbox:koha((2200b4aa3d...))$ prove xt/yaml_valid.t 
xt/yaml_valid.t .. 1/18 
#   Failed test
'/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref
is YAML'
#   at xt/yaml_valid.t line 41.

#   Failed test
'/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref
is YAML'
#   at xt/yaml_valid.t line 41.

#   Failed test
'/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/local_use.pref
is YAML'
#   at xt/yaml_valid.t line 41.
# Looks like you failed 3 tests of 18.
xt/yaml_valid.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/18 subtests 

Test Summary Report
-------------------
xt/yaml_valid.t (Wstat: 768 Tests: 18 Failed: 3)
  Failed tests:  9, 15, 17
  Non-zero exit status: 3
Files=1, Tests=18,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.62 cusr  0.02
csys =  0.67 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 06:31:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 05:31:42 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-k1P8ZGcDsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Martin Renvoize from comment #16)
> The value does come from the encryption.  If the database is somehow
> compromised (for example, someone accidentally shares a backup.. it could be
> as simple as that).. by having the data in the databawse encrypted the
> nafarious actor doesn't have something useful to them.. They still need to
> hack the machine to get ahold of the key (from the conf file) and/or read
> the code to understand what sort of algorithm is used.

That's why I wondered if there was any gain compared to just storing the
passwords into koha-conf.xml directly? (or another file)

The question would have been more relevant on bug 28998 now that such a
mechanism is implemented, the work is done and it's not very hard to use on any
data to be protected from SQL injection or accidental backup publication.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 06:32:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 05:32:28 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-52wwAlZuvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
At "sub agreement_relationships"

+        my $back_links = {
+            'supersedes'       => 'is-superseded-by',
+            'is-superseded-by' => 'supersedes',
+            'provides_post-cancellation_access_for' =>
'has-post-cancellation-access-in',
+            'has-post-cancellation-access-in'       =>
'provides_post-cancellation_access_for',
+            'tracks_demand-driven_acquisitions_for' =>
'has-demand-driven-acquisitions-in',
+            'has-demand-driven-acquisitions-in'     =>
'tracks_demand-driven_acquisitions_for',
+            'has_backfile_in'  => 'has_frontfile_in',
+            'has_frontfile_in' => 'has_backfile_in',
+            'related_to'       => 'related_to',
+        };


What are the rules for using - or _? Like "has-demand-driven-acquisitions-in"
and "tracks_demand-driven_acquisitions_for"
Just in case, with some greps I double checked that there wasn't a mixup
between - and _ anywhere, all good! 👍️

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 08:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 07:21:37 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-x2Pt4mJ1t8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #12 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to David Nind from comment #11)
> The tests fail 8-(...
> 
> prove t/db_dependent/Circulation.t
> t/db_dependent/Circulation.t .. 62/67 Use of uninitialized value
> $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line
> 1119.
> 
>     #   Failed test 'Branchcodes match when hold exists.'
>     #   at t/db_dependent/Circulation.t line 5718.
>     #          got: undef
>     #     expected: 'CU4TLG6'
> Use of uninitialized value $rentalCharge in numeric gt (>) at
> /kohadevbox/koha/C4/Circulation.pm line 1119.
> Use of uninitialized value $rentalCharge in numeric gt (>) at
> /kohadevbox/koha/C4/Circulation.pm line 1119.
> Use of uninitialized value $rentalCharge in numeric gt (>) at
> /kohadevbox/koha/C4/Circulation.pm line 1119.
>     # Looks like you failed 1 test of 4.
> t/db_dependent/Circulation.t .. 64/67 
> #   Failed test 'CanBookBeIssued + needsconfirmation message'
> #   at t/db_dependent/Circulation.t line 5733.
> # Looks like you planned 67 tests but ran 64.
> # Looks like you failed 1 test of 64 run.
> t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 4/67 subtests 
> 
> Test Summary Report
> -------------------
> t/db_dependent/Circulation.t (Wstat: 256 Tests: 64 Failed: 1)
>   Failed test:  64
>   Non-zero exit status: 1
>   Parse errors: Bad plan.  You planned 67 tests but ran 64.
> Files=1, Tests=64, 42 wallclock secs ( 0.11 usr  0.01 sys + 35.68 cusr  3.49
> csys = 39.29 CPU)
> Result: FAIL

It seems test fails because of circulation rules. Which is odd since this
wasn't an issue while I tested these.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 08:54:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 07:54:39 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-BUQTQlwauN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Victor Grousset/tuxayo from comment #13)
> In the /agreements page, the «Filter by expired: [X] on» is confusing. It's
> not clear that it must be ticked for the date field to have any effect. Or
> maybe unchecked has a different effect. But it seems not.
> 
> https://wtf.roflcopter.fr/pics/foywDHSU/5E4BFfT6.png

It's not how it appears, it should be displayed like this:
https://snipboard.io/Pv5a9O.jpg

> The doc draft says
> > At the top of the Agreements page you will notice a Filter box. The purpose of this is to allow you to quickly filter expired agreements or agreements which may have an upcoming renewal (and therefore might require action).
> 
> There doesn't seem to be another filter mode when unchecked.

Another filter mode? What do you mean?

> From the code it seems the date field is only used when the box is ticked.
> Is that done to be able to keep an expiration date saved without having it
> used? (it's not saved so it's not that)
> Otherwise the filter could just be used when the date field is populated.

You only need to click the checkbox to search for "expired on today" (it will
populate the date with today when the checkbox is ticked). That's something you
couldn't have with your suggestion.

I don't think the current behaviour is confusing, really. We could eventually
hide 'on [date]' when the checkbox is not checked. We are talking about
providing a MVP for 22.11 inclusion, not trying to catch minor UI design flaws
;)

(In reply to Victor Grousset/tuxayo from comment #14)
> At "sub agreement_relationships"
> 
> +        my $back_links = {
> +            'supersedes'       => 'is-superseded-by',
> +            'is-superseded-by' => 'supersedes',
> +            'provides_post-cancellation_access_for' =>
> 'has-post-cancellation-access-in',
> +            'has-post-cancellation-access-in'       =>
> 'provides_post-cancellation_access_for',
> +            'tracks_demand-driven_acquisitions_for' =>
> 'has-demand-driven-acquisitions-in',
> +            'has-demand-driven-acquisitions-in'     =>
> 'tracks_demand-driven_acquisitions_for',
> +            'has_backfile_in'  => 'has_frontfile_in',
> +            'has_frontfile_in' => 'has_backfile_in',
> +            'related_to'       => 'related_to',
> +        };
> 
> 
> What are the rules for using - or _? Like
> "has-demand-driven-acquisitions-in" and
> "tracks_demand-driven_acquisitions_for"
> Just in case, with some greps I double checked that there wasn't a mixup
> between - and _ anywhere, all good! 👍️

Coming from Folio:
https://github.com/folio-org/ui-agreements/blob/master/src/constants/agreementRelationshipTypes.js
I guess the idea was to have '_' for spaces and '-' for '-', but yes, it's
inconsistent.

Note that we are displaying the code when we should display strings.
Reported on https://tree.taiga.io/project/joubu-koha-erm/us/138

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 09:14:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 08:14:28 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-V3Ypp3OD7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
+            // table_dt.on('search', console.log);

hum?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 09:32:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 08:32:32 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-aIKsGd6B7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #16 from Jonathan Field <jonathan.field at ptfs-europe.com> ---
(In reply to Victor Grousset/tuxayo from comment #13)
> In the /agreements page, the «Filter by expired: [X] on» is confusing. It's
> not clear that it must be ticked for the date field to have any effect. Or
> maybe unchecked has a different effect. But it seems not.
> 
> https://wtf.roflcopter.fr/pics/foywDHSU/5E4BFfT6.png
> 
> The doc draft says
> > At the top of the Agreements page you will notice a Filter box. The purpose of this is to allow you to quickly filter expired agreements or agreements which may have an upcoming renewal (and therefore might require action).

I agree with Jonathan, it works as it was intended as far as I'm concerned. The
idea was to have something like the Print Serials page
(cgi-bin/koha/serials/checkexpiration.pl) where you can look up upcoming
subscriptions (electronic in this case). This filter has benefits as it's more
versatile, you can look up expired subscriptions for example.    
> 
> There doesn't seem to be another filter mode when unchecked.
> 
> From the code it seems the date field is only used when the box is ticked.
> Is that done to be able to keep an expiration date saved without having it
> used? (it's not saved so it's not that)
> Otherwise the filter could just be used when the date field is populated.

Not sure what you mean here but the table filters really provide all the other
filtering you might need I would say. For example, Status: cancelled etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 09:58:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 08:58:07 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-Vq5fAg4AOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

--- Comment #8 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
Created attachment 143347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143347&action=edit
Bug 32016: Remove debug console.log

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 09:58:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 08:58:58 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-lwVeZ4bZbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

--- Comment #9 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to Jonathan Druart from comment #7)
> +            // table_dt.on('search', console.log);
> 
> hum?

.. My bad, I forgot it >_< thanks for your feedback

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:29:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:29:59 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-XjVnJ5ULMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #59 from Kevin Carnes <kevin.carnes at ub.lu.se> ---
(In reply to Aleisha Amohia from comment #58)
> This appears to have broken our ES6, we're seeing this error:
> 
> Exception 'Koha::Exception' thrown 'Unable to update mappings for index
> "koha_instance_biblios". Reason was: "request
> [/koha_instance_biblios/_mapping/data] contains unrecognized parameter:
> [include_type_name]". Index needs to be recreated and reindexed'
> Something went wrong rebuilding indexes 
> 
> How do we fix this please? I'm not sure what this change means for us if
> we're still running ES6.

Which version of Elasticsearch are you using? I think at least version 6.8 is
required to use include_type_name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:49:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:49:10 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-8EPZe9Kpmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143348&action=edit
Bug 31889: (follow-up) Correct item order

MARC::Record::insert_fields_ordered reverses the order of fields
with the same tag. So we need to reverse the input order here.

This made Exporter/Record.t fail.

Test plan:
Run t/db_dependent/Koha/Biblio/Metadata.t
Run t/db_dependent/Exporter/Record.t (should pass now)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:50:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:50:12 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-D2SkHEuevQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:50:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:50:20 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-nMhelMpZmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:50:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:50:30 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-MiSfgqjsnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:56:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:56:08 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-QcGC98OKhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 10:57:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 09:57:44 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-I8LAorBWc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
@RM: Last patch only ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:21:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:21:03 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-9zkdto6B20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Claes <claes.eriksson at vti.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claes.eriksson at vti.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:35:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:35:46 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-uMRZpltBGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:35:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:35:56 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
 regular Koha plugins
In-Reply-To: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19605-70-xtrJeEXh4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:02 +0000
Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module
In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19822-70-sj0ndXsSYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:06 +0000
Subject: [Koha-bugs] [Bug 21017] Plugins: Allow for post-install configure
 flag
In-Reply-To: <bug-21017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21017-70-rARH2Cgegr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21017

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:12 +0000
Subject: [Koha-bugs] [Bug 21482] Create a "landing page" for ILL
In-Reply-To: <bug-21482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21482-70-ZjOeV1V5CZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21482

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:17 +0000
Subject: [Koha-bugs] [Bug 22528] Add tab with current/active ILL requests to
 patron circulation page
In-Reply-To: <bug-22528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22528-70-NBrFkEoYdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:20 +0000
Subject: [Koha-bugs] [Bug 30575] Returning an ILL item shouldn't just change
 the request status
In-Reply-To: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30575-70-lmYvcSYJQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30575

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:26 +0000
Subject: [Koha-bugs] [Bug 22843] Finer control of who receives purchase
 suggestion notifications
In-Reply-To: <bug-22843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22843-70-4Y45bqlYBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22843

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:36:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:36:59 +0000
Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to
 enable users to renew before the autorenew date
In-Reply-To: <bug-22018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22018-70-7zfjLi5ZvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:03 +0000
Subject: [Koha-bugs] [Bug 8155] Comply with UK Electronic Commerce (EC
 Directive) Regulations 2002
In-Reply-To: <bug-8155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8155-70-cCO3zED1i0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8155

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:07 +0000
Subject: [Koha-bugs] [Bug 21833] Request type is not displayed on ILL
 request detail page
In-Reply-To: <bug-21833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21833-70-QiE4UY1kCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:10 +0000
Subject: [Koha-bugs] [Bug 18203] Add per borrower category restrictions on
 ILL placement
In-Reply-To: <bug-18203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18203-70-HJipRIoDYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:17 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-npogni98fQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:22 +0000
Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities
In-Reply-To: <bug-14974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14974-70-xzxdGGXHWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:28 +0000
Subject: [Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and
 "Reserve Charge" does not create account offset
In-Reply-To: <bug-21678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21678-70-c043zsyvrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:33 +0000
Subject: [Koha-bugs] [Bug 17436] Add a way to know in patron module where
 renew of an item was made
In-Reply-To: <bug-17436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17436-70-1OP7L6I0uW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:35 +0000
Subject: [Koha-bugs] [Bug 18588] ILL email text is hardcoded in the the Perl
 module
In-Reply-To: <bug-18588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18588-70-qcvmdRaRxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:38 +0000
Subject: [Koha-bugs] [Bug 20646] "ILL Request" menu options not displayed
 when user has superlibrarian permission
In-Reply-To: <bug-20646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20646-70-4Z4hP3HRjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:41 +0000
Subject: [Koha-bugs] [Bug 21016] Plugins: Expand usage of opac_js method,
 or create intranet_js
In-Reply-To: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21016-70-MiDxFnQP6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:45 +0000
Subject: [Koha-bugs] [Bug 23614] Alert staff when patron modifies ILL
 request in opac
In-Reply-To: <bug-23614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23614-70-idbjyjOhEv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23614

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:49 +0000
Subject: [Koha-bugs] [Bug 23615] Alert staff when patron cancels an ILL
 request in opac
In-Reply-To: <bug-23615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23615-70-VxZdWKQq8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23615

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:52 +0000
Subject: [Koha-bugs] [Bug 23391] Hide finished ILL requests
In-Reply-To: <bug-23391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23391-70-Bb6lwi5H2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:37:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:37:55 +0000
Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339
 datetimes
In-Reply-To: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24850-70-AKqRHYHuvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:38:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:38:09 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-sBAAf2hekJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-up pushed to master, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:00 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-8yAhhi9NGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:00 +0000
Subject: [Koha-bugs] [Bug 25999] Renewal due date not being honoured for
 items with holds
In-Reply-To: <bug-25999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25999-70-UgWvuw1lNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:03 +0000
Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's
 link to it - missing foreign key
In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21983-70-02ctkaFUcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:03 +0000
Subject: [Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for
 specifying a source number for SMS messages
In-Reply-To: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21988-70-71j7Whktkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:04 +0000
Subject: [Koha-bugs] [Bug 29992] Default Apache config should contain
 CGIPassAuth directive
In-Reply-To: <bug-29992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29992-70-91ZGBOTtWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:14 +0000
Subject: [Koha-bugs] [Bug 24609] Add routes for updating checkouts
In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24609-70-bhbrAOZYRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:15 +0000
Subject: [Koha-bugs] [Bug 27542] It should be possible to cancel an ILL
 request sent to a partner
In-Reply-To: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27542-70-Ia86rjMi95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27542

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:16 +0000
Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
 display partners in audit log
In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22531-70-5T2C4RFPjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:18 +0000
Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to
 use backend template
In-Reply-To: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28909-70-auc87usaxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:17 +0000
Subject: [Koha-bugs] [Bug 28634] ILL partner request notices are attached to
 the request creator rather than the partner recipient
In-Reply-To: <bug-28634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28634-70-qNnZUiiZsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:17 +0000
Subject: [Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
In-Reply-To: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24471-70-VdteeeoIHj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:31 +0000
Subject: [Koha-bugs] [Bug 30484] Interlibrary loans should have the ability
 to send notices based on request supplier updates
In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30484-70-BIB1EXaGaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:31 +0000
Subject: [Koha-bugs] [Bug 20883] Display patron user id
In-Reply-To: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20883-70-Z6ww98QjcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:30 +0000
Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-80h8rD5qvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:42 +0000
Subject: [Koha-bugs] [Bug 20923] Merging backend status graph into main
 status graph incorrect use of grep
In-Reply-To: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20923-70-ntkJAcDZp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:41 +0000
Subject: [Koha-bugs] [Bug 20917] Improve email functionality relating to ILL
 requests
In-Reply-To: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20917-70-rwqCkwyGwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:51 +0000
Subject: [Koha-bugs] [Bug 21679] Software error when placing a hold on an
 item with a charge associated with it
In-Reply-To: <bug-21679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21679-70-K2GlTM6e6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21679

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:56 +0000
Subject: [Koha-bugs] [Bug 21900]
 intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken
In-Reply-To: <bug-21900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21900-70-9ow45s5Swl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:57 +0000
Subject: [Koha-bugs] [Bug 22169] ill-requests.tt failing QA test
In-Reply-To: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22169-70-5lCp2l2ZFF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22169

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:40:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:40:59 +0000
Subject: [Koha-bugs] [Bug 22244] Typo in Mana Knowledge Base message
In-Reply-To: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22244-70-MQcY56sFp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22244

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:08 +0000
Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions
In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23971-70-KjXAzXfUx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:13 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-UoxMyjrwO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:17 +0000
Subject: [Koha-bugs] [Bug 24650] API returned timestamps are incompatible
 with existing helpers
In-Reply-To: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24650-70-ciYQcoYqMN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:17 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-YRNHwpaglN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:27 +0000
Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display
 arbitrary links to related resources
In-Reply-To: <bug-27170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27170-70-5aseTxwpBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:32 +0000
Subject: [Koha-bugs] [Bug 28340] Provide improved display of ILL request
 metadata in notices
In-Reply-To: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28340-70-rkHYfBFk8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:41:36 +0000
Subject: [Koha-bugs] [Bug 31592] Fix ILL API following new date_due property
In-Reply-To: <bug-31592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31592-70-ViOqJIeb9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31592

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:42:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:42:55 +0000
Subject: [Koha-bugs] [Bug 24608] Allow modification of checkout due date
In-Reply-To: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24608-70-FLd4WOdM41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugzilla at warmlight.co.uk    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:51:29 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-NtmCb8s1OH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143112|0                           |1
        is obsolete|                            |

--- Comment #13 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143349&action=edit
Bug 31447: Add unit tests

To test prove t/db_dependent/Circulation.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:51:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:51:45 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-6dCfxhHUaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:52:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:52:27 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-6tcTC9u7El@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #14)
> @RM: Last patch only ;)

I'm not sure why we should be sorting this fields at all. And we are now doing
even more math/CPU use.

Generally, I think using MARC::Record->insert_grouped_field is good enough. As
I said before, this method needs to go away soon in favor of the
RecordProcessor, which right now is appending things, so moving the discussion
there.

Thanks for the patch fixing the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:53:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:53:51 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-NaOE7mAXd1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #14 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
The problem was actually new item group level holds feature (bug 24860). Just
needed to add items item_group value to reserves item_group_id.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:53:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:53:58 +0000
Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled
In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24806-70-fRqg0PlrAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806

--- Comment #11 from Hans Pålsson <hans.palsson at hkr.se> ---
Still a problem (22.05.05).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 11:54:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 10:54:37 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-OZH6Zm65jt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-up pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 12:31:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 11:31:42 +0000
Subject: [Koha-bugs] [Bug 31889] Insert 952 tags in correct order when
 embedding items
In-Reply-To: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31889-70-PUjHflbTpn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31889

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143350&action=edit
Bug 31889: (follow-up) Add test for explicit warning

On bug 29697, an explicit call to 'warn' was added, but no tests were
added for that behavior.

This patch adds that.

To test:

1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> FAIL: There's a warn, no tests for it :-(
2. Apply this patch
3. Repeat 1
=> SUCCESS: A new test was added, no more warns printed
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 12:39:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 11:39:38 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-ulhKxZi23w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldoldoldstable   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 12:39:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 11:39:39 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
 other endpoints
In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22440-70-qYdAJMbGst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
Bug 22440 depends on bug 29032, which changed state.

Bug 29032 Summary: ILL route unusable (slow)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldoldoldstable   |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:02:19 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-CwIgT2akIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #60 from Nick Clemens <nick at bywatersolutions.com> ---
Correct, 6.8 is required for include_type_name:
https://www.elastic.co/blog/moving-from-types-to-typeless-apis-in-elasticsearch-7-0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:06:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:06:01 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-WYe7bueYYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #4)
> I like the x icon better than the trash icon, because it does empty the
> field but not actually delete/remove. I think the red color was restored by
> another patch I tested, but not sure which one right now :(

As said in the commit message I have simply copied the behaviour from other
areas (like the guarantor when editing a patron).
Shouldn't we reach consistency first, then improve if we want it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:06:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:06:50 +0000
Subject: [Koha-bugs] [Bug 32118] New: Clarify expansion/embed modifiers
Message-ID: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

            Bug ID: 32118
           Summary: Clarify expansion/embed modifiers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
                CC: tomascohen at gmail.com

With bug 26635 we add a new additive function to the embed header options..
+av_expand.. this is a special case in that it's not just pulling in a related
object, but also setting a flag to expand coded values and embed them within
their own structure.

We also have +relation_count.. to add a single field in a parent structure to
just return the 'count' of a relation.. I think we should use :relation_count
for this case?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:07:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:07:54 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-j2KVtCqo8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. I've gone through eRM pretty rigorously now.. every question I've had I've
answered by going through the vue docs.

Happy to add my SO line for QA.. marking as such.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:08:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:08:55 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-H5aP7zbg7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118
[Bug 32118] Clarify expansion/embed modifiers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:08:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:08:55 +0000
Subject: [Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers
In-Reply-To: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32118-70-Bly7BLUo6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |26635


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
[Bug 26635] Expand coded values in REST API call
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:10:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:10:29 +0000
Subject: [Koha-bugs] [Bug 32119] New: Cannot add new guarantee
Message-ID: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

            Bug ID: 32119
           Summary: Cannot add new guarantee
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 31422

Can't call method "id" on an undefined value at
/kohadevbox/koha/members/memberentry.pl line 662                               
                                                                               
             eval {...} at /kohadevbox/koha/members/memberentry.pl line 932

To recreate:
go to a patron detail view, click "add guarantee"


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422
[Bug 31422] Library limitations might cause data loss when editing patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:10:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:10:29 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-YMgcv1Sl9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32119


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119
[Bug 32119] Cannot add new guarantee
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:12:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:12:29 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-W8OXkjJOjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:12:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:12:35 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-jTz7rCC2sj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143351&action=edit
Bug 32119: (bug 31422 follow-up) Fix add guarantee

Can't call method "id" on an undefined value at
/kohadevbox/koha/members/memberentry.pl line 662                               
                                                                               
             eval {...} at /kohadevbox/koha/members/memberentry.pl line 932

To recreate:
go to a patron detail view, click "add guarantee"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:15:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:15:38 +0000
Subject: [Koha-bugs] [Bug 32120] New: Wrong display when editing a fund
Message-ID: <bug-32120-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32120

            Bug ID: 32120
           Summary: Wrong display when editing a fund
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

https://snipboard.io/mdgyUa.jpg - the bullet point before "remove" and the
alignment.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:15:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:15:38 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-gLgFcAxyEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32120


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32120
[Bug 32120] Wrong display when editing a fund
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:20:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:20:06 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-mkfjbxCja5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Should we actually have a "search" icon? The tooltip of the icon says "Search
for another patron".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:20:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:20:19 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-IIprihzFvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:20:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:20:28 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-vVLZFftK5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143351|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143352&action=edit
Bug 32119: (bug 31422 follow-up) Fix add guarantee

Can't call method "id" on an undefined value at
/kohadevbox/koha/members/memberentry.pl line 662                               
                                                                               
             eval {...} at /kohadevbox/koha/members/memberentry.pl line 932

To recreate:
go to a patron detail view, click "add guarantee"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:22:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:22:13 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-ga9uybA0LZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143353&action=edit
[ALTERNATIVE PATCH] Bug 32108: Replace "x" icon with the "search" icon

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:24:31 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-TKRXQBvhAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How it looks like with the alternative patch: https://snipboard.io/YsFVnT.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:29:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:29:32 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-0h0wO9ZzVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143127|0                           |1
        is obsolete|                            |

--- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143354&action=edit
Bug 26635: Add tests

Add tests in t/db_dependent/Koha/Object.t and
t/db_dependent/Koha/REST/Plugin/Objects.t

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:29:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:29:38 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-hgTH9fUmre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #17)
> OK.. I've gone through eRM pretty rigorously now.. every question I've had
> I've answered by going through the vue docs.
> 
> Happy to add my SO line for QA.. marking as such.

Added to the remote branch, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:29:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:29:40 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-pSFRLPQ7bN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143128|0                           |1
        is obsolete|                            |

--- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143355&action=edit
Bug 26635: Expand authorised values in to_api method

This patch adds the posibility to expand authorised values when to_api
method is called.

The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following

{
  column_name => Koha::AuthorisedValue->unblessed
  ...
}

This patch will be used in bug 8179, so please test there.

Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:29:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:29:48 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-8iD1Ga2CBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143129|0                           |1
        is obsolete|                            |

--- Comment #105 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143356&action=edit
Bug 26635: Add tests for av-expand => 0

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:29:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:29:54 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-KLAAifV65t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143130|0                           |1
        is obsolete|                            |

--- Comment #106 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143357&action=edit
Bug 26635: AV expansion should ackowledge $params->{public}

This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.

It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:30:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:30:01 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-OTbj3psgby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143131|0                           |1
        is obsolete|                            |

--- Comment #107 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143358&action=edit
Bug 26635: Refined data structure and methods

This patch makes the returned data structure be simpler:

_str => {
    attribute_1 => {
        category => 'some_category_name',
        str      => 'description',
        type     => 'av'
    },
    ...
}

The description is sensible to context, so if public => 1 is passed,
then lib_opac is passed, and lib is returned otherwise. Whenever we add
language to the combo, we will add it to the implementation.

Tests are adjusted accordingly, also to reflect the public => 1 use
case.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:30:25 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-F2bGOmwgbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143132|0                           |1
        is obsolete|                            |

--- Comment #108 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143359&action=edit
Bug 26635: Move expand syntax to x-koha-embed

Instead of a global av-expand flag (through a header) this patch
proposes to allow specifying +av_expand at the x-koha-embed header
level. This allows a more fine-grained control on what objects get avs
expanded. e.g.:

GET /patrons/123
x-koha-expand: +av_expand,checkouts.item+av_expand
=>
{
    "_str": {
        "city": { "str": "Córdoba", ... }
    },
    ...
    "checkouts": [
        {
            ...,
            "item": {
                "_str": {
                    "not_for_loan_status": { "str": "Reference material", ...
},
                    ...
                },
                ...
            }
        }
    ]
}

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/Koha/REST/Plugin/Query.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
2. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:30:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:30:33 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-KR22DqVbop@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143134|0                           |1
        is obsolete|                            |

--- Comment #109 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143360&action=edit
Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header

This patch updates the last remaining test that mentioned the now defunkt
x-koha-av-expand header.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:30:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:30:39 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-rkKaMgnOIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143276|0                           |1
        is obsolete|                            |

--- Comment #110 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143361&action=edit
Bug 26635: (QA follow-up) Rename key _str to _strings

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:30:44 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-0W9QULxHNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143362&action=edit
Bug 26635: (follow-up) Rename av_expand to strings

This patch updates the `av_expand` occurences to `strings` to match the
change of the return structure of `_strings`.

We replace `+av_expand` in the headers with `+strings`, the expected
object method name from `api_av_mapping` to `api_strings_mapping` and
the internal hash key from `av_expand` to `strings`.

Test plan
1) Run the included unit tests.. all should still pass.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:32:23 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-SSZYvG488R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143133|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:32:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:32:58 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-IZW4zBKl2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
As discussed.. I updated the embed call to also refer to 'strings' as aposed to
'av_expand'.

Passed QA now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:33:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:33:27 +0000
Subject: [Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers
In-Reply-To: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32118-70-gmHuSPKAK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143363&action=edit
Bug 32118: Add optional support for `:` as the modifier

This patch adds optional support for using `:` as the modifier for
invoking the 'count' method for relations as discussed.

We retain support for `+` for backward compatability to prevent a
breaking change.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:33:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:33:42 +0000
Subject: [Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers
In-Reply-To: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32118-70-kEiX3D1uJp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:33:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:33:48 +0000
Subject: [Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers
In-Reply-To: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32118-70-YSp7oYsKGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:35:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:35:55 +0000
Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss
 when editing patrons
In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31422-70-U1fWHVDnuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #10)
> Commit message could have more words! ;)

Yes, definitely! :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:43:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:43:58 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-SOoYU87WAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:44:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:44:04 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-b40mkewMwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143352|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143364&action=edit
Bug 32119: (bug 31422 follow-up) Fix add guarantee

To test:
1 - go to a patron detail view, click "add guarantee"
2 - Confirm form loads
3 - Confirm categories lsited are eligible to have a guarantor
4 - Fill out required fields and confirm patron saved correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:45:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:45:33 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-e3K01gqThd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143290|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143365&action=edit
Bug 32110: Fixup to db_rev for non-english, multilingual Koha

Without this patch, the update process duplicates all the news and
content entries when they were non-english to start with.

This patch keeps the same process, but new "default" "parent" entries are empty
so there'
no duplication in the OPAC display, while still being editable/deletable
in the intranet.

We came through that through many iterations.  This was the least
invasive while still providing satisfying results.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:45:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:45:52 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-FJWwRQ7RaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:46:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:46:00 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-rXcO6giEff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:48:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:48:30 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-Be9SYcpVlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart+koha at gmail. |nick at bywatersolutions.com
                   |com                         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:50:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:50:40 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-qUYXzsH0U3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:50:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:50:45 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-fQtdFKKyPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143364|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143366&action=edit
Bug 32119: (bug 31422 follow-up) Fix add guarantee

To test:
1 - go to a patron detail view, click "add guarantee"
2 - Confirm form loads
3 - Confirm categories lsited are eligible to have a guarantor
4 - Fill out required fields and confirm patron saved correctly

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 13:52:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 12:52:38 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-X55FNtk23D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #8)
> How it looks like with the alternative patch: https://snipboard.io/YsFVnT.jpg

Sorry, I think I was too much in a hurry here - I thought you wanted to replace
the X in general. But: I really like the change to the search icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:36:57 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-a8TSq9Cmxw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #201 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #133)
> Agustín, how are you testing this during development?
> 
> In my docker-compose.yml, I use the following:
> 
>     keycloak:
>         image: jboss/keycloak
>         networks:
>             - kohanet
>         environment:
>             KEYCLOAK_USER: <username>
>             KEYCLOAK_PASSWORD: <password>
>         ports:
>             - "8082:8080"
> 
> If you are interested in using Keycloak for testing, I can give a few more
> instructions on how to set up the realm, the client, the user, and where to
> find the details for the Koha configuration.

I've just added an --sso option switch to the 'ktd' command, using the examples
you provided (with minor tweaks).

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:37:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:37:56 +0000
Subject: [Koha-bugs] [Bug 32121] New: Show an alert when adding a checked
 out item to an item bundle
Message-ID: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121

            Bug ID: 32121
           Summary: Show an alert when adding a checked out item to an
                    item bundle
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:38:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:38:30 +0000
Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out
 item to an item bundle
In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32121-70-Gzhw5mxrK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items for circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:38:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:38:30 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-D4RUdGhLr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32121


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121
[Bug 32121] Show an alert when adding a checked out item to an item bundle
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:39:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:39:03 +0000
Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out
 item to an item bundle
In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32121-70-37JF5Py0EX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143367&action=edit
Bug 32121: Show an alert when adding a checked out item to an item bundle

When trying to add a checked out item to an item bundle, an alert
message will show up, giving the user a chance to return the item
immediately before adding it to the bundle

Test plan:
1. Create an item bundle (see bug 28854 comment 458)
2. Create a biblio with one item and check out this item.
3. Try to add the checked out item to the bundle
   You should see a message saying that the item is checked out. Next to
   this message should be a button "Check in and add to bundle".
4. Click on the button. There should be a message saying that the item
   was added to the bundle.
5. Close the modal window and verify that the item was correctly
   returned and added to the bundle

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:39:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:39:13 +0000
Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out
 item to an item bundle
In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32121-70-UOGB5yAFwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:48:23 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-oSesteDtJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dependency
                 CC|                            |mtj at kohaaloha.com,
                   |                            |tomascohen at gmail.com

--- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Mason, can you confirm there are no dependency issues?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:48:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:48:51 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-o3JFhN1Fjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:48:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:48:56 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-Ep97ap5n4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143125|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143368&action=edit
Bug 32097: Consistent classes for primary buttons: Lists

This patch makes changes the button markup in lists templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view lists pages to confirm that everything
looks correct. In most cases there are no visible changes.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:49:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:49:10 +0000
Subject: [Koha-bugs] [Bug 31168] Temporary Item Locations
In-Reply-To: <bug-31168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31168-70-K532Dj34oG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31168

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emily.lamancusa at montgomeryc
                   |                            |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:51:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:51:21 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-zZnjm4BAIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using KTD).

1. These changed templates accessed from: Lists

2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   - Listing the templates in
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/ and splitting into two
lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document 
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser
cache)
   - Going through the list of files again: compared to original screenshot
taken, then noted whether changed or not
   - Noting any questions - these don't affect the sign off for this bug

3. Files changed - no visible changes noticed:
   - ../../includes/virtualshelves/merge/selection.tt (Not sure how to trigger
the dislay of this one - not referenced by any files (git grep selection.tt
":(exclude)*.po"))
   - addbybiblionumber.tt (Lists > select a list > Add items > modal window to
add using barcodes or biblio number)
   - downloadshelf.tt (No visible change. Not sure how to display from the
lists area - standard formats and CSV profiles download automatically without a
separate a form/page. Accessed directly using
http://127.0.0.1:8081/cgi-bin/koha/virtualshelves/downloadshelf.pl?shelfnumber=1)
   - sendshelfform.tt (No visible change. Lists > select a list to view > Send
list) 
   - shelves.tt
     . Lists homepage (No visible change. Lists)
     . Create a new list (No visible change. Lists > New list > enter details >
Save)
     . Edit list (No visible change. Lists > select a list > Edit > Edit list) 
     . Transfer ownership (No visible change. Lists > select a public list >
Transfer action > search for new owner > Transfer)
     . Add items to another list (No visible change. Lists > view a list with
more than one item > select two or more items > from the toolbar select the
list to add to > Save - pop up window appears with options to save or cancel)
     . Place a hold (select one or more items in a list > select 'Place hold'
from the toolbar > taken to Catalog area to complete the holds actions)
     . Merge selected (select one or more items in a list > select 'Merge
selected' from the toolbar > taken to Cataloguing area to start the merging
records process)

4. Files not changed:
   - tables/shelves_results.tt (used to generate the list of lists under Your
lists and Public lists - no submit buttons)
   - sendshelf.tt (no buttons - message sent when sending list)

5. File count check:
   - Number of files in folder: 5 + 1 in tables directory + 1 in merge
directory = 7
   - Number of files listed: 7 (5 changed in this patch)

Questions

1. Should the buttons be in the div or outisde the div? Those in the white
background are:
   - Transfer ownership: Lists > select a public list > Transfer action >
search for new owner > Transfer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:53:39 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-sAslsrwyQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143369&action=edit
Screnshots - pages before patch applied

This attachment has screenshots of pages before the patch was applied.

No visible changes noticed for any of the files changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:56:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:56:08 +0000
Subject: [Koha-bugs] [Bug 32122] New: Wrong permissions check on item
 circulation alerts
Message-ID: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

            Bug ID: 32122
           Summary: Wrong permissions check on item circulation alerts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Bug 14391 added granular permissions for the administration module, however,
there was a mismatch in the check on item circulation alerts and the new
permission

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:58:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:58:40 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-8i2YB6e2fT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:58:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:58:44 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-El34NBvycp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143370&action=edit
Bug 32122: Correct permissions check on item circulation alerts

This patch changes the check from 'item_circ_alerts' to
'manage_item_circ_alerts'

To test:
1 - Give an account catalogue and manage_item_circ_alerts permissions
2 - Log in to staff client iwht this account
3 - Browse to Admin->Item circulation alerts
4 - Error, you do not have permission to view this page
5 - Apply patch
6 - Restart all
7 - Browse to page agian, success!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:59:40 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-K61H53HwgX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14391
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391
[Bug 14391] Granular permissions for the administration module
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 14:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 13:59:40 +0000
Subject: [Koha-bugs] [Bug 14391] Granular permissions for the administration
 module
In-Reply-To: <bug-14391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14391-70-YF9UAT9aEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32122


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122
[Bug 32122] Wrong permissions check on item circulation alerts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:01:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:01:38 +0000
Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when
 only one result
In-Reply-To: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31967-70-Emfux20C9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:01:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:01:41 +0000
Subject: [Koha-bugs] [Bug 31967] Search terms retained in header search when
 only one result
In-Reply-To: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31967-70-oQ9S8sNvm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31967

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:01:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:01:43 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-cvSdjunq20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:01:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:01:46 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-FHpWXh5Ajs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:04:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:04:17 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-8hHYyeLgiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
I am provisionally passing QA on this. The only open issue is uploading large
documents ( https://tree.taiga.io/project/joubu-koha-erm/us/130 ). If that gets
sorted ( even by limited the size of uploads or such ) I think everything will
be good!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:06:35 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-wKYZduGIxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from David Nind <david at davidnind.com> ---
Tests still failing - they pass if I change the number of tests from 67 to 64.

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/67 Odd number of elements in anonymous hash
at t/db_dependent/Circulation.t line 5705.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. 64/67 # Looks like you planned 67 tests but ran
64.
t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 3/67 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 65280 Tests: 64 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 67 tests but ran 64.
Files=1, Tests=64, 50 wallclock secs ( 0.12 usr  0.01 sys + 42.00 cusr  4.12
csys = 46.25 CPU)
Result: FAIL

Test results if I change the number of tests to 64 (from 67):

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 63/64 Odd number of elements in anonymous hash
at t/db_dependent/Circulation.t line 5705.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. ok     
All tests successful.
Files=1, Tests=64, 44 wallclock secs ( 0.11 usr  0.01 sys + 36.17 cusr  3.52
csys = 39.81 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:08:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:08:49 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-HYBjN5wq5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Straight to QA, minor and easy fix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:10:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:10:25 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-FR5OZuzvtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:10:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:10:25 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-u4cfLzhmp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #20 from Jonathan Field <jonathan.field at ptfs-europe.com> ---
(In reply to Kyle M Hall from comment #19)
> I am provisionally passing QA on this. The only open issue is uploading
> large documents ( https://tree.taiga.io/project/joubu-koha-erm/us/130 ). If
> that gets sorted ( even by limited the size of uploads or such ) I think
> everything will be good!

Thanks Kyle! The upload document issue is sorted with this commit
https://gitlab.com/joubu/Koha/-/commit/468ae2cf215630274f953b539bc3b373cb8f73f8
so, hopefully, all is good!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:10:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:10:29 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-EHv8MUv6cW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143366|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:13:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:13:10 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-FeDO4lQ9Rx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143371&action=edit
Bug 32119: (bug 31422 follow-up) Fix add guarantee

To test:
1 - go to a patron detail view, click "add guarantee"
2 - Confirm form loads
3 - Confirm categories lsited are eligible to have a guarantor
4 - Fill out required fields and confirm patron saved correctly

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:18:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:18:07 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-aWKM3KDw1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:18:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:18:09 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-auSfB6asGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143370|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:18:39 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-WAJfP1MkdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143372&action=edit
Bug 32122: Correct permissions check on item circulation alerts

This patch changes the check from 'item_circ_alerts' to
'manage_item_circ_alerts'

To test:
1 - Give an account catalogue and manage_item_circ_alerts permissions
2 - Log in to staff client iwht this account
3 - Browse to Admin->Item circulation alerts
4 - Error, you do not have permission to view this page
5 - Apply patch
6 - Restart all
7 - Browse to page agian, success!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:20:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:20:45 +0000
Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit
In-Reply-To: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31895-70-TgljyXx5ex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:20:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:20:48 +0000
Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit
In-Reply-To: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31895-70-7jAbLhix05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:20:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:20:50 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-IRUtVxzUpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:20:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:20:53 +0000
Subject: [Koha-bugs] [Bug 32119] Cannot add new guarantee
In-Reply-To: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32119-70-oG1Gq2oX9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32119

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:20:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:20:56 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-h5atI7iWCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:21:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:21:00 +0000
Subject: [Koha-bugs] [Bug 32122] Wrong permissions check on item circulation
 alerts
In-Reply-To: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32122-70-cfTpeTpLr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:43:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:43:25 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-nZPs3YJbt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:43:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:43:31 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-gSRc8YuskO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136693|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143373&action=edit
Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to
block

Currently this syspref only bokcs the literal 'return' from a patron, i.e. the
checkin

It still processes transfers, refunds lost items, updates NotForLoan status
etc.

We should block all of these things

To test:
1 - Set BlockReturnOfWithdrawn to block
2 - Set an item as lost and withdrawn
3 - Check it in
4 - Item is found
5 - Apply patch
6 - Repeat 1-3
7 - Checkin is blocked, item still lost

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:51:30 +0000
Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle
 NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29755-70-rdMpZi6Vk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:54:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:54:09 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-JzLRkhobJn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Field from comment #20)
> Thanks Kyle! The upload document issue is sorted with this commit
> https://gitlab.com/joubu/Koha/-/commit/
> 468ae2cf215630274f953b539bc3b373cb8f73f8 so, hopefully, all is good!

💯

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 15:59:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 14:59:13 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-ZEJlJKTrtP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Victor Grousset/tuxayo from comment #21)
> That's why I wondered if there was any gain compared to just storing the
> passwords into koha-conf.xml directly? (or another file)

Simply put, imo, that would mean librarians could no longer update that data
without help from the server administrator, making their jobs more difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:00:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:00:28 +0000
Subject: [Koha-bugs] [Bug 28465] Don't allow staff user to change patron
 categories of other staff users and their own account
In-Reply-To: <bug-28465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28465-70-hAqMYQSXBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28465

--- Comment #3 from George Williams (NEKLS) <george at nekls.org> ---
I would also find this feature helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:01:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:01:10 +0000
Subject: [Koha-bugs] [Bug 32123] New: CRASH: Can't use an undefined value as
 a HASH reference at circ/article-requests.pl line 38
Message-ID: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

            Bug ID: 32123
           Summary: CRASH: Can't use an undefined value as a HASH
                    reference at circ/article-requests.pl line 38
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Looks like bug 32075.
Just another case where userenv returns undef.

my $branchcode = defined( $query->param('branchcode') ) ?
$query->param('branchcode') : C4::Context->userenv->{'branch'};

This line is just after get_template_and_user so we should expect it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:08:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:08:39 +0000
Subject: [Koha-bugs] [Bug 22398] Ability to create patrons that can't be
 deleted with normal edit_borrowers permissions
In-Reply-To: <bug-22398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22398-70-4BaNXan529@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22398

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #2 from George Williams (NEKLS) <george at nekls.org> ---
I would find this very useful

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:11:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:11:44 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-s9Asobn6tH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:15:04 +0000
Subject: [Koha-bugs] [Bug 32124] New: [OMNIBUS] Problems with
 C4::Context->userenv
Message-ID: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124

            Bug ID: 32124
           Summary: [OMNIBUS] Problems with C4::Context->userenv
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Things like:

Can't use an undefined value as a HASH reference at mainpage.pl 
Can't use an undefined value as a HASH reference at circ/article-requests.pl
line 38

See referenced bugs. In both cases you should though expect to find a userenv.
So what's going on in C4::Context or C4::Auth here ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:15:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:15:46 +0000
Subject: [Koha-bugs] [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
In-Reply-To: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32124-70-7lPG6vIHfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32075, 32123


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075
[Bug 32075] Staff mainpage crashed on Can't use an undefined value as a HASH
reference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123
[Bug 32123] CRASH: Can't use an undefined value as a HASH reference at
circ/article-requests.pl line 38
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:15:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:15:46 +0000
Subject: [Koha-bugs] [Bug 32075] Staff mainpage crashed on Can't use an
 undefined value as a HASH reference
In-Reply-To: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32075-70-BrJz0KXhVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32124


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124
[Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:15:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:15:46 +0000
Subject: [Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a
 HASH reference at circ/article-requests.pl line 38
In-Reply-To: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32123-70-uwhJUmVMjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32124


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124
[Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:20:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:20:36 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-zoB45x9d7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:34:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:34:55 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-tYtRoTNVSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I see.. this is another place we're a little inconsistent with how we mark up a
'toolbar'.

On 'Opac problem reports' and 'checkout notes' there are similar "toolbars" for
filtering the datatable... they have the following marking

<fieldset class="action" style="cursor:pointer;">

Should we try to synchronize the markup of those two 'filter bars' too here?

Challenge with this is that on those two pages there are also already <div
id="toolbar"> blocks on the page too.

I feel like an id of toolbar is wrong.. it should likely be a class instead.?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 16:55:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 15:55:47 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-NOdjrdtqLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143178|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143374&action=edit
Bug 32109: Fix spacing in toolbars containing text links

This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.

- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 17:03:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 16:03:03 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-8PTaV0musW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Signing off.. happy to see a follow-up here to make the other two cases I
identified match the markup.. or we could submit another bug for that.. I'll
defer that decision to the RM/QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 17:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 16:39:26 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-aNR7Uih8H2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 17:41:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 16:41:06 +0000
Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron
 (Single Sign On - SSO)
In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17004-70-eLUqCLEjPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 17:41:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 16:41:16 +0000
Subject: [Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI
 service GetRecords
In-Reply-To: <bug-30913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30913-70-ZSd4l8LPWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 17:43:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 16:43:16 +0000
Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved
 should check 'On shelf holds allowed' policy
In-Reply-To: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20985-70-jHVhbRCce8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 17:59:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 16:59:20 +0000
Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29440-70-FU9DKT4sMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #59 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 143375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143375&action=edit
Bug 29440: Replace removed syspref BiblioAddsAuthorities with AutoLinkBiblios

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:08:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:08:07 +0000
Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching
 on original id
In-Reply-To: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29654-70-UFkmekUufy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #9 from David Gustafsson <glasklas at gmail.com> ---
Sorry about being slow to reply. Tried applying the patch and applied cleanly
for me, realized the conflict was in bug 29440 which since have been rebased.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:12:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:12:41 +0000
Subject: [Koha-bugs] [Bug 32125] New: Implement contextual return on opac
 comments
Message-ID: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

            Bug ID: 32125
           Summary: Implement contextual return on opac comments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We should use the contextual return option added in bug 31699 to ensure a
patron is returned to the biblio details page they were on when trying to add a
comment to said biblio and getting prompted to login.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:12:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:12:52 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-ZsFMr47Bz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31699


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699
[Bug 31699] Add a generic way to redirect back to the page you were on at login
for modal logins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:12:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:12:52 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-LnD3Lz1yad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32125


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125
[Bug 32125] Implement contextual return on opac comments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:14:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:14:29 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-Wge2qOzM0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143376&action=edit
Bug 32125: Impliment modal context return on opac-detail.

This patch utilises the generic return option introduced in the previous
patch to prevent lose of context when clicking to login to add a comment
to a biblio.

Test plan
1/ Test that prior to this patch, upon clicking 'Log in to your account
to post a comment' you are redirected to opac-user.pl and thus loose
your context.
2/ Apply the patch
3/ Confirm that a login using the 'Log in to your account to post a
comment' link now redirect immediatly back the correct record and thus
maintains context.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:14:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:14:33 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-ctF2ZeA9Ik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143377&action=edit
Bug 32125: Select correct tab on return

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:14:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:14:42 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-RAm6fv8tai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:14:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:14:48 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-WuLjAASBS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:14:55 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-ySEOqSxYez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:15:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:15:01 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-VeHgVZMd1u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:15:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:15:38 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-e8TYMSNKyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This simply splits the work from bug 31699 to better document it for the
release notes.. carrying over SO and QA stamps

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:16:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:16:24 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-iLbEDjxnvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement ensures
      release notes|                            |patrons are returned to the
                   |                            |correct biblio detail page
                   |                            |after a login that is
                   |                            |prompted when attempting to
                   |                            |comment on a bilio.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:16:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:16:33 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-s8DSEyLyht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:17:10 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-FTRIWBsX5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142733|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143378&action=edit
Bug 31699: Add 'return' option to opac modal login

This patch adds the option to trigger a redirect back to the current
context after successful login using modal logins triggered from various
places in the OPAC.

To make use of this, simply add 'data-return="true"' to the modal trigger link.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:17:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:17:29 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-oPX6UqbvhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142734|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:18:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:18:52 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-TbCLnz5iuH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I decided to split this into two bugs.. one for the generic return code and one
for the use of it in the biblio details comments tab.

I also added a minor follow-up on the subsequent bug to ensure the correct tab
is selected too.

Keeping the QA stamp here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:20:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:20:50 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-HR1T0HPgOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:24:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:24:22 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-GlkSFobuKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Anyone else got an opinion here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:45:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:45:06 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-68gDa0oaqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:53:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:53:16 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-HdEP0bcMKR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143373|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143379&action=edit
Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to
block

Currently this syspref only bokcs the literal 'return' from a patron, i.e. the
checkin

It still processes transfers, refunds lost items, updates NotForLoan status
etc.

We should block all of these things

To test:
1 - Set BlockReturnOfWithdrawn to block
2 - Set an item as lost and withdrawn
3 - Check it in
4 - Item is found
5 - Apply patch
6 - Repeat 1-3
7 - Checkin is blocked, item still lost

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:53:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:53:28 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-nWWMs9RTj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:56:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:56:39 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-aS4qtqR1VK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

--- Comment #6 from David Nind <david at davidnind.com> ---
The older style for me (>)(ideally without the italics).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 18:58:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 17:58:47 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-qQyulVQnsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Older style (>), normal text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:14:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:14:41 +0000
Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/orderreceive.pl
In-Reply-To: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22405-70-L4FdPNDsvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405

Jaki <jaki.frisina at leblibrary.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jaki.frisina at leblibrary.com

--- Comment #3 from Jaki <jaki.frisina at leblibrary.com> ---
Since we have a lot of inactive budgets, it's a little confusing to sift
through all the old ones that shouldn't show up. It would be nice if only the
active ones show up!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:28:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:28:31 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-pkLroR8u0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:28:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:28:39 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-BfipyL200T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143343|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143380&action=edit
Bug 31414: Set focus to name in additional fields.

Focus is set to name on additional fields on
administation add fields.

Test plan
1. Go to administation and manange additional
fields.
2. If you then add field the focus should
automatically go to the field name.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:37:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:37:42 +0000
Subject: [Koha-bugs] [Bug 32120] Wrong display when editing a fund
In-Reply-To: <bug-32120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32120-70-TEqSdo9mtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32120

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:41:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:41:18 +0000
Subject: [Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a
 HASH reference at circ/article-requests.pl line 38
In-Reply-To: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32123-70-WNsK5T767o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31908

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:41:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:41:18 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-rI0BMV84ZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32123

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:43:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:43:04 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-72vWyYtyiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30109,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31042

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:43:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:43:04 +0000
Subject: [Koha-bugs] [Bug 30109] Wrong interface in logs when renewing patron
In-Reply-To: <bug-30109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30109-70-25UaFfBGDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30109

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31908

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 19:43:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 18:43:04 +0000
Subject: [Koha-bugs] [Bug 31042] OVERRIDE_SYSPREF does not work for REST API
In-Reply-To: <bug-31042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31042-70-GU6vb4gOT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31908

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:19:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:19:01 +0000
Subject: [Koha-bugs] [Bug 31345] Add ability to exit
 process_message_queue.pl early if any plugin before_send_messages hook
 fails
In-Reply-To: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31345-70-YFtT42yPht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:19:05 +0000
Subject: [Koha-bugs] [Bug 31345] Add ability to exit
 process_message_queue.pl early if any plugin before_send_messages hook
 fails
In-Reply-To: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31345-70-q4rrdsJaby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31345

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139027|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143381&action=edit
Bug 31345 - Add ability to exit process_message_queue.pl early if any plugin
before_send_messages hook fails

Sometimes it would be better for process_message_queue.pl to stop if a plugin
hook fails rather than continue processing. It would be nice if that was a
command line option.

Test Plan:
1) Install any plugin with a before_send_messages hook
2) Modify the plugin, add a 'die;' statement at the start of the
   before_send_messages method of the plugin.
3) Run process_message_queue.pl as usual
4) Note the exit code is 0
5) Run it again with the new -e setting
6) Note the exit code is 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:27:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:27:36 +0000
Subject: [Koha-bugs] [Bug 32126] New: Adding item search fields is broken -
 can't add more than one field
Message-ID: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

            Bug ID: 32126
           Summary: Adding item search fields is broken - can't add more
                    than one field
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

When adding item search fields (Administration > Catalog > Item search fields)
in current master, you can only add one new field.

If you try and add another one, the body of the page is blank (navigation, etc
is still in place).

I also checked this on the latest 22.05, and this problem doesn't occur - I can
successfully add multiple item search fields.  So something has broken this in
master.

I have also tried in different browsers (Firefox and Google Chrome).

To replicate:
1. Go to Administration > Catalog > Item search fields.
2. Click on 'New search field'.
3. Enter required details and submit:
   ==> table with the item search field added displayed.
4. Repeat step 2:
   ==> You now get a blank page (navigation, etc is still in place) and no add
new item search field form.

Identified when testing bug 31406.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:30:09 +0000
Subject: [Koha-bugs] [Bug 31406] Set focus for cursor to Name input when
 adding a new item search field
In-Reply-To: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31406-70-2q8Y4PLuCT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32126
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Hi Isobel.

This isn't working for me after applying the patch on master.

I think something else is going on that is unrelated to your change (both
before and after your patch is applied):
- I can add ONE new search field
- If I go to add another one, the body of the page is blank (navigation, etc is
still in place) and I don't get the add new item search field form
- Have tried in different browsers (Firefox and Google Chrome)
- I checked on the latest 22.05 version, and this problem doesn't occur: I can
successfully add multiple item search fields

I have created bug 32126 for this issue. Once that is fixed, this bug can be
retested.

David


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126
[Bug 32126] Adding item search fields is broken - can't add more than one field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:30:09 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-8wCheKMtwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31406


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406
[Bug 31406] Set focus for cursor to Name input when adding a new item search
field
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:32:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:32:10 +0000
Subject: [Koha-bugs] [Bug 31406] Set focus for cursor to Name input when
 adding a new item search field
In-Reply-To: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31406-70-h1b2BKGxz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #3 from David Nind <david at davidnind.com> ---
Status incorrectly changed!

Have changed back to Needs Signoff - once bug 32126 is fixed, this can be
retested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 20:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 19:32:35 +0000
Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/orderreceive.pl
In-Reply-To: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22405-70-dE8EuQGUKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405

--- Comment #4 from Abbey Holt <aholt at dubuque.lib.ia.us> ---
I agree 100 percent. Our acquisitions staff member regularly grumbles about
this!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 21:07:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 20:07:25 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-KPAv8TkeTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
This works on the staff interface, but I get no results for the OPAC.

This is related to the query in the URL I think.

OPAC:
- Query in URL generated on the OPAC:
/cgi-bin/koha/opac-search.pl?q=Host-item%3A("Easy piano pieces for children
\%2F")%26sort_by%3Dtitle_asc
- Search box: Host-item:("Easy piano pieces for children \/")&sort_by=title_asc
- Note - the staff interface has this in the search box: Host-item:("Easy piano
pieces for children \/")

If I change the query in the OPAC URL to the match that used in the staff
interface, it works:
- Change OPAC URL to: /cgi-bin/koha/opac-search.pl?q=Host-item:("Easy piano
pieces for children \/")&sort_by=title_asc
- OPAC search box: Host-item:("Easy piano pieces for children \/")

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 21:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 20:41:04 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-VFeLKgBd5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32075
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
-    my $local_pendingsuggestions_count = $pendingsuggestions->search({
'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();
+    if( C4::Context->userenv() && C4::Context->userenv()->{branch} ){

In this case there should be a userenv. Why it isnt? Reported this too on bug
32075. Weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 21:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 20:41:04 +0000
Subject: [Koha-bugs] [Bug 32075] Staff mainpage crashed on Can't use an
 undefined value as a HASH reference
In-Reply-To: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32075-70-AZcUjKXJTL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31908

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 22:40:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 21:40:19 +0000
Subject: [Koha-bugs] [Bug 32127] New: Always sort patrpn
Message-ID: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

            Bug ID: 32127
           Summary: Always sort patrpn
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 22:41:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 21:41:26 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-DLDbdNZsI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Always sort patrpn          |Sort patron categories by
                   |                            |description in templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 22:41:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 21:41:33 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-oDlO3eP2tW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 22:50:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 21:50:53 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-e8EQ7PjcuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 22:50:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 21:50:57 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-4HARchPNcH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 143382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143382&action=edit
Bug 32127: Sort by description in Koha::Template::Plugin::Categories

Like in Koha::Template::Plugin::Branches, methods in
Koha::Template::Plugin::Categories must return categories sorted by
description.

Test plan :
1) Create a new patron category with code ZZZ and description AAAAAA
2) Go to patron search /cgi-bin/koha/members/members-home.pl
3) Look at filter by category :
=> Without patch the value AAAAAA is last
=> With patch the value AAAAAA is first
4) Click on 'New patron'
=> Without patch the value AAAAAA is last
=> With patch the value AAAAAA is first

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 23:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 22:54:40 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-D0xHpYPc3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov  7 23:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Nov 2022 22:55:14 +0000
Subject: [Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI
 service GetRecords
In-Reply-To: <bug-30913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30913-70-ni7SJFTqb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I thought I'd attached a patch for this. Looks like I hadn't...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 02:04:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 01:04:20 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-IHFIvocHyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 02:32:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 01:32:24 +0000
Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31051-70-EFhiRBL2GL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139937|0                           |1
        is obsolete|                            |

--- Comment #32 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143384&action=edit
Bug 31051: (follow-up) Tests for get_savings and more

- Added tests in t/db_dependent/Koha/Patron.t
- Added wording to OPACShowSavings syspref about anonymised checkout
history
- Added IDs to the savings messages on the OPAC
- Prevent explosion if a checked out item has been deleted

Sponsored-by: Horowhenua Libraries Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 02:33:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 01:33:25 +0000
Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31051-70-6jZbnyjBmr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

--- Comment #33 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Lucas Gass from comment #31)
> Aleisha,
> 
> I think if we make this one dependent on Bug 26648 we can move it back to
> NSO.

Addressed in latest patch, ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 03:19:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 02:19:16 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-vfqJtYVJD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #202 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #201)
> I've just added an --sso option switch to the 'ktd' command, using the
> examples you provided (with minor tweaks).

I use a bit of a custom setup, but I'll include your docker-compose.sso.yml :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 04:57:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 03:57:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-cB6lEWk2yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #203 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #202)
> (In reply to Tomás Cohen Arazi from comment #201)
> > I've just added an --sso option switch to the 'ktd' command, using the
> > examples you provided (with minor tweaks).
> 
> I use a bit of a custom setup, but I'll include your docker-compose.sso.yml
> :D

Looks like the docker-compose.sso.yml still needs some work, but I've emailed
about fixing that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 05:05:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 04:05:32 +0000
Subject: [Koha-bugs] [Bug 32129] New: Use patron categorycode of most
 relevant recall when checking if item can be a waiting recall
Message-ID: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

            Bug ID: 32129
           Summary: Use patron categorycode of most relevant recall when
                    checking if item can be a waiting recall
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We check in (return) an item to trigger the recalls process and set it as
waiting for the patron who requested the recall.

Sometimes the recalls process isn't triggered, and there is no other way to
alert the patron that their item is ready for them to pick up if they've
recalled it.

This is because of more specific circulation rules. When we check if an item
can be set as waiting to fill a recall, we do not consider the category code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 05:05:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 04:05:44 +0000
Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant
 recall when checking if item can be a waiting recall
In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32129-70-2eKRPZIxyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |
         Depends on|                            |19532
  Change sponsored?|---                         |Sponsored


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 05:05:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 04:05:44 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-ZQL4dz7g3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32129


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129
[Bug 32129] Use patron categorycode of most relevant recall when checking if
item can be a waiting recall
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 05:37:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 04:37:43 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-vM7BktEx8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #22 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Jonathan Druart from comment #15)
> It's not how it appears, it should be displayed like this:
> https://snipboard.io/Pv5a9O.jpg

Weird, I still have it wrong on default zoom after getting latest code and
running yarn install.
I see it fine on the ERM sandbox.


> > There doesn't seem to be another filter mode when unchecked.
> 
> Another filter mode? What do you mean?

I was hypothesizing that the checkbox could be to switch from agreements having
expired before or equal to the date field. And to switch to agreements having
expired precisely at the date. The checkbox is next to the "on" so I though it
activated the "on" to modify the filter. To only show the agreements having
expired precisely on the date.
Or something else.


> > From the code it seems the date field is only used when the box is ticked.
> > Is that done to be able to keep an expiration date saved without having it
> > used? (it's not saved so it's not that)
> > Otherwise the filter could just be used when the date field is populated.
> 
> You only need to click the checkbox to search for "expired on today" (it
> will populate the date with today when the checkbox is ticked). That's
> something you couldn't have with your suggestion.

Ah ok the checkbox actually does something different! Now I though it was just
a switch meaning "take the next date field filter into account". Which seems
redundant and confusing. So my confusion came from wrongly understanding this.
Wait, when I click it doesn't populate the field. And no JS console error to
help. Same with Chromium. Same on ERM sandbox.

> I don't think the current behaviour is confusing, really. We could
> eventually hide 'on [date]' when the checkbox is not checked. We are talking
> about providing a MVP for 22.11 inclusion, not trying to catch minor UI
> design flaws ;)

Well at first my comment would have been about the expiration date filter not
working at all. I might have messed up when trying with the agreement periods
(End date vs Cancellation deadline) and though it was the license period. Since
the licenses have an expired status. But of course it wasn't the license
period.
But I finally got it working but thought either the checkbox was redundant and
was just to enable the use of the date filter. Or that there was two filter
modes or something else that I missed. Anyway, yes at that moment I lost the
focus on the MVP since indeed the expiration filter works! Let's keep that for
follow-ups.

> (In reply to Victor Grousset/tuxayo from comment #14)
> Coming from Folio:
> https://github.com/folio-org/ui-agreements/blob/master/src/constants/
> agreementRelationshipTypes.js
> I guess the idea was to have '_' for spaces and '-' for '-', but yes, it's
> inconsistent.

Ok it's to be consistent with another project. Makes sense even if they don't
:P
Thanks for the clarifications :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 06:29:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 05:29:03 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-QW7julw4G7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Kyle M Hall from comment #19)
> I am provisionally passing QA on this.

I've added your signed-off-by lines, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 06:30:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 05:30:15 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-HSf8Ztu4aY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Victor Grousset/tuxayo from comment #22)
> Wait, when I click it doesn't populate the field. And no JS console error to
> help. Same with Chromium. Same on ERM sandbox.

Click filter without date selected, today date will be used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:09:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:09:32 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-WOrRZmaeBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #204 from David Cook <dcook at prosentient.com.au> ---
Test plan 1:
0. Apply patches
1. apt install libmojolicious-plugin-oauth2-perl
2. koha-upgrade-schema kohadev
3. restart_all

Test plan 2a (Quarkus Keycloak):
1. Go to http://<workstation_ip>:8082/
2. Click "Administration Console"
3. Login to master realm
4. Click on dropdown menu that says "master"
5. Click "Create Realm"
6. Type "test" into "Realm name" and click "Create"
7. Click "Clients"
8. Click "Create client"
9. Type "test" into "Client ID"
10. Click "Next"
11. Set "Client authentication" to "On"
12. Click "Save"
13. Add "Valid redirect URIs" of "http://localhost:8080/*" and
"http://localhost:8081/*"
14. Click "Credentials" tab and note the "Client secret"
15. Click "Advanced" tab and turn "Exclude Session State From Authentication
Response" to "On" then click "Save"
16. Click "Users" on left nav
17. Click "Create new user"
18. Type "kohadev" into "Username"
19. Type "kohadev at koha-community.org" into Email"
20. Type "Firstname" into "First name"
21. Type "Lastname" into "Last name"
22. Click "Create"
23. Click "Credentials" tab and click "Set password"
24. Choose a password, turn off "Temporary", and click "Save"
25. Click "Realm settings" from the left nav
26. Click "OpenID Endpoint Configuration" at the bottom of the page

Test plan 2b:
1. Go to http://localhost:8081/cgi-bin/koha/admin/admin-home.pl
2. Click on "Identity providers"
3. Click "New identity provider"
4a. Type "test" into "Code"
4b. Type "Test" into "Description"
4c. Choose "OIDC" for "Protocol"
4d. Click "Add default OIDC configuration"
4e. Click "Add default OIDC mapping"
4f. Update "Configuration" to match Keycloak details for "key", "secret", and
"well_known_url"
5. Click on "Manage Domains"
6. Click "Edit" on the default domains
7. Set "Allow staff" and allow update on login and autoregister and click
"Submit"

8. koha-plack --restart kohadev
9. Update OPACBaseURL and staffClientBaseURL to http://localhost:8080 and
http://localhost:8081 respectively

Test plan 3:
1. In an Incognito window or different browser, go to http://localhost:8080,
and try logging in with a user that doesn't exist in Koha

--

I got the following error: 

There was an error authenticating to external identity provider

DBIC result _type isn't of the _type Category at
/usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130.

Looks like auto register doesn't work still...

I changed the email address for the "koha" user to "kohadev at koha-community.org"
at
http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51

Login works, but it doesn't update the user details on login either. 

Going to have to fail this again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:13:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:13:44 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-xbwqQYXMAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #205 from David Cook <dcook at prosentient.com.au> ---
When I add a Domain rule that forbids login for staff interface or OPAC, it
says "No configuration found for your email domain".

I think you could just leave it as "There was an error authenticating to
external identity provider".


But that's just a comment and not a blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:14:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:14:28 +0000
Subject: [Koha-bugs] [Bug 32130] New: Vue files must be kept tidy
Message-ID: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

            Bug ID: 32130
           Summary: Vue files must be kept tidy
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Keywords: rel_22_11_candidate
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030

We want to keep them tidy, and all use the them rules.
To enforce that we should have a test in xt to catch possible discrepancies.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:14:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:14:28 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-tcKqQKA2OC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32130


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130
[Bug 32130] Vue files must be kept tidy
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:16:55 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-aG6l6QC0nI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:16:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:16:59 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-jhtdGTN3Eo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143385&action=edit
Bug 32130: Add a test to ensure vue files will be kept tidy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:17:34 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-2wMp4ibgon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #206 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #204)
> I got the following error: 
> 
> There was an error authenticating to external identity provider
> 
> DBIC result _type isn't of the _type Category at
> /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130.
> 
> Looks like auto register doesn't work still...

It looks like I had forgotten to provide "Default library" and "Default
category".

When I do provide "Default library" and "Default category", it does auto
register a new patron! Yay!

If I provide a "Default category" but no "Default library", then I get this
error:

"There was an error authenticating to external identity provider

Broken FK constraint"

--

I think for these two scenarios, you just shouldn't show the error on the Web
UI. Log it to the log files and leave it at that. It's enough to tell the end
user that "There was an error authentication to external identity provider.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:24:31 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-oEUAl0LeDh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #207 from David Cook <dcook at prosentient.com.au> ---
I've double-checked that my ID token and UserInfo responses include
"given_name" and "family_name" and they do.

I've noticed with the auto register that it isn't populating the "firstname"
and "surname" fields.

That's probably why the update on login isn't working either.

--

So I think fixes required are:

1) Hide overly revealing error messages in Web UI
2) Fix mapping so that auto-register "update on login" works and auto register
includes mappings beyond just email.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:26:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:26:29 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-2knDrEg7V2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #208 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #207)
> So I think fixes required are:
> 
> 1) Hide overly revealing error messages in Web UI
> 2) Fix mapping so that auto-register "update on login" works and auto
> register includes mappings beyond just email.

I notice in the help text that it says "If you plan to use auto register
feature, either userid or cardnumber must be present in this mapping". 

That doesn't appear to be true in my testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:54:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:54:18 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-mAK2HQjTs5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #17 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
My bad. I added those four tests under new subtest to count instead of one.
This is now fixed, hopefully they pass now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 07:51:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 06:51:42 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-xCHsOw0H6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143349|0                           |1
        is obsolete|                            |

--- Comment #16 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143386&action=edit
Bug 31447: Add unit tests

To test prove t/db_dependent/Circulation.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 08:07:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 07:07:07 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-rqseSCMHls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://tree.taiga.io/proje
                   |                            |ct/joubu-koha-erm/us/140

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 08:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 07:08:46 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-r5MQ7AhXKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143385|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143387&action=edit
Bug 32130: Add a test to ensure vue files will be kept tidy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 09:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 08:13:15 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-IminS0nj7m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32131


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131
[Bug 32131] Cypress tests are failing if ERMModule is off
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 09:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 08:13:15 +0000
Subject: [Koha-bugs] [Bug 32131] New: Cypress tests are failing if ERMModule
 is off
Message-ID: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

            Bug ID: 32131
           Summary: Cypress tests are failing if ERMModule is off
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030

The tests are failing if the syspref is off.

What would be the best approach to turn the syspref on before running the test
(and making sure it's set back to its original value when the tests finished)?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 09:14:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 08:14:03 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-zKDydcoljA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, pjamorim91 at gmail.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 09:14:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 08:14:10 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-Hzx8HeEab5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 10:44:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 09:44:42 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-8pkGUaivRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132284|0                           |1
        is obsolete|                            |
 Attachment #132285|0                           |1
        is obsolete|                            |
 Attachment #132286|0                           |1
        is obsolete|                            |
 Attachment #132287|0                           |1
        is obsolete|                            |

--- Comment #42 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143388&action=edit
Bug 16223: Add new columns to table restriction_types

This patch adds two new columns, lift_after_payment and fee_limit,
to table restriction_types. These colums are used to control
lifting patrons restrictions after paying their fees.

To test:
1. Apply this patch.
2. Update your database via updatedatabase.pl.
=> Confirm your table restriction_types has two new columns.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 10:45:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 09:45:14 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-ABFycaxy5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #43 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143389&action=edit
Bug 16223: DO NOT PUSH! Schema changes

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 10:45:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 09:45:46 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-af8lyEayWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #44 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143390&action=edit
Bug 16223: Add ability to define liftable restrictions

Some libraries debar Patrons at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Patron has paid his/her fines.

This patch adds ability to create restrictions which are lifted after
patron pays ceratain amount of fines.

To test:
1. Apply this patch.
2. Restart your services if needed.
3. Navigate to page restrictions.pl.
=> Note that table has two new colums in it, "Lift after payment?" and "Fee
limit".
4. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
5. Create fees for a patron so they exceed fee limit e.g. 10
6. Add restriction made in step 2. for the patron
7. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 10:45:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 09:45:57 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-2i6MlPMWnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 12:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 11:59:29 +0000
Subject: [Koha-bugs] [Bug 32132] New: Missing budget_period_id in aqbudgets
 kills lateorders.pl
Message-ID: <bug-32132-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132

            Bug ID: 32132
           Summary: Missing budget_period_id in aqbudgets kills
                    lateorders.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

If column budget_period_id in aqbudgets table is NULL lateorders.pl, Koha dies
on error 500. Logs read:

Template process failed: undef error - DBIC result _type  isn't of the _type
Aqbudget at
/home/koha/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
line 157. 

Of course solution for this is to fix missing values, but I think we should
still prevent Koha dying on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:08:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:08:57 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-XPPBoJkKye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:09:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:09:00 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-CSenHfKSjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143382|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143391&action=edit
Bug 32127: Sort by description in Koha::Template::Plugin::Categories

Like in Koha::Template::Plugin::Branches, methods in
Koha::Template::Plugin::Categories must return categories sorted by
description.

Test plan :
1) Create a new patron category with code ZZZ and description AAAAAA
2) Go to patron search /cgi-bin/koha/members/members-home.pl
3) Look at filter by category :
=> Without patch the value AAAAAA is last
=> With patch the value AAAAAA is first
4) Click on 'New patron'
=> Without patch the value AAAAAA is last
=> With patch the value AAAAAA is first

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:56:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:56:51 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-VkXUjTQdiw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #2)
> Hmm..I though maybe we could just fix the front end, but it gets weird
> 
> Apply patch
> Sign in as unauthorised user
> You are not allowed
> Sign in as authorised user
> Note username refers to unauthorised user

Without your patch, this triggers:
Can't use an undefined value as a HASH reference at /usr/share/koha/mainpage.pl
line 88
This brings us closer to finding the cause !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:57:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:57:28 +0000
Subject: [Koha-bugs] [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
In-Reply-To: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32124-70-12nGG45fWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908
[Bug 31908] Context accessed but not always set on mainpage.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:57:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:57:28 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-DKSq1T70ll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32124


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124
[Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:57:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:57:53 +0000
Subject: [Koha-bugs] [Bug 32075] Staff mainpage crashed on Can't use an
 undefined value as a HASH reference
In-Reply-To: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32075-70-aYAUSIexdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---


*** This bug has been marked as a duplicate of bug 31908 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:57:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:57:53 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-FTFxKnht0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
*** Bug 32075 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 13:57:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 12:57:54 +0000
Subject: [Koha-bugs] [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
In-Reply-To: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32124-70-FkDG4mfRhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124
Bug 32124 depends on bug 32075, which changed state.

Bug 32075 Summary: Staff mainpage crashed on Can't use an undefined value as a HASH reference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32075

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:06:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:06:05 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-Ws4G8BF9o1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Digging a bit further. With your test plan in mind I tend to not trust these
lines in Auth:

                else {
                    $info{'nopermission'} = 1;
                    C4::Context::_unset_userenv($sessionID);
                }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:07:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:07:54 +0000
Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to
 have a 'branch only' option
In-Reply-To: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30880-70-actl6YgXz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:07:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:07:57 +0000
Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to
 have a 'branch only' option
In-Reply-To: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30880-70-T0V4BjREOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:08:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:08:00 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-fisisZT6KX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:08:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:08:03 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-fOpLax7quE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:18:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:18:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-NHo5U0quRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #209 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #208)
> (In reply to David Cook from comment #207)
> > So I think fixes required are:
> > 
> > 1) Hide overly revealing error messages in Web UI
> > 2) Fix mapping so that auto-register "update on login" works and auto
> > register includes mappings beyond just email.
> 
> I notice in the help text that it says "If you plan to use auto register
> feature, either userid or cardnumber must be present in this mapping". 
> 
> That doesn't appear to be true in my testing.

Any NOT NULL attribute on the borrowers table needs to be mapped for
auto-register. I don't really understand this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:19:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:19:00 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for holds
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-kODLzhZ8lA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Laura <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Laura.escamilla at bywatersolu
                   |                            |tions.com
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:19:45 +0000
Subject: [Koha-bugs] [Bug 32133] New: Streamline OIDC error messages
Message-ID: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32133

            Bug ID: 32133
           Summary: Streamline OIDC error messages
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:19:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:19:52 +0000
Subject: [Koha-bugs] [Bug 32133] Streamline OIDC error messages
In-Reply-To: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32133-70-wAHzW3gSiZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:19:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:19:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-NqJwoVwFDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32133
[Bug 32133] Streamline OIDC error messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:31:07 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-yxMeIX9G6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Apparently not the above.
But this seems to work:

                #if a user enters an id ne to the id in the current session, we
need to log them in...
                #first we need to clear the anonymous session...
                $anon_search_history = $session->param('search_history');
                $session->delete();
                $session->flush;
                $cookie = $cookie_mgr->clear_unless( $query->cookie, @$cookie
);
                C4::Context::_unset_userenv($sessionID);
                $sessionID = undef;
undef $userid;

If we clear $userid here, it will go into the unless($userid) block and get a
new session. Note that $userid and $q_userid are not equal here !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:37:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:37:29 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-NTNd1sfDQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From 20.11.x:

            #if a user enters an id ne to the id in the current session, we
need to log them in...
            #first we need to clear the anonymous session...
            $debug and warn "query id = $q_userid but session id = $s_userid";
            $anon_search_history = $session->param('search_history');
            $session->delete();
            $session->flush;
            C4::Context->_unset_userenv($sessionID);
            $sessionID = undef;
            $userid    = undef;

See former comment too.
Note that probably in the 2FA changes, this $userid line got "lost" somewhere.
So I propose to reinsert it here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:43:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:43:47 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-RfVnrNM5lm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:43:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:43:52 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-7yvYwoFgZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143392&action=edit
Bug 31908: Resolve second login with another userid

Somewhere the line undef $userid got removed.
We need it to resolve the second login situation.

Test plan:
Login in staff with user missing privileges.
On the login form login again with another staff user.
Note that you do no longer crash.

Run t/db../Auth.t
Run t/db../Koha/Auth/TwoFactorAuth.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:44:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:44:08 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-CjpuNcvkpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:46:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:46:35 +0000
Subject: [Koha-bugs] [Bug 31908] Context accessed but not always set on
 mainpage.pl
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-2OQsUosGxX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142361|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 142361
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142361
Bug 31908: Only count local suggestions if there is a userenv

This patch should no longer be needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:56:21 +0000
Subject: [Koha-bugs] [Bug 31908] New login fails while having cookie from
 previous session
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-rriNCop3mW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Context accessed but not    |New login fails while
                   |always set on mainpage.pl   |having cookie from previous
                   |                            |session

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 14:57:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 13:57:31 +0000
Subject: [Koha-bugs] [Bug 31908] New login fails while having cookie from
 previous session
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-wovnUJi0o0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You can recreate the problem too by logging into the OPAC with user A, and on
another tab login with user B on staff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:00:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:00:55 +0000
Subject: [Koha-bugs] [Bug 31908] New login fails while having cookie from
 previous session
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-cuu33qWrtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #12)
> You can recreate the problem too by logging into the OPAC with user A, and
> on another tab login with user B on staff.

And if you try to replicate with two OPAC tabs, the second tab will not login
but it will logout the first one too. Nice.
Resolved with the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:01:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:01:20 +0000
Subject: [Koha-bugs] [Bug 31908] New login fails while having cookie from
 previous session
In-Reply-To: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31908-70-ozXu6Hr847@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31908

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-iEoGZq9bLN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:57 +0000
Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents
 in checkouts table
In-Reply-To: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25503-70-r7PtCA2H7s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503
Bug 25503 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:57 +0000
Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the
 inventory tool
In-Reply-To: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29099-70-tIIiO4mLKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099
Bug 29099 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:58 +0000
Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding
 items to bundles
In-Reply-To: <bug-29560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29560-70-g2OoJCrYHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560
Bug 29560 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:58 +0000
Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice
In-Reply-To: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29566-70-Pkge7ZFJXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566
Bug 29566 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:58 +0000
Subject: [Koha-bugs] [Bug 31078] Lost status different to 1 don't show with
 description in bundle detail view
In-Reply-To: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31078-70-hddGh3JZEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078
Bug 31078 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:58 +0000
Subject: [Koha-bugs] [Bug 31079] Entering an empty line on checking of an
 item bundle, gives "Unexpected:" error
In-Reply-To: <bug-31079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31079-70-kX8YDY2bPY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079
Bug 31079 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:58 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-zofIPvAnyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080
Bug 31080 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:59 +0000
Subject: [Koha-bugs] [Bug 31081] Improve display of 'Manage bundle' button
In-Reply-To: <bug-31081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31081-70-zVGRsCMfEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31081
Bug 31081 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:59 +0000
Subject: [Koha-bugs] [Bug 31082] Add tooltip to buttons when item bundles
 cannot be changed while checked out
In-Reply-To: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31082-70-NHkvH8wY28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082
Bug 31082 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:59 +0000
Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table
In-Reply-To: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31084-70-pjgWm23eab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084
Bug 31084 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:59 +0000
Subject: [Koha-bugs] [Bug 31130] Display collection code in bundle
 management table
In-Reply-To: <bug-31130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31130-70-jFD37itYs6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130
Bug 31130 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:06:59 +0000
Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without
 verifying their contents
In-Reply-To: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31615-70-EhgNOEhScT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615
Bug 31615 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:07:00 +0000
Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out
 item to an item bundle
In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32121-70-DX2KsD0UuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121
Bug 32121 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:07:00 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-bL21tQLUbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083
Bug 31083 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:07:00 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-8zWFUQeKuv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192
Bug 31192 depends on bug 28854, which changed state.

Bug 28854 Summary: Add ability to create bundles of items for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:07:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:07:24 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-LkwjHwq1Ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #509 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Documentation converted from google doc and merged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:08:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:08:30 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-QaBjxB2sA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
First draft of documentation is now merged into the manual.. Lucy (from ptfs-e)
is reviewing and refining it now it's made it upstream :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:08:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:08:40 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-Hasit9YqyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:08:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:08:47 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-9zh5VvaJGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:08:48 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-nc4OtfmNwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130
Bug 32130 depends on bug 32030, which changed state.

Bug 32030 Summary: Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:08:48 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-cFGsHoVQC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131
Bug 32131 depends on bug 32030, which changed state.

Bug 32030 Summary: Electronic resource management (ERM)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:28:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:28:32 +0000
Subject: [Koha-bugs] [Bug 32134] New: Show the bundle size when checked out
Message-ID: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134

            Bug ID: 32134
           Summary: Show the bundle size when checked out
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

When checking out a bundle, it can be useful to know the number of items in
this bundle, so that librarians can quickly check if items are missing.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items for circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:28:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:28:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-OVWHQxer9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32134


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134
[Bug 32134] Show the bundle size when checked out
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:29:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:29:14 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32134-70-0rfSumghAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143393&action=edit
Bug 32134: Show the bundle size when checked out

When checking out a bundle, it can be useful to know the number of items
in this bundle, so that librarians can quickly check if items are
missing.

Test plan:
1. Create a bundle (see bug 28854 comment 458)
2. Check out the bundle.
3. Verify that you have the bundle size in the message below the barcode
   input ("Checked out: [...]. Bundle of X items. Due on [...]")
4. Checkout an item that is not a bundle.
5. Verify that the bundle message does not appear

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:29:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:29:24 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32134-70-HUDLm8kFp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:33:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:33:47 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-YAUnsyjVLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. so people don't like the header idea.

In which case...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:34:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:34:21 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-bUYB2y4jh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143394&action=edit
Next

How does this look?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:42:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:42:16 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-c1oyIKG1rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #45 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
The third patch here just failed to apply for me on a sandbox. Not sure what
might have changed, given how recently you posted it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:45:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:45:04 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-akFF7rlS0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:46:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:46:05 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-DiPSTCU9Ir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143266|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:48:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:48:29 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-A2ytu2MCoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143267|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:48:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:48:32 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for holds
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-GelYt2oABm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Laura <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:48:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:48:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-apEXTvqvqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143268|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:48:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:48:43 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-tcQMvHUNIv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143269|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:48:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:48:49 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-UYHWXu9dQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143270|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:48:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:48:55 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9b7EBhpVqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143271|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:02 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-NTyEa8OIyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143272|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:08 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-MZJvuGgDVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143273|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:15 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-355WXY4Qkq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143274|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:21 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-rqtbT4cJpa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143275|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:28 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-PwoCyNXjXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143277|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:34 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-bF5ffTdKsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143278|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:40 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-sPhX2SmCT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143279|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:46 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eOeRmpLAE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143280|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:51 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-1E4YaIze5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143281|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:49:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:49:58 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-CLqvJ7ArCr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143282|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:05 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-q8OUIOY1fS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143283|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:13 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-z9CfVgKF6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143284|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:19 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-8YWWyruzGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143285|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:27 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-0LUFdAOvUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143286|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:31 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-qG4uhEkAP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143395&action=edit
Bug 31852: Move hidden input fields

There didn't appear to be any reason to have the hidden form fields here
nested in the ordered list and they were causing undesired styling
issues.

This patch simply moves them to the beggining of the fieldset.

Test plan
1) Confirm the 'HTML message' label now aligns correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:35 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-vloAOjk1OL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143287|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:41 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-lfKTFyGd1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143288|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:50:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:50:45 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-Gh1T2XstQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:11 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-tOqKYZZCJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #210 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143396&action=edit
Bug 31378: DB changes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:15 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-9VJteDJET7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Straight to QA, trivial patch, just needs regression testing by a QA member
please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:23 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-qLb0wqFfuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eKCievHjMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #211 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143397&action=edit
Bug 31378: DBIC updates [DO NOT PUSH]

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:34 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-U1lKbneRTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #212 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143398&action=edit
Bug 31378: Add dependencies

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:43 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-fOSOMTqCkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #213 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143399&action=edit
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:51:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:51:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-IjEfjllvOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #214 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143400&action=edit
Bug 31378: Add Koha::Auth::Provider(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:04 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-56yemF2XaR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #215 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143401&action=edit
Bug 31378: Add Koha::Auth::Client* modules

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:13 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eudaYRUMKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #216 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143402&action=edit
Bug 31378: Add Auth mojo plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-M2J95IpdXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #217 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143403&action=edit
Bug 31378: Add API routes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:32 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-gEQHibVkHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #218 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143404&action=edit
Bug 31378: Add auth providers template plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:39 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-oBWvVlVWF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #219 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143405&action=edit
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:47 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-hs4Zo6oD6Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #220 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143406&action=edit
Bug 31378: Add OPAC support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:52:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:52:55 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-1Fz70yaNqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #221 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143407&action=edit
Bug 31378: Add STAFF support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:04 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-PNFhWfxS3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #222 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143408&action=edit
Bug 31378: Add accessor methods for JSON attributes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:12 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-MVMYy8X0uU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #223 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143409&action=edit
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:20 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-LUAR1OxuSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #224 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143410&action=edit
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:28 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-AbjNWZrp0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #225 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143411&action=edit
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:36 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-pTLhTqzlmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #226 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143412&action=edit
Bug 31378: Add an administration interface for authentication sources

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:44 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-66D9if5OeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #227 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143413&action=edit
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:53:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:53:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-YFaXO3lcMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #228 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143414&action=edit
Bug 31378: (follow-up) Fix QA concerns

Several FIXME comments added on the report addressed here.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:54:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:54:02 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Ma1wZ4KfRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #229 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143415&action=edit
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:54:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:54:10 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-y1T14jF5qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #230 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143416&action=edit
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:54:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:54:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-rQmUs5FscN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #231 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143417&action=edit
Bug 31378: (QA follow-up) Tidy tests

This patch perltidys the tests added lately. It also removes some
commented debugging lines.

Note: There's an attempt to write tests on the full auth workflow that
is commented out but left there on purpose for now.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 15:54:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 14:54:26 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-hXReIktC8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #232 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143418&action=edit
Bug 31378: Add domain settings to IdP add page

This patch introduces a small form for an initial domain configuration
to the 'New identity provider' page, to avoid confusion on testers about
required settings for things to work.

To test:
1. Apply this patch
2. Verify you are now offered a configuration section for domain
   settings. Fields like 'Default category' and 'Default library' are
   mandatory.
3. Choosing some values makes them get stored on 'Submit'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:00:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:00:45 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-V05sw3ExyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143395|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:01:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:01:13 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-s1rK9wIlWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143419&action=edit
Bug 31752: Move hidden input fields

There didn't appear to be any reason to have the hidden form fields here
nested in the ordered list and they were causing undesired styling
issues.

This patch simply moves them to the beggining of the fieldset.

Test plan
1) Confirm the 'HTML message' label now aligns correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:01:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:01:32 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-jZknPi99Ip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:12:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:12:35 +0000
Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode
In-Reply-To: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31482-70-aMU9VJv4wA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:14:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:14:19 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-mkrglIsB6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Keywords|                            |rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:00 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-VWEYNA1QPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143396|0                           |1
        is obsolete|                            |

--- Comment #233 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143420&action=edit
Bug 31378: DB changes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-yYBrAn1yX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143397|0                           |1
        is obsolete|                            |

--- Comment #234 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143421&action=edit
Bug 31378: DBIC updates [DO NOT PUSH]

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-z8126E3Q8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143398|0                           |1
        is obsolete|                            |

--- Comment #235 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143422&action=edit
Bug 31378: Add dependencies

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:27 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-2Oow2a3J5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143399|0                           |1
        is obsolete|                            |

--- Comment #236 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143423&action=edit
Bug 31378: Add Koha::Auth::Provider::Domain(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-2cyAxQaZFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143400|0                           |1
        is obsolete|                            |

--- Comment #237 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143424&action=edit
Bug 31378: Add Koha::Auth::Provider(s) class(es)

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:45 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-FHJNs9jOPp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143401|0                           |1
        is obsolete|                            |

--- Comment #238 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143425&action=edit
Bug 31378: Add Koha::Auth::Client* modules

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:52 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-LQ4rieyi4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143402|0                           |1
        is obsolete|                            |

--- Comment #239 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143426&action=edit
Bug 31378: Add Auth mojo plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:23:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:23:59 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-NVrxYZUgeF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143403|0                           |1
        is obsolete|                            |

--- Comment #240 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143427&action=edit
Bug 31378: Add API routes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-RxRejig9fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143404|0                           |1
        is obsolete|                            |

--- Comment #241 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143428&action=edit
Bug 31378: Add auth providers template plugin

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:14 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-NkvNiIFFos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143405|0                           |1
        is obsolete|                            |

--- Comment #242 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143429&action=edit
Bug 31378: Add the API-based auth mechanism to C4::Auth::check_api_auth

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-Jbs3Zu3j5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143406|0                           |1
        is obsolete|                            |

--- Comment #243 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143430&action=edit
Bug 31378: Add OPAC support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:31 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-H8Hle6e12C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143407|0                           |1
        is obsolete|                            |

--- Comment #244 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143431&action=edit
Bug 31378: Add STAFF support for authentication providers

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:39 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-YInLwoKQVN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143408|0                           |1
        is obsolete|                            |

--- Comment #245 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143432&action=edit
Bug 31378: Add accessor methods for JSON attributes

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:48 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-nzfsePyYn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143409|0                           |1
        is obsolete|                            |

--- Comment #246 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143433&action=edit
Bug 31378: Add manage_authentication_providers permission

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:24:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:24:55 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-7waOEu0aWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143410|0                           |1
        is obsolete|                            |

--- Comment #247 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143434&action=edit
Bug 31378: Add 'parameter' parameter to Koha::Exceptions::MissingParameter

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:03 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-UXtxpgVwJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143411|0                           |1
        is obsolete|                            |

--- Comment #248 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143435&action=edit
Bug 31378: Add authentication provider endpoints

This patch adds routes for handling authentication providers to the REST
API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_providers.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:12 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-OcUbpWI4tv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143412|0                           |1
        is obsolete|                            |

--- Comment #249 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143436&action=edit
Bug 31378: Add an administration interface for authentication sources

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:20 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-HxayjKh6zN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143413|0                           |1
        is obsolete|                            |

--- Comment #250 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143437&action=edit
Bug 31378: Rename Auth Provider to Identity Provider and add Client.t tests

Signed-off-by: Lukasz Koszyk <lukasz.koszyk at kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:29 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-HTvY4SmUtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143414|0                           |1
        is obsolete|                            |

--- Comment #251 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143438&action=edit
Bug 31378: (follow-up) Fix QA concerns

Several FIXME comments added on the report addressed here.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:36 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-QrnmLiaE0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143415|0                           |1
        is obsolete|                            |

--- Comment #252 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143439&action=edit
Bug 31378: Use base URLs for redirect uri

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:43 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-wZKpibWydc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143416|0                           |1
        is obsolete|                            |

--- Comment #253 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143440&action=edit
Bug 31378: (follow-up) catch startup error when missing Oauth provider table

In theory, this shouldn't come up with a package install, but
it could happen with other installations, so best to let it get to
the web installer.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:50 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-jacgCmlcrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143417|0                           |1
        is obsolete|                            |

--- Comment #254 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143441&action=edit
Bug 31378: (QA follow-up) Tidy tests

This patch perltidys the tests added lately. It also removes some
commented debugging lines.

Note: There's an attempt to write tests on the full auth workflow that
is commented out but left there on purpose for now.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:25:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:25:57 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-aNOCaHsLDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143418|0                           |1
        is obsolete|                            |

--- Comment #255 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143442&action=edit
Bug 31378: Add domain settings to IdP add page

This patch introduces a small form for an initial domain configuration
to the 'New identity provider' page, to avoid confusion on testers about
required settings for things to work.

To test:
1. Apply this patch
2. Verify you are now offered a configuration section for domain
   settings. Fields like 'Default category' and 'Default library' are
   mandatory.
3. Choosing some values makes them get stored on 'Submit'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:26:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:26:05 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-4PpPiDEFzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #256 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143443&action=edit
Bug 31378: DBIC Build

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:37:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:37:08 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-JFMr8Pplx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Severity|minor                       |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:38:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:38:01 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-qdKvJUoM3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Martin Renvoize from comment #18)
> Created attachment 143394 [details]

I like this one, but as we've discussed on IRC it doesn't work if the tabs are
on a white background. If we want to go this way we'll have to make sure we can
restructure pages in a way that lets the tabs stand on their own.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:38:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:38:25 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-MCRP3uQxJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff Client                |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:52:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:52:22 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-oicYI9RoKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143444&action=edit
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:53:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:53:37 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-Tj6b4aPMXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
           Severity|enhancement                 |trivial
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:53:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:53:43 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-GHSAHM16hW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 16:54:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 15:54:20 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-jKsfBaZlSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I can't entirely remember if there was anything else here.. could you verify
that it was just the header underline we were concerned with David?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:07:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:07:56 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-8E4dGDJAb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

Olivier Hubert <olivier.hubert at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142517|0                           |1
        is obsolete|                            |

--- Comment #2 from Olivier Hubert <olivier.hubert at inlibro.com> ---
Created attachment 143445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143445&action=edit
Bug 31074: Reload a plugin's module before installation

When using Plack, memcached or another caching mechanism, a plugin's old
version is retained
in the cache, even when uninstalled. If the plugin is then reinstalled, the old
version is
used, no matter the version installed. To prevent this, the plugin's module is
reloaded every
time it is installed.

To test:
1) Install a plugin, like the kitchen sink.
   https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases
2) Modify the .kpz and in KitchenSink.pm, change MINIMUN_VERSION.
3) Uninstall the plugin.
4) Install the new version.
5) The Minimum Koha version column still lists the old version.
6) Apply patch.
7) Repeat steps 1 through 4.
8) Observe that the Minimum Koha version column lists the correct version.
9) Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:08:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:08:13 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-7lQrfBdc30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Inspecting the page on this it appears we're setting font in px.. the top bar
options are 13px and the dropdown are 12px

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:08:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:08:53 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-1dVtIvxa3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:13:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:13:58 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-6glO95vMzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143446&action=edit
Bug 32004: Match font size for dropdowns to header

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:14:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:14:24 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-ucFkNtjaAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:14:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:14:30 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-VCefcBH4dJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:14:43 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-I0XK3QOfka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |trivial
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:30:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:30:56 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-qkfiUhBoz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143447&action=edit
Bug 32005: Remove stack unordered lists

Not sure why, but we had two unordered list elements stacked on top of
each other here instead of just one overall list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:31:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:31:00 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-oFDbpw6hBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143448&action=edit
Bug 32005: Cleanup indenting

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:31:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:31:19 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-skNmHvmpnn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Severity|enhancement                 |trivial
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:31:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:31:27 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-89GVOPevvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:31:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:31:34 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-pzuEETR71f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:39:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:39:28 +0000
Subject: [Koha-bugs] [Bug 28486] MARCItemFieldsToOrder values lost when
 using Add Order button
In-Reply-To: <bug-28486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28486-70-N6AJsuZR6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28486

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31092

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:39:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:39:28 +0000
Subject: [Koha-bugs] [Bug 31092] Upon importing batch records, if a full
 MARC record is found, only append the items;
 do not overlay a full MARC record
In-Reply-To: <bug-31092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31092-70-LCe1vUkPTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31092

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28486

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:58:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:58:18 +0000
Subject: [Koha-bugs] [Bug 32135] New: Ability to batch cancel transfers
Message-ID: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32135

            Bug ID: 32135
           Summary: Ability to batch cancel transfers
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: madamyk at ckls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

For consortiums and other large systems, it would be helpful to have the
ability to batch cancel transfers, or cancel more than one at a time. 

Most likely the easiest place to do this would be on the Transfers to Receive
page, where you might be able to add a "Cancel Transfer" checkbox instead of
(or in addition to) the button.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:59:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:59:22 +0000
Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or
 warn the user if CheckPrevCheckout is used via SIP2
In-Reply-To: <bug-26591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26591-70-DVPrGfLWGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591

Juliet Heltibridle <jheltibridle at rcplib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jheltibridle at rcplib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 17:59:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 16:59:43 +0000
Subject: [Koha-bugs] [Bug 32135] Ability to batch cancel transfers
In-Reply-To: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32135-70-ll3gCY6j4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32135

--- Comment #1 from Michael Adamyk <madamyk at ckls.org> ---
Something that would be a super cool addition would be to also have the option
to "Cancel and mark lost," but that's probably beyond the scope of a single
bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 18:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 17:50:54 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-ntj8ab1hRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Do we need some form of validation for $return?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 18:54:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 17:54:42 +0000
Subject: [Koha-bugs] [Bug 32136] New: E-mail testing
Message-ID: <bug-32136-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32136

            Bug ID: 32136
           Summary: E-mail testing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Email Checker (email-checker.net) is a tool that does some e-mail validation. 
Step 1 Koha already does, but I am curious if Koha could do steps 2 and 3?

How do we verify an email ?
First it checks for email address format.
Then make sure that domain name is valid. We also check whether it’s a
disposable email address or not.
In the final step, It extracts the MX records from the domain records and
connects to the email server (over SMTP and also simulates sending a message)
to make sure the mailbox really exists for that user/address. Some mail servers
do not cooperate in the process, in such cases, the result of this email
verification tool may not be as accurate as expected.

The tool itself limits you to 5 checks per hour.  There is a premium plan, and
also an API.

Only 5 lookups per hour, in free plan.

Upgrade to our premium plan or use the API.

This would be a great tool when creating a patron record.  With the way it is
worded, I don't know if the API is free to use, but if not, I'm wondering if we
could incorporate the same methods in Koha?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 18:55:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 17:55:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-WSaCeVLRMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|dcook at prosentient.com.au    |testopia at bugs.koha-communit
                   |                            |y.org
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 18:57:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 17:57:01 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-lUD6Lsr9oU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 18:57:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 17:57:04 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-BENGVyMPWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #257 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 18:58:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 17:58:48 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-aPyVSjcl6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gitlab.com/thekesol |
                   |utions/Koha/-/commits/oauth |
                   |_client                     |
           Keywords|rel_22_11_candidate         |release-notes-needed

--- Comment #258 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Thanks everyone. Any issues you might find, please file follow-up bugs.
Fixes/enhancements are welcome of course.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 19:05:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 18:05:20 +0000
Subject: [Koha-bugs] [Bug 32137] New: Resend notices with updated info
Message-ID: <bug-32137-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

            Bug ID: 32137
           Summary: Resend notices with updated info
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

When you resend a notice, it seems to simply resend using the same info it used
before.  This is pointless.  If the number or e-mail address was bad to begin
with, why are we resending to the same?  Many times we can correct issues with
numbers or addresses, or we change HOW the patron receives a notice.  We should
be able to resend the notice based on current info in the patron record.  This
would be much more useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 20:13:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 19:13:21 +0000
Subject: [Koha-bugs] [Bug 21699] Allowing circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-Skyhgbxmvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 20:14:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 19:14:57 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-gUHGyxO7fi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 20:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 19:52:16 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-JGiAURw5FR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, probably a good idea... You thinking something like a test that at the
base matches OpacBaseURL?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 20:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 19:55:40 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-g9d12wjHWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #17)
> Hmm, probably a good idea... You thinking something like a test that at the
> base matches OpacBaseURL?

At least the domain used to retrieve the page (maybe calculated).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 21:16:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 20:16:36 +0000
Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant
 recall when checking if item can be a waiting recall
In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32129-70-0zssAvvogG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 21:16:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 20:16:40 +0000
Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant
 recall when checking if item can be a waiting recall
In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32129-70-q4PjoaMb2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143449&action=edit
Bug 32129: Use patron category when checking if item can fill recall

This patch uses the patron category of the patron who requested the most
relevant recall to check for more specific circulation rules relating to
recalls. This ensures that patrons who are allowed to place recalls are
able to fill their recalls, especially when recalls are not generally
available for all patron categories.

To test:
1) Go to Administration -> System preferences and enable UseRecalls
2) Go to Administration -> Circulation and fines rules and set a general
All/All rule and a Category A/Itemtype A rule. All values can be set
however you like except for these recalls rules:

All/All rule:
Recalls allowed: 0
Recalls per record: 0
On shelf recalls allowed: if any unavailable

Category A/Itemtype A rule:
Recalls allowed: 5
Recalls per record: 5
On shelf recalls allowed: if any unavailable

3) Find an item of Itemtype A. Check it out to Patron A (any category).
4) Log into the OPAC as Patron B (of Category A). Find the item and
place a recall on the item.
5) Back in the staff interface, check in the item. This should trigger
the recalls process so you can allocate the item to Patron B's recall,
however the pop-up box to confirm the recall does not show. This is the
bug.

6) Apply the patch and restart services

7) Check in the item again. Confirm the pop-up box to confirm the recall
shows and you are able to allocate the item to Patron B's recall.
8) Confirm tests pass t/db_dependent/Koha/Item.t

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 22:07:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 21:07:26 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-TGSezZGrjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #40 from Mason James <mtj at kohaaloha.com> ---
(In reply to Tomás Cohen Arazi from comment #39)
> Mason, can you confirm there are no dependency issues?

looks good to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 22:28:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 21:28:47 +0000
Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant
 recall when checking if item can be a waiting recall
In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32129-70-X0ylVN05Jd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch uses the patron
      release notes|                            |category of the patron who
                   |                            |requested the most relevant
                   |                            |recall to check for more
                   |                            |specific circulation rules
                   |                            |relating to recalls. This
                   |                            |ensures that patrons who
                   |                            |are allowed to place
                   |                            |recalls are able to fill
                   |                            |their recalls, especially
                   |                            |when recalls are not
                   |                            |generally available for all
                   |                            |patron categories.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:29:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:29:08 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-goLNiYPIZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #259 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143450&action=edit
Bug 31378: (follow-up) MySQL 8 doens't allow default for longtext

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:38:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:38:42 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-ucl2kG9bHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #16)
> Do we need some form of validation for $return?

100%

The "return" param could either be window.location.pathname +
window.location.search so the Perl could append that to OpacBaseURL, or
"return" could be a full URL, and the Perl replaces the hostname with
OpacBaseURL. 

This is the approach we use in C4::Auth_with_shibboleth, and it's something
I've used elsewhere as well. 

The only downside I see is that it locks you into using the particular
OpacBaseURL you have defined for that virtual host. 

Either way, we definitely need to validate/construct the URL, or else we're
creating this problem:
https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:39:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:39:37 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-0h75ncMm2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #20 from David Cook <dcook at prosentient.com.au> ---
I'd be tempted to mark this as Failed QA until it addresses the security hole,
but I'll leave it up to the RM whether we do that or add a follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:43:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:43:07 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-bkjw2Dxtr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #260 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #209)
> > I notice in the help text that it says "If you plan to use auto register
> > feature, either userid or cardnumber must be present in this mapping". 
> > 
> > That doesn't appear to be true in my testing.
> 
> Any NOT NULL attribute on the borrowers table needs to be mapped for
> auto-register. I don't really understand this one.

Both userid and cardnumber can be null though. Auto-register works without them
being mapped, although perhaps it shouldn't.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:45:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:45:28 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-CrM1lav0uD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #261 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #258)
> Thanks everyone. Any issues you might find, please file follow-up bugs.
> Fixes/enhancements are welcome of course.

Sounds good. I'll give it another test this morning, and open follow-up bugs
for any issues I find. 

Glad to see this one in master in any case!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:53:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:53:29 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-Sw8LddmeA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov  8 23:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 22:57:25 +0000
Subject: [Koha-bugs] [Bug 32136] E-mail testing
In-Reply-To: <bug-32136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32136-70-wXUuZx0i2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32136

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Checking that the domain name is valid and extracting the MX records is easy
enough.

Connecting to the target mail server to try to check if the mailbox exists is
more problematic. 

Depending on the usage you envision, this could be a good use case for a Koha
plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 00:56:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 23:56:53 +0000
Subject: [Koha-bugs] [Bug 32138] New: OIDC client uses backwards default
 mapping
Message-ID: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

            Bug ID: 32138
           Summary: OIDC client uses backwards default mapping
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

The OAuth2 client has a good default mapping, but the OIDC client has the first
name and last name mappings backwards. Must be a mistake from an earlier
iteration.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 00:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 23:59:38 +0000
Subject: [Koha-bugs] [Bug 32139] New: "Update on login" setting not set when
 creating domain from new IdP page
Message-ID: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

            Bug ID: 32139
           Summary: "Update on login" setting not set when creating domain
                    from new IdP page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

When you're creating a new Identity Provider, you're prompted to create a
domain. 

All the settings are saved correctly except "Update on login". It will be set
to "No" even when you select "Yes"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 00:59:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 23:59:58 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-997QtyCK4f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 00:59:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Nov 2022 23:59:59 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-Xn2JAOPwzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:01:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:01:16 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-GkmxGb9k56@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:01:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:01:16 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-ioEhGvGax5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32138


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138
[Bug 32138] OIDC client uses backwards default mapping
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:01:18 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-Aoz0nTu9Fv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:01:18 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-GoW36kwrHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32139


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139
[Bug 32139] "Update on login" setting not set when creating domain from new IdP
page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:14:51 +0000
Subject: [Koha-bugs] [Bug 32140] New: Sessions created using the OIDC/OAuth2
 client use an "api" interface rather than "intranet" or "opac"
Message-ID: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140

            Bug ID: 32140
           Summary: Sessions created using the OIDC/OAuth2 client use an
                    "api" interface rather than "intranet" or "opac"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Bug 31378 provides an OAuth2/OIDC client for authenticating into the Staff
Interface and the OPAC, but the "interface" is always "api".

So far it hasn't caused any obvious problems, but I think we might find small
discrepancies start to rise up - at least in our data.

Where we want or expect to find "opac" or "intranet", instead it will say
"api".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:15:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:15:01 +0000
Subject: [Koha-bugs] [Bug 32140] Sessions created using the OIDC/OAuth2
 client use an "api" interface rather than "intranet" or "opac"
In-Reply-To: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32140-70-zx2xqnoYaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:15:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:15:01 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-grUtHVjv9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32140


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140
[Bug 32140] Sessions created using the OIDC/OAuth2 client use an "api"
interface rather than "intranet" or "opac"
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:18:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:18:22 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-hzIXOyne4J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #262 from David Cook <dcook at prosentient.com.au> ---
I've raised bug 32138 and bug 32139 as follow-ups, but they just relate to some
configuration-related fixes. They should be easy to fix, so I'll write patches
for them shortly. 

When they're fixed, I think that I'll be happy enough with this feature. (I'll
probably raise 1 more follow-up soon but it's a minor UI tweak.)

I also raised bug 32140 because I'm a bit concerned that the "interface" is set
to "api" rather than the relevant "intranet" or "opac", but I haven't observed
any obvious problems with that yet, so... I'm not making it a priority right
now.

--

Thanks again to Agustin and Tomas and everyone else for making this happen. 

I've carried a local customization to enable OIDC auth in Koha since 2014, so
I'll be glad to put that to rest, and just focus on helping make this core OIDC
client the best it can be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:37:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:37:55 +0000
Subject: [Koha-bugs] [Bug 32141] New: Identity provider textboxes too small
 on edit pages
Message-ID: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

            Bug ID: 32141
           Summary: Identity provider textboxes too small on edit pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

When adding an Identity Provider, the textboxes are 75 columns by 10 rows.

But when editing an Identity Provider, the boxes don't have explicit sizing,
and they're too small and always need to be manually resized. 

Not a big drama but it's annoying.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:41:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:41:38 +0000
Subject: [Koha-bugs] [Bug 32141] Identity provider textboxes too small on
 edit pages
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-vBfT3iZcgy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31378


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:41:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:41:38 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-ncjQGJkNtO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32141


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141
[Bug 32141] Identity provider textboxes too small on edit pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:45:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:45:41 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-fBkp61m8mF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:45:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:45:45 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-cE2Z4yBdPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143451&action=edit
Bug 32138: Fix OIDC default mapping

This patch fixes the OIDC default mapping to have the Koha fields on
the left (ie key) and the OIDC standard claim fields on the right (ie value).

1. Apply the patch
2. Go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3. Choose "OIDC" for "Protocol"
4. Click "Add default OIDC mapping"
5. Note the following is displayed:
{
  "email": "email",
  "firstname": "given_name",
  "surname": "family_name"
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:48:23 +0000
Subject: [Koha-bugs] [Bug 32141] Identity provider textboxes too small on
 edit pages
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-PxHkOpk6LR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:54:40 +0000
Subject: [Koha-bugs] [Bug 32142] New: Add HoldFeeMode option "if all items
 are checked out OR the record has at least one hold already"
Message-ID: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

            Bug ID: 32142
           Summary: Add HoldFeeMode option "if all items are checked out
                    OR the record has at least one hold already"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Relates to Bug 31963.

There is an option for the HoldFeeMode system preference "only if all items are
checked out and the record has at least one hold already", except it behaved
more like "if all items are checked out OR the record has at least one hold
already". Bug 31963 fixed this so that the behaviour better matches the
description i.e. it says 'and' so that implies BOTH conditions must be met.

However we now need an option so that the behaviour from before isn't lost,
behaviour like "if all items are checked out or the record has at least one
hold already"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:54:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:54:48 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-Q4C1HmKkPG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:54:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:54:58 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-ihN91Ip9Fv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963
[Bug 31963] Only show hold fee message on OPAC and charge hold fee if
HoldFeeMode conditions are true as described in the system preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 01:54:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 00:54:58 +0000
Subject: [Koha-bugs] [Bug 31963] Only show hold fee message on OPAC and
 charge hold fee if HoldFeeMode conditions are true as described in the
 system preference
In-Reply-To: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31963-70-GKtN5xdUYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32142


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142
[Bug 32142] Add HoldFeeMode option "if all items are checked out OR the record
has at least one hold already"
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 02:31:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 01:31:45 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-Db33pqHWt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143452&action=edit
Bug 32142: Add issued_or_reserved option to HoldFeeMode syspref

Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 02:31:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 01:31:49 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-O0UPE2awvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143453&action=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

Tests and test plan to come.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:03:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:03:36 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-9udn4qOmwR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:03:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:03:41 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-RIyZ7ebTNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143454&action=edit
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on
login"
are all set to "Yes"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:06:54 +0000
Subject: [Koha-bugs] [Bug 32141] New and Edit Identity Provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-iwU8YQJA8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Identity provider textboxes |New and Edit Identity
                   |too small on edit pages     |Provider UIs inconsistent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:13:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:13:51 +0000
Subject: [Koha-bugs] [Bug 32141] New and Edit Identity Provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-fbKfdGIOeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:13:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:13:55 +0000
Subject: [Koha-bugs] [Bug 32141] New and Edit Identity Provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-ZaIehwgLBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143455&action=edit
Bug 32141: Fix textbox formatting on edit IdP screen

This patch makes the textbox have the same number of rows and columns
on the "Edit" page as it does on the "New" page for Identity Providers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:13:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:13:59 +0000
Subject: [Koha-bugs] [Bug 32141] New and Edit Identity Provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-kfy9l1RTBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143456&action=edit
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"

This patch adds missing fieldset legends and titlecases "matchpoint",
so that the "Edit" UI is consistent with the "New" UI for adding
and modifying Identity Providers.

Test plan:
1) Apply patches
2) Go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3) Fill out the fields to add an identity provider
4) Click "Edit" next to the Identity Provider in the list
5) In a new tab, go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
6) Compare the two screens and note that all the labels, inputs, and help text
are the same on both screens.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:14:55 +0000
Subject: [Koha-bugs] [Bug 32133] Streamline OIDC error messages
In-Reply-To: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32133-70-ZPgKl1j4oO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32133

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:18:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:18:27 +0000
Subject: [Koha-bugs] [Bug 31900] Add support for logout from external
 OAuth2/OIDC identity providers
In-Reply-To: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31900-70-m8GjrjKxAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
In order to do this, I think that we'd need to store a reference in the user's
database session to the identity provider that was used when logging in. 

Perhaps "identity_provider: X" would be enough. Or potentially
"identity_provider_logout" with the logout URL, so that we don't have to
re-fetch the "end_session_endpoint" via the well_known_url.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:22:29 +0000
Subject: [Koha-bugs] [Bug 31900] Add support for logout from external
 OAuth2/OIDC identity providers
In-Reply-To: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31900-70-pnx21NR8HF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The logout URL is retrieved during the OIDC warm up, and reused. Alternatively,
it can be set in the config, and the plugin will use it.

And yes, we need to add the idp reference on the session. 

It should also be configurable with 3 options
- No logout
- Automatic logout
- Give the option to logout

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 03:33:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 02:33:24 +0000
Subject: [Koha-bugs] [Bug 31900] Add support for logout from external
 OAuth2/OIDC identity providers
In-Reply-To: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31900-70-YOoiCk0Q3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31900

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Sounds good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 05:47:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 04:47:36 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-9gNoSiIzPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #300 from David Nind <david at davidnind.com> ---
Thanks Martin for looking at things I raised!

1. An update is required to the DBIC Schema Update patch. The DBIC patch failed
- I skipped this patch, and then ran dbic.

2. Displaying "Catalog concerns pending: X". I think I found the cause of the
problem I was experiencing (using KTD and the koha (superliabrarian user)) - a
capital P is required in line 180 for Koha.Preferences in intranet-main.tt (see
2.4). To replicate:
   2.1 Enable OpacCatalogConcerns and add a concern using the OPAC.
       ==> Pending concerns are not displayed on the staff interface home page
   2.2 Display logic and expected results when there are pending concerns and
correct permissions:
       2.2.1 CatalogConcerns and OpacCatalogConcerns: both enabled - displays
       2.2.2 CatalogConcerns and OpacCatalogConcerns: both disabled - doesn't
display
       2.2.3 CatalogConcerns enabled and OpacCatalogConcerns disabled: displays
       2.2.4 CatalogConcerns disabled and OpacCatalogConcerns enabled: displays
   2.3 Currently with the preferences set as per 2.2.4, pending concerns are
not displayed.
   2.4 Edit line 180 of
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt - a capital P required
for Koha.Preference
       . change Koha.preference('OpacCatalogConcerns') to
Koha.Preference('OpacCatalogConcerns')
   2.5 Set preferences as per 2.2.4 - refresh the home page and now pending
concerns are now displayed.

3. Notices - now showing acknowledgement, update and resolved notices for a
patron. Thanks for fixing!

4. Notices - notification to cataloguers still not coming through for me. I'll
put this down to a combination of the email configuration for Gmail that I'm
using and system preferences for email addresses.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 08:06:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 07:06:44 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-ed1bQQoODM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143457&action=edit
Bug 30687 (alternative patch): Always allow to force hold pickup location

If AllowHoldPolicyOverride is enabled and only some pickup locations are
available, you still have the possibility to force one of the others
pickup locations.
But when there are zero pickup locations available, that is not
possible.

This patch change that by always displaying the list of pickup locations
when AllowHoldPolicyOverride is enabled.

Test plan:
1. Apply patch
2. Disable AllowHoldPolicyOverride
3. Create a biblio B with an item I at library A.
4. Configure this library A to not be a pickup location
5. Add a "Default holds policy by item type" for item I type where "Hold
   pickup library match" is "item's home library"
6. Try to place a hold on biblio B
   You should not be able to place a hold because there is no valid
   pickup locations
7. Enable AllowHoldPolicyOverride
8. Try to place a hold on biblio B
   You should now see all valid pickup locations in a dropdown list
   (with an exclamation mark in front of each option) with none selected
   by default
9. Verify you can place a title-level hold and an item-level hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 08:07:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 07:07:10 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-6WXBBsbEoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 08:10:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 07:10:29 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-Mesrzqth6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry chaps, it was late last night when this discussion took place. I've
marked it assigned and will work on it today.

Bit disappointed with myself that I didn't spot this at initial development. 
Still, it should be a trivial follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 08:18:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 07:18:19 +0000
Subject: [Koha-bugs] [Bug 32143] New: backgrouns_jobs fails when special
 charset
Message-ID: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32143

            Bug ID: 32143
           Summary: backgrouns_jobs fails when special charset
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org

We have realized that in koha 22.05 and probably newer koha versions, any
process that runs on background_jobs (specially batchitems= it fails if the
home branch name includes non english charset

example: 'í'
{"interface":"intranet","id":"Odigital","shibboleth":"0","desk_id":null,"branchname":"Enríquez
XXX - Universidad del
XXXX","desk_name":null,"cardnumber":"OREX_DIGITAL","flags":"1","number":"25055","register_name":null,"branch":"UNICARIBE","emailaddress":"","surname":"Digital","firstname":"Orex","register_id":null}

causes 500 error

On logs


worker-output.log:malformed UTF-8 character in JSON string, at character offset
212 (before "\x{fffd}ez ...") at /usr/share/koha/lib/Koha/BackgroundJob.pm line
170.

If we change the name and restart servicess (cache and plack) worka again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 08:34:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 07:34:53 +0000
Subject: [Koha-bugs] [Bug 32144] New: Expand POD for merge_and_replace_with
Message-ID: <bug-32144-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32144

            Bug ID: 32144
           Summary: Expand POD for merge_and_replace_with
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Developer documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

The POD for Koha::Patron::Attributes::merge_and_replace_with() is kind of
minimal:

=head3 merge_and_replace_with

$new_attributes is an arrayref of hashrefs

=cut

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 08:59:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 07:59:11 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-8QUVjgGbNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143458&action=edit
Bug 32030: Remove maintenance file

This script is actually not used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:01:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:01:34 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-9KEyVsxJQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143459&action=edit
Bug 32030: Fix perlcritic errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:05:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:05:01 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-nXiB3Pqr2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143460&action=edit
Bug 32030: Fix Makefile.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:13:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:13:51 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-nxmYVUKBK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143461&action=edit
Bug 32030: Add missing additionalProperties to
/erm/eholdings/local/titles/import

This fixes xt/api.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:17:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:17:43 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-kjqQc7EDZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #46 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Andrew Fuerste-Henry from comment #45)
> The third patch here just failed to apply for me on a sandbox. Not sure what
> might have changed, given how recently you posted it.

That's odd, rebasing or applying patches via bz-tool doesn't give merge
conflict on my test environment. I also asked one our librarians to test this
on sandbox (she used ptfs-europen sandbox) and she had no issues. But in
Bywaters sandbox she got following error when she opened restrictions.pl: 

Template process failed: undef error - The method
Koha::Patron::Restriction::Type->lift_after_payment is not covered by tests!

Seems like schema update problem to me.

Also there seems to be some typos and need for improvement on last patches test
plan. Fixing that asap.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:26:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:26:02 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-gwyt28QCAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143390|0                           |1
        is obsolete|                            |

--- Comment #47 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143462&action=edit
Bug 16223: Add ability to define liftable restrictions

Some libraries debar Patrons at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Patron has paid his/her fines.

This patch adds ability to create restrictions which are lifted after
patron pays ceratain amount of fines.

To test:
1. Apply this patch.
2. Restart your services if needed.
3. Navigate to page restrictions.pl, Administration->Patron restrictions.
=> Note that table has two new colums in it, "Lift after payment?" and "Fee
limit".
4. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
5. Create fees for a patron so they exceed fee limit e.g. 10
6. Add restriction made in step 4. for the patron
7. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:27:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:27:34 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-3FO7an1Tg4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
TestBuilder.t is failing on ERM::User::Roles, it's missing a primary key on
erm_user_roles I think

Can be tested with:

use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
my $m = 'Koha::ERM::UserRoles';
eval "require $m";
my $object = $builder->build_object( { class => $m } ); 
say ref($object);

Should display "Koha::ERM::UserRole", not be empty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:28:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:28:26 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-JjryL1KayQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143463&action=edit
Bug 31699: (follow-up) Protect against unauthorized redirects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:28:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:28:57 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-j98fX4pWqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143378|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143464&action=edit
Bug 31699: Add 'return' option to opac modal login

This patch adds the option to trigger a redirect back to the current
context after successful login using modal logins triggered from various
places in the OPAC.

To make use of this, simply add 'data-return="true"' to the modal trigger link.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:29:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:29:02 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-BV04WAX2vc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143463|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143465&action=edit
Bug 31699: (follow-up) Protect against unauthorized redirects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:29:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:29:06 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-JKkrsUGR89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #48 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Test plan updated. Setting this back to "Needs Signoff" since patches seem to
apply nicely apart from ByWaters sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:29:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:29:26 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-ASIQuGaik5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:36:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:36:04 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-TQeu3TpDxL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143376|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143466&action=edit
Bug 32125: Impliment modal context return on opac-detail.

This patch utilises the generic return option introduced in the previous
patch to prevent lose of context when clicking to login to add a comment
to a biblio.

Test plan
1/ Test that prior to this patch, upon clicking 'Log in to your account
to post a comment' you are redirected to opac-user.pl and thus loose
your context.
2/ Apply the patch
3/ Confirm that a login using the 'Log in to your account to post a
comment' link now redirect immediatly back the correct record and thus
maintains context.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:36:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:36:08 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on opac comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-7NSOevL72f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143377|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143467&action=edit
Bug 32125: Select correct tab on return

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:38:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:38:22 +0000
Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New"
In-Reply-To: <bug-31561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31561-70-bbVzTETHW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561

Andreas Jonsson <andreas.jonsson at kreablo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.jonsson at kreablo.se

--- Comment #7 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
The issue here is that when queuing a background job while a transaction is
active the transaction might not have been committed when the worker process
fetches the job object from the database.

For example C4::AddBiblio, where a background job for indexing ElasticSearch is
initiated from within a call to txn_do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:39:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:39:51 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-K3054FmOsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #31)
> TestBuilder.t is failing on ERM::User::Roles, it's missing a primary key on
> erm_user_roles I think
> 
> Can be tested with:
> 
> use t::lib::TestBuilder;
> my $builder = t::lib::TestBuilder->new;
> my $m = 'Koha::ERM::UserRoles';
> eval "require $m";
> my $object = $builder->build_object( { class => $m } ); 
> say ref($object);
> 
> Should display "Koha::ERM::UserRole", not be empty

I confirm that the following changes fix the test:

ALTER TABLE erm_user_roles ADD COLUMN user_role_id int(11) NOT NULL
AUTO_INCREMENT PRIMARY KEY FIRST;

diff --git a/installer/data/mysql/kohastructure.sql
b/installer/data/mysql/kohastructure.sql
index 54ed708304a..33e2980576b 100644
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -2865,13 +2865,15 @@ CREATE TABLE `erm_agreement_periods` (

 DROP TABLE IF EXISTS `erm_user_roles`;
 CREATE TABLE `erm_user_roles` (
+    `user_role_id` INT(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key',
     `agreement_id` INT(11) NULL COMMENT 'link to the agreement',
     `license_id` INT(11) NULL COMMENT 'link to the license',
     `user_id` INT(11) NOT NULL COMMENT 'link to the user',
     `role` VARCHAR(80) NOT NULL COMMENT 'role of the user',
     CONSTRAINT `erm_user_roles_ibfk_1` FOREIGN KEY (`agreement_id`) REFERENCES
`erm_agreements` (`agreement_id`) ON DELETE CASCADE ON UPDATE CASCADE,
     CONSTRAINT `erm_user_roles_ibfk_2` FOREIGN KEY (`license_id`) REFERENCES
`erm_licenses` (`license_id`) ON DELETE CASCADE ON UPDATE CASCADE,
-    CONSTRAINT `erm_user_roles_ibfk_3` FOREIGN KEY (`user_id`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE
+    CONSTRAINT `erm_user_roles_ibfk_3` FOREIGN KEY (`user_id`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE,
+    PRIMARY KEY(`user_role_id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Then `dbic`.

But the REST API spec and Vue part need to be adjusted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:48:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:48:57 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-hACE70gxdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143464|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143468&action=edit
Bug 31699: Add 'return' option to opac modal login

This patch adds the option to trigger a redirect back to the current
context after successful login using modal logins triggered from various
places in the OPAC.

To make use of this, simply add 'data-return="true"' to the modal trigger link.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 09:49:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 08:49:03 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-JjKnigRaZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143465|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143469&action=edit
Bug 31699: (follow-up) Protect against unauthorized redirects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:11:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:11:16 +0000
Subject: [Koha-bugs] [Bug 32143] backgrouns_jobs fails when special charset
In-Reply-To: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32143-70-H1AbkGz1Sn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32143

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Looks like a duplicate of bug 31351.

*** This bug has been marked as a duplicate of bug 31351 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:11:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:11:16 +0000
Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator
 last name/first name/branch name contains non-ASCII chars
In-Reply-To: <bug-31351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31351-70-nkAMQ4Mo72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 32143 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:11:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:11:59 +0000
Subject: [Koha-bugs] [Bug 32143] backgrouns_jobs fails when special charset
In-Reply-To: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32143-70-09r2Vw564n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32143

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Please upgrade to 22.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:45:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:45:50 +0000
Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
In-Reply-To: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30869-70-4ELnWIXPHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

Pedro Amorim <pjamorim91 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:51:09 +0000
Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
In-Reply-To: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30869-70-el3IbcuPo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

Pedro Amorim <pjamorim91 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:56:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:56:40 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-8J0zs5CE0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It might also hinder a a quick desaster recovery to a different server? At
least something more to think about for backups etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:59:19 +0000
Subject: [Koha-bugs] [Bug 31047] Fix OPACResultsUnavailableGroupingBy system
 preference description
In-Reply-To: <bug-31047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31047-70-p2JX3pFKLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31047

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30880
           Keywords|                            |Academy


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880
[Bug 30880] Expand OPACResultsUnavailableGroupingBy to have a 'branch only'
option
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 10:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 09:59:19 +0000
Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to
 have a 'branch only' option
In-Reply-To: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30880-70-HdsLQKRPQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31047


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31047
[Bug 31047] Fix OPACResultsUnavailableGroupingBy system preference description
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 11:31:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 10:31:52 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-tynTKMOhKI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 143394
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143394
Next

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 11:33:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 10:33:24 +0000
Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit
In-Reply-To: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31895-70-QtAwsTGx6y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please update https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 11:46:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 10:46:39 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-oZJHIdNodr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We've had some issues in the past when adding new modules and them not working
in a package installation (missing paths I think?) - if it hasn't been done
yet, might be nice to verify all is good in a package installation too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 11:53:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 10:53:32 +0000
Subject: [Koha-bugs] [Bug 32125] Implement contextual return on OPAC comments
In-Reply-To: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32125-70-zRTImAYMri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32125

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Implement contextual return |Implement contextual return
                   |on opac comments            |on OPAC comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:18:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:18:29 +0000
Subject: [Koha-bugs] [Bug 32143] background_jobs fails when special charset
In-Reply-To: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32143-70-MZJKzGi7bC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32143

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|backgrouns_jobs fails when  |background_jobs fails when
                   |special charset             |special charset

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:28:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:28:42 +0000
Subject: [Koha-bugs] [Bug 32141] New and Edit Identity Provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-umFh9WN8i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #0)
> When adding an Identity Provider, the textboxes are 75 columns by 10 rows.
> 
> But when editing an Identity Provider, the boxes don't have explicit sizing,
> and they're too small and always need to be manually resized. 
> 
> Not a big drama but it's annoying.

Yeah, I added that on my last follow-up on the bug, and forgot to tweak the
edit page. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:29:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:29:43 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-IrR9W2FtMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|New and Edit Identity       |New and edit identity
                   |Provider UIs inconsistent   |provider UIs inconsistent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:37:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:37:07 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-nbQvl0mxH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:37:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:37:22 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-t9odygcjiN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143322|0                           |1
        is obsolete|                            |

--- Comment #301 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143470&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:37:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:37:32 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-zpX7gw5wK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143323|0                           |1
        is obsolete|                            |

--- Comment #302 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143471&action=edit
Bug 31028: DBIC Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:37:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:37:39 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-uUVqoyHqAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143324|0                           |1
        is obsolete|                            |

--- Comment #303 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143472&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:37:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:37:46 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-uQvwIEgnPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143325|0                           |1
        is obsolete|                            |

--- Comment #304 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143473&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:37:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:37:54 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ZdIxFVUQuj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143326|0                           |1
        is obsolete|                            |

--- Comment #305 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143474&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:01 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-EvDUafBgcK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143327|0                           |1
        is obsolete|                            |

--- Comment #306 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143475&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:09 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-TxCEgOU3Jx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143328|0                           |1
        is obsolete|                            |

--- Comment #307 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143476&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:18 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-Ufi6UsOUiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143329|0                           |1
        is obsolete|                            |

--- Comment #308 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143477&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:29 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-2DRnISFuWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143330|0                           |1
        is obsolete|                            |

--- Comment #309 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143478&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:38 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-IhqtKaW50Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143331|0                           |1
        is obsolete|                            |

--- Comment #310 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143479&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional cataloger notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CatalogerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CatalogerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:45 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ZNyUDwiFhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143332|0                           |1
        is obsolete|                            |

--- Comment #311 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143480&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:38:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:38:53 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-17i6YI30wk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143333|0                           |1
        is obsolete|                            |

--- Comment #312 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143481&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:00 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-L98WwML4iq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143334|0                           |1
        is obsolete|                            |

--- Comment #313 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143482&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:12 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-7QAnZuYnJC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143335|0                           |1
        is obsolete|                            |

--- Comment #314 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143483&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:19 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-mMtqkxhbhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143336|0                           |1
        is obsolete|                            |

--- Comment #315 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143484&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:36 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ziNbJ5HaTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143337|0                           |1
        is obsolete|                            |

--- Comment #316 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143485&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:44 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-brOT96aUji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143338|0                           |1
        is obsolete|                            |

--- Comment #317 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143486&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:51 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-zUhmhMKmt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143339|0                           |1
        is obsolete|                            |

--- Comment #318 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143487&action=edit
Bug 31028: Add feedback to the patron on submission

This patch adds a success alert box when a patron submits a concern
sucessfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:39:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:39:58 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-LTGC2QxcDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143340|0                           |1
        is obsolete|                            |

--- Comment #319 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143488&action=edit
Bug 31028: (follow-up) Fix permissions names

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:40:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:40:07 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-CcxYKJtard@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143341|0                           |1
        is obsolete|                            |

--- Comment #320 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143489&action=edit
Bug 31028: (follow-up) Add <br> to notices

This should resolve the lack of linebreaks in resulting emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 12:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 11:40:16 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-zv69UkMj3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #321 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143490&action=edit
Bug 31028: (follow-up) Fix template whitespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:06:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:06:04 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-qQMqjHKren@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:08:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:08:29 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-AnnJHDLSFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:08:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:08:34 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-j4fpUmfXsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143185|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143492&action=edit
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a
date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput:
true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:08:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:08:42 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-qDMVcAScoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #322 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Wow master is moving so fast..

Fixed the DBIC schema issue, thanks.

Great spot of `p` vs `P`.. fixed now, thanks.

4. Notices - notification to cataloguers still not coming through for me. I'll
put this down to a combination of the email configuration for Gmail that I'm
using and system preferences for email addresses.

This got me to dig a little further.. I found a regression from one of the
rebases.. 'catalog' vs 'catalogue' module name.. sorted now.

Whitespace in emails in the database is still an issue, but as they're HTML in
the email client they should appear OK I believe. (I'm working on removing the
superflous whitespace from the includes in a new bug now)

Thanks again for all the testing David,

Martin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:11:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:11:48 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-IM5mgVvMTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:12:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:12:01 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-MCXo2L6zlx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143138|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143493&action=edit
Bug 31818: Enable table elements in keyboard shortcuts popover

This patch updates the whitelist for the popover to ensrue our shortcuts table
displays

To test:
1 - Open the advanced cataloging editor
2 - Click 'Keyboard shortcuts'
3 - Is empty, be sad
4 - Apply patch
5 - Reload
6 - Click it again
7 - Shortcuts!

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:12:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:12:19 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-0NbV7qlQPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:13:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:13:08 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-LpjPFevUtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:13:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:13:19 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-xgkmsswMIx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143444|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143494&action=edit
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:14:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:14:59 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-9yz3bWPtyQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

--- Comment #5 from David Nind <david at davidnind.com> ---
(In reply to Martin Renvoize from comment #3)
> I can't entirely remember if there was anything else here.. could you verify
> that it was just the header underline we were concerned with David?

I think that was it - button issue (light gray background) was fixed on another
bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:16:04 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-5zepsIBwvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:16:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:16:31 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-D4t5uDW7bm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143298|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143495&action=edit
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:19:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:19:51 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-lMlmFb4Wt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:23:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:23:56 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-50CBPAAFz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:24:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:24:01 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-4ym9zz7Vvi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143139|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143496&action=edit
Bug 31271: Preselect previous search index

This patch passes the constructed value of the preselect to search_indexes.inc

To test:
1 - Perform an advanced search, making sure to select different indexes
2 - Click 'Edit search' on results page
3 - Confirm index selections are preselected
4 - Enable  IntranetCatalogSearchPulldown
5 - Do a search form the top bar using an index
6 - Confirm 'Edit search' correctly popluates the chosen index

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:24:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:24:32 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-aS9WLrQqnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:28:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:28:24 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-G0LzuRJrmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #263 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Error while loading /etc/koha/plack.psgi: Can't load application from file
"/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm in
@INC 

Should we mark this as dependency for Mason please?

apt-get install libmojolicious-plugin-oauth2-perl
apt-get install libmojolicious-plugin-renderfile-perl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:29:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:29:26 +0000
Subject: [Koha-bugs] [Bug 32145] New: Cancel hold modal confirm/submit
 button has a white background and text can't be read
Message-ID: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

            Bug ID: 32145
           Summary: Cancel hold modal confirm/submit button has a white
                    background and text can't be read
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 143497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143497&action=edit
Screenshot - cancel hold modal window (button backgroudn white)

Confirm/submit buttons for when cancelling a hold:
- a white background
- when hovered over, the button text is white, background is grey, border is
red

This makes it hard to read in both states.

See screenshot attached.

To replicate:
1. Place a hold on a record.
2. From the holds section, select the hold and click the delete icon.
3. Note that the "Confirm cancellation" button:
   . has a white background
   . when hovered over, the button text is white, background is grey, border is
red

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:40:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:40:37 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-eBirBD9D4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #264 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hola, Marcel!

(In reply to Marcel de Rooy from comment #263)
> Error while loading /etc/koha/plack.psgi: Can't load application from file
> "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm
> in @INC 
> 
> Should we mark this as dependency for Mason please?
> 
> apt-get install libmojolicious-plugin-oauth2-perl
> apt-get install libmojolicious-plugin-renderfile-perl

Dependencies are packaged (by Mason) and already present on the latest KTD
images. Thanks for reporting, I will mention it on the list for other devs to
be aware!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:41:19 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-BGnV8VYlte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> 1. Delete confirmation messages: there are two styles, assuming there will
> be bugs to fix these at some stage to make consistent:
>    - Patron restrictions - "new" style (confirmation message in a page
> section div)
>    - Patron attribute types - "old" yellow style (yellow box and asking you
> to confirm deletion)
>    - Cities and towns - "old" yellow style

I think it would be nice to have a separate bug about these. We should tackle
them at some point for sure, just a lot of things to go through right now.


> 2. Patron restrictions: Delete - 'Delete this restriction' and cancel
> buttons are in the page section div.

Bit confused about this one. Aren't they all in the table?


> 3. Plugins: has the tools sidebar menu, breadcrumb, and page title - if
> there is not a bug for that already, then I can log one.

I believe that's because you can also access some plugins from the tools page.
Could you file separately please?


> Other notes:
> 
> 1. Plugins: installed three plugins - BiblbioCommons connector plugin for
> Koha, Example Kitchen-Sink Plugin, and SMS::Send::LinkMobility::Driver.
> Assuming it will be up to the plugin author to update any pages for their
> plugin, for example, the kitchen sink plugin configure section.
> 
> 2. Circulation and fines rules: 
>    - before patch applied any before any changes made: 0 errors, 73 warnings
> (using HTML Validator for Firefox - https://www.gueury.com/mozilla/)
>    - after applying patch: 0 errors, 54 warnings
>    - not sure of the "best" tool to do this or where the threshold is for
> addressing any issues

On this page the h2 headings are outside the page-sections, but for the
advanced search and on other pages they are inside. I think this is already a
good change, but we really need to write our style guide about these kinds of
things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:42:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:42:44 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-DxO2f56S1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:42:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:42:54 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-BsRi3R1CY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143260|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143498&action=edit
Bug 32028: Add page-section to various admin pages

This patch adds the page section to div to the following administration pages:

admin/cash_registers.tt
admin/cities.tt
admin/credit_types.tt
admin/debit_types.tt
admin/patron-attr-types.tt
admin/restrictions.tt
plugins/plugins-home.tt

To test go the following pages and make sure everything looks good:

Administration > Cash registers. You must enable the sys pref
'UseCashRegisters'
Administration > Cities and towns.
Administration > Credit types
Administration > Debit types
Administration > Patron restrictions
Adminstration > Patron attribute types
Administration > Manage plugins

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=32082

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:43:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:43:06 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-1hgz3xSAvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143261|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143499&action=edit
Bug 32028: Add page-section to smart-rules.tt and fix markup errors

To test:
1. Apply patch
2. Go to Adminstration > Circulation and fine rules
3. Look at the page-section added and make sure each looks good.
4. Use an HTML validator to check and make sure the HTML looks good.

Note: There are indentation changes and some fixes to bad markup ( stray tags,
etc ).

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=32082

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:49:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:49:58 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-baOxZegUZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-ups pushed to master. Please file a new bug for the outstanding issue
with TestBuilder.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:51:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:51:17 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-bg9IhEp8H5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:52:46 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-NKCZloBLEe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143500&action=edit
Bug 32028: (follow-up) Improve smart rules formatting

I correct the indenting here, so remember to diff ignoring whitespace ;)

I remove some of the page-section divs introduced by the previous patch
and instead add the page-section class to existing 'container' divs.
This brings the page-sections more in line with elsewhere in the
codebase.

I also update the 'h3' headings to 'h2' as we were somehow skipping that
heading level page wide.

Finally, I break up the top section more, using bg-info for the top
block of instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:53:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:53:12 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-gdunDtE1s6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:53:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:53:19 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-ZGObiMccRj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143446|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143501&action=edit
Bug 32004: Match font size for dropdowns to header

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:54:12 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-H3P4j6k8WU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #1)
> Created attachment 143262 [details]
> Overlay of previous version and current version
> 
> Overlaying the two versions it looks to me like the new version is, if
> anything, slightly larger.

Maybe it's the different font, it just looks still all a little smaller to me
than before, but I think this patch is a good improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:54:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:54:21 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-0CaAJdworR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #35 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 143502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143502&action=edit
Bug 32030: Add missing primary key to erm_user_roles table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:54:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:54:56 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-B1YXWICuaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:58:43 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-cpQ2V3HL4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143500|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143503&action=edit
Bug 32028: (follow-up) Improve smart rules formatting

I correct the indenting here, so remember to diff ignoring whitespace ;)

I remove some of the page-section divs introduced by the previous patch
and instead replace the 'container' classes with the new 'page-section
class on existing divs.

This brings the page-sections more in line with elsewhere in the
codebase.

I also update the 'h3' headings to 'h2' as we were somehow skipping that
heading level page wide and update the final 'h4' heading to 'h2' to
match the other section headings appropriately.

Finally, I break up the top section more, using bg-info for the top
block of instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:58:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:58:56 +0000
Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/orderreceive.pl
In-Reply-To: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22405-70-4U7ojiXhkl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:59:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:59:48 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-MUElBhio51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143504&action=edit
Bug 12758: (QA follow-up) Enhance POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 13:59:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 12:59:58 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-eIUQo81dq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Katrin and I clashed.. just as I was assigning it to myself for QA she passed
it ;).

Please check my final followup Katrin.. I think it improves the smart rules a
fair bit ;P

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:04:48 +0000
Subject: [Koha-bugs] [Bug 32146] New: Add page-section to course reserves
Message-ID: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

            Bug ID: 32146
           Summary: Add page-section to course reserves
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

In staff, we need some page-sectioning done for:

* List of course reserves
* Reserves detail page


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:04:48 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-RaSc7PzY4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32146


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146
[Bug 32146] Add page-section to course reserves
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:04:48 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-zKT89XUvqd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32146


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146
[Bug 32146] Add page-section to course reserves
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:24 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-QZ0aMLXC29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:29 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-7jZlCNNwsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:35 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-3E8BxcXmw8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:39 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-0FSA58wgRg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:48 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-tNsfet85Th@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:55 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-DcaOOm5G3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:06:59 +0000
Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
In-Reply-To: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31894-70-f5SkT1Ku7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:07 +0000
Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
In-Reply-To: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31894-70-1xErjS6eWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:09 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-V3rT8ScDLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:13 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-AjYm98exbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:17 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-UvMIek8Duq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:21 +0000
Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC
In-Reply-To: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32111-70-975VzwoC8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:25 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-DAEf8eUTNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:07:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:07:27 +0000
Subject: [Koha-bugs] [Bug 32114] Template error in OPAC search results RSS
In-Reply-To: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32114-70-5oJHS0gP1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32114

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:09:04 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-CVlZ1ww5cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
File not found : js/vue/dist/main.js at
/usr/share/koha/Koha/Template/Plugin/Asset.pm line 84.

Does this module not work on a dev install ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:10:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:10:21 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-o40sxwDoTO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #36)
> File not found : js/vue/dist/main.js at
> /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84.
> 
> Does this module not work on a dev install ?

This makes a whole block on the main page disappear..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:10:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:10:53 +0000
Subject: [Koha-bugs] [Bug 31894] Extend Hold hooks with more actions
In-Reply-To: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31894-70-Dk4MGYeuQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please update documentation on
https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:11:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:11:27 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-0L4gM9WJwi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:11:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:11:35 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-MqTRQQdzKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143301|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143505&action=edit
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:14:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:14:31 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for holds
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-lFVyy9nnET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Laura <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #58 from Laura <Laura.escamilla at bywatersolutions.com> ---
Signed-off-by: Laura Escamilla <lauraescamilla at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:18:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:18:31 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-BVEjnMbxeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143498|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143506&action=edit
Bug 32028: Add page-section to various admin pages

This patch adds the page section to div to the following administration pages:

admin/cash_registers.tt
admin/cities.tt
admin/credit_types.tt
admin/debit_types.tt
admin/patron-attr-types.tt
admin/restrictions.tt
plugins/plugins-home.tt

To test go the following pages and make sure everything looks good:

Administration > Cash registers. You must enable the sys pref
'UseCashRegisters'
Administration > Cities and towns.
Administration > Credit types
Administration > Debit types
Administration > Patron restrictions
Adminstration > Patron attribute types
Administration > Manage plugins

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=32082

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:18:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:18:38 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-KeBpTQqWEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143499|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143507&action=edit
Bug 32028: Add page-section to smart-rules.tt and fix markup errors

To test:
1. Apply patch
2. Go to Adminstration > Circulation and fine rules
3. Look at the page-section added and make sure each looks good.
4. Use an HTML validator to check and make sure the HTML looks good.

Note: There are indentation changes and some fixes to bad markup ( stray tags,
etc ).

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=32082

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:18:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:18:46 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-NrjMWdtbiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143503|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143508&action=edit
Bug 32028: (follow-up) Improve smart rules formatting

I correct the indenting here, so remember to diff ignoring whitespace ;)

I remove some of the page-section divs introduced by the previous patch
and instead replace the 'container' classes with the new 'page-section
class on existing divs.

This brings the page-sections more in line with elsewhere in the
codebase.

I also update the 'h3' headings to 'h2' as we were somehow skipping that
heading level page wide and update the final 'h4' heading to 'h2' to
match the other section headings appropriately.

Finally, I break up the top section more, using bg-info for the top
block of instructions.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:19:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:19:39 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-GAU4sITjjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:20:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:20:38 +0000
Subject: [Koha-bugs] [Bug 32147] New: Capitalization: E-Ressource management
 should be E-ressource management
Message-ID: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

            Bug ID: 32147
           Summary: Capitalization: E-Ressource management should be
                    E-ressource management
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

This is according to our capitalization rules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:21:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:21:56 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-glksNkhqnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Well, probably this needs a lot of additional configuration and I dont know
where to find all that stuff.. In short, cant test it without documentation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:22:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:22:36 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Ressource management
 should be E-ressource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-xQR9IRBJ1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:22:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:22:36 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-zuYu2uUH2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32147


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147
[Bug 32147] Capitalization: E-Ressource management should be E-ressource
management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:22:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:22:50 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Ressource management
 should be E-ressource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-XhtPdAFvav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:23:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:23:14 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Ressource management
 should be E-ressource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-oZdAhS1QA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:24:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:24:19 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-DpLEXxPchX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Capitalization: E-Ressource |Capitalization: E-Resource
                   |management should be        |management should be
                   |E-ressource management      |E-resource management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:25:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:25:05 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-aC6lJKjsIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143509&action=edit
Bug 32028: (follow-up) Fix headings levels

This patch corrects the headings levels on cash_registers,
patron-attr-types and restrictions admin pages.

We also move the h2 headings inside the page-section div as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:28:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:28:58 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-dTe2B6cLcq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
https://www.dictionary.com/browse/e-

It doesn't have e-resource, but it has other examples of e- and in all those
cases the second word is not capitalized.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:32:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:32:31 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-uxZ0s2TWc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #36)
> File not found : js/vue/dist/main.js at
> /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84.
> 
> Does this module not work on a dev install ?

`yarn build_js` will generate it
Should have been done by Tomas, as we agreed on...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:33:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:33:18 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-VGJzOG0Gf3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #38)
> Well, probably this needs a lot of additional configuration and I dont know
> where to find all that stuff.. In short, cant test it without documentation.

See comment 26, and kohadocs repo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:35:24 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-ZFqarrGGdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:39:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:39:45 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-MDK9hTxeTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:39:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:39:50 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-G4OUP4Oydd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143510&action=edit
Bug 32147: Capitalization: E-Resource management

When e- is used as prefix, the second word should not
be capitalized.

To test:
* Best to check the code... but:
* All E-Resource should now read E-resource, as on:
  * Koha start page
  * Breadcrumbs in the ERM module
  * Descriptions of AV categories...

I chose to update the sysprefs.sql and the DB update as well
as this hasn't been released yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:46:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:46:39 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-Ia3g120Uxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143510|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143511&action=edit
Bug 32147: Capitalization: E-Resource management

When e- is used as prefix, the second word should not
be capitalized. And when e-resource-management is used
as part of a sentence, the e shouldn't be either.
See: e-mail, e-commerce. etc.

To test:
* Best to check the code... but:
* All E-Resource should now read e-resource or E-resource, as on:
  * Koha start page
  * Breadcrumbs in the ERM module
  * Descriptions of AV categories...

I chose to update the sysprefs.sql and the DB update as well
as this hasn't been released yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:51:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:51:06 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-Kl5MHCvjk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143501|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143512&action=edit
Bug 32004: Match font size for dropdowns to header

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:51:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:51:11 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-Ay720a6Gja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143513&action=edit
Bug 32004: (follow-up) Increase padding between menu items

I think the increased font size means we need slightly more padding
between items for good legibility.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:51:25 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-rGeUWlLwYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:51:29 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-CJKFZkQYAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143342|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143514&action=edit
Bug 32088: Consistent classes for primary buttons: Patron card creator

This patch makes changes the button markup in patron card creator
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view patron card creator pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:51:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:51:53 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-sMPlCyqb4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:53:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:53:29 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-LkCQHNdxge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks Owen :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:58:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:58:32 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-79SVh3dMzC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:58:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:58:37 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-A7MJ68WZUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143380|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143515&action=edit
Bug 31414: Set focus to name in additional fields.

Focus is set to name on additional fields on
administation add fields.

Test plan
1. Go to administation and manange additional
fields.
2. If you then add field the focus should
automatically go to the field name.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 14:58:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 13:58:46 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-1kASJs2IKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143516&action=edit
Bug 31414: (QA follow-up) Re-add required class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:06:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:06:01 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-5WGKdD9XZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Must admit.. I don't know what the standard terms are here really.. 

I feel like it's an abbreviation and should be 'ERM' or 'Electronic resource
management'.. 'E-resource management' feels strange to look at.. 'e-resource
management' not so strange, but doesn't capitalise well for sentence case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:06:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:06:28 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-RJVLWY7AL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
https://en.wikipedia.org/wiki/Electronic_resource_management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:07:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:07:53 +0000
Subject: [Koha-bugs] [Bug 32148] New: Buttons must inherit Bootstrap size
 classes
Message-ID: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

            Bug ID: 32148
           Summary: Buttons must inherit Bootstrap size classes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32044

The global changes to button styles made by Bug 32044 created an issue with
button styling: The default font size and padding changes have the side-effect
of overriding Bootstrap's button size classes: btn-sm, btn-xs, etc.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044
[Bug 32044] Yellow buttons are styled differently in different spots
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:07:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:07:53 +0000
Subject: [Koha-bugs] [Bug 32044] Yellow buttons are styled differently in
 different spots
In-Reply-To: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32044-70-vRzE5MxeRH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32148


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148
[Bug 32148] Buttons must inherit Bootstrap size classes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:20:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:20:38 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-RWSndLH1hx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:20:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:20:42 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-iIMDSYUzSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143517&action=edit
Bug 32148: Buttons must inherit Bootstrap size classes

This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.

To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:

- Circulation -> Check out:
  - The "Check out" button, the "Show checkouts" button, Renew buttons
    in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:28:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:28:37 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-FoPL7yyB7Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
While each element can have only one CSS id, classes can be repeated separated
by space :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:31:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:31:23 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-PZQEluQhed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Any chance of sharing those patches David?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 15:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 14:32:17 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-7hVk1rCIqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I tried changing the button on the start page to Electronic resource
management, but it adds a line break. Changing this might require a bit more
than a string change then. 

I like ERM and Eletronic resource management, but I really want to have a
solution before we reach string freeze tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:00:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:00:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Ee2acj2umy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This new feature adds the   |This new feature adds the
      release notes|ability to create item      |ability to create item
                   |bundles for loans.
         |bundles for loans.
                   |
                           |
                   |One can                     |One can
                   |create a new collection     |create a new collection
                   |level biblio record and add |level biblio record and add
                   |items to it as normal.      |items to it as normal.
                   |Those items can then be     |Those items can then be
                   |converted to bundles by     |converted to bundles by
                   |adding existing items to    |adding existing items to
                   |them using their barcodes.  |them using their barcodes.
                   |The items will be marked as |The items will be marked as
                   |'not for loan' in their     |'not for loan' in their
                   |original parent records.
   |original parent records.
                   |                            |
                   |Bundle items follow normal  |Bundle items follow normal
                   |circulation rules for       |circulation rules for
                   |checkout. Upon check-in a   |checkout. Upon check-in a
                   |new verification step is    |new verification step is
                   |added where by the          |added where by the
                   |librarian is expected to    |librarian is expected to
                   |scan each constituent item  |scan each constituent item
                   |to varify it's presence in  |to varify it's presence in
                   |the bundle. If an item is   |the bundle. If an item is
                   |missing from the bundle it  |missing from the bundle it
                   |is marked as lost with a    |is marked as lost with a
                   |new lost - Missing from     |new lost - Missing from
                   |bundle value.  If an item   |bundle value.  If an item
                   |is found that is not        |is found that is not
                   |expected to be in the       |expected to be in the
                   |bundle it it highlighted to |bundle it it highlighted to
                   |the librarian after         |the librarian after
                   |check-in so it can be       |check-in so it can be
                   |placed to one side.         |placed to one side.
                   |                            |
                   |                            |**Sponsored by** *PTFS
                   |                            |Europe*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:02:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:02:24 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-QdjN3wVn2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:02:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:02:28 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-Ckv4mt4ehQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142950|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143518&action=edit
Bug 32071: Consistent classes for primary buttons: Catalog

This patch makes changes the button markup in Catalog
templates -- including the Cart -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

Edit: This revised patch changes the button styles on the search history
page to make them more consistent with buttons in similar interfaces
(see catalog search results).

The patch also adds Bootstrap size classes to the item detail page and
removes some global CSS which targeted buttons on that page.

To test, apply the patch and view pages the catalog to confirm
that everything looks correct. In most cases there are no visible
changes.

- Advanced search: The main search button at the top
- Search results: The "Search within results" submit button
- Bibliographic detail page: This change is to a hidden button. This
  section can be removed in a separate bug.
- Bibliographic detail page -> Items: Various "Update" and "Set status"
  buttons. Note that the alignment of buttons has not changed in the
  redesign.
- Item search: The main search button at the top
- Search history (from the logged-in user's menu in the top right):
  "Delete" buttons in each section
   - Catalog -- Current and previous sessions
   - Authority -- Current and previous sessions
- In the Cart popup window, click "Send." In the resulting popup, the
  "Send button.
- The template basket/downloadcart.tt has been modified but I think the
  template might be unused.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:02:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:02:43 +0000
Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed
In-Reply-To: <bug-25936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25936-70-BTLva1eoHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|When the system preference  |When the system preference
      release notes|NotifyPasswordChange is set |NotifyPasswordChange is set
                   |to 'Notify' a notification  |to 'Notify' a notification
                   |will be sent to the user    |will be sent to the user
                   |when their password is      |when their password is
                   |changed. The new            |changed. The new
                   |notification uses the       |notification uses the
                   |letter code PASSCHANGE.     |letter code PASSCHANGE.
                   |                            |
                   |                            |**Sponsored by** *PTFS
                   |                            |Europe*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:02:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:02:52 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-mq7fDbiXM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32071


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071
[Bug 32071] Consistent classes for primary buttons: Catalog
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:02:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:02:52 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-YZ64LEC5yh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32148


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148
[Bug 32148] Buttons must inherit Bootstrap size classes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:03:53 +0000
Subject: [Koha-bugs] [Bug 32149] New: Item shelflocation in OPAC detail,
 if value is not in authorized values
Message-ID: <bug-32149-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32149

            Bug ID: 32149
           Summary: Item shelflocation in OPAC detail, if value is not in
                    authorized values
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: viliam.polonec at snk.sk
        QA Contact: testopia at bugs.koha-community.org

There is no shelf location information in OPAC, if value is not in authorized
values, like in staff interface. (also ccode)
It will be fine to get this info

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:04:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:04:05 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-zx8FeziU8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This patch adds a new       |This patch adds a new
      release notes|system preference           |system preference
                   |"OverdueNoticeFrom" that    |"OverdueNoticeFrom" that
                   |overrides the --frombranch  |overrides the --frombranch
                   |parameter of the            |parameter of the
                   |overdue_notices.pl cronjob. |overdue_notices.pl cronjob.
                   |
                           |
                   |
                           |
                   |This allows systems         |This allows systems
                   |librarians the option to    |librarians the option to
                   |pick which address to use   |pick which address to use
                   |for overdues notices.
      |for overdues notices.
                   |
                           |
                   |The                         |The
                   |default value is            |default value is
                   |"command-line option",      |"command-line option",
                   |meaning if there is a       |meaning if there is a
                   |branch specified in the     |branch specified in the
                   |cronjob, the behavior will  |cronjob, the behavior will
                   |not change.                 |not change.
                   |                            |
                   |                            |**Sponsored
                   |                            |by** *PTFS Europe*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:05:35 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-hRJWExPm7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This fixes the formatting   |This fixes the formatting
      release notes|of dates on the cashup      |of dates on the cashup
                   |summary modal (it uses the  |summary modal (it uses the
                   |existing $datetime JS       |existing $datetime JS
                   |include).                   |include).
                   |                            |
                   |                            |**Sponsored by**
                   |                            |*PTFS Europe*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:07:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:07:57 +0000
Subject: [Koha-bugs] [Bug 30484] Interlibrary loans should have the ability
 to send notices based on request supplier updates
In-Reply-To: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30484-70-njay12lHev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This interlibrary loans
      release notes|                            |module enhancement allows
                   |                            |backend developers to
                   |                            |trigger notices to patrons
                   |                            |upon certain backend
                   |                            |actions.
                   |                            |
                   |                            |**Sponsored by**
                   |                            |*PTFS Europe*

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:09:14 +0000
Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be
 definable at the credit_type/debit_type level
In-Reply-To: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26689-70-NicAhfJuyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement allows end |**Sponsored by** *PTFS
      release notes|users to define their       |Europe*
                   |account notices (print      |
                   |receipt and print invoice   |This enhancement
                   |for example) at the debit   |allows end users to define
                   |type and credit type level. |their account notices
                   |
                           |(print receipt and print
                   |Simply add a new notice     |invoice for example) at the
                   |with code                   |debit type and credit type
                   |'DEBIT_your_debit_type_code |level.
                   |' or                        |
                   |'CREDIT_your_credit_type_co |Simply add a new
                   |de' to the notices and we   |notice with code
                   |will pick that over the     |'DEBIT_your_debit_type_code
                   |existing default            |' or
                   |'ACCOUNT_DEBIT' and         |'CREDIT_your_credit_type_co
                   |'ACCOUNT_CREDIT' notices.   |de' to the notices and we
                   |                            |will pick that over the
                   |                            |existing default
                   |                            |'ACCOUNT_DEBIT' and
                   |                            |'ACCOUNT_CREDIT' notices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:09:31 +0000
Subject: [Koha-bugs] [Bug 32150] New: Wide character in print at
 /usr/share/koha/opac/opac-downloadshelf.pl line 138.
Message-ID: <bug-32150-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32150

            Bug ID: 32150
           Summary: Wide character in print at
                    /usr/share/koha/opac/opac-downloadshelf.pl line 138.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Just like bug 32009.
RIS is encoded in utf8. But MARC and BibTex are not.

L138         print $output;
This is 21.11.

L137 in master at this moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:11:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:11:26 +0000
Subject: [Koha-bugs] [Bug 32151] New: [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
Message-ID: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

            Bug ID: 32151
           Summary: [WARN] Use of uninitialized value in numeric ne (!=)
                    at C4/Ris.pm line 834.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Line 834 (21.11) shows the ugly:
    if ($kwfield != undef) {

Master same line.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:16:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:16:26 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-o2G9WTzkrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:16:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:16:31 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-SyJ7JG17q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143519&action=edit
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris

We should not write:
    if ($kwfield != undef) {

Test plan:
Pick record with UTF8 chars.
Download via cart or shelf in RIS format.
Check your logs.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:17:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:17:23 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-dafJSAndhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Trivial oneliner. Self SO

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:20:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:20:10 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-k0jTPM4GeV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Disclaimer: as you all know, English is not my first language, so take my
comments accordingly.

Personally, I like the long form better; Electronic resource management.

Also, I've always seen the small e when used for "electronic", like e-Book or
eBook, except where the word has entered regular vocabulary, like Email.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:24:31 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-nxfpVY5yhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:29:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:29:17 +0000
Subject: [Koha-bugs] [Bug 32136] E-mail testing
In-Reply-To: <bug-32136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32136-70-0E2hwl0VbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32136

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:29:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:29:21 +0000
Subject: [Koha-bugs] [Bug 32137] Resend notices with updated info
In-Reply-To: <bug-32137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32137-70-rTqg6uvAFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:29:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:29:54 +0000
Subject: [Koha-bugs] [Bug 32137] Resend notices with updated info
In-Reply-To: <bug-32137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32137-70-7cWbq3xleV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

--- Comment #1 from George Williams (NEKLS) <george at nekls.org> ---
Being able to re-send a message with updated contact information would be
awesome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:34:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:34:34 +0000
Subject: [Koha-bugs] [Bug 32152] New: Add DataTables to suggestions table at
 /members/purchase-suggestions.pl
Message-ID: <bug-32152-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32152

            Bug ID: 32152
           Summary: Add DataTables to suggestions table at
                    /members/purchase-suggestions.pl
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jrobb at sekls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Staff would like to be able to filter/search the table of suggestions for a
specific patron at /members/purchase-suggestions.pl. It would also be nice if
the table were paginated as the page is very long for patrons with many
requests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:34:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:34:47 +0000
Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
 adding on order item to existing record
In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20817-70-jYhElAXdEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle at bywatersolutions.com   |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:35:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:35:00 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-aFVnOoi62j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:44:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:44:17 +0000
Subject: [Koha-bugs] [Bug 32028] Add page-section to various administration
 pages (part 2)
In-Reply-To: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32028-70-wPtgLiO16o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> ---
Cait and Martin, thanks for the follow-ups!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:48:36 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-qJWozg45De@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 16:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 15:48:40 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-waKhL0PRnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143520&action=edit
Bug 32146: Add page-section to course reserves

This patch adds a "page-section" wrapping div to two Course Reserves
templates.

Note: This patch contains indentation changes.

To test, apply the patch and go to Course Reserves.

 - The table of course reserves should appear in a white section.
 - View the details of a course: There should be a white section for the
   list of details at the top and another for the table of reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:09:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:09:36 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-8igkPcezYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
There is a space missing in the description of the ERM_AGREEMENT_LICENSE_STATUS
authorized value category.

Statuses of the licenses' agreements(e-resource management module)

Should be

Statuses of the licenses' agreements (e-resource management module)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:11:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:11:04 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-72HgY2K6qE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:18:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:18:36 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-mbavPtVKz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:18:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:18:41 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-g1IpfLFRmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143521&action=edit
Bug 31823: Add page-section to uncertain prices page (acq)

This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions

Note: This patch contains indentation changes.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
  list of orders with uncertain prices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:27 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-05OUMZYpE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff Client                |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:28 +0000
Subject: [Koha-bugs] [Bug 31932] The basket summary page template needs a
 cleanup
In-Reply-To: <bug-31932-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31932-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31932-70-oKduF8T2af@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff Client                |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:28 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to items tab (cat)
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-JD223JOVl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff Client                |Templates

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:29 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-gX9Vr3P9fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:29 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-A4JKdu6Rff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff Client                |Templates

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:29 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-NfmXHWdOH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:30 +0000
Subject: [Koha-bugs] [Bug 31820] Add page-section to order receive page (acq)
In-Reply-To: <bug-31820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31820-70-zwp7hTJOdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:30 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-K2vbwyBHob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:20:30 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-7YmI3KaF0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:21:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:21:31 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-yopC2NnSi1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:23:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:23:06 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-lZtxBoqfgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143522&action=edit
Bug 32147: (follow-up) Fix missing space

One of the AV category descriptions was missing a space
before the (e-resource management).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:26:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:26:21 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-3oGGlKTnfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:33:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:33:36 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-Ic9tTcqYMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:33:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:33:40 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-ZmwIKOM52A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143454|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143523&action=edit
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on
login"
are all set to "Yes"

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:34:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:34:09 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-BKQVlEfL1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:35:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:35:59 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-7npLI3OSPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:36:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:36:03 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-GHqmPr9qfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143524&action=edit
Bug 31828: Add page-section to list of open invoices on receive shipment page
(acq)

This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.

This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
  section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
  fields -> Invoices) there should be a third section showing those
  fields.
- With no additional fields defined you should not see an empty
  fieldset.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:37:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:37:20 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-xEf4EaLQE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:37:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:37:24 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-uMI1KadUIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143456|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:37:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:37:29 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-OA07MKZ6mM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143455|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:38:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:38:06 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-x2CC4JDlob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:39:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:39:13 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-62XpLiCXVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143525&action=edit
Bug 32141: Fix textbox formatting on edit IdP screen

This patch makes the textbox have the same number of rows and columns
on the "Edit" page as it does on the "New" page for Identity Providers.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:39:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:39:18 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-itJw1klsk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143526&action=edit
Bug 32141: Add missing fieldset legends and titlecase "matchpoint"

This patch adds missing fieldset legends and titlecases "matchpoint",
so that the "Edit" UI is consistent with the "New" UI for adding
and modifying Identity Providers.

Test plan:
1) Apply patches
2) Go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3) Fill out the fields to add an identity provider
4) Click "Edit" next to the Identity Provider in the list
5) In a new tab, go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
6) Compare the two screens and note that all the labels, inputs, and help text
are the same on both screens.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:40:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:40:07 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-ywVlMPopM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:41:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:41:13 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-MWX5XDTddc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:41:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:41:18 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-ZajUyqW4PU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143451|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:41:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:41:43 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-UOyGdXRfel@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:41:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:41:49 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-hxfoiEGcZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:42:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:42:03 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-IcF04seKvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139135|0                           |1
        is obsolete|                            |
 Attachment #139136|0                           |1
        is obsolete|                            |
 Attachment #139137|0                           |1
        is obsolete|                            |
 Attachment #139138|0                           |1
        is obsolete|                            |
 Attachment #139139|0                           |1
        is obsolete|                            |
 Attachment #139140|0                           |1
        is obsolete|                            |
 Attachment #139141|0                           |1
        is obsolete|                            |
 Attachment #139142|0                           |1
        is obsolete|                            |
 Attachment #139143|0                           |1
        is obsolete|                            |
 Attachment #139144|0                           |1
        is obsolete|                            |
 Attachment #139145|0                           |1
        is obsolete|                            |
 Attachment #139146|0                           |1
        is obsolete|                            |
 Attachment #139147|0                           |1
        is obsolete|                            |
 Attachment #139148|0                           |1
        is obsolete|                            |
 Attachment #139149|0                           |1
        is obsolete|                            |
 Attachment #139150|0                           |1
        is obsolete|                            |
 Attachment #139151|0                           |1
        is obsolete|                            |
 Attachment #139152|0                           |1
        is obsolete|                            |
 Attachment #139153|0                           |1
        is obsolete|                            |
 Attachment #139154|0                           |1
        is obsolete|                            |
 Attachment #139155|0                           |1
        is obsolete|                            |
 Attachment #139156|0                           |1
        is obsolete|                            |
 Attachment #139157|0                           |1
        is obsolete|                            |
 Attachment #139158|0                           |1
        is obsolete|                            |
 Attachment #139159|0                           |1
        is obsolete|                            |
 Attachment #139160|0                           |1
        is obsolete|                            |
 Attachment #139161|0                           |1
        is obsolete|                            |
 Attachment #139162|0                           |1
        is obsolete|                            |
 Attachment #139163|0                           |1
        is obsolete|                            |

--- Comment #382 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143527&action=edit
Bug 20256: Update database

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create two library groups with some libraries in them,
   make sure to enable the new feature to limit editing of items
4) Test the functionality, if an item is owned by a library in
   your group, you should have full editing abilities. If an item
   is from a different group, you should only be able to make the
   same changes you would be able to if IndependentBranches were.

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:42:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:42:30 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-BIpA9GDaHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143528&action=edit
Bug 32138: Fix OIDC default mapping

This patch fixes the OIDC default mapping to have the Koha fields on
the left (ie key) and the OIDC standard claim fields on the right (ie value).

1. Apply the patch
2. Go to
http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form
3. Choose "OIDC" for "Protocol"
4. Click "Add default OIDC mapping"
5. Note the following is displayed:
{
  "email": "email",
  "firstname": "given_name",
  "surname": "family_name"
}

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:42:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:42:36 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-K96pu59BNZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #383 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143529&action=edit
Bug 20256: Add new permission to editor

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:42:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:42:47 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-VP3nqb1eHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #384 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143530&action=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:42:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:42:58 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-dL8pF3iong@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #385 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143531&action=edit
Bug 20256: Add new methods for checking item editing permissions

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:43:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:43:08 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-X1TcBiYk5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #386 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143532&action=edit
Bug 20256: Update groups editor

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:43:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:43:18 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-j6GzCOOp7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #387 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143533&action=edit
Bug 20256: Use new methods

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:43:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:43:30 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-BVvC1e00Nw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #388 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143534&action=edit
Bug 20256: Add unit tests

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:43:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:43:39 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-hLjQlXV4my@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #389 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143535&action=edit
Bug 20256: (QA follow-up) Remove double negative from code

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:43:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:43:49 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-5gOQmSBOMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #390 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143536&action=edit
Bug 20256: (QA follow-up) Change meaning should change code

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:43:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:43:59 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-Npm6p7k1s9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #391 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143537&action=edit
Bug 20256: (QA follow-up) test borrowernumber in userenv too

Bug 22600 added userenv for scripts, so userenv is defined, but some of
values in userenv not

Test plan:
Run with some params: misc/cronjobs/delete_items.pl

--> without this patch you will se error message:
    Can't call method "can_edit_item" on an undefined value at
/home/vagrant/kohaclone/C4/Items.pm line 1748
--> with this patch everything works smoothly

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:44:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:44:08 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-8yfSqFM3S5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #392 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143538&action=edit
Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to
item.can_be_edited

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:44:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:44:17 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-VqXr4KH8TP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #393 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143539&action=edit
Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit
this item

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:44:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:44:32 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-LIlEuSfQlp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #394 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143540&action=edit
Bug 20256: (QA follow-up) Handle non-existing userenv

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:44:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:44:40 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-WmiNWMSqg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #395 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143541&action=edit
Bug 20256: (QA follow-up) Give existing users with edit_items permission
edit_any_item as well

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:44:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:44:52 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-6BXAGnmn9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #396 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143542&action=edit
Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions
for

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:45:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:45:01 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-RXpUyc7E5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #397 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143543&action=edit
Bug 20256: Mark ft_limit_item_editing as boolean in schema file

Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:45:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:45:13 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-36VWjr8E2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #398 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143544&action=edit
Bug 20256: (QA follow-up) Implement for course reserves

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:45:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:45:31 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-d50RYNDzl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #399 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143545&action=edit
Bug 20256: (QA follow-up) Implement for item search

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:45:47 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-k3eCBqwTWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #400 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143546&action=edit
Bug 20256: Update DB Schema [DO NOT PUSH]

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:45:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:45:56 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-ZtzJfQhpRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #401 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143547&action=edit
Bug 20256: (follow-up) Fix spelling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:46:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:46:07 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-UuNuu8bMA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #402 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143548&action=edit
Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:46:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:46:21 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-p71Q80V9PC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #403 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143549&action=edit
Bug 20256: (QA follow-up) Remove duplicated sub

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:46:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:46:33 +0000
Subject: [Koha-bugs] [Bug 32153] New: Wrong link for help for
 systempreferences in 22.05 and below
Message-ID: <bug-32153-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32153

            Bug ID: 32153
           Summary: Wrong link for help for systempreferences in 22.05 and
                    below
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

On 22.05 and 21.11 clicking help from system preferences points to:
https://koha-community.org/manual//22.05/en/html/systempreferences.html
which is a 404

It should point to:
https://koha-community.org/manual//22.05/en/html/globalpreferences.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:46:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:46:32 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-E2yyOs7i1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #404 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143550&action=edit
Bug 20256: (QA follow-up) Update permission descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:46:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:46:44 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-8c72pdwry9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #405 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143551&action=edit
Bug 20256: (QA follow-up) Update group feature description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:47:00 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-Mexz9Zy9tP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #406 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143552&action=edit
Bug 20256: (QA follow-up) Fix typo in permission descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:47:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:47:10 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-6OD9tmKNHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #407 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143553&action=edit
Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item
cannot be edited

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:47:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:47:42 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-UoXBC6wuKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #408 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143554&action=edit
Bug 20256: (QA follow-up) Allow removal of course reserves for items that
cannot be edited

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:47:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:47:54 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-j7DyDy505H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #409 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143555&action=edit
Bug 20256: (QA follow-up) Fix explosion for items batch edit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:48:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:48:05 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-PD3Y4xq7y1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #410 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143556&action=edit
Bug 20256: (QA follow-up) Hide link to delete item if unable to delete the item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:49:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:49:23 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-nUc3uHIzc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:49:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:49:27 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-q2q6R8jAqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143557&action=edit
Bug 31824: Add page-section to list of pending/received orders (acq)

This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
  invoice number link.
  - If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
  orders" and "Already received."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:52:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:52:37 +0000
Subject: [Koha-bugs] [Bug 31820] Add page-section to order receive page (acq)
In-Reply-To: <bug-31820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31820-70-nmkJ4wE9yL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 31824 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:52:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:52:37 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-9PxdxECrDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 31820 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:52:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:52:38 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-oPyKpvHRZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
Bug 31757 depends on bug 31820, which changed state.

Bug 31820 Summary: Add page-section to order receive page (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 17:53:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 16:53:46 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-vLNZV2hPiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:16:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:16:02 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-dBsodAJ8WS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Juliet Heltibridle <jheltibridle at rcplib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #33 from Juliet Heltibridle <jheltibridle at rcplib.org> ---
(In reply to Owen Leonard from comment #27)
> Created attachment 142195 [details] [review]
> Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled
> 
> This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
> templates and scripts which were missed in the first patch. The patch
> also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.
> 
> Check these pages in the OPAC:
> 
>  - Catalog -> Search results
>    - And search results -> RSS
>  - Catalog -> Bibliographic details page -> Shelf browser
>  - Catalog -> Lists -> List contents
>  - Catalog -> Recent comments
>    - And recent comments -> RSS
>  - Your summary -> Checkouts and Overdues

Cover images display in search results, bibligraphic details page, recent
comments, recent comments RSS, and lists (both public & private), and summary
checkouts and overdues.

Cover images are still not displaying on the search results -> RSS feed.

Additionally, cover images from Baker & Taylor do not display on the
bibliographic details page on the staff intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:16:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:16:58 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-ijvXvS7eCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:17:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:17:03 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-UaX3r6vKE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143558&action=edit
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:20:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:20:39 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-VYJhqG6Qdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:30:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:30:45 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-1X6j5ZUCrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:30:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:30:49 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-PIDElU5UgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143559&action=edit
Bug 31827: Add page-section to list to log viewer

This patch adds a "page-section" container div around the log viewer
output.

To test, apply the patch and go to Tools -> Logs.

- Perform a log search which will return results.
- The table of results should appear in a white box.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:33:43 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-hNlTDzU8gK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:33:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:33:51 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-VQlGklcxNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:34:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:34:06 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-NsfZiZ48Ie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:34:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:34:51 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-XdSsa5vYNg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Main page - OK

More menu - OK

ERM module - I'm missing the yarn thing, so I didn't test that, sorry...

System preferences - OK

Authorized values - OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:20 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-DiCKWXWOzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:24 +0000
Subject: [Koha-bugs] [Bug 26635] Expand coded values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-qsTsBSvtZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #113 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:28 +0000
Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration
 dates when importing patrons
In-Reply-To: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27920-70-4sYdriCwtk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:31 +0000
Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration
 dates when importing patrons
In-Reply-To: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27920-70-e8YbvlLdAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920

--- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:34 +0000
Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults
 when cataloguing
In-Reply-To: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30250-70-7vC5u5BRz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:40 +0000
Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults
 when cataloguing
In-Reply-To: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30250-70-reXpd3Vus5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250

--- Comment #40 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:47 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-D8K8QLScFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:49 +0000
Subject: [Koha-bugs] [Bug 31414] Set focus for cursor to Name when adding
 additional fields for baskets or subscriptions
In-Reply-To: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31414-70-WVvPcXyqLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31414

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:52 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-ywI7wUOAED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:54 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-Uuj3dyFDi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:39:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:39:57 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-7xeKvsGC1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:00 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-RUkBLtDLdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:03 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-yvty7kPq2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:07 +0000
Subject: [Koha-bugs] [Bug 32004] Increase font size in top navigation pull
 downs
In-Reply-To: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32004-70-S0PFAg7ZEF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32004

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:10 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-NoqwORvk5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:11 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-882EdwCaT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:13 +0000
Subject: [Koha-bugs] [Bug 32087] Consistent classes for primary buttons:
 Course reserves
In-Reply-To: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32087-70-OsgOd7XoQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:16 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-2FhkPUODKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:18 +0000
Subject: [Koha-bugs] [Bug 32088] Consistent classes for primary buttons:
 Patron card creator
In-Reply-To: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32088-70-xxgg6cS3iz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:21 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-wmIHt3EoxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:24 +0000
Subject: [Koha-bugs] [Bug 32138] OIDC client uses backwards default mapping
In-Reply-To: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32138-70-XvI6w7ZmFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:26 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-6u1f09mXGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:29 +0000
Subject: [Koha-bugs] [Bug 32139] "Update on login" setting not set when
 creating domain from new IdP page
In-Reply-To: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32139-70-NUWaSsW3SJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32139

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:32 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-Ip971JoGcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:40:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:40:34 +0000
Subject: [Koha-bugs] [Bug 32141] New and edit identity provider UIs
 inconsistent
In-Reply-To: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32141-70-dBDhRW1Hfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32141

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:42:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:42:47 +0000
Subject: [Koha-bugs] [Bug 32154] New: Missing primary key on erm_user_roles
 table
Message-ID: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

            Bug ID: 32154
           Summary: Missing primary key on erm_user_roles table
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pedro.amorim at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This is an outstanding issue related to the ERM module mentioned at:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030#c31

Jonathan Druart:
TestBuilder.t is failing on ERM::User::Roles, it's missing a primary key on
erm_user_roles I think
Can be tested with:

use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
my $m = 'Koha::ERM::UserRoles';
eval "require $m";
my $object = $builder->build_object( { class => $m } ); 
say ref($object);

Should display "Koha::ERM::UserRole", not be empty

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:47:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:47:04 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-yM5993Q41V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:49:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:49:06 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-z20UmuulRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:49:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:49:10 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-X2DAHWyPZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143368|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143560&action=edit
Bug 32097: Consistent classes for primary buttons: Lists

This patch makes changes the button markup in lists templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view lists pages to confirm that everything
looks correct. In most cases there are no visible changes.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:50:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:50:24 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-tRqaG76ut1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:50:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:50:29 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-ILJnDjLkgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143345|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143561&action=edit
Bug 32091: Consistent classes for primary buttons: Reports

This patch makes changes the button markup in reports templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view reports pages to confirm that
everything looks correct. In most cases there are no visible changes.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:52:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:52:49 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-kBeZpLPb5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:52:54 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-upf3tc9qwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143141|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:52:57 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-GkVEF9fyIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143142|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:53:01 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-qzpU92qUTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143143|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:53:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:53:34 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-2yKY39drdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143562&action=edit
Bug 8948: Display MARC 787 relationship field

This field is defined similar to 775, as a related work:
https://www.loc.gov/marc/bibliographic/bd787.html

This patch adds a display of this field, linking to the referenced record as
the 775 does

It also tests for 580 field, and displays the text there if present, using the
787 a and t subfields otherwise

To test:
1 - Edit the default framework to make 787atw and 580a visible in editor
2 - Add a 787 to a record:
    $tThe ideas behind the chess openings
    $aFine, Reuben<
    $w2470231
3 - Confirm there is no display
4 - Apply patch / restart all
5 - 'Other related works' now shows
6 - Link should be using title of record
7 - Set system preference UseControlNumber to Use
8 - Reload details, link should now use control number
9 - Add a 580 to the record:
    $a This is a friendly work to this one
10 - Confirm the text of the link now displays before the link
11 - Add a second 580, confirm it displays as well
   - there is no seperator as each should end with a period or other
punctuation according to MARC
   - there is a dpan with a class surrounding each so styling can be added as
desired
12 - Add a second 787
   - confirm seperator present and wrapped in a span with a class
   - confirm each 787 is shown with a span/class for styling

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:53:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:53:40 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-BRTQmomv83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143563&action=edit
Bug 8948: Changes for OPAC

Test with same record, confirm OPAC view is as expected

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:53:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:53:48 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-AXNRGS6x89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143564&action=edit
Bug 8948: (follow-up) Correct OPAC link

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:56:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:56:10 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-J0hbUwi2mR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

--- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 143565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143565&action=edit
Bug 32154: Missing primary key on erm_user_roles table

The aforementioned TestBuilder should display "Koha::ERM::UserRole", not be
empty. This patch adds a primary key to the erm_user_roles table and fixes
that.
Also includes atomicupdate file to update database schema as well as updates to
kohastructure.sql provided by Jonathan Druart.
Looked into the vue files but didn't find anywhere or a need to include the new
primary key in any of the requests as there is no request of users by
role_user_id being made.
Erm users are being created/updated as a relationship through
licenceses/agreements. Furthermore, when editing a role of an existing user,
this new primary key is already being supplied embeded in the
license/agreement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:56:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:56:20 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-KiwtO2h8su@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:56:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:56:25 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-EOM3WrSzuw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142588|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:56:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:56:29 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-X86v5ckwRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142589|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:56:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:56:33 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-6t1Bwj65uh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143069|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:57:18 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-r3KejdnyFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m

--- Comment #41 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Outstanding issue related to primary key of erm_user_roles table created at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 18:59:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 17:59:25 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-L3gvzP2Y4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:01:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:01:15 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-bSOu1UEEbT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

--- Comment #46 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143566&action=edit
Bug 13600: XSLT - 8xx not showing if there is no 4xx

This patch adjusts XSLT so that series tag displays if any 440,490,800,810,830
is present

It also adjusts 8xx to display even if 490 ind 1 = 1 is not present

To test:
1 - Check records with multiple series tag
2 - Confirm display is correct

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:01:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:01:23 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-v1wJ0zlXCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

--- Comment #47 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143567&action=edit
Bug 13600: (follow-up) Add separator between different series fields

This patch checks for an upcoming series tag, and adds a separator if one is
found

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:01:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:01:31 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-uhBF3wVKGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

--- Comment #48 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143568&action=edit
Bug 13600: (follow-up) Add seperator on the OPAC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:05 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-ogDsEkWP0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:10 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-ELa3FRJNng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142877|0                           |1
        is obsolete|                            |
 Attachment #142878|0                           |1
        is obsolete|                            |
 Attachment #142879|0                           |1
        is obsolete|                            |
 Attachment #142880|0                           |1
        is obsolete|                            |
 Attachment #142881|0                           |1
        is obsolete|                            |
 Attachment #142882|0                           |1
        is obsolete|                            |
 Attachment #142883|0                           |1
        is obsolete|                            |
 Attachment #142884|0                           |1
        is obsolete|                            |
 Attachment #142885|0                           |1
        is obsolete|                            |
 Attachment #142886|0                           |1
        is obsolete|                            |
 Attachment #142887|0                           |1
        is obsolete|                            |
 Attachment #142888|0                           |1
        is obsolete|                            |
 Attachment #143020|0                           |1
        is obsolete|                            |

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143569&action=edit
Bug 24606: Update database, add new schema file

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:30 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-edaNiY2D23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143570&action=edit
Bug 24606: Add Koha Object(s) with unit tests

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:34 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-277jKrPeJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143571&action=edit
Bug 24606: Implement item templates

This patch set implements item editor templates for community Koha.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Restart all the things!
4) prove t/db_dependent/Koha/Item/Template*
5) As a non superlibrarian, enter the item editor
6) Set some item fields, save as a new template using the buttom and
   form below the editor.
7) Test loading a template without remembering for the session
8) Test loading a template while remembering for the session
9) Test deleting a template
10) Test updating a template
11) Create one or more shared templates
12) Log in as another non superlibrarian without the new permission
manage_item_editor_templates,
    verify you cannot edit/delete templates shared to you
13) Enable the new permission manage_item_editor_templates,
    verify you can now edit and delete templates shared to you

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:38 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-CGUSL8tA1u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143572&action=edit
Bug 24606: Add item template editor permission

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:43 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-AhNUlROZyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143573&action=edit
Bug 24606: (QA follow-up) Set existing sharing setting when updating existing
template

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:47 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-dGo6QnCmdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143574&action=edit
Bug 24606: (QA follow-up) Fix QA script issues

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:52 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-mcMXfWG9qD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143575&action=edit
Bug 24606: (QA follow-up) Update js message translation style

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:17:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:17:56 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-OdYfYIJaGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143576&action=edit
Bug 24606: (QA follow-up) Fix up interface

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:18:00 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-fVDLot2DfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143577&action=edit
Bug 24606: (QA follow-up) Hide button when using multi-add

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:18:05 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-dFzFYEhIGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143578&action=edit
Bug 24606: (QA follow-up) Disable 'Apply template' button if no template is
selected

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:18:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:18:10 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-JKUNRSvtPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Rebecca Coert <rcoert at arlingtonva.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcoert at arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:18:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:18:12 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-ZcbIXoG4Gv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143579&action=edit
Bug 24606: (QA follow-up) Remove string variable

This string is no longer needed as the __() is used
in the .js file directly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:18:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:18:16 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-dGfS8D8g7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143580&action=edit
Bug 24606: (QA follow-up) Fix up save form a bit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:18:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:18:22 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-BCB8GAdH0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143581&action=edit
Bug 24606: Update existing schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:35 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-MTbL4i4uZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:38 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-rpu4dO9jx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:42 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-IZf9N4EDbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:45 +0000
Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
In-Reply-To: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13600-70-LIineuNmEm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600

--- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:48 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-bQUWdUVE6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:51 +0000
Subject: [Koha-bugs] [Bug 32091] Consistent classes for primary buttons:
 Reports
In-Reply-To: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32091-70-mndytYfNWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32091

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:53 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-DW1KEj9lVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:29:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:29:56 +0000
Subject: [Koha-bugs] [Bug 32097] Consistent classes for primary buttons:
 Lists
In-Reply-To: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32097-70-wmxycxEHaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32097

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:39:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:39:04 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-YOKNyO4fdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 19:39:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 18:39:08 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-fj7bZjL5dc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143582&action=edit
Bug 31928: Add page-section to callnumber browser value builder (cat)

This patch adds a page-section div around the search results shown by
the call number browser plugin in Cataloging.

The patch also restructures the search form so that the layout is
correct.

To test you must have an item subfield linked to the call number browser
plugin:

- Go to MARC frameworks -> Default MARC framework -> MARC structure.
- Locate the 952 tag and click Actions -> Edit subfields.
- Open the "o" tab and in the last section, "Other options," choose
  "cn_browser.pl" for the plugin field.

Open an item record for editing:

- Go to Cataloging and search for a bibliographic record.
- Click Actions -> Add/Edit items for one of the results.
- In the item edit form, the  "o - Full call number" field should have a
  "..." link at the end.
- Clicking it should trigger a popup window.
- The search form at the top should be laid out correctly.
- Perform a search which will return results.
- The table of results should be contained within a white box.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 20:11:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 19:11:10 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-s5ksmeEI72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 20:11:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 19:11:15 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-f8kgpD4fcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125377|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143583&action=edit
Bug 28966: Reimplement query using objects

Test Plan:
1) Generate the holds queue
2) Load the holds queue viewer page
3) Apply this patch
4) Restart all the things!
5) Reload the page
6) Note nothing has changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 20:12:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 19:12:13 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-Si3CT6joZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143583|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143584&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

Test Plan:
1) Generate the holds queue
2) Load the holds queue viewer page
3) Apply this patch
4) Restart all the things!
5) Reload the page
6) Note nothing has changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 20:37:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 19:37:14 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-17L7CCXkdd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #323 from David Nind <david at davidnind.com> ---
Thanks Martin!

Hopefully this is the last set of issues:

1. OPAC redirect to log in:
   - I get redirected to the login page
   - After enter the details, I get this message (in Firefox) (it may be
something to do with bug 31699, and I haven't set things up correctly):

    "Oops.

    The site at
http://127.0.0.1:8080/cgi-bin/koha/opac-user.pl?has-search-query=;return=http://127.0.0.1:8080/cgi-bin/koha/opac-detail.pl?biblionumber=262&query_desc=kw%2Cwrdl%3A%20perl&modal=concern
has experienced a network protocol violation that cannot be repaired.

   The page you are trying to view cannot be shown because an error in the data
transmission was detected.

   Please contact the website owners to inform them of this problem."

2. Catalog concerns landing page: the filter for the Status column doesn't seem
to work:
  - Have two catalog concerns - one open and one closed
  - For the status column filter, start typing Open
  - No results shown

Otherwise, happy to finally sign off!

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:06:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:06:27 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-mHJQLE2Qi2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:06:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:06:44 +0000
Subject: [Koha-bugs] [Bug 28502] Changing patron category from child to
 adult doesn't delete non patron guarantor data.
In-Reply-To: <bug-28502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28502-70-mdL68VFBEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28502

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:15:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:15:40 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-wZ5tXo4GFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143585&action=edit
Bug 37159: Testing alternate tab style

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:20:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:20:19 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-rdnGq0l5hO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:20:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:20:23 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-zFxKGiL4Zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143520|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143586&action=edit
Bug 32146: Add page-section to course reserves

This patch adds a "page-section" wrapping div to two Course Reserves
templates.

Note: This patch contains indentation changes.

To test, apply the patch and go to Course Reserves.

 - The table of course reserves should appear in a white section.
 - View the details of a course: There should be a white section for the
   list of details at the top and another for the table of reserves.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:30:25 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-5Fcn0c3VVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Laura <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Laura.escamilla at bywatersolu
                   |                            |tions.com
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Laura <Laura.escamilla at bywatersolutions.com> ---
Signed-Off: Laura Escamilla (Laura.escamilla at bywatersolutions.com)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:36:06 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-eo3Fq1818I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---

> > Also, when you edit an item, the date last seen changes to the current date
> > but with the time set as 00:00.

Editing an item should not update the datelastseen. For me it doesn't update
without this patchset and it should not with it either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:42:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:42:21 +0000
Subject: [Koha-bugs] [Bug 32155] New: Course reserves - instructors display
 is misaligned on course information page
Message-ID: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

            Bug ID: 32155
           Summary: Course reserves - instructors display is misaligned on
                    course information page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 143587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143587&action=edit
Screenshot - course information instructor misalignment

On the course reserve information page, the instructors section is misaligned.

See the attached screenshot.

To replicate:
1. Create or edit an existing course.
2. Search and add an instructor.
3. Note that the columns are misaligned: the name of the course instructor is
shown first, then the label "Instructors" is shown next.
4. Add another three instructors.
5. Note that this pushes the labels for the next few fields to the right.

Note that bug 32146 fixes the page-section style.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:48:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:48:07 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-2TvlK6Loa9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:48:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:48:12 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-3dfB4u5Uov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143521|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143588&action=edit
Bug 31823: Add page-section to uncertain prices page (acq)

This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions

Note: This patch contains indentation changes.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
  list of orders with uncertain prices.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:51:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:51:42 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-JiT6a5scX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:51:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:51:51 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-3w3dCdcPF6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143557|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 143589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143589&action=edit
Bug 31824: Add page-section to list of pending/received orders (acq)

This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
  invoice number link.
  - If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
  orders" and "Already received."

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:57:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:57:00 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-6TZOV41AII@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 21:57:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 20:57:06 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-106ZCbq0Uc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143558|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143590&action=edit
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:00:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:00:31 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-muMBT0vAAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:00:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:00:37 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-HljtTiQwmX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143559|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143591&action=edit
Bug 31827: Add page-section to list to log viewer

This patch adds a "page-section" container div around the log viewer
output.

To test, apply the patch and go to Tools -> Logs.

- Perform a log search which will return results.
- The table of results should appear in a white box.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:07:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:07:21 +0000
Subject: [Koha-bugs] [Bug 32156] New: Form misalignment - wrapping when
 content wider than screen
Message-ID: <bug-32156-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32156

            Bug ID: 32156
           Summary: Form misalignment - wrapping when content wider than
                    screen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 143592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143592&action=edit
Screenshot - form label and content misalignment

When the content for a form is wider than the screen, the wrapping is
misaligned.

For an example, see Tools > Log viewer - the content for modules and actions
fields are in the label column (see the attached screenshot).

I'm sure I've seen this elsewhere, but where escapes me at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:08:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:08:04 +0000
Subject: [Koha-bugs] [Bug 32156] Form misalignment - wrapping when content
 wider than screen
In-Reply-To: <bug-32156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32156-70-RMsmRehIHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32156

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:08:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:08:04 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-b3NXLAEnfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32156


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32156
[Bug 32156] Form misalignment - wrapping when content wider than screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:08:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:08:56 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-3JHHIqfH01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155
[Bug 32155] Course reserves - instructors display is misaligned on course
information page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:08:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:08:56 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-DSYfGmqfAy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:12:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:12:48 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-4LJ5wFV3Tz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:12:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:12:53 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-LB4rNM31jB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143524|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143593&action=edit
Bug 31828: Add page-section to list of open invoices on receive shipment page
(acq)

This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.

This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
  section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
  fields -> Invoices) there should be a third section showing those
  fields.
- With no additional fields defined you should not see an empty
  fieldset.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:19:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:19:20 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-iaS6eGrrTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:19:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:19:30 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-QCmgP4E3kK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143582|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143594&action=edit
Bug 31928: Add page-section to callnumber browser value builder (cat)

This patch adds a page-section div around the search results shown by
the call number browser plugin in Cataloging.

The patch also restructures the search form so that the layout is
correct.

To test you must have an item subfield linked to the call number browser
plugin:

- Go to MARC frameworks -> Default MARC framework -> MARC structure.
- Locate the 952 tag and click Actions -> Edit subfields.
- Open the "o" tab and in the last section, "Other options," choose
  "cn_browser.pl" for the plugin field.

Open an item record for editing:

- Go to Cataloging and search for a bibliographic record.
- Click Actions -> Add/Edit items for one of the results.
- In the item edit form, the  "o - Full call number" field should have a
  "..." link at the end.
- Clicking it should trigger a popup window.
- The search form at the top should be laid out correctly.
- Perform a search which will return results.
- The table of results should be contained within a white box.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:19:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:19:31 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-kqucqFgayG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #49 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I got the same error on the BibLibre sandboxes for some reason. Spinning one up
on PTFS-Europe's site now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:28:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:28:09 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-Spnig78WPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
I noticed some "weird" behaviour with the results section:

- The first time you search (for example, "a"), there is a darker green line
under the column headers
- If you then search for something else (for example, "s") the dark green line
moves to the bottom
- Repeat searching for different terms, and the green line swaps about
- If there is more than one result (I added some call numebrs to items), it
does the same

I'm not familiar with searching using the value builder, so it may be a feature
- particularly where all items have call numbers (as there are not many in the
same data).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:41:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:41:35 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-IW7Bw1ArSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

--- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143595&action=edit
Bug 31212: (follow-up) Fix datelastseen when returning item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:49:25 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-yTZwKvQiAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 22:49:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 21:49:30 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-BK3CdQLDL6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143517|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143596&action=edit
Bug 32148: Buttons must inherit Bootstrap size classes

This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.

To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:

- Circulation -> Check out:
  - The "Check out" button, the "Show checkouts" button, Renew buttons
    in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:00:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:00:09 +0000
Subject: [Koha-bugs] [Bug 32157] New: Renewal due date input field width -
 adjusts to the width of the screen
Message-ID: <bug-32157-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32157

            Bug ID: 32157
           Summary: Renewal due date input field width - adjusts to the
                    width of the screen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 143597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143597&action=edit
Screenshot - renewal due date input field width

For Circulation > Renew, the renewal due date input field adjusts to the width
of the screen.

See the attached screenshot.

Maybe this is a new "style" as part of the staff interface redesign? but I
think it looks odd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:01:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:01:55 +0000
Subject: [Koha-bugs] [Bug 32157] Renewal due date input field width -
 adjusts to the width of the screen
In-Reply-To: <bug-32157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32157-70-9SE2BID6JN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32157

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:01:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:01:55 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-gAdNLfwDWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32157


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32157
[Bug 32157] Renewal due date input field width - adjusts to the width of the
screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:17:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:17:29 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-dRxHyH27dP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:34:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:34:15 +0000
Subject: [Koha-bugs] [Bug 31896] New Recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-q1MUEAlF1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please remember to update
https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:37:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:37:47 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-UsrCffcLfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:37:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:37:52 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-Odweoz1Ceb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143453|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143598&action=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:38:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:38:45 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-AM3UBS2R4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds an
      release notes|                            |issued_or_reserved option
                   |                            |to the HoldFeeMode system
                   |                            |preference, so that a hold
                   |                            |fee may be charged if
                   |                            |either all items are check
                   |                            |out, or the record has at
                   |                            |least one hold already.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:39:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:39:10 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-7VZfJifIbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #33 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #32)
> Any chance of sharing those patches David?

They're a bit hacky but I could certainly share them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:40:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:40:43 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-RF9qh3YzGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This wasn't PQA for a reason. Displaying 580 in context of 787 is not correct,
I'd even say it can lead to things looking quite wrong. Please see comment#20.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:41:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:41:16 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-HsNwW6sOpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #32)
> This wasn't PQA for a reason. Displaying 580 in context of 787 is not
> correct, I'd even say it can lead to things looking quite wrong. Please see
> comment#20.

We should remove 580 display for the time being.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:42:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:42:26 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-yGHeQTKtsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #265 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #263)
> Error while loading /etc/koha/plack.psgi: Can't load application from file
> "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm
> in @INC 
> 
> Should we mark this as dependency for Mason please?
> 
> apt-get install libmojolicious-plugin-oauth2-perl
> apt-get install libmojolicious-plugin-renderfile-perl

I can see 'Mojolicious::Plugin::RenderFile' in cpanfile, but I can't see
'Mojolicious::Plugin::OAuth2'.

I think cpanfile might need an update? 

I think debian/control gets updated at release time...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:48:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:48:01 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-72Uli8Iaox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #23)
> It might also hinder a a quick desaster recovery to a different server? At
> least something more to think about for backups etc.

With the encryption key in koha-conf.xml, they wouldn't be able to decrypt the
encrypted passwords in the database either. 

(In reply to Kyle M Hall from comment #22)
> (In reply to Victor Grousset/tuxayo from comment #21)
> > That's why I wondered if there was any gain compared to just storing the
> > passwords into koha-conf.xml directly? (or another file)
> 
> Simply put, imo, that would mean librarians could no longer update that data
> without help from the server administrator, making their jobs more difficult.

Agreed with Kyle. There needs to be a balance between security and
functionality/convenience.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:48:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:48:07 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-ELCnIaY2V2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #33)
> (In reply to Katrin Fischer from comment #32)
> > This wasn't PQA for a reason. Displaying 580 in context of 787 is not
> > correct, I'd even say it can lead to things looking quite wrong. Please see
> > comment#20.
> 
> We should remove 580 display for the time being.

I did move the 580, they display after the 787

While they could mismatch, in general the documentation makes it seem it will
be clear which note relates to which link. The 580 can now also be easily
styled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:49:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:49:24 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-GhqaWtGJ63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #24)
> (In reply to Katrin Fischer from comment #23)
> > It might also hinder a a quick desaster recovery to a different server? At
> > least something more to think about for backups etc.
> 
> With the encryption key in koha-conf.xml, they wouldn't be able to decrypt
> the encrypted passwords in the database either. 

True, so something to keep in mind then for the sysadmins?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov  9 23:52:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 22:52:28 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-qM9tw9Fe46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, but: 

+        <!--  787 Other Relationship Entry  -->
+        <xsl:if test="marc:datafield[@tag=787]">
+        <span class="results_summary other_relationship_entry"><span
class="label">Other related works: </span>
+        <xsl:for-each select="marc:datafield[@tag=580]">
+            <span class="linking_complexity_note">
+                <xsl:call-template name="subfieldSelect">
+                    <xsl:with-param name="codes">a</xsl:with-param>
+                </xsl:call-template>
+                <xsl:text> </xsl:text>
+            </span>
+        </xsl:for-each>

You only display the 580 of a 787 exists and it displays after the "Other
related works" which is the 787 label.

The problem is: 580 might belong to ANY 7xx field, not just the 787. In the
documentation there are examples for 773 and 785 respectively. 

The problem is not if there are mulitple 787, but if we give a totally wrong
context here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:01:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:01:41 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-zGcpl6rUIH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:02:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:02:03 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-Z8xmVDXf9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #27 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #21)
> Sorry chaps, it was late last night when this discussion took place. I've
> marked it assigned and will work on it today.
> 
> Bit disappointed with myself that I didn't spot this at initial development.
> Still, it should be a trivial follow-up.

No worries. We're all human and it's why it's always good to have another set
of eyes on things!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:04:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:04:35 +0000
Subject: [Koha-bugs] [Bug 32158] New: Specify due date field is very long now
Message-ID: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

            Bug ID: 32158
           Summary: Specify due date field is very long now
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952

When checking out an item with a specified due date, this field is stretched
the full length of the options area now.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:04:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:04:35 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ZnjarLS4Up@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32158


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158
[Bug 32158] Specify due date field is very long now
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:06:59 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-JvcUE33oko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:07:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:07:03 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-D5JNjO2ou7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143291|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143599&action=edit
Bug 32043: Circulation alerts can overlap other elements on smaller screens

This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.

To test, apply the patch and rebuild the staff interface CSS.

Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:

- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.

The confirmation dialog should have a comfortable margin between it and
the checkout form.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:12:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:12:02 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-7Lnngjj3sX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I didn't see the console error on master - could you please verify if maybe bug
31609 fixed this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:18:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:18:18 +0000
Subject: [Koha-bugs] [Bug 32159] New: Uncertain prices has 2 level 1 headings
Message-ID: <bug-32159-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159

            Bug ID: 32159
           Summary: Uncertain prices has 2 level 1 headings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy, accessibility
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Instead of h1 - h2 - h2 we have 2 h1 headings with almost the same text on the
uncertain prices page in acquisitions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:20:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:20:36 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-WQeDTfC2xY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:20:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:20:42 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-uvHPTPijaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143588|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143600&action=edit
Bug 31823: Add page-section to uncertain prices page (acq)

This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions

Note: This patch contains indentation changes.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
  list of orders with uncertain prices.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:21:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:21:15 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-00DR4VZJQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:22:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:22:18 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-YrwPcsLTdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #28 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 143469
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143469
Bug 31699: (follow-up) Protect against unauthorized redirects

Review of attachment 143469:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31699&attachment=143469)
-----------------------------------------------------------------

::: opac/opac-user.pl
@@ +428,5 @@
>  # back to the page we triggered the login from
>  my $return = $query->param('return');
>  if ( $return ) {
> +    my $uri = C4::Context->preference('OPACBaseURL');
> +    $uri .= $return;

If OPACBaseURL isn't set, which happens more often than I'd like, this would
still be vulnerable to open redirects.

I was thinking that we'd re-write the URL using the URI module. 

Today, I thought we could potentially get away with nuking the "scheme" and
"authority", but then I figured out a URL trick to get it to redirect to a
malicious URL. 

So I think we need to do a bit more validation. I'll write up a quick patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:22:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:22:41 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-vnYnxA4ROS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:22:45 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-1y1xGw7j82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143589|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143601&action=edit
Bug 31824: Add page-section to list of pending/received orders (acq)

This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
  invoice number link.
  - If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
  orders" and "Already received."

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:27:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:27:17 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-2o05oPEbvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #29 from David Nind <david at davidnind.com> ---
The last follow-up has "broken" the redirect used for bug 31028 - Catalog
concerns (see comment 323 (!!)), so it may pay to test with that bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:32:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:32:57 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-QrNy62paNm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:33:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:33:01 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-raTKKHdHta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143590|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143602&action=edit
Bug 31826: Add page-section to item form on order receive page (acq)

This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
  shipments. Otherwise click on the invoice number link to get to the
  "Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
  details, Acquisitions details, and Items.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:36:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:36:40 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-ihgWnQ7fTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:36:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:36:44 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-l7B0wNpxKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143591|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143603&action=edit
Bug 31827: Add page-section to list to log viewer

This patch adds a "page-section" container div around the log viewer
output.

To test, apply the patch and go to Tools -> Logs.

- Perform a log search which will return results.
- The table of results should appear in a white box.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:36:57 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-wtfE5ZgV5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:38:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:38:40 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-ba43KzZbWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:38:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:38:45 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-ffcIVUgm55@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143593|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143604&action=edit
Bug 31828: Add page-section to list of open invoices on receive shipment page
(acq)

This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.

This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.

To test, apply the patch and go to Acquisitions.

- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
  section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
  fields -> Invoices) there should be a third section showing those
  fields.
- With no additional fields defined you should not see an empty
  fieldset.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:43:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:43:05 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-VQmW4Q25Np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:43:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:43:10 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-19cFzfCUs0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143586|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143605&action=edit
Bug 32146: Add page-section to course reserves

This patch adds a "page-section" wrapping div to two Course Reserves
templates.

Note: This patch contains indentation changes.

To test, apply the patch and go to Course Reserves.

 - The table of course reserves should appear in a white section.
 - View the details of a course: There should be a white section for the
   list of details at the top and another for the table of reserves.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:45:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:45:58 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-wSMiamxm9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #30 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Nind from comment #29)
> The last follow-up has "broken" the redirect used for bug 31028 - Catalog
> concerns (see comment 323 (!!)), so it may pay to test with that bug.

That's interesting. I don't think it would've been the follow-up, so much as
the whole feature.

How were you setting the data-return attribute? I think that might be part of
your problem?

(Interestingly, it looks like opac-reserve.pl might be broken in master as well
on an unrelated note...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:45:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:45:59 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-CPoOUYI7rz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:46:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:46:03 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-XEh5ylFB04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143594|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143606&action=edit
Bug 31928: Add page-section to callnumber browser value builder (cat)

This patch adds a page-section div around the search results shown by
the call number browser plugin in Cataloging.

The patch also restructures the search form so that the layout is
correct.

To test you must have an item subfield linked to the call number browser
plugin:

- Go to MARC frameworks -> Default MARC framework -> MARC structure.
- Locate the 952 tag and click Actions -> Edit subfields.
- Open the "o" tab and in the last section, "Other options," choose
  "cn_browser.pl" for the plugin field.

Open an item record for editing:

- Go to Cataloging and search for a bibliographic record.
- Click Actions -> Add/Edit items for one of the results.
- In the item edit form, the  "o - Full call number" field should have a
  "..." link at the end.
- Clicking it should trigger a popup window.
- The search form at the top should be laid out correctly.
- Perform a search which will return results.
- The table of results should be contained within a white box.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:47:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:47:14 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-DDN9Xdnghx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
At the moment, with Martin's patches, the following will generate a
"ERR_INVALID_REDIRECT":

http://localhost:8080/cgi-bin/koha/opac-user.pl?return=http://koha-community.org/test

If I erase OPACBaseURL, then I get the open redirect vulnerability again.

So now I'll add a patch...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:48:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:48:05 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-YHPgrvd9HK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #32 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #31)
> If I erase OPACBaseURL, then I get the open redirect vulnerability again.

Worth noting that this affects only logged in users. The redirect code won't
trigger for anonymous users, since we short-circuit opac-user.pl for anonymous
users and prompt with a regular login box.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:51:36 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-jDztsvs9Jo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:51:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:51:40 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-HalU3eoAHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143596|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143607&action=edit
Bug 32148: Buttons must inherit Bootstrap size classes

This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.

To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:

- Circulation -> Check out:
  - The "Check out" button, the "Show checkouts" button, Renew buttons
    in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 00:58:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Nov 2022 23:58:55 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-q1WMNRBGYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #33 from David Cook <dcook at prosentient.com.au> ---
With my upcoming patch, 

Without OPACBaseURL, no redirection happens for the following:
http://localhost:8080/cgi-bin/koha/opac-user.pl?return=http://koha-community.org/test?test=test

With OPACBaseURL, the return URL is rewritten to use the scheme and authority
of OPACBaseURL, so that the following:

http://localhost:8080/cgi-bin/koha/opac-user.pl?return=http://koha-community.org/test?test=test#test

Redirects to:

http://localhost:8080/test?test=test#test

--

So it shouldn't be possible to send a user anywhere other than
http://localhost:8080.

(An alternative would be to set the page visited in the user's database session
and then juggle that around and try to return to that, but that would be a more
difficult code change than Martin's patches here.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:03:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:03:32 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-SyHbCEmNiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #34 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143608&action=edit
Bug 31699: (follow-up) Protect more against open redirects

This change checks that the OPACBaseURL exists, and uses its scheme
and authority to rewrite the URL passed through the "return"
param.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:05:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:05:57 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-9SWVYiIccp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
Note that while the code checks for URI::http as the URI class type, this
includes URI::https since it subclasses URI::http, so it works for OPACBaseURL
using either HTTP or HTTPS URLs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:18:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:18:42 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-IJZF45cnhl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #36 from David Cook <dcook at prosentient.com.au> ---
I was doing some more thinking...

On one hand, I was thinking maybe we should make a more consistent login box.

For instance, if you go to
http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add_form, the
opac-auth.tt template creates a login box that works as expected.

But the modal sends you off to opac-user.pl. There's no reason the masthead.inc
couldn't create the same login box as opac-auth.tt.

On the other hand, I like the idea of login endpoints (like with SSO), which
need to redirect you back, so maybe this redirect is fine (so long as we're
rewriting/validating the redirect URLs)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:22:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:22:06 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-rJ8GzcnCIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #25)
> (In reply to David Cook from comment #24)
> > (In reply to Katrin Fischer from comment #23)
> > > It might also hinder a a quick desaster recovery to a different server? At
> > > least something more to think about for backups etc.
> > 
> > With the encryption key in koha-conf.xml, they wouldn't be able to decrypt
> > the encrypted passwords in the database either. 
> 
> True, so something to keep in mind then for the sysadmins?

Yeah, I mean there's other bits of config that this happens for too. I use the
"OAI-PMH:ConfFile" syspref, and if you just restore the database dump without
including the server-side file, it'll break the OAI.

So sysadmins really need to keep in mind that the database and server-side
config need to be restored together.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:30:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:30:11 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-9CfPoavDhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #266 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #265)
> (In reply to Marcel de Rooy from comment #263)
> > Error while loading /etc/koha/plack.psgi: Can't load application from file
> > "/usr/share/koha/api/v1/app.pl": Can't locate Mojolicious/Plugin/OAuth2.pm
> > in @INC 
> > 
> > Should we mark this as dependency for Mason please?
> > 
> > apt-get install libmojolicious-plugin-oauth2-perl
> > apt-get install libmojolicious-plugin-renderfile-perl
> 
> I can see 'Mojolicious::Plugin::RenderFile' in cpanfile, but I can't see
> 'Mojolicious::Plugin::OAuth2'.

The third patch introduced it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:36:52 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-PCetZsOYO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:36:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:36:56 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-dJDy0du3gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143150|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143609&action=edit
Bug 32101: Add padding to floating toolbars

This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.

To test, apply the patch and rebuild the staff interface CSS.

View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:

- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:39:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:39:15 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-T6ZP7RemZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is a conflict in the .t, can you please fix?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:42:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:42:27 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-CQg9uOrTdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #3)
> I didn't see the console error on master - could you please verify if maybe
> bug 31609 fixed this?

It did not, the console error remains.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:43:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:43:15 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-tVX2Btphxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I couldn't make it happen when I tried earlier, maybe another set of eyes would
help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:45:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:45:22 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-Ks8O79n6Ym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
It looks like I can only make the error happen when using Firefox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:46:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:46:07 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-nH9cPJKq5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #6)
> It looks like I can only make the error happen when using Firefox.

Hm I did use Firefox :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:47:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:47:39 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-DExXg7plvG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:47:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:47:43 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-M7Mfl5qJxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143294|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143610&action=edit
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:53:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:53:58 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-6oWeOJgDeF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is it expected that the search doesn't work with cardnumber? Or is it because
42 is too short an input?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:54:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:54:35 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-AlGo8u3lEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 01:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 00:54:40 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-yXZszGeszQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143180|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143611&action=edit
Bug 32108: Replace "x" icon with the "search" icon

Change "x" icon to replace patron when scheduling a pickup.

Test plan:
Schedule a new pickup, select a patron, notice the change.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 02:26:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 01:26:53 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-lKUMWtg4cD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 02:26:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 01:26:57 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-reJSi1ehFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143149|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143612&action=edit
Bug 32102: Improve specificity of batch record modification breadcrumbs

This patch makes a minor change to the batch record modification
template so that there is a link back to the initial view after you have
submitted a batch for modification.

To test, apply the patch and go to Cataloging -> Batch record
modification.

- Initially the breadcrumbs menu should show Home -> Cataloging -> Batch
  record modification
- Submit a batch of bibliographic or authority records for modification
- The breadcrumbs should now read Home -> Cataloging -> Batch record
  modification -> Results
- The same menu options should show after you confirm the operation

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 02:44:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 01:44:10 +0000
Subject: [Koha-bugs] [Bug 32160] New: Batch record modification - show MARC
 preview no longer works
Message-ID: <bug-32160-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32160

            Bug ID: 32160
           Summary: Batch record modification - show MARC preview no
                    longer works
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When clicking on the 'Show MARC' action from the list of records to be modified
using Cataloguing > Batch record modification, it shows as 'Loading' and does
not complete the display of the modified MARC record.

In the web developer tools an error is displayed:

14:24:26.131 XHR GET
http://127.0.0.1:8081/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=262&mmtid=3&overlay_context=batchmod
[HTTP/1.1 500 Internal Server Error 87ms]

To replicate using koha-testing-docker (KTD):
1. Add a MARC modification template (Cataloguing > MARC modification templates
> New template > give it a name and click submit > add a 'New action" (for
example: Add new 500$a with value 'OK')).
2. Modify a batch of records (Cataloguing > Batch record modification):
   - For 'Enter a list of record numbers' enter 17 and 262 (sample data for
KTD)
   - Choose the template you created in step 1
   - Press Continue
3. Enable the web developer tools console.
3. From the results list, click on 'Show MARC'.
4. On the modal window, note that the spinner says 'Loading', and doesn't
complete the display of the MARC.
5. Note that in the web developer tools console there is an error:
   14:24:26.131 XHR GET
http://127.0.0.1:8081/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=262&mmtid=3&overlay_context=batchmod
[HTTP/1.1 500 Internal Server Error 87ms]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 02:58:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 01:58:27 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-xog0wwNUn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
I'm getting an error trace after applying the patch and restarting everything
(flush_memcached and restart_all, using koha-testing-docker)(step 7):

try() encountered an unexpected argument (undef) - perhaps a missing semi-colon
before or at /kohadevbox/koha/Koha/Plugins.pm line 251.
 at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289
....

Testing with the ByWater Solutions kitchen sink plugin.

Before applying the patch, I can install plugins without any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:02:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:02:50 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-6aW6TLUjK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:02:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:02:54 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-Cbk2mI8Jrm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143387|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 143613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143613&action=edit
Bug 32130: Add a test to ensure vue files will be kept tidy

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:03:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:03:59 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-AgHdQtVQy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Tested (using KTD) by running prove xt/vue_tidy.t

I hope that is sufficient.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:17:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:17:19 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-JupyPAexJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:17:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:17:23 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-El8ZvFOwXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143160|0                           |1
        is obsolete|                            |

--- Comment #42 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143614&action=edit
Bug 31692: Add Koha::Hold::change_type and unit tests

To test:
1. prove t/db_dependent/Koha/Hold.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:17:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:17:28 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-3n97Rf739C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143161|0                           |1
        is obsolete|                            |

--- Comment #43 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143615&action=edit
Bug 31692: Allow librarians to change hold type in staff client

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown value has changed from "Only item <barcode>" to
   "Next available"
8. Cancel the hold and add two item level holds
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:17:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:17:33 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-AMDy0evssn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143162|0                           |1
        is obsolete|                            |

--- Comment #44 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143616&action=edit
Bug 31692: (follow-up) Adjust reserves.item_level_hold

Original patch missed handling reserves.item_level_hold column.

To test:
1. prove t/db_dependent/Koha/Hold.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:20:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:20:50 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-uM3dX39XvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #267 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #266)
> The third patch introduced it.

Ahhh, I see it now. I expected it to be in the usual alphabetical order, but I
do see it now. All good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:24:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:24:13 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-hRrgmMqOhV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #45 from Lari Taskula <lari.taskula at hypernova.fi> ---
I accidentally removed the signed-off lines from patches, fixing...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:29:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:29:08 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-7J4IxXr0kY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:29:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:29:11 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-UB6PmLG76W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143614|0                           |1
        is obsolete|                            |

--- Comment #46 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143617&action=edit
Bug 31692: Add Koha::Hold::change_type and unit tests

To test:
1. prove t/db_dependent/Koha/Hold.t

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:29:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:29:18 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-4XcN9sNlJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143615|0                           |1
        is obsolete|                            |

--- Comment #47 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143618&action=edit
Bug 31692: Allow librarians to change hold type in staff client

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown is gone and cell value has changed from
   "Only item <barcode>" to "Next available"
8. Cancel the hold and add two item level holds for the same patron
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:29:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:29:24 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-bELxTd3OIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143616|0                           |1
        is obsolete|                            |

--- Comment #48 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 143619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143619&action=edit
Bug 31692: (follow-up) Adjust reserves.item_level_hold

Original patch missed handling reserves.item_level_hold column.

To test:
1. prove t/db_dependent/Koha/Hold.t

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 03:30:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 02:30:12 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-NuRCN1Sohe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #49 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to David Nind from comment #40)
> I've ended up adding sign off lines for the first two patches - not sure how
> to remove those!

I've removed those for you.

(In reply to Katrin Fischer from comment #41)
> There is a conflict in the .t, can you please fix?

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:08:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:08:29 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-ob08BxzXnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #10)
> Is it expected that the search doesn't work with cardnumber? Or is it
> because 42 is too short an input?

The autocomplete starts at 3 chars, yes. Is that a problem?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:11:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:11:41 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-zhYS4zsQUG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
           Keywords|                            |rel_22_11_candidate
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |pjamorim91 at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:22:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:22:38 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-bx0zxNtiz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #12 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Setting this as Needs Signoff, notice form shouldn't now be saved when pressing
cancel on pop-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:34:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:34:39 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-b2GR5m6q9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |
        released in|                            |

--- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #39)
> (In reply to Marcel de Rooy from comment #36)
> > File not found : js/vue/dist/main.js at
> > /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84.
> > 
> > Does this module not work on a dev install ?
> 
> `yarn build_js` will generate it
> Should have been done by Tomas, as we agreed on...

This was wrong, we agreed on generating them at releasing time. See
https://lists.koha-community.org/pipermail/koha-devel/2022-November/047385.html
for more details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:35:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:35:10 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-e7kbwAoBnd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:35:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:35:14 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-rf6JsfrpaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143565|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143620&action=edit
Bug 32154: Missing primary key on erm_user_roles table

The aforementioned TestBuilder should display "Koha::ERM::UserRole", not be
empty. This patch adds a primary key to the erm_user_roles table and fixes
that.
Also includes atomicupdate file to update database schema as well as updates to
kohastructure.sql provided by Jonathan Druart.
Looked into the vue files but didn't find anywhere or a need to include the new
primary key in any of the requests as there is no request of users by
role_user_id being made.
Erm users are being created/updated as a relationship through
licenceses/agreements. Furthermore, when editing a role of an existing user,
this new primary key is already being supplied embeded in the
license/agreement.

Test plan:
Add users to license and agreement
Run the cypress tests
Confirm that the change fix the test that was failing in TestBuilder.t
(another one may still fail however)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:36:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:36:16 +0000
Subject: [Koha-bugs] [Bug 32161] New: ErmEholdingsPackagesAgreement has
 wrong koha_object_class
Message-ID: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

            Bug ID: 32161
           Summary: ErmEholdingsPackagesAgreement has wrong
                    koha_object_class
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:36:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:36:16 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-xTVvdhdVTf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161
[Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:37:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:37:43 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-ZccEcwa8sn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:37:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:37:47 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-XkcE4BaBRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143621&action=edit
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for
ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:37:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:37:56 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-c584sWUQJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:51:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:51:08 +0000
Subject: [Koha-bugs] [Bug 32162] New: erm_eholdings_packages_agreements does
 not have a primary key
Message-ID: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

            Bug ID: 32162
           Summary: erm_eholdings_packages_agreements does not have a
                    primary key
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030

And TestBuilder.t is failing because of this.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 07:51:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 06:51:08 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-27YYSP8ltE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162
[Bug 32162] erm_eholdings_packages_agreements does not have a primary key
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:09:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:09:16 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-alGzDkA12K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:09:20 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-hynsMxapmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143622&action=edit
Bug 32162: Add primar key to erm_eholdings_packages_agreements

Test plan:
Confirm that this change fixes the related TestBuilder.t failure
Confirm that it does not break the eRM app, try to attach an agreement
to a package.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:14:51 +0000
Subject: [Koha-bugs] [Bug 32163] New: ErmUserRole has wrong
 koha_object[s]_class
Message-ID: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

            Bug ID: 32163
           Summary: ErmUserRole has wrong koha_object[s]_class
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:14:51 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-9QxbkOQ1ce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163
[Bug 32163] ErmUserRole has wrong koha_object[s]_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:15:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:15:16 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-G36ejXTndg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32154
           Keywords|                            |rel_22_11_candidate


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154
[Bug 32154] Missing primary key on erm_user_roles table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:15:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:15:16 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-LWazWJKdi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163
[Bug 32163] ErmUserRole has wrong koha_object[s]_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:15:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:15:52 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-VEx6smsI37@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:17:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:17:13 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-3APKPddaJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:17:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:17:17 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-iNeVffEhNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143623&action=edit
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:17:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:17:54 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-DeYrp8ceZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154
[Bug 32154] Missing primary key on erm_user_roles table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 08:17:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 07:17:54 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-l340BbA3oc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 09:04:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 08:04:54 +0000
Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves in
 staff
In-Reply-To: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24192-70-BKxm2qKzC5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96104|0                           |1
        is obsolete|                            |

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143624&action=edit
Bug 24192: Show host record items in basket/shelves

If EasyAnalyticalRecords is enabled, and if record has no items, display
host record items in baskets and lists (staff interface only)

Test plan:
0. Login to staff interface
1. Set EasyAnalyticalRecords to "Display"
2. Create a biblio record without items
3. On the biblio record detail page, click in the menu Edit > Link
to host item, and enter a valid barcode
4. Add the biblio record to your cart
5. Open your cart and verify that the linked item is displayed
6. Add the biblio record to a list
7. Open the list and verify that the linked item is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 09:06:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 08:06:00 +0000
Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves in
 staff
In-Reply-To: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24192-70-PG0TRTd8zB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Rebased on master and removed the parts related to enumchron (this will go in a
separate bug)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 09:45:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 08:45:49 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32134-70-ql8UbCBBoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 09:45:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 08:45:54 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32134-70-FztysQpzxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143393|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143625&action=edit
Bug 32134: Show the bundle size when checked out

When checking out a bundle, it can be useful to know the number of items
in this bundle, so that librarians can quickly check if items are
missing.

Test plan:
1. Create a bundle (see bug 28854 comment 458)
2. Check out the bundle.
3. Verify that you have the bundle size in the message below the barcode
   input ("Checked out: [...]. Bundle of X items. Due on [...]")
4. Checkout an item that is not a bundle.
5. Verify that the bundle message does not appear

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:12:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:12:57 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-dpDSQBMisa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:14:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:14:15 +0000
Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the
 order was placed/sent to the vendor
In-Reply-To: <bug-14083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14083-70-ptvvccYfbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083

--- Comment #11 from Maura Stephens <maura.stephens at gmit.ie> ---
Just reviewing my calls and this is still an issue for us here. Not sure what
developers have in mind. My ideal in Koha would be to get rid of baskets
altogether, they serve no function other than batching orders to send out, but
the reopening and closing is not a useful acquisitions function. If one order
at a time needed to be modified that should be fine, perhaps a modify date
added. Anyhow just want to keep this requirement on the horizon for those of us
tied into Acquisitions framework agreements.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:16:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:16:48 +0000
Subject: [Koha-bugs] [Bug 32164] New: Add link to MARC modification
 templates to batch record modification page
Message-ID: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164

            Bug ID: 32164
           Summary: Add link to MARC modification templates to batch
                    record modification page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When no MARC modification templates are defined and you open up the page for
the batch record modification, we show a hint:

/cgi-bin/koha/tools/batch_record_modification.pl

No MARC modification template is defined. You have to create at least one
template for using this tool. 

It would be nice if we linked to the MARC modification tools there directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:20:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:20:05 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-d4W5yNGtpj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:20:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:20:09 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-edM6y4KnWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143612|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143626&action=edit
Bug 32102: Improve specificity of batch record modification breadcrumbs

This patch makes a minor change to the batch record modification
template so that there is a link back to the initial view after you have
submitted a batch for modification.

To test, apply the patch and go to Cataloging -> Batch record
modification.

- Initially the breadcrumbs menu should show Home -> Cataloging -> Batch
  record modification
- Submit a batch of bibliographic or authority records for modification
- The breadcrumbs should now read Home -> Cataloging -> Batch record
  modification -> Results
- The same menu options should show after you confirm the operation

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:20:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:20:29 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-2qtOtuflaJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Depending on time frame: this has some string changes/additions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:31:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:31:24 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-saP0bPm5Rn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed on master as of this morning.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:35:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:35:46 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-GeG7QWm2FZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:36:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:36:03 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-hr478toaex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143617|0                           |1
        is obsolete|                            |

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143627&action=edit
Bug 31692: Add Koha::Hold::change_type and unit tests

To test:
1. prove t/db_dependent/Koha/Hold.t

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:36:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:36:23 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-u38i25fqiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143618|0                           |1
        is obsolete|                            |

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143628&action=edit
Bug 31692: Allow librarians to change hold type in staff client

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown is gone and cell value has changed from
   "Only item <barcode>" to "Next available"
8. Cancel the hold and add two item level holds for the same patron
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:36:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:36:32 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-ujYgF9wfns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143619|0                           |1
        is obsolete|                            |

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143629&action=edit
Bug 31692: (follow-up) Adjust reserves.item_level_hold

Original patch missed handling reserves.item_level_hold column.

To test:
1. prove t/db_dependent/Koha/Hold.t

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:38:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:38:58 +0000
Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to
 record level holds when possible
In-Reply-To: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31692-70-5Cl9TuwEYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the quick fix, Lari. This has some string changes, so not sure if we
can still make it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:40:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:40:30 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-gA7Vd6g0rB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:40:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:40:34 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-HRCvk4qghn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143518|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143630&action=edit
Bug 32071: Consistent classes for primary buttons: Catalog

This patch makes changes the button markup in Catalog
templates -- including the Cart -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

Edit: This revised patch changes the button styles on the search history
page to make them more consistent with buttons in similar interfaces
(see catalog search results).

The patch also adds Bootstrap size classes to the item detail page and
removes some global CSS which targeted buttons on that page.

To test, apply the patch and view pages the catalog to confirm
that everything looks correct. In most cases there are no visible
changes.

- Advanced search: The main search button at the top
- Search results: The "Search within results" submit button
- Bibliographic detail page: This change is to a hidden button. This
  section can be removed in a separate bug.
- Bibliographic detail page -> Items: Various "Update" and "Set status"
  buttons. Note that the alignment of buttons has not changed in the
  redesign.
- Item search: The main search button at the top
- Search history (from the logged-in user's menu in the top right):
  "Delete" buttons in each section
   - Catalog -- Current and previous sessions
   - Authority -- Current and previous sessions
- In the Cart popup window, click "Send." In the resulting popup, the
  "Send button.
- The template basket/downloadcart.tt has been modified but I think the
  template might be unused.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:48:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:48:31 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-Ed4JNPun82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Jonathan Field <jonathan.field at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.field at ptfs-europe.
                   |                            |com

--- Comment #11 from Jonathan Field <jonathan.field at ptfs-europe.com> ---
(In reply to Martin Renvoize from comment #4)
> Must admit.. I don't know what the standard terms are here really.. 
> 
> I feel like it's an abbreviation and should be 'ERM' or 'Electronic resource
> management'.. 'E-resource management' feels strange to look at.. 'e-resource
> management' not so strange, but doesn't capitalise well for sentence case.

There's actually a reason behind this! Electronic Resource Management is really
the proper term but, when we used that initially, the string was so long that
it looked very odd on the dropdown menu and the Koha Home screen. So we
shortened!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 10:51:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 09:51:08 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-kfQK23VnUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I completely understand about avoiding the longer form, but the capital R is
what triggers me as it stands out in the interface now going against our rules. 

For me this would work like e-mail, e-commerce, e-resource... e-journal.

It's not a name, it's not an abbreviation and the dictionaries suggest the
lower r.

We refer to that dictionary on
https://wiki.koha-community.org/wiki/Terminology.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:03:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:03:22 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-6dhFJ3i37x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:04:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:04:19 +0000
Subject: [Koha-bugs] [Bug 29996] Show an alert on main page when serial
 issues are late
In-Reply-To: <bug-29996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29996-70-wVqN7kjeWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130045|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143631&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
4. Go back to the main page. You should see an alert with a link to your
   subscription
5. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
6. Set your library back to its original value to make the alert
   reappear.
7. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:06:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:06:31 +0000
Subject: [Koha-bugs] [Bug 29996] Show an alert on main page when serial
 issues are late
In-Reply-To: <bug-29996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29996-70-kvP79ZogTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Owen Leonard from comment #2)
> The method Koha::Serials->subscriptionid is not covered by tests!

It was caused by the changes of bug 29844. I added the now required 'as_list'
call and it works again :)
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:12:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:12:16 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-DPyEQ8fynU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:12:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:12:21 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-oNtskoxSkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143630|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143632&action=edit
Bug 32071: Consistent classes for primary buttons: Catalog

This patch makes changes the button markup in Catalog
templates -- including the Cart -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

Edit: This revised patch changes the button styles on the search history
page to make them more consistent with buttons in similar interfaces
(see catalog search results).

The patch also adds Bootstrap size classes to the item detail page and
removes some global CSS which targeted buttons on that page.

To test, apply the patch and view pages the catalog to confirm
that everything looks correct. In most cases there are no visible
changes.

- Advanced search: The main search button at the top
- Search results: The "Search within results" submit button
- Bibliographic detail page: This change is to a hidden button. This
  section can be removed in a separate bug.
- Bibliographic detail page -> Items: Various "Update" and "Set status"
  buttons. Note that the alignment of buttons has not changed in the
  redesign.
- Item search: The main search button at the top
- Search history (from the logged-in user's menu in the top right):
  "Delete" buttons in each section
   - Catalog -- Current and previous sessions
   - Authority -- Current and previous sessions
- In the Cart popup window, click "Send." In the resulting popup, the
  "Send button.
- The template basket/downloadcart.tt has been modified but I think the
  template might be unused.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:12:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:12:57 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-nwaNsLQrHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:15:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:15:38 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-ROtWgZuoi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #13 from Jonathan Field <jonathan.field at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #12)
> I completely understand about avoiding the longer form, but the capital R is
> what triggers me as it stands out in the interface now going against our
> rules. 
> 
> For me this would work like e-mail, e-commerce, e-resource... e-journal.
> 
> It's not a name, it's not an abbreviation and the dictionaries suggest the
> lower r.
> 
> We refer to that dictionary on
> https://wiki.koha-community.org/wiki/Terminology.

Fine, let's go with your proposal then!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:15:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:15:42 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-dpmzEIKLuq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:15:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:15:46 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-ThcibXzHR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143419|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143633&action=edit
Bug 31752: Move hidden input fields

There didn't appear to be any reason to have the hidden form fields here
nested in the ordered list and they were causing undesired styling
issues.

This patch simply moves them to the beggining of the fieldset.

Test plan
1) Confirm the 'HTML message' label now aligns correctly

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:18:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:18:56 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-YhLg8k9raG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:19:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:19:00 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-5Bt4X42xTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143447|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143634&action=edit
Bug 32005: Remove stack unordered lists

Not sure why, but we had two unordered list elements stacked on top of
each other here instead of just one overall list.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:19:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:19:04 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-OBs2Dls6kN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143448|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143635&action=edit
Bug 32005: Cleanup indenting

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:19:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:19:40 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-WqhJDq09lW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The indenting patch could in theory affect translations (not sure how much
change is needed to trigger a fuzzy)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:20:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:20:43 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to items tab (cat)
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-KSqBzjbHXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:25:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:25:17 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-zhrdP7mJ3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:25:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:25:21 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-rHuhv30AdR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142951|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143636&action=edit
Bug 32072: Consistent classes for primary buttons: Cataloging

This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:30:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:30:50 +0000
Subject: [Koha-bugs] [Bug 31406] Set focus for cursor to Name input when
 adding a new item search field
In-Reply-To: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31406-70-l8m0B1rsCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It should work... but it's also not working for me :(

In Firefox the cursor is somewhere outside the input field and I can't type.
In Chrome the cursor is 'nowhere'.

Adding Owen, maybe he has an idea why the focus class would not work here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:31:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:31:08 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to items tab (cat)
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-PUE3kUzRc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |oleonard at myacpl.org
                   |.com                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:31:35 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to items tab (cat)
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-tVqVEy9iUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, I tried to take a look at this one and found the template insanely
confusing... I gave up :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 11:59:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 10:59:41 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-fTeILt8di3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co
                   |com                         |m
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:01:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:01:39 +0000
Subject: [Koha-bugs] [Bug 32165] New: Add page-section to some catalog pages
Message-ID: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

            Bug ID: 32165
           Summary: Add page-section to some catalog pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952
            Blocks: 31757

This bug aims to catch any low hanging fruit on the pages linked from the left
side menu when viewing a catalog detail page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:01:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:01:39 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-9P5aAmyNml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165
[Bug 32165] Add page-section to some catalog pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:01:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:01:39 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-iKjy5C7JNy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165
[Bug 32165] Add page-section to some catalog pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:01:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:01:54 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-Oj3pBeLNYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:02:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:02:39 +0000
Subject: [Koha-bugs] [Bug 29997] Allow to send email notification when a
 serial issue is late
In-Reply-To: <bug-29997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29997-70-le1lwlD9Lm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130048|0                           |1
        is obsolete|                            |

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 143637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143637&action=edit
Bug 29997: Allow to send email notification when a serial issue is late

This patch adds the ability to define, for each subscription, a letter
that will be sent whenever an issue is automatically marked as late by
the script misc/cronjobs/serialsUpdate.pl.
If no letter is defined for a subscription, then no letter will be sent.

The letter will be sent to the subscription's manager (the staff
member who created or last modified the subscription).

Test plan:
1. Run updatedatabase.pl and update_dbix_class_files.pl
2. Create a letter in Tools › Notices & slips for module "Serials". Fill
   the Email template.
3. Create a new subscription, with a grace period of 1 day, and set the
   new field "Late issue notification" to the letter you just created.
   Set the first issue publication date and subscription start date to
   two days ago
4. Run `misc/cronjobs/serialsUpdate.pl -v -c`.
5. The first serial issue of your subscription should have been
   automatically marked as late. Now verify that the table message_queue
   contains a new message corresponding to this serial issue. The
   message's contents should be what you defined in step 1.
   The message should be addressed to the subscription's manager (you)

Technical note:
   The "subscription" table contained a column named "librarian", which
   contained the userid of the patron who created or last modified the
   subscription, but there was no foreign key constraint referencing the
   borrowers table. So this patch also adds a new column "manager_id"
   which contains the borrowernumber of the patron who created or last
   modified the subscription, and it also adds the foreign key
   constraint.  The atomicupdate script tries to fill the new
   "manager_id" column by searching patrons by their "userid", which
   might fail, so it's normal to have some NULL values in "manager_id"
   at the end. The "librarian" column is removed at the end of the
   script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:03:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:03:25 +0000
Subject: [Koha-bugs] [Bug 29997] Allow to send email notification when a
 serial issue is late
In-Reply-To: <bug-29997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29997-70-RsuXYfSuoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased on master + fixed a bug (hardcoded letter code)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:04:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:04:01 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-BcqwT9qnd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143638&action=edit
Bug 32165: Add page-section to labeledMARCdetail

Test plan
1) Confirm that page-sections now appear as expected on the labeled marc
   view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:04:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:04:06 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-dNEjpFsPjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143639&action=edit
Bug 32165: Add page-section to ISBDdetail

We fix some whitespace and move the toolbar above the H1 too.

Test plan
1) Confirm the headings and page-sections now look correct on the ISBD
   details view

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:04:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:04:10 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-t0OeAnxaAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143640&action=edit
Bug 32165: Add page-section to issuehistory

Test plan
1) Confirm the issue history view now uses page-section appropriately

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:04:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:04:57 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-KOFvWmlMch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Quick self signoff to hit the QA queue.. I deliberately missed the items detail
page as that's already got a bug associated to it and is non-trivial to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:05:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:05:03 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-Rh4vgAVhD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:25:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:25:23 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-rZrGODxXka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143641&action=edit
Original

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:27:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:27:07 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-KZuxotJdyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm.. we're going in the right direction, but it still feels a bit weird.. not
sure flex 25% is the way to go.. as David points out.. on a wide screen it
shifts the content to look 'centered' which feels a bit strange.. I think I'd
rather see a more fixed width for all the labels...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:37:30 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-uFSHKFHTiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #36 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143642&action=edit
Bug 8948: (follow-up) Remove 580 display from 787

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:44:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:44:42 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-VTpyKwsPDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:46:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:46:07 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-zkpndIrqtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit
                   |.com                        |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 12:48:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 11:48:29 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-O5AUKTojoT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:01:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:01:32 +0000
Subject: [Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs
In-Reply-To: <bug-30917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30917-70-dUNLSH8NYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

--- Comment #9 from Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> ---
I don't think this requires an update to the documentation, marked Resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:05:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:05:03 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-wBunT6OvbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> ---
I don't think this requires an update to the documentation, marked Resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:06:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:06:38 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-1FfFCJ3Dv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Just thinking about this one, it feels to me like it should be a multi-field
primary key rather than a new field entirely.

Having said that, it looks like we allow a user + licence + agreement
combination to have multiple roles?  That would mean having all four fields in
the primary key... food for thought.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:13:20 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-FcfcMADAho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143608|0                           |1
        is obsolete|                            |

--- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143643&action=edit
Bug 31699: (follow-up) Protect more against open redirects

This change checks that the OPACBaseURL exists, and uses its scheme
and authority to rewrite the URL passed through the "return"
param.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:18:05 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-VN4Fk1C724@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for working on this David, your follow-up is indeed a much more thorough
way of doing things.. my approach was a little lazy.

Works great,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:20:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:20:27 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-xbavHdVbkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Katrin, does the follow-up answer your concerns?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:31:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:31:53 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-6hm1FSoIGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:31:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:31:57 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-bGKLnAKThZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143644&action=edit
Bug 32145: Fix style of buttons with class .btn-danger

This patch adds style to the staff client's global SCSS which adds
correct styling to buttons classed with .btn-danger.

This isn't the correct way to fix this, but it's the fast way.
Rebuilding Bootstrap with custom colors is the correct way, but
Bootstrap 3.x doesn't use SCSS. I consider this is a FIXME for an
upgrade of Bootstrap in the staff interface.

To test, apply the patch and rebuild the staff interface CSS. Test
instances where the .btn-danger class is used. Two examples:

Holds:

- Locate a bibliographic records with holds and view the holds.
- Click the "trash" icon to delete one of the holds.
- In the confirmation modal, check that the "Confirm cancellation"
  button looks correct in its default, hover, and active ("clicked")
  state.

Cataloging:

- Open a new blank record in the basic MARC editor.
- Click "Save" without filling any mandatory fields.
- You should see a warning about the empty fields.
- Scroll down until the warning is offscreen. An "Errors" button should
  appear in the toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:32:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:32:12 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-4Bh2JF25m5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143622|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143645&action=edit
Bug 32162: Add primar key to erm_eholdings_packages_agreements

Test plan:
Confirm that this change fixes the related TestBuilder.t failure
Confirm that it does not break the eRM app, try to attach an agreement
to a package.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 13:50:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 12:50:49 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-TW4DhFV7C8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|pedro.amorim at ptfs-europe.co |jonathan.druart+koha at gmail.
                   |m                           |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:03:31 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-auzCVLj8pU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #324 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Nind from comment #323)
> 1. OPAC redirect to log in:

This was because of the work that happened on 21699 between times.. I've got a
fix ready here now and will upload shortly.

> 2. Catalog concerns landing page: the filter for the Status column doesn't
> seem to work:
>   - Have two catalog concerns - one open and one closed
>   - For the status column filter, start typing Open
>   - No results shown

This one is much harder.. searches happen serverside and run against the
'resolved_date' right now (i.e A search for the displayed words won't work as
it's expecting to search on a date).  It highlighted to me that I also display
resolver name so we should fire against the firstname and lastname fields for
the resolver (So a search for 'David' would filter.. but this doesn't help with
a search for 'Open' still and I have no clear way around that.. we do have the
filter at the top of the page especially for this reason though..)

Should  just remove searching for that field do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:13 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-ZNDfXfAspI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Is this PQA or In discussion?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:39 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-2352jl9ApO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:42 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-tI7WqoQjy3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:45 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-kqHtB8nlyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:48 +0000
Subject: [Koha-bugs] [Bug 31752] Alignment of labels in notices is wonky
In-Reply-To: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31752-70-HRPcEfF1my@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31752

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:51 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-HMeeLYggva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:54 +0000
Subject: [Koha-bugs] [Bug 31823] Add page-section to uncertain prices page
 (acq)
In-Reply-To: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31823-70-MvrBtFgIU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31823

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:05:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:05:57 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-NSFXFczenN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:01 +0000
Subject: [Koha-bugs] [Bug 31824] Add page-section to list of
 pending/received orders (acq)
In-Reply-To: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31824-70-UgrYpH5DcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31824

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:04 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-4I8UmpdpPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:07 +0000
Subject: [Koha-bugs] [Bug 31826] Add page-section to item form on order
 receive page (acq)
In-Reply-To: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31826-70-s3kljWbTjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31826

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:11 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-WeXMyD4KhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:14 +0000
Subject: [Koha-bugs] [Bug 31827] Add page-section to list to log viewer
In-Reply-To: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31827-70-oJqDbbh3Ol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:17 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-dbFaRuasxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:20 +0000
Subject: [Koha-bugs] [Bug 31828] Add page-section to list of open invoices
 on receive shipment page (acq)
In-Reply-To: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31828-70-3pZJFHkWzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:23 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-Ix5akE9bbv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:26 +0000
Subject: [Koha-bugs] [Bug 31928] Add page-section to callnumber browser
 value builder (cat)
In-Reply-To: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31928-70-SxWUNLO3Lj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:29 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-ovY30X8Shl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:33 +0000
Subject: [Koha-bugs] [Bug 32005] Spacing between entries in left side
 navigation on staff catalog detail page is uneven
In-Reply-To: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32005-70-O0K9v4BCOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32005

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:35 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-NCnjpGJGXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:39 +0000
Subject: [Koha-bugs] [Bug 32071] Consistent classes for primary buttons:
 Catalog
In-Reply-To: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32071-70-Ym4ZDivc0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:42 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-XXJOSyPRcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:45 +0000
Subject: [Koha-bugs] [Bug 32101] Add padding to floating toolbars
In-Reply-To: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32101-70-dR1hj0CjwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:48 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-tutLje0rLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:51 +0000
Subject: [Koha-bugs] [Bug 32146] Add page-section to course reserves
In-Reply-To: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32146-70-PJ1DSaxpWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32146

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:54 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-haORGHo2MQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:06:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:06:57 +0000
Subject: [Koha-bugs] [Bug 32148] Buttons must inherit Bootstrap size classes
In-Reply-To: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32148-70-IvgHOdrdVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:10:12 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-eajTA6pK8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:10:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:10:15 +0000
Subject: [Koha-bugs] [Bug 32043] Circulation alerts can overlap other
 elements on smaller screens
In-Reply-To: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32043-70-Ph8dIeVgFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32043

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:10:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:10:18 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-45hgV8tjOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:10:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:10:20 +0000
Subject: [Koha-bugs] [Bug 32102] Improve specificity of batch record
 modification breadcrumbs
In-Reply-To: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32102-70-dDpAP4LTlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32102

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:12:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:12:48 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-NrDMRJ7tST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:12:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:12:56 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-HbgpxN8W81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:14:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:14:35 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-uLfaivnZP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |
        released in|                            |
           Keywords|additional_work_needed      |

--- Comment #38 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
My mistake, I hadn't pushed this. Waiting for Katrin to answer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:17:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:17:42 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-Rp22UT1PBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

--- Comment #25 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143646&action=edit
Bug 28726: Add sort1 and sort2 to patron card creator - patron search.

Also adds a select all / clear all and checkboxes.

Test plan:

1. start a new batch in the patron card creator (Tools -> Patron card creator
-> New -> card batch)
2. click the Add patron(s) button.  Observe that Category and Library are the
only options.
3. Close search for patron window.
4. Apply patch.
5. click the Add patron(s) button.  Observe that you can now search for patrons
by their sort1 and sort2 values.
6. perform a search and observe the 'Select all | Clear all | Add selected
patrons' links and button.
7. use the Select all link to select all the patrons found by the search.
8. use the Add selected patrons button to add the selected patrons to the card
batch's Add by borrowernumber(s) text input field.
9. close the search for patron window.

Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:19:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:19:23 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-AMboonURHs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Laura <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Laura.escamilla at bywatersolu
                   |                            |tions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:22:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:22:27 +0000
Subject: [Koha-bugs] [Bug 31853] The Overdue-tab states "no renewals left"
 when item is on hold
In-Reply-To: <bug-31853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31853-70-O4KeB9nh8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31853

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:46:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:46:45 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-PP2hQEKOuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143470|0                           |1
        is obsolete|                            |

--- Comment #325 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143647&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:46:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:46:56 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-FDEGRrxzE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143471|0                           |1
        is obsolete|                            |

--- Comment #326 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143648&action=edit
Bug 31028: DBIC Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:06 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-0nkhLbLBdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143472|0                           |1
        is obsolete|                            |

--- Comment #327 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143649&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:15 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-KfNbLfUyvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143473|0                           |1
        is obsolete|                            |

--- Comment #328 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143650&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:23 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-GQ9MWNGIx7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143474|0                           |1
        is obsolete|                            |

--- Comment #329 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143651&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:31 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-VOBI15Pl5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143475|0                           |1
        is obsolete|                            |

--- Comment #330 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143652&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:39 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-LRmqkbvBZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143476|0                           |1
        is obsolete|                            |

--- Comment #331 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143653&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:47 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-pCZmVXDELN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143477|0                           |1
        is obsolete|                            |

--- Comment #332 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143654&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:47:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:47:56 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ujfoMSoR1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143478|0                           |1
        is obsolete|                            |

--- Comment #333 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143655&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:04 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-Gs9ojhcgc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143479|0                           |1
        is obsolete|                            |

--- Comment #334 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143656&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional cataloger notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CatalogerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CatalogerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:12 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-W4FrBeNBO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143480|0                           |1
        is obsolete|                            |

--- Comment #335 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143657&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:20 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-sBUovSuwVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143481|0                           |1
        is obsolete|                            |

--- Comment #336 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143658&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:28 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-xhlrqkC4Be@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143482|0                           |1
        is obsolete|                            |

--- Comment #337 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143659&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:36 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-LVVHMg0tfa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143483|0                           |1
        is obsolete|                            |

--- Comment #338 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143660&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:44 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-VJkJmNKBaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143484|0                           |1
        is obsolete|                            |

--- Comment #339 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143661&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:48:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:48:52 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-rFtYqTqrrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143485|0                           |1
        is obsolete|                            |

--- Comment #340 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143662&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:49:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:49:00 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-fwcDWZmvxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143486|0                           |1
        is obsolete|                            |

--- Comment #341 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143663&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:49:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:49:08 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-RWLbTToj2R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143487|0                           |1
        is obsolete|                            |

--- Comment #342 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143664&action=edit
Bug 31028: Add feedback to the patron on submission

This patch adds a success alert box when a patron submits a concern
sucessfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:49:17 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-09I4OdhDfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143488|0                           |1
        is obsolete|                            |

--- Comment #343 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143665&action=edit
Bug 31028: (follow-up) Fix permissions names

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:49:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:49:24 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-UUrkHFZBHV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143489|0                           |1
        is obsolete|                            |

--- Comment #344 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143666&action=edit
Bug 31028: (follow-up) Add <br> to notices

This should resolve the lack of linebreaks in resulting emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:49:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:49:32 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-MRjKsAyy4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143490|0                           |1
        is obsolete|                            |

--- Comment #345 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143667&action=edit
Bug 31028: (follow-up) Fix template whitespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:50:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:50:08 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-8nxLFsqU51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143667|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:53:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:53:11 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-49KDcVTuvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #346 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for all your testing David,

Hopefully this last rebase has the redirects working properly again.

As for the searching issue on the Status column, I've got it searching on
firstname, surname and date but I can't easily add a special case for 'Open' vs
'Resolved'.. but there are the filters at the top of the page for that.. I
think this one will have to just come down to training.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 14:53:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 13:53:19 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-rmPfPioai7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi, I'm still not convinced, to be honest. In production it is common to use
several domain names for the same Koha instance, and I don't think sticking to
OpacBaseURL is enough for that use case.

In my opinion, using OpacBaseURL as a fixed value (instead of an allow-list) is
a design mistake because of what I mentioned above.

We should somehow be using x-forwarded-for or similar header.

I know solving it is not this bug's responsability. But I think we should be
able to find a nicer approach.

That said, this is a bugfix and we can still think about it and if it doesn't
make it to the release date it will be backported for sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:31:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:31:46 +0000
Subject: [Koha-bugs] [Bug 32153] Wrong link for help for systempreferences
 in 22.05 and below
In-Reply-To: <bug-32153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32153-70-YexXry9tv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32153

Anke <anke.bruns at gwdg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |anke.bruns at gwdg.de

--- Comment #1 from Anke <anke.bruns at gwdg.de> ---
This will be corrected in 22.11, see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465.

Meanwhile, you might edit 

/usr/share/koha/lib/Koha/Manual.pm

as a workaround and change the lines:

    'admin/preferences'                        => '/globalpreferences.html',

(from systempreferences.html) 

and 

    'admin/systempreferences'                  => '/localusepreferences.html'

(from systempreferences.html#local-use).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:34:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:34:57 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-Ih18sj6YNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

Olivier Hubert <olivier.hubert at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:35:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:35:00 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-dxdJFr3Cuj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

Olivier Hubert <olivier.hubert at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143445|0                           |1
        is obsolete|                            |

--- Comment #4 from Olivier Hubert <olivier.hubert at inlibro.com> ---
Created attachment 143668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143668&action=edit
Bug 31074: Reload a plugin's module before installation

When using Plack, memcached or another caching mechanism, a plugin's old
version is retained
in the cache, even when uninstalled. If the plugin is then reinstalled, the old
version is
used, no matter the version installed. To prevent this, the plugin's module is
reloaded every
time it is installed.

To test:
1) Install a plugin, like the kitchen sink.
   https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases
2) Modify the .kpz and in KitchenSink.pm, change MINIMUN_VERSION.
3) Uninstall the plugin.
4) Install the new version.
5) The Minimum Koha version column still lists the old version.
6) Apply patch.
7) Repeat steps 1 through 4.
8) Observe that the Minimum Koha version column lists the correct version.
9) Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:39:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:39:56 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-dUYcCYA4B7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #5 from Olivier Hubert <olivier.hubert at inlibro.com> ---
Patch is updated and working now, sorry about the fluke.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:47:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:47:24 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-GiErKQwIRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143669&action=edit
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken

I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.

To test, apply the patch and view a basket in Acquisitions.

- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:49:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:49:58 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-BqrH0tQHPc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143388|0                           |1
        is obsolete|                            |

--- Comment #50 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143670&action=edit
Bug 16223: Add new columns to table restriction_types

This patch adds two new columns, lift_after_payment and fee_limit,
to table restriction_types. These colums are used to control
lifting patrons restrictions after paying their fees.

To test:
1. Apply this patch.
2. Update your database via updatedatabase.pl.
=> Confirm your table restriction_types has two new columns.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:50:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:50:04 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-TvtcQceP8z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143389|0                           |1
        is obsolete|                            |

--- Comment #51 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143671&action=edit
Bug 16223: DO NOT PUSH! Schema changes

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 15:50:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 14:50:10 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-7MeXA5B31g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143462|0                           |1
        is obsolete|                            |

--- Comment #52 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143672&action=edit
Bug 16223: Add ability to define liftable restrictions

Some libraries debar Patrons at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Patron has paid his/her fines.

This patch adds ability to create restrictions which are lifted after
patron pays ceratain amount of fines.

To test:
1. Apply this patch.
2. Restart your services if needed.
3. Navigate to page restrictions.pl.
=> Note that table has two new colums in it, "Lift after payment?" and "Fee
limit".
4. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
5. Create fees for a patron so they exceed fee limit e.g. 10
6. Add restriction made in step 2. for the patron
7. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:00:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:00:18 +0000
Subject: [Koha-bugs] [Bug 32166] New: When adding to a basket from a staged
 file we may use the wrong inputs
Message-ID: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

            Bug ID: 32166
           Summary: When adding to a basket from a staged file we may use
                    the wrong inputs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On addorderiso2709.pl we loop over the records in the staged batch:
    for my $biblio (@$biblios){
        $biblio_count++;

skipping any not selected, which inlcudes any already imported:
        next if not grep { $_ eq $$biblio{import_record_id} }
@import_record_id_selected;

Later we use that count to find the inputs:
        my @homebranches = $input->multi_param('homebranch_' . $biblio_count);

The problem being that if a record is already imported, our count increases,
but the input on the page still counts from 1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:08:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:08:40 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-OJUBSfGmPz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:19:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:19:20 +0000
Subject: [Koha-bugs] [Bug 15404] CanBookBeReserved: No count of biblio level
 holds if ReservesControlBranch is item's home library
In-Reply-To: <bug-15404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15404-70-ni6M9YPnmK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:22:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:22:16 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-sbcX7AANqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:22:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:22:21 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-v6cAUgSa6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143644|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143673&action=edit
Bug 32145: Fix style of buttons with class .btn-danger

This patch adds style to the staff client's global SCSS which adds
correct styling to buttons classed with .btn-danger.

This isn't the correct way to fix this, but it's the fast way.
Rebuilding Bootstrap with custom colors is the correct way, but
Bootstrap 3.x doesn't use SCSS. I consider this is a FIXME for an
upgrade of Bootstrap in the staff interface.

To test, apply the patch and rebuild the staff interface CSS. Test
instances where the .btn-danger class is used. Two examples:

Holds:

- Locate a bibliographic records with holds and view the holds.
- Click the "trash" icon to delete one of the holds.
- In the confirmation modal, check that the "Confirm cancellation"
  button looks correct in its default, hover, and active ("clicked")
  state.

Cataloging:

- Open a new blank record in the basic MARC editor.
- Click "Save" without filling any mandatory fields.
- You should see a warning about the empty fields.
- Scroll down until the warning is offscreen. An "Errors" button should
  appear in the toolbar.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:24:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:24:22 +0000
Subject: [Koha-bugs] [Bug 32167] New: When adding an order from a a staged
 file without item fields we only add price if there is a vendor discount
Message-ID: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

            Bug ID: 32167
           Summary: When adding an order from a a staged file without item
                    fields we only add price if there is a vendor discount
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In addorderis02907.pl:
                my $c = $c_discount ? $c_discount : $bookseller->discount;
                $orderinfo{discount} = $c;
                if ( $c ) {
                    $orderinfo{ecost} = $c_price * ( 1 - $c / 100 );
                    $orderinfo{rrp}   = $c_price;
                }
                $orderinfo{listprice} = $orderinfo{rrp} /
$active_currency->rate;


IF there is no discount, we don't set the price fields!

This combines with 32166 to end up importing blank order records

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:24:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:24:40 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-stg7geMZZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|martin.renvoize at ptfs-europe |katrin.fischer at bsz-bw.de
                   |.com                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:25:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:25:09 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-BCYFgZJbC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:28:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:28:13 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-VldtMk9YGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:34:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:34:01 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-k40JaQZGEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:34:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:34:05 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-A85NKEm8Lx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143638|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143674&action=edit
Bug 32165: Add page-section to labeledMARCdetail

Test plan
1) Confirm that page-sections now appear as expected on the labeled marc
   view.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:34:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:34:10 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-0Zwvql5HBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143639|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143675&action=edit
Bug 32165: Add page-section to ISBDdetail

We fix some whitespace and move the toolbar above the H1 too.

Test plan
1) Confirm the headings and page-sections now look correct on the ISBD
   details view

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:34:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:34:15 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-G23dx43HAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143640|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143676&action=edit
Bug 32165: Add page-section to issuehistory

Test plan
1) Confirm the issue history view now uses page-section appropriately

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:34:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:34:19 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-xMmVdjUsqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143677&action=edit
Bug 32165: (QA follow-up) Fix tabs in ISBD details

The QA test tools complained about tabs in 2 lines, this is fixed here.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:41:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:41:39 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-Dgp5DRSgQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:46:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:46:28 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-VBdbIcIeGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:46:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:46:32 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-xb8raAaHNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142952|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143678&action=edit
Bug 32073: Consistent classes for primary buttons: Circulation

This patch makes changes the button markup in Circulation templates --
including offline circulation -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Circulation to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:46:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:46:36 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-AIhB5NzAck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143679&action=edit
Bug 32073: (QA follow-up) Fix capitalization: Cancel and Transfer all

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:47:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:47:01 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-xaQUl5llQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Going straight to PQA for this one (string fix included).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:48:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:48:22 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-lIaI6t5Q1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Going straight to PQA here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:54:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:54:39 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-ctZ5FtvMHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oh wow, Emmi, you star!

Thanks for the full rework here.. my apologies I missed the action had taken
place.. the code it looking great..

I'm going to work through it now.. I'm afraid it's just missed 22.11 freezes
but hopefully we can get it pushed as one of the first features for 23.05!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:55:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:55:07 +0000
Subject: [Koha-bugs] [Bug 32153] Wrong link for help for systempreferences
 in 22.05 and below
In-Reply-To: <bug-32153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32153-70-S5CGEvrf8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32153

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |DUPLICATE

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 31465 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:55:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:55:07 +0000
Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct
 manual pages
In-Reply-To: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31465-70-QJ8AxZdMIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 32153 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 16:56:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 15:56:00 +0000
Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct
 manual pages
In-Reply-To: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31465-70-egKwSctVHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:02:19 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-FiAXrcdCU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:02:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:02:24 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-8rFFtPnJKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143680&action=edit
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken

I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.

To test, apply the patch and view a basket in Acquisitions.

- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:02:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:02:28 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-J2Q45Db0VB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143681&action=edit
Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:03:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:03:37 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-vob5wpoI4Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:03:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:03:39 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-UhBN8cGSR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143137|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:03:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:03:42 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-IRJjminCdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143669|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:04:37 +0000
Subject: [Koha-bugs] [Bug 31812] Add yellow button to stage imports page
In-Reply-To: <bug-31812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31812-70-3qdMQRMKph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add yellow to stage imports |Add yellow button to stage
                   |page                        |imports page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:08:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:08:17 +0000
Subject: [Koha-bugs] [Bug 32168] New: Editing date/datetime fields without
 the dateaccessioned.pl plugin can cause errors
Message-ID: <bug-32168-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

            Bug ID: 32168
           Summary: Editing date/datetime fields without the
                    dateaccessioned.pl plugin can cause errors
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When editing items that are date or datetime formatted without the
dateaccessioned cataloging plugin it is quite easy to cause an error. 

To recreate:
1. Make sure some 952 field with dates (datelastseen, dateaccessioned ) are
visible in the editor but make sure the dateaccessiond plugin is turned off. 
2. Set the date format system preference to mm/dd/yyyy
3. Edit an item and attempt to edit one of the date fields to something in the
correct dateformat, like 11/11/2018.
4. You get an error as Koha is expecting the SQL date type format of
YYYY-MM-DD. 

I'm not sure how to best solve this. My first thought is that we should require
the dateaccessioned.pl plugin on date fields. 

Or we could add a hint about format?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:09:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:09:36 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-GvkjyY5WNz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143645|0                           |1
        is obsolete|                            |

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 143682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143682&action=edit
Bug 32162: Add primar key to erm_eholdings_packages_agreements

Test plan:
Confirm that this change fixes the related TestBuilder.t failure
Confirm that it does not break the eRM app, try to attach an agreement
to a package.

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:09:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:09:47 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-roMwSKhn0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

--- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> ---
> > - Changed the BKS framework for 952$r so that it displays in the editor with
> > the dateaccessioned.pl plugin
> > - Edited an item: saves date and time with 00:00 for the time
> > - Without the daetaccessioned.pl plugin you have to enter the date and time
> > including seconds, otherwise you get an error (edited item so no date, added
> > date without time): "Invalid value passed, items.datelastseen=09/05/2022
> > expected type is datetime at /...."

I think this is a separate bug about how we handle dates when not using the
dateaccessioned plugin. I have filed it as such:


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:09:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:09:48 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-6MtahQdO9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143683&action=edit
Bug 31819: (QA follow-up) Add page section to list of items

In order to test, you need to add items on order and add
at least one to make the list appear above the item section

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:13:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:13:26 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-65gHwm0kVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm... I've not actually tested this yet.. just applied it and done a minor
rebase.. reading the code it look like it won't work quite yet and it also
looks like the follow-up to move from 'pay' to 'apply' is missing.

I'll test and provide a follow-up myself now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:13:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:13:44 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-2XxyOiOUuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lucas at bywatersolutions.com  |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:17:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:17:00 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-aFr80alXMO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:17:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:17:05 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-BUrgDPyE7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143562|0                           |1
        is obsolete|                            |

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143684&action=edit
Bug 8948: Display MARC 787 relationship field

This field is defined similar to 775, as a related work:
https://www.loc.gov/marc/bibliographic/bd787.html

This patch adds a display of this field, linking to the referenced record as
the 775 does

It also tests for 580 field, and displays the text there if present, using the
787 a and t subfields otherwise

To test:
1 - Edit the default framework to make 787atw and 580a visible in editor
2 - Add a 787 to a record:
    $tThe ideas behind the chess openings
    $aFine, Reuben<
    $w2470231
3 - Confirm there is no display
4 - Apply patch / restart all
5 - 'Other related works' now shows
6 - Link should be using title of record
7 - Set system preference UseControlNumber to Use
8 - Reload details, link should now use control number
9 - Add a 580 to the record:
    $a This is a friendly work to this one
10 - Confirm the text of the link now displays before the link
11 - Add a second 580, confirm it displays as well
   - there is no seperator as each should end with a period or other
punctuation according to MARC
   - there is a dpan with a class surrounding each so styling can be added as
desired
12 - Add a second 787
   - confirm seperator present and wrapped in a span with a class
   - confirm each 787 is shown with a span/class for styling

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:17:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:17:11 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-mTQjwzJkhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143563|0                           |1
        is obsolete|                            |

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143685&action=edit
Bug 8948: Changes for OPAC

Test with same record, confirm OPAC view is as expected

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:17:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:17:17 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-zWLGLWpeWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143564|0                           |1
        is obsolete|                            |

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143686&action=edit
Bug 8948: (follow-up) Correct OPAC link

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:17:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:17:23 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-U3BF2B9o3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143642|0                           |1
        is obsolete|                            |

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143687&action=edit
Bug 8948: (follow-up) Remove 580 display from 787

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:18:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:18:29 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-Ed7Olosy7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Katrin Fischer from comment #10)
> > Is it expected that the search doesn't work with cardnumber? Or is it
> > because 42 is too short an input?
> 
> The autocomplete starts at 3 chars, yes. Is that a problem?

I think it's at least a totally different issue than the button :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:19:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:19:02 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-4Bd8BtaIKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143353|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:19:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:19:02 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-alAmi7qkmJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143670|0                           |1
        is obsolete|                            |

--- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143688&action=edit
Bug 16223: Add new columns to table restriction_types

This patch adds two new columns, lift_after_payment and fee_limit,
to table restriction_types. These colums are used to control
lifting patrons restrictions after paying their fees.

To test:
1. Apply this patch.
2. Update your database via updatedatabase.pl.
=> Confirm your table restriction_types has two new columns.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:19:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:19:08 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-DVxhSK3lz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143671|0                           |1
        is obsolete|                            |

--- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143689&action=edit
Bug 16223: DO NOT PUSH! Schema changes

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:19:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:19:13 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-i4c7U6aduU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143672|0                           |1
        is obsolete|                            |

--- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143690&action=edit
Bug 16223: Add ability to define liftable restrictions

Some libraries debar Patrons at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Patron has paid his/her fines.

This patch adds ability to create restrictions which are lifted after
patron pays ceratain amount of fines.

To test:
1. Apply this patch.
2. Restart your services if needed.
3. Navigate to page restrictions.pl.
=> Note that table has two new colums in it, "Lift after payment?" and "Fee
limit".
4. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
5. Create fees for a patron so they exceed fee limit e.g. 10
6. Add restriction made in step 2. for the patron
7. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:19:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:19:50 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-q7DixnfB51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #13)
> Is this PQA or In discussion?

I feel the search icon is fine, so no disagreement on my side, we could ask for
another opinion if you think it would be better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:30:25 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to items tab (cat)
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-M2UH1Hos75@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok. I now tried too and it's really confusing. Help?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:31:35 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-dlRGyGbWJE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The layout would work for me - maybe some more white background?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:32:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:32:34 +0000
Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should
 have an option to filter out notforloan statuses
In-Reply-To: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27973-70-emOUxCuo7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Todd Goatley <tgoatley at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tgoatley at gmail.com

--- Comment #6 from Todd Goatley <tgoatley at gmail.com> ---
+1 Yes, this is being talked about more and more by libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:35:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:35:49 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-OrROAd34q3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> ---
Updated test plan:

1. Apply patch, updatedatabase, restart_all
2. Check out an item, look at the datelastseen and make sure it is correctly
updated with the correct timestamp.
3. Check in an item, look at the datelastseen and make sure it is correctly
updated with the correct timestamp.
4. Search the catalogue and select a biblio with at least one item. Confirm in
the holdings table that every entry in the "Last Seen" column is in date-time
format.
5. Navigate to "Items" in for that same biblio and check the item "History"
section to have "Last Seen" in the correct format
6. Click "Edit" then "Edit Items" and confirm that the table has date-time
format for the "Date Last Seen" Column entries
7. Edit one of the items to have lost status, then navigate to the Reports
section, find "Items Lost", and search for the item with the barcode. Confirm
the proper date-time format in the result.
8. Navigate to Tools, then Inventory, run inventory and confirm that the "Date
Last Seen" column entries are in proper format
9. Update MARC frameworks to expose the datelastseen column in the editor, also
turn on the dateaccessioned plugin. Make sure you can properly edit the
datelastseen using the datepicker

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:45:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:45:20 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-JMx00Vcey9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143680|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143691&action=edit
Bug 31819: [alternate] Formatting of item form in acq when ordering is broken

I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.

To test, apply the patch and view a basket in Acquisitions.

- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:45:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:45:25 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-lhmeqjX5re@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143681|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143692&action=edit
Bug 31819: (QA follow-up) Fix alignment of Statistic fields at end of form

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:45:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:45:30 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-H4xOxl4pHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143683|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143693&action=edit
Bug 31819: (QA follow-up) Add page section to list of items

In order to test, you need to add items on order and add
at least one to make the list appear above the item section

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:46:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:46:30 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-AyQbzr8mmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Well.. these patches fix some things and improve some others.. I still think
the page looks a bit weird but I can't really fail it for that.

We can continue to refine next cycle.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:57:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:57:34 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-N5T9rm9Yqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143694&action=edit
Bug 37159: Updated tab style

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test plan
1) Confirm the styling change for top level tabs on patron details or catalog
   details pages.
2) Confirm the styling change is ok for a nested set of tabs (catalog
   holds page is a good example).

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:58:00 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-EbjMDzNjSY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143585|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:58:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:58:11 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-HxMy3UCL3M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141892|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:58:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:58:23 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-xhP5XNUco0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141895|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:58:43 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-mSx45XZz0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141896|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:58:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:58:55 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-qcVq1pdnv1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142681|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:58:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:58:56 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-2vz1ParD9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:59:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:59:00 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-bShdLK9n0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143511|0                           |1
        is obsolete|                            |
 Attachment #143522|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143695&action=edit
Bug 32147: Capitalization: E-Resource management

When e- is used as prefix, the second word should not
be capitalized. And when e-resource-management is used
as part of a sentence, the e shouldn't be either.
See: e-mail, e-commerce. etc.

To test:
* Best to check the code... but:
* All E-Resource should now read e-resource or E-resource, as on:
  * Koha start page
  * Breadcrumbs in the ERM module
  * Descriptions of AV categories...

I chose to update the sysprefs.sql and the DB update as well
as this hasn't been released yet.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:59:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:59:05 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-MB2HO1eM21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143696&action=edit
Bug 32147: (follow-up) Fix missing space

One of the AV category descriptions was missing a space
before the (e-resource management).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:59:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:59:06 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-P6dMQubsT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142716|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:59:19 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-wq9pfQr61g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143394|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 17:59:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 16:59:27 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-Yt6BOOht3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:00:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:00:19 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-h04ZrqkYDu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think we have a winner here... so much so that I fixed up the commit message,
added a test plan, obsoleted all the previous screenshots, mockups and patches
and am signing this one off :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:01:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:01:37 +0000
Subject: [Koha-bugs] [Bug 31759] Tabs vs Pills
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-CRKtc3sNoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:18:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:18:20 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-Ln0KMmgfNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:29:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:29:55 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-atj2RVMTjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for your patience and the follow-up, Nick :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:36:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:36:28 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-86saW9UnQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Tabs vs Pills               |Improve styling of tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:42:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:42:45 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-b2ywpuDj5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:42:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:42:50 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-c26m2hWDC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143694|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143697&action=edit
Bug 37159: Updated tab style

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test plan
1) Confirm the styling change for top level tabs on patron details or catalog
   details pages.
2) Confirm the styling change is ok for a nested set of tabs (catalog
   holds page is a good example).

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

https://bugs.koha-community.org/show_bug.cgi?id=31759

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:17 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-PkRoqiYWsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:20 +0000
Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8948-70-ktVzbQEtOJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

--- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:23 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-OPH4j6afO2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:26 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-atAGFvz5mD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #56 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:29 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-L9jS0ft4oR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:31 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-dPxhMyynRa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:34 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-DuepoU2mnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:39 +0000
Subject: [Koha-bugs] [Bug 32073] Consistent classes for primary buttons:
 Circulation
In-Reply-To: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32073-70-iasgkfrS7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32073

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:41 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-J8GBIOWhA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:44 +0000
Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when
 scheduling a pickup
In-Reply-To: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32108-70-EgbuO7uBOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:47 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-XgDviIXNZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:50 +0000
Subject: [Koha-bugs] [Bug 32145] Cancel hold modal confirm/submit button has
 a white background and text can't be read
In-Reply-To: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32145-70-zZcrF4YvYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:53 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-s5ZQhaz9Fw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:51:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:51:56 +0000
Subject: [Koha-bugs] [Bug 32165] Add page-section to some catalog pages
In-Reply-To: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32165-70-SVJ6aok0q4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32165

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:54:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:54:24 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-d4aE9qxdF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:54:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:54:27 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-LAV8jx3rIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:59:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:59:20 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-qTgcvStLNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m

--- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Need to apply bug 32162 (+dbic) after applying this or else the test fails
before getting to the error that this patch fixes.
More specifically, as it stands, bug 32162 fixes test 575 and this fixes test
576 when running TestBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:59:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:59:47 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-VxNOCrPus2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162
[Bug 32162] erm_eholdings_packages_agreements does not have a primary key
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 18:59:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 17:59:47 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-LDXjWEXwkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161
[Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:07:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:07:17 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-wNCCspXEnb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143621|0                           |1
        is obsolete|                            |

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 143698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143698&action=edit
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for
ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:15:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:15:20 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-jkinyWjSXA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Going straight to PQA here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:17:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:17:11 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-X5gWfoQlfu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:18:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:18:22 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-79SBvgbGYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161
[Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:18:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:18:22 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-PlJ2R9PJDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163
[Bug 32163] ErmUserRole has wrong koha_object[s]_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:20:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:20:55 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-LKvo5jOgn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:21:37 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-OcCpodXTUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:21:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:21:42 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-vhmxm0lrIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143140|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143699&action=edit
Bug 32099: Consistent classes for primary buttons: Assorted templates

This patch makes changes the button markup in various assorted
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view the following pages to confirm that
everything looks correct. In most cases there are no visible changes.

- Staff interface login
- Authorities -> Add/edit
- Authorities -> Merge
- ILL -> ILL requests
- Tools -> Patron lists
- Administration -> Manage plugins -> Upload plugin
- Point of sale
- Point of sale -> Transaction history
- Holds
- Suggestions
- Tags
- Calendar

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:22:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:22:12 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-rp33m7DBHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

--- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
This also requires bug 32161.
With this patch (and the previous ones it depends on) all tests from
TestBuidler.t are successful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:22:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:22:39 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-dcVRcN7Cnj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:23:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:23:42 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-bK9myu4yIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:23:46 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-z4xtMJbpv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143126|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143700&action=edit
Bug 32098: Consistent classes for primary buttons: Clubs and rotating
collections

This patch makes changes the button markup in clubs and rotating
collections templates so that all submit buttons and any buttons that
should should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron clubs and rotating collections
pages to confirm that everything looks correct. In most cases there are
no visible changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:25:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:25:35 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-YlBTqxgeJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143623|0                           |1
        is obsolete|                            |

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 143701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143701&action=edit
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:28:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:28:53 +0000
Subject: [Koha-bugs] [Bug 32169] New: Add page-section to item list on top
 of batch item edit (tools)
Message-ID: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

            Bug ID: 32169
           Summary: Add page-section to item list on top of batch item
                    edit (tools)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

The list of items on top of the batch edit item form is missing the white
background/page-section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:28:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:28:53 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-aKt0CPt5Yp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169
[Bug 32169] Add page-section to item list on top of batch item edit (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:28:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:28:53 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-hRDAnkOUkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169
[Bug 32169] Add page-section to item list on top of batch item edit (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:30:59 +0000
Subject: [Koha-bugs] [Bug 32170] New: Add page-section to CSV profiles
 (tools)
Message-ID: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

            Bug ID: 32170
           Summary: Add page-section to CSV profiles (tools)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

The list/table of existing CSV profiles is missing the white
background/page-section look.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:30:59 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-D9iCgJ9L2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32170


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170
[Bug 32170] Add page-section to CSV profiles (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:30:59 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-cHmsP1BqKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32170


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170
[Bug 32170] Add page-section to CSV profiles (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 19:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 18:34:35 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-SubCROI58Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
We use SetEnvIf to overcome the OpacBaseUrl thing already here.. your already
setting up a host to get the different domains..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:12:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:12:14 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-yGBiu8aQm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:12:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:12:18 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-GpgEbPIKtD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143702&action=edit
Bug 32158: Specify due date field is very long now

This patch adds a reasonable width to the "specify due date" date field
on the circulation page.

To test, apply the patch and rebuild the staff interface CSS.

Check out to a patron and click the "setting" icon on the "Enter item
barcode" field.

In the checkout setting panel, confirm that the date field isn't
unreasonably wide.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:29:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:29:56 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-rMO5P1hRlr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14680
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680
[Bug 14680] When creating orders from a staged file discounts supplied in the
form are added
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:29:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:29:56 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-K9bBvJsEUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167
[Bug 32167] When adding an order from a a staged file without item fields we
only add price if there is a vendor discount
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:30:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:30:00 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-q7nQzlJSwD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143703&action=edit
Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on
vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

https://bugs.koha-community.org/show_bug.cgi?id=14680

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:30:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:30:13 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-GehpgdKURM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:47:17 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-JSSSrFAD8i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:47:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:47:24 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-yMzXlyS2tV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:47:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:47:31 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-ObWX7Ewhfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:47:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:47:51 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-un7AsygFUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143703|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143704&action=edit
Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on
vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

https://bugs.koha-community.org/show_bug.cgi?id=14680

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:48:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:48:39 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-QhbTx5uH1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:49:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:49:11 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-tEobnm9xws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 20:59:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 19:59:04 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-FjMZYyD68X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_23_05_candidate

--- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #40)
> We use SetEnvIf to overcome the OpacBaseUrl thing already here.. your
> already setting up a host to get the different domains..

I'm sorry, I'm really overwhelmed by the amount of stuffs that need to be
done/fixed for the release. This can be clearly considered a bugfix and pushed
right after the release and backported if required. I can commit to that.

I'm really sorry, but my brain bandwidth is exhausted right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:19:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:19:39 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-vq60mKeYeq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:19:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:19:43 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-5y21KRXpa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143705&action=edit
Bug 32166: Use import record id for retrieving correct inputs

When importing from a staged file we retrieve the records form the DB, skip any
that are not selected,
and process the rest.

When we skip some, we still raise our record count, and use this to retrieve
the inputs.

When building the page, we don't increment for skipped reocrds, so there can be
a mismatch, i.e.
Record #1 on the page to add records may be the 3rd record in the import file

Rather than using a counting system, let us use the import record id directly

To test:
 0 - Set system preferences:

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

 1 - Stage attached sample file, Format:MARCXML, Record matching:Koha biblio
999$c
 2 - Add to a basket from the staged file
 3 - Select 1st record to basket and save
 4 - Record is added with the fields above as expected
 5 - Add to basket again, select 2nd record
 6 - Record is added with price from 020a, ignoring incoming fields
 7 - Repeat with 3rd, same problem
 8 - Apply patch
 9 - Stage file and repeat step 3
10 - Confirm added with correct values
11 - Add 2nd record and save, values correct
12 - Add 3rd record, values correct

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:20:16 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-MQm0xurV7G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143706&action=edit
Test records

Test records for importing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:20:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:20:29 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-k8ovjMUHUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:22:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:22:05 +0000
Subject: [Koha-bugs] [Bug 32171] New: Order prices not populated when adding
 to a basket form a staged file
Message-ID: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

            Bug ID: 32171
           Summary: Order prices not populated when adding to a basket
                    form a staged file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

>From bug 29955 - in '3rd add order' we remembered to store the order after
populating, when adding from a basket we didn't

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:22:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:22:18 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket form a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-Fa4fcvgpdE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29955


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955
[Bug 29955] Move C4::Acquisition::populate_order_with_prices to
Koha::Acquisition::Order
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:22:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:22:18 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-brkXsWraW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32171


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171
[Bug 32171] Order prices not populated when adding to a basket form a staged
file
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:22:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:22:52 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket form a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-n0meMnjnX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32166


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166
[Bug 32166] When adding to a basket from a staged file we may use the wrong
inputs
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:22:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:22:52 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-1ZRLWAZRBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32171


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171
[Bug 32171] Order prices not populated when adding to a basket form a staged
file
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:25:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:25:00 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket form a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-hPhdD9RmkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:25:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:25:04 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket form a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-pnRODVGyLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143707&action=edit
Bug 32171: Store after populating order

This updates the call to store after populating the order

I put this on it's own bug just for sake of dependency, in case it is needed
seperate from 32166 for backports

To test:
1 - Apply and test with bug 32166

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:25:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:25:14 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket form a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-zFkY5PyCJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:40:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:40:18 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-JDLuARFNhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:40:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:40:24 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-W89V36TD1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #347 from David Nind <david at davidnind.com> ---
Created attachment 143708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143708&action=edit
Bug 31699: (follow-up) Protect more against open redirects

This change checks that the OPACBaseURL exists, and uses its scheme
and authority to rewrite the URL passed through the "return"
param.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:40:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:40:33 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-4FeYASRM7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143647|0                           |1
        is obsolete|                            |

--- Comment #348 from David Nind <david at davidnind.com> ---
Created attachment 143709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143709&action=edit
Bug 31028: Add `tickets` and `ticket_updates` tables

This patch adds the new `tickets` and `ticket_updates` tables for
tracking catalog concern tickets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:40:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:40:42 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-lK7e4pnga3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143649|0                           |1
        is obsolete|                            |

--- Comment #349 from David Nind <david at davidnind.com> ---
Created attachment 143710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143710&action=edit
Bug 31028: Add new Koha::Object(s) classes

This patch adds new Koha::Object(s) for the newly introduced tables,
including updateing existing Koha::Objects adding new relations as
required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:40:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:40:50 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-XMNP5btkt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143650|0                           |1
        is obsolete|                            |

--- Comment #350 from David Nind <david at davidnind.com> ---
Created attachment 143711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143711&action=edit
Bug 31028: Add API's for tickets

This patch adds basic CRUD API's for the ticket endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:40:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:40:59 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-yehehGysOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143651|0                           |1
        is obsolete|                            |

--- Comment #351 from David Nind <david at davidnind.com> ---
Created attachment 143712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143712&action=edit
Bug 31028: Add `OpacCatalogConcerns` preference

Enabling this preference should allow catalog concerns to be added by
logged in patrons on the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:07 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-99LPKtbhcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143652|0                           |1
        is obsolete|                            |

--- Comment #352 from David Nind <david at davidnind.com> ---
Created attachment 143713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143713&action=edit
Bug 31028: Add ability to report catalog concerns from the OPAC

This patch adds the ability for patrons to report catalog concerns via
the opac.

Test plan
1) Enable the new `OpacCatalogConcerns` system preference
2) Navigate to the record details page of a biblio record on the OPAC
3) You should see a new 'Report a concern' option in the right side
   actions box
4) If not logged in you should have the login modal displayed and upon a
   successful login you should be redirected back to the details page
   with a new model displayed for entering concern details
5) Submit your concern with a title and details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:15 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-Oy4ZeKbIw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143653|0                           |1
        is obsolete|                            |

--- Comment #353 from David Nind <david at davidnind.com> ---
Created attachment 143714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143714&action=edit
Bug 31028: Add configurable help text and templates

This patch adds configurable help text and a template option to the
catalog concern report modal in the OPAC.

Test plan
1) Enable `OpacCatalogConcerns` preference
2) Build the CSS for the OPAC
3) Check that there is a 'CatalogConcernHelp' block listed in the HTML
   Customisations page.
4) On the OPAC navigate to a record and click the 'Report a concern'
   button.
5) Confirm that the content of 'CatalogConcernHelp' displays beneath the
   detail entry box and that it displays as expected.
6) Check that there is a 'CatalogConcernTemplate' block listed in the
   HTML customisations page.
7) On the OPAC 'Report a concern' modal, you should see the content of
   the 'CatalogConcernTemplate' block pre-filled in the details
textarea.

Note: There is a caveat to the template.. as textarea can only be used
to submit plaintext with this patch and as such the template needs to
not utilise the WYSIWYG editor else you will be faced with raw HTML
inside your textarea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:24 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-UvpFlLVKEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143654|0                           |1
        is obsolete|                            |

--- Comment #354 from David Nind <david at davidnind.com> ---
Created attachment 143715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143715&action=edit
Bug 31028: Add acknowledgement notice

This patch adds an acknowledgement notice that will be sent to the opac
user upon submission of a catalog concern report.

Test plan
1) Confirm that a new notice template is added to the notices management
   page.
2) If using a sandbox, check the 'email log' from the management UI to
   see the resultant notice has been 'sent'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:33 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-5GmZdBC4XK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143655|0                           |1
        is obsolete|                            |

--- Comment #355 from David Nind <david at davidnind.com> ---
Created attachment 143716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143716&action=edit
Bug 31028: Add catalog concern management page to staff

This patch adds a catalog concern management page to the staff client
accessible via the cataloging home page and a new 'Pending catalog
concerns' link on the front page.

This includes added the requisit ticket_updates api endpoints and notice
triggers and templates for notifying patrons of changes to their
reported concerns.

Test plan
1) Enable the `OpacCatalogConcerns` system preference
2) Catalog concern management is tied to your users ability to edit the
   catalog, `editcatalogue`.
3) Confirm that you can see 'Catalog concerns' listed on the cataloging
   home page if you have the `editcatalogue` permission and not if you
   do not.
4) Add a new concern as an opac user.
5) Confirm that once a concern is present in the system you see a count
   of 'catalog concerns pending' on the intranet main page if you have
   the `editcatalogue` permission.
6) Click through either the cataloging home page or pending concerns
   link on the main page to view the new concerns management page.
7) Confirm the table displays as one would expect.
8) Confirm clicking on details or the concern title exposes a 'details'
   modal with the option to add an update or resolve the concern.
9) Verify that if selecting 'notify' when updateing or resolving a
   concern triggers a notice to be sent to the opac user who first
   reported the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:41 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-iVyDxzTdb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143656|0                           |1
        is obsolete|                            |

--- Comment #356 from David Nind <david at davidnind.com> ---
Created attachment 143717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143717&action=edit
Bug 31028: Add email notification of cataloguers on submissions

This patch adds an optional cataloger notification to email the
cataloging team whenever a new catalog concern is reported.

Test plan
1) Enable `OpacCatalogConcerns`
2) Add at least one email address to the new `CatalogerEmails`
   prefernce (a comma delimited list is also allowed).
3) Confirm that a default template has been added to the Notices
   management, `TICKET_NOTIFY`.
4) Submit a new concern using the OPAC
5) Confirm that an email is sent to those email addresses listed in
   CatalogerEmails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:49 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-5JQV4xFPp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143657|0                           |1
        is obsolete|                            |

--- Comment #357 from David Nind <david at davidnind.com> ---
Created attachment 143718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143718&action=edit
Bug 31028: Add ability to report concerns from the staff interface

This patch brings the CatalogConcerns feature to the staff client
allowing non-cataloguers to report issues with catalog records from the
record details page.

Test plan
1) Enable the new `CatalogConcerns` system preference
2) Confirm that without the `edit_catalogue` permission your user can
   submit a catalog concern via `New -> New catalog concern` from the
   toolbar on a records detail display.
3) Confirm that the right user was recorded as the reporter on the
   catalog concern management page (You must have logged in again as a
   user with the `edit_catalogue` permission to see this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:41:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:41:57 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-eXGCYpi4sL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143658|0                           |1
        is obsolete|                            |

--- Comment #358 from David Nind <david at davidnind.com> ---
Created attachment 143719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143719&action=edit
Bug 31028: Add display to details page

This patch adds the display of biblio specific concerns to the biblio
detail display page.

Test plan
1) Enable the feature as in prior patch test plans
2) Add a concern as per prior patch test plans
3) Confirm that a new tab appears at the bottom of the catalog record
   details display and all functionality from the concern management
   page is precent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:06 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-AJ2VEUHaxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143659|0                           |1
        is obsolete|                            |

--- Comment #359 from David Nind <david at davidnind.com> ---
Created attachment 143720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143720&action=edit
Bug 31028: (follow-up) System preference terminology

Capitalise NOTE and swap 'client' for 'interface'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:14 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-uCScSgtWNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143660|0                           |1
        is obsolete|                            |

--- Comment #360 from David Nind <david at davidnind.com> ---
Created attachment 143721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143721&action=edit
Bug 31028: Only show pending concerns if there are some

This patch adds logic to catch when pending_biblio_tickets equals zero.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:23 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-bUN9XhiBd0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143661|0                           |1
        is obsolete|                            |

--- Comment #361 from David Nind <david at davidnind.com> ---
Created attachment 143722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143722&action=edit
Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE

TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:33 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-XUPd0X4722@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143662|0                           |1
        is obsolete|                            |

--- Comment #362 from David Nind <david at davidnind.com> ---
Created attachment 143723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143723&action=edit
Bug 31028: (follow-up) Update notice module codes

This patch updates the notice codes from 'catalog' to 'catalogue' to be
consistent with the existing codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:41 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-78L7DyTKn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143663|0                           |1
        is obsolete|                            |

--- Comment #363 from David Nind <david at davidnind.com> ---
Created attachment 143724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143724&action=edit
Bug 31028: (follow-up) Consistently style help-block

This patch updates the opac and staff modals to set the help-block
inside a div instead of a paragraph element allowing for the wysiwyg
edited content to display as prescribed.

We move the scss inside the fieldset definition to ensure we are
specific enough to catch only the intended elements.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:50 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-NSmWBYFvfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143664|0                           |1
        is obsolete|                            |

--- Comment #364 from David Nind <david at davidnind.com> ---
Created attachment 143725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143725&action=edit
Bug 31028: Add feedback to the patron on submission

This patch adds a success alert box when a patron submits a concern
sucessfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:42:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:42:58 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-L3oTi6E2BL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143665|0                           |1
        is obsolete|                            |

--- Comment #365 from David Nind <david at davidnind.com> ---
Created attachment 143726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143726&action=edit
Bug 31028: (follow-up) Fix permissions names

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:43:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:43:07 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-wdlJ2KZ1kK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143666|0                           |1
        is obsolete|                            |

--- Comment #366 from David Nind <david at davidnind.com> ---
Created attachment 143727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143727&action=edit
Bug 31028: (follow-up) Add <br> to notices

This should resolve the lack of linebreaks in resulting emails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 21:58:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 20:58:53 +0000
Subject: [Koha-bugs] [Bug 32172] New: Random biblionumber passed when
 clicking 'Z3950 SRU/Search' from the search results in staff client
Message-ID: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

            Bug ID: 32172
           Summary: Random biblionumber passed when clicking 'Z3950
                    SRU/Search' from the search results in staff client
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The code for Z3950 popup:
393 /* this function open a popup to search on z3950 server.  */
394 function PopupZ3950() {
395     if( strQuery ){
396        
window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=" +
biblionumber + strQuery,"z3950sear   
ch",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes');
397     }
398 }
399 


Picks a random biblionumber variable

Seems to get defined when images are enabled, presumably from
verify_cover_images

We shouldn't ever be replacing a biblio from the results page, so lets just
remove it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:01:18 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-D3Im77kUtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:01:22 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-x09IqmjxWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143728&action=edit
Bug 32172: Remove biblionumber param from Z3950 popup on results

This param is not defined in routine, who knows whereit comes from

To test:
1 - Enable coce and coce intranet, select all providers:
    https://coce.bywatersolutions.com
2 - Search on staff client
3 - Click Z3950 search
4 - Note url contains a random biblionumber
5 - Apply patch
6 - Repeat
7 - No biblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:01:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:01:40 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-jtshbzjZ3J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:09:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:09:52 +0000
Subject: [Koha-bugs] [Bug 32173] New: Add count of total titles in list to
 staff client view
Message-ID: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

            Bug ID: 32173
           Summary: Add count of total titles in list to staff client view
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In the OPAC, when viewing a list there is a line that reads "This list contains
X titles". 

The staff side list view should include the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:13:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:13:35 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ykwF24SlPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #367 from David Nind <david at davidnind.com> ---
(In reply to Martin Renvoize from comment #346)
> Thanks for all your testing David,
> 
> Hopefully this last rebase has the redirects working properly again.
> 
> As for the searching issue on the Status column, I've got it searching on
> firstname, surname and date but I can't easily add a special case for 'Open'
> vs 'Resolved'.. but there are the filters at the top of the page for that..
> I think this one will have to just come down to training.

Thanks Martin! Good call - I think this is pretty minor in the scheme of
things!

I've signed off, but the DBIC patch no longer applies - I skipped this and then
ran dbic (things are moving so quickly!)...

On the OPAC for the report a concern form, the template text is now below the
input form and help text - I'm assuming it is to do with the DBIC patch not
working. If not, I'll let you add a follow-up patch!

I'll also attach an updated consolidated testing plan/notes, if this is any
help for the QA Team and documenting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:17:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:17:01 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalog records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-CznWkZmXQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #368 from David Nind <david at davidnind.com> ---
Updated consolidated test plan/notes - may (or may not) make it easier for
testing/QA/documenting as there are so many patches:

1. Apply patches
2. Update database: updatedatabase
3. Build CSS:
   3.1 yarn install
   3.2 yarn build
   3.3 yarn build --opac

4. Setup for testing:
   4.1 Configure email for testing the work flow and notices - see [1] for
using Gmail and an app password
   4.2 Add an email address to the patron account used for testing the OPAC
(for example, koha)
   4.3 Add an email address to the staff account used for testing the staff
interface (for example, koha)
   4.4 Add an email address to the new CatalogerEmails system preference

5. Report a catalog concern from the OPAC:
   5.1 Enable the new system preference: OpacCatalogConcerns
   5.2 Search for a record and view the details page
   5.3 There is now a "Report a concern" link in the actions box on the
right-hand sidebar (under "Suggest a purchase")
   5.4 Click on "Report a concern"
   5.5 Add some information to the form (Title, information for each of the
headings) and click Submit
   5.6 Success message:"Your concern was successfully submitted."
   5.7 Repeat steps 5.2-5.6 for another record
   5.7 Log out from the OPAC and click on the "Report a concern" link for a
record - you should be prompted to log in. After logging in, you are then
redirected back to the record page and the form is displayed to report a
concern.
   5.8 Confirm emails received:
       . Patron that logged the cataloging concern should have received a
"Catalog concern acknowledgement" message
       . The email address configured for CatalogerEmails system preference
should have received a "Catalog concern reported" message

6. Manage catalog concerns from the staff interface:
   6.1 From the staff interface home page, select the "Catalog concerns
pending: 2" link after the main module links.
   OR
   6.0 Go to Cataloging > Reports > Catalog concerns
   6.4 The concern(s) you entered on the OPAC should be listed
   6.5 Click on "Details" in the actions column
       ==> Ticket details displayed in a modal window
   6.6 Add some text in the update field for the concern, select the Notify
checkbox, and click on the Comment button
   6.7 Click the "Details" action again, add an update, select the Notify
checkbox, and click on the Resolve button
   6.8 Check that the table filters for each column work as expected
   6.9 Check that "Hide resolved" and "Show all" filters for the page work as
expected
   6.10 Check that notifications are sent:
        . process the mail queue: misc/cronjobs/process_message_queue.pl
        . the patron should receive a "Catalog concern updated" and "Catalog
concern resolved" messages

7. Report a catalog concern from the staff interface:
   7.1 Enable the CatalogConcerns system preference
   7.1 Search for a record and view the details page
   7.2 Select New > New catalog concern
   7.4 Enter a title and details, and submit
   7.5 Catalog concerns created by staff are managed in the exact same way as
those reported from the OPAC - see 6. (includes email notifications)

8. View catalog concerns for a record in the staff interface:
   8.1 Go to the record that a concern was logged for in step 5
   8.2 Note that there is now a "Concerns" tab for the record
   8.3 The "Concerns" tab should list catalog concerns, and you can view the
"Details" and manage concern in the same way as step 6

9. Notifications: 
   9.1 There are four new notice templates in the Catalog category:
TICKET_NOTIFY, TICKET_ACKNOWLEDGE, TICKET_RESOLVE, TICKET_UPDATE (see Tools >
Patrons and circulation > Notices and slips)
   9.2 Prevous steps should have triggered the various notices:
       . TICKET_ACKNOWLEDGE: email to patron when they raise a concern
       . TICKET_NOTIFY: email to library staff when a concern is raised
       . TICKET_UPDATE: add an update to a concern
       . TICKET_RESOLVE: when concern marked as resolved
    9.3 Check that you can see the notices for the patron used in step 5 in
their account: Patron details > Notices section

10. Test with OPACReportProblem enabled:
    10.1 Enable the system preference
    10.2 Submit a "Report a problem" report from the OPAC
    10.3 Check that this works as expected in the staff interface, and that
both pending problem reports and catalog concerns are displayed
    10.4 BONUS tests (optional): test various combinations of enabling and
disabling suggestions, OPACReportProblem, AllowCheckoutNotes,
OpacCatalogConcerns, and CatalogConcerns system preferences

11. Test a non-super librarian and set them up so that they can manage catalog
concerns:
    11.1 Add a username and password to a staff user (for example: Henry
Acevedo)
    11.2 Set the account so that they have some permissions, such as staff
access, suggestion management, place and manage holds, but NOT Edit catalog
(editcatalogue)
    11.3 Log in to the staff interface
    11.4 With active concerns, you should not see "Catalog concerns pending: X"
on the home page or be able to access Cataloging > Reports > Catalog concerns
    11.5 Change their permissions so that they have the Edit catalog
(editcatalogue) permission
    11.6 You should now see the pending concerns on the home page and be able
to view and manage catalog concerns

12. Table configuration: have some active catalog concerns, click configure,
hide status column by default, check that you can toggle the status column on
and off.

13. Customise the catalog concern help text and template:
    13.1 Go to Tools > HTML customizations
    13.2 Note that there are two entries available for editing:
CatalogConcernHelp and CatalogConcernTemplate
    13.3 Make some edits to the CatalogConcernTemplate (note: only use the text
editor)
    13.4 Make some edits to the CatalogConcernHelp using the WYSIWYG editor -
add a bulleted list and some bold text
    13.5 Go to report a concern from the OPAC and staff interface
    13.6 The changes you made should be reflected in the report a concern forms

[1] Set up KTD so that email can be sent (using a Gmail address and an app
password):

Fromm your Gmail account, set up an App Password.

Add these lines (with <user_name> and <password> updated) to
/etc/koha/sites/kohadev/koha-conf.xml:

<smtp_server>
    <host>smtp.gmail.com</host>
    <port>587</port>
    <timeout>5</timeout>
    <ssl_mode>STARTTLS</ssl_mode>
    <user_name>YOURGMAILADDRESS</user_name>
    <password>GMAILAPPPASSORD</password>
    <debug>1</debug>
 </smtp_server>

restart_all

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:18:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:18:54 +0000
Subject: [Koha-bugs] [Bug 32173] Add count of total titles in list to staff
 client view
In-Reply-To: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32173-70-uNnpOTAbAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:18:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:18:57 +0000
Subject: [Koha-bugs] [Bug 32173] Add count of total titles in list to staff
 client view
In-Reply-To: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32173-70-PxhGLTOqzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143729&action=edit
Bug 32173: Add list count to shelves.tt

To test:
1. Build a list and look at it in the staff client.
2. No indication of how many items are in the list.
3. Apply patch and look again
4. You should see "This list contains x titles"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:19:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:19:19 +0000
Subject: [Koha-bugs] [Bug 32173] Add count of total titles in list to staff
 client view
In-Reply-To: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32173-70-Qd1sFVsqxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:25:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:25:03 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-A9iQudlVId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:25:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:25:08 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-bfnQJa64tG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143668|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143730&action=edit
Bug 31074: Reload a plugin's module before installation

When using Plack, memcached or another caching mechanism, a plugin's old
version is retained
in the cache, even when uninstalled. If the plugin is then reinstalled, the old
version is
used, no matter the version installed. To prevent this, the plugin's module is
reloaded every
time it is installed.

To test:
1) Install a plugin, like the kitchen sink.
   https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases
2) Modify the .kpz and in KitchenSink.pm, change MINIMUN_VERSION.
3) Uninstall the plugin.
4) Install the new version.
5) The Minimum Koha version column still lists the old version.
6) Apply patch.
7) Repeat steps 1 through 4.
8) Observe that the Minimum Koha version column lists the correct version.
9) Sign off.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:27:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:27:23 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-x0vgF85iZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #7 from David Nind <david at davidnind.com> ---
(In reply to Olivier Hubert from comment #5)
> Patch is updated and working now, sorry about the fluke.

Thanks! Things are now working as per the test plan.

Testing notes (using koha-testing-docker):

- I used the ByWater Solutions kitchen sink plugin - for the changed version, I
changed the minimum version from 21.05 to 20.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:55:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:55:07 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-NapeEiVfQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

LeeAnn Nilsson <lnilsson at lewistonschools.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lnilsson at lewistonschools.ne
                   |                            |t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:55:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:55:07 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-snNobbjjrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

LeeAnn Nilsson <lnilsson at lewistonschools.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lnilsson at lewistonschools.ne
                   |                            |t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 22:59:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 21:59:00 +0000
Subject: [Koha-bugs] [Bug 32174] New: bulkmarcimport.pl ignore items info
 when using -update
Message-ID: <bug-32174-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32174

            Bug ID: 32174
           Summary: bulkmarcimport.pl ignore items info when using -update
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Using this command:

/usr/share/koha/bin/migration_tools/bulkmarcimport.pl 
  -v 
  -insert 
  -biblios 
  -framework "BKS" 
  -file /home/me/books.mrc 
  -l /tmp/books.log

works fine. If changes are made (on normal fields and on 952) on MRC and then
we run:

/usr/share/koha/bin/migration_tools/bulkmarcimport.pl 
  -v 
  -match Control-number,001 
  -update 
  -biblios 
  -framework "BKS" 
  -file /home/me/books.mrc 
  -l /tmp/books.log

the information is update/overwritten, but *only at biblio level*. Item info
remains untouched.

The solution maybe could be to add a --add-items-if-match option. To include
-all option and have consistency with web interface --add-items-if-nomatch and
--add-items-always could be added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:10:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:10:58 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-XLKB37Waea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

--- Comment #42 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #39)
> In my opinion, using OpacBaseURL as a fixed value (instead of an allow-list)
> is a design mistake because of what I mentioned above.

I was thinking about that a bit as well. With the OIDC server, they use an
allow list to great effect. 

I figure Koha would possibly benefit in a few different places from URL
redirect allow lists.

(In reply to Martin Renvoize from comment #40)
> We use SetEnvIf to overcome the OpacBaseUrl thing already here.. your
> already setting up a host to get the different domains..

But I also agree with this in terms of addressing the practical problem. 

(In reply to Tomás Cohen Arazi from comment #41)
> I'm really sorry, but my brain bandwidth is exhausted right now.

You've been doing so much! We all understand!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:21:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:21:30 +0000
Subject: [Koha-bugs] [Bug 32173] Add count of total titles in list to staff
 client view
In-Reply-To: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32173-70-YH9ffjVrjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143729|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143731&action=edit
Bug 32173: Add list count to shelves.tt

To test:
1. Build a list and look at it in the staff client.
2. No indication of how many items are in the list.
3. Apply patch and look again
4. You should see "This list contains x titles"

Signed-off-by: Barbara Johnson  <barbara.johnson at swbell.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:22:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:22:15 +0000
Subject: [Koha-bugs] [Bug 32173] Add count of total titles in list to staff
 client view
In-Reply-To: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32173-70-2vzjWV5MOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:28:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:28:08 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-krHb3mXUyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
I was surprised to find Module::Refresh in koha-testing-docker, but "apt-cache
rdepends --installed libmodule-refresh-perl" shows that it's a dependency of
libplack-perl.

That's because Plack::Middleware::Refresh comes bundled with Plack:
https://metacpan.org/pod/Plack::Middleware::Refresh

Reading Plack::Middleware::Refresh documentation, it seems like this middleware
is typically only used during development and not production...

https://metacpan.org/pod/Module::Refresh also mentions bugs relating to global
variables...

But then the practice seems normal in an O'Reilly mod_perl book:
https://docstore.mik.ua/orelly/weblinux2/modperl/ch06_08.htm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:31:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:31:18 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-uWS1Awdgor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:31:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:31:23 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-zVEfyBjLrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143124|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143732&action=edit
Bug 32096: Consistent classes for primary buttons: Tools

This patch makes changes the button markup in various tool
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in the tools section to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:31:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:31:50 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-zzJekfA83h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
I haven't tested this yet, but I see one potential problem.

This refresh code runs in only 1 of the Starman workers. That worker might
refresh the plugin code, but it shouldn't affect the other Starman workers. 

The way to test this would probably be to increase the number of
"plack_workers" in koha-conf.xml and try re-loading the page again and again. 

So far, we might be noticing a coincidence where the refreshed worker is the
one serving the plugin page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:35:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:35:33 +0000
Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned
In-Reply-To: <bug-31935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31935-70-vlfpB7fubJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd love to see this fixed before release as it's THE form in the serials
module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:40:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:40:08 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-xpc3rmcOz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:40:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:40:13 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-bGDanE7Xf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143121|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143733&action=edit
Bug 32094: Consistent classes for primary buttons: Serials

This patch makes changes the button markup in serials templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view serials pages to confirm that
everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:41:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:41:14 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-7z3KMJ3bMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143702|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143734&action=edit
Bug 32158: Specify due date field is very long now

This patch adds a reasonable width to the "specify due date" date field
on the circulation page.

To test, apply the patch and rebuild the staff interface CSS.

Check out to a patron and click the "setting" icon on the "Enter item
barcode" field.

In the checkout setting panel, confirm that the date field isn't
unreasonably wide.

Signed-off-by: Barbara Johnson  <barbara.johnson at swbell.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:41:36 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-oAULvjOhBX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:51:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:51:17 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-k8PrAAlTrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Something quite odd: 

http://localhost:8081/cgi-bin/koha/members/pay.pl?borrowernumber=51

I see the new tabs on checkouts tab, but the 'old' tabs with rounded corners
(!) on the accounting tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:51:31 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-r591T4yRb9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:55:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:55:10 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-zK4KkIAsT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like .statictabs might be to blame?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:55:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:55:48 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-qN8WIfTCpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:55:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:55:53 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-LWhMTE8vzp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143082|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143735&action=edit
Bug 32086: Consistent classes for primary buttons: Patrons

This patch makes changes the button markup in patron
module templates so that all submit buttons and any buttons that should
should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron module pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:59:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:59:43 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-aYcuCYKXpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 10 23:59:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 22:59:48 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-vpaiUsLsjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143153|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143736&action=edit
Bug 32103: Remove flex from tab-content list elements

To test:
1. Go to HTML customization, News, or Pages and make a new entry using the text
editor ( CodeMirror )
2. It is hard to focus on the Content field because the wrapper width is very
small.
3. Apply patch and try again
4. The CodeMirror wrapper width should be normal again.
5. Check the other language tabs.
6. Also test the WYSIWYG editor, it should also be normal.

Note: I added some CSS to make the labels appear bold.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:00:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:00:17 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-nuZeGqPmhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:03:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:03:13 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-gWMMJotGoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:04:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:04:12 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-TtoCAymS9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:04:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:04:17 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-tCHqNpS7ep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143734|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143737&action=edit
Bug 32158: Specify due date field is very long now

This patch adds a reasonable width to the "specify due date" date field
on the circulation page.

To test, apply the patch and rebuild the staff interface CSS.

Check out to a patron and click the "setting" icon on the "Enter item
barcode" field.

In the checkout setting panel, confirm that the date field isn't
unreasonably wide.

Signed-off-by: Barbara Johnson  <barbara.johnson at swbell.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:04:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:04:28 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-a5QUslco77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:05:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:05:47 +0000
Subject: [Koha-bugs] [Bug 32175] New: Flatpickr usage causes acquisitions
 item info clone to fail when dateaccessioned is filled in
Message-ID: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

            Bug ID: 32175
           Summary: Flatpickr usage causes acquisitions item info clone to
                    fail when dateaccessioned is filled in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Bug 29369 added Flatpickr to the "Date acquired" field

When creating items at receival time in Acquisitions, the item info should be
cloned/prefilled for the next item after adding an item.

However, if you've added a value to "Date acquired", it will trigger a
Javascript error that stops the clone/prefill from working.

This is because the "input[name='field_value']" element is wrapped by '<span
class="flatpickr_wrapper">' which creates a problematic inconsistency with the
HTML structure...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:05:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:05:56 +0000
Subject: [Koha-bugs] [Bug 32175] Flatpickr usage causes acquisitions item
 info clone to fail when dateaccessioned is filled in
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-UPK3rm0Ids@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29369


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369
[Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:05:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:05:56 +0000
Subject: [Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging
 plugin
In-Reply-To: <bug-29369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29369-70-owYPbrlwYL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32175


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175
[Bug 32175] Flatpickr usage causes acquisitions item info clone to fail when
dateaccessioned is filled in
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:16:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:16:02 +0000
Subject: [Koha-bugs] [Bug 32175] Flatpickr usage causes acquisitions item
 info clone to fail when dateaccessioned is filled in
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-gpjFEeskgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
(Looks like PrefillItem is also broken for regular cataloguing in 21.11 at
least.. fun)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:20:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:20:05 +0000
Subject: [Koha-bugs] [Bug 32175] Flatpickr usage causes acquisitions item
 info clone to fail when dateaccessioned is filled in
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-XfTdPq6WtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I don't know how widely used this cloneItemBlock function is... although it
looks like it might not be working correctly in other parts of Koha.

I'm tempted to just handle the error, although that means "Date acquired" won't
be cloned...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:22:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:22:08 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-sWKse5p9CG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Flatpickr usage causes      |Item info not cloning when
                   |acquisitions item info      |receiving multiple items
                   |clone to fail when          |due to Flatpickr issue
                   |dateaccessioned is filled   |
                   |in                          |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:25:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:25:17 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-Mu6X1YAL84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:27:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:27:06 +0000
Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct
 manual pages
In-Reply-To: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31465-70-rYoDQSMDEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:29:45 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-G8r67CCs1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:31:07 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-2jdMkDHSpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:31:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:31:13 +0000
Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct
 manual pages
In-Reply-To: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31465-70-jwkuxnAbsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:33:08 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-IDC8aPEHr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:33:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:33:12 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-5bLHXVql8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143738&action=edit
Bug 32175: Prevent Javascript error by checking for kohafield sibling

This patch checks for kohafield sibling before proceeding with
data clone when creating items during receival.

If the kohafield sibling is not available, don't try to clone the
value.

Test plan:
1. Create a test vendor
2. Create a test basket (create item on receival)
3. Create a test order for 3 items
4. Close the test basket
5. Receive the order
6. Fill out many item fields including "Date acquired"
7. Click "Add item"
8. Note that the fields aren't cloned and there is a Javascript error
in the console

9. Apply the patch

10. Refresh the page
11. Fill out many item fields including "Date acquired"
12. Click "Add item"
13. Note that the fields are cloned, except "Date acquired"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:33:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:33:37 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-vfaXQzBJeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Note that not cloning "Date acquired" isn't too big of a deal, as it will
automatically be set (these days) when saving the item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:37:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:37:58 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-f6GuaItCtM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:38:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:38:22 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-IQNbcJSUNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_21_11_candidate,        |
                   |rel_22_05_candidate         |

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:40:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:40:48 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-8QGIE2W3iT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Patchset will not apply cleanly to 22.05.x branch, please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:47:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:47:27 +0000
Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode
In-Reply-To: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31482-70-4s4xRODh4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |
           Keywords|rel_22_05_candidate         |
             Status|Pushed to master            |Pushed to stable

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:56:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:56:32 +0000
Subject: [Koha-bugs] [Bug 32080] Public lists not available after recent
 upgrade
In-Reply-To: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32080-70-D5QctDFE1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32080

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Thanks all, this is backported to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:57:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:57:02 +0000
Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a
 dropdown field in the cataloguing editor
In-Reply-To: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31646-70-3Om0vP0Npu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:57:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:57:26 +0000
Subject: [Koha-bugs] [Bug 32011] 2FA - Problem with qr_code generation
In-Reply-To: <bug-32011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32011-70-myaSJnKJ8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_05_candidate,        |
                   |rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 00:58:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Nov 2022 23:58:51 +0000
Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC
In-Reply-To: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30036-70-Bun4p2swNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
This is marked as a rel_22_05_candidate but it looks like an enhancement. Do we
need to backport it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 01:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 00:51:25 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-vvuS6b9S3F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Mark Hofstetter <koha at trust-box.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at trust-box.at

--- Comment #1 from Mark Hofstetter <koha at trust-box.at> ---
quick testing on 22.05.05.000 seem to indicate that this bug still persists

although it seems to work on 21.05.04.000

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 03:28:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 02:28:59 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-DplEKrrmNJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #22 from David Nind <david at davidnind.com> ---
Hi Lucas.

I've re-tested, but I'm still having an issue with the date last seen updating
to the current date when editing an item.

If I edit an item, the date last seen field is now pre-populated with the
current date (952$r setup to display in staff interface and date_accesioned
plugin added).

This isn't the case before the patch is applied - it is populated with the date
originally recorded before editing.

Everything else seems to be working as expected in the test plan.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 03:31:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 02:31:21 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-SqePVKCD3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
I had a go at testing a couple of times, but I couldn't replicate the issue (on
current master just updated, using Firefox).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 03:40:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 02:40:43 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-O4tLfq46BF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 03:40:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 02:40:47 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-NTOYRWfbOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143728|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143739&action=edit
Bug 32172: Remove biblionumber param from Z3950 popup on results

This param is not defined in routine, who knows whereit comes from

To test:
1 - Enable coce and coce intranet, select all providers:
    https://coce.bywatersolutions.com
2 - Search on staff client
3 - Click Z3950 search
4 - Note url contains a random biblionumber
5 - Apply patch
6 - Repeat
7 - No biblionumber

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 06:45:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 05:45:16 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-20nh6sRUR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Nind from comment #5)
> I had a go at testing a couple of times, but I couldn't replicate the issue
> (on current master just updated, using Firefox).

Hmm, ok, I'll have another look at this one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 07:47:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 06:47:01 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-3YvvMychgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #18 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Tried to apply patches on current master and received following error:

Applying: Bug 28966: Prefetch patron data for holds queue viewer
error: sha1 information is lacking or useless (C4/HoldsQueue.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 28966: Prefetch patron data for holds queue viewer
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-28966-Prefetch-patron-data-for-holds-queue-vie-FQNEIE.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 08:26:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 07:26:14 +0000
Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
 for float
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-zB6PHnLfHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139024|0                           |1
        is obsolete|                            |

--- Comment #55 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143740&action=edit
Bug 9525: Add ft_local_float_group column

This patch adds new ft_local_float_group column
to library_groups table.

To test:
1. Apply patch and update database
2. Confirm new column is added correctly to the
library_groups table

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Lisette Scheer <lisettePalouse+Koha at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 08:26:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 07:26:47 +0000
Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
 for float
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-sZh1iiOX8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139025|0                           |1
        is obsolete|                            |

--- Comment #56 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143741&action=edit
Bug 9525: DO NOT PUSH! Schema update

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Lisette Scheer <lisettePalouse+Koha at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 08:27:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 07:27:32 +0000
Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
 for float
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-B4W84INdMj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139026|0                           |1
        is obsolete|                            |

--- Comment #57 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143742&action=edit
Bug 9525: Add option to define float groups and rules for  float

Bug 22284 introduced ability to create hold groups.
We should have ability to create float groups in
same manner. This patch adds checkbox "Is local
float group" to group creation feature and new return
policy "Item floats by librarygroup".

To test:
1. Add new float group and some libraries to it.
2. From circulation and fine rules, set default
return policy as "Item floats by library group".
3. Check out an item for a patron.
4. Set library as one that belongs in the same
float group.
5. Check in the item.
=> Observe that notice for transfer doesn't pop up.
6. Check out again.
7. This time set library as one that doen's
belong in the same float group.
8. Check in.
=> Observe that notice for transfer pops up.

Experiment this feature by changing return policy
per library, item type etc.

Also prove t/db_dependent/Koha/Libraries.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Lisette Scheer <lisettePalouse+Koha at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 08:28:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 07:28:07 +0000
Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
 for float
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-1RghOxQa8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #58 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143743&action=edit
Bug 9525: Fix tests

To test prove t/db_dependent/Koha/Libraries.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 08:28:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 07:28:27 +0000
Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
 for float
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-YB7TGOSvbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #59 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Rebased patches and fixed tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 08:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 07:51:09 +0000
Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host
 is incorrect
In-Reply-To: <bug-29268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29268-70-ulokBuKOvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #5 from Magnus Enger <magnus at libriotech.no> ---
Is there a test plan for this, or is it just a question of running the affected
tests?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:00:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:00:20 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-WHGcqRBFXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I missed this.. anyone care to remind me why we have statictabs?  There's a few
occurrences and I can't remember how they differ from other tab classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:01:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:01:58 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-PxpwiHYp3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #3)
> Just thinking about this one, it feels to me like it should be a multi-field
> primary key rather than a new field entirely.
> 
> Having said that, it looks like we allow a user + licence + agreement
> combination to have multiple roles?  That would mean having all four fields
> in the primary key... food for thought.

It's actually not possible, license_id and agreement_id are nullable and thus
cannot be part of the primary key
https://mariadb.com/kb/en/primary-keys-with-nullable-columns/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:09:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:09:09 +0000
Subject: [Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify
 search mapping modifications
In-Reply-To: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17897-70-TeKyyEIQZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115322|0                           |1
        is obsolete|                            |

--- Comment #12 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143744&action=edit
Bug 17897: Fix failing tests

Tests failed when txn_begin and rollback were used inside
of subtests.

To test prove t/db_dependent/Koha/SearchEngine/ElasticSearch.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:10:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:10:30 +0000
Subject: [Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify
 search mapping modifications
In-Reply-To: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17897-70-bNQnRj8UIc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Fixed tests, patches should apply cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:01 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-nhuVeeSGB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142059|0                           |1
        is obsolete|                            |

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143745&action=edit
Bug 31095: Add Koha::Patron::Restriction(s)

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:06 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-x2MnaQ29b0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142060|0                           |1
        is obsolete|                            |

--- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143746&action=edit
Bug 31095: Add restrictions accessor to Koha::Patron

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:12 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-pO7rJnQkUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142061|0                           |1
        is obsolete|                            |

--- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143747&action=edit
Bug 31095: Add type relation accessor to Koha::Patron::Restriction

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:18 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-ZLy8NUc09F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142062|0                           |1
        is obsolete|                            |

--- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143748&action=edit
Bug 31095: Remove GetDebarments from circ/circulation.pl

This patch remove the use of GetDebarments from circ/circulation.pl,
replacing it with a reference to patron.restrictions in the template and
includes.

Test plan
1. Confirm that the 'Restrictions (x)' tab still appears on the checkout
   page for a user.
2. Confirm that the 'Restrictions (x)' tab count is correct
3. Confirm that the 'Restrictions (x)' tab table functions
4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form
   works as expected

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:24 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-jrmBzTpeqA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142063|0                           |1
        is obsolete|                            |

--- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143749&action=edit
Bug 31095: Remove GetDebarments from members/moremember.pl

This patch removes the use of GetDebarments from members/moremember.pl
and replaces template references with patrons.restrictions and the new
includes introduced in the prior patch

Test plan
1. Confirm that the 'Restrictions (x)' tab still appears on the patron
   details page.
2. Confirm that the 'Restrictions (x)' tab count is correct
3. Confirm that the 'Restrictions (x)' tab table functions
4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form
   works as expected

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:29 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-2BaiGTX0m9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142064|0                           |1
        is obsolete|                            |

--- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143750&action=edit
Bug 31095: Remove GetDebarments from members/memberentry.pl

This patch removes the use of GetDebarments from members/memberentry.pl
and replaces the references in the templates with patron.restrictions.

Test plan
1. Add a new user and confirm that the patron restrictions section does
   not appear on the form
2. Edit the user and confirm the patron restrictions section now appears
3. Add a manual restriction using the patron edit form
4. Confirm the restriction appears on the patron edit form
5. Confirm you can remove the restriction usine the patron edit form

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:35 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-LEMqk5nqMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142065|0                           |1
        is obsolete|                            |

--- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143751&action=edit
Bug 31095: Remove borrower_debarments and patron_restrictions includes

This patch removes the aforementioned includes and drops the last
remaining reference to them.

We have replaces these includes with patron-restrictions-tab.inc and
restriction-types.inc.

Test plan
1. Confirm the includes are no longer referenced anywhere in the
   codebase. 'git grep borrower_debarments.inc', 'git grep
   patron_restrictions.inc'

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:41 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-vSapHa1a5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142066|0                           |1
        is obsolete|                            |

--- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143752&action=edit
Bug 31095: Remove keyed_on_code

We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types
as we have relation accessors for the relevent use cases and no longer
reference the method anywhere in the codebase!

Test plan
1. Confirm 'keyed_on_code' is no longer referenced anywhere in the
   codebase.
   `git grep keyed_on_code`

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:46 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-imhZ8vJz0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142067|0                           |1
        is obsolete|                            |

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143753&action=edit
Bug 31095: Remove GetDebarments from tools/modborrowers.pl

This patch removes GetDebarments from the modborrowers tool controller
and replaces it with $patron->restrictions as appropriate.

Test plan
1. Confirm that the 'Batch patron modification' tool pages still load
   and perform as expected.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:52 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-tE4un3sYyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142068|0                           |1
        is obsolete|                            |

--- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143754&action=edit
Bug 31095: Remove GetDebarments from Circulation.pm

This patch removes GetDebarments from Circulation.pm replacing them with
calls to $patron->restrictions and filtering using a chained search
call.

Test plan
1. Confirm that t/db_dependant/Circulation.t continues to pass

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:34:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:34:57 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-EZQqsoTw2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142069|0                           |1
        is obsolete|                            |

--- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143755&action=edit
Bug 31095: Remove GetDebarments from Circulation.t

Replace GetDebarments with $patron->restrictions.

Test plan
1. Run test prior to patch - all should pass
2. Run test after patch - all should pass
3. Confirm no tests were removed as part of the patch

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:02 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-gUQWdWmfte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142070|0                           |1
        is obsolete|                            |

--- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143756&action=edit
Bug 31095: Remove GetDebarments from Patron::Import

This patch replaced GetDebarments with $patron->restrictions->search in
Koha::Patron::Import.

Test plan
1. Confirm that importing patrons with debarred and debarredcomment
   fields in the import still works as expected

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:09 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-faaDAcmj9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142071|0                           |1
        is obsolete|                            |

--- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143757&action=edit
Bug 31095: Remove GetDebarments from maxsuspensiondays.t

This patch replaces GetDebarments in maxsuspensiondays.t with calls to
the restrictions accessor.

Test plan
1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior
   to this patch
2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after
   this patch
3. Confirm no tests have been removed in this patch

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:15 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-XerUmtXDFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142072|0                           |1
        is obsolete|                            |

--- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143758&action=edit
Bug 31095: Remove GetDebarments from MarkIssueReturned.t

This patch removes GetDebarments from Ciculation/MarkIssueReturned.t

Test plan
1. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes prior
   to the patch
2. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes after
   the patch
3. Confirm no tests have been removed

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:21 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-TOkARjiwfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142073|0                           |1
        is obsolete|                            |

--- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143759&action=edit
Bug 31095: Remove GetDebarments from Restriction/Type.t

This patch replaces GetDebarments with $patron->restrictions in
t/db_dependent/Koha/Patron/Restriction/Type.t

Test plan
1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to
   the patch
2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after
   the patch
3. Confirm no tests were removed

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:28 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-i0exASzkFW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142074|0                           |1
        is obsolete|                            |

--- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143760&action=edit
Bug 31095: Remove GetDebarments from Borrower_Debarments.t

This patch replaces calls to GetDebarments with teh
$patron->restritions->search() equivilents.

Test plan
1. Run the test prior to the patch and confirm it passes
2. Run the test after the patch and confirm it passes
3. Confirm no tests were removed

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:33 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-TKFj6RP7q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142075|0                           |1
        is obsolete|                            |

--- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143761&action=edit
Bug 31095: Remove GetDebarments from Koha::Patron::Debarments

This patch finally removes GetDebarments from the codebase.

Test plan
1. Confirm GetDebarments is no longer mentioned in the codebase. `git
   grep GetDebarments`
2. Confirm t/db_dependent/Patron/Borrower_Debarments.t continues to pass

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:39 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-DACk5kYtLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142076|0                           |1
        is obsolete|                            |

--- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143762&action=edit
Bug 31095: (QA follow-up) Fix after rebase

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:35:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:35:45 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-eCd5YkhJBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140731|0                           |1
        is obsolete|                            |

--- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143763&action=edit
Bug 31095: (follow-up) Iterate debarments in batch mod

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:41:09 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-l6b05HASNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:42:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:42:29 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-rGVhQyAAgt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Same, I cannot recreate on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:54:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:54:51 +0000
Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for
 automatic logins (like self-checkout)
In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22322-70-cTS5D5JpJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322

--- Comment #7 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143764&action=edit
Bug 22322: Fix QA issues

This patch fixes following QA issues:
- Add missing filters
- Use dt_from_string instead of DateTime->now in sco-main.pl

Following issue is left unchanged, since it is purposeful:
forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 09:55:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 08:55:06 +0000
Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for
 automatic logins (like self-checkout)
In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22322-70-rSxeN5v3hG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:02:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:02:50 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-t5OIk1WUEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:20:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:20:23 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-eogLJ0yReG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:27:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:27:48 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-upBGsPjBYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

--- Comment #93 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Patches were in the wrong order on bugzilla somehow.. fix that and done a minor
rebase for the page-section bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:30:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:30:42 +0000
Subject: [Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search
 does not work
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-5dMnkDoKOG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30578


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578
[Bug 30578] We should drop circ/ysearch.pl in preference to using the REST
API's
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:30:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:30:42 +0000
Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in
 preference to using the REST API's
In-Reply-To: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30578-70-3pS5AelYM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31782


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782
[Bug 31782] Patron lists - patron autocomplete search does not work
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:31:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:31:22 +0000
Subject: [Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search
 does not work
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-YBYxSDQOzQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:33:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:33:32 +0000
Subject: [Koha-bugs] [Bug 31843] Stock rotations do not allow rotas with the
 same name
In-Reply-To: <bug-31843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31843-70-hWd0UlDoY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31843

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:34:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:34:06 +0000
Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
In-Reply-To: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30869-70-Wzmgpxh1ZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 10:36:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 09:36:45 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-Y197mh1pZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #196 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Patches no longer apply.

Applying: Bug 8367: Add holds_pickup_period circulation rule
Using index info to reconstruct a base tree...
M       Koha/Hold.pm
M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
M       koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
M       opac/opac-reserve.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-reserve.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Auto-merging Koha/Hold.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 8367: Add holds_pickup_period circulation rule
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-8367-Add-holdspickupperiod-circulation-rule-PsnpwK.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:19:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:19:20 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-JLeNZ7qc7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:27:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:27:56 +0000
Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for
 holds at reservation time
In-Reply-To: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26498-70-g53SwGZDcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498

--- Comment #35 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Marcel de Rooy from comment #34)
> Is there any reason why the hold end date on the opac-reserve form is not
> filled with the default date?
> Note that this field is available via OPACAllowHoldDateInFuture.
> 
Tested and default date was set nicely. 

> And even, if you enable the DefaultHoldExpiration prefs, should you not show
> the hold end date although OPACAllowHoldDateInFuture might be off ?
> 
Hmm, to me it seems that hold end date field is hidden only if
AllowHoldDateInFuture syspref is set off. And if I understand correctly end
date field in opac should only be shown if both AllowHoldDateInFuture _and_
OPACAllowHoldDateInFuture are enabled. So it seems OPACAllowHoldDateInFuture
isn't working as it should? 

> How do we alert the user on the default end date for a hold now?

Good point. We don't currently by my knowledge. Maybe we need one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:30:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:30:21 +0000
Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for
 holds at reservation time
In-Reply-To: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26498-70-eJ6pvYFwor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:31:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:31:59 +0000
Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins
 home
In-Reply-To: <bug-23222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23222-70-TZDB7EKkuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:01 +0000
Subject: [Koha-bugs] [Bug 24455] Add ability to apply Koha formatting to
 dates from Javascript
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Md0UOtsUYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:02 +0000
Subject: [Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only
 with dates with offset
In-Reply-To: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24980-70-8MUlv13g2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:04 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
 Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-cp49gmF7OT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:05 +0000
Subject: [Koha-bugs] [Bug 21641] Software error when checking out an item
 with a charge associated with it
In-Reply-To: <bug-21641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21641-70-D6qTxvw8Ho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:09 +0000
Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7088-70-aZY1Tr5rrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:13 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15260-70-2Zovm2itR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:19 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18589-70-WQLeJyCkIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:26 +0000
Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans
 workflow
In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18837-70-zThGKAMtsO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:28 +0000
Subject: [Koha-bugs] [Bug 20284] ILL: Adding a 'new request' from OPAC fails
 with template error if text exists in ILLModuleCopyrightClearance
In-Reply-To: <bug-20284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20284-70-Y9XuP0y44x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:34 +0000
Subject: [Koha-bugs] [Bug 20548] Remove copyright clearance workflow from
 staff created ILL requests
In-Reply-To: <bug-20548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20548-70-Q95bSz2lBs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:39 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
 requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-HatfMej44B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:42 +0000
Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for
 OPAC driven requests
In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20639-70-pfK3wjur0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:46 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-krgrauyI1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:51 +0000
Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber
 does not work
In-Reply-To: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21460-70-Y1PnDEJ8Kr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:58 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-vslhbuRMTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:32:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:32:59 +0000
Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks
 the session out
In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17050-70-QfgOqK4rzi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:03 +0000
Subject: [Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-vRYKMHPP5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:09 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-5pKX7A3jiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:14 +0000
Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display
 needs to be fixed
In-Reply-To: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21270-70-t9mUAKHPxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:20 +0000
Subject: [Koha-bugs] [Bug 21529] Fix display of HTML tags in print notices
In-Reply-To: <bug-21529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21529-70-jYhQ0C6UAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:22 +0000
Subject: [Koha-bugs] [Bug 21635] Incorrect GROUP BY clause in batchMod.pl
In-Reply-To: <bug-21635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21635-70-zEqBdyU4py@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21635

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:24 +0000
Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out
 by field in Checkout history
In-Reply-To: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28859-70-r61noobrmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:29 +0000
Subject: [Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
In-Reply-To: <bug-22363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22363-70-hTB91DW3lM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:33 +0000
Subject: [Koha-bugs] [Bug 22615] Add routes for /ill_backends
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-JFYNdc9b5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:38 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
 according to CurrencyFormat pref
In-Reply-To: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22121-70-gZLMd2GpEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:43 +0000
Subject: [Koha-bugs] [Bug 23835] ILL Module not working in 19.05,
 shows error in about page
In-Reply-To: <bug-23835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23835-70-C4QL4vxHnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23835

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:47 +0000
Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and
 managing Koha's JavaScript Dependencies
In-Reply-To: <bug-17241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17241-70-wqtQtAtCO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17241

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:52 +0000
Subject: [Koha-bugs] [Bug 21073] Improve plugin performance
In-Reply-To: <bug-21073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21073-70-Py2EdbUVW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:33:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:33:57 +0000
Subject: [Koha-bugs] [Bug 21352] Allow plugins to add CSS and Javascript to
 Staff interface
In-Reply-To: <bug-21352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21352-70-OmiyfZwAt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21352

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:01 +0000
Subject: [Koha-bugs] [Bug 21905] Plugin hook
 intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered
In-Reply-To: <bug-21905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21905-70-DGeN5WMqnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:06 +0000
Subject: [Koha-bugs] [Bug 28768] OPAC reading history page
 (opac-readingrecord.pl) wont display news items
In-Reply-To: <bug-28768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28768-70-475GFizd3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:10 +0000
Subject: [Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on
 ILLs
In-Reply-To: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18591-70-0dLQc46JVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:14 +0000
Subject: [Koha-bugs] [Bug 21585] Missing firstnames should be gracefully
 ignored in ILL requests table
In-Reply-To: <bug-21585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21585-70-GfvcRoKyP9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:18 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-a46T2I8Ojr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:25 +0000
Subject: [Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset
In-Reply-To: <bug-20536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20536-70-pgxu3bfHjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:30 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20640-70-kXlgw6Xd3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:37 +0000
Subject: [Koha-bugs] [Bug 23171] The plugin_methods table should not include
 imported methods
In-Reply-To: <bug-23171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23171-70-H4P3qexeBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23171

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:41 +0000
Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying
 accruing fine with RenewAccruingItemWhenPaid turned off
In-Reply-To: <bug-25508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25508-70-00y9xQd5zy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:45 +0000
Subject: [Koha-bugs] [Bug 27927] longoverdue cronjob renews items before
 marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine
 are enabled
In-Reply-To: <bug-27927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27927-70-Kux3UFScQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:49 +0000
Subject: [Koha-bugs] [Bug 21725] Incorrect HAVING in group by in
 Acquisitions.pm
In-Reply-To: <bug-21725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21725-70-n42cjwbcfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:54 +0000
Subject: [Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor
In-Reply-To: <bug-20260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20260-70-4GDy7DZAWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:34:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:34:59 +0000
Subject: [Koha-bugs] [Bug 22196] Clean up Mana KB administration template
In-Reply-To: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22196-70-1UGaCHhK2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:35:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:35:04 +0000
Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a
 next/previous status
In-Reply-To: <bug-22280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22280-70-fkOeDWdgtm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:35:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:35:08 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: <bug-24321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24321-70-MkrNdP7ZM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:35:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:35:12 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-4RmADeaZTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:35:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:35:17 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-1amlQsgIKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:35:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:35:21 +0000
Subject: [Koha-bugs] [Bug 26114] ILL should mark status=RET only if a return
 happened
In-Reply-To: <bug-26114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26114-70-K25OF39way@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114

Andrew Isherwood <bugzilla at warmlight.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bugzilla at warmlight.co.uk    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:45:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:45:22 +0000
Subject: [Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify
 search mapping modifications
In-Reply-To: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17897-70-Lc9pdWuF0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from David Nind <david at davidnind.com> ---
Tests are still failing for me:

prove -vvv t/db_dependent/Koha/SearchEngine/ElasticSearch.t
t/db_dependent/Koha/SearchEngine/ElasticSearch.t .. 
# Subtest: Reset Elasticsearch mappings
    ok 1 - Scenario: Reset Elasticsearch mappings to an empty database
    ok 2 - Given empty search mapping tables
    ok 3 - When reset_elasticsearch_mappings() has been ran
    ok 4 - Then search mapping tables have been populated
    ok 5 - Scenario: Reset Elasticsearch mappings when custom mappings already
exist
    1..5
ok 1 - Reset Elasticsearch mappings
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Data truncated for column 'type' at row 1 at
/kohadevbox/koha/Koha/Objects.pm line 114
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 11 just after 1.
Dubious, test returned 11 (wstat 2816, 0xb00)
All 1 subtests passed 

Test Summary Report
-------------------
t/db_dependent/Koha/SearchEngine/ElasticSearch.t (Wstat: 2816 Tests: 1 Failed:
0)
  Non-zero exit status: 11
  Parse errors: No plan found in TAP output
Files=1, Tests=1,  4 wallclock secs ( 0.02 usr  0.00 sys +  3.65 cusr  0.15
csys =  3.82 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:46:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:46:44 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-A55mNRqopH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143688|0                           |1
        is obsolete|                            |

--- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143765&action=edit
Bug 16223: Add new columns to table restriction_types

This patch adds two new columns, lift_after_payment and fee_limit,
to table restriction_types. These colums are used to control
lifting patrons restrictions after paying their fees.

To test:
1. Apply this patch.
2. Update your database via updatedatabase.pl.
=> Confirm your table restriction_types has two new columns.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:46:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:46:49 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-yc3IQuQsCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143689|0                           |1
        is obsolete|                            |

--- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143766&action=edit
Bug 16223: DO NOT PUSH! Schema changes

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:46:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:46:55 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-UKjZMlDylP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143690|0                           |1
        is obsolete|                            |

--- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143767&action=edit
Bug 16223: Add ability to define liftable restrictions

Some libraries debar Patrons at the end of the year for having unpaid fines,
like in Bug 15157. Currently librarians have to manually remove this type of
debarments after Patron has paid his/her fines.

This patch adds ability to create restrictions which are lifted after
patron pays ceratain amount of fines.

To test:
1. Apply this patch.
2. Restart your services if needed.
3. Navigate to page restrictions.pl.
=> Note that table has two new colums in it, "Lift after payment?" and "Fee
limit".
4. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
5. Create fees for a patron so they exceed fee limit e.g. 10
6. Add restriction made in step 2. for the patron
7. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:47:00 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-iMixhBqiFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143768&action=edit
Bug 16223: (QA follow-up) Fix kohastructure bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:47:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:47:06 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-e5I42TMsYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143769&action=edit
Bug 16223: (QA follow-up) Remove GetDebarments

We remove the GetDebarments routine in 31095.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:47:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:47:12 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-z7y3ctrt0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143770&action=edit
Bug 16223: (QA follow-up) Move trigger to apply

This patch moves the del_restrictions_after_payment from before the
actual credit application call inside Koha::Account::pay to after the
application of credits to debits in Koha::Account::Line::apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:47:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:47:32 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-1G7t1S3gx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31095


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
[Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use
$patron->restrictions in preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:47:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:47:32 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
 Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
 preference
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-IEk9agHzOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16223


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
[Bug 16223] Automatically remove any borrower debarments after a payment
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:47:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:47:54 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-T33heFkSK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:49:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:49:11 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-NamwYxLaXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've rebased this and taken bug 31095 into account too.. 

I'd love to get an independent sign-off on this if your still interested in
testing it  Andrew Fuerste-Henry ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 11:58:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 10:58:50 +0000
Subject: [Koha-bugs] [Bug 29074] DefaultHoldExpirationdatePeriod blank value
 interpreted as zero
In-Reply-To: <bug-29074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29074-70-ITH9NavGc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |emmi.takkinen at koha-suomi.fi
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Andrew Fuerste-Henry from comment #0)
> If DefaultHoldExpirationdate is on and DefaultHoldExpirationdatePeriod is
> blank, the blank is treated as a zero and all holds are created with an
> expiration date of today. I'm not sure what the best answer is. We could:
> - add some text to the syspref to make clear that a blank is treated as zero
> - make it always save and display a zero when you try to save a blank
> or
> - make it treat a blank as disabled (and then add some text to the syspref
> to tell people that)

Hmm, I'd say either of two last options could be the way to go.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:10:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:10:22 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-6jpWfToxdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143682|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143771&action=edit
Bug 32162: Add primar key to erm_eholdings_packages_agreements

Test plan:
Confirm that this change fixes the related TestBuilder.t failure
Confirm that it does not break the eRM app, try to attach an agreement
to a package.

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:10:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:10:34 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-OzeFNQ3m61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:11:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:11:04 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-nckEQ6ACUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial correction, works as designed, no regressions.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:13:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:13:19 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-tRScaXc92m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143698|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143772&action=edit
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for
ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:13:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:13:34 +0000
Subject: [Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search
 does not work
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-sgzUIt7oPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:13:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:13:46 +0000
Subject: [Koha-bugs] [Bug 31782] Patron lists - patron autocomplete search
 does not work
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-jvdJUcytWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
           Severity|normal                      |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:13:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:13:50 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-S7PUSAe213@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial correction works as desired.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:14:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:14:18 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-dJFDb8O5Ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|32030                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:14:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:14:18 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-BJlCrtZSaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32161                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161
[Bug 32161] ErmEholdingsPackagesAgreement has wrong koha_object_class
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:16:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:16:52 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-SnecJVFY94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143620|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143773&action=edit
Bug 32154: Missing primary key on erm_user_roles table

The aforementioned TestBuilder should display "Koha::ERM::UserRole", not be
empty.

This patch adds a primary key to the erm_user_roles table and fixes that.

Also includes atomicupdate file to update database schema as well as updates to
kohastructure.sql provided by Jonathan Druart.

Looked into the vue files but didn't find anywhere or a need to include the new
primary key in any of the requests as there is no request of users by
role_user_id
being made.

Erm users are being created/updated as a relationship through
licenceses/agreements.

Furthermore, when editing a role of an existing user, this new primary key is
already
being supplied embeded in the license/agreement.

Test plan:
Add users to license and agreement
Run the cypress tests
Confirm that the change fix the test that was failing in TestBuilder.t
(another one may still fail however)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:17:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:17:36 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-gr1YRCxYws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ah yes, your right.. I'd completely missed the NULLable.

Working as desired then..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:18:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:18:13 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-Rg2iwn0i6Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patron lists - patron       |Patron autocomplete broken
                   |autocomplete search does    |when using
                   |not work                    |js/autocomplete/patrons.js

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:19:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:19:09 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-mWXOj2t5vy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143701|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143774&action=edit
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:19:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:19:36 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-YnskaUUL7w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another trivial correction, thanks for the quick follow-ups chaps.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:22:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:22:04 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-HXvseEaTw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143613|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143775&action=edit
Bug 32130: Add a test to ensure vue files will be kept tidy

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:22:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:22:37 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-U1Iy6NL9Ff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Makes great sense to have this.. works as desired.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:25:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:25:54 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-FtJMWIX7aY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:25:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:25:59 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-zBmAa63J3V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141292|0                           |1
        is obsolete|                            |

--- Comment #18 from David Nind <david at davidnind.com> ---
Created attachment 143776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143776&action=edit
Bug 31447: Use holds pick up branch in "Please confirm checkout" message

When one tries to check out item which has hold in it,
"Please confirm checkout" message uses patrons home library
instead of holds pick up library. It would be more logical
to use latter here.

To test:
1. Find record with holds.
2. For first priority hold, change it's pick up library to differ from patrons
homebranch if needed.
3. Check out records item for a different patron.
=> Note that notice reads: "Item ... has been on hold for ... at [patrons
homebranch] since ...".
4. Apply this patch.
5. Repeat steps 2 and 3.
=> Notice should now read: "Item ... has been on hold for ... at [holds pick up
branch] since ...".

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Axelle Clarisse <axelle.clarisse at univ-amu.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:26:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:26:04 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-FWquZzNfMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143386|0                           |1
        is obsolete|                            |

--- Comment #19 from David Nind <david at davidnind.com> ---
Created attachment 143777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143777&action=edit
Bug 31447: Add unit tests

To test prove t/db_dependent/Circulation.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:26:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:26:23 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-3JbjyKRnnb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:26:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:26:27 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-idkIg9vTIO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143778&action=edit
Bug 31782: Fix patron autocomplete on patron list

Test plan:
Add new patrons to a patron list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:26:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:26:31 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-A7kyvxag1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143779&action=edit
Bug 31782: Fix patron autocomplete on order search

Test plan:
Search for order using the "Basket created by" field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:26:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:26:36 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-cy8CyTeU68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143780&action=edit
Bug 31782: Fix autocomplete when duplicating orders

Test plan:
Add a new order to a basket from an existing order
Search for the order to duplicate using the "Basket created by" field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:26:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:26:40 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-kjcjuR9WOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143781&action=edit
Bug 31782: Remove js/autocomplete/patrons.js

On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons
route. A new patron_autocomplete JS function has been written
(js/patron-autocomplete.js) for that purpose.

However 3 occurrences were using an existing patron_autocomplete
function, and 30578 didn't take care of adjusting correctly the call to
the REST API route.

On this patchset I am suggesting to copy/paste the JS functions defined
in js/autocomplete/patrons.js, because we are very close of the 22.11
release. But ideally we should improve js/patron-autocomplete.js to add
a new 'on-select-add-to' option that will take care of add/remove/hide
behaviour. IMO that must be done on a separate bug, and after 22.11 is
released (to not need to retest the other occurrences of the patron
autocomplete)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:32:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:32:06 +0000
Subject: [Koha-bugs] [Bug 32176] New: js/patron-autocomplete.js need another
 option
Message-ID: <bug-32176-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32176

            Bug ID: 32176
           Summary: js/patron-autocomplete.js need another option
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

See commit message from "Bug 31782: Remove js/autocomplete/patrons.js"

We need another option in this function, and remove code duplicate from
patron_lists/list.tt, acqui/histsearch.tt and acqui/duplicate_orders.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:32:35 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-8pa5zUkAzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #5)
> On this patchset I am suggesting to copy/paste the JS functions defined
> in js/autocomplete/patrons.js, because we are very close of the 22.11
> release. But ideally we should improve js/patron-autocomplete.js to add
> a new 'on-select-add-to' option that will take care of add/remove/hide
> behaviour. IMO that must be done on a separate bug, and after 22.11 is
> released (to not need to retest the other occurrences of the patron
> autocomplete)

See bug 32176.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:33:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:33:25 +0000
Subject: [Koha-bugs] [Bug 32177] New: Tests failing for
 t/db_dependent/Circulation.t
Message-ID: <bug-32177-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32177

            Bug ID: 32177
           Summary: Tests failing for t/db_dependent/Circulation.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Tests are failing on master for t/db_dependent/Circulation.t.

Identified when testing bug 31447.

Test results:

root at kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/63 
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5683.
    #          got: '2022-11-11T11:13:53'
    #     expected: '2022-11-25T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5689.
    #          got: '2022-11-11T11:13:53'
    #     expected: '2022-11-25T23:59:00'
    # Looks like you failed 2 tests of 5.

#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.
# Looks like you failed 1 test of 63.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/63 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 63 Failed: 1)
  Failed test:  63
  Non-zero exit status: 1
Files=1, Tests=63, 44 wallclock secs ( 0.12 usr  0.01 sys + 36.52 cusr  3.69
csys = 40.34 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:34:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:34:02 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-kQi6Xef2NP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #20 from David Nind <david at davidnind.com> ---
Note that tests were failing before and after the patches were applied.

I have signed off and created bug 32177.

Before
======

root at kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/63 
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5683.
    #          got: '2022-11-11T11:13:53'
    #     expected: '2022-11-25T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5689.
    #          got: '2022-11-11T11:13:53'
    #     expected: '2022-11-25T23:59:00'
    # Looks like you failed 2 tests of 5.

#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.
# Looks like you failed 1 test of 63.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/63 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 63 Failed: 1)
  Failed test:  63
  Non-zero exit status: 1
Files=1, Tests=63, 44 wallclock secs ( 0.12 usr  0.01 sys + 36.52 cusr  3.69
csys = 40.34 CPU)
Result: FAIL

After
=====

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/64 
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5683.
    #          got: '2022-11-11T11:23:12'
    #     expected: '2022-11-25T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5689.
    #          got: '2022-11-11T11:23:12'
    #     expected: '2022-11-25T23:59:00'
    # Looks like you failed 2 tests of 5.

#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.
Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line
5705.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. 64/64 # Looks like you failed 1 test of 64.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/64 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 64 Failed: 1)
  Failed test:  63
  Non-zero exit status: 1
Files=1, Tests=64, 43 wallclock secs ( 0.10 usr  0.02 sys + 36.13 cusr  3.76
csys = 40.01 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:42:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:42:08 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-60BSOINYd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:42:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:42:12 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-1ouScCIaSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143778|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 143782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143782&action=edit
Bug 31782: Fix patron autocomplete on patron list

Test plan:
Add new patrons to a patron list

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:42:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:42:17 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-bVDLPQy99s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143779|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 143783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143783&action=edit
Bug 31782: Fix patron autocomplete on order search

Test plan:
Search for order using the "Basket created by" field

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:42:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:42:23 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-up9z3wU4IP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143780|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 143784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143784&action=edit
Bug 31782: Fix autocomplete when duplicating orders

Test plan:
Add a new order to a basket from an existing order
Search for the order to duplicate using the "Basket created by" field

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 12:42:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 11:42:28 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-xH5Zs56S4J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143781|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 143785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143785&action=edit
Bug 31782: Remove js/autocomplete/patrons.js

On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons
route. A new patron_autocomplete JS function has been written
(js/patron-autocomplete.js) for that purpose.

However 3 occurrences were using an existing patron_autocomplete
function, and 30578 didn't take care of adjusting correctly the call to
the REST API route.

On this patchset I am suggesting to copy/paste the JS functions defined
in js/autocomplete/patrons.js, because we are very close of the 22.11
release. But ideally we should improve js/patron-autocomplete.js to add
a new 'on-select-add-to' option that will take care of add/remove/hide
behaviour. IMO that must be done on a separate bug, and after 22.11 is
released (to not need to retest the other occurrences of the patron
autocomplete)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:02:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:02:56 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-bIinm5YUT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:02:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:02:58 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-FvDjjrHI2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:01 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-kZyOBcI6Fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:04 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-PXVD4dBbkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:06 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-6KGVjasLUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:09 +0000
Subject: [Koha-bugs] [Bug 32158] Specify due date field is very long now
In-Reply-To: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32158-70-Co3XNrF19z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32158

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:12 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-0352ODUXGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:15 +0000
Subject: [Koha-bugs] [Bug 32161] ErmEholdingsPackagesAgreement has wrong
 koha_object_class
In-Reply-To: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32161-70-rpZq8YReB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:18 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-7uGChPWysM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:21 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-Sy5sdSX4Rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:24 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-DpZqBBFy2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:03:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:03:27 +0000
Subject: [Koha-bugs] [Bug 32163] ErmUserRole has wrong koha_object[s]_class
In-Reply-To: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32163-70-i9rydQEsR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32163

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:04:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:04:54 +0000
Subject: [Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC
 file
In-Reply-To: <bug-30384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30384-70-Rvu26QlhNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:05:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:05:01 +0000
Subject: [Koha-bugs] [Bug 30420] Rename Koha::Patron->get_overdues with
 ->overdues
In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30420-70-xRd95bNE7w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:05:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:05:10 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-Gcpw88xOJR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:05:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:05:18 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-CDYrhXJlDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:05:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:05:26 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-UZJZbFScpo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:05:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:05:34 +0000
Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search
 pages
In-Reply-To: <bug-29971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29971-70-fcOX0N5dyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:05:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:05:41 +0000
Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges
In-Reply-To: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31158-70-BkXL8UuxGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:06:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:06:00 +0000
Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a
 new 'holds' table
In-Reply-To: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25260-70-ajALe78ei1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:06:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:06:32 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-QqkUPWmo4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_21_11_candidate,        |
                   |rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:06:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:06:43 +0000
Subject: [Koha-bugs] [Bug 31343] DataTables error on waitingreserves.tt
In-Reply-To: <bug-31343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31343-70-cMrN8XphSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31343

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:06:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:06:50 +0000
Subject: [Koha-bugs] [Bug 31395] Checking in non-existent barcodes makes
 Koha explode
In-Reply-To: <bug-31395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31395-70-9RSR7zJmfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31395

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:07:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:07:22 +0000
Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the
 page you were on at login for modal logins
In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31699-70-TNxvUjXG6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:13:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:13:08 +0000
Subject: [Koha-bugs] [Bug 31538] Crash on item tab of a record with UNIMARC
In-Reply-To: <bug-31538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31538-70-LyaHPTl5mK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31538

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This looks like a data problem from misc4dev. You should report the problem
there (which I won't fix myself however).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:14:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:14:23 +0000
Subject: [Koha-bugs] [Bug 30739] Fatal errors during MARC import force
 status of "Importing" forever
In-Reply-To: <bug-30739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30739-70-QWpsdH7sQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How is this behaving after bug 27421?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:35:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:35:15 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-iZhmaUzA5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Mark Hofstetter <koha at trust-box.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha at trust-box.at
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:51:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:51:03 +0000
Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
In-Reply-To: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30951-70-YAwgPQOYkg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|22.05                       |unspecified
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Severity|critical                    |normal

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I've tried an upgrade from v3.0.6, then updatedatabase, and the query does not
return anything. Lowering severity.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:54:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:54:02 +0000
Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
In-Reply-To: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30951-70-G9LejTEU9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143787&action=edit
diff to run updatedatabase from v3.0.6

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:54:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:54:36 +0000
Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
In-Reply-To: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30951-70-R8kbbMi5o1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143788&action=edit
output of updatedatabase from v3.0.6 to 22.06.00.083

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:55:14 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-LhQC905swT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #2 from Mark Hofstetter <koha at trust-box.at> ---
Created attachment 143789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143789&action=edit
Bug 20207: Anonymous Purchase Suggestions show on OPAC even when
OPACViewOthersSuggestions is set to Don't Show

When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make
purchase suggestions, once a suggestion has successfully been submitted,  
Anonymous Purchase Suggestions will show on OPAC even when system preference
OPACViewOthersSuggestions, is set to Don't Show.

The suggestions will show on opac-suggestions.pl. However, if you search for
the title you suggested, you will get a message saying "You are not authorized
to see pending purchase suggestions."

This patch fixes the error, ie if OPACViewOthersSuggestions is set to false not
other suggestions are shown (if you are not logged in and AnonSuggestions) OR
ONLY your own suggestions if you are logged in

To test:
1) activate AnonSuggestions
2) create an anon suggestion
3) create a suggestion with a logged in user
4) toggle OPACViewOthersSuggestions Show/Don't show
5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case
6) apply patch
7) OPACViewOthersSuggestions is now respected ie suggestions from other users
are only shown if activated
8) Please sign off

Sponsored-by: Library of the Natural History Museum Vienna

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:55:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:55:22 +0000
Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
In-Reply-To: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30951-70-C7Wab3vw3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
For those wondering, see last two attachments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:58:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:58:14 +0000
Subject: [Koha-bugs] [Bug 31290] Getting error in batch modification
In-Reply-To: <bug-31290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31290-70-E12HGERfmh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31290

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---


*** This bug has been marked as a duplicate of bug 31245 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 13:58:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 12:58:14 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-dWxahoaSr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nayema at mes.ac.in

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 31290 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 14:01:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 13:01:31 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-eO53djFvKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Mark Hofstetter <koha at trust-box.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 14:53:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 13:53:03 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-a1Ew42qUFQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Same for me, I don't get the error (using Firefox).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 14:59:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 13:59:10 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-B7wjDkhDGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #29 from Owen Leonard <oleonard at myacpl.org> ---
statictabs were necessary at the time because there wasn't a good way to
implement jQueryUI tabs when the tabs linked to other pages. It seems likely
that Bootstrap will can do better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:03:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:03:04 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-Baxxvh5Te5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
https://snipboard.io/0uEloj.jpg - shouldn't we hide if there is no template
defined?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:04:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:04:40 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-hQaN1BVtLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #58 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Use statements appear twice
+use URI::Escape qw( uri_escape_utf8 );
+use URI::Escape qw( uri_escape_utf8 );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:16:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:16:53 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-3xSBUSm085@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
There is an encoding issue when you are applying a template that has ♥ in one
of its subfield

Wide character in subroutine entry at /kohadevbox/koha/Koha/Item/Template.pm
line 58

    in Koha::Item::Template::decoded_contents at
/kohadevbox/koha/Koha/Item/Template.pm line 58

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:20:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:20:52 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-FiAdDqNfIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:20:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:20:56 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-TvcojNHCBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143519|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143790&action=edit
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris

We should not write:
    if ($kwfield != undef) {

Test plan:
Pick record with UTF8 chars.
Download via cart or shelf in RIS format.
Check your logs.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:29:36 +0000
Subject: [Koha-bugs] [Bug 32179] New: ERM is missing page-sections
Message-ID: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

            Bug ID: 32179
           Summary: ERM is missing page-sections
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952, 32030
            Blocks: 31757

The newly added ERM module is missing appropraite page-section containers. This
is required to improve contrast in table row highlighting and brings more
consistency to our UI.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:29:36 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-bqeB6ZraEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179
[Bug 32179] ERM is missing page-sections
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:29:36 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-EQOaN9jLOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179
[Bug 32179] ERM is missing page-sections
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:29:36 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-6BT09vUjZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179
[Bug 32179] ERM is missing page-sections
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:29:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:29:46 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-wO0CmY5fDg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:29:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:29:53 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-9Vk3cgdlOo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:36:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:36:50 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-kJVvuuopaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Shouldn't we lower the severity of this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:38:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:38:31 +0000
Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 -
 ES7
In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25439-70-zyVj5ifvBe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
What's the status of this? All the bug reports linked have been pushed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:42:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:42:44 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-u1NjOjz0cZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 15:47:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 14:47:34 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-axhOFIXHYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143791&action=edit
Bug 32179: Add page-sections as appropraite to the ERM module

We missed the page-section addition when ERM was updated for the new UI
prior to push.

Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
   * ERM > Agreements
   * ERM > Licenses
   * ERM > eHoldings > Local > Packages
   * ERM > eHoldings > Local > Titles
   * ERM > eHoldings > Local > Titles > Add from a list
   * ERM > eHoldings > EBSCO > Packages
   * ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
   step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:13:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:13:55 +0000
Subject: [Koha-bugs] [Bug 32180] New: ERM - Mandatory fields don't have the
 'required' class on the label
Message-ID: <bug-32180-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32180

            Bug ID: 32180
           Summary: ERM - Mandatory fields don't have the 'required' class
                    on the label
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030

At least not all of them, it's inconsistent - https://snipboard.io/pIRQBl.jpg


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:13:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:13:55 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-HoSdQO1scF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32180


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32180
[Bug 32180] ERM - Mandatory fields don't have the 'required' class on the label
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:30:53 +0000
Subject: [Koha-bugs] [Bug 32181] New: ERM - Cannot filter by expired when
 adding an agreement to EBSCO's package
Message-ID: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

            Bug ID: 32181
           Summary: ERM - Cannot filter by expired when adding an
                    agreement to EBSCO's package
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:30:53 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-fkWEhlNNTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32181


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181
[Bug 32181] ERM - Cannot filter by expired when adding an agreement to EBSCO's
package
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:31:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:31:22 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-tXqt6YXZvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, pjamorim91 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:34:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:34:20 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-vguHABTYS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:34:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:34:25 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-30O3N0DTHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143792&action=edit
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's
package

We shouldn't change the current route (which will lead to change the
view) when we are adding an agreement to a EBSCO's package

Test plan:
Go to E-Resource management / eHoldings / EBSCO / Packages
Search for a package, select one
Click "Add new agreement"
Use the "Filter by expired" filter
=> Without this patch you are redirected to the package list view
=> With this patch applied the table is filtered as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:36:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:36:25 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-SwDuJOBmkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:36:30 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-bDUHMO8KwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143791|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143793&action=edit
Bug 32179: Add page-sections as appropraite to the ERM module

We missed the page-section addition when ERM was updated for the new UI
prior to push.

Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
   * ERM > Agreements
   * ERM > Licenses
   * ERM > eHoldings > Local > Packages
   * ERM > eHoldings > Local > Titles
   * ERM > eHoldings > Local > Titles > Add from a list
   * ERM > eHoldings > EBSCO > Packages
   * ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
   step 4.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: Run prettier

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:36:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:36:44 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-72SOQSdlSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:41:04 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-nXQH5mpOTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
          Component|Staff Client                |ERM
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:41:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:41:29 +0000
Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy
In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32130-70-LH0gZrqnaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |jonathan.field at ptfs-europe.
                   |                            |com,
                   |                            |pedro.amorim at ptfs-europe.co
                   |                            |m
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
          Component|Architecture, internals,    |ERM
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:41:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:41:43 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-XCzXbTG5oZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.field at ptfs-europe.
                   |                            |com,
                   |                            |pedro.amorim at ptfs-europe.co
                   |                            |m
          Component|Staff Client                |ERM
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:41:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:41:47 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-xYp5DCD3Hs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
          Component|Architecture, internals,    |ERM
                   |and plumbing                |
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |jonathan.field at ptfs-europe.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:41:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:41:58 +0000
Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not
 have a primary key
In-Reply-To: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32162-70-N25PAN2wu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun
                   |com                         |ity.org
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
          Component|ERM                         |Architecture, internals,
                   |                            |and plumbing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:42:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:42:06 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-VOculHScHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ERM                         |Architecture, internals,
                   |                            |and plumbing
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:42:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:42:20 +0000
Subject: [Koha-bugs] [Bug 32180] ERM - Mandatory fields don't have the
 'required' class on the label
In-Reply-To: <bug-32180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32180-70-TZb1LvehIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32180

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |jonathan.field at ptfs-europe.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |pedro.amorim at ptfs-europe.co
                   |                            |m
          Component|Templates                   |ERM
           Assignee|oleonard at myacpl.org         |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 16:42:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 15:42:33 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-xNsAeLY0gy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
          Component|Templates                   |ERM
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |jonathan.field at ptfs-europe.
                   |                            |com,
                   |                            |pedro.amorim at ptfs-europe.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 17:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 16:16:55 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-imwUa4s6WS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pedro.amorim at ptfs-europe.co
                   |                            |m
           Assignee|chris at bigballofwax.co.nz    |pedro.amorim at ptfs-europe.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 17:17:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 16:17:11 +0000
Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC
In-Reply-To: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30036-70-o1Gj6Its9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like the keyword was set by Tomas in October - maybe it was just a
mistake, meant to be 22.11?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 18:01:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 17:01:55 +0000
Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC
In-Reply-To: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30036-70-Oxe96yMT3S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #16)
> It looks like the keyword was set by Tomas in October - maybe it was just a
> mistake, meant to be 22.11?

(In reply to Lucas Gass from comment #15)
> This is marked as a rel_22_05_candidate but it looks like an enhancement. Do
> we need to backport it?

My mistake. Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 18:19:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 17:19:59 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-Qf3G37CjQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Best approach imo would be to use set the syspref using before() instead of
beforeEach() we're already using for cy.login.

However, this implies the following:
1) Because before() runs previous to beforeEach() this means we would also have
to move login to before() - previous to setting sys pref.
2) If we're doing 1) we also need to re-implement how login is being done,
using cy.session, see
https://www.cypress.io/blog/2021/08/04/authenticate-faster-in-tests-cy-session-command/
3) That said, to use cy.session, we also need to put
experimentalSessionAndOrigin: true in cypress.json since this is still an
experimental thing added in Cypress 8.2, we're using cypress 9.5 last time I
checked.

Lastly, before() can save the original ERMModule sys pref value in some
variable and we restore its' value using after().

I tried all this, and is half-working. It works as expected for the first test
in a spec, but for some reason it's not authenticating for the second test in
the spec. Will keep at it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 18:29:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 17:29:00 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-vuKRDa5Wi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 18:29:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 17:29:10 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-toMcDHruAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 18:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 17:33:15 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-dNvsUg1mZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 18:33:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 17:33:18 +0000
Subject: [Koha-bugs] [Bug 32151] [WARN] Use of uninitialized value in
 numeric ne (!=) at C4/Ris.pm line 834.
In-Reply-To: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32151-70-6CHZzUDggG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32151

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 19:43:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 18:43:02 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-UWkCFXvdMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #60 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143794&action=edit
Bug 24606: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 19:43:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 18:43:41 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-fRuJe41W8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #61 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143795&action=edit
Bug 24606: Fix encoding issues on decoded content

This patch makes the `decoded_contents` method UTF-8 encode the data
before calling the relevant decode_json, as expected by the JSON library
[1].

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item/Template.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!

[1] `Any decoding or encoding (e.g. to UTF-8 or UTF-16) needs to be done
yourself, e.g. using the Encode module.` https://metacpan.org/pod/JSON

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 19:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 18:49:17 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-fbDJWzrgpt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143796&action=edit
Bug 24606: (QA follow-up) Remove duplicate include

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 19:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 18:51:30 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-c8Ar8O1eT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 19:51:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 18:51:57 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-Nt0tLUVbt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143636|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143797&action=edit
Bug 32072: Consistent classes for primary buttons: Cataloging

This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 20:39:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 19:39:02 +0000
Subject: [Koha-bugs] [Bug 32182] New: Replace static tabs markup with
 Bootstrap
Message-ID: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

            Bug ID: 32182
           Summary: Replace static tabs markup with Bootstrap
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: david at davidnind.com, dcook at prosentient.com.au,
                    gmcharlt at gmail.com, lucas at bywatersolutions.com,
                    martin.renvoize at ptfs-europe.com,
                    testopia at bugs.koha-community.org
        Depends on: 30952

In order for tabs to look correct on certain pages which use the "statictabs"
class we need to restructure the tabs to use Bootstrap markup.

maininvoice.tt
pay.tt
paycollect.tt
reviewswaiting.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 20:39:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 19:39:02 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-IdidRpyXwi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32182


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182
[Bug 32182] Replace static tabs markup with Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 20:54:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 19:54:11 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-QKvOsqR1Zf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 20:54:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 19:54:24 +0000
Subject: [Koha-bugs] [Bug 32072] Consistent classes for primary buttons:
 Cataloging
In-Reply-To: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32072-70-IrcrvXU89P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32072

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 20:55:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 19:55:39 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-tvPmuqxxcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #58)
> Use statements appear twice
> +use URI::Escape qw( uri_escape_utf8 );
> +use URI::Escape qw( uri_escape_utf8 );

Done.

(In reply to Jonathan Druart from comment #59)
> There is an encoding issue when you are applying a template that has ♥ in
> one of its subfield
> 
> Wide character in subroutine entry at /kohadevbox/koha/Koha/Item/Template.pm
> line 58

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 20:56:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 19:56:55 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-XN3fPRmjiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #64 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #57)
> https://snipboard.io/0uEloj.jpg - shouldn't we hide if there is no template
> defined?

Kyle, this is not strictly a blocker, but we really need you to fix it for the
release. Separate bug please.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 21:33:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 20:33:37 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-IEB3HKOnAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 21:33:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 20:33:42 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-3kfXok2DYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143789|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 143798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143798&action=edit
Bug 20207: Anonymous Purchase Suggestions show on OPAC even when
OPACViewOthersSuggestions is set to Don't Show

When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make
purchase suggestions, once a suggestion has successfully been submitted,  
Anonymous Purchase Suggestions will show on OPAC even when system preference
OPACViewOthersSuggestions, is set to Don't Show.

The suggestions will show on opac-suggestions.pl. However, if you search for
the title you suggested, you will get a message saying "You are not authorized
to see pending purchase suggestions."

This patch fixes the error, ie if OPACViewOthersSuggestions is set to false not
other suggestions are shown (if you are not logged in and AnonSuggestions) OR
ONLY your own suggestions if you are logged in

To test:
1) activate AnonSuggestions
2) create an anon suggestion
3) create a suggestion with a logged in user
4) toggle OPACViewOthersSuggestions Show/Don't show
5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case
6) apply patch
7) OPACViewOthersSuggestions is now respected ie suggestions from other users
are only shown if activated
8) Please sign off

Sponsored-by: Library of the Natural History Museum Vienna

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 21:40:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 20:40:57 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-nZdGmEJWUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
This fixes the display of purchase suggestions on the OPAC when not logged in 

However, if you are a logged in user on the OPAC you still only see your own
purchase suggestions. (Home > Your account > Purchase suggestions > [toggle
'Suggested by anyone' and 'Suggested by me' in search for]

Should this be fixed on this bug, or a new one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 11 21:54:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 20:54:25 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-v3Lco8i7yE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #5 from Mark Hofstetter <koha at trust-box.at> ---
sorry I don't see the possibility to [toggle 'Suggested by anyone' and
'Suggested by me' in search for] I am working on 22.05

imho OPACViewOthersSuggestions suggests (sorry f the pun) that no other
suggestions are shown. Maybe 'Suggested by anyone' should be rephrased or only
shown if OPACViewOthersSuggestions is true

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 00:35:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 23:35:10 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-yqm22pcVty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143800&action=edit
Screenshot [22.05.x] - logged in patron purchase suggestions

Apologies for any confusion caused!

I've run through things again (detailed notes below), with these conclusions:

- This patch fixes things on master for the issue identified in this bug (I
didn't try and apply the patch to 22.05.x)

- A separate bug is required for master only for logged in patrons: if
OPACViewOthersSuggestions is set to 'Show', it only shows the logged in
patron's suggestions and not all suggestions (this is working correctly on
22.05.x, but NOT on master)

I hope I haven't confused things even more!

22.05.x
=======

Setup: need at least x1 suggestion already by an anonymous patron, and x1
suggestion by a logged in patron.

Not logged in
-------------

AnonSuggestions set to 'Allow'
AND
OPACViewOthersSuggestions set to 'Show'
AND
when not logged in

>From OPAC home > Purchase suggestions:
==> displays suggestions from anonymous and logged in patrons (as expected)

If OPACViewOthersSuggestions is set to "Don't show":
==> doesn't display any suggestions (as expected)

If OPACViewOthersSuggestions is set to "Don't show" and you add a new
suggestion when not logged in:
==> it shows other suggestions made by anonymous users (but NOT suggestions
made by logged in users)

Logged in
---------

Login as a patron and go to Your account > Purchase suggestions - purchase
suggestions show correctly:
- OPACViewOthersSuggestions set to "Don't show" - can only see your own
suggestions (as expected)
- OPACViewOthersSuggestions set to "Show" - after the search for the input
field there is a dropdown list with options to show suggestions "Suggested by
me" and "Suggested by anyone", works as expected

master
======

Setup: need at least x1 suggestion already by an anonymous patron, and x1
suggestion by a logged in patron.

Not logged in
-------------

AnonSuggestions set to 'Allow'
AND
OPACViewOthersSuggestions set to 'Show'
AND
when not logged in

>From OPAC home > Purchase suggestions:
==> displays suggestions from anonymous and logged in patrons (as expected)

If OPACViewOthersSuggestions is set to "Don't show":
==> displays suggestions from anonymous and logged in patrons (NOT expected,
also different behaviour from 22.05.x where it does not show any suggestions)

If OPACViewOthersSuggestions is set to "Don't show" and you add a new
suggestion when not logged in:
==> it shows other suggestions made by anonymous AND logged in patrons (NOT
expected, also different behaviour from 22.05.x where it only shows suggestions
from anonymous users).

Logged in user
--------------

Login as a patron and go to Your account > Purchase suggestions - purchase
suggestions DON'T show correctly:
- OPACViewOthersSuggestions set to "Don't show" - can only see your own
suggestions (as expected)
- OPACViewOthersSuggestions set to "Show" - after the search for the input
field there is a dropdown list with options to show suggestions "Suggested by
me" and "Suggested by anyone", correctly shows your own suggestions, but when
you select "Suggested by anyone" and press 'Go' it DOESN'T show suggestions
made by others (NOT expected, different behaviour from 22.05.x where it works
as expected)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 00:53:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 23:53:12 +0000
Subject: [Koha-bugs] [Bug 32183] New: Purchase suggestions for logged in
 patron - doesn't display suggestions made by everyone
Message-ID: <bug-32183-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32183

            Bug ID: 32183
           Summary: Purchase suggestions for logged in patron - doesn't
                    display suggestions made by everyone
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

If OPACViewOthersSuggestions is set to 'Show', for a logged in patron they can
only see their own suggestions - not all suggestions as expected.

This is working correctly on 22.05.x, but is not working on the current master.

To replicate on the current master:
1. Set AnonSuggestions to 'Allow'.
2. Set OPACViewOthersSuggestions to 'Show'.
3. On the OPAC, when not logged in, add a purchase suggestion.
4. On the OPAC, log in as a patron and make a purchase suggestion.
5. Change OPACViewOthersSuggestions to "Don't show".
6. Under Your account > Purchase suggestions, you can only see your own
suggestions (as expected).
6. Change OPACViewOthersSuggestions set to "Show".
7. Under Your account > Purchase suggestions, after the "Search for" input
field there is a dropdown list with options:
   7.1 Select "Suggested by me" and press "Go": the patron's own suggestion(s)
are correctly shown.
   7.2 Select "Suggested by anyone" and press 'Go': it DOESN'T show all
suggestions.

Identified when testing bug 20207.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 00:53:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 23:53:35 +0000
Subject: [Koha-bugs] [Bug 32183] Purchase suggestions for logged in patron -
 doesn't display suggestions made by everyone
In-Reply-To: <bug-32183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32183-70-GoPXy4WCny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32183

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20207

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 00:53:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Nov 2022 23:53:35 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-dEXLwVdC2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32183

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 08:30:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 07:30:00 +0000
Subject: [Koha-bugs] [Bug 31050] Standardize session setup
In-Reply-To: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31050-70-v1H4eaaV7L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32178

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 08:32:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 07:32:30 +0000
Subject: [Koha-bugs] [Bug 28507] Create Koha::Session wrapper to create
 consistent sessions throughout Koha
In-Reply-To: <bug-28507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28507-70-DXXznaZS7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32178

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:10:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:10:11 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-JbwfxzUUFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143793|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143801&action=edit
Bug 32179: Add page-sections as appropraite to the ERM module

We missed the page-section addition when ERM was updated for the new UI
prior to push.

Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
   * ERM > Agreements
   * ERM > Licenses
   * ERM > eHoldings > Local > Packages
   * ERM > eHoldings > Local > Titles
   * ERM > eHoldings > Local > Titles > Add from a list
   * ERM > eHoldings > EBSCO > Packages
   * ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
   step 4.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:10:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:10:51 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-g0525jKu7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:11:11 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-pd8Pd2OMkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Minor rebase (and now I have the prettier git hook :) )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:12:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:12:28 +0000
Subject: [Koha-bugs] [Bug 31815] Remove round corners from tabbed sections
In-Reply-To: <bug-31815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31815-70-pBU80ypgbU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This was sorted by bug 31759 :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:13:15 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-CilFctRRBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32182

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:13:15 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-MHTZzqBw3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31759

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:13:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:13:58 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-hXyxsi7KnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for the reminder Owen, Koha's got so much history now I forget how
things work sometimes ;P..

I see you've opened bug 32182 to resolve this piece, awesome :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:14:43 +0000
Subject: [Koha-bugs] [Bug 31759] Improve styling of tabs
In-Reply-To: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31759-70-ANyAN4T9Wh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32182


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182
[Bug 32182] Replace static tabs markup with Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:14:43 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-Fm6e2zKWmu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31759


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31759
[Bug 31759] Improve styling of tabs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:16:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:16:10 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-YUj7niVlHE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |30952
             Blocks|30952                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:16:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:16:10 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-BPSq3UxAeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32155
         Depends on|32155                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155
[Bug 32155] Course reserves - instructors display is misaligned on course
information page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:16:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:16:27 +0000
Subject: [Koha-bugs] [Bug 32156] Form misalignment - wrapping when content
 wider than screen
In-Reply-To: <bug-32156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32156-70-qnWODHD21s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |30952
             Blocks|30952                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:16:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:16:27 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-uRhSGA1Q7X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32156
         Depends on|32156                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32156
[Bug 32156] Form misalignment - wrapping when content wider than screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:16:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:16:46 +0000
Subject: [Koha-bugs] [Bug 32157] Renewal due date input field width -
 adjusts to the width of the screen
In-Reply-To: <bug-32157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32157-70-Sg8DKo0qYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30952
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Blocks|30952                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:16:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:16:46 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-25N6afGC2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32157
         Depends on|32157                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32157
[Bug 32157] Renewal due date input field width - adjusts to the width of the
screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:17:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:17:58 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-ZIq3uNtLaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30952                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:17:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:17:58 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-r9VKNVxq58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32182                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182
[Bug 32182] Replace static tabs markup with Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:18:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:18:55 +0000
Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref
In-Reply-To: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31886-70-MXcMwdEQmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30952                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:18:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:18:55 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-s1xXpJavY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31886                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886
[Bug 31886] No side menu when searching for syspref
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:19:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:19:25 +0000
Subject: [Koha-bugs] [Bug 31815] Remove round corners from tabbed sections
In-Reply-To: <bug-31815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31815-70-EPR7kEuerF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30952                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:19:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:19:25 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-UaBZM9GciJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31815                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31815
[Bug 31815] Remove round corners from tabbed sections
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:20:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:20:25 +0000
Subject: [Koha-bugs] [Bug 31902] Inconsistent table formatting for 'Existing
 holds'
In-Reply-To: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31902-70-cezgy0ccc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|31806                       |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806
[Bug 31806] Add 'page-section' to holds page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:20:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:20:25 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-n1qFgPbQOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31902


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902
[Bug 31902] Inconsistent table formatting for 'Existing holds'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:20:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:20:25 +0000
Subject: [Koha-bugs] [Bug 31806] Add 'page-section' to holds page
In-Reply-To: <bug-31806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31806-70-MQfGY8iSRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31902                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902
[Bug 31902] Inconsistent table formatting for 'Existing holds'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:21:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:21:32 +0000
Subject: [Koha-bugs] [Bug 31926] Add page-section to MARC framework pages
 (admin)
In-Reply-To: <bug-31926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31926-70-t9aC4dtKPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30952                       |
             Blocks|31757                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:21:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:21:32 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-OXucgKFbHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31926                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926
[Bug 31926] Add page-section to MARC framework pages (admin)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:21:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:21:32 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-vg6vFjWBAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|31926                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31926
[Bug 31926] Add page-section to MARC framework pages (admin)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:21:58 +0000
Subject: [Koha-bugs] [Bug 31820] Add page-section to order receive page (acq)
In-Reply-To: <bug-31820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31820-70-r7NtIuvyWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30952                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Blocks|31757                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:21:58 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-cjgTqQwavD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31820                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820
[Bug 31820] Add page-section to order receive page (acq)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:21:58 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-S7g9To8jLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|31820                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31820
[Bug 31820] Add page-section to order receive page (acq)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 09:24:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 08:24:16 +0000
Subject: [Koha-bugs] [Bug 31950] Page section on library view is too wide /
 not aligned with toolbar
In-Reply-To: <bug-31950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31950-70-FK1mEM00ZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |isobel.graham09 at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 12:35:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 11:35:30 +0000
Subject: [Koha-bugs] [Bug 32184] New: Rename opacbookbag and intranetbookbag
Message-ID: <bug-32184-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32184

            Bug ID: 32184
           Summary: Rename opacbookbag and intranetbookbag
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Book bag is not a term used anywhere in Koha, it would be better to rename the
pref to something including 'cart' or another more generic/known term.

See also: bug 26130

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 12:37:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 11:37:22 +0000
Subject: [Koha-bugs] [Bug 32184] Rename opacbookbag and intranetbookbag
In-Reply-To: <bug-32184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32184-70-hxK9iBDyUl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32184

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bargioni at pusc.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 14:21:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 13:21:03 +0000
Subject: [Koha-bugs] [Bug 32185] New: Template error in opac-reserve.pl
Message-ID: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

            Bug ID: 32185
           Summary: Template error in opac-reserve.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

This turned up in translations:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: 

<span class="notforloan">Not for loan ([%
AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan',
authorised_value => itemLoo.notforloan ) %] %])

Results in this string:
Not for loan (%s %%])

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 17:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 16:41:27 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-vWCvXXzZpr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

advsalahuddinahmed072 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |advsalahuddinahmed072 at gmail
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 17:47:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 16:47:08 +0000
Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation
 (MARC21 880)
In-Reply-To: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23032-70-TQVtsDAzDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142224|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143802&action=edit
Bug 23032: Show MARC21 880 for 264 on detail pages

This patch adds the 880 display for 264 (in addition to 260) on the
detail pages.

To test:
0) Apply patch
1) Create/edit a record
2) Create 264 $6 880-01 $a Xianggang : $b Tushuguan, $c 2022
3) Create 880 $6 264-01 $a 香港 : $b 图书馆, $c 2022
4) View record and see "Publication details" appear with the 880
script on the detail page on both the staff interface and OPAC

Signed-off-by: Johanna Miettunen <johanna.miettunen at haaga-helia.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 17:55:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 16:55:37 +0000
Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation
 (MARC21 880)
In-Reply-To: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23032-70-nSjUVjE9BQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

jmiettunen <johanna.miettunen at haaga-helia.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johanna.miettunen at haaga-hel
                   |                            |ia.fi

--- Comment #7 from jmiettunen <johanna.miettunen at haaga-helia.fi> ---
Works as described is staff client and in OPAC, when 264 and 880 with subfields
6, a, b, c have been changed to visible in MARC bibliographic framework that
the record is using.
Notice! If there's information both in 260 and 264, plus linkage in 880, then
information in 260 is not shown in Publication details in Normal view. I'm not
a cataloguer, but I guess in real life one is not putting publication details
to both 260 and 264 at the same time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 19:40:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 18:40:41 +0000
Subject: [Koha-bugs] [Bug 31505] Improve
 etc/zebradb/lang_defs/nb/sort-string-utf.chr
In-Reply-To: <bug-31505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31505-70-lH1YgQPrXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31505

advsalahuddinahmed072 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |advsalahuddinahmed072 at gmail
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 21:32:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 20:32:59 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-yvBDQ65RXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 143803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143803&action=edit
Bug 32131: Cypress tests are failing if ERMModule is off

This patch solves this by enabling the system preference before each test,
right after login. It also sets the system preference back to its original
initial value after the tests finish running.

To test:
1) Disable ERMModule system preference
2) Run cypess tests: yarn cypress open / yarn cypress run
3) Verify that tests run successfully
(Optional): While tests are running, visit the system preferences panel and
verify that the system preference is now "Enable".
4) Wait for the tests to finish and confirm that the system preference is set
back to its original "Disable" value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 21:35:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 20:35:15 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-IjvXPEl1si@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Further analysis:
login() doesn't work if called in before(), with or without cy.session, so it
needs to remain in beforeEach() which means the setting of the ERM sys pref
also needs to happen in beforeEach(), after logging in.

Tried to shorten the tests suite runtime duration by preventing visiting sys
pref panel in case we are trying to enable the already enabled sys pref. Did
this using env vars but this could cause it to fail if tests are paused and
redone, leading to the real value and env var value to differ, i.e. env var
value persists through subsequent test runs (this happened while using cypress
open).

Finally, using cy.session for login works (and shortens tests suite duration
slightly), but again, only if in beforeEach(), not in before(). I think this
should also be implemented, but with its' own bug # and only if the use of
experimentalSessionAndOrigin is considered reasonable by others.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 22:11:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 21:11:49 +0000
Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation
 (MARC21 880)
In-Reply-To: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23032-70-bazWf1xXgU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

jmiettunen <johanna.miettunen at haaga-helia.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 22:20:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 21:20:33 +0000
Subject: [Koha-bugs] [Bug 32186] New: [DOCS] Add information about the
 opacbookbag preference to the manual
Message-ID: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

            Bug ID: 32186
           Summary: [DOCS] Add information about the opacbookbag
                    preference to the manual
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

Add information about the 'opacbookbag' system preference to the cart chapter
(lists.rst).

See the mailing list discussion thread
https://lists.katipo.co.nz/pipermail/koha/2022-November/058666.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 22:22:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 21:22:35 +0000
Subject: [Koha-bugs] [Bug 32186] [DOCS] Add information about the
 opacbookbag preference to the manual
In-Reply-To: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32186-70-g0nrjPJE77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/koha-com
                   |                            |munity/koha-manual/-/merge_
                   |                            |requests/602

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I made a merge request adding some information:

https://gitlab.com/koha-community/koha-manual/-/merge_requests/602

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 12 22:25:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Nov 2022 21:25:21 +0000
Subject: [Koha-bugs] [Bug 32186] [DOCS] Add information about the
 opacbookbag preference to the manual
In-Reply-To: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32186-70-uo5ysGVRMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from David Nind <david at davidnind.com> ---
Merged. Thanks Katrin! 

(I was going to add a bug number to the commit message, then didn't actually
add it!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 03:03:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 02:03:51 +0000
Subject: [Koha-bugs] [Bug 32186] [DOCS] Add information about the
 opacbookbag preference to the manual
In-Reply-To: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32186-70-fPsiiIpGKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I wondered if you had missed it and had the same idea I had :) Should have made
a bug to begin with.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:10:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:10:57 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-nhAbc4nmFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:11:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:11:01 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-aoz9MeRVaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143201|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143804&action=edit
Bug 31261: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:11:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:11:06 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-QV0PI9P5BN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143203|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143805&action=edit
Bug 31261: Introduce flatpickr-futureinclusive

That let us use future + today, and it's working perfectly for our use
case :)

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:11:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:11:54 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-gbTmxeZL8W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Really helpful enh bordering on a bug fix (scheduling something in the past
doesn't make sense) :)

Touches templates, but doesn't change strings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:12:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:12:01 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-S6ZN0L3ITn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:23:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:23:16 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-CanjcuaqdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:23:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:23:21 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-YFLjxwKhVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143782|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143806&action=edit
Bug 31782: Fix patron autocomplete on patron list

Test plan:
Add new patrons to a patron list

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:23:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:23:26 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-heS0OvcOW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143783|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143807&action=edit
Bug 31782: Fix patron autocomplete on order search

Test plan:
Search for order using the "Basket created by" field

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:23:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:23:31 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-yVTdNNhMSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143784|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143808&action=edit
Bug 31782: Fix autocomplete when duplicating orders

Test plan:
Add a new order to a basket from an existing order
Search for the order to duplicate using the "Basket created by" field

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:23:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:23:36 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-vSEOcPTKXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143785|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143809&action=edit
Bug 31782: Remove js/autocomplete/patrons.js

On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons
route. A new patron_autocomplete JS function has been written
(js/patron-autocomplete.js) for that purpose.

However 3 occurrences were using an existing patron_autocomplete
function, and 30578 didn't take care of adjusting correctly the call to
the REST API route.

On this patchset I am suggesting to copy/paste the JS functions defined
in js/autocomplete/patrons.js, because we are very close of the 22.11
release. But ideally we should improve js/patron-autocomplete.js to add
a new 'on-select-add-to' option that will take care of add/remove/hide
behaviour. IMO that must be done on a separate bug, and after 22.11 is
released (to not need to retest the other occurrences of the patron
autocomplete)

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:24:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:24:10 +0000
Subject: [Koha-bugs] [Bug 32185] Template error in opac-reserve.pl
In-Reply-To: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32185-70-zYUZdcjAi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Keywords|                            |rel_22_11_candidate
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:33:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:33:45 +0000
Subject: [Koha-bugs] [Bug 32185] Template error in opac-reserve.pl
In-Reply-To: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32185-70-gpXzlSCBDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:33:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:33:49 +0000
Subject: [Koha-bugs] [Bug 32185] Template error in opac-reserve.pl
In-Reply-To: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32185-70-pnsnme1Pm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143810&action=edit
Bug 32185: Fix template typo in opac-reserve.pl

This removes the %] showing for not for loan items disappear.

To test:
* Create a record with multiple items, mark one 'not for loan'
* Place an item level request on this record in the OPAC
* Make sure you 'Show nonholdable items'
* Verify the %] shows in the column with the not for loan status
* Apply patch
* Verify display is now improved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:34:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:34:43 +0000
Subject: [Koha-bugs] [Bug 32185] Template error in opac-reserve.pl
In-Reply-To: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32185-70-loaH6WZUqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As this was found translating we can be sure it affects translations, changing
a string in the OPAC. Maybe we could do another update to the strings a few
days before release to catch such last minute fixed stuff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:35:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:35:22 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-VQ4DnWDfnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:36:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:36:01 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC
 even when OPACViewOthersSuggestions is set to Don't Show
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-IDbJXnhHJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:36:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:36:25 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-tkLfwSgQ9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Anonymous Purchase          |Anonymous suggestions show
                   |Suggestions show on OPAC    |in OPAC even when
                   |even when                   |OPACViewOthersSuggestions
                   |OPACViewOthersSuggestions   |is set to 'Don't show'
                   |is set to Don't Show        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:36:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:36:40 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-kINde9ju1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 14:38:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 13:38:30 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-e9O1PuiBkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
2 things here (for the future):

* When fixing a bug, make sure it's marked as such (bugzilla defaults to
enhancement). This can influence how fast things are looked at, if they are
pushed to stable vesions etc.
* The bug title should describe the problem, the commit message/subject shoudl
describe the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:00:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:00:26 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-soWlBFxMce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #9 from mathieu saby <mathsabypro at gmail.com> ---
Hi
My library is planning to use the holds API to mimic the behavior of the OPAC,
and the current behavior is problematic.

What about a new parameter to define the "context" of the action
(?context=staff vs ?context=opac ) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:10:50 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-1vkSqDlNE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:10:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:10:54 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-fmW5hux4qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143798|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143811&action=edit
Bug 20207: Don't show anyones's suggestions when OPACViewOthersSuggestions is
deactivated

When you enable AnonSuggestions and ALLOW patrons that aren't logged
in to make purchase suggestions, once a suggestion has successfully
been submitted, anonymous purchase suggestions will show on OPAC even
when system preference OPACViewOthersSuggestions, is set to Don't show.

The suggestions will show on opac-suggestions.pl. However, if you search
for the title you suggested, you will get a message saying
"You are not authorized to see pending purchase suggestions."

This patch fixes the error, ie if OPACViewOthersSuggestions is set to
false not other suggestions are shown (if you are not logged in and
AnonSuggestions)
OR ONLY your own suggestions if you are logged in

To test:
1) activate AnonSuggestions
2) create an anon suggestion
3) create a suggestion with a logged in user
4) toggle OPACViewOthersSuggestions Show/Don't show
5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case
6) apply patch
7) OPACViewOthersSuggestions is now respected ie suggestions from other users
are only shown if activated
8) Please sign off

Sponsored-by: Library of the Natural History Museum Vienna

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:10:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:10:59 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-HBM33R27oh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143812&action=edit
Bug 20207: Don't show search options when no suggestions show

When you are not logged in and OPACViewOthersSuggestions is
deactivated, you don't see any suggestions.

When we see no suggestions, we should also not show the option
to serach in suggestions.

To test:
* as a logged in user and logged out, try various combinations of:
  * OPACViewOthersSuggestions
  * AnonSuggestions
* Verify display matches expectations (new button, shown suggestions,
  search input)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:11:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:11:43 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-bCwWU2NPjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
No string changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:39:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:39:32 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-Aq574RsGtC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The Circulation tests are a quite picky. I often only get them to pass
completely after a fresh reset_all. But in this case, these unrelated tests
keep failing:

t/db_dependent/Circulation.t .. 62/64 
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5683.
    #          got: '2022-11-13T14:26:32'
    #     expected: '2022-11-27T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5689.
    #          got: '2022-11-13T14:26:32'
    #     expected: '2022-11-27T23:59:00'
    # Looks like you failed 2 tests of 5.
t/db_dependent/Circulation.t .. 63/64 
#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:41:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:41:40 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-qEPR5oPat5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:41:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:41:45 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-WGW6YzqxBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143776|0                           |1
        is obsolete|                            |

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143813&action=edit
Bug 31447: Use holds pick up branch in "Please confirm checkout" message

When one tries to check out item which has hold in it,
"Please confirm checkout" message uses patrons home library
instead of holds pick up library. It would be more logical
to use latter here.

To test:
1. Find record with holds.
2. For first priority hold, change it's pick up library to differ from patrons
homebranch if needed.
3. Check out records item for a different patron.
=> Note that notice reads: "Item ... has been on hold for ... at [patrons
homebranch] since ...".
4. Apply this patch.
5. Repeat steps 2 and 3.
=> Notice should now read: "Item ... has been on hold for ... at [holds pick up
branch] since ...".

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Axelle Clarisse <axelle.clarisse at univ-amu.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:41:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:41:49 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-X5qPXTwj84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143777|0                           |1
        is obsolete|                            |

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143814&action=edit
Bug 31447: Add unit tests

To test prove t/db_dependent/Circulation.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:42:38 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-78mxL7D32k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
No string changes :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:44:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:44:05 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-4QYngkMqPx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:47:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:47:12 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-tmglc8dI2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:47:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:47:16 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-CXOo8CnVaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143391|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143815&action=edit
Bug 32127: Sort by description in Koha::Template::Plugin::Categories

Like in Koha::Template::Plugin::Branches, methods in
Koha::Template::Plugin::Categories must return categories sorted by
description.

Test plan :
1) Create a new patron category with code ZZZ and description AAAAAA
2) Go to patron search /cgi-bin/koha/members/members-home.pl
3) Look at filter by category :
=> Without patch the value AAAAAA is last
=> With patch the value AAAAAA is first
4) Click on 'New patron'
=> Without patch the value AAAAAA is last
=> With patch the value AAAAAA is first

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:48:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:48:37 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-MKK7NF5D0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:58:38 +0000
Subject: [Koha-bugs] [Bug 32187] New: (Bug 24161 follow-up) With
 IndependentBranches on a non superlibrarian librarian is not able to track
 late orders
Message-ID: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

            Bug ID: 32187
           Summary: (Bug 24161 follow-up) With IndependentBranches on a
                    non superlibrarian librarian is not able to track late
                    orders
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P3
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart+koha at gmail.com

With IndependentBranches a non superlibrarian librarian is not able to track
late orders. 

To reproduce: have an installation of Koha with IndependentBranches on.  Be a
librarian without superlibrarian rights.  Try to generate the report about late
orders (.../cgi-bin/koha/acqui/lateorders.pl).  You should get an error 500
page.  In log you should find something like:

... DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'branchcode' in 'where clause' at
/usr/share/koha/lib/Koha/Objects.pm line 417:
/usr/share/koha/intranet/cgi-bin/acqui/lateorders.pl, referer: ...

This is due to:

            (
                C4::Context->preference('IndependentBranches')
                  && !C4::Context->IsSuperLibrarian
                ? ( 'borrower.branchcode' => C4::Context->userenv->{branch} )
                : ()
            ),

from Koha/Acquisition/Orders::filter_by_lates  (line ~128)

Changing borrower.branchcode into borrowers.branchcode (borrowerS -- missing
's' at the end) does not correct the issue.

The borrower.branchcode was to substitue the C4::Acquisition::GetLateOrders
function, but something went wrong...

The problem was found in 21.11, but it seems that it is still present in the
master (as of November 12th, 2022).

Unfortunately, I'm not able to fix it at the moment.  Jonathan, would you be
able...?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 15:58:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 14:58:47 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-4huOkGoHJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This sounds a bit similar to bug 23202 we encountered after the switch to
flatpickr for 'items on ordering'. 

I also had no issues testing this on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 16:03:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 15:03:45 +0000
Subject: [Koha-bugs] [Bug 31853] The overdue tab states "no renewals left"
 when item is on hold
In-Reply-To: <bug-31853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31853-70-mkQtl9Hiki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31853

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|The Overdue-tab states "no  |The overdue tab states "no
                   |renewals left" when item is |renewals left" when item is
                   |on hold                     |on hold
           Severity|minor                       |normal
            Version|22.05                       |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Hanna, I just checked this on master which will soon be 22.11:

- Checked out an item with a due date in the past 
- Verified it showed on the overdue tab in the OPAC (5 renewals left)
- Placed a hold on it
- OPAC message changed to: No renewals left

As you said, the checkouts tab is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 16:05:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 15:05:04 +0000
Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for
 automatic logins (like self-checkout)
In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22322-70-05KL9Qr4Hn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 16:05:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 15:05:09 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-JwjcHlZVhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:32:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:32:01 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-DeVOTdLmK0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:34:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:34:03 +0000
Subject: [Koha-bugs] [Bug 32188] New: Only show template controls above item
 form if templates have been defined
Message-ID: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

            Bug ID: 32188
           Summary: Only show template controls above item form if
                    templates have been defined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: kyle at bywatersolutions.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
        Depends on: 24606

The new item templates above the item edit form should only show, when at least
one template has been defined.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606
[Bug 24606] Allow storing item values as a template for creating new items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:34:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:34:03 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-TH23Hm73J2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188
[Bug 32188] Only show template controls above item form if templates have been
defined
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:34:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:34:15 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-TlwQwIp013@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:34:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:34:55 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-p637fgKycR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #64)
> (In reply to Jonathan Druart from comment #57)
> > https://snipboard.io/0uEloj.jpg - shouldn't we hide if there is no template
> > defined?
> 
> Kyle, this is not strictly a blocker, but we really need you to fix it for
> the release. Separate bug please.

Filed it as: Bug 32188 - Only show template controls above item form if
templates have been defined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:37:41 +0000
Subject: [Koha-bugs] [Bug 32189] New: When items are created on receive,
 item form layout is broken
Message-ID: <bug-32189-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32189

            Bug ID: 32189
           Summary: When items are created on receive, item form layout is
                    broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952

When items in acquisitions are created on order, the item form shows the same
issues we already fixed on the order form (see bug 31819).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:37:41 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-WS6EUHxu0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32189
[Bug 32189] When items are created on receive, item form layout is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:37:41 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-72LFQq2y2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32189

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:38:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:38:14 +0000
Subject: [Koha-bugs] [Bug 31819] Formatting of item form in acq when
 ordering is broken
In-Reply-To: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31819-70-7ByTs0sGdg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31819

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #16)
> Note that it's still messy when receiving - https://snipboard.io/FxMiK9.jpg

Filed separately as: Bug 32189 - When items are created on receive, item form
layout is broken

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:41:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:41:49 +0000
Subject: [Koha-bugs] [Bug 32174] bulkmarcimport.pl ignore items info when
 using -update
In-Reply-To: <bug-32174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32174-70-9ZM8NEk3GO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32174

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Pablo, there are scripts that mimick the staged import that are probably
better suited for this task: stage_file.pl and commit_file.pl

To my knowledge matching/updating items was not developed for bulkmarcimport.pl
yet, which would make this an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:42:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:42:37 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-9J3p011plh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Order prices not populated  |Order prices not populated
                   |when adding to a basket     |when adding to a basket
                   |form a staged file          |from a staged file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:48:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:48:28 +0000
Subject: [Koha-bugs] [Bug 27973] Limit to currently available items should
 have an option to filter out notforloan statuses
In-Reply-To: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27973-70-YynwgJxIEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27973

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=25375

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Which version have you been testing with?

I believe bug 25375 should have fixed this for 22.11 and 22.05

Although I still believe it's different for different type of libraries and
would love if the behavior could be customized. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 13 23:48:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 22:48:28 +0000
Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items
 does not work
In-Reply-To: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25375-70-lChJUlW1t5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27973

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 00:01:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 23:01:55 +0000
Subject: [Koha-bugs] [Bug 32168] Editing date/datetime fields without the
 dateaccessioned.pl plugin can cause errors
In-Reply-To: <bug-32168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32168-70-C8k2gWAPtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31212

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like we already added dateaccessioned.pl to $w, so we could probably
also add it to datelastseen? 

Just wondering, if that could cause problems with bug 31212

  925         - tagfield: "952"
  926           tagsubfield: "w"
  927           liblibrarian: "Price effective from"
  928           libopac: "Price effective from"
  929           repeatable: 0
  930           mandatory: 0
  931           kohafield: items.replacementpricedate
  932           tab: 10
  933           authorised_value: ""
  934           authtypecode: ""
  935           value_builder: dateaccessioned.pl
  936           isurl: 0
  937           hidden: 0
  938           frameworkcode: ""
  939           seealso: ""
  940           link: ""
  941           defaultvalue:

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 00:01:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 23:01:55 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-RF0gRQZ3hU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32168

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 00:04:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 23:04:10 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-hD9P3sxoIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 00:06:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 23:06:45 +0000
Subject: [Koha-bugs] [Bug 32135] Ability to batch cancel transfers
In-Reply-To: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32135-70-oCysUUexsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32135

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We now also have transfers to send. Should this be added to both pages?

What's the reason/use case for needing the bulk cancel?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 00:34:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Nov 2022 23:34:47 +0000
Subject: [Koha-bugs] [Bug 32140] Sessions created using the OIDC/OAuth2
 client use an "api" interface rather than "intranet" or "opac"
In-Reply-To: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32140-70-Dj5zyzyvNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32140

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
It looks like bug 32178 will resolve this

*** This bug has been marked as a duplicate of bug 32178 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 04:12:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 03:12:40 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-gZyI9y5Ed5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143598|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143817&action=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 04:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 03:13:20 +0000
Subject: [Koha-bugs] [Bug 32142] Add HoldFeeMode option "if all items are
 checked out OR the record has at least one hold already"
In-Reply-To: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32142-70-y7CTGSEqsu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32142

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143817|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 143818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143818&action=edit
Bug 32142: Implement issued_or_reserved HoldFeeMode option

This enhancement adds an issued_or_reserved option to the HoldFeeMode
system preference, so that a hold fee may be charged if either all items
are check out, or the record has at least one hold already.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> Patron categories
3) Edit Category A and add a hold fee of $1.00

4) Go to Administration -> System preferences and search for
HoldFeeMode
5) Set HoldFeeMode to not_always - "only if all items are checked out
and the record has at least one hold already"

6) In another tab, open the staff interface. Search for a record with
one item attached to it (Biblio A)
7) Place a hold on this record for Patron B (any category).

not_always, reserved but not issued

8) Place a hold on Biblio A for Patron A. (Make sure Patron A is of
Category A which the hold fee applies to)
9) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, reserved but not issued

10) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
11) Delete Patron A's hold on Biblio A
12) Place a hold on Biblio A for Patron A
13) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued but not reserved

14) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
15) Delete all holds on Biblio A
16) Check out Biblio A's item (Item A) to Patron B
17) Place a hold on Biblio A for Patron A
18) Check Patron A's accounting page. They should NOT have a hold fee

issued_or_reserved, issued but not reserved

19) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
20) Delete Patron A's hold on Biblio A
21) Place a hold on Biblio A for Patron A
22) Check Patron A's accounting page. They SHOULD have a hold fee

not_always, issued and reserved

23) In your System preferences tab, change HoldFeeMode to
not_always - "only if all items are checked out and the record
has at least one hold already"
24) Delete all holds on Biblio A
25) Place a hold on Biblio A for Patron C (any category).
26) Place a hold on Biblio A for Patron A
27) Check Patron A's accounting page. They SHOULD have a hold fee

issued_or_reserved, issued and reserved

28) In your System preferences tab, change HoldFeeMode to
issued_or_reserved - "either if all items are checked out, or the record
has at least one hold already"
29) Delete Patron A's hold on Biblio A. There should still be a hold for
Patron C.
30) Place a hold on Biblio A for Patron A
31) Check Patron A's accounting page. They SHOULD have a hold fee

32) Ensure tests pass t/db_dependent/Reserves/GetReserveFee.t

Sponsored-by: Horowhenua Libraries Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 05:29:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 04:29:34 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-EM5ZD5gqlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 05:50:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 04:50:42 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-nta2MnbnxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 07:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 06:09:04 +0000
Subject: [Koha-bugs] [Bug 9717] Local use recorded for holds/transfers
In-Reply-To: <bug-9717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9717-70-JyRbUYVx3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 08:54:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 07:54:46 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-GmOkagZVZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The alternative OIDC implementation has been pushed and I hope it fulfills all
requirements of this development. Marking as duplicate, also to make people
aware.

*** This bug has been marked as a duplicate of bug 31378 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 08:54:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 07:54:46 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-cynxrBXrUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shi-yao.wang at inLibro.com

--- Comment #270 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 30988 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 08:55:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 07:55:56 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-Y6oFSou4BK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 09:47:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 08:47:51 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-XALt8XpBtZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pedro, thanks for your time on this.

Yes, we need to use beforeEach, and that's not nice. But we can go with this
solution for 22.11 and improve later.

You should:
1. Build the patch on top of bug 32147 (that will certainly make the tests
fail)
2. Set ERMProviders as well (some tests will fail if EBSCO is selected)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 10:01:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 09:01:42 +0000
Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running
 Koha plugins
In-Reply-To: <bug-31380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31380-70-iJdGZ9NStr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 10:32:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 09:32:10 +0000
Subject: [Koha-bugs] [Bug 18232] Koha::Cache::flush - Simply flush all caches
In-Reply-To: <bug-18232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18232-70-yoQE9RvLRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #7 from Magnus Enger <magnus at libriotech.no> ---
Do we still need this after Bug 20116, which added misc/bin/clear_cache.pl?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:11:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:11:04 +0000
Subject: [Koha-bugs] [Bug 32190] New: An unlimited suspension because of
 OverduesBlockRenewing braks suspension fines
Message-ID: <bug-32190-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32190

            Bug ID: 32190
           Summary: An unlimited suspension because of
                    OverduesBlockRenewing braks suspension fines
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When a user has an account restriction because OverduesBlockRenewing , when the
user returns the material, is not calculating the suspension.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:18:39 +0000
Subject: [Koha-bugs] [Bug 32190] An unlimited suspension because of
 OverduesBlockRenewing breaks suspension fines
In-Reply-To: <bug-32190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32190-70-52vqp2yTdw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|An unlimited suspension     |An unlimited suspension
                   |because of                  |because of
                   |OverduesBlockRenewing braks |OverduesBlockRenewing
                   |suspension fines            |breaks suspension fines

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could you please add a step by step test plan on how to reproduce the issue?
Did you verify switching the preference fixes the problem? Which version did
you test on?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:28:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:28:48 +0000
Subject: [Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in
 OPAC search results
In-Reply-To: <bug-29603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29603-70-FUPbuTZ0YM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.05.00                    |22.05.00;21.11.14
        released in|                            |

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:35:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:35:10 +0000
Subject: [Koha-bugs] [Bug 32011] 2FA - Problem with qr_code generation
In-Reply-To: <bug-32011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32011-70-LGPyl4L2Nx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #28 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on 2FA auth, not present in 21.11.x branch.
Not backporting this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:49:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:49:09 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-FEAmogQwWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #27 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
This one brings in conflicts because of "UseRecalls" present in 22.05 (and not
21.11.x).
It is not easy to backport, I'm afraid to miss the logic here.
Can I get some help with a backport patch for 21.11? Wont backport unless
provided.
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:52:46 +0000
Subject: [Koha-bugs] [Bug 31379] Change results per page text for default
In-Reply-To: <bug-31379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31379-70-wsCHfEnjeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:53:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:53:56 +0000
Subject: [Koha-bugs] [Bug 31489] Typo in EnableExpiredPasswordReset
 description
In-Reply-To: <bug-31489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31489-70-bWWV1KzxtY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on bz29925 which is not present in 21.11.x.
won't backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:55:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:55:36 +0000
Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with
 GetMarcUrls for whitespace
In-Reply-To: <bug-30262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30262-70-R3404KYL0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:55:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:55:52 +0000
Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with
 GetMarcUrls for whitespace
In-Reply-To: <bug-30262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30262-70-hxyVXeydlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:56:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:56:18 +0000
Subject: [Koha-bugs] [Bug 31379] Change results per page text for default
In-Reply-To: <bug-31379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31379-70-vCIVjCMSAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07,         |22.11.00, 22.05.07
        released in|21.11.14                    |
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:56:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:56:56 +0000
Subject: [Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in
 OPAC search results
In-Reply-To: <bug-29603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29603-70-VeidcdAi2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:57:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:57:46 +0000
Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category
 breaks patron search
In-Reply-To: <bug-31421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31421-70-UFpWM1DZlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 11:58:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 10:58:39 +0000
Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer
 auto-resizes
In-Reply-To: <bug-31863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31863-70-hI6SE4v9HE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 12:09:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 11:09:15 +0000
Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
In-Reply-To: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31177-70-VChrVhXsW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to stable            |RESOLVED
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on 22347 not present in 21.11.x.
no need for backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 12:11:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 11:11:55 +0000
Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect
 calendar when calculating expiration date for holds
In-Reply-To: <bug-31356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31356-70-daHE7n8Rhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 12:15:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 11:15:47 +0000
Subject: [Koha-bugs] [Bug 31674] We need a template/guideline around how to
 consistently form our modals
In-Reply-To: <bug-31674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31674-70-pLOdqIfAkO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
          Component|Templates                   |Style guide

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 12:17:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 11:17:41 +0000
Subject: [Koha-bugs] [Bug 31802] We need a clear coding guideline for alert
 box positioning
In-Reply-To: <bug-31802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31802-70-u9wlrboHWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31802

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Style guide
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 12:53:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 11:53:38 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-nLT9Bd9mr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:02:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:02:32 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-JpMnWNG86M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
(In reply to mathieu saby from comment #9)
> Hi
> My library is planning to use the holds API to mimic the behavior of the
> OPAC, and the current behavior is problematic.
> 
> What about a new parameter to define the "context" of the action
> (?context=staff vs ?context=opac ) ?

Hi Mathieu,
I totally agree with you.
Moreover, this is what I've implemented in another bug I've been working on :
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

This one was for ILS-DI but some circulation rules are dependent of the context
by design
(opacitemholds especially).

So, we need a way to set C4::Context->interface from API calls.

I think this new parameter should be optional so as not to break any existing
software that use this API.
What do you think the default behavior should be if parameter is not set? Opac
or Staff?
I would recommend Opac since it is more restrictive.
Arthur

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:07:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:07:23 +0000
Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is
 restricted/debarred
In-Reply-To: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24841-70-dR7bbihaGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to mathieu saby from comment #9)
> Hi
> My library is planning to use the holds API to mimic the behavior of the
> OPAC, and the current behavior is problematic.
> 
> What about a new parameter to define the "context" of the action
> (?context=staff vs ?context=opac ) ?

By design, the /api/v1/holds endpoint is to be used as an admin user. As such,
it has some -x-koha-override options (that can be enlarged, and it should
prevent placing a hold under those problematic scenarios. If it doesn't it is
because the underlying methods are not implementing the checks, as Arthur
mentions.

On the other hand, if you really want to do things as the patron (OPAC) we
should be implementing a /api/v1/public/ route instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:05 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-XnHHqqSBsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:08 +0000
Subject: [Koha-bugs] [Bug 20207] Anonymous suggestions show in OPAC even
 when OPACViewOthersSuggestions is set to 'Don't show'
In-Reply-To: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20207-70-YbrZxRCRcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:11 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-cpbxJhS581@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:13 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-nXhFPPD82r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:19 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-MYTkgFRq2l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:25 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-nMZSLzz76e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:29 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-kjCmAaZ432@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:33 +0000
Subject: [Koha-bugs] [Bug 32179] ERM is missing page-sections
In-Reply-To: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32179-70-XZqrniRJJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32179

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:36 +0000
Subject: [Koha-bugs] [Bug 32185] Template error in opac-reserve.pl
In-Reply-To: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32185-70-cyqXLb7uEO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:22:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:22:38 +0000
Subject: [Koha-bugs] [Bug 32185] Template error in opac-reserve.pl
In-Reply-To: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32185-70-i89NZRuJMj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32185

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:24:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:24:39 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-N2JcedSBQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Failed QA

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Makes sense, needs regression tests though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:27:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:27:27 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-mKzel2Hquy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:27:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:27:30 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-vSZHDHPKSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:30:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:30:04 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-JvMNgmDyj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:30:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:30:07 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-S2ABkTiydi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143735|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:30:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:30:30 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-hgAHJp6Skf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143823&action=edit
Bug 32086: Consistent classes for primary buttons: Patrons

This patch makes changes the button markup in patron
module templates so that all submit buttons and any buttons that should
should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron module pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:31:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:31:18 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-1i3raBfZU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:31:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:31:29 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-Rn9Bnwt0rM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143733|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:32:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:32:02 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-IX3HluuBSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143824&action=edit
Bug 32094: Consistent classes for primary buttons: Serials

This patch makes changes the button markup in serials templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view serials pages to confirm that
everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:34:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:34:02 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-yHX2oZ4eok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:34:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:34:05 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-79jP2YVYsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143732|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:35:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:35:09 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-KcEIefpiP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:35:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:35:13 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-PJCs41ubQD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143700|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:35:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:35:47 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-DzOvtTZM0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143825&action=edit
Bug 32098: Consistent classes for primary buttons: Clubs and rotating
collections

This patch makes changes the button markup in clubs and rotating
collections templates so that all submit buttons and any buttons that
should should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron clubs and rotating collections
pages to confirm that everything looks correct. In most cases there are
no visible changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:36:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:36:49 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-fZPB84rAsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:36:52 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-S7tQaSurc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143699|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:37:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:37:23 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-BePjGJJDKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143826&action=edit
Bug 32099: Consistent classes for primary buttons: Assorted templates

This patch makes changes the button markup in various assorted
templates so that all submit buttons and any buttons that should should
be styled as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view the following pages to confirm that
everything looks correct. In most cases there are no visible changes.

- Staff interface login
- Authorities -> Add/edit
- Authorities -> Merge
- ILL -> ILL requests
- Tools -> Patron lists
- Administration -> Manage plugins -> Upload plugin
- Point of sale
- Point of sale -> Transaction history
- Holds
- Suggestions
- Tags
- Calendar

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:38:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:38:44 +0000
Subject: [Koha-bugs] [Bug 32177] Tests failing for
 t/db_dependent/Circulation.t
In-Reply-To: <bug-32177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32177-70-2xBbh1Bz4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32177

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:39:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:39:31 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-rAvqLrkHs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:39:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:39:34 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-ufXG0Zzs9e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143736|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:40:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:40:21 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-D4pasQNBxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143827&action=edit
Bug 32103: Remove flex from tab-content list elements

To test:
1. Go to HTML customization, News, or Pages and make a new entry using the text
editor ( CodeMirror )
2. It is hard to focus on the Content field because the wrapper width is very
small.
3. Apply patch and try again
4. The CodeMirror wrapper width should be normal again.
5. Check the other language tabs.
6. Also test the WYSIWYG editor, it should also be normal.

Note: I added some CSS to make the labels appear bold.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:40:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:40:47 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-CCzDUn0Aqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:40:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:40:49 +0000
Subject: [Koha-bugs] [Bug 32086] Consistent classes for primary buttons:
 Patrons
In-Reply-To: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32086-70-zsQabzMDXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:40:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:40:52 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-ExBiCOEPXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:40:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:40:55 +0000
Subject: [Koha-bugs] [Bug 32094] Consistent classes for primary buttons:
 Serials
In-Reply-To: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32094-70-TudOemeRn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32094

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:40:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:40:57 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-OF0cf3Gu6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:00 +0000
Subject: [Koha-bugs] [Bug 32096] Consistent classes for primary buttons:
 Tools
In-Reply-To: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32096-70-uMLjCatkcJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32096

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:03 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-aEYDPlik7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:06 +0000
Subject: [Koha-bugs] [Bug 32098] Consistent classes for primary buttons:
 Clubs and rotating collections
In-Reply-To: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32098-70-LsF2uIblbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32098

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:09 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-MnJ9EgC5aQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:11 +0000
Subject: [Koha-bugs] [Bug 32099] Consistent classes for primary buttons:
 Assorted templates
In-Reply-To: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32099-70-zve3b1nNNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32099

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:14 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-mNNMv0p7yc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:41:19 +0000
Subject: [Koha-bugs] [Bug 32103] Content field in HTML customizations is too
 narrow ( CodeMirror )
In-Reply-To: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32103-70-MKuZ8TvGE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:48:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:48:11 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-bOTG7ZklWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |
  Text to go in the|                            |This feature introduces a
      release notes|                            |way to integrate Koha with
                   |                            |any OAuth2/OIDC identity
                   |                            |provider.
                   |                            |
                   |                            |It also prepares
                   |                            |the ground for later adding
                   |                            |more protocol and
                   |                            |prioritizing authentication
                   |                            |methods/identity providers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 13:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 12:48:23 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-8pk6WcwGpo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:03:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:03:12 +0000
Subject: [Koha-bugs] [Bug 32191] New: Consistent upgrade messages
Message-ID: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

            Bug ID: 32191
           Summary: Consistent upgrade messages
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Our use of 'say $out'  is not really consistent, and we need to tidy it for the
release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:03:31 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-ReOYZFXktr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:12:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:12:40 +0000
Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series
 entry in search results
In-Reply-To: <bug-30231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30231-70-rXn0MFWfg7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:26:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:26:29 +0000
Subject: [Koha-bugs] [Bug 31488] Rephrase "You have checked out too many
 items" to be friendlier
In-Reply-To: <bug-31488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31488-70-o7kVT1Me3u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:27:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:27:55 +0000
Subject: [Koha-bugs] [Bug 31364] Saving multi-select system preference don't
 save when all checks are removed
In-Reply-To: <bug-31364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31364-70-KxRRrLzvIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:29:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:29:23 +0000
Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use
In-Reply-To: <bug-30042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30042-70-7aIezzMRy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |RESOLVED

--- Comment #13 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on bz29843, can't backport to 21.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:30:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:30:43 +0000
Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl
In-Reply-To: <bug-31483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31483-70-PxRIJiWWk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on bz31382, can't backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:31:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:31:05 +0000
Subject: [Koha-bugs] [Bug 31483] Minor UI problem in opac-reset-password.pl
In-Reply-To: <bug-31483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31483-70-1GO4P6AXnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:32:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:32:15 +0000
Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require
 full serials permission
In-Reply-To: <bug-29608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29608-70-uS8wnPJTv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:33:35 +0000
Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields
 cause ISE
In-Reply-To: <bug-28290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28290-70-VRLkan2yJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:35:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:35:06 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-feAqi0tvhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:38:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:38:50 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
 the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To: <bug-26626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26626-70-AARST9OZ5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #20 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:46:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:46:51 +0000
Subject: [Koha-bugs] [Bug 32192] New: Fines Calculation not working
Message-ID: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32192

            Bug ID: 32192
           Summary: Fines Calculation not working
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: samrocks1011 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 143828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143828&action=edit
Red Box Created.

Dear Team,

I have set "finesMode"  to Calculate and Charges, but even though the Fine is
not calculated, it doesn't show under individual patron pages.

I have checked the koha-common Cron job on the server is running fine with any
error. I have created the Circulation & fines rule as suggested by Koha Wiki.

I have checked the logs files bit nothing is generated that points to any
issue. 

I do not know if this is a bug or if I have more settings that needs to be done
on koha to make this work.

Regards,
Sandeep Patel

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 14:51:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 13:51:44 +0000
Subject: [Koha-bugs] [Bug 31401] Update administration sidebar to match
 entries on administration start page
In-Reply-To: <bug-31401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31401-70-w9lYYqimcj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:02:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:02:05 +0000
Subject: [Koha-bugs] [Bug 32192] Fines Calculation not working
In-Reply-To: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32192-70-P61lrDiVNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32192

Sandeep Patel <samrocks1011 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:02:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:02:44 +0000
Subject: [Koha-bugs] [Bug 31542] Home page links wrong font-family
In-Reply-To: <bug-31542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31542-70-CsI9v8PxXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31542

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:08:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:08:37 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-p3X7qamseD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #25 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11.x for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:10:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:10:51 +0000
Subject: [Koha-bugs] [Bug 31530] HTML tags in TT comments in
 patron-search.inc
In-Reply-To: <bug-31530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31530-70-pH1Ic4MTdo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31530

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
                 CC|                            |arthur.suzuki at biblibre.com
         Resolution|---                         |FIXED

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on 30063, can't backport on 21.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:12:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:12:03 +0000
Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29658-70-969YHm7d82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:13:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:13:52 +0000
Subject: [Koha-bugs] [Bug 31486] Deleting a message from checkouts tab
 redirects to detail tab in patron account
In-Reply-To: <bug-31486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31486-70-HF0RCPU2nW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:19:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:19:16 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-sY0yrYd7iA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:19:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:19:17 +0000
Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad
 data or constraints
In-Reply-To: <bug-29409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29409-70-qsKSb9Ba4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:19:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:19:21 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-E6bWWNwSin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132117|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143829&action=edit
Bug 30344: Changing a patron from a category that allows guarantees to one that
doesn't should remove that link

If an adult type patron is changed to a child type patron, it hides the
patron's guarantees, but does not remove that link.
We should be removing that link as we do when a guarantee becomes an adult type
patron.

Test Plan:
1) Create an adult with a guarantor
2) Turn that adult into a child patron tyupe
3) Note the guarantees show on the patron details, but not in the patron
   editor
4) Turn that patron back into an adult
5) Note the guarantees how again in the editor
6) Apply this patch
7) Restart all the things!
8) Turn that patron back into a child again
9) Note the guarantees no longer show on the patron details
10) Turn that patron back into an adult
11) Note the patron still has no guarantees

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:21:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:21:23 +0000
Subject: [Koha-bugs] [Bug 31513] NaN errors when using refund and payout
 with CurrencyFormat = FR
In-Reply-To: <bug-31513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31513-70-5kOCmxo4eP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:22:45 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-4qLLevkRgO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #37 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:26:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:26:05 +0000
Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails
 for Koha to MARC mapping using biblio table
In-Reply-To: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31239-70-FT74Prb03L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:27:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:27:30 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-Tmgme0KJnK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:27:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:27:34 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-5VBF7wdqwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143830&action=edit
Bug 32182: Replace static tabs markup with Bootstrap

This patch reimplements certain tabbed interfaces to use Bootstrap
markup. Previously these tabs required special CSS because they're
static, i.e. not JS-driven tabs for switching in-page. The tabs are
links to separate pages.

Note: This patch includes whitespace changes, so use diff accordingly.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the tabs look correct and still
link to the correct locations:

- Patron details
   - Accounting
     - Pay amount
   - Transactions
   - Create manual invoice
   - Create manual credit
- Tools -> Comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:37:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:37:49 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-WnUHUKFWB1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from David Nind <david at davidnind.com> ---
The patch no longer applies 8-(..

git bz apply 32182

Bug 32182 - Replace static tabs markup with Bootstrap

143830 - Bug 32182: Replace static tabs markup with Bootstrap

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32182: Replace static tabs markup with Bootstrap
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
M       koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
M       koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 32182: Replace static tabs markup with Bootstrap

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:48:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:48:48 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-pD4VxDVWmY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:48:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:48:53 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-J6vdpPW7Dd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143831&action=edit
Bug 32170: Add page-section to csv-profiles

This patch adds a page-section div around the csv_profiles list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:50:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:50:20 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-GneHCaegJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143830|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143832&action=edit
Bug 32103: Remove flex from tab-content list elements

    Bug 32182: Replace static tabs markup with Bootstrap

    This patch reimplements certain tabbed interfaces to use Bootstrap
    markup. Previously these tabs required special CSS because they're
    static, i.e. not JS-driven tabs for switching in-page. The tabs are
    links to separate pages.

    Note: This patch includes whitespace changes, so use diff accordingly.

    To test, apply the patch and rebuild the staff interface CSS.

    Test the following pages to confirm that the tabs look correct and still
    link to the correct locations:

    - Patron details
       - Accounting
         - Pay amount
       - Transactions
       - Create manual invoice
       - Create manual credit
    - Tools -> Comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:51:31 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-IEyzfzYX35@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143832|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:52:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:52:21 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-9OruHVxXFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:52:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:52:25 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-bW9lhHCy0C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143833&action=edit
Bug 32182: Replace static tabs markup with Bootstrap

This patch reimplements certain tabbed interfaces to use Bootstrap
markup. Previously these tabs required special CSS because they're
static, i.e. not JS-driven tabs for switching in-page. The tabs are
links to separate pages.

Note: This patch includes whitespace changes, so use diff accordingly.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the tabs look correct and still
link to the correct locations:

- Patron details
    - Accounting
      - Pay amount
    - Transactions
    - Create manual invoice
    - Create manual credit
- Tools -> Comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:52:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:52:59 +0000
Subject: [Koha-bugs] [Bug 15404] CanBookBeReserved: No count of biblio level
 holds if ReservesControlBranch is item's home library
In-Reply-To: <bug-15404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15404-70-nkodKyI9hp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=25408

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 15:52:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 14:52:59 +0000
Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved
 should check "opacitemholds" policy
In-Reply-To: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25408-70-BEI185tDAM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15404

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:01:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:01:59 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-SOwtJDi4sq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:06:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:06:06 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-vGlmirMD18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143834&action=edit
Bug 32191: Add sample output for copying and pasting to skeleton.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:06:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:06:12 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-ZQhjw4BQHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143835&action=edit
Bug 32191: Tidy upgrade scripts output

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:08:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:08:10 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-eTY7WH7VNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:08:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:08:14 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-3bCw9xJ7vn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143833|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 143836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143836&action=edit
Bug 32182: Replace static tabs markup with Bootstrap

This patch reimplements certain tabbed interfaces to use Bootstrap
markup. Previously these tabs required special CSS because they're
static, i.e. not JS-driven tabs for switching in-page. The tabs are
links to separate pages.

Note: This patch includes whitespace changes, so use diff accordingly.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the tabs look correct and still
link to the correct locations:

- Patron details
    - Accounting
      - Pay amount
    - Transactions
    - Create manual invoice
    - Create manual credit
- Tools -> Comments

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:16:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:16:56 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-XVIWmFJ15l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This feature introduces a   |This feature introduces a
      release notes|way to integrate Koha with  |way to integrate Koha with
                   |any OAuth2/OIDC identity    |any OAuth2/OIDC identity
                   |provider.
                  |provider.
                   |
                           |
                   |It also prepares            |It also prepares
                   |the ground for later adding |the ground for later adding
                   |more protocol and           |more protocols and
                   |prioritizing authentication |prioritizing authentication
                   |methods/identity providers. |methods/identity providers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:22:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:22:54 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-nAKTLL27QW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:22:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:22:58 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-5iObzMT8oE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143374|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143837&action=edit
Bug 32109: Fix spacing in toolbars containing text links

This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.

- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Circulation -> Checkout notes
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons
- Tools -> OPAC problem reports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:24:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:24:57 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-wwDO3et792@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:29:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:29:18 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-F8eEjtWIHI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
I reworked this so that all instances of the "selections-toolbar" class also
have the "btn-toolbar" class, and the "toolbar" ID is removed. The intention of
this is to reserve the "toolbar" ID for the "main" toolbar on the page, the one
containing the action buttons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:33:35 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-a0Nmi3Zmid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:33:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:33:40 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-f5OCfJrHBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143834|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143838&action=edit
Bug 32191: Add sample output for copying and pasting to skeleton.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:33:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:33:46 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-XdvOAkIdP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143835|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143839&action=edit
Bug 32191: Tidy upgrade scripts output

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:34:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:34:04 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-Dn1AJG77Bq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I <3 consistency!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:35:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:35:17 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-SmCxHaP8Oa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:35:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:35:23 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-4kTELcCbUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143840&action=edit
Bug 32169: Add page-section and fieldsets to batch item modification

This patch extends some alert boxes to include the error details tables
and updates the html_helpers include to add a page-section around the
item results table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:35:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:35:42 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-m1k91g8ZTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:35:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:35:49 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-YNeAVePvPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:53:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:53:33 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-fdhW9AgGf8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:54:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:54:56 +0000
Subject: [Koha-bugs] [Bug 32135] Ability to batch cancel transfers
In-Reply-To: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32135-70-Esn0g0Q2Yw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32135

--- Comment #3 from Michael Adamyk <madamyk at ckls.org> ---
Primarily because as a consortium we send a lot of transfers in bulk. There are
times when mistakes are made or boxes go missing, and we have to cancel many
transfers at once. 

However, it's an inconvenience at worst, so this may be better marked as
"Trivial" (if that's that the lowest priority level)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 16:58:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 15:58:59 +0000
Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001
 control number to the biblionumber
In-Reply-To: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27981-70-tKupUVt5UD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds a new
      release notes|                            |system preference:
                   |                            |autoControlNumber
                   |                            |
                   |                            |The
                   |                            |systempreference has two
                   |                            |options, Control Number
                   |                            |(001) is:
                   |                            | - generated as
                   |                            |biblionumber: will set
                   |                            |field 001 to the
                   |                            |biblionumber when you
                   |                            |create a new record or edit
                   |                            |an existing record and
                   |                            |clear the 001 field. If a
                   |                            |value is present in 001
                   |                            |when saving the record it
                   |                            |will be preserved.When
                   |                            |duplicating a record the
                   |                            |pre-existing 001 will be
                   |                            |removed.
                   |                            | - not generated
                   |                            |automatically: the 001
                   |                            |field will not be touched

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:04:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:04:30 +0000
Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop
In-Reply-To: <bug-31558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31558-70-oSu39EvKem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:05:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:05:47 +0000
Subject: [Koha-bugs] [Bug 31299] Duplicate output in
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-31299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31299-70-u2eP6fwVke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:09:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:09:41 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-FGaNFycooK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:09:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:09:46 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-jKl73Wkni6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143843&action=edit
Bug 32188: Only show template controls above item form if templates have been
defined

The new item templates above the item edit form should only show, when at least
one template has been defined.

Test Plan:
1) Browse to the item editor
2) Delete all templates
3) Note the template toolbar is displayed
4) Apply this patch
5) Reload the page, note the toolbar is not displayed
6) Create a new template, note the toolbar is now displayed
7) Delete that template, note the toolbar is no longer displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:10:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:10:47 +0000
Subject: [Koha-bugs] [Bug 32193] New: Reindent item details template
Message-ID: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

            Bug ID: 32193
           Summary: Reindent item details template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=X
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 32042

I propose to reformat the item details template in the staff interface
(moredetail.tt) so that it has consistent spacing and indentation.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042
[Bug 32042] Add page-section to items tab (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:10:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:10:47 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to items tab (cat)
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-Nk5QWOYrJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32193


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193
[Bug 32193] Reindent item details template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:11:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:11:39 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-v4t3S4mQr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #65 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
With these new patches the restriction is no longer being lifting on payment. I
see that my restriction type exists, is marked to lift on payment, with a fee
limit of 5.000000. On two different patrons I added a $10 fee, created a
restriction of my created type, and then paid the fine down to under $5. In
both cases, the restriction was not removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:16:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:16:41 +0000
Subject: [Koha-bugs] [Bug 31531] Some modules loaded twice in
 opac-memberentry.pl
In-Reply-To: <bug-31531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31531-70-soBQOVwlmq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31531

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:17:34 +0000
Subject: [Koha-bugs] [Bug 31342] process_message_queue can run over the top
 of itself causing double-up emails
In-Reply-To: <bug-31342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31342-70-Er1agnRzzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31342

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:18:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:18:42 +0000
Subject: [Koha-bugs] [Bug 32194] New: "Can be guarantee" value should show
 uppercase "No"
Message-ID: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

            Bug ID: 32194
           Summary: "Can be guarantee" value should show uppercase "No"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 12446

On the patron categories page, there's a column for "can be guaranteee," that
shows a yes or no value. Except it shows "Yes" with a capital "Y" and "no" with
a lowercase "n." Per our general style guidelines, that "no" should be
capitalized.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:18:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:18:42 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-YLBLG1cgQO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32194


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194
[Bug 32194] "Can be guarantee" value should show uppercase "No"
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:25:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:25:51 +0000
Subject: [Koha-bugs] [Bug 32135] Ability to batch cancel transfers
In-Reply-To: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32135-70-fKYJKeSYks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32135

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trivial - blocker are used for errorenous behaviour/problems. I'd say
enhancement is right here as it would be a small new feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:28:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:28:13 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-7nLZ81NFSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:28:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:28:59 +0000
Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive
 page
In-Reply-To: <bug-30359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30359-70-Sh4QNSUWeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:30:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:30:33 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-TixrT8Mxxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:30:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:30:39 +0000
Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty
 when not filled in before first save attempt
In-Reply-To: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31497-70-iQN0QGy2No@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:32:50 +0000
Subject: [Koha-bugs] [Bug 31598] Fix random failure on Jenkins for
 t/db_dependent/Upload.t
In-Reply-To: <bug-31598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31598-70-paeXJH3f5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31598

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #5 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:35:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:35:17 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-Rns5oDEIfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|Needs Signoff               |RESOLVED

--- Comment #5 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I can no longer reproduce the original issue on master without these patches.
Here's what I get before I apply any of this:

1: create a patron in a category where canbeguarantee=1
2: give that patron a guarantor, confirm it shows in details and editor
3: edit that patron to a category where canbeguarantee=0
4: confirm on details and in editor that patron's guarantor no longer shows
5: edit patron back to their original category
6: confirm their guarantor *still* doesn't show

So I'm marking this resolved, Works for Me, but please adjust if you can
reproduce the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:35:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:35:17 +0000
Subject: [Koha-bugs] [Bug 30351] Changing a patron type should warn
 librarian if a guarantor/guarantee relationship will be severed
In-Reply-To: <bug-30351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30351-70-CQHrZeW1T8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30351
Bug 30351 depends on bug 30344, which changed state.

Bug 30344 Summary: Changing a patron from a category that allows guarantees to one that doesn't should remove that link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:37:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:37:34 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-7DU3lIBQMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:37:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:37:39 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-5hRDrweigp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143844&action=edit
Bug 32193: Reindent item details template

This patch performs general template cleanup to the lists template:
Make indentation consistent, replace tabs with spaces, and trim trailing
whitespace.

To test, apply the patch and confirm that the layout of the page is
unchanged. Test the various operations on the page:

- Setting lost status
- Setting damaged status
- Setting withdrawn status
- Setting local holds priority status
- Adding a public or non-public note

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:37:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:37:44 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-JzhrXH92wt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143845&action=edit
Bug 32193: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:40:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:40:29 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-iFrL4sncA7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:40:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:40:33 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-HQKK4QxWSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143843|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143846&action=edit
Bug 32188: Only show template controls above item form if templates have been
defined

The new item templates above the item edit form should only show, when at least
one template has been defined.

Test Plan:
1) Browse to the item editor
2) Delete all templates
3) Note the template toolbar is displayed
4) Apply this patch
5) Reload the page, note the toolbar is not displayed
6) Create a new template, note the toolbar is now displayed
7) Delete that template, note the toolbar is no longer displayed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:40:51 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-JXGCYPqMHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Setting straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:47:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:47:14 +0000
Subject: [Koha-bugs] [Bug 32195] New: Changing a patron category to disallow
 guarantors should remove existing guarantors
Message-ID: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32195

            Bug ID: 32195
           Summary: Changing a patron category to disallow guarantors
                    should remove existing guarantors
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:
1: have a patron category where CanBeGuarantee is set to Yes.
2: Create a patron in that category, give them a guarantor
3: edit the patron category to set CanBeGuarantee to No
4: confirm your patron still has a guarantor that shows on the details page,
but the guarantor no longer shows on the edit screen
5: this means the guarantor cannot be removed :(

I see a few ways to move forward. We could:
- make Koha go find and remove relationships right away when a category is
updated
- provide a script that could be run/cronned to find and delete relationships
from the command line

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:47:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:47:33 +0000
Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong
In-Reply-To: <bug-30890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30890-70-US5HmWeeZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:48:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:48:37 +0000
Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use
 in intranet and UseCashRegisters is disabled
In-Reply-To: <bug-28167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28167-70-8h6VrRIDEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:49:40 +0000
Subject: [Koha-bugs] [Bug 32196] New: One should be able to remove a
 borrower relationship whenever one exists
Message-ID: <bug-32196-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32196

            Bug ID: 32196
           Summary: One should be able to remove a borrower relationship
                    whenever one exists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 12446

Per bug 32195, there is still at least one way for a patron to end up with a
guarantor in a category that does not allow guarantors. When that happens, the
patron edit screen does not show one the relationship and therefore the
relationship cannot be removed. One should *always* be able to remove an
existing relationship.

To recreate:
1: have a patron category where CanBeGuarantee is set to Yes.
2: Create a patron in that category, give them a guarantor
3: edit the patron category to set CanBeGuarantee to No
4: confirm your patron still has a guarantor that shows on the details page,
but the guarantor no longer shows on the edit screen
5: this means the guarantor cannot be removed :(


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:49:40 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-bAsIzEz9zT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32196
[Bug 32196] One should be able to remove a borrower relationship whenever one
exists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:49:40 +0000
Subject: [Koha-bugs] [Bug 32195] Changing a patron category to disallow
 guarantors should remove existing guarantors
In-Reply-To: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32195-70-DaRpfpyETO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32195

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32196

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:50:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:50:07 +0000
Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single
 label as PDF
In-Reply-To: <bug-31564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31564-70-m24L465Phz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:50:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:50:36 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-phvwlGueVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
That said, please see bug 32195 and bug 32196 for issues where a patron
category is edited and leaves un-editable relationships.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:51:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:51:19 +0000
Subject: [Koha-bugs] [Bug 32195] Changing a patron category to disallow
 guarantors should remove existing guarantors
In-Reply-To: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32195-70-dh957ck9qo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32195

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:51:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:51:21 +0000
Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users
 associated with the funds
In-Reply-To: <bug-27550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27550-70-vcjs65c5ri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:51:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:51:19 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-f0KpOmK3Sn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32195


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32195
[Bug 32195] Changing a patron category to disallow guarantors should remove
existing guarantors
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 17:52:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 16:52:25 +0000
Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include
 totals of sub-sub-funds on acquisitions home page
In-Reply-To: <bug-31367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31367-70-9rdS4WBFgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:02:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:02:44 +0000
Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields
In-Reply-To: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31562-70-CuPJV8ac84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:05:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:05:42 +0000
Subject: [Koha-bugs] [Bug 30462] Should the background job list view hide
 index tasks by default?
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-NlgoZnypSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #38 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on 27344, seems i can't apply that one on 21.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:07:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:07:30 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-4mMMhLzT7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #27 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
unmet dependancies, can't apply on 21.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:07:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:07:31 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-yRGR5ceQxl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
Bug 30982 depends on bug 31565, which changed state.

Bug 31565 Summary: Patron search filter by category code with special character returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:08:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:08:11 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-17QahXoBjE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #28 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
ups, wrong bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:08:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:08:12 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-LfNmi73Pg5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
Bug 30982 depends on bug 31565, which changed state.

Bug 31565 Summary: Patron search filter by category code with special character returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:08:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:08:31 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-SQUGyQaG68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:08:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:08:43 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-XMZszImhid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add page-section to items   |Add page-section to
                   |tab (cat)                   |catalog's item detail view

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:08:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:08:50 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-ZbRcsnrXUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:09:04 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-HWCErkHcGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:09:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:09:23 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-q1kHGdzEIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:10:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:10:03 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-JvK4YjKqQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to stable            |RESOLVED
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #86 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
unmet dependencies, can't apply on 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:10:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:10:04 +0000
Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
In-Reply-To: <bug-31666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31666-70-66cY5duYl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666
Bug 31666 depends on bug 30982, which changed state.

Bug 30982 Summary: Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:14:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:14:20 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-jvboEDKQAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:14:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:14:26 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-HHcTHwBEhJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143847&action=edit
Bug 32042: Add page-section to catalog's item detail view

This patch adds a couple of .page-section divs to the item detail view
in the catalog. A "clearfix" class is also added in order to make sure
the sections don't overlap.

To test, apply the patch and locate a bibliographic record in the
catalog.

- In the sidebar menu of the bibliographic detail view, click "Items."
- On the item detail page, confirm that the information is displayed
  well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:20:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:20:21 +0000
Subject: [Koha-bugs] [Bug 32197] New: Add page-section to catalog's stock
 rotation page
Message-ID: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

            Bug ID: 32197
           Summary: Add page-section to catalog's stock rotation page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 30952
            Blocks: 31757

The stock rotation view of a bibliographic record needs to have a page-section
div added.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:20:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:20:21 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-H553f539Ao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32197


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197
[Bug 32197] Add page-section to catalog's stock rotation page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:20:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:20:21 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-QFfhTSfgCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32197


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197
[Bug 32197] Add page-section to catalog's stock rotation page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:21:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:21:19 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-j1ilTuoAMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:21:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:21:25 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-ZKdg2RT0I1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143845|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143848&action=edit
Bug 32193: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:21:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:21:42 +0000
Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items
 does not work
In-Reply-To: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25375-70-ycb7LBdfKp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #45 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:23:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:23:03 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-z0bDI5IrrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:25:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:25:22 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-uj8ju5M8pZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:25:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:25:28 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-6ECEgQnaSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143831|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143849&action=edit
Bug 32170: Add page-section to csv-profiles

This patch adds a page-section div around the csv_profiles list.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:26:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:26:01 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-AeNiv9qkWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Small 2 line patch, going straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:27:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:27:24 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-Hsd0qiK38U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:27:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:27:27 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-gyFGkYdzmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143850&action=edit
Bug 32197: Add page-section to catalog's stock rotation page

This page wraps the content of the stock rotation page in the catalog
with a "page-section" div.

Note: This patch includes indentation changes, so use diff accordingly.

To test you  must have the StockRotation system preference enabled.
Apply the patch and locate a bibliographic record in the catalog.

- Click the "Rota" link in the sidebar.
- Confirm that the table of items on this page is surrounded by a
  container with a white-background.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:29:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:29:49 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-wfHRcJvInP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks so easy now... :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:30:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:30:20 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-5jfSUvOtD7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:30:25 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-TPgjBKQNag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143847|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143851&action=edit
Bug 32042: Add page-section to catalog's item detail view

This patch adds a couple of .page-section divs to the item detail view
in the catalog. A "clearfix" class is also added in order to make sure
the sections don't overlap.

To test, apply the patch and locate a bibliographic record in the
catalog.

- In the sidebar menu of the bibliographic detail view, click "Items."
- On the item detail page, confirm that the information is displayed
  well.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:45:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:45:12 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-RK2AygelO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143851|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143852&action=edit
Bug 32042: Add page-section to catalog's item detail view

This patch adds a couple of .page-section divs to the item detail view
in the catalog. A "clearfix" class is also added in order to make sure
the sections don't overlap.

To test, apply the patch and locate a bibliographic record in the
catalog.

- In the sidebar menu of the bibliographic detail view, click "Items."
- On the item detail page, confirm that the information is displayed
  well.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:46:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:46:00 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-vKEKSBMk5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Again, an easy fix. PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 18:46:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 17:46:24 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-TEDzJLWpKR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:00:03 +0000
Subject: [Koha-bugs] [Bug 31442] Node.js v12 is EOL
In-Reply-To: <bug-31442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31442-70-ZwBgUe2lNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31442

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
KTD has been upgraded to Node.js v14

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:01:22 +0000
Subject: [Koha-bugs] [Bug 32198] New: Add page-section to stock rotation
 stages list (cat)
Message-ID: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

            Bug ID: 32198
           Summary: Add page-section to stock rotation stages list (cat)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/tools/stockrotation.pl?op=manage_stages&
                    rota_id=1
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

Activate StockRotation in system preferences. Add a rota and then add a stage
to it. The list of stages is missing the page section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:01:22 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-89O5KFZMuG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198
[Bug 32198] Add page-section to stock rotation stages list (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:01:22 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-8yCfbHMlIv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198
[Bug 32198] Add page-section to stock rotation stages list (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:02:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:02:38 +0000
Subject: [Koha-bugs] [Bug 26333] "In" analytics link incorrectly formed when
 "UseControlNumber" set to "Don't use"
In-Reply-To: <bug-26333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26333-70-vnXZNHddcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26333

Daphne Hoolahan <dch at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dch at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:03:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:03:12 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-SwfX6ms7YS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:03:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:03:18 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-abE9DsSUez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143850|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143853&action=edit
Bug 32197: Add page-section to catalog's stock rotation page

This page wraps the content of the stock rotation page in the catalog
with a "page-section" div.

Note: This patch includes indentation changes, so use diff accordingly.

To test you  must have the StockRotation system preference enabled.
Apply the patch and locate a bibliographic record in the catalog.

- Click the "Rota" link in the sidebar.
- Confirm that the table of items on this page is surrounded by a
  container with a white-background.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:04:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:04:07 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-8btGA4GmxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
And another one bites the dust...!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:08:48 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-LOsctEmA0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:17 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-m5BrE8qWkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:19 +0000
Subject: [Koha-bugs] [Bug 32199] New: Add page-section to various patron
 pages
Message-ID: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

            Bug ID: 32199
           Summary: Add page-section to various patron pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 30952
            Blocks: 31757

Several patron-related pages need the page-section container:

- includes/ill-list-table.inc
- members/discharges.tt
- members/files.tt
- members/holdshistory.tt
- members/notices.tt
- members/purchase-suggestions.tt
- members/routing-lists.tt
- members/statistics.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:19 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-5zihmuqaD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32199


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199
[Bug 32199] Add page-section to various patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:19 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-mXZgAqVcxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32199


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199
[Bug 32199] Add page-section to various patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:21 +0000
Subject: [Koha-bugs] [Bug 32188] Only show template controls above item form
 if templates have been defined
In-Reply-To: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32188-70-eozomFxpvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32188

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:25 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-wmsptJ9EPN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:09:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:09:28 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-RgGAa49XMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:10:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:10:27 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-WT7IoReqhv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:10:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:10:32 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-sdHKqpRaws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143840|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143854&action=edit
Bug 32169: Add page-section and fieldsets to batch item modification

This patch extends some alert boxes to include the error details tables
and updates the html_helpers include to add a page-section around the
item results table

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:12:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:12:38 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-sgBpvNbpEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
... PQA too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:20:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:20:00 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-dsGjK9oStj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:20:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:20:18 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-NhSjmEw3f7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143792|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143855&action=edit
Bug 32181: ERM - Fix 'filter by expired' when adding an agreement to EBSCO's
package

We shouldn't change the current route (which will lead to change the
view) when we are adding an agreement to a EBSCO's package

Test plan:
Go to E-Resource management / eHoldings / EBSCO / Packages
Search for a package, select one
Click "Add new agreement"
Use the "Filter by expired" filter
=> Without this patch you are redirected to the package list view
=> With this patch applied the table is filtered as expected

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:23:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:23:54 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-D5NjcacErt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:24:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:24:04 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-6n29XmbYms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143856&action=edit
Bug 32199: Add page-section to various patron pages

This patch adds a .page-section div to various patron-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Patrons ->
    Patron details ->
      - Files
      - Holds history
      - ILL request history
      - Notices
      - Purchase suggestions
      - Routing lists
      - Statistics
- Staff interface home page ->
    Discharge requests pending

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:25:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:25:09 +0000
Subject: [Koha-bugs] [Bug 32200] New: Add page-section checkout notes page
 (circ)
Message-ID: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

            Bug ID: 32200
           Summary: Add page-section checkout notes page (circ)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/circ/checkout-notes.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

The list of checkout notes in staff is missing a page section.

To get there:
* Activate checkout notes in system preferences
* Check something out
* Add a note to the checkout from the OPAC
* From the start page, go to the checkout notes list


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:25:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:25:09 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-sBxmUKmP8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200
[Bug 32200] Add page-section checkout notes page (circ)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:25:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:25:09 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-k2MssbkSa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200
[Bug 32200] Add page-section checkout notes page (circ)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:27:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:27:02 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-IQKklBq1dZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:27:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:27:05 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-gSGjN7tAim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:27:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:27:07 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-ZDaW10PxEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143857&action=edit
Bug 28966: Add Koha::Object(s) for tmp_holdsqueue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:27:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:27:13 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-PRCdwR7MAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143837|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143858&action=edit
Bug 32109: Fix spacing in toolbars containing text links

This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.

- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Circulation -> Checkout notes
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons
- Tools -> OPAC problem reports

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:27:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:27:59 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-cNmWEQiMqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Great fix, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:28:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:28:52 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-gU6KHF5A5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143584|0                           |1
        is obsolete|                            |
 Attachment #143857|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143859&action=edit
Bug 28966: Add Koha::Object(s) for tmp_holdsqueue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 19:29:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 18:29:04 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-uRgPgWXKZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143860&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

Test Plan:
1) Generate the holds queue
2) Load the holds queue viewer page
3) Apply this patch
4) Restart all the things!
5) Reload the page
6) Note nothing has changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:21:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:21:11 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-Utm1dmWGEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:21:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:21:16 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-aUkXUTCsRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143856|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143861&action=edit
Bug 32199: Add page-section to various patron pages

This patch adds a .page-section div to various patron-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Patrons ->
    Patron details ->
      - Files
      - Holds history
      - ILL request history
      - Notices
      - Purchase suggestions
      - Routing lists
      - Statistics
- Staff interface home page ->
    Discharge requests pending

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:21:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:21:20 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-5FzqQ2WzBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143862&action=edit
Bug 32199: (follow-up) Add page-section to circulation history

Note: There is a trick here. If OnsiteCheckouts are active,
the circulation history will be tabbed and not use page-section.
If the pref is off, you'll see the page-section with this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:21:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:21:25 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-6xx9drA9rU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143863&action=edit
Bug 32199: (follow-up) Add page-section to list of validated discharges

This requires that a discharge is added to the patron account first.
Then you'll see that the 'Aready validated discharges' appear within
the white page section.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:27:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:27:39 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-Zr5AX6SGDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143864&action=edit
Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue
syspref is on [v22.05]

The real time hold queue and the build_holds_queue.pl jobs are not 100%
compatible in that we should not be running the cron if the real time queue is
enabled, this could lead to double server work. It would be good to have a
check in build_holds_queue for the RealTimeHoldsQueue syspref and not run the
job if the preference is enabled.

There might be times when we'd want to force a run of this job without changing
the syspref. To that end we would also want a flag for this job so that system
administrators could force the job from the command line if required,
overriding this limitation.

Test Plan:
1) Apply this patch
2) Try run misc/cronjobs/holds/build_holds_queue.pl with the -h/--help and
-m/--man options
3) Disable RealTimeHoldsQueue
4) Run with no options, should succeed
5) Enable RealTimeHoldsQueue
6) Run with no options, should display a message and not rebuild the
   holds queue
7) Run again with the -f/--force option, should succeed

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Bug 31995: (QA follow-up) Add 'system preference' to help text

We often get asked where something can be found in setting,
adding the hint that RealTimeHoldsQueue is a system preference
is hopefully helpful here.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:53:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:53:31 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-ez5oznepu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:53:39 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-o7aEF13SUG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143836|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143865&action=edit
Bug 32182: Replace static tabs markup with Bootstrap

This patch reimplements certain tabbed interfaces to use Bootstrap
markup. Previously these tabs required special CSS because they're
static, i.e. not JS-driven tabs for switching in-page. The tabs are
links to separate pages.

Note: This patch includes whitespace changes, so use diff accordingly.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the tabs look correct and still
link to the correct locations:

- Patron details
    - Accounting
      - Pay amount
    - Transactions
    - Create manual invoice
    - Create manual credit
- Tools -> Comments

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:53:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:53:49 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-AOlDnGAzSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:55:14 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-MKqJ9wU8TR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:55:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:55:50 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-ExzDqBhYQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143861|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 143866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143866&action=edit
Bug 32199: Add page-section to various patron pages

This patch adds a .page-section div to various patron-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Patrons ->
    Patron details ->
      - Files
      - Holds history
      - ILL request history
      - Notices
      - Purchase suggestions
      - Routing lists
      - Statistics
- Staff interface home page ->
    Discharge requests pending

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 20:55:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 19:55:57 +0000
Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation
 (MARC21 880)
In-Reply-To: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23032-70-brG7b58B8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:00:03 +0000
Subject: [Koha-bugs] [Bug 32192] Fines Calculation not working
In-Reply-To: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32192-70-niFF7HLpqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32192

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|BLOCKED                     |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sandeep, the red notice is not equal to fines, just saying it's past the due
date. There are several things that can prevent fines from being charged:

* Is today a holiday in your calendar?
* Is the correct circulation rule applied? Where fine, fine interval, max fine
and grace period set correctly? If the fine interval is not 1, is the fine to
be charged at the beginning or end of the interval?

We just tested fines calculation on master, it worked ok. so this is most
likely a configuration issue that is better suited for IRC or the mailing list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:02:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:02:24 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-5wuZonfj1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143861|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:02:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:02:50 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-gEF8rkv4R3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143866|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:04:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:04:10 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-vO0svGUOfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:04:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:04:15 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-8Eyy6y9LTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143861|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143867&action=edit
Bug 32199: Add page-section to various patron pages

This patch adds a .page-section div to various patron-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Patrons ->
    Patron details ->
      - Files
      - Holds history
      - ILL request history
      - Notices
      - Purchase suggestions
      - Routing lists
      - Statistics
- Staff interface home page ->
    Discharge requests pending

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:04:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:04:20 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-GrGcTojjFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143862|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143868&action=edit
Bug 32199: (follow-up) Add page-section to circulation history

Note: There is a trick here. If OnsiteCheckouts are active,
the circulation history will be tabbed and not use page-section.
If the pref is off, you'll see the page-section with this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:04:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:04:26 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-KZ9nAeMhdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143863|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143869&action=edit
Bug 32199: (follow-up) Add page-section to list of validated discharges

This requires that a discharge is added to the patron account first.
Then you'll see that the 'Aready validated discharges' appear within
the white page section.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:10:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:10:26 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-h2bsDUICjo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
While this is being corrected, adding the following code in OPACUserCSS will
limit the size of the image in OPAC results so that it doesn't take the whole
screen

.cover-image img {
  max-width : 200px;
}

For the intranet, in IntranetUserCSS

td.bookcoverimg {
  max-width : 200px;
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:39:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:39:34 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-o84B4usJCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:39:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:39:52 +0000
Subject: [Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation
 (MARC21 880)
In-Reply-To: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23032-70-eQmMxRb6wt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

--- Comment #8 from Heather <heather_hernandez at nps.gov> ---
You are correct, Johanna--no record should have both a 260 and a 264.  If there
*are* a 260 and 264(s) in one record, 264s are the more recent fields, so I
think it's a good think that 264 data would be displayed (and not 260 data). 
And I am a cataloger.:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:41:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:41:50 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-VDAAYVPPff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143867|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 143870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143870&action=edit
Bug 32199: Add page-section to various patron pages

This patch adds a .page-section div to various patron-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Patrons ->
    Patron details ->
      - Files
      - Holds history
      - ILL request history
      - Notices
      - Purchase suggestions
      - Routing lists
      - Statistics
- Staff interface home page ->
    Discharge requests pending

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:41:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:41:54 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-ku9APKpBGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143868|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 143871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143871&action=edit
Bug 32199: (follow-up) Add page-section to circulation history

Note: There is a trick here. If OnsiteCheckouts are active,
the circulation history will be tabbed and not use page-section.
If the pref is off, you'll see the page-section with this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:41:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:41:59 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-lqPasIfAaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143869|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 143872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143872&action=edit
Bug 32199: (follow-up) Add page-section to list of validated discharges

This requires that a discharge is added to the patron account first.
Then you'll see that the 'Aready validated discharges' appear within
the white page section.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:58:38 +0000
Subject: [Koha-bugs] [Bug 32201] New: Patron circulation history - table
 style: centered and has left border
Message-ID: <bug-32201-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32201

            Bug ID: 32201
           Summary: Patron circulation history - table style: centered and
                    has left border
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 143873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143873&action=edit
Screenshot - circulation history table style issues

When testing bug 32199 (Add page-section to various patron pages) two style
issues were identified with the patron circulation history page:
1. Table is centred
2. There is a left table column border

To replicate:
1. Enable the OnSiteCheckouts system preference
2. Check out two items to a patron
3. Check in one of the items
4. View the circulation history page for the patron
5. Make the screen as wide as possible (or zoom out) - note that the table is
centred instead of left aligned
6. Note that there is a table border on the left-hand side - compare this to
the table on the patron's details > checkouts page 

Images:
- Attached: with patch for bug 32199 applied
- Link: current master https://snipboard.io/aIBufb.jpg

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:59:29 +0000
Subject: [Koha-bugs] [Bug 32201] Patron circulation history - table style:
 centered and has left border
In-Reply-To: <bug-32201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32201-70-XW4mpYwUHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32201

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30952
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32199


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:59:29 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-lRC2Goz7z3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32201


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32201
[Bug 32201] Patron circulation history - table style: centered and has left
border
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 21:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 20:59:29 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-MZAcLd0pJd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32201

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:06:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:06:26 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-t46ykh5vWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:09:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:09:22 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-qj6Vdmt2GJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:09:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:09:26 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-yhQncseUEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 143874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143874&action=edit
Bug 32155: Fix alignment of course details page

This patch eliminates some unnessesary CSS and converts the course details div
into a fieldset.

To test:
1. Create or edit an existing course.
2. Search and add an instructor.
3. Note that the columns are misaligned: the name of the course instructor is
shown first, then the label "Instructors" is shown next.
4. Add another three instructors.
5. Note that this pushes the labels for the next few fields to the right.
6. Apply patch
7. Try steps 1-4 again and confirm everthing looks and works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:09:50 +0000
Subject: [Koha-bugs] [Bug 31735] Circulation optimizations
In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31735-70-ORWb9eGpwN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Optimizations are always good, but reading a bug title as general like this,
always makes me suspicious. 

I feel like this should be an omnibus with separate dependent bugs for the
identified issues. If they need to be done in a certain sequence (which seems
likely for conflicts) they can also be linked to each other using depends.

I'd strongly recommend 'small steps' over big massive patch sets, as they tend
to get stuck in queues because it's too hard to find the time to test them in
one session and they are also most of the time scary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:14:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:14:14 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-iBc9C7KbrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david at davidnind.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:14:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:14:32 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-Qyo4E9MhT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:24:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:24:23 +0000
Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic
 records with standard identifiers from authority data
In-Reply-To: <bug-22972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22972-70-Xnnz9Jsg2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
For MARC21 I think identifiers for $0 are often found in 001/035:
https://www.loc.gov/marc/authority/ad035.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:26:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:26:50 +0000
Subject: [Koha-bugs] [Bug 31706] Journal title and article title fields on
 the ILL request form should be expandable
In-Reply-To: <bug-31706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31706-70-6kzrT0QhHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31706

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Journal Title and Article   |Journal title and article
                   |title fields on the ILL     |title fields on the ILL
                   |Request form should be      |request form should be
                   |expandable                  |expandable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:27:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:27:24 +0000
Subject: [Koha-bugs] [Bug 31705] Option for ILL "Manage request" button to
 appear on left of the screen to improve accessibility
In-Reply-To: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31705-70-bJiUCZ2nQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Option for ILL "Manage      |Option for ILL "Manage
                   |Request" button to appear   |request" button to appear
                   |on Left of the screen to    |on left of the screen to
                   |improve accessibility       |improve accessibility

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:28:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:28:52 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-3plCCSopAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This renders the upload functionality in acq useless. If it's too hard to do
the correct redirect with the jobs in between - should we remove the file
upload option or maybe open it in a new tab so the connection to the basket is
not totally lost?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:30:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:30:13 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-zKLw3HidfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
[Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:30:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:30:13 +0000
Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to
 BackgroundJob
In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27421-70-jsvcprUdzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31711


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711
[Bug 31711] When creating order lines "From a new file" you are no longer
redirected to acq after import
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:39:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:39:08 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order mulitple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-AfctHag63N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I think this might actually be due to the item type from the staged file not
being correctly used to meet the itype requirement on the Item Information tab.
I was getting the same error you pasted on trying to add one of three records
from a MARC file before I touched anything on the accounting tab (following the
test plan on bug 32166). When I selected an item type, the error cleared and
the order saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:39:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:39:41 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-UrgYKhZFGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:39:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:39:45 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-gQEvghExMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

--- Comment #1 from David Nind <david at davidnind.com> ---
Created attachment 143875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143875&action=edit
Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee"
column

This fixes the display of the patron categories "Can be guarantee"
column so that "No" values have a capital "N".

Test plan:
1. Go to Administration > Patrons and circulation > Patron categories.
2. Note that for the "Can be guarantee" column, it shows "Yes" values
   with a capital "Y" and "no" values with a lowercase "n".
3. Apply the patch.
4. Refresh the page.
5. Note that any "No" values now have a capital "N".
6. Sign off D:

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:41:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:41:37 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-Vdxl152cec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the display of
      release notes|                            |the patron categories "Can
                   |                            |be guarantee" column so
                   |                            |that "No" values have a
                   |                            |capital "N". Previously,
                   |                            |"no" values were shown with
                   |                            |a lowercase "n".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:45:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:45:05 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-hEIe9zWSJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:45:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:45:10 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-TX1RRNrXyi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135632|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143876&action=edit
Bug 25267: Impove shelf browser responsiveness

Test plan:
1. Turn on  OPACShelfBrowser.
2. If youre using test data you will have to give some items call numbers. I
did: update items set itemcallnumber = 'acallnumber';
3. It will also be best if you add some cover images.
4. Go to an item detail page and Browse Shelf.
5. The feature looks good until the viewport is about 1700px or less.
6. Apply patch
7. Regenerate OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
8. Try the shelf browse at all screen sizes and make sure everything still
works.
9. Test the controls (previous, next, and close), make sure they still work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:45:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:45:16 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-pywG1dIQ6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135634|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143877&action=edit
Bug 25267: (follow-up) Improve title text responsiveness

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:45:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:45:54 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-zTGEgLJKDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Rebased and fixed conflict in opac.scss.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:48:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:48:15 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-MfPL0ZD6SB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |String patch
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:50:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:50:10 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-UbegCRCFuj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:50:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:50:15 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-3WpgaIGKKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143875|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143878&action=edit
Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee"
column

This fixes the display of the patron categories "Can be guarantee"
column so that "No" values have a capital "N".

Test plan:
1. Go to Administration > Patrons and circulation > Patron categories.
2. Note that for the "Can be guarantee" column, it shows "Yes" values
   with a capital "Y" and "no" values with a lowercase "n".
3. Apply the patch.
4. Refresh the page.
5. Note that any "No" values now have a capital "N".
6. Sign off D:

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:51:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:51:00 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-yQWjOlq96U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Might have to wait because of string freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:52:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:52:26 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-HGydB6RKT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:52:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:52:30 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-TNLYe3MqGx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143874|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143879&action=edit
Bug 32155: Fix alignment of course details page

This patch eliminates some unnessesary CSS and converts the course details div
into a fieldset.

To test:
1. Create or edit an existing course.
2. Search and add an instructor.
3. Note that the columns are misaligned: the name of the course instructor is
shown first, then the label "Instructors" is shown next.
4. Add another three instructors.
5. Note that this pushes the labels for the next few fields to the right.
6. Apply patch
7. Try steps 1-4 again and confirm everthing looks and works correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:53:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:53:10 +0000
Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in
 a Koha that was created before bug 28364 was applied
In-Reply-To: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31612-70-GZZMt3aFM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is there something we can do about this one, at least documentation wise/info
for sysadmins?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:55:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:55:08 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-X5JtlF66oR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

--- Comment #3 from David Nind <david at davidnind.com> ---
Thanks Lucas for fixing!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:55:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:55:27 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-Fo8VWAu4di@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |andrewfh at dubcolib.org

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Looks like you forgot to declare your oder:
Could not compile /kohadevbox/koha/acqui/addorderiso2709.pl: Global symbol
"$oder" requires explicit package name (did you forget to declare "my $oder"?)
at /kohadevbox/koha/acqui/addorderiso2709.pl line 297.
BEGIN not safe after errors--compilation aborted at
/kohadevbox/koha/acqui/addorderiso2709.pl line 754.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:57:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:57:11 +0000
Subject: [Koha-bugs] [Bug 31726] Show record type in z39.50 search results
In-Reply-To: <bug-31726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31726-70-92uKZTt6XD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31726

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe a possible workaround for now would be 
AdditionalFieldsInZ3950ResultSearch. We use it to display 336-338 which gives a
good hint on the type of record for RDA records at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:58:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:58:07 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-4JF4yjZbAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I got an error in testing this and bug 32171 together. The error is due to a
typo in 32171.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:59:46 +0000
Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
In-Reply-To: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12285-70-vUGacg2fHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Emmi, bug 31713 has been pushed now. I think it makes this probably a
duplicate, but could you have a look if it covers all your requirements?

*** This bug has been marked as a duplicate of bug 31713 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 22:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 21:59:46 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-7wRiNppFhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 12285 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:00:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:00:56 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-M8crecKbD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Would still love to have this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:04:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:04:12 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-TBKrAIWEjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #16)
> Subfield `z` is often 'public note' and subfield `x` is often 'nonpublic
> note' for other fields.. I did wonder about supporting subfield `u`
> specifically for a 'uri' to allow for linking to more details or a content
> policy or some such.

a, x an z certainly make sense. Not sure what is better: keep it simple or make
it a complete list. Both could be options.

The 5xx vary a lot in the number of subfields, 500 for example has almost
none/just the basics: https://www.loc.gov/marc/bibliographic/bd500.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:11:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:11:50 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-vxZXfp9sVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140356|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143880&action=edit
Bug 31123: Add `ContentWarningField` preference

This patch adds a new `ContentWarningField` preference allowing the
library to define which 59X field to use to store harmful content
warning notes.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:11:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:11:55 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-DUqCY1H1MR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140357|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143881&action=edit
Bug 31123: Display content warnings on the intranet

This patch adds handling to our XSLT processing to pass the new
`ContentWarningField` preference value to the stylesheets and then uses
that variable to add content warning notes to both the detail and search
result displays of the staff client.

Test plan
1) Run the database update to expose the new system preference
2) Set `ContentWarningField` to something sensible, like `599`
3) Add the above select field to one of your frameworks with a subfield
   `a`.
4) Edit a record with that framework to add a content warning into the
   record
5) Search for the record and confirm you now see `Content warning: Your
   test text`
6) Click into the record detail and confirm you see the content warning
   text there too
7) Bonus points: Assign a new authorized value category to the chosen
   field and subfield and confirm the staff client display text is used
   in the above tests.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:12:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:12:00 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-rWJMSfkcYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140358|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143882&action=edit
Bug 31123: Display content warnings in OPAC

This patch adds handling of content warning display to the OPAC for both
detail and search result views

Test plan
1) Work through the test plan for the previous patch
2) Confirm that the same text now also displays on the equivilent OPAC
   pages.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:13:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:13:08 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-oZHI8QnjI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #17)
> (In reply to Martin Renvoize from comment #16)
> > Subfield `z` is often 'public note' and subfield `x` is often 'nonpublic
> > note' for other fields.. I did wonder about supporting subfield `u`
> > specifically for a 'uri' to allow for linking to more details or a content
> > policy or some such.
> 
> a, x an z certainly make sense. Not sure what is better: keep it simple or
> make it a complete list. Both could be options.
> 
> The 5xx vary a lot in the number of subfields, 500 for example has almost
> none/just the basics: https://www.loc.gov/marc/bibliographic/bd500.html

Rebased. Suggestion: let's use a complete list? That way libraries can use
whatever. Also maybe good in case of UNIMARC?

Did a tiny rebase: conflict in .pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:14:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:14:06 +0000
Subject: [Koha-bugs] [Bug 31742] Highlight logged-in library holdings on
 add/edit items screen (additem.pl)
In-Reply-To: <bug-31742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31742-70-3ovGEl7KeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31742

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like the idea, this would be similar to how we highlight users of the
logged-in library in patron search now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:14:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:14:14 +0000
Subject: [Koha-bugs] [Bug 31742] Highlight logged-in library holdings on
 add/edit items screen (additem.pl)
In-Reply-To: <bug-31742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31742-70-FJxqjgMQ3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:15:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:15:40 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-PyGDFahGMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Catrina Berka <catrina at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |catrina at bywatersolutions.co
                   |                            |m

--- Comment #18 from Catrina Berka <catrina at bywatersolutions.com> ---
Patch didn't apply in sandbox

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:18:00 +0000
Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
In-Reply-To: <bug-28420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28420-70-7ZxxjHG3Wz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420

--- Comment #25 from David Cook <dcook at prosentient.com.au> ---
Changing this to be a duplicate of bug 31378 since it's a generic
implementation now available in master and presumably soon in 22.11

*** This bug has been marked as a duplicate of bug 31378 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:18:00 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-3XHmXfePeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark.jaroski at gmail.com

--- Comment #271 from David Cook <dcook at prosentient.com.au> ---
*** Bug 28420 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:18:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:18:03 +0000
Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response
In-Reply-To: <bug-23548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23548-70-TinjTCn9i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some of the tests are not as independent as they should be. Ususally we assume
all tests need to pass on a standard sample database as provided by ktd or
kohadevbox. You could also probably download the SQL with the data for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:19:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:19:25 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
 Connect)
In-Reply-To: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-MF9Yr3PRLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #79 from David Cook <dcook at prosentient.com.au> ---
I suspect eventually this will be deprecated and removed now that we have bug
31378 in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:19:45 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
 Connect)
In-Reply-To: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-BhyNPZQUtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31378

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:19:45 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-ods1DZ6Z6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10988

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:20:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:20:12 +0000
Subject: [Koha-bugs] [Bug 31779] Article request form shows all locations in
 pickup library menu
In-Reply-To: <bug-31779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31779-70-r4lbuVU56d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
          Component|OPAC                        |Circulation
            Version|22.05                       |master
            Summary|Article Request form shows  |Article request form shows
                   |all locations in pickup     |all locations in pickup
                   |library menu                |library menu

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Changing from OPAC to circulation as the article request form in staff probably
shows the same behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:24:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:24:07 +0000
Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in
 a Koha that was created before bug 28364 was applied
In-Reply-To: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31612-70-1bhCQnRSNB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #3)
> Is there something we can do about this one, at least documentation
> wise/info for sysadmins?

I think this is one of those ones that is easy to fix once you know about it,
so it's tough to devote resources to a more robust automated fix...

Not sure what documentation we'd update for this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:25:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:25:26 +0000
Subject: [Koha-bugs] [Bug 32202] New: Remove kohalib.pl from recall cronjobs
Message-ID: <bug-32202-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32202

            Bug ID: 32202
           Summary: Remove kohalib.pl from recall cronjobs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 29734

>From misc/cronjobs/recalls/expire_recalls.pl and
misc/cronjobs/recalls/overdue_recalls.pl:

+BEGIN {
+    # find Koha's Perl modules
+    # test carefully before changing this
+    use FindBin;
+    eval { require "$FindBin::Bin/../kohalib.pl" };
+}


As Jonathan pointed out on bug 19532 this should not longer be used, as
kohalib.pl has been removed with bug 28617.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:25:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:25:26 +0000
Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29734-70-3vNDFpQket@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32202


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32202
[Bug 32202] Remove kohalib.pl from recall cronjobs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:27:00 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-Ioll1UhVt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #927 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #926)
> From misc/cronjobs/recalls/expire_recalls.pl and
> misc/cronjobs/recalls/overdue_recalls.pl:
> 
> +BEGIN {
> +    # find Koha's Perl modules
> +    # test carefully before changing this
> +    use FindBin;
> +    eval { require "$FindBin::Bin/../kohalib.pl" };
> +}
> 
> Since bug 28617 you should not do that anymore.

Moved to a new bug:
Bug 32202 - Remove kohalib.pl from recall cronjobs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:30:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:30:01 +0000
Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in
 a Koha that was created before bug 28364 was applied
In-Reply-To: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31612-70-MBPVYZuqDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Is there something we can do about this one, at least documentation
> > wise/info for sysadmins?
> 
> I think this is one of those ones that is easy to fix once you know about
> it, so it's tough to devote resources to a more robust automated fix...
> 
> Not sure what documentation we'd update for this one?

We could have updated the release notes note on bug 28346 - but it might be a
little late for that one :)

Maybe a note here and then close this?
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:31:35 +0000
Subject: [Koha-bugs] [Bug 31509] Additional contents: Allow changing the
 column 'code' that groups records
In-Reply-To: <bug-31509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31509-70-CO7WVuYiw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31509

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #5)
> If we really want to fix the mess we should split the table into 2 different
> tables.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:33:35 +0000
Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in
 a Koha that was created before bug 28364 was applied
In-Reply-To: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31612-70-mXc52ec2Wc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #5)
> We could have updated the release notes note on bug 28346 - but it might be
> a little late for that one :)
> 
> Maybe a note here and then close this?
> https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server

I like the idea of adding a note there.

Although I don't think we need to close this one. I still like the idea of an
audit script to check for problematic permissions and stuff like that...
(although I have no idea when I'd ever do it...)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:34:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:34:51 +0000
Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting
 natively when using Zebra
In-Reply-To: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31756-70-NiWYzIJ0IQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
What's the status here? Should the last 2 patches be obsoleted and this be
retested?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:38:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:38:26 +0000
Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in
 a Koha that was created before bug 28364 was applied
In-Reply-To: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31612-70-ezQ03cyykv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server#Troubleshooting

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:38:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:38:31 +0000
Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out
In-Reply-To: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30403-70-csQsS07ygR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142915|0                           |1
        is obsolete|                            |

--- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143883&action=edit
Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout

We currently have syspref UpdateNotForLoanStatusOnCheckin which updates
notforloan status when item is checked in. We should also have
same kind of syspref for check outs. This would be usefull if for
example library has item in exhibition with status
"In exhibition, available for loan". When patron check outs the
item notforloan status can be reseted back to 0, informing staff
that the item is back on circulation.

This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout.

To test:
1. Set items notforloan status as e.g -1.
2. Check out item for a patron.
=> Note that items status doesn't change.
3. Apply patch and update database if needed.
4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout.
5. Check item in and out again for a patron.
=> Note that items status is changed as 0.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Catrina <catrina at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:41:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:41:13 +0000
Subject: [Koha-bugs] [Bug 31612] koha-z3950-responder breaks if it's run in
 a Koha that was created before bug 28364 was applied
In-Reply-To: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31612-70-UQDi0zkrYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31612

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #7)
> https://wiki.koha-community.org/wiki/Setting_up_the_Z39.
> 50_and_SRU_Server#Troubleshooting

Awesome, thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:42:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:42:02 +0000
Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out
In-Reply-To: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30403-70-UethM03JNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403

Catrina Berka <catrina at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catrina at bywatersolutions.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 14 23:45:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 22:45:29 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-fL90ESFSvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #15 from David Nind <david at davidnind.com> ---
There is a build error when regenerating the CSS for the OPAC. This is
happening as well on master, so not caused by this bug. Once resolved, I'll
have a go at testing again.

yarn build --view opac
yarn run v1.22.19
$ node_modules/.bin/gulp build --view opac
[22:33:59] Using gulpfile /kohadevbox/koha/gulpfile.js
[22:33:59] Starting 'build'...
Error in plugin 'sass'
Message:
    koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
Error: File to import not found or unreadable:
../../../../../node_modules/bootstrap/scss/custom-forms.
        on line 52 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
        from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>> @import "../../../../../node_modules/bootstrap/scss/custom-forms";

   ^

[22:33:59] Finished 'build' after 91 ms
Done in 2.42s.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:00:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:00:42 +0000
Subject: [Koha-bugs] [Bug 31849] 'Cancel and transfer all' button does not
 go to background jobs
In-Reply-To: <bug-31849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31849-70-0QUain7v3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31849

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cancel and Transfer all     |'Cancel and transfer all'
                   |button does not go to       |button does not go to
                   |background jobs             |background jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:03:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:03:45 +0000
Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via
 syspref and not just home library
In-Reply-To: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25426-70-56YuynYo55@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:09:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:09:03 +0000
Subject: [Koha-bugs] [Bug 29480] Add email address as a method for
 generating the userid when self registering in OPAC
In-Reply-To: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29480-70-FvBzryu9NL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #13)
> Functional question about:
> 
> +If PatronSelfRegistrationUseridGenerationMethod is set to 'email', the email
> +address will be used as the userid. If the patron being created has no
> email,
> +or the patron has an email address that is already in use by another patron,
> +the default way of creating the userid ($firstname.$surname) will be used.
> 
> Is that really what you want? If my email address is already in the
> database, I probably dont want another account.
> One of the issues we face is actually that impatient people register 2 or 3
> accounts.

We see this for families where the email address of the parents is used in the
children's accounts as well. Also sometimes for internal accounts where a
library address might be used several times. Some academic libraries also do
separate accounts for 'permanent loans'.

Maybe display a warning or so instead of not allowing it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:10:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:10:34 +0000
Subject: [Koha-bugs] [Bug 31748] Restore progress bar on record import
In-Reply-To: <bug-31748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31748-70-VrICeYH1Q3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes please!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:24:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:24:08 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-No7Xe0UCk9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12446

--- Comment #4 from David Nind <david at davidnind.com> ---
This relates to a new feature added to 22.11 in Bug 12446 - Enable an adult to
have a guarantor, so only affects master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:24:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:24:08 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-7O1Lds8fMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32194

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:24:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:24:35 +0000
Subject: [Koha-bugs] [Bug 32194] "Can be guarantee" value should show
 uppercase "No"
In-Reply-To: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32194-70-OY0kldduIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32194

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=12446                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:24:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:24:35 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-Q7h2AT7jCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=32194                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:29:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:29:20 +0000
Subject: [Koha-bugs] [Bug 31576] [21.11] Cannot place hold even when
 AllowHoldPolicyOverride should allow it
In-Reply-To: <bug-31576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31576-70-OwpHH4qfnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cannot place hold even when |[21.11] Cannot place hold
                   |AllowHoldPolicyOverride     |even when
                   |should allow it             |AllowHoldPolicyOverride
                   |                            |should allow it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:32:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:32:57 +0000
Subject: [Koha-bugs] [Bug 31734] Hooks for account, recall,
 indexing and more actions for holds
In-Reply-To: <bug-31734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31734-70-XQlwA0XKS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've updated the wiki with some basic information, but couldn't provide the
full descriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:46:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:46:13 +0000
Subject: [Koha-bugs] [Bug 31968] Problems with MARC staging/import
In-Reply-To: <bug-31968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31968-70-cIjZarCsPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
[Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:46:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:46:13 +0000
Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to
 BackgroundJob
In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27421-70-CI0jEpkVxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31968


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968
[Bug 31968] Problems with MARC staging/import
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:47:00 +0000
Subject: [Koha-bugs] [Bug 31968] Problems with MARC staging/import
In-Reply-To: <bug-31968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31968-70-3VXqvOPwJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|27421                       |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, the dependency made no sense, this was reported for 22.05, but bug 27421 is
only in 22.11... but the mention of the background_job?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
[Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:47:00 +0000
Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to
 BackgroundJob
In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27421-70-W8eEWjB01R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31968                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31968
[Bug 31968] Problems with MARC staging/import
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:51:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:51:14 +0000
Subject: [Koha-bugs] [Bug 32203] New: Refactor checkauth() auth rejected to
 improve maintainability
Message-ID: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

            Bug ID: 32203
           Summary: Refactor checkauth() auth rejected to improve
                    maintainability
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

checkauth() appears to be 706 lines at the time of this writing.

The "AUTH rejected" section is 154 lines or over 20% of the function. 

It's a section devoted mainly to setting up the authentication template, so
it's a very low risk part to change, and for the most part easy to change,
since you just need to check the display on a failed auth.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:51:25 +0000
Subject: [Koha-bugs] [Bug 32203] Refactor checkauth() auth rejected to
 improve maintainability
In-Reply-To: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32203-70-IPfqqRUxIv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:53:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:53:09 +0000
Subject: [Koha-bugs] [Bug 31645] flatpickr - update coding guidelines
In-Reply-To: <bug-31645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31645-70-0km7VnemJl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31645

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Developer documentation     |Style guide

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 00:56:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Nov 2022 23:56:32 +0000
Subject: [Koha-bugs] [Bug 32204] New: in-page anchor to edititem on
 additem.pl not working
Message-ID: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204

            Bug ID: 32204
           Summary: in-page anchor to edititem on additem.pl not working
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

To recreate:

1. Search the catalog and view a record detail page of a record with items
2. Click 'Edit items'
3. Choose one item from the list and click 'Edit'
4. The URL fragment or in-page anchor (#edititem) is appended to the end of the
URL but you are not placed on it. Instead you are placed at the top of the page
and must scroll down to edit the particular item.

Note: This issue is present in master and 22.05.x, as far as I can tell.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 01:01:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 00:01:48 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-qaay5F8mGF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ping? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 01:02:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 00:02:37 +0000
Subject: [Koha-bugs] [Bug 29154] Add hold cancellation reason to holds
 awaiting pickup page
In-Reply-To: <bug-29154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29154-70-nQ1V5xDv7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add hold cancellation       |Add hold cancellation
                   |reason to Holds Awaiting    |reason to holds awaiting
                   |Pickup page                 |pickup page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 01:05:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 00:05:48 +0000
Subject: [Koha-bugs] [Bug 31636] Add part_number and part_name in OPAC
 browse search
In-Reply-To: <bug-31636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31636-70-0IvmrYxxvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31636

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|OPAC                        |Searching - Elasticsearch
            Summary|Add part_number and         |Add part_number and
                   |part_name in opac browse    |part_name in OPAC browse
                   |search                      |search
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 01:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 00:36:41 +0000
Subject: [Koha-bugs] [Bug 30314] Microsoft font makes extra space in OPAC
 with Chrome, Edge, and Vivaldi browsers
In-Reply-To: <bug-30314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30314-70-UNuegSCbj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30314

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I don't believe this to be a Koha issue as Koha itself is neither using
Microsoft nor Google fonts. If there is something we can do, please provide
more information about the changes you made in order to fix this for your
installation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:13:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:13:18 +0000
Subject: [Koha-bugs] [Bug 32203] Refactor checkauth() auth rejected to
 improve maintainability
In-Reply-To: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32203-70-OZwepHH4ST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143888&action=edit
Bug 32203: Add render_auth_page() function

This change adds a "render_auth_page()" function to C4::Auth for
rendering the login page for a failed auth/login.

Test plan:
0. Don't apply patch yet
1. In new tab, go to http://localhost:8081/ and do a failed login
2. In new tab, go to http://localhost:8080/ and do a failed login
3. Apply patch
4. In new tab, go to http://localhost:8081/ and do a failed login
5. In new tab, go to http://localhost:8080/ and do a failed login
6. Note how the failed login screens look the same after the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:16:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:16:25 +0000
Subject: [Koha-bugs] [Bug 32203] Refactor checkauth() auth rejected to
 improve maintainability
In-Reply-To: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32203-70-2751IN9AA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dcook at prosentient.com.au    |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I think I let my excitement to refactor C4::Auth get the better of me. 

Resetting this one to default assignee as I've run out of steam. This patch
probably needs to be split out into 30-50 smaller patches to make the amount of
testing actually workable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:22:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:22:10 +0000
Subject: [Koha-bugs] [Bug 32205] New: Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
Message-ID: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

            Bug ID: 32205
           Summary: Unnecessary sysprefs used in template params for
                    masthead during failed OPAC auth
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

C4::Auth sends many sysprefs as template params unnecessarily since the create
of Koha.Preference().

This issue highlights some of them which are sent during a failed OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:22:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:22:19 +0000
Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32205-70-LLlYewA3T7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32203

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:22:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:22:19 +0000
Subject: [Koha-bugs] [Bug 32203] Refactor checkauth() auth rejected to
 improve maintainability
In-Reply-To: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32203-70-QLUKhCjQMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32205

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:22:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:22:27 +0000
Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32205-70-AUcEHwECiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:28:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:28:30 +0000
Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32205-70-tTiDkiQk6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:28:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:28:34 +0000
Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32205-70-H1zDmLsKGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 143889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143889&action=edit
Bug 32205: Remove unnecessary syspref template params for failed OPAC auth

This patch removes some unnecessary syspref template params for
failed OPAC auth. The templates handle these syspref using the
Koha.Preference() TT plugin function, so they're completely redundant
and just make checkauth() longer than it needs to be.

Test plan:
1) Apply patch
2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs
3) koha-plack --restart kohadev
4) Log out of Koha if you're logged in
5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl
6) Note that you can see the Cart as well as links for the following:
Browse by hierarchy, Authority search, Tag cloud, Subject cloud,
Most popular

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:28:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:28:45 +0000
Subject: [Koha-bugs] [Bug 32203] Refactor checkauth() auth rejected to
 improve maintainability
In-Reply-To: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32203-70-5TjuVxV8pO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:29:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:29:14 +0000
Subject: [Koha-bugs] [Bug 32203] Refactor checkauth() auth rejected to
 improve maintainability
In-Reply-To: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32203-70-jeyL6SsZE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Actually, I think I made a mistake taking out "suggestion" as it doesn't use
Koha.Preference() in the masthead, so the purchase suggestions wouldn't show up
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:33:08 +0000
Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32205-70-DrLEjrXvFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
There are more sysprefs to remove (both for OPAC and staff interface), but I
thought this was an easily manageable chunk.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:33:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:33:22 +0000
Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template
 params for masthead during failed OPAC auth
In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32205-70-59uLYsZH4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Authentication              |Templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 02:36:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 01:36:47 +0000
Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting
 natively when using Zebra
In-Reply-To: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31756-70-rrfE08eVzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #13)
> What's the status here? Should the last 2 patches be obsoleted and this be
> retested?

I suppose I'm fairly indifferent overall. I'm probably OK with this just being
Failed QA / Resolved Won't Fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 06:07:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 05:07:14 +0000
Subject: [Koha-bugs] [Bug 23817] Normalize phone number when searching
 patrons
In-Reply-To: <bug-23817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23817-70-K9BVMWyegP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817

--- Comment #18 from David Cook <dcook at prosentient.com.au> ---
Still looking for testers for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 06:12:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 05:12:34 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for
 the same record
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-HsjVxGvenE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #277 from David Cook <dcook at prosentient.com.au> ---
Aleisha, do you have clients using this functionality?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 06:12:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 05:12:38 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-x96Iqas1rY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #456 from David Cook <dcook at prosentient.com.au> ---
Aleisha, do you have clients using this functionality?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 06:15:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 05:15:41 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-ilwKwmN8GF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #197 from David Cook <dcook at prosentient.com.au> ---
I'll try to keep my eyes upon to QA this one when it's ready.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 07:32:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 06:32:49 +0000
Subject: [Koha-bugs] [Bug 30314] Microsoft font makes extra space in OPAC
 with Chrome, Edge, and Vivaldi browsers
In-Reply-To: <bug-30314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30314-70-fkJYc7BZNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30314

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
謝謝 Frank. Great to hear from you. Very much appreciate your work on translating
Koha into Chinese. 

I've taken a look at biblionumber 132 on the Koha from your screenshot, but I
can't replicate the problem on the latest Chrome on Windows 10.

In the screenshot, the problem looks like it's concerning this line of HTML:
<span class="title_resp_stmt">朝碧雲新聞社編集局編著</span>

On my system, those 11 Chinese glyphs are rendered using the Microsoft YaHei
font, and there's no space there.

--

I'm just noticing that you reported this back in March, so I'm guessing that
you must have resolved your issue.

I was going to say that it's a strange place for there to be a space regardless
of font. I would've guessed a data error rather than a font error there.

I've recently been doing more work on Koha in Traditional Chinese, so your
issue caught my eye.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 08:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 07:05:58 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-f1zsnvag5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi

--- Comment #2 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
We are facing similar problem on version 21.11, but with "Holds pickup period
(day)" field. However in current master the problem field is "Decreased loan
period for high holds" as Klas mentioned.

To test:
1. Create new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period for high holds"
are now empty or have value "Unlimited".
3. Modify rule and set field "Decreased loan period for high holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create new rule, fill all fields expect field "Decreased loan period for
high holds".
6. Delete the rule.
=> Rule is deleted successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 08:10:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 07:10:27 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-WRhmDojLn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143858|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 143890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143890&action=edit
Bug 32109: Fix spacing in toolbars containing text links

This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.

- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Circulation -> Checkout notes
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons
- Tools -> OPAC problem reports

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 08:10:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 07:10:59 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-6gmQwvv7Sh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks Owen :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 08:13:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 07:13:05 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-pTeY2VtAGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

--- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Also to add to this, logs show no error and browsers console shows no
Javascript etc. errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 08:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 07:33:08 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-KINgrVquMs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |

--- Comment #4 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143891&action=edit
Bug 30694: Set decreaseloanholds undef when deleting circulation rule

When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds"
filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 08:50:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 07:50:18 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-SM46Dq3WNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #4) 
> You should:
> 1. Build the patch on top of bug 32147 (that will certainly make the tests
> fail)

Tomas, are you going to push it into 22.11?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:10:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:10:38 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-K9iOYwA8uw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:10:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:10:42 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-oafLHXNkND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143892&action=edit
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:11:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:11:43 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-AosGtOICtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:11:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:11:59 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-R0rlp3DECC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Would that work for you, Katrin?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:25:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:25:31 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-gQTYPJ1FqT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Bug 30327 - Add biblionumber to ComponentSortField
  Added biblionumber option to ComponentSortField

Is this needed? What is the added value of the detail part?

I am not sure we are not adding confusion. For instance we have:
Bug 30392 - Add deleteditems.deleted_on

Without the "Added" part, which could mean it hasn't been added(?)

Also:
Bug 28269 - Add new system preference SearchWithISSNVariations
vs
Bug 30250 - Add new system preference ApplyFrameworkDefaults
  Added new system preference 'ApplyFrameworkDefaults'

We are lacking consistency.

My suggestion would be to:
1. Don't add a detail when there is only 1 thing to tell and it has already
been said in the description
2. Don't add the past -ed, which is only useful when we are executing a script
and want to provide feedback (here we only want to tell what it done, use
infinitive everywhere then)
3. Use the detail page ($out) when there are several things. For instance:
Bug 42424: New awesome feature
  Add new DB column table.column
  Add new system preference SysPref
  etc.

Note that "Bug 32030 - Add an ERM module" could have a detail part.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:27:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:27:32 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-YJH4uDMVOJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143893&action=edit
update DB output 22.05.00 to 22.06.00.083

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:41:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:41:03 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-ZX2EDxTOEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Bug 31378 - Add identity_provider and identity_provider_domains configuration
tables
        manage_identity_providers permission added

=> This is not consistent either.

It could be 

Bug 31378 - OAuth2/OIDC client implementation
  Add new DB tables identity_provider and identity_provider_domains
  Add new permission manage_identity_providers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:48:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:48:30 +0000
Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic
 records with standard identifiers from authority data
In-Reply-To: <bug-22972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22972-70-RyFegT8oZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972

--- Comment #6 from bruno.forment at orpheusinstituut.be <bruno.forment at orpheusinstituut.be> ---
(In reply to Katrin Fischer from comment #5)
> For MARC21 I think identifiers for $0 are often found in 001/035:
> https://www.loc.gov/marc/authority/ad035.html

Those identifiers work only on the level of the complete record, not with
respect to the various authorities (personal, geographic, topical terms etc.).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:57:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:57:20 +0000
Subject: [Koha-bugs] [Bug 32187] (Bug 24161 follow-up) With
 IndependentBranches on a non superlibrarian librarian is not able to track
 late orders
In-Reply-To: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32187-70-slvdFaXyhC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |unspecified
         Depends on|                            |24161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Add ability to track the claim dates of later orders
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 09:57:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 08:57:20 +0000
Subject: [Koha-bugs] [Bug 24161] Add ability to track the claim dates of
 later orders
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-dSKXeM9WO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32187


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187
[Bug 32187] (Bug 24161 follow-up) With IndependentBranches on a non
superlibrarian librarian is not able to track late orders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 10:10:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 09:10:14 +0000
Subject: [Koha-bugs] [Bug 32187] (Bug 24161 follow-up) With
 IndependentBranches on a non superlibrarian librarian is not able to track
 late orders
In-Reply-To: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32187-70-eIUIYDztzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143894&action=edit
Bug 32187: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 10:10:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 09:10:19 +0000
Subject: [Koha-bugs] [Bug 32187] (Bug 24161 follow-up) With
 IndependentBranches on a non superlibrarian librarian is not able to track
 late orders
In-Reply-To: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32187-70-FmTlGQ3Wsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143895&action=edit
Bug 32187: Correct join on borrowers in Koha::Acq::Orders->filter_by_late

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 10:11:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 09:11:00 +0000
Subject: [Koha-bugs] [Bug 32187] (Bug 24161 follow-up) With
 IndependentBranches on a non superlibrarian librarian is not able to track
 late orders
In-Reply-To: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32187-70-fd8FypKOy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am not able to continue right now.

What's missing:
1. Unit tests
2. atomic update (that will need a bit of cleaning on aqbasket.authorisedby
before we create the FK)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 10:14:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 09:14:36 +0000
Subject: [Koha-bugs] [Bug 32206] New: How To Find Cash App Customer Service
 Hours Number Easily
Message-ID: <bug-32206-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32206

            Bug ID: 32206
           Summary: How To Find Cash App Customer Service Hours Number
                    Easily
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: adenjaxson9939 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

All the cash app problems can be resolved when you connect with Cash App
customer service but how to know Cash App customer service hours so that easily
connect with the team and get resolve their hurdle with ease. To make it easy,
we have provided the proper guidance on it that you can get by the following
link from this section.
https://www.primotechy.com/cash-app-customer-service-phone-number/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 10:17:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 09:17:32 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-KD0JwGO0EY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #124 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This does not work.

Because of bug 30718 you don't need the KohaDates filter on the flatpickr's
input.
The commit "Fix calendar widget" is actually messing with the date.

The bug I found appears when you edit an order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 10:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 09:19:45 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-Bprr0k1San@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

--- Comment #5 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Another side note, we are using bug 8367 so our problem with field "Holds
pickup period (day)" comes from there and has nothing to with this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 11:10:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 10:10:25 +0000
Subject: [Koha-bugs] [Bug 32206] SPAM
In-Reply-To: <bug-32206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32206-70-IfsI16Qr0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32206

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|How To Find Cash App        |SPAM
                   |Customer Service Hours      |
                   |Number Easily               |
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 11:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 10:13:14 +0000
Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting
 natively when using Zebra
In-Reply-To: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31756-70-MX8xY2Tohx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|Failed QA                   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 11:17:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 10:17:47 +0000
Subject: [Koha-bugs] [Bug 22972] Proposal for enriching the bibliographic
 records with standard identifiers from authority data
In-Reply-To: <bug-22972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22972-70-OufcUlEesi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22972

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to bruno.forment at orpheusinstituut.be from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > For MARC21 I think identifiers for $0 are often found in 001/035:
> > https://www.loc.gov/marc/authority/ad035.html
> 
> Those identifiers work only on the level of the complete record, not with
> respect to the various authorities (personal, geographic, topical terms
> etc.).

Hi Brono, I meant the 035 in authorities, not 035 in the bibliographic record.
In our case for example one of the 035 of the authority has the ID from the
national authority database for this person/subject/topical term.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 11:20:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 10:20:46 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-30fBPEqBlB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #125 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #124)
> This does not work.
> 
> Because of bug 30718 you don't need the KohaDates filter on the flatpickr's
> input.
> The commit "Fix calendar widget" is actually messing with the date.
> 
> The bug I found appears when you edit an order.

I think there was an overlap in development/time gap between this passing and
being pushed. 

Can you explain more what needs to be fixed/what is broken?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 11:23:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 10:23:22 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-VD8MiQqhv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #198 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Note that there is a bug here similar to bug 30694 but with
holds_pickup_period.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:37:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:37:19 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-POiRUy47La@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #126 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143896&action=edit
Bug 15348: (follow-up) Fix filters on input fields

With bug 30718 we on longer need the KohaDates TT filter
on the inputs. This patch removes them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:46:38 +0000
Subject: [Koha-bugs] [Bug 32207] New: Add page-section to some circulation
 pages
Message-ID: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

            Bug ID: 32207
           Summary: Add page-section to some circulation pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 30952
            Blocks: 31757

Several circulation-related pages need the page-section container:

- bookcount.tt
- branchoverdues.tt
- on-site_checkouts.tt
- overdue.tt
- transfers_to_send.tt
- transferstoreceive.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:46:38 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-0aZTMBmuTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207
[Bug 32207] Add page-section to some circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:46:38 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-YtzVoectAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207
[Bug 32207] Add page-section to some circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:51:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:51:10 +0000
Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via
 syspref and not just home library
In-Reply-To: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25426-70-XXU8fV3A6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a new
      release notes|                            |system preference,
                   |                            |CircControlReturnsBranch.
                   |                            |Previously circulation
                   |                            |rules for return policies
                   |                            |always used the item's home
                   |                            |library. This new
                   |                            |preference allows choosing
                   |                            |between the item's home
                   |                            |library, the item's holding
                   |                            |library, and the logged in
                   |                            |library when selecting the
                   |                            |return policy from the
                   |                            |circulation rules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:54:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:54:51 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-pLCdisjSZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Jonathan Druart from comment #4) 
> > You should:
> > 1. Build the patch on top of bug 32147 (that will certainly make the tests
> > fail)
> 
> Tomas, are you going to push it into 22.11?

Yes, was waiting for it to be PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:57:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:57:15 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-r0DwbIsD2W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:57:18 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-YL0HnyOGvt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143897&action=edit
Bug 32207: Add page-section to some circulation pages

This patch adds a .page-section div to various circ-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages in Circulation to
confirm that the primary page content is wrapped in a container with a
white background:

- Overdues
- Overdues with fines
- Transfers to receive: Your system should have items which have been
  transfered from at least two other libraries.
- Transfers to send: Your system must have one or more items in the
  branchtransfers table with the datesent value = null.
- On-site checkouts
- Catalog -> Bibliographic record -> Items -> View item's checkout
  history

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:58:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:58:32 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-jJA7J6BKgC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 12:58:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 11:58:36 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-iB5niDRvGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143898&action=edit
Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:20:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:20:10 +0000
Subject: [Koha-bugs] [Bug 31812] Add yellow button to stage imports page
In-Reply-To: <bug-31812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31812-70-2CkxkZlsBd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Martin Renvoize from comment #9)
> (In reply to Katrin Fischer from comment #7)
> > I feel like the upload file button should be yellow too, as we only see this
> > one at first, what do you think?

Fixed by Bug 32096: Consistent classes for primary buttons: Tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:25:52 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-qOJ4gEX6Xp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #127 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143900&action=edit
Bug 15348: Store estimated delivery date when adding an order

When the estimated delivery date was entered on adding or modifying
and order, it was not saved to the database.

To test:
* Add new order, fill in estimated delivery date
* Save
* Verify the estimated delivery date is empty
* Modify order line, date will also not be saved
* Apply patch
* The date should now save and update correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:26:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:26:13 +0000
Subject: [Koha-bugs] [Bug 29480] Add email address as a method for
 generating the userid when self registering in OPAC
In-Reply-To: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29480-70-78A088bFdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #14)
> (In reply to Marcel de Rooy from comment #13)
> > Functional question about:
> > 
> > +If PatronSelfRegistrationUseridGenerationMethod is set to 'email', the email
> > +address will be used as the userid. If the patron being created has no
> > email,
> > +or the patron has an email address that is already in use by another patron,
> > +the default way of creating the userid ($firstname.$surname) will be used.
> > 
> > Is that really what you want? If my email address is already in the
> > database, I probably dont want another account.
> > One of the issues we face is actually that impatient people register 2 or 3
> > accounts.
> 
> We see this for families where the email address of the parents is used in
> the children's accounts as well. Also sometimes for internal accounts where
> a library address might be used several times. Some academic libraries also
> do separate accounts for 'permanent loans'.
> 
> Maybe display a warning or so instead of not allowing it?

Maybe a lax or strict mode or so? Obviously you dont need to use email as
userid, but if you do, it might be nice to choose between fallback to name
based userid or not allowing it..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:33:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:33:17 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-sJDyl0Iqfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #128 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe the first fix is what Joubu asked for and the second is something I
found while testing.

I have a remaining issue: when clicking on 'edit' from basket, the date in the
modal is no longer pre-set with the stored date. This might also appear in
other spots where the modal is used (late orders).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:50:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:50:46 +0000
Subject: [Koha-bugs] [Bug 23017] Allow limiting Z39.50 searches on material
 type
In-Reply-To: <bug-23017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23017-70-xItPf4le8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23017

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31726

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:50:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:50:46 +0000
Subject: [Koha-bugs] [Bug 31726] Show record type in z39.50 search results
In-Reply-To: <bug-31726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31726-70-OsUXKmP1Hf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31726

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23017

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:58:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:58:35 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-p61now2jVa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 13:58:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 12:58:39 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-XyekzHGV4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143707|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143901&action=edit
Bug 32171: Store after populating order

This updates the call to store after populating the order

I put this on it's own bug just for sake of dependency, in case it is needed
seperate from 32166 for backports

To test:
1 - Apply and test with bug 32166

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:22:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:22:55 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-1ltgV0mdnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #66 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Thank you Martin and Andrew for looking into this. I'll try to work on this
again tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:35:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:35:36 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-lkOO7d61zB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:35:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:35:40 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-o6p9MM9PCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143892|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143902&action=edit
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:36:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:36:22 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-PMJGK8qzqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #129 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143903&action=edit
Bug 15348: (follow-up) Fix modals to pre-set input with stored date

Makes sure that when an estimated delivery day is edited using
the modals on the basket summary or late order pages, the
date input is pre-set to the stored estimated delivery date.

To test:
* Create some order lines with and without estimated delivery date set
* Make sure that on the basket summary the edit link comes up with an
  empty modal
* Close the basket
* Check that on late orders the dates are pre-filled incorrectly as well
* Apply patch
* Refresh basket summary and late order pages
* All edit links now should bring up the modal with the correct date filled in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:37:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:37:15 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-pj320E5y9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #130 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks Owen for the hints and explanations!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:39:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:39:28 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-yHNwYiPadM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 14:54:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 13:54:34 +0000
Subject: [Koha-bugs] [Bug 32208] New: Adjustable title
Message-ID: <bug-32208-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32208

            Bug ID: 32208
           Summary: Adjustable title
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

More info follows

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:01:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:01:10 +0000
Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by
 OpacHiddenItems turn up in facet results
In-Reply-To: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14007-70-3BTBz0PNA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

Andreas Jonsson <andreas.jonsson at kreablo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.jonsson at kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:04:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:04:17 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-JZHyUBQ61c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143903|0                           |1
        is obsolete|                            |

--- Comment #131 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143904&action=edit
Bug 15348: (follow-up) Fix modals to pre-set input with stored date

Makes sure that when an estimated delivery day is edited using
the modals on the basket summary or late order pages, the
date input is pre-set to the stored estimated delivery date.

To test:
* Create some order lines with and without estimated delivery date set
* Make sure that on the basket summary the edit link comes up with an
  empty modal
* Close the basket
* Check that on late orders the dates are pre-filled incorrectly as well
* Apply patch
* Refresh basket summary and late order pages
* All edit links now should bring up the modal with the correct date filled in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:19:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:19:08 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order mulitple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-6JIo2L17tC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:19:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:19:11 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order mulitple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-4LjxDYkSNE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143905&action=edit
Bug 32045: Use bootstrap tabs to select item tab

When the form to add orders from a staged file is validated, we use
toptabs functionality to switch to the item tab if there are missing fields.

The display now uses bootstrap tabs, so the JS is throwing an error:
Uncaught Error: cannot call methods on tabs prior to initialization; attempted
to call method 'option'

This patch simply switches the call to switch tabs

To test:
1 - Stage a file for import
2 - Either use Marc(Item)FieldsToOrder to populate the orders
    or select a budget on the third tab
3 - View the second tab, items info, confirm itemtype is required, but don't
populate it
4 - Attempt to save order, nothing happens
5 - Check the JS console (F12)
6 - Note the error:
    Uncaught Error: cannot call methods on tabs prior to initialization;
attempted to call method 'option'
7 - Apply patch
8 - Cancel and add from staged file again
9 - Select a budget and save
10 - You now get an error popup: Some required item subfields are not set
11 - Confirm after the error you are shown the items tab
12 - Select itemtype
13 - Save
14 - Confirm orders added successfully

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:21:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:21:45 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-tA7zJwFxD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:21:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:21:49 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-SylQSBPBZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143897|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143906&action=edit
Bug 32207: Add page-section to some circulation pages

This patch adds a .page-section div to various circ-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages in Circulation to
confirm that the primary page content is wrapped in a container with a
white background:

- Overdues
- Overdues with fines
- Transfers to receive: Your system should have items which have been
  transfered from at least two other libraries.
- Transfers to send: Your system must have one or more items in the
  branchtransfers table with the datesent value = null.
- On-site checkouts
- Catalog -> Bibliographic record -> Items -> View item's checkout
  history

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:22:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:22:08 +0000
Subject: [Koha-bugs] [Bug 32209] New: Item subfields required even when
 supplied for each order
Message-ID: <bug-32209-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32209

            Bug ID: 32209
           Summary: Item subfields required even when supplied for each
                    order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When using MarcItemFieldsToOrder to populate order information while staging
records you can set things up to supply an itemtype, however, if the itemtype
field is required, you still must select one on the items tab

To recreate:
See bug 32166 - use file and settings to add to basket form a staged file
Note you must still populate the itemtype on the second tab

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:36:36 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-TzWrpAcaR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:36:41 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-XF6MPJRcau@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143902|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143907&action=edit
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:38:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:38:05 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-kTo9nMt1l0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:45:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:45:23 +0000
Subject: [Koha-bugs] [Bug 32210] New: When checking out with a date in the
 past, the due date input is too wide
Message-ID: <bug-32210-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32210

            Bug ID: 32210
           Summary: When checking out with a date in the past, the due
                    date input is too wide
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952

When you check out an item with a specified due date in the past, the date in
the confirmation message is too wide.

You can see something similar for the date modals for the estimated delivery
date in acq.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:45:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:45:23 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ULHKDXFw7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32210


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32210
[Bug 32210] When checking out with a date in the past, the due date input is
too wide
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:48:40 +0000
Subject: [Koha-bugs] [Bug 23541] Duplicate Hold Notifications
In-Reply-To: <bug-23541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23541-70-wVBt3HnRHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:48:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:48:47 +0000
Subject: [Koha-bugs] [Bug 32195] Changing a patron category to disallow
 guarantors should remove existing guarantors
In-Reply-To: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32195-70-nJ6RAl5S52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32195

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:48:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:48:58 +0000
Subject: [Koha-bugs] [Bug 32196] One should be able to remove a borrower
 relationship whenever one exists
In-Reply-To: <bug-32196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32196-70-8s2pOEbwpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32196

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:52:57 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-aD9O4Tm9cq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cannot order mulitple from  |Cannot order multiple from
                   |staged file                 |staged file

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:53:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:53:03 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-39rRrfcWGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:54:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:54:28 +0000
Subject: [Koha-bugs] [Bug 14007] Item types for items hidden by
 OpacHiddenItems turn up in facet results
In-Reply-To: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14007-70-octRL2InBd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Item Types for items hidden |Item types for items hidden
                   |by OpacHiddenItems turn up  |by OpacHiddenItems turn up
                   |in facet results            |in facet results

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:57:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:57:43 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-kiLszbnmkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:57:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:57:47 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-Jn3rioK461@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143906|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143908&action=edit
Bug 32207: Add page-section to some circulation pages

This patch adds a .page-section div to various circ-related pages in
order to provide a consistent page structure.

To test, apply the patch and view the following pages in Circulation to
confirm that the primary page content is wrapped in a container with a
white background:

- Overdues
- Overdues with fines
- Transfers to receive: Your system should have items which have been
  transfered from at least two other libraries.
- Transfers to send: Your system must have one or more items in the
  branchtransfers table with the datesent value = null.
- On-site checkouts
- Catalog -> Bibliographic record -> Items -> View item's checkout
  history

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 15:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 14:59:38 +0000
Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via
 syspref and not just home library
In-Reply-To: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25426-70-t5IUNK1qEe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:16:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:16:14 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-kKLb9rU2SQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:16:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:16:19 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-ZUKRSNKmOh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143905|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143909&action=edit
Bug 32045: Use bootstrap tabs to select item tab

When the form to add orders from a staged file is validated, we use
toptabs functionality to switch to the item tab if there are missing fields.

The display now uses bootstrap tabs, so the JS is throwing an error:
Uncaught Error: cannot call methods on tabs prior to initialization; attempted
to call method 'option'

This patch simply switches the call to switch tabs

To test:
1 - Stage a file for import
2 - Either use Marc(Item)FieldsToOrder to populate the orders
    or select a budget on the third tab
3 - View the second tab, items info, confirm itemtype is required, but don't
populate it
4 - Attempt to save order, nothing happens
5 - Check the JS console (F12)
6 - Note the error:
    Uncaught Error: cannot call methods on tabs prior to initialization;
attempted to call method 'option'
7 - Apply patch
8 - Cancel and add from staged file again
9 - Select a budget and save
10 - You now get an error popup: Some required item subfields are not set
11 - Confirm after the error you are shown the items tab
12 - Select itemtype
13 - Save
14 - Confirm orders added successfully

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:16:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:16:46 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-iVRje8ZOQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for investigating!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:18:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:18:10 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-yGnAxm128v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #3)
> I got an error in testing this and bug 32171 together. The error is due to a
> typo in 32171.

Nick, can you please check and explain a bit more about 32171?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:28:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:28:44 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-QRzHCDkPcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #4)
> (In reply to Andrew Fuerste-Henry from comment #3)
> > I got an error in testing this and bug 32171 together. The error is due to a
> > typo in 32171.
> 
> Nick, can you please check and explain a bit more about 32171?

32171 is updated - it is a separate issue, but hard to fix one without the
other  as you won't see the prices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:32:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:32:28 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-lmDM0hvVfw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:32:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:32:33 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-VgAbpmDl5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134926|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143910&action=edit
Bug 29100: Add checkouts data loop to predue notices script (
advance_notices.pl )

Predue / due notices are limited to using itemscontent to display checkouts
data. It would be nice to make all the checkouts data available for those
notices so that libraries could format that data more nicely if they wish.

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
Title: [% issue.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
Titles:
[% FOREACH i IN issues %]
* [% i.title %]
[% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles

Signed-off-by: Felicity Brown <Felicity.Brown at montgomerycountymd.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:32:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:32:37 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-PB6hviZ6xr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137996|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143911&action=edit
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

Signed-off-by: Felicity Brown <Felicity.Brown at montgomerycountymd.gov>
Signed-off-by: George Veranis <gveranis at dataly.gr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:32:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:32:43 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-xCCWtJH1gU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143898|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143912&action=edit
Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s)

Adapted test plan:

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
   Title: [% checkout.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
   Titles:
   [% FOREACH c IN checkouts %]
    * [% c.title %][% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:34:35 +0000
Subject: [Koha-bugs] [Bug 32211] New: Update sample (pre) due notices to use
 TT syntax
Message-ID: <bug-32211-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211

            Bug ID: 32211
           Summary: Update sample (pre) due notices to use TT syntax
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 29100

With 29100 we can improve the notices to show how TT can be used to get all the
information we need here and have nice formatting (replacing items.content
especially).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100
[Bug 29100] Add checkouts data loop to predue/due notices script
(advance_notices.pl)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:34:35 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due
 notices script (advance_notices.pl)
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-XszMSwyUqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32211


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211
[Bug 32211] Update sample (pre) due notices to use TT syntax
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:37:10 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-QuP7wJWeXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:37:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:37:15 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-3Lt3xPjHiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143879|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143913&action=edit
Bug 32155: Fix alignment of course details page

This patch eliminates some unnessesary CSS and converts the course details div
into a fieldset.

To test:
1. Create or edit an existing course.
2. Search and add an instructor.
3. Note that the columns are misaligned: the name of the course instructor is
shown first, then the label "Instructors" is shown next.
4. Add another three instructors.
5. Note that this pushes the labels for the next few fields to the right.
6. Apply patch
7. Try steps 1-4 again and confirm everthing looks and works correctly.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:37:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:37:31 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-FPGiPWSYuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:37:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:37:43 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-EZUFPyXhcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:40:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:40:35 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-jK5Yik2Yau@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
(In reply to Katrin Fischer from comment #5)
> Thx for investigating!

Thank you for filing a bug that helped explain why the test plan for something
else was giving me trouble :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:42:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:42:02 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-dwabGRDrhU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:45:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:45:29 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-3Od3cPMuPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to David Nind from comment #15)
> Error: File to import not found or unreadable:
> ../../../../../node_modules/bootstrap/scss/custom-forms.

Bug 32030 - ERM - upgraded the Bootstrap Node module to 5.2, but the OPAC still
expects 4.5.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:55:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:55:21 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-29SgAjPJfu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
           Keywords|                            |rel_22_11_candidate

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is related to our changes on the page, but I haven't quite figured out yet
what's going on.

The visibility of the form on the page is managed with Javascript:

$(document).ready(function(){
    $("#add_field_form").hide();
    $("#new_search_field").on("click",function(e){
        e.preventDefault();
        $("#add_field_form").show();
        $(".dialog").hide();
        $("#search_fields_list").hide();
    });
    $(".hide_form").on("click",function(e){
        e.preventDefault();
        $("#add_field_form").hide();
        $(".dialog").show();
        $("#search_fields_list,#toolbar").show();
    });

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:57:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:57:37 +0000
Subject: [Koha-bugs] [Bug 32212] New: Add separate Bootstrap 4 node module
 for the OPAC
Message-ID: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

            Bug ID: 32212
           Summary: Add separate Bootstrap 4 node module for the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030
            Blocks: 25267

Bug 32030 - Electronic resource management - updated the Bootstrap node module
to 5.2.x, but the OPAC still needs a copy of Bootstrap 4.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267
[Bug 25267] OPAC browse shelf feature is not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:57:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:57:37 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-pwKcoopBDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212
[Bug 32212] Add separate Bootstrap 4 node module for the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:57:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:57:37 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-XEzAqqn4OX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212
[Bug 32212] Add separate Bootstrap 4 node module for the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:59:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:59:18 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-kEmiGJpEVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143705|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143916&action=edit
Bug 32166: Use import record id for retrieving correct inputs

When importing from a staged file we retrieve the records form the DB, skip any
that are not selected,
and process the rest.

When we skip some, we still raise our record count, and use this to retrieve
the inputs.

When building the page, we don't increment for skipped reocrds, so there can be
a mismatch, i.e.
Record #1 on the page to add records may be the 3rd record in the import file

Rather than using a counting system, let us use the import record id directly

To test:
 0 - Set system preferences:

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

 1 - Stage attached sample file, Format:MARCXML, Record matching:Koha biblio
999$c
 2 - Add to a basket from the staged file
 3 - Select 1st record to basket and save
 4 - Record is added with the fields above as expected
 5 - Add to basket again, select 2nd record
 6 - Record is added with price from 020a, ignoring incoming fields
 7 - Repeat with 3rd, same problem
 8 - Apply patch
 9 - Stage file and repeat step 3
10 - Confirm added with correct values
11 - Add 2nd record and save, values correct
12 - Add 3rd record, values correct

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:59:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:59:20 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-OdbqbWMEiv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 16:59:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 15:59:47 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-nez5aeyRo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:03:24 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-0mOotQ1hlw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:03:44 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-PXrABcJVIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886
[Bug 31886] No side menu when searching for syspref
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:03:44 +0000
Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref
In-Reply-To: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31886-70-Kud8AyuU4j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126
[Bug 32126] Adding item search fields is broken - can't add more than one field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:03:53 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-iLMwYTnCXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|31886                       |31986


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886
[Bug 31886] No side menu when searching for syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986
[Bug 31986] Add page-section to various administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:03:53 +0000
Subject: [Koha-bugs] [Bug 31886] No side menu when searching for syspref
In-Reply-To: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31886-70-FtVgeb7m5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32126                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126
[Bug 32126] Adding item search fields is broken - can't add more than one field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:03:53 +0000
Subject: [Koha-bugs] [Bug 31986] Add page-section to various administration
 pages
In-Reply-To: <bug-31986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31986-70-JXiq1vb8IG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126
[Bug 32126] Adding item search fields is broken - can't add more than one field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:08:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:08:51 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-IoSCpAdATO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:08:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:08:55 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-YEROYu7o1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143917&action=edit
Bug 32126: Fix missing div breaking the form for adding more search fields

The missing div caused a problem with the JS that controls
visibility of the list of search fields, the form and the toolbar.
With the div added, everything should now work as expected.

To test:
* Add a item search field, everything should work.
* Add a second item search field - intead of the form, you'll see an empty
page.
* Apply patch.
* Add second and more search fields, all should work.
* Edit search fields.
* Delete search fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:11:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:11:37 +0000
Subject: [Koha-bugs] [Bug 32213] New: Reindent item search fields template
Message-ID: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

            Bug ID: 32213
           Summary: Reindent item search fields template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32126

The template file items_search_fields.tt is hard to read and is not indented
correctly. It would be nice to fix this in order to make the template easier to
read and avoid errors in the future (see bug 32126)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126
[Bug 32126] Adding item search fields is broken - can't add more than one field
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:11:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:11:37 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-CbNbTgIaGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32213


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213
[Bug 32213] Reindent item search fields template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:14:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:14:02 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-Id3AASOOHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Klas Blomberg from comment #0)
> If you have entered a value in the column "Decreased loan period for high
> holds" for a circulation rule - you can't delete that line.
> 
> The only thing that will happend is that all numerical values are wiped out
> - giving today as duedate

Confirmed on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:29:45 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-UPpq68aHVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:29:50 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-IZKeRAhg8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143891|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143918&action=edit
Bug 30694: Set decreaseloanholds undef when deleting circulation rule

When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds"
filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:30:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:30:08 +0000
Subject: [Koha-bugs] [Bug 30694] Impossible to delete line in circulation
 and fine rules
In-Reply-To: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30694-70-Cb7DxILCWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:32:35 +0000
Subject: [Koha-bugs] [Bug 31944] Toolbar is not correctly aligned
In-Reply-To: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31944-70-lrT7sSAE5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Checked this on current master and button and page-section now align perfectly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:35:24 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-aPH8HCN4vb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Misaligned checkbox and     |Move "Delete selected
                   |text in batchmod.pl         |items" button to new line
         Depends on|                            |30952

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The checkbox and the label now align correctly on maser - I believe this to be
a positive side-effect from some other fixes.

We the Save button is still on the same line as the checkbox, that might be
something to still look into here. Adjusting bug description.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:35:24 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-HiHo5M6EF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32112


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112
[Bug 32112] Move "Delete selected items" button to new line
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:36:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:36:45 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-O3sBxZxvV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143901|0                           |1
        is obsolete|                            |

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143919&action=edit
Bug 32171: Store after populating order

This updates the call to store after populating the order

I put this on it's own bug just for sake of dependency, in case it is needed
seperate from 32166 for backports

To test:
1 - Apply and test with bug 32166

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:38:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:38:48 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-RFrbR6biou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:40:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:40:47 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-RhLUJhm0Fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
coopted the test plan from 32166:
To test:
 -1: apply patch
 0 - Set system preferences:

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

 1 - Stage attached sample file, Format:MARCXML, Record matching:Koha biblio
999$c
 2 - Add to a basket from the staged file
 3 - Select 1st record to basket and save
 4 - Record is added with the fields above as expected AND THE PRICE FIELDS ARE
POPULATED
 5- repeat with the other records if you feel like it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:41:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:41:23 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-eoYMKzcEWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:41:27 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-sVbZU53gYv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143920&action=edit
Bug 32112: Move 'Delete selected items' to its own line

This moves the checkbox and its label out of the action field set
which makes it appear above the bottons instead of in front of it.

To test:
* Go to any record
* Select items and send to item batch delete
* Verify checkbox appears in front of button
* Apply patch
* Verify the checkbox and the yellow 'delete selected items' button
  are now on separate lines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:43:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:43:53 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-oX7qNdRnBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Owen, will you have time for this one? I could try to have a go at the
misaligned statistics and the item form (looking at the other places we fixed
them)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:44:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:44:17 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
 tool
In-Reply-To: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32095-70-gQJNrrByyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:44:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:44:17 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-uRa1Z9MyGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32095


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095
[Bug 32095] Remove bullets from statuses in inventory tool
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:47:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:47:41 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-DZTIOFgN4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:57:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:57:15 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-elz1TSfJkq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:57:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:57:19 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-ciFJ1HBFPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143921&action=edit
Bug 32093: Make help and code match for bg-days in cleanup_database.pl

There as a mismatch between the parameter name in documentation (bg-days)
and what was checked in the code (bg-jobs). This makes both match.

To test:
* Apply patch
* Make sure you have some background_jobs older than one day
* Verify the help of the script documents the parameter bg-days
* Run the cleanup_database.pl job
  Example:  ./misc/cronjobs/cleanup_database.pl --bg-days  --confirm -v
* Verify there are no errors and the lines have been deleted as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:58:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:58:32 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-tqq00FZU6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:59:29 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-eI3EnT73IG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32093


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093
[Bug 32093] cleanup_database.pl bg-jobs parameter should be bg-days
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 17:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 16:59:29 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-XYAtnAeVt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |rel_22_11_candidate
         Depends on|                            |31969

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As this new option has not been released yet, we should push this before
release so people can have it right from the beginning.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969
[Bug 31969] Options for cleanup_database.pl to remove finished jobs from the
background job queue
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:00:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:00:22 +0000
Subject: [Koha-bugs] [Bug 31518] Hidden items count not displayed on hold
 request page
In-Reply-To: <bug-31518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31518-70-IIX5O4pOO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:01:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:01:37 +0000
Subject: [Koha-bugs] [Bug 31525] Street number not being accessed correctly
 on patron search results page
In-Reply-To: <bug-31525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31525-70-LdxwWUYSzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31525

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
file koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format-address.inc
missing in 21.11. can't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:04:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:04:28 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-ApdfUBJt3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #29 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:05:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:05:16 +0000
Subject: [Koha-bugs] [Bug 31527] Breadcrumbs for anonymous suggestions are
 not correct
In-Reply-To: <bug-31527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31527-70-kFguEZtimb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31527

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:06:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:06:26 +0000
Subject: [Koha-bugs] [Bug 31605] Improve style of OPAC suggestions search
 form
In-Reply-To: <bug-31605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31605-70-JP6adwXR14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31605

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:07:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:07:29 +0000
Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a
 dropdown field in the cataloguing editor
In-Reply-To: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31646-70-Ek4UO2kgu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:08:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:08:34 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-WXnEVtpFZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #12 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:09:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:09:24 +0000
Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct
 manual pages
In-Reply-To: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31465-70-Qm9itw3JYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #18 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:10:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:10:51 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-RQCv2tDpkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:12:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:12:03 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-gkeFqNyYsc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:13:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:13:06 +0000
Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode
In-Reply-To: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31482-70-IV4UpjEmYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.07          |22.11.00, 22.05.07,
        released in|                            |21.11.14
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:17:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:17:20 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-Qdfvu4hM9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
         Version(s)|22.11.00                    |22.11.00, 22.05.06
        released in|                            |

--- Comment #13 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14 (backported from 22.05, lucas probably just
forgot to update the bz)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:17:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:17:21 +0000
Subject: [Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha
 namespace [OMNIBUS]
In-Reply-To: <bug-21204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21204-70-5iRB69GU3R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204
Bug 21204 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:17:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:17:21 +0000
Subject: [Koha-bugs] [Bug 29959] Populate prices when creating an order with
 the API
In-Reply-To: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29959-70-nTODqo6NnN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29959
Bug 29959 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:17:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:17:21 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-A9hIvfsj7L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171
Bug 32171 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:17:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:17:22 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-5m53dALlHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348
Bug 15348 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:18:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:18:11 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-LLBBttZXQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.06          |22.11.00, 22.05.06,
        released in|                            |21.11.14

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
applied to 21.11 for 21.11.14 (backported from 22.05, lucas probably just
forgot to update the bz)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:18:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:18:27 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-YoyZCF6Pvz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:18:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:18:41 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-hE4ksQJXVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:19:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:19:04 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-L0PkO7q1wi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:19:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:19:18 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-3N7YdBLRs4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 18:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 17:20:15 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-ooxudtUx3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Any news?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:43:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:43:57 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-VlttuFcoVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:45:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:45:39 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-Zy4iiuYgz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:48:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:48:04 +0000
Subject: [Koha-bugs] [Bug 32204] in-page anchor to edititem on additem.pl
 not working
In-Reply-To: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32204-70-969pZNDyuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:50:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:50:53 +0000
Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the
 same item, from different fund classes
In-Reply-To: <bug-10209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10209-70-gurXcWFRiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:51:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:51:16 +0000
Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the
 same item, from different fund classes
In-Reply-To: <bug-10209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10209-70-XFf2oJHkH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:57:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:57:35 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-QPtxHzFYIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #9)
> Created attachment 143893 [details]
> update DB output 22.05.00 to 22.06.00.083

I think that's before I pushed my patch, please try again or check the new
attachment. It is pretty consistent to me right now. There might be style
opinions, though. I basically renamed the descriptions for the bug descriptions
and then put the 'actions' that took place, so the identity providers one
really reads:

Upgrade to 22.06.00.081  [18:54:12]: Bug 31378 - Add identity_provider and
identity_provider_domains configuration tables
        Added new permission 'manage_identity_providers'
        Added new table 'identity_providers'
        Added new table 'identity_provider_domains'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 19:59:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 18:59:52 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-L3jsIPt3rY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143922&action=edit
22.05.00 => 22.06.83 upgrade

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:03:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:03:40 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-AKOFVkOuR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:03:44 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-XKevZNwbaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143917|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 143923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143923&action=edit
Bug 32126: Fix missing div breaking the form for adding more search fields

The missing div caused a problem with the JS that controls
visibility of the list of search fields, the form and the toolbar.
With the div added, everything should now work as expected.

To test:
* Add a item search field, everything should work.
* Add a second item search field - intead of the form, you'll see an empty
page.
* Apply patch.
* Add second and more search fields, all should work.
* Edit search fields.
* Delete search fields.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:04:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:04:41 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-9XSWTZZQvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:04:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:04:44 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-9Nlr54sFGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143924&action=edit
Bug 32212: Add separate Bootstrap 4 node module for the OPAC

This patch updates package.json so that Bootstrap 4 will be installed
alongside Bootstrap 5. The addition of ERM changed the installed version
of Bootstrap to 5.2.x but the OPAC still requires 4.x.

To test, apply the patch and run 'yarn install.'

After packages install, run 'yarn build --view opac'

The build process should complete correctly and the OPAC should look the
same as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:11:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:11:34 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-0N66LhNIGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

--- Comment #5 from David Nind <david at davidnind.com> ---
Thanks Katrin for fixing!

I did note (and it was doing it before this patch) that the form very briefly
appears then disappears when there are no item search fields, or when going to
Administration > Item search fields.

Another bug, or just the way this one works?

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:20:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:20:54 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-NozYBAQnCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:20:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:20:57 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-8kW7K8wkSY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143924|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143925&action=edit
Bug 32212: Add separate Bootstrap 4 node module for the OPAC

This patch updates package.json so that Bootstrap 4 will be installed
alongside Bootstrap 5. The addition of ERM changed the installed version
of Bootstrap to 5.2.x but the OPAC still requires 4.x.

To test, apply the patch and run 'yarn install.'

After packages install, run 'yarn build --view opac'

The build process should complete correctly and the OPAC should look the
same as before.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:22:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:22:53 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-jsmOoUPbBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just the way this works - elements get hidden/unhidden with Javascript, that's
the flickering you see.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:23:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:23:34 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-UMzSJIRagh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes:

- I had a brief roam around the OPAC, everything looked OK and I didn't notice
anything that was different.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:24:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:24:42 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-GCNoolyI20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:24:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:24:46 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-F3u9QyziOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143926&action=edit
Bug 31751: Breadcrumb style

This patch updates the breadcrumb style to use the old caret icon
instead of a slash.

I've left the italic because I think it works well to set the text off
from the normal text above, in the search bar, and below in the main
body of the page.

To test, apply the patch and rebuild the staff interface CSS. Look at
various pages in the staff interface and check the style of the
breadcrumbs menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:30:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:30:45 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-yjQl8eJFfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
ah! I have certainly checked out master before the updatedatabase instead of
the branch with this patch. That is way better now, thanks! Sorry for the
confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:36:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:36:07 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-OxFjy5999N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #17 from David Nind <david at davidnind.com> ---
Created attachment 143927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143927&action=edit
Screenshot - shef browser is now vertical (after patch is applied)

The shelf browser is now vertical at any browser width - see the screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:36:41 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-JK6qKHeB9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143927|Screenshot - shef browser   |Screenshot - shelf browser
        description|is now vertical (after      |is now vertical (after
                   |patch is applied)           |patch is applied)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:38:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:38:21 +0000
Subject: [Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive
In-Reply-To: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25267-70-TPxNQBlMJE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #18 from David Nind <david at davidnind.com> ---
Testing notes (using KTD):

1. As this patch now depends on bug 32212, need to yarn install then yarn build
--view opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:42:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:42:14 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-oa83QPjKun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

--- Comment #7 from David Nind <david at davidnind.com> ---
(In reply to Katrin Fischer from comment #6)
> Just the way this works - elements get hidden/unhidden with Javascript,
> that's the flickering you see.

Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:58:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:58:02 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-7q0aQ4g41g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:58:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:58:07 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-a3aysnZdBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143926|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 143928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143928&action=edit
Bug 31751: Breadcrumb style

This patch updates the breadcrumb style to use the old caret icon
instead of a slash.

I've left the italic because I think it works well to set the text off
from the normal text above, in the search bar, and below in the main
body of the page.

To test, apply the patch and rebuild the staff interface CSS. Look at
various pages in the staff interface and check the style of the
breadcrumbs menu.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:59:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:59:01 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-fPw78ZEXgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #457 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Cook from comment #456)
> Aleisha, do you have clients using this functionality?

Catalyst had received sponsorship to work on this for a library years ago, they
may still be using a version of this in production but I'm not sure as we don't
work with that library anymore and sponsorship has run out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 20:59:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 19:59:17 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for
 the same record
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-Euo7MyVsME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #278 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Cook from comment #277)
> Aleisha, do you have clients using this functionality?

Catalyst had received sponsorship to work on this for a library years ago, they
may still be using a version of this in production but I'm not sure as we don't
work with that library anymore and sponsorship has run out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:11:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:11:13 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-PjXmhPbF3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31891
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:11:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:11:13 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-yiQaZ7LNzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31711

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:11:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:11:20 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-dCOJUXUewB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:11:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:11:20 +0000
Subject: [Koha-bugs] [Bug 31892] Regression: return to
 /manage-marc-import.pl after importing batch
In-Reply-To: <bug-31892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31892-70-wizEqKE0mn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31892

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31711

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:12:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:12:01 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-qQSaTvyHt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Thanks for filing and patching this! I've added See Alsos to a couple of
related bugs that I'm hoping this might fix incidentally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:16:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:16:25 +0000
Subject: [Koha-bugs] [Bug 32209] Item subfields required even when supplied
 for each order
In-Reply-To: <bug-32209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32209-70-YWZj0kABMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32209

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Adding a bit more detail and a file to use.
To recreate:
1: put the following into the MARCItemFieldsToOrder syspref:

homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

2: stage the attached marc record for import, selecting MARC format. It doesn't
matter if you check for duplicates or not.
3: go to acquisitions, find or create a basket with items created on ordering
4: add to your basket from your staged file
5: on the Add Orders page, select the title and confirm that the item record
details on the "Select to import" tab include an itype selection
6: click to the "Item information" tab and confirm that here the itype is
blank. Don't select anything here yet.
7: Click Save. Nothing happens. If you inspect the element and look in the
console, you'll see some an error "Uncaught Error: cannot call methods on tabs
prior to initialization; attempted to call method 'option'"
8: Select an itype in the "Item information" tab
9: Click Save again. It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:16:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:16:50 +0000
Subject: [Koha-bugs] [Bug 32209] Item subfields required even when supplied
 for each order
In-Reply-To: <bug-32209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32209-70-D3a9mYftET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32209

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 143929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143929&action=edit
A sample marc file

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:17:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:17:38 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-VCamqzmZiZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:17:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:17:43 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-duHF3wxpXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143921|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 143930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143930&action=edit
Bug 32093: Make help and code match for bg-days in cleanup_database.pl

There as a mismatch between the parameter name in documentation (bg-days)
and what was checked in the code (bg-jobs). This makes both match.

To test:
* Apply patch
* Make sure you have some background_jobs older than one day
* Verify the help of the script documents the parameter bg-days
* Run the cleanup_database.pl job
  Example:  ./misc/cronjobs/cleanup_database.pl --bg-days  --confirm -v
* Verify there are no errors and the lines have been deleted as expected

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:24:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:24:44 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-kgpWYzfI1D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Testing notes (using KTD):

1. To create some background jobs that could be purged (I'm sure there are
quicker ways), I:
   - Enabled Elasticsearch (SearchEngine)
   - Reindexed (koha-elasticsearch --rebuild -d -b -a kohadev)
   - Edited some records (changed titles)
   - Updated the dates in the database for background jobs so that they are
more than 1 day old (wasn't sure what date is used to trigger pruging):
     . select * from background_jobs;
     . update background_jobs set enqueued_on = "2022-11-13 20:09:00";
     . update background_jobs set started_on = "2022-11-13 20:09:00";
     . update background_jobs set ended_on = "2022-11-13 20:10:00";
   - Edited a few more records (changed title)

2. Ran the cleanup_database.pl job.

3. Checked that the older background jobs were deleted in the database and UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:34:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:34:41 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-PYoZjNoMru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:34:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:34:46 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-OeHVg9qPf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143920|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143931&action=edit
Bug 32112: Move 'Delete selected items' to its own line

This moves the checkbox and its label out of the action field set
which makes it appear above the bottons instead of in front of it.

To test:
* Go to any record
* Select items and send to item batch delete
* Verify checkbox appears in front of button
* Apply patch
* Verify the checkbox and the yellow 'delete selected items' button
  are now on separate lines

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:56:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:56:39 +0000
Subject: [Koha-bugs] [Bug 32214] New: Staff interface toolbar - no options
 when search catalog selected
Message-ID: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

            Bug ID: 32214
           Summary: Staff interface toolbar - no options when search
                    catalog selected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 143932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143932&action=edit
Screenshot - options empty for search catalog in toolbar

There are no options if you select the options/settings icon before the
search/arrow button when 'Search catalog' is selected - see the screenshot
attached.

Compare this with the patrons area, where there are several options to help you
refine your search.

To replicate:
1. In the staff interface toolbar select 'Search catalog'.
2. Click on the options/setting icon before the search arrow.
3. Note that there are no options to select from

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:57:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:57:21 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-19Rh0Khevd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 21:57:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 20:57:21 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ovMYxYTeWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32214


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214
[Bug 32214] Staff interface toolbar - no options when search catalog selected
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 22:49:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 21:49:59 +0000
Subject: [Koha-bugs] [Bug 32215] New: Capitalization: %s You Searched for %s
Message-ID: <bug-32215-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215

            Bug ID: 32215
           Summary: Capitalization: %s You Searched for %s
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating, so still needs to be located in the GUI:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:163
%s You Searched for %s

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 22:54:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 21:54:29 +0000
Subject: [Koha-bugs] [Bug 32216] New: Send MEMBERSHIP_EXPIRY notice as print
Message-ID: <bug-32216-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32216

            Bug ID: 32216
           Summary: Send MEMBERSHIP_EXPIRY notice as print
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This is bug 23773 but for print versions of MEMBERSHIP_EXPIRY

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:00:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:00:14 +0000
Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New"
In-Reply-To: <bug-31561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31561-70-L5JG4xpzUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561

jesus at medios.es changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesus at medios.es

--- Comment #8 from jesus at medios.es ---
Here are my two cents:
After restarting the server, jobs are still stuck. This is the log after
restarting with the jobs stuck at New:

[Tue Nov 15 22:40:07.697358 2022] [cgi:error] [pid 2005] [client
194.126.225.130:53851] AH01215: Can't use an undefined value as an ARRAY
reference at /usr/share/koha/lib/Koha/BackgroundJob/BatchUpdateItem.pm line
175.: /usr/share/koha/intranet/cgi-bin/admin/background_jobs.pl, referer:
http://rgpi-intra.koha.sibadoc.es/cgi-bin/koha/admin/background_jobs.pl
[Tue Nov 15 22:40:07.731067 2022] [cgi:error] [pid 2005] [client
194.126.225.130:53851] End of script output before headers: background_jobs.pl,
referer:
http://rgpi-intra.koha.sibadoc.es/cgi-bin/koha/admin/background_jobs.pl

This is the error when cancelling one stuck job:

[Tue Nov 15 22:50:02.192227 2022] [cgi:error] [pid 2622] [client
194.126.225.130:53880] AH01215: Can't use an undefined value as an ARRAY
reference at /usr/share/koha/lib/Koha/BackgroundJob/BatchUpdateItem.pm line
175.: /usr/share/koha/intranet/cgi-bin/admin/background_jobs.pl, referer:
http://rgpi-intra.koha.sibadoc.es/cgi-bin/koha/admin/background_jobs.pl?op=cancel&id=1
[Tue Nov 15 22:50:02.228410 2022] [cgi:error] [pid 2622] [client
194.126.225.130:53880] End of script output before headers: background_jobs.pl,
referer:
http://rgpi-intra.koha.sibadoc.es/cgi-bin/koha/admin/background_jobs.pl?op=cancel&id=1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:01:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:01:45 +0000
Subject: [Koha-bugs] [Bug 32217] New: Typo: Error authenticating in external
 provider
Message-ID: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32217

            Bug ID: 32217
           Summary: Typo: Error authenticating in external provider
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:11

%sTwo-factor authentication%s %sTwo-factor authentication setup%s %sLog in to
Koha%s %sThis account has been locked. %sInvalid username or password%s %sIP
address change%s %sSession timed out%s %sAccess denied%s %sError authenticating
in external provider%s &rsaquo; Koha␠

Should it be: Error authenticating against external provider?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:21:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:21:28 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-6wYuwdShXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The main page has a page-section now, but once you click through to a staged
set the results table at the bottom of the page is not contained within such a
div yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:22:29 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-vFTOM1hINk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
           Assignee|lucas at bywatersolutions.com  |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:22:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:22:37 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-pvD9l8SO3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:22:45 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-P2kQKjdzwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:24:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:24:07 +0000
Subject: [Koha-bugs] [Bug 32218] New: Rephrase: Allow OPAC access to users
 from this domain to login with this identity provider.
Message-ID: <bug-32218-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218

            Bug ID: 32218
           Summary: Rephrase: Allow OPAC access to users from this domain
                    to login with this identity provider.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:204
Allow OPAC access to users from this domain to login with this identity
provider.

Maybe this was meant?

Allow users of this domain to log into the OPAC using this identity provider.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:24:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:24:13 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-9yUkyT7Yyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:24:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:24:16 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-pqWdxxpaoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:25:11 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-c5OTN8nBUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Koha security               |Koha
                 CC|                            |dpavlin at rot13.org
          Component|Koha                        |Authentication
         QA Contact|                            |nick at bywatersolutions.com
              Group|Koha security               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:26:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:26:29 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-J6HAfI97Oh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:26:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:26:32 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-LI9kBgsXcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:39:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:39:18 +0000
Subject: [Koha-bugs] [Bug 32218] Rephrase: Allow OPAC access to users from
 this domain to login with this identity provider.
In-Reply-To: <bug-32218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32218-70-kT3o29rp59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Certainly sounds like a good rephrase to me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:42:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:42:26 +0000
Subject: [Koha-bugs] [Bug 32217] Typo: Error authenticating in external
 provider
In-Reply-To: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32217-70-KZKFnNpT93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32217

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I did a bit of Googling for phrasing and I think maybe "Error authenticating
with X" seems to be the norm.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 15 23:44:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 22:44:54 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-519JKM5ihj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Anything particular to look for in this one?

Is something clearly broken without it which is fixed with it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 00:03:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Nov 2022 23:03:45 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-SQkylLmOS5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #5 from David Nind <david at davidnind.com> ---
(In reply to David Cook from comment #4)
> Anything particular to look for in this one?
> 
> Is something clearly broken without it which is fixed with it?

See bug 25267 - without this, you can't rebuild the CSS for the OPAC.

So, before applying the patch:
1. yarn install
2. yarn build --view opac
3. Result - you get an error:

yarn build --view opac
yarn run v1.22.19
$ node_modules/.bin/gulp build --view opac
[22:33:59] Using gulpfile /kohadevbox/koha/gulpfile.js
[22:33:59] Starting 'build'...
Error in plugin 'sass'
Message:
    koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
Error: File to import not found or unreadable:
../../../../../node_modules/bootstrap/scss/custom-forms.
        on line 52 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
        from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>> @import "../../../../../node_modules/bootstrap/scss/custom-forms";

   ^

[22:33:59] Finished 'build' after 91 ms
Done in 2.42s.

4. Apply the patch.
5. Repeat steps 1 and 2.
6. Result - OPAC CSS is rebuilt successfully without any errors.

Also, see the discussion on IRC
http://irc.koha-community.org/koha/2022-11-15#i_2462075

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:09:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:09:09 +0000
Subject: [Koha-bugs] [Bug 32220] New: Capitalization: Allow opac
Message-ID: <bug-32220-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32220

            Bug ID: 32220
           Summary: Capitalization: Allow opac
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating, at least 3 occurrences:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:302
Allow opac

Locations:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:150
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:251 
Allow opac:␠

OPAC is an abbreviation (Online Public Access Catalog) and should be
capitalized: OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:10:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:10:44 +0000
Subject: [Koha-bugs] [Bug 32218] Rephrase: Allow OPAC access to users from
 this domain to login with this identity provider.
In-Reply-To: <bug-32218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32218-70-cTxkEaZ06U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32218

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is another, similar one:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:212
Allow staff access to users from this domain to login with this identity
provider.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:15:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:15:07 +0000
Subject: [Koha-bugs] [Bug 32221] New: password option should be removed from
 notice templates
Message-ID: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

            Bug ID: 32221
           Summary: password option should be removed from notice
                    templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Since the password can no longer be shown in notices, borrowers.password should
be removed from the notice templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:15:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:15:55 +0000
Subject: [Koha-bugs] [Bug 32222] New: Capitalization: id
Message-ID: <bug-32222-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222

            Bug ID: 32222
           Summary: Capitalization: id
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

ID is an abbreviation and should be written with capitals.

See:
https://www.oxfordlearnersdictionaries.com/definition/english/identification

Found these instances while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:73
An error occurred trying to open the identity provider domain for editing. The
passed id is invalid.

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:69
An error occurred trying to open the identity provider for editing. The passed
id is invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:31:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:31:54 +0000
Subject: [Koha-bugs] [Bug 32222] Capitalization: id
In-Reply-To: <bug-32222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32222-70-RFcVsGgv0w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:32:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:32:09 +0000
Subject: [Koha-bugs] [Bug 32221] password option should be removed from
 notice templates
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-RvsAgguTFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:32:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:32:27 +0000
Subject: [Koha-bugs] [Bug 32220] Capitalization: Allow opac
In-Reply-To: <bug-32220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32220-70-F5hU0rPfuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32220

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 01:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 00:39:26 +0000
Subject: [Koha-bugs] [Bug 32221] password option should be removed from
 notice templates
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-XwSc0SG4Hb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher, do you mean the ability to add it using the list in the notice
editor or do you mean one of the sample notices? The latter should have been
done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 06:59:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 05:59:57 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-UMbgidT1c3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am sorry, this is a mistake, we should not have the version bump. We are
finally not using bootstrap 5 for ERM, see commit "Bug 32030: ERM - Remove
BootstrapVue3"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:01:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:01:40 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-CEhLvo1vpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
We could go with your patch or remove
  "bootstrap-vue-3": "^0.1.7",
and adjust the bootstrap version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:09:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:09:05 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-kZWUwfzCjV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32219

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:36:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:36:42 +0000
Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New"
In-Reply-To: <bug-31561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31561-70-Xq0HVkBEXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561

--- Comment #9 from Björn Nylén <bjorn.nylen at ub.lu.se> ---
(In reply to jesus from comment #8)
> Here are my two cents:
> After restarting the server, jobs are still stuck. This is the log after
> restarting with the jobs stuck at New:
> 
These errors seem to be related to Bug 31245. It's related to reporting on non
started job but the error is the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:41:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:41:55 +0000
Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to
 BackgroundJob
In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27421-70-mDnKIcvE8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31891


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891
[Bug 31891] Regression: show "MARC staging results" with clear link to manage
staged bartch
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:41:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:41:55 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-OhyGWlb4sn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|31666                       |27421
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
[Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666
[Bug 31666] Add job progress bar to stage-marc-import.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:41:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:41:55 +0000
Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl
In-Reply-To: <bug-31666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31666-70-hkDDrXzYzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31891                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891
[Bug 31891] Regression: show "MARC staging results" with clear link to manage
staged bartch
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:46:38 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-ZfMnZGiAYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:46:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:46:42 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-cMhdQh02Lw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143933&action=edit
Bug 31891: (bug 27421 follow-up) Remove one additional click

>From comment 0
"""
Moving marc batch import actions to background jobs has introduced some
confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:56:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:56:30 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-G6KCCSAraT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:56:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:56:34 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-YZn71TQaaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143934&action=edit
Bug 32214: Prevent empty search option block in catalog search header

In the header, if "Search catalog" is selected, there is an "option"
icon to display some filters.
Fitlers are displayed if IntranetCatalogSearchPulldown or
IntranetAddMastheadLibraryPulldown is set. If none are set we should
hide the icon to avoid and empty div to be displayed

Test plan:
Confirm that the icon is only displayed if one of the 2 prefs is turned
on.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:57:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:57:00 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-3lKILh6YvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 07:57:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 06:57:07 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-kTHbtKiKw1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 08:07:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 07:07:57 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-sUplpQPOs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #67 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Hmm, it seems code returns only "MANUAL" restriction. Tests however return
correct type. So for some reason Koha saves restrictions incorrectly from UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 08:08:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 07:08:36 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-ssTJiPyGAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
https://snipboard.io/fDocvA.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 08:10:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 07:10:27 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged bartch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-lNUoZgqU0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143933|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143935&action=edit
Bug 31891: (bug 27421 follow-up) Remove one additional click

>From comment 0
"""
Moving marc batch import actions to background jobs has introduced some
confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 08:30:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 07:30:32 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-Tt8mxttHI6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

--- Comment #68 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143936&action=edit
Bug 16223: Add correct value attributes to restriction options in select
element

Restrictions weren't lift after payment because value
attributes for restrictions code were missing from
restriction select element in patron-restrictions-tab.inc.
Due this restrictions were always set as type "MANUAL".

To test:
1. Add new restriction which has "Lift after payment?" set
as Yes and fee limit as 5.
2. Create fees for a patron so they exceed fee limit e.g. 10
3. Add restriction made in step 1. for the patron
4. Pay patrons fees partially so that they go under fee limit
=> Note that patrons restriction should now be lifted.

Also prove t/db_dependent/Patron/Borrower_Debarments.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 08:30:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 07:30:46 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-rSriIbRLMH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:00:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:00:58 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-ggVtct5i5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:01:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:01:03 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-66GQ3s5QbM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143695|0                           |1
        is obsolete|                            |
 Attachment #143696|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143937&action=edit
Bug 32147: Capitalization: E-Resource management

When e- is used as prefix, the second word should not
be capitalized. And when e-resource-management is used
as part of a sentence, the e shouldn't be either.
See: e-mail, e-commerce. etc.

To test:
* Best to check the code... but:
* All E-Resource should now read e-resource or E-resource, as on:
  * Koha start page
  * Breadcrumbs in the ERM module
  * Descriptions of AV categories...

I chose to update the sysprefs.sql and the DB update as well
as this hasn't been released yet.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Bug 32147: (follow-up) Fix missing space

One of the AV category descriptions was missing a space
before the (e-resource management).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:01:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:01:47 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-8fKHpf2iqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32147


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147
[Bug 32147] Capitalization: E-Resource management should be E-resource
management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:01:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:01:47 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-cTetSdDlEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32131


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131
[Bug 32131] Cypress tests are failing if ERMModule is off
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:04:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:04:36 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-nryxrDmOPf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:04:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:04:40 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-KdTLIAIYgi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143803|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143938&action=edit
Bug 32131: Cypress tests are failing if ERMModule is off

This patch solves this by enabling the system preference before each test,
right after login. It also sets the system preference back to its original
initial value after the tests finish running.

To test:
1) Disable ERMModule system preference
2) Run cypess tests: yarn cypress open / yarn cypress run
3) Verify that tests run successfully
(Optional): While tests are running, visit the system preferences panel and
verify that the system preference is now "Enable".
4) Wait for the tests to finish and confirm that the system preference is set
back to its original "Disable" value.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:04:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:04:45 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-AThrVPjAGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143939&action=edit
Bug 32131: Move set_ERM_sys_pref_value to before

We cannot (yet) move login to before, but we can set the pref before all
the tests. We need to login in before anyway to retrieve the value of
the pref.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:04:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:04:49 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-5Pbf94WDYY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143940&action=edit
Bug 32131: Make sure we login before we restore original pref's value

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:04:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:04:54 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-YUAJJbV270@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143941&action=edit
Bug 32131: (to-squash) Cypress tests are failing if ERMModule is off

Please squash this with the first patch if 32147 is pushed before 32131.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:09:14 +0000
Subject: [Koha-bugs] [Bug 32223] New: package.json script paths too specific
Message-ID: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

            Bug ID: 32223
           Summary: package.json script paths too specific
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

"build": "node_modules/.bin/gulp build",

We should not specify the node_modules/.bin part if the env is correctly
configured.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:10:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:10:07 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-erC9dBTnQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:10:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:10:11 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-ma996RW9le@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143942&action=edit
Bug 32223: Remove node_modules/.bin from package.json

We should not specify the node_modules/.bin part if the env is correctly
configured.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:10:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:10:44 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-GmP49rgPLw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:12:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:12:35 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-xVpzekT11l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
To test:
pull the latest ktd images (to get /kohadevbox/node_modules)
remove your node_modules directory from $SYNC_REPO (if exists)
Run yarn gulp commands to regenerate css files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:18:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:18:09 +0000
Subject: [Koha-bugs] [Bug 32224] New: Add cypress to the yarn commands
Message-ID: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

            Bug ID: 32224
           Summary: Add cypress to the yarn commands
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Either I am missing something obvious, or we need to add cypress to the scripts
of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I
cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see
https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905)
but I think both should work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:18:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:18:41 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress to the yarn commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-G3apldvZv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32131
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:18:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:18:41 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-KVdvKc8gUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32224

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:19:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:19:10 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress to the yarn commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-qphMroNwDf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32223


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223
[Bug 32223] package.json script paths too specific
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:19:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:19:10 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-J5i2Bd7QVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32224


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224
[Bug 32224] Add cypress to the yarn commands
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:19:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:19:57 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress to the yarn commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-RHN2ah3Y5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:20:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:20:01 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress to the yarn commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-C7ZcAOqDKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143943&action=edit
Bug 32224: Add cypress to yarn commands

Either I am missing something obvious, or we need to add cypress to the scripts
of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I
cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see
https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905)
but I think both should work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:24:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:24:47 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-pFR6QSYKu2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:42:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:42:32 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-EQwlSCKi85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:42:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:42:36 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-WT24HSCSH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143931|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143944&action=edit
Bug 32112: Move 'Delete selected items' to its own line

This moves the checkbox and its label out of the action field set
which makes it appear above the bottons instead of in front of it.

To test:
* Go to any record
* Select items and send to item batch delete
* Verify checkbox appears in front of button
* Apply patch
* Verify the checkbox and the yellow 'delete selected items' button
  are now on separate lines

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 09:55:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 08:55:10 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-F7SED5anlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
           Severity|enhancement                 |major
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Upping severity.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 10:00:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 09:00:56 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-iYUHG390b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |additional_work_needed

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This is missing the "DBIC changes" commit in master!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 10:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 09:13:20 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-NnNon3QEVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 10:13:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 09:13:23 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-yzMrgO6VBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143934|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 143945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143945&action=edit
Bug 32214: Prevent empty search option block in catalog search header

In the header, if "Search catalog" is selected, there is an "option"
icon to display some filters.
Fitlers are displayed if IntranetCatalogSearchPulldown or
IntranetAddMastheadLibraryPulldown is set. If none are set we should
hide the icon to avoid and empty div to be displayed

Test plan:
Confirm that the icon is only displayed if one of the 2 prefs is turned
on.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 10:29:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 09:29:48 +0000
Subject: [Koha-bugs] [Bug 32192] Fines Calculation not working
In-Reply-To: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32192-70-TIy0yJPEJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32192

--- Comment #2 from Sandeep Patel <samrocks1011 at gmail.com> ---
Hello Katrin,

Thanks for the reply.  But the issue is resolved. The Librarian create multiple
libraries which I was not aware of. I applied the rule to each library and the
issue got resolved. 

Regards,
Sandeep Patel

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 10:57:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 09:57:54 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-4PNK7fuhH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regression: show "MARC      |Regression: show "MARC
                   |staging results" with clear |staging results" with clear
                   |link to manage staged       |link to manage staged batch
                   |bartch                      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 11:30:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 10:30:16 +0000
Subject: [Koha-bugs] [Bug 32225] New: Capitalization: Display Order
Message-ID: <bug-32225-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32225

            Bug ID: 32225
           Summary: Capitalization: Display Order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:675
Display Order

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 11:34:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 10:34:38 +0000
Subject: [Koha-bugs] [Bug 32226] New: Capitalization: Edit html content
Message-ID: <bug-32226-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226

            Bug ID: 32226
           Summary: Capitalization: Edit html content
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

HTML is an abbreviation and should be capitalized:

Edit html content
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt:259

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 11:38:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 10:38:57 +0000
Subject: [Koha-bugs] [Bug 32227] New: Adlibris plug-in creates multiple
 baskets
Message-ID: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32227

            Bug ID: 32227
           Summary: Adlibris plug-in creates multiple baskets
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stina at imcode.com
        QA Contact: testopia at bugs.koha-community.org

When ordering, using the Adlibris plug-in, sometimes two baskets are created in
Koha, or even three at rare occations. There has also been instances where more
than one item is created in the catalogue.

The problem only occurs in Koha, not in Adlibris, and the duplicates that are
created can be deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 11:46:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 10:46:47 +0000
Subject: [Koha-bugs] [Bug 32227] Adlibris plug-in creates multiple baskets
In-Reply-To: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32227-70-GeZuKPkVdb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32227

Stina <stina at imcode.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stina at imcode.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 11:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 10:46:53 +0000
Subject: [Koha-bugs] [Bug 32228] New: Clean staged MARC records confirmation
 message should include a note related to Undo Import into Catalog
Message-ID: <bug-32228-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32228

            Bug ID: 32228
           Summary: Clean staged MARC records confirmation message should
                    include a note related to Undo Import into Catalog
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucy.vaux-harvey at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The warning message that displays when you select the Clean a file in Staged
MARC management is as follows:

"Clear all reservoir records staged in this batch?  This cannot be undone."

It would be helpful to also make clear in the message that once a file is
'cleaned' it will no longer be possible to use the 'Undo import into catalog'
option to remove a file of imported records from the catalogue.  

We have instances where a file has been cleaned but the library still require
to remove the records from the catalogue at a later stage.  These records then
need to be identified separately and deleted using batch record deletion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:00:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:00:35 +0000
Subject: [Koha-bugs] [Bug 32229] New: Typo: Items missing from bundle at
 checking for %s
Message-ID: <bug-32229-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32229

            Bug ID: 32229
           Summary: Typo: Items missing from bundle at checking for %s
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: martin.renvoize at ptfs-europe.com

Should this have been checkin?

Items missing from bundle at checking for %s
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt:1336

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:02:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:02:42 +0000
Subject: [Koha-bugs] [Bug 32227] Adlibris plug-in creates multiple baskets
In-Reply-To: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32227-70-HnIXSHXFVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32227

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Stina, as the Adlibris plug-in is not a part of Koha, you should first file
an issue with the plugin creators. If you have the URL of the repository, like
gitlab or github, you might be able to file the issue there.

Only if it turns out to be an issue with our API or so, we can start
investigating in Koha, but there will be more information needed first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:03:53 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-rFKjqir9bJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:03:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:03:57 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-hfu1NFbaUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143948&action=edit
Bug 31543: (follow-up) Use url filter for opac components search

The previous patch switches to using 'query_string' which is returned encoded.
Using uri we doulbe encode the string - this patch prevents that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:08:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:08:58 +0000
Subject: [Koha-bugs] [Bug 32227] Adlibris plug-in creates multiple baskets
In-Reply-To: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32227-70-fZv1TG5LUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32227

--- Comment #2 from Stina <stina at imcode.com> ---
Hi Katrin, I am new to posting bugs, so I need to learn this. Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:13:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:13:30 +0000
Subject: [Koha-bugs] [Bug 32230] New: Capitalization: Manage Domains
Message-ID: <bug-32230-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230

            Bug ID: 32230
           Summary: Capitalization: Manage Domains
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating:

Manage Domains
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:406

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:27:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:27:59 +0000
Subject: [Koha-bugs] [Bug 26835] Ability to remove Lost Items from Patrons
 Account without Checking in
In-Reply-To: <bug-26835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26835-70-A0cFdZnyQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26835

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 32019 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:27:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:27:59 +0000
Subject: [Koha-bugs] [Bug 32019] Add option to mark items returned in batch
 modification
In-Reply-To: <bug-32019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32019-70-Wq2R2hCpFl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 26835 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:29:57 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-GSLEutRgbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:32:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:32:25 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-gqUU6RYr98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:32:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:32:29 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-2IonoXpKpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143942|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143949&action=edit
Bug 32223: Remove node_modules/.bin from package.json

We should not specify the node_modules/.bin part if the env is correctly
configured.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:32:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:32:54 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-cqgn8vuCJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:34:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:34:10 +0000
Subject: [Koha-bugs] [Bug 28203] Add Match-heading search field and UNIMARC
 mappings
In-Reply-To: <bug-28203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28203-70-TmEX8CMPQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
I don't think this is correct - Match-heading is a standardized format based on
the heading of the authority record - it is constructed according to set rules
and does not need to be configurable.

The field has been removed from mappings and is auto-constructed in the
indexing now

The changes for Match-heading-see-from could be moved forward, I am not sure
how utilized this field is though

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:41:24 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-drdnq8UYE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
I think removing Bootstrap 5 is the right thing to do, if we don't need it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:44:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:44:49 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-Ks4ZrxEblm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:44:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:44:52 +0000
Subject: [Koha-bugs] [Bug 32223] package.json script paths too specific
In-Reply-To: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32223-70-R5VOOJ6VXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:47:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:47:45 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-dkdUycTnjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 12:47:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 11:47:48 +0000
Subject: [Koha-bugs] [Bug 32147] Capitalization: E-Resource management
 should be E-resource management
In-Reply-To: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32147-70-VEENjIOHUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32147

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:09:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:09:17 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-jt3yedcbeG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:09:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:09:22 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-VWKE7SYv7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:16:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:16:02 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-M2paNU3rlx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
We do have a password expiry mechanism now - if a patron's password is set as
expired when setup, they would have to reset on first login - but we need a
convenient way of setting new passwords as expired

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:20:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:20:51 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-lZBrQHEplf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #4)
> We do have a password expiry mechanism now - if a patron's password is set
> as expired when setup, they would have to reset on first login - but we need
> a convenient way of setting new passwords as expired

Which is great! So it should not be that difficult anymore to make this
additional step..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:24:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:24:49 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-TFngVmYmEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:31:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:31:33 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-liMagqf0bC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:13 +0000
Subject: [Koha-bugs] [Bug 31711] When creating order lines "From a new file"
 you are no longer redirected to acq after import
In-Reply-To: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31711-70-6MaJyiHcxl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31711

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Keywords|regression,                 |
                   |rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:31 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-OLCM8eC6tq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:34 +0000
Subject: [Koha-bugs] [Bug 32042] Add page-section to catalog's item detail
 view
In-Reply-To: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32042-70-ePT8ZpkRLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32042

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:39 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-SrvNHaLyTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:45 +0000
Subject: [Koha-bugs] [Bug 32112] Move "Delete selected items" button to new
 line
In-Reply-To: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32112-70-nQkZQsJmce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32112

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:52 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-pSkqEJPlcQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:39:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:39:57 +0000
Subject: [Koha-bugs] [Bug 32155] Course reserves - instructors display is
 misaligned on course information page
In-Reply-To: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32155-70-ahCcxwN7W7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32155

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:02 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-s9YjO6vLIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:05 +0000
Subject: [Koha-bugs] [Bug 32169] Add page-section to item list on top of
 batch item edit (tools)
In-Reply-To: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32169-70-Pjv4f8IbUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32169

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:08 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-WEJV5MBxt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:11 +0000
Subject: [Koha-bugs] [Bug 32170] Add page-section to CSV profiles (tools)
In-Reply-To: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32170-70-OqZOuq2Ogq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32170

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:16 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-St61C5kjjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:20 +0000
Subject: [Koha-bugs] [Bug 32182] Replace static tabs markup with Bootstrap
In-Reply-To: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32182-70-1yM2urDNwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32182

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:23 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-MB5kncvqxp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:26 +0000
Subject: [Koha-bugs] [Bug 32193] Reindent item details template
In-Reply-To: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32193-70-BoR93zvB5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32193

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:29 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-ZqcpQGQSfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:34 +0000
Subject: [Koha-bugs] [Bug 32197] Add page-section to catalog's stock
 rotation page
In-Reply-To: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32197-70-1xNQkabiri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32197

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:38 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-wbJeeacjoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:42 +0000
Subject: [Koha-bugs] [Bug 32199] Add page-section to various patron pages
In-Reply-To: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32199-70-sokrpRcn8x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32199

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:45 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-WTg4IiqvSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:40:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:40:48 +0000
Subject: [Koha-bugs] [Bug 32207] Add page-section to some circulation pages
In-Reply-To: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32207-70-EgFHFBKSaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32207

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:43:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:43:28 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-UKOg3oHKkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:43:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:43:34 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-I21PtyCWGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143928|0                           |1
        is obsolete|                            |

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143950&action=edit
Bug 31751: Breadcrumb style

This patch updates the breadcrumb style to use the old caret icon
instead of a slash.

I've left the italic because I think it works well to set the text off
from the normal text above, in the search bar, and below in the main
body of the page.

To test, apply the patch and rebuild the staff interface CSS. Look at
various pages in the staff interface and check the style of the
breadcrumbs menu.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:47:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:47:05 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-KyounSgTbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:52:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:52:33 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-wLtMU68Qpk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:52:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:52:38 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-R8W3WMYMSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143739|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143951&action=edit
Bug 32172: Remove biblionumber param from Z3950 popup on results

This param is not defined in routine, who knows whereit comes from

To test:
1 - Enable coce and coce intranet, select all providers:
    https://coce.bywatersolutions.com
2 - Search on staff client
3 - Click Z3950 search
4 - Note url contains a random biblionumber
5 - Apply patch
6 - Repeat
7 - No biblionumber

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:54:44 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-ZoUvsfo9qv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 13:54:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 12:54:51 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-p57UPHh85C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143952&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:05:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:05:50 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-Aex7ItHyjC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Jonathan Druart from comment #9)
> > Created attachment 143893 [details]
> > update DB output 22.05.00 to 22.06.00.083
> 
> I think that's before I pushed my patch, please try again or check the new
> attachment. It is pretty consistent to me right now. There might be style
> opinions, though. I basically renamed the descriptions for the bug
> descriptions and then put the 'actions' that took place, so the identity
> providers one really reads:
> 
> Upgrade to 22.06.00.081  [18:54:12]: Bug 31378 - Add identity_provider and
> identity_provider_domains configuration tables
> 	Added new permission 'manage_identity_providers'
> 	Added new table 'identity_providers'
> 	Added new table 'identity_provider_domains'

Should we add this to the wiki?
https://wiki.koha-community.org/wiki/Database_updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:19:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:19:06 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-Bm38xnoHl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:30:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:30:19 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-8yFBS2ioTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:30:25 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-ZvCJ178Ykw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143916|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143953&action=edit
Bug 32166: Use import record id for retrieving correct inputs

When importing from a staged file we retrieve the records form the DB, skip any
that are not selected,
and process the rest.

When we skip some, we still raise our record count, and use this to retrieve
the inputs.

When building the page, we don't increment for skipped reocrds, so there can be
a mismatch, i.e.
Record #1 on the page to add records may be the 3rd record in the import file

Rather than using a counting system, let us use the import record id directly

To test:
 0 - Set system preferences:

MarcFieldsToOrder:
price: 949$g
quantity: 949$k
budget_code: 949$l
discount: 949$m
sort1: 949$n
sort2: 949$q

MarcItemFieldsToOrder:
homebranch: 949$a
holdingbranch: 949$b
itype: 949$y
nonpublic_note: 949$x
public_note: 949$z
loc: 949$c
ccode: 949$8
notforloan: 949$7
uri: 949$u
copyno: 949$t
price: 949$g
replacementprice: 949$v
itemcallnumber: 949$o
quantity: 949$k
budget_code: 949$l

 1 - Stage attached sample file, Format:MARCXML, Record matching:Koha biblio
999$c
 2 - Add to a basket from the staged file
 3 - Select 1st record to basket and save
 4 - Record is added with the fields above as expected
 5 - Add to basket again, select 2nd record
 6 - Record is added with price from 020a, ignoring incoming fields
 7 - Repeat with 3rd, same problem
 8 - Apply patch
 9 - Stage file and repeat step 3
10 - Confirm added with correct values
11 - Add 2nd record and save, values correct
12 - Add 3rd record, values correct

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:37:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:37:09 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-a22IaGcYGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:37:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:37:14 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-tVacboSamr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143919|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143954&action=edit
Bug 32171: Store after populating order

This updates the call to store after populating the order

I put this on it's own bug just for sake of dependency, in case it is needed
seperate from 32166 for backports

To test:
1 - Apply and test with bug 32166

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:37:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:37:34 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-y42abK8Kw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the help with the test plan, Andrew!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:54:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:54:46 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-lBCvGZeccP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 14:54:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 13:54:50 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-i9OkHhtMkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143935|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143955&action=edit
Bug 31891: (bug 27421 follow-up) Remove one additional click

>From comment 0
"""
Moving marc batch import actions to background jobs has introduced some
confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:08:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:08:21 +0000
Subject: [Koha-bugs] [Bug 32231] New: Improve display of items,
 when items are created from staged files
Message-ID: <bug-32231-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32231

            Bug ID: 32231
           Summary: Improve display of items, when items are created from
                    staged files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 32046

With the improved display from bug 32046 and the test plan from bug 32166 we
see the items created from staged files:

https://snipboard.io/DLZQ41.jpg

They could look a little prettier.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046
[Bug 32046] When adding a new records from a staged files, there are style
issues
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:08:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:08:21 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-Lo3OiaocB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32231


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32231
[Bug 32231] Improve display of items, when items are created from staged files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:15:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:15:47 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-zCcHNBOsfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:15:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:15:52 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-2z0t5vBpyX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143952|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143956&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:23:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:23:35 +0000
Subject: [Koha-bugs] [Bug 31576] [21.11] Cannot place hold even when
 AllowHoldPolicyOverride should allow it
In-Reply-To: <bug-31576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31576-70-EkuTeEHCsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Keywords|                            |rel_21_11_candidate

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #5)
> Shouldnt this be pushed to the queue of the RMaint of 21.11 ?

Yes, but still could use a QA eye ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:24:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:24:46 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-leMFhYvbCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:24:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:24:51 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-VsAkdaTUG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143890|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143957&action=edit
Bug 32109: Fix spacing in toolbars containing text links

This patch adds a new class to toolbars in certain contexts: Where the
toolbar contains only text links (as opposed to Bootstrap-styled
controls). This lets us set some comfortable padding on the links.

To test, apply the patch and rebuild the staff interface CSS.

Test the following pages to confirm that the toolbar of selection links
("Select all," "Clear all," etc.) has legible spacing.

- Cataloging -> Batch item modification -> List of submitted barcodes
- Cataloging -> Batch item deletion -> List of submitted barcodes
- Cataloging -> Batch record modification -> List of submitted records
- Cataloging -> Batch record deletion -> List of submitted records
- Circulation -> Checkout notes
- Tools -> Batch extend due dates -> Preview results
- Tools -> Batch patron modification -> List of submitted patrons
- Tools -> OPAC problem reports

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:25:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:25:13 +0000
Subject: [Koha-bugs] [Bug 32232] New: Koha crashes if dateofbirth is
 1947-04-27, 1948-04-25, or 1949-04-24
Message-ID: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232

            Bug ID: 32232
           Summary: Koha crashes if dateofbirth is 1947-04-27, 1948-04-25,
                    or 1949-04-24
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I think this only happens if the server/computer is set to an Eastern Canadian
timezone. In 1947, 1948 and 1949, Canada decided to switch to daylight saving
time at midnight rather than the usual 2am. Therefore, 1947-04-27 00:00:00,
1948-04-25 00:00:00 and 1949-04-24 00:00:00 don't exist in this timezone.

Even if borrowers.dateofbirth is set to 'date' (not 'datetime'), Koha crashes,
saying the date doesn't exist. I suspect it would happen with any date, but
dateofbirth is the most likely (only) field to have dates in those years.

To test:
1. Create a patron, setting the date of birth to one of these three dates
- 1947-04-27
- 1948-04-25
- 1949-04-24
2. Save the patron
--> Error

I tested this on production installations in 21.05 and it works fine.
Production installations in 22.05, it crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:30:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:30:16 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-0jUsVnCozV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #112 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I added an open_article_requests_limit without patron category by script. And
it works fine. Disadvantage: the record is not shown on the Circulation rules
interface..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:31:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:31:04 +0000
Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27,
 1948-04-25, or 1949-04-24
In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32232-70-ZBtMnAppIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 15:31:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 14:31:10 +0000
Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27,
 1948-04-25, or 1949-04-24
In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32232-70-8ZrukPzXYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:11:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:11:29 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-yxbLQJgVRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Steve Butzel <librarydirector at wigginml.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |librarydirector at wigginml.or
                   |                            |g

--- Comment #14 from Steve Butzel <librarydirector at wigginml.org> ---
Can't wait to see this fix implemented. I'm so glad that it appears to have
been solved. 

Thanks,
Steve

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:13:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:13:03 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-VmspAd2zkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Examples updated and added to on the wiki page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:13:20 +0000
Subject: [Koha-bugs] [Bug 30730] Holds to Pull should not list items with a
 notforloan status
In-Reply-To: <bug-30730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30730-70-oz6VH0CjPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730

Steve Butzel <librarydirector at wigginml.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |librarydirector at wigginml.or
                   |                            |g

--- Comment #22 from Steve Butzel <librarydirector at wigginml.org> ---
Getting this into 21.11 would FANTASTIC!!! Please and thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:13:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:13:32 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-LXDQyFDqQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Perhaps a QA script addition?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:25:11 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-eLTCcu7zqd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #66 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The following follow-up looks highly arguable to me:

Bug 24606: Fix encoding issues on decoded content

-    return decode_json( $self->contents ) if $self->contents;
+    return decode_json( encode_utf8($self->contents) ) if $self->contents;

Note a few lines above (in ->store):
    if ( ref( $self->contents ) eq 'HASH' ) {
        $self->contents( encode_json( $self->contents ) );
    }

The reference to "Do it yourself" in the commit message is not very specific
and out of its context.

Since we are storing strings to the database here, I think we should refer the
utf8 encoding to that layer. And we should encode/decode in the middle of the
process.

So I would quote another part of the JSON docs:
utf8 flag disabled
When utf8 is disabled (the default), then encode/decode generate and expect
Unicode strings, that is, characters with high ordinal Unicode values (> 255)
will be encoded as such characters, and likewise such characters are decoded
as-is, no changes to them will be done, except "(re-)interpreting" them as
Unicode codepoints or Unicode characters, respectively (to Perl, these are the
same thing in strings unless you do funny/weird/dumb stuff).
This is useful when you want to do the encoding yourself (e.g. when you want to
have UTF-16 encoded JSON texts) or when some other layer does the encoding for
you (for example, when printing to a terminal using a filehandle that
transparently encodes to UTF-8 you certainly do NOT want to UTF-8 encode your
data first and have Perl encode it another time).

What does practically mean?
You should switch from using decode_json and encode_json TO from_json and
to_json. Leave the strings in Perl internal format during the process.

encode_json Converts the given Perl data structure to a UTF-8 encoded, binary
string.
to_json Converts the given Perl data structure to a Unicode string by default. 

This needs further attention imo. (But cant fail it anymore :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:26:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:26:01 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-ZSJImfnCNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #67 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
And we should encode/decode in the middle of the process.

And we should NOT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:28:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:28:12 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-wp811DfBul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:42:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:42:15 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-N8WTQD5whF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:43:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:43:27 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-tdll44ca2k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Is this something we'd like defined in the patron category? So for each
category one would define both the regular password expiration interval (as one
does now) and, optionally, the expiration interval to use at account creation?

Our existing value is borrowers.password_expiry_days. The new value could be
something like borrowers.enrollment_password_expiry_days. That name is awfully
long.

That would allow one to define various setups like:

Juvenile patrons have NULL for password_expiry_days and
enrollment_password_expiry_days, so their passwords never expire.

Adult patrons have password_expiry_days=365 and
enrollment_password_expiry_days=0. Whatever password is set at creation is
immediately expired, but going forward they expire at 365 days.

Staff accounts have password_expiry_days=365 and
enrollment_password_expiry_days is NULL. Their accounts expire at 365 days with
no special behavior at account creation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 16:57:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 15:57:32 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-pIBFTpmDgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> Same for me, I don't get the error (using Firefox).

Interesting! Not quite sure what is going on here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:15:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:15:59 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-1AdNWnRbdd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:16:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:16:03 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-g4RRAburkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143958&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:27:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:27:48 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-KR877QXQyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allowing circulation        |Allow circulation messages
                   |messages to be editable     |to be editable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:31:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:31:40 +0000
Subject: [Koha-bugs] [Bug 31949] Remove round corners from toolbars
In-Reply-To: <bug-31949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31949-70-zix7YHRUGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Fixed by Bug 32101

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:51:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:51:08 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-8hmP281uXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:51:12 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-9hfYbDbse2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143959&action=edit
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation
messages appearing in the Patron Detail page.  It was commented by a librarian
that it would be nice to have the circulation messages editable. At times
libraries need to keep a specific message on a patrons account with the details
such as what branch it was written from and the staff member that wrote it, but
it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 17:56:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 16:56:01 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-2VgQMzhKgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143959|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143960&action=edit
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation
messages appearing in the Patron Detail page.  It was commented by a librarian
that it would be nice to have the circulation messages editable. At times
libraries need to keep a specific message on a patrons account with the details
such as what branch it was written from and the staff member that wrote it, but
it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:00:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:00:10 +0000
Subject: [Koha-bugs] [Bug 32233] New: Cannot add a guarantor when patron
 attributes have certain characters
Message-ID: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233

            Bug ID: 32233
           Summary: Cannot add a guarantor when patron attributes have
                    certain characters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:

1. Setup a patron attribute 
2. Setup an authorized value category and link it to the new patron attribute
3. Make sure the new authorized value category has a code like 'Driver's
License'.
4. Make sure that patron has been give that value in the patron attribute.
5. Now try to link a child account to that borrower. Nothing happens but you
will see a console error like:

JSON.parse: unterminated string at line 1 column 892 of the JSON data

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:03:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:03:33 +0000
Subject: [Koha-bugs] [Bug 32233] Cannot add a guarantor when patron
 attributes have certain characters
In-Reply-To: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32233-70-qDiHyPFyDk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Lucas, do you really mean code or one of the descriptions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:03:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:03:55 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-kshggZznb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143960|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 143961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143961&action=edit
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation
messages appearing in the Patron Detail page.  It was commented by a librarian
that it would be nice to have the circulation messages editable. At times
libraries need to keep a specific message on a patrons account with the details
such as what branch it was written from and the staff member that wrote it, but
it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:11:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:11:30 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-v3B9s64HfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143961|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 143962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143962&action=edit
Bug 21699: Allow circulation messages to be editable

During a Webinar discussion regarding the new placement of the circulation
messages appearing in the Patron Detail page.  It was commented by a librarian
that it would be nice to have the circulation messages editable. At times
libraries need to keep a specific message on a patrons account with the details
such as what branch it was written from and the staff member that wrote it, but
it would be nice to be able to edit this message.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Browser to a patron record
4) Create a new patron message
5) Note the patron message now has an "edit" button
6) Edit the existing message using the edit button and form
7) Check the action logs for that message, note there is a modification
   logged to that message if BorrowersLog is enabled

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:11:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:11:57 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-in29gaavuw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #68 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #66)
> What does practically mean?
> You should switch from using decode_json and encode_json TO from_json and
> to_json. Leave the strings in Perl internal format during the process.

The docs and you say the same: decode_json expects to be passed a string with
Perl's internal format representing UTF-8 characters. And that's what
encode_utf8 does, and why the patch introduces it at that exact place. 

> This needs further attention imo. (But cant fail it anymore :)

You can't fail what is correct :-P

The cool thing is that you can propose some other solution. But I'd vote
against something that adds more steps to the caller.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:13:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:13:09 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-3WrqYxkGxw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

--- Comment #10 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
This is a wonderful addition - works great.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:13:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:13:41 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-Jya2CB1xYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:15:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:15:25 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-hT3uI2MwxX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #69 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #66)
> encode_json Converts the given Perl data structure to a UTF-8 encoded,
> binary string.
> to_json Converts the given Perl data structure to a Unicode string by
> default. 

"
This module also exports to_json and from_json for backward compatibility.
These are slower
"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:18:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:18:14 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-175J8hTmGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #16)
> Perhaps a QA script addition?

We should add it to some taiga board for 23.05. I cannot spend time on that
right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:18:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:18:50 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-zHQ7cN5lTE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:18:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:18:54 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-Rcs67DsHxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142665|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143963&action=edit
Bug 31543: Use query string, rather than query, to build link

This patch returns the query string from build_query_compat
Under Zebra, either works for the link, for ES we need the simple string

I expand the test for get_components_query to test both engines

To test:
1.0) Set search engine to Elasticsearch
1.1) Go to Tools > Stage MARC records for import
1.2) Upload the example file
1.3) In the form, choose the format 'MARCXML'
1.4) Click 'Stage for import'
1.5) Click 'Manage staged records'
1.6) Click 'Import this batch into the catalog'

2) Change MaxComponentRecords to 10
3) In the staff interface, search the catalog for 'easy piano'
4) Click on the record 'Easy piano pieces for children'
5) Click on the 'show all component parts' link at the bottom of the Components
tab
--> it searches for HASH(...) - returns no results
6) Try the same in OPAC
--> it searches for HASH(...) - returns no results
7) Apply patch and restart all
8) repeat 3-6
9) Results returned!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:18:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:18:58 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-SNDdyFgeKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143948|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 143964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143964&action=edit
Bug 31543: (follow-up) Use url filter for opac components search

The previous patch switches to using 'query_string' which is returned encoded.
Using uri we doulbe encode the string - this patch prevents that

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:27:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:27:31 +0000
Subject: [Koha-bugs] [Bug 32233] Cannot add a guarantor when patron
 attributes have certain characters
In-Reply-To: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32233-70-B6uhdWZcLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> Hi Lucas, do you really mean code or one of the descriptions?

Katrin, sorry. I mean code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:38:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:38:09 +0000
Subject: [Koha-bugs] [Bug 32233] Cannot add a guarantor when patron
 attributes have certain characters
In-Reply-To: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32233-70-MlDkvrDrLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32233

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, then I am not opposed to fixing issues, but I'd also strongly encourage
people not to do that. "Driver's license" is not a code, it's a description.

We train libraries to stick to alphanumeric, no spaces, no underscores, no
special characters etc. because it also tends to create problems with search
(locations, collections, etc.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 18:49:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 17:49:16 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-k4uOoXMedC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I'm not sure if this is a distinct bug or a wrinkle within this one. Sara and
Katrin's comments show that when the staff interface says a category has
Unlimited holds that rule doesn't really get saved in the database. We have a
slightly different scenario.

Our Default checkout, hold and return policy sets unlimited checkouts and 15
holds for all patrons. I want to make our staff category have unlimited
checkouts and unlimited holds. That should mean saving an entry in Default
checkout, hold policy by patron category setting blank values for both rules.
Koha will not save that at all, it just doesn't create a line in that table.

If I cheat and save a line with no value in total checkouts, a (meaningless for
us) value in onsite checkouts, and no value in holds, then it saves and tells
me that both checkouts and holds will be unlimited (but then I run into what
Sara and Katrin have documented, the rule doesn't *really* exist).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:08:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:08:34 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-u7Sz7ZmNDj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am tempted to update severity on this one - circulation rules are complex as
is and they should do what they say in the GUI.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:16:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:16:35 +0000
Subject: [Koha-bugs] [Bug 32234] New: Add page-section to list of imported
 records (cat)
Message-ID: <bug-32234-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32234

            Bug ID: 32234
           Summary: Add page-section to list of imported records (cat)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/tools/manage-marc-import.pl?import_batch
                    _id=7
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

When looking at a batch of imported records, the table is missing the
page-section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:16:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:16:35 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-xkRBX7tdQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32234
[Bug 32234] Add page-section to list of imported records (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:16:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:16:35 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-8tJ2GwxZ8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32234
[Bug 32234] Add page-section to list of imported records (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:18:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:18:06 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-stN76Q5T7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #5 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
(In reply to Katrin Fischer from comment #4)
> I am tempted to update severity on this one - circulation rules are complex
> as is and they should do what they say in the GUI.

Yes, let's. Making this Major.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:19:05 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-b64BVPLXsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:26:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:26:45 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-5v04C2tRvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:26:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:26:50 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-WdrQTVprhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143963|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143965&action=edit
Bug 31543: Use query string, rather than query, to build link

This patch returns the query string from build_query_compat
Under Zebra, either works for the link, for ES we need the simple string

I expand the test for get_components_query to test both engines

To test:
1.0) Set search engine to Elasticsearch
1.1) Go to Tools > Stage MARC records for import
1.2) Upload the example file
1.3) In the form, choose the format 'MARCXML'
1.4) Click 'Stage for import'
1.5) Click 'Manage staged records'
1.6) Click 'Import this batch into the catalog'

2) Change MaxComponentRecords to 10
3) In the staff interface, search the catalog for 'easy piano'
4) Click on the record 'Easy piano pieces for children'
5) Click on the 'show all component parts' link at the bottom of the Components
tab
--> it searches for HASH(...) - returns no results
6) Try the same in OPAC
--> it searches for HASH(...) - returns no results
7) Apply patch and restart all
8) repeat 3-6
9) Results returned!

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:26:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:26:54 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-JcCSFsgvjp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143964|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143966&action=edit
Bug 31543: (follow-up) Use url filter for opac components search

The previous patch switches to using 'query_string' which is returned encoded.
Using uri we doulbe encode the string - this patch prevents that

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:37:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:37:16 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-nzvwHSavnW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #17)
> (In reply to Martin Renvoize from comment #16)
> > Perhaps a QA script addition?
> 
> We should add it to some taiga board for 23.05. I cannot spend time on that
> right now.

We didn't expect you to :) I've filed an issue on gitlab:
https://gitlab.com/koha-community/qa-test-tools/-/issues/63

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:42:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:42:49 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-1WL5gsPa5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If it was only to be used on patron creation, I think we would not need to
store it in the borrower record. Maybe a checkbox on the patron category
administration page for "enforce new password on first login" and then we
realize it by setting the first expiration date to 'immediately' when this is
set and the patron is created.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:55:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:55:59 +0000
Subject: [Koha-bugs] [Bug 32235] New: Add page-section to list of staged
 files (acq)
Message-ID: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235

            Bug ID: 32235
           Summary: Add page-section to list of staged files (acq)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=1
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

When ordering from a staged file, the list of files is missing the page
section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:55:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:55:59 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-mIC7DLmgjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32235


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235
[Bug 32235] Add page-section to list of staged files (acq)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:55:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:55:59 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-qwbymDK95O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32235


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235
[Bug 32235] Add page-section to list of staged files (acq)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:11 +0000
Subject: [Koha-bugs] [Bug 32235] Add page-section to list of staged files
 (acq)
In-Reply-To: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32235-70-Lb3dYE5MSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|/cgi-bin/koha/acqui/parcel. |/cgi-bin/koha/acqui/addorde
                   |pl?invoiceid=1              |riso2709.pl?booksellerid=1&
                   |                            |basketno=1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:30 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-SCqtxmES29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:32 +0000
Subject: [Koha-bugs] [Bug 32109] Toolbar containing text links lacks spacing
In-Reply-To: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32109-70-1fhr8omNOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32109

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:35 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-neX2dJgJpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:37 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-IrIS8XzPLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:40 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-D553ADeL2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:42 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-wfNHyKzqDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:45 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-T7YBCdNUCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 19:56:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 18:56:48 +0000
Subject: [Koha-bugs] [Bug 32172] Random biblionumber passed when clicking
 'Z3950 SRU/Search' from the search results in staff client
In-Reply-To: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32172-70-nRyuFD2U41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:02:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:02:02 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-JfjAFMiZqv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
I think I tested this correctly, but have a couple of comments:

1. Could we make an exception to the add/edit item form so that the width for
form labels is wider? In my view, making it narrow and then wrapping the text:
   - makes it harder to read/scan
   - makes the input field height longer
   - which makes the alignment for the tick boxes and RegEx links look "weird"
(Batch item modification form)
   - particularly when there is enough space on the page, even for smaller
screen widths

2. For the acquisition screens, I wasn't sure why on these that the dropdown
lists have a grey background.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:03:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:03:43 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-PopiLxltjb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The first tab looks great now, the third tab too, but I got some issues with
the item form:

https://snipboard.io/QHUtIW.jpg

The longer descriptions now blow up the input fields, this was not the case in
previous iterations.

In general I'd love if we could give labels more space in multiple locations.
We always need to add additional CSS there for German and I'd so love to get
rid of it. Also the problem seems prominent now also for the English templates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:03:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:03:58 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-hI5ovNtpG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Great minds think alike ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:04:42 +0000
Subject: [Koha-bugs] [Bug 31543] MaxComponentRecords link is broken
In-Reply-To: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31543-70-njxKwbuWKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31543

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
                 CC|                            |tomascohen at gmail.com
         Version(s)|                            |22.11
        released in|                            |

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:04:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:04:59 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-NDrPayAxWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:08:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:08:40 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-xVY8sJiVVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:08:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:08:44 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-IEHJdc9j6r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143945|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143967&action=edit
Bug 32214: Prevent empty search option block in catalog search header

In the header, if "Search catalog" is selected, there is an "option"
icon to display some filters.
Fitlers are displayed if IntranetCatalogSearchPulldown or
IntranetAddMastheadLibraryPulldown is set. If none are set we should
hide the icon to avoid and empty div to be displayed

Test plan:
Confirm that the icon is only displayed if one of the 2 prefs is turned
on.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:10:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:10:16 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-6hJ72LhIvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |katrin.fischer at bsz-bw.de
                   |.com                        |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Stealing this one from Martin...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:13:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:13:23 +0000
Subject: [Koha-bugs] [Bug 32236] New: Batch item modification - alignment of
 tick box for 'Use default values'
Message-ID: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

            Bug ID: 32236
           Summary: Batch item modification - alignment of tick box for
                    'Use default values'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

For the Cataloguing > Batch item modification form - 'Use default values'
section: the tick box is on the left instead of the right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:14:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:14:37 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-wlPzYmLEM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:14:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:14:40 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-uvpPn1MoxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
         Depends on|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:14:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:14:40 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-grgOwvF44A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32236


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236
[Bug 32236] Batch item modification - alignment of tick box for 'Use default
values'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:14:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:14:42 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-Y0U3ulCfbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143968&action=edit
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:17:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:17:27 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-ra7zMu0Han@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice one Katrin, thought I might get to this one today with one of the new team
but we didn't manage it so happy to see it stolen.. plenty more out there 😁

I'll get them to practice a signoff instead

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:30:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:30:06 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-yO73y0WtEk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:30:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:30:10 +0000
Subject: [Koha-bugs] [Bug 32214] Staff interface toolbar - no options when
 search catalog selected
In-Reply-To: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32214-70-6Mqj5hYcno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32214

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:35:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:35:43 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress to the yarn commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-KoWIDBepSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 20:35:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 19:35:47 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress to the yarn commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-Q4bEaui2hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143943|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 143969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143969&action=edit
Bug 32224: Add cypress to yarn commands

Either I am missing something obvious, or we need to add cypress to the scripts
of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I
cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see
https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905)
but I think both should work.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 21:44:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 20:44:32 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-Px2hBAl0eD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 31892 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 21:44:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 20:44:32 +0000
Subject: [Koha-bugs] [Bug 31892] Regression: return to
 /manage-marc-import.pl after importing batch
In-Reply-To: <bug-31892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31892-70-jlFb7ee1A0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31892

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe the patch on bug 31891 also fixes this.

*** This bug has been marked as a duplicate of bug 31891 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:32:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:32:03 +0000
Subject: [Koha-bugs] [Bug 28701] primary_contact_method not part of the REST
 API spec
In-Reply-To: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28701-70-imwTsyhudI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |alexis.ripetti at inLibro.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:32:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:32:42 +0000
Subject: [Koha-bugs] [Bug 28701] primary_contact_method not part of the REST
 API spec
In-Reply-To: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28701-70-OUthyKdosQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:32:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:32:46 +0000
Subject: [Koha-bugs] [Bug 28701] primary_contact_method not part of the REST
 API spec
In-Reply-To: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28701-70-QX2lxUkhLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136124|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143972&action=edit
Bug 28701 - Adding primary_contact_method to the REST API spec

This patch adds the primary_contact_method field to the api response for
patrons

To test:
1 - GET http://localhost:8081/api/v1/patrons/51
2 - Look for primary_contact_method, it's not there
3 - Apply patch
4 - GET http://localhost:8081/api/v1/patrons/51
5 - Look for primary_contact_method, it's not there

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:43:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:43:14 +0000
Subject: [Koha-bugs] [Bug 32237] New: Batch delete records "no record IDs
 defined"
Message-ID: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

            Bug ID: 32237
           Summary: Batch delete records "no record IDs defined"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: geraud.frappier at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

To test : 
1. Go to Lists in the intranet.
2. Add a list by clicking on "New list". Choose a random name for it and select
private or public and save.
3.Add one or more items into it and save.
4.Go back to the main page and select "Cataloging".
5.Go to "Batch record deletion".
6.In "upload a file" select "Select a list of records" and choose a list and
keep the Bibliographic on.
7.Select continue and see that the list of records is not shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:49:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:49:29 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-EFcWx5Y2PS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:51:37 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-a1OcUirODP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:51:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:51:42 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-T2N3WDYnD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143973&action=edit
Bug 32236: Fix alignment of checkbox "Use default values" for item batch
modification

This moves the label to the right in front of the checkbox.
It also shortens the label by adding an additional longer hint text.

To test:
* Go to cataloguing > item batch modification
* On the first page of the tool, look at the checkbox at the bottom
* Apply the patch
* Verify changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:52:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:52:39 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-cLp72CqHzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This solution has one disadvantage: It adds a new string. But I didn't like how
squashed the label looked in either position, forced on multiple lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 22:55:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 21:55:03 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-C2IrF3zQ1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:02:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:02:18 +0000
Subject: [Koha-bugs] [Bug 32221] password option should be removed from
 notice templates
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-ZdkgBMQGVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 143974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143974&action=edit
borrowers.password

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:02:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:02:49 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-bWE2nQbyZp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

geraud.frappier at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:02:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:02:52 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-F0nqD2JQzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

--- Comment #2 from geraud.frappier at inlibro.com ---
Created attachment 143975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143975&action=edit
Bug 32237 : Batch delete records "no record IDs defined". List of records not
shown.

To test patch carry out the same procedure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:03:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:03:00 +0000
Subject: [Koha-bugs] [Bug 32204] in-page anchor to edititem on additem.pl
 not working
In-Reply-To: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32204-70-C29S2RzGIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could the reason be the empty searchid param?

This doesn't work:
http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=126&itemnumber=263&searchid=#edititem

This does work (sometimes)
http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=126&itemnumber=263&searchid=5#edititem

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:03:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:03:21 +0000
Subject: [Koha-bugs] [Bug 32221] password option should be removed from
 notice templates
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-V1bjAnjVfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #1)
> Hi Christopher, do you mean the ability to add it using the list in the
> notice editor or do you mean one of the sample notices? The latter should
> have been done.

I mean the list (see attachment).  Doesn't make sense to have it there anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:05:11 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-QpXX14hMvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Geraud, please add a problem/solution description and the full test plans to
the commit messages. This might be helpful:
https://wiki.koha-community.org/wiki/Commit_messages

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:07:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:07:53 +0000
Subject: [Koha-bugs] [Bug 32221] password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-Q3PyJyijjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|password option should be   |password entry should be
                   |removed from notice         |removed from placeholder
                   |templates                   |list in notices editor

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for clarifying!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:09:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:09:27 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-zRk3CcqFwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #8 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #7)
> If it was only to be used on patron creation, I think we would not need to
> store it in the borrower record. Maybe a checkbox on the patron category
> administration page for "enforce new password on first login" and then we
> realize it by setting the first expiration date to 'immediately' when this
> is set and the patron is created.

What would constitute recognizing it as a patron creation?

I could see this feature being used anytime staff would have to reset a
password.  It might be better to have a rule set somewhere that could be
enabled to force a password change whenever an account is created or the
password is reset by staff.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:12:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:12:38 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-5TWOOeIqMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:12:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:12:42 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-DvJhHGBNeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143976&action=edit
Bug 32237: Fix using a list as base for batch record deletion

When a list was used to select records for batch deletion, the
record IDs were no longer found.

To test:

1. Go to Lists in the intranet.
2. Add a list by clicking on "New list". Choose a random name for it and select
private or public and save.
3.Add one or more items into it and save.
4.Go back to the main page and select "Cataloging".
5.Go to "Batch record deletion".
6.In "upload a file" select "Select a list of records" and choose a list and
keep the Bibliographic on.
7.Select continue and see that the list of records is not shown.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:13:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:13:31 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-INJ8eKNPRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #9 from Christopher Brannon <cbrannon at cdalibrary.org> ---
*** Bug 32219 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:15:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:15:11 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-Jqxd5Jx9nS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think my use case was 'first login' for a new user. We could then implement
it in the routine for adding a new patron.

But we could still do it with a button 'anytime' I think, just setting the
expiration date for the password into the past.

My thought were mostly about possibly not needing a field in the borrowers
table when we can look up the intended behavior for the patron category.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:15:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:15:49 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-3jqqugHEXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143975|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:20:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:20:03 +0000
Subject: [Koha-bugs] [Bug 32113] Missing table from batchMod.pl when coming
 from a bib record
In-Reply-To: <bug-32113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32113-70-4Jvtx9Wbkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Caroline,
I just tested on master, but this appears to work for me. Here is what I did:

* Found a record, I was using "The C programming language" from the sample
records
* From the detail page: Edit > Edit items in batch
* The table showed as expected.
* From the detail page: Select all > Modify selected items
* The table showed as expected.

Was this in a specific version or could there be another difference in testing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:23:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:23:59 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-hSFNZVkWNE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #11 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I'm wondering if this is necessary at all.  In rethinking another similar bug,
I realize that we can set new accounts with some random, unknown password, and
just rename the 'forgot password' link to something more encompassing. 
Because, in theory, you could have new patrons click on that link and reset the
password to something they know.  Right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:29:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:29:01 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-4yGcfd0vwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #12 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Sorry, I misspoke a bit. I didn't mean we'd put something in the borrower, but
rather the category. I said "Our existing value is
borrowers.password_expiry_days. The new value could be something like
borrowers.enrollment_password_expiry_days," but I really meant
categories.password_expiry_days.

It might be simpler to just have a setting to do/don't automatically expire
passwords created in the staff interface, but I still think that should be set
in categories rather than globally in a syspref.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:31:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:31:15 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-ITvMJsjoul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #13 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
(In reply to Christopher Brannon from comment #11)
> I'm wondering if this is necessary at all.  In rethinking another similar
> bug, I realize that we can set new accounts with some random, unknown
> password, and just rename the 'forgot password' link to something more
> encompassing.  Because, in theory, you could have new patrons click on that
> link and reset the password to something they know.  Right?

I've suggested this to libraries before and it works *ok,* you just tell all
patrons they can't log into the OPAC until they've done a password reset. But
it does require the patron to have an email address and to be comfortable with
the mild complexity of the password reset process. So this could for sure get
easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:37:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:37:19 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-pFEg05tpne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just noting that you don't need to set any password. The password reset doesn't
need an existing password. But I think there might be a use case for an initial
/temporary password too. Maybe a checkbox on the password reset form in staff
could be a nice idea? Could be pre-checked or not according to patron category
:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:38:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:38:01 +0000
Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page
In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32061-70-uLLIZFyrKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:38:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:38:14 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-ybLcgAfUcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:38:17 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-a333YejQnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143973|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 143977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143977&action=edit
Bug 32236: Fix alignment of checkbox "Use default values" for item batch
modification

This moves the label to the right in front of the checkbox.
It also shortens the label by adding an additional longer hint text.

To test:
* Go to cataloguing > item batch modification
* On the first page of the tool, look at the checkbox at the bottom
* Apply the patch
* Verify changes

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:44:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:44:38 +0000
Subject: [Koha-bugs] [Bug 32019] Add option to mark items returned in batch
 modification
In-Reply-To: <bug-32019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32019-70-iPhYBvg6kt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019

Michael Spagnuolo <mspagnuolo at nrhtx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mspagnuolo at nrhtx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:46:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:46:52 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-95upzLwHhB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #14)
> I think there might be a use case for
> an initial /temporary password too. Maybe a checkbox on the password reset
> form in staff could be a nice idea? Could be pre-checked or not according to
> patron category :)

Sounds good to me.

Keycloak has this feature. On the "Reset Password" screen, it has the following
prompts:

- Password
- Password Confirmation
- Temporary

Setting temporary passwords are handy when you need to reset someone's password
for them. 

--

We'd also need this on the "Add patron" screen. A lot of libraries like to set
up insecure default passwords for patrons, and it would be great to default
these to be "Temporary". This is where having an option at the patron category
level would be useful. 

--

Other than that... it could be good for the "Import patrons" tool to take a
"temporary_password" option as well, so that imported patrons need to reset
their passwords after first login too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:50:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:50:42 +0000
Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page
In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32061-70-1lDMTIIRMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:50:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:50:47 +0000
Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page
In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32061-70-yTYHXI7j6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143978&action=edit
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:59:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:59:09 +0000
Subject: [Koha-bugs] [Bug 32015] Cannot search for basket creator in
 advanced order search
In-Reply-To: <bug-32015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32015-70-lki6VuyYcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32015

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Stefan, I believe this was fixed by bug 31782 now.

*** This bug has been marked as a duplicate of bug 31782 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 16 23:59:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 22:59:09 +0000
Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using
 js/autocomplete/patrons.js
In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31782-70-GqmZ6ajXWJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan.berndtsson at ub.gu.se

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 32015 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:00:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:00:35 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-lsYFGngTWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #16 from Christopher Brannon <cbrannon at cdalibrary.org> ---
So, maybe we direct first time users to the link (reworded or not) and they set
their password.

For patrons that don't have an e-mail, we have a set/reset option that
generates a temporary password, and prints a slip that directs them to a page
where they type in their library card number (not printed on the slip), and
they use that password.  Then it prompts them to reset the password.  The slip
doesn't have to be printed for over-the-phone resets.  We just direct them to
the page and give them the password over the phone.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:04:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:04:31 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-3ep3tCEOqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143979&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:05:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:05:28 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-GbYH13IkoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:05:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:05:33 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-S4gC3VoQ69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142712|0                           |1
        is obsolete|                            |
 Attachment #143979|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143980&action=edit
Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition

The condition is fine as long as we only have GDPR consents.
But if you dont, you would have trouble. I know :)
Lets prevent that here, although the table still has an ENUM. So
double safety.

Test plan:
Run t/db_dependent/Koha/Patrons.t
Bonus: Run cleanup_database.pl and check for unusual number of
locked accounts:
     misc/cronjobs/cleanup_database.pl --confirm -v --sessions

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:07:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:07:24 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view
 (open/closed)
In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22773-70-VfJkk3oQeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

--- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Mirjam Vantieghem from comment #57)
> (In reply to Jonathan Druart from comment #44)
> > We would have certainly saved time, lines of code, readability and
> > maintainability with only one table and correct filters.
> > 
> > [un]select all links are missing, not considering blocker however.
> 
> We are very happy with this enhancement!
> It would be even greater if there would be "(un)select all" links.
> Not sure if I have to file a new bug for this?

Hi Mirjam, once a feature/bug has been published in a release, we always need a
new bug for any fixes or further improvements. Please file one! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:10:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:10:35 +0000
Subject: [Koha-bugs] [Bug 31608] ShowComponentRecords doesn't display
 components if UseControlNumber is turned on
In-Reply-To: <bug-31608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31608-70-lbd2UxJUW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31608

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Caroline, do you still happen to know were you were testing? If it was an
updated installation, the cnr index might have been missing as it's not added
on update for Elasticsearch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:15:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:15:52 +0000
Subject: [Koha-bugs] [Bug 32238] New: Add page-section to list of items in
 label batch (tools)
Message-ID: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

            Bug ID: 32238
           Summary: Add page-section to list of items in label batch
                    (tools)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/labels/label-edit-batch.pl?op=add&number
                    _type=itemnumber&number_list=18
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

When printing a batch in the label creator, the list of items is missing the
page section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:15:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:15:52 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-FBG8Oj5jjb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32238


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238
[Bug 32238] Add page-section to list of items in label batch (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:15:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:15:52 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-Cb79iAPcK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32238


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238
[Bug 32238] Add page-section to list of items in label batch (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:18:00 +0000
Subject: [Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.
In-Reply-To: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31241-70-C2QpV0a8gj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I just tested on master and could print labels with different layouts without
problems, selected and full batch. I think we will definitely need more
information on the configuration. In the label module often a specific setting
can cause an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:23:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:23:31 +0000
Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is <
 10000 and fails in various places
In-Reply-To: <bug-27365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27365-70-MYcq6AG37b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just a note here: the normal cataloguing editor does enforce a length, the
input field shave maxsize = 9999 set (at least in MARC21). Is this different
for UNIMARC? But if you import using staged import it's probably just being
added as is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:26:44 +0000
Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is <
 10000 and fails in various places
In-Reply-To: <bug-27365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27365-70-K788tvQoOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Eric Phetteplace from comment #18)
> Created attachment 142786 [details]
> example MARC record
> 
> (In reply to David Cook from comment #16)
> > (In reply to Blou from comment #15)
> > > We have the problem in searches (opac/staff).  ES indexes without any
> > > problem.  I see the data returned when turning on trace_to in koha-conf.xml.
> > > 
> > > But somewhere in Koha or MARC library, something breaks.  The records with a
> > > 505$a longer than 9999 characters are not displayed correctly in the results.
> > > 
> > > Actually, NO data shows up.  But there's an empty entry in the results.  The
> > > other records are listed without problem.
> > > 
> > > Considering that the xslt for the results never infer to 505 the slightest,
> > > it seems to me its the marcxml that breaks down.  Somewhere, somehow.
> > 
> > Are you able to reliably reproduce that problem? If so, attach a copy of
> > that record here with the steps needed to reproduce it. Someone might be
> > able to take it somewhere then. 
> > 
> > Long ago, I locally customized the Zebra indexing to only index 5000
> > characters for the notes fields, as I think that 9999+ notes fields were
> > causing us problems, but I think the original record would still be
> > retrieved and used in Koha. Since you're using ES, that's probably not
> > relevant.
> > 
> > Sounds like more investigation is needed, but also sounds like an edgecase,
> > so perhaps more of a support issue...
> 
> We're able to recreate this bug with the attached record. If you search for
> it on the staff side, a broken search result appears with the cover image in
> the left-side column and the list of action links (hold, add to cart,
> etc...) in the second column, no metadata. The public search results show an
> analogous problem. To fix it, we split the long 505 field in two; that
> record works fine.
> 
> We're on Elasticsearch. I tried retrieving the record with the API as well
> as going to its detail views pages on the public and staff sides; all of
> those are OK. So the problem is specific to search results. I did not test
> on Zebra.

Not sure if this is good or bad news, but I imported the attached record into
my  dev installation without problem. The record is searchable and display on
detail page and in result list looks ok too. (Maybe something changed since
this was filed initially?)

If someone could confirm, we might be able to close this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:29:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:29:05 +0000
Subject: [Koha-bugs] [Bug 31639] While receiving items through acquisitions
 and adding barcode error of "No such Column"
In-Reply-To: <bug-31639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31639-70-dJosOOHFOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31639

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sunita, does this error persist? 
If so, what is your UniqueItemFields  system preference set to?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:29:45 +0000
Subject: [Koha-bugs] [Bug 31640] Fuzzy translations of preferences can cause
 missing sections and inaccurate translations
In-Reply-To: <bug-31640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31640-70-dXYlUtSLsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:35:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:35:42 +0000
Subject: [Koha-bugs] [Bug 27901] Cancelling acq order does not delete item
 record, causes error
In-Reply-To: <bug-27901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27901-70-XqwbcwVbFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27901

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There has been no feedback on the questions asked for over a year. I am closing
this WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:37:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:37:40 +0000
Subject: [Koha-bugs] [Bug 20200] Show MARC 770 Supplement/Special Issue
 Entry on detail pages
In-Reply-To: <bug-20200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20200-70-lYqkkB3fmK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Eugene Espinoza from comment #3)
> I checked on current iteration of Koha ILS, it seems this has been
> addressed. Katrin, can this be confirmed?

Yes, i can confirm :)

*** This bug has been marked as a duplicate of bug 15141 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:37:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:37:40 +0000
Subject: [Koha-bugs] [Bug 15141] Add MARC21 770/772 to OPAC and staff detail
 pages
In-Reply-To: <bug-15141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15141-70-NI4lL4goFk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15141

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 20200 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:40:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:40:11 +0000
Subject: [Koha-bugs] [Bug 31568] Renaming/removing an authorised value does
 not cascade to linked tables
In-Reply-To: <bug-31568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31568-70-472v0RrRno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31568

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In theory I guess we could look up via the frameworks if a authorised value is
used and then offer to update the items or at least display a warning.

Fixing this in general for all types of AV would probably turn out a bit
nightmarish.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:45:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:45:06 +0000
Subject: [Koha-bugs] [Bug 29198] Inconsistencies in OPAC results display vs
 staff results display
In-Reply-To: <bug-29198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29198-70-9XXw96AsVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inconsistencies in opac     |Inconsistencies in OPAC
                   |results display vs staff    |results display vs staff
                   |results display             |results display

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:46:38 +0000
Subject: [Koha-bugs] [Bug 31450] HTML customizations and News will not
 display on OPAC without Publication date
In-Reply-To: <bug-31450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31450-70-BthznJm5OC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31450

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Paul, could you please check the patch? It only seems to be removing some
debug lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:50:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:50:02 +0000
Subject: [Koha-bugs] [Bug 31454] Ability to update multiple subscriptions at
 once
In-Reply-To: <bug-31454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31454-70-xNOMtSVT82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31454

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sarah, thx for explaining and sorry for the late reply. Do you think this
could qualify as a duplicate for bug 17656 then? (or maybe be covered by
31230?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:54:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:54:01 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-Y8nSYiRvF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
(In reply to Christopher Brannon from comment #16)
> So, maybe we direct first time users to the link (reworded or not) and they
> set their password.
> 
> For patrons that don't have an e-mail, we have a set/reset option that
> generates a temporary password, and prints a slip that directs them to a
> page where they type in their library card number (not printed on the slip),
> and they use that password.  Then it prompts them to reset the password. 
> The slip doesn't have to be printed for over-the-phone resets.  We just
> direct them to the page and give them the password over the phone.

With other systems in a public library context, usually a new user will be told
"your password is the last 4 digits of your phone number" or something like
that, and then when you log into the OPAC with that password, it prompts you to
reset your password.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 00:59:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Nov 2022 23:59:28 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-CQQtuvkOVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #17)
> (In reply to Christopher Brannon from comment #16)
> > So, maybe we direct first time users to the link (reworded or not) and they
> > set their password.
> > 
> > For patrons that don't have an e-mail, we have a set/reset option that
> > generates a temporary password, and prints a slip that directs them to a
> > page where they type in their library card number (not printed on the slip),
> > and they use that password.  Then it prompts them to reset the password. 
> > The slip doesn't have to be printed for over-the-phone resets.  We just
> > direct them to the page and give them the password over the phone.
> 
> With other systems in a public library context, usually a new user will be
> told "your password is the last 4 digits of your phone number" or something
> like that, and then when you log into the OPAC with that password, it
> prompts you to reset your password.

This doesn't feel like a good practice because it would encourage insecure
passwords and there is no guarantee the user will log in and change it anytime
soon?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:03:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:03:30 +0000
Subject: [Koha-bugs] [Bug 31438] Currency can't have "spaces" in currency
 name
In-Reply-To: <bug-31438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31438-70-g2GWas5lbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31438

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think maybe we should fix the behavior instead. 

It looks like something with the JavaScript on this page is going wrong.

When you modify an existing order and change the currency to one with a space,
the form shows a lot of NaN instead of the calculated values.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:05:13 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-CfFgHRGDfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #18)
> This doesn't feel like a good practice because it would encourage insecure
> passwords and there is no guarantee the user will log in and change it
> anytime soon?

Koha already gives libraries the ability to do this anyway, so the "temporary
password" option would at least add a layer of protection over top of their
existing insecure practice.

(I've actually been thinking more lately about implementing system restrictions
so that even superlibrarians can't create insecure Koha configurations.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:09:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:09:03 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-pnY6XruAky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Karen Venturella from comment #5)
> I was told "There isn't a way to unreceive them in order to receive them in
> FY22."
> Perhaps you can reach out to Sara Brown to describe the problem.
> 
> I want to receive 3 print copies of MLA handbook in FY22 and I had entered
> the order in FY2021.
> Is it possible to enter new order and mark FY21 order as cancelled?
> 
> Karen

Hi Karen, sorry for the late reply!

When you receive an order created in FY21 in FY22, you can change the fund
during the receive process.

You can also, once the FY21 is over, close the budget and move all open orders
to FY22 automatically. 

So in theory, it should not be necessary to cancel and reenter. But if you want
to cancel the order, the easiest way is to do it from the receive screen
(Receive Shipment > Fake invoice number or reuse existing > use the cancel
links in list)

Does this help? If not, could you rephrase the problem maybe a bit? I am not
sure I get the full picture.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:11:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:11:32 +0000
Subject: [Koha-bugs] [Bug 29398] Importing Authority Records without
 Renumbering
In-Reply-To: <bug-29398-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29398-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29398-70-A3BpcVdx1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29398

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like that too as an option, although I believe there was a reason we did
enforce 001 = auth_id from auth_header table. This means enforcing is not so
easy as you'd also have to ensure that the records get imported with an
enforced record id in Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:21:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:21:13 +0000
Subject: [Koha-bugs] [Bug 32239] New: Report options for adding groups/sub
 groups are misaligned
Message-ID: <bug-32239-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32239

            Bug ID: 32239
           Summary: Report options for adding groups/sub groups are
                    misaligned
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952

When adding a new SQL report, the options for adding/creating groups and sub
groups are misaligned: 

https://snipboard.io/Nfpu0d.jpg

There is a lot of space between the label and the pull down that belongs to it.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:21:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:21:13 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-q3ASRSElmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32239


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32239
[Bug 32239] Report options for adding groups/sub groups are misaligned
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:21:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:21:26 +0000
Subject: [Koha-bugs] [Bug 28701] primary_contact_method not part of the REST
 API spec
In-Reply-To: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28701-70-AXTWdPqfk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I think it should be an enum

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:24:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:24:16 +0000
Subject: [Koha-bugs] [Bug 31301] Upgrade to 21.11.05.004 [13:28:59]: ERROR:
 {UNKNOWN}: Can't use an undefined value as a subroutine reference at
 /usr/share/koha/lib/C4/Installer.pm line 737. at
 /usr/share/koha/lib/C4/Installer.pm line 739
In-Reply-To: <bug-31301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31301-70-VPxuMwX1DT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31301

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 30899 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:24:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:24:16 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-tXQszrecC1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |syamsivanmail at gmail.com

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 31301 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:26:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:26:04 +0000
Subject: [Koha-bugs] [Bug 30332] Outbound SRU does not work via https
In-Reply-To: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30332-70-bLVLjjxdZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #18)
> Are folk happy to close this one now? 
> 
> See
> https://wiki.koha-community.org/wiki/
> System_requirements_and_recommendations#Zebra

I'd say so :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:28:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:28:14 +0000
Subject: [Koha-bugs] [Bug 8634] Style should be user-selectable
In-Reply-To: <bug-8634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8634-70-qk78NaPdrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8634

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'll mark this duplicate with the more recent discussion on adding a dark theme
or similar on bug 31327.

*** This bug has been marked as a duplicate of bug 31327 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:28:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:28:14 +0000
Subject: [Koha-bugs] [Bug 31327] Can we add color scheme picker to the
 OPAC.. especially a 'dark mode'?
In-Reply-To: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31327-70-5VcIOTu1yr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcamins at cpbibliography.com

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 8634 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:31:17 +0000
Subject: [Koha-bugs] [Bug 32063] Streamline importing of records
In-Reply-To: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32063-70-WhBgiDUJj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Caroline, I think the new'ish progress bar and this bug might help with that
a little: 
Bug 31891 - Regression: show "MARC staging results" with clear link to manage
staged batch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:31:37 +0000
Subject: [Koha-bugs] [Bug 32063] Streamline importing of records
In-Reply-To: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32063-70-S8K7npmq9N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31891

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:31:37 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-OP4UDeB4Xh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32063

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:32:23 +0000
Subject: [Koha-bugs] [Bug 31159] Can we make sidebar navigation collapsable?
In-Reply-To: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31159-70-jO5opnzJ6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:32:23 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-l6M1soW0Jo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31159


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159
[Bug 31159] Can we make sidebar navigation collapsable?
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:35:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:35:15 +0000
Subject: [Koha-bugs] [Bug 30293] ODS report download inserts apostrophe in
 front of numerical results
In-Reply-To: <bug-30293-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30293-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30293-70-UcATC2Y4sF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30293

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed in master. My test report was 'select * from aqorders', because acq
has a lot of numerical values.
I am not sure how this can be solved - we'd probably send/set a datatype
somehow?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:38:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:38:03 +0000
Subject: [Koha-bugs] [Bug 23757] Able to delete patron expiration date
In-Reply-To: <bug-23757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23757-70-Fbs2DXVGpQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27920

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #3)
> +1, yes please, we would like Koha to auto-calculate new expiration dates
> when clearing existing dates via batch patron modification.

Maybe a workaround could be bug 27920

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:38:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:38:03 +0000
Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration
 dates when importing patrons
In-Reply-To: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27920-70-uUY4q1giHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23757

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 01:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 00:52:46 +0000
Subject: [Koha-bugs] [Bug 31327] Can we add color scheme picker to the
 OPAC.. especially a 'dark mode'?
In-Reply-To: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31327-70-w9GF6hC5xV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
I don't know the best way to do this from the CSS point of view for Koha
(especially with the new staff interface), but I have some thoughts from the
system point of view.

Do we want dark mode to be available to all users or only authenticated users?

I think apps like Github only allow you to customize the app's appearance if
you're logged in. Then you can go to an "Appearance" option in your account to
choose "dark mode".

If it's only for authenticated users, we could save that option, and present
that through something like the "userenv". 

In the templates, I imagine that we'd probably set a class or attribute at a
high level. (Looking at Github, it seems that the "data-color-mode" attribute
on the "html" root element lets them toggle between "dark" and "light".
Obviously there's more that goes into it than that, but that's the initial
hook.)

--

The problem with a "dark" mode is that we already allow so much customization
to Koha, so I wonder how many libraries would be able to actually customize and
test a "light" and "dark" mode. We'd definitely want system preferences to
control this feature. 

But it would be a great feature to have out of the box.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:27:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:27:25 +0000
Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints
In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5334-70-s88thINT8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
Bug 5334 depends on bug 25731, which changed state.

Bug 25731 Summary: The table authorised_values_branches should have foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25731

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:27:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:27:24 +0000
Subject: [Koha-bugs] [Bug 25731] The table authorised_values_branches should
 have foreign key constraints
In-Reply-To: <bug-25731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25731-70-IaDKgcDtPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25731

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:29:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:29:32 +0000
Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on
 the way?
In-Reply-To: <bug-29390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29390-70-cyk50kHpMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #6)
> Coming back here soon.

Still interested in working on this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:31:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:31:24 +0000
Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on
 the way?
In-Reply-To: <bug-29390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29390-70-InBibcV0JR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > Coming back here soon.
> 
> Still interested in working on this?

Yes. Sorry, it dropped a bit on my list. But it is still there ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:32:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:32:25 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-XijW0f6yCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #6)
> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Great. Thx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:34:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:34:59 +0000
Subject: [Koha-bugs] [Bug 32063] Streamline importing of records
In-Reply-To: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32063-70-88YkIWcgiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32063

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Please let me know if you think we can still improve it!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:39:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:39:41 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-nM0qw8Ebjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #70 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
We are using a cookie when localStorage should be used, see bug 12410.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:45:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:45:16 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-4ccBNMki8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #71 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #69)
> (In reply to Marcel de Rooy from comment #66)
> > encode_json Converts the given Perl data structure to a UTF-8 encoded,
> > binary string.
> > to_json Converts the given Perl data structure to a Unicode string by
> > default. 
> 
> "
> This module also exports to_json and from_json for backward compatibility.
> These are slower
> "

It's not working, so it's wrong.

[2022/11/17 06:44:05] [WARN] The job has not been sent to the message broker:
(Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl-base/IO/Handle.pm
line 200.

To recreate, see bug 31351

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:45:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:45:26 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-GWkvYt4pRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:46:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:46:58 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-o4OpCas71f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #72 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #68)
> The docs and you say the same: decode_json expects to be passed a string
> with Perl's internal format representing UTF-8 characters. And that's what
> encode_utf8 does, and why the patch introduces it at that exact place. 

Perl internal format is certainly not UTF-8. Perhaps you are saying that here,
but you could well mean something else too.. Not sure what you mean. But it is
clear to me that we should not use decode_json here.

> You can't fail what is correct :-P
That is true. But this is absolutely not correct ;)

> The cool thing is that you can propose some other solution. But I'd vote
> against something that adds more steps to the caller.
If the right thing would take one more step, you should just take it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:47:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:47:44 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-PPcpQt90EP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #73 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The correct pattern is in BackgroundJob:

sub decoded_data {
    my ($self) = @_;

    return $self->data ? $self->json->decode( $self->data ) : undef;
}

sub set_encoded_data {
    my ( $self, $data ) = @_;

    return $self->data( $data ? $self->json->encode($data) : undef );
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:48:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:48:17 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-UXtI1uLvH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #74 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #69)
> This module also exports to_json and from_json for backward compatibility.
> These are slower

Thats true. We should switch to OO interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:49:36 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-3BvB8chhyd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #75 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From Backgrount too

sub json {
    my ( $self ) = @_;
    $self->{_json} //= JSON->new->utf8(0); # TODO Should we allow_nonref ?
    return $self->{_json};
}

I remember that you were objecting against it too. But it is the right
approach. Do not set utf8, but keep everything in Perl internal format in the
middle of the process..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:56:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:56:35 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-g10pGkzTZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 07:56:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 06:56:40 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-5jVTTAzpVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143925|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143981&action=edit
Bug 32212: (bug 32030 follow-up) Restore bootstrap 4

During the development of the eRM module I've tried to use bootstrap 5
(and vue-bootstrap), but I didn't manage to make it work without
modifying the version used in Koha. This change is actually not needed
and we can keep version 4.
See commit 8c32f186d5a62e742621c35cfacff5b22bb42b71
Bug 32030: ERM - Remove BootstrapVue3

Test plan:
% yarn install
% git diff
you should notice the version change in yarn.lock

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:03:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:03:52 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-H8PaY21ZSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #76 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #71)
> [2022/11/17 06:44:05] [WARN] The job has not been sent to the message
> broker: (Wide character in syswrite at
> /usr/lib/x86_64-linux-gnu/perl-base/IO/Handle.pm line 200.
> 
> To recreate, see bug 31351

Bug 31351 has been pushed.
How do you recreate the problem? And explain the connection to this report
please. This is different code?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:04:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:04:54 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-OAyqzGGPhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:05:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:05:00 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-K7BvafGMZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143980|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143982&action=edit
Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition

The condition is fine as long as we only have GDPR consents.
But if you dont, you would have trouble. I know :)
Lets prevent that here, although the table still has an ENUM. So
double safety.

Test plan:
Run t/db_dependent/Koha/Patrons.t
Bonus: Run cleanup_database.pl and check for unusual number of
locked accounts:
     misc/cronjobs/cleanup_database.pl --confirm -v --sessions

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:05:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:05:25 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-4biV30rWwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |21336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336
[Bug 21336] GDPR: Handle unsubscribe requests automatically by optional
(administrative) lock, anonymize and remove
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:05:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:05:25 +0000
Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests
 automatically by optional (administrative) lock, anonymize and remove
In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21336-70-JfjiuVFskI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937
[Bug 31937] Prevent cleanup_database.pl from locking too many accounts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:40:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:40:41 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-XFhW1lUJt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #77 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #76)
> (In reply to Jonathan Druart from comment #71)
> > [2022/11/17 06:44:05] [WARN] The job has not been sent to the message
> > broker: (Wide character in syswrite at
> > /usr/lib/x86_64-linux-gnu/perl-base/IO/Handle.pm line 200.
> > 
> > To recreate, see bug 31351
> 
> Bug 31351 has been pushed.
> How do you recreate the problem? And explain the connection to this report
> please. This is different code?

Different code? The first patch is replacing encode_json calls with encode, and
remove the utf8 encoding :)

To recreate, batch mod items, add ❤ in the note, submit the job, go to the job
detail => it fails
go to the koha logs => see the "Wide char" error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:45:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:45:07 +0000
Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in
 templates
In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32127-70-cF2ngqyNdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Indeed.

I've tried to add in t/db_dependent/Template/Plugin/Categories.t.
But I don't know how to manage the existing categories.

Any help is welcome :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:50:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:50:22 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-SosbMH2mnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add cypress to the yarn     |Add cypress and prettier to
                   |commands                    |the yarn commands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:50:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:50:52 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-o5KAIp0PkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Looks like we need prettier as well

xt/vue_tidy.t is failing with:
  error Command "prettier" not found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:54:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:54:21 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-epTmYquHZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143983&action=edit
Bug 32224: Add prettier to yarn commands

xt/vue_tidy.t was failing with:
  error Command "prettier" not found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 08:59:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 07:59:07 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-mN5fa6mXPx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #78 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #77)
> (In reply to Marcel de Rooy from comment #76)
> > (In reply to Jonathan Druart from comment #71)
> > > [2022/11/17 06:44:05] [WARN] The job has not been sent to the message
> > > broker: (Wide character in syswrite at
> > > /usr/lib/x86_64-linux-gnu/perl-base/IO/Handle.pm line 200.
> > > 
> > > To recreate, see bug 31351
> > 
> > Bug 31351 has been pushed.
> > How do you recreate the problem? And explain the connection to this report
> > please. This is different code?
> 
> Different code? The first patch is replacing encode_json calls with encode,
> and remove the utf8 encoding :)
> 
> To recreate, batch mod items, add ❤ in the note, submit the job, go to the
> job detail => it fails
> go to the koha logs => see the "Wide char" error

Okay. You actually mean that Tomas is right.
I am on it today. Please wait a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:28:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:28:33 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-c3szHoRoOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
             Status|NEW                         |ASSIGNED
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24669

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Related to bug 24669, why didn't we use strip_non_numeric for one occurrence?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:28:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:28:33 +0000
Subject: [Koha-bugs] [Bug 24669] Editing circulation rule breaks holds when
 total holds unlimited
In-Reply-To: <bug-24669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24669-70-wwZwagekmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24669

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30794

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:30:44 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-DxKRn04tO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:30:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:30:50 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-2VXvWKkNUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143984&action=edit
Bug 30794: Insert blank rule (unlimited) for max_holds

Related to bug 24669, why didn't we use strip_non_numeric for one occurrence?

Note that there is still a problem, if none of the 3 inputs is filled,
no rule will be created (ie. action ignored)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:31:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:31:11 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-Be5ZD0W6jx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Could you test this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:31:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:31:56 +0000
Subject: [Koha-bugs] [Bug 32191] Consistent upgrade messages
In-Reply-To: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32191-70-7mHhtRxW35@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32191

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Just to say, I love this consistency improvement.. another little polishing
touch that makes Koha look all the more professional :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:41:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:41:16 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-cB3rw0qqMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |geraud.frappier at inlibro.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:42:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:42:26 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-P6wt4mVXSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:51:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:51:39 +0000
Subject: [Koha-bugs] [Bug 32240] New: api/erm_users.t fails if checkouts
 exist
Message-ID: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

            Bug ID: 32240
           Summary: api/erm_users.t fails if checkouts exist
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Cannot delete or update a parent row: a foreign key constraint
fails (`koha_kohadev`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE)
at /kohadevbox/koha/Koha/Object.pm line 234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:51:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:51:39 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-CyQE7x5B6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32240


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240
[Bug 32240] api/erm_users.t fails if checkouts exist
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:53:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:53:27 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-lHVWgiUUIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:53:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:53:32 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-ea5bOxnObj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143985&action=edit
Bug 32240: Prevent erm_users.t to fail if checkout exist

We should not (never) remove all patrons before tests

Test plan:
0. Don't apply the patch
1. Check an item out
2. Run the tests
=> Fail
3. Apply the patch
4. Create a patron with the erm permission
5. Run the tests
=> Must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:53:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:53:59 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-46oPZ1mgcD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 09:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 08:59:38 +0000
Subject: [Koha-bugs] [Bug 23962] We should drop support for Debian 8 Jessie
 and Debian 9 Stretch
In-Reply-To: <bug-23962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23962-70-8U1Zz5TO4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
From
https://wiki.koha-community.org/wiki/System_requirements_and_recommendations it
looks like we did drop Debian 8/9 support. Please reopen if I am missing
something!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:01:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:01:46 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-96BfPEZrCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #79 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
For the record, my comments didn't make sense. I hadn't noticed that Tomas was
not modifying Koha::BackgroundJob.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:10:33 +0000
Subject: [Koha-bugs] [Bug 32241] New: Add page-section to list of records in
 batch record modificaton (tool)
Message-ID: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

            Bug ID: 32241
           Summary: Add page-section to list of records in batch record
                    modificaton (tool)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/tools/batch_record_modification.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

When batch editing records, the list of records still needs the page
sectioning.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:10:33 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-xu986KiPQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32241


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241
[Bug 32241] Add page-section to list of records in batch record modificaton
(tool)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:10:33 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-30669SWnv8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32241


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241
[Bug 32241] Add page-section to list of records in batch record modificaton
(tool)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:13:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:13:24 +0000
Subject: [Koha-bugs] [Bug 32160] Batch record modification - show MARC
 preview no longer works
In-Reply-To: <bug-32160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32160-70-C4hmtGXtHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32160

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks to me like the problem might be that we are trying to use the
templates on the record we view there (preview of changes) and that this
failes.

My action was a simple "delete field xxx"

Can't call method "field" on an undefined value at
/kohadevbox/koha/Koha/SimpleMARC.pm line 534
        Koha::SimpleMARC::_delete_field('HASH(0x560470731670)') called at
/kohadevbox/koha/Koha/SimpleMARC.pm line 522
        Koha::SimpleMARC::delete_field('HASH(0x56046fff90a8)') called at
/kohadevbox/koha/C4/MarcModificationTemplates.pm line 630
        C4::MarcModificationTemplates::ModifyRecordWithTemplate(1, undef)
called at /kohadevbox/koha/svc/records/preview line 53
        eval {...} at /kohadevbox/koha/svc/records/preview line 2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:15:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:15:18 +0000
Subject: [Koha-bugs] [Bug 32100] "edit search" feature quote-wraps search
 terms if original search had no results
In-Reply-To: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32100-70-Zs6odiaeOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31213


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213
[Bug 31213] When performing a basic search with no results, repeat the search
with term quoted
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:15:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:15:18 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-zgrhP8yx2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32100


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100
[Bug 32100] "edit search" feature quote-wraps search terms if original search
had no results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:15:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:15:34 +0000
Subject: [Koha-bugs] [Bug 32100] "edit search" feature quote-wraps search
 terms if original search had no results
In-Reply-To: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32100-70-j2qpBhJC7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|31271                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271
[Bug 31271] "Edit search" always resets search options to keyword
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:15:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:15:34 +0000
Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options
 to keyword
In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31271-70-9MFkBr9ecl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32100                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100
[Bug 32100] "edit search" feature quote-wraps search terms if original search
had no results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:16:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:16:10 +0000
Subject: [Koha-bugs] [Bug 32100] "edit search" feature quote-wraps search
 terms if original search had no results
In-Reply-To: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32100-70-JDrrLZI5BW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe the new behaviour introduced by bug 31213 is possibly involved here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:21:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:21:42 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-bc2DbeCGGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #80 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #78)
> (In reply to Jonathan Druart from comment #77)
> > (In reply to Marcel de Rooy from comment #76)
> > > (In reply to Jonathan Druart from comment #71)
> > > > [2022/11/17 06:44:05] [WARN] The job has not been sent to the message
> > > > broker: (Wide character in syswrite at
> > > > /usr/lib/x86_64-linux-gnu/perl-base/IO/Handle.pm line 200.
> > > > 
> > > > To recreate, see bug 31351
> > > 
> > > Bug 31351 has been pushed.
> > > How do you recreate the problem? And explain the connection to this report
> > > please. This is different code?
> > 
> > Different code? The first patch is replacing encode_json calls with encode,
> > and remove the utf8 encoding :)
> > 
> > To recreate, batch mod items, add ❤ in the note, submit the job, go to the
> > job detail => it fails
> > go to the koha logs => see the "Wide char" error
> 
> Okay. You actually mean that Tomas is right.
> I am on it today. Please wait a bit.

We complicated this discussion a bit by mixing two separate issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:25:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:25:25 +0000
Subject: [Koha-bugs] [Bug 32242] New: The job has not been sent to the
 message broker: (Wide character in syswrite ... )
Message-ID: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

            Bug ID: 32242
           Summary: The job has not been sent to the message broker: (Wide
                    character in syswrite ... )
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

The full version:

[2022/11/17 08:51:39] [WARN] The job has not been sent to the message broker:
(Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl-base/IO/Handle.pm
line 200.) at /usr/share/koha/Koha/BackgroundJob.pm line 147.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:26:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:26:01 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-qPuMo1rXjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
[Bug 31351] Worker dies on reindex job when operator last name/first
name/branch name contains non-ASCII chars
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:26:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:26:01 +0000
Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator
 last name/first name/branch name contains non-ASCII chars
In-Reply-To: <bug-31351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31351-70-4KjF5RBbXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242
[Bug 32242] The job has not been sent to the message broker: (Wide character in
syswrite ... )
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:26:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:26:20 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect
 default value used and warning message on order form
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-I0zincb6Ng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Either the pref or the behavior is certainly wrong! Confirmed on current master
that the last value of taxrate is selected instead of the first as documented.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:26:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:26:29 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-fcRbI70DgP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #81 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Opened bug 32242 for the Background issue now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:27:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:27:07 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-lHeDapCTms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I think we should encode via Net::Stomp but I will first add a quick fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:34:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:34:08 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-VK7AyWW46w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:34:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:34:12 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-WRXTI6AXPb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143986&action=edit
Bug 32242: Resolve encoding issue when sending to Net::Stomp

This is meant as a quick fix. It should be enhanced later on by
letting Net::Stomp do the UTF8 conversion.

Test plan:
Run batch mod items. Add a Unicode char in the notes.
Check if job runs and results are correct.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:34:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:34:39 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-FvnFAnatGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:34:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:34:59 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-s0PJyGiAWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:36:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:36:40 +0000
Subject: [Koha-bugs] [Bug 32243] New: BackgroundJob: Leave encoding to
 Net::Stomp
Message-ID: <bug-32243-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32243

            Bug ID: 32243
           Summary: BackgroundJob: Leave encoding to Net::Stomp
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Question: Should we actually use Net::Stomp::Client ?

Further info:
If $Net::STOMP::Client::Frame::UTF8Header is true, the module will use UTF-8 to
encode/decode the header part of the frame.
If $Net::STOMP::Client::Frame::UTF8Body is true, the module will:
[etc]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:36:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:36:54 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-uRFJcuZs2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32243

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:36:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:36:54 +0000
Subject: [Koha-bugs] [Bug 32243] BackgroundJob: Leave encoding to Net::Stomp
In-Reply-To: <bug-32243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32243-70-6Hd2BW2qE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32243

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32242

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:38:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:38:53 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-T2bf7faI24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
FYI Tomas: The json to UTF8 conversion was handled correctly at the database
layer but this bug is about sending json to RabbitMQ. That conversion is not
handled properly (yet). See also bug 32243.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:39:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:39:49 +0000
Subject: [Koha-bugs] [Bug 31618] Typo in POD for
 C4::ImportBatch::RecordsFromMARCXMLFile
In-Reply-To: <bug-31618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31618-70-0tjGxYACX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31618

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:41:09 +0000
Subject: [Koha-bugs] [Bug 32243] BackgroundJob: Leave encoding to Net::Stomp
In-Reply-To: <bug-32243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32243-70-8LxeHNP5pJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32243

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au,
                   |                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:42:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:42:26 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-mXjODr80CH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #82 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Tomás: I will add a patch here for your consideration now. (By way of exception
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:45:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:45:14 +0000
Subject: [Koha-bugs] [Bug 31337] Lack of notes field for all methods of
 paying fines
In-Reply-To: <bug-31337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31337-70-wRq0GEvSSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31337

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23674

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:45:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:45:14 +0000
Subject: [Koha-bugs] [Bug 23674] Allowing editable notes on all entries in
 patron Transactions table
In-Reply-To: <bug-23674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23674-70-amUIWligER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31337

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:49:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:49:54 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-GZv44EzvPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143986|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143987&action=edit
Bug 32242: Resolve encoding issue when sending to Net::Stomp

This is meant as a quick fix. It should be enhanced later on by
letting Net::Stomp do the UTF8 conversion.

Test plan:
Run batch mod items. Add a Unicode char in the notes.
Check if job runs and results are correct.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:50:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:50:33 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-7UQkuRPkAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Still added a use Encode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:53:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:53:22 +0000
Subject: [Koha-bugs] [Bug 32244] New: We need to add vue (and cypress
 possibly) to the about page
Message-ID: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

            Bug ID: 32244
           Summary: We need to add vue (and cypress possibly) to the about
                    page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32030

Now we've introduced Vue in to our software stack, we need to add it to our
`About > Licenses` page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030
[Bug 32030] Electronic resource management (ERM)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:53:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:53:22 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-Evz4rl9096@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32244


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244
[Bug 32244] We need to add vue (and cypress possibly) to the about page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:53:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:53:33 +0000
Subject: [Koha-bugs] [Bug 32244] We need to add vue (and cypress possibly)
 to the about page
In-Reply-To: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32244-70-AhS9KWGLhD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:53:39 +0000
Subject: [Koha-bugs] [Bug 32244] We need to add vue (and cypress possibly)
 to the about page
In-Reply-To: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32244-70-ZvYdWxNi4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:54:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:54:02 +0000
Subject: [Koha-bugs] [Bug 32244] We need to add vue (and cypress possibly)
 to the about page
In-Reply-To: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32244-70-5tmTVvPGN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:54:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:54:21 +0000
Subject: [Koha-bugs] [Bug 32244] We need to add vue (and cypress possibly)
 to the about page
In-Reply-To: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32244-70-mbqnGPnJP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This will clearly be a string change...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:55:14 +0000
Subject: [Koha-bugs] [Bug 29830] Superlibrarian unable to delete patron list
In-Reply-To: <bug-29830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29830-70-vXZrilHq43@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29830

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to JaTara Barnes from comment #2)
> I currently have 3 patron lists in our system and I don't know which of our
> 80+ staff member(s) created it, nor is there an easy way of finding out.
> 
> Also, if one of those staff members resigns / retires without deleting the
> patron lists they've created, then we're potentially left with a bunch of
> lists that literally no one is able to delete.

If the patron account of the staff member is deleted, the patron lists will be
deleted with their other account information automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:55:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:55:22 +0000
Subject: [Koha-bugs] [Bug 32244] We need to add vue (and cypress possibly)
 to the about page
In-Reply-To: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32244-70-98D9dSdf8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jake.deery at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 10:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 09:59:19 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view
 (open/closed)
In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22773-70-jcHPLPcd2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

--- Comment #59 from Mirjam Vantieghem <mirjam.vantieghem at etf.edu> ---
Thanks for your reply, Katrin. Someone has already done this: bug 30438.
I saw this only after I placed my comment ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:00:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:00:21 +0000
Subject: [Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills
 lateorders.pl
In-Reply-To: <bug-32132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32132-70-g3h080PUgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143988&action=edit
Bug 32132: Return undef if budget is not found

If budget_period_id column is set as NULL, "Late orders"
page dies on error 500. Logs read:

Template process failed: undef error - DBIC result _type isn't of the _type
Aqbudget at
/home/koha/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
line 157

Prevent this happening by returning undef from method "budget".

To test:
1. Navigate to "Late orders" page.
2. Choose any order, take a note in which budget it belongs to.
3. Update chosen budget from database:
UPDATE aqbudgets SET budget_period_id WHERE budget_id = <budget_id>;
4. Reload "Late orders" page.
=> Page dies on error 500.
5. Apply this patch.
6. Reload page again.
=> Late orders should now be displayed correctly.

Also prove t/db_dependent/Koha/Acquisition/Fund.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:01:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:01:29 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-7dbJKEuf04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #6)
> (In reply to Nick Clemens from comment #5)

> > > For "OPAC problem reports management" and "Recalls", you get the same thing
> > > whether you click the top level or the sub-permission, and that's clearly
> > > indicated visually.
> > 
> > Sure, but then why is the subpermission added at all? If it is the same as
> > clicking the top level, let's not provide two checkboxes when one will do
> 
> I think that's the crux of the matter. 
> 
> I suppose one option could be removing unnecessary sub-permissions? 
> 
> Alternatively, we could also grey-out sub-permissions where there's only 1
> sub-permission available. That might make it less confusing visually?

I think you are right, having a module permission with only one sub-permission
makes no sense. Recalls should be a top-level permission without
sub-permissions and then when something requires a specific permission, a
'remaining recalls permissions' should be added as a second sub-permission,
like we have elsewhere (circulate for an example)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:02:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:02:11 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view
 (open/closed)
In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22773-70-NKMayw2kSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

--- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Mirjam Vantieghem from comment #59)
> Thanks for your reply, Katrin. Someone has already done this: bug 30438.
> I saw this only after I placed my comment ...

Great :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:04:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:04:34 +0000
Subject: [Koha-bugs] [Bug 31340] Add record review and publish permission
 separate from edit (change edit_catalogue permission)
In-Reply-To: <bug-31340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31340-70-tivwt8WrO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31340

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20678

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Linking bug 20678 that goes in a similar direction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:04:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:04:34 +0000
Subject: [Koha-bugs] [Bug 20678] Save draft records without committing them
 to the catalogue
In-Reply-To: <bug-20678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20678-70-2sdNmjO2K4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31340

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:06:54 +0000
Subject: [Koha-bugs] [Bug 31277] The LinkerOptions system preference should
 supply a list of available options
In-Reply-To: <bug-31277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31277-70-6LR1sobx8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31277

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, I see you tagged me on this one, but I really have no idea :( We don't
use the linking script and me working with Jared on this was way too long ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:11:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:11:58 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-ziVRfQXf2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Update - koha-testing-docker and misc4dev have been updated to run `yarn
build_js` when the container is setting up (during the `reset_all` step).

Which means the eRM module is now working out of the box in ktd, and ready to
test new patches on sandboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:13:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:13:48 +0000
Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as
 Ordered
In-Reply-To: <bug-29619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29619-70-7ncERALi1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Minna, I just tested this on current master and it works ok for me. I set
the default in the framework and my ordered items are created as 'on order'.
Does the problem still occur for you and could you double check for framework
configuration for ACQ 952$7?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:17:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:17:09 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-NHzKnOucmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #83 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143989&action=edit
Bug 24606: (QA follow-up) Fix encoding/decoding

We should use OO interface and leave encoding to database
layer.

Test plan:
Add a new item template containing real Unicode chars.
Save. Apply on new item.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:17:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:17:16 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-cgsYdNImwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #84 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 143990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143990&action=edit
Bug 24606: (QA follow-up) Add test for encoding/decoding

NOTE: I have the impression that this unit test is quite
rudimentary. I do not see the apply function tested?

Test plan:
Run t/db_dependent/Koha/Item/Templates.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:24:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:24:29 +0000
Subject: [Koha-bugs] [Bug 24550] Books renewals triggers item loan policies
 to revert to branch renewing item
In-Reply-To: <bug-24550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24550-70-grbjmCdCCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jason Robb from comment #5)

> It would be nice if renewal behavior could be explicitly defined to follow
> the rules of the library of the initial checkout to close that loophole.

The system preferences are explained well here:
https://bywatersolutions.com/education/monday-minutes-circulation-rules-for-multi-branch-systems

I'd say it works as described. HomeOrHoldingBranch doesn't take effect,
CircControl does.

I think it would not make sense to pull some values from one rule and others
from another. If you use the loan period from one library, also their renewal
rules should apply.


Maybe "the library the item is from" + holding branch would work like you
expect?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:28:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:28:37 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-o4FwEmJizZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:55:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:55:24 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-IINEWCMBLs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:55:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:55:29 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-wVdCzLHqpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140908|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143991&action=edit
Bug 31080: Unit tests

Unit tests for add_to_bundle functionality that prevents bundle nesting.

Test plan
1) Run t/db_dependent/Koha/Item.t
2) The test should fail
3) Apply the second patch
4) Re-run the test and watch it pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:55:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:55:34 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-n8H9wKajet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140909|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 143992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143992&action=edit
Bug 31080: Prevent bundles from being nested

This is a follow-up for bug 28854 to prevent bundle type items from
being nested in to other bundles.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:58:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:58:17 +0000
Subject: [Koha-bugs] [Bug 27730] Innocent changes to framework silently
 delete bibliographic data
In-Reply-To: <bug-27730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27730-70-cjsi2ZQiJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
With Bug 31923 - 'Ignore' tab description is misleading there is no at least a
warning in the framework configuration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:58:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:58:26 +0000
Subject: [Koha-bugs] [Bug 27730] Innocent changes to framework silently
 delete bibliographic data
In-Reply-To: <bug-27730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27730-70-qD5OksV0ou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31923

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 11:58:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 10:58:26 +0000
Subject: [Koha-bugs] [Bug 31923] 'Ignore' tab description is misleading
In-Reply-To: <bug-31923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31923-70-RNn9WPtg1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31923

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27730

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:04:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:04:25 +0000
Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
 adding on order item to existing record
In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20817-70-fMbAl0hQSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

--- Comment #130 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, does this still need a follow-up or back to testing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:11:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:11:48 +0000
Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
 adding on order item to existing record
In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20817-70-hQYkmpF2kz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #131 from Nick Clemens <nick at bywatersolutions.com> ---
This needs work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:31:35 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-xqkjbsalms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143968|0                           |1
        is obsolete|                            |

--- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 143993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143993&action=edit
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:33:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:33:27 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-NjHhTUa5Pd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:36:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:36:27 +0000
Subject: [Koha-bugs] [Bug 31925] AutoCreateAuthorities needs to preserve
 subject heading thesaurus to not create duplicate authority records
In-Reply-To: <bug-31925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31925-70-DoDjLFAXj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could we get some attention to this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:37:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:37:26 +0000
Subject: [Koha-bugs] [Bug 31925] AutoCreateAuthorities needs to preserve
 subject heading thesaurus to not create duplicate authority records
In-Reply-To: <bug-31925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31925-70-thhQuBDYB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just some thought: I think Phil's suggestion for making Koha create correct
records is the right one. But also: what do we do with the existing 'bad'
records. Could it be an option to make the new stricter behavior dependent on a
system preference?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:43:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:43:55 +0000
Subject: [Koha-bugs] [Bug 32031] Sidebars and breadcrumbs
In-Reply-To: <bug-32031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32031-70-T2mUSKbrjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32031

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31751
            Summary|Sidebars and Breadcrumbs    |Sidebars and breadcrumbs

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with Owen that it looks a bit too jumbled and we have a lot of pages
without the sidebars, so it would 'jump' around quite a bit. From a user's
perspective I think it's nice to have it always 'anchored' to the very same
spot that I can easily focus on. I think the breadcrumbs could be considered
part of the header, not part of main.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:43:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:43:55 +0000
Subject: [Koha-bugs] [Bug 31751] Breadcrumb style
In-Reply-To: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31751-70-uslrmQ6S0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31751

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32031

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:47:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:47:55 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-mPQnhxVHwp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:47:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:47:59 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-4ABDPEnVzr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143987|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143994&action=edit
Bug 32242: Resolve encoding issue when sending to Net::Stomp

This is meant as a quick fix. It should be enhanced later on by
letting Net::Stomp do the UTF8 conversion.

Test plan:
Run batch mod items. Add a Unicode char in the notes.
Check if job runs and results are correct.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:52:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:52:39 +0000
Subject: [Koha-bugs] [Bug 32245] New: Deleting news entries from Koha's
 staff start page is broken
Message-ID: <bug-32245-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32245

            Bug ID: 32245
           Summary: Deleting news entries from Koha's staff start page is
                    broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When you try to delete a news entry from Koha's staff start page you get the
confirmation question, but when you say yes, you end up in the HTML
customizations with an empty page. The news entry is not deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 12:56:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 11:56:09 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-IFy5Rsmlb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
Testing notes (using KTD):

1. Use Batch item modification (Cataloging > Batch editing) to edit two
records:
   - Add a Unicode character, such as 〼, in the non-public note and public note
fields
2. View the details of job - no records modified
3. Check the items - no change was made
4. Check the /var/log/koha/kohadev/plack-intranet-error.log - there is a
warning:
[2022/11/17 11:43:13] [WARN] The job has not been sent to the message broker   
: (Wide character in syswrite at /usr/lib/x86_64-linux-gnu/perl-base/IO/Hand   
le.pm line 200.
5. Apply the patch (and restart all the things)
6. Repeat steps 1-4 - the records should be successfully modified and there
should be no warning message in the logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:07:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:07:40 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-sce88W2RTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
It's fixing the problem.

Any good reasons to not import encode_utf8 from Encode?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:12:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:12:14 +0000
Subject: [Koha-bugs] [Bug 32246] New: Standardize start page layout between
 different modules
Message-ID: <bug-32246-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32246

            Bug ID: 32246
           Summary: Standardize start page layout between different
                    modules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The reports, cataloguing and Koha start page all leave room to the left, but
the circulation page does not. It would be nice to adapt it for more
consistency :)

Also makes me wonder how to use that space - we have the news on the start
page, maybe we could make this the dedicated area for IntranetReportsHomeHTML
etc.?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:14:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:14:29 +0000
Subject: [Koha-bugs] [Bug 31502] Add a customizable list of useful resources
 for cataloging to the left side of the cataloging module
In-Reply-To: <bug-31502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31502-70-lQra3Gblbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think maybe below the contents would be nice, to match
IntranetReportsHomeHTML and IntranetCirculationHomeHTML.

And possibly it should be moved to the HTML customizatoins/starting out there
in the first place instead of being a pref.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:17:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:17:40 +0000
Subject: [Koha-bugs] [Bug 31268] Clearly indicate reason for failed item
 creation when receiving expired subscription
In-Reply-To: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31268-70-1yZzUuUYfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31268

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we should fix that so items are still created while you can create
issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:18:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:18:44 +0000
Subject: [Koha-bugs] [Bug 29188] Expired serial subscriptions can still
 receive issues
In-Reply-To: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29188-70-Y7YnfKS7SI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

I think for a subscription that is expired, but where not  all issues in the
subscription lifespan have arrived yet, it makes sense to still be able to
receive issues. But we should probably not be able to create some with
prediction/publication date after expiration date?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:23:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:23:34 +0000
Subject: [Koha-bugs] [Bug 32089] build_holds_queue should optimize transfers
 to the hold pickup location rather than the patron home library
In-Reply-To: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32089-70-KnV6mBrUTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
That sounds like a pretty big oversight to the general holds system?

Is there a way to test this/make it visible in the GUI?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:25:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:25:00 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect
 default value used and warning message on order form
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-9zN8fVorJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

--- Comment #6 from David Nind <david at davidnind.com> ---
Worked out that the 19.65 is coming from the vendor information:
1. Check "My Vendor" - tax rate is set to 19.65% - drop down list has values
from TaxRates.
2. Change TaxRates, for example: from 0|0.12|0.1965 to 0|0.12|0.15
3. Vendor tax rate remains as 19.65 until you edit the vendor (when editing
will default to 0%).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:25:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:25:08 +0000
Subject: [Koha-bugs] [Bug 28844] Suggestion from existing title can alert
 patron in error
In-Reply-To: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28844-70-yVG8dYKhLq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:27:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:27:25 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect
 default value used and warning message on order form
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-ECNx8wL5T2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Nind from comment #6)
> Worked out that the 19.65 is coming from the vendor information:
> 1. Check "My Vendor" - tax rate is set to 19.65% - drop down list has values
> from TaxRates.
> 2. Change TaxRates, for example: from 0|0.12|0.1965 to 0|0.12|0.15
> 3. Vendor tax rate remains as 19.65 until you edit the vendor (when editing
> will default to 0%).

Ok, that makes sense.

When you create a new vendor, the first is selected correctly.

So is this ok after all?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:30:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:30:46 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-GRTvO8yt7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:30:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:30:50 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-OpETVP9tZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143981|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 143995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143995&action=edit
Bug 32212: (bug 32030 follow-up) Restore bootstrap 4

During the development of the eRM module I've tried to use bootstrap 5
(and vue-bootstrap), but I didn't manage to make it work without
modifying the version used in Koha. This change is actually not needed
and we can keep version 4.
See commit 8c32f186d5a62e742621c35cfacff5b22bb42b71
Bug 32030: ERM - Remove BootstrapVue3

Test plan:
% yarn install
% git diff
you should notice the version change in yarn.lock

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:32:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:32:26 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-jhhBcgwq3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #11 from David Nind <david at davidnind.com> ---
Testing notes (using KTD):

1. Can now rebuild OPAC CSS.

2. There are two warnings when running yarn install - not sure whether these
need to be addressed or not:

yarn install
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > bootstrap at 4.6.2" has unmet peer dependency "jquery at 1.9.1 - 3".
warning " > bootstrap at 4.6.2" has unmet peer dependency "popper.js@^1.16.1".
[4/4] Building fresh packages...
success Saved lockfile.
Done in 6.43s.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:33:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:33:41 +0000
Subject: [Koha-bugs] [Bug 30122] Display note fields in authority result list
In-Reply-To: <bug-30122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30122-70-OlDbuYRLZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe more like a denylist? We could mimick NotesToHide used for the 5xx in
bibliographic records and the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:35:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:35:19 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-wyYGWFGidA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:35:24 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-uQ0bh3GVrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143958|0                           |1
        is obsolete|                            |

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143996&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:36:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:36:18 +0000
Subject: [Koha-bugs] [Bug 30381] On order items still available for item
 level holds with TrapHoldsOnOrder
In-Reply-To: <bug-30381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30381-70-Y6aGU5l9Uq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30381

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Kyle M Hall from comment #1)
> I don't think this is a bug. This syspref is not related to whether an item
> may be placed on hold or not. It is specifically constrained to only
> deciding if on order items can be trapped to filled existing holds.

Hi Kyle, I am still confused a bit by placing holds on items that will not
trap... but for on order it probably makes the most sense as they will someday
probably 'trap' when they become available. Thx.

In case you know: How to handle it if libraries don't want the on order items
to be already holdable? Using an itemtype is not really nice there, but the
only thing I can think of right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:39:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:39:00 +0000
Subject: [Koha-bugs] [Bug 31235] UseDaysMode is used for calculating the
 expiration date for waiting holds
In-Reply-To: <bug-31235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31235-70-8lWOyIu3vM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #2)
> Koha::Calendar need a days_mode to be instantiated correctly.
> 
> > and just use calendar or not.
> What does it mean? That we need the different days_mode option for
> ExcludeHolidaysFromMaxPickUpDelay?

I guess that would be the only solution if you want to make them behave
differently... but for now it might be easiest to mention it in the UseDaysMode
system preference for documentation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:39:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:39:53 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-gPlovCNzXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Victor Grousset/tuxayo from comment #2)
> It's only happening the Ubuntu 18.04 on the CI
> Which I also happen to use, let's try.
> 
> Confirmed!
> Maybe the YAML is valid and the particular version of the OS of the failing
> build has a bug. Checking against external tools and YAML specs might be
> needed to be sure what's wrong.
> 
> root at kohadevbox:koha((2200b4aa3d...))$ prove xt/yaml_valid.t 
> xt/yaml_valid.t .. 1/18 
> #   Failed test
> '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/
> preferences/i18n_l10n.pref is YAML'
> #   at xt/yaml_valid.t line 41.
> 
> #   Failed test
> '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/
> preferences/serials.pref is YAML'
> #   at xt/yaml_valid.t line 41.
> 
> #   Failed test
> '/kohadevbox/koha/xt/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/
> preferences/local_use.pref is YAML'
> #   at xt/yaml_valid.t line 41.
> # Looks like you failed 3 tests of 18.
> xt/yaml_valid.t .. Dubious, test returned 3 (wstat 768, 0x300)
> Failed 3/18 subtests 
> 
> Test Summary Report
> -------------------
> xt/yaml_valid.t (Wstat: 768 Tests: 18 Failed: 3)
>   Failed tests:  9, 15, 17
>   Non-zero exit status: 3
> Files=1, Tests=18,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.62 cusr  0.02
> csys =  0.67 CPU)
> Result: FAIL

Hm I cannot test that. How should we proceed here and does only the test fail
or are there also issues in the GUI?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:40:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:40:35 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-8EBkPQztiB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
> It's fixing the problem.
> 
> Any good reasons to not import encode_utf8 from Encode?

I didnt need to import it. Main reason ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:42:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:42:22 +0000
Subject: [Koha-bugs] [Bug 30812] subfield 9 deleted if no other data is
 available
In-Reply-To: <bug-30812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30812-70-reC460CKMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30812

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am wondering - doesn't the DNB also deliver 020$a without hyphens in addition
to $9? At least that is the case for K10plus.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:42:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:42:42 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-sPr7SXXOLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:45:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:45:01 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect
 default value used and warning message on order form
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-4qP66m0zg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

--- Comment #8 from David Nind <david at davidnind.com> ---
(In reply to Katrin Fischer from comment #7)

> Ok, that makes sense.
> 
> When you create a new vendor, the first is selected correctly.
> 
> So is this ok after all?

It makes sense.

But should there be a warning somewhere?

Either (or both):

- For the TaxRates system preference to say that vendor information may need
updating if you remove existing values (for example, "NOTE: Current vendor
information may need updating if existing tax rates values are removed.")

- For the warning on the order to say something along the lines of "vendor tax
rate needs updating" (Possibly "The tax rate for the vendor does not match any
values in the TaxRates system preference - please update the information for
this vendor."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:50:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:50:44 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect
 default value used and warning message on order form
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-RppCuWDmFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
To me the warning is ok as is, but I think adding to the pref might be helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:51:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:51:11 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-gBSs5CmA0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
That's not a discussion for this bug report, but I thought we agreed on the
following pattern:

use Module qw( sub list );
then call Module::list() of list()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:54:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:54:01 +0000
Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30568-70-7L54kPFEAV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #2)
> patron-title.inc currently allows for the following output formats
> 
> * surname (othernames)
> * <span class="patron-title">title</span> surname, firstname (othernames) 
> * <span class="patron-title">title</span> firtname (othernames) surname
> * title surname, firstname (othernames)
> * title firstname (othernames) surname
> * surname (othernames) (cardnumber)
> * <span class="patron-title">title</span> surname, firstname (othernames)
> (cardnumber)
> * <span class="patron-title">title</span> firtname (othernames) surname
> (cardnumber)
> * title surname, firstname (othernames) (cardnumber)
> * title firstname (othernames) surname (cardnumber)
> * cardnumber
> * <span>A patron from library [% Branches.GetName( patron.branchcode ) |
> html -%]</span>

I like the idea of having clearer definitions on when to use what. 

Long, short, anonymous? 

The versions with span and without are for use in the title tag. 
And you'd probably still want title/no title. 

Probably would be nice to see how often each is used to see if we could replace
one or another or if there is a good reason for them to be needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:55:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:55:21 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-ZNpV09A8EH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #10)
> That's not a discussion for this bug report, but I thought we agreed on the
> following pattern:
> 
> use Module qw( sub list );
> then call Module::list() of list()

It is conform that agreement with the list being empty ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:55:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:55:35 +0000
Subject: [Koha-bugs] [Bug 28770] Add request date to order
In-Reply-To: <bug-28770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28770-70-38rHWR289m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28770

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for explaining!

I guess if it comes from a suggestion the field could be pre-filled and
manually updated otherwise?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:57:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:57:23 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-iiHpTiydfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 13:57:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 12:57:32 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-oz8bWvuubI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143996|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 143997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143997&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:00:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:00:49 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-gDaggNWQMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
What would be the easiest option here to make everyone happy for now: Could it
be made a configuration option somehow?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:03:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:03:04 +0000
Subject: [Koha-bugs] [Bug 30280] Support authority records with common
 subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-ZaKp8q1qWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The problem is, we broke things with this one for people and a lot of libraries
- we need to find a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:03:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:03:47 +0000
Subject: [Koha-bugs] [Bug 31924] AutoLinkBiblios with Zebra broken by patch
 from Bug 30280
In-Reply-To: <bug-31924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31924-70-48rzjZ65eQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31924

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Frank Hansen from comment #56)
> (In reply to Katrin Fischer from comment #55)
> > hi Frank, could you maybe have a look at the new bugs in Blocks? bug 31924
> > and bug 31925.
> 

> I'n not an expert on Zebra. Probably the new
> subject-heading-thesaurus-conventions index needs to be set up in Zebra as
> well. I'm not 100% certain how to do that. 

That might give us a starting point.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:04:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:04:00 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - incorrect
 default value used and warning message on order form
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-cAQUQjerM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david at davidnind.com
                   |ity.org                     |

--- Comment #10 from David Nind <david at davidnind.com> ---
(In reply to Katrin Fischer from comment #9)
> To me the warning is ok as is, but I think adding to the pref might be
> helpful.

Have assigned to myself - I think I can manage changing the text for the system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:13:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:13:41 +0000
Subject: [Koha-bugs] [Bug 32089] build_holds_queue should optimize transfers
 to the hold pickup location rather than the patron home library
In-Reply-To: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32089-70-G8ECaK5lQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> That sounds like a pretty big oversight to the general holds system?
> 
> Is there a way to test this/make it visible in the GUI?

I think it's basically taking bug 31557 and adding a third option, pickup
branch. Does that summarize this correctly Andrew?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:34:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:34:09 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-Y6fL21ruWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 143998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143998&action=edit
Bug 32242: Add selenium tests

This is not testing the thing at the correct level, but at least we test
the whole workflow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:34:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:34:42 +0000
Subject: [Koha-bugs] [Bug 28770] Add request date to order
In-Reply-To: <bug-28770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28770-70-L7lXIvL1Y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28770

--- Comment #4 from Michael Sutherland <sudrland at vt.edu> ---
(In reply to Katrin Fischer from comment #3)
> Thx for explaining!
> 
> I guess if it comes from a suggestion the field could be pre-filled and
> manually updated otherwise?

Yes, purchase requests utilizing Koha's suggestion form, pre-filling the date
on the submitted form would be beneficial.  

When we create an order from other purchase requests not using Koha's purchase
suggestion form, we would need to manually enter a date requested. 

As an FYI, we use this data for strategic goals and planning for Collections &
Technical Services with Demand Driven Acquisitions (DDA) to show turn-around
times between when requests are made and when they're fulfilled. Thus far, this
data collection is all manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:38:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:38:45 +0000
Subject: [Koha-bugs] [Bug 32247] New: HoldsQueue does not need to check
 items if there are no holds
Message-ID: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

            Bug ID: 32247
           Summary: HoldsQueue does not need to check items if there are
                    no holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

update_queue_for_biblio currently
1 - gets the holds on a bib
2 - gets the items available to fill any holds
3 - combines these to build the queue, exiting if there are no holds or items

If there are no holds at step 1, we don't need to do step 2 or 3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:40:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:40:42 +0000
Subject: [Koha-bugs] [Bug 32247] HoldsQueue does not need to check items if
 there are no holds
In-Reply-To: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32247-70-GVOrmkZWqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:40:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:40:46 +0000
Subject: [Koha-bugs] [Bug 32247] HoldsQueue does not need to check items if
 there are no holds
In-Reply-To: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32247-70-4y14XJIeBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 143999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143999&action=edit
Bug 32247: Exit holds queue builder if there are no holds on the biblio

update_queue_for_biblio currently
1 - gets the holds on a bib
2 - gets the items available to fill any holds
3 - combines these to build the queue, exiting if there are no holds or items

If there are no holds at step 1, we don't need to do step 2 or 3
This patch simply deletes the queue for this biblio, then exits if there are no
holds

To test:
prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t
t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t
t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:41:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:41:05 +0000
Subject: [Koha-bugs] [Bug 32247] HoldsQueue does not need to check items if
 there are no holds
In-Reply-To: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32247-70-xpmmt1quXB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:52:16 +0000
Subject: [Koha-bugs] [Bug 32248] New: t/00-checkdatabase-version.t should be
 removed
Message-ID: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

            Bug ID: 32248
           Summary: t/00-checkdatabase-version.t should be removed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 25078


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
[Bug 25078] Update DB process - wrap each DBRev inside a transaction and better
error handling
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:52:16 +0000
Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside
 a transaction and better error handling
In-Reply-To: <bug-25078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25078-70-2qWbjGQCWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248
[Bug 32248] t/00-checkdatabase-version.t should be removed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:53:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:53:30 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-IFUWP8RB8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 14:53:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 13:53:34 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-1DCa8YN51l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144000&action=edit
Bug 32248: Remove t/00-checkdatabase-version.t

Since bug 25078 we do no longer use updatedatabase.pl. This test was
there to make sure the RM(aints) was replacing the XXX correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:05:11 +0000
Subject: [Koha-bugs] [Bug 32247] HoldsQueue does not need to check items if
 there are no holds
In-Reply-To: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32247-70-NoQusbPUwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143999|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144001&action=edit
Bug 32247: Exit holds queue builder if there are no holds on the biblio

update_queue_for_biblio currently
1 - gets the holds on a bib
2 - gets the items available to fill any holds
3 - combines these to build the queue, exiting if there are no holds or items

If there are no holds at step 1, we don't need to do step 2 or 3
This patch simply deletes the queue for this biblio, then exits if there are no
holds

To test:
prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t
t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t
t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:22:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:22:54 +0000
Subject: [Koha-bugs] [Bug 18247] Remove SQL queries from
 branch_transfer_limit.pl administrative script
In-Reply-To: <bug-18247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18247-70-1iof1AJSFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247

jacob.omara at ptfs-europe.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jacob.omara at ptfs-europe.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:26:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:26:14 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-6Z5CIwNwFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:29:57 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-MIfe2XMw1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143993|0                           |1
        is obsolete|                            |

--- Comment #6 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 144002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144002&action=edit
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:34:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:34:19 +0000
Subject: [Koha-bugs] [Bug 30243] When OPACSuggestionMandatoryFields includes
 branchcode the dropdown should default to an empty value
In-Reply-To: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30243-70-KghXbrvi9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243

Catrina Berka <catrina at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catrina at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:34:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:34:21 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-8JkVqROvai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Using this bug to work on sandboxes for a few minutes.. trying to get signoffs
using the form input

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:39:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:39:08 +0000
Subject: [Koha-bugs] [Bug 32249] New: When OPACSuggestionMandatoryFields
 includes branchcode the dropdown defaults to patron home branch
Message-ID: <bug-32249-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32249

            Bug ID: 32249
           Summary: When OPACSuggestionMandatoryFields includes branchcode
                    the dropdown defaults to patron home branch
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: catrina at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 144003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144003&action=edit
OPACSuggestionMandatoryFields defaults to patron home branch

When testing for documentation of Bug 30243 in 22.05, the branchcode dropdown
defaults to patron home branch instead of an empty value. 

OPACSuggestionMandatoryFields includes branchcode
OPACSuggestionUnwantedFields does NOT include branchcode
Save all OPAC preferences

On the OPAC, select "New Purchase Suggestion"
In the form, Library defaults to patron's home branch instead of an empty
value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:41:19 +0000
Subject: [Koha-bugs] [Bug 30243] When OPACSuggestionMandatoryFields includes
 branchcode the dropdown should default to an empty value
In-Reply-To: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30243-70-O89x7eFJ1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243

--- Comment #6 from Catrina Berka <catrina at bywatersolutions.com> ---
Filed bug 32249, reporting that this doesn't work as anticipated. The dropdown
defaults to patron home branch, not an empty value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:45:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:45:32 +0000
Subject: [Koha-bugs] [Bug 32250] New: link_bibs_to_authorities generates too
 many background jobs
Message-ID: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250

            Bug ID: 32250
           Summary: link_bibs_to_authorities generates too many background
                    jobs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When running the linker job we call ModBiblio for every linked record

We should pass skip_record_index and skip_holds_queue and capture the
biblionumbers - we can then generate a job per commit, rather than per record

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:58:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:58:22 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-iFLCyMIX3J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144002|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144004&action=edit
Bug 31774: Add 'page-section' to list of imported records

To test:
* Stage a MARC file with a few records
* Look at the import results
* The list of imported records doesn't have the white
  page section background
* Apply patch
* Refresh page and verify the table now is contained

Signed-off-by: Jacob O'Mara <jacob.omara at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 15:59:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 14:59:41 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-8tJ3ooQsfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've sorted out the SO line to catch Jacob (one of our new devs) who actually
tested and signed off on the bug on a sandbox during training today.

Will keep bashing at fixing the sandboxes.

Passing QA on the patch itself.. trivial and solid fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:01:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:01:00 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-Qd2aVHpwHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #7)
> (In reply to David Cook from comment #6)
> > (In reply to Nick Clemens from comment #5)
> 
> > > > For "OPAC problem reports management" and "Recalls", you get the same thing
> > > > whether you click the top level or the sub-permission, and that's clearly
> > > > indicated visually.
> > > 
> > > Sure, but then why is the subpermission added at all? If it is the same as
> > > clicking the top level, let's not provide two checkboxes when one will do
> > 
> > I think that's the crux of the matter. 
> > 
> > I suppose one option could be removing unnecessary sub-permissions? 
> > 
> > Alternatively, we could also grey-out sub-permissions where there's only 1
> > sub-permission available. That might make it less confusing visually?
> 
> I think you are right, having a module permission with only one
> sub-permission makes no sense. Recalls should be a top-level permission
> without sub-permissions and then when something requires a specific
> permission, a 'remaining recalls permissions' should be added as a second
> sub-permission, like we have elsewhere (circulate for an example)

Just to add, I don't like 'remaining' permisssions - it is very unclear to the
end user what exactly these are - I know they are 'everything not listed
elsewhere' but it comes off as somewhat ambiguous

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:15:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:15:22 +0000
Subject: [Koha-bugs] [Bug 32089] build_holds_queue should optimize transfers
 to the hold pickup location rather than the patron home library
In-Reply-To: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32089-70-SJUWp6fl1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I'm actually closing this one.

In talking through bug 31557, we misread the code a bit. I've just run through
some scenarios that should have led to some weird hold targeting if our read
was correct, but Koha consistently picked the item at the hold pickup location
rather than the patron's branch, so this appears to be working as desired.

Clearly I'm just too ready to think the worst of the holds system. False alarm!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:23:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:23:19 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-0Pt4u40PfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:24:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:24:50 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-mEganC5Yg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143985|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144005&action=edit
Bug 32240: Prevent erm_users.t to fail if checkout exist

We should not (never) remove all patrons before tests

Test plan:
0. Don't apply the patch
1. Check an item out
2. Run the tests
=> Fail
3. Apply the patch
4. Create a patron with the erm permission
5. Run the tests
=> Must return green

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:25:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:25:14 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-fFkBkwGXXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:25:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:25:27 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-Vf1yUruNQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:25:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:25:34 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-sUBBc1K51a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:26:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:26:29 +0000
Subject: [Koha-bugs] [Bug 32251] New: opac-page.pl: Add a fallback for when
 language cookie was removed
Message-ID: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251

            Bug ID: 32251
           Summary: opac-page.pl: Add a fallback for when language cookie
                    was removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Simply put:
Replace
-    my $lang = $query->param('language') ||
$query->cookie('KohaOpacLanguage');
+    my $lang = $query->param('language') || $query->cookie('KohaOpacLanguage')
|| $template->lang;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:26:44 +0000
Subject: [Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when
 language cookie was removed
In-Reply-To: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32251-70-N3AxymLHNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:30:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:30:21 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-5ZO2mKl88p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143938|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144006&action=edit
Bug 32131: Cypress tests are failing if ERMModule is off

This patch solves this by enabling the system preference before each test,
right after login. It also sets the system preference back to its original
initial value after the tests finish running.

To test:
1) Disable ERMModule system preference
2) Run cypess tests: yarn cypress open / yarn cypress run
3) Verify that tests run successfully
(Optional): While tests are running, visit the system preferences panel and
verify that the system preference is now "Enable".
4) Wait for the tests to finish and confirm that the system preference is set
back to its original "Disable" value.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:30:25 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-PFqIL3XyaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143939|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144007&action=edit
Bug 32131: Move set_ERM_sys_pref_value to before

We cannot (yet) move login to before, but we can set the pref before all
the tests. We need to login in before anyway to retrieve the value of
the pref.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:30:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:30:29 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-U9qEHMYNjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143940|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144008&action=edit
Bug 32131: Make sure we login before we restore original pref's value

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:30:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:30:34 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-dAdsMypysS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143941|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144009&action=edit
Bug 32131: (to-squash) Cypress tests are failing if ERMModule is off

Please squash this with the first patch if 32147 is pushed before 32131.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:32:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:32:55 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-MiHNImak5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works as described and makes sense.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:39:26 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-fQvi8rZU5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Shame this didn't make it in time for 22.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:50:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:50:42 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-arGAKRLJhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 16:50:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 15:50:45 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-Omoe5E3CTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144010&action=edit
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:00:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:00:19 +0000
Subject: [Koha-bugs] [Bug 32252] New: Number of results in a facet do not
 show after facet selection
Message-ID: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32252

            Bug ID: 32252
           Summary: Number of results in a facet do not show after facet
                    selection
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: catrina at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 27035 was supposed to show the number of results in a facet after
selection, but the old behavior persists, only showing [x] that the facet has
been selected, not the (n) indicating the number of results. 

This screencast shows the results on the staff interface:
https://watch.screencastify.com/v/rWbvqeBLY7hXTex8TekX

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:01:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:01:07 +0000
Subject: [Koha-bugs] [Bug 27035] Shows the number of results in a facet
 after facet selection
In-Reply-To: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27035-70-gSFRxrCPjV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035

Catrina Berka <catrina at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catrina at bywatersolutions.co
                   |                            |m

--- Comment #16 from Catrina Berka <catrina at bywatersolutions.com> ---
Filed bug 32252 - this does not appear to be resolved in 22.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:16:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:16:24 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-dJ5Gzrt4An@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #9 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Test plan:

1: have an All/All rule in the circ matrix that allows unlimited holds
2: set Default checkout, hold, and return policy to maximum 1 total hold
allowed
3: set Default checkout, hold policy by patron category to allow Board patrons
to have unlimited holds (remember you can't just save a blank set of rules
here, so you'll want to put a number into Total Checkouts, nothing in Total
Holds, and save that -- you'll end up with "Unlimited" showing in Total Holds).
4: Place a hold for a Board patron. It works!
5: Try to place a second hold for the same Board patron. It tells you you're
over the limit, "[patron] can only place a maximum of 1 total holds."
6: In reports, select * from circulation_rules where rule_name='max_holds', see
that your Board patron rule didn't get created

APPLY PATCH

7: Back in circ rules, delete and re-create your Default checkout, hold policy
by patron category rule for Board patrons
8: Try your second hold again. It works!
9: Run your report again, see you now have a rule where categorycode=B,
rule_name=max_holds, rule_value is null

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:17:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:17:02 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-7cpoGWsd65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143984|0                           |1
        is obsolete|                            |

--- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 144011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144011&action=edit
Bug 30794: Insert blank rule (unlimited) for max_holds

Related to bug 24669, why didn't we use strip_non_numeric for one occurrence?

Note that there is still a problem, if none of the 3 inputs is filled,
no rule will be created (ie. action ignored)

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:17:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:17:22 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-8l8TYUCJKR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:27:00 +0000
Subject: [Koha-bugs] [Bug 32089] build_holds_queue should optimize transfers
 to the hold pickup location rather than the patron home library
In-Reply-To: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32089-70-B9xF99Xt6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32089

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for testing, Andrew!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:29:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:29:07 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-gJuu20DX0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

Jonathan Cuéllar <jcautomatizacion at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |22.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:29:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:29:32 +0000
Subject: [Koha-bugs] [Bug 27761] Koha is reporting deleted items when a
 pickup is done by OAI
In-Reply-To: <bug-27761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27761-70-bqwK62KKwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27761

Jonathan Cuéllar <jcautomatizacion at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Cataloging
                   |and plumbing                |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:31:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:31:44 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-tjn1RrDmB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

what is your exact Koha version? 22.11.XX
How did you install Koha?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:33:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:33:21 +0000
Subject: [Koha-bugs] [Bug 32252] Number of results in a facet do not show
 after facet selection
In-Reply-To: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32252-70-cYmbJIVyWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32252

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Catrina, did you set displayFacetCount to show?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:42:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:42:48 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-QFjzZwVYKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:42:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:42:51 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-HHaZJR0xPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:42:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:42:55 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-fOIEZwTuXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:42:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:42:57 +0000
Subject: [Koha-bugs] [Bug 31937] Prevent cleanup_database.pl from locking
 too many accounts
In-Reply-To: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31937-70-gwjsDYXx5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31937

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:43:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:43:00 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-MleMIKhJ4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:43:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:43:03 +0000
Subject: [Koha-bugs] [Bug 32131] Cypress tests are failing if ERMModule is
 off
In-Reply-To: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32131-70-HATOdlgC7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:43:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:43:05 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-7V5q2oF8jm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:43:09 +0000
Subject: [Koha-bugs] [Bug 32240] api/erm_users.t fails if checkouts exist
In-Reply-To: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32240-70-oCTZ1l7jZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32240

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:44:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:44:13 +0000
Subject: [Koha-bugs] [Bug 32252] Number of results in a facet do not show
 after facet selection
In-Reply-To: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32252-70-WRqUfgGLsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32252

--- Comment #2 from Catrina Berka <catrina at bywatersolutions.com> ---
Yes, displayFacetCount = show

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:47:00 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-lF2eI647d1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:47:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:47:05 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-4AwiSXg4Sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144000|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144012&action=edit
Bug 32248: Remove t/00-checkdatabase-version.t

Since bug 25078 we do no longer use updatedatabase.pl. This test was
there to make sure the RM(aints) was replacing the XXX correctly.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:47:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:47:49 +0000
Subject: [Koha-bugs] [Bug 32253] New: Advanced cataloging editor doesn't
 load every line initially
Message-ID: <bug-32253-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32253

            Bug ID: 32253
           Summary: Advanced cataloging editor doesn't load every line
                    initially
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If you load the advanced cataloging editor with a record that has more than 25
lines not all the lines will load initially. Once you add focus to the
CodeMirror instance those lines do load but they should all load intially.

To recreate:
1. Have advanced editor turned on. 
2. Load a record with many lines and see that not all the lines appear until
you click on the visible ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:54:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:54:57 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-lgTDscjF1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 17:55:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 16:55:04 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-pOpewdBTTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144012|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144013&action=edit
Bug 32248: Remove t/00-checkdatabase-version.t

Since bug 25078 we do no longer use updatedatabase.pl. This test was
there to make sure the RM(aints) was replacing the XXX correctly.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:01:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:01:38 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-T6Vti1uln2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:01:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:01:54 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-zo9CLOQp1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143969|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:02:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:02:09 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-jp4LvUdiWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143983|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:03:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:03:00 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-qT9fC5s1j5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144014&action=edit
Bug 32224: Add cypress to yarn commands

Either I am missing something obvious, or we need to add cypress to the scripts
of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I
cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see
https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905)
but I think both should work.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:03:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:03:16 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-4lkVVuH4zO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144015&action=edit
Bug 32224: Add prettier to yarn commands

xt/vue_tidy.t was failing with:
  error Command "prettier" not found.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:23:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:23:14 +0000
Subject: [Koha-bugs] [Bug 32254] New: Add 'page-section' to various tools
 pages
Message-ID: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

            Bug ID: 32254
           Summary: Add 'page-section' to various tools pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, martin.renvoize at ptfs-europe.com,
                    testopia at bugs.koha-community.org
            Blocks: 31757

Several pages listed on the Tools page need the page-section container:

- patroncards/edit-batch.tt
- pos/register.tt
- pos/registers.tt
- tools/access_files.tt
- tools/additional-contents.tt
- tools/batch_extend_due_dates.tt
- tools/modborrowers.tt
- tools/picture-upload.tt
- tools/upload.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:23:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:23:14 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-wMoDlhtJyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32254


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254
[Bug 32254] Add 'page-section' to various tools pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:41:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:41:10 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-KZrEyOZ7KL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:41:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:41:13 +0000
Subject: [Koha-bugs] [Bug 32224] Add cypress and prettier to the yarn
 commands
In-Reply-To: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32224-70-k0py7x5gHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:41:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:41:16 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-V4hIYRgSHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:41:19 +0000
Subject: [Koha-bugs] [Bug 32248] t/00-checkdatabase-version.t should be
 removed
In-Reply-To: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32248-70-GhcIlBMCr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32248

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:45:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:45:35 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-RnzLD6oDjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:45:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:45:38 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-tFxWOy45fE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143994|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:45:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:45:41 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-xkL7SOjFDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143998|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:46:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:46:08 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-kxH7g1NkAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144016&action=edit
Bug 32242: Resolve encoding issue when sending to Net::Stomp

This is meant as a quick fix. It should be enhanced later on by
letting Net::Stomp do the UTF8 conversion.

Test plan:
Run batch mod items. Add a Unicode char in the notes.
Check if job runs and results are correct.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:46:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:46:13 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-80FD7eXEsv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144017&action=edit
Bug 32242: Add selenium tests

This is not testing the thing at the correct level, but at least we test
the whole workflow.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:47:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:47:32 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-M9mYAsAOab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:47:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:47:35 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-9vetVFXkSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:48:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:48:09 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-LcHPOO29H8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:48:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:48:13 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-9PIK7i7aGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144018&action=edit
Bug 32254: Add 'page-section' to various tools pages

This patch adds a .page-section div to various pages in the tools
section in order to provide a consistent page structure.

Also changed: Corrected a couple of templates which were missing some
<tr> tags.

This patch includes indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Tools -> Access files
- Tools -> HTML customizations
  - Additional contents, news or pages-- all use the same template.
  - Check the list of existing entries.
- Tools -> Batch extend due dates
  - Choose a set of criteria that will return results and click
   "Continue".
  - Check the list of checkouts to be updated.
- Tools -> Batch patron modification
  - Submit a batch of patrons for modification.
  - Check the list of patrons to be modified.
- Tools -> Upload patron images
  - Upload one or more patron images
  - Check the view of results
- Tools -> Upload
  - Upload a file and view the results, or perform a search and check
    the view of results.
- Tools -> Patron card creator -> New patron card batch.
  - Submit a set of patrons and check the display of patrons in the
    resulting batch.
- Tools -> Cash summary for <library> and Tools -> Transaction history
  for <register>
  - Confirm that the table of data looks correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:50:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:50:26 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-bQFJdXtkYc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:50:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:50:30 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-aS9gLxI3NG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143995|0                           |1
        is obsolete|                            |

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144019&action=edit
Bug 32212: (bug 32030 follow-up) Restore bootstrap 4

During the development of the eRM module I've tried to use bootstrap 5
(and vue-bootstrap), but I didn't manage to make it work without
modifying the version used in Koha. This change is actually not needed
and we can keep version 4.
See commit 8c32f186d5a62e742621c35cfacff5b22bb42b71
Bug 32030: ERM - Remove BootstrapVue3

Test plan:
% yarn install
% git diff
you should notice the version change in yarn.lock

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:56:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:56:01 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-vYxXBNEu3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:56:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:56:06 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-d0e85nIsTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143930|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144020&action=edit
Bug 32093: Make help and code match for bg-days in cleanup_database.pl

There as a mismatch between the parameter name in documentation (bg-days)
and what was checked in the code (bg-jobs). This makes both match.

To test:
* Apply patch
* Make sure you have some background_jobs older than one day
* Verify the help of the script documents the parameter bg-days
* Run the cleanup_database.pl job
  Example:  ./misc/cronjobs/cleanup_database.pl --bg-days  --confirm -v
* Verify there are no errors and the lines have been deleted as expected

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 18:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 17:57:18 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-FX34rHbK7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:03:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:03:50 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-FPmXI8nCRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:03:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:03:55 +0000
Subject: [Koha-bugs] [Bug 32104] console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-vGEZFPpGwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143164|0                           |1
        is obsolete|                            |

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144021&action=edit
Bug 32104: Prevent console error on additonal-contents.pl

To test:
1. Make a new HTML customization, news item, or page with the text editor (
CodeMirror ).
2. Save the content ( not Save and continue )
3. Notice the console error:
4. Apply patch
5. Try 1 & 2 again.
6. No error.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:31 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-GixojHbBmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:33 +0000
Subject: [Koha-bugs] [Bug 32093] cleanup_database.pl bg-jobs parameter
 should be bg-days
In-Reply-To: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32093-70-5swXugr1Ed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32093

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:37 +0000
Subject: [Koha-bugs] [Bug 32104] Console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-AFhh3Acj83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|console error on            |Console error on
                   |additional_content.pl after |additional_content.pl after
                   |saving                      |saving

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:37 +0000
Subject: [Koha-bugs] [Bug 32104] Console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-oYF77jrU5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|console error on            |Console error on
                   |additional_content.pl after |additional_content.pl after
                   |saving                      |saving

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:39 +0000
Subject: [Koha-bugs] [Bug 32104] Console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-v2rj0dPCHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:42 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-euAGcP1i4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:46 +0000
Subject: [Koha-bugs] [Bug 32181] ERM - Cannot filter by expired when adding
 an agreement to EBSCO's package
In-Reply-To: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32181-70-yrEK8IZG8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32181

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:49 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-KMoEYTN2nY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:04:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:04:52 +0000
Subject: [Koha-bugs] [Bug 32212] Add separate Bootstrap 4 node module for
 the OPAC
In-Reply-To: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32212-70-B8U276pZR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32212

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:10:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:10:31 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-J324jiRmzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, conflicts... :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:24:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:24:58 +0000
Subject: [Koha-bugs] [Bug 32255] New: Cannot use file upload in batch record
 modification
Message-ID: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

            Bug ID: 32255
           Summary: Cannot use file upload in batch record modification
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When using the batch record modification tool with a file of biblionumbers,
nothing happens. When we click 'Continue' the file is somehow removed before
continuing.

To test:
1. Get a file of biblionumbers (if you already have a file, proceed to step 2)
   1.1. Go to Reports
   1.2. Click on 'Create from SQL'
   1.3. Enter a report name (e.g. biblionumbers)
   1.4. Enter the following SQL query

SELECT biblionumber FROM biblio LIMIT 100

   1.5. Click 'Save report'
   1.6. Click 'Run report'
   1.7. Click 'Download' > 'Tab separated text'

2. Create a MARC modification template (if you already have a MARC modification
template, proceed to step 3)
   2.1. Go to Cataloging > MARC modification template
   2.2. Click 'New template'
   2.3. Enter a template name (e.g. Add note)
   2.4. Click 'Submit'
   2.5. Click 'New action'
   2.6. Choose
        - Add new
        - Field 500 a
        - with value Note
   2.7. Click 'Add action'

3. Batch modify records
   3.1. Go to Cataloging > Batch record modification
   3.2. In the 'Upload a file tab', choose the biblionumber file
   --> Note that the name of the file appears next to the Choose button
   3.3. In 'Template', select the MARC modification template
   3.4. Click 'Continue'
   --> The name of the file disappears next to the Choose button and goes back
to 'No file chosen'
   --> Message 'No records were modified.'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:25:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:25:14 +0000
Subject: [Koha-bugs] [Bug 31643] Link authorities automatically requires ALL
 cataloging and authorities permissions
In-Reply-To: <bug-31643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31643-70-CWi1KD7rzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31643

hebah at bywatersolutions.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hebah at bywatersolutions.com

--- Comment #6 from hebah at bywatersolutions.com ---
Any chance of backporting this to 22.05?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:25:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:25:37 +0000
Subject: [Koha-bugs] [Bug 25787] Club holds can't be placed without
 modify_holds_priority permission
In-Reply-To: <bug-25787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25787-70-jK5UXJOJYv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:25:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:25:45 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-o51DW8SXWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Apparently, might be the same as bug 32237, but on a different page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:25:52 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-gRiMsdnRTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32237

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:25:52 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-1HjrusIo5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32255

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:27:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:27:51 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-hiPL9BeJyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
This goes back all the way to 22.05 at least.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:30:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:30:01 +0000
Subject: [Koha-bugs] [Bug 32256] New: self-checkout batch mode
Message-ID: <bug-32256-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256

            Bug ID: 32256
           Summary: self-checkout batch mode
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Self checkout
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ddaghita at mckinneytexas.org
        QA Contact: testopia at bugs.koha-community.org

Please enable batch checkouts on self-checkout machines using koha
self-checkout module (/cgi-bin/koha/sco/sco-main.pl?).

We have patrons place one book at time on the RFID pad to self-checkout.  

We would ideally like patrons to stack five or more materials at a time so they
checkout more efficiently all at once as it does on the koha staff side.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:36:06 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-t4VpXA1skQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:36:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:36:12 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-cS9xZZ8MkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143956|0                           |1
        is obsolete|                            |
 Attachment #143997|0                           |1
        is obsolete|                            |

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144022&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:36:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:36:17 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-vb2XttfTcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144023&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:41:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:41:47 +0000
Subject: [Koha-bugs] [Bug 32257] New: Label for patron attributes misaligned
 on patron batch mod
Message-ID: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

            Bug ID: 32257
           Summary: Label for patron attributes misaligned on patron batch
                    mod
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952

On the patron batch modification tool, the label for patron attributes is
misaligned.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:41:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:41:47 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-fxB6kY9TPE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32257


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257
[Bug 32257] Label for patron attributes misaligned on patron batch mod
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:44:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:44:04 +0000
Subject: [Koha-bugs] [Bug 31329] Add ability to block all linked accounts
 when one account has been restricted
In-Reply-To: <bug-31329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31329-70-WmPtGqAyGG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31329

--- Comment #5 from Wally DesChamps <wdeschamps at prospertx.gov> ---
Koha-US VP has requested ideas for sponsored development.  I am unashamedly
campaigning for this bug to win the sponsorship prize!!!  If you feel this is a
worthwhile development, PLEASE comment, share, and ask others to also comment
and send the Development Committee an email at development at koha-us.org of their
interest in development of Bug 31329.  Thanks! :-)  (Happy Thanksgiving
everyone!)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:44:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:44:55 +0000
Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page
In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32061-70-IEKT7VYIun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:45:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:45:00 +0000
Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page
In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32061-70-PZQuNTn3PV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143978|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 144024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144024&action=edit
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:47:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:47:59 +0000
Subject: [Koha-bugs] [Bug 31329] Add ability to block all linked accounts
 when one account has been restricted
In-Reply-To: <bug-31329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31329-70-ChoqI88l4p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31329

--- Comment #6 from Wally DesChamps <wdeschamps at prospertx.gov> ---
Actually, express your interest via: Submit your proposals here to have your
development considered:
https://docs.google.com/forms/d/e/1FAIpQLSdR5nodA8jGa-9dchqOkFN_2O1mYyz8oej2IevxQYKtft7s-w/viewform

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:48:23 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-NyrU9HQ5JB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:48:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:48:28 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-xLKrIFYIJp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144018|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144025&action=edit
Bug 32254: Add 'page-section' to various tools pages

This patch adds a .page-section div to various pages in the tools
section in order to provide a consistent page structure.

Also changed: Corrected a couple of templates which were missing some
<tr> tags.

This patch includes indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Tools -> Access files
- Tools -> HTML customizations
  - Additional contents, news or pages-- all use the same template.
  - Check the list of existing entries.
- Tools -> Batch extend due dates
  - Choose a set of criteria that will return results and click
   "Continue".
  - Check the list of checkouts to be updated.
- Tools -> Batch patron modification
  - Submit a batch of patrons for modification.
  - Check the list of patrons to be modified.
- Tools -> Upload patron images
  - Upload one or more patron images
  - Check the view of results
- Tools -> Upload
  - Upload a file and view the results, or perform a search and check
    the view of results.
- Tools -> Patron card creator -> New patron card batch.
  - Submit a set of patrons and check the display of patrons in the
    resulting batch.
- Tools -> Cash summary for <library> and Tools -> Transaction history
  for <register>
  - Confirm that the table of data looks correct

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:48:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:48:32 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-5plrNUasn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144026&action=edit
Bug 32254: (follow-up) Add page section to Cashup history

Adds one missing page section on the last table of the
POS transactions page.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:50:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:50:25 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-42l0fXjcVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Templates
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:55:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:55:12 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-Ptu1VAwhW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:55:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:55:17 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-D4dhFay3hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144022|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144027&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 19:55:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 18:55:22 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-ENlaviwmQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144023|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144028&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:03:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:03:27 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-cSyDsgHHN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:03:31 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-qshOKy1mzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144029&action=edit
Bug 32198: Add page-section to stock rotation stages list (cat)

This patch adds a .page-section container around relevant areas of the
stock rotation management interface.

Also changed: Removed a .dialog.message container which was not correct.

To test, apply the patch and go to Cataloging -> Stock rotation.

- If necessary, add a rota.
- Click Manage -> Stages on your rota.
  - If neccesary, create one or more stages.
  - The display of stages should look correct.
- From the list of rotas click Manage -> Items.
  - Click "Add items" and use a barcode file to add multiple items at
    once.
  - The page confirming your submission, with a list of items, should
    have a page-section.
  - Return to the view of items in the rota. The display of items should
    look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:16:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:16:50 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-vklpfTNF3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:16:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:16:54 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-hFqP5tcmVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144030&action=edit
Bug 32241: Add page-section to list of records in batch record modificaton
(tool)

This patch modifies the batch record modification page template so that
the preview of submitted records is contained in a .page-section
container.

To test, apply the patch and go to Cataloging -> Batch record
modification.

Submit a batch of bibliographic record numbers and a batch of authority
record numbers. In both cases the page which previews the list of
submitted records in a table should be correctly styled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:18:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:18:28 +0000
Subject: [Koha-bugs] [Bug 32258] New: ITEMTYPECAT groups only show on OPAC
 adavnced search page
Message-ID: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

            Bug ID: 32258
           Summary: ITEMTYPECAT groups only show on OPAC adavnced search
                    page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If you add some ITEMTYPECAT categories and then assign some item types to that
group and go the OPAC advanced search you will see the ITEMTYPECAT group appear
with the other item types. 

They do not not appear in the staff client adavnced search or item search. They
should probably appear on both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:25:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:25:13 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-ZLcuXpGP7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff interface             |Templates
            Summary|Add page-section to list of |Add page-section to label
                   |items in label batch        |creator pages
                   |(tools)                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:26:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:26:04 +0000
Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC
 advanced search page
In-Reply-To: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32258-70-vrNX2kSdAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ITEMTYPECAT groups only     |ITEMTYPECAT groups only
                   |show on OPAC adavnced       |show on OPAC advanced
                   |search page                 |search page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:26:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:26:21 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-V9QTWRJqr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:26:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:26:27 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-zyQ2KSzHMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144010|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 144031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144031&action=edit
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:26:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:26:43 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-7REFdGLhju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:26:44 +0000
Subject: [Koha-bugs] [Bug 32234] Add page-section to list of imported
 records (cat)
In-Reply-To: <bug-32234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32234-70-2hUmSGkNSH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32234

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:26:44 +0000
Subject: [Koha-bugs] [Bug 32235] Add page-section to list of staged files
 (acq)
In-Reply-To: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32235-70-n3bi9WXvVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:28:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:28:13 +0000
Subject: [Koha-bugs] [Bug 32252] Number of results in a facet do not show
 after facet selection
In-Reply-To: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32252-70-si8xn0Tp18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32252

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Confirmed on master. In the staff client the (n) will not show after making a
selection, only the [x].

However, it does show the number after making a selection when searching in the
OPAC. 

Ultimately, they should function the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:33:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:33:20 +0000
Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC
 advanced search page
In-Reply-To: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32258-70-iUTySnnkml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure about this one. Maybe it could be a preference or a separate tab
on advanced search in staff? I could imagine that staff needs the more granular
search option while they want to group for users.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:36:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:36:56 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-Z6burtkEsi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:37:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:37:00 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-7wSGazCZNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144032&action=edit
Bug 32238: Add page-section to label creator pages

This patch modifies two label creator templates so that a .page-section
container is used to wrap main content.

To test, apply the patch and go to Cataloging -> Label creator.

 - Click Manage -> Label batches.
   - The display of existing batches should look correct.
 - Click "Edit" on one of the label batches.
   - If necessary, submit a set of barcodes or item numbers to add to
     the batch.
   - The display of items in the table of items should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:41:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:41:00 +0000
Subject: [Koha-bugs] [Bug 32234] Add page-section to list of imported
 records (cat)
In-Reply-To: <bug-32234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32234-70-hNzL2Yreey@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32234

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 31774 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:41:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:41:00 +0000
Subject: [Koha-bugs] [Bug 31774] Add 'page-section' to Manage staged MARC
 records page
In-Reply-To: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31774-70-WOqWABapXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31774

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 32234 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:41:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:41:01 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-VQuatdsbkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
Bug 31757 depends on bug 32234, which changed state.

Bug 32234 Summary: Add page-section to list of imported records (cat)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:49:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:49:53 +0000
Subject: [Koha-bugs] [Bug 32235] Add page-section to list of staged files
 (acq)
In-Reply-To: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32235-70-mgwWeSWTOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 32046 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:49:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:49:53 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-CfPKS3Rmmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 32235 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:49:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:49:53 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-RLxxm7QTE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
Bug 31757 depends on bug 32235, which changed state.

Bug 32235 Summary: Add page-section to list of staged files (acq)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32235

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:54:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:54:36 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-AUol88Thnl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:57:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:57:23 +0000
Subject: [Koha-bugs] [Bug 112] Borrowed items location show as "Not
 available"
In-Reply-To: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-112-70-QuVvJ9DsKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=112

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144033&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:57:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:57:27 +0000
Subject: [Koha-bugs] [Bug 112] Borrowed items location show as "Not
 available"
In-Reply-To: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-112-70-ELijWbiENs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=112

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144034&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:59:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:59:01 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-0B61ppuV7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 20:59:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 19:59:05 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-uNvWk8jGtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144031|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144035&action=edit
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

Signed-off-by: David <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:03:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:03:56 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-OgnE6d9qS5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:04:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:04:01 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-3vlZ4AzprV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144032|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144036&action=edit
Bug 32238: Add page-section to label creator pages

This patch modifies two label creator templates so that a .page-section
container is used to wrap main content.

To test, apply the patch and go to Cataloging -> Label creator.

 - Click Manage -> Label batches.
   - The display of existing batches should look correct.
 - Click "Edit" on one of the label batches.
   - If necessary, submit a set of barcodes or item numbers to add to
     the batch.
   - The display of items in the table of items should look correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:04:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:04:31 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-YutgANwlgt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Straight to Tomas with this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:07:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:07:48 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-Kwd20IBTHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:07:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:07:53 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-q8X2GaZlHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144029|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144037&action=edit
Bug 32198: Add page-section to stock rotation stages list (cat)

This patch adds a .page-section container around relevant areas of the
stock rotation management interface.

Also changed: Removed a .dialog.message container which was not correct.

To test, apply the patch and go to Cataloging -> Stock rotation.

- If necessary, add a rota.
- Click Manage -> Stages on your rota.
  - If neccesary, create one or more stages.
  - The display of stages should look correct.
- From the list of rotas click Manage -> Items.
  - Click "Add items" and use a barcode file to add multiple items at
    once.
  - The page confirming your submission, with a list of items, should
    have a page-section.
  - Return to the view of items in the rota. The display of items should
    look correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:08:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:08:43 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-hoLqvgDgkd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144037|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144038&action=edit
Bug 32198: Add page-section to stock rotation stages list (cat)

This patch adds a .page-section container around relevant areas of the
stock rotation management interface.

Also changed: Removed a .dialog.message container which was not correct.

To test, apply the patch and go to Cataloging -> Stock rotation.

- If necessary, add a rota.
- Click Manage -> Stages on your rota.
  - If neccesary, create one or more stages.
  - The display of stages should look correct.
- From the list of rotas click Manage -> Items.
  - Click "Add items" and use a barcode file to add multiple items at
    once.
  - The page confirming your submission, with a list of items, should
    have a page-section.
  - Return to the view of items in the rota. The display of items should
    look correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:11:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:11:35 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-3xeoQujVLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Straight to Tomas with this one as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:12:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:12:33 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-daIQtikpfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
A follow-up is also needed for the "Older transactions" section:*

1. Go to Transaction history for
2. In the "Older transactions" section enter a from date, for example: 1
November 2022
3. Click "Display"
4. Result: table (with no entries) has no page-section

* Need to enable the UseCashRegisters system preference and add a cash register

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:13:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:13:55 +0000
Subject: [Koha-bugs] [Bug 112] Borrowed items location show as "Not
 available"
In-Reply-To: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-112-70-XBmpOxokK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144033|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:14:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:14:09 +0000
Subject: [Koha-bugs] [Bug 112] Borrowed items location show as "Not
 available"
In-Reply-To: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-112-70-kqSgOh5smL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144034|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:19:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:19:01 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-Fs9ABMvV5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:19:05 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-z4t4DRDBUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144030|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144039&action=edit
Bug 32241: Add page-section to list of records in batch record modificaton
(tool)

This patch modifies the batch record modification page template so that
the preview of submitted records is contained in a .page-section
container.

To test, apply the patch and go to Cataloging -> Batch record
modification.

Submit a batch of bibliographic record numbers and a batch of authority
record numbers. In both cases the page which previews the list of
submitted records in a table should be correctly styled.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:19:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:19:24 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-oFeAgLDUpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
... doing it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:20:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:20:18 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-gycrvhNVew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:20:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:20:29 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-xRdoxVukbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Asked Owen if I could steal that one :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:21:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:21:20 +0000
Subject: [Koha-bugs] [Bug 32247] HoldsQueue does not need to check items if
 there are no holds
In-Reply-To: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32247-70-XMprg13ySw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:21:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:21:25 +0000
Subject: [Koha-bugs] [Bug 32247] HoldsQueue does not need to check items if
 there are no holds
In-Reply-To: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32247-70-A2ROfjEvj0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32247

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144001|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 144040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144040&action=edit
Bug 32247: Exit holds queue builder if there are no holds on the biblio

update_queue_for_biblio currently
1 - gets the holds on a bib
2 - gets the items available to fill any holds
3 - combines these to build the queue, exiting if there are no holds or items

If there are no holds at step 1, we don't need to do step 2 or 3
This patch simply deletes the queue for this biblio, then exits if there are no
holds

To test:
prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t
t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t
t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t
t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:40:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:40:52 +0000
Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page
In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32061-70-s5EUzDkiOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144024|0                           |1
        is obsolete|                            |

--- Comment #3 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144041&action=edit
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.

Signed-off-by: David <david at davidnind.com>
Signed-off-by: hammat <hammat at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 21:41:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 20:41:43 +0000
Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC
 advanced search page
In-Reply-To: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32258-70-gE5RemSuVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

Catrina Berka <catrina at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catrina at bywatersolutions.co
                   |                            |m

--- Comment #2 from Catrina Berka <catrina at bywatersolutions.com> ---
It would be ideal if the expanded and collapsed versions of the search were
available, so staff could search for all Movies (DVD and Blu-Ray) and narrow
down to preferred format.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:14:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:14:54 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-05LzqzoWBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

--- Comment #3 from geraud.frappier at inlibro.com ---
Created attachment 144042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144042&action=edit
Bug 32255 : Resolve "Cannot use file upload in batch record modification"

When using the batch record modification tool with a file of biblionumbers,
nothing happens. When we click 'Continue' the file is somehow removed before
continuing.

To test:
1. Get a file of biblionumbers (if you already have a file, proceed to step 2)
   1.1. Go to Reports
   1.2. Click on 'Create from SQL'
   1.3. Enter a report name (e.g. biblionumbers)
   1.4. Enter the following SQL query

SELECT biblionumber FROM biblio LIMIT 100

   1.5. Click 'Save report'
   1.6. Click 'Run report'
   1.7. Click 'Download' > 'Tab separated text'

2. Create a MARC modification template (if you already have a MARC modification
template, proceed to step 3)
   2.1. Go to Cataloging > MARC modification template
   2.2. Click 'New template'
   2.3. Enter a template name (e.g. Add note)
   2.4. Click 'Submit'
   2.5. Click 'New action'
   2.6. Choose
        - Add new
        - Field 500 a
        - with value Note
   2.7. Click 'Add action'

3. Batch modify records
   3.1. Go to Cataloging > Batch record modification
   3.2. In the 'Upload a file tab', choose the biblionumber file
   --> Note that the name of the file appears next to the Choose button
   3.3. In 'Template', select the MARC modification template
   3.4. Click 'Continue'
   --> The name of the file disappears next to the Choose button and goes back
to 'No file chosen'
   --> Message 'No records were modified

4. Apply path
   4.1. Procede step 3.
   4.2. See that we can see the list now

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:15:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:15:49 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-7fiYzLSx4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

geraud.frappier at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geraud.frappier at inlibro.com
                   |                            |,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:16:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:16:28 +0000
Subject: [Koha-bugs] [Bug 31994] Clicking the next button of a DataTable
 loading its data from the HTML does nothing
In-Reply-To: <bug-31994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31994-70-OOnRVNnP5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994

Olivier Hubert <olivier.hubert at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:17:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:17:08 +0000
Subject: [Koha-bugs] [Bug 31074] Plugin metadata is kept in cache after
 uninstalling a plugin
In-Reply-To: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31074-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31074-70-BAWcUfe3wR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

Olivier Hubert <olivier.hubert at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:35:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:35:19 +0000
Subject: [Koha-bugs] [Bug 32259] New: Date inputs too small in tables
Message-ID: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32259

            Bug ID: 32259
           Summary: Date inputs too small in tables
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Since Bug 31943 reduced the width of date inputs, the display in tables like
holds table is too small.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:35:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:35:27 +0000
Subject: [Koha-bugs] [Bug 32259] Date inputs too small in tables
In-Reply-To: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32259-70-qDTX5MzmK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32259

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31943


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943
[Bug 31943] Date inputs wider than other inputs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:35:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:35:27 +0000
Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs
In-Reply-To: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31943-70-5JMvFiTyq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32259


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32259
[Bug 32259] Date inputs too small in tables
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:36:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:36:07 +0000
Subject: [Koha-bugs] [Bug 32259] Date inputs too small in tables
In-Reply-To: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32259-70-zx9DeYFivs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32259

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144043&action=edit
Screenshot without patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:38:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:38:30 +0000
Subject: [Koha-bugs] [Bug 32259] Date inputs too small in tables
In-Reply-To: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32259-70-KayeGrBiiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32259

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Needs a min-width ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:39:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:39:19 +0000
Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs
In-Reply-To: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31943-70-GcmWsiIvmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Arf this has impact on display in tables such as holds table.
I created Bug 32259

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:54:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:54:23 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-O9ObwN7MXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 17 22:54:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 21:54:27 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-Rz1MReyXsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144044&action=edit
Bug 32200: Add page-section to checkout notes page

To test:
* Turn on AllowCheckoutNotes system preference
* Check out an item
* Go to the OPAC and add a checkout note to your checkout
* In the staff interface, look at: Circulation > Checkout notes
* Verify the page section is missing from the notes table
* Apply patch
* Verify the table now looks better!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 00:47:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Nov 2022 23:47:22 +0000
Subject: [Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in
 OPAC search results
In-Reply-To: <bug-29603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29603-70-c94yvBNpwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.05.00;21.11.14           |22.05.00;21.11.14,21.05.21
        released in|                            |
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for the upcoming release (21.05.21)

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:12:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:12:16 +0000
Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category
 breaks patron search
In-Reply-To: <bug-31421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31421-70-VJCeK2hwfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
21.05.x not affected, no backport.
Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:17:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:17:24 +0000
Subject: [Koha-bugs] [Bug 31863] Advanced cataloging editor no longer
 auto-resizes
In-Reply-To: <bug-31863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31863-70-AU7OnEG9Kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31863

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:18:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:18:18 +0000
Subject: [Koha-bugs] [Bug 31379] Change results per page text for default
In-Reply-To: <bug-31379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31379-70-bLGfOhbmGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:18:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:18:51 +0000
Subject: [Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with
 GetMarcUrls for whitespace
In-Reply-To: <bug-30262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30262-70-KgCJZV0npU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:19:45 +0000
Subject: [Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect
 calendar when calculating expiration date for holds
In-Reply-To: <bug-31356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31356-70-zK6oL3qwmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:20:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:20:18 +0000
Subject: [Koha-bugs] [Bug 30231] Don't display (rejected) forms of series
 entry in search results
In-Reply-To: <bug-30231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30231-70-1g4Yjo1mtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 02:21:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 01:21:46 +0000
Subject: [Koha-bugs] [Bug 31488] Rephrase "You have checked out too many
 items" to be friendlier
In-Reply-To: <bug-31488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31488-70-2znmYXOKaJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Needs documenting
                 CC|                            |victor at tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Maybe the message is somewhere in the documentation or a screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 03:03:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 02:03:20 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-Zbda2InvVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #8)
> Just to add, I don't like 'remaining' permisssions - it is very unclear to
> the end user what exactly these are - I know they are 'everything not listed
> elsewhere' but it comes off as somewhat ambiguous

Agreed. Circulation could benefit from more granular permissions, or even a
rename of that one I suppose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 03:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 02:10:55 +0000
Subject: [Koha-bugs] [Bug 32036] Cannot set single sub-permission without
 also setting the top level flag
In-Reply-To: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32036-70-nKA2Eh67mS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32036

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #8)
> Just to add, I don't like 'remaining' permisssions - it is very unclear to
> the end user what exactly these are - I know they are 'everything not listed
> elsewhere' but it comes off as somewhat ambiguous

Of course, Koha's permission system could use a complete overhaul anyway.

Personally, I'd like a policy based access control that evaluated subject,
object, operation, and perhaps environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 06:50:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 05:50:56 +0000
Subject: [Koha-bugs] [Bug 32104] Console error on additional_content.pl
 after saving
In-Reply-To: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32104-70-Gcv4vbfoSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32104

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #11)
> Pushed to master for 22.11.

Did you get the warning?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:00:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:00:16 +0000
Subject: [Koha-bugs] [Bug 32175] Item info not cloning when receiving
 multiple items due to Flatpickr issue
In-Reply-To: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32175-70-4QcDlPzBfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32175

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Closing, please reopen if needed.

*** This bug has been marked as a duplicate of bug 23202 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:00:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:00:16 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-09de2O2V5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 32175 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:19:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:19:37 +0000
Subject: [Koha-bugs] [Bug 31364] Saving multi-select system preference don't
 save when all checks are removed
In-Reply-To: <bug-31364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31364-70-cSoUDYGND8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Doesn't affect 21.05.x, not backported.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:32:11 +0000
Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require
 full serials permission
In-Reply-To: <bug-29608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29608-70-EFvODzsl0P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:43:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:43:34 +0000
Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs
In-Reply-To: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31943-70-li0TJ26udT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
And this one is still way too wide: https://snipboard.io/Ym1QqO.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:44:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:44:17 +0000
Subject: [Koha-bugs] [Bug 31943] Date inputs wider than other inputs
In-Reply-To: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31943-70-1qDT2gC6eY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31943

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
And this one is still way too wide: https://snipboard.io/N6Omph.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 07:57:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 06:57:15 +0000
Subject: [Koha-bugs] [Bug 23962] We should drop support for Debian 8 Jessie
 and Debian 9 Stretch
In-Reply-To: <bug-23962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23962-70-swAE1dJG8W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23962

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I dropped it from the dashboard today too

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:14:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:14:05 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-oKnMhrfQp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:14:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:14:15 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-C6OsXfNyOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:14:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:14:26 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-fr2dm1eLco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:14:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:14:36 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-z7TTFiFVgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:15:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:15:07 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-r8bDMOFzrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #85 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changed status to get attention from RM for last two follow-ups. Thx.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:42:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:42:29 +0000
Subject: [Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when
 language cookie was removed
In-Reply-To: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32251-70-LVnm4D1qtk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:42:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:42:33 +0000
Subject: [Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when
 language cookie was removed
In-Reply-To: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32251-70-XD64035nUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144045&action=edit
Bug 32251: Add a fallback for when language cookie was removed

Since we remove cookies after logout now, the language cookie
might not be there yet. It is friendlier to add the template
language fallback here now too before switching to 'default' in
the Additional contents (AC)-context.

Note: The cookie will not be removed when you added it to the list
in koha-conf.xml.

Note2: This only pertains to the use of opac-page with code param.

Test plan:
[1] Create a CMS page with AC. Add two languages (say en, nl-NL).
    Add different text to default and both languages.
[2] Remove the KohaOPACLanguage cookie from your browser (via
    dev console).
[3] Without this patch, copy the Current language URL from the AC
    overview page. (Note that the Default URL always refers you to
    'default'.)
[4] Go to that page with the selected (Current..) URL. Observe that
    you still see the 'default' text.
[5] Remove the cookie again if it might be there already.
[6] With this patch, observe that you get the language of the
    interface now on the CMS page using the same URL.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:43:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:43:08 +0000
Subject: [Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when
 language cookie was removed
In-Reply-To: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32251-70-L0uTF8nhKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 08:44:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 07:44:14 +0000
Subject: [Koha-bugs] [Bug 32251] opac-page.pl: Add a fallback for when
 language cookie was removed
In-Reply-To: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32251-70-vfRnJZDfuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32251

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 09:51:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 08:51:21 +0000
Subject: [Koha-bugs] [Bug 32260] New: Prevent alert when searching patron
 (autocomplete)
Message-ID: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

            Bug ID: 32260
           Summary: Prevent alert when searching patron (autocomplete)
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 09:52:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 08:52:05 +0000
Subject: [Koha-bugs] [Bug 32261] New: Insufficient user feedback when
 selecting patron in autocomplete
Message-ID: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

            Bug ID: 32261
           Summary: Insufficient user feedback when selecting patron in
                    autocomplete
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 09:57:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 08:57:44 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-BKMRTVQVDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 09:57:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 08:57:49 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-OTYEDOgQlU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144046&action=edit
Bug 32261: Patron autocomplete - do not empty text field

The jQuery UI autocomplete is supposed to replace the text field with
the 'value' attribute of the selected item. As it does not exist it's
emptied. We should not replace what the user typed in.

Test plan:
Go to the Koha home page
Select "Search patrons" in the header
Type 'edn', it will return 1 result
Use the down key to select the item (it is not obvious but there is a
little change in the color when you select the item)
=> Without this patch the search field is emptied
=> With this patch applied the search field is not modified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 09:57:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 08:57:54 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-GBVYowKE8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144047&action=edit
Bug 32261: Add more UI feedback when selecting patron from autocomplete

There is only a tiny change in the color of the selected item, but it's
not obvious.

Test plan:
Regenerate the css files using `yarn build`
Search for patrons and note that the down/up keys let you select a
patron and the background color change.
Note that the background color is not on the container and so is not
similar as the hover rule (when using the mouse). We could change that,
but then the behaviour is weird when you have both the mouse and the
keyboard selecting items in the item list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:06:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:06:02 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-PqAIuq0Fom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:06:30 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-ZVn0oH2VHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:06:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:06:34 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-PbSeSmcLzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144048&action=edit
Bug 32260: Patron autocomplete - Do not display an alert if request is rejected

Not sure what is going on exactly, neither if this patch is the correct
way to fix this.
The request is "rejected" at some point (by the browser?), when we
search for patrons using the autocomplete and DT "at the same time".

To recreate:
Don't apply this patch
Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5
Search for "edn" then hit enter
You may see an alert, that will disappear
If you don't see the alert, repeat

This patch suggests to ignore the alert if the status of the request is
"rejected".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:07:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:07:10 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-kbY6HO1Mwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:10:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:10:42 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-T3s9neufUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:10:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:10:46 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-VvBfKXLGEr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143976|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144049&action=edit
Bug 32237: Fix using a list as base for batch record deletion

When a list was used to select records for batch deletion, the
record IDs were no longer found.

To test:

1. Go to Lists in the intranet.
2. Add a list by clicking on "New list". Choose a random name for it and select
private or public and save.
3.Add one or more items into it and save.
4.Go back to the main page and select "Cataloging".
5.Go to "Batch record deletion".
6.In "upload a file" select "Select a list of records" and choose a list and
keep the Bibliographic on.
7.Select continue and see that the list of records is not shown.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:11:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:11:01 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-AiFsRMBZ7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:12:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:12:29 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-jMhApIGSpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   FAIL   js_in_body
                A <script> tag found inside head, must be moved to the body
(see bug 17858)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:27:00 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-RnMJXhcyIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:36:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:36:13 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-hiyhYxBFdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32261

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:36:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:36:13 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-26VGNJiK4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32260

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:37:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:37:05 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-zzEcoMAkH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:39:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:39:45 +0000
Subject: [Koha-bugs] [Bug 31933] Import patrons fails when patron attribute
 value contains a comma
In-Reply-To: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31933-70-vIcNjqnfer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:40:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:40:53 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-KGIQ779m75@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> Note that there is still a problem, if none of the 3 inputs is filled,
> no rule will be created (ie. action ignored)

|  99 | NULL       | NULL         | NULL     | patron_maxissueqty              
|            |
| 100 | NULL       | NULL         | NULL     | patron_maxonsiteissueqty        
|            |
| 101 | NULL       | NULL         | NULL     | max_holds                       
|            |
| 102 | NULL       | B            | NULL     | patron_maxonsiteissueqty        
|            |
| 103 | NULL       | B            | NULL     | patron_maxissueqty              
|            |
| 104 | NULL       | B            | NULL     | max_holds                       
|            |

Looks like the rule is created though?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:41:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:41:48 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-n5CJFTyBln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #12)
> > Note that there is still a problem, if none of the 3 inputs is filled,
> > no rule will be created (ie. action ignored)
> 
> Looks like the rule is created though?

Ah. The rule is there but it is not shown on the interface !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:42:38 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-s0WN9di11T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I had something similar the other day with open_article_requests_limit. See bug
27945

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:45:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:45:20 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-eJiupMMPef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Should we open a new bug report for that? Or is it already somewhere?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:46:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:46:25 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-CWETK4MTXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:46:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:46:29 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-tjncgdfd5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144011|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144050&action=edit
Bug 30794: Insert blank rule (unlimited) for max_holds

Related to bug 24669, why didn't we use strip_non_numeric for one occurrence?

Note that there is still a problem, if none of the 3 inputs is filled,
no rule will be created (ie. action ignored)

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:46:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:46:45 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-vF1ZYkAi3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:46:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:46:56 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-8OCQb1oGFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:49:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:49:18 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-7QHsP8zqon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's a false positive, I checked with Owen when I signed off and he also noted
in the commit:

> Note that the QA tool's js_in_body error is invalid for this template
> which requires that the JS stay inside <head>.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:49:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:49:19 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-V3yJec7SSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #12)
> Shame this didn't make it in time for 22.11

It contains strings. Sorry ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:49:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:49:27 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-QSPrhseQge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:50:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:50:23 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-1F6fZMpscc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:51:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:51:54 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-fYYRsVsUaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:53:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:53:36 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-qQIuuJEFOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We have had some incremental updates to the po files. Maybe we put this in
Tomas queue and when something bad requires a string change, this could be
pushed with it before we run another update.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 10:59:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 09:59:25 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-uNpZku9aaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #15)
> Should we open a new bug report for that? Or is it already somewhere?

I haven't created it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:00:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:00:44 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-XKRngbUsPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:00:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:00:48 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-c5C6e0Tl01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143909|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144051&action=edit
Bug 32045: Use bootstrap tabs to select item tab

When the form to add orders from a staged file is validated, we use
toptabs functionality to switch to the item tab if there are missing fields.

The display now uses bootstrap tabs, so the JS is throwing an error:
Uncaught Error: cannot call methods on tabs prior to initialization; attempted
to call method 'option'

This patch simply switches the call to switch tabs

To test:
1 - Stage a file for import
2 - Either use Marc(Item)FieldsToOrder to populate the orders
    or select a budget on the third tab
3 - View the second tab, items info, confirm itemtype is required, but don't
populate it
4 - Attempt to save order, nothing happens
5 - Check the JS console (F12)
6 - Note the error:
    Uncaught Error: cannot call methods on tabs prior to initialization;
attempted to call method 'option'
7 - Apply patch
8 - Cancel and add from staged file again
9 - Select a budget and save
10 - You now get an error popup: Some required item subfields are not set
11 - Confirm after the error you are shown the items tab
12 - Select itemtype
13 - Save
14 - Confirm orders added successfully

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:05:58 +0000
Subject: [Koha-bugs] [Bug 32262] New: smart-rules: Some rules can be created
 but are not visible on interface
Message-ID: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

            Bug ID: 32262
           Summary: smart-rules: Some rules can be created but are not
                    visible on interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

See e.g. bug 30794 and bug 27945.
On 30794 you can create a rule with all inputs blank for a patron category
under 'Default checkout, hold policy by patron category'. You wont see it.
Same for creating an rule for open_article_request_limit outside the interface
though (bad practice generally) with itemtype NULL iirc. You wont see it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:06:35 +0000
Subject: [Koha-bugs] [Bug 32262] smart-rules: Some rules can be created but
 are not visible on interface
In-Reply-To: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32262-70-nKLHHTglCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30794, 27945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794
[Bug 30794] 'Default checkout, hold and return policy' overrides Unlimited
holds in 'Default checkout, hold policy by patron category'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:06:35 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-Sg3kJqOeZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262
[Bug 32262] smart-rules: Some rules can be created but are not visible on
interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:06:35 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-0y53MbWBYN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262
[Bug 32262] smart-rules: Some rules can be created but are not visible on
interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:13:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:13:02 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-5zfrVp5ayP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Ah, I see:
[%# As long as cataloging plugins rely on 'script' tags added inline, JS must
be in the header %]
<script>
    const template_path = "[% interface | html %]/[% theme | html %]";
</script>

Katrin: You switched status. But you did not add signoff lines ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:15:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:15:55 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-FWyQusyUbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Actually, there are such large changes in a template that I cant oversee if we
somewhere add string changes at this time before release..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:18:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:18:31 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-U87EGpQJE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #21)
> Actually, there are such large changes in a template that I cant oversee if
> we somewhere add string changes at this time before release..

Ah, will fix. It's my usual mistake when I forget to git stash the yarn. The
git so then fails a bit too silently.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:20:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:20:57 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-guSl07YdJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144027|0                           |1
        is obsolete|                            |

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144052&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:21:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:21:02 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-yIE4YyqYOq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144028|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144053&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:25:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:25:47 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-emyukMqbA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
        if ( ref($_) eq 'Koha::Exceptions::Object::DuplicateID' ) {
            return $c->render(
                status  => 409,
                openapi => {
                    error => 'Item is already bundled',
                    key   => $_->duplicate_id
                }
            );
        }
        elsif ( ref($_) eq 'Koha::Exceptions::Item::Bundle::IsBundle' ) {
            return $c->render(
                status => 400,
                openapi => {
                    error => 'Bundles cannot be nested'

Somehow I wonder why we differentiate here between 400 and 409 ? 400 is the
general failure, 409 is a conflict. The nested bundle could be a 409 too. But I
would not mind having both on 400 as well. This seems inconsistent.
No blocker, easily to be adjusted..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:26:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:26:59 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-0Sm9RZGfSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Dont forget the template btw:

+                      } else if ( data.status === 400 ) {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:29:45 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-iFzk6i45XE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:29:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:29:49 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-MvB9jrttZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143991|0                           |1
        is obsolete|                            |

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144054&action=edit
Bug 31080: Unit tests

Unit tests for add_to_bundle functionality that prevents bundle nesting.

Test plan
1) Run t/db_dependent/Koha/Item.t
2) The test should fail
3) Apply the second patch
4) Re-run the test and watch it pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:29:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:29:52 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-my1R7FpXc8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143992|0                           |1
        is obsolete|                            |

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144055&action=edit
Bug 31080: Prevent bundles from being nested

This is a follow-up for bug 28854 to prevent bundle type items from
being nested in to other bundles.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:30:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:30:38 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-mN7759FOTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #14)
> We have had some incremental updates to the po files. Maybe we put this in
> Tomas queue and when something bad requires a string change, this could be
> pushed with it before we run another update.

Tomás: Do as you please :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:33:08 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-ZsYHOj4mLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:35:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:35:17 +0000
Subject: [Koha-bugs] [Bug 32263] New: Capitalization: ...and on the
 Libraries page in the OPAC.
Message-ID: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263

            Bug ID: 32263
           Summary: Capitalization: ...and on the Libraries page in the
                    OPAC.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Full string:

Set to 'yes' to show this library as a search option and on the Libraries page
in the OPAC.

koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt:303

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:37:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:37:47 +0000
Subject: [Koha-bugs] [Bug 32264] New: Capitalization/Terminology: Show in
 Staff client?
Message-ID: <bug-32264-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264

            Bug ID: 32264
           Summary: Capitalization/Terminology: Show in Staff client?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Show in Staff client?

Should be: 
Show in staff interface

Appears in multiple spots:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt:83
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt:64
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:733

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:37:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:37:57 +0000
Subject: [Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries
 page in the OPAC.
In-Reply-To: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32263-70-vF1LUbBw4v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:41:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:41:38 +0000
Subject: [Koha-bugs] [Bug 32265] New: Terminology: Staff client
Message-ID: <bug-32265-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32265

            Bug ID: 32265
           Summary: Terminology: Staff client
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Staff client should be staff interface on:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt:47

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:58:43 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-vYqdAvN5NI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:58:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:58:47 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-OwWVnKaKLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143955|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144056&action=edit
Bug 31891: (bug 27421 follow-up) Remove one additional click

>From comment 0
"""
Moving marc batch import actions to background jobs has introduced some
confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 11:59:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 10:59:41 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-9Rc0o6HCrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Does not include new strings.

Strings are already present:
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc:
           <a
href="/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=[%
report.import_batch_id | uri %]">View batch</a>
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc:
           <a id="addtobasket" class="btn btn-default"
href="/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=[%
report.import_batch_id | html %]&basketno=[% report.basket_id | html
%]&booksellerid=[% report.vendor_id | html %]">Add staged files to basket</a>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 12:00:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 11:00:04 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-X3Yi1aXCqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 12:00:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 11:00:45 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-63m5CxPp7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You could argue that this patch is somewhere between bug and enhancement..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:05:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:05:42 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-8qPhfNEKiZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:05:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:05:46 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-33bHI20nkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144048|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144057&action=edit
Bug 32260: Patron autocomplete - Do not display an alert if request is rejected

Not sure what is going on exactly, neither if this patch is the correct
way to fix this.
The request is "rejected" at some point (by the browser?), when we
search for patrons using the autocomplete and DT "at the same time".

To recreate:
Don't apply this patch
Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5
Search for "edn" then hit enter
You may see an alert, that will disappear
If you don't see the alert, repeat

This patch suggests to ignore the alert if the status of the request is
"rejected".

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:10:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:10:43 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-9U9UpAy8Jl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I was able to reproduce this problem by following the test plan, bug
specifically:

- You must search for a string which will return only one result.
- You must enter the string and hit ENTER before the autocomplete has time to
show any results. I was able to do this by copying the string and using Ctrl-V
to quickly paste and hit enter right away.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:20:16 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-i2KztyE63u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:20:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:20:24 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-jS9fPWOMHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144046|0                           |1
        is obsolete|                            |
 Attachment #144047|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144058&action=edit
Bug 32261: Patron autocomplete - do not empty text field

The jQuery UI autocomplete is supposed to replace the text field with
the 'value' attribute of the selected item. As it does not exist it's
emptied. We should not replace what the user typed in.

Test plan:
Go to the Koha home page
Select "Search patrons" in the header
Type 'edn', it will return 1 result
Use the down key to select the item (it is not obvious but there is a
little change in the color when you select the item)
=> Without this patch the search field is emptied
=> With this patch applied the search field is not modified

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:20:30 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-v3j3IJJMt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144059&action=edit
Bug 32261: Add more UI feedback when selecting patron from autocomplete

There is only a tiny change in the color of the selected item, but it's
not obvious.

Test plan:
Regenerate the css files using `yarn build`
Search for patrons and note that the down/up keys let you select a
patron and the background color change.
Note that the background color is not on the container and so is not
similar as the hover rule (when using the mouse). We could change that,
but then the behaviour is weird when you have both the mouse and the
keyboard selecting items in the item list.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:38:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:38:49 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-HWkNVGgBwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

Jonathan Cuéllar <jcautomatizacion at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|22.05                       |20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:39:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:39:22 +0000
Subject: [Koha-bugs] [Bug 27761] Koha is reporting deleted items when a
 pickup is done by OAI
In-Reply-To: <bug-27761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27761-70-yal3AJcuiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27761

Jonathan Cuéllar <jcautomatizacion at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Cataloging                  |Lists

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:39:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:39:48 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-jbOrtjpTjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

Jonathan Cuéllar <jcautomatizacion at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Cataloging                  |Lists

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:40:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:40:29 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-pl8XxHAvIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

Jonathan Cuéllar <jcautomatizacion at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Lists                       |Cataloging
            Version|20.05                       |22.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:47:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:47:00 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-RpgC1RpNvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

--- Comment #2 from Jonathan Cuéllar <jcautomatizacion at gmail.com> ---
Hi Katrin,

This bug started in version 21.05 and then I did a couple of updates until
22.05.
Install a new instance from scratch and the error remains.

In the new instance of koha 22.05 I have the following errors recorded in the
log:

[Thu Nov 17 11:57:22.898804 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: Template process failed: undef error - The
method Koha::KeyboardShortcuts->shortcut_keys is not covered by tests!:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.899004 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: :
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.899121 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: Trace begun at
/usr/share/koha/lib/Koha/Objects.pm line 572:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.899366 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
Koha::Objects::AUTOLOAD('Koha::KeyboardShortcuts=HASH(0x5574c79f6d20)') called
at
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/cataloguing/editor.tt
line 334: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.899522 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: eval {...} at
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/cataloguing/editor.tt
line 334: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.899676 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: eval {...} at
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/cataloguing/editor.tt
line 332: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.899825 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: eval {...} at
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/cataloguing/editor.tt
line 18: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.900009 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
Template::Provider::_ANON_('Template::Context=HASH(0x5574c53f7128)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template/Document.pm line 163:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.900135 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: eval {...} at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template/Document.pm line 161:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.900351 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
Template::Document::process('Template::Document=HASH(0x5574c7a69518)',
'Template::Context=HASH(0x5574c53f7128)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template/Context.pm line 351:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.900515 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: eval {...} at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template/Context.pm line 321:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.900723 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
Template::Context::process('Template::Context=HASH(0x5574c53f7128)',
'Template::Document=HASH(0x5574c7a69518)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template/Service.pm line 94:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.900845 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215: eval {...} at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template/Service.pm line 91:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.901089 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
Template::Service::process('Template::Service=HASH(0x5574c53c19d0)',
'/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/cataloguing/editor.tt',
'HASH(0x5574c7a22a70)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.30/Template.pm line 66:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.901340 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
Template::process('Template=HASH(0x5574c53cb398)',
'/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES/modules/cataloguing/editor.tt',
'HASH(0x5574c7a22a70)', 'SCALAR(0x5574c15d4368)') called at
/usr/share/koha/lib/C4/Templates.pm line 127:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.901493 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] AH01215:
C4::Templates::output('C4::Templates=HASH(0x5574c53caf00)') called at
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl line 86:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl
[Thu Nov 17 11:57:22.930560 2022] [cgi:error] [pid 833718] [client
186.102.16.136:36960] End of script output before headers: editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:50:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:50:18 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-GRT7gC9N93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 13:50:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 12:50:23 +0000
Subject: [Koha-bugs] [Bug 32200] Add page-section checkout notes page (circ)
In-Reply-To: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32200-70-nq06bOMdio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32200

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144044|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 144060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144060&action=edit
Bug 32200: Add page-section to checkout notes page

To test:
* Turn on AllowCheckoutNotes system preference
* Check out an item
* Go to the OPAC and add a checkout note to your checkout
* In the staff interface, look at: Circulation > Checkout notes
* Verify the page section is missing from the notes table
* Apply patch
* Verify the table now looks better!

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:02:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:02:55 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-ZwcwbVqngx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144061&action=edit
Bug 32154: Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:03:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:03:10 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-suQTlQeY3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:09:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:09:08 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-6ge1c6hz4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #87 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
+    is( Koha::BackgroundJobs->search_limited->count, 0, 'No jobs found without
userenv' );

This is wrong if jobs exist.

Jenkins is failing because of this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:12:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:12:15 +0000
Subject: [Koha-bugs] [Bug 32266] New: Large amount of late orders slows the
 service
Message-ID: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266

            Bug ID: 32266
           Summary: Large amount of late orders slows the service
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

Almost all our library consortiums have large amounts of late orders. Smallest
amount is around 2000, but largest is over 25000. Even with batch of 2000
orders, lateorders.pl takes over 40 seconds to open. Handling larger batches
eventually leads to a Proxy error. 

One (quite easy imo) way to speed up fetching late orders is to add a syspref
to set default value for late order filter "Order date: [] days ago".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:14:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:14:53 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-xrZZCJy4cY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #88 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I don't recreate locally. I've run the different tests that (directly) insert
background jobs, there are some leftover in the DB, but the tests are still
passing.

21:28:55 koha_1       |     #   Failed test 'No jobs found without userenv'
21:28:55 koha_1       |     #   at t/db_dependent/Koha/BackgroundJobs.t line
135.
21:28:55 koha_1       |     #          got: '2'
21:28:55 koha_1       |     #     expected: '0'
21:28:55 koha_1       |     # Looks like you failed 1 test of 3.
21:28:55 koha_1       | 
21:28:55 koha_1       | #   Failed test 'search_limited'
21:32:22 koha_1       | #   at t/db_dependent/Koha/BackgroundJobs.t line 142.
21:32:22 koha_1       | # Looks like you failed 1 test of 15.
21:32:22 koha_1       | [20:28:55] t/db_dependent/Koha/BackgroundJobs.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:16:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:16:36 +0000
Subject: [Koha-bugs] [Bug 32267] New: Koha/ERM/Agreements.t is failing
Message-ID: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

            Bug ID: 32267
           Summary: Koha/ERM/Agreements.t is failing
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 32154

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 109.              
                          #     Structures begin differing at:                  
    #          $got->[0]{user_role_id} = '1'                                    
    #     $expected->[0]{user_role_id} = Does not exist                         
    # Looks like you failed 1 test of 4.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154
[Bug 32154] Missing primary key on erm_user_roles table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:16:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:16:36 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-CAY0u2c0Oa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32267


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267
[Bug 32267] Koha/ERM/Agreements.t is failing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:17:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:17:07 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-UTpvUyOkvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #9)
> Created attachment 144061 [details] [review]
> Bug 32154: Fix Agreements.t
> 
> #   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
>     #     Structures begin differing at:
>     #          $got->[0]{user_role_id} = '2'
>     #     $expected->[0]{user_role_id} = Does not exist
>     # Looks like you failed 1 test of 4.

Moved to bug 32267.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:18:00 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-qH8690CXOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:18:05 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-I8uArBODtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144062&action=edit
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:18:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:18:28 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-gGjfegNYoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pjamorim91 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:18:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:18:34 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-G77i9FoXbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:20:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:20:19 +0000
Subject: [Koha-bugs] [Bug 9563] Author links don't generate correct search
 query url for UseAuthoritesForTracings
In-Reply-To: <bug-9563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9563-70-6NXPHuyQr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9563

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |nick at bywatersolutions.com
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:39:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:39:07 +0000
Subject: [Koha-bugs] [Bug 32268] New: t/db_dependent/XSLT.t is failing
 randomly
Message-ID: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

            Bug ID: 32268
           Summary: t/db_dependent/XSLT.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19532
            Blocks: 25551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:39:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:39:07 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-GSYXLzjGwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32268


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268
[Bug 32268] t/db_dependent/XSLT.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:39:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:39:07 +0000
Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25551-70-KbppFAl9AR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32268


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268
[Bug 32268] t/db_dependent/XSLT.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:43:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:43:27 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-8gkKJcEkuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:43:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:43:31 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-oVZEYPvtV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144063&action=edit
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at
/kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:43:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:43:47 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-bPfnHSUjrw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:46:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:46:04 +0000
Subject: [Koha-bugs] [Bug 32154] Missing primary key on erm_user_roles table
In-Reply-To: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32154-70-da7ND5phOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32154

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144061|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:49:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:49:46 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-Era4t85MHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:53:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:53:46 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-p8Qfj3iI4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:53:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:53:49 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-p3vHY0V5gy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144062|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:54:12 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-S5tFeUUFxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 14:54:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 13:54:16 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-0Ky3HZxYWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144064&action=edit
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
    #     Structures begin differing at:
    #          $got->[0]{user_role_id} = '2'
    #     $expected->[0]{user_role_id} = Does not exist
    # Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:01:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:01:30 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-SyDvY0Cxfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
           Keywords|additional_work_needed      |

--- Comment #86 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #85)
> Changed status to get attention from RM for last two follow-ups. Thx.

Thanks for the follow-ups, Marcel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:01:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:01:33 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-iSKRNEaP59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:09:31 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-lb70cyLspf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
+        item_group_id => $item->item_group

in t/db_dependent/Circulation.t

Looks wrong.

And please, perltidy your code!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:12:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:12:02 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-f0Wvg3G8ta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #26)
> +        item_group_id => $item->item_group
> 
> in t/db_dependent/Circulation.t

This is the cause of the new warning "Odd number of elements in anonymous hash"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:18:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:18:32 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-dBiBIKEhAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:18:39 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-qhPuD5Mj8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142914|0                           |1
        is obsolete|                            |

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144065&action=edit
Bug 32010: Make sure the alert will be displayed after the ajax call

There is a missing wait_for_ajax call at after we click but wait_for_ajax
is waiting for the return of success, and the alert is there.

22:01:57 koha_1       | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in
Selenium::Remote::Driver::catch {...}
22:01:57 koha_1       |         /usr/share/perl5/Selenium/Remote/Driver.pm:361
in Try::Tiny::try
22:01:57 koha_1       |         (eval 541):1 in
Selenium::Remote::Driver::__ANON__
22:01:57 koha_1       |         (eval 543):2 in
Selenium::Remote::Driver::__ANON__
22:01:57 koha_1       |         /usr/share/perl5/Selenium/Remote/Driver.pm:654
in Selenium::Remote::Driver::_execute_command
22:01:57 koha_1       |        
t/db_dependent/selenium/authentication_2fa.t:282 in
Selenium::Remote::Driver::get_alert_text
22:01:57 koha_1       |         /usr/share/perl/5.32/Test/Builder.pm:334 in
main::__ANON__
22:01:57 koha_1       |         /usr/share/perl/5.32/Test/Builder.pm:334 in
(eval)
22:01:57 koha_1       |         /usr/share/perl/5.32/Test/More.pm:809 in
Test::Builder::subtest
22:01:57 koha_1       |        
t/db_dependent/selenium/authentication_2fa.t:291 in Test::More::subtest
22:01:57 koha_1       |
22:01:57 koha_1       |     # Looks like you planned 7 tests but ran 4.
22:01:57 koha_1       |
22:01:57 koha_1       | #   Failed test 'Enforce 2FA setup on first login'
22:01:57 koha_1       | #   at t/db_dependent/selenium/authentication_2fa.t
line 291.
22:01:57 koha_1       | Error while executing command: no such alert at
/usr/share/perl5/Selenium/Remote/Driver.pm line 411.
22:01:57 koha_1       |  at /usr/share/perl5/Selenium/Remote/Driver.pm line
356.
22:01:57 koha_1       | # Looks like your test exited with 255 just after 4.
22:01:57 koha_1       | [20:59:37] t/db_dependent/selenium/authentication_2fa.t

Test plan:
Confirm that the test pass (execute it in a loop, hundreds of times)
Confirm that the behaviour of 2FA "enforced" (see bug 30588) is still
working as expected.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:19:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:19:34 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-SKfYfQC6wX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:25:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:25:43 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-ihQE2ycN3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:25:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:25:49 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-pVZys7qyhb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144063|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144066&action=edit
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at
/kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:27:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:27:18 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-ujaAWqgRxv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:31:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:31:06 +0000
Subject: [Koha-bugs] [Bug 32269] New: Circulation.t is failing randomly
Message-ID: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

            Bug ID: 32269
           Summary: Circulation.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 25551

21:28:55 koha_1       |     #   Failed test 'Checkouts with auto-renewal can be
renewed earliest on due date if no renewalbefore'
21:28:55 koha_1       |     #   at t/db_dependent/Circulation.t line 5683.
21:28:55 koha_1       |     #          got: '2022-11-17T20:25:30'
21:28:55 koha_1       |     #     expected: '2022-12-01T00:00:00'
21:28:55 koha_1       | 
21:28:55 koha_1       |     #   Failed test 'Checkouts with auto-renewal can be
renewed earliest on due date if no renewalbefore'
21:28:55 koha_1       |     #   at t/db_dependent/Circulation.t line 5689.
21:28:55 koha_1       |     #          got: '2022-11-17T20:25:30'
21:28:55 koha_1       |     #     expected: '2022-12-01T23:59:00'
21:28:55 koha_1       |     # Looks like you failed 2 tests of 5.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:31:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:31:06 +0000
Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25551-70-Qbz8cb12XG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269
[Bug 32269] Circulation.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:32:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:32:51 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-FXYhsqtM3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:32:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:32:56 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-cNZCmUrR52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144067&action=edit
Bug 32269: Prevent Circulation.t to fail randomly

Highlighted by Bug 32030: fix test builder for boolean

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 343.
    #          got: '2022-11-18T14:16:12'
    #     expected: '2022-12-02T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 349.
    #          got: '2022-11-18T14:16:12'
    #     expected: '2022-12-02T23:59:00'
    # Looks like you failed 2 tests of 5

We were reaching return $now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:50:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:50:27 +0000
Subject: [Koha-bugs] [Bug 31748] Restore progress bar on record import
In-Reply-To: <bug-31748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31748-70-wWLVWREdvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:50:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:50:30 +0000
Subject: [Koha-bugs] [Bug 31748] Restore progress bar on record import
In-Reply-To: <bug-31748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31748-70-fzz62nMawz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 144068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144068&action=edit
Bug 31748: Restore progress bar on record import

Test Plan:
1) Apply this patch
2) Upload a marc batch
3) Import the marc batch
4) Note that under the message "The job has been enqueued! It will be processed
as soon as possible."
   There is now a functioning progress bar and the page no longer redirects
automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 15:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 14:52:11 +0000
Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists
 to allow staff with permission to edit contents
In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30418-70-uLFyu5F4Sb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |hammat.wele at inlibro.com

--- Comment #10 from Hammat wele <hammat.wele at inlibro.com> ---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
error: Failed to merge in the changes.Patch failed at 0001 Bug 30418: Template
and JavaScript changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:02:19 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-DVwcx7rvfC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144069&action=edit
Bug 32178: Adapt tests to new auth.session params

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:02:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:02:25 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-CABpsQQ27h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144070&action=edit
Bug 32178: (QA follow-up) Correct modules import

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:08:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:08:06 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-ZMD97XF1UP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:08:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:08:08 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-Vip9E7IlyZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:08:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:08:11 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-zFQA9OVqpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:08:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:08:14 +0000
Subject: [Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing
In-Reply-To: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32267-70-R2ZgzsJCP9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:08:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:08:17 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-7oJhEej7mT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:08:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:08:20 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-z1bl1KBY8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:14:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:14:21 +0000
Subject: [Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in
 sco-main.tt
In-Reply-To: <bug-21266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21266-70-lVAnF1W9Pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hammat.wele at inlibro.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #15 from Hammat wele <hammat.wele at inlibro.com> ---
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt).
error: could not build fake ancestor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:30:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:30:49 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-U0rYhekMjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #272 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144071&action=edit
Bug 31378: (QA follow-up) Defer store until JSON fields are populated

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:43:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:43:12 +0000
Subject: [Koha-bugs] [Bug 32270] New: Add Page Section to Cataloguing -
 Label Creator - Manage Labels
Message-ID: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

            Bug ID: 32270
           Summary: Add Page Section to Cataloguing - Label Creator -
                    Manage Labels
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: matt.blenkinsop at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We need to add page section divs to Cataloguing - Label Creator - Manage Labels
to ensure proper contrast of even odd rows in tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:43:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:43:29 +0000
Subject: [Koha-bugs] [Bug 32271] New: Overdue fines cap (amount) set to 0.00
 when editing rule
Message-ID: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

            Bug ID: 32271
           Summary: Overdue fines cap (amount) set to 0.00 when editing
                    rule
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

I noticed that when I add a circulation rule, if I leave the Overdue fines cap
(amount) field empty, it is displayed as 0.00. If I later edit this rule, the
Overdue fines cap (amount) field is *set to* 0.00, even if that's not what I
wanted. This causes the fines.pl script to charge no fine at all.

To test:

0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. MaxFine system preference must be empty
   0.3. In Tools > Calendar, today must not be a holiday

1. Add a circulation rule with fines but no fines cap
   1.1. Go to Administration > Circulation and fines rules
   1.2. Add or modify a circulation rule, make sure
        -  There is a quantity in "Current checkouts allowed"
        -  There is a number of days in "Loan period"
        -  There is an amount in "Fine amount"
        -  There is a number in "Fine charging interval" (usually 1)
        -  "Overdue fines cap (amount)" is **empty**
   1.3. Save the circulation rule
   --> Note that the amount in "Overdue fines cap (amount)" is displayed as
0.00

2. Checkout an item with a date in the past to create an overdue
   2.1. Find an item barcode
        2.1.1. Go to Item search
        2.2.2. Click Search
        2.2.3. Copy a barcode from the search results
   2.2. Go to a patron's file
        2.2.1. Go to Patrons
        2.2.2. Click on "Search"
        2.2.3. Click on a patron's name
   2.3. Click on the "Check out" tab on the left of the patron's file
   2.4. Click on the settings icon in the "Enter item barcode" field
   2.5. Pick a due date in the past
   2.6. Paste the item barcode in the field
   2.7. Click "Check out" or press Enter
   2.8. Click "Yes, check out"
   --> Patron should have an overdue

3. Run fines.pl
   3.1. In a terminal, run

   ./misc/cronjobs/fines.pl

4. Check that the patron has fines
   4.1. Go to the patron's file
   4.2. Click on the "Accounting" tab on the left
   --> Patron should have a fine (accruing)

5. Modify the circulation rule, change any field except "Overdue fines cap
(amount)" (let's say the quantity of current checkouts has gone up)
   5.1. Go to Administration > Circulation and fines rules
   5.2. Click "Edit" next to the rule created in step 1
   --> Note that the amount in "Overdue fines cap (amount)" is 0.00
   5.3. Change any setting except "Overdue fines cap (amount)", e.g. change
Current checkouts allowed to another number
   5.4. Click "Save"
   --> Note that the amount in "Overdue fines cap (amount)" is displayed as
0.00

6. Redo step 2

7. Redo step 3

8. Redo step 4
--> Note that the patron has no fine

If Overdue fines cap (amount) is empty, it should display as empty (or
"Unlimited"), and when we edit the rule, the field should still be empty and
save as empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:44:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:44:34 +0000
Subject: [Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label
 Creator - Manage Labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-SDOtNFiL7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jacob.omara at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:44:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:44:50 +0000
Subject: [Koha-bugs] [Bug 32272] New: Last borrower and previous borrower
 display on moredetail.pl is broken
Message-ID: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

            Bug ID: 32272
           Summary: Last borrower and previous borrower display on
                    moredetail.pl is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Bug 31315 removed GetItemsInfo from moredetail.pl

In the template we expected the item to contain the borrowernumber and
cardnumber for last three borrowers from old issues:

341                 [% IF ( ITEM_DAT.card0 ) %]<li><span class="label">Last
borrower:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%
ITEM_DAT.borrower0 | uri %]">[% ITEM_DAT.card0 | html %]</a>&nbsp;</li>[% END
%]
342                 [% IF ( ITEM_DAT.card1 ) %]<li><span class="label">Previous
borrower:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%
ITEM_DAT.borrower1 | uri %]">[% ITEM_DAT.card1 | html %]</a>&nbsp;</li>[% END
%]
343                 [% IF ( ITEM_DAT.card2 ) %]<li><span class="label">Previous
borrower:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%
ITEM_DAT.borrower2 | uri %]">[% ITEM_DAT.card2 | html %]</a>&nbsp;</li>[% END
%]


We should either fix this, or remove this display

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:44:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:44:59 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-fCUcZclJNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31315


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315
[Bug 31315] Remove GetItemsInfo from moredetail
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:44:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:44:59 +0000
Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail
In-Reply-To: <bug-31315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31315-70-B3e2Bb6ajh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272
[Bug 32272] Last borrower and previous borrower display on moredetail.pl is
broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:45:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:45:17 +0000
Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when
 editing rule
In-Reply-To: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32271-70-7w65ZmH019@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I noticed this as far back as 22.05 (did not check 21.11, but 21.05 is OK).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:54:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:54:24 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-XS3Tgi54Bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 16:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 15:56:45 +0000
Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when
 editing rule
In-Reply-To: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32271-70-KM2tfQaIje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:01:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:01:35 +0000
Subject: [Koha-bugs] [Bug 32273] New: Unable to set author subfields in
 Elastic search configuration
Message-ID: <bug-32273-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32273

            Bug ID: 32273
           Summary: Unable to set author subfields in Elastic search
                    configuration
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Laura.escamilla at bywatersolutions.com

In a situation in which you have 2 authors that are both named Barnaby Conrad
but one has the authorized name of dates 1922-2013 and the other has III,
1952-. If you click on one of their names for a search from a record where they
are the author, results for both show up as the search just does au:"Conrad,
Barnaby,". Configuring subfields in the Elastic search do not resolve the
problem. Current work around is to enable 'UseAuthoritiesForTracing.'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:16:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:16:17 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-LTOHhdmf4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:16:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:16:21 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-Ya11SvlwRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144072&action=edit
Bug 28235: Correct CSS governing max width of custom cover images

Images shown in the OPAC and staff interface when the
OPACCustomCoverImages and  CustomCoverImages preferences are enabled
should be getting a max-width set in the current CSS, but the order of
the declarations is preventing the correct specificity.

This patch moves the CSS to the correct place in each file so that the
max-width is applied.

To test, apply the patch and rebuild both the staff and OPAC CSS. If you
get an error during the build process you may need to run 'yarn
install.'

- Go to Administration -> System preferences, and enable the
  OPACCustomCoverImages and  CustomCoverImages preferences.
- If you're testing with the default test database you can set the
  CustomCoverImagesURL preference to
  https://static.myacpl.org/public/covers/{normalized_isbn}.jpg
- Perform a catalog search in both OPAC and staff client limiting by
  itemtype = 'Book'.
- The search results in both interface should show several covers
  supplied from the external URL.
- In the staff client, these images should be limited to 140px wide even
  if the source image is larger.
- In the OPAC, view the detail page for one of the results with cover
  images. The image shown on the detail page should be constrained to
  140px wide even if the source image is larger.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:17:10 +0000
Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a
 field in a framework can lose data
In-Reply-To: <bug-19361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19361-70-FDz64geVFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|alexbuckley at catalyst.net.nz |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:19:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:19:48 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-R1CFrGQkan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:32:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:32:56 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-WgcoDjH7tg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:33:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:33:00 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-UWtPgk3WDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143295|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 144073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144073&action=edit
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:34:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:34:32 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-fCPJfDSuFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:34:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:34:37 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-DwX7IhzgIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144074&action=edit
Bug 32254: (follow-up) Add missing div around "Older transactions"

To test:

- Tools -> Cash summary for <library> and Tools -> Transaction history
  for <register>
  - In the "Older transactions" section, submit start and end dates
    which will return results.
  - The table of results should be styled correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:34:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:34:42 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-A6outqUU7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:34:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:34:54 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for holds
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-FtaoWIcMhX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:42:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:42:22 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-PGpO9D7N6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:43:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:43:26 +0000
Subject: [Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label
 Creator - Manage Labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-Wyhxzh1rHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

jacob.omara at ptfs-europe.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:43:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:43:29 +0000
Subject: [Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label
 Creator - Manage Labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-ek3zXEcX1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

--- Comment #1 from jacob.omara at ptfs-europe.com ---
Created attachment 144075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144075&action=edit
Bug 32270: add page section to label management

Test plan:
Navigate to Cataloguing - Label Creator - Manage Labels
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 17:56:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 16:56:05 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for holds
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-v3k1JNchHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140646|0                           |1
        is obsolete|                            |
 Attachment #140647|0                           |1
        is obsolete|                            |

--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 144076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144076&action=edit
Bug 24194: Add ReserveExpiration system preference to disable expiration date
options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can
see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you
can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as waiting. Notice that an expiration date has
now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system
preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date
field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field
disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice
that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 18:00:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 17:00:11 +0000
Subject: [Koha-bugs] [Bug 30986] Improve responsiveness of DataTable toolbar
In-Reply-To: <bug-30986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30986-70-uyr2pr1Isy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30986

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
These changes ended up in Bug 31754.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 18:10:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 17:10:43 +0000
Subject: [Koha-bugs] [Bug 32274] New: Add option for repeating calendar
 closings on the nth weekday of the month
Message-ID: <bug-32274-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32274

            Bug ID: 32274
           Summary: Add option for repeating calendar closings on the nth
                    weekday of the month
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jrobb at sekls.org
        QA Contact: testopia at bugs.koha-community.org

It would be very helpful if closings could be scheduled to repeat on a specific
occurrence of a weekday each month (i.e. repeat closing each 2nd Saturday of
every month).

My use scenario here is a library that's only open the first Saturday of the
month. Currently the fastest way to pull that off is a weekly repeated holiday
on Saturday, and then manually placing exceptions each first Saturday which
requires ongoing manual upkeep.

Double bonus points if it could also limit to a specific month (i.e. repeat
closing every 4th Thursday in November). Currently those "Unique" holidays have
to be added at the start of each year despite their yearly repetition on a
predictable schedule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 18:31:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 17:31:54 +0000
Subject: [Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the
 item editor
In-Reply-To: <bug-30931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30931-70-tMyUPB1CzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |hammat.wele at inlibro.com

--- Comment #19 from Hammat wele <hammat.wele at inlibro.com> ---
Test Plan:

1. Apply patch

2. Add an item to a biblio record. Notice there is a hint message for Date
acquired field.

3. Edit an existing item. Notice there is no hint message displaying for the
Date acquired field.

4. Batch modify an item by submitting an item barcode into Tools > Batch item
modification. Notice no hint message is displayed for the Date acquired.

5. Receive a Serial edition by changing status of issue to 'Arrived'. Notice
there is a hint message for Date acquired field.

6. But When ordering a purchase suggestions (Acquisitions) there is no hint
message displaying for the Date acquired field. The hint message should be
displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 18:57:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 17:57:15 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-UiwuXbWEPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> ---
+1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 19:09:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 18:09:02 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-OOgPdHGpOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
+1 on this. It'd be good to have a way to delete these manually from the staff
interface and also a way to set cleanup_database to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 19:18:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 18:18:35 +0000
Subject: [Koha-bugs] [Bug 32275] New: Fill blank record in basic editor
 using ISBN with Google Books API
Message-ID: <bug-32275-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32275

            Bug ID: 32275
           Summary: Fill blank record in basic editor using ISBN with
                    Google Books API
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jrobb at sekls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 14242 added the ability to fill the OPAC purchase suggestion form with data
from the Google Books API by entering an ISBN.

My catalogers would be ecstatic if that functionality could be used to populate
the relevant fields on a blank bib record in the basic editor as a starting
point for creating records from scratch. This would save a substantial amount
of time entering data.

Logical mappings would be:
volumeInfo.title > 245$a
volumeInfo.subtitle > 245$b
volumeInfo.authors > 100$a
volumeInfo.publisher > 264$a
volumeInfo.publishedDate > 264$c
volumeInfo.pageCount > 300$a
volumeInfo.dimensions.height > 300$c
volumeInfo.description > 500$a

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 20:22:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 19:22:33 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-KNa6XDGBUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143704|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 144077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144077&action=edit
Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on
vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

https://bugs.koha-community.org/show_bug.cgi?id=14680

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 20:22:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 19:22:48 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-npcy04hnrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 20:31:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 19:31:01 +0000
Subject: [Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label
 Creator - Manage Labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-ZJ42yvsiW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144075|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 144078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144078&action=edit
Bug 32270: add page section to label management

Test plan:
Navigate to Cataloguing - Label Creator - Manage Labels
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 20:34:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 19:34:02 +0000
Subject: [Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label
 Creator - Manage Labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-bSdvqx6mQ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 20:48:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 19:48:43 +0000
Subject: [Koha-bugs] [Bug 32276] New: Customize notice recipients
Message-ID: <bug-32276-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32276

            Bug ID: 32276
           Summary: Customize notice recipients
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

It would be great, if in the notices, we had options for who receives notices.

For example, what if, in each notice template, there were options of sending
the notice to any combination of patron, library, or other e-mails (filled in
on a field on that template).

Perhaps we could indicate if each recipient should be a CC or BCC?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 20:56:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 19:56:15 +0000
Subject: [Koha-bugs] [Bug 32277] New: Widget dashboard
Message-ID: <bug-32277-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32277

            Bug ID: 32277
           Summary: Widget dashboard
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It would be great if we could develop a panel above the news panel on the staff
interface that would serve as a widget dashboard in which we could activate
future developed widgets.

For example, I currently use jQuery mods to move the #area-pending element that
houses the patron suggestions patrons requesting modifications up above the
news.  I've also recently added a panel to show upcoming library closures.

Maybe in the future those could be turned into option widgets that could be
added to this dashboard.  And maybe others could be developed to show libraries
that are closed, show the number of holds waiting to be pulled at your library,
show curbside statuses, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 21:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 20:09:31 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-LrQcwqZbRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |ASSIGNED
           Keywords|rel_22_11_candidate         |additional_work_needed

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
This broke tests:

kohadev-koha at kohadevbox:/kohadevbox/koha$ prove
t/db_dependent/Koha/BackgroundJobs.t
t/db_dependent/Koha/BackgroundJobs.t .. 1/15
    #   Failed test 'No jobs found without userenv'
    #   at t/db_dependent/Koha/BackgroundJobs.t line 135.
    #          got: '2'
    #     expected: '0'
    # Looks like you failed 1 test of 3.

#   Failed test 'search_limited'
#   at t/db_dependent/Koha/BackgroundJobs.t line 142.
...

Reverting makes tests pass:

git revert 022034a1c7b91adac539c7ed16fc7b48d566912e

Please take your time to fix it for the release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 21:16:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 20:16:57 +0000
Subject: [Koha-bugs] [Bug 28515] Make it easy to run batch modification on
 "all"
In-Reply-To: <bug-28515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28515-70-ndASkR41yH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28515

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
I love the danger of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 21:19:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 20:19:36 +0000
Subject: [Koha-bugs] [Bug 32276] Customize notice recipients
In-Reply-To: <bug-32276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32276-70-ANTnlRs5Fe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32276

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
This seems like a hard idea to implement with how Koha thinks about notices
now. Generally, some event prompts Koha to go look for a letter with a given
code and a borrower with a given borrowernumber, then send that letter to that
borrower. So there'd need to be some mechanism for the letter-based value
you've suggested to override the originally-intended recipient.

Maybe instead there could be a new page in administration that lists events
that trigger notices and allows one to set whether those go to patron or to
staff? OR to both, actually, that could be helpful. We'd have to somehow tell
it *which* staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 21:20:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 20:20:34 +0000
Subject: [Koha-bugs] [Bug 31025] Reports with too many params can exceed
 length limit of URI
In-Reply-To: <bug-31025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31025-70-MFJnrxmzh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31025

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
This same thing also happens with batch modification from the detail page - our
example was someone trying to modify more than 400 items from the detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 21:29:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 20:29:02 +0000
Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff client
 should be able to change their own password
In-Reply-To: <bug-30700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30700-70-TWWHzz1w4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hammat.wele at inlibro.com
             Status|Needs Signoff               |Failed QA

--- Comment #17 from Hammat wele <hammat.wele at inlibro.com> ---
After apply this patch:
- When i click on the menu with my username 'Patran A' in the top-right there
is no link 'Change password' as expected.
- I can directly access to
http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X and
change the 'Patran A' password
- But i can also access to
http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X of other
users and i'm not redirected to a 404 page as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:02:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:02:41 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-ezpJrdsvw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:02:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:02:46 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-G7AhU8YYsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144025|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 144079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144079&action=edit
Bug 32254: Add 'page-section' to various tools pages

This patch adds a .page-section div to various pages in the tools
section in order to provide a consistent page structure.

Also changed: Corrected a couple of templates which were missing some
<tr> tags.

This patch includes indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Tools -> Access files
- Tools -> HTML customizations
  - Additional contents, news or pages-- all use the same template.
  - Check the list of existing entries.
- Tools -> Batch extend due dates
  - Choose a set of criteria that will return results and click
   "Continue".
  - Check the list of checkouts to be updated.
- Tools -> Batch patron modification
  - Submit a batch of patrons for modification.
  - Check the list of patrons to be modified.
- Tools -> Upload patron images
  - Upload one or more patron images
  - Check the view of results
- Tools -> Upload
  - Upload a file and view the results, or perform a search and check
    the view of results.
- Tools -> Patron card creator -> New patron card batch.
  - Submit a set of patrons and check the display of patrons in the
    resulting batch.
- Tools -> Cash summary for <library> and Tools -> Transaction history
  for <register>
  - Confirm that the table of data looks correct

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:02:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:02:50 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-Bn7qIP676L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144026|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 144080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144080&action=edit
Bug 32254: (follow-up) Add page section to Cashup history

Adds one missing page section on the last table of the
POS transactions page.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:02:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:02:56 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-QefOidd9NY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144074|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 144081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144081&action=edit
Bug 32254: (follow-up) Add missing div around "Older transactions"

To test:

- Tools -> Cash summary for <library> and Tools -> Transaction history
  for <register>
  - In the "Older transactions" section, submit start and end dates
    which will return results.
  - The table of results should be styled correctly.

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:06:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:06:49 +0000
Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31051-70-F31HGTFaBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:06:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:06:56 +0000
Subject: [Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
In-Reply-To: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31051-70-E7Jz7FZ7ue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143384|0                           |1
        is obsolete|                            |

--- Comment #34 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144082&action=edit
Bug 31051: (follow-up) Tests for get_savings and more

- Added tests in t/db_dependent/Koha/Patron.t
- Added wording to OPACShowSavings syspref about anonymised checkout
history
- Added IDs to the savings messages on the OPAC
- Prevent explosion if a checked out item has been deleted

Sponsored-by: Horowhenua Libraries Trust
Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:36:57 +0000
Subject: [Koha-bugs] [Bug 31025] Reports with too many params can exceed
 length limit of URI
In-Reply-To: <bug-31025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31025-70-8HeHRIBFcy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31025

--- Comment #2 from Liz Rea <wizzyrea at gmail.com> ---
We had a library try to use the following - we're going to try to increase the
limit but perhaps we can make this work differently so that it works a little
more consistently at this scale?

https://staff.partner.bywatersolutions.com/cgi-bin/koha/tools/batchMod.pl?op=show&itemnumber=48432&itemnumber=48433&itemnumber=48434&itemnumber=48435&itemnumber=48436&itemnumber=48437&itemnumber=48438&itemnumber=48439&itemnumber=48440&itemnumber=48441&itemnumber=48442&itemnumber=48443&itemnumber=48444&itemnumber=48445&itemnumber=48446&itemnumber=48447&itemnumber=48448&itemnumber=48449&itemnumber=48450&itemnumber=48451&itemnumber=48452&itemnumber=48453&itemnumber=48454&itemnumber=48455&itemnumber=48456&itemnumber=48457&itemnumber=48458&itemnumber=48459&itemnumber=48460&itemnumber=48461&itemnumber=48462&itemnumber=48463&itemnumber=48464&itemnumber=48465&itemnumber=48466&itemnumber=48467&itemnumber=48468&itemnumber=48469&itemnumber=48470&itemnumber=48471&itemnumber=48472&itemnumber=48473&itemnumber=48474&itemnumber=48475&itemnumber=48476&itemnumber=48477&itemnumber=48478&itemnumber=48479&itemnumber=48480&itemnumber=48481&itemnumber=48482&itemnumber=48483&itemnumber=48484&itemnumber=48485&itemnumber=48486&itemnumber=48487&itemnumber=48488&itemnumber=48489&itemnumber=48490&itemnumber=48491&itemnumber=48492&itemnumber=48493&itemnumber=48494&itemnumber=48495&itemnumber=48496&itemnumber=48497&itemnumber=48498&itemnumber=48499&itemnumber=48500&itemnumber=48501&itemnumber=48502&itemnumber=48503&itemnumber=48504&itemnumber=48505&itemnumber=48506&itemnumber=48507&itemnumber=48508&itemnumber=48509&itemnumber=48510&itemnumber=48511&itemnumber=48512&itemnumber=48513&itemnumber=48514&itemnumber=48515&itemnumber=48516&itemnumber=48517&itemnumber=48518&itemnumber=48519&itemnumber=48520&itemnumber=48521&itemnumber=48522&itemnumber=48523&itemnumber=48524&itemnumber=48525&itemnumber=48526&itemnumber=48527&itemnumber=48528&itemnumber=48529&itemnumber=48530&itemnumber=48531&itemnumber=48532&itemnumber=48533&itemnumber=48534&itemnumber=48535&itemnumber=48536&itemnumber=48537&itemnumber=48538&itemnumber=48539&itemnumber=48540&itemnumber=48541&itemnumber=48542&itemnumber=48543&itemnumber=48544&itemnumber=48545&itemnumber=48546&itemnumber=48547&itemnumber=48548&itemnumber=48549&itemnumber=48550&itemnumber=48551&itemnumber=48552&itemnumber=48553&itemnumber=48554&itemnumber=48555&itemnumber=48556&itemnumber=48557&itemnumber=48558&itemnumber=48559&itemnumber=48560&itemnumber=48561&itemnumber=48562&itemnumber=48563&itemnumber=48564&itemnumber=48565&itemnumber=48566&itemnumber=48567&itemnumber=48568&itemnumber=48569&itemnumber=48570&itemnumber=48571&itemnumber=48572&itemnumber=48573&itemnumber=48574&itemnumber=48575&itemnumber=48576&itemnumber=48577&itemnumber=48578&itemnumber=48579&itemnumber=48580&itemnumber=48581&itemnumber=48582&itemnumber=48583&itemnumber=48584&itemnumber=48585&itemnumber=48586&itemnumber=48587&itemnumber=48588&itemnumber=48589&itemnumber=48590&itemnumber=48591&itemnumber=48592&itemnumber=48593&itemnumber=48594&itemnumber=48595&itemnumber=48596&itemnumber=48597&itemnumber=48598&itemnumber=48599&itemnumber=48600&itemnumber=48601&itemnumber=48602&itemnumber=48603&itemnumber=48604&itemnumber=48605&itemnumber=48606&itemnumber=48607&itemnumber=48608&itemnumber=48609&itemnumber=48610&itemnumber=48611&itemnumber=48612&itemnumber=48613&itemnumber=48614&itemnumber=48615&itemnumber=48616&itemnumber=48617&itemnumber=48618&itemnumber=48619&itemnumber=48620&itemnumber=48621&itemnumber=48622&itemnumber=48623&itemnumber=48624&itemnumber=48625&itemnumber=48626&itemnumber=48627&itemnumber=48628&itemnumber=48629&itemnumber=48630&itemnumber=48631&itemnumber=48632&itemnumber=48633&itemnumber=48634&itemnumber=48635&itemnumber=48636&itemnumber=48637&itemnumber=48638&itemnumber=48639&itemnumber=48640&itemnumber=48641&itemnumber=48642&itemnumber=48643&itemnumber=48644&itemnumber=48645&itemnumber=48646&itemnumber=48647&itemnumber=48648&itemnumber=48649&itemnumber=48650&itemnumber=48651&itemnumber=48652&itemnumber=48653&itemnumber=48654&itemnumber=48655&itemnumber=48656&itemnumber=48657&itemnumber=48658&itemnumber=48659&itemnumber=48660&itemnumber=48661&itemnumber=48662&itemnumber=48663&itemnumber=48664&itemnumber=48665&itemnumber=48666&itemnumber=48667&itemnumber=48668&itemnumber=48669&itemnumber=48670&itemnumber=48671&itemnumber=48672&itemnumber=48673&itemnumber=48674&itemnumber=48675&itemnumber=48676&itemnumber=48677&itemnumber=48678&itemnumber=48679&itemnumber=48680&itemnumber=48681&itemnumber=48682&itemnumber=48683&itemnumber=48684&itemnumber=48685&itemnumber=48686&itemnumber=48687&itemnumber=48688&itemnumber=48689&itemnumber=48690&itemnumber=48691&itemnumber=48692&itemnumber=48693&itemnumber=48694&itemnumber=48695&itemnumber=48696&itemnumber=48697&itemnumber=48698&itemnumber=48699&itemnumber=48700&itemnumber=48701&itemnumber=48702&itemnumber=48703&itemnumber=48704&itemnumber=48705&itemnumber=48706&itemnumber=48707&itemnumber=48708&itemnumber=48709&itemnumber=48710&itemnumber=48711&itemnumber=48712&itemnumber=48713&itemnumber=48714&itemnumber=48715&itemnumber=48716&itemnumber=48717&itemnumber=48718&itemnumber=48719&itemnumber=48720&itemnumber=48721&itemnumber=48722&itemnumber=48723&itemnumber=48724&itemnumber=48725&itemnumber=48726&itemnumber=48727&itemnumber=48728&itemnumber=48729&itemnumber=48730&itemnumber=48731&itemnumber=48732&itemnumber=48733&itemnumber=48734&itemnumber=48735&itemnumber=48736&itemnumber=48737&itemnumber=48738&itemnumber=48739&itemnumber=48740&itemnumber=48741&itemnumber=48742&itemnumber=48743&itemnumber=48744&itemnumber=48745&itemnumber=48746&itemnumber=48747&itemnumber=48748&itemnumber=48749&itemnumber=48750&itemnumber=48751&itemnumber=48752&itemnumber=48753&itemnumber=48754&itemnumber=48755&itemnumber=48756&itemnumber=48757&itemnumber=48758&itemnumber=48759&itemnumber=48760&itemnumber=48761&itemnumber=48762&itemnumber=48763&itemnumber=48764&itemnumber=48765&itemnumber=48766&itemnumber=48767&itemnumber=48768&itemnumber=48769&itemnumber=48770&itemnumber=48771&itemnumber=48772&itemnumber=48773&itemnumber=48774&itemnumber=48775&itemnumber=48776&itemnumber=48777&itemnumber=48778&itemnumber=48779&itemnumber=48780&itemnumber=48781&itemnumber=48782&itemnumber=48783&itemnumber=48784&itemnumber=48785&itemnumber=48786&itemnumber=48787&itemnumber=48788&itemnumber=48789&itemnumber=48790&itemnumber=48791&itemnumber=48792&itemnumber=48793&itemnumber=48794&itemnumber=48795&itemnumber=48796&itemnumber=48797&itemnumber=48798&itemnumber=48799&itemnumber=48800&itemnumber=48801&itemnumber=48802&itemnumber=48803&itemnumber=48804&itemnumber=48805&itemnumber=48806&itemnumber=48807&itemnumber=48808&itemnumber=48809&itemnumber=48810&itemnumber=48811&itemnumber=48812&itemnumber=48813&itemnumber=48814&itemnumber=48815&itemnumber=48816&itemnumber=48817&itemnumber=48818&itemnumber=48819&itemnumber=48820&itemnumber=48821&itemnumber=48822&itemnumber=48823&itemnumber=48824&itemnumber=48825&itemnumber=48826&itemnumber=48827&itemnumber=48828&itemnumber=48829&itemnumber=48830&itemnumber=48831&itemnumber=48832&itemnumber=48833&itemnumber=48834&itemnumber=48835&itemnumber=48836&itemnumber=48837&itemnumber=48838&itemnumber=48839&itemnumber=48840&itemnumber=48841&itemnumber=48842&itemnumber=48843&itemnumber=48844&itemnumber=48845&itemnumber=48846&itemnumber=48847&itemnumber=48848&itemnumber=48849&itemnumber=48850&itemnumber=48851&itemnumber=48852&itemnumber=48853&itemnumber=48854&itemnumber=48855&itemnumber=48856&itemnumber=48857&itemnumber=48858&itemnumber=48859&itemnumber=48860&itemnumber=48861&itemnumber=48862&itemnumber=48863&itemnumber=48864&itemnumber=48865&itemnumber=48866&itemnumber=48867&itemnumber=48868&itemnumber=48869&itemnumber=48870&itemnumber=48871&itemnumber=48872&itemnumber=48873&itemnumber=48874&itemnumber=48875&itemnumber=48876&itemnumber=48877&itemnumber=48878&itemnumber=48879&itemnumber=48880&itemnumber=48881&itemnumber=48882&itemnumber=48883&itemnumber=48884&itemnumber=48885&itemnumber=48886&itemnumber=48887&itemnumber=48888&itemnumber=48889&itemnumber=48890&itemnumber=48891&itemnumber=48892&itemnumber=48893&itemnumber=48894&itemnumber=48895&itemnumber=48896&itemnumber=48897&itemnumber=48898&itemnumber=48899&itemnumber=48900&itemnumber=48901&itemnumber=48902&itemnumber=48903&itemnumber=48904&itemnumber=48905&itemnumber=48906&itemnumber=48907&itemnumber=48908&itemnumber=48909&itemnumber=48910&biblionumber=26604&src=CATALOGUING

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:42:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:42:03 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-2TWbdPMypE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #22 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Hi all,
I'm curious to know the usefulness of having the fines.pl cron run during
library operation hours... If anyone can enlighten me on this, I would be very
grateful.

I was able to recreate the problem on master, and I created a detailed test
plan, if you're interested (see below). However, the patches don't apply on the
current master, so I was not able to test them.

Here is my detailed test plan (I know it's a lot but I figured that I already
wrote it, so might as well share it!)

0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
        1.1.1. Go to Administration > Global system preferences
        1.1.2. Search for BatchCheckouts
        1.1.3. Set BatchCheckouts to Allow
        1.1.4. Select all categories in BatchCheckoutsValidCategories 
        1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
        1.2.1. Go to Reports
        1.2.2. Click "Create from SQL"
        1.2.3. Give the report a name
        1.2.4. For the SQL query, enter

               SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

        1.2.5. Click "Save report"
        1.2.6. Click "Run report"
        1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
        1.3.1. Go to Patrons
        1.3.2. Click on "Search"
        1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
        1.4.1. Click on the "Batch check out" tab on the left
        1.4.2. In "Use a file", click "Choose file"
        1.4.3. Choose the file downloaded from the report
        1.4.4. In "Hard due date", choose a date in the past
        1.4.5. Click "Check out"
        1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

        SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

        ./misc/cronjobs/fines.pl


   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

    4.1. Click on the patron's name in the check in screen
    4.2. Go to the Accounting tab on the left
    4.3. In the search box just above the table, paste in the returned item's
barcode

    --> There are two fines, one Fine (Accruing) and one Fine (Returned) for
the same item at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 22:50:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 21:50:52 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-Zc65ynAWNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #23 from Michael Hafen <michael.hafen at washk12.org> ---
(In reply to Caroline Cyr La Rose from comment #22)
> Hi all,
> I'm curious to know the usefulness of having the fines.pl cron run during
> library operation hours... If anyone can enlighten me on this, I would be
> very grateful.
> 

The fines.pl is part of the daily cron job, which starts around 2:30 on my
system. (as per /etc/crontab)
By the time the daily cron job gets done with fines it's after 6, which is when
some of my libraries open (I'm running Koha for a School District).

It's probably not intended to be run during operation hours, it just happens to
for me.

I'll rebase the patch for current master and upload it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:00:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:00:02 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-PtisB52fCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131304|0                           |1
        is obsolete|                            |
 Attachment #131961|0                           |1
        is obsolete|                            |

--- Comment #24 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 144083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144083&action=edit
Bug 18855: Don't create duplicate overdue fines if an issue  is returned

[rebased Nov. 13, 2022]
[includes Jonathan's followup]

Test plan (by Caroline):
0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
        1.1.1. Go to Administration > Global system preferences
        1.1.2. Search for BatchCheckouts
        1.1.3. Set BatchCheckouts to Allow
        1.1.4. Select all categories in BatchCheckoutsValidCategories
        1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
        1.2.1. Go to Reports
        1.2.2. Click "Create from SQL"
        1.2.3. Give the report a name
        1.2.4. For the SQL query, enter

               SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

        1.2.5. Click "Save report"
        1.2.6. Click "Run report"
        1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
        1.3.1. Go to Patrons
        1.3.2. Click on "Search"
        1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
        1.4.1. Click on the "Batch check out" tab on the left
        1.4.2. In "Use a file", click "Choose file"
        1.4.3. Choose the file downloaded from the report
        1.4.4. In "Hard due date", choose a date in the past
        1.4.5. Click "Check out"
        1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

        SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

        ./misc/cronjobs/fines.pl

   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

    4.1. Click on the patron's name in the check in screen
    4.2. Go to the Accounting tab on the left
    4.3. In the search box just above the table, paste in the returned item's
barcode

    --> There are two fines, one Fine (Accruing) and one Fine (Returned) for
the same item at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:06:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:06:07 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-AUKQtddRUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:11:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:11:36 +0000
Subject: [Koha-bugs] [Bug 32278] New: Batch modifications from the biblio
 page can cause 415 URI too long when attempting to modify many items
Message-ID: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32278

            Bug ID: 32278
           Summary: Batch modifications from the biblio page can cause 415
                    URI too long when attempting to modify many items
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

We had a library attempt to request the following uri from the detail page with
a "select all -> modify" type of workflow. They could do up to about 400 items
(I presume because their biblionumbers are of this specific length) but not 500
or 800, response from apache is 414 Request URI too long.

We will likely up the limit for this but wondering if there is something that
can be done to make this work a little better at scale.

https://staff.partner.kohaprovider.com/cgi-bin/koha/tools/batchMod.pl?op=show&itemnumber=48432&itemnumber=48433&itemnumber=48434&itemnumber=48435&itemnumber=48436&itemnumber=48437&itemnumber=48438&itemnumber=48439&itemnumber=48440&itemnumber=48441&itemnumber=48442&itemnumber=48443&itemnumber=48444&itemnumber=48445&itemnumber=48446&itemnumber=48447&itemnumber=48448&itemnumber=48449&itemnumber=48450&itemnumber=48451&itemnumber=48452&itemnumber=48453&itemnumber=48454&itemnumber=48455&itemnumber=48456&itemnumber=48457&itemnumber=48458&itemnumber=48459&itemnumber=48460&itemnumber=48461&itemnumber=48462&itemnumber=48463&itemnumber=48464&itemnumber=48465&itemnumber=48466&itemnumber=48467&itemnumber=48468&itemnumber=48469&itemnumber=48470&itemnumber=48471&itemnumber=48472&itemnumber=48473&itemnumber=48474&itemnumber=48475&itemnumber=48476&itemnumber=48477&itemnumber=48478&itemnumber=48479&itemnumber=48480&itemnumber=48481&itemnumber=48482&itemnumber=48483&itemnumber=48484&itemnumber=48485&itemnumber=48486&itemnumber=48487&itemnumber=48488&itemnumber=48489&itemnumber=48490&itemnumber=48491&itemnumber=48492&itemnumber=48493&itemnumber=48494&itemnumber=48495&itemnumber=48496&itemnumber=48497&itemnumber=48498&itemnumber=48499&itemnumber=48500&itemnumber=48501&itemnumber=48502&itemnumber=48503&itemnumber=48504&itemnumber=48505&itemnumber=48506&itemnumber=48507&itemnumber=48508&itemnumber=48509&itemnumber=48510&itemnumber=48511&itemnumber=48512&itemnumber=48513&itemnumber=48514&itemnumber=48515&itemnumber=48516&itemnumber=48517&itemnumber=48518&itemnumber=48519&itemnumber=48520&itemnumber=48521&itemnumber=48522&itemnumber=48523&itemnumber=48524&itemnumber=48525&itemnumber=48526&itemnumber=48527&itemnumber=48528&itemnumber=48529&itemnumber=48530&itemnumber=48531&itemnumber=48532&itemnumber=48533&itemnumber=48534&itemnumber=48535&itemnumber=48536&itemnumber=48537&itemnumber=48538&itemnumber=48539&itemnumber=48540&itemnumber=48541&itemnumber=48542&itemnumber=48543&itemnumber=48544&itemnumber=48545&itemnumber=48546&itemnumber=48547&itemnumber=48548&itemnumber=48549&itemnumber=48550&itemnumber=48551&itemnumber=48552&itemnumber=48553&itemnumber=48554&itemnumber=48555&itemnumber=48556&itemnumber=48557&itemnumber=48558&itemnumber=48559&itemnumber=48560&itemnumber=48561&itemnumber=48562&itemnumber=48563&itemnumber=48564&itemnumber=48565&itemnumber=48566&itemnumber=48567&itemnumber=48568&itemnumber=48569&itemnumber=48570&itemnumber=48571&itemnumber=48572&itemnumber=48573&itemnumber=48574&itemnumber=48575&itemnumber=48576&itemnumber=48577&itemnumber=48578&itemnumber=48579&itemnumber=48580&itemnumber=48581&itemnumber=48582&itemnumber=48583&itemnumber=48584&itemnumber=48585&itemnumber=48586&itemnumber=48587&itemnumber=48588&itemnumber=48589&itemnumber=48590&itemnumber=48591&itemnumber=48592&itemnumber=48593&itemnumber=48594&itemnumber=48595&itemnumber=48596&itemnumber=48597&itemnumber=48598&itemnumber=48599&itemnumber=48600&itemnumber=48601&itemnumber=48602&itemnumber=48603&itemnumber=48604&itemnumber=48605&itemnumber=48606&itemnumber=48607&itemnumber=48608&itemnumber=48609&itemnumber=48610&itemnumber=48611&itemnumber=48612&itemnumber=48613&itemnumber=48614&itemnumber=48615&itemnumber=48616&itemnumber=48617&itemnumber=48618&itemnumber=48619&itemnumber=48620&itemnumber=48621&itemnumber=48622&itemnumber=48623&itemnumber=48624&itemnumber=48625&itemnumber=48626&itemnumber=48627&itemnumber=48628&itemnumber=48629&itemnumber=48630&itemnumber=48631&itemnumber=48632&itemnumber=48633&itemnumber=48634&itemnumber=48635&itemnumber=48636&itemnumber=48637&itemnumber=48638&itemnumber=48639&itemnumber=48640&itemnumber=48641&itemnumber=48642&itemnumber=48643&itemnumber=48644&itemnumber=48645&itemnumber=48646&itemnumber=48647&itemnumber=48648&itemnumber=48649&itemnumber=48650&itemnumber=48651&itemnumber=48652&itemnumber=48653&itemnumber=48654&itemnumber=48655&itemnumber=48656&itemnumber=48657&itemnumber=48658&itemnumber=48659&itemnumber=48660&itemnumber=48661&itemnumber=48662&itemnumber=48663&itemnumber=48664&itemnumber=48665&itemnumber=48666&itemnumber=48667&itemnumber=48668&itemnumber=48669&itemnumber=48670&itemnumber=48671&itemnumber=48672&itemnumber=48673&itemnumber=48674&itemnumber=48675&itemnumber=48676&itemnumber=48677&itemnumber=48678&itemnumber=48679&itemnumber=48680&itemnumber=48681&itemnumber=48682&itemnumber=48683&itemnumber=48684&itemnumber=48685&itemnumber=48686&itemnumber=48687&itemnumber=48688&itemnumber=48689&itemnumber=48690&itemnumber=48691&itemnumber=48692&itemnumber=48693&itemnumber=48694&itemnumber=48695&itemnumber=48696&itemnumber=48697&itemnumber=48698&itemnumber=48699&itemnumber=48700&itemnumber=48701&itemnumber=48702&itemnumber=48703&itemnumber=48704&itemnumber=48705&itemnumber=48706&itemnumber=48707&itemnumber=48708&itemnumber=48709&itemnumber=48710&itemnumber=48711&itemnumber=48712&itemnumber=48713&itemnumber=48714&itemnumber=48715&itemnumber=48716&itemnumber=48717&itemnumber=48718&itemnumber=48719&itemnumber=48720&itemnumber=48721&itemnumber=48722&itemnumber=48723&itemnumber=48724&itemnumber=48725&itemnumber=48726&itemnumber=48727&itemnumber=48728&itemnumber=48729&itemnumber=48730&itemnumber=48731&itemnumber=48732&itemnumber=48733&itemnumber=48734&itemnumber=48735&itemnumber=48736&itemnumber=48737&itemnumber=48738&itemnumber=48739&itemnumber=48740&itemnumber=48741&itemnumber=48742&itemnumber=48743&itemnumber=48744&itemnumber=48745&itemnumber=48746&itemnumber=48747&itemnumber=48748&itemnumber=48749&itemnumber=48750&itemnumber=48751&itemnumber=48752&itemnumber=48753&itemnumber=48754&itemnumber=48755&itemnumber=48756&itemnumber=48757&itemnumber=48758&itemnumber=48759&itemnumber=48760&itemnumber=48761&itemnumber=48762&itemnumber=48763&itemnumber=48764&itemnumber=48765&itemnumber=48766&itemnumber=48767&itemnumber=48768&itemnumber=48769&itemnumber=48770&itemnumber=48771&itemnumber=48772&itemnumber=48773&itemnumber=48774&itemnumber=48775&itemnumber=48776&itemnumber=48777&itemnumber=48778&itemnumber=48779&itemnumber=48780&itemnumber=48781&itemnumber=48782&itemnumber=48783&itemnumber=48784&itemnumber=48785&itemnumber=48786&itemnumber=48787&itemnumber=48788&itemnumber=48789&itemnumber=48790&itemnumber=48791&itemnumber=48792&itemnumber=48793&itemnumber=48794&itemnumber=48795&itemnumber=48796&itemnumber=48797&itemnumber=48798&itemnumber=48799&itemnumber=48800&itemnumber=48801&itemnumber=48802&itemnumber=48803&itemnumber=48804&itemnumber=48805&itemnumber=48806&itemnumber=48807&itemnumber=48808&itemnumber=48809&itemnumber=48810&itemnumber=48811&itemnumber=48812&itemnumber=48813&itemnumber=48814&itemnumber=48815&itemnumber=48816&itemnumber=48817&itemnumber=48818&itemnumber=48819&itemnumber=48820&itemnumber=48821&itemnumber=48822&itemnumber=48823&itemnumber=48824&itemnumber=48825&itemnumber=48826&itemnumber=48827&itemnumber=48828&itemnumber=48829&itemnumber=48830&itemnumber=48831&itemnumber=48832&itemnumber=48833&itemnumber=48834&itemnumber=48835&itemnumber=48836&itemnumber=48837&itemnumber=48838&itemnumber=48839&itemnumber=48840&itemnumber=48841&itemnumber=48842&itemnumber=48843&itemnumber=48844&itemnumber=48845&itemnumber=48846&itemnumber=48847&itemnumber=48848&itemnumber=48849&itemnumber=48850&itemnumber=48851&itemnumber=48852&itemnumber=48853&itemnumber=48854&itemnumber=48855&itemnumber=48856&itemnumber=48857&itemnumber=48858&itemnumber=48859&itemnumber=48860&itemnumber=48861&itemnumber=48862&itemnumber=48863&itemnumber=48864&itemnumber=48865&itemnumber=48866&itemnumber=48867&itemnumber=48868&itemnumber=48869&itemnumber=48870&itemnumber=48871&itemnumber=48872&itemnumber=48873&itemnumber=48874&itemnumber=48875&itemnumber=48876&itemnumber=48877&itemnumber=48878&itemnumber=48879&itemnumber=48880&itemnumber=48881&itemnumber=48882&itemnumber=48883&itemnumber=48884&itemnumber=48885&itemnumber=48886&itemnumber=48887&itemnumber=48888&itemnumber=48889&itemnumber=48890&itemnumber=48891&itemnumber=48892&itemnumber=48893&itemnumber=48894&itemnumber=48895&itemnumber=48896&itemnumber=48897&itemnumber=48898&itemnumber=48899&itemnumber=48900&itemnumber=48901&itemnumber=48902&itemnumber=48903&itemnumber=48904&itemnumber=48905&itemnumber=48906&itemnumber=48907&itemnumber=48908&itemnumber=48909&itemnumber=48910&biblionumber=26604&src=CATALOGUING

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:12:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:12:26 +0000
Subject: [Koha-bugs] [Bug 32278] Batch modifications from the biblio page
 can cause 414 URI too long when attempting to modify many items
In-Reply-To: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32278-70-B3Wj20YFzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32278

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Batch modifications from    |Batch modifications from
                   |the biblio page can cause   |the biblio page can cause
                   |415 URI too long when       |414 URI too long when
                   |attempting to modify many   |attempting to modify many
                   |items                       |items
                 CC|                            |wizzyrea at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:18:39 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-h6FZMVjfJc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:18:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:18:43 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-2HLtvDOVe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #25 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 144084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144084&action=edit
Bug 18855: Don't create duplicate overdue fines if an issue is returned

This includes Jonathan's followup

If cronjobs/fines.pl is running during circulation hours, then an issue may
be considered for having it's overdue fine updated after the issue has been
returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'.  In
this case UpdateFine will create a duplicate fine because it can't find the
specific accountline for the (formerly) overdue issue.

This changes cronjobs/fines.pl to double check the issue before updating
the fine.  If the issue has changed between starting the script and updating
the fine, then the script will skip it.

There is a small amount of time between the check and calling UpdateFine
where the issue can be changed and this problem can reoccure.  The chance
of that happening is so small that it's probably fine to leave as is.

It is also possible that the fine won't be updated because the issue was
returned.  In this case the fine payed by the patron will be lower, but that
is better then the patron finding later that there is more to a fine they
thought they had paid all of.

Test plan (by Caroline):
0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
        1.1.1. Go to Administration > Global system preferences
        1.1.2. Search for BatchCheckouts
        1.1.3. Set BatchCheckouts to Allow
        1.1.4. Select all categories in BatchCheckoutsValidCategories
        1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
        1.2.1. Go to Reports
        1.2.2. Click "Create from SQL"
        1.2.3. Give the report a name
        1.2.4. For the SQL query, enter

               SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

        1.2.5. Click "Save report"
        1.2.6. Click "Run report"
        1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
        1.3.1. Go to Patrons
        1.3.2. Click on "Search"
        1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
        1.4.1. Click on the "Batch check out" tab on the left
        1.4.2. In "Use a file", click "Choose file"
        1.4.3. Choose the file downloaded from the report
        1.4.4. In "Hard due date", choose a date in the past
        1.4.5. Click "Check out"
        1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

        SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

        ./misc/cronjobs/fines.pl

   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

    4.1. Click on the patron's name in the check in screen
    4.2. Go to the Accounting tab on the left
    4.3. In the search box just above the table, paste in the returned item's
barcode

    --> Without the patch, there are two fines, one Fine (Accruing) and one
Fine (Returned) for the same item at the same time
    --> With the patch, there is only one fine, Fine (Returned)

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:20:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:20:11 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-UVhJBqwGh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #26 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Wow, thanks for the quick rebase Michael!

I tested and I only have one fine, Fine (Returned), now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 18 23:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 22:22:45 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
 run during active circulation
In-Reply-To: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18855-70-65XluazogC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #27 from Michael Hafen <michael.hafen at washk12.org> ---
(In reply to Caroline Cyr La Rose from comment #26)
> Wow, thanks for the quick rebase Michael!
> 
> I tested and I only have one fine, Fine (Returned), now.

You're welcome.  Thanks for the sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 00:22:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 23:22:20 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-7OSMtaksyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Passed QA

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #16)
> This broke tests:
> 
> kohadev-koha at kohadevbox:/kohadevbox/koha$ prove
> t/db_dependent/Koha/BackgroundJobs.t
> t/db_dependent/Koha/BackgroundJobs.t .. 1/15
>     #   Failed test 'No jobs found without userenv'
>     #   at t/db_dependent/Koha/BackgroundJobs.t line 135.
>     #          got: '2'
>     #     expected: '0'
>     # Looks like you failed 1 test of 3.
> 
> #   Failed test 'search_limited'
> #   at t/db_dependent/Koha/BackgroundJobs.t line 142.
> ...
> 
> Reverting makes tests pass:
> 
> git revert 022034a1c7b91adac539c7ed16fc7b48d566912e
> 
> Please take your time to fix it for the release.

I was wrong. My bisect was flawed because of the reset_all I was using.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 00:22:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 23:22:30 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-nrU26m5GW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 00:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Nov 2022 23:52:54 +0000
Subject: [Koha-bugs] [Bug 32276] Customize notice recipients
In-Reply-To: <bug-32276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32276-70-418vm92F0w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32276

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Yes, thinking through this more, it would be a matter of determining for each
template if the notice is going through the owning library, the issuing
library, or the patron's home branch, and then determining the staff associated
with that template and particular branch.

I could envision a page that lists the available templates based on the
selected library, and then setting settings/e-mails for each particular
template.  One could assume that the staff e-mails and selections associated
with a template would be based on however the notice originally is sent to the
patron (from owning library, the issuing library, or the patron's home branch).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:34:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:34:05 +0000
Subject: [Koha-bugs] [Bug 32279] New: GetAuthorizedHeading missing from
 exports of C4::AuthoritiesMarc
Message-ID: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

            Bug ID: 32279
           Summary: GetAuthorizedHeading missing from exports of
                    C4::AuthoritiesMarc
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is
called in other modules :
 > git grep GetAuthorizedHeading
C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading
C4/AuthoritiesMarc.pm:  $heading = &GetAuthorizedHeading({ record => $record,
authid => $authid })
C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading {
C4/Breeding.pm:                            $heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord });
C4/ImportBatch.pm:            $row->{'authorized_heading'} =
C4::AuthoritiesMarc::GetAuthorizedHeading( { authid =>
$row->{'candidate_match_id'} } );
C4/ImportBatch.pm:    my $authorized_heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record });

It should be exported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:34:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:34:16 +0000
Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports
 of C4::AuthoritiesMarc
In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32279-70-iB5PHAuR4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:38:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:38:26 +0000
Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports
 of C4::AuthoritiesMarc
In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32279-70-8LWaLpAcLZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
The main cause for us it that we want to call it in our plugin :
https://github.com/biblibre/koha-plugin-idref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:43:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:43:45 +0000
Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports
 of C4::AuthoritiesMarc
In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32279-70-dO7Wc2K54J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:43:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:43:49 +0000
Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports
 of C4::AuthoritiesMarc
In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32279-70-ZJidL4QA9a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144085&action=edit
Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc

C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is
called in other modules :
 > git grep GetAuthorizedHeading
C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading
C4/AuthoritiesMarc.pm:  $heading = &GetAuthorizedHeading({ record => $record,
authid => $authid })
C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading {
C4/Breeding.pm:                            $heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord });
C4/ImportBatch.pm:            $row->{'authorized_heading'} =
C4::AuthoritiesMarc::GetAuthorizedHeading( { authid =>
$row->{'candidate_match_id'} } );
C4/ImportBatch.pm:    my $authorized_heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record });

This patch adds it to be exported.
For example for use in Koha plugins.

Test plan :
Check import of authorities from a file is OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:54:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:54:20 +0000
Subject: [Koha-bugs] [Bug 32280] New: Export method ImportBreedingAuth from
 C4::Breeding
Message-ID: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

            Bug ID: 32280
           Summary: Export method ImportBreedingAuth from C4::Breeding
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In C4::Breeding method ImportBreedingAuth() should be exported to be used for
example by plugins.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:57:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:57:00 +0000
Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from
 C4::Breeding
In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32280-70-vz8lu1PaeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 04:57:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 03:57:04 +0000
Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from
 C4::Breeding
In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32280-70-30OBZtLlkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144086&action=edit
Bug 32280: Export method ImportBreedingAuth from C4::Breeding

In C4::Breeding method ImportBreedingAuth() should be exported to be used for
example by plugins.

No test plan needed i bet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 10:48:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 09:48:07 +0000
Subject: [Koha-bugs] [Bug 32281] New: Can I Get Aid From Cash App Customer
 Service Represeantives Over The Phone?
Message-ID: <bug-32281-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32281

            Bug ID: 32281
           Summary: Can I Get Aid From Cash App Customer Service
                    Represeantives Over The Phone?
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: paulilauli143 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Whenever you face any errors and hurdles with your Cash App account due to any
technical or non-technical reasons, you have to try contacting Cash App
Customer Service executives. To do so, you have to first make a call at the
official helpline number and this helpline number will connect you to a team of
highly skilled professionals. Moreover, you will have to contact these geeks
and they will help you to fix any problems permanently from the root.
https://www.emailcontacthelp.com/cash-app-customer-service.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:22:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:22:05 +0000
Subject: [Koha-bugs] [Bug 32282] New: Capitalization: User id
Message-ID: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

            Bug ID: 32282
           Summary: Capitalization: User id
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

ID is an abbreviation and as such should always be capitalized:

User id => User ID

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:406

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:36:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:36:49 +0000
Subject: [Koha-bugs] [Bug 32283] New: Capitalization: opac users of this
 domain to login with this identity provider
Message-ID: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

            Bug ID: 32283
           Summary: Capitalization: opac users of this domain to login
                    with this identity provider
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

opac is an abbreviation and needs to be written in capitals: OPAC

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:261

opac users of this domain to login with this identity provider

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:46:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:46:34 +0000
Subject: [Koha-bugs] [Bug 32284] New: Capitalization: Audio Carriers
Message-ID: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284

            Bug ID: 32284
           Summary: Capitalization: Audio Carriers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:15

Audio Carriers should be Audio carriers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:49:25 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_32285=5D_New=3A_Punctuation=3A_Comp?=
 =?utf-8?q?leteness_of_the_reproduction_code=E2=90=A0=3A?=
Message-ID: <bug-32285-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285

            Bug ID: 32285
           Summary: Punctuation: Completeness of the reproduction code␠:
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

In English, there is not space before the colon:

Completeness of the reproduction code␠:

should be

Completeness of the reproduction code:

in
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325h.tt:16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:50:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:50:17 +0000
Subject: [Koha-bugs] [Bug 32284] Capitalization: Audio Carriers,
 Computer Carriers
In-Reply-To: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32284-70-su6PTJu8tU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Capitalization: Audio       |Capitalization: Audio
                   |Carriers                    |Carriers, Computer Carriers

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Same for: Computer Carriers

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:77

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:51:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:51:53 +0000
Subject: [Koha-bugs] [Bug 32284] Capitalization: Audio Carriers,
 Computer Carriers ... in UNIMARC value builders
In-Reply-To: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32284-70-UVlr4viTkf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Capitalization: Audio       |Capitalization: Audio
                   |Carriers, Computer Carriers |Carriers, Computer Carriers
                   |                            |... in UNIMARC value
                   |                            |builders

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Content Form
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181a.tt:13

Content Type
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181c.tt:13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:55:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:55:26 +0000
Subject: [Koha-bugs] [Bug 32286] New: Update titles of UNIMARC value
 builders from "Framework plugin example"
Message-ID: <bug-32286-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32286

            Bug ID: 32286
           Summary: Update titles of UNIMARC value builders from
                    "Framework plugin example"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Some value builders still use the example text in their title attribute:

Framework plugin example &rsaquo; Cataloguing &rsaquo; Koha

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:2
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181a.tt:2
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:2
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181c.tt:2
...

These should be updated to describe the individual value builder.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:55:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:55:32 +0000
Subject: [Koha-bugs] [Bug 32286] Update titles of UNIMARC value builders
 from "Framework plugin example"
In-Reply-To: <bug-32286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32286-70-ZG2e1wKzjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32286

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 14:56:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 13:56:32 +0000
Subject: [Koha-bugs] [Bug 32286] Update titles of UNIMARC value builders
 from "Framework plugin example"
In-Reply-To: <bug-32286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32286-70-0HeYseH3aV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32286

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Example from other plugin: Framework-Plugin for UNIMARC 146$d

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:02:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:02:36 +0000
Subject: [Koha-bugs] [Bug 32284] Capitalization: Audio Carriers,
 Computer Carriers ... in UNIMARC value builders
In-Reply-To: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32284-70-OzEznWGI2b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32284

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Media Type
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt:13

Media Type Code␠
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt:13

Microform Carriers
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:133

Microscopic Carriers
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:195

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:07:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:07:06 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_32285=5D_Punctuation=3A_Completenes?=
 =?utf-8?b?cyBvZiB0aGUgcmVwcm9kdWN0aW9uIGNvZGXikKA6LCAuLi4=?=
In-Reply-To: <bug-32285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32285-70-wvdGMayOdU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Punctuation: Completeness   |Punctuation: Completeness
                   |of the reproduction code␠:  |of the reproduction code␠:,
                   |                            |...

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Also:

Number of units under embargo␠:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:121

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:09:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:09:44 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_32287=5D_New=3A_Capitalization=3A_P?=
 =?utf-8?q?rinting_and/or_Publishing_Information_Transcribed_as_Found_in_t?=
 =?utf-8?b?aGUgQ29sb3Bob2464pCg?=
Message-ID: <bug-32287-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32287

            Bug ID: 32287
           Summary: Capitalization: Printing and/or Publishing Information
                    Transcribed as Found in the Colophon:␠
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Found while translating:

Printing and/or Publishing Information Transcribed as Found in the Colophon:␠
koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl:161
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl:322

and

Printing and/or Publishing Information Transcribed as Found in the Main Source
of Information:␠
koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl:180
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl:341

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:11:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:11:20 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_32285=5D_Punctuation=3A_Completenes?=
 =?utf-8?b?cyBvZiB0aGUgcmVwcm9kdWN0aW9uIGNvZGXikKA6LCAuLi4=?=
In-Reply-To: <bug-32285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32285-70-TzEcs2Oe9o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Qualifier type␠:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:49

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:13:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:13:50 +0000
Subject: [Koha-bugs] [Bug 32288] New: Capitalization: RDA Carrier, etc.
Message-ID: <bug-32288-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32288

            Bug ID: 32288
           Summary: Capitalization: RDA Carrier, etc.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

RDA Carrier
       
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:17
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:19
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:17
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:19
...


RDA Content
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:23
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:25
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:23
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:25
...


RDA Media
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:29
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:31
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:29
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:31
...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:16:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:16:18 +0000
Subject: [Koha-bugs] [Bug 27017] Add defensive coding to EDI Invoice handling
In-Reply-To: <bug-27017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27017-70-PcxcYlqDNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27017

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:16:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:16:28 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-XqIDEs5bWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:19:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:19:40 +0000
Subject: [Koha-bugs] [Bug 32281] SPAM
In-Reply-To: <bug-32281-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32281-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32281-70-nsdYLrUWsR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32281

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
            Summary|Can I Get Aid From Cash App |SPAM
                   |Customer Service            |
                   |Represeantives Over The     |
                   |Phone?                      |
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:21:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:21:27 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-7ImPR60Hm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:21:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:21:28 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-xS3YZ3WjxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bug 23838 depends on bug 30275, which changed state.

Bug 30275 Summary: Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:21:29 +0000
Subject: [Koha-bugs] [Bug 30637] Add Koha::Checkout->renew method
In-Reply-To: <bug-30637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30637-70-y955XQ9kbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637
Bug 30637 depends on bug 30275, which changed state.

Bug 30275 Summary: Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:21:29 +0000
Subject: [Koha-bugs] [Bug 30642] We should record the renewal type
 (Automatic/Manual)
In-Reply-To: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30642-70-NqNUrLb67k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642
Bug 30642 depends on bug 30275, which changed state.

Bug 30275 Summary: Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:21:29 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-Lf0PxTzjPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133
Bug 31133 depends on bug 30275, which changed state.

Bug 30275 Summary: Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:23:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:23:19 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-YQFDovfHDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |renewals table to store
                   |                            |details of a checkouts
                   |                            |renewals.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:24:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:24:23 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-WsLdkvXSUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |modal to display checkout
                   |                            |renewal history details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 15:30:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 14:30:30 +0000
Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not
 require edit_borrowers permission
In-Reply-To: <bug-30230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30230-70-Qm3rPlXP0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 16:53:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 15:53:35 +0000
Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30568-70-I1HNveC15w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568

--- Comment #6 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
Here are some formats that would be appropriate for us:

firstname surname 

firstname (other names) surname

firstname (othernames) surname (cardnumber)


As I look at it now, we really just want to be able to output names in a
variety of formats without the title.  (e.g. including "title" in the item
status field in item detail.pl. is too much.)

We are also an outlier in that we have repurposed the title field for pronouns.
 So this would also be desirable for us:

firstname surname (title)

I hope I'm answering the right question here.  ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 18:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 17:59:32 +0000
Subject: [Koha-bugs] [Bug 32289] New: Punctuation:
Message-ID: <bug-32289-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289

            Bug ID: 32289
           Summary: Punctuation:
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt:        

<h1>Delete desk "[% desk.desk_name | html %]?"</h1>

The ending " should be before the question mark.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:00:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:00:10 +0000
Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?"
In-Reply-To: <bug-32289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32289-70-bWCDWZpV1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Punctuation:                |Punctuation: Delete desk
                   |                            |"...?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:04:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:04:34 +0000
Subject: [Koha-bugs] [Bug 32290] New: Terminology: You must choose a branch
Message-ID: <bug-32290-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290

            Bug ID: 32290
           Summary: Terminology: You must choose a branch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:                   
                        <span class="required">You must choose a branch</span>

Branch should be library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:07:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:07:52 +0000
Subject: [Koha-bugs] [Bug 30568] Make patron name fields more flexible
In-Reply-To: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30568-70-GWuZ81zw2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sarah, thx for weighing in. Just a note: 22.11 will have 2 new fields:
pronouns and middle name.  So you will be able to move from title to pronouns
if you'd like.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:09:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:09:39 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-FeiXl7fUos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Summary|Add Page Section to         |Add page-section to label
                   |Cataloguing - Label Creator |creator - manage labels
                   |- Manage Labels             |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:10:50 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 labels
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-FALSSAw2om@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Welcome Matt and Jacob  :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:13:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:13:18 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-Eg8s4N39YQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add page-section to label   |Add page-section to label
                   |creator - manage labels     |creator - manage label
                   |                            |layouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:15:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:15:59 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-jptDC5aKei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:16:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:16:03 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-5V90vJhQmr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144078|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144087&action=edit
Bug 32270: add page section to label layouts

Test plan:
Navigate to Cataloguing - Label creator - Manage label layots
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:26:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:26:30 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-gm8QQflTG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Geraud, commit message is looking much better. One more small thing: Make
sure the format of your subject line is: Bug xxxxx: without the additional
space before the :.
If you wan the QA test tools on your patches, they will point out such
mistakes. If you are using ktd docker, you can just do: qa -v 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:26:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:26:49 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-KKtYhXEqwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:26:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:26:53 +0000
Subject: [Koha-bugs] [Bug 32255] Cannot use file upload in batch record
 modification
In-Reply-To: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32255-70-0ldiEYQ04P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144088&action=edit
Bug 32255: Resolve "Cannot use file upload in batch record modification"

When using the batch record modification tool with a file of biblionumbers,
nothing happens. When we click 'Continue' the file is somehow removed before
continuing.

To test:
1. Get a file of biblionumbers (if you already have a file, proceed to step 2)
   1.1. Go to Reports
   1.2. Click on 'Create from SQL'
   1.3. Enter a report name (e.g. biblionumbers)
   1.4. Enter the following SQL query

SELECT biblionumber FROM biblio LIMIT 100

   1.5. Click 'Save report'
   1.6. Click 'Run report'
   1.7. Click 'Download' > 'Tab separated text'

2. Create a MARC modification template (if you already have a MARC modification
template, proceed to step 3)
   2.1. Go to Cataloging > MARC modification template
   2.2. Click 'New template'
   2.3. Enter a template name (e.g. Add note)
   2.4. Click 'Submit'
   2.5. Click 'New action'
   2.6. Choose
        - Add new
        - Field 500 a
        - with value Note
   2.7. Click 'Add action'

3. Batch modify records
   3.1. Go to Cataloging > Batch record modification
   3.2. In the 'Upload a file tab', choose the biblionumber file
   --> Note that the name of the file appears next to the Choose button
   3.3. In 'Template', select the MARC modification template
   3.4. Click 'Continue'
   --> The name of the file disappears next to the Choose button and goes back
to 'No file chosen'
   --> Message 'No records were modified

4. Apply path
   4.1. Procede step 3.
   4.2. See that we can see the list now

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:29:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:29:21 +0000
Subject: [Koha-bugs] [Bug 32290] Terminology: 'You must choose a branch' in
 ill-requests.tt
In-Reply-To: <bug-32290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32290-70-COw09YlZmq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Terminology: You must       |Terminology: 'You must
                   |choose a branch             |choose a branch' in
                   |                            |ill-requests.tt

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is another in this template:

koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:                   
    <div class="alert">This item cannot be issued as it has no biblio record
associated with it</div>

* issued should be checked out
* biblio record should be replaced with bibliographic record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 19:41:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 18:41:42 +0000
Subject: [Koha-bugs] [Bug 32291] New: What is a library category?
Message-ID: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

            Bug ID: 32291
           Summary: What is a library category?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Also noticed a while ago, while translating. The errors mention library
categories repeatedly, but I didn't figure out how to trigger those messages or
what they were referring to. What is a library category and how can you add
one?

The page is Administration > Libraries
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt

        [% CASE 'error_on_update_category' %]
            <span>An error occurred when updating this library category.
Perhaps it already exists.</span>
        [% CASE 'error_on_insert_category' %]
            <span>An error occurred when adding this library category. The
categorycode might already exist.</span>
        [% CASE 'error_on_delete_category' %]
            <span>An error occurred when deleting this library category. Check
the logs.</span>
        [% CASE 'success_on_update_category' %]
            <span>Library category updated successfully.</span>
        [% CASE 'success_on_insert_category' %]
            <span>Library category added successfully.</span>
        [% CASE 'success_on_delete_category' %]
            <span>Library category deleted successfully.</span>
        [% CASE 'cannot_delete_category' %]
            <span>This library category cannot be deleted. [%
m.data.libraries_count | html %] libraries are still using it.</span>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:02:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:02:38 +0000
Subject: [Koha-bugs] [Bug 32292] New: suggestions in Columns.pm are not
 translated to real labels
Message-ID: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

            Bug ID: 32292
           Summary: suggestions in Columns.pm are not translated to real
                    labels
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr, jonathan.druart+koha at gmail.com

When looking at Column.pm, you can see that all the columns are translated to
nice display messages, but not the ones for suggestions. They are direct copies
of the names of the database columns. This means that 'collectiontitle' and
similar show up in translations creating some confusion.

Should these not also be nice labels?

        suggestions=> {
            "author"          => __("author"),
            "copyrightdate"   => __("copyrightdate"),
            "isbn"            => __("isbn"),
            "publishercode"   => __("publishercode"),
            "collectiontitle" => __("collectiontitle"),
            "place"           => __("place"),
            "quantity"        => __("quantity"),
            "itemtype"        => __("itemtype"),
            "branchcode"      => __("branchcode"),
            "patronreason"    => __("patronreason"),
            "note"            => __("note"),
            "title"           => __("title"),
        }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:06:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:06:40 +0000
Subject: [Koha-bugs] [Bug 32293] New: Terminology: Some budgets are not
 defined in item records
Message-ID: <bug-32293-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293

            Bug ID: 32293
           Summary: Terminology: Some budgets are not defined in item
                    records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The error message should use 'funds' not 'budgets':

koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js:            
alert( __("Some budgets are not defined in item records") )

I think that this one appears when you try to add orders from a staged file,
but leave the fund empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:50:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:50:47 +0000
Subject: [Koha-bugs] [Bug 32294] New: Capitalization:
Message-ID: <bug-32294-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294

            Bug ID: 32294
           Summary: Capitalization:
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Web based self check help text:

Enter your User ID, and click the submit button (or press the enter key).

Should be: user ID

To test:
* Enable WebBasedSelfCheck 
* Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC
* Log in and open help

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:51:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:51:11 +0000
Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID...
In-Reply-To: <bug-32294-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32294-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32294-70-K53152aZlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Capitalization:             |Capitalization: Enter your
                   |                            |User ID...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:55:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:55:34 +0000
Subject: [Koha-bugs] [Bug 32115] Add ID to check-out default help message
 dialog to allow customization
In-Reply-To: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32115-70-ruhelXpx98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:55:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:55:39 +0000
Subject: [Koha-bugs] [Bug 32115] Add ID to check-out default help message
 dialog to allow customization
In-Reply-To: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32115-70-UAE4pcH7ec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144089&action=edit
Bug 32115: Add ID to check-out default help message dialog to allow
customization

This adds a div with the id attribute selfcheckdefaulthelpmessage to
the first paragraph of the web based self check help page.

To test:
* Enable WebBasedSelfCheck
* Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC
* Log in and open help
* Verify by looking at the source code, that the first paragraph
  starting with "If this is your first time..." now has an id.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 20:56:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 19:56:17 +0000
Subject: [Koha-bugs] [Bug 32115] Add ID to check-out default help message
 dialog to allow customization
In-Reply-To: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32115-70-cU2xfohQ5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32115

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mona, I believe this has been your first patch for Koha? Welcome! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:01:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:01:57 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-Enzlf4nGpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:02:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:02:02 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-sszhMiMwQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144067|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144090&action=edit
Bug 32269: Prevent Circulation.t to fail randomly

Highlighted by Bug 32030: fix test builder for boolean

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 343.
    #          got: '2022-11-18T14:16:12'
    #     expected: '2022-12-02T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 349.
    #          got: '2022-11-18T14:16:12'
    #     expected: '2022-12-02T23:59:00'
    # Looks like you failed 2 tests of 5

We were reaching return $now

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:05:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:05:29 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-rJzIhjewbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |nick at bywatersolutions.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure Jonathan, there are several different errors.

[Tue Oct 18 14:19:17.189372 2022] [cgi:error] [pid 3532853] [client
186.102.58.32:7547] AH01215: {UNKNOWN}: DBI Exception: DBD::mysql::db
selectall_arrayref failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near ',servername' at line 3  at /usr/share/perl5/DBIx/Class/Schema.pm line
1118.: /usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://intra-archivohistoricopsbdc.org/cgi-bin/koha/cataloguing/addbooks.pl

Do you have any SRU/Z39.50 sources configured? servername is a column there.

186.102.16.136:36960] AH01215: Template process failed: undef error - The
method Koha::KeyboardShortcuts->shortcut_keys is not covered by tests!:
/usr/share/koha/intranet/cgi-bin/cataloguing/editor.pl, referer:
http://archivohistorico-intra.org:82/cgi-bin/koha/cataloguing/addbooks.pl

This one also doesn't look good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:07:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:07:22 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-fypg3uCW0m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144081|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144091&action=edit
Bug 32254: (follow-up) Add missing div around "Older transactions"

To test:

- Tools -> Cash summary for <library> and Tools -> Transaction history
  for <register>
  - In the "Older transactions" section, submit start and end dates
    which will return results.
  - The table of results should be styled correctly.

Signed-off-by: David <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:14:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:14:06 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-tw1E7trqj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:14:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:14:11 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-oTUikWoBM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144057|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144092&action=edit
Bug 32260: Patron autocomplete - Do not display an alert if request is rejected

Not sure what is going on exactly, neither if this patch is the correct
way to fix this.
The request is "rejected" at some point (by the browser?), when we
search for patrons using the autocomplete and DT "at the same time".

To recreate:
Don't apply this patch
Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5
Search for "edn" then hit enter
You may see an alert, that will disappear
If you don't see the alert, repeat

This patch suggests to ignore the alert if the status of the request is
"rejected".

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:18:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:18:08 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-ZWYrgLftDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:18:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:18:12 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-nD5DTHm9uR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144058|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144093&action=edit
Bug 32261: Patron autocomplete - do not empty text field

The jQuery UI autocomplete is supposed to replace the text field with
the 'value' attribute of the selected item. As it does not exist it's
emptied. We should not replace what the user typed in.

Test plan:
Go to the Koha home page
Select "Search patrons" in the header
Type 'edn', it will return 1 result
Use the down key to select the item (it is not obvious but there is a
little change in the color when you select the item)
=> Without this patch the search field is emptied
=> With this patch applied the search field is not modified

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:18:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:18:17 +0000
Subject: [Koha-bugs] [Bug 32261] Insufficient user feedback when selecting
 patron in autocomplete
In-Reply-To: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32261-70-aY6BkzgZnC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144059|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144094&action=edit
Bug 32261: Add more UI feedback when selecting patron from autocomplete

There is only a tiny change in the color of the selected item, but it's
not obvious.

Test plan:
Regenerate the css files using `yarn build`
Search for patrons and note that the down/up keys let you select a
patron and the background color change.
Note that the background color is not on the container and so is not
similar as the hover rule (when using the mouse). We could change that,
but then the behaviour is weird when you have both the mouse and the
keyboard selecting items in the item list.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:22:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:22:25 +0000
Subject: [Koha-bugs] [Bug 31856] Improve performance of serials
 subscriptions search
In-Reply-To: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31856-70-LcvcRRvsDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31856

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is there a trick or script we could use to add a lot of subscriptions? Have
been pondering how to best test this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:22:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:22:58 +0000
Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface
 sometimes creates invalid Zebra query
In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31841-70-XfAzfdOCQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, did you mean to sign-off here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:38:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:38:05 +0000
Subject: [Koha-bugs] [Bug 32295] New: Punctuation: Filters :
Message-ID: <bug-32295-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295

            Bug ID: 32295
           Summary: Punctuation: Filters :
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/serials/claims.pl
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

On the late issues page for subscriptions, the heading is:

Filters :

But should be:

Filters:

To test:
* Add a subscription
* Generate next issue, to have a late one
* Go to serials > claims
* Select your vendor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:39:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:39:12 +0000
Subject: [Koha-bugs] [Bug 16723] Add additional subscription fields to
 serial claim notices
In-Reply-To: <bug-16723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16723-70-mYHkSP7SH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like we can only access the branches object in this notice via TT
right now:
https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Variables_available_in_each_notice

Can this be true?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 21:57:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 20:57:14 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-xzsAxZYKd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 22:01:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 21:01:23 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-Bu36Iffg9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 22:01:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 21:01:28 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-DHMHGze0RH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144095&action=edit
Bug 31233: Amend 'fine grace period' as it's also used for suspensions

The grace period setting in circulation rules is not only used
for fines, but also for suspensions. So the label 'Fine grace period'
is a little misleading.

This patch updates it to "Fine/suspension grace period".

To test:
* Go to Administration > Circulation rules
* Verify the description is "Fine grace period" in the big table
* Apply patch
* Verify the description now changed to "Fine/suspension grace period"

https://bugs.koha-community.org/show_bug.cgi?id=32261

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 22:05:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 21:05:02 +0000
Subject: [Koha-bugs] [Bug 31326] Koha::Biblio->get_components_query fetches
 too many component parts
In-Reply-To: <bug-31326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31326-70-TFrLaJlA1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31326

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Johanna, could you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 22:14:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 21:14:06 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-eTJA7i4LG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 19 22:15:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Nov 2022 21:15:30 +0000
Subject: [Koha-bugs] [Bug 27761] Koha is reporting deleted items when a
 pickup is done by OAI
In-Reply-To: <bug-27761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27761-70-c0gLAcwr7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27761

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There hasn't been a comment of feedback to questions for a year now. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:22:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:22:06 +0000
Subject: [Koha-bugs] [Bug 28290] Record matching rules with no subfields
 cause ISE
In-Reply-To: <bug-28290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28290-70-3QnxSVm8JJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:22:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:22:31 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-7XuJmwXT3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:25:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:25:00 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
 the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To: <bug-26626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26626-70-ZrGVviKecd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:27:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:27:01 +0000
Subject: [Koha-bugs] [Bug 31401] Update administration sidebar to match
 entries on administration start page
In-Reply-To: <bug-31401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31401-70-mOacdXNyCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:27:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:27:01 +0000
Subject: [Koha-bugs] [Bug 31411] [Omnibus] Set focus to first input field of
 an add/entry form
In-Reply-To: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31411-70-Vjxrwg3tIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411
Bug 31411 depends on bug 31401, which changed state.

Bug 31401 Summary: Update administration sidebar to match entries on administration start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31401

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:28:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:28:57 +0000
Subject: [Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber
 and issues.itemnumber
In-Reply-To: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30483-70-hwe3gQ67Xa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to stable            |RESOLVED

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:28:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:28:58 +0000
Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
 (older) database revisions
In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30486-70-gTQMrtXQvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
Bug 30486 depends on bug 30483, which changed state.

Bug 30483 Summary: Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:32:44 +0000
Subject: [Koha-bugs] [Bug 31542] Home page links wrong font-family
In-Reply-To: <bug-31542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31542-70-NsWkRmfLZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31542

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:34:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:34:09 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-okL8QiGxMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:34:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:34:36 +0000
Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29658-70-RXkrhfSdvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:34:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:34:58 +0000
Subject: [Koha-bugs] [Bug 31486] Deleting a message from checkouts tab
 redirects to detail tab in patron account
In-Reply-To: <bug-31486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31486-70-RJ9zobY4K9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:35:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:35:22 +0000
Subject: [Koha-bugs] [Bug 31516] Missing error handling for accessing
 deleted/non-existent club enrollment
In-Reply-To: <bug-31516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31516-70-QUAZxMWyY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 01:35:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 00:35:51 +0000
Subject: [Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad
 data or constraints
In-Reply-To: <bug-29409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29409-70-EA6dazTeOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 02:42:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 01:42:04 +0000
Subject: [Koha-bugs] [Bug 32296] New: Capitalization: Specification of
 Dimensionality, ...
Message-ID: <bug-32296-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32296

            Bug ID: 32296
           Summary: Capitalization: Specification of Dimensionality,...
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Specification of Dimensionality␠
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:79

Specification of Motion␠
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:49

Specification of Type
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:13

Stereographic Carriers
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:271

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 02:48:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 01:48:00 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_32297=5D_New=3A_Punctuation=3A_Syst?=
 =?utf-8?b?ZW0gY29kZeKQoDosIC4uLg==?=
Message-ID: <bug-32297-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32297

            Bug ID: 32297
           Summary: Punctuation: System code␠:, ...
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

There should be no space before the colon:

System code␠:
       
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181-2.tt:13
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt:13
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt:13
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_283-2.tt:13

Terms of access to the reproduction␠:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:13

Unit under embargo␠:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:79

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 13:35:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 12:35:31 +0000
Subject: [Koha-bugs] [Bug 32278] Batch modifications from the biblio page
 can cause 414 URI too long when attempting to modify many items
In-Reply-To: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32278-70-U1vhietnmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32278

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 13:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 12:48:40 +0000
Subject: [Koha-bugs] [Bug 32266] Large amount of late orders slows the
 service
In-Reply-To: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32266-70-tY1X34qX23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 13:49:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 12:49:43 +0000
Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without
 borrowers permission
In-Reply-To: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10943-70-NHHa1ti2Xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 13:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 12:59:32 +0000
Subject: [Koha-bugs] [Bug 32298] New: Add page-section to cataloguing search
 results (cat)
Message-ID: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

            Bug ID: 32298
           Summary: Add page-section to cataloguing search results (cat)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/cataloguing/addbooks.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

When searching in the cataloguing module, the results page needs
page-sectioning for both areas: local results and results in the reservoir.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 13:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 12:59:32 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-5iJm2qtQis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298
[Bug 32298] Add page-section to cataloguing search results (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 13:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 12:59:32 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-mGiEqPJQIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298
[Bug 32298] Add page-section to cataloguing search results (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:01:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:01:29 +0000
Subject: [Koha-bugs] [Bug 32299] New: Add page-section to Z39.50/SRU results
 (cat)
Message-ID: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

            Bug ID: 32299
           Summary: Add page-section to Z39.50/SRU results (cat)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/cataloguing/z3950_search.pl
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

When searching Z39.50 the result list should have a page-section on the table.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:01:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:01:29 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-3QPGPCl2bq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32299


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299
[Bug 32299] Add page-section to Z39.50/SRU results (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:01:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:01:29 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-P0jSWN3iBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32299


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299
[Bug 32299] Add page-section to Z39.50/SRU results (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:35:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:35:14 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-QbZX2ZrNAS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Catrina Berka from comment #19)
> Created attachment 140836 [details]
> Screencast showing 008 defaults to BK
> 
> This screencast shows how the 008 reverts back to Material Type BK, even
> when changed to VM in the record creation process, using the 008 helper.

Hi Catrina, 

please check that your LDR pos. 6 is set correctly. In your video you left it
unchanged, so it used BK which is default. Koha will determine the selection on
008 depending on the LDR setting. I just tested this and it seems to still work
ok on master.

Some ideas how we can improve this for discussion:

* Add a note that the value will be pulled from LDR pos. 6 to the label of the
008 material type pull down
* Don't allow to update the material type pull down manually, make it read
only.

What do you all think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:36:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:36:31 +0000
Subject: [Koha-bugs] [Bug 32300] New: Add page-section to cataloguing
 plugins (cat)
Message-ID: <bug-32300-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300

            Bug ID: 32300
           Summary: Add page-section to cataloguing plugins (cat)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/cataloguing/plugin_launcher.pl?
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952
            Blocks: 31757

The cataloguing plugins need page-sections as well, especially;

* 007
* 008
* LDR


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:36:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:36:31 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-BpWVgpJX9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32300


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300
[Bug 32300] Add page-section to cataloguing plugins (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:36:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:36:31 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-S2bp6Hxkqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32300


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300
[Bug 32300] Add page-section to cataloguing plugins (cat)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:46:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:46:06 +0000
Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in
 cash_register_stats.pl
In-Reply-To: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29664-70-62OuH7Y8FU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have just verified that this is still the beahviour on master. When limiting
the search to payments, the voided payments show and the total given is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 14:49:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 13:49:56 +0000
Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series
 because of OPAC/staff interface confusion
In-Reply-To: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30162-70-atNUo41cSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Patch doesn't apply in a mean way, wondering if this was maybe written for an
older version/not on master branch?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 30162 - XSLT has broken link for traced series because of
OPAC/staff interface confusion
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl).
error: could not build fake ancestor
Patch failed at 0001 Bug 30162 - XSLT has broken link for traced series because
of OPAC/staff interface confusion
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-30162---XSLT-has-broken-link-for-traced-series-_pb72j.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 15:03:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 14:03:25 +0000
Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series
 because of OPAC/staff interface confusion
In-Reply-To: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30162-70-CKnWtw4yA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|Patch doesn't apply         |RESOLVED

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I tried rewriting this patch for master, but there is no longer any mention of
the control-number index in the Utils file on master:

        <xsl:for-each select="marc:datafield[@tag=830 and @ind1!='z']">
            <xsl:choose>
                <xsl:when test="$UseControlNumber = '1' and
marc:subfield[@code='w']">
                    <a
href="/cgi-bin/koha/catalogue/search.pl?q=rcn:{marc:subfield[@code='w']}">


More so, to me it looks like it has always been rcn and not control-numer -
could this have been a local change? Scratching my head looking at the git
histories here:

https://git.koha-community.org/Koha-community/Koha/commit/c4e04e2cbaff0a9af124dc5a28ddbdc7058405d0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 23:33:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 22:33:18 +0000
Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface
 sometimes creates invalid Zebra query
In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31841-70-M8cnmiOGpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #5)
> Hi David, did you mean to sign-off here?

I'm not sure I understand the question? 😅

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 23:41:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 22:41:32 +0000
Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface
 sometimes creates invalid Zebra query
In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31841-70-S2RAsnCa8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > Hi David, did you mean to sign-off here?
> 
> I'm not sure I understand the question? 😅

Sorry, I got confused :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 23:48:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 22:48:49 +0000
Subject: [Koha-bugs] [Bug 32278] Batch modifications from the biblio page
 can cause 414 URI too long when attempting to modify many items
In-Reply-To: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32278-70-Yp3AWeqJzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32278

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Off the top of my head, for scale, I think we'd want to POST itemnumbers
(probably in batches) to an API "add to batch" endpoint, and then call an API
endpoint to perform the batch mod (as a background job).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 23:49:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 22:49:45 +0000
Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface
 sometimes creates invalid Zebra query
In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31841-70-phknPpN0YP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #7)
> Sorry, I got confused :)

No worries!

I'd love to someone to sign it off though heh.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 23:50:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 22:50:10 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_32297=5D_Punctuation=3A_System_code?=
 =?utf-8?b?4pCgOiwgLi4u?=
In-Reply-To: <bug-32297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32297-70-dAA0EHnt7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32297

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 20 23:50:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Nov 2022 22:50:17 +0000
Subject: [Koha-bugs] [Bug 32296] Capitalization: Specification of
 Dimensionality, ...
In-Reply-To: <bug-32296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32296-70-03j3sK6Prh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32296

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 02:51:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 01:51:22 +0000
Subject: [Koha-bugs] [Bug 32291] What is a library category?
In-Reply-To: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32291-70-sJWKicnTa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:37:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:37:42 +0000
Subject: [Koha-bugs] [Bug 32301] New: Show correct defaultSortField in Staff
 Client Advanced Search
Message-ID: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

            Bug ID: 32301
           Summary: Show correct defaultSortField in Staff Client Advanced
                    Search
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wainuiwitikapark at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 144096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144096&action=edit
Sort by option in Staff Client Advanced Search

The defaultSortField system preference doesn't seem to affect the Staff Client
Advanced Search, it still shows 'relevance' as the sort field whichever option
you use in the syspref. 

However, when you submit the search it does in fact search by the value of the
syspref.

Need to:

- In the advanced search in the staff client, display the correct default "sort
by" option that is chosen in the defaultSortField system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:50:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:50:38 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-TYPMETf7BK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:50:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:50:48 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-HC99GAyUmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142897|0                           |1
        is obsolete|                            |

--- Comment #199 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144097&action=edit
Bug 8367: Add holds_pickup_period circulation rule

So that pickup delay can have a different value per patron category,
   item type or branch.

To test:

1) Update database, restart services
2) Set ReservesMaxPickUpDelay syspref (if not already set)
3) Edit your circulation rules and set a value under 'Holds pickup
period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few
different numbers for different branches as well.
4) Place a hold on a biblio from the staff client.
5) Check in an item from that biblio and confirm the hold as waiting
6) Confirm the expiration date is calculated using the 'Holds pickup
period' value instead of the ReservesMaxPickUpDelay syspref
7) Revert the waiting status and delete the hold
8) Re-place the hold on the biblio on the OPAC. Notice that when you
change the pick up location, the number of days in the pickup message
below the dropdown changes based on the circ rules.
9) Create a holiday with a date that will overlap with the 'Holds pickup
period'
10) Check in an item from that biblio and confirm the hold as waiting
11) Confirm the expiration date is calculated using the 'Holds pickup
period' value AND considers the special holiday
12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t
13) Test Talking Tech:
13a) Enable TalkingTechItivaPhoneNotification
13b) Go to Tools -> Notices & slips. Add content to the HOLD phone
(itiva) notice.
13c) In your terminal, run perl
/path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o
~/itiva.tmp -w 0 --type=RESERVE

Sponsored-by: Catalyst IT

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:50:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:50:57 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-h6uO1d7B05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142898|0                           |1
        is obsolete|                            |

--- Comment #200 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144098&action=edit
Bug 8367: Make database update idempotent

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:52:16 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-XJSBEllbzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142899|0                           |1
        is obsolete|                            |

--- Comment #201 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144099&action=edit
Bug 8367: Make database update idempotent (across different MariaDB versions)

The previous query seemed to work on MariaDB 10.1.48 (used by
koha-testing-docker),
but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this
writing),
but this patched query works on both indempotently.

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:52:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:52:27 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-xgtOr9LRmX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142900|0                           |1
        is obsolete|                            |

--- Comment #202 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144100&action=edit
Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:52:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:52:38 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-X6ZaOtbGFW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142901|0                           |1
        is obsolete|                            |

--- Comment #203 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144101&action=edit
Bug 8367: (follow-up) Remove pickup delay message from OPAC

It adds unnecessary complexity and information.

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:52:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:52:47 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-hFprox0y9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142902|0                           |1
        is obsolete|                            |

--- Comment #204 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144102&action=edit
Bug 8367: (follow-up) Fix tests

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 03:52:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 02:52:56 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-ypqZH1k1JJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142903|0                           |1
        is obsolete|                            |

--- Comment #205 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144103&action=edit
Bug 8367: (follow-up) Remove unnecessary code and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:18:05 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-HXzv51PrFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:18:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:18:11 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-P7PYPG7DER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142594|0                           |1
        is obsolete|                            |

--- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144104&action=edit
Bug 31391: Request recalls and convert reserves on staff interface

This enhancement adds the ability to place recalls via the staff
interface by introducing a system preference, RecallsInterface, to
configure where recalls can be placed. Recalls can either be placed via
the OPAC, or the staff interface, or both. This is set to OPAC by
default to be consistent with current behaviour.

This enhancement also adds the ability to convert existing reserves to
recalls easily via the staff interface. The reserve will be cancelled
and a recall placed using the reserve's information.

To test:
1) Update database and restart services
2) Enable UseRecalls and set the relevant recalls circulation rules
3) View the new RecallsInterface system preference. Confirm it is set to
OPAC only by default
4) Check out Item A to Patron B.
5) Log into the OPAC as Patron A. Confirm you can place, view and cancel
recalls as normal.
6) In the staff interface, set RecallsInterface to Staff interface only.
7) In the OPAC, confirm you can still view and cancel recalls, but can
no longer place recalls.
8) In the staff interface, search for Item A and go to the Reserves tab.
Place a reserve for Patron C.
9) Under the Priority column, select the dropdown and choose the recall
option next to your reserve.
10) Click Update holds. Confirm when the page refreshes that your
reserve has disappeared.
11) Go to the recalls tab. Confirm your reserve has been converted to a
recall, and details like the patron, expiration, and pickup location have
carried across to the recall.
12) On this recalls page, use the patron search to find Patron D. Test
placing a record-level recall by keeping the 'recall next available
item' checkbox.
13) When the page refreshes, confirm the recall was successfully placed
with the correct details stored.
14) Repeat steps 12 and 13 with Patron E, this time place an item-level
recall by choosing an item in the 'place a recall on a specific item'
table. When selecting one of these items, the 'recall next available
item' checkbox should de-select.
15) Set RecallsInterface back to OPAC only. Go back to the record and
view the Recalls tab.
16) Confirm you cannot search for a patron to place a recall, but can
still view and cancel recalls. Confirm you also cannot convert reserves
to recalls.
17) Set RecallsInterface to both staff interface and OPAC. Confirm you
can place recalls on both interfaces.
18) On the staff interface, test placing recalls that your circulation
rules do not allow. For example, if 'recalls per record' is 1, ensure
you're blocked from placing a second recall on a record for a patron.
19) Place a reserve for one of the patron's that already has a recall.
Once complete, try to convert this reserve into a recall. Confirm you
are blocked and shown a message that the hold cannot be converted to a
recall.
20) Ensure tests pass t/db_dependent/Holds.t

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:18:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:18:16 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-5LlABOMQHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143155|0                           |1
        is obsolete|                            |

--- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144105&action=edit
Bug 31391: (follow-up) Fix cancel recalls using checkbox

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:23:32 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-bAk7ycrc38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Nind from comment #17)
> This is still not working for me and doesn't appear to be fixed.
> 
> If it helps, there is an entry in
> /var/log/koha/kohadev/plack-intranet-error.log:
> [2022/11/04 06:36:44] [WARN] Use of uninitialized value $biblionumber in
> concatenation (.) or string at /kohadevbox/koha/recalls/request.pl     line
> 49.
> 
> Everything else continues to work as per the test plan.

Sorry you were right - amended in most recent patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:24:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:24:26 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in Staff
 Client Advanced Search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-Z5JPfJVtVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144096|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:25:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:25:07 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in Staff
 Client Advanced Search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-VoOytZmu5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

--- Comment #1 from wainuiwitikapark at catalyst.net.nz ---
Sort by option in Staff Client Advanced Search

The defaultSortField system preference doesn't seem to affect the Staff Client
Advanced Search, it still shows 'relevance' as the sort field whichever option
you use in the syspref. 

However, when you submit the search it does in fact search by the value of the
syspref.

Need to:

- In the advanced search in the staff client, display the correct default "sort
by" option that is chosen in the defaultSortField system preference

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 04:25:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 03:25:20 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-Coqfpent1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #49 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Marcel de Rooy from comment #47)
> Wondering if this is a bit too aggressively cleaning up?
> E.g. field 008 (and maybe more control fields) could end with a few spaces.
> You will remove them, which is not correct.

Should I write a follow-up to exclude fields < 010?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 06:58:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 05:58:59 +0000
Subject: [Koha-bugs] [Bug 32302] New: Hide "ISBN" label when no ISBN data
 when sending list
Message-ID: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

            Bug ID: 32302
           Summary: Hide "ISBN" label when no ISBN data when sending list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

There's a template toolkit bug in the condition for BIBLIO_RESULT.ISBN in
./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt so "ISBN:" shows
in the email whether or not there is any ISBN data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 06:59:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 05:59:05 +0000
Subject: [Koha-bugs] [Bug 32302] Hide "ISBN" label when no ISBN data when
 sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-W3BXP4EjHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 07:55:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 06:55:47 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-6UNPirDjRV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This is still failing.

Jenkins is getting "no such alert" and I have "unexpected alert open"
locally...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 07:58:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 06:58:03 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-UZu2Gj5KA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144106&action=edit
Bug 32010: 2AF selenium tests - Alert can appear when we are waiting for ajax

If we are waiting for ajax (there is a sleep 1s) and the alert pops up
at the same time, Selenium is raising "unexpected alert open"

We should not wait for the ajax request, but better wait for the
alert actually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 07:58:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 06:58:28 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-Wp6hPrFoYc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 08:49:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 07:49:13 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-RUG1GfER4p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Aleisha Amohia from comment #49)
> (In reply to Marcel de Rooy from comment #47)
> > Wondering if this is a bit too aggressively cleaning up?
> > E.g. field 008 (and maybe more control fields) could end with a few spaces.
> > You will remove them, which is not correct.
> 
> Should I write a follow-up to exclude fields < 010?

Sounds reasonable to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 08:49:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 07:49:42 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-D7D8nDADjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29695
           Keywords|                            |Academy

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Yes, I think so.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
[Bug 29695] Centralize columns' descriptions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 08:49:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 07:49:42 +0000
Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29695-70-xtCe5gVUaN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32292


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292
[Bug 32292] suggestions in Columns.pm are not translated to real labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 09:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 08:59:12 +0000
Subject: [Koha-bugs] [Bug 32303] New: DT pagination on system preference
 search result
Message-ID: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

            Bug ID: 32303
           Summary: DT pagination on system preference search result
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30952

Weird thing here, The DataTable pagination is displayed when it should not, and
it appears twice.

To recreate, search for "last"

http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=last

Go to the "OPAC" section, and see: https://snipboard.io/E3boHT.jpg


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 09:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 08:59:12 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-CH3vyshPfu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32303


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303
[Bug 32303] DT pagination on system preference search result
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:11:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:11:58 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-QeWVNzz6fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
What's your opinion on this?

I don't mind reintroducing the "feature", but there is something inconsistent:
We are displaying "Last returned by" if StoreLastBorrower is set, but then
display the last 3 patrons who borrowed the items whatever is the value of
StoreLastBorrower.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:23:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:23:10 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-AZEao4OoFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:23:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:23:14 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-o3FbvBT79X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144107&action=edit
Bug 32272: Restore last and previous borrowers on moredetail

GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of
the last 3 borrowers.
But 31315 forgot to adjust the code when it has been moved to using
Koha::Items

Test plan:
Check an item in and out to several patrons
Go to the moredetail page (items) and confirm that the "last borrowers"
info is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:23:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:23:57 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-6cpMFPb73L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:24:31 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-OBtMhpUzkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Marking as 22.11 candidate but could be for .01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:35:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:35:29 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-UeEPRHrOph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I am seeing this now Tomas, but it should not be related to this report:

# Subtest: purge
    1..9
    ok 1 - Only the old finished type1 job would be purged
    not ok 2 - All finished old jobs would be purged with job_types = all
    #   Failed test 'All finished old jobs would be purged with job_types =
all'
    #   at t/db_dependent/Koha/BackgroundJobs.t line 162.
    #          got: '5'
    #     expected: '2'
    ok 3 - All jobs still left in queue
    ok 4 - Only the old finished type1 job is purged
    ok 5 - 3 jobs still left in queue
    not ok 6 - The remaining old finished jobs is purged
    #   Failed test 'The remaining old finished jobs is purged'
    #   at t/db_dependent/Koha/BackgroundJobs.t line 183.
    #          got: '4'
    #     expected: '1'
    ok 7 - 2 jobs still left in queue
    ok 8 - Unfinished job still left in queue
    ok 9 - Recent finished job still left in queue
    # Looks like you failed 2 tests of 9.
not ok 15 - purge

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:42:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:42:24 +0000
Subject: [Koha-bugs] [Bug 32304] New: Subtest purge in BackgroundJobs.t
 fails when having older jobs
Message-ID: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

            Bug ID: 32304
           Summary: Subtest purge in BackgroundJobs.t fails when having
                    older jobs
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

See comment18 of bug 32242

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:46:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:46:38 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-MLAJqktz34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #18)
>     not ok 2 - All finished old jobs would be purged with job_types = all
>     #   Failed test 'All finished old jobs would be purged with job_types =
> all'
>     #   at t/db_dependent/Koha/BackgroundJobs.t line 162.
>     #          got: '5'
>     #     expected: '2'

It seems that this test assumes that there are no other old jobs. So this
should be corrected by removing them all first ?
Opened bug 32304.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:55:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:55:37 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-l8uPg0zjgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:55:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:55:41 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-ZSj9ySRFw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144108&action=edit
Bug 32304: BackgroundJobs.t - Start purge test with clean sheet

Test plan:
Run t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:55:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:55:58 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-y8pEcmU4WV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:56:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:56:53 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-l8o3UA1MS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Trivial: self SO

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 10:59:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 09:59:06 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-ro4IuRv5Cs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:00:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:00:43 +0000
Subject: [Koha-bugs] [Bug 31421] Library limitation on patron category
 breaks patron search
In-Reply-To: <bug-31421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31421-70-5OiOUvtysI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07,         |22.11.00, 22.05.07
        released in|21.11.14                    |

--- Comment #16 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
revert on 21.11. bug actually not reproduced.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:01:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:01:38 +0000
Subject: [Koha-bugs] [Bug 31364] Saving multi-select system preference don't
 save when all checks are removed
In-Reply-To: <bug-31364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31364-70-kf995885zO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07,         |22.11.00, 22.05.07
        released in|21.11.14                    |

--- Comment #14 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
revert on 21.11, bug not reproduced

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:12:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:12:23 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?=
 =?utf-8?b?4pyUIOKdpCDimIU=?=
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-ocmrIBkVol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Test bug for Git-bz         |Test bug for Git-bz ✔ ❤ ★

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:13:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:13:39 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?=
 =?utf-8?b?4pyUIOKdpCDimIU=?=
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-ABntZ2qwye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:13:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:13:48 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?=
 =?utf-8?b?4pyUIOKdpCDimIU=?=
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-DAcq39hWb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #260 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144109&action=edit
Bug 6473 - Test bug for Git-bz ✔ ❤ ★

Bug 6473 - Test bug for Git-bz ✔ ❤ ★
Bug 6473 - Test bug for Git-bz ✔ ❤ ★

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:21:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:21:33 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-D3UqQEiWc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32304

--- Comment #89 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #88)
> I don't recreate locally. I've run the different tests that (directly)
> insert background jobs, there are some leftover in the DB, but the tests are
> still passing.
> 
> 21:28:55 koha_1       |     #   Failed test 'No jobs found without userenv'
> 21:28:55 koha_1       |     #   at t/db_dependent/Koha/BackgroundJobs.t line
> 135.
> 21:28:55 koha_1       |     #          got: '2'
> 21:28:55 koha_1       |     #     expected: '0'
> 21:28:55 koha_1       |     # Looks like you failed 1 test of 3.
> 21:28:55 koha_1       | 
> 21:28:55 koha_1       | #   Failed test 'search_limited'
> 21:32:22 koha_1       | #   at t/db_dependent/Koha/BackgroundJobs.t line 142.
> 21:32:22 koha_1       | # Looks like you failed 1 test of 15.
> 21:32:22 koha_1       | [20:28:55] t/db_dependent/Koha/BackgroundJobs.t

See bug 32304.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304
[Bug 32304] Subtest purge in BackgroundJobs.t fails when having older jobs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:21:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:21:33 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-s0uIr2bpBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30982


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
[Bug 30982] Use the REST API for background job list view
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:23:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:23:53 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-IhWbW4vcQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
It's usually a bad idea to remove data. You should adapt your code, like count
before and after. We had problem recently (like delete from borrowers does not
work if you have issues, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 11:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 10:31:31 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-B1aQ92YE8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> It's usually a bad idea to remove data. You should adapt your code, like
> count before and after. We had problem recently (like delete from borrowers
> does not work if you have issues, etc.)

Thanks.
I didnt write this test. So I leave that to the author. Just providing a quick
fix for a 'silly' assumption.
Note that there are a lot of those deletes in test scripts though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 12:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 11:05:15 +0000
Subject: [Koha-bugs] [Bug 31616] koha_worker isn't using RabbitMQ on startup
 if it's a local server.
In-Reply-To: <bug-31616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31616-70-vOEcxeZG9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31616

--- Comment #2 from Didier Gautheron <didier.gautheron at biblibre.com> ---
(In reply to David Cook from comment #1)
> I'm not having this problem in prod on Ubuntu

Are rabbitmq and koha-worker.service running on the same host, i.e. connecting
using 127.1 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 12:56:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 11:56:47 +0000
Subject: [Koha-bugs] [Bug 32305] New: Backround worker doesn't check jobs
 receive from rabbitmq are in 'new' state.
Message-ID: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

            Bug ID: 32305
           Summary: Backround worker doesn't check jobs receive from
                    rabbitmq are in 'new' state.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

How to reproduce :

1) stop rabbitmq and koha-worker services.
2) start koha-worker , without rabbitmq it's polling the database.
3) start rabbitmq, koha-worker is not connecting to it.
4) submit a job. A new row is add to background_jobs table and the job is
enqueued in rabbitmq.
5) the job is processed by koha-worker from the database.
6) restart koha-worker, this time connection to rabbitmq succeeded 
7) koha-worker receive job message from rabbitmq and rerun it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:14:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:14:01 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-cWLrJc3ghF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30982                       |31969


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
[Bug 30982] Use the REST API for background job list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969
[Bug 31969] Options for cleanup_database.pl to remove finished jobs from the
background job queue
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:14:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:14:01 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-MTqHF0YKA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32304                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304
[Bug 32304] Subtest purge in BackgroundJobs.t fails when having older jobs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:14:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:14:01 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-J2za9s1tAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32304


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304
[Bug 32304] Subtest purge in BackgroundJobs.t fails when having older jobs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:23:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:23:52 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-4gxIJuxBrV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Any good reasons to not have used the filter_by_last_update methods for
filtering, which is the pattern used all around cleanup_database?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:32:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:32:05 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-y8NePar1W6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Since when are we sending a confirm flag to a method? Why isn't this simply
reusing the same pattern that exist for other flags?

381 if ($pMessages) {
382     print "Purging messages older than $pMessages days.\n" if $verbose;
383     my $messages = Koha::Patron::Messages->filter_by_last_update(
384         { timestamp_column_name => 'message_date', days => $pMessages } );
385     my $count = $messages->count;
386     $messages->delete if $confirm;
387     if ( $verbose ) {
388         say $confirm
389           ? sprintf( "Done with purging %d messages", $count )
390           : sprintf( "%d messages would have been removed", $count );
391     }
392 }

That's all what you needed. No additional methods, unit tests, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:33:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:33:27 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-hTT4T6MJIK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
31969 is all wrong, see bug 31969 comment 18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:46:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:46:47 +0000
Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's
 details page
In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26598-70-RJg4hLJle9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 13:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 12:46:53 +0000
Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's
 details page
In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26598-70-v6KfY4zMtN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142655|0                           |1
        is obsolete|                            |

--- Comment #14 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144110&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

+ resolve a git merge conflict

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
    => A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 14:45:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 13:45:57 +0000
Subject: [Koha-bugs] [Bug 32306] New: Hold modifications don't log correctly
Message-ID: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306

            Bug ID: 32306
           Summary: Hold modifications don't log correctly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Transaction logs
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

When one modifies holds from records holds page, these changes don't log into
action_logs table correctly. Instead holds data before modifications is stored
to action_logs.

To test:
1. Find hold to modify.
2. If possible, locate this hold from action_logs table:
SELECT * FROM action_logs WHERE module = "HOLDS" AND object = <reserve_id>; 
3. Modify hold, change its pickup library from A to B.
4. Save changes.
5. Take a look at action_logs table.
=> Modification is saved, but holds pickup library is still A.
6. Modify hold again, e.g add expiration date.
7. Save.
=> Expiration date is empty, but pickup library is now B.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 15:58:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 14:58:52 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-zlnKjzqJj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe
                   |ity.org                     |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 16:41:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 15:41:46 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-MrB7hOP1pg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

--- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144111&action=edit
Bug_32298 - Page section added to cataloguing search

Div added to "Records found in this catalog", page section class added to
"Records found in the reservoir". Level two heading changed and horizontal line
removed as it is now superfluous

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both
sections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 16:42:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 15:42:35 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-cQEl0EKIi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:24:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:24:51 +0000
Subject: [Koha-bugs] [Bug 32307] New: Chocolat image viewer broken in the
 staff interface
Message-ID: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

            Bug ID: 32307
           Summary: Chocolat image viewer broken in the staff interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I'm seeing errors in the console when viewing a bibliographic record in the
staff interface.

Looking at a record with more than one cover image available (e.g. Amazon and
Coce) I can click the cover and see the first image in the Chocolat viewer, but
there is an error in the console:

Uncaught (in promise) 
<img src="null">
chocolat_22.0600032.js:54:19

When I click the arrow to view the next cover, the cover doesn't load. It
appears to fail on the *last* image. If my record has three covers available
(e.g. Local, Amazon, and Coce) the first and second images are displayed
correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:30:09 +0000
Subject: [Koha-bugs] [Bug 32308] New: Update Chocolat image viewer CSS to
 conform to redesign color scheme
Message-ID: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

            Bug ID: 32308
           Summary: Update Chocolat image viewer CSS to conform to
                    redesign color scheme
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

The Chocolat image viewer uses SVG data-urls in CSS to control the appearance
of buttons (next, previous, close). These need to be updated to go along with
the new color scheme.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:30:09 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-93zuA0FKTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32308


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308
[Bug 32308] Update Chocolat image viewer CSS to conform to redesign color
scheme
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:46:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:46:49 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-poWLi4eQ8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:46:53 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-jTl2EDSBWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144112&action=edit
Bug 32308: Update Chocolat image viewer CSS to conform to redesign color scheme

This patch makes minor modifications to the Chocolat CSS so that the
buttons (next, previous, close) are styled with colors that conform to
the new interface color scheme.

Note: You may encounter Bug 32307 when testing.

To test, apply the patch and enable at least two cover image services in
the staff interface: Amazon, Local cover images, and/or Coce.

Locate a bibliographic record which has at least two cover images and
view the detail page. Click on the cover image to trigger the image
viewer overlay.

Confirm that the controls in this view are colored green, matching the
current color scheme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:54:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:54:33 +0000
Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
In-Reply-To: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1993-70-l1712cQirz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

Michaela Sieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:54:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:54:39 +0000
Subject: [Koha-bugs] [Bug 32309] New: Store saved_reports values as hash
Message-ID: <bug-32309-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32309

            Bug ID: 32309
           Summary: Store saved_reports values as hash
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: nick at bywatersolutions.com

When using the --store-results option in runreport.pl, the resulting stored
data would be more easily usable if stored as a hash.

So, say we have a patron named Andrew Fuerste-Henry and a report "select
surname, firstname from borrowers." Currently, that will show up in
saved_reports as:

[["surname","firstname"],["Fuerste-Henry","Andrew"]]

That makes it hard to do something like find all the surnames connected to a
given firstname.

The data would be easier to work with if we instead stored it as a hash, like:

["surname" : "Fuerste-Henry" , "firstname" : "Andrew"]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:56:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:56:01 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-jqWnodQerp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 17:56:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 16:56:06 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-P0w7RE6RfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144112|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144113&action=edit
Bug 32308: Update Chocolat image viewer CSS to conform to redesign color scheme

This patch makes minor modifications to the Chocolat CSS so that the
buttons (next, previous, close) are styled with colors that conform to
the new interface color scheme.

Note: You may encounter Bug 32307 when testing.

To test, apply the patch and enable at least two cover image services in
the staff interface: Amazon, Local cover images, and/or Coce.

Locate a bibliographic record which has at least two cover images and
view the detail page. Click on the cover image to trigger the image
viewer overlay.

Confirm that the controls in this view are colored green, matching the
current color scheme.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 18:55:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 17:55:19 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14367-70-GvrRW23brJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |hammat.wele at inlibro.com

--- Comment #68 from Hammat wele <hammat.wele at inlibro.com> ---
Applying: Bug 14367: Add MARC record history
.git/rebase-apply/patch:393: trailing whitespace.

warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M       C4/Biblio.pm
M       cataloguing/addbiblio.pl
M       koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
M       koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
M       koha-tmpl/intranet-tmpl/prog/js/cataloging.js
.git/rebase-apply/patch:393: trailing whitespace.

warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
Auto-merging cataloguing/addbiblio.pl
CONFLICT (content): Merge conflict in cataloguing/addbiblio.pl
Auto-merging C4/Biblio.pm
CONFLICT (content): Merge conflict in C4/Biblio.pm
error: Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 19:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 18:21:55 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-cCx4FoJGwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 19:22:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 18:22:00 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-2owB0JcadM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144095|0                           |1
        is obsolete|                            |

--- Comment #3 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144114&action=edit
Bug 31233: Amend 'fine grace period' as it's also used for suspensions

The grace period setting in circulation rules is not only used
for fines, but also for suspensions. So the label 'Fine grace period'
is a little misleading.

This patch updates it to "Fine/suspension grace period".

To test:
* Go to Administration > Circulation rules
* Verify the description is "Fine grace period" in the big table
* Apply patch
* Verify the description now changed to "Fine/suspension grace period"

https://bugs.koha-community.org/show_bug.cgi?id=32261
Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 19:37:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 18:37:23 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-WzhUScjzzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Hammat!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:08:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:08:38 +0000
Subject: [Koha-bugs] [Bug 32310] New: Correct CSS in the staff interface
 which still uses old color scheme
Message-ID: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

            Bug ID: 32310
           Summary: Correct CSS in the staff interface which still uses
                    old color scheme
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

Using https://www.css-color-extractor.com I was able to search our CSS for
instances of colors which should be updated to conform to the new color scheme
in the staff interface.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:08:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:08:38 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-0fn7aOMrWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32310


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310
[Bug 32310] Correct CSS in the staff interface which still uses old color
scheme
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:14:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:14:10 +0000
Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is
 alphabetical
In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13976-70-QBSkP31eay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141068|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144115&action=edit
Bug 13976: Sort popularity numerically in Zebra

To test:
1 - Create a new template at Tools->Marc modification template
2 - Add action: Copy 999$c to 942$0
3 - Create a report:
    SELECT biblionuber FROM biblios
4 - Run report, show all, do a batch modification to all records using template
above
5 - Search for 'a' (make sure you are using Zebra)
6 - Sort by popularity
7 - Note records are sorted wrong
8 - Apply patch
9 - Restart all
10 - Reload search results
11 - Success! Sorted correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:14:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:14:42 +0000
Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is
 alphabetical
In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13976-70-fTFxhPZEfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31756
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:14:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:14:42 +0000
Subject: [Koha-bugs] [Bug 31756] Biblionumber not numerically sorting
 natively when using Zebra
In-Reply-To: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31756-70-UtGul27oh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13976

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:14:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:14:57 +0000
Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is
 alphabetical
In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13976-70-eocVjDxlLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 20:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 19:29:50 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-VwRN1ZpSiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:02:26 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-seCsLZUUNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:02:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:02:30 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-8T6xKLG92K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

--- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Created attachment 144116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144116&action=edit
Bug 17350: Purge old saved reports via cleanup_database

To test:
apply patch
1 - have or create a report
2 - run your report via the command line with --store-results. Do this twice.
3 - update the saved_reports table to set date_run for one of your two saved
results set to a datetime more than 5 days ago
4 - perl misc/cronjobs/cleanup_database.pl --reports 5 --verbose --confirm
5 - Koha tells you its deleting saved reports data from more than 5 days ago
6 - confirm in the database and the staff interface that it's done so

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:03:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:03:12 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports with cleanup_database
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-mJC3IMJejl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |andrewfh at dubcolib.org
            Summary|Add option to delete data   |Add option to delete data
                   |stored in saved_reports     |stored in saved_reports
                   |                            |with cleanup_database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:05:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:05:25 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports with cleanup_database
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-Ep0rwbQlsP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:05:58 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-NLsqRRbrPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:07:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:07:40 +0000
Subject: [Koha-bugs] [Bug 32311] New: Add option to delete saved reports
 results from staff interface
Message-ID: <bug-32311-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32311

            Bug ID: 32311
           Summary: Add option to delete saved reports results from staff
                    interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org

Once a set of report results has been saved, there's no way to delete those
saved values. Bug 17350 adds a way to delete them via cleanup_database, but it
would also be good to have a way to delete them from the staff interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:07:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:07:40 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports with cleanup_database
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-U6910Q5hSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32311

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:08:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:08:52 +0000
Subject: [Koha-bugs] [Bug 17350] Add option to delete data stored in
 saved_reports with cleanup_database
In-Reply-To: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17350-70-hjkaaE3Sjh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

--- Comment #5 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I *think* I managed to write a patch to add this functionality to
cleanup_databse. I've filed bug 32311 to add a way to delete these from the
staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:09:14 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-1rba5ZWURq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am also stuck on the 'spinning thing' not going away with bug 32308 applied.
When I click the views and switching between covers works?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:10:33 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-rNM6I4nHFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:10:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:10:38 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-7Yqkyo1Oav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144113|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144117&action=edit
Bug 32308: Update Chocolat image viewer CSS to conform to redesign color scheme

This patch makes minor modifications to the Chocolat CSS so that the
buttons (next, previous, close) are styled with colors that conform to
the new interface color scheme.

Note: You may encounter Bug 32307 when testing.

To test, apply the patch and enable at least two cover image services in
the staff interface: Amazon, Local cover images, and/or Coce.

Locate a bibliographic record which has at least two cover images and
view the detail page. Click on the cover image to trigger the image
viewer overlay.

Confirm that the controls in this view are colored green, matching the
current color scheme.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:13:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:13:01 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-GPB47jsHiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
When I search for 'e' I see even 3 datatable controls on the first entry.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:15:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:15:50 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-iLoGnMLdqD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:15:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:15:54 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-fO0mtLu9qN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144111|0                           |1
        is obsolete|                            |

--- Comment #2 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144118&action=edit
Bug_32298 - Page section added to cataloguing search

Div added to "Records found in this catalog", page section class added to
"Records found in the reservoir". Level two heading changed and horizontal line
removed as it is now superfluous

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both
sections

Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:21:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:21:21 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-C4hZ44uSW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Show correct                |Show correct
                   |defaultSortField in Staff   |defaultSortField in staff
                   |Client Advanced Search      |client advanced search

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed on master. It works nicely in simple search, but not in advanced
search:

* Set defaultSortField: title
* Set defaultSortOrder: A-Z
* Do a catalog search for... anything (I used perl)
* Sorting is alphabetic and in the sort pull down, the title has a little
checkmark in front of the entry (could stand out a little more)


* Set defaultSortField: author
* Set defaultSortOrder: ascending
* Searched for 'perl' again
* No author is on top, rest seems to sort ok, C D G...
* Checkmark on search shows

But on advanced search, the search pull down seems stuck to Relevance no matter
what.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:22:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:22:14 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-KShaQQqmw3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:28:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:28:37 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-P0aRuGzbcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:28:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:28:42 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-UZ2Yqsw0vH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144118|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144119&action=edit
Bug 32298: Page section added to cataloguing search

Div added to "Records found in this catalog", page section class added to
"Records found in the reservoir". Level two heading changed and horizontal line
removed as it is now superfluous

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both
sections

Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

Signed-off-by: Katrin <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:29:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:29:27 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-j5Ty0xZosK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Matt, 

congrats on your first patch! :)

Some small stuff:

* The commit message always needs to start with: Bug XXXX: - this helps with
our tools and also gives some consistency in the commit message. You can find
information on how to write good commit messages in the wiki:
https://wiki.koha-community.org/wiki/Commit_messages. If you run the qa test
tools on your patches, they will also alert you of issues like this. on ktd in
the shell: qa -v 2

* Not a problem, but maybe you'd want to change the first bit to use a
formatted name: mattblenkinsop <matt.blenkinsop at ptfs-europe.com>. This should
come from GIT_USER_NAME= in the .env of ktd. I have Katrin Fischer there and it
works with the blank and without quotes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 21:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 20:30:53 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-Ub5PPTwDlw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:30:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:30:11 +0000
Subject: [Koha-bugs] [Bug 14462] aqorders.sort*_authcat unused?
In-Reply-To: <bug-14462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14462-70-Z7lCwi5Ed6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14462

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
These fields still seem to be unused. I suggest we change that and set them to
the authorised value category linked to the sort* fields.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:39:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:39:36 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-1iOZbKgSLW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:39:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:39:43 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-9zqs6d0Ms0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143057|0                           |1
        is obsolete|                            |

--- Comment #51 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144120&action=edit
Bug 30358: Strip leading/trailing whitespace characters from input fields when
cataloguing

This enhancement adds a system preference StripWhitespaceChars which,
when enabled, will strip leading and trailing whitespace characters from
all fields when cataloguing both bibliographic records and authority
records. Whitespace characters that will be stripped are:
- spaces
- newlines
- carriage returns
- tabs

To test:
1. Apply patch and install database updates
2. Go to Administration, system preferences, find the new
StripWhitespaceChars preference. It should be "Don't strip" by default.
Change it to "Strip".
3. Search for a biblio record and edit it. Put some leading or trailing
whitespace characters in input fields and textarea fields and save.
4. Confirm these characters are removed when you save the record.
5. Repeat steps 3 and 4 for authority records.
6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t

Sponsored-by: Educational Services Australia SCIS

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:39:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:39:51 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-bymDSWZ7PX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143058|0                           |1
        is obsolete|                            |

--- Comment #52 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144121&action=edit
Bug 30358: (follow-up) Also strip inner newlines

This patch amends the StripWhitespaceChars system preference to also
strip inner newlines (line breaks and carriage returns) when enabled.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:39:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:39:58 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-3lJNiXKMzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143059|0                           |1
        is obsolete|                            |

--- Comment #53 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144122&action=edit
Bug 30358: (follow-up) Inner newlines should be replaced with a space

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:06 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-GWmcaDw2vR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143060|0                           |1
        is obsolete|                            |

--- Comment #54 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144123&action=edit
Bug 30358: (follow-up) Fixing tests and including for inner newlines

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:13 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-aA9iGu2LwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143061|0                           |1
        is obsolete|                            |

--- Comment #55 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144124&action=edit
Bug 30358: (follow-up) Clarify syspref wording about fields affected

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:21 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-4z8awAPWuf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143062|0                           |1
        is obsolete|                            |

--- Comment #56 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144125&action=edit
Bug 30358: (follow-up) Consider field has multiple subfields of same key

To test:

1) Click the clone subfield button to make multiple subfields with the
same key, i.e. 500$a$a$a
2) Save the record and confirm that the fields contain the correct data
after whitespaces are stripped.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:29 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-patHnaYJEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143063|0                           |1
        is obsolete|                            |

--- Comment #57 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144126&action=edit
Bug 30358: (follow-up) Put multiple subfields fix on auth side

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:36 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-XWiwj6aBZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143064|0                           |1
        is obsolete|                            |

--- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144127&action=edit
Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests

To test:

Confirm test plan above still works as expected and tests pass in
t/Koha_MetadataRecord.t

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:43 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-adZ6ASYHek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143065|0                           |1
        is obsolete|                            |

--- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144128&action=edit
Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:51 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-cDq1YZqDKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #60 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144129&action=edit
Bug 30358 (follow-up): Do not strip whitespace from control fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 22:40:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 21:40:59 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-elJctA9u5k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

--- Comment #61 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144130&action=edit
Bug 30358 (follow-up) Simplify regex

The regex does the following:
1. Replace newlines and carriage returns with a space
2. Replace leading and trailing whitespace with nothing (strip)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:00:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:00:34 +0000
Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant
 recall when checking if item can be a waiting recall
In-Reply-To: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32129-70-qTev9knezN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hammat.wele at inlibro.com

--- Comment #2 from Hammat wele <hammat.wele at inlibro.com> ---
I am unable to reproduce the original bug.

Steps performed:
1) Go to Administration -> System preferences and enable UseRecalls
2) Go to Administration -> Circulation and fines rules and set a general
All/All rule and a Category A/Itemtype A rule. All values can be set
however you like except for these recalls rules:

All/All rule:
Recalls allowed: 0
Recalls per record: 0
On shelf recalls allowed: if any unavailable

Category A/Itemtype A rule:
Recalls allowed: 5
Recalls per record: 5
On shelf recalls allowed: if any unavailable

3) Find an item of Itemtype A. Check it out to Patron A (any category).
4) Log into the OPAC as Patron B (of Category A). Find the item and
place a recall on the item.
5) Back in the staff interface, check in the item => there is already a pop-up
box showed to confirm the recall

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:04:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:04:58 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-HtVGpUDo1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:05:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:05:06 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-M0WqvjXVzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139642|0                           |1
        is obsolete|                            |

--- Comment #21 from David Nind <david at davidnind.com> ---
Created attachment 144131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144131&action=edit
Bug 31391: RecallsInterface system preference

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:05:15 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-Tw2hX0xavp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139643|0                           |1
        is obsolete|                            |

--- Comment #22 from David Nind <david at davidnind.com> ---
Created attachment 144132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144132&action=edit
Bug 31391: Recalled authorised value for hold cancellation

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:05:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:05:22 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-SDNuaLCLes@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139644|0                           |1
        is obsolete|                            |

--- Comment #23 from David Nind <david at davidnind.com> ---
Created attachment 144133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144133&action=edit
Bug 31391: Implement RecallsInterface on OPAC

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:05:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:05:29 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-uR8O92Gdk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144104|0                           |1
        is obsolete|                            |

--- Comment #24 from David Nind <david at davidnind.com> ---
Created attachment 144134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144134&action=edit
Bug 31391: Request recalls and convert reserves on staff interface

This enhancement adds the ability to place recalls via the staff
interface by introducing a system preference, RecallsInterface, to
configure where recalls can be placed. Recalls can either be placed via
the OPAC, or the staff interface, or both. This is set to OPAC by
default to be consistent with current behaviour.

This enhancement also adds the ability to convert existing reserves to
recalls easily via the staff interface. The reserve will be cancelled
and a recall placed using the reserve's information.

To test:
1) Update database and restart services
2) Enable UseRecalls and set the relevant recalls circulation rules
3) View the new RecallsInterface system preference. Confirm it is set to
OPAC only by default
4) Check out Item A to Patron B.
5) Log into the OPAC as Patron A. Confirm you can place, view and cancel
recalls as normal.
6) In the staff interface, set RecallsInterface to Staff interface only.
7) In the OPAC, confirm you can still view and cancel recalls, but can
no longer place recalls.
8) In the staff interface, search for Item A and go to the Reserves tab.
Place a reserve for Patron C.
9) Under the Priority column, select the dropdown and choose the recall
option next to your reserve.
10) Click Update holds. Confirm when the page refreshes that your
reserve has disappeared.
11) Go to the recalls tab. Confirm your reserve has been converted to a
recall, and details like the patron, expiration, and pickup location have
carried across to the recall.
12) On this recalls page, use the patron search to find Patron D. Test
placing a record-level recall by keeping the 'recall next available
item' checkbox.
13) When the page refreshes, confirm the recall was successfully placed
with the correct details stored.
14) Repeat steps 12 and 13 with Patron E, this time place an item-level
recall by choosing an item in the 'place a recall on a specific item'
table. When selecting one of these items, the 'recall next available
item' checkbox should de-select.
15) Set RecallsInterface back to OPAC only. Go back to the record and
view the Recalls tab.
16) Confirm you cannot search for a patron to place a recall, but can
still view and cancel recalls. Confirm you also cannot convert reserves
to recalls.
17) Set RecallsInterface to both staff interface and OPAC. Confirm you
can place recalls on both interfaces.
18) On the staff interface, test placing recalls that your circulation
rules do not allow. For example, if 'recalls per record' is 1, ensure
you're blocked from placing a second recall on a record for a patron.
19) Place a reserve for one of the patron's that already has a recall.
Once complete, try to convert this reserve into a recall. Confirm you
are blocked and shown a message that the hold cannot be converted to a
recall.
20) Ensure tests pass t/db_dependent/Holds.t

Sponsored-by: Auckland University of Technology

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:05:35 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-R0pGDbBwog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144105|0                           |1
        is obsolete|                            |

--- Comment #25 from David Nind <david at davidnind.com> ---
Created attachment 144135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144135&action=edit
Bug 31391: (follow-up) Fix cancel recalls using checkbox

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:05:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:05:41 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-gHL7tlUcNZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #26 from David Nind <david at davidnind.com> ---
Created attachment 144136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144136&action=edit
Bug 31391: (follow-up) Fix number of tests and terminology

Fixed two items:
- Number of tests: changed to 77 (from 76), tests now pass
- Terminology: changed message when attempting to place recalls
from the staff interface when RecallsInterface in set to the OPAC
only (staff client should be staff interface)

Signed-off-by: David <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:19:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:19:43 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-llYteRwxgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:19:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:19:48 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-tAq6hv2Ni8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144137&action=edit
Bug 32292: Add column descriptions to subscriptions table / complete items
table

* Adds proper labels to the database columns for suggestions
* Adds missing item columns:
  * coded_location_qualifier
  * deleted_on
  * exclude_form_local_holds_priority
* Fixes spelling of item type, Uniform resource identifier

To test:
* Go to reports > Guided reports
* Select acquisition or another module using the items
* Make sure all entries for the tables items up with nice descriptions
* Changes to subscriptions: verify reading the patch, these don't seem to show
  up yet in guided reports.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:19:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:19:53 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-28aseafhHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144138&action=edit
Bug 32292: Add column descriptions to aqorders table

This adds nice descriptions to the aqorders database columns.

To test:
* Go to Guided reports
* Start a new report for acquisitions module
* Verify that all aqorders columns show with nice descriptions
  None should be missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:19:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:19:58 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-TZTIjlmPSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144139&action=edit
Bug 32292: Add column descriptions to biblio table

This adds nice descriptions to the aqorders database columns.

To test:
* Go to Guided reports
* Start a new report for acquisitions module
* Verify that all aqorders columns show with nice descriptions
      None should be missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:20:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:20:04 +0000
Subject: [Koha-bugs] [Bug 32292] suggestions in Columns.pm are not
 translated to real labels
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-XdUe98Wefs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144140&action=edit
Bug 32291: Add missing column descriptions to borrowers table

Adds missing column descriptions for new features etc. to the
existing entry for borrowres columns descriptions.

To test:
* Go to reports > Guided reports
* Select patrons module
* Make sure all entries for the tables items and suggestions show
  up with nice descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:20:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:20:43 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-p25hZCaFDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #27 from David Nind <david at davidnind.com> ---
(In reply to Aleisha Amohia from comment #20)
> (In reply to David Nind from comment #17)
> > This is still not working for me and doesn't appear to be fixed.
> > 
> > If it helps, there is an entry in
> > /var/log/koha/kohadev/plack-intranet-error.log:
> > [2022/11/04 06:36:44] [WARN] Use of uninitialized value $biblionumber in
> > concatenation (.) or string at /kohadevbox/koha/recalls/request.pl     line
> > 49.
> > 
> > Everything else continues to work as per the test plan.
> 
> Sorry you were right - amended in most recent patch

Thanks Aleisha - now signed off!

I added a follow-up to change the number of tests so that tests pass, and
change staff client to staff interface.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:22:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:22:20 +0000
Subject: [Koha-bugs] [Bug 32292] Update and add database column descriptions
 used in guided reports
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-NxS24zPCaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This completes and adds
      release notes|                            |column descriptions that
                   |                            |show up when creating a new
                   |                            |guided report for following
                   |                            |tables:
                   |                            |* items
                   |                            |* borrowers
                   |                            |* biblio
                   |                            |* aqorders
                   |                            |*
                   |                            |suggestions
            Summary|suggestions in Columns.pm   |Update and add database
                   |are not translated to real  |column descriptions used in
                   |labels                      |guided reports

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Fell down the rabbit hole a little bit here... will file some bugs for other
tables still missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:25:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:25:26 +0000
Subject: [Koha-bugs] [Bug 31391] Staff-side recalls
In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31391-70-JxlOzrmESs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

--- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to David Nind from comment #27)

> Thanks Aleisha - now signed off!
> 
> I added a follow-up to change the number of tests so that tests pass, and
> change staff client to staff interface.
> 
> David

Good catch! Thank you for your awesome testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:26:18 +0000
Subject: [Koha-bugs] [Bug 32312] New: Complete database column descriptions
 for serials module in guided reports
Message-ID: <bug-32312-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312

            Bug ID: 32312
           Summary: Complete database column descriptions for serials
                    module in guided reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
        Depends on: 29695

There are entries missing for the statistics table.

How to test:
* Add a new guided report
* Select module serials
* Verify that statistics is missing some descriptions, only showing the
database value


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
[Bug 29695] Centralize columns' descriptions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:26:18 +0000
Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29695-70-QtRe6VJO59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32312


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312
[Bug 32312] Complete database column descriptions for serials module in guided
reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:27:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:27:16 +0000
Subject: [Koha-bugs] [Bug 31616] koha_worker isn't using RabbitMQ on startup
 if it's a local server.
In-Reply-To: <bug-31616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31616-70-klFiqj5DeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31616

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Didier Gautheron from comment #2)
> (In reply to David Cook from comment #1)
> > I'm not having this problem in prod on Ubuntu
> 
> Are rabbitmq and koha-worker.service running on the same host, i.e.
> connecting using 127.1 ?

There's no koha-worker.service when you're using Debian packages.

But yes RabbitMQ and the background_jobs_worker.pl processes are all running on
the same host and communicating using "localhost" as the hostname for the
RabbitMQ.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:27:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:27:46 +0000
Subject: [Koha-bugs] [Bug 32313] New: Complete database column descriptions
 for cataloguing module in guided reports
Message-ID: <bug-32313-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32313

            Bug ID: 32313
           Summary: Complete database column descriptions for cataloguing
                    module in guided reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
        Depends on: 32292, 29695

There are entries missing for the biblioitems table.
Bug 32292 takes care of missing entries in biblio and items.

How to test:
* Add a new guided report
* Select module catalog
* Verify that statistics is missing some descriptions, only showing the
database value


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
[Bug 29695] Centralize columns' descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292
[Bug 32292] Update and add database column descriptions used in guided reports
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:27:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:27:46 +0000
Subject: [Koha-bugs] [Bug 32292] Update and add database column descriptions
 used in guided reports
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-r2m9gAkW14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32313


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32313
[Bug 32313] Complete database column descriptions for cataloguing module in
guided reports
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:27:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:27:46 +0000
Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29695-70-5CaeDoptPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32313


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32313
[Bug 32313] Complete database column descriptions for cataloguing module in
guided reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:32:11 +0000
Subject: [Koha-bugs] [Bug 32292] Update and add database column descriptions
 used in guided reports
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-MJhMmFAzsz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 144141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144141&action=edit
Bug 32292: Fix POD

POD had a typo in suggestions and was missing the new aqorders.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:34:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:34:14 +0000
Subject: [Koha-bugs] [Bug 29986] Descriptions of system internal debit types
 and credit types should be editable
In-Reply-To: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29986-70-pRWWBD7yHo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29986

Sara Brown <sbrown at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbrown at bywatersolutions.com

--- Comment #3 from Sara Brown <sbrown at bywatersolutions.com> ---
It would be helpful in general for libraries to be able to edit these
descriptions, not just for translating. For instance, if a library applies a
refund to a manually invoiced charged that is not a fine, the description for
REFUND (A refund applied to a patrons fine) won't be accurate. It can then be
confusing for staff on reports.

(If this should be its own bug, I can file separately!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:35:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:35:22 +0000
Subject: [Koha-bugs] [Bug 32314] New: Complete database column descriptions
 for accounts module in guided reports
Message-ID: <bug-32314-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32314

            Bug ID: 32314
           Summary: Complete database column descriptions for accounts
                    module in guided reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
        Depends on: 32292, 29695

There are entries missing for the accountlines table.
Bug 32292 takes care of missing entries in borrowers.

How to test:
* Add a new guided report
* Select module Accounts
* Verify that statistics is missing some descriptions, only showing the
database value


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
[Bug 29695] Centralize columns' descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292
[Bug 32292] Update and add database column descriptions used in guided reports
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:35:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:35:22 +0000
Subject: [Koha-bugs] [Bug 32292] Update and add database column descriptions
 used in guided reports
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-x1QQ587Ord@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32314
[Bug 32314] Complete database column descriptions for accounts module in guided
reports
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:35:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:35:22 +0000
Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29695-70-cwxqoj8ixx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32314
[Bug 32314] Complete database column descriptions for accounts module in guided
reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:36:41 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-PdlcpSEd4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:37:10 +0000
Subject: [Koha-bugs] [Bug 32315] New: Complete database column descriptions
 for serials module in guided reports
Message-ID: <bug-32315-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32315

            Bug ID: 32315
           Summary: Complete database column descriptions for serials
                    module in guided reports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
        Depends on: 32292, 29695

There are entries missing for the serial, serialitems, subscription,
subscriptionhistory, subscriptionroutinglist and aqbooksellers tables.

Bug 32292 takes care of biblio and biblioitems.

How to test:
* Add a new guided report
* Select module serials
* Verify that statistics is missing some descriptions, only showing the
database value


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695
[Bug 29695] Centralize columns' descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292
[Bug 32292] Update and add database column descriptions used in guided reports
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:37:10 +0000
Subject: [Koha-bugs] [Bug 32292] Update and add database column descriptions
 used in guided reports
In-Reply-To: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32292-70-FfGztb5HvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32315


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32315
[Bug 32315] Complete database column descriptions for serials module in guided
reports
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:37:10 +0000
Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions
In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29695-70-bF5OQUBa4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32315


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32315
[Bug 32315] Complete database column descriptions for serials module in guided
reports
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:39:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:39:49 +0000
Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for
 circulation module in guided reports
In-Reply-To: <bug-32312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32312-70-6q2QoQfL3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Complete database column    |Complete database column
                   |descriptions for serials    |descriptions for
                   |module in guided reports    |circulation module in
                   |                            |guided reports

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are entries missing for the statistics table.

How to test:
* Add a new guided report
* Select module circulation
* Verify that statistics is missing some descriptions, only showing the
  database value

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:43:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:43:41 +0000
Subject: [Koha-bugs] [Bug 29986] Descriptions of system internal debit types
 and credit types should be editable
In-Reply-To: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29986-70-WiXzRjp7Kx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29986

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Sara Brown from comment #3)
> It would be helpful in general for libraries to be able to edit these
> descriptions, not just for translating. For instance, if a library applies a
> refund to a manually invoiced charged that is not a fine, the description
> for REFUND (A refund applied to a patrons fine) won't be accurate. It can
> then be confusing for staff on reports.
> 
> (If this should be its own bug, I can file separately!)

I think i would not have the effect you expect: the description from the
database are basically only used for reporting. What you see in the templates
is built from the codes, so they can be translated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:44:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:44:31 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-x11iqF0uMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
(In reply to Jonathan Druart from comment #1)
> What's your opinion on this?
> 
> I don't mind reintroducing the "feature", but there is something
> inconsistent: We are displaying "Last returned by" if StoreLastBorrower is
> set, but then display the last 3 patrons who borrowed the items whatever is
> the value of StoreLastBorrower.

Yeah, those are two parallel but distinct systems with some confusing labels.
Both are meaningful and needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 21 23:45:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 22:45:12 +0000
Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display
 on moredetail.pl is broken
In-Reply-To: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32272-70-DK5EX6SRFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #5 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Patch doesn't apply:
Applying: Bug 32272: Restore last and previous borrowers on moredetail
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 32272: Restore last and previous borrowers on
moredetail
[33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-32272-Restore-last-and-previous-borrowers-on-m-ilGOtR.patch
Apply? [(y)es, (n)o, (i)nteractive]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 00:19:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Nov 2022 23:19:35 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-LfAMDAblVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 01:17:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 00:17:16 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-nyIraqMHMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |wainuiwitikapark at catalyst.n
                   |ity.org                     |et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 07:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 06:52:57 +0000
Subject: [Koha-bugs] [Bug 28179] Use a lightbox gallery to display the
 images - detail page, staff interface
In-Reply-To: <bug-28179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28179-70-qt98Oi1RUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32307


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307
[Bug 32307] Chocolat image viewer broken in the staff interface when Coce is
enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 07:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 06:52:57 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-nqZ4NRtdRI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Chocolat image viewer       |Chocolat image viewer
                   |broken in the staff         |broken in the staff
                   |interface                   |interface when Coce is
                   |                            |enabled
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |28179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179
[Bug 28179] Use a lightbox gallery to display the images - detail page, staff
interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 08:15:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 07:15:56 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-DMPxe9VPJK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 08:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 07:16:00 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-5s03VEn6X8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144142&action=edit
Bug 32307: Fix gallery when Coce is enabled

Bug 28179 added the gallery in the staff interface, and bug 28180 in the
OPAC.

OPAC and staff have different code, because the cover image providers
are different.
On bug 28180 we noticed that the OPAC needed additional code to handle
OpenLibrary, Google Jacket and Coce, to differ the creation of the
gallery to prevent Chocolat to be instantiated before the links (img src)
are effectively in the DOM.

To acchieve that we introduced a wait_for_images function, and added a
"done" flag to the 3 "JS modules".

However we haven't ported this code for the staff interface, which is
also using Coce.

Note that there was a bug at the OPAC as well for COCE, the ajax jQuery
function is async, and so 'done' was set even if the call was not
finished.

Test plan:
0. Do not apply this patch
1. Enable LocalCoverImages and IntranetCoce
2. Pick a bibliographic record with an image returned from Coce
3. Add a local cover image
4. Go to the detail page
5. Open the gallery
=> Notice that you can notice a JS error and a loading icon on the
second image. This behaviour is not always broken, it depends on the
speed of the Coce server. If you don't see the problem reload the page.
6. Apply the patch and repeat
=> Notice that the cover slider block is longer to display the icon, but
that the error is gone.
7. Confirm that there is no regression at the OPAC

We could improve the situation here, and we could display the images
in the slider, especially if the first image is a local image. But
that's for another bug...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 08:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 07:46:53 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-U5TAl0e3mm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Any future plans to now use this new subroutine from other places?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 08:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 07:52:46 +0000
Subject: [Koha-bugs] [Bug 31859] Error 500 when enabling advanced cataloging
 editor
In-Reply-To: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31859-70-XK8n4mqSrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31859

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How did you install? Using the Debian packages?

Looks like several things are going wrong.

This one "The method Koha::KeyboardShortcuts->shortcut_keys is not covered by
tests" may be fixed if you restart the services.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:12:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:12:05 +0000
Subject: [Koha-bugs] [Bug 32262] smart-rules: Some rules can be created but
 are not visible on interface
In-Reply-To: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32262-70-RN7hxiJsma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hum, CirculationRules.Search() never returns an undefined value and, more
generally, methods from the TT plugins return an empty string when we actually
return undef...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:14:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:14:22 +0000
Subject: [Koha-bugs] [Bug 32262] smart-rules: Some rules can be created but
 are not visible on interface
In-Reply-To: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32262-70-6LYmLzTr89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Ok, perl returns an empty string for undef in a string context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:32:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:32:29 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-GSZa8WqUlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:40:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:40:12 +0000
Subject: [Koha-bugs] [Bug 32262] smart-rules: Some rules can be created but
 are not visible on interface
In-Reply-To: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32262-70-iQQ0lmOzyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144143&action=edit
Bug 32262: Handle non-existing circ rules

Some rules are not displayed on the UI, even if they exist in the DB,
that's confusing.
That's because we are implicitely returning 'undef' from
CirculationRules.Search, and perl returns an empty string for undef in
a string context. Which means "rules.defined" is always true.

This patch is ugly and really hope somebody else will come with a better
solution.

Test plan:
I don't know, search for regressions on the circ rule UI?... :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:40:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:40:45 +0000
Subject: [Koha-bugs] [Bug 32262] smart-rules: Some rules can be created but
 are not visible on interface
In-Reply-To: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32262-70-JM0aEHORD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:41:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:41:42 +0000
Subject: [Koha-bugs] [Bug 32262] smart-rules: Some rules can be created but
 are not visible on interface
In-Reply-To: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32262-70-FMLGgXzihl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Note that want_rule flag could have unexpected behaviours

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:42:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:42:52 +0000
Subject: [Koha-bugs] [Bug 32316] New: Send invitations to share a list
 immediately
Message-ID: <bug-32316-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32316

            Bug ID: 32316
           Summary: Send invitations to share a list immediately
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Invitations to share a list (SHARE_INVITE) are sent via the message_queue, so
there can be a noticeable delay. It would be nice if we could use the same
trick here as for password reset and self registration verification mails, that
are sent through message_queue, but processed/sent immediately.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 09:51:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 08:51:58 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-Ypc4GN85tc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
ping Martin?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 10:20:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 09:20:34 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_6473=5D_Test_bug_for_Git-bz_?=
 =?utf-8?b?4pyUIOKdpCDimIU=?=
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-qsgDSlHLUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #261 from Slava Shishkin <slavashishkin at gmail.com> ---
Created attachment 144144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144144&action=edit
Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 10:24:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 09:24:47 +0000
Subject: [Koha-bugs] [Bug 32266] Large amount of late orders slows the
 service
In-Reply-To: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32266-70-Br6NDbHaMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 144145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144145&action=edit
Bug 32266: Add new syspref DefaultLateOrderFilterDaysAgo

Some libraries might have large amounts of late orders that
slow down opening the lateorders.pl. E.g. patch of 2000
orders takes about 40 seconds to open, larger patches lead
to a proxy error.

This patch adds new syspref DefaultLateOrderFilterDaysAgo.
With this libraries can control how many days old late orders
should be for them to show in late orders listing.

To test:
1. Open browsers console (F12) and from there Network tab.
2. Navigate to Acquisitions -> Late Orders.
=> Take a note from browsers console how long it takes to open late orders
listing.
3. Apply this patch, update you database and restart your services if needed.
4. Set some value to syspref DefaultLateOrderFilterDaysAgo (999 is max).
5. Load Late orders page again.
=> Loading page should now be significantly faster.
=> Only orders which

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 10:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 09:33:35 +0000
Subject: [Koha-bugs] [Bug 29198] Inconsistencies in OPAC results display vs
 staff results display
In-Reply-To: <bug-29198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29198-70-fS832KyY2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29198

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 11:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 10:01:12 +0000
Subject: [Koha-bugs] [Bug 32317] New: Online joining form
Message-ID: <bug-32317-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32317

            Bug ID: 32317
           Summary: Online joining form
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: paul.sewell at cumbria.gov.uk
        QA Contact: testopia at bugs.koha-community.org

Hi,

Please can someone look into a software enchancement that allows new patrons to
upload documents such as ID photos when joining the library service via the
OPAC. 

This would allow us to streamline our online joining process.

Kind regards,
Paul

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 11:04:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 10:04:44 +0000
Subject: [Koha-bugs] [Bug 32318] New: Add a delete link to the edit split
 button on the items table in staff detail page
Message-ID: <bug-32318-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32318

            Bug ID: 32318
           Summary: Add a delete link to the edit split button on the
                    items table in staff detail page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

On the staff detail page we now have had an "Edit" button for each item for a
while. If you allow local covers, it turns into a split button to also allow
for uploading item covers. 

It would be nice to also have the option to delete the item from this table as
another option in the split button with edit still being the primary action.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 11:06:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 10:06:33 +0000
Subject: [Koha-bugs] [Bug 32317] Self registration: Allow users to upload
 files
In-Reply-To: <bug-32317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32317-70-AdhGwm5ZmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32317

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Online joining form         |Self registration: Allow
                   |                            |users to upload files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 11:28:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 10:28:57 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-4oFASxuLDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144103|0                           |1
        is obsolete|                            |

--- Comment #206 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 144146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144146&action=edit
Bug 8367: (follow-up) Remove unnecessary code and atomic update

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 11:35:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 10:35:13 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-yhZsRcKiPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #207 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Tested this again and everything seems to work as described. However
circulation rule with "Holds pickup period (day)" column filled cannot be
deleted. There is a similar problem with column "Decreased loan period for high
holds" (bug 30694) where rule isn't included to deletion in smart-rules.pl. Not
sure what is a proper status for this, is it "Patch doesn't apply" or "Failed
QA"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 11:38:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 10:38:34 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-TKi1iPhg3J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #208 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Emmi Takkinen from comment #207)
> Tested this again and everything seems to work as described. However
> circulation rule with "Holds pickup period (day)" column filled cannot be
> deleted. There is a similar problem with column "Decreased loan period for
> high holds" (bug 30694) where rule isn't included to deletion in
> smart-rules.pl. Not sure what is a proper status for this, is it "Patch
> doesn't apply" or "Failed QA"?

Hi Emmi, probably only needs a small follow-up, but Failed QA would be the
correct one for now. Thx for linking the other bug already, that's a good clue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:34:35 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-Z69quqMBox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:34:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:34:39 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-EiYw8jV3WX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144147&action=edit
Bug 32310: Correct CSS in the staff interface which still uses old color scheme

This patch updates staff interface CSS so that it better conforms to the
color scheme of the updated staff interface.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Tools -> Calendar. Corrected are the borders around the calendar
  and around the "Add new holiday" panel which appears when you click a
  date on the calendar.
- Go to Patrons and perform a search which will return multiple results.
  - Check the checkbox for some patrons. The color of the "Patrons
    selected" box have been updated.
  - Incorrect padding values have also been removed from the adjacent
    patron list and merge buttons.
- Locate a multi-paged DataTable, e.g. Administration -> Authorized
  values. The style of the "Next" and "Previous" buttons have been
  updated.
- View a patron record and choose More -> Set permissions from the
  toolbar. In the table of permissions, when you hover your mouse over
  one of the headings ("Check out and check in items," "Edit
  authorities," etc.) the color should be correct.
- I don't think this is ever visible in the staff interface, but the
  template has markup in it to display a "Log in" link in the header
  menu if the user isn't logged in. I've removed some redundant CSS
  corresponding to this link and corrected some markup just in case
  there is a situation in which is appears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:49:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:49:30 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-YSVXcqvw14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144148&action=edit
Bug 32270: Add page section to label layouts

Test plan:
1) Navigate to `Cataloguing > Label creator > Manage label layouts`
2) Observe the missing page section surrounding the table
3) Apply patch
4) Observe that missing page section has now appeared

Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Sponsored-by: PTFS Europe
Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:50:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:50:02 +0000
Subject: [Koha-bugs] [Bug 32319] New: Give header search submit button more
 padding
Message-ID: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32319

            Bug ID: 32319
           Summary: Give header search submit button more padding
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

Created attachment 144149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144149&action=edit
Before and after versions of the search bar

I think the header search button is a little too small a target for those who
like to click.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:50:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:50:02 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-Dpkiz1iGKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32319


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32319
[Bug 32319] Give header search submit button more padding
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:50:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:50:10 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-EQaQ2TP00Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
 Attachment #144087|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:50:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:50:37 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-LjBmI4fWgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Minor tidy up of the commit message, adding sponsor and mentor details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:54:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:54:55 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-r1B3Xbtakn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144119|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144150&action=edit
Bug 32298: Page section added to cataloguing search

Added div to "Records found in this catalog".
Added page-section class to "Records found in the reservoir".
Corrected level two heading and removed horizontal line as it is now
superfluous.

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both
sections

Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Sponsored-by: PTFS Europe
Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>
Signed-off-by: Katrin <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:56:21 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-CV4UscGCyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144150|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144151&action=edit
Bug 32298: Page section added to cataloguing search

Added div to "Records found in this catalog".
Added page-section class to "Records found in the reservoir".
Corrected level two heading and removed horizontal line as it is now
superfluous.

Test plan:
1) Apply patch from bug 32298
2) Navigate to Cataloging
3) Enter a search into the search field and run the search
4) Verify that the white page section identifier is now visible around both
sections

Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Sponsored-by: PTFS Europe
Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>
Signed-off-by: Katrin <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 12:57:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 11:57:09 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-6UQ1iR8aeH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Minor commit message fixes, added mentorship and sponsorship details and
correct full name on committer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:02:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:02:07 +0000
Subject: [Koha-bugs] [Bug 32319] Give header search submit button more
 padding
In-Reply-To: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32319-70-mNxVCudMw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32319

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:02:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:02:11 +0000
Subject: [Koha-bugs] [Bug 32319] Give header search submit button more
 padding
In-Reply-To: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32319-70-HibRtmiZjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32319

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144152&action=edit
Bug 32319: Give header search submit button more padding

This patch tweaks the appearance of the header search submit button so
that it has a little more spacing, making it an easier click target.

The patch also gives the button a slightly different hover state in
order to make it clearer that it's a button.

To test, apply the patch and rebuild the staff interface CSS.

View various pages in the staff interface to confirm that the header
search bar looks good and works correctly at various screen sizes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:02:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:02:35 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-dtcsIofvv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Interesting, I am missing my last name. This was the first patch I signed from
the new laptop, will have to go check.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:09:30 +0000
Subject: [Koha-bugs] [Bug 32320] New: Remove text-shadow from header menu
 links
Message-ID: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32320

            Bug ID: 32320
           Summary: Remove text-shadow from header menu links
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

The header menu inherits a text-shadow from Bootstrap which is subtle but makes
the links look slightly fuzzy. It should be removed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:09:30 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-bP5SIihKsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32320


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32320
[Bug 32320] Remove text-shadow from header menu links
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:16:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:16:07 +0000
Subject: [Koha-bugs] [Bug 32320] Remove text-shadow from header menu links
In-Reply-To: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32320-70-nbVtO7wYrm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32320

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:16:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:16:13 +0000
Subject: [Koha-bugs] [Bug 32320] Remove text-shadow from header menu links
In-Reply-To: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32320-70-k5tVlzUfSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32320

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144153&action=edit
Bug 32320: Remove text-shadow from header menu links

This patch unsets the text-shadow style on links in the header menu.
This makes the links look a little crisper. The style is inherited from
Bootstrap's defaults and is incorrect for our design.

To test, apply the patch and rebuild the staff interface CSS.

View any page in the staff interface to confirm that header menu links
look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:00 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-hqGGVCVtfO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:04 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-pFBcP7gwBs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:07 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-c4ZnGMyufK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:09 +0000
Subject: [Koha-bugs] [Bug 31891] Regression: show "MARC staging results"
 with clear link to manage staged batch
In-Reply-To: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31891-70-OAuY4gK50D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:12 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-NfASp42YQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:15 +0000
Subject: [Koha-bugs] [Bug 32045] Cannot order multiple from staged file
In-Reply-To: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32045-70-87xtnwcAHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32045

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:19 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-LkTl95ZRia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:25 +0000
Subject: [Koha-bugs] [Bug 32270] Add page-section to label creator - manage
 label layouts
In-Reply-To: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32270-70-XR90OWrnMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:29 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-4GItPrpEru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:35 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-rmsAegJhht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:37 +0000
Subject: [Koha-bugs] [Bug 32308] Update Chocolat image viewer CSS to conform
 to redesign color scheme
In-Reply-To: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32308-70-IZBxZUARKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32308

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:45 +0000
Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing
 randomly
In-Reply-To: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32010-70-4IoofkICo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-up pushed to master. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:33:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:33:31 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-PLEYuYS11X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #209 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Settig this as Failed QA for reason mentioned in comment 207.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:33:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:33:55 +0000
Subject: [Koha-bugs] [Bug 31327] Add color scheme picker to the OPAC
In-Reply-To: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31327-70-2DJx6KlhJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can we add color scheme     |Add color scheme picker to
                   |picker to the OPAC..        |the OPAC
                   |especially a 'dark mode'?   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:39:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:39:21 +0000
Subject: [Koha-bugs] [Bug 32291] What is a library category?
In-Reply-To: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32291-70-DEPBdKeP5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com
          Component|Templates                   |System Administration
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 13:31:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 12:31:32 +0000
Subject: [Koha-bugs] [Bug 32298] Add page-section to cataloguing search
 results (cat)
In-Reply-To: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32298-70-GzdQjUNtxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 14:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 13:14:43 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-XWoTVkB3zn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew.auld at ptfs-europe.com
                   |ity.org                     |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 14:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 13:49:50 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-KEmPybkRQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Staff interface             |Templates
         Depends on|30952                       |32016
            Version|unspecified                 |master


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016
[Bug 32016] Fix 'clear filter' button behavior on datatable saving their state
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 14:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 13:49:50 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-mcfV4w46vy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32303                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303
[Bug 32303] DT pagination on system preference search result
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 14:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 13:49:50 +0000
Subject: [Koha-bugs] [Bug 32016] Fix 'clear filter' button behavior on
 datatable saving their state
In-Reply-To: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32016-70-df1UId7rLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32016

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32303


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303
[Bug 32303] DT pagination on system preference search result
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 14:52:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 13:52:05 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-wUPwIKt6kY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Does bug 30871 solve this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:04:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:04:56 +0000
Subject: [Koha-bugs] [Bug 32321] New: 006 field not correctly prepopulated
 in Advanced cataloging editor
Message-ID: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

            Bug ID: 32321
           Summary: 006 field not correctly prepopulated in Advanced
                    cataloging editor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The 006 helper should load the correct values based on the first position of
the field - this is not happening

To recreate:
1 - Edit a record in advanced cataloging editor with field helpers enabled
2 - Choose a material type, not BKS, from dropdown
3 - Set the first position to something
4 - Save the record
5 - 006 shows 'BKS'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:05:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:05:04 +0000
Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in
 Advanced cataloging editor
In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32321-70-hFy67sXkFo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:07:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:07:21 +0000
Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in
 Advanced cataloging editor
In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32321-70-JzOBXZCFHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:07:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:07:25 +0000
Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in
 Advanced cataloging editor
In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32321-70-kzxg2wstvq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144154&action=edit
Bug 32321: Pre-populate material type for 006 in advanced cataloging editor

To test"
1 - Edit a record in advanced cataloging editor with field helpers enabled
2 - Choose a material type, not BKS, from dropdown
3 - Set the first position to something
4 - Save the record
5 - 006 shows 'BKS'
6 - Apply patch
7 - Reload
8 - Record should show correct value
9 - Edit 006 and confirm the first position correctly determines material type

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:16:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:16:07 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-ED3jMkcM4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144155&action=edit
Bug 32299: Add page-section to Z39.50 results

Test plan
Step 1: Navigate to Cataloguing module and click 'New from Z39.50/SRU' to start
a search
Step 2: Carry out a search
Step 3: Confirm that the white background to the table of results is missing
Step 4: Apply patch
Step 6: Repeat search
Step 7: Confirm that the white background is now showing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:17:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:17:16 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-nlTWz5vMjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:19:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:19:03 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-CbvxNt5UvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
We trialled a slightly different workflow on this one, Andrew submitted a
pull-request to the PTFS Europe mirror of the community repository and then I
extracted it to upload here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:21:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:21:27 +0000
Subject: [Koha-bugs] [Bug 32282] Capitalization: User id
In-Reply-To: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32282-70-43YenWpbY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

Andrew Auld <andrew.auld at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.auld at ptfs-europe.com
           Assignee|oleonard at myacpl.org         |andrew.auld at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:22:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:22:09 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-f4Zy466S6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

Andrew Auld <andrew.auld at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.auld at ptfs-europe.com
           Assignee|oleonard at myacpl.org         |andrew.auld at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:33:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:33:40 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-oKIoHmwUOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

--- Comment #1 from Didier Gautheron <didier.gautheron at biblibre.com> ---
Created attachment 144156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144156&action=edit
Bug 32305: Only process jobs in 'new' state

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:38:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:38:21 +0000
Subject: [Koha-bugs] [Bug 32282] Capitalization: User id
In-Reply-To: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32282-70-788ulf4YLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144157&action=edit
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:38:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:38:46 +0000
Subject: [Koha-bugs] [Bug 32282] Capitalization: User id
In-Reply-To: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32282-70-9zK6LhnpnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:39:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:39:18 +0000
Subject: [Koha-bugs] [Bug 32282] Capitalization: User id
In-Reply-To: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32282-70-9KXy1zxXv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another one submitted via github and transferred via my dev systems

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:40:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:40:40 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-FMvb6a81RM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144158&action=edit
Bug 32283: Correct capitalisation of opac > OPAC

Test plan
Step 1: Navigate to admin>Identity Providers
Step 2: Add new domain
Step 3: For 'Allow opac' setting, verify that opac is lower case in both label
and description
Step 4: Apply patch
Step 5: Navigate to admin>Identity Providers
Step 6: Add new domain
Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label
and description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:41:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:41:02 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-hH3vn8CoIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 15:41:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 14:41:30 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-RWZL39D2LE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another one coming in via github pull request and then transferred via my
systems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:23:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:23:10 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-T3OTPeXt4a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:35:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:35:18 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-klzGTj2p6Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:35:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:35:25 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-2VItbb4wRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144159&action=edit
Bug 32303: DT pagination on system preference search result

This patch updates the way we retrieve a DataTable's saved state during
initialization. The change is to prevent cases where making a duplicate
call to DataTables() initializes the table again.

To recreate the bug, search system preferences for the term "last."
Scroll down to the "OPAC preferences" section and observe that there are
two filter forms displayed above it.

Apply the patch and perform the same search again. The extra forms
should be gone.

Confirm that DataTables behavior is still the same:

 - Test pages which use the "saveState" option in DataTables.
   - Type text in the table's search field
   - Reload the page. The search field should still have the string you
     entered, and the "Clear filter" button should be active.
     - Administration -> Libraries
     - Acquisitions -> Vendor -> Receive shipments -> Receive orders
     - Circulation -> Overdues

 - Test pages which don't use the "saveState" option, e.g. the checkout
   screen, patron search results, list of saved reports, etc. The
   behavior of the search form and table operations in general should be
   unchanged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:41:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:41:11 +0000
Subject: [Koha-bugs] [Bug 32322] New: Column settings menu should not
 include "select all |none" in label text for Check In column
Message-ID: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

            Bug ID: 32322
           Summary: Column settings menu should not include "select all
                    |none" in label text for Check In column
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

On both the Checkout (circulation, issues-table) and Details (moremember,
issues-table) tab of the patron record, the table of checkouts data includes a
column to select items to check in. On both tables, the label to toggle this
column on and off with the Columns button is labled "Check in select all |
none." We don't need the "select all | none" part. It should just say "Check
in."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:43:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:43:32 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-nV3r2NarvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #87 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Template.t fails now. But the code is wrong in the test. I'll have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:49:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:49:00 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-COpfnDshoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:49:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:49:05 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-ICOWiAoXNm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144155|0                           |1
        is obsolete|                            |

--- Comment #3 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144160&action=edit
Bug 32299: Add page-section to Z39.50 results

Test plan
Step 1: Navigate to Cataloguing module and click 'New from Z39.50/SRU' to start
a search
Step 2: Carry out a search
Step 3: Confirm that the white background to the table of results is missing
Step 4: Apply patch
Step 6: Repeat search
Step 7: Confirm that the white background is now showing.

Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:50:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:50:50 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-upoiPe2VCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #88 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144161&action=edit
Bug 24606: (QA follow-up) Fix Template.t

The test cases here still assumed UTF-8 enocding in the middle
of the process. Can be much simpler.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:51:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:51:01 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-5wIy6QX6Nz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> ---
I actually fixed a label on this as well as the description. See test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:51:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:51:24 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-24YuXtEvnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:55:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:55:51 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-RcoRGL5en9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144077|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144162&action=edit
Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on
vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 16:56:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 15:56:25 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-F7kEF8Onr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, code is clear.  Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:19:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:19:14 +0000
Subject: [Koha-bugs] [Bug 32282] Capitalization: User id
In-Reply-To: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32282-70-xbQcVhrbG0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144157|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135 at gmail.com

--- Comment #3 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 144163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144163&action=edit
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:19:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:19:30 +0000
Subject: [Koha-bugs] [Bug 32282] Capitalization: User id
In-Reply-To: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32282-70-U0VLkLZld4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32282

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:23:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:23:11 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-u9yI3tbABD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:24:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:24:07 +0000
Subject: [Koha-bugs] [Bug 25314] Make OPAC facets collapse
In-Reply-To: <bug-25314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25314-70-amEir6pwpG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:25:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:25:07 +0000
Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface
 home page
In-Reply-To: <bug-27497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27497-70-XSW5ZvHqK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:26:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:26:24 +0000
Subject: [Koha-bugs] [Bug 24372] Elasticsearch - cannot search for titles
 containing a colon next to a search term using the colon
In-Reply-To: <bug-24372-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24372-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24372-70-276exNjIB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24372

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:27:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:27:10 +0000
Subject: [Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do
 not show that they will not renew due to a hold
In-Reply-To: <bug-25758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25758-70-AxnwDvvlRG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:27:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:27:44 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-llOYpEaa5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:29:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:29:07 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
 deleted
In-Reply-To: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17355-70-j91TuRXyzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:33:43 +0000
Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with
 duplicated column names
In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23982-70-1hJVCnohEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:34:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:34:20 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-P3n00YnWM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #89 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #88)
> Created attachment 144161 [details] [review]
> Bug 24606: (QA follow-up) Fix Template.t
> 
> The test cases here still assumed UTF-8 enocding in the middle
> of the process. Can be much simpler.
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Follow-up pushed, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:35:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:35:34 +0000
Subject: [Koha-bugs] [Bug 25940] Two separate print dialogs when checking
 in/transferring an item
In-Reply-To: <bug-25940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25940-70-Mk1H8enfjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:36:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:36:29 +0000
Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently
 removed when renewing multiple items at once
In-Reply-To: <bug-26208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26208-70-lPp2fw9quU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:36:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:36:54 +0000
Subject: [Koha-bugs] [Bug 26703] Modify the "title" elements to contain
 unique information first
In-Reply-To: <bug-26703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26703-70-1THDvxhTbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|madamyk at ckls.org            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:38:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:38:51 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-JSR8llN5yz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:43:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:43:34 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-xNDpkK25gl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144147|0                           |1
        is obsolete|                            |

--- Comment #2 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 144164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144164&action=edit
Bug 32310: Correct CSS in the staff interface which still uses old color scheme

To test, apply the patch and rebuild the staff interface CSS.

- Go to Tools -> Calendar. Corrected are the borders around the calendar
  and around the "Add new holiday" panel which appears when you click a
  date on the calendar.
- Go to Patrons and perform a search which will return multiple results.
  - Check the checkbox for some patrons. The color of the "Patrons
    selected" box have been updated.
  - Incorrect padding values have also been removed from the adjacent
    patron list and merge buttons.
- Locate a multi-paged DataTable, e.g. Administration -> Authorized
  values. The style of the "Next" and "Previous" buttons have been
  updated.
- View a patron record and choose More -> Set permissions from the
  toolbar. In the table of permissions, when you hover your mouse over
  one of the headings ("Check out and check in items," "Edit
  authorities," etc.) the color should be correct.
- I don't think this is ever visible in the staff interface, but the
  template has markup in it to display a "Log in" link in the header
  menu if the user isn't logged in. I've removed some redundant CSS
  corresponding to this link and corrected some markup just in case
  there is a situation in which is appears.

Working as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:44:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:44:25 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-phlSCEE4yl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:46:53 +0000
Subject: [Koha-bugs] [Bug 32266] Large amount of late orders slows the
 service
In-Reply-To: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32266-70-yvz35MYVVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:51:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:51:07 +0000
Subject: [Koha-bugs] [Bug 32266] Large amount of late orders slows the
 service
In-Reply-To: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32266-70-oyPaJK7JAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144145|0                           |1
        is obsolete|                            |

--- Comment #2 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 144165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144165&action=edit
Bug 32266: Add new syspref DefaultLateOrderFilterDaysAgo

To test:
1. Open browsers console (F12) and from there Network tab.
2. Navigate to Acquisitions -> Late Orders.
=> Take a note from browsers console how long it takes to open late orders
listing.
3. Apply this patch, update you database and restart your services if needed.
4. Set some value to syspref DefaultLateOrderFilterDaysAgo (999 is max).
5. Load Late orders page again.

Nice enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:51:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:51:21 +0000
Subject: [Koha-bugs] [Bug 32266] Large amount of late orders slows the
 service
In-Reply-To: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32266-70-muiQ95651E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32266

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 17:59:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 16:59:42 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-JEKAcHkZ45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:04:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:04:57 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-Y3solRGUb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This new feature allows
      release notes|                            |librarians to create and
                   |                            |share "item templates"
                   |                            |where one or more item
                   |                            |field values can be set for
                   |                            |a template. Templates can
                   |                            |be applied on a one by one
                   |                            |basis, or set for the
                   |                            |remainder of the logged in
                   |                            |session. Each template may
                   |                            |be optionally shared ( read
                   |                            |only ) to other catalogers.
                   |                            |Librarians with the
                   |                            |manage_item_editor_template
                   |                            |s permission may edit any
                   |                            |template regardless of who
                   |                            |created it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:08:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:08:57 +0000
Subject: [Koha-bugs] [Bug 32323] New: Correct focus state of some DataTables
 controls
Message-ID: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323

            Bug ID: 32323
           Summary: Correct focus state of some DataTables controls
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

Created attachment 144166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144166&action=edit
Screenshot of the button focus state

If you use the tab key to navigate through DataTables controls, some of the
buttons have a style which is out of place in our design. See screenshot
attached.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:08:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:08:57 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-XqPwiPInQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32323


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323
[Bug 32323] Correct focus state of some DataTables controls
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:16:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:16:15 +0000
Subject: [Koha-bugs] [Bug 32320] Remove text-shadow from header menu links
In-Reply-To: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32320-70-B3YrPx1O7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32320

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:16:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:16:18 +0000
Subject: [Koha-bugs] [Bug 32320] Remove text-shadow from header menu links
In-Reply-To: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32320-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32320-70-Upe6ZCNCB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32320

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144153|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 144167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144167&action=edit
Bug 32320: Remove text-shadow from header menu links

This patch unsets the text-shadow style on links in the header menu.
This makes the links look a little crisper. The style is inherited from
Bootstrap's defaults and is incorrect for our design.

To test, apply the patch and rebuild the staff interface CSS.

View any page in the staff interface to confirm that header menu links
look correct.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:16:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:16:54 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-sw8iZgcUQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Sara Brown <sbrown at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbrown at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:20:15 +0000
Subject: [Koha-bugs] [Bug 32323] Correct focus state of some DataTables
 controls
In-Reply-To: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32323-70-vkp51JCl8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:20:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:20:20 +0000
Subject: [Koha-bugs] [Bug 32323] Correct focus state of some DataTables
 controls
In-Reply-To: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32323-70-7KdzfeJw2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 144168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144168&action=edit
Bug 32323: Correct focus state of some DataTables controls

This patch makes changes to the style of some DataTable controls in
order to make hover, active, and focus states more consistent.

To test, apply the patch and rebuild the staff interface css.

View a page that has a DataTable showing controls like "Columns,"
"Export," and "Configure." For example: Saved reports, Libraries,
Overdues.

 - Click the DataTables search form to put cursor focus there.
 - Use the tab key to move through the next buttons.
 - The style should now be more consistent with the appearance of other
   similar buttons in the staff client.
 - Test with and without text in the search filter.
 - Test pages which don't have the full set of controls, e.g. the
   table of of a patron's checkouts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:21:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:21:31 +0000
Subject: [Koha-bugs] [Bug 32319] Give header search submit button more
 padding
In-Reply-To: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32319-70-INMxDmcPXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32319

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:21:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:21:34 +0000
Subject: [Koha-bugs] [Bug 32319] Give header search submit button more
 padding
In-Reply-To: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32319-70-hcgRtE6PaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32319

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144152|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 144169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144169&action=edit
Bug 32319: Give header search submit button more padding

This patch tweaks the appearance of the header search submit button so
that it has a little more spacing, making it an easier click target.

The patch also gives the button a slightly different hover state in
order to make it clearer that it's a button.

To test, apply the patch and rebuild the staff interface CSS.

View various pages in the staff interface to confirm that the header
search bar looks good and works correctly at various screen sizes.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:23:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:23:01 +0000
Subject: [Koha-bugs] [Bug 30241] Show description of fines in details of
 payment
In-Reply-To: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30241-70-ImuBonh55I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30241

Valerie <valerie at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |valerie at bywatersolutions.co
                   |                            |m

--- Comment #1 from Valerie <valerie at bywatersolutions.com> ---
I have talked to libraries who are very unhappy about this display omission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:28:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:28:14 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-xrGDgofeRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #2)
> This solution has one disadvantage: It adds a new string. But I didn't like
> how squashed the label looked in either position, forced on multiple lines.

One more string, yes. It is a much cleaner look!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:29:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:29:59 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-EEZbsVB8gh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:30:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:30:05 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-WkArQ9h5IK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143977|0                           |1
        is obsolete|                            |

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 144170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144170&action=edit
Bug 32236: Fix alignment of checkbox "Use default values" for item batch
modification

This moves the label to the right in front of the checkbox.
It also shortens the label by adding an additional longer hint text.

To test:
* Go to cataloguing > item batch modification
* On the first page of the tool, look at the checkbox at the bottom
* Apply the patch
* Verify changes

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:31:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:31:11 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-N2gBBAzQ1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:31:17 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-wotOxWQ5bl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144130|0                           |1
        is obsolete|                            |

--- Comment #62 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144171&action=edit
Bug 30358 (follow-up) Simplify regex

The regex does the following:
1. Replace newlines and carriage returns with a space
2. Replace leading and trailing whitespace with nothing (strip)

Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:42:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:42:55 +0000
Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in
 Advanced cataloging editor
In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32321-70-lKrnVDGBU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144154|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 144172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144172&action=edit
Bug 32321: Pre-populate material type for 006 in advanced cataloging editor

To test"
1 - Edit a record in advanced cataloging editor with field helpers enabled
2 - Choose a material type, not BKS, from dropdown
3 - Set the first position to something
4 - Save the record
5 - 006 shows 'BKS'
6 - Apply patch
7 - Reload
8 - Record should show correct value
9 - Edit 006 and confirm the first position correctly determines material type

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:43:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:43:13 +0000
Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in
 Advanced cataloging editor
In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32321-70-Lpj1KXwSmf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 18:43:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 17:43:33 +0000
Subject: [Koha-bugs] [Bug 32324] New: Add ability to disable the opac
Message-ID: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32324

            Bug ID: 32324
           Summary: Add ability to disable the opac
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

With more libraries using discovery services, it would be nice to have a way to
disable the OPAC via syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 19:13:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 18:13:29 +0000
Subject: [Koha-bugs] [Bug 32324] Add ability to disable the opac
In-Reply-To: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32324-70-DQslEJU9V0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32324

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |tomascohen at gmail.com,
                   |                            |wizzyrea at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 19:46:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 18:46:24 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-OkvPosOsfR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #101 from Blou <philippe.blouin at inlibro.com> ---
Comments from Kate/RM would be appreciated so that Shi Yao (or others) can move
ahead with this patch.  ShiYao has fixed and commented on the bullet points and
this is now in Limbo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:09:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:09:51 +0000
Subject: [Koha-bugs] [Bug 32325] New: Valid 006/00 values should not depend
 on Type of Material selection
Message-ID: <bug-32325-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32325

            Bug ID: 32325
           Summary: Valid 006/00 values should not depend on Type of
                    Material selection
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl, nick at bywatersolutions.com
        Depends on: 32321

In the 006 control field, the value in position 00 sets the "form of material"
("language material," "notated music," etc). That value informs the type of
material configuration ("Books," "Computer files," etc).

For example, if the leader position 06 and the 006 position 00 are "m," then
the material type should be "Computer files" and the other 006 positions and
parts of the 008 should behave accordingly.
(https://www.loc.gov/marc/bibliographic/bd008c.html)

In both the regular and advanced cataloging editors, Koha shows one both the
006 position 00 value *and* the material type. That's handy, but Koha makes the
material type manually editable rather than derived from the position 00 value.
In fact, Koha forces position 00 to only allow one to enter values that match
what you've selected for material type. So to change the value in position 00,
one must first change the type of material.

Instead, one should be able to set 006/00 to any value allowed in the MARC
specifications and that choice should set the Type of Material and thereby
define how the rest of the 006 behaves.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321
[Bug 32321] 006 field not correctly prepopulated in Advanced cataloging editor
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:09:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:09:51 +0000
Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in
 Advanced cataloging editor
In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32321-70-t9iGAhk2ce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32325


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32325
[Bug 32325] Valid 006/00 values should not depend on Type of Material selection
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:12:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:12:46 +0000
Subject: [Koha-bugs] [Bug 24606] Allow storing item values as a template for
 creating new items
In-Reply-To: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24606-70-afjLMJRvhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:21:37 +0000
Subject: [Koha-bugs] [Bug 32326] New: Install Date/Time
Message-ID: <bug-32326-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32326

            Bug ID: 32326
           Summary: Install Date/Time
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

It would be helpful to see a date and time of the last version upgrade on the
server in the about page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:21:58 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-LrbLymuYE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:22:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:22:02 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-QxGUEElULJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144173&action=edit
Bug 31381: Handle null attributes in list

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:23:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:23:34 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-HvspME6yyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
This is affecting stables and preventing patron searching, we can handle it via
data as well, but we should patch this to prevent failures and then forbid null
attributes at the DB level on another bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:31:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:31:24 +0000
Subject: [Koha-bugs] [Bug 27017] Add further defensive coding to EDI Invoice
 handling
In-Reply-To: <bug-27017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27017-70-TTFH7w4i5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27017

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add defensive coding to EDI |Add further defensive
                   |Invoice handling            |coding to EDI Invoice
                   |                            |handling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:31:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:31:51 +0000
Subject: [Koha-bugs] [Bug 32326] Show installation date and time on the
 about page
In-Reply-To: <bug-32326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32326-70-w5o70gid0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32326

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Install Date/Time           |Show installation date and
                   |                            |time on the about page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:07 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-L2cyNHT9cx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:10 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-lvOplJo89h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:14 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-vf01MGBifj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:19 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-d8nOgeRS44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:21 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-YclRybOwrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:25 +0000
Subject: [Koha-bugs] [Bug 32198] Add page-section to stock rotation stages
 list (cat)
In-Reply-To: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32198-70-u1S3vodWSi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32198

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:28 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-v8ishcNUYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:30 +0000
Subject: [Koha-bugs] [Bug 32237] Batch delete records "no record IDs defined"
In-Reply-To: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32237-70-EdcgO8yPek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32237

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:33 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-KqsTcmotXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:36 +0000
Subject: [Koha-bugs] [Bug 32238] Add page-section to label creator pages
In-Reply-To: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32238-70-Czo7m1efeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32238

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:38 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-Y0vwqYQVp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:41 +0000
Subject: [Koha-bugs] [Bug 32241] Add page-section to list of records in
 batch record modificaton (tool)
In-Reply-To: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32241-70-WvsY6duqfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32241

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:44 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-kHd8BtkqMH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:40:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:40:46 +0000
Subject: [Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages
In-Reply-To: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32254-70-2XKuovEas6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 20:52:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 19:52:50 +0000
Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when
 editing rule
In-Reply-To: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32271-70-8yKNT4W6Aj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

Sara Brown <sbrown at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbrown at bywatersolutions.com

--- Comment #2 from Sara Brown <sbrown at bywatersolutions.com> ---
The same thing is happening on 21.11.11. However, it isn't (consistently?)
preventing patrons from accruing fines for overdue items - I'm seeing patrons
who are accruing fines as they should be even though the applicable rule in the
matrix shows the 0.00 fine cap.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:03:24 +0000
Subject: [Koha-bugs] [Bug 23988] When replace record with z39.50,
 give option on what gets pre-populated
In-Reply-To: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23988-70-Qn8WOXOmbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23988

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Yes, please, this would be very helpful!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:03:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:03:55 +0000
Subject: [Koha-bugs] [Bug 30241] Show description of fines in details of
 payment
In-Reply-To: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30241-70-N7hbzn1w1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30241

Suzanne <smhodson123extra at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |smhodson123extra at yahoo.com

--- Comment #2 from Suzanne <smhodson123extra at yahoo.com> ---
Created attachment 144174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144174&action=edit
Photo of the Accounting Transaction History

This shows a $0.12 waiver and then a $5 payment for the same item, but on the
payment, it shows no details about the payment item. Please fix this ASAP!
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:06:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:06:19 +0000
Subject: [Koha-bugs] [Bug 30241] Show description of fines in details of
 payment
In-Reply-To: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30241-70-CYThSHwWHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30241

--- Comment #3 from Suzanne <smhodson123extra at yahoo.com> ---
I am very surprised this hasn't been corrected already. I wonder if it just
recently happened, as it is a real problem. When patrons pay for an item (fine
or lost item), any write off gives the details on the item that had a write
off, but a payment shows nothing at all about what item was paid for. Please
escalate this as soon as possible. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:07:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:07:35 +0000
Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when
 editing rule
In-Reply-To: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32271-70-y940zFQeo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
(In reply to Sara Brown from comment #2)
> The same thing is happening on 21.11.11. However, it isn't (consistently?)
> preventing patrons from accruing fines for overdue items - I'm seeing
> patrons who are accruing fines as they should be even though the applicable
> rule in the matrix shows the 0.00 fine cap.

Hi Sara,

If you didn't edit the rule, the matrix will show 0.00, but in the database,
the overdue fines cap is actually empty. So your patrons will still accrue (?)
fines normally.

Only beware if you need to edit the rule, make sure to empty the overdue fines
cap field.

Caroline

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:12:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:12:13 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-RtyaA2ke14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> And adjust the tests.

(In reply to Jonathan Druart from comment #7)
> And certainly as well api/v1/swagger/paths/patrons_extended_attributes.yaml

What about that, Nick?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:13:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:13:49 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-ORZX96AhVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Jonathan Druart from comment #6)
> > And adjust the tests.
> 
> (In reply to Jonathan Druart from comment #7)
> > And certainly as well api/v1/swagger/paths/patrons_extended_attributes.yaml
> 
> What about that, Nick?

The tests pass - I can add a test that a null value doesn't fail

For the second, I don't think we should add support to set attributes as null -
we should prevent it wholly on another bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:16:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:16:41 +0000
Subject: [Koha-bugs] [Bug 32327] New: When replacing bib record via z39.50,
 only 1 ISBN should be searched and it should be normalized
Message-ID: <bug-32327-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32327

            Bug ID: 32327
           Summary: When replacing bib record via z39.50, only 1 ISBN
                    should be searched and it should be normalized
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The replace via z39.50 function pre-populates the z39.50 search form with
values from the existing bib. Koha just pastes in the contents of
biblioitems.isbn, which means it very often pre-populates that field with a
value that will never find anything.

If the existing record has more than 1 ISBN, the prepopulated form will list
them all, pipe-separated. This search will always return no results, even when
either ISBN returns results successfully on its own.

If the existing record contains a parenthetical note about binding, that search
will generally fail as well.

We should only put the first ISBN from the record into the search form and we
should strip out any binding note or other fluff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:16:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:16:41 +0000
Subject: [Koha-bugs] [Bug 23988] When replace record with z39.50,
 give option on what gets pre-populated
In-Reply-To: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23988-70-N9vnnvI8IL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23988

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32327

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:20:16 +0000
Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items
 via SIP2 based on itemtypes
In-Reply-To: <bug-31296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31296-70-IM0BFe9A1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported upon request to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:29:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:29:20 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-rtAHpztGzQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Thanks Kyle! Pushed to 22.05.x for upcoming 22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:35:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:35:18 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-rr9CJJMMD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
This patch won't apply cleanly to 22.05.x but I know it is needed for 22.05.07.
Please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:47:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:47:18 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-PYgwRQYA4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Lucas Gass from comment #9)
> This patch won't apply cleanly to 22.05.x but I know it is needed for
> 22.05.07. Please rebase!

I think the confusion is 29955 says it is in 22.05/x, but it isn't?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 21:52:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 20:52:05 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-mjvSqUfFP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.06,         |22.11.00, 22.05.07,
        released in|21.11.14                    |21.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 22:01:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 21:01:34 +0000
Subject: [Koha-bugs] [Bug 32328] New: Add ability to specify how long an
 item stays on a library's holds queue
Message-ID: <bug-32328-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32328

            Bug ID: 32328
           Summary: Add ability to specify how long an item stays on a
                    library's holds queue
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

With multi-location libraries that are open varying hours, it would be helpful
to be able to specify how long an item appears on a library's hold queue before
the item appears on another location's queue.

For example, Title A is available at both Library D and Library E. The patron
wants to pickup the item at Library D.  Library D is closed Saturday and
Sunday, but Library E is not.  Currently, the item could potentially show on
Library E's hold queue.  Since it takes three days of transit time to move the
item from Library E to Library D, it would be faster to fill the hold from
Library D, but because it was moved off Library D's queue, it won't be filled
there.

It would be nice to be able to specify by Library how long an item will appear
on the holds queue for that library before it is moved, and the item is sent
from another library.

Using Holds Queue Skip Closed (and the other associated sys prefs) does not
address this sufficiently.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 22:02:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 21:02:03 +0000
Subject: [Koha-bugs] [Bug 32328] Add ability to specify how long an item
 stays on a library's holds queue
In-Reply-To: <bug-32328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32328-70-24cKzLpj6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32328

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catrina at bywatersolutions.co
                   |                            |m,
                   |                            |hebah at bywatersolutions.com,
                   |                            |sbrown at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 22:05:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 21:05:14 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-rdijMe2SO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.07,         |22.11.00, 22.05.06,
        released in|21.11.14                    |21.11.14

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
To clarify, this was backported for 22.05.x and will be in the upcoming
22.05.07 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 22:23:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 21:23:42 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-vWr52JEE0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #273 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144175&action=edit
Bug 31378: Tests shouldn't remove all patrons

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 22:30:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 21:30:42 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-leHeoHtkfQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 22:30:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 21:30:47 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-Gf9OZlakW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144160|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144176&action=edit
Bug 32299: Add page-section to Z39.50 results

Test plan
Step 1: Navigate to Cataloguing module and click 'New from Z39.50/SRU' to start
a search
Step 2: Carry out a search
Step 3: Confirm that the white background to the table of results is missing
Step 4: Apply patch
Step 6: Repeat search
Step 7: Confirm that the white background is now showing.

Signed-off-by: Hammat Wele <hammat.wele at inlibro.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:31:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:31:49 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
 box for 'Use default values'
In-Reply-To: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32236-70-ooeFykU7aB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Lucas! I think you forgot your sign-off line?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:32:44 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-mDzrffXwkZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:32:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:32:49 +0000
Subject: [Koha-bugs] [Bug 28235] Custom cover images are very large in staff
 search results and OPAC details
In-Reply-To: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28235-70-6sgab260JA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144072|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 144177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144177&action=edit
Bug 28235: Correct CSS governing max width of custom cover images

Images shown in the OPAC and staff interface when the
OPACCustomCoverImages and  CustomCoverImages preferences are enabled
should be getting a max-width set in the current CSS, but the order of
the declarations is preventing the correct specificity.

This patch moves the CSS to the correct place in each file so that the
max-width is applied.

To test, apply the patch and rebuild both the staff and OPAC CSS. If you
get an error during the build process you may need to run 'yarn
install.'

- Go to Administration -> System preferences, and enable the
  OPACCustomCoverImages and  CustomCoverImages preferences.
- If you're testing with the default test database you can set the
  CustomCoverImagesURL preference to
  https://static.myacpl.org/public/covers/{normalized_isbn}.jpg
- Perform a catalog search in both OPAC and staff client limiting by
  itemtype = 'Book'.
- The search results in both interface should show several covers
  supplied from the external URL.
- In the staff client, these images should be limited to 140px wide even
  if the source image is larger.
- In the OPAC, view the detail page for one of the results with cover
  images. The image shown on the detail page should be constrained to
  140px wide even if the source image is larger.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:36:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:36:24 +0000
Subject: [Koha-bugs] [Bug 32178] query parameters in check_api_auth lets
 anyone assume a user id
In-Reply-To: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32178-70-LLAKL0tQno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #22 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #21)
> Any future plans to now use this new subroutine from other places?

Patterned off bug 31050, this new subroutine would probably need to be
refactored to add a "session" parameter, but C4::Auth::checkauth() and
C4::Auth::check_api_auth() could both use it. Maybe
C4::InstallAuth::checkauth() although that one is a very special case.

I don't have any immediate plans to write those patches, but I'd test/QA
someone else's patches. If no one else writes them, I might be able to do it
around February-April 2023.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:37:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:37:31 +0000
Subject: [Koha-bugs] [Bug 30241] Show description of fines in details of
 payment
In-Reply-To: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30241-70-LdNYMadCt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30241

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Suzanne, your screenshot shows the transactions. The 5.00 could have been
applied against multiple open fines and fees, even if it might not be the case
here. Please click on the details button on the right - it should give you more
information. My bug was about adding the description to that details view, as
there we should be able to do it easily, without making the other table
unreadable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:48:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:48:31 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-d9nijSAWTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:48:36 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-RshDCHIHK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144159|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 144178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144178&action=edit
Bug 32303: DT pagination on system preference search result

This patch updates the way we retrieve a DataTable's saved state during
initialization. The change is to prevent cases where making a duplicate
call to DataTables() initializes the table again.

To recreate the bug, search system preferences for the term "last."
Scroll down to the "OPAC preferences" section and observe that there are
two filter forms displayed above it.

Apply the patch and perform the same search again. The extra forms
should be gone.

Confirm that DataTables behavior is still the same:

 - Test pages which use the "saveState" option in DataTables.
   - Type text in the table's search field
   - Reload the page. The search field should still have the string you
     entered, and the "Clear filter" button should be active.
     - Administration -> Libraries
     - Acquisitions -> Vendor -> Receive shipments -> Receive orders
     - Circulation -> Overdues

 - Test pages which don't use the "saveState" option, e.g. the checkout
   screen, patron search results, list of saved reports, etc. The
   behavior of the search form and table operations in general should be
   unchanged.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:59:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:59:07 +0000
Subject: [Koha-bugs] [Bug 32323] Correct focus state of some DataTables
 controls
In-Reply-To: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32323-70-eynvvcJypi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 22 23:59:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 22:59:13 +0000
Subject: [Koha-bugs] [Bug 32323] Correct focus state of some DataTables
 controls
In-Reply-To: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32323-70-EzX4oVghlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144168|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 144179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144179&action=edit
Bug 32323: Correct focus state of some DataTables controls

This patch makes changes to the style of some DataTable controls in
order to make hover, active, and focus states more consistent.

To test, apply the patch and rebuild the staff interface css.

View a page that has a DataTable showing controls like "Columns,"
"Export," and "Configure." For example: Saved reports, Libraries,
Overdues.

 - Click the DataTables search form to put cursor focus there.
 - Use the tab key to move through the next buttons.
 - The style should now be more consistent with the appearance of other
   similar buttons in the staff client.
 - Test with and without text in the search filter.
 - Test pages which don't have the full set of controls, e.g. the
   table of of a patron's checkouts.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 00:34:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 23:34:13 +0000
Subject: [Koha-bugs] [Bug 31221] Buttons overflow in OPAC search results in
 mobile view
In-Reply-To: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31221-70-LZShcvz4lj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |hammat.wele at inlibro.com
                 CC|                            |hammat.wele at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 00:42:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 23:42:58 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-awhcym2AiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 00:43:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 23:43:07 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-cuquXykTbM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144158|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 144180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144180&action=edit
Bug 32283: Correct capitalisation of opac > OPAC

Test plan
Step 1: Navigate to admin>Identity Providers
Step 2: Add new domain
Step 3: For 'Allow opac' setting, verify that opac is lower case in both label
and description
Step 4: Apply patch
Step 5: Navigate to admin>Identity Providers
Step 6: Add new domain
Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label
and description

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 00:46:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Nov 2022 23:46:51 +0000
Subject: [Koha-bugs] [Bug 32329] New: Marking early closures in calendar
Message-ID: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32329

            Bug ID: 32329
           Summary: Marking early closures in calendar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

There is currently no way (that I can see) to mark a partial or early closure
for a day.  It seems to be an all or nothing day.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 01:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 00:11:11 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-X8ZpHKLk5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144180|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 144181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144181&action=edit
Bug 32283: Correct capitalisation of opac > OPAC

Test plan
Step 1: Navigate to admin>Identity Providers
Step 2: Add new domain
Step 3: For 'Allow opac' setting, verify that opac is lower case in both label
and description
Step 4: Apply patch
Step 5: Navigate to admin>Identity Providers
Step 6: Add new domain
Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label
and description

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 01:11:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 00:11:16 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-EjKtM52EES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 144182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144182&action=edit
Bug 32283: (follow-up) Fix in two other places

Fix two other occurences where the capitalization of OPAC
is incorrect:
- Identity provider email domains table column heading
- 'New email domain' form label

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 01:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 00:13:14 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-86Ru2wJm0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
I added a follow-up after signing off, I hope that is OK!

Two fixes were required:
- Identity provider email domains table column heading: should also be 'Allow
OPAC'.
- 'New email domain' form: the hint text is right, but the label is in lower
case and should also be 'Allow OPAC'.

Testing notes:
1. Go to Administration > Additional parameters > Identity providers.
2. Add a 'New identity provider'
3. Once added, select the 'Manage Domains' action for the identity provider.
4. Edit the existing "Identity provider email domains" entry:
   ==> after the patch is applied, OPAC is now in upper case for the 'Allow
OPAC' label and hint text.
5. Note that for the "Identity provider email domains" table, the column
heading is 'Allow opac' instead of 'Allow OPAC'.
6. Add a 'New email domain' got the identity provider, note that the label is
'Allow opac' (the hint text is correct).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 01:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 00:17:34 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-SrtD97G9QR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #8 from David Nind <david at davidnind.com> ---
I also noted that for the forms in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt, the
'<label for="allow_opac">' is used for the 'Allow staff' form field on lines
158 and 264.

I don't know enough about these forms, but should that be '<label
for="allow_staff">' instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 01:55:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 00:55:24 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21699-70-R9RgOdygCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699

Anthony Morris- Orem Public Library <amorris at orem.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amorris at orem.org

--- Comment #11 from Anthony Morris- Orem Public Library <amorris at orem.org> ---
This will be very helpful for our circulation team!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 02:02:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 01:02:41 +0000
Subject: [Koha-bugs] [Bug 30241] Show description of fines in details of
 payment
In-Reply-To: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30241-70-oBjznV5nSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30241

--- Comment #5 from Suzanne <smhodson123extra at yahoo.com> ---
Created attachment 144183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144183&action=edit
Title and Barcode don't show on on the transaction history or on the details

I think this is a dual problem. In my opinion, the title of the item paid
should be on both the overview of the accounting transaction and ALSO on the
detail screen. As you'll see in this new attachment, there is also no title or
barcode if you go to see further details. Why does it show the title and
barcode when a write off happens, but not when a payment is made? That makes no
sense at all, to me. I can only imagine that this is a recent problem and it
hasn't always been this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 02:05:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 01:05:06 +0000
Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC
 advanced search page
In-Reply-To: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32258-70-TWgpPVlXYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

Anthony Morris- Orem Public Library <amorris at orem.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amorris at orem.org

--- Comment #3 from Anthony Morris- Orem Public Library <amorris at orem.org> ---
My staff have asked for this- we have so many detailed item types, they would
also like the ability to do quicker broad searches. For example, we have
several item types related to DVDs, BLUrays, and 4k movies. Sometimes our staff
want to grab a cart of all the related media and want to just narrow to
'Movies' without having to select all the specific item types. If the advanced
search retained the ability to search based on the item types, but also had an
option to search based on ITEMTYPECAT groups, that would be the best of both
worlds for us!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 02:09:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 01:09:18 +0000
Subject: [Koha-bugs] [Bug 30241] Show description of fines in details of
 payment
In-Reply-To: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30241-70-WtvyKATir1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30241

--- Comment #6 from Suzanne <smhodson123extra at yahoo.com> ---
(In reply to Katrin Fischer from comment #4)
> Hi Suzanne, your screenshot shows the transactions. The 5.00 could have been
> applied against multiple open fines and fees, even if it might not be the
> case here. Please click on the details button on the right - it should give
> you more information. My bug was about adding the description to that
> details view, as there we should be able to do it easily, without making the
> other table unreadable.

Katrin, this was a test and it was specifically paid toward the same book as
the write off, which does include the title. It should look the same for both a
write off and for a payment and include both the barcode and the title on both
the table and on the details. (You can see in my last attachment that it is
blank, whereas a write off includes both the barcode and title).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:06:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:06:36 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-Suop1z2FBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:07:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:07:01 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-80PN398jy8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c
                   |ity.org                     |om
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:33:43 +0000
Subject: [Koha-bugs] [Bug 32330] New: Table background_jobs is missing
 indexes
Message-ID: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

            Bug ID: 32330
           Summary: Table background_jobs is missing indexes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Table background_jobs should have indexes to optimize queries.

Query on borrowernumber :
mainpage.pl:    my $already_ran_jobs = Koha::BackgroundJobs->search(
mainpage.pl-        { borrowernumber => $logged_in_user->borrowernumber }
)->count ? 1 : 0;

Query on status:
misc/background_jobs_worker.pl:        my $jobs =
Koha::BackgroundJobs->search({ status => 'new', queue => \@queues });

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:33:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:33:52 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32330-70-Jljyq9lFK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32305

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:33:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:33:52 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-8swF5ZPOMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32330

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:57:18 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32330-70-W8BDMGm6Vr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 07:57:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 06:57:37 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32330-70-tO0o3b0pdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 08:02:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 07:02:58 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32330-70-l9j9kKeV6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144184&action=edit
Bug 32330: Add indexes to table background_jobs

Table background_jobs should have indexes to optimize queries.

Query on borrowernumber :
mainpage.pl:    my $already_ran_jobs = Koha::BackgroundJobs->search(
mainpage.pl-        { borrowernumber => $logged_in_user->borrowernumber }
)->count ? 1 : 0;

Query on status:
misc/background_jobs_worker.pl:        my $jobs =
Koha::BackgroundJobs->search({ status => 'new', queue => \@queues });

Test plan :
Run updatedatabase and play with background jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 08:05:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 07:05:22 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-cIMpkbjxf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I've created Bug 32330 to optimize query of background_jobs_worker.pl when
pooling jobs directly from database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 08:06:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 07:06:11 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-8sLISh6fMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #9 from Andrew Auld <andrew.auld at ptfs-europe.com> ---
I can fix those too. Should I do that under this bug? @David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 08:07:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 07:07:36 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32330-70-h20lVfUPKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144184|0                           |1
        is obsolete|                            |

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144185&action=edit
Bug 32330: Add indexes to table background_jobs

Table background_jobs should have indexes to optimize queries.

Query on borrowernumber :
mainpage.pl:    my $already_ran_jobs = Koha::BackgroundJobs->search(
mainpage.pl-        { borrowernumber => $logged_in_user->borrowernumber }
)->count ? 1 : 0;

Query on status:
misc/background_jobs_worker.pl:        my $jobs =
Koha::BackgroundJobs->search({ status => 'new', queue => \@queues });

Test plan :
Run updatedatabase and play with background jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 08:08:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 07:08:07 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32330-70-4ckMoHVv51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144185|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144186&action=edit
Bug 32330: Add indexes to table background_jobs

Table background_jobs should have indexes to optimize queries.

Query on borrowernumber :
mainpage.pl:    my $already_ran_jobs = Koha::BackgroundJobs->search(
mainpage.pl-        { borrowernumber => $logged_in_user->borrowernumber }
)->count ? 1 : 0;

Query on status and queue :
misc/background_jobs_worker.pl:        my $jobs =
Koha::BackgroundJobs->search({ status => 'new', queue => \@queues });

Test plan :
Run updatedatabase and play with background jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:06:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:06:15 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-L0s6bbj0pa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:06:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:06:19 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-AcxnytVaow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144178|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144187&action=edit
Bug 32303: Remove DT pagination on system preference search result

This patch updates the way we retrieve a DataTable's saved state during
initialization. The change is to prevent cases where making a duplicate
call to DataTables() initializes the table again.

To recreate the bug, search system preferences for the term "last."
Scroll down to the "OPAC preferences" section and observe that there are
two filter forms displayed above it.

Apply the patch and perform the same search again. The extra forms
should be gone.

Confirm that DataTables behavior is still the same:

 - Test pages which use the "saveState" option in DataTables.
   - Type text in the table's search field
   - Reload the page. The search field should still have the string you
     entered, and the "Clear filter" button should be active.
     - Administration -> Libraries
     - Acquisitions -> Vendor -> Receive shipments -> Receive orders
     - Circulation -> Overdues

 - Test pages which don't use the "saveState" option, e.g. the checkout
   screen, patron search results, list of saved reports, etc. The
   behavior of the search form and table operations in general should be
   unchanged.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:12:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:12:13 +0000
Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC
 advanced search page
In-Reply-To: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32258-70-a27VCWfHxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like this to be on separate tabs, what do you think? This way it would also
be easy to see what is a grouped item type and what is a singular one and it
would give us a 'short list' and a 'long list' for easier navigation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:33:15 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-LKPMNi6843@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Also, before this is released in 22.11, should not we replace "background" and
"bg" with "job"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:29:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:29:52 +0000
Subject: [Koha-bugs] [Bug 32331] New: Remove NULLABLE on
 borrower_attributes.attribute
Message-ID: <bug-32331-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32331

            Bug ID: 32331
           Summary: Remove NULLABLE on borrower_attributes.attribute
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 31381

The UI does not allow it, we should remove the NULLABLE clause on
borrower_attributes.attribute

See bug 31381 for more discussion.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381
[Bug 31381] [Intranet/REST-API] Searching patrons by letter broken when using
non-mandatory extended attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:29:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:29:52 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-wLSoTvEmFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32331


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32331
[Bug 32331] Remove NULLABLE on borrower_attributes.attribute
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:30:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:30:56 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-tY1S4xEibq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144188&action=edit
Bug 31381: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 09:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 08:59:19 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-jkKgV6QHnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144189&action=edit
Bug 31969: Use filter_by_last_update

This script has a pattern to delete rows depending on a given
date/number of days, we should use the filter_by_last_update
Koha::Objects method.
No need for another method and tests, everything is already tested
there.

This patch also suggests to rename the reference to "background" and
"bg" with "jobs", which seems more appropriate and not an abbreviation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:02:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:02:44 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-rnWVZFad0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Emmi, did you see the last comments?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:07:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:07:03 +0000
Subject: [Koha-bugs] [Bug 32291] What is a library category?
In-Reply-To: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32291-70-YVZu8mr8vS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |16735

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This is coming from bug 16735 that forgot to remove those messages.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735
[Bug 16735] Replace existing library search groups functionality with the new
hierarchical groups system
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:07:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:07:03 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-ZUH6Lu0Cwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32291


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291
[Bug 32291] What is a library category?
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:08:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:08:16 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-Ya6mFBLNPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144189|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144190&action=edit
Bug 31969: Use filter_by_last_update

This script has a pattern to delete rows depending on a given
date/number of days, we should use the filter_by_last_update
Koha::Objects method.
No need for another method and tests, everything is already tested
there.

This patch also suggests to rename the reference to "background" and
"bg" with "jobs", which seems more appropriate and not an abbreviation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:10:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:10:39 +0000
Subject: [Koha-bugs] [Bug 32291] What is a library category?
In-Reply-To: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32291-70-JySp75x7yL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:10:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:10:43 +0000
Subject: [Koha-bugs] [Bug 32291] What is a library category?
In-Reply-To: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32291-70-ESVSYgyk21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144191&action=edit
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt

On bug 16735 we rewrite the library groups system. Those references in
branches.tt were part of the previous code, and they can be removed.

Test plan:
Confirm the above and that those code errors are never sent to the
template.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:11:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:11:29 +0000
Subject: [Koha-bugs] [Bug 32291] "library category" messages should be
 removed (not used)
In-Reply-To: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32291-70-TxeJhJSGoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|What is a library category? |"library category" messages
                   |                            |should be removed (not
                   |                            |used)
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:14:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:14:17 +0000
Subject: [Koha-bugs] [Bug 32323] Correct focus state of some DataTables
 controls
In-Reply-To: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32323-70-vYGnjKakFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32323

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Where is coming from #ADADAD?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:17:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:17:40 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-elSA1xTBEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #29 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Jonathan Druart from comment #28)
> Emmi, did you see the last comments?

I did, but haven't had time to look into this. I'll try to get onto this at
some point today. And with perltidy, I'm guessing you mean at least this
fraction of tests:

my $hold = $builder->build_object({ class => 'Koha::Holds', value => {
        biblionumber => $item->biblionumber,
        branchcode => $library->branchcode,
        itemnumber => undef,
        itemtype => undef,
        priority => 1,
        found => undef,
        suspend => 0,
        item_group_id => $item->item_group
}});

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:18:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:18:24 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-tr5K1NuAMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:28:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:28:01 +0000
Subject: [Koha-bugs] [Bug 29222] OMNIBUS: Replace the use of jQueryUI
In-Reply-To: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29222-70-ybUvXnYam4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Owen Leonard from comment #0)
> No Bootstrap option. Possible candidate:
> https://tarekraafat.github.io/autoComplete.js/.

[Adding this here, to keep track of it]
I've tried https://github.com/xcash/bootstrap-autocomplete, which seems to work
well, but it does not with bootstrap 3 (no longer supported by the author)
I've almost managed to deal with the different problem, but we will certainly
need to build our own js file.

First I had to pick the this fix:
https://github.com/xcash/bootstrap-autocomplete/pull/129 or the drodown is
empty with bootstrap 3

Then I faced https://github.com/xcash/bootstrap-autocomplete/issues/103 which
appears to be fixed, but it's not (or not for bootstrap 3, I don't know).

It's sad because I am almost there, but I lost confidence in this lib.

Can be tested on https://gitlab.com/joubu/Koha/-/commits/bootstrap-autocomplete
using the patron search autocomplete in the header.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:28:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:28:51 +0000
Subject: [Koha-bugs] [Bug 29222] OMNIBUS: Replace the use of jQueryUI
In-Reply-To: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29222-70-VS4ANYDFqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I've also tried https://tarekraafat.github.io/autoComplete.js but there was too
much existing styling and I gave up quickly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:32:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:32:34 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-tKpk4roD4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Yes, all the subtest actually. Which IDE do you use?

If vi, you can:
1. install perltidy
2. Define a vmap on F8 (or whatever) in your .vimrc
  vmap <F8> :!perltidy -q<CR>
3. Open a new vi instance, select text in visual mode, press F8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:56:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:56:00 +0000
Subject: [Koha-bugs] [Bug 32332] New: bulkmarcimport.pl -insert fails to add
 MARC field 999
Message-ID: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

            Bug ID: 32332
           Summary: bulkmarcimport.pl -insert fails to add MARC field 999
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

We have several libraries that have problems with their batch imports/updates
from external sources after upgrading to 22.05.06. The problem is that records
that are imported and/or updated via bulkmarcimport.pl do not get a 999 field,
with the biblionumber in $c and $d. No 999 field is added at all. 

To reproduce in koha-testing-docker:

- Edit koha/t/db_dependent/Record/testrecords/marcxml_utf8.xml and remove the
952 field (otherwise Koha will complain about an undefined branchcode)

- Import that file: 
$ sudo koha-shell -c "perl koha/misc/migration_tools/bulkmarcimport.pl -b -v
-m=MARCXML -match=Control-number,001 -insert -l=/tmp/import.log -file
koha/t/db_dependent/Record/testrecords/marcxml_utf8.xml" kohadev

- Check the result: 
$ sudo koha-mysql kohadev
MariaDB [koha_kohadev]> SELECT biblionumber, ExtractValue(metadata,
'count(//datafield[@tag="999"])') AS count999 FROM biblio_metadata HAVING
count999 = 0;

This should give output like this: 

+--------------+----------+
| biblionumber | count999 |
+--------------+----------+
|          439 | 0        |
+--------------+----------+
1 row in set (0.013 sec)

...meaning biblionumber 439 does not have a 999 field. 

- Updating the same record: 
$ sudo koha-shell -c "perl koha/misc/migration_tools/bulkmarcimport.pl -b -v
-m=MARCXML -match=Control-number,001 -update -l=/tmp/import.log -file
koha/t/db_dependent/Record/testrecords/marcxml_utf8.xml" kohadev

...seems to add the 999 and make the problem go away: 
$ sudo koha-mysql kohadev
MariaDB [koha_kohadev]> SELECT biblionumber, ExtractValue(metadata,
'count(//datafield[@tag="999"])') AS count999 FROM biblio_metadata HAVING
count999 = 0;
Empty set (0.009 sec)

BUT on live servers (running 22.05.06, not master like in ktd) it looks like
updating a record via bulkmarcimport.pl can cause an existing record to loose
its 999 field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:57:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:57:58 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-5xfWSVCaCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 10:59:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 09:59:49 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-Q86PvNtZDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:04:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:04:19 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-sNmFie5ZP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:04:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:04:23 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-aRU1m0bOkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144090|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144192&action=edit
Bug 32269: Prevent Circulation.t to fail randomly

Highlighted by Bug 32030: fix test builder for boolean

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 343.
    #          got: '2022-11-18T14:16:12'
    #     expected: '2022-12-02T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 349.
    #          got: '2022-11-18T14:16:12'
    #     expected: '2022-12-02T23:59:00'
    # Looks like you failed 2 tests of 5

We were reaching return $now

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:05:54 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-08d6oawMwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:06:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:06:22 +0000
Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly
 when using "Refund lost item charge and charge new overdue fine" option in
 circ rules
In-Reply-To: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30254-70-zlYfcYd8op@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think this may have fallen off Katrin's radar... bump

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:13:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:13:30 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-DBASpNHEjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144052|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144193&action=edit
Bug 32046: When adding a new records from a staged files, there are style
issues

This patch modifies the template for adding a record from a staged file
in order to resolve some layout problems introduced by the staff
redesign.

This patch also corrects an problem with addorderiso2709.js: It included
some template markup. The template variables are converted to a JS
variable to prevent a JS error.

Note that the QA tool's js_in_body error is invalid for this template
which requires that the JS stay inside <head>.

To test you must have at least one MARC file staged for import.

- Apply the patch and go to Acquisitions.
- Locate a vendor and create a basket if necessary.
- Add to the basket and choose the option of adding an order from a
  staged file.
- Click "Add orders" next to one of the staged files.
- On the Add orders from MARC file page, test that everything looks
  correct and works correctly:
  - In the first tab, expanding and collapsing order details by checking
    the checkbox or clicking the title.
  - Test the "MARC" and "Card" preview buttons.
  - Under the Item information tab, confirm that the layout looks
    correct and that the form works correctly, including plugin
    operations like auto barcode fill.
  - Test that, under the Default accounting details tab, changing the
    fund automatically sets the fund for each title in the first tab.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:13:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:13:35 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-SI3cMbROYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144053|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144194&action=edit
Bug 32046: (follow-up) Accommodate the inclusion of item information

If you have item information configured in the MarcItemFieldsToOrder
system preference, the "Select to import" tab will display a basic item
information form which needs to use the same style as other item edit
forms.

In order to make the CSS in addbiblio.css more generic, I've changed
some styles to use a class, .item_edit_form, instead of an ID. This lets
us have multiple <div class="item_edit_form"> in this template without
duplicating IDs. Other instances of <div
id="cataloguing_additem_newitem"> have haa the .item_edit_form class
added.

To test you must have a staged MARC file which includes items and you
must configure the MarcItemFieldsToOrder preference to map those items
in the ordering interface.

As you follow the previous patch's test plan you'll find that when you
click a checkbox or title to expand the information about that title
you'll see "Item record X" headings following by a properly-styled form.

To confirm that the changes to addbiblio.css are not too far-reaching,
test the other affected pages:

 - Item add/edit
 - Batch item modification
 - Batch item deletion

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:15:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:15:06 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-MwAryx4hA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice improvement, QA scripts generally happy and all works as expected.

Passing QA.

Warning: This patch does introduce two new strings as far as I can tell, labels
only.  I'll leave it to RM's discretion whether as a major it's worth the pain
or not to push now or just after 22.11.00 release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:15:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:15:27 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-4Kd1zj2UTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

Hanna Dehlin <hanna.dehlin at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hanna.dehlin at hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:56:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:56:37 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-8AwRGXrvon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:56:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:56:41 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-dTexPpmgqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144173|0                           |1
        is obsolete|                            |
 Attachment #144188|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144196&action=edit
Bug 31381: Handle null attributes in list

This patch allows null values to be returned in patron attributes
to prevent a crash when searching patrons

To test:
1 - Add a NULL attribute to a borrower, in sample data, Edna Acosta
    sudo koha-mysql kohadev
    INSERT INTO borrower_attributes (borrowernumber,code,attribute) VALUES
(5,'SHOW_BCODE',NULL);
2 - Browse to 'Home->Patrons'
    http://localhost:8081/cgi-bin/koha/members/members-home.pl
3 - Click 'Browse by last name: A'
4 - Datatables error:
    Expected string - got null
5 - Apply patch
6 - Restart all
7 - Browse by last name: A
8 - Success!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 11:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 10:56:45 +0000
Subject: [Koha-bugs] [Bug 31381] [Intranet/REST-API] Searching patrons by
 letter broken when using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-fRa5O5nJ0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144197&action=edit
Bug 31381: Add tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:17:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:17:25 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-2yHCRRbd1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569
[Bug 31569] Remove GetImportsRecordRange from acqui/addorderiso2709
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:17:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:17:25 +0000
Subject: [Koha-bugs] [Bug 31569] Remove GetImportsRecordRange from
 acqui/addorderiso2709
In-Reply-To: <bug-31569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31569-70-72ShrqJOi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32166


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166
[Bug 32166] When adding to a basket from a staged file we may use the wrong
inputs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:38:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:38:50 +0000
Subject: [Koha-bugs] [Bug 26869] Enable batch record modification to create
 952/item on existing bibs
In-Reply-To: <bug-26869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26869-70-8SD4fMUjhd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

Aude Charillon <aude.charillon at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aude.charillon at ptfs-europe.
                   |                            |com

--- Comment #12 from Aude Charillon <aude.charillon at ptfs-europe.com> ---
I agree with previous comments that it would be useful to be able to add items
to existing records using a MARC modification template. It just happens that
sometimes you change how you deal with eBook records and all the existing ones
need to be amended!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:42:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:42:07 +0000
Subject: [Koha-bugs] [Bug 31221] Buttons overflow in OPAC search results in
 mobile view
In-Reply-To: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31221-70-TLGzJ9aWRp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221

--- Comment #1 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144198&action=edit
Fix overflowing pagination in OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:50:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:50:00 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-Gcd9MDUtzM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #31 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Jonathan Druart from comment #30)
> Yes, all the subtest actually. Which IDE do you use?
> 
> If vi, you can:
> 1. install perltidy
> 2. Define a vmap on F8 (or whatever) in your .vimrc
>   vmap <F8> :!perltidy -q<CR>
> 3. Open a new vi instance, select text in visual mode, press F8

Thanks, this worked fine. I was able to fix tests and perltidy them, should I
just at the patch here or should I make a new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:53:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:53:47 +0000
Subject: [Koha-bugs] [Bug 32333] New: IdRef system preference revamping
Message-ID: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

            Bug ID: 32333
           Summary: IdRef system preference revamping
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: frederic at tamil.fr
        QA Contact: testopia at bugs.koha-community.org

IdRef system preference enables a Unimarc-only functionality. Authors
fields contain in $3 subfield a PPN, an unique identifier in IdRef a
French national authority file, similar to VIAF.

KohaLa, the Koha French users association, has designed a revamped
implementation of IdRef in Koha. The goal is to improve the visual and
to add a functionality.

- Visually — The author publications list is currently displayed in
  an old fashion dialog box. It uses greybox library, which is
  deprecated. See bug 8290. The list is displayed in a
  distinct tab of holdings block.

- Functionality — The title in the list are searched in Koha local
  catalog. So it's possible to mark titles locally available and link
  to them. PPN are searched directly in Elasticsearch for efficiency.
  Koha IdRef users are academic libraries or higher education school. So
  Zebra support is not required for them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:54:12 +0000
Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping
In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32333-70-xTMKXz3eAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8290


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 12:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 11:54:12 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
 Bootstrap modals
In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8290-70-TZJHeO3sk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32333


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333
[Bug 32333] IdRef system preference revamping
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:06:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:06:33 +0000
Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping
In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32333-70-zWaMsXirw1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

--- Comment #1 from Frédéric Demians <frederic at tamil.fr> ---
Created attachment 144199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144199&action=edit
Bug 32333: IdRef system preference revamping

IdRef system preference enables a Unimarc-only functionality. Authors
fields contain in $3 subfield a PPN, an unique identifier in IdRef a
French national authority file, similar to VIAF.

KohaLa, the Koha French users association, has designed a revamped
implementation of IdRef in Koha. The goal is to improve the visual and
to add a functionality.

- Visually — The author publications list is currently displayed in
  an old fashion dialog box. It uses greybox library, which is
  deprecated. See bug 8290. With this patch, the list is displayed in a
  distinct tab of holdings block.

- Functionality — The title in the list are searched in Koha local
  catalog. So it's possible to mark titles locally available and link
  to them. PPN are searched directly in Elasticsearch for efficiency.
  Koha IdRef users are academic libraries or higher education school. So
  Zebra support is not required for them.

NOTE: After pushing this patch, greybox library could be removed
      completely for OPAC :
      /koha-tmpl/opac-tmpl/bootstrap/lib/greybox/

TO TEST :

- On a Unimarc Koha, with a Sudoc compliant Catalog, enable IdRef.
- Use default OPAC XSL.
- On opac-detail.pl page, you can see a logo IdRef next to authors
  having a $3 (ppn) subfield. Click on the logo.
- Confirm that a tab is added to holdings. It contains the author
  publications found in the Sudoc.
- A Sudoc logo is displayed in front of each title. Clicking the icon
  open the title in Sudoc web site.
- A Koha logo is displayed in from of each title available locally.
  Clicking the logo open the title in Koha OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:07:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:07:10 +0000
Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping
In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32333-70-iBsViLYnYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:13:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:13:32 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-ziAFHr45Fv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Arthur Suzuki from comment #7)
> Thanks!
> 
> Pushed to 21.11 for 21.11.12

This depends on 30992 which was not backported to 21.11
This means that:
reservedate is being formatted in opac-reserve.pl:
    $itemLoopIter->{reservedate}     = output_pref({ dt =>
dt_from_string($first_hold->reservedate), dateonly => 1 }); # FIXME Should be
formatted in the template

And is also being formatted in the template:
<span>On hold for patron expected at [% Branches.GetName(
itemLoo.ExpectedAtLibrary ) | html %] since [% itemLoo.reservedate | $KohaDates
%]</span>

And DateUtils dies on an unexpected date (as it has already been formatted)

Please revert

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:22:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:22:58 +0000
Subject: [Koha-bugs] [Bug 32334] New: Working title
Message-ID: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334

            Bug ID: 32334
           Summary: Working title
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

More info follows.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:26:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:26:53 +0000
Subject: [Koha-bugs] [Bug 32166] When adding to a basket from a staged file
 we may use the wrong inputs
In-Reply-To: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32166-70-vmUQLCaFIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #10)
> (In reply to Lucas Gass from comment #9)
> > This patch won't apply cleanly to 22.05.x but I know it is needed for
> > 22.05.07. Please rebase!
> 
> I think the confusion is 29955 says it is in 22.05/x, but it isn't?

This depends on 31569

This was a tangle of confusion in fixing bugs, 32167 is needed for 22.05 - but
this is not

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:36:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:36:04 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-nFBwAp02aE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Lucas Gass from comment #15)
> To clarify, this was backported for 22.05.x and will be in the upcoming
> 22.05.07 release

It looks like only the last patch was picked? That should be okay, just
verifiying

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:08 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-KVfnnbJ4Zu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:11 +0000
Subject: [Koha-bugs] [Bug 32046] When adding a new records from a staged
 files, there are style issues
In-Reply-To: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32046-70-nJku3mLSJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32046

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:14 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-VrW410fuGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:17 +0000
Subject: [Koha-bugs] [Bug 32260] Prevent alert when searching patron
 (autocomplete)
In-Reply-To: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32260-70-O09mZJUPXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32260

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:19 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-dJBekZmecs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:21 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-zfw8EIwP22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:24 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-25VzNuLMTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:27 +0000
Subject: [Koha-bugs] [Bug 32299] Add page-section to Z39.50/SRU results (cat)
In-Reply-To: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32299-70-ObraqMuNdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32299

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:29 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-MKRsIOFHoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:48:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:48:32 +0000
Subject: [Koha-bugs] [Bug 32303] DT pagination on system preference search
 result
In-Reply-To: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32303-70-zFLdkM0SpD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32303

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:52:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:52:07 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-E2l1i1kBw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:52:11 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-cVU4d3l0wQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139401|0                           |1
        is obsolete|                            |
 Attachment #139402|0                           |1
        is obsolete|                            |
 Attachment #139403|0                           |1
        is obsolete|                            |
 Attachment #139404|0                           |1
        is obsolete|                            |

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144200&action=edit
Bug 27138: Index host items in child records when sending to search engine

On the Koha side we seperate the items from the MARC record but we do put them
in
the search engines

For easy analytics we embed host items when displaying results after fetching
from the search engine

We can simpify things and improve results by including the host items when
indexing

To test:
 1 - Enable EasyAnalyticalRecords
 2 - Find a record in the staff client
 3 - From details page select Edit->Link to host record
 4 - Attach a barcode from a different record
 5 - Search for that barcode in the staff client
 6 - Only host record is returned
 7 - Perform a search that returns the child record and others
 8 - Note the host item is listed on the child record in the results page
 9 - Repeat on OPAC
10 - Note on opac that host item is missing on results
11 - Apply patch
12 - Search for barcode
13 - Child and host record returned on both staff and OPAC
14 - Child record correctly includes host item on staff and OPAC
15 - Connect to the Z3950 responder or zebra directly
     yaz-client localhost:2100
     yaz-client unix:/var/run/koha/kohadev/bibliosocket
16 - Search for the child record
     base biblios
     find record_keyword
     show 1+10
17 - Note the record includes the host item
18 - Repeat tests for Elasticsearch

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Michael Sutherland <sudrland at vt.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:52:16 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-EE1KVaL6DQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144201&action=edit
Bug 27138: (follow-up) Embed host items when performing index from command line

The previous patch made sure host items were embedded when indexes were
performed inside of Koha (catalg edits, checkins, etc.) but did not affect a
command line reindex

To test:
0 - Follow previous test plan to setup records and set search engine to
elasticsearch
1 - perl misc/search_tools/rebuild_elasticsearch.pl -d
2 - Search for the barcode and confirm both records are returned
3 - Confirm the host items are included in the results

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Michael Sutherland <sudrland at vt.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:52:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:52:21 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-BPviIodwYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144202&action=edit
Bug 27138: Add preference EmbedHostItemsInSearchEngine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 13:52:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 12:52:25 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-nrVg683ILz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144203&action=edit
Bug 27138: Import needed subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:22:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:22:39 +0000
Subject: [Koha-bugs] [Bug 32335] New: Allow stock rotation items to be moved
 several stages ahead
Message-ID: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

            Bug ID: 32335
           Summary: Allow stock rotation items to be moved several stages
                    ahead
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently when an item is added to stock rotation it can only be moved ahaead
one stage, then the transfer must be filled to allow moving to the next stage.

Some libraries will want to add an item to a rotation, and move it ahead to
'catch-up' with other items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:28:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:28:06 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-F3W5GkFztC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:28:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:28:10 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-7boIEkSUgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144204&action=edit
Bug 32335: Allow stock rotation items to be advanced when in transit

This patch simply removes the disabling of the 'Move to next stage' button
and adds a title to let the librarian know the item is in transit

To test:
1 - Setup a rota with multiple stages
2 - Add an item
3 - Advance to next stage
4 - Observe 'Move to next stage' button is disabled
5 - Check item in at destination
6 - Reload rota - observe 'Move to next stage' is enabled
7 - Apply patch
8 - Click 'Move to next stage'
9 - Note button is not disabled
10 - Hover and confirm note about transit
11 - Click 'Move to next stage'
12 - Checkin item at wrong branch, confirm it is correctly directed to correct
stage

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:28:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:28:29 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-7dlOP9SMQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:30:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:30:47 +0000
Subject: [Koha-bugs] [Bug 31221] Buttons overflow in OPAC search results in
 mobile view
In-Reply-To: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31221-70-kWTVYUyFHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144198|0                           |1
        is obsolete|                            |

--- Comment #2 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144205&action=edit
Fix overflowing pagination in OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:37:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:37:34 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-CxbRf9uuhd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144204|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144206&action=edit
Bug 32335: Allow stock rotation items to be advanced when in transit

This patch simply removes the disabling of the 'Move to next stage' button
and adds a title to let the librarian know the item is in transit

To test:
1 - Setup a rota with multiple stages
2 - Add an item
3 - Advance to next stage
4 - Observe 'Move to next stage' button is disabled
5 - Check item in at destination
6 - Reload rota - observe 'Move to next stage' is enabled
7 - Apply patch
8 - Click 'Move to next stage'
9 - Note button is not disabled
10 - Hover and confirm note about transit
11 - Click 'Move to next stage'
12 - Checkin item at wrong branch, confirm it is correctly directed to correct
stage

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:38:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:38:48 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-jy5R5fxwmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice, discussed with Nick, and I am happy this change doesn't affect the logic
in any detrimental way :)

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 14:58:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 13:58:39 +0000
Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in
 database
In-Reply-To: <bug-27880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27880-70-8RZgNvGoqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 15:00:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 14:00:29 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-Q7azIHABXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
This is a bit weird, but now I can't reproduce the exact behaviour described in
the first comment. On the first run with -import, the 999 field is missing. But
if I the exact same command once more, the 999 goes away. And then I can re-run
the -import as many times as I want, and no 999 is added. So run
bulkmarcimport.pl with -import twice to reproduce the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 15:27:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 14:27:50 +0000
Subject: [Koha-bugs] [Bug 32258] ITEMTYPECAT groups only show on OPAC
 advanced search page
In-Reply-To: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32258-70-IUzQorl0RG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32258

--- Comment #5 from Catrina Berka <catrina at bywatersolutions.com> ---
I think separate tabs would work for this purpose, giving libraries the ability
to search in expanded or condensed item type groupings. 

(In reply to Katrin Fischer from comment #4)
> I'd like this to be on separate tabs, what do you think? This way it would
> also be easy to see what is a grouped item type and what is a singular one
> and it would give us a 'short list' and a 'long list' for easier navigation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 15:41:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 14:41:23 +0000
Subject: [Koha-bugs] [Bug 32336] New: MARCXML output of REST API may be
 badly encoded (UNIMARC)
Message-ID: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

            Bug ID: 32336
           Summary: MARCXML output of REST API may be badly encoded
                    (UNIMARC)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
                CC: tomascohen at gmail.com

In Koha/REST/V1/Biblios.pm (methods get and get_public),
MARC::Record::as_xml_record is called without a $format parameter, which means
it relies on the package variable $MARC::File::XML::RecordFormat to be
correctly set, which may or may not be the case depending on what the current
starman/mojo worker has done before.
We should pass the format explicitly to avoid problems.

This is only a problem for UNIMARC, because $MARC::File::XML::RecordFormat
defaults to 'USMARC'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 15:46:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 14:46:19 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-2yjd6FRQIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Done some more digging, and I think I found the problem. The POD for
bulkmarcimport.pl reads:

    -insert
        if set, only insert when possible

    -update
        if set, only updates (any biblio should have a matching record)

    -all
        if set, do whatever is required

The way I interpret this, if -insert is provided, records that are not present
in the database (based on the matching provided by -match) should be inserted,
and records that are already present should be skipped and not updated. 

If the script is run with -match and -insert, it will look for an existing
record. If one is found, then the following logic happens: 

            if ($biblionumber) {
                eval{
                    $biblioitemnumber = Koha::Biblios->find( $biblionumber
)->biblioitem->biblioitemnumber;
                };
                if ($update) {
                    # If run with -update, but this is not what we are looking
for
                } else {
                    # If run with -insert, nothing happens, except some logging
                    printlog( { id => $id || $originalid || $biblionumber, op
=> "insert", status => "warning : already in database" } ) if ($logfile);
                }
            } else {
                # An existing record was not found
            }

This looks OK, nothing happens if there is a match and -insert is provided. But
then, further down in the script, ModBiblioMarc gets run for all records:

            ModBiblioMarc( $clone_record, $biblionumber );

This updates biblio_metadata.metadata, even if we did not want to update
records that have a match! To check this behviour, run the "bulkmarcimport.pl
-import" command I gave in the first comment, then log into the database and
run this: 

MariaDB [koha_kohadev]> select timestamp from biblio_metadata where
biblionumber = 439;

(Replace 439 with the biblionumber you got, if you got another biblionumber.)

Then run "bulkmarcimport.pl -import" again and check the timestamp again. It
will be different from the first timestamp. 

This could have worked (sort of), if the 999 field was added in ModBiblioMarc,
but since bug 29486 that has not been the case. 

I think the solution here is to not run ModBiblioMarc for records that have a
match, when run with -insert?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 16:14:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 15:14:26 +0000
Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly
 encoded (UNIMARC)
In-Reply-To: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32336-70-zH4ldteTkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 144207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144207&action=edit
Bug 32336: Fix encoding of MARCXML output for REST API (UNIMARC)

Test plan:
1. Be sure to test on a UNIMARC instance
2. Enable system preferences RESTPublicAPI and RESTPublicAnonymousRequests
3. Create a biblio with some diacritics
4. Restart koha and do not interact with OPAC or the staff interface
   (this may change $MARC::File::XML::RecordFormat)
5. Query the public API to retrieve the created biblio in MARCXML. For
   instance with cURL:

   curl -H 'Accept: application/marcxml+xml' \
    http://koha.local/api/v1/public/biblios/<biblionumber>

   You should see encoding issues.
6. Apply the patch and restart Koha.
7. Repeat step 5.
   You should see no encoding issues.
8. You should also test /api/v1/biblios/<biblionumber> (this one
   requires authentication, so cURL might not be the most practical
   tool; use your favorite tool for this)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 16:14:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 15:14:36 +0000
Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly
 encoded (UNIMARC)
In-Reply-To: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32336-70-MW3xWBiAz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 16:36:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 15:36:14 +0000
Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly
 encoded (UNIMARC)
In-Reply-To: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32336-70-8SbwveanWN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 16:49:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 15:49:21 +0000
Subject: [Koha-bugs] [Bug 32337] New: System preference to block holds with
 debarments
Message-ID: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

            Bug ID: 32337
           Summary: System preference to block holds with debarments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hebah at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

A number of libraries would like the ability to have borrower debarments
prevent placing holds. Currently, debarments only block checkouts, not the
placing of holds. Ideally this would be a system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:01:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:01:50 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-DQZk1KnU37@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Doesn't apply cleanly to 22.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:02:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:02:59 +0000
Subject: [Koha-bugs] [Bug 31995] build_holds_queue.pl should check to see if
 the RealTime syspref is on
In-Reply-To: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31995-70-DHouxcUQB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31995

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:04:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:04:26 +0000
Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC
In-Reply-To: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30036-70-K3QHzyTTuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
           Keywords|rel_22_05_candidate         |
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:08:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:08:04 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-v1Xh04UfAi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144208&action=edit
Bug 32167: [22.05.x] (bug 14860 follow-up) Populate price fields even if no
discount on vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:25:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:25:38 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-oIBpFVza4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.07
        released in|                            |

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Thanks Nick! This fix is backported to 22.05.x for upcoming 22.05.07 release!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:32:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:32:10 +0000
Subject: [Koha-bugs] [Bug 32322] Column settings menu should not include
 "select all |none" in label text for Check In column
In-Reply-To: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32322-70-mJ0jqDuWNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

--- Comment #1 from Jacob O'Mara <jacob.omara at ptfs-europe.com> ---
Created attachment 144209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144209&action=edit
Bug 32322 : Removal of "Select all|None"

Removed "Select all|None" from check in column of circ > checkouts and circ >
details pages

Test Plan:

Navigate to Circulation > checkouts > *user*
Ensure *user* has book checked out
Observe that under both the Check Out and Details tabs on the left, the table
has a column labelled "Check in select all | none."
Apply Patch
Observe that the above column on both tabs now reads "Check in"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:33:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:33:47 +0000
Subject: [Koha-bugs] [Bug 32322] Column settings menu should not include
 "select all |none" in label text for Check In column
In-Reply-To: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32322-70-enzf4AI0aA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

Jacob O'Mara <jacob.omara at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jacob.omara at ptfs-europe.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:44:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:44:10 +0000
Subject: [Koha-bugs] [Bug 26869] Enable batch record modification to create
 952/item on existing bibs
In-Reply-To: <bug-26869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26869-70-IPnvlt1wws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

Susan <susan.merner at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |susan.merner at nhs.net

--- Comment #13 from Susan <susan.merner at nhs.net> ---
I agree having the option to list items makes sense - It helps with limiting
results to specific library having a journal/book online or in print format.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 17:49:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 16:49:37 +0000
Subject: [Koha-bugs] [Bug 32338] New: OPAC - Mobile - Selection toolbar in
 search result is shifted and not adjusted
Message-ID: <bug-32338-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338

            Bug ID: 32338
           Summary: OPAC - Mobile - Selection toolbar in search result is
                    shifted and not adjusted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: hammat.wele at inlibro.com
          Reporter: hammat.wele at inlibro.com
        QA Contact: hammat.wele at inlibro.com

To reproduce:

    1- Go to the OPAC
    2- Open mobile mode
    3- Perform a search
    4- Check the top of the results table
        --> options are not displayed correctly;
        --> there is a blank space between "Unhighlight" and "Select All"

    5- Apply the patch and perform the same search again. 
    6- Confirm that options are displayed correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 18:19:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 17:19:20 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-BxO3lEUrL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

--- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144210&action=edit
Bug 32257 : Label for Patron Attributes Misaligned

Label has now been realigned to match the format of the fields above.

Test Plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields
above

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 18:19:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 17:19:36 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-QBE1pSbSc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |matt.blenkinsop at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 18:21:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 17:21:20 +0000
Subject: [Koha-bugs] [Bug 32338] OPAC - Mobile - Selection toolbar in search
 result is shifted and not adjusted
In-Reply-To: <bug-32338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32338-70-CoOzFY3z6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32338

--- Comment #1 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144211&action=edit
OPAC - Mobile - The Selection toolbar in search result is shifted and not
adjusted

To reproduce:

    Go to the OPAC
    Open mobile mode
    Perform a search
    Check the top of the results table
        --> options are not displayed correctly;
        --> there is a blank space between 'Unhighlight' and 'Select All'

Apply the patch and perform the same search again.
Confirm that options are displayed correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 18:31:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 17:31:16 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
 when using EasyAnalytics
In-Reply-To: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27138-70-Yh7k5YAW4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #31 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
> 13 - Child and host record returned on both staff and OPAC
> 14 - Child record correctly includes host item on staff and OPAC

With these patches applied, zebra search by barcode returns only the host on
staff and OPAC. On the OPAC, search results when searching for the child record
don't include the host item.

I did a reset_all after applying patches. Was there something else I should
have done to make the changes apply?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 18:32:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 17:32:36 +0000
Subject: [Koha-bugs] [Bug 32167] When adding an order from a a staged file
 without item fields we only add price if there is a vendor discount
In-Reply-To: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32167-70-Wz1ERTU6He@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 144212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144212&action=edit
Bug 32167: [21.11.x] (bug 14860 follow-up) Populate price fields even if no
discount on vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 18:40:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 17:40:43 +0000
Subject: [Koha-bugs] [Bug 32322] Column settings menu should not include
 "select all |none" in label text for Check In column
In-Reply-To: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32322-70-JIdlJL9kF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Sorry, I wasn't quite clear. I think it's helpful to have "select all | none"
in the column header itself. I don't think we need to include it in the Column
Settings menu that pops up when you click the Columns button. Your patch
removes the wording in both places.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 19:28:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 18:28:07 +0000
Subject: [Koha-bugs] [Bug 31513] NaN errors when using refund and payout
 with CurrencyFormat = FR
In-Reply-To: <bug-31513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31513-70-p8TXplywQ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31513

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 19:30:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 18:30:02 +0000
Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates
In-Reply-To: <bug-18273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18273-70-WDLYa3VwF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 19:30:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 18:30:08 +0000
Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates
In-Reply-To: <bug-18273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18273-70-5OQrYPfXEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61106|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 144213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144213&action=edit
Bug 18273: Do not insert authority if there already are duplicates in koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 19:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 18:30:44 +0000
Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly
 encoded (UNIMARC)
In-Reply-To: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32336-70-6dWErEheIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 19:36:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 18:36:26 +0000
Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates
In-Reply-To: <bug-18273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18273-70-sL6rzhDhia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
I think I managed to successfully rebase this one, but I'm not sure how to
test.

If we could get a test plan, I'll have a go at testing.

It would be great if the test plan could include:
- the bulkmarcimport command to use, and
- authority record samples to use to test the scenarios outlined in the bug
description (or how to create).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 19:49:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 18:49:16 +0000
Subject: [Koha-bugs] [Bug 32283] Capitalization: opac users of this domain
 to login with this identity provider
In-Reply-To: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32283-70-ymMPeP1JP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32283

--- Comment #10 from David Nind <david at davidnind.com> ---
(In reply to Andrew Auld from comment #9)
> I can fix those too. Should I do that under this bug? @David

Maybe better as a separate bug I think - as it is different from fixing the
capitalisation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 22:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 21:46:53 +0000
Subject: [Koha-bugs] [Bug 32322] Column settings menu should not include
 "select all |none" in label text for Check In column
In-Reply-To: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32322-70-CA5G5L5pYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
While I agree that it's confusing to see this in the column settings, I don't
think it can be removed from one but not the other place. What you see in the
"columns" list is build with JS from the table headings 1:1.

Maybe the select all | none could be moved somewhere else? Or wrapped into a
classs that is then hidden from the column listing?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 22:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 21:51:29 +0000
Subject: [Koha-bugs] [Bug 32337] System preference to block holds with
 debarments
In-Reply-To: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32337-70-sfXmV2TCf3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
May I make a slightly different suggestion?

In 22.11 you can define restrictions under Administration > patron
restrictions.
I think instead of a system preference, it would be great to have a 'can place
holds' flag in this table. 

This could be a first step to fully configurable patron restrictions (define
per restrictions which behavior it will block or not)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 22:52:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 21:52:24 +0000
Subject: [Koha-bugs] [Bug 32337] System preference to block holds with
 restrictions
In-Reply-To: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32337-70-MVRo5RxOqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|System preference to block  |System preference to block
                   |holds with debarments       |holds with restrictions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 23:03:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 22:03:22 +0000
Subject: [Koha-bugs] [Bug 32339] New: [Elasticsearch] Provide record when
 cataloguing biblios
Message-ID: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339

            Bug ID: 32339
           Summary: [Elasticsearch] Provide record when cataloguing
                    biblios
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When reindexing with elasticsearch, the record is passed for authorities but
not for biblios. This means that authorities are indexed as they are, while
biblios are pushed to a background job. These processes should be consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 23:08:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 22:08:57 +0000
Subject: [Koha-bugs] [Bug 32339] [Elasticsearch] Provide record when
 cataloguing biblios
In-Reply-To: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32339-70-6gOu1n55ID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 23:09:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 22:09:01 +0000
Subject: [Koha-bugs] [Bug 32339] [Elasticsearch] Provide record when
 cataloguing biblios
In-Reply-To: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32339-70-AgMmi6Z7l3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144214&action=edit
Bug 32339: Provide record when cataloguing biblios

To test:

1. Ensure you have Elasticsearch enabled and configured
2. Add a new record and confirm you can search for it straight after
saving, before and after applying the patch

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 23 23:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Nov 2022 22:10:12 +0000
Subject: [Koha-bugs] [Bug 32339] [Elasticsearch] Provide record when
 cataloguing biblios
In-Reply-To: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32339-70-h1YFe7WDpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 05:38:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 04:38:01 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-RAesg3xEO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #38 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
21.05.x doesn't seem affected.

Did I check right? from comment 20

>To test:
>1. Confirm you have/set value to syspref "itemcallnumber" e.g. 084a
>2. Find some item(s) to modify
>3. Provide barcodes of those item(s) and check checkbox "Use default values"
I picked items that already had barcodes and checked "Populate fields with
default values from default framework"
from sample data: 39999000012972 and 39999000012996
>4. Hit "Continue"
>=> error 500 is raised
No error. (no patches applied of course)


For now, unless I made a mistake in testing:
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 09:42:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 08:42:25 +0000
Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
 Use of uninitialized value in string eq
In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29898-70-G56f1BNwyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898

--- Comment #6 from Anke Bruns <anke.bruns at gwdg.de> ---
This bug is present also in 22.05, where the line in question is 675 instead of
663.

Could this be fixed for future versions, so we won't have to change Overdues.pm
manually after every update?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 10:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 09:09:14 +0000
Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
 Use of uninitialized value in string eq
In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29898-70-VhB3ud4R5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 10:16:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 09:16:07 +0000
Subject: [Koha-bugs] [Bug 32339] [Elasticsearch] Provide record when
 cataloguing biblios
In-Reply-To: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32339-70-nHCTFxAX2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure this is the right fix, as we are moving to background jobs
everywhere, maybe the indexing for the authorities should be changed instead?

Is there a visible difference here? My impression was that usually the single
jobs get handled immediately.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 12:30:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 11:30:57 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-BcgV4I0KW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

--- Comment #151 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Martin Renvoize from comment #150)
> I actually prefer your original approach if I'm honest.. it doesn't look to
> me like MessageAttribute has been much yet.. perhaps we could go the other
> way and keep the work here and update core to match?
> 
> tl;dr I like Koha::Patron::Message::Attribute(s) better than
> Koha::MessageAttribute(s).
> 
> I'll ask Tomas to weight in.

Has there been any decision on this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 12:34:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 11:34:01 +0000
Subject: [Koha-bugs] [Bug 32340] New: Several tests failing for
 t/db_dependent/Reserves.t
Message-ID: <bug-32340-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32340

            Bug ID: 32340
           Summary: Several tests failing for t/db_dependent/Reserves.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

Runnig prove t/db_dependent/Reserves.t gives following results on master:

t/db_dependent/Reserves.t .. 1/77 Failed to load
Koha::Plugin::Fi::KohaSuomi::OKMStats: Could not find or check module
'Koha::Plugin::Fi::KohaSuomi::OKMStats' at /home/emmi/Koha/Koha/Plugins.pm line
124.
t/db_dependent/Reserves.t .. 2/77 No reserves HOLD letter transported by print
at /home/emmi/Koha/C4/Letters.pm line 584.
Could not find a letter called 'HOLD' for print in the 'reserves' module at
/home/emmi/Koha/C4/Reserves.pm line 1915.
No reserves HOLD_CANCELLATION letter transported by email at
/home/emmi/Koha/C4/Letters.pm line 584.
No reserves HOLD letter transported by print at /home/emmi/Koha/C4/Letters.pm
line 584.
Could not find a letter called 'HOLD' for print in the 'reserves' module at
/home/emmi/Koha/C4/Reserves.pm line 1915.

#   Failed test 'patron notified when item set to waiting'
#   at t/db_dependent/Reserves.t line 416.
#          got: '0'
#     expected: '1'

#   Failed test 'patron not notified a second time (bug 11445)'
#   at t/db_dependent/Reserves.t line 421.
#          got: '0'
#     expected: '1'
No circulation HOLD_SLIP letter transported by email at
/home/emmi/Koha/C4/Letters.pm line 584.

#   Failed test 'can successfully generate hold slip (bug 10949)'
#   at t/db_dependent/Reserves.t line 433.
No reserves HOLD letter transported by print at /home/emmi/Koha/C4/Letters.pm
line 584.
Could not find a letter called 'HOLD' for print in the 'reserves' module at
/home/emmi/Koha/C4/Reserves.pm line 1915.
No reserves HOLD letter transported by print at /home/emmi/Koha/C4/Letters.pm
line 584.
Could not find a letter called 'HOLD' for print in the 'reserves' module at
/home/emmi/Koha/C4/Reserves.pm line 1915.
t/db_dependent/Reserves.t .. 41/77 No reserves HOLD letter transported by print
at /home/emmi/Koha/C4/Letters.pm line 584.
Could not find a letter called 'HOLD' for print in the 'reserves' module at
/home/emmi/Koha/C4/Reserves.pm line 1915.
t/db_dependent/Reserves.t .. 69/77 
    #   Failed test 'Item not available for item-level hold because no
effective item type'
    #   at t/db_dependent/Reserves.t line 1469.
    # Looks like you failed 1 test of 2.

#   Failed test 'IsAvailableForItemLevelRequest() tests'
#   at t/db_dependent/Reserves.t line 1475.
t/db_dependent/Reserves.t .. 75/77 # Looks like you failed 4 tests of 77.
t/db_dependent/Reserves.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/77 subtests 

Test Summary Report
-------------------
t/db_dependent/Reserves.t (Wstat: 1024 Tests: 77 Failed: 4)
  Failed tests:  26-27, 29, 73
  Non-zero exit status: 4
Files=1, Tests=77,  6 wallclock secs ( 0.03 usr  0.00 sys +  5.23 cusr  0.37
csys =  5.63 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 12:54:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 11:54:49 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-nQ5egr8T66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
First spec for this is that I feel we should make sure the required fields
match those listed in the csv import page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 12:55:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 11:55:01 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-Z8NLEEzQN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 13:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 12:30:53 +0000
Subject: [Koha-bugs] [Bug 32340] Several tests failing for
 t/db_dependent/Reserves.t
In-Reply-To: <bug-32340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32340-70-ByY5qfNryd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32340

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
So it seems I'm missing few notices from my test environment. I can understand
that tests assume that HOLD and HOLD_SLIP are present, they are included in
sample notices. But I can't find any traces of this HOLD_CANCELLATION notice,
are we missing it from sample_notices.yml?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 13:44:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 12:44:45 +0000
Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly
In-Reply-To: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32306-70-ROOvi4n7Kr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 144215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144215&action=edit
Bug 32306: Add unit tests

In ModReserves logging changes actually happens
before we store any of made changes.

To test:
1. Run prove t/db_dependent/Reserves.t
=> Tests should fail.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 13:45:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 12:45:27 +0000
Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly
In-Reply-To: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32306-70-qOpr8EOhBF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306

--- Comment #2 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 144216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144216&action=edit
Bug 32306: Log after storing changes in ModReserve

When one modifies holds from records holds page, these
changes don't log into action_logs table correctly.
Instead holds data before modifications is stored to action_logs.

This patch moves call for logaction after changes have
been stored in ModReserve.

To test:
1. Find hold to modify.
2. If possible, locate this hold from action_logs table:
SELECT * FROM action_logs WHERE module = "HOLDS" AND object = <reserve_id>;
3. Modify hold, change its pickup library from A to B.
4. Save changes.
5. Take a look at action_logs table.
=> Modification is saved, but holds pickup library is still A.
6. Modify hold again, e.g add expiration date.
7. Save.
8. Find this new modification from action_logs.
=> In action_logs table expiration date is empty, but pickup library is now B.
9. Apply this patch.
10. Modify hold, change its pickup library back from B to A.
11. Save changes.
=> In action_logs table holds modification has now a correct pickup library A.

Also prove t/db_dependent/Reserves.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:50:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:50:12 +0000
Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP
 checkin/checkout
In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25812-70-kysXB41s31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Display overdue fines for   |Fines can be displayed on
                   |the item on SIP checkin     |SIP checkin/checkout

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:54:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:54:17 +0000
Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP
 checkin/checkout
In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25812-70-DEwMxm0XFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139690|0                           |1
        is obsolete|                            |

--- Comment #8 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 144217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144217&action=edit
Bug 25812: Fines can be displayed on SIP checkin/checkout

This new patch adds the following:

 - rebased on master
 - adds a configuration option in SIPconfig.xml: show_outstanding_amount
 - extends the feature to SIP checkout
 - adds unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:54:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:54:37 +0000
Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP
 checkin/checkout
In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25812-70-B3cZ8oiqJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:57:18 +0000
Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP
 checkin/checkout
In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25812-70-eRutCnOHhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

--- Comment #9 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
I'm not sure if the status should be Signed Off or Needs Signoff, since Martin
has signed off before, but the feature has been extended to checkouts. Feel
free to change accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:59:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:59:07 +0000
Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed
 for GetMarcBiblio
In-Reply-To: <bug-29486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29486-70-kTDZGOi0vD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32332
                 CC|                            |magnus at libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:59:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:59:07 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-A4gKD65jSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29486

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 14:59:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 13:59:42 +0000
Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP
 checkin/checkout
In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25812-70-QAbE3Ov5wv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

--- Comment #10 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Also, not sure if show_outstanding_amount should be enabled or disabled by
default in SIPconfig.xml.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 17:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 16:14:43 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-wDBMX55fMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #76 from Blou <philippe.blouin at inlibro.com> ---
So, Signed Off or Failed QA ?
Seems the 9999 is still a valid test, per Cate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 17:27:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 16:27:55 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-DQwCVyvPB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

--- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144218&action=edit
Bug 31160: Required Fields in Patron API

The Patron API PUT request required the fields
"surname","address","city","library_id","category_id". Meanwhile the CSV import
page for patrons only requires "surname","library_id","category_id". The fields
for "address" and "city" have been removed from the "required" section of the
api>v1>swagger>definitions>patron.yaml file to match the CSV import page.

Test Plan:
1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty
body
2) Error message should ask for 5 missing fields as listed above
3) Apply patch
4) Restart Apache server using "restart_all" in your ktd shell
5) Resubmit your request
6) Error message should now only request "surname","library_id","category_id"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 17:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 16:56:45 +0000
Subject: [Koha-bugs] [Bug 26539] Inconsistent case sensitivity around patron
 attribute code - potential data loss
In-Reply-To: <bug-26539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26539-70-osguUxDLLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:18:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:18:16 +0000
Subject: [Koha-bugs] [Bug 32333] IdRef system preference revamping
In-Reply-To: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32333-70-NqVIUjGSRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32333

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
           Assignee|oleonard at myacpl.org         |frederic at tamil.fr

--- Comment #2 from David Nind <david at davidnind.com> ---
Changed assignee.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:23:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:23:19 +0000
Subject: [Koha-bugs] [Bug 32322] Column settings menu should not include
 "select all |none" in label text for Check In column
In-Reply-To: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32322-70-QWE07hrjWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jacob.omara at ptfs-europe.com
                   |ity.org                     |
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Changed assignee.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:28:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:28:06 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-ve5YOQbQOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
 Attachment #144147|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:28:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:28:22 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-k4N2KNucsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144164|0                           |1
        is obsolete|                            |
 Attachment #144164|0                           |1
           is patch|                            |
 Attachment #144164|application/mbox            |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:37:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:37:38 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-aQoLHFucBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:37:41 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-YoUUxpcuo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144147|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:38:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:38:42 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-SRRzvSQcQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144219&action=edit
Bug 32310: Correct CSS in the staff interface which still uses old color scheme

This patch updates staff interface CSS so that it better conforms to the
color scheme of the updated staff interface.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Tools -> Calendar. Corrected are the borders around the calendar
  and around the "Add new holiday" panel which appears when you click a
  date on the calendar.
- Go to Patrons and perform a search which will return multiple results.
  - Check the checkbox for some patrons. The color of the "Patrons
    selected" box have been updated.
  - Incorrect padding values have also been removed from the adjacent
    patron list and merge buttons.
- Locate a multi-paged DataTable, e.g. Administration -> Authorized
  values. The style of the "Next" and "Previous" buttons have been
  updated.
- View a patron record and choose More -> Set permissions from the
  toolbar. In the table of permissions, when you hover your mouse over
  one of the headings ("Check out and check in items," "Edit
  authorities," etc.) the color should be correct.
- I don't think this is ever visible in the staff interface, but the
  template has markup in it to display a "Log in" link in the header
  menu if the user isn't logged in. I've removed some redundant CSS
  corresponding to this link and corrected some markup just in case
  there is a situation in which is appears.

Signed-off-by: Amit Gupta <amitddng135 at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 19:54:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 18:54:54 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-qswTIbsDHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #132 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Tomas, did you miss these?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:00:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:00:31 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-buZ8BNWG2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:00:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:00:42 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-URo1ejKawX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:00:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:00:54 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-77KV9O2UPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:01:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:01:23 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-KpDuvT3roT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #133 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Last 3 commits haven't been pushed yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:02:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:02:00 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-qBUHtMpYS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:02:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:02:06 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-xnxcMr7NPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144142|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 144220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144220&action=edit
Bug 32307: Fix gallery when Coce is enabled

Bug 28179 added the gallery in the staff interface, and bug 28180 in the
OPAC.

OPAC and staff have different code, because the cover image providers
are different.
On bug 28180 we noticed that the OPAC needed additional code to handle
OpenLibrary, Google Jacket and Coce, to differ the creation of the
gallery to prevent Chocolat to be instantiated before the links (img src)
are effectively in the DOM.

To acchieve that we introduced a wait_for_images function, and added a
"done" flag to the 3 "JS modules".

However we haven't ported this code for the staff interface, which is
also using Coce.

Note that there was a bug at the OPAC as well for COCE, the ajax jQuery
function is async, and so 'done' was set even if the call was not
finished.

Test plan:
0. Do not apply this patch
1. Enable LocalCoverImages and IntranetCoce
2. Pick a bibliographic record with an image returned from Coce
3. Add a local cover image
4. Go to the detail page
5. Open the gallery
=> Notice that you can notice a JS error and a loading icon on the
second image. This behaviour is not always broken, it depends on the
speed of the Coce server. If you don't see the problem reload the page.
6. Apply the patch and repeat
=> Notice that the cover slider block is longer to display the icon, but
that the error is gone.
7. Confirm that there is no regression at the OPAC

We could improve the situation here, and we could display the images
in the slider, especially if the first image is a local image. But
that's for another bug...

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:02:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:02:41 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-6FGEsTrJGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
I've signed off. I think I managed to test this correctly - it took a while for
the Coce images to appear (I used https://coce.bywatersolutions.com).

Just noting the behaviour for the OPAC (which is different from the staff
interface) where there are multiple cover image sources:

- For the staff interface search results (with both LocalCoverImages and
IntranetCoce enabled), you can switch between the two images using the coloured
dots (where a record has both a local image and an image from Coce).

- For the OPAC search results (with both LocalCoverImages and OpacCoce enabled)
there are two images displayed side-by-side. Where there is no local cover
image, the generic "No cover image available" is displayed as well as the Coce
image.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 20:57:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 19:57:41 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-WpuC4VJGbp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

--- Comment #134 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Follow-ups have been pushed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:07:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:07:14 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-IcLd2usfyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds a third option
      release notes|                            |'enforce' to the
                   |                            |TwoFactorAuthentication
                   |                            |system preference. If
                   |                            |chosen, staff will no
                   |                            |longer be able to log into
                   |                            |the staff client without
                   |                            |setting up and using
                   |                            |2-factor authentication.
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:11:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:11:09 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-xAf3kMySoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This feature allows for     |This feature allows for
      release notes|libraries to group items    |libraries to group items
                   |within a record.  A new     |within a record.  A new
                   |system preference has been  |system preference has been
                   |added for this feature,     |added for this feature,
                   |EnableItemGroups.  This     |EnableItemGroups. This
                   |system preference once      |system preference, once
                   |enabled will allow the      |enabled, will allow the
                   |library to group specific   |library to group specific
                   |items on a record to each   |items on a record to each
                   |other. A library can name   |other. A library can name
                   |the group and add items     |the group and add items
                   |from the same record to     |from the same record to
                   |this group.  From the       |this group. From the
                   |record, a new tab will      |record, a new tab will
                   |appear and display on that  |appear and display on that
                   |item if it is part of a     |item if it is part of a
                   |group.                      |group.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:22:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:22:13 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-DSOpBM0JLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |With this feature you can
      release notes|                            |now place holds on groups
                   |                            |of items. A group consists
                   |                            |of multiple items of the
                   |                            |same record, representing
                   |                            |for example, all items of a
                   |                            |specific volume. When a
                   |                            |hold for an item group is
                   |                            |placed, only items of the
                   |                            |requested group will be
                   |                            |able to fill the hold.
                   |                            |The
                   |                            |feature is enabled using
                   |                            |the new
                   |                            |EnableItemGroupHolds system
                   |                            |preference. It also
                   |                            |requires EnableItemGroups
                   |                            |for managing item groups.
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:35:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:35:38 +0000
Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-52ddgTXynI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds a new
      release notes|                            |configuration page for
                   |                            |managing user defined and
                   |                            |Koha internal patron
                   |                            |restrictions to the
                   |                            |administration module.
                   |                            |
                   |                            |If
                   |                            |the new system preference
                   |                            |PatronRestrictionTypes is
                   |                            |enabled, you will also be
                   |                            |able to choose the
                   |                            |restriction type when
                   |                            |manually restricting a
                   |                            |patron.
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:37:41 +0000
Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails
 for Koha to MARC mapping using biblio table
In-Reply-To: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31239-70-1CCvMQV5ie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:50:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:50:51 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-vI2lnOGalS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |With this module staff and
      release notes|                            |patrons will be available
                   |                            |to manage curbside pickups
                   |                            |from the OPAC and staff
                   |                            |interface.
                   |                            |It adds a new
                   |                            |configuration page to the
                   |                            |administration module which
                   |                            |allows each library in an
                   |                            |installation to set their
                   |                            |own rules and time slots
                   |                            |for scheduling pickups.
                   |                            |If
                   |                            |a library chooses to
                   |                            |activate curbside pickups,
                   |                            |they will be able to manage
                   |                            |all stages to the process
                   |                            |from within Koha:
                   |                            |scheduling a pickup time,
                   |                            |preparing items for pickup
                   |                            |and completing pickups.
                   |                            |Patrons can indicate that
                   |                            |they have arrived at the
                   |                            |library for their pickup
                   |                            |through the OPAC.
                   |                            |Use the
                   |                            |CurbsidePickup system
                   |                            |preference to enable this
                   |                            |module.
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:51:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:51:02 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-HxTdcmPAso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18532
                 CC|                            |victor at tuxayo.net

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
I guess this depends on bug 18532


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532
[Bug 18532] Messaging preferences for auto renewals
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:51:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:51:02 +0000
Subject: [Koha-bugs] [Bug 18532] Messaging preferences for auto renewals
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-7pa36iOJ2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28553


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553
[Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha
does not generate them
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:51:37 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-D0Czig7kOF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
         Version(s)|22.11.00, 22.05.07,         |22.11.00, 22.05.07,
        released in|21.11.14                    |21.11.14, 21.05.21

--- Comment #17 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for the upcoming release (21.05.21)
Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:51:37 +0000
Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only
 generated if patron is also set to receive email
In-Reply-To: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30355-70-YOO0gUJLHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355
Bug 30355 depends on bug 28553, which changed state.

Bug 28553 Summary: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:52:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:52:52 +0000
Subject: [Koha-bugs] [Bug 31558] Upgrade of TinyMCE broke image drag and drop
In-Reply-To: <bug-31558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31558-70-1lxFQkc7rx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31558

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:53:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:53:43 +0000
Subject: [Koha-bugs] [Bug 31299] Duplicate output in
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-31299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31299-70-8yynsWJu1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:54:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:54:05 +0000
Subject: [Koha-bugs] [Bug 31531] Some modules loaded twice in
 opac-memberentry.pl
In-Reply-To: <bug-31531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31531-70-8mrps4WrDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31531

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:54:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:54:09 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-ei0QzTfhX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement utilises   |This enhancement utilises
      release notes|the Additional Contents     |the additional contents
                   |feature to add custom pages |feature to add custom pages
                   |to the staff interface and  |to the staff interface and
                   |the OPAC in the user's      |the OPAC in the user's
                   |desired language.           |desired language.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:54:44 +0000
Subject: [Koha-bugs] [Bug 31342] process_message_queue can run over the top
 of itself causing double-up emails
In-Reply-To: <bug-31342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31342-70-DX5vSKo3NH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31342

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:54:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:54:58 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-HZJzVyC5kG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement allows you |This enhancement allows you
      release notes|to specify an estimated     |to specify an estimated
                   |delivery date per order.    |delivery date per order
                   |The specified estimated     |line. The specified
                   |delivery date is also       |estimated delivery date is
                   |considered (alongside the   |also considered (alongside
                   |calculated estimated        |the calculated estimated
                   |delivery date, if no date   |delivery date, if no date
                   |has been specified) when    |has been specified) when
                   |searching for late orders   |searching for late orders
                   |and exporting late orders.  |and exporting late orders.
                   |You can also edit the       |You can also edit the
                   |estimated delivery date     |estimated delivery date
                   |from the late orders page.  |from the late orders page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:55:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:55:52 +0000
Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive
 page
In-Reply-To: <bug-30359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30359-70-fnTeMBaDIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:55:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:55:53 +0000
Subject: [Koha-bugs] [Bug 31459] Make order receive page faster on systems
 with many budgets
In-Reply-To: <bug-31459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31459-70-S828azp19x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459
Bug 31459 depends on bug 30359, which changed state.

Bug 30359 Summary: GetBudgetHierarchy is slow on order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:56:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:56:43 +0000
Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt
In-Reply-To: <bug-25763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25763-70-59RiH9mjYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |This allows to update the
        released in|                            |fund of an order line from
                   |                            |the invoices page. As
                   |                            |different funds might be
                   |                            |linked to different
                   |                            |authorized values for
                   |                            |statistical purposes, the
                   |                            |statistics fields can also
                   |                            |be updated in the same
                   |                            |step.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 21:57:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 20:57:59 +0000
Subject: [Koha-bugs] [Bug 27817] Enhance display of title information
 throughout acquisitions
In-Reply-To: <bug-27817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27817-70-JnD8zZAhOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds remainder of
      release notes|                            |title/subtitle, medium,
                   |                            |part name, and part number
                   |                            |to several pages in the
                   |                            |acquisitions module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:00:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:00:32 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-SNl9nk0u1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds ISSN as a new
      release notes|                            |search option to the
                   |                            |acquisitions advanced
                   |                            |search form. If
                   |                            |SearchWithISSNVariations is
                   |                            |enabled, you'll be able to
                   |                            |search for the ISSN with
                   |                            |and without the hyphen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:00:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:00:38 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-J5eYwj6NlE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:02:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:02:48 +0000
Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a
 basket as PDF
In-Reply-To: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31257-70-iML8tksvS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds a new
      release notes|                            |English 1 page layout to be
                   |                            |used when exporting a
                   |                            |basket group as PDF. It can
                   |                            |be selected as a new
                   |                            |option from the
                   |                            |OrderPdfFormat system
                   |                            |preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:04:37 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-W8WuALm2Kf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:08:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:08:34 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-II8MGTenZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement adds a     |This enhancement adds a
      release notes|modal to display checkout   |modal to display checkout
                   |renewal history details.    |renewal history details
                   |                            |where appropriate. This
                   |                            |includes the circulation
                   |                            |history and the items tab
                   |                            |of the staff detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:09:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:09:24 +0000
Subject: [Koha-bugs] [Bug 30684] koha-* scripts --restart should start even
 when not running
In-Reply-To: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30684-70-fI2AwqObfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Command-line Utilities
                   |and plumbing                |
                 CC|                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:11:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:11:58 +0000
Subject: [Koha-bugs] [Bug 23063] Item table in cataloguing doesn't respect
 CurrencyFormat
In-Reply-To: <bug-23063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23063-70-t5iiEszUhJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This makes sure that the
      release notes|                            |price and replacement price
                   |                            |of an item is displayed
                   |                            |according to the
                   |                            |CurrencyFormat setting in
                   |                            |the items table above the
                   |                            |add/edit item form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:13:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:13:35 +0000
Subject: [Koha-bugs] [Bug 31781] Transferred items table
 (branchtransfers.tt) needs page-section class
In-Reply-To: <bug-31781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31781-70-r1ZxnpJeoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31781

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:15:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:15:00 +0000
Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for
 non-waiting holds
In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14783-70-ByGG8WuQD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:16:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:16:25 +0000
Subject: [Koha-bugs] [Bug 31948] Add timestamp to tmp_holdsqueue
In-Reply-To: <bug-31948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31948-70-GGjNfkKQJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31948

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |
  Text to go in the|                            |This adds a timestamp
      release notes|                            |column to the
                   |                            |tmp_holdsqueue table that
                   |                            |the holds queue in
                   |                            |circulation is built from.
                   |                            |With RealTimeHoldsQueue
                   |                            |this will enable reporting
                   |                            |on the date and time an
                   |                            |entry was added to the
                   |                            |holds queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:19:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:19:37 +0000
Subject: [Koha-bugs] [Bug 31715] Add missing German translations for
 language descriptions
In-Reply-To: <bug-31715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31715-70-pURCSnVqEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds the missing
      release notes|                            |German translations for
                   |                            |languages, as seen in the
                   |                            |language list on the
                   |                            |advanced search in staff
                   |                            |interface and OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:23:32 +0000
Subject: [Koha-bugs] [Bug 31894] Extend hold hooks with more actions
In-Reply-To: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31894-70-ULVABNaDdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31894

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds three more
      release notes|                            |hooks to the existing
                   |                            |"after_hold_action",
                   |                            |extending it to handle the
                   |                            |different found values.
                   |                            |
                   |                            |*
                   |                            |"transfer" when a hold
                   |                            |calls "set_transfer()"
                   |                            |(found=T)
                   |                            |* "waiting" when
                   |                            |a hold calls
                   |                            |"set_waiting()" (found=W)
                   |                            |*
                   |                            |"processing" when a hold
                   |                            |calls "set_processing()"
                   |                            |(found=P)
            Summary|Extend Hold hooks with more |Extend hold hooks with more
                   |actions                     |actions
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:24:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:24:23 +0000
Subject: [Koha-bugs] [Bug 31895] New Account hook when adding credit
In-Reply-To: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31895-70-hBVBSzJWdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch adds a new hook
      release notes|                            |"after_account_action" with
                   |                            |the action "add_credit".
                   |                            |This is triggered when a
                   |                            |credit is added via for
                   |                            |example PAYMENT or
                   |                            |WRITEOFF.
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:24:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:24:53 +0000
Subject: [Koha-bugs] [Bug 31895] New account hook when adding credit
In-Reply-To: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31895-70-a8pqgy57Cq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|New Account hook when       |New account hook when
                   |adding credit               |adding credit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:25:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:25:10 +0000
Subject: [Koha-bugs] [Bug 32341] New: OPAC - Mobile - Items table columns
 are too thin
Message-ID: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

            Bug ID: 32341
           Summary: OPAC - Mobile - Items table columns are too thin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: hammat.wele at inlibro.com
          Reporter: hammat.wele at inlibro.com
        QA Contact: hammat.wele at inlibro.com

The bibliographic display of a record in the OPAC on mobile is not correct

This patch fix this problem by making the table responsive 

To test:
      1- Go to the OPAC
      2- Open mobile mode
      3- Go to a bibliographic record detail page in the OPAC
(opac-detail.pl?biblionumber=X)
      4- Check the Holdings table 
            --> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
            --> we see very narrow columns
            --> unreadable text

      5- Apply the patch and perform previous step (1-4). 
      6- Confirm that the table are displayed correctly and is now responsive

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:25:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:25:19 +0000
Subject: [Koha-bugs] [Bug 31896] New recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-kdG9aAkaYa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|New Recall hook when adding |New recall hook when adding
                   |recall                      |recall
  Text to go in the|                            |This adds a new hook
      release notes|                            |"after_recall_action" with
                   |                            |the action "add".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:25:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:25:22 +0000
Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM)
In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32030-70-mzx4VsE7Kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This new module adds a
      release notes|                            |mechanism to track the
                   |                            |selection, acquisition,
                   |                            |licensing, access,
                   |                            |maintenance, usage,
                   |                            |evaluation, retention, and
                   |                            |de-selection of a library’s
                   |                            |electronic information
                   |                            |resources. These resources
                   |                            |include, but are not
                   |                            |limited to, electronic
                   |                            |journals, electronic books,
                   |                            |streaming media, databases,
                   |                            |datasets, CD-ROMs, and
                   |                            |computer software.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:25:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:25:26 +0000
Subject: [Koha-bugs] [Bug 31896] New recall hook when adding recall
In-Reply-To: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31896-70-kEFe9MJbap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:37:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:37:16 +0000
Subject: [Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961
 (300 shown) .
In-Reply-To: <bug-29312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29312-70-ShRGA9dj2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:38:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:38:02 +0000
Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
 staff interface
In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27546-70-oQuJzNEe2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:38:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:38:27 +0000
Subject: [Koha-bugs] [Bug 31537] Elasticsearch - index mapping for 003
 control-number-identifier is twice in mappings.yaml
In-Reply-To: <bug-31537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31537-70-5AfADTK31X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31537

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:40:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:40:27 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-jSGHLy4RFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement brings     |This enhancement brings
      release notes|more order the cataloguing  |more order to the
                   |features.
                  |cataloguing features. We
                   |
                           |create a new 'Cataloguing'
                   |We create a new             |module home page and
                   |'Cataloguing' module home   |collect the cataloguing
                   |page and collect the        |tools into it.
                   |cataloguing tools into it.  |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:40:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:40:41 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-PJtEZqPHFF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:40:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:40:58 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-y8bQe9S2vC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:41:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:41:38 +0000
Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips
In-Reply-To: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31714-70-bMQH3ut0RP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Notices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:42:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:42:15 +0000
Subject: [Koha-bugs] [Bug 31333] Add the ability to limit purchase
 suggestions by patron category
In-Reply-To: <bug-31333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31333-70-nF1YiMuR8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|System Administration       |Acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:42:38 +0000
Subject: [Koha-bugs] [Bug 31490] Terminology: change "staff client" to
 "staff interface" in marc-overlay-rules
In-Reply-To: <bug-31490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31490-70-8u5ccBKk4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31490

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|System Administration       |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:46:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:46:51 +0000
Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
 staff interface
In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27546-70-i12Aqfddnn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
  Text to go in the|                            |This enhancement adds a new
      release notes|                            |input above the search
                   |                            |results allowing one to
                   |                            |search within the results.
                   |                            |The search
                   |                            |box will take a
                   |                            |query and add it as a limit
                   |                            |to the previous search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:53:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:53:11 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-UQQt1Dn3yn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed
  Text to go in the|                            |This allows Koha to
      release notes|                            |remember the changes a user
                   |                            |has made to the columns
                   |                            |settings on a page so they
                   |                            |are kept when reloading the
                   |                            |page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:53:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:53:18 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-hcX6OK81YI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:54:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:54:56 +0000
Subject: [Koha-bugs] [Bug 31780] Add 'page-section' to audio alerts (
 audio_alerts.tt )
In-Reply-To: <bug-31780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31780-70-lkjZWzM49R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31780

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tools                       |Staff interface
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:55:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:55:41 +0000
Subject: [Koha-bugs] [Bug 32339] [Elasticsearch] Provide record when
 cataloguing biblios
In-Reply-To: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32339-70-heDYsd7vnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32339

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Also agree it might not be the best solution, I guess it might just be a
workaround. The real problem for us is background jobs, they keep getting stuck
at New and I found it was the queuing of the background job that meant records
weren't getting indexed. We can cancel this if the ideal is that $record is
never passed like it is for authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 22:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 21:57:18 +0000
Subject: [Koha-bugs] [Bug 31587] Basket not accessible from ACQORDER notice
In-Reply-To: <bug-31587-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31587-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31587-70-Bh4kY2LzYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31587

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This makes sure that the
      release notes|                            |basket object is passed to
                   |                            |the ACQORDER notice in
                   |                            |order to allow adding
                   |                            |information about the
                   |                            |basket and the order lines
                   |                            |within it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:01:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:01:15 +0000
Subject: [Koha-bugs] [Bug 27920] Add ability to update patron expiration
 dates when importing patrons
In-Reply-To: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27920-70-BvFF3l9qKx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds a new option to
      release notes|                            |the patron import from that
                   |                            |allows to use the
                   |                            |expiration date from the
                   |                            |import file or recalculate
                   |                            |the patron's expiration
                   |                            |date using today's date or
                   |                            |the original expiration
                   |                            |date as base.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:02:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:02:09 +0000
Subject: [Koha-bugs] [Bug 6936] Allow to limit on multiple itemtypes when
 exporting bibliographic records
In-Reply-To: <bug-6936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6936-70-pxudP7fNL8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This allows multiple item
      release notes|                            |types to be chosen when
                   |                            |exporting
                   |                            |bibliographic
                   |                            |records from the export
                   |                            |catalog tool.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:03:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:03:19 +0000
Subject: [Koha-bugs] [Bug 31969] Options for cleanup_database.pl to remove
 finished jobs from the background job queue
In-Reply-To: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31969-70-aMSJG5s3XI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|System Administration       |Command-line Utilities
                 CC|                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:03:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:03:54 +0000
Subject: [Koha-bugs] [Bug 31289] Hide article requests column in circulation
 rules when ArticleRequests syspref is disabled
In-Reply-To: <bug-31289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31289-70-4UyLxqkEdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Hide Article requests       |Hide article requests
                   |column in circulation rules |column in circulation rules
                   |when ArticleRequests        |when ArticleRequests
                   |syspref is disabled         |syspref is disabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:04:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:04:57 +0000
Subject: [Koha-bugs] [Bug 30462] Should the background job list view hide
 index tasks by default?
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-y5n22xPvEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:07:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:07:16 +0000
Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines
In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31713-70-bHVnutbix7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
  Text to go in the|                            |Adds the option to print an
      release notes|                            |accounts summary from the
                   |                            |print pull down in the
                   |                            |patron's account in the
                   |                            |staff interface. This uses
                   |                            |the new notice
                   |                            |ACCOUNTS_SUMMARY.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:08:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:08:36 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-webJTk995U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #399 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's a big change I'd like to highlight as a new feature with some nice release
notes. Help?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:11:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:11:46 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-ImHwA16muI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |With the new system
      release notes|                            |preference
                   |                            |IntranetCatalogSearchPulldo
                   |                            |wn enabled, you will be
                   |                            |able to limit your simple
                   |                            |searches in the staff
                   |                            |interface by library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:12:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:12:30 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-M1NCsvqesz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:13:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:13:28 +0000
Subject: [Koha-bugs] [Bug 31296] Add ability to disable demagnetizing items
 via SIP2 based on itemtypes
In-Reply-To: <bug-31296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31296-70-paEUYwDSIP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31296

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:13:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:13:33 +0000
Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via
 SIP using Template Toolkit
In-Reply-To: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31236-70-f0yIeohERq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:13:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:13:41 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-M9MiYvNFpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:14:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:14:12 +0000
Subject: [Koha-bugs] [Bug 31597] Missing semicolon after try-catch in
 restrictions.pl
In-Reply-To: <bug-31597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31597-70-rUqPEPikJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31597

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:17:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:17:05 +0000
Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new
 patrons added at first login via LDAP/SAML
In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30646-70-oV23yYht48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |When LDAP or Shibboleth are
      release notes|                            |used to create user
                   |                            |accounts on first login,
                   |                            |the WELCOME notice can be
                   |                            |send automatically to the
                   |                            |new users. This requires
                   |                            |adding the new
                   |                            |configuration option
                   |                            |<welcome>1</welcome> to the
                   |                            |respective configuration
                   |                            |files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:17:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:17:30 +0000
Subject: [Koha-bugs] [Bug 32341] OPAC - Mobile - Items table columns are too
 thin
In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32341-70-IB0vOVt6a6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

--- Comment #1 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144221&action=edit
The bibliographic display of a record in the opac on a mobile is not correct
Items table columns are too thin

This patch fix this problem by making the table responsive

To test:
      1- Go to the OPAC
      2- Open mobile mode
      3- Go to a bibliographic record detail page in the OPAC
(opac-detail.pl?biblionumber=X)
      4- Check the Holdings table
            --> the information is not presented in a table as it is when
viewing on a laptop or PC browser screen.
            --> we see very narrow columns
            --> unreadable text

      5- Apply the patch and perform previous step (1-4).
      6- Confirm that the table are displayed correctly and responsive

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:20:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:20:11 +0000
Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
In-Reply-To: <bug-10950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10950-70-ubgm452c2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
  Text to go in the|                            |This adds a new free text
      release notes|                            |field 'pronouns' to the
                   |                            |patron record. The pronouns
                   |                            |also display prominently in
                   |                            |the brief patron
                   |                            |information section on the
                   |                            |left side of the patron
                   |                            |account pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:23:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:23:03 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-1MZY04u2T3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This adds a new free text
      release notes|                            |field 'Middle name' to the
                   |                            |patron record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Nov 24 23:23:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 22:23:18 +0000
Subject: [Koha-bugs] [Bug 21366] Add Plack reload
In-Reply-To: <bug-21366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21366-70-8b7T18AeUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 00:45:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 23:45:18 +0000
Subject: [Koha-bugs] [Bug 32341] OPAC - Mobile - Items table columns are too
 thin
In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32341-70-jn6PKf6X5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 00:45:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Nov 2022 23:45:58 +0000
Subject: [Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new
 patrons added at first login via LDAP/SAML
In-Reply-To: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30646-70-Yp5cg3LUzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 01:05:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 00:05:17 +0000
Subject: [Koha-bugs] [Bug 31497] Quick add: mandatory fields save as empty
 when not filled in before first save attempt
In-Reply-To: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31497-70-Q6LEkaZOoW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
21.05.x not affected, no backport.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 01:07:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 00:07:25 +0000
Subject: [Koha-bugs] [Bug 31598] Fix random failure on Jenkins for
 t/db_dependent/Upload.t
In-Reply-To: <bug-31598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31598-70-zEo8sDWBkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31598

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 01:08:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 00:08:35 +0000
Subject: [Koha-bugs] [Bug 30890] ILL breadcrumbs are wrong
In-Reply-To: <bug-30890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30890-70-ObL3gI9Vfa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30890

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 01:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 00:09:31 +0000
Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use
 in intranet and UseCashRegisters is disabled
In-Reply-To: <bug-28167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28167-70-3asCKgQZom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 01:09:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 00:09:32 +0000
Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed
In-Reply-To: <bug-27126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27126-70-HzDAdPpYcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126
Bug 27126 depends on bug 28167, which changed state.

Bug 28167 Summary: A warning when setting which library to use in intranet and UseCashRegisters is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 01:10:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 00:10:38 +0000
Subject: [Koha-bugs] [Bug 31564] Pass start label when exporting single
 label as PDF
In-Reply-To: <bug-31564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31564-70-DfeRCCCjjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31564

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:07:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:07:59 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-eZPxDf5gpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144222&action=edit
Bug 32307: (follow-up) Fix gallery when Coce is enabled

Yet another fix, this is porting the following change to the intranet:
  commit 1916c644808577beb3170d642f93b456bfcc5c56
  Bug 28180: Fix bug with first image does not exist

To recreate the problem:
Enable Coce
Go to biblionmber=5 detail
=> No image (but one is displayed on the search result)
Add a local cover image
=> Only the local cover image is displayed
Apply this patch
=> Both images are displayed
Remove the local cover image
=> Image from coce is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:09:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:09:00 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-wVbubaL9sU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Thanks for your time, David!

Did you notice that this patch was for the detail page?

Reading your comment I realised I didn't test the search result, and... found a
bug on the detail page! Added another patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:18:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:18:23 +0000
Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
In-Reply-To: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12285-70-ZKEc2kBCeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285

--- Comment #52 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Katrin Fischer from comment #51)
> Hi Emmi, bug 31713 has been pushed now. I think it makes this probably a
> duplicate, but could you have a look if it covers all your requirements?
> 
> *** This bug has been marked as a duplicate of bug 31713 ***

I'm gonna ask one our librarians to test this next week, they have better
understanding if something is missing :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:26:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:26:26 +0000
Subject: [Koha-bugs] [Bug 32343] New: Koha/Patron.t is failing randomly
Message-ID: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

            Bug ID: 32343
           Summary: Koha/Patron.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

t/db_dependent/Koha/Patron.t ..                                                 
        #   Failed test 'Exception thrown on unique attribute'                  
        #   at t/db_dependent/Koha/Patron.t line 251.                           
        # expecting: Koha::Exceptions::Patron::Attribute::UniqueIDConstraint    
        # found: normal exit                                                    

        #   Failed test 'Extended attributes storing rolled back'               
        #   at t/db_dependent/Koha/Patron.t line 255.                           
        #          got: '2'                                                     
        #     expected: '0'                                                     
        # Looks like you failed 2 tests of 5.                                   

    #   Failed test 'unique attributes tests'                                   
    #   at t/db_dependent/Koha/Patron.t line 259.                               
    # Looks like you failed 1 test of 16.                                       
t/db_dependent/Koha/Patron.t .. 1/1                                             
#   Failed test 'extended_attributes'                                           
#   at t/db_dependent/Koha/Patron.t line 393.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:27:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:27:50 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-obMLByXJmk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:27:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:27:56 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-2O08BEgjrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144223&action=edit
Bug 32343: Prevent Koha/Patron.t to fail randomly

Highlighted by Bug 32030: fix test builder for boolean

The attribute is named "unique_id", not "unique"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:28:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:28:22 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-vs6U4UUNfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:28:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:28:32 +0000
Subject: [Koha-bugs] [Bug 32269] Circulation.t is failing randomly
In-Reply-To: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32269-70-85GHOhOV1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:28:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:28:39 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-Ubse2mYXLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
             Blocks|                            |25551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:28:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:28:39 +0000
Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25551-70-EEua9ORsaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32343


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343
[Bug 32343] Koha/Patron.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:28:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:28:51 +0000
Subject: [Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly
In-Reply-To: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32268-70-5ZbT9Wv7xW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:30:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:30:38 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-hdtWDQzSYv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Emmi Takkinen from comment #31)
> (In reply to Jonathan Druart from comment #30)
> > Yes, all the subtest actually. Which IDE do you use?
> > 
> > If vi, you can:
> > 1. install perltidy
> > 2. Define a vmap on F8 (or whatever) in your .vimrc
> >   vmap <F8> :!perltidy -q<CR>
> > 3. Open a new vi instance, select text in visual mode, press F8
> 
> Thanks, this worked fine. I was able to fix tests and perltidy them, should
> I just at the patch here or should I make a new bug?

It's too late, but keep it in mind for your next patches.

For the test a follow-up here should be fine, but it's release today so that
should be discussed with Tomas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:48:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:48:19 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-7rVKD5Q1JI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:50:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:50:55 +0000
Subject: [Koha-bugs] [Bug 32332] bulkmarcimport.pl -insert fails to add MARC
 field 999
In-Reply-To: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32332-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32332-70-N8c4PKX3pE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32332

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am not familiar with this script, but I am wondering: should not we skip to
the next record way before we reach those lines?

Maybe we need a "next" in the "search for a match" block?

iff --git a/misc/migration_tools/bulkmarcimport.pl
b/misc/migration_tools/bulkmarcimport.pl
index d2dfe1ad56a..45a7c94e39c 100755
--- a/misc/migration_tools/bulkmarcimport.pl
+++ b/misc/migration_tools/bulkmarcimport.pl
@@ -349,6 +349,7 @@ RECORD: while (  ) {
                     next;
                 }
             }
+            next if $insert;
         } elsif ( $results && scalar(@$results) > 1 ) {
             $logger->debug("more than one match for $query");
         } else {

But not knowing much this script it's hard to tell if it won't introduce
regressions.

Or, another option, more inline with your diagnostic, could be to 

 diff --git a/misc/migration_tools/bulkmarcimport.pl
b/misc/migration_tools/bulkmarcimport.pl
index d2dfe1ad56a..e95b1fa199e 100755
--- a/misc/migration_tools/bulkmarcimport.pl
+++ b/misc/migration_tools/bulkmarcimport.pl
@@ -480,7 +480,7 @@ RECORD: while (  ) {
             C4::Biblio::_strip_item_fields($clone_record, '');
             # This sets the marc fields if there was an error, and also calls
             # defer_marc_save.
-            ModBiblioMarc( $clone_record, $biblionumber );
+            ModBiblioMarc( $clone_record, $biblionumber ) if $insert;
             if ( $error_adding ) {
                 warn "ERROR: Adding items to bib $biblionumber failed:
$error_adding";
                                printlog({id=>$id||$originalid||$biblionumber,
op=>"insertitem",status=>"ERROR"}) if ($logfile);

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:51:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:51:52 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-jmcrVWYKxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This is the result of a
      release notes|                            |wide scale review of the
                   |                            |staff interface user
                   |                            |experience.
                   |                            |
                   |                            |A team of
                   |                            |librarians, designers and
                   |                            |developers has worked hard
                   |                            |to refresh, modernize and
                   |                            |increase consistency in the
                   |                            |staff interface.
                   |                            |
                   |                            |We hope
                   |                            |you like the fresh new look
                   |                            |and feel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 07:55:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 06:55:12 +0000
Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips
In-Reply-To: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31714-70-ONopib3NIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This is a first step
      release notes|                            |towards drying out our slip
                   |                            |printing code.  We add a
                   |                            |new, modern, controller
                   |                            |script that accepts any
                   |                            |notice template to be
                   |                            |passed to it for printing.
                   |                            |
                   |                            |Next steps would be to
                   |                            |start migrating some of the
                   |                            |old slips to use this
                   |                            |controller and drop their
                   |                            |respective controller
                   |                            |scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:01:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:01:03 +0000
Subject: [Koha-bugs] [Bug 32344] New: Migrate print_overdues.pl to
 printnotice.pl
Message-ID: <bug-32344-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32344

            Bug ID: 32344
           Summary: Migrate print_overdues.pl to printnotice.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

A more generic modern print script was introduced in bug 31714. 

We should be able to use that here and remove this bear duplicate controller.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:01:22 +0000
Subject: [Koha-bugs] [Bug 32344] Migrate print_overdues.pl to printnotice.pl
In-Reply-To: <bug-32344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32344-70-3sxMzMygBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32344

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31714


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714
[Bug 31714] Add a more generic way to print patron slips
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:01:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:01:22 +0000
Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips
In-Reply-To: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31714-70-QH7WokUn67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32344


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32344
[Bug 32344] Migrate print_overdues.pl to printnotice.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:06:30 +0000
Subject: [Koha-bugs] [Bug 32345] New: Migrate checkinslip from printslip.pl
 to printnotice.pl
Message-ID: <bug-32345-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32345

            Bug ID: 32345
           Summary: Migrate checkinslip from printslip.pl to
                    printnotice.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 31714

A more generic modern print script was introduced in bug 31714. 

We should be able to use that here and take us one step closer to being able to
remove to older printslip.pl controller.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714
[Bug 31714] Add a more generic way to print patron slips
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:06:30 +0000
Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips
In-Reply-To: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31714-70-ai5ZAjdVco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32345


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32345
[Bug 32345] Migrate checkinslip from printslip.pl to printnotice.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:08:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:08:02 +0000
Subject: [Koha-bugs] [Bug 32346] New: Migrate issueslip from printslip.pl to
 printnotice.pl
Message-ID: <bug-32346-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32346

            Bug ID: 32346
           Summary: Migrate issueslip from printslip.pl to printnotice.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 31714

A more generic modern print script was introduced in bug 31714. 

We should be able to use that here and take us one step closer to being able to
remove to older printslip.pl controller.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714
[Bug 31714] Add a more generic way to print patron slips
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:08:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:08:02 +0000
Subject: [Koha-bugs] [Bug 31714] Add a more generic way to print patron slips
In-Reply-To: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31714-70-DdTodUM2Tl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32346


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32346
[Bug 32346] Migrate issueslip from printslip.pl to printnotice.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:08:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:08:12 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-oz4jVaIqcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Add the ability to send an
      release notes|                            |email containing the token
                   |                            |to the
                   |                            |patron once it's
                   |                            |authenticated
                   |                            |
                   |                            |The new
                   |                            |notice template is
                   |                            |'2FA_OTP_TOKEN'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:23:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:23:39 +0000
Subject: [Koha-bugs] [Bug 30991] [% ELSE %]0[% END %] will break
 translations if used for assigning variables
In-Reply-To: <bug-30991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30991-70-uCD0loOSU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30991

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I do understand what we are doing on bug 23713.

But here we are simply splitting the rule on different lines. That is not
fixing the problem in the long term.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:25:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:25:22 +0000
Subject: [Koha-bugs] [Bug 30991] [% ELSE %]0[% END %] will break
 translations if used for assigning variables
In-Reply-To: <bug-30991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30991-70-PVhZIjV2yL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30991

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I mean, it's not solid for future changes, another author can put the statement
back on one line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:27:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:27:05 +0000
Subject: [Koha-bugs] [Bug 30462] Improve the default display for the
 background jobs queue management page
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-TuIYpaG1To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Should the background job   |Improve the default display
                   |list view hide index tasks  |for the background jobs
                   |by default?                 |queue management page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:42:38 +0000
Subject: [Koha-bugs] [Bug 32347] New: xt/find-nonutf8 not used and not
 maintain
Message-ID: <bug-32347-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32347

            Bug ID: 32347
           Summary: xt/find-nonutf8 not used and not maintain
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

sh scripts are not run by our CI, the script cannot be run out of the box in
ktd (xt/find-nonutf8: 31: isutf8: not found), and it's failing when the package
is installed.

kohadev-koha at kohadevbox:/kohadevbox/koha$ sh xt/find-nonutf8 
koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/FontAwesome.otf
koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.eot
koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.ttf
koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.woff
koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.woff2
koha-tmpl/intranet-tmpl/lib/tiny_mce/skins/ui/oxide-dark/fonts/tinymce-mobile.woff
koha-tmpl/intranet-tmpl/lib/tiny_mce/skins/ui/oxide/fonts/tinymce-mobile.woff
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff2
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff2
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff2
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff
koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff2
koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/FontAwesome.otf
koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.eot
koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.ttf
koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.woff
koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.woff2
koha-tmpl/opac-tmpl/lib/verovio/000_acoustic_grand_piano.data
misc/release_notes/release_notes_16_5_0.md
misc/release_notes/release_notes_17_05_00.html
misc/release_notes/release_notes_17_05_00.md
t/Koha/I18N/po/xx_XX/LC_MESSAGES/Koha.mo
t/db_dependent/Koha/Plugins/KitchenSinkPlugin.kpz
t/db_dependent/data/frameworks/auth_type.ods
t/db_dependent/data/frameworks/auth_type_smaller.ods
t/db_dependent/data/frameworks/biblio_framework.ods
t/db_dependent/data/frameworks/biblio_framework_new.ods
t/db_dependent/data/frameworks/biblio_framework_smaller.ods

Should we remove or adjust?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:43:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:43:03 +0000
Subject: [Koha-bugs] [Bug 32347] xt/find-nonutf8 not used and not maintained
In-Reply-To: <bug-32347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32347-70-mZ0lVskVdA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32347

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|xt/find-nonutf8 not used    |xt/find-nonutf8 not used
                   |and not maintain            |and not maintained

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:43:09 +0000
Subject: [Koha-bugs] [Bug 32347] xt/find-nonutf8 not used and not maintained
In-Reply-To: <bug-32347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32347-70-TS9uHwvBap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32347

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:55:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:55:57 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-kl9pdS2djq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144223|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144224&action=edit
Bug 32343: Prevent Koha/Patron.t to fail randomly

Highlighted by Bug 32030: fix test builder for boolean

The attribute is named "unique_id", not "unique"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:56:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:56:16 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-dEGFYG8qU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:56:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:56:32 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-tGjArLmaCM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fix confirmed, going straight for QA.

Passed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:57:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:57:04 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-aCnkItj6IQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This makes me wonder however.. should we be throwing errors in testbuilder if
we're passed unrecognised fields in the values param?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:57:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:57:13 +0000
Subject: [Koha-bugs] [Bug 32348] New: Library public is missing from columns
 settings
Message-ID: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

            Bug ID: 32348
           Summary: Library public is missing from columns settings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Bug 27360 added public info on libraries table.
This should be added to columns settings.
Currently the column "STMP server" can not be managed in settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:57:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:57:17 +0000
Subject: [Koha-bugs] [Bug 32348] Library public is missing from columns
 settings
In-Reply-To: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32348-70-kCoZfcTOWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27360


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360
[Bug 27360] Libraries should be able to pick which branches display on the
public 'Libraries' page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:57:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:57:17 +0000
Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which
 branches display on the public 'Libraries' page
In-Reply-To: <bug-27360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27360-70-dxQVHmxE5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32348


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348
[Bug 32348] Library public is missing from columns settings
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:57:25 +0000
Subject: [Koha-bugs] [Bug 32348] Library public is missing from columns
 settings
In-Reply-To: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32348-70-MWmmIIEoGY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:59:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:59:44 +0000
Subject: [Koha-bugs] [Bug 32348] Library public is missing from columns
 settings
In-Reply-To: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32348-70-NsCoy5kLJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 08:59:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 07:59:48 +0000
Subject: [Koha-bugs] [Bug 32348] Library public is missing from columns
 settings
In-Reply-To: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32348-70-3plaxXGgNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 144225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144225&action=edit
Bug 32348: Add library public in columns settings

Bug 27360 added public info on libraries table.
This should be added to columns settings.
Currently the column "STMP server" can not be managed in settings.

Test plan :
Play with columns settings of table Administration > Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:06:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:06:32 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-oC5vUmXC8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Tomás: What is your plan here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:06:54 +0000
Subject: [Koha-bugs] [Bug 32349] New: Remove TEST_QA
Message-ID: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349

            Bug ID: 32349
           Summary: Remove TEST_QA
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 5485

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically
installed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485
[Bug 5485] Add a framework for static source code analysis
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:06:54 +0000
Subject: [Koha-bugs] [Bug 5485] Add a framework for static source code
 analysis
In-Reply-To: <bug-5485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5485-70-oDMeqNGxkZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32349


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349
[Bug 32349] Remove TEST_QA
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:08:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:08:15 +0000
Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA
In-Reply-To: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32349-70-7Ql97k3GyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144226&action=edit
Bug 32349: Remove TEST_QA

There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.

Do we really need this? libtest-perl-critic-perl is packaged and automatically
installed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:09:04 +0000
Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA
In-Reply-To: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32349-70-10SjHYexjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |mtj at kohaaloha.com,
                   |                            |tomascohen at gmail.com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Mason, you are the only one this removal could affect. Do you agree with this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:09:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:09:17 +0000
Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA
In-Reply-To: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32349-70-zvySIqDBsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:18:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:18:22 +0000
Subject: [Koha-bugs] [Bug 32350] New: Should we die if TestBuilder is passed
 a column we're not expecting
Message-ID: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

            Bug ID: 32350
           Summary: Should we die if TestBuilder is passed a column we're
                    not expecting
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:20:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:20:01 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-74av1j6Ff7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144227&action=edit
Bug 32304: Fix subtest search_limited

Jenkins reported:
    not ok 1 - No jobs found without userenv

We need to check if there are jobs without borrowernumber.

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:20:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:20:06 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-mj77Yq4Pc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144228&action=edit
Bug 32304: BackgroundJobs.t: Fix subtest purge

Instead of deleting, I added a count :)
Note that one of the purges eventually deletes my
older jobs..

Test plan:
Run t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:20:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:20:35 +0000
Subject: [Koha-bugs] [Bug 32304] Subtest purge in BackgroundJobs.t fails
 when having older jobs
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-4KBVOcD6yj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144108|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 144108
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144108
Bug 32304: BackgroundJobs.t - Start purge test with clean sheet

To make Joubu happy ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:20:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:20:53 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-RE80wC6UsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144229&action=edit
Bug 32350: Die on unrecognised column passed to testbuilder

This should prevent mis-matches between tests and database fields in the
future and reduce our chances of hitting random test failures.

However, it may have a performance impact on the test suite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:21:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:21:04 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-YxfSu8vfqB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:21:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:21:13 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-NbOHaHazzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Subtest purge in            |Fix subtest search_limited
                   |BackgroundJobs.t fails when |and purge in
                   |having older jobs           |BackgroundJobs.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:21:18 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-su4vL0cIRB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:21:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:21:27 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-S0DlCpzA87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:22:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:22:14 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-JGzF20m5uC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Is this a crazy idea of worthwhile.. I can't make up my mind.. 

It would have helped prevent the series of bugs Jonathan is now working through
after the boolean fix.. I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:22:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:22:33 +0000
Subject: [Koha-bugs] [Bug 32242] The job has not been sent to the message
 broker: (Wide character in syswrite ... )
In-Reply-To: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32242-70-29ifmI2uJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #17)
> > kohadev-koha at kohadevbox:/kohadevbox/koha$ prove
> > t/db_dependent/Koha/BackgroundJobs.t
> > t/db_dependent/Koha/BackgroundJobs.t .. 1/15
> >     #   Failed test 'No jobs found without userenv'
> >     #   at t/db_dependent/Koha/BackgroundJobs.t line 135.
> >     #          got: '2'
> >     #     expected: '0'
> >     # Looks like you failed 1 test of 3.
> > 
> > #   Failed test 'search_limited'
> > #   at t/db_dependent/Koha/BackgroundJobs.t line 142.

Added a fix for this one on bug 32304 too now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:24:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:24:37 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-0QtaVqhAPN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144229|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144230&action=edit
Bug 32350: Die on unrecognised column passed to testbuilder

This should prevent mis-matches between tests and database fields in the
future and reduce our chances of hitting random test failures.

However, it may have a performance impact on the test suite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:32:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:32:21 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-rMAKr8eNTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144227|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144231&action=edit
Bug 32304: Fix subtest search_limited

Jenkins reported:
    not ok 1 - No jobs found without userenv

We need to check if there are jobs without borrowernumber.

Test plan:
Run test again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:32:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:32:25 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-mR1ylVHYcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144228|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144232&action=edit
Bug 32304: BackgroundJobs.t: Fix subtest purge

Instead of deleting, I added a count :)
Note that one of the purges eventually deletes my
older jobs..

Test plan:
Run t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:32:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:32:56 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-eFJRqmLk4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:33:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:33:50 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-DkuePncbEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Confirmed fixes the failures, thanks Marcel.

Straight PQA from me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:36:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:36:26 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-p5CzbwgmU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
[09:35] <marcelr> ashimema: you should do the check in build not in
build_object
[09:35] <marcelr> we are using build too still
[09:35] <marcelr> and build_object calls bild
[09:35] <marcelr> build

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:36:57 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-w1Q1DoLLGe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I would have used Array::List::intersect

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:37:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:37:18 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-8Jc7KAdb9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #5)
> I would have used Array::List::intersect

In _buildColumnValues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:37:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:37:29 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-XVkFDSzSQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #4)
> [09:35] <marcelr> ashimema: you should do the check in build not in
> build_object
> [09:35] <marcelr> we are using build too still
> [09:35] <marcelr> and build_object calls bild
> [09:35] <marcelr> build

Nonsense, sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:40:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:40:37 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-d2psov1LuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
index d065835ded0..d9e48b45c54 100644
--- a/t/lib/TestBuilder.pm
+++ b/t/lib/TestBuilder.pm
@@ -8,6 +8,7 @@ use Koha::Biblios qw( _type );
 use Koha::Items qw( _type );
 use Koha::DateUtils qw( dt_from_string );

+use Array::Utils qw( intersect );
 use Bytes::Random::Secure;
 use Carp qw( carp );
 use Module::Load qw( load );
@@ -280,6 +281,9 @@ sub _buildColumnValues {
     my @columns = $self->schema->source($source)->columns;
     my %unique_constraints =
$self->schema->source($source)->unique_constraints();

+    my @intersect = intersect( keys %$original_value, @columns );
+    die Dumper @intersect if @intersect;
+
     my $build_value = 5;
     # we try max $build_value times if there are unique constraints
     BUILD_VALUE: while ( $build_value ) {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:41:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:41:26 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-0sG3ivLFV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Something in the lines, with a good die message :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:43:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:43:51 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-wYFFC4SMIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Please see last patch on bug 31969.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:45:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:45:50 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-INaLyZsbq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32350

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #4)
> This makes me wonder however.. should we be throwing errors in testbuilder
> if we're passed unrecognised fields in the values param?

Bue 32350

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:45:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:45:50 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-OQjbfr0wnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32343

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 09:57:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 08:57:10 +0000
Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for
 non-waiting holds
In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14783-70-qCzfI97S6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

Björn Nylén <bjorn.nylen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement allows
      release notes|                            |patrons to change the
                   |                            |pickup location of
                   |                            |non-waiting holds from the
                   |                            |opac.
                   |                            |
                   |                            |The new system
                   |                            |preference
                   |                            |"OPACAllowUserToChangeBranc
                   |                            |h" controls at what stages
                   |                            |the pickup location can be
                   |                            |changed (Pending,
                   |                            |In-transit, Suspended).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 10:10:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 09:10:24 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-rap8xz4zvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Needs a bit more logic for the "FK hashes" in value. On it now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 10:11:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 09:11:24 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-apW4b4dhhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #8)
>  
> +    my @intersect = intersect( keys %$original_value, @columns );
> +    die Dumper @intersect if @intersect;
> +

No intersect. Wrong logic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 10:11:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 09:11:36 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-l8dIWlmDWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 10:11:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 09:11:57 +0000
Subject: [Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a
 HASH reference at circ/article-requests.pl line 38
In-Reply-To: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32123-70-jKeTSNbqzQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How do you recreate the error?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 10:25:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 09:25:39 +0000
Subject: [Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a
 HASH reference at circ/article-requests.pl line 38
In-Reply-To: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32123-70-fBLa1kiQJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #1)
> How do you recreate the error?

It has been addressed. Check see also. Comes from Auth..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:00:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:00:50 +0000
Subject: [Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a
 HASH reference at circ/article-requests.pl line 38
In-Reply-To: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32123-70-gROPwOYaDk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
31908 is not pushed yet, and I don't recreate the problem on master.

If addressed, do we close this one then?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:06:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:06:29 +0000
Subject: [Koha-bugs] [Bug 32123] CRASH: Can't use an undefined value as a
 HASH reference at circ/article-requests.pl line 38
In-Reply-To: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32123-70-lG4xFifngV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:06:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:06:29 +0000
Subject: [Koha-bugs] [Bug 32124] [OMNIBUS] Problems with C4::Context->userenv
In-Reply-To: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32124-70-zi6wLbxFHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32124
Bug 32124 depends on bug 32123, which changed state.

Bug 32123 Summary: CRASH: Can't use an undefined value as a HASH reference at circ/article-requests.pl line 38
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32123

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:22:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:22:35 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-FOwGNeMJ1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:22:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:22:39 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-umAFLZJOq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144230|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144233&action=edit
Bug 32350: Die on unrecognised column passed to testbuilder

This should prevent mis-matches between tests and database fields in the
future and reduce our chances of hitting random test failures.

However, it may have a performance impact on the test suite.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:22:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:22:44 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-n2xdUfibyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144234&action=edit
Bug 32350: Use array_minus and ignore nesting

Note: Test will be extended in follow-up. This fixes the
module_bit hash to follow the FK path from user_permissions
to permissions to userflags. One step was missed in the
existing test, although it did not fail. The change here
revealed that now.

Test plan:
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:22:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:22:49 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-fhn5LGH3HB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144235&action=edit
Bug 32350: Add subtest for bad columns

Test plan:
Run t/db_dependent/TestBuilder.t
And now run the whole test suite :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:25:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:25:58 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-WDJqt7zZur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
t/db_dependent/Koha/Holds.t ................... 6/10     # No tests run!

#   Failed test 'No tests run for subtest "Test Koha::Hold::item_group"'
#   at t/db_dependent/Koha/Holds.t line 669.
Error: value hash contains unrecognized columns: biblionumber at
/usr/share/koha/t/lib/TestBuilder.pm line 287.
# Looks like your test exited with 255 just after 8.
t/db_dependent/Koha/Holds.t ................... Dubious, test returned 255
(wstat 65280, 0xff00)
Failed 3/10 subtests

First hit in t/db../Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:28:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:28:11 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-4waRcgHa0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
t/db_dependent/Koha/Patron.t .................. 6/19         # No tests run!

    #   Failed test 'No tests run for subtest "unique attributes tests"'
    #   at t/db_dependent/Koha/Patron.t line 593.
    # Looks like you planned 16 tests but ran 13.
    # Looks like you failed 1 test of 13 run.
t/db_dependent/Koha/Patron.t .................. 7/19
#   Failed test 'extended_attributes'
#   at t/db_dependent/Koha/Patron.t line 727.
Error: value hash contains unrecognized columns: unique at
/usr/share/koha/t/lib/TestBuilder.pm line 287.
# Looks like your test exited with 255 just after 7.
t/db_dependent/Koha/Patron.t .................. Dubious, test returned 255
(wstat 65280, 0xff00)
Failed 13/19 subtests
t/db_dependent/Koha/Patrons.t ................. 1/44     # Looks like you
planned 9 tests but ran 4.
t/db_dependent/Koha/Patrons.t ................. 5/44
#   Failed test 'guarantees'
#   at t/db_dependent/Koha/Patrons.t line 235.
Error: value hash contains unrecognized columns: guarantorid at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:34:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:34:15 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-kvW03k77tG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |m.de.rooy at rijksmuseum.nl
                   |.com                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:40:51 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-qzawx8VGMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Here are few more from t/db.. in root dir

./Acquisition.t ........................... 63/71
#   Failed test 'No tests run for subtest "ModReceiveOrder replacementprice
tests"'
#   at ./Acquisition.t line 748.
Error: value hash contains unrecognized columns: booksellerid at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

./Budgets.t ............................... 105/154     # No tests run!
#   Failed test 'No tests run for subtest "GetBudgetSpent and GetBudgetOrdered
and GetBudgetHierarchy shipping and adjustments"'
#   at ./Budgets.t line 1039.
Error: value hash contains unrecognized columns: budget_total at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

./Circulation.t ........................... 33/64     # No tests run!
#   Failed test 'No tests run for subtest "CanBookBeIssued +
AutoReturnCheckedOutItems"'
#   at ./Circulation.t line 2895.
Error: value hash contains unrecognized columns: library at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

./Illrequests.t ........................... 9/15     # No tests run!
#   Failed test 'No tests run for subtest "Checking out"'
#   at ./Illrequests.t line 1312.
Error: value hash contains unrecognized columns: category_type at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

./Members.t ............................... 43/54     # Looks like you planned
8 tests but ran 5.
./Members.t ............................... 53/54
#   Failed test 'purgeSelfRegistration'
#   at ./Members.t line 470.
Error: value hash contains unrecognized columns: acocunttype at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

./Reserves.t .............................. 72/77     # Looks like you planned
2 tests but ran 1.
#   Failed test 'IsAvailableForItemLevelRequest() tests'
#   at ./Reserves.t line 1475.
Error: value hash contains unrecognized columns: notloan at
/usr/share/koha/t/lib/TestBuilder.pm line 287.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:41:17 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-qsmxUMR3IW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Aude Charillon <aude.charillon at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |Aude Charillon
            contact|                            |
                 CC|                            |aude.charillon at ptfs-europe.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:41:36 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-tTNfup4vPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Not sure if following are related. I missed Test::DBIx::Class. Skipped selenium
and www.

./Holds.t ................................. 76/76 # Looks like you failed 2
tests of 76.
./Search.t                              (Wstat: 65280 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 3 tests but ran 1.
./Sitemapper.t                          (Wstat: 512 Tests: 2 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 16 tests but ran 2.
./Suggestions.t                         (Wstat: 256 Tests: 91 Failed: 1)
  Failed test:  89
  Non-zero exit status: 1
./check_sysprefs.t                      (Wstat: 256 Tests: 795 Failed: 1)
  Failed test:  294
  Non-zero exit status: 1
./yaml.t                                (Wstat: 1024 Tests: 4 Failed: 4)
  Failed tests:  1-4
  Non-zero exit status: 4

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:44:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:44:41 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-TJ6IsNFWbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I think it makes sense to fix those tests on follow-up reports. And push when
it looks like we are green ;)
Will fix some now on a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:46:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:46:27 +0000
Subject: [Koha-bugs] [Bug 32351] New: Fix TestBuilder calls in Koha/Holds.t
Message-ID: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

            Bug ID: 32351
           Summary: Fix TestBuilder calls in Koha/Holds.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

See 32350. Follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:46:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:46:41 +0000
Subject: [Koha-bugs] [Bug 32351] Fix TestBuilder calls in Koha/Holds.t
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-pLc9GQz7zw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32350


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350
[Bug 32350] Should we die if TestBuilder is passed a column we're not expecting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:46:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:46:41 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-PH3T8vIvnk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351
[Bug 32351] Fix TestBuilder calls in Koha/Holds.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:46:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:46:50 +0000
Subject: [Koha-bugs] [Bug 32351] Fix TestBuilder calls in Koha/Holds.t
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-Atrut8rLid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:50:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:50:18 +0000
Subject: [Koha-bugs] [Bug 32186] [DOCS] Add information about the
 opacbookbag preference to the manual
In-Reply-To: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32186-70-De3QdZ56MO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |Needs documenting
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:51:31 +0000
Subject: [Koha-bugs] [Bug 32351] Fix TestBuilder calls in Koha/Holds.t
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-LWIWhg6muw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 11:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 10:51:36 +0000
Subject: [Koha-bugs] [Bug 32351] Fix TestBuilder calls in Koha/Holds.t
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-Lg3xMp0eaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144236&action=edit
Bug 32351: Holds.t - replace biblionumber by biblio_id

Trivial fix, found by bug 32350.
Note that the test also passes without this value hash ;)

Test plan:
Run test.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:02:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:02:43 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-VOQqT7MLEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #19)
> I think it makes sense to fix those tests on follow-up reports. And push
> when it looks like we are green ;)
> Will fix some now on a follow-up.

Probably better to fix them all on 32351

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:03:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:03:14 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-eeehETfuXx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fix TestBuilder calls in    |Fix all TestBuilder calls
                   |Koha/Holds.t                |failing due to wrong column
                   |                            |names (see 32350)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:03:44 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-HxPnPY7E9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:04:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:04:06 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-EgDP0wJcHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:04:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:04:12 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-XFJzZwGcjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144220|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 144237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144237&action=edit
Bug 32307: Fix gallery when Coce is enabled

Bug 28179 added the gallery in the staff interface, and bug 28180 in the
OPAC.

OPAC and staff have different code, because the cover image providers
are different.
On bug 28180 we noticed that the OPAC needed additional code to handle
OpenLibrary, Google Jacket and Coce, to differ the creation of the
gallery to prevent Chocolat to be instantiated before the links (img src)
are effectively in the DOM.

To acchieve that we introduced a wait_for_images function, and added a
"done" flag to the 3 "JS modules".

However we haven't ported this code for the staff interface, which is
also using Coce.

Note that there was a bug at the OPAC as well for COCE, the ajax jQuery
function is async, and so 'done' was set even if the call was not
finished.

Test plan:
0. Do not apply this patch
1. Enable LocalCoverImages and IntranetCoce
2. Pick a bibliographic record with an image returned from Coce
3. Add a local cover image
4. Go to the detail page
5. Open the gallery
=> Notice that you can notice a JS error and a loading icon on the
second image. This behaviour is not always broken, it depends on the
speed of the Coce server. If you don't see the problem reload the page.
6. Apply the patch and repeat
=> Notice that the cover slider block is longer to display the icon, but
that the error is gone.
7. Confirm that there is no regression at the OPAC

We could improve the situation here, and we could display the images
in the slider, especially if the first image is a local image. But
that's for another bug...

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:04:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:04:18 +0000
Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff
 interface when Coce is enabled
In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32307-70-aV8D2UaYCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144222|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 144238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144238&action=edit
Bug 32307: (follow-up) Fix gallery when Coce is enabled

Yet another fix, this is porting the following change to the intranet:
  commit 1916c644808577beb3170d642f93b456bfcc5c56
  Bug 28180: Fix bug with first image does not exist

To recreate the problem:
Enable Coce
Go to biblionmber=5 detail
=> No image (but one is displayed on the search result)
Add a local cover image
=> Only the local cover image is displayed
Apply this patch
=> Both images are displayed
Remove the local cover image
=> Image from coce is displayed

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:04:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:04:38 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-4lCenDVhgN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #225 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
`biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic record
the group belongs to',

DEFAULT 0, is this correct?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:04:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:04:46 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-LTeoZxWHGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|m.de.rooy at rijksmuseum.nl    |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:04:55 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-tjJH7oVn8U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:05:15 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-sqtQcP2NB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:05:58 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-CRjU7PUIlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144235|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144239&action=edit
Bug 32350: Add subtest for bad columns

Test plan:
Run t/db_dependent/TestBuilder.t
And now run the whole test suite :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:06:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:06:31 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-QyWZLl0DqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Couldnt live with it:

-             value => { surname => 'Pass', categorycode => { description =>
'bla', wrong_nested => 1 }},
+             value => { surname => 'WontPass', categorycode => { description
=> 'bla', wrong_nested => 1 }},

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:10:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:10:40 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-U1yOPXRlZp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144236|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144240&action=edit
Bug 32351: Holds.t - remove wrong column reference

Found by bug 32350.
The test does not need this value at all..

Test plan:
Run test.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:12:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:12:39 +0000
Subject: [Koha-bugs] [Bug 22467] t/00-valid-xml.t shouldn't fail due to
 node_modules presence
In-Reply-To: <bug-22467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22467-70-Qo0RMyzEg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22467

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---


*** This bug has been marked as a duplicate of bug 24494 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:12:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:12:39 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-EL15vkI2Ce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 22467 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:13:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:13:09 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-bRkDLelpcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #33 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 144241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144241&action=edit
Bug 31447: Fix test

Tests for this feature raised a new warning
"Odd number of elements in anonymous hash".
Setting $item->item_group as seperated variable
removes this warning.

To test prove t/db_dependent/Circulation.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:24:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:24:20 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-Cb2bvUzjUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32352

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:24:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:24:20 +0000
Subject: [Koha-bugs] [Bug 32352] New: xt/check_makefile.t failing on
 node_modules
Message-ID: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

            Bug ID: 32352
           Summary: xt/check_makefile.t failing on node_modules
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

21:55:20 koha_1       | #   Failed test 'All directories must be listed in
Makefile.PL'
21:55:20 koha_1       | #   at xt/check_makefile.t line 39.
21:55:20 koha_1       | #          got: '1'
21:55:20 koha_1       | #     expected: '0'
21:55:20 koha_1       | # $VAR1 = [
21:55:20 koha_1       | #           './node_modules'
21:55:20 koha_1       | #         ];

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:26:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:26:52 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-lAQ0LzPiQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, mtj at kohaaloha.com,
                   |                            |tomascohen at gmail.com
             Status|NEW                         |ASSIGNED
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:27:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:27:39 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-n5yv2in29w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144242&action=edit
Bug 32352: Make xt/check_makefile.t check directories in git index

It's failing if 'node_modules' exists. We could simply skip it, but it
seems that it would be better to actually list directories that are part
of the git index only.

The question is: do we actually support test execution outside of a git
directory?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:28:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:28:31 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-1NQsAZwYml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:36:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:36:11 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-N7wJyeMghP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144243&action=edit
Bug 32351: Fix Acquisition.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:43:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:43:31 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-Fy9ZsLSXQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144244&action=edit
Bug 32351: Fix Budgets.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:44:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:44:45 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-Hg3MeXazQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144233|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144245&action=edit
Bug 32350: Die on unrecognised column passed to testbuilder

This should prevent mis-matches between tests and database fields in the
future and reduce our chances of hitting random test failures.

However, it may have a performance impact on the test suite.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:44:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:44:50 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-ab1ScLbCi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144234|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144246&action=edit
Bug 32350: Use array_minus and ignore nesting

Note: Test will be extended in follow-up. This fixes the
module_bit hash to follow the FK path from user_permissions
to permissions to userflags. One step was missed in the
existing test, although it did not fail. The change here
revealed that now.

Test plan:
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:44:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:44:55 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-T0tpvKNubc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144239|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144247&action=edit
Bug 32350: Add subtest for bad columns

Test plan:
Run t/db_dependent/TestBuilder.t
And now run the whole test suite :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:45:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:45:00 +0000
Subject: [Koha-bugs] [Bug 32350] Should we die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-rk9y3JHQnX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144248&action=edit
Bug 32350: (follow-up) Remove List::Util import

We replaced it with Array::Utils

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:45:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:45:23 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-gF5Q8nm4Q7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Should we die if            |We should die if
                   |TestBuilder is passed a     |TestBuilder is passed a
                   |column we're not expecting  |column we're not expecting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:45:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:45:44 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-BC6OlNRv4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great teamwork here :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:46:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:46:00 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-6NPtFnuN8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144249&action=edit
Bug 32351: Fix Illrequests.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:48:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:48:01 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-iPRE7hfOJg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144250&action=edit
Bug 32351: Fix Members.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:49:25 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-pCd7oQCOeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144251&action=edit
Bug 32351: Fix Reserves.t

itemtypes.notforloan already defaults to 0

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:52:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:52:30 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-953WsVAgOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
First and last patches are useless, can we remove them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 12:57:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 11:57:30 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-Fe2Ak2x26Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144252&action=edit
Bug 32351: Fix Circulation.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:00:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:00:06 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-KCPhXCNOxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Emmi Takkinen from comment #33)
> Created attachment 144241 [details] [review]
> Bug 31447: Fix test
> 
> Tests for this feature raised a new warning
> "Odd number of elements in anonymous hash".
> Setting $item->item_group as seperated variable
> removes this warning.
> 
> To test prove t/db_dependent/Circulation.t.
> 
> Sponsored-by: Koha-Suomi Oy

Are you sure?
Did you just try

  item_group_id => $item->item_group->item_group_id

?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:02:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:02:43 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-koTC4WiQ5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

--- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Ok got it, nevermind, I will deal with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:02:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:02:54 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-xLzY3cc3W2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144241|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:05:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:05:48 +0000
Subject: [Koha-bugs] [Bug 32353] New: items.item_group_id should be
 undefined in tests by default
Message-ID: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

            Bug ID: 32353
           Summary: items.item_group_id should be undefined in tests by
                    default
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24857

TestBuilder should set it to NULL and don't generate the item group.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to group items for records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:05:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:05:48 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-F1yYxCaJxz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32353


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353
[Bug 32353] items.item_group_id should be undefined in tests by default
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:06:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:06:06 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-PT3AxGBudC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32353

--- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
See bug 32353.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353
[Bug 32353] items.item_group_id should be undefined in tests by default
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:06:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:06:06 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-t1l1eoh73Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31447


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447
[Bug 31447] "Please confirm checkout" message uses patron's home library not
holds pick up library
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:07:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:07:18 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-ywLzdn8cFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #37 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Jonathan Druart from comment #34)
> (In reply to Emmi Takkinen from comment #33)
> > Created attachment 144241 [details] [review] [review]
> > Bug 31447: Fix test
> > 
> > Tests for this feature raised a new warning
> > "Odd number of elements in anonymous hash".
> > Setting $item->item_group as seperated variable
> > removes this warning.
> > 
> > To test prove t/db_dependent/Circulation.t.
> > 
> > Sponsored-by: Koha-Suomi Oy
> 
> Are you sure?
> Did you just try
> 
>   item_group_id => $item->item_group->item_group_id
> 
> ?

Just tried it, cannot call item_group_id of undefined value. So either it
should be undef or there should be mocked item group.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:07:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:07:59 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-AmKoCKnXhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:08:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:08:03 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-CfzVCP5IIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144253&action=edit
Bug 32353: Don't generate item group for items in tests

See bug 31447, we don't want the tests to deal with potential failures
because of some item groups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:08:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:08:21 +0000
Subject: [Koha-bugs] [Bug 31447] "Please confirm checkout" message uses
 patron's home library not holds pick up library
In-Reply-To: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31447-70-8lWVBs0ab8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #38 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Jonathan Druart from comment #36)
> See bug 32353.

Ok, makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:09:30 +0000
Subject: [Koha-bugs] [Bug 32186] [DOCS] Add information about the
 opacbookbag preference to the manual
In-Reply-To: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32186-70-TK9tCY4xs9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Testing a dashboard change.. I've reset this to 'Needs documenting', can you
set it to 'RESOLVED' Katrin.. then the dashboard should pick you up as the
contributor...

Though thinking about it, I perhaps need to rethink that a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:10:12 +0000
Subject: [Koha-bugs] [Bug 31933] Import patrons fails when patron attribute
 value contains a comma
In-Reply-To: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31933-70-CELMRw5yGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |jacob.omara at ptfs-europe.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:11:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:11:03 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-kPa7uzGlFr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:19:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:19:10 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-dWxyS5a90k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144254&action=edit
Bug 32353: Pick the default value for FK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:20:16 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-8HjMM8dipu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|jonathan.druart+koha at gmail. |chris at bigballofwax.co.nz
                   |com                         |
             Status|ASSIGNED                    |NEW

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Entered a rabbit hole here, and found a TestBuilder bug I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:23:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:23:40 +0000
Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP
 checkin/checkout
In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25812-70-ZtBuleTjxe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Tests look solid to me.. my signoff still stands.. just need a QA on this now
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:24:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:24:07 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-0MNTlzQ8is@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144254|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144255&action=edit
Bug 32353: Pick the default value for FK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:24:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:24:28 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-p5ZGKKbzuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Still failing actually...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:26:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:26:36 +0000
Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action
 and should be treated as such
In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32013-70-ZrEbV7Rzgk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:29:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:29:51 +0000
Subject: [Koha-bugs] [Bug 32244] We need to add vue (and cypress possibly)
 to the about page
In-Reply-To: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32244-70-W2e6VMa9gk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:31:31 +0000
Subject: [Koha-bugs] [Bug 31950] Page section on library view is too wide /
 not aligned with toolbar
In-Reply-To: <bug-31950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31950-70-5rsWzhoG1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31950

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|isobel.graham09 at gmail.com   |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:37:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:37:08 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-i6FSurdCrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:46:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:46:47 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-5an4uYcWAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:46:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:46:50 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-XkD2LaLQ73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:46:53 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-K1ehhLSqYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:46:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:46:56 +0000
Subject: [Koha-bugs] [Bug 32343] Koha/Patron.t is failing randomly
In-Reply-To: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32343-70-UEwpgQrOAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32343

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:49:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:49:33 +0000
Subject: [Koha-bugs] [Bug 32310] Correct CSS in the staff interface which
 still uses old color scheme
In-Reply-To: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32310-70-zpFqtyGbnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32310

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 13:57:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 12:57:24 +0000
Subject: [Koha-bugs] [Bug 32304] Fix subtest search_limited and purge in
 BackgroundJobs.t
In-Reply-To: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32304-70-QUIB8pcPEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32304

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
No idea why this has been pushed right before the follow-up on bug 31969 (Use
filter_by_last_update) that actually... removes this code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 14:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 13:03:24 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-O9WlSmjnlt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #28)
> First and last patches are useless, can we remove them?

You're welcome to do it in the QA step :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 14:08:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 13:08:29 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-gUa53VYteg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    } elsif( !exists $value->{$col_name}
+           && exists $self->{default_values}{$source}{$col_name} ) {
+        my $v = $self->{default_values}{$source}{$col_name};
+        $v = &$v() if ref($v) eq 'CODE';
+        push @$retvalue, $v;
     } elsif( $col_info->{is_foreign_key} || _should_be_fk($source,$col_name) )
{
         if( exists $value->{$col_name} ) {
             if( !defined $value->{$col_name} && !$col_info->{is_nullable} ) {
@@ -427,10 +432,6 @@ sub _buildColumnValue {
             return;
         }
         push @$retvalue, $value->{$col_name};
-    } elsif( exists $self->{default_values}{$source}{$col_name} ) {
-        my $v = $self->{default_values}{$source}{$col_name};
-        $v = &$v() if ref($v) eq 'CODE';
-        push @$retvalue, $v;

Sure about this change? This has been working for years?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 14:09:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 13:09:03 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-JFkWozEKOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 14:09:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 13:09:17 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-D04WZ0AmFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 14:10:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 13:10:46 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-q86XNt6LJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart+koha at gmail. |chris at bigballofwax.co.nz
                   |com                         |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #6)
> Sure about this change? This has been working for years?

We have no default on FK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 15:03:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 14:03:03 +0000
Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for
 non-waiting holds
In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14783-70-W96vgLI4v9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you for the release notes, Björn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 15:32:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 14:32:47 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 22.11
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-CDHmHjNMid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144256&action=edit
Bug 30808: Add the 23.05 release team

This patch updates the teams.yaml to include the voted in 23.05 release
team and also updates the release date of 22.11 to match the actual
release.

Test plan
1/ Check against https://wiki.koha-community.org/wiki/Release_Teams

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 15:32:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 14:32:49 +0000
Subject: [Koha-bugs] [Bug 32328] Add ability to specify how long an item
 stays on a library's holds queue
In-Reply-To: <bug-32328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32328-70-U2Syv8H0nY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32328

Wendy Sharkey <catalog at bfli.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catalog at bfli.org

--- Comment #1 from Wendy Sharkey <catalog at bfli.org> ---
In a multi-location consortium some libraries will be closed while others are
open, not just on a day-to-day basis, but hourly. Some libraries open for half
days while others are open for full days. The holds queue cron job runs in our
case every 2 hours, continually. If a patron places a hold after their library
closes, the holds queue could cycle through several times before the next
opening.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 15:33:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 14:33:14 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 22.11
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-DB4UYkhBvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135202|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 15:33:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 14:33:42 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-B5tntI7hTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Release team 22.11          |Release team 23.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 15:39:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 14:39:24 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-WwnNDe3aYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.05.00, 21.05.16          |22.11.00, 22.05.00,
        released in|                            |21.05.16
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:21:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:21:07 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-atxZt9U8sA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139599|0                           |1
        is obsolete|                            |

--- Comment #323 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144257&action=edit
Bug 17015: Performance comparison (images)

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:21:18 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-cFGUw7URyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139601|0                           |1
        is obsolete|                            |

--- Comment #324 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144258&action=edit
Bug 17015: Schema file for new discrete_calendar table

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:21:29 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-LLsTmDQ0DX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139602|0                           |1
        is obsolete|                            |

--- Comment #325 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144259&action=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts

Signed-off-by: Michal Denar <black23 at gmail.com>

Bug 17015: When using book drop mode, set check in time as closing hours

Signed-off-by: Michal Denar <black23 at gmail.com>

Bug 17015: Automatically update calendar when creating or deleting a branch

Signed-off-by: Michal Denar <black23 at gmail.com>

Bug 17015: Rebase and tests for discrete calendar

This patch is a rebase of all the previous patches in order to show the
discrete calendar.

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)

Signed-off-by: Michal Denar <black23 at gmail.com>

Bug 17015: DiscreteCalendar->new() method is now in a HASH

This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
 ~ The error "Can't use string ("branchcode") as a HASH ref while
   "strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar

USING THE DISCRETE CALENDAR:
1- New UI
  a) Calendar on the left
  b) Holidays list on the right
2- New color system for holiday types:
  a) Working day : white
  b) Unique holiday: red
  c) Holiday repeating weekly: yellow
  d) Holiday repeating yearly: orange
  e) Floating holiday: green
  f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch

Bug 17015: Fixing QA tools failures

This patch fixes tests that fails with the QA tool.

To test, run the QA tool
All tests should say OK except 2 that fails.

Bug 17015: Check out with the useDaysMode preference

When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.

To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:21:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:21:39 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-mdBz0ZoLve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139603|0                           |1
        is obsolete|                            |

--- Comment #326 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144260&action=edit
Bug 17015: Tests for DiscreteCalendar

Signed-off-by: Michal Denar <black23 at gmail.com>

Bug 17015: Rebase and tests for discrete calendar

This patch is a rebase of all the previous patches in order to show the
discrete calendar.

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:21:50 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-aGNUo6CHdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139851|0                           |1
        is obsolete|                            |

--- Comment #327 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144261&action=edit
Bug 17015: DatePicker/TimePicker to Flatpickr

Changed all datepicker/timepicker to flatpickr + some small fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:22:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:22:02 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-P6TaBDfDLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140150|0                           |1
        is obsolete|                            |

--- Comment #328 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144262&action=edit
Bug 17015: Install scripts for DiscreteCalendar

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:22:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:22:07 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-6muL480k0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144263&action=edit
Bug 30808: Add support for version codenames

This patch adds the 'Rosalie' codename to the 22.11 release and adds
corresponding support to the about page for displaying it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:22:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:22:11 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-5Fhq9X2oPE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141176|0                           |1
        is obsolete|                            |

--- Comment #329 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144264&action=edit
Bug 17015: Use branchcode when adding or modifying a holiday

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:36:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:36:37 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-etIsElNQ03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144265&action=edit
Bug 30808: Add a dedications tab to the about page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:39:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:39:47 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-A4DpcrcPpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144265|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144266&action=edit
Bug 30808: Add a dedications tab to the about page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 16:47:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 15:47:54 +0000
Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
In-Reply-To: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17983-70-5kmi8HBr25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139519|0                           |1
        is obsolete|                            |

--- Comment #31 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144267&action=edit
Bug 17983: Add minutes loan to DiscreteCalendar

This is an additional feature to our new Discrete Calendar.
Theses patches add the possibility to choose the loan unit as minutes in
circulations rules.

Test plan:
- Apply patch of Bugzilla 17015
- Apply this patch.
- Run test t/db_dependent/minutes_loan.t
- Create new item type for the new rule.
- Create circulation rule and fill the fields, make sure the unit is set to :
minutes, choose the item type of the one created above.-
- Checkout an item that follow the circulation rule and set due date in the
past.

- Run fines.pl.
- Check if the correct amount was calculated.
    - Note: make sure to factor in the fine grace period if set and the system
preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 17:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 16:02:26 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-mFxLDjV3V3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I don't remember writing this to be honest.  I thought the tests within a
directory ran in order at the time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:11:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:11:01 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-cE6soVEbOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #330 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144268&action=edit
Bug 17015: Add description field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:11:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:11:10 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-HHzKpw5sOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #331 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144269&action=edit
Bug 17015: Allow holiday edits to be applied to all branches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:11:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:11:18 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-uKMD82GKw3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #332 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144270&action=edit
Bug 17015: Add an option to view past holiday details in table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:11:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:11:29 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-KsnAeIpivS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #333 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144271&action=edit
Bug 17015: Add minDate restrictions for pairs of date selectors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:11:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:11:38 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-2XUYM3im1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #334 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144272&action=edit
Bug 17015: UI tweaks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:11:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:11:46 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-AzyNdkXF5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #335 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 144273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144273&action=edit
Bug 17015: Always uncheck "Copy all librairies" when opening edit page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:38:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:38:29 +0000
Subject: [Koha-bugs] [Bug 32305] Backround worker doesn't check jobs receive
 from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-RphActZHzy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amit.gupta at informaticsgloba
                   |                            |l.com,
                   |                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 18:42:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 17:42:55 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
 receive from rabbitmq are in 'new' state.
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-EqBW3KOYqD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Backround worker doesn't    |Background worker doesn't
                   |check jobs receive from     |check jobs receive from
                   |rabbitmq are in 'new'       |rabbitmq are in 'new'
                   |state.                      |state.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 20:19:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 19:19:56 +0000
Subject: [Koha-bugs] [Bug 30280] Support authority records with common
 subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-WLFya1ksYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #58 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Katrin Fischer from comment #57)
> The problem is, we broke things with this one for people and a lot of
> libraries - we need to find a fix.

Katrin, I have been working on a fix to make it compatible with Zebra. There is
some code to be uploaded as well. The patch should work in theory but I can get
Zebra to work as expected. But it work nicely with Elasticsearch. Do you want
me to submit the patch here or to Bug 31924? I will definitely need some help
with setting up the search field correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Nov 25 23:11:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Nov 2022 22:11:41 +0000
Subject: [Koha-bugs] [Bug 13576] Add a default circulation rule to the
 optional sample data
In-Reply-To: <bug-13576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13576-70-BqWPPDXdqc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576

advsalahuddinahmed072 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |advsalahuddinahmed072 at gmail
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 03:02:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 02:02:06 +0000
Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from
 C4::Breeding
In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32280-70-uI6UO7j0vS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32279

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 03:02:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 02:02:06 +0000
Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports
 of C4::AuthoritiesMarc
In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32279-70-KIRtqJetuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32280

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 03:02:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 02:02:14 +0000
Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from
 C4::Breeding
In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32280-70-4PUQrcNBLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 03:16:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 02:16:53 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-V7c6r7V9c6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
You mean like Bug 24156

Looks like the column can be defined but not the ascending or descending order.
Would need a new config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 04:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 03:56:52 +0000
Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users
 associated with the funds
In-Reply-To: <bug-27550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27550-70-IOMSVCfmMH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 04:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 03:57:25 +0000
Subject: [Koha-bugs] [Bug 31367] Display of sub-funds does not include
 totals of sub-sub-funds on acquisitions home page
In-Reply-To: <bug-31367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31367-70-TOJ1TF1brJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31367

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 04:57:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 03:57:46 +0000
Subject: [Koha-bugs] [Bug 31562] Patron 'flags' don't respect unwanted fields
In-Reply-To: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31562-70-SgwYxnq2Zb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #19 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 04:58:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 03:58:05 +0000
Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items
 does not work
In-Reply-To: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25375-70-2fT3zT6Wmb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #46 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 04:58:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 03:58:30 +0000
Subject: [Koha-bugs] [Bug 31518] Hidden items count not displayed on hold
 request page
In-Reply-To: <bug-31518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31518-70-4Ek4Z2PtEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 08:24:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 07:24:00 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-Zj9Ltp5gJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a dumb question :) What about:
The dir should exist, right?

diff --git a/Makefile.PL b/Makefile.PL
index 131d8a0ae2..9d4eb9d604 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -346,6 +346,7 @@ my $target_map = {
   './misc/translator'           => { target => 'MISC_DIR', trimdir => 2 },
   './misc/koha-install-log'     => { target => 'MISC_DIR', trimdir => -1 },
   './misc/installer_devel_notes' => 'NONE',
+  './node_modules'              => 'INTRANET_CGI_DIR',
   './opac'                      => 'OPAC_CGI_DIR',
   './OpenILS'                   => 'PERL_MODULE_DIR',
   './README.txt'                => 'NONE',

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 09:28:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 08:28:37 +0000
Subject: [Koha-bugs] [Bug 32186] [DOCS] Add information about the
 opacbookbag preference to the manual
In-Reply-To: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32186-70-mfU2PdhqHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32186

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 09:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 08:54:12 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-Wtzo3KTDvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
No, it shouldn't in production env.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Nov 26 09:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 08:55:14 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-F3HEDbLAnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
And it's not part of git index, so not necessarily exists on dev env either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 00:34:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 23:34:32 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-wCBIioD351@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
Bug 30982 depends on bug 31565, which changed state.

Bug 31565 Summary: Patron search filter by category code with special character returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 00:34:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 23:34:32 +0000
Subject: [Koha-bugs] [Bug 31565] Patron search filter by category code with
 special character returns no results
In-Reply-To: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31565-70-zcLgo9Dy5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31565

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #30 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 00:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 23:36:30 +0000
Subject: [Koha-bugs] [Bug 31527] Breadcrumbs for anonymous suggestions are
 not correct
In-Reply-To: <bug-31527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31527-70-8SEfpAW7Hg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31527

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 00:39:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Nov 2022 23:39:16 +0000
Subject: [Koha-bugs] [Bug 31605] Improve style of OPAC suggestions search
 form
In-Reply-To: <bug-31605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31605-70-VvHBGqoRAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31605

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:05:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:05:04 +0000
Subject: [Koha-bugs] [Bug 31646] Focus input by default when clicking on a
 dropdown field in the cataloguing editor
In-Reply-To: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31646-70-gfQyTi1kt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31646

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:05:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:05:42 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-xLQ5IOVo9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:06:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:06:18 +0000
Subject: [Koha-bugs] [Bug 31465] Link system preference tabs to correct
 manual pages
In-Reply-To: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31465-70-zD1Hb0hfsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #19 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:15:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:15:02 +0000
Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard
 shortcuts
In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31818-70-SYlM35hwcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
21.05.x not affected, no backport.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:16:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:16:08 +0000
Subject: [Koha-bugs] [Bug 32110] Duplicated additional content entries on
 DBRev 210600016
In-Reply-To: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32110-70-eJV9PpI6Wb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32110

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:16:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:16:32 +0000
Subject: [Koha-bugs] [Bug 31482] Label creator does not call barcodedecode
In-Reply-To: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31482-70-QSi6hcKahj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31482

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:16:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:16:57 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-VyTF0XabUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #17 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:16:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:16:58 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-Xx7IcBelgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348
Bug 15348 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:16:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:16:59 +0000
Subject: [Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha
 namespace [OMNIBUS]
In-Reply-To: <bug-21204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21204-70-JQX8k72ocw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204
Bug 21204 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:16:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:16:59 +0000
Subject: [Koha-bugs] [Bug 29959] Populate prices when creating an order with
 the API
In-Reply-To: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29959-70-8SG21sUeYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29959
Bug 29959 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 01:17:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 00:17:00 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-cU93GX9x72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171
Bug 32171 depends on bug 29955, which changed state.

Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 05:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 04:04:48 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-5R3Mn8ATxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #27 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Kyle M Hall from comment #22)
> (In reply to Victor Grousset/tuxayo from comment #21)
> > That's why I wondered if there was any gain compared to just storing the
> > passwords into koha-conf.xml directly? (or another file)
> 
> Simply put, imo, that would mean librarians could no longer update that data
> without help from the server administrator, making their jobs more difficult.

Hence the earlier «maybe Koha can't write to that file and that would need a
separate file»


(In reply to David Cook from comment #26)
> So sysadmins really need to keep in mind that the database and server-side
> config need to be restored together.

Ah yes, so actually encrypting data in the DB does not protect from a backup
leak. (I wrongly said that earlier) Since a backup should have the config
files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 05:09:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 04:09:43 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-pwGDctxRar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #2 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> The tricky thing is that we don't currently have a way of noting which key was used to encrypt which field.

As long as there is one key at the time, it's not needed. The update process
should be one transaction to guaranty that though.


> However, we have no easy way to change key should that key be leaked or found to be to simple to crack


It's generated so cracking shouldn't be an issue. As for a leak, yes a
webserver misconfiguration or a vulnerability in Koha or another app on the
same server could expose the config file while still having the DB unleaked.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 05:18:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 04:18:02 +0000
Subject: [Koha-bugs] [Bug 32065] Invalid YAML for some system preferences
In-Reply-To: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32065-70-4Mk7Ged0iS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32065

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> Hm I cannot test that

This should work:
cd stuff/cats/world-domination-plan/koha-testing-docker-directory ;
KOHA_IMAGE=master-bionic bin/ktd up


> How should we proceed here and does only the test fail or are there also issues in the GUI?

Good question, I didn't check which UI action access this data. Even if it's a
bug in the version of some YAML lib in Ubuntu 18.04 (and so the YAML is valid)
it's possible that it causes an issue when Koha on Ubuntu 18.04 tries to access
the data with that same lib.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 11:57:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 10:57:38 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-vZDT2tiauy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
A major bug, a silly easy fix, but noone to QA? :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:21:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:21:39 +0000
Subject: [Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually
 authorize
In-Reply-To: <bug-25797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25797-70-u0Ee38lmhH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Is this still valid? Noting Bug 31378 has now been pushed upstream.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:24:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:24:09 +0000
Subject: [Koha-bugs] [Bug 32354] New: Handle session_state param given by
 OAuth identity provider
Message-ID: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

            Bug ID: 32354
           Summary: Handle session_state param given by OAuth identity
                    provider
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

We're trying Bug 31378 in production with OpenID Connect and Azure AD.

Azure is passing back a parameter session_state which causes Koha to throw a
'malformed query string' error

[{"message":"Malformed query string","path":"\/query\/session_state"}]

Believe this means we need to add session_state to the list of parameters Koha
can expect from the IdP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:27:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:27:47 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
 identity provider
In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32354-70-HK1v4yagKz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31378
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378
[Bug 31378] Add a generic OAuth2/OIDC client implementation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:27:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:27:47 +0000
Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client
 implementation
In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31378-70-0eNNgASUSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
[Bug 32354] Handle session_state param given by OAuth identity provider
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:27:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:27:53 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
 identity provider
In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32354-70-xkCgapZxhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 144274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144274&action=edit
Bug 32354: Accept session_state param given by OAuth IdP

This patch ensures Koha doesn't throw an error if the IdP hands back a
session_state parameter.

To test:

1) Set up an identity provider
2) On the IdP's configuration, make it hand back a session_state
3) Confirm authentication using OIDC works with and without the
session_state

Sponsored-by: Plant & Food Research

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:28:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:28:44 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
 identity provider
In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32354-70-Cy4XWlUdBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch ensures Koha
      release notes|                            |doesn't throw an error if
                   |                            |the IdP hands back a
                   |                            |session_state parameter.
   Patch complexity|---                         |Trivial patch
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:41:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:41:10 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-r2TahSedYk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[Intranet/REST-API]         |Searching patrons by letter
                   |Searching patrons by letter |broken when using
                   |broken when using           |non-mandatory extended
                   |non-mandatory extended      |attributes
                   |attributes                  |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:42:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:42:37 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
 receive from rabbitmq are in 'new' state
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-cXyv72eggm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Background worker doesn't   |Background worker doesn't
                   |check jobs receive from     |check jobs receive from
                   |rabbitmq are in 'new'       |rabbitmq are in 'new' state
                   |state.                      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:44:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:44:34 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-foSPzVVbo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sounds more like an enh than a bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 22:45:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 21:45:20 +0000
Subject: [Koha-bugs] [Bug 19361] Linking an authorised value category to a
 field in a framework can lose data
In-Reply-To: <bug-19361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19361-70-OitrrWKtQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Nov 27 23:03:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 22:03:58 +0000
Subject: [Koha-bugs] [Bug 32335] Allow stock rotation items to be moved
 several stages ahead
In-Reply-To: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32335-70-HPbXpTU3Ck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 00:26:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 23:26:32 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
 identity provider
In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32354-70-GNptkUI5g2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I noticed this during testing as well. I was able to turn off session
management in Keycloak, but that might not be possible in all identity
providers. 

I'll come back to this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 00:31:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 23:31:47 +0000
Subject: [Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually
 authorize
In-Reply-To: <bug-25797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25797-70-kFLM4WARVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Aleisha Amohia from comment #6)
> Is this still valid? Noting Bug 31378 has now been pushed upstream.

Bug 31378 is unrelated. This bug is about using OAuth tokens from the
/api/v1/oauth/token endpoint. 

I don't think this bug was ever valid.

I've only used the Cookie auth and HTTP Basic auth for the REST API, so I can't
really speak to the OAuth2 auth for the REST API, but the issue report and
patch don't really make sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 00:42:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 23:42:20 +0000
Subject: [Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually
 authorize
In-Reply-To: <bug-25797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25797-70-vikcEtwXF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #7)
> (In reply to Aleisha Amohia from comment #6)
> > Is this still valid? Noting Bug 31378 has now been pushed upstream.
> 
> Bug 31378 is unrelated

That said, I have thought about how it would be cool to use tokens from an OIDC
IdP to allow access to Koha's REST API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 00:46:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 23:46:15 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-DTKS6WfM72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #61 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Updated doc to reflect this:
https://wiki.koha-community.org/wiki/System_requirements_and_recommendations

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 00:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Nov 2022 23:57:25 +0000
Subject: [Koha-bugs] [Bug 32078] We should have an easy way for an
 administrator to update the encryption keys
In-Reply-To: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32078-70-4ZAyeNcIdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32078

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Victor Grousset/tuxayo from comment #2)
> > The tricky thing is that we don't currently have a way of noting which key was used to encrypt which field.
> 
> As long as there is one key at the time, it's not needed. The update process
> should be one transaction to guaranty that though.

That's not going to scale. If you have a large number of amount of data, that's
going to be slow, require downtime, and potentially put unnecessary load on the
database server. Large transactions are rarely a programmer's friend. 

That said, it would be easier in the short-term and for small databases. So
certainly better than nothing.

> > However, we have no easy way to change key should that key be leaked or found to be to simple to crack
> 
> 
> It's generated so cracking shouldn't be an issue. As for a leak, yes a
> webserver misconfiguration or a vulnerability in Koha or another app on the
> same server could expose the config file while still having the DB unleaked.

Theoretically we might learn of new computing methods that mean the generated
key is too weak, and we need to employ a different algorithm. What Martin is
saying is that there's no way to currently re-encrypt using a stronger/unknown
key.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 01:26:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 00:26:10 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-gkFZwls7XS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> This patch adds the 'Rosalie' codename to the 22.11 release and adds corresponding support to the about page for displaying it.

Thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 08:28:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 07:28:35 +0000
Subject: [Koha-bugs] [Bug 32355] New: Add class url to all URL syspref
Message-ID: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355

            Bug ID: 32355
           Summary: Add class url to all URL syspref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Hi,

Some syspref aren't defined as class url and their input field is too small.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 08:33:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 07:33:21 +0000
Subject: [Koha-bugs] [Bug 32355] Add class url to all URL syspref
In-Reply-To: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32355-70-OecuZQtUNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355

--- Comment #1 from Didier Gautheron <didier.gautheron at biblibre.com> ---
Created attachment 144275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144275&action=edit
Bug 32355: Add css class url to URL syspref

Add missing css class to URL syspref.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 08:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 07:33:43 +0000
Subject: [Koha-bugs] [Bug 32355] Add class url to all URL syspref
In-Reply-To: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32355-70-QUaELuZ7rL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 08:57:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 07:57:13 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-RiOC30gzo6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144245|0                           |1
        is obsolete|                            |
 Attachment #144246|0                           |1
        is obsolete|                            |
 Attachment #144247|0                           |1
        is obsolete|                            |
 Attachment #144248|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144276&action=edit
Bug 32350: Use array_minus and ignore nesting

Note: Test will be extended in follow-up. This fixes the
module_bit hash to follow the FK path from user_permissions
to permissions to userflags. One step was missed in the
existing test, although it did not fail. The change here
revealed that now.

Test plan:
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 08:57:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 07:57:17 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-Ptj52ULSKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 144277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144277&action=edit
Bug 32350: Add subtest for bad columns

Test plan:
Run t/db_dependent/TestBuilder.t
And now run the whole test suite :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 08:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 07:58:00 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-rRUHjattMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #28)
> First and last patches are useless, can we remove them?

So I did now, making Martin loose his attribution. One of the reasons why I
didnt do it in the first place..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:01:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:01:56 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-fpKqKkleSd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:04:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:04:43 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-3am1VcLV4j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > Sure about this change? This has been working for years?
> 
> We have no default on FK

A FK might have a default value. We should not make assumptions based on the
current state of our tables. If someone adds one, we forget to update something
else, etc. etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:18:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:18:29 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-tpf0nGOxGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> Entered a rabbit hole here, and found a TestBuilder bug I think.

Creating a TestBuilder bug, I tend to think..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:20:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:20:18 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-kl7uwRI9ww@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Shouldnt we do something like this:

diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
index 5a08b3a018..92068f83c4 100644
--- a/t/lib/TestBuilder.pm
+++ b/t/lib/TestBuilder.pm
@@ -583,6 +583,8 @@ sub _gen_default_values {
             damaged            => 0,
             materials          => undef,
             more_subfields_xml => undef,
+        },
+        ItemGroupItem => {
             item_group_id      => undef,
         },
         Category => {


There is no such field in items:
CREATE TABLE `item_group_items` (
  `item_group_items_id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'id for the
group/item link',
  `item_group_id` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key making this
table a 1 to 1 join from items to item groups',
  `item_id` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key linking this table
to the items table',

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:21:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:21:07 +0000
Subject: [Koha-bugs] [Bug 32353] items.item_group_id should be undefined in
 tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-w5Z5sNXJIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
We need a good test here before we change TestBuilder imo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:28:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:28:43 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-yqkE76B0e4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Remember to set 'Needs Signoff' Matt ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:31:35 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
 receive from rabbitmq are in 'new' state
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-ZP2wOhXMSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au,
                   |                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am not sure this is the correct place, shouldn't it be in
Koha::BackgroundJob->process?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:32:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:32:07 +0000
Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items
In-Reply-To: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26860-70-dvHb98xCpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

--- Comment #25 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Maybe can now be implemented with Bug 17170

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:35:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:35:26 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
 receive from rabbitmq are in 'new' state
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-KWgFTuza9e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144278&action=edit
[ALTERNATIVE-PATCH] Bug 32305: Don't process a job if its status is not 'new'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:35:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:35:59 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
 receive from rabbitmq are in 'new' state
In-Reply-To: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32305-70-1fDKGIHsQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Patch for discussion, will need tests if we go with it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:37:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:37:58 +0000
Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items
In-Reply-To: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26860-70-0xoA3rSMRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:38:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:38:10 +0000
Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items
In-Reply-To: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26860-70-5XWxNDTrn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17170

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:38:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:38:10 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-85z3hc2AGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26860

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 09:51:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 08:51:14 +0000
Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
In-Reply-To: <bug-31897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31897-70-WjQcJpxUrU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This looks great

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 10:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 09:15:04 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
 in tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-4lHo3r1UPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|items.item_group_id should  |reserves.item_group_id
                   |be undefined in tests by    |should be undefined in
                   |default                     |tests by default

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 10:15:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 09:15:53 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
 in tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-OgERMwBOcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
it's reserves.item_group_id, not items.item_group_id. I've noticed my mistake
on Friday, and correct the patch but... hadn't attached it here it seems :-/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 10:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 09:16:55 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
 in tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-Q15FaeTSmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144253|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144279&action=edit
Bug 32353: Don't generate item group for holds in tests

See bug 31447, we don't want the tests to deal with potential failures
because of some item groups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 10:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 09:21:58 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
 in tests by default
In-Reply-To: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32353-70-n2gjI6kgM4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
# Subtest: transferbook tests
    1..9
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
    ok 1 - Koha::Patron->store raises an exception on missing params
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
    ok 2 - Koha::Patron->store raises an exception on missing params
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
    ok 3 - Koha::Patron->store raises an exception on missing params
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/Koha/Objects.pm line 96
    # Looks like you planned 9 tests but ran 3.
not ok 57 - transferbook tests
#   Failed test 'transferbook tests'
#   at t/db_dependent/Circulation.t line 5394.
Exception 'Koha::Exceptions::MissingParameter' thrown 'The to parameter is
mandatory'
# Looks like your test exited with 11 just after 57.

Might be something else ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 10:40:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 09:40:38 +0000
Subject: [Koha-bugs] [Bug 31933] Import patrons fails when patron attribute
 value contains a comma
In-Reply-To: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31933-70-jwp64C9e6M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
We investigated this a little further last week.. It's a bit strange to allow
more fields in the rows than in the header that describes which rows are
available.

Jacob is working on refining that to give clear errors when we find such cases
in the input data and also add a bit more documentation around full quoting
with escaped quotes the attributes field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 10:55:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 09:55:59 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-NMwSeSbGPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Checking the git tree feels like the right approach.

Must admit, I've never tried to run the tests from outside of the kohaclone..
but that's doesn't mean there isn't someone out there doing that.

I think I'd suggest going with this patch and documenting that the expectation
is that tests are run from inside the project somewhere.  I can't see any
obvious flaws with this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 12:02:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 11:02:54 +0000
Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
 each release
In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26947-70-41qqfwbdXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32334

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 12:02:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 11:02:54 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32334-70-xDDn3nsyeq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
            Summary|Working title               |Sync comments in database
                   |                            |with schema
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26947

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 12:05:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 11:05:05 +0000
Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for
 each release
In-Reply-To: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26947-70-J7gHH0Py8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #66 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
To still catch differences more easily, I will submitting some code on bug
32334 to sync the comments between actual database and schema.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 12:29:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 11:29:30 +0000
Subject: [Koha-bugs] [Bug 32355] Add class url to all URL syspref
In-Reply-To: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32355-70-AoIVKUEd1t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 12:29:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 11:29:35 +0000
Subject: [Koha-bugs] [Bug 32355] Add class url to all URL syspref
In-Reply-To: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32355-70-ARwnzZRpNf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144275|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 144280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144280&action=edit
Bug 32355: Add css class url to URL syspref

Add missing css class to URL syspref.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 12:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 11:30:53 +0000
Subject: [Koha-bugs] [Bug 32355] Add class url to all URL syspref
In-Reply-To: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32355-70-Ig8h7FNP2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32355

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c
                   |ity.org                     |om
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Changed assignee.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 13:23:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 12:23:39 +0000
Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24239-70-gSx7Zxjk8g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 13:26:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 12:26:09 +0000
Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24239-70-x2zORp2uY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #36 from Hans Pålsson <hans.palsson at hkr.se> ---
It would be of great value to many Swedish libraries if this could be
backported to 22.05.x (if possible also 21.11.x). 
Thanks everyone for the great work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 13:33:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 12:33:10 +0000
Subject: [Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with
 (older) database revisions
In-Reply-To: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30486-70-4vqjd2VmgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
[Bug 32334] Sync comments in database with schema
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 13:33:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 12:33:10 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32334-70-XVLSveHsJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30486


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
[Bug 30486] [OMNIBUS] Synchronize database schema with (older) database
revisions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 13:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 12:33:43 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32334-70-LrPlNT0bKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 13:54:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 12:54:31 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-SFCaeuRjD7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144281&action=edit
Bug 30719: Batch requests minor misc improvements

- Fix wrong link in message in case there are no requests batch
- Detail of batch update - View status of any request within a batch
- Fix typo to correctly display status code on batch statuses list

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 14:03:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 13:03:55 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-BWEEWCuWQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 14:17:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 13:17:51 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-Oh1mVDIX2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I agree only checking things in the git tree is the right approach.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 14:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 13:31:37 +0000
Subject: [Koha-bugs] [Bug 21544] Self Check-in tool does not trigger holds
In-Reply-To: <bug-21544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21544-70-3PoEQeqxEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21544

Laura <Laura.escamilla at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.05                       |22.05
                 CC|                            |Laura.escamilla at bywatersolu
                   |                            |tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 14:35:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 13:35:03 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - add note about
 updating vendor tax rates where required
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-FIHpR1NNEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |note to the TaxRates system
                   |                            |preference about updating
                   |                            |vendors tax rates when the
                   |                            |TaxRates system preference
                   |                            |values are changed or
                   |                            |removed. (Vendors retain
                   |                            |the original value entered,
                   |                            |and this is used to
                   |                            |calculate the tax rate for
                   |                            |orders.)
            Summary|TaxRate system preference - |TaxRate system preference -
                   |incorrect default value     |add note about updating
                   |used and warning message on |vendor tax rates where
                   |order form                  |required
           Severity|normal                      |trivial
             Status|NEW                         |ASSIGNED
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 14:38:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 13:38:16 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - add note about
 updating vendor tax rates where required
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-gGRk80asU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 14:38:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 13:38:20 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - add note about
 updating vendor tax rates where required
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-EvVp5dy275@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 144282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144282&action=edit
Bug 31984: TaxRate preference - add note about vendor updates

If a value for the TaxRates system preference is changed or
removed, vendors retain the original value recorded in their
tax rate field.

The vendor tax rate is used to calculate prices for orders
added to a basket. Where the tax rate doesn't match with the
system preference, a warning message is displayed on the order
form "Tax rate not defined in system preference TaxRates!".

This patch adds a note to the system preference description
about updating vendor tax rate information where required.

Test plan:
1. Check the values recorded for the TaxRates system preference.
2. For a vendor (Acquisitions > search for a vendor > Edit vendor),
   check the value recorded in the tax rate field.
3. Note that the tax rate field is populated from a dropdown list
   using values from the TaxRates system preference.
4. Change the TaxRates system preferemce to remove a tax
   rate. For example, change 0|0.12|0.1965 to 0|0.12.
5. Refresh the vendor page.
6. Note that the vendor tax rate remains as the original value
   until you edit the vendor.
7. Apply the patch.
8. Review the description for the TaxRates system preference and
   make sure the new note about updating vendor tax rates where
   required makes sense.
9. Sign off!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 15:28:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 14:28:30 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-UKsB2dGvJA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 15:28:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 14:28:36 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-RLy1Y4gUpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144242|0                           |1
        is obsolete|                            |

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144283&action=edit
Bug 32352: Make xt/check_makefile.t check directories in git index

It's failing if 'node_modules' exists. We could simply skip it, but it
seems that it would be better to actually list directories that are part
of the git index only.

The question is: do we actually support test execution outside of a git
directory?

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 15:34:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 14:34:12 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-7oyQoQv1tJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 15:49:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 14:49:23 +0000
Subject: [Koha-bugs] [Bug 32221] password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-vUX5Copld1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

--- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144284&action=edit
Bug 32221: Borrowers.password should no longer be an option

When creating a notice template the user has the option to add the borrower's
password to the template. This should be removed as the password should not be
an option to be added to a notice.

Test plan:
1) Navigate to Tools > Notices and slips
2) Either create a new notice or edit an existing notice
3) Observe that in the list of fields available to insert into the message
body, there is the option for "borrowers.password"
4) Apply patch
5) Navigate to the same menu
6) Observe that the "borrowers.password" option is now no longer visible

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 15:49:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 14:49:59 +0000
Subject: [Koha-bugs] [Bug 32221] password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-8CuKkiGXsG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matt.blenkinsop at ptfs-europe
                   |                            |.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:26:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:26:09 +0000
Subject: [Koha-bugs] [Bug 10950] Add pronoun field to patron record
In-Reply-To: <bug-10950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10950-70-MvR35cleDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add preferred pronoun field |Add pronoun field to patron
                   |to patron record            |record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:50:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:50:34 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-r9hjhpsdlp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144285&action=edit
Bug 30719: DB, API & tests

This commit adds the following:

- A database update that adds an "illbatches" table, a
"illrequest.batch_id" foreign key and an "illbatches.borrowernumber"
foreign key
- Illbatch and Illbatches Koha objects
- Adds 'batch' accessor to Illrequest object
- CRUD API endpoints for working with ILL batches
- Unit tests of the Koha objects and API endpoints
- Adds 'batch_id' filter to /illrequests endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:51:30 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-At45ooOCpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144286&action=edit
Bug 30719: Batch ILL requests

- Add API endpoint for ILL request creation
- UI for creation of ILL batches, including:
  - Ability to paste in list of identifier
  - Auto metadata enrichment for each identifier, using installed third party
service API plugins
  - Auto retrieval of identifier availability, using installed third party
service API plugins
  - Auto creation of local requests within batch
- UI for management of existing ILL batches, including adding requests to, and
removing requests from, batches
- Additional UI to allow users to navigate from requests to their enclosing
batches and vice-versa

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:51:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:51:59 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-T6SSCNtJg5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144287&action=edit
Bug 30719: Logging of batch operations

This commit adds logging of the following batch operations:

- Batch creation
- Batch update (Updating of the batch itself, not its contents)
- Batch delete

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:52:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:52:31 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-fXp6WuZbhW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144288&action=edit
Bug 30719: Batch statuses

This commits adds the following provision for batch statuses:

- Database updates
- Object definitions
- CRUD REST API
- Unit tests
- UI adding support for batch statuses in batch UI
- Admin UI for managing batch statuses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:53:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:53:13 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-DDQMPmEVY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144285|0                           |1
        is obsolete|                            |

--- Comment #6 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144289&action=edit
Bug 30719: DB, API & tests

This commit adds the following:

- A database update that adds an "illbatches" table, a
"illrequest.batch_id" foreign key and an "illbatches.borrowernumber"
foreign key
- Illbatch and Illbatches Koha objects
- Adds 'batch' accessor to Illrequest object
- CRUD API endpoints for working with ILL batches
- Unit tests of the Koha objects and API endpoints
- Adds 'batch_id' filter to /illrequests endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 16:54:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 15:54:20 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-AVMAMlllsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Apply all current 5 patches, on ktd, preparation:
- Run DBIC
- Run reset_all
- Enable ILLModule sys pref
- Default ILLLIBS patron category needs to exist, create that
- At least one ILL batch status needs to exist, admin -> ILL batch statuses,
create for example name:NEW status:NEW
- At least one ILL Backend with "provide_batch_requests" capability needs to
exist, create ReprintsDesk backend from
https://github.com/PTFS-Europe/koha-ill-reprintsdesk
- Install ReprintsDesk backend dependencies: cpan XML::Compile XML::Smart
XML::Compile:WSDL11 XML::Compile::SOAP12
- Need to restart plack here
- Update backend_directory in koha-conf.xml to
<backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory>
- Need to restart plack here
- Install metadata enrichment plugin pubmedid from
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0
through "Manage plugins" in admin
- Need to restart plack here
- Go to ILL Requests admin area, click "New ILL batch request" and select
ReprintsDesk
- Create new batch (insert name, cardnumber and library) and press "continue"
- Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process
identifiers"
- After processing is complete, click "add items to batch" and then "finish and
view batch"

Verify that:
- The items requested in the batch are now illrequests in Koha, and are part of
the batch that was just created
- Clicking on "Batch requests" lists all batch requests created
- Clicking on a batch name lists only the requests from that batch
- If a batch is deleted, whatever requests previously on that batch are not
deleted (they have been detached, their batch_id is now NULL)
- When editing a request that is part of a batch, it's possible to change which
batch the request is part of, or none.

Test logs:
- Before doing the above, enable illlog sys pref
- Do some CRUD actions on batch requests
- Check log viewer -> module "Interlibrary loans"
- Verify that the actions performed have been logged

Run tests:
perl t/db_dependent/Illbatches.t
perl t/db_dependent/Illbatchstatuses.t #currently failing, will check why soon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:06:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:06:46 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-eCqmRv5Fsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144281|0                           |1
        is obsolete|                            |

--- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144290&action=edit
Bug 30719: Batch requests minor misc improvements

    - Fix wrong link in message in case there are no requests batch
    - Detail of batch update - View status of any request within a batch
    - Fix typo to correctly display status code on batch statuses list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:26:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:26:28 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-iYNXjRKxP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144289|0                           |1
        is obsolete|                            |

--- Comment #9 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144291&action=edit
Bug 30719: DB, API & tests

This commit adds the following:

- A database update that adds an "illbatches" table, a
"illrequest.batch_id" foreign key and an "illbatches.borrowernumber"
foreign key
- Illbatch and Illbatches Koha objects
- Adds 'batch' accessor to Illrequest object
- CRUD API endpoints for working with ILL batches
- Unit tests of the Koha objects and API endpoints
- Adds 'batch_id' filter to /illrequests endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:27:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:27:01 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-lyliJEtm8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144286|0                           |1
        is obsolete|                            |

--- Comment #10 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144292&action=edit
Bug 30719: Batch ILL requests

- Add API endpoint for ILL request creation
- UI for creation of ILL batches, including:
  - Ability to paste in list of identifier
  - Auto metadata enrichment for each identifier, using installed third party
service API plugins
  - Auto retrieval of identifier availability, using installed third party
service API plugins
  - Auto creation of local requests within batch
- UI for management of existing ILL batches, including adding requests to, and
removing requests from, batches
- Additional UI to allow users to navigate from requests to their enclosing
batches and vice-versa

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:27:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:27:29 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-f9XuqRwIFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144287|0                           |1
        is obsolete|                            |

--- Comment #11 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144293&action=edit
Bug 30719: Logging of batch operations

This commit adds logging of the following batch operations:

- Batch creation
- Batch update (Updating of the batch itself, not its contents)
- Batch delete

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:27:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:27:58 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-EjH3GCI8N7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144288|0                           |1
        is obsolete|                            |

--- Comment #12 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144294&action=edit
Bug 30719: Batch statuses

This commits adds the following provision for batch statuses:

- Database updates
- Object definitions
- CRUD REST API
- Unit tests
- UI adding support for batch statuses in batch UI
- Admin UI for managing batch statuses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:28:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:28:23 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-UtbLddXq17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144290|0                           |1
        is obsolete|                            |

--- Comment #13 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144295&action=edit
Bug 30719: Batch requests minor misc improvements

- Fix wrong link in message in case there are no requests batch
- Detail of batch update - View status of any request within a batch
- Fix typo to correctly display status code on batch statuses list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:29:57 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-hyDuvd9AXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:39:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:39:29 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-bPrmjQG0Cd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #14 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Apply all current 5 patches, on ktd, preparation:
- Run DBIC
- Run reset_all
- Enable ILLModule sys pref
- Default ILLLIBS patron category needs to exist, create that
- At least one ILL batch status needs to exist, admin -> ILL batch statuses,
create for example name:NEW status:NEW
- At least one ILL Backend with "provide_batch_requests" capability needs to
exist, create ReprintsDesk backend from
https://github.com/PTFS-Europe/koha-ill-reprintsdesk
- Install ReprintsDesk backend dependencies: cpan XML::Compile XML::Smart
XML::Compile:WSDL11 XML::Compile::SOAP12
- Need to restart plack here
- Update backend_directory in koha-conf.xml to
<backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory>
- Need to restart plack here
- Install metadata enrichment plugin pubmedid from
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0
through "Manage plugins" in admin
- Need to restart plack here
- Go to ILL Requests admin area, click "New ILL batch request" and select
ReprintsDesk
- Create new batch (insert name, cardnumber and library) and press "continue"
- Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process
identifiers"
- After processing is complete, click "add items to batch" and then "finish and
view batch"

Verify that:
- The items requested in the batch are now illrequests in Koha, and are part of
the batch that was just created
- Clicking on "Batch requests" lists all batch requests created
- Clicking on a batch name lists only the requests from that batch
- If a batch is deleted, whatever requests previously on that batch are not
deleted (they have been detached, their batch_id is now NULL)
- When editing a request that is part of a batch, it's possible to change which
batch the request is part of, or none.

Test logs:
- Before doing the above, enable illlog sys pref
- Do some CRUD actions on batch requests
- Check log viewer -> module "Interlibrary loans"
- Verify that the actions performed have been logged

Run tests:
perl t/db_dependent/Illbatches.t
perl t/db_dependent/Illbatchstatuses.t #currently failing, will check why soon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:44:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:44:46 +0000
Subject: [Koha-bugs] [Bug 30808] Release team 23.05
In-Reply-To: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30808-70-pQdIJhbjHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hopefully I split the commits up enough that it should be simple enough to
backport what's needed and ignore the rest ;P

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:49:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:49:59 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-Snl4MJnhqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

--- Comment #15 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144296&action=edit
Koha 22.11.00 Rosalie is here!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:53:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:53:29 +0000
Subject: [Koha-bugs] [Bug 31651] Log message incorrect in
 Auth_with_shibboleth.pm
In-Reply-To: <bug-31651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31651-70-2z9UIzJ7KG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651

Jacob O'Mara <jacob.omara at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jacob.omara at ptfs-europe.com
           Assignee|koha-bugs at lists.koha-commun |jacob.omara at ptfs-europe.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 17:59:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 16:59:22 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-7rlJsIPydo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144296|0                           |1
        is obsolete|                            |

--- Comment #16 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144297&action=edit
Koha 22.11.00 Rosalie is here!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:26:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:26:30 +0000
Subject: [Koha-bugs] [Bug 31933] Import patrons fails when patron attribute
 value contains a comma
In-Reply-To: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31933-70-VV80odFChC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31933

Jacob O'Mara <jacob.omara at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Jacob O'Mara <jacob.omara at ptfs-europe.com> ---
After some more extensive searching it appears that the issue lies in how smart
quotes are being handled within the spreadsheet editor itself prior to
uploading to the koha db as I was getting some weird results once saving the
csv in LibreOffice and opening in text editor.

The easiest way we discussed to solve this is possibly just to disable smart
quotes entirely in the spreadsheet editor and amend the documentation notes to
specify the issues between escape quotes and smart quotes. Commas etc then seem
to work as expected once disabled and in the format you specified below,
bounded within one cell:

"COURSE:Government, Economics and Commerce","CSCODE:ABC1234"

we could probably do some kind of regex fix for the smart quotes issue as you
suggested but Martin believes this is something we should discuss further
first. 

It appears the error handling does in fact catch the mismatch of columns:values
and probably won't need any additional tinkering.

Let me know what you think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:27:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:27:34 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
 in-transit items
In-Reply-To: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-1VWYKAoUVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Carolyn Hughesman <chughesman at cclsny.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chughesman at cclsny.org

--- Comment #6 from Carolyn Hughesman <chughesman at cclsny.org> ---
Hoping to revive this bug.  On the search results page in the staff interface,
items are still counted as available both when they are in transit and sitting
on the holds shelf.

This is confusing to our staff.  Items should only be listed as available if
they are physically on the shelf.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:42:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:42:01 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-pYYkMuQfQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144291|0                           |1
        is obsolete|                            |

--- Comment #17 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144298&action=edit
Bug 30719: DB, API & tests

This commit adds the following:

- A database update that adds an "illbatches" table, a
"illrequest.batch_id" foreign key and an "illbatches.borrowernumber"
foreign key
- Illbatch and Illbatches Koha objects
- Adds 'batch' accessor to Illrequest object
- CRUD API endpoints for working with ILL batches
- Unit tests of the Koha objects and API endpoints
- Adds 'batch_id' filter to /illrequests endpoint

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:42:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:42:06 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-XTyTzVKuXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144292|0                           |1
        is obsolete|                            |

--- Comment #18 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144299&action=edit
Bug 30719: Batch ILL requests

- Add API endpoint for ILL request creation
- UI for creation of ILL batches, including:
  - Ability to paste in list of identifier
  - Auto metadata enrichment for each identifier, using installed third party
service API plugins
  - Auto retrieval of identifier availability, using installed third party
service API plugins
  - Auto creation of local requests within batch
- UI for management of existing ILL batches, including adding requests to, and
removing requests from, batches
- Additional UI to allow users to navigate from requests to their enclosing
batches and vice-versa

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:42:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:42:11 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-ygVuGN5F7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144293|0                           |1
        is obsolete|                            |

--- Comment #19 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144300&action=edit
Bug 30719: Logging of batch operations

This commit adds logging of the following batch operations:

- Batch creation
- Batch update (Updating of the batch itself, not its contents)
- Batch delete

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:42:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:42:17 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-uYLpcbSwlJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144294|0                           |1
        is obsolete|                            |

--- Comment #20 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144301&action=edit
Bug 30719: Batch statuses

This commits adds the following provision for batch statuses:

- Database updates
- Object definitions
- CRUD REST API
- Unit tests
- UI adding support for batch statuses in batch UI
- Admin UI for managing batch statuses

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:42:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:42:22 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-IdqCEFcbIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144295|0                           |1
        is obsolete|                            |

--- Comment #21 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Created attachment 144302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144302&action=edit
Bug 30719: Batch requests minor misc improvements

- Fix wrong link in message in case there are no requests batch
- Detail of batch update - View status of any request within a batch
- Fix typo to correctly display status code on batch statuses list

Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:42:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:42:57 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-huceaHFCFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:46:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:46:18 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-tjzwuGJtfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Katharine Dixon <katharin at ci.salinas.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katharin at ci.salinas.ca.us

--- Comment #8 from Katharine Dixon <katharin at ci.salinas.ca.us> ---
Comment on attachment 2796
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2796
on hold when limited to available

This issue is very troublesome for our Patron's requesting holds on Hot spots,
I hope that it can be resolved soon.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:48:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:48:32 +0000
Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create
 batch requests
In-Reply-To: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30719-70-nzakuAubvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144297|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:57:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:57:12 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - add note about
 updating vendor tax rates where required
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-ftQOaGDxoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 18:57:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 17:57:19 +0000
Subject: [Koha-bugs] [Bug 31984] TaxRate system preference - add note about
 updating vendor tax rates where required
In-Reply-To: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31984-70-dBQ1ksc11x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31984

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144282|0                           |1
        is obsolete|                            |

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 144303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144303&action=edit
Bug 31984: TaxRate preference - add note about vendor updates

If a value for the TaxRates system preference is changed or
removed, vendors retain the original value recorded in their
tax rate field.

The vendor tax rate is used to calculate prices for orders
added to a basket. Where the tax rate doesn't match with the
system preference, a warning message is displayed on the order
form "Tax rate not defined in system preference TaxRates!".

This patch adds a note to the system preference description
about updating vendor tax rate information where required.

Test plan:
1. Check the values recorded for the TaxRates system preference.
2. For a vendor (Acquisitions > search for a vendor > Edit vendor),
   check the value recorded in the tax rate field.
3. Note that the tax rate field is populated from a dropdown list
   using values from the TaxRates system preference.
4. Change the TaxRates system preferemce to remove a tax
   rate. For example, change 0|0.12|0.1965 to 0|0.12.
5. Refresh the vendor page.
6. Note that the vendor tax rate remains as the original value
   until you edit the vendor.
7. Apply the patch.
8. Review the description for the TaxRates system preference and
   make sure the new note about updating vendor tax rates where
   required makes sense.
9. Sign off!

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 19:03:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 18:03:23 +0000
Subject: [Koha-bugs] [Bug 32348] Library public is missing from columns
 settings
In-Reply-To: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32348-70-cAU4p6FCW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 19:03:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 18:03:35 +0000
Subject: [Koha-bugs] [Bug 32348] Library public is missing from columns
 settings
In-Reply-To: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32348-70-Sfo1JB7ydj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32348

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144225|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 144304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144304&action=edit
Bug 32348: Add library public in columns settings

Bug 27360 added public info on libraries table.
This should be added to columns settings.
Currently the column "STMP server" can not be managed in settings.

Test plan :
Play with columns settings of table Administration > Libraries

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 19:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 18:08:46 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-ZH279BiyEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 19:37:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 18:37:53 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-TdpjRSgcJE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |23.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 19:37:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 18:37:56 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-3iAZdVped7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:26:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:26:54 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-0C2e1ldfhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:27:00 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-4wZNmYSc1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 144305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144305&action=edit
Bug 32257: Label for patron attributes misaligned

Label has now been realigned to match the format of the fields above.

Test plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields
above

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:27:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:27:38 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-5CupXH4qTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
 Attachment #144210|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:31:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:31:13 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-Ltk3Uwldgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

--- Comment #3 from David Nind <david at davidnind.com> ---
Hi Matt.

I probably should have marked as Failed QA, but have amended your patch as this
is an easy change:

1. We normally use sentence case for field labels: I changed "Patron Attribute"
to "Patron attribute".

2. Commit message title: I changed the bug title in the patch, see the
development guidelines
https://wiki.koha-community.org/wiki/Commit_messages#Subject_line

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:42:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:42:45 +0000
Subject: [Koha-bugs] [Bug 32221] password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-P7n92FBC3f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:42:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:42:50 +0000
Subject: [Koha-bugs] [Bug 32221] password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-sJJCgudGAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144284|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 144306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144306&action=edit
Bug 32221: Borrowers.password should no longer be an option

When creating a notice template the user has the option to add the borrower's
password to the template. This should be removed as the password should not be
an option to be added to a notice.

Test plan:
1) Navigate to Tools > Notices and slips
2) Either create a new notice or edit an existing notice
3) Observe that in the list of fields available to insert into the message
body, there is the option for "borrowers.password"
4) Apply patch
5) Navigate to the same menu
6) Observe that the "borrowers.password" option is now no longer visible

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:43:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:43:30 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30409-70-PZDVWNwb3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Keywords|                            |rel_21_11_candidate

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
This is missing from 21.11.x - its dependent bug was pushed, however, which is
causing failures in libraries adding items to lists - please backport ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:43:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:43:57 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-zqLBz5Rjec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #31 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Arthur Suzuki from comment #29)
> thx pushed to 21.11.x for 21.11.12

This is causing a regression in 21.11.x - missing dependency bug 30409

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 20:44:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 19:44:41 +0000
Subject: [Koha-bugs] [Bug 32221] password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-P6l4qbKUlT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe
                   |ity.org                     |.com
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
Matt, I have added you as the assignee for the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 21:08:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 20:08:34 +0000
Subject: [Koha-bugs] [Bug 32221] Password entry should be removed from
 placeholder list in notices editor
In-Reply-To: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32221-70-P5RmiKUZKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|password entry should be    |Password entry should be
                   |removed from placeholder    |removed from placeholder
                   |list in notices editor      |list in notices editor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 21:16:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 20:16:56 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
 in-transit items
In-Reply-To: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-WMhZawOsKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just to explain why this is not as easy of a fix as it might sound:

The information if an item is on hold or in transfer is only found in the
reserves table right now. it's not part of the item records. 

In order to be able to exclude these from the availability search, the
information needs to be made available to the search engines. 

This means: The information needs to be added to the records, for example into
otherwise unused MARC fields at the time of indexing. And every time a hold
changed status, we'd need to automatically trigger reindexing of the record.

At the moment the filter only looks at information in the item record already.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 21:41:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 20:41:22 +0000
Subject: [Koha-bugs] [Bug 32356] New: fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
Message-ID: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

            Bug ID: 32356
           Summary: fr-FR installer dir
                    /kohadevbox/koha/installer/data/mysql/fr-FR already
                    exists.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: aleisha at catalyst.net.nz, frederic at tamil.fr

When installing a language that has already been installed before you'll end up
with this error:

fr-FR installer dir /kohadevbox/koha/installer/data/mysql/fr-FR already exists.

This is a problem, as the files in the directory won't be replaced with their
updated versions or files will be missing:

Hadn't been installed before:
kohadev-koha at kohadevbox:/kohadevbox/koha/misc/translator$ ls -l
../../installer/data/mysql/es-ES
total 12
drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 Nov 28 20:25 mandatory
drwxr-xr-x 4 kohadev-koha kohadev-koha 4096 Nov 28 20:25 marcflavour
drwxr-xr-x 2 kohadev-koha kohadev-koha 4096 Nov 28 20:25 optional


Had been installed before:
kohadev-koha at kohadevbox:/kohadevbox/koha/misc/translator$ ls -l
../../installer/data/mysql/fr-FR/
total 0

There have been reports on problems with installing/updating languages on the
mailing list and IRC:

https://lists.katipo.co.nz/pipermail/koha/2022-November/058691.html
https://lists.koha-community.org/pipermail/koha-devel/2022-November/047398.html
http://irc.koha-community.org/koha/2022-11-28#i_2464321

Something is not going well here.

Another thing:
The start page looks ok for es-ES but appears broken for de-DE in my test.
Still investigating, but also wondering if it's another file related issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 22:56:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 21:56:46 +0000
Subject: [Koha-bugs] [Bug 32357] New: Set
 borrower_message_preferences.days_in_advance default to NULL
Message-ID: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

            Bug ID: 32357
           Summary: Set borrower_message_preferences.days_in_advance
                    default to NULL
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at hypernova.fi
        QA Contact: testopia at bugs.koha-community.org

days_in_advance currently defaults to 0, but it should default to NULL because
all but one entry in message_attribute has takes_days=1 making it the exception
and not the default.

Current column default 0 is already ignored by
C4::Members::Messaging::SetMessagingPreference, see
https://github.com/Koha-Community/Koha/blob/8c367775470fcecdda54e28270b05d92834cd33f/C4/Members/Messaging.pm#L134
, so we should also make NULL default at database level instead.

Blocking Bug 18595 (because without this change some tests there will fail
unless we replicate the misuse of default values)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 22:58:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 21:58:54 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-uVZjzs692u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Lari Taskula from comment #0)
> because all but one entry in message_attribute has takes_days=1 making it
> the exception and not the default.

I of course meant to say that only one entry in message_attribute has
takes_days=1 making it the exception and not the default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 22:59:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 21:59:52 +0000
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31059-70-atbdveSHPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

--- Comment #1 from Chris Slone <cslone at camdencountylibrary.org> ---
Confirming that this does not get added to the koha-conf.xml. For anyone
looking for what to add it would be:

 <!-- Encryption key for crypted password or sensitive data -->
 <encryption_key>__ENCRYPTION_KEY__</encryption_key>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:01:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:01:14 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-S7XvKygGR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18595


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595
[Bug 18595] Move C4::Members::Messaging to Koha namespace
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:01:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:01:14 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
 namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-kuaBusohvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32357


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357
[Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:04:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:04:13 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-eN6r0haiMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:04:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:04:16 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-v3YoxiOxWy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

--- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 144307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144307&action=edit
Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:17:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:17:06 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-3yuFZiJ0QB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:17:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:17:11 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-BA7mMvMIgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144218|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 144308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144308&action=edit
Bug 31160: Required Fields in Patron API

The Patron API PUT request required the fields
"surname","address","city","library_id","category_id". Meanwhile the CSV import
page for patrons only requires "surname","library_id","category_id". The fields
for "address" and "city" have been removed from the "required" section of the
api>v1>swagger>definitions>patron.yaml file to match the CSV import page.

Test Plan:
1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty
body
2) Error message should ask for 5 missing fields as listed above
3) Apply patch
4) Restart Apache server using "restart_all" in your ktd shell
5) Resubmit your request
6) Error message should now only request "surname","library_id","category_id"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:20:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:20:39 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-nP0G6sH5l7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Hi Matt.

I'll let you fix up the title for the patch - it should be in sentence case.

David

Testing notes using KTD (koha-testing-docker):

1. I used Postman to make the request.

2. I had to put empty curly brackets in the body ({}) and select JSON as the
format to get the error message asking for the empty fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:23:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:23:41 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-ebe0VAvqBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

--- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> ---
Not sure how to test it thoroughly, but any case using SetMessagingPreference()
should not be affected as mentioned in comment #1 - as far as I understand only
direct SQL INSERT to borrower_message_preferences and inserts with DBIx object
(or TestBuilder) may cause regression. I found five tests making such
insertions using
$ grep -rn 'BorrowerMessagePreference'
and
$ grep -rn 'borrower_message_preferences'

t/db_dependent/cronjobs/advance_notices_digest.t
t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Koha/CurbsidePickups.t
t/db_dependent/Koha/Patrons.t
t/db_dependent/Patron/Messaging.t

I'll add these to the patch description.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Nov 28 23:26:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 22:26:37 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-JLdIbuYMnm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144307|0                           |1
        is obsolete|                            |

--- Comment #4 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 144309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144309&action=edit
Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL

To test:
1. prove t/db_dependent/cronjobs/advance_notices_digest.t
2. prove t/db_dependent/Letters/TemplateToolkit.t
3. prove t/db_dependent/Koha/CurbsidePickups.t
4. prove t/db_dependent/Koha/Patrons.t
5. prove t/db_dependent/Patron/Messaging.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 00:37:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 23:37:06 +0000
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31059-70-syptOV4E9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Yeah, this is an annoyance. The same problem exists for quite a few different
koha-conf.xml options :/.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 00:55:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 23:55:08 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-8ORZPhaWKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Tests pass both before and after the patch is applied.

However, I don't think the databaseupdate updates existing installations. I had
to do a reset_all to replicate a new installation (using koha-testing-docker).

Not that I really know how all this should work!

Testing notes:
1. Access the database: koha-mysql kohadev
2. Show the current database configuration - the default before the patch is
applied for days_in_advance is 0. SQL query: show columns from
borrower_message_preferences;
3. Apply the patch.
4. Update the database (updatedatabase).
5. Repeat steps 1-2 - the default for days_in_advance should now be NULL.[1]
6. Tests should pass:
   . prove t/db_dependent/cronjobs/advance_notices_digest.t
   . prove t/db_dependent/Letters/TemplateToolkit.t
   . prove t/db_dependent/Koha/CurbsidePickups.t
   . prove t/db_dependent/Koha/Patrons.t
   . prove t/db_dependent/Patron/Messaging.t

[1] The updatedatabase command didn't update the existing installation, I had
to do a reset_all to get the database to update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 00:57:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Nov 2022 23:57:40 +0000
Subject: [Koha-bugs] [Bug 32357] Set
 borrower_message_preferences.days_in_advance default to NULL
In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32357-70-BI1dpr0H38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi
                   |ity.org                     |

--- Comment #6 from David Nind <david at davidnind.com> ---
I've changed the assignee.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 01:24:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 00:24:45 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
 identity provider
In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32354-70-OESwiJLNlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
We need to document it better. Understand if the param name is standard, if it
needs to be carried around in responses as well, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 02:19:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 01:19:33 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
 identity provider
In-Reply-To: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32354-70-cbWyFJ09Bg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #3)
> We need to document it better. Understand if the param name is standard, if
> it needs to be carried around in responses as well, etc.

I'm not 100% sure what you mean, but I think I agree. I've got a deadline
tomorrow, but I'm hoping to look at this in December. I'll be testing with
Keycloak. 

That said, from what I've read so far at
https://openid.net/specs/openid-connect-session-1_0.html, it looks like the
session_state is just used by optional client side iframes for checking the
user's session status with the IdP. 

So I think we can accept session_state in the IdP's AuthN response without
actually supporting OIDC session management ourselves.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 02:28:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 01:28:34 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-H9P1JORmI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

--- Comment #3 from wainuiwitikapark at catalyst.net.nz ---
Created attachment 144310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144310&action=edit
Bug 32301: defaultSortField changes the default Sort By in Staff Client
Advanced Search

Use the system preference "defaultSortField" to choose the default Sort
By in the Staff Client Advances Search

To test:
1) Go to staff client
2) Go to Advanced Search
3) Notice the default Sort By value is "Relevance"
4) Go to system preferences
5) Go to "defaultSortField"
6) Change the value of the system preference
7) Go back to Advanced Search and refresh the page
8) Notice that there are no changes, the default Sort By is still
"Relevance"
9) Apply patch
10) Notice that changing the system preference now changes the default
Sort By in Advanced Search

Sponsored-by: National Institute of Atmospheric and Water Research

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 02:29:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 01:29:40 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-6e2PnYc6iq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 08:59:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 07:59:50 +0000
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31059-70-7AA237m5wM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We could add something to the about page and future release notes here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 09:25:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 08:25:15 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-FYOeJcOCe2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How to recreate the problem? I've run twice translate install fr-FR and don't
see the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 09:30:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 08:30:37 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-ttIJi8xgqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it should be visible when you run the commands koha-translate --update
language and the language is already installled. It also appeared for me when I
used the old way: kshell, cd misc/translator, perl translate install de-DE. I
always had the message.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 09:32:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 08:32:24 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-y9KqRyKdnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
On IRC I also talked to Tylathos in PM and he showed me the same error message
on his package installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:07:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:07:47 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-8I29Ae90gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I think there are several things here.

The de-DE interface is broken because of "% l: Unknown or unsupported format
specification"

To get the origin of the error:
% junitmsgfmt misc/translator/po/de-DE*

 <failure message="msgfmt
failure">misc/translator/po/de-DE-staff-prog.po:12520: 'msgstr' is not a valid
C format string, unlike 'msgid'. Reason: The character that terminates the
directive number 2 is not a valid conversion specifier.
 misc/translator/po/de-DE-staff-prog.po:66878: 'msgstr' is not a valid C format
string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
 msgfmt: found 2 fatal errors


12519 msgid "Are you sure you want to delete \"%s\"?"
12520 msgstr "Sind Sie sicher, dass Sie \"%s% löschen möchten?"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:10:50 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-pTcQATy2ZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #4)
> I think there are several things here.
> 
> The de-DE interface is broken because of "% l: Unknown or unsupported format
> specification"
> 
> To get the origin of the error:
> % junitmsgfmt misc/translator/po/de-DE*
> 
>  <failure message="msgfmt
> failure">misc/translator/po/de-DE-staff-prog.po:12520: 'msgstr' is not a
> valid C format string, unlike 'msgid'. Reason: The character that terminates
> the directive number 2 is not a valid conversion specifier.
>  misc/translator/po/de-DE-staff-prog.po:66878: 'msgstr' is not a valid C
> format string, unlike 'msgid'. Reason: The string ends in the middle of a
> directive.
>  msgfmt: found 2 fatal errors
> 
> 
> 12519 msgid "Are you sure you want to delete \"%s\"?"
> 12520 msgstr "Sind Sie sicher, dass Sie \"%s% löschen möchten?"

Yes, I already fixed these. But I also had display problems with other
installed languages. It was fr-FR - maybe also some errors there. Let's keep
the display issue separate from the files not being updated in the installer
directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:12:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:12:34 +0000
Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format
In-Reply-To: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24262-70-cXPfLLyoya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32356

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Bernardo, do yo remember why you added that?

> It will not create a installer directory if it already exists.

379     if ( -d $langdir ) {
380         say "$self->{lang} installer dir $langdir already exists.\nDelete
it if you want to recreate it." if $self->{verbose};
381         return;
382     }


On upgrade we want to update the directory.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356
[Bug 32356] fr-FR installer dir /kohadevbox/koha/installer/data/mysql/fr-FR
already exists.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:12:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:12:34 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-U8ZXik5WRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262
[Bug 24262] Translate installer data in YAML format
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:19:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:19:10 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-yEfwxRG1vP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
> https://lists.katipo.co.nz/pipermail/koha/2022-November/058691.html

Aleisha, did you manage to recreate the problem in ktd?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:25:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:25:59 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-S8PoaHPGhj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:26:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:26:03 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-fKTPv54vj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144311&action=edit
Bug 32356: Install installer translated files on update

If the installer files exist for a given language, the translate script
won't update it.
We should get a confirmation from Bernardo (author of bug 24262), but I
don't understand why it could be needed (side-effects?)

Test plan:
Installer several times the same language, drop the DB and run the
installer+onboarding process.
Check files installed by the installer (yaml for notice templates,
biblio frameworks) have inserted the data properly in DB.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:27:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:27:16 +0000
Subject: [Koha-bugs] [Bug 32356] fr-FR installer dir
 /kohadevbox/koha/installer/data/mysql/fr-FR already exists.
In-Reply-To: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32356-70-Ig8ne8X3wr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |mik at adminkuhn.ch

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This patch might fix Michael's problem, but it shouldn't fix Aleisha's.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:35:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:35:39 +0000
Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for
 pseudonymization but are not set on upgrade
In-Reply-To: <bug-28911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28911-70-8rdr5zwtJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to David Cook from comment #4)
> (In reply to David Cook from comment #3)
> > Just got stung by this one. 
> > 
> > There are quite a few settings like this I think (e.g. plugin_repos,
> > koha_xslt_security, smtp_server).
> 
> I'm writing a local script that fixes up a lot of the missing/bad config.
> It's not very elegant but I could probably share it once I'm done.

Yes please, share it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:37:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:37:10 +0000
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31059-70-W9msIevZ3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
We need to script that add missing entries. It could be a simple (perl) misc
script that is called at the end of the debian upgrade procedure.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 10:41:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 09:41:22 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-XVAQqNe634@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I don't know how this is relevant, but borrowers.secret is MEDIUMTEXT and you
are using VARCHAR(256) here.

By the way, 256? Typo for 255?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 11:29:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 10:29:00 +0000
Subject: [Koha-bugs] [Bug 31651] Log message incorrect in
 Auth_with_shibboleth.pm
In-Reply-To: <bug-31651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31651-70-m9YfO0Td9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651

--- Comment #1 from Jacob O'Mara <jacob.omara at ptfs-europe.com> ---
Created attachment 144312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144312&action=edit
BUG 31651: Replaced duplicate error message

The duplicated error message on ln119 has now been replaced for clarity.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 11:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 10:31:37 +0000
Subject: [Koha-bugs] [Bug 31651] Log message incorrect in
 Auth_with_shibboleth.pm
In-Reply-To: <bug-31651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31651-70-KClRzjI7lA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651

--- Comment #2 from Jacob O'Mara <jacob.omara at ptfs-europe.com> ---
Test plan to follow....

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 11:45:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 10:45:28 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-kNipcNMPh2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

--- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144313&action=edit
Bug 31160: Required fields in patron api

The Patron API PUT request required the fields
"surname","address","city","library_id","category_id". Meanwhile the CSV import
page for patrons only requires "surname","library_id","category_id". The fields
for "address" and "city" have been removed from the "required" section of the
api>v1>swagger>definitions>patron.yaml file to match the CSV import page.

Test Plan:
1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty
body
2) Error message should ask for 5 missing fields as listed above
3) Apply patch
4) Restart Apache server using "restart_all" in your ktd shell
5) Resubmit your request
6) Error message should now only request "surname","library_id","category_id"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 11:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 10:47:17 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-B1tSTWszfa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144308|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 12:16:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 11:16:13 +0000
Subject: [Koha-bugs] [Bug 32358] New: Will Cash App Refund Money If Scammed
 Through A Cash App Dispute Facility
Message-ID: <bug-32358-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32358

            Bug ID: 32358
           Summary: Will Cash App Refund Money If Scammed Through A Cash
                    App Dispute Facility
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jacobhudson8076 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When you file a dispute against any fraudulent transactions, Cash App starts
investing and finds the solutions. Sometimes, it benefits you and sometimes it
is not; so you have to be clear about the fact that the chance of getting the
return of stolen money on Cash App is low. Further, you may also contact
officials to get your queries like how Will Cash App Refund Money If Scammed
answered properly. Visit Cash App help and policy section for better
understanding! 
https://www.contactmail-support.com/blog/will-cash-app-refund-money-if-scammed/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 13:02:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 12:02:31 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-f5iRuk68X3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 13:06:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 12:06:40 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-hydEN4yG3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144035|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144314&action=edit
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

Signed-off-by: David <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Edit: changed intendation on a tiny bit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 13:08:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 12:08:42 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-6Uqfx2xtET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |23.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 13:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 12:08:46 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-R5CAdLHmID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 13:08:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 12:08:49 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-gzarvbT6q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |23.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 13:08:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 12:08:53 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-796J7s0N7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:05:54 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-s7G2K4iDda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:08:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:08:22 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-EzwETFMMdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|23.05.00                    |23.05.00, 22.11.01
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:08:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:08:45 +0000
Subject: [Koha-bugs] [Bug 32213] Reindent item search fields template
In-Reply-To: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32213-70-x9Wte2jVYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 22.11.x for 22.11.01 release.

Thanks everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:09:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:09:12 +0000
Subject: [Koha-bugs] [Bug 32126] Adding item search fields is broken - can't
 add more than one field
In-Reply-To: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32126-70-aYES07Vm6I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|23.05.00                    |23.05.00, 22.11.01
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 22.11.x for 22.11.01 release.

Thanks everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:09:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:09:29 +0000
Subject: [Koha-bugs] [Bug 32352] xt/check_makefile.t failing on node_modules
In-Reply-To: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32352-70-I0yaApgvO1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|23.05.00                    |23.05.00, 22.11.01
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 22.11.x for 22.11.01 release.

Thanks everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:14:43 +0000
Subject: [Koha-bugs] [Bug 31059] encryption_key config entry not generated
 when upgrading
In-Reply-To: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31059-70-X0JBXtuMAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059

--- Comment #5 from Chris Slone <cslone at camdencountylibrary.org> ---
I think a script like that would be great. Documentation would definitely help
too, as the tags for wrapping the entry, or even the need for changing the
config file at all, wasn't really in the release notes for the new feature (not
that I saw, anyhow).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:30:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:30:14 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-NofnCsg1S3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142989|0                           |1
        is obsolete|                            |

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 144323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144323&action=edit
Bug 30649: Vendor EDI account passwords should be encrypted in the database

We are storing edi vendor acccount passwords in clear text in the
database. Now that Koha has the Koha::Encryption module, we should
use that to encrypt passwords for all existing and new EDI accounts.

Test Plan:
1) Apply this patch
2) Create one or more EDI vendor accounts
3) Run a report to view the account passwords, note they are in clear
   text
4) Run updatedatabase.pl
5) Re-run the report, account passwords should be encrypted now
6) Edit a vendor EDI account, note you can still view and update the
   password for an account

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:30:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:30:54 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-fGAixuLOAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144323|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 144324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144324&action=edit
Bug 30649: Vendor EDI account passwords should be encrypted in the database

We are storing edi vendor acccount passwords in clear text in the
database. Now that Koha has the Koha::Encryption module, we should
use that to encrypt passwords for all existing and new EDI accounts.

Test Plan:
1) Apply this patch
2) Create one or more EDI vendor accounts
3) Run a report to view the account passwords, note they are in clear
   text
4) Run updatedatabase.pl
5) Re-run the report, account passwords should be encrypted now
6) Edit a vendor EDI account, note you can still view and update the
   password for an account

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:31:07 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-Zcpj5tb1Pz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 144325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144325&action=edit
Bug 30649: (QA follow-up) Switch password field to mediumtext

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:33:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:33:52 +0000
Subject: [Koha-bugs] [Bug 30649] Vendor EDI account passwords should be
 encrypted in the database
In-Reply-To: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30649-70-UKcybEKmyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30649

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #28)
> I don't know how this is relevant, but borrowers.secret is MEDIUMTEXT and
> you are using VARCHAR(256) here.
> 
> By the way, 256? Typo for 255?

I like the idea of using mediumtext much better for encrypted data fields than
varchar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:42:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:42:05 +0000
Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when
 editing rule
In-Reply-To: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32271-70-s6aZ94moxO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:46:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:46:34 +0000
Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
 indexation correctly
In-Reply-To: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30460-70-oPcNukmYEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Crap.. I didn't get Unit Tests added for any of these module changes..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:50:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:50:13 +0000
Subject: [Koha-bugs] [Bug 32366] New: BatchDeleteBiblio task should have
 tests to prove indexing all takes place in one step
Message-ID: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

            Bug ID: 32366
           Summary: BatchDeleteBiblio task should have tests to prove
                    indexing all takes place in one step
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30460

We worked through changing our code such that we actioned the batch deletes in
a loop passing skip_record_index and then finally passed a list of biblios to
specialUpdate all in one hit at the end..

But we forgot to add unit tests for this change!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460
[Bug 30460] BatchDeleteBiblio task does not deal with indexation correctly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:50:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:50:13 +0000
Subject: [Koha-bugs] [Bug 30460] BatchDeleteBiblio task does not deal with
 indexation correctly
In-Reply-To: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30460-70-sSCd0GBJ0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30460

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32366


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366
[Bug 32366] BatchDeleteBiblio task should have tests to prove indexing all
takes place in one step
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 15:58:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 14:58:20 +0000
Subject: [Koha-bugs] [Bug 32367] New: Default indicators display incorrectly
 when Display only used tags/subfields option is ticked
Message-ID: <bug-32367-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32367

            Bug ID: 32367
           Summary: Default indicators display incorrectly when Display
                    only used tags/subfields option is ticked
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucy.vaux-harvey at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To reproduce:
Go to Administration > MARC Cataloguing Frameworks and then MARC structure for
one of the frameworks.
Go to Edit tag for any tag and add a default value to Indicator 1 and Save
changes.
Tick and untick 'Display only used tags/subfields' and notice that the second
indicator value is incorrect when this is ticked.
Add default values to indicator 1 and 2, the second indicator will be replaced
with the value in indicator 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 16:43:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 15:43:11 +0000
Subject: [Koha-bugs] [Bug 32171] Order prices not populated when adding to a
 basket from a staged file
In-Reply-To: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32171-70-u3i8a9fNMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 16:49:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 15:49:53 +0000
Subject: [Koha-bugs] [Bug 32324] Add ability to disable the opac
In-Reply-To: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32324-70-EThVy2JOyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32324

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|OPAC                        |System Administration
                 CC|                            |gmcharlt at gmail.com
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:17:10 +0000
Subject: [Koha-bugs] [Bug 32368] New: Add page-section to report results
Message-ID: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

            Bug ID: 32368
           Summary: Add page-section to report results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/cataloguing/plugin_launcher.pl?
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff interface
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, katrin.fischer at bsz-bw.de,
                    koha-bugs at lists.koha-community.org,
                    testopia at bugs.koha-community.org
        Depends on: 30952
            Blocks: 31757

The results page after running a report needs page-section adding.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:17:10 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-iw4KirCplo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32368


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368
[Bug 32368] Add page-section to report results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:17:10 +0000
Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31757-70-X1GTAqdFHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32368


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368
[Bug 32368] Add page-section to report results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:17:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:17:22 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-naD6KzEVo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|/cgi-bin/koha/cataloguing/p |
                   |lugin_launcher.pl?          |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:17:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:17:33 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-tUITJgowET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:28:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:28:28 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-yNS6Xof0Lc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144326&action=edit
Bug 32368: Add page-section to report results

This patch adds the page-section container to the results page after
running a report

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:31:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:31:29 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-FzCrzLcjEF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:31:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:31:44 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 client advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-iS0q3KHGOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144310|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 144327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144327&action=edit
Bug 32301: defaultSortField changes the default Sort By in Staff Client
Advanced Search

Use the system preference "defaultSortField" to choose the default Sort
By in the Staff Client Advances Search

To test:
1) Go to staff client
2) Go to Advanced Search
3) Notice the default Sort By value is "Relevance"
4) Go to system preferences
5) Go to "defaultSortField"
6) Change the value of the system preference
7) Go back to Advanced Search and refresh the page
8) Notice that there are no changes, the default Sort By is still
"Relevance"
9) Apply patch
10) Notice that changing the system preference now changes the default
Sort By in Advanced Search

Sponsored-by: National Institute of Atmospheric and Water Research

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:34:26 +0000
Subject: [Koha-bugs] [Bug 30140] Allow for autoMemberNum to generate
 cardnumbers with leading zeros
In-Reply-To: <bug-30140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30140-70-PDBeHbA3cT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30140

Anke Bruns <anke.bruns at gwdg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anke.bruns at gwdg.de

--- Comment #2 from Anke Bruns <anke.bruns at gwdg.de> ---
This would be a great enhancement!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:35:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:35:10 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-U3SyJFDswy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:40:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:40:18 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-BfV40obz93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:40:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:40:28 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-R7uAPHfw7p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:44:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:44:24 +0000
Subject: [Koha-bugs] [Bug 32329] Marking early closures in calendar
In-Reply-To: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32329-70-nNA3u9cBgC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32329

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
You're correct, the calendar only records open or closed for the entire day.
All of the things the calendar is used for are all-or-nothing for the day -- Do
we charge fines today? Do we send overdue notices today? Stuff like that.

What are you looking to accomplish by recording days with reduced hours? Are
you looking for that to figure into hourly checkouts and fines?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:46:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:46:15 +0000
Subject: [Koha-bugs] [Bug 32337] System preference to block holds with
 restrictions
In-Reply-To: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32337-70-2kD35IGWxl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
+1 on the idea of making this configurable per restriction type. That seems
like nice flexibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:50:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:50:39 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-hE9BbaBIqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:50:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:50:45 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-qhZvxaGvW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144326|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 144328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144328&action=edit
Bug 32368: Add page-section to report results

This patch adds the page-section container to the results page after
running a report

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:51:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:51:18 +0000
Subject: [Koha-bugs] [Bug 32337] System preference to block holds with
 restrictions
In-Reply-To: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32337-70-s37YJmuo7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

--- Comment #3 from hebah at bywatersolutions.com ---
By restriction would also work just fine, so long as functionality is there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:51:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:51:21 +0000
Subject: [Koha-bugs] [Bug 32368] Add page-section to saved report results
In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32368-70-Gcc5YCBLoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
            Summary|Add page-section to report  |Add page-section to saved
                   |results                     |report results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:51:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:51:48 +0000
Subject: [Koha-bugs] [Bug 32337] System preference to block holds with
 restrictions
In-Reply-To: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32337-70-kotXrpc3d0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

--- Comment #4 from vstever at myokaloosa.com ---
I voted for the enhancement and I, too, prefer the option to configure by
restriction type.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:51:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:51:59 +0000
Subject: [Koha-bugs] [Bug 32324] Add ability to disable the opac
In-Reply-To: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32324-70-4rommsRXKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32324

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Yes, please!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 17:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 16:55:40 +0000
Subject: [Koha-bugs] [Bug 32300] Add page-section to cataloguing plugins
 (cat)
In-Reply-To: <bug-32300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32300-70-WoeZ5dKKad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff interface             |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 18:06:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 17:06:19 +0000
Subject: [Koha-bugs] [Bug 29308] Regression: NewItemsDefaultLocation should
 not be applied to items.permanent_location
In-Reply-To: <bug-29308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29308-70-IqxVTrQmK0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29308

Daphne Hoolahan <dch at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dch at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 18:15:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 17:15:57 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-BBZ2e1ikQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 18:26:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 17:26:21 +0000
Subject: [Koha-bugs] [Bug 32369] New: Two Factor Authentication Can Be
 Bypassed If Catalog and Staff Client URL Aren't Properly Configured
Message-ID: <bug-32369-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369

            Bug ID: 32369
           Summary: Two Factor Authentication Can Be Bypassed If Catalog
                    and Staff Client URL Aren't Properly Configured
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cslone at camdencountylibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Ideally, there aren't any publicly accessible, production sites set up in the
way described below, however there is a bypass of 2FA if there are (though this
would still require a compromised PIN).

I have a test environment of Koha on a local-network server. When I first set
it up, I made the staff client address the IP of the server, and the OPAC the
same IP at a specific port (xxx.xxx.xxx.xxx:8081). I've never gotten around to
correcting that, and consequently when I'm logged into the staff client it also
considers me to be logged in to the OPAC, and visa versa (at that point I can
go to either the IP or the IP+Port to go between them).

I set up two factor authentication on a staff account, which is working
correctly when I log into the staff client. As expected, when I log into the
OPAC there's no 2FA code requested, however I can then just go to the base IP
(the staff client) and I will be logged into the staff client without having to
deal with 2FA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 18:28:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 17:28:13 +0000
Subject: [Koha-bugs] [Bug 32370] New: Provide a generic set of tools for
 JSON fields
Message-ID: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

            Bug ID: 32370
           Summary: Provide a generic set of tools for JSON fields
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 18:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 17:32:50 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-0w6TPTevhH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
         Depends on|                            |30943


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943
[Bug 30943] Make background job classes use helpers
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 18:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 17:32:50 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30943-70-REnOtVJdbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32370


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
[Bug 32370] Provide a generic set of tools for JSON fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:22:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:22:48 +0000
Subject: [Koha-bugs] [Bug 31793] REST API: DELETE endpoint for Authorities
In-Reply-To: <bug-31793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31793-70-lF0Dl3FMxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:22:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:22:58 +0000
Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities
In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31795-70-B04Ehhamkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:23:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:23:10 +0000
Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities
In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31796-70-PjwtnmtXaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:23:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:23:25 +0000
Subject: [Koha-bugs] [Bug 31797] REST API: DELETE endpoint for Items
In-Reply-To: <bug-31797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31797-70-IvPxb1e3nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31797

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:23:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:23:35 +0000
Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31798-70-SDaGtZIznj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:23:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:23:44 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31799-70-LVv0BoonNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:23:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:23:54 +0000
Subject: [Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios
In-Reply-To: <bug-31800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31800-70-zjZrzLtsrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:24:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:24:03 +0000
Subject: [Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios
In-Reply-To: <bug-31801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31801-70-5pnCG5x9mV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:24:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:24:17 +0000
Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities
In-Reply-To: <bug-31794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31794-70-D00b17yu50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:24:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:24:30 +0000
Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent
 modification through the Koha staff interface(s).
In-Reply-To: <bug-31791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31791-70-REOUiUy7Qs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:25:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:25:36 +0000
Subject: [Koha-bugs] [Bug 32371] New: Restart Hold Process
Message-ID: <bug-32371-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32371

            Bug ID: 32371
           Summary: Restart Hold Process
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

How about an option to restart a hold that is waiting?

Currently, you can revert the waiting status to next in line, but sometimes
patrons or staff need to cancel the hold, and start the hold process again. 
Perhaps the patron can't pick up the hold and wants to go back on the list, but
they need to go to the end of the queue again.  This is a tedious process that
could be simplified with an action choice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:26:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:26:40 +0000
Subject: [Koha-bugs] [Bug 31791] Add the ability to lock records to prevent
 modification through the Koha staff interface(s).
In-Reply-To: <bug-31791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31791-70-FM9KnEuTP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #3)
> Are you thinking of some kind of automatism to set the locked maybe on
> import too?

On the API front, this will be a flag to be passed, with (probably) some
default for each source i.e. there will be an 'Import sources' crud page, to
set this things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:28:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:28:55 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-PH1g5FKw77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:29:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:29:00 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-1jEaX9QPl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144329&action=edit
Bug 32370: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:29:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:29:05 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-5k0l9EuKvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144330&action=edit
Bug 32370: Provide a generic set of tools for JSON fields

This patch introduces a new class for extending Koha::Object-based
classes so they have reusable ways to deal with JSON encoded fields.

As documented in the POD, classes can now

```perl
use base qw(Koha::Object Koha::Object::JSONFields);
```

and will have the following methods available:

* decode_json_field
* set_encoded_json_field

For convenience, the Koha::Auth::Identity::Provider class is tweaked to
make use of this, and also to prove the behavior is correct (expected
results, exceptions, encoding, etc).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Auth/Identity/Provider.t \
           t/db_dependent/api/v1/idp.t
=> SUCCESS: Identity provider related tests pass!
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run the specific tests:
  k$ prove t/db_dependent/Koha/Object/JSONField.t
=> SUCCESS: Tests pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:30:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:30:05 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-GRHvsg5Lrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351
[Bug 31351] Worker dies on reindex job when operator last name/first
name/branch name contains non-ASCII chars
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:30:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:30:05 +0000
Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator
 last name/first name/branch name contains non-ASCII chars
In-Reply-To: <bug-31351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31351-70-YiHCYMWHRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32370


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
[Bug 32370] Provide a generic set of tools for JSON fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:31:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:31:05 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-3sYyXC6mHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 19:58:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 18:58:16 +0000
Subject: [Koha-bugs] [Bug 29983] Display the return claims column in the
 circulation overdues page (overdue.tt)
In-Reply-To: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29983-70-4d7oEnrjSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
          Component|Acquisitions                |Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:02:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:02:15 +0000
Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-qRVHEYUpDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

--- Comment #9 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Sam Passey from comment #4)
> Does anyone have updates on this one? This is problematic. Available now to
> me means that something is on the shelf at that moment that someone should
> be able to grab.

There is not update.  No one is working on this bug, unfortunately.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:02:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:02:24 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-8P64BHELiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144331&action=edit
Bug 32370: (follow-up) Make Koha::BackgroundJob use Koha::Object::JSONFields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:02:26 +0000
Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns
 an empty object
In-Reply-To: <bug-30181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30181-70-ToMDfphrnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:03:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:03:36 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-4XKcX01onL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #3)
> Created attachment 144331 [details] [review]
> Bug 32370: (follow-up) Make Koha::BackgroundJob use Koha::Object::JSONFields

^^ to avoid the 'completeness' discussion we always have (y)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:04:37 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30943-70-p7egymrv1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I forgot about this one, should've been on 22.11...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:06:54 +0000
Subject: [Koha-bugs] [Bug 32329] Marking early closures in calendar
In-Reply-To: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32329-70-i1DvWrnURN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32329

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Funny you should ask, as it was brought to my attention when I started using
your calendar hack to show upcoming closures on the home screen.  The one thing
it doesn't show is any early closures, because we can't define those in the
calendar.  It would be nice to be able to put those in the calendar, even if
they didn't have any particular impact on fines or fees.  Maybe if we marked an
event as an early closure, we could have a system preference that would include
or exclude those types of events.  That would be a good start.  Then down the
road maybe it could have a more fine tuned role.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:07:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:07:17 +0000
Subject: [Koha-bugs] [Bug 15500] Add FRBRized view to OPAC & staff interface
 results
In-Reply-To: <bug-15500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15500-70-ChpkH2T5pi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500

Lauren Denny <lauren_denny at sil.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lauren_denny at sil.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:16:00 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-OhHdfxNzrz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:16:04 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-4jIC1tWhzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144329|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:16:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:16:09 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-zlvSkuKsP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144330|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:16:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:16:13 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-9eqX5MNlHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144331|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:16:55 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-jLwew0dy9N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144332&action=edit
Bug 32370: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:17:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:17:02 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-394L5SPbVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144333&action=edit
Bug 32370: Provide a generic set of tools for JSON fields

This patch introduces a new class for extending Koha::Object-based
classes so they have reusable ways to deal with JSON encoded fields.

As documented in the POD, classes can now

```perl
use base qw(Koha::Object Koha::Object::JSONFields);
```

and will have the following methods available:

* decode_json_field
* set_encoded_json_field

For convenience, the Koha::Auth::Identity::Provider class is tweaked to
make use of this, and also to prove the behavior is correct (expected
results, exceptions, encoding, etc).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Auth/Identity/Provider.t \
           t/db_dependent/api/v1/idp.t
=> SUCCESS: Identity provider related tests pass!
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run the specific tests:
  k$ prove t/db_dependent/Koha/Object/JSONField.t
=> SUCCESS: Tests pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:17:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:17:09 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-GLjk5RAz4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144334&action=edit
Bug 32370: (follow-up) Make Koha::BackgroundJob use Koha::Object::JSONFields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:21:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:21:27 +0000
Subject: [Koha-bugs] [Bug 32329] Marking early closures in calendar
In-Reply-To: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32329-70-P8y1EaWTxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32329

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
It seems like it would be useful (and not too deep/involved an enhancement) to
add the ability to record an event/note/whatever on a given date in the
calendar. Basically attach a title and description to a date but not actually
enforce it as a closure. That could be an early closure, a notable program, or
any number of other things.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:56:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:56:26 +0000
Subject: [Koha-bugs] [Bug 32372] New: Calculate hold waiting expiration
 based on days closed
Message-ID: <bug-32372-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32372

            Bug ID: 32372
           Summary: Calculate hold waiting expiration based on days closed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Currently the ExcludeHolidaysFromMaxPickUpDelay is an on or off function.  This
is problematic with libraries that are closed several days in a week.  It would
be helpful if there were a threshold that could be set for this setting.  The
question would be, what kind of a threshold?

For example, if ReservesMaxPickUpDelay is set to 7, and a pickup library is
closed for 4 days in a week, if ExcludeHolidaysFromMaxPickUpDelay does not use
the calendar, the expiration on the waiting hold will likely fall on a closed
day, and also reduce the number of opportunities to be picked up.  However, if
ExcludeHolidaysFromMaxPickUpDelay is set to use the calendar, that same library
will end up holding the item for more than two weeks to fulfill the 7 days.

If ExcludeHolidaysFromMaxPickUpDelay uses the calendar, it would be helpful if
there were an option to extend the ReservesMaxPickUpDelay to the closest open
day past the closed dates.  Perhaps something like
MaxReservePickupExtentension, in which if it is blank or set to 0, it does
nothing, like Koha does currently, but if it is set to a number of days, it
would extend the expiration past the close date to the next open day that falls
within the number of days defined. 

For example, ReservesMaxPickUpDelay is set to 7, and our proposed
MaxReservePickupExtentension setting is set to 7 as well, and the pickup
library is closed Sunday, Monday, Wednesday, and Friday.  The pickup library
receives the item on Tuesday, and instead of expiring on the following Monday
when they are closed, Koha would look to the next open day (within 7 days past
ReservesMaxPickUpDelay), which would be the following Tuesday.  If there is no
open days within the extra days defined in MaxReservePickupExtentension, it
would keep the original expiration date, or more accurately, expire on the last
open day before the closed expiration date.

I hope that makes sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 20:58:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 19:58:14 +0000
Subject: [Koha-bugs] [Bug 32329] Marking early closures in calendar
In-Reply-To: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32329-70-wB76UfMfsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32329

--- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Andrew Fuerste-Henry from comment #3)
> It seems like it would be useful (and not too deep/involved an enhancement)
> to add the ability to record an event/note/whatever on a given date in the
> calendar. Basically attach a title and description to a date but not
> actually enforce it as a closure. That could be an early closure, a notable
> program, or any number of other things.

That would be QUITE useful.  :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 21:11:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 20:11:56 +0000
Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority
 targets like for bibliographic targets
In-Reply-To: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19220-70-1GlJE8gcyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220

--- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Any news ?

Are the 2 new patches an alternate ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 21:23:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 20:23:53 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-iZiiS9FxOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele <hammat.wele at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141157|0                           |1
        is obsolete|                            |

--- Comment #149 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144335&action=edit
Bug 17385: Add custom export XSLT

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 21:57:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 20:57:57 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-PUyBhUsUOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #150 from Hammat wele <hammat.wele at inlibro.com> ---
Created attachment 144336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144336&action=edit
This patch adds 'XSL-Simple Export' when saving a bibliographic record

To test:
1) Search for a record in the intranet.
2) Click on the 'Save' button and observe the dropdown menu.
3) Notice that 'XSL- Simple Export' is not in the menu.
4) Apply the patch.
5) In System preferences search for OpacExportOptions and enable XSL
6) Repeat the steps 1 and 2.
7) Notice that 'XSL - Simple Export' is in the menu.
8) Click on 'XSL - Simple Export'. A .html file should be downloaded.
9) Open the .html file. You should see the record's informations.
10) Add some items to your Cart
11) Open the Cart
12) Click on the 'Download' button and observe the dropdown menu.
13) Notice that 'XSL - Simple Export' is in the menu.
14) Click on 'XSL - Simple Export'. A .html file should be downloaded.
15) Open the .html file. You should see the record's informations.
16) Add some items to a List
17) Open the List
18) Click on the 'Download' button and observe the dropdown menu.
19) Notice that 'XSL - Simple Export' is in the menu.
20) Click on 'XSL - Simple Export'. A .html file should be downloaded.
21) Open the .html file. You should see the record's informations.
22) Do the same steps in OPAC
23) In System preferences search for OpacExportOptions and disable XSL
24) Repeat all steps
25) Notice that 'XSL - Simple Export' is no more in the menus.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 22:30:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 21:30:58 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-InQuIt5Xad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Command-line Utilities

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 22:31:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 21:31:34 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-ZwBfPvR3BF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Command-line Utilities      |Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 22:39:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 21:39:06 +0000
Subject: [Koha-bugs] [Bug 32204] in-page anchor to edititem on additem.pl
 not working
In-Reply-To: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32204-70-d8S4EHDI1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
For me the empty searchid parameter doesn't seem to matter.

If I click 'Edit item', I am still at the top of the page ( fragment doesn't
work )

but if I then go to the address bar and press return to refresh I am taken to
the #edititem location. ( fragment does work )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 22:54:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 21:54:55 +0000
Subject: [Koha-bugs] [Bug 32373] New: Show Date of Restriction on Patron
 Screen
Message-ID: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373

            Bug ID: 32373
           Summary: Show Date of Restriction on Patron Screen
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: smhodson123extra at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 144337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144337&action=edit
Photo of patron account with restriction and flags (where I'd love to see the
date they were placed)

It would be nice to see the date a restriction was placed, without having to go
in and view the restrictions. We are planning to add a more detailed message
about the restriction, so it would be nice to be able to look for the date
without having to leave the page. It would also be nice to get a date for when
the lost card and gone--no address flags were added. (See attached photo.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 23:08:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 22:08:12 +0000
Subject: [Koha-bugs] [Bug 32374] New: CHECKIN notice preview not accurate
Message-ID: <bug-32374-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32374

            Bug ID: 32374
           Summary: CHECKIN notice preview not accurate
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

TO recreate:

I'm using this CHECKIN notice template:


[% borrower.firstname %] [% borrower.surname %]

The following items have been checked in:
----
[% biblio.title %]
----
Thank you.




1. Add my sample notice.
2. Checkout an item.
3. Use that item's barcode to generate a preview. 
4. Notice the firstname and surname are missing 
5. Check the item in to generate the actual notice. ( make sure the patron's
messaging prefs are set to receive one )
6. It accurately adds the firstname and surname.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Nov 29 23:15:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Nov 2022 22:15:12 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-dlIP83FHyu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 01:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 00:13:14 +0000
Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and
 object_store_post
In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28173-70-r0ZU0DdhgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29392

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Bug 29672 pushed master for 22.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 01:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 00:13:14 +0000
Subject: [Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or
 authorities
In-Reply-To: <bug-29392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29392-70-rKgiWxX0V5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28173

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 04:57:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 03:57:20 +0000
Subject: [Koha-bugs] [Bug 32375] New: 22.05.07 failing
 t/AuthoritiesMarc_MARC21.t
Message-ID: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375

            Bug ID: 32375
           Summary: 22.05.07 failing t/AuthoritiesMarc_MARC21.t
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: wainuiwitikapark at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

t/AuthoritiesMarc_MARC21.t is failing on 22.05.07

Please see the output below:

kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/AuthoritiesMarc_MARC21.t  
t/AuthoritiesMarc_MARC21.t .. 1/5     # No tests run!
t/AuthoritiesMarc_MARC21.t .. 5/5 
#   Failed test 'No tests run for subtest "FindDuplicateAuthority tests"'
#   at t/AuthoritiesMarc_MARC21.t line 62.
DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI
connect('database=koha_kohadev;host=localhost;port=3306','koha_kohadev',...)
failed: Can't connect to local MySQL server through socket
'/var/run/mysqld/mysqld.sock' (2) at /home/vagrant/kohaclone/Koha/Database.pm
line 91. at /home/vagrant/kohaclone/Koha/Database.pm line 139
# Looks like your test exited with 255 just after 5.
t/AuthoritiesMarc_MARC21.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/5 subtests 

Test Summary Report
-------------------
t/AuthoritiesMarc_MARC21.t (Wstat: 65280 Tests: 5 Failed: 1)
  Failed test:  5
  Non-zero exit status: 255
Files=1, Tests=5,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.57 cusr  0.17
csys =  1.77 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 04:57:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 03:57:49 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32375-70-DjeBjyD0RN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 05:01:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 04:01:15 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32375-70-Dsmf90lCr1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
It appears the tests added in bug 31023 have made this test db dependent now so
it looks like it needs to be moved to t/db_dependent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 07:26:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 06:26:28 +0000
Subject: [Koha-bugs] [Bug 29921] Allow to index in Elasticsearch all records
 modified since a given date
In-Reply-To: <bug-29921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29921-70-6TIs3uvClv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29921

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This surely needs a unit test for changes in get_all_biblios_iterator()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 07:48:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 06:48:59 +0000
Subject: [Koha-bugs] [Bug 13498] 'email' templates used for printing slips
In-Reply-To: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13498-70-ftvAfnrcgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 07:53:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 06:53:06 +0000
Subject: [Koha-bugs] [Bug 13498] 'email' templates used for printing slips
In-Reply-To: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13498-70-5l96gjJUtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498

--- Comment #18 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Problem still exists on current master. This also happens when printing via
"print and clear screen" button.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:21:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:21:09 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-LUgzUB42pt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am certainly missing the context here, but this feels like unnecessary
overhead.

You are basically adding a Koha::Object base class for JSON decode and encode
calls. That's all.
The exception is there only to raise a Koha exception, but having a JSON
exception is also fine. The MissingParameter exceptions are not needed either
IMO, you will get a perl error if you are calling the method with missing
mandatory parameter.

If we really need these methods, and that I am missing the root idea and
context of these patches, can you clarify why a base class instead of a regular
class?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:32:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:32:12 +0000
Subject: [Koha-bugs] [Bug 32376] New: selenium/authentication_2fa.t produces
 artefact
Message-ID: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32376

            Bug ID: 32376
           Summary: selenium/authentication_2fa.t produces artefact
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30588

There is a selenium_failure_2.png screenshot that is created, even if the tests
succeed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
[Bug 30588] Add the option to require 2FA setup on first staff login
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:32:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:32:12 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-RHUAyk4qJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32376


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32376
[Bug 32376] selenium/authentication_2fa.t produces artefact
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:33:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:33:41 +0000
Subject: [Koha-bugs] [Bug 32376] selenium/authentication_2fa.t produces
 artefact
In-Reply-To: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32376-70-oQHdE5QlY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32376

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:33:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:33:46 +0000
Subject: [Koha-bugs] [Bug 32376] selenium/authentication_2fa.t produces
 artefact
In-Reply-To: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32376-70-8ArZxUEPND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32376

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144338&action=edit
Bug 32376: Remove creation of selenium_failure_2.png

This was for debugging purpose.

Test plan:
Run the tests and confirm that the screenshot is not generated when the
patch is applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:57:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:57:41 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-iyiiPGpfw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:57:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:57:45 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-OKg5721DxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144339&action=edit
Bug 32366: (bug 30460 follow-up) Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:57:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:57:58 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-Y6EMQSkhvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |jonathan.druart+koha at gmail.
                   |.com                        |com
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 08:58:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 07:58:23 +0000
Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception
 if AnonymousPatron is not set
In-Reply-To: <bug-30007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30007-70-pHHay6Bywn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007

--- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> ---
We should remove this help text :
https://git.koha-community.org/Koha-community/Koha/src/branch/22.11.x/misc/cronjobs/batch_anonymise.pl#L41

"Note: If the system preference 'AnonymousPatron' is not defined, NULL will be
used."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:02:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:02:03 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30943-70-0RaxNc4f8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140329|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144340&action=edit
Bug 30943: Simplify background jobs code using helpers

This patch makes the current background jobs classes use the added
helpers in order to simplify them.

No behavior change is expected.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:05:13 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30943-70-YKGCxLv56h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oops, I forgot about this one too.

So.. I've signed off.. but I have a query.

This is great that it now ensures we consistently catch the cases where a job
has already started and thus we shouldn't continue.. however, we're throwing an
exception.

Should we be wrapping calls to start in a try/catch to just skip the job or
something instead..?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:23:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:23:31 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-cHpHoJFOBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm still contemplating this...

Considering
https://metacpan.org/pod/DBIx::Class::InflateColumn::Serializer::JSON as an
example to compare to.

I think I still prefer the idea of a Koha::Object::InflateField::* hierarchy if
we want something like this... to me, I think it's more elegant to outright
replace the field accessor with automatic inflation rather than add additional
accessors.. then fall back to get_column should one need the raw data.. but
perhaps just because I'm so familiar with 'the DBIC way' I'm not seeing what
we'd be losing in Koha land.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:34:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:34:11 +0000
Subject: [Koha-bugs] [Bug 13498] 'email' templates used for printing slips
In-Reply-To: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13498-70-bjEAWF2LdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498

--- Comment #19 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Tested this a little (sorry if I'm repeating what has already been said). We
call printslip.pl when printing ISSUESLIP or ISSUEQSLIP and from there we call
IssueSlip(). This then calls GetPreparedLetter(). 
If we add message_transport_type => 'print' parameter to that
GetPreparedLetter() call in IssueSlip(), print notice is printed correctly.
However if 'print' notice isn't found, GetPreparedLetter() fails to, because

my $mtt         = $params{message_transport_type} || 'email';

obviously has value 'print', not undef and doesn't fall back to email.

So we need to 1) add message_transport_type => 'print' param when calling
notices that are primaly printed (not just to printslip.pl but also
hold-transfer-slip.pl etc.) 2) determine in GetPreparedLetter() if print notice
actually exists and then fall back to email notice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:41:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:41:05 +0000
Subject: [Koha-bugs] [Bug 13498] 'email' templates used for printing slips
In-Reply-To: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13498-70-TgWjdnddVV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498

--- Comment #20 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Emmi Takkinen from comment #19)
> Tested this a little (sorry if I'm repeating what has already been said). We
> call printslip.pl when printing ISSUESLIP or ISSUEQSLIP and from there we
> call IssueSlip(). This then calls GetPreparedLetter(). 
> If we add message_transport_type => 'print' parameter to that
> GetPreparedLetter() call in IssueSlip(), print notice is printed correctly.
> However if 'print' notice isn't found, GetPreparedLetter() fails to, because
> 
> my $mtt         = $params{message_transport_type} || 'email';
> 
> obviously has value 'print', not undef and doesn't fall back to email.
> 
> So we need to 1) add message_transport_type => 'print' param when calling
> notices that are primaly printed (not just to printslip.pl but also
> hold-transfer-slip.pl etc.) 2) determine in GetPreparedLetter() if print
> notice actually exists and then fall back to email notice.

Correcting the first point, we need to add message_transport_type to methods
which are called when printing mainly 'print' notices. E.g. printslip.pl ->
IssueSlip(), hold-transfer-slip.pl -> ReserveSlip().

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:56:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:56:03 +0000
Subject: [Koha-bugs] [Bug 5463] Limit to available shows on hold items
In-Reply-To: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5463-70-dPiQOiJ4eL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7012
            Summary|limit to available shows on |Limit to available shows on
                   |hold items                  |hold items

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have tried to explain why this is not an easy fix on the similar bug 7012.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 09:56:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 08:56:03 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
 in-transit items
In-Reply-To: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-1L9ZdXQtij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5463

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:26:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:26:47 +0000
Subject: [Koha-bugs] [Bug 32358] SPAM
In-Reply-To: <bug-32358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32358-70-hxvimEl2VU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32358

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Will Cash App Refund Money  |SPAM
                   |If Scammed Through A Cash   |
                   |App Dispute Facility        |
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:28:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:28:43 +0000
Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff
 interface advanced search
In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32301-70-ebuJJgIRzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Show correct                |Show correct
                   |defaultSortField in staff   |defaultSortField in staff
                   |client advanced search      |interface advanced search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:32:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:32:03 +0000
Subject: [Koha-bugs] [Bug 32337] Add option to block holds with restrictions
In-Reply-To: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32337-70-TQ58iISaWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32337

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|System preference to block  |Add option to block holds
                   |holds with restrictions     |with restrictions

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I generalized the bug description a little bit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:37:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:37:42 +0000
Subject: [Koha-bugs] [Bug 32324] Add ability to disable the OPAC
In-Reply-To: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32324-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32324-70-MIj53PxuZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32324

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability to disable the  |Add ability to disable the
                   |opac                        |OPAC

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should this also include all the account related pages? We often link to them
or the course reserves etc. that is not available from the discovery.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:39:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:39:55 +0000
Subject: [Koha-bugs] [Bug 32369] Two factor authentication can be bypassed
 if catalog and staff interface URL aren't properly configured
In-Reply-To: <bug-32369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32369-70-UlLGCmjgRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
            Summary|Two Factor Authentication   |Two factor authentication
                   |Can Be Bypassed If Catalog  |can be bypassed if catalog
                   |and Staff Client URL Aren't |and staff interface URL
                   |Properly Configured         |aren't properly configured

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:49:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:49:04 +0000
Subject: [Koha-bugs] [Bug 32376] selenium/authentication_2fa.t produces
 artefact
In-Reply-To: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32376-70-3V6TM4kfaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32376

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:52:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:52:31 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-4fJxUB5QWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:52:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:52:35 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-jcIrDds0SM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 144341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144341&action=edit
Bug 29274: Remove z_reset.t

>From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77

"""
    Bug 22709: (RM follow-up) Clean up plugin tests

    The plugin tests were failing due to failed rollbacks and run order.
    This patch moves them into their own directory and adds a reset test to
    restore the original state of the plugin system after the tests have
    run.
"""

This is wrong, the tests are run in a random order.

We don't need this file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 10:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 09:55:40 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-5TQRQ7WwvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:08:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:08:36 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-tSQpicIjZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144341|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144342&action=edit
Bug 29274: Remove z_reset.t

>From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77

"""
    Bug 22709: (RM follow-up) Clean up plugin tests

    The plugin tests were failing due to failed rollbacks and run order.
    This patch moves them into their own directory and adds a reset test to
    restore the original state of the plugin system after the tests have
    run.
"""

This is wrong, the tests are run in a random order.

We don't need this file.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:08:48 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-RoLIDkPRgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:09:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:09:09 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29274-70-498EOgb8O4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial fix, straight removal.

Going straight for QA, Passed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:18:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:18:30 +0000
Subject: [Koha-bugs] [Bug 32377] New: GetBudgetHierarchy slows down
 acqui/histsearch.pl
Message-ID: <bug-32377-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377

            Bug ID: 32377
           Summary: GetBudgetHierarchy slows down acqui/histsearch.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

Like in bug 30359, when acqui/histsearch.pl is opened and there are lot of
budgets, loading the page takes a long time. Bug 30359 added parameter
skiptotals to GetBudgetHierarchy. We should set this parameter also to call of
GetBudgetHierarchy in acqui/histsearch.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:34:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:34:37 +0000
Subject: [Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down
 acqui/histsearch.pl
In-Reply-To: <bug-32377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32377-70-iCEEfQNXvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 144343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144343&action=edit
Bug 32377: Set param skiptotals on call of GetBudgetHierarchy in
acqui/histsearch.pl

Calling GetBudgetHierarchy from acqui/histsearch.pl
is slow if param skiptotals is not used.

To test:
1. Open browsers Console -> Network (F12).
2. Navigate to Order search page and perform search.
=> Take a note how long it takes to load the Search results page.
3. Apply this patch.
4. Repeat step 2.
=> Page should now load faster.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:35:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:35:21 +0000
Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive
 page
In-Reply-To: <bug-30359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30359-70-UultGL1AuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=32377

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:35:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:35:21 +0000
Subject: [Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down
 acqui/histsearch.pl
In-Reply-To: <bug-32377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32377-70-XevHDQ973T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30359

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:53:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:53:38 +0000
Subject: [Koha-bugs] [Bug 32302] Hide "ISBN" label when no ISBN data when
 sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-DLHVTIngzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

Adam Styles <adam.styles at esa.edu.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adam.styles at esa.edu.au

--- Comment #1 from Adam Styles <adam.styles at esa.edu.au> ---
Hi David,

Just to clarify the issues of bug raised:


By "ISBN:" shows in the email whether or not there is any ISBN data." 

Are you suggesting that, IF a bibliographic record, has NO ISBN FIELD in the
marc file? that the output resulted in email form, still displays a blank ISBN
label.

OR that...

IF a bibliographic record, has an empty ISBN FIELD value in the marc file? that
the output resulted in email form, still displays a blank ISBN label.

The reason I ask, is that in the file:
./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt

There is a specific IF statement line 61 - 68

```
[% IF ( BIBLIO_RESULT.ISBN ) %]
<span>
                ISBN: [% FOREACH isbn IN BIBLIO_RESULT.ISBN %]
                          [% isbn | $raw %]
                          [% UNLESS ( loop.last ) %]; [% END %]
                      [% END %]
            </span><br/>
[% END %]

```

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 11:59:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 10:59:06 +0000
Subject: [Koha-bugs] [Bug 32369] Two factor authentication can be bypassed
 if catalog and staff interface URL aren't properly configured
In-Reply-To: <bug-32369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32369-70-x0dF27pLV4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Not sure this is considered a bug. It's a configuration issue in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:04:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:04:51 +0000
Subject: [Koha-bugs] [Bug 32257] Label for patron attributes misaligned on
 patron batch mod
In-Reply-To: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32257-70-SxxvTZi8G1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for the little fixes in line David.. Great to see a new dev getting
welcomed to the community so nicely :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:06:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:06:20 +0000
Subject: [Koha-bugs] [Bug 32302] Hide "ISBN" label when no ISBN data when
 sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-xPDmsYyJDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

--- Comment #2 from Adam Styles <adam.styles at esa.edu.au> ---
Hi David,

Just to clarify the bug raised:

```
"ISBN:" shows in the email whether or not there is any ISBN data." 
```

Are you suggesting that, IF a bibliographic record, has NO ISBN FIELD in the
marc file? that the output result in email, still displays a blank ISBN label.

OR that...

IF a bibliographic record, has an empty ISBN FIELD with no value in subfields,
in the marc file, that the output result in email, still displays a blank ISBN
label.

The reason I ask, is that in the file:
./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt

There is a specific IF statement line 61 - 68, that will only display the ISBN
output IF the marc file itself has an ISBN marc field present (either subfield
populated or not).

See below

```
[% IF ( BIBLIO_RESULT.ISBN ) %]
<span>
    ISBN: [% FOREACH isbn IN BIBLIO_RESULT.ISBN %]
              [% isbn | $raw %]
              [% UNLESS ( loop.last ) %]; [% END %]
          [% END %]
</span><br/>
[% END %]
```

I ran a quick test in opac which appears to show the ISBN label, only when the
marc record itself has a 020 ISBN field. When I removed 020 ISBN field in test
marc record, the ISBN label did not populate in output results.

Are you able to create a test plan based on your perspective on this bug? IF so
I can test authentically.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:23:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:23:42 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
 tool
In-Reply-To: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32095-70-FVh84Kmrp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095

--- Comment #3 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144344&action=edit
Bug 32095: Remove bullets from inventory tool status

The new design included bullet points in a list where the elements were aligned
to the right. The bullets have now been removed using "list-style: none;" to
make the styling much cleaner.

Test plan:
1) Navigate to Cataloging > Inventory
2) Observe that in the "Optional filters for inventory list or comparing
barcodes" section there are bullet points in the listed items
3) Apply patch
4) Navigate to the same window and observe that the bullet points are now
missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:24:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:24:15 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
 tool
In-Reply-To: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32095-70-x4gr3nFS8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095

Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |matt.blenkinsop at ptfs-europe
                   |                            |.com
             Status|NEW                         |Needs Signoff
                 CC|                            |matt.blenkinsop at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:26:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:26:52 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30943-70-acLUK1jKoB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #4)
>
> Should we be wrapping calls to start in a try/catch to just skip the job or
> something instead..?

Yes, absolutely. In theory, as written right now, we are hidding those
situations by skipping in some cases. My idea was to just explode and handle
things correctly.

One example: if a task has already been started, and it is asked to start
again, should we proceed? Should we alert?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:36:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:36:43 +0000
Subject: [Koha-bugs] [Bug 32378] New: Incorrect label for in identity
 provider domains
Message-ID: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32378

            Bug ID: 32378
           Summary: Incorrect label for in identity provider domains
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

David spotted this as part of testing bug 32283

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:38:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:38:52 +0000
Subject: [Koha-bugs] [Bug 32378] Incorrect label for in identity provider
 domains
In-Reply-To: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32378-70-TNsS6DjLYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32378

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144345&action=edit
Bug 32378: Correction to allow_staff form field label

The forms for attributes were mis-copied. This corrects that mistake.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:39:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:39:11 +0000
Subject: [Koha-bugs] [Bug 32378] Incorrect label for in identity provider
 domains
In-Reply-To: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32378-70-F6aLHcznAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |andrew.auld at ptfs-europe.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:39:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:39:39 +0000
Subject: [Koha-bugs] [Bug 32378] Incorrect label for in identity provider
 domains
In-Reply-To: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32378-70-tjEOv3GoPz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32378

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Extracted from follow-ups written by Andrew on bug 32283.. Signing off myself
here to pass through to QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 12:47:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 11:47:47 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-9t0UY9BhVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #8)
> I am certainly missing the context here, but this feels like unnecessary
> overhead.

I thought the examples in IdP and BackgroundJob were enough context. But fair.

> You are basically adding a Koha::Object base class for JSON decode and
> encode calls. That's all.

We are repeating code everywhere, and I provide a way to extend
Koha::Object-derived classes with accessors for JSON fields. Yes. It sounds
like a simple enough approach. If we did a regular class, we would need to
instantiate it as needed and it feels counter productive and unnecessary.

(In reply to Martin Renvoize from comment #9)
> I'm still contemplating this...
> 
> Considering
> https://metacpan.org/pod/DBIx::Class::InflateColumn::Serializer::JSON as an
> example to compare to.

I agree with this approach and I found it interesting. YOu mentioned it after I
already wrote this so I thought I would post this to start the discussion. Will
think about it. The main drawback is that devs might be caught by surprise with
inflation, but it shouldn't be a problem. It will jus tbe a general behavior
change and we would need to measure performance/memory overhead, as my
implementation will only introduce overhead if the new accessors are really
called.

I tried to provide real-life examples on how it would be used to make the point
code-wise.

(In reply to Jonathan Druart from comment #8)
> The exception is there only to raise a Koha exception, but having a JSON
> exception is also fine. The MissingParameter exceptions are not needed
> either IMO, you will get a perl error if you are calling the method with
> missing mandatory parameter.

Yeah, I tried that. You get
- "Can't call method undefined", I prefer a named exception but this is really
taste.
- As of JSON, I think I picked what we already had. But it is fair not to throw
our own exception; again, a matter of taste.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:06:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:06:28 +0000
Subject: [Koha-bugs] [Bug 32379] New: CRASH: Can't call method "itemlost" on
 an undefined value
Message-ID: <bug-32379-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32379

            Bug ID: 32379
           Summary: CRASH: Can't call method "itemlost" on an undefined
                    value
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

21.11
    my $item = Koha::Items->find($itemnumber);
    # FIXME Handle non existent item
[L426]    my $olditemlost = $item->itemlost;

MASTER
    my $itemnumber = $input->param('itemnumber');
    my $item = Koha::Items->find($itemnumber);
    # FIXME Handle non existent item
[L535]    my $olditemlost = $item->itemlost;

Confirming the FIXME ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:16:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:16:13 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30943-70-Fstoxw8kXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #5)
> One example: if a task has already been started, and it is asked to start
> again, should we proceed? Should we alert?

See also bug 32305.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:40:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:40:46 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-kCvDl5Dlgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd love to see us have another go at this.. perhaps a 23.05 cycle target?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:40:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:40:59 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-RVeG9ikwSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:43:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:43:57 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-RnBgW5SouH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jacob.omara at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:44:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:44:50 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-wgDdkPmA1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matt.blenkinsop at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:45:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:45:54 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-MXT4IkIUTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:55:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:55:50 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-Pv9e9vDtUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144339|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 144346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144346&action=edit
Bug 32366: (bug 30460 follow-up) Add tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:57:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:57:07 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-nKkYzCCKml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oh, thanks for jumping on this Jonathan, you beat me to it.

It's a nice trivial test once you wrap you head around it.. so going straight
for a PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:58:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:58:40 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
 prove indexing all takes place in one step
In-Reply-To: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32366-70-2a0IyXc60b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 13:59:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 12:59:27 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-RJzJSFMfFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
malformed JSON string, neither tag, array, object, number, string or atom, at
character offset 0 (before "HASH(0x55ae880d9628)") at
/kohadevbox/koha/misc/background_jobs_worker.pl line 93.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 14:00:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 13:00:52 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-fnM9sHfvQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> malformed JSON string, neither tag, array, object, number, string or atom,
> at character offset 0 (before "HASH(0x55ae880d9628)") at
> /kohadevbox/koha/misc/background_jobs_worker.pl line 93.

Hum, forget that, I guess I need to copy the new version of the misc script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 14:15:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 13:15:29 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
 fields
In-Reply-To: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32370-70-AIcCQ5fGHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144334|0                           |1
        is obsolete|                            |

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144347&action=edit
Bug 32370: (follow-up) Make Koha::BackgroundJob use Koha::Object::JSONFields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 15:00:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 14:00:05 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
 in-transit items
In-Reply-To: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-xrwFWgf4si@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

--- Comment #8 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Katrin Fischer from comment #7)

> At the moment the filter only looks at information in the item record
> already.

Is performance the reason Koha can't also check the reserves table? Is this
something that can (or has?) been addressed with elastic search? 

We're willing to pitch in funds if a solution is possible.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 15:58:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 14:58:55 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-VFII1lLCv5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Should this be NSO rather than Assigned?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:21:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:21:35 +0000
Subject: [Koha-bugs] [Bug 32060] Improve performance of
 Koha::Item->columns_to_str
In-Reply-To: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32060-70-uagYTimmo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142894|0                           |1
        is obsolete|                            |

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 144348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144348&action=edit
Bug 32060: Improve performance of columns_to_str

To test:
1) Ensure tests in t/db_dependent/Koha/Item.t all pass
2) Go to a biblio (preferably as serial) with many items and
   click "New" -> "New item" and take not of the response time.
3) Apply the patch.
4) Ensure tests in t/db_dependent/Koha/Item.t still pass
5) Repeat step 1), the response time should be substantially
   improved.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:27:00 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-tWpwJPg6Go@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Let's leave it ASSIGNED and we just keep adding patches here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:44:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:44:35 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-iahY7EaFjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:44:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:44:47 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-7yO7RI1r9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144276|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:44:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:44:57 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-LG1qVNhQ7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144277|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:48:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:48:47 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-bZO91jCXcm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144349&action=edit
Bug 32350: Use array_minus and ignore nesting

Note: Test will be extended in follow-up. This fixes the
module_bit hash to follow the FK path from user_permissions
to permissions to userflags. One step was missed in the
existing test, although it did not fail. The change here
revealed that now.

Test plan:
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:49:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:49:06 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-ytXDuCgv0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144350&action=edit
Bug 32350: Add subtest for bad columns

Test plan:
Run t/db_dependent/TestBuilder.t
And now run the whole test suite :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:50:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:50:28 +0000
Subject: [Koha-bugs] [Bug 32380] New: There should be a staff side
 equivalent to PatronSelfRegistrationEmailMustBeUnique
Message-ID: <bug-32380-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32380

            Bug ID: 32380
           Summary: There should be a staff side equivalent to
                    PatronSelfRegistrationEmailMustBeUnique
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We have the ability to enforce unique email address from self reg. We should
have a staff side equivalent.  

When using SSO it can be problematic to have the same email address on
different accounts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:50:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:50:50 +0000
Subject: [Koha-bugs] [Bug 32380] There should be a staff side equivalent to
 PatronSelfRegistrationEmailMustBeUnique
In-Reply-To: <bug-32380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32380-70-abpJuDYr59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32380

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:57:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:57:52 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-8mFU4W6BZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |23.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 16:58:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 15:58:31 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-YRHW8IeWVV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:24:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:24:35 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
 column we're not expecting
In-Reply-To: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32350-70-ii2J6jrpBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350

--- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Bad timing for BZ to be down.

I pushed this to see what happens on jenkins, then I'll move to bug 32351 so we
chase all the problems.

Thanks everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:31:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:31:03 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-V9usRUKUn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Works, makes sense, QA script happy. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:31:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:31:15 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-jeWmYNOd6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144196|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:31:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:31:39 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-86g5JY2HW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144197|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:32:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:32:55 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-NKHdIVmY7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144351&action=edit
Bug 31381: Handle null attributes in list

This patch allows null values to be returned in patron attributes
to prevent a crash when searching patrons

To test:
1 - Add a NULL attribute to a borrower, in sample data, Edna Acosta
    sudo koha-mysql kohadev
    INSERT INTO borrower_attributes (borrowernumber,code,attribute) VALUES
(5,'SHOW_BCODE',NULL);
2 - Browse to 'Home->Patrons'
    http://localhost:8081/cgi-bin/koha/members/members-home.pl
3 - Click 'Browse by last name: A'
4 - Datatables error:
    Expected string - got null
5 - Apply patch
6 - Restart all
7 - Browse by last name: A
8 - Success!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:33:15 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-aRuOtigsHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144352&action=edit
Bug 31381: Add tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:42:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:42:06 +0000
Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific
 people or groups
In-Reply-To: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32105-70-vVUfnUlDpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hafen at washk12.org

--- Comment #1 from Michael Hafen <michael.hafen at washk12.org> ---
Sounds to me like you should file an enhancement request against the plugin,
which comes from somewhere else, rather than here in Koha core.

Though I agree that it should be possible to share a list with a group; I don't
like the all or nothing either.

My idea was to be able to share it with other staff at a certain branch, which
should be a relatively easy enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:46:53 +0000
Subject: [Koha-bugs] [Bug 32381] New: Koha should be able to receive and
 record reasons for failed SMS notices
Message-ID: <bug-32381-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381

            Bug ID: 32381
           Summary: Koha should be able to receive and record reasons for
                    failed SMS notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org

When a third-party SMS-sending service fails to send a notice and returns a
reason for the failure, there is apparently no way for that reason to get
passed into Koha and recorded in message_queue.failure_code. I gather this is a
limitation based on the SMS::Send drivers.

For example, if a library is using Twilio to send their SMS notices and a
patron unsubscribes to library texts via Twilio, all future SMS notices
generated in Koha will fail to send. In the staff interface, they show
"NO_NOTES" in message_queue.failure_code. The error logs on the server show
"Attempt to send to unsubscribed recipient at /usr/share/perl5/SMS/Send.pm
line=270."

It would be quite useful if the Koha interface could show staff why the notice
didn't send.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:52:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:52:50 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-D3eb3EcvWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:52:54 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-WeAIzu4r4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144240|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:52:57 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-kvpnCZzVOu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144243|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:53:01 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-9M8vse06FR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144244|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:53:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:53:09 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-HE2QnQlcHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144249|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:53:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:53:14 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-IbNrjFfY8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144250|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:53:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:53:17 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-GGE9uKNifg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144251|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:53:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:53:21 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-25JDnNmR1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144252|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:53:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:53:53 +0000
Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
 /patrons REST API route
In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30063-70-NWjFb0KQVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:54:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:54:23 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
 in-transit items
In-Reply-To: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-CcIoxZmeZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Benjamin Daeuber from comment #8)
> (In reply to Katrin Fischer from comment #7)
> 
> > At the moment the filter only looks at information in the item record
> > already.
> 
> Is performance the reason Koha can't also check the reserves table? Is this
> something that can (or has?) been addressed with elastic search? 
> 
> We're willing to pitch in funds if a solution is possible.

Elasticsearch and Zebra both index MARC. So bibliographic records and items.

Information from reserves is not part of the data that we push to the search
engines for indexing at the moment.

So we would need to do that AND then make sure everytime a hold changes in any
way, the record gets reindexed with updated information.

I was just trying to explain why this isn't just about changing the search
query used. The data is currently not available for searching in the first
place.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:56:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:56:19 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-zl1txsZpqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144353&action=edit
Bug 32351: Holds.t - remove wrong column reference

Found by bug 32350.
The test does not need this value at all..

Test plan:
Run test.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:56:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:56:32 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-DcWOtpXLT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144354&action=edit
Bug 32351: Fix Acquisition.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:56:45 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
 in-transit items
In-Reply-To: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-TXxLi48cT6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
you could change to "Seeking cosponsors" if you wanted - also people from bug
5463 could be interested. It's mostly the same issue.

Hm, actually it depends. transfers can also be in branchtransfers... so maybe
we'd need both info from reserves and branchtransfers.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:56:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:56:50 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-eqcRAVGkab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144355&action=edit
Bug 32351: Fix Budgets.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:57:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:57:09 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-UwFfKWptef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144356&action=edit
Bug 32351: Fix Illrequests.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:57:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:57:27 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-QXSClELuE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144357&action=edit
Bug 32351: Fix Members.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:57:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:57:44 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-NaMg4dKCbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144358&action=edit
Bug 32351: Fix Reserves.t

itemtypes.notforloan already defaults to 0

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:57:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:57:54 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-iBFiHlS2ru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144359&action=edit
Bug 32351: Fix Circulation.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:58:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:58:01 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-lRd4I4xn3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144360&action=edit
Bug 32351: Fix CourseItems.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:58:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:58:10 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-9C7mVYg8UB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144361&action=edit
Bug 32351: Fix TemplateToolkit.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:58:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:58:19 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-RxEY7HXkmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144362&action=edit
Bug 32351: Fix Koha/Patrons.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:58:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:58:30 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-4xUI8Kd45G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144363&action=edit
Bug 32351: Fix t/db_dependent/api/v1/patrons.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:58:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:58:42 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-XFK4BdVyEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144364&action=edit
Bug 32351: Fix  t/db_dependent/Circulation/NoIssuesChargeGuarantees.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:58:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:58:55 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-oEtNcra2Dh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 144365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144365&action=edit
Bug 32351: Fix t/db_dependent/Koha/Charges/Sales.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:59:29 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-8YpE5ToRSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |23.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:59:32 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
 using non-mandatory extended attributes
In-Reply-To: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31381-70-etlchmdV38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:59:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:59:37 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-j6I8mY1LQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |23.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 19:59:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 18:59:40 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
 wrong column names (see 32350)
In-Reply-To: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32351-70-CRLHfeVVi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 20:28:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 19:28:52 +0000
Subject: [Koha-bugs] [Bug 24179] Preserve subfield order when linking
 authority
In-Reply-To: <bug-24179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24179-70-8MjUCgc1GV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24179

Esther Melander <estherm at sodaspringsid.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |estherm at sodaspringsid.com

--- Comment #1 from Esther Melander <estherm at sodaspringsid.com> ---
This bug still exists in 21.11

My example:

1. Edit a bib in the advanced editor.
2. Select an authority for look-up and fail to find authority
3. Click on create new authority
4. Fill in form fields with order $a, $x, $z, $x, $y
5. Save

The authority links as it should but the fields are now reordered $a, $x, $x,
$z, $y. The authority record fields should not be reordered.

Looking up the newly created authority using the authority tool outside of the
bib editor shows the original order as originally created. There is something
about linking that is causing the reordering of the fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 20:28:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 19:28:58 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
 subfields in search results
In-Reply-To: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14911-70-GqZwf9vmER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 22:01:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 21:01:54 +0000
Subject: [Koha-bugs] [Bug 32382] New: Fund input misaligned on invoice
 summary page
Message-ID: <bug-32382-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382

            Bug ID: 32382
           Summary: Fund input misaligned on invoice summary page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30952

When you 'finish receiving' you'll see information about your invoice on top.
The fund pull down there is misaligned.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 22:01:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 21:01:54 +0000
Subject: [Koha-bugs] [Bug 30952] New design for staff interface
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-eoqDc0SPaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32382


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382
[Bug 32382] Fund input misaligned on invoice summary page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 22:27:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 21:27:28 +0000
Subject: [Koha-bugs] [Bug 32383] New: Indefinite debarments should not be
 recorded with an expiration date of '9999-12-31'
Message-ID: <bug-32383-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32383

            Bug ID: 32383
           Summary: Indefinite debarments should not be recorded with an
                    expiration date of '9999-12-31'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 11846

This all might be a regression, looking at Bug 11846 from 2014.

To recreate:
- have a patron
- create a manual restriction for your patron, entering a reason but not a date
- confirm that the patron account shows your restriction with an expiration
date of "indefinite"
- in reports, SELECT * FROM borrower_debarments WHERE borrowernumber= [your
patron]
- confirm borrower_debarments.expiration is null
- in reports, SELECT * FROM borrowers WHERE borrowernumber= [your patron]
- confirm borrowers.debarred='9999-12-31'

This will cause a lot of issues in 7,977 years.

Here in the year 2022, it's generally incorrect and confusing to be using a
far-future date to denote "indefinite," and is made more confusing by the fact
that borrowers and borrower_debarments don't handle it the same way.

This also means one cannot create indefinite debarments via patron import. If
one's CSV contains a debarredcomment value without a debarred value, no
restriction is created. If one's CSV contains a debarred value of '9999-12-31,'
that is treated literally and the restriction is given an expiration date of
'9999-12-31.'


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846
[Bug 11846] Correct database update for debarments with 9999-12-31
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 22:27:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 21:27:28 +0000
Subject: [Koha-bugs] [Bug 11846] Correct database update for debarments with
 9999-12-31
In-Reply-To: <bug-11846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11846-70-nS2JQiP9RT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32383


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32383
[Bug 32383] Indefinite debarments should not be recorded with an expiration
date of '9999-12-31'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 22:33:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 21:33:03 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32375-70-WYgWAILiry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
I dont think the tests can be written to work without a db, (and still test
something) so shifting this file to t/db_dependent seems the only way forward.
We will send a patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 23:14:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 22:14:53 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-7362NzL4kq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #6)
> I'd love to see us have another go at this.. perhaps a 23.05 cycle target?

This DataTables extension might be useful for this as well:
https://datatables.net/extensions/responsive/examples/column-control/auto.html

I know I've commented elsewhere about it but can't remember where now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 23:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 22:20:15 +0000
Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements
In-Reply-To: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12580-70-CPSCrfLy7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #7)
> (In reply to Martin Renvoize from comment #6)
> > I'd love to see us have another go at this.. perhaps a 23.05 cycle target?
> 
> This DataTables extension might be useful for this as well:
> https://datatables.net/extensions/responsive/examples/column-control/auto.
> html
> 
> I know I've commented elsewhere about it but can't remember where now.

Turns out it was on the listserv and not on Bugzilla:

https://www.mail-archive.com/koha-devel at lists.koha-community.org/msg12844.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 23:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 22:51:12 +0000
Subject: [Koha-bugs] [Bug 32302] Hide "ISBN" label when no ISBN data when
 sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-8VC4IdPy9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Hi Adam,

Thanks for taking an interest in this one. I'm not sure that I 100% follow your
comment. 

The premise is there is a List with bib records that don't have the 020 MARC
field in them. If you view the list in the OPAC, click "Send list", and email
the list to yourself, the email should have blank "ISBN:" lines in the email
for the records that don't have 020 MARC fields in them. 

This is because BIBLIO_RESULT.ISBN contains an empty array reference which
counts as a "true" value in [% IF ( BIBLIO_RESULT.ISBN ) %].

That IF statement needs to check the size/length of the array reference in the
ISBN field of the BIBLIO_RESULT hash. 

I've already fixed this one locally, so it hasn't been a high priority for me,
but I'll attach a patch in a minute.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 23:53:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 22:53:20 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
 present when sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-Nnu88aJg02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Hide "ISBN" label when no   |"ISBN" label shows when no
                   |ISBN data when sending list |ISBN data present when
                   |                            |sending list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 23:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 22:56:45 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
 present when sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-3JWecD1fLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Nov 30 23:56:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 22:56:49 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
 present when sending list
In-Reply-To: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-32302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-32302-70-KGyaO52wvm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Created attachment 144366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144366&action=edit
Bug 32302: Hide "ISBN" label when no ISBN data when sending list

There is a logic mistake in the opac-sendshelf.tt template where
we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when
we should really be testing if the arrayref returned by "ISBN" is
empty or not, since that "ISBN" key always exists and contains at least
an empty arrayref.

Test plan:
1. Apply patch and restart your Koha Starman
2. Create a public list containing records with 020 MARC fields and
records without 020 MARC fields
3. View the list in the OPAC
4. Click "Send list" and email it to yourself
5. Note that only records with 020 MARC fields with show "ISBN:"
in the email output

-- 
You are receiving this mail because:
You are watching all bug changes.