[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Signed Off                  |Failed QA

--- Comment #29 from David Nind <david at davidnind.com> ---
Apologies, I signed off and then reealised that I hadn't run the tests after
applying the patches!

Tests now fail after the patches are applied. Weirdly, running the tests seemed
to uninstall the plugins. I reinstalled the plugins again, flush_memcached +
restart_all, and ran the tests again - they failed [4].

Testing notes (using koha-testing-docker):
1. Ran prove t/db_dependent/Koha/Plugins/Plugins.t - tests passed
2. Installed 2 plugins and enabled
3. Ran misc/devel/install_plugins.pl [1]
4. Applied test script patch and ran [2]
5. Applied other patches and flush_memcached + restart_all
6. Re-ran test script [3]
7. Ran prove t/db_dependent/Koha/Plugins/Plugins.t - tests failed

[1] Output from running misc/devel/install_plugins.pl:

misc/devel/install_plugins.pl
Installed Example Kitchen-Sink Plugin version 2.3.0
Installed BiblbioCommons connector plugin for Koha version 0.5.3
All plugins successfully re-initialised

[2] Output of the test script BEFORE the patches were applied:

./test-plugins-call.pl
1 call(s): Elapsed 0.686131 seconds
10 call(s): Elapsed 0.093689 seconds
100 call(s): Elapsed 0.572402 seconds
1000 call(s): Elapsed 5.629604 seconds

[3] Output of the test script AFTER the patches were applied:

./test-plugins-call.pl
1 call(s): Elapsed 0.683855 seconds
10 call(s): Elapsed 0.000213 seconds
100 call(s): Elapsed 0.001843 seconds
1000 call(s): Elapsed 0.017745 seconds

[4] Tests fail after patches are applied:

prove t/db_dependent/Koha/Plugins/Plugins.t
t/db_dependent/Koha/Plugins/Plugins.t .. 6/61 
    #   Failed test at t/db_dependent/Koha/Plugins/Plugins.t line 112.
    # found warning: Failed to load
Koha::Plugin::Com::ByWaterSolutions::KitchenSink: Could not find or check
module 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' at
/kohadevbox/koha/Koha/Plugins.pm line 116.
    # found warning: Failed to load Koha::Plugin::Com::Theke::BiblioCommons:
Could not find or check module 'Koha::Plugin::Com::Theke::BiblioCommons' at
/kohadevbox/koha/Koha/Plugins.pm line 116.
    # found warning: Plugin error (Test Plugin): Exception 'Koha::Exception'
thrown 'item_barcode_transform called with parameter: 1'
    # found warning: Plugin error (Test Plugin for item_barcode_transform):
Exception 'Koha::Exception' thrown 'item_barcode_transform called with
parameter: 2'
    # expected to find warning: Plugin error (Test Plugin): Exception
'Koha::Exception' thrown 'item_barcode_transform called with parameter: 1'
    # expected to find warning: Plugin error (Test Plugin for
item_barcode_transform): Exception 'Koha::Exception' thrown
'item_barcode_transform called with parameter: 2'
    # Looks like you failed 1 test of 6.

#   Failed test 'more call() tests'
#   at t/db_dependent/Koha/Plugins/Plugins.t line 129.
t/db_dependent/Koha/Plugins/Plugins.t .. 48/61 # Looks like you failed 1 test
of 61.
t/db_dependent/Koha/Plugins/Plugins.t .. Dubious, test returned 1 (wstat 256,
0x100)
Failed 1/61 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Plugins/Plugins.t (Wstat: 256 Tests: 61 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=1, Tests=61,  3 wallclock secs ( 0.03 usr  0.01 sys +  2.63 cusr  0.24
csys =  2.91 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.