[Koha-bugs] [Bug 24860] Add ability to place item group level holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #201 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #179)
> I am sorry Kyle, the latest follow-up fixed the error, but the new text in
> pendingreserves never displays. I have tried to figure out what's going on
> there, but got stuck on this line:
> 
> +    if ( $res_info->item_group ) {
> +       $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> $_->item_group && ( $_->item_group->id == $res_info->item_group_id )  ?
> $_->barcode : () } @$items ];
> +    }
> +
> 
> I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold
> group hold.

Yes, the problem here is that there are not items with the selected hold group
currently available. We have two choices where, either we hide that hold until
there is an item from that item group available, or we just display an "Any
item from item group $item_group" message.

"Bug 24860: (QA follow-up) Don't show holds where a matching item group item is
not available" does the former, "Bug 24860: (QA follow-up) Ask for any
available item of matching group" does the latter. Please choose which behavior
you would prefer and deprecate the other patch!

-- 
You are receiving this mail because:
You are watching all bug changes.