[Koha-bugs] [Bug 31963] Only show hold fee message on OPAC if they will actually be charged

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It took me a bit to wrap my head around this.

I believe while this advertises as a display fix, it's also a behavior change:

GetReserveFee:

-        if( $notissued ) {
+        if( $notissued == 0 ) {
+            # all items are issued


And later this is also used to determine what is charged:

AddReserve:

    # add a reserve fee if needed
    if ( C4::Context->preference('HoldFeeMode') ne 'any_time_is_collected' ) {
        my $reserve_fee = GetReserveFee( $borrowernumber, $biblionumber );
        ChargeReserveFee( $borrowernumber, $reserve_fee, $title );
    }

The system preference states: "Charge a hold fee only if all items are checked
out and the record has at least one hold already". So the change in behaviour
makes this happen. 

Only problem: I am having a hard time to phrase out the actual difference in
when a user is charged right now :(

Can you please update the bug description/title and release notes to be more
clear about this not only affecting display please?

-- 
You are receiving this mail because:
You are watching all bug changes.