[Koha-bugs] [Bug 32107] Send $self to Plugins->call and call discard_changes inside

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32107

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Julian Maurice from comment #1)
> (In reply to Marcel de Rooy from comment #0)
> > To make it even more explicit, we could add a parameter to ->call that
> > controls if we do or do not discard after the plugins loop..
> 
> I think that Koha::Plugin::call should not do anything on its @args except
> passing it to plugins. It should not even care of what's in these @args.
> IMO its the responsibility of the caller of Koha::Plugin::call to pass the
> right arguments and handle the eventual side-effects correctly.

Yes, I appreciate that principle. But the problem is that we are inserting more
and more calls to Plugins->call and that we are loosing consistency. So we are
looking for a balance here..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.