[Koha-bugs] [Bug 32087] Consistent classes for primary buttons: Course reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using KTD).

1. These changed templates accessed from: Home page > Course reserves.

2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit"
class="btn btn-primary"...
   - Listing the templates in
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/ and splitting into two
lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I haven't attached
this, but am happy to)
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser
cache)
   - Going through the list of files again: compared to original screenshot
taken, then noted whether thre is a visible change or not
   - Noting any questions - these don't affect the sign off for this bug

3. Files changed:
   - add_items-step1.tt (No visible change. Course reserves > [select or create
a course] > Add reserves > [First step - barcode or biblionumber])
   - add_items-step2.tt (No visible change. Next step when adding a course
reserve - continues from step 1 - [select check boxes, add staff or public
notes])
   - batch_add_items.tt (No visible change. Course reserves > [select or create
a course] > Batch add reserves)
   - batch_rm_items.tt (No visible change. Course reserves > Batch remove
reserves)
   - course.tt (No visible change. Course reserves > New course)

4. Files not changed:
   - course-details.tt (Course reserves > [select or create a course])
   - course-reserves.tt (Course reserves) (course reserves home page)
   - invalid-course.tt (Not sure how to trigger - has no buttons anyway)

5. File count check:
   - Number of files in folder: 8
   - Number of files listed: 8 (5 changed in this patch)

Questions/notes: none

-- 
You are receiving this mail because:
You are watching all bug changes.