[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from David Nind <david at davidnind.com> ---
Tests still failing - they pass if I change the number of tests from 67 to 64.

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/67 Odd number of elements in anonymous hash
at t/db_dependent/Circulation.t line 5705.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. 64/67 # Looks like you planned 67 tests but ran
64.
t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 3/67 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 65280 Tests: 64 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 67 tests but ran 64.
Files=1, Tests=64, 50 wallclock secs ( 0.12 usr  0.01 sys + 42.00 cusr  4.12
csys = 46.25 CPU)
Result: FAIL

Test results if I change the number of tests to 64 (from 67):

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 63/64 Odd number of elements in anonymous hash
at t/db_dependent/Circulation.t line 5705.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. ok     
All tests successful.
Files=1, Tests=64, 44 wallclock secs ( 0.11 usr  0.01 sys + 36.17 cusr  3.52
csys = 39.81 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.