[Koha-bugs] [Bug 32030] Electronic resource management (ERM)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030

--- Comment #22 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Jonathan Druart from comment #15)
> It's not how it appears, it should be displayed like this:
> https://snipboard.io/Pv5a9O.jpg

Weird, I still have it wrong on default zoom after getting latest code and
running yarn install.
I see it fine on the ERM sandbox.


> > There doesn't seem to be another filter mode when unchecked.
> 
> Another filter mode? What do you mean?

I was hypothesizing that the checkbox could be to switch from agreements having
expired before or equal to the date field. And to switch to agreements having
expired precisely at the date. The checkbox is next to the "on" so I though it
activated the "on" to modify the filter. To only show the agreements having
expired precisely on the date.
Or something else.


> > From the code it seems the date field is only used when the box is ticked.
> > Is that done to be able to keep an expiration date saved without having it
> > used? (it's not saved so it's not that)
> > Otherwise the filter could just be used when the date field is populated.
> 
> You only need to click the checkbox to search for "expired on today" (it
> will populate the date with today when the checkbox is ticked). That's
> something you couldn't have with your suggestion.

Ah ok the checkbox actually does something different! Now I though it was just
a switch meaning "take the next date field filter into account". Which seems
redundant and confusing. So my confusion came from wrongly understanding this.
Wait, when I click it doesn't populate the field. And no JS console error to
help. Same with Chromium. Same on ERM sandbox.

> I don't think the current behaviour is confusing, really. We could
> eventually hide 'on [date]' when the checkbox is not checked. We are talking
> about providing a MVP for 22.11 inclusion, not trying to catch minor UI
> design flaws ;)

Well at first my comment would have been about the expiration date filter not
working at all. I might have messed up when trying with the agreement periods
(End date vs Cancellation deadline) and though it was the license period. Since
the licenses have an expired status. But of course it wasn't the license
period.
But I finally got it working but thought either the checkbox was redundant and
was just to enable the use of the date filter. Or that there was two filter
modes or something else that I missed. Anyway, yes at that moment I lost the
focus on the MVP since indeed the expiration filter works! Let's keep that for
follow-ups.

> (In reply to Victor Grousset/tuxayo from comment #14)
> Coming from Folio:
> https://github.com/folio-org/ui-agreements/blob/master/src/constants/
> agreementRelationshipTypes.js
> I guess the idea was to have '_' for spaces and '-' for '-', but yes, it's
> inconsistent.

Ok it's to be consistent with another project. Makes sense even if they don't
:P
Thanks for the clarifications :)

-- 
You are receiving this mail because:
You are watching all bug changes.