[Koha-bugs] [Bug 32028] Add page-section to various administration pages (part 2)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32028

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> 1. Delete confirmation messages: there are two styles, assuming there will
> be bugs to fix these at some stage to make consistent:
>    - Patron restrictions - "new" style (confirmation message in a page
> section div)
>    - Patron attribute types - "old" yellow style (yellow box and asking you
> to confirm deletion)
>    - Cities and towns - "old" yellow style

I think it would be nice to have a separate bug about these. We should tackle
them at some point for sure, just a lot of things to go through right now.


> 2. Patron restrictions: Delete - 'Delete this restriction' and cancel
> buttons are in the page section div.

Bit confused about this one. Aren't they all in the table?


> 3. Plugins: has the tools sidebar menu, breadcrumb, and page title - if
> there is not a bug for that already, then I can log one.

I believe that's because you can also access some plugins from the tools page.
Could you file separately please?


> Other notes:
> 
> 1. Plugins: installed three plugins - BiblbioCommons connector plugin for
> Koha, Example Kitchen-Sink Plugin, and SMS::Send::LinkMobility::Driver.
> Assuming it will be up to the plugin author to update any pages for their
> plugin, for example, the kitchen sink plugin configure section.
> 
> 2. Circulation and fines rules: 
>    - before patch applied any before any changes made: 0 errors, 73 warnings
> (using HTML Validator for Firefox - https://www.gueury.com/mozilla/)
>    - after applying patch: 0 errors, 54 warnings
>    - not sure of the "best" tool to do this or where the threshold is for
> addressing any issues

On this page the h2 headings are outside the page-sections, but for the
advanced search and on other pages they are inside. I think this is already a
good change, but we really need to write our style guide about these kinds of
things.

-- 
You are receiving this mail because:
You are watching all bug changes.