[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #20 from David Nind <david at davidnind.com> ---
Note that tests were failing before and after the patches were applied.

I have signed off and created bug 32177.

Before
======

root at kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/63 
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5683.
    #          got: '2022-11-11T11:13:53'
    #     expected: '2022-11-25T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5689.
    #          got: '2022-11-11T11:13:53'
    #     expected: '2022-11-25T23:59:00'
    # Looks like you failed 2 tests of 5.

#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.
# Looks like you failed 1 test of 63.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/63 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 63 Failed: 1)
  Failed test:  63
  Non-zero exit status: 1
Files=1, Tests=63, 44 wallclock secs ( 0.12 usr  0.01 sys + 36.52 cusr  3.69
csys = 40.34 CPU)
Result: FAIL

After
=====

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 62/64 
    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5683.
    #          got: '2022-11-11T11:23:12'
    #     expected: '2022-11-25T00:00:00'

    #   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
    #   at t/db_dependent/Circulation.t line 5689.
    #          got: '2022-11-11T11:23:12'
    #     expected: '2022-11-25T23:59:00'
    # Looks like you failed 2 tests of 5.

#   Failed test 'GetSoonestRenewDate tests'
#   at t/db_dependent/Circulation.t line 5694.
Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line
5705.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. 64/64 # Looks like you failed 1 test of 64.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/64 subtests 

Test Summary Report
-------------------
t/db_dependent/Circulation.t (Wstat: 256 Tests: 64 Failed: 1)
  Failed test:  63
  Non-zero exit status: 1
Files=1, Tests=64, 43 wallclock secs ( 0.10 usr  0.02 sys + 36.13 cusr  3.76
csys = 40.01 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.