[Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #2 from Mark Hofstetter <koha at trust-box.at> ---
Created attachment 143789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143789&action=edit
Bug 20207: Anonymous Purchase Suggestions show on OPAC even when
OPACViewOthersSuggestions is set to Don't Show

When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make
purchase suggestions, once a suggestion has successfully been submitted,  
Anonymous Purchase Suggestions will show on OPAC even when system preference
OPACViewOthersSuggestions, is set to Don't Show.

The suggestions will show on opac-suggestions.pl. However, if you search for
the title you suggested, you will get a message saying "You are not authorized
to see pending purchase suggestions."

This patch fixes the error, ie if OPACViewOthersSuggestions is set to false not
other suggestions are shown (if you are not logged in and AnonSuggestions) OR
ONLY your own suggestions if you are logged in

To test:
1) activate AnonSuggestions
2) create an anon suggestion
3) create a suggestion with a logged in user
4) toggle OPACViewOthersSuggestions Show/Don't show
5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case
6) apply patch
7) OPACViewOthersSuggestions is now respected ie suggestions from other users
are only shown if activated
8) Please sign off

Sponsored-by: Library of the Natural History Museum Vienna

-- 
You are receiving this mail because:
You are watching all bug changes.