[Koha-bugs] [Bug 20207] Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 143800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143800&action=edit
Screenshot [22.05.x] - logged in patron purchase suggestions

Apologies for any confusion caused!

I've run through things again (detailed notes below), with these conclusions:

- This patch fixes things on master for the issue identified in this bug (I
didn't try and apply the patch to 22.05.x)

- A separate bug is required for master only for logged in patrons: if
OPACViewOthersSuggestions is set to 'Show', it only shows the logged in
patron's suggestions and not all suggestions (this is working correctly on
22.05.x, but NOT on master)

I hope I haven't confused things even more!

22.05.x
=======

Setup: need at least x1 suggestion already by an anonymous patron, and x1
suggestion by a logged in patron.

Not logged in
-------------

AnonSuggestions set to 'Allow'
AND
OPACViewOthersSuggestions set to 'Show'
AND
when not logged in

>From OPAC home > Purchase suggestions:
==> displays suggestions from anonymous and logged in patrons (as expected)

If OPACViewOthersSuggestions is set to "Don't show":
==> doesn't display any suggestions (as expected)

If OPACViewOthersSuggestions is set to "Don't show" and you add a new
suggestion when not logged in:
==> it shows other suggestions made by anonymous users (but NOT suggestions
made by logged in users)

Logged in
---------

Login as a patron and go to Your account > Purchase suggestions - purchase
suggestions show correctly:
- OPACViewOthersSuggestions set to "Don't show" - can only see your own
suggestions (as expected)
- OPACViewOthersSuggestions set to "Show" - after the search for the input
field there is a dropdown list with options to show suggestions "Suggested by
me" and "Suggested by anyone", works as expected

master
======

Setup: need at least x1 suggestion already by an anonymous patron, and x1
suggestion by a logged in patron.

Not logged in
-------------

AnonSuggestions set to 'Allow'
AND
OPACViewOthersSuggestions set to 'Show'
AND
when not logged in

>From OPAC home > Purchase suggestions:
==> displays suggestions from anonymous and logged in patrons (as expected)

If OPACViewOthersSuggestions is set to "Don't show":
==> displays suggestions from anonymous and logged in patrons (NOT expected,
also different behaviour from 22.05.x where it does not show any suggestions)

If OPACViewOthersSuggestions is set to "Don't show" and you add a new
suggestion when not logged in:
==> it shows other suggestions made by anonymous AND logged in patrons (NOT
expected, also different behaviour from 22.05.x where it only shows suggestions
from anonymous users).

Logged in user
--------------

Login as a patron and go to Your account > Purchase suggestions - purchase
suggestions DON'T show correctly:
- OPACViewOthersSuggestions set to "Don't show" - can only see your own
suggestions (as expected)
- OPACViewOthersSuggestions set to "Show" - after the search for the input
field there is a dropdown list with options to show suggestions "Suggested by
me" and "Suggested by anyone", correctly shows your own suggestions, but when
you select "Suggested by anyone" and press 'Go' it DOESN'T show suggestions
made by others (NOT expected, different behaviour from 22.05.x where it works
as expected)

-- 
You are receiving this mail because:
You are watching all bug changes.