[Koha-bugs] [Bug 32187] New: (Bug 24161 follow-up) With IndependentBranches on a non superlibrarian librarian is not able to track late orders

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32187

            Bug ID: 32187
           Summary: (Bug 24161 follow-up) With IndependentBranches on a
                    non superlibrarian librarian is not able to track late
                    orders
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P3
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart+koha at gmail.com

With IndependentBranches a non superlibrarian librarian is not able to track
late orders. 

To reproduce: have an installation of Koha with IndependentBranches on.  Be a
librarian without superlibrarian rights.  Try to generate the report about late
orders (.../cgi-bin/koha/acqui/lateorders.pl).  You should get an error 500
page.  In log you should find something like:

... DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'branchcode' in 'where clause' at
/usr/share/koha/lib/Koha/Objects.pm line 417:
/usr/share/koha/intranet/cgi-bin/acqui/lateorders.pl, referer: ...

This is due to:

            (
                C4::Context->preference('IndependentBranches')
                  && !C4::Context->IsSuperLibrarian
                ? ( 'borrower.branchcode' => C4::Context->userenv->{branch} )
                : ()
            ),

from Koha/Acquisition/Orders::filter_by_lates  (line ~128)

Changing borrower.branchcode into borrowers.branchcode (borrowerS -- missing
's' at the end) does not correct the issue.

The borrower.branchcode was to substitue the C4::Acquisition::GetLateOrders
function, but something went wrong...

The problem was found in 21.11, but it seems that it is still present in the
master (as of November 12th, 2022).

Unfortunately, I'm not able to fix it at the moment.  Jonathan, would you be
able...?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.