[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

--- Comment #68 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #66)
> What does practically mean?
> You should switch from using decode_json and encode_json TO from_json and
> to_json. Leave the strings in Perl internal format during the process.

The docs and you say the same: decode_json expects to be passed a string with
Perl's internal format representing UTF-8 characters. And that's what
encode_utf8 does, and why the patch introduces it at that exact place. 

> This needs further attention imo. (But cant fail it anymore :)

You can't fail what is correct :-P

The cool thing is that you can propose some other solution. But I'd vote
against something that adds more steps to the caller.

-- 
You are receiving this mail because:
You are watching all bug changes.