[Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 143988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143988&action=edit
Bug 32132: Return undef if budget is not found

If budget_period_id column is set as NULL, "Late orders"
page dies on error 500. Logs read:

Template process failed: undef error - DBIC result _type isn't of the _type
Aqbudget at
/home/koha/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
line 157

Prevent this happening by returning undef from method "budget".

To test:
1. Navigate to "Late orders" page.
2. Choose any order, take a note in which budget it belongs to.
3. Update chosen budget from database:
UPDATE aqbudgets SET budget_period_id WHERE budget_id = <budget_id>;
4. Reload "Late orders" page.
=> Page dies on error 500.
5. Apply this patch.
6. Reload page again.
=> Late orders should now be displayed correctly.

Also prove t/db_dependent/Koha/Acquisition/Fund.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.